1. 30 Nov, 2007 23 commits
  2. 29 Nov, 2007 17 commits
    • zecke@webkit.org's avatar
      * Fix fast/events/mousedown_in_scrollbar.html · 28b3fb53
      zecke@webkit.org authored
      * This test used to crash in PlatformScrollbarQt::mouse*Event due parent() returning 0.
      * Extend the current check that the scrollbar in the mev can be go away.
        This happens if we destroy a RenderLayer as the result of a click. In the
        case of Qt we can have this scrollbar in m_lastScrollbarUnderMouse. The RenderLayer
        is the ScrollbarClient, m_lastScrollbarUnderMouse is a RefPtr and keeps the
        last reference. When calling into this scrollbar the m_client pointer is a dangling pointer.
        We extend the check to set m_lastScrollbarUnderMouse back to zero when it was the
        scrollbar in the old mev and is gone in the new one.
      * This happens only on the Qt port because we send more/different move events.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28b3fb53
    • antti@apple.com's avatar
      WebCore: · d3c49746
      antti@apple.com authored
              Reviewed by Mitz.
      
              Fix aspect ratio calculation of video.
              
              Video should always be treated as a replaced element in size calculation.
              
              Test: media/video-aspect-ratio.html
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calcWidth):
              (WebCore::RenderBox::calcHeight):
              * rendering/RenderBox.h:
              (WebCore::RenderBox::shouldCalculateSizeAsReplaced):
              * rendering/RenderMedia.h:
              (WebCore::RenderMedia::shouldCalculateSizeAsReplaced):
      
      LayoutTests:
      
              Reviewed by Mitz.
              
              Test for video aspect ratio calculation.
      
              * media/video-aspect-ratio.html: Added.
              * platform/mac/media: Added.
              * platform/mac/media/video-aspect-ratio-expected.checksum: Added.
              * platform/mac/media/video-aspect-ratio-expected.png: Added.
              * platform/mac/media/video-aspect-ratio-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3c49746
    • weinig@apple.com's avatar
      Reviewed by Oliver. · 2a4ff543
      weinig@apple.com authored
              Additional fix for <rdar://problem/5592988> / http://bugs.webkit.org/show_bug.cgi?id=15936
              - More closely match IE's policy for frame navigation.
      
              * bindings/js/kjs_window.cpp:
              (KJS::WindowProtoFuncOpen::callAsFunction):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::shouldAllowNavigation):
              * page/FrameTree.cpp:
              (WebCore::FrameTree::top):
              * page/FrameTree.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a4ff543
    • mitz@apple.com's avatar
      Reviewed by Adam Roben and John Sullivan. · 343036d6
      mitz@apple.com authored
              - make the recent searches popup extend only along the straight part of
                the search field (unless it needs to be wider).
      
              * platform/PopupMenuClient.h:
                Added clientInsetLeft() and clientInsetRight() for clients to
                specify desired horizontal insets for the menu.
              * platform/win/PopupMenuWin.cpp:
              (WebCore::PopupMenu::calculatePositionAndSize):
              (WebCore::PopupMenu::paint):
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::clientInsetLeft): Added. Returns 0.
              (WebCore::RenderMenuList::clientInsetRight): Ditto.
              * rendering/RenderMenuList.h:
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::clientInsetLeft): Added. Returns half the
              control's height, which is the radius of the cap on the left.
              (WebCore::RenderTextControl::clientInsetRight): Added.
              * rendering/RenderTextControl.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      343036d6
    • oliver@apple.com's avatar
      Make the JS collector work with multiple threads · bb3a4a14
      oliver@apple.com authored
      Reviewed by Maciej and Darin.
      
      Under heavy contention it was possible the GC to suspend other
      threads inside the pthread spinlock, which could lead to the GC
      thread blocking on the pthread spinlock itself.
      
      We now determine and store each thread's stack base when it is
      registered, thus removing the need for any calls to pthread_get_stackaddr_np
      that needed the pthread spinlock.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb3a4a14
    • andersca@apple.com's avatar
      WebKitTools: · ed6d7b9f
      andersca@apple.com authored
              Reviewed by Sam.
      
              <rdar://problem/5230478>
              FrameLoadDelegate callbacks are not dumped in DRT.
              
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (shouldLogFrameLoadDelegates):
              (runTest):
              (main):
              * DumpRenderTree/win/FrameLoaderDelegate.cpp:
              (BSTRtoString):
              (descriptionSuitableForTestResult):
              (FrameLoadDelegate::QueryInterface):
              (FrameLoadDelegate::didStartProvisionalLoadForFrame):
              (FrameLoadDelegate::didFailProvisionalLoadWithError):
              (FrameLoadDelegate::didCommitLoadForFrame):
              (FrameLoadDelegate::didFinishLoadForFrame):
              (FrameLoadDelegate::willCloseFrame):
              (FrameLoadDelegate::didClearWindowObject):
              (FrameLoadDelegate::didFinishDocumentLoadForFrame):
              (FrameLoadDelegate::didHandleOnloadEventsForFrame):
              * DumpRenderTree/win/FrameLoaderDelegate.h:
              (FrameLoadDelegate::windowScriptObjectAvailable):
              (FrameLoadDelegate::didFirstLayoutInFrame):
      
      LayoutTests:
      
              Reviewed by Sam.
      
              <rdar://problem/5230478>
              FrameLoadDelegate callbacks are not dumped in DRT.        
      
              Remove now passing tests.
      
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed6d7b9f
    • andersca@apple.com's avatar
      Reviewed by Sam. · 0b93f147
      andersca@apple.com authored
              Add an IWebFrameLoadDelegate2 interface with a didClearWindowObject method 
              that passes in the frame whose window has been cleared. This matches a newly
              added delegate method on the Mac.
              
              * Interfaces/IWebFrameLoadDelegate.idl:
              * WebFrame.cpp:
              (WebFrame::windowObjectCleared):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b93f147
    • alice.liu@apple.com's avatar
      Reviewed by Adam. · d3d08448
      alice.liu@apple.com authored
              * platform/win/Skipped: Removed two Mac-specific tests.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3d08448
    • alice.liu@apple.com's avatar
      Move incorrect, Mac-specific results of... · dfd08b77
      alice.liu@apple.com authored
              Move incorrect, Mac-specific results of fast/dom/Window/window-resize.html into platform/mac and replace them with non-Mac results
      
              The incorrect results are tracked by <rdar://5563578>.
      
              Reviewed by Adam.
      
              * fast/dom/Window/window-resize-expected.txt: Replaced.
              * platform/mac/fast/dom/Window/window-resize-expected.txt: Copied from fast/dom/Window/window-resize-expected.txt.
              * platform/win/Skipped: Removed window-resize tests.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28219 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfd08b77
    • weinig@apple.com's avatar
      WebKitTools: · 0e1d3ae4
      weinig@apple.com authored
              Reviewed by Anders.
      
              Add database quota UIDelegates methods to DRT UIDelegate.
      
              * DumpRenderTree/mac/UIDelegate.mm:
              (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
              (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
      
      LayoutTests:
      
              Reviewed by Anders.
      
              Revert r28213 which added an error callback that was not needed and changed
              the results.
      
              * storage/transaction_callback_exception_crash.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e1d3ae4
    • alice.liu@apple.com's avatar
      Reviewed by Adam. · f269fada
      alice.liu@apple.com authored
              * platform/win/Skipped: Removed a passing test.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f269fada
    • alice.liu@apple.com's avatar
      Group failures related to dumpResourceLoadCallbacks being unimplemented · d9ba6e56
      alice.liu@apple.com authored
              Reviewed by Adam.
      
              * platform/win/Skipped: 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9ba6e56
    • alp@webkit.org's avatar
      2007-11-30 Alp Toker <alp@atoker.com> · 9c7b230c
      alp@webkit.org authored
              Reviewed by Maciej.
      
              http://bugs.webkit.org/show_bug.cgi?id=16173
              Licensing change
      
              Change license from BSD to LGPL.
      
              This is being done to encourage vendors to contribute their fixes back
              upstream.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c7b230c
    • alice.liu@apple.com's avatar
      Group failures related to using Cygwin paths · 8e7666c0
      alice.liu@apple.com authored
              Reviewed by Adam.
      
              * platform/win/Skipped: 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e7666c0
    • beidson@apple.com's avatar
      Not reviewed. · fd7db656
      beidson@apple.com authored
              Fixed a hang in the layout tests.
              My checkin earlier today broke things such that the transaction call errors out instead of succeeds.
              Therefore LayoutTestController is never notified that the test is done.
              
              This changes modifies the test such that the controller is notified of completion even if
              there's a transaction error.
      
              The net effect of this fix is to transform the hang to a single layout test failure, so people
              and the bots don't have their run-webkit-tests hang while I try to fix the real regression.
      
              * storage/transaction_callback_exception_crash.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd7db656
    • darin@apple.com's avatar
      WebCore: · 5fb14bef
      darin@apple.com authored
              Reviewed by Adele.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=16191
                REGRESSION: cannot tab to radio input after setting checked to false
      
              Test: fast/forms/input-radio-checked-tab.html
      
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::CheckedRadioButtons::addButton): Fix this code
              so that it doesn't call setChecked(false) until after the map has been updated.
              Otherwise, we can end up deallocating the map before manipulating it. As long
              as I was changing the function, I decided to make it do only a single hash
              table lookup.
      
              * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked):
              Remove the button from the radio buttons set before changing the checked
              state. This matches the idiom used elsewhere and fixes the problem where
              setting checked to false would not remove it from the set.
      
      LayoutTests:
      
              Reviewed by Adele.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=16191
                REGRESSION: cannot tab to radio input after setting checked to false
      
              * fast/forms/input-radio-checked-tab-expected.txt: Added.
              * fast/forms/input-radio-checked-tab.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fb14bef
    • alice.liu@apple.com's avatar
      Move Mac-specific results of fast/dom/wrapper-classes.html into... · ae1ab5cd
      alice.liu@apple.com authored
              Move Mac-specific results of fast/dom/wrapper-classes.html into platform/mac and replace them with non-Mac results
      
              Reviewed by Adam.
      
              * fast/dom/wrapper-classes-expected.txt: Replaced.
              * platform/mac/fast/dom/wrapper-classes-expected.txt: Copied from fast/dom/wrapper-classes-expected.txt.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae1ab5cd