1. 04 Sep, 2012 39 commits
    • tkent@chromium.org's avatar
      [Chromium] Test expectation update · 7aaa1420
      tkent@chromium.org authored
      Rebaseline vertical-writing tests.
      
      * platform/chromium-linux-x86/fast/writing-mode/border-vertical-lr-expected.txt: Added.
      * platform/chromium-linux-x86/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
      * platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Added.
      * platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Added.
      * platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Added.
      * platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Added.
      * platform/chromium-linux-x86/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt.
      * platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
      * platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
      * platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.png: Added.
      * platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.txt: Added.
      * platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.png: Added.
      * platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
      * platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.png: Added.
      * platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
      * platform/chromium-linux/fast/writing-mode/vertical-font-fallback-expected.png: Added.
      * platform/chromium-linux/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt.
      * platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt.
      * platform/chromium-mac/fast/writing-mode/japanese-lr-selection-expected.png: Added.
      * platform/chromium-mac/fast/writing-mode/japanese-rl-selection-expected.png: Added.
      * platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
      * platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
      * platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
      * platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
      * platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
      * platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
      * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
      * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
      * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
      * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt.
      * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
      * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
      * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
      * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt.
      * platform/chromium-win-xp/fast/dynamic/text-combine-expected.png:
      * platform/chromium-win-xp/fast/dynamic/text-combine-expected.txt: Added.
      * platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
      * platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.png:
      * platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt.
      * platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.png:
      * platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.txt: Added.
      * platform/chromium-win-xp/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
      * platform/chromium-win-xp/fast/writing-mode/border-vertical-lr-expected.txt: Added.
      * platform/chromium-win-xp/fast/writing-mode/broken-ideographic-font-expected.txt:
      * platform/chromium-win-xp/fast/writing-mode/fallback-orientation-expected.png:
      * platform/chromium-win-xp/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
      * platform/chromium-win-xp/fast/writing-mode/japanese-lr-text-expected.png: Removed.
      * platform/chromium-win-xp/fast/writing-mode/japanese-lr-text-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt.
      * platform/chromium-win-xp/fast/writing-mode/japanese-rl-text-expected.png: Removed.
      * platform/chromium-win-xp/fast/writing-mode/japanese-rl-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt.
      * platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
      * platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Added.
      * platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
      * platform/chromium-win-xp/fast/writing-mode/vertical-align-table-baseline-expected.png:
      * platform/chromium-win-xp/fast/writing-mode/vertical-font-fallback-expected.png: Added.
      * platform/chromium-win-xp/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/writing-mode/broken-ideographic-font-expected.txt.
      * platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
      * platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
      * platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
      * platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
      * platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
      * platform/chromium-win/fast/dynamic/text-combine-expected.png:
      * platform/chromium-win/fast/dynamic/text-combine-expected.txt:
      * platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
      * platform/chromium-win/fast/ruby/base-shorter-than-text-expected.png:
      * platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt:
      * platform/chromium-win/fast/text/international/text-spliced-font-expected.png:
      * platform/chromium-win/fast/text/international/text-spliced-font-expected.txt:
      * platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
      * platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
      * platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.png:
      * platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.txt:
      * platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.png:
      * platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt:
      * platform/chromium-win/fast/writing-mode/fallback-orientation-expected.png:
      * platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.png:
      * platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.txt:
      * platform/chromium-win/fast/writing-mode/japanese-lr-text-expected.png:
      * platform/chromium-win/fast/writing-mode/japanese-lr-text-expected.txt:
      * platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.png:
      * platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.txt:
      * platform/chromium-win/fast/writing-mode/japanese-rl-text-expected.png:
      * platform/chromium-win/fast/writing-mode/japanese-rl-text-expected.txt:
      * platform/chromium-win/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png:
      * platform/chromium-win/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Removed.
      * platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
      * platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
      * platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
      * platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
      * platform/chromium-win/fast/writing-mode/vertical-align-table-baseline-expected.png:
      * platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.png: Added.
      * platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.txt:
      * platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
      * platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7aaa1420
    • roger_fong@apple.com's avatar
    • roger_fong@apple.com's avatar
    • roger_fong@apple.com's avatar
    • roger_fong@apple.com's avatar
    • commit-queue@webkit.org's avatar
      Frame element doesn't always unload its child frame. · 4f074eea
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94717
      
      Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2012-09-04
      Reviewed by Hajime Morita.
      
      Source/WebCore:
      
      It's possible for a frame element that has been removed from the document
      to retain an active child frame. This inconsistent state may become a source
      of security vulnerabilities.
      
      The patch adds a global HashSet to store the nodes currently processed by
      ChildFrameDisconnector. Insertion into these nodes' subtrees is not allowed until
      the processing is complete.
      
      Also, the ChildFrameDisconnector call in removeChild(ren) is now immediately
      followed by the actual removal.
      
      Test: fast/frames/out-of-document-iframe-has-child-frame.html
      
      * dom/ContainerNode.cpp:
      (WebCore::willRemoveChildren): Move the ChildFrameDisconnector call out of a loop.
      (WebCore::ContainerNode::removeChild): Rearrange some event firing code.
      (WebCore::ContainerNode::removeChildren): Ditto.
      * dom/ContainerNodeAlgorithms.cpp:
      (WebCore::ChildFrameDisconnector::collectDescendant): Pass a new parameter to collectDescendant(Node*).
      * dom/ContainerNodeAlgorithms.h:
      (WebCore::ChildFrameDisconnector::ChildFrameDisconnector):
      (ChildFrameDisconnector): Maintain a list of nodes that have an active ChildFrameDisconnector.
      (WebCore::ChildFrameDisconnector::~ChildFrameDisconnector):
      (WebCore::ChildFrameDisconnector::rootNodes):
      (WebCore::ChildFrameDisconnector::collectDescendant): Add ShouldIncludeRoot parameter.
      (WebCore::ChildFrameDisconnector::nodeHasDisconnector):
      (WebCore):
      * dom/Node.cpp:
      (WebCore::checkAcceptChild): Reject a parent node if it or one of its parents has an active ChildFrameDisconnector.
      * html/HTMLFrameElementBase.cpp:
      (WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Check if an element is still in the document.
      
      LayoutTests:
      
      * fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added.
      * fast/frames/out-of-document-iframe-has-child-frame.html: Added.
      * fast/innerHTML/innerHTML-iframe-expected.txt:
      * platform/chromium/fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added.
      * platform/chromium/fast/innerHTML: Added.
      * platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f074eea
    • bashi@chromium.org's avatar
      [Chromium] Unreviewed test expectation update after r127457 · db08652d
      bashi@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db08652d
    • roger_fong@apple.com's avatar
      Unreviewed. Adding test inspector/timeline/timeline-decode-resize.html to Windows skip list. · d79fb265
      roger_fong@apple.com authored
      It fails on both Windows and Mac: https://bugs.webkit.org/show_bug.cgi?id=94374.
      
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d79fb265
    • roger_fong@apple.com's avatar
      Unreviewed. Rebaseline tests after http://trac.webkit.org/changeset/127354. · 8c8a9b09
      roger_fong@apple.com authored
      * platform/win/fast/text/international/text-spliced-font-expected.txt:
      * platform/win/fast/writing-mode/border-vertical-lr-expected.txt:
      * platform/win/fast/writing-mode/japanese-lr-selection-expected.txt:
      * platform/win/fast/writing-mode/japanese-lr-text-expected.txt:
      * platform/win/fast/writing-mode/japanese-rl-selection-expected.txt:
      * platform/win/fast/writing-mode/japanese-rl-text-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c8a9b09
    • roger_fong@apple.com's avatar
      Unreviewed gardening. editing/style/apply-style-atomic.html fails on Windows... · 7e8ccee7
      roger_fong@apple.com authored
      Unreviewed gardening. editing/style/apply-style-atomic.html fails on Windows since introduced in http://trac.webkit.org/changeset/126865.
      Test added to skip list.
      
      https://bugs.webkit.org/show_bug.cgi?id=95795
      
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e8ccee7
    • commit-queue@webkit.org's avatar
      [CSS Shaders] Implement multiply, screen, darken, lighten, difference, exclusion blend modes. · 2e26ec8b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93870
      
      Patch by Max Vujovic <mvujovic@adobe.com> on 2012-09-04
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      Add expressions for the aforementioned blend modes. The expressions are lifted directly
      from the CSS Compositing and Blending spec [1]. WebKit adds these blending expressions to
      the author's shader.
      
      [1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blendingnormal
      
      Test: css3/filters/custom/custom-filter-blend-modes.html
      
      * platform/graphics/filters/CustomFilterValidatedProgram.cpp:
      (WebCore::CustomFilterValidatedProgram::blendFunctionString):
      
      LayoutTests:
      
      Add test to check that the DOM element texture blends correctly with the css_MixColor
      variable from the author's shader for each blend mode.
      
      * css3/filters/custom/custom-filter-blend-modes-expected.html: Added.
      * css3/filters/custom/custom-filter-blend-modes.html: Added.
      * css3/filters/resources/mix-color.fs: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e26ec8b
    • jpfau@apple.com's avatar
      Make plugins respect third-party storage blocking setting · 45aa6587
      jpfau@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=94888
      
      Reviewed by Brady Eidson.
      
      Source/WebCore:
      
      Added functions for discerning if a plugin should be able to access its storage in its current origin.
      
      Tests: http/tests/security/cross-origin-plugin-allowed.html
             http/tests/security/cross-origin-plugin.html
      
      * WebCore.exp.in: Export FrameTree::top and SecurityOrigin::canAccessStorage
      * page/SecurityOrigin.h: Added canAccessPluginStorage
      (WebCore::SecurityOrigin::canAccessPluginStorage):
      
      Source/WebKit2:
      
      Plugins that are in a third-party context should be put into private browsing mode so their storage is temporary.
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::isPrivateBrowsingEnabled): Put the plugin into private browsing mode if it is in a third-party context.
      (WebKit::PluginView::privateBrowsingStateChanged): Make sure a plugin doesn't leave private browsing mode if it's in a third-party context.
      
      LayoutTests:
      
      Created tests for plugins in a third party and first party context when third-party blocking is on and off.
      
      * http/tests/security/cross-origin-plugin-allowed-expected.txt: Added.
      * http/tests/security/cross-origin-plugin-allowed.html: Added.
      * http/tests/security/cross-origin-plugin-expected.txt: Added.
      * http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed-expected.txt: Added.
      * http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html: Added.
      * http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt: Added.
      * http/tests/security/cross-origin-plugin-private-browsing-toggled.html: Added.
      * http/tests/security/cross-origin-plugin.html: Added.
      * http/tests/security/resources/cross-origin-iframe-for-plugin.html: Added.
      * http/tests/security/resources/cross-origin-iframe-for-plugin-async.html: Added.
      * platform/mac-wk2/http/tests/security/cross-origin-plugin-expected.txt: Added.
      * platform/mac-wk2/http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45aa6587
    • roger_fong@apple.com's avatar
      Unreviewed. Rebaseline Windows expected results for... · 399c7aca
      roger_fong@apple.com authored
      Unreviewed. Rebaseline Windows expected results for accessibility\canvas-description-and-role-expected.txt.
      One of the results in the test now passes.
      
      * platform/win/accessibility/canvas-description-and-role-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      399c7aca
    • wangxianzhu@chromium.org's avatar
      Unreviewed. Update test expectations for Android. · 2a4c824f
      wangxianzhu@chromium.org authored
      * platform/chromium-android/TestExpectations:
      * platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a4c824f
    • robert@webkit.org's avatar
      Regression(r127163): Heap-use-after-free in WebCore::RenderBoxModelObject::hasSelfPaintingLayer · 30264438
      robert@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95632
      
      Reviewed by Abhishek Arya.
      
      Source/WebCore:
      
      Don't add floats to the floating object set of blocks that avoid floats. There's no point in doing that
      and they will never get cleared out during relayout.
      
      Tests: fast/css/intruding-floats-crash.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::clearFloatsIfNeeded):
      
      LayoutTests:
      
      * fast/css/intruding-floats-crash-expected.txt: Added.
      * fast/css/intruding-floats-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30264438
    • msaboff@apple.com's avatar
      equal() in CSSParser.cpp should check the length of characters · 5f2e9dec
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95706
      
      Source/WebCore: 
      
      Reviewed by Abhishek Arya.
      
      Pass the length of string literals to CSSParser static functions equal() and 
      equalIgnoringCase() so that checks won't access out of bounds memory.
      
      Added test fast/css/crash-comparing-equal.html.
      
      * css/CSSParser.cpp:
      (WebCore::equal): Use template to retrieve the length of string literal.
      (WebCore::equalIgnoringCase): Ditto.
      (WebCore::CSSParser::parseDashboardRegions): Use const char[] instead of const char*
      
      LayoutTests: 
      
      Added test from duplicate defect https://bugs.webkit.org/show_bug.cgi?id=95634.
      
      Reviewed by Abhishek Arya.
      
      * fast/css/crash-comparing-equal-expected.txt: Added.
      * fast/css/crash-comparing-equal.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f2e9dec
    • roger_fong@apple.com's avatar
      Unreviewed gardening. meda/video-controls-captions.html fails on Windows after... · 0ca6bb2d
      roger_fong@apple.com authored
      Unreviewed gardening. meda/video-controls-captions.html fails on Windows after it was introduced in http://trac.webkit.org/changeset/127035.
      https://bugs.webkit.org/show_bug.cgi?id=95428
      
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ca6bb2d
    • tommyw@google.com's avatar
      MediaStream API: Add the async createOffer functionality to RTCPeerConnection · ee34ed92
      tommyw@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95734
      
      Reviewed by Adam Barth.
      
      Source/Platform:
      
      * Platform.gypi:
      * chromium/public/WebRTCPeerConnectionHandler.h:
      (WebKit):
      (WebRTCPeerConnectionHandler):
      * chromium/public/WebRTCSessionDescriptionDescriptor.h: Added.
      (WebCore):
      (WebKit):
      (WebRTCSessionDescriptionDescriptor):
      (WebKit::WebRTCSessionDescriptionDescriptor::WebRTCSessionDescriptionDescriptor):
      (WebKit::WebRTCSessionDescriptionDescriptor::~WebRTCSessionDescriptionDescriptor):
      (WebKit::WebRTCSessionDescriptionDescriptor::operator=):
      (WebKit::WebRTCSessionDescriptionDescriptor::isNull):
      * chromium/public/WebRTCSessionDescriptionRequest.h: Added.
      (WebCore):
      (WebKit):
      (WebRTCSessionDescriptionRequest):
      (ExtraData):
      (WebKit::WebRTCSessionDescriptionRequest::ExtraData::~ExtraData):
      (WebKit::WebRTCSessionDescriptionRequest::WebRTCSessionDescriptionRequest):
      (WebKit::WebRTCSessionDescriptionRequest::~WebRTCSessionDescriptionRequest):
      (WebKit::WebRTCSessionDescriptionRequest::operator=):
      (WebKit::WebRTCSessionDescriptionRequest::isNull):
      
      Source/WebCore:
      
      createOffer sends a request to the platform implementer requesting it to gather up all candidates.
      This can take some time, therefore the request is async.
      
      Test: fast/mediastream/RTCPeerConnection-createOffer.html
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCErrorCallback.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
      (WebCore):
      (RTCErrorCallback):
      (WebCore::RTCErrorCallback::~RTCErrorCallback):
      * Modules/mediastream/RTCErrorCallback.idl: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
      * Modules/mediastream/RTCPeerConnection.cpp:
      (WebCore::RTCPeerConnection::createOffer):
      (WebCore):
      * Modules/mediastream/RTCPeerConnection.h:
      (WebCore):
      (RTCPeerConnection):
      * Modules/mediastream/RTCPeerConnection.idl:
      * Modules/mediastream/RTCSessionDescriptionCallback.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
      (WebCore):
      (RTCSessionDescriptionCallback):
      (WebCore::RTCSessionDescriptionCallback::~RTCSessionDescriptionCallback):
      * Modules/mediastream/RTCSessionDescriptionCallback.idl: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
      * Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp: Added.
      (WebCore):
      (WebCore::RTCSessionDescriptionRequestImpl::create):
      (WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
      (WebCore::RTCSessionDescriptionRequestImpl::~RTCSessionDescriptionRequestImpl):
      (WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
      (WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
      (WebCore::RTCSessionDescriptionRequestImpl::stop):
      (WebCore::RTCSessionDescriptionRequestImpl::clear):
      * Modules/mediastream/RTCSessionDescriptionRequestImpl.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
      (WebCore):
      (RTCSessionDescriptionRequestImpl):
      * WebCore.gypi:
      * platform/chromium/support/WebRTCSessionDescriptionDescriptor.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h.
      (WebKit):
      (WebKit::WebRTCSessionDescriptionDescriptor::WebRTCSessionDescriptionDescriptor):
      (WebKit::WebRTCSessionDescriptionDescriptor::assign):
      (WebKit::WebRTCSessionDescriptionDescriptor::reset):
      (WebKit::WebRTCSessionDescriptionDescriptor::operator WTF::PassRefPtr<WebCore::RTCSessionDescriptionDescriptor>):
      (WebKit::WebRTCSessionDescriptionDescriptor::initialize):
      (WebKit::WebRTCSessionDescriptionDescriptor::type):
      (WebKit::WebRTCSessionDescriptionDescriptor::setType):
      (WebKit::WebRTCSessionDescriptionDescriptor::sdp):
      (WebKit::WebRTCSessionDescriptionDescriptor::setSDP):
      * platform/chromium/support/WebRTCSessionDescriptionRequest.cpp: Added.
      (WebKit):
      (WebKit::WebRTCSessionDescriptionRequest::WebRTCSessionDescriptionRequest):
      (WebKit::WebRTCSessionDescriptionRequest::assign):
      (WebKit::WebRTCSessionDescriptionRequest::reset):
      (WebKit::WebRTCSessionDescriptionRequest::requestSucceeded):
      (WebKit::WebRTCSessionDescriptionRequest::requestFailed):
      (ExtraDataContainer):
      (WebKit::ExtraDataContainer::ExtraDataContainer):
      (WebKit::ExtraDataContainer::extraData):
      (WebKit::WebRTCSessionDescriptionRequest::extraData):
      (WebKit::WebRTCSessionDescriptionRequest::setExtraData):
      * platform/mediastream/RTCPeerConnectionHandler.cpp:
      (RTCPeerConnectionHandlerDummy):
      (WebCore::RTCPeerConnectionHandlerDummy::createOffer):
      (WebCore):
      * platform/mediastream/RTCPeerConnectionHandler.h:
      (WebCore):
      (RTCPeerConnectionHandler):
      * platform/mediastream/RTCSessionDescriptionDescriptor.h:
      (WebCore::RTCSessionDescriptionDescriptor::type):
      (WebCore::RTCSessionDescriptionDescriptor::sdp):
      * platform/mediastream/RTCSessionDescriptionRequest.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
      (WebCore):
      (RTCSessionDescriptionRequest):
      (ExtraData):
      (WebCore::RTCSessionDescriptionRequest::ExtraData::~ExtraData):
      (WebCore::RTCSessionDescriptionRequest::~RTCSessionDescriptionRequest):
      (WebCore::RTCSessionDescriptionRequest::extraData):
      (WebCore::RTCSessionDescriptionRequest::setExtraData):
      (WebCore::RTCSessionDescriptionRequest::RTCSessionDescriptionRequest):
      * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
      (WebCore::RTCPeerConnectionHandlerChromium::createOffer):
      (WebCore):
      * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
      (RTCPeerConnectionHandlerChromium):
      
      Tools:
      
      * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
      (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
      (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
      (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
      (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
      (MockWebRTCPeerConnectionHandler::createOffer):
      * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
      (MockWebRTCPeerConnectionHandler):
      (MockWebRTCPeerConnectionHandler::taskList):
      (SuccessCallbackTask):
      (FailureCallbackTask):
      
      LayoutTests:
      
      * fast/mediastream/RTCPeerConnection-createOffer-expected.txt: Added.
      * fast/mediastream/RTCPeerConnection-createOffer.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee34ed92
    • mitz@apple.com's avatar
      Reverted r127468 (the fix for <http://webkit.org/b/93443>) because the test it included caused · 6cb577ef
      mitz@apple.com authored
      an assertion failure in Document::updateStyleIfNeeded().
      
      Source/WebCore: 
      
      * dom/NamedFlowCollection.cpp:
      (WebCore::NamedFlowCollection::ensureFlowWithName):
      (WebCore::NamedFlowCollection::discardNamedFlow):
      * inspector/Inspector.json:
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::didCreateNamedFlow):
      (WebCore::InspectorCSSAgent::didRemoveNamedFlow):
      (WebCore::InspectorCSSAgent::getNamedFlowCollection):
      (WebCore::InspectorCSSAgent::getFlowByName):
      (WebCore):
      * inspector/InspectorCSSAgent.h:
      (InspectorCSSAgent):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
      (WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      (WebCore::InspectorInstrumentation::didCreateNamedFlow):
      (WebCore::InspectorInstrumentation::didRemoveNamedFlow):
      * inspector/front-end/CSSStyleModel.js:
      (WebInspector.CSSStyleModel):
      (WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
      (WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
      (WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
      (WebInspector.CSSStyleModel.prototype._namedFlowCreated):
      (WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
      (WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
      (WebInspector.CSSDispatcher.prototype.namedFlowCreated):
      (WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
      (WebInspector.NamedFlow):
      (WebInspector.NamedFlow.parsePayloadArray):
      * rendering/RenderNamedFlowThread.cpp:
      (WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):
      
      LayoutTests: 
      
      * inspector/styles/protocol-css-regions-commands-expected.txt:
      * inspector/styles/protocol-css-regions-commands.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cb577ef
    • simon.fraser@apple.com's avatar
      Regression: Heap-use-after-free in WebCore::FrameView::scrollContentsFastPath · 0dd46922
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95754
      
      Reviewed by Dave Hyatt.
      
      Source/WebCore:
      
      It's possible to have a renderer with position:fixed or sticky style,
      but no layer, for example a RenderScrollBarPart. Don't register such
      renderers with the FrameView.
      
      Moved the code that registers/unregisters with the FrameView from
      styleWillChange() to styleDidChange(), since in the latter case
      we can check if we have a RenderLayer. Only register renderers with layers.
      We always unregister, which required removing an assertion in
      FrameView::removeFixedObject(), and replacing it with a null check of m_fixedObjects.
      
      Test: fast/css/remove-fixed-resizer-crash.html
      
      * page/FrameView.cpp:
      (WebCore::FrameView::removeFixedObject):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::styleWillChange):
      (WebCore::RenderBoxModelObject::styleDidChange):
      
      LayoutTests:
      
      Testcase with a position:fixed resizer and scrolling.
      
      * fast/css/remove-fixed-resizer-crash-expected.txt: Added.
      * fast/css/remove-fixed-resizer-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0dd46922
    • roger_fong@apple.com's avatar
      Unreviewed. Removing accidentally added executable properties on test files. · 364b2484
      roger_fong@apple.com authored
      * platform/win/accessibility/canvas-description-and-role-expected.txt: Removed property svn:executable.
      * platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Removed property svn:executable.
      * platform/win/fast/css/image-resolution/image-resolution-expected.txt: Removed property svn:executable.
      * platform/win/fast/css/image-set-setting-expected.txt: Removed property svn:executable.
      * platform/win/fast/css/parse-border-image-repeat-null-crash-expected.txt: Removed property svn:executable.
      * platform/win/fast/css/variables/build-supports-variables-expected.txt: Removed property svn:executable.
      * platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Removed property svn:executable.
      * platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Removed property svn:executable.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      364b2484
    • tommyw@google.com's avatar
      MediaStream API: Change the MediaStreamTrackList track added/removed signaling · 4b9a957b
      tommyw@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95721
      
      Reviewed by Adam Barth.
      
      Source/Platform:
      
      Adding the signaling to the WebKit interface.
      
      * chromium/public/WebMediaStreamCenter.h:
      (WebKit::WebMediaStreamCenter::didAddMediaStreamTrack):
      (WebKit::WebMediaStreamCenter::didRemoveMediaStreamTrack):
      
      Source/WebCore:
      
      This allows the platform implementor to throw an NOT_SUPPORTED_ERR exception if it doesn support these methods.
      
      Patch covered by expanded existing test.
      
      * Modules/mediastream/MediaStreamTrackList.cpp:
      (WebCore::MediaStreamTrackList::add):
      (WebCore::MediaStreamTrackList::remove):
      * platform/mediastream/MediaStreamCenter.h:
      (MediaStreamCenter):
      * platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:
      (WebCore::MediaStreamCenterBlackBerry::didAddMediaStreamTrack):
      (WebCore):
      (WebCore::MediaStreamCenterBlackBerry::didRemoveMediaStreamTrack):
      * platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
      (MediaStreamCenterBlackBerry):
      * platform/mediastream/chromium/MediaStreamCenterChromium.cpp:
      (WebCore::MediaStreamCenterChromium::didAddMediaStreamTrack):
      (WebCore::MediaStreamCenterChromium::didRemoveMediaStreamTrack):
      * platform/mediastream/chromium/MediaStreamCenterChromium.h:
      (MediaStreamCenterChromium):
      * platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
      (WebCore::MediaStreamCenterGStreamer::didAddMediaStreamTrack):
      (WebCore::MediaStreamCenterGStreamer::didRemoveMediaStreamTrack):
      * platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
      (MediaStreamCenterGStreamer):
      
      Tools:
      
      * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
      (MockWebMediaStreamCenter::didAddMediaStreamTrack):
      (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
      * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
      (MockWebMediaStreamCenter):
      
      LayoutTests:
      
      * fast/mediastream/MediaStreamTrackList.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b9a957b
    • commit-queue@webkit.org's avatar
      Automatic features should work in sandboxed iframes if "allow-scripts" flag is set · 5fa0b77a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93961
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-04
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Allow automatic features (video autoplay and form control
      autofocus) in a sandboxed iframe that has "allow-scripts"
      flag set. This behavior is according to the latest
      specification at:
      http://dev.w3.org/html5/spec/browsers.html#attr-iframe-sandbox-allow-same-origin
      
      This sandboxed automatic features browsing context flag is
      relaxed by the same keyword as scripts, because when
      scripts are enabled these features are trivially possible
      anyway, and it would be unfortunate to force authors to
      use script to do them when sandboxed rather than allowing
      them to use the declarative features.
      
      Tests: fast/forms/autofocus-in-sandbox-with-allow-scripts.html
             media/auto-play-in-sandbox-with-allow-scripts.html
      
      * dom/SecurityContext.cpp:
      (WebCore::SecurityContext::parseSandboxPolicy):
      
      LayoutTests:
      
      Add layout tests to check that automatic features (video
      autoplay and form control autofocus) are allowed / working
      in sandboxed iframes if the "allow-scripts" flag is set.
      This behavior is according to the latest specification at:
      http://dev.w3.org/html5/spec/browsers.html#attr-iframe-sandbox-allow-same-origin
      
      The tests to check that automatic features are blocked in
      sandboxed iframes have been removed since they relied on
      the "allow-scripts" flag to work.
      
      * fast/forms/autofocus-in-sandbox-with-allow-scripts-expected.txt: Added.
      * fast/forms/autofocus-in-sandbox-with-allow-scripts.html: Renamed from LayoutTests/fast/forms/no-autofocus-in-sandbox.html.
      * fast/forms/no-autofocus-in-sandbox-expected.txt: Removed.
      * media/auto-play-in-sandbox-with-allow-scripts-expected.txt: Added.
      * media/auto-play-in-sandbox-with-allow-scripts.html: Renamed from LayoutTests/media/no-auto-play-in-sandbox.html.
      * media/no-auto-play-in-sandbox-expected.txt: Removed.
      * media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html: Added.
      * media/resources/no-auto-play-in-sandbox-iframe.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fa0b77a
    • timothy_horton@apple.com's avatar
      ASSERTion failure when SVG element is removed from document and readded · 85558650
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95517
      <rdar://problem/12175583>
      
      Reviewed by Brady Eidson.
      
      Previously, SVG animations would cease to animate when their parent
      <svg> element was removed and re-added to the document.
      
      Instead, to match Firefox and Opera, we should continue the animation
      with the same beginTime (i.e. the animation continues as if it had never
      been removed from the document).
      
      Test: svg/animations/reinserting-svg-into-document.html
      
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::insertedInto): Don't call begin() on an already-started SMILTimeContainer().
      * svg/animation/SMILTimeContainer.cpp:
      (WebCore::SMILTimeContainer::isStarted): Added.
      * svg/animation/SMILTimeContainer.h: Add isStarted().
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::insertedInto): Always reschedule SVGSMILElements with
      their parent SMILTimeContainer when they are inserted into the document, otherwise
      they are lost (and never again update) when their subtree is removed and then
      readded to the document.
      
      Add a test that ensures that removing an SVG element from the document
      and readding it continues SMIL animations.
      
      * svg/animations/reinserting-svg-into-document.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85558650
    • scheib@chromium.org's avatar
      [Chromium] Allow asyncronous response of pointer lock requests in layout tests. · 34be567b
      scheib@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95628
      
      Reviewed by James Robinson.
      
      Tools:
      
      Future tests need the ability to respond asynchronously that
      pointer lock requests have been accepted or rejected. This patch
      adds the following:
          testRunner.setPointerLockWillRespondAsynchronously();
          testRunner.didAcquirePointerLock();
          testRunner.didNotAcquirePointerLock();
      
      Tested in existing test:
          pointerlockchange-pointerlockerror-events.html
      
      * DumpRenderTree/chromium/DRTTestRunner.cpp:
      (DRTTestRunner::DRTTestRunner):
      (DRTTestRunner::didAcquirePointerLock):
      (DRTTestRunner::didNotAcquirePointerLock):
      (DRTTestRunner::setPointerLockWillRespondAsynchronously):
      * DumpRenderTree/chromium/DRTTestRunner.h:
      (DRTTestRunner):
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::requestPointerLock):
      (WebViewHost::didAcquirePointerLock):
      (WebViewHost::didNotAcquirePointerLock):
      * DumpRenderTree/chromium/WebViewHost.h:
      (WebViewHost):
      (WebViewHost::setPointerLockWillRespondAsynchronously):
      
      LayoutTests:
      
      Add testing for testRunner.setPointerLockWillRespondAsynchronously().
      
      * pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
      * pointer-lock/pointerlockchange-pointerlockerror-events.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34be567b
    • commit-queue@webkit.org's avatar
      [CSS Regions] Destroying a render named flow thread without unregistering... · 9e41565f
      commit-queue@webkit.org authored
      [CSS Regions] Destroying a render named flow thread without unregistering left-over content nodes triggered an assertion.
      https://bugs.webkit.org/show_bug.cgi?id=95645
      
      Patch by Andrei Bucur <abucur@adobe.com> on 2012-09-04
      Reviewed by Abhishek Arya.
      
      Source/WebCore:
      
      This patch cleans up the render named flow thread before destruction by unregistering left-over content nodes.
      
      Tests: fast/regions/moved-content-node-crash.html
      
      * rendering/RenderNamedFlowThread.cpp:
      (WebCore::RenderNamedFlowThread::~RenderNamedFlowThread):
      
      LayoutTests:
      
      Simple test case that triggers an ASSERT in debug mode and causes a crash in release.
      The ASSERT appears in RenderFlowThreadController::unregisterNamedFlowContentNode
      ASSERT(it != m_mapNamedFlowContentNodes.end());
      
      It happens because when a content node is added to an iframe document and then moved back, the iframe's RenderNamedFlowThread is destroyed
      without calling unregisterNamedFlowContentNode on the node. This triggers the before mentioned assertion after a lazyAttach and a detach
      in the parent document.
      
      * fast/regions/moved-content-node-crash-expected.txt: Added.
      * fast/regions/moved-content-node-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e41565f
    • vsevik@chromium.org's avatar
      Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event · ad981b04
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93443
      
      Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-09-04
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Added "regionLayoutUpdate" event to the protocol.
      
      Removed "getFlowByName" from protocol.
      
      The front-end keeps in sync the requested Named Flow Collections.
      
      Modified existing test: inspector/styles/protocol-css-regions-commands.html
      
      * dom/NamedFlowCollection.cpp:
      (WebCore::NamedFlowCollection::ensureFlowWithName):
      (WebCore::NamedFlowCollection::discardNamedFlow):
      * inspector/Inspector.json:
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::didCreateNamedFlow):
      (WebCore::InspectorCSSAgent::willRemoveNamedFlow):
      (WebCore):
      (WebCore::InspectorCSSAgent::didUpdateRegionLayout):
      (WebCore::InspectorCSSAgent::getNamedFlowCollection):
      (WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):
      * inspector/InspectorCSSAgent.h:
      (InspectorCSSAgent):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
      (WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
      (WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      (WebCore::InspectorInstrumentation::didCreateNamedFlow):
      (WebCore::InspectorInstrumentation::willRemoveNamedFlow):
      (WebCore):
      (WebCore::InspectorInstrumentation::didUpdateRegionLayout):
      * inspector/front-end/CSSStyleModel.js:
      (WebInspector.CSSStyleModel):
      (WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
      (WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
      (WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
      (WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
      (WebInspector.CSSStyleModel.prototype._namedFlowCreated):
      (WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
      (WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
      (WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
      (WebInspector.CSSDispatcher.prototype.namedFlowCreated):
      (WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
      (WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
      (WebInspector.NamedFlow):
      (WebInspector.NamedFlowCollection):
      (WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
      (WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
      (WebInspector.NamedFlowCollection.prototype.flowByName):
      * rendering/RenderNamedFlowThread.cpp:
      (WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):
      
      LayoutTests:
      
      Validate "regionLayoutUpdate" event.
      
      * inspector/styles/protocol-css-regions-commands-expected.txt:
      * inspector/styles/protocol-css-regions-commands.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad981b04
    • commit-queue@webkit.org's avatar
      [Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex · 61d00bd3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95618
      
      Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-09-04
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Make sure we only emit the the signal for menu lists and list
      boxes rendered from actual HTML select elements.
      
      * accessibility/gtk/AXObjectCacheAtk.cpp:
      (WebCore::notifyChildrenSelectionChange): We support accessibility
      ListBoxes and MenuLists only here, assuming they represent HTML
      select elements, which might be not always true (e.g. ARIA). Thus,
      check if that condition is true, early returning in other case.
      
      LayoutTests:
      
      New layout test to ensure we don't crash with ATK notifications
      anymore when changing the selection in an ARIA listbox.
      
      * platform/gtk/accessibility/aria-listbox-crash-expected.txt: Added.
      * platform/gtk/accessibility/aria-listbox-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61d00bd3
    • commit-queue@webkit.org's avatar
      [EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash · 96d3a434
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86961
      
      Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-09-04
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore:
      
      Add ecore_x initialisation check before calling ecore_x_bell
      to avoid crashes when X server is not running.
      
      * platform/efl/SoundEfl.cpp:
      (WebCore::systemBeep):
      
      LayoutTests:
      
      Unskipped two layout tests that were crashing.
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96d3a434
    • commit-queue@webkit.org's avatar
      [EFL][WK2] CSS3 Media Queries functionality is broken · 5f30dea0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95680
      
      Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-09-04
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore:
      
      In WK2, WebProcess doesn't have access to ewk_view evas object.
      Methods that get screen rect or screen depth either return incorrect value or crash.
      This patch removes dependency to ewk_view evas object and relies on ecore_x_* functions
      to get screen rectangle or color depth of the screen.
      
      * platform/efl/EflScreenUtilities.cpp: removed unused getPixelDepth method definition
      * platform/efl/EflScreenUtilities.h: removed unsused getPixelDepth method declaration
      (WebCore):
      * platform/efl/PlatformScreenEfl.cpp:
      (WebCore):
      (WebCore::screenHorizontalDPI):
      (WebCore::screenVerticalDPI):
      (WebCore::screenDepth):
      (WebCore::screenDepthPerComponent):
      (WebCore::screenIsMonochrome):
      (WebCore::screenRect):
      
      LayoutTests:
      
      Unskipped passing CSS3 Media Query tests.
      
      * platform/efl-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f30dea0
    • vsevik@chromium.org's avatar
      Web Inspector: Skip inspector WebGL tests where WebGL is disabled · c42e66cc
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95733
      
      Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-04
      Reviewed by Vsevolod Vlasov.
      
      This is to update Skipped and TestExpectations files.
      
      * platform/efl/TestExpectations:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c42e66cc
    • commit-queue@webkit.org's avatar
      [EFL] Gardening of failing tests · c58dfc2f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95725
      
      Unreviewed gardening.
      
      Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-09-04
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c58dfc2f
    • allan.jensen@nokia.com's avatar
      Allow child-frame content in hit-tests. · 8083183d
      allan.jensen@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95204
      
      .:
      
      Reviewed by Antonio Gomes.
      
      Update exported symbols.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Reviewed by Antonio Gomes.
      
      Refactors how EventHandler::hitTestResultAtPoint handles child-frame content,
      it is now handled by the hit test itself controlled by the AllowChildFrameContent
      flag in HitTestRequest.
      
      Tests: fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html
             touchadjustment/iframe-boundary.html
      
      * WebCore.exp.in:
      * WebCore.order:
      * dom/Document.cpp:
      (WebCore::Document::nodesFromRect):
      * dom/Document.h:
      (Document):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::hitTestResultAtPoint):
      * rendering/HitTestRequest.h:
      (WebCore::HitTestRequest::allowChildFrameContent):
      (WebCore::HitTestRequest::childFrameHitTest):
      (WebCore::HitTestRequest::testChildFrameScrollBars):
      * rendering/RenderFrameBase.cpp:
      (WebCore::RenderFrameBase::nodeAtPoint):
      (WebCore):
      * rendering/RenderFrameBase.h:
      (RenderFrameBase):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::hitTest):
      * testing/Internals.cpp:
      (WebCore::Internals::nodesFromRect):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      Reviewed by Antonio Gomes.
      
      Update symbols for the Windows build-system.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      Reviewed by Antonio Gomes.
      Touch-Adjustment test by Kevin Ellis
      
      Two new tests for hit-testing child frame content. One for testing it as an option to
      nodesFromRect, and one testing its improvement on touch adjustment on iframe boundaries.
      
      * fast/dom/nodesFromRect/nodesFromRect-child-frame-content-expected.txt: Added.
      * fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html: Added.
      * fast/dom/nodesFromRect/resources/child-frame.html: Added.
      * fast/dom/nodesFromRect/resources/nodesFromRect.js:
      (check):
      (checkShadowContent):
      (checkRect):
      (nodesFromRectAsString):
      * touchadjustment/iframe-boundary-expected.txt: Added.
      * touchadjustment/iframe-boundary.html: Added.
      * touchadjustment/resources/inner-content-page.html: Added.
      * touchadjustment/resources/inner-navigation-frame.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8083183d
    • vsevik@chromium.org's avatar
      Unreviewed tests fix. · fc2c7c8e
      vsevik@chromium.org authored
      * http/tests/inspector/workspace-test.js:
      * inspector/debugger/dynamic-script-tag-expected.txt:
      * inspector/debugger/dynamic-script-tag.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc2c7c8e
    • vsevik@chromium.org's avatar
      Web Inspector: Create JavaScriptSources based on network resources. · 192582ad
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95352
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
      RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
      Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
      Removed rawSourceCode as it was not needed anymore.
      
      Tests: inspector/debugger/network-uisourcecode-provider.html
             inspector/debugger/resource-script-mapping.html
      
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * inspector/compile-front-end.py:
      * inspector/front-end/CompilerScriptMapping.js:
      * inspector/front-end/DebuggerModel.js:
      (WebInspector.DebuggerDispatcher.prototype.scriptFailedToParse):
      * inspector/front-end/JavaScriptSource.js:
      (WebInspector.JavaScriptSource):
      * inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.
      (WebInspector.NetworkUISourceCodeProvider):
      (WebInspector.NetworkUISourceCodeProvider.prototype._populate):
      (WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
      (WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
      (WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
      (WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
      (WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
      (WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
      (WebInspector.NetworkUISourceCodeProvider.prototype._reset):
      * inspector/front-end/RawSourceCode.js:
      * inspector/front-end/ResourceScriptMapping.js:
      (WebInspector.ResourceScriptMapping):
      (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
      (WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
      (WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
      (WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
      (WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
      (WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
      (WebInspector.ResourceScriptMapping.prototype._reset):
      * inspector/front-end/ScriptSnippetModel.js:
      (WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
      (WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
      (WebInspector.SnippetJavaScriptSource):
      * inspector/front-end/UISourceCode.js:
      (WebInspector.UISourceCode):
      (WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
      (WebInspector.UISourceCode.prototype.setSourceMapping):
      * inspector/front-end/WebKit.qrc:
      * inspector/front-end/Workspace.js: Drive-by: fixed duplicating uiSourceCodes in workspace.
      * inspector/front-end/inspector.html:
      * inspector/front-end/inspector.js:
      
      LayoutTests:
      
      Removed raw-source-code.html test as RawSourceCode was removed by this patch.
      Added resource-script-mapping.html to test script <-> uiSourceCode binding behavior.
      Added network-uisourcecode-provider.html to test uiSourceCode creation behavior.
      Updated dynamic-script-tag.html to better match expected behavior.
      
      * http/tests/inspector/network/network-request-revision-content.html:
      * http/tests/inspector/workspace-test.js: Added.
      (initialize_WorkspaceTest.InspectorTest.createWorkspace):
      (initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent.uiSourceCodeReplaced):
      (initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent):
      (initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent.uiSourceCodeAdded):
      (initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
      (initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):
      (initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
      (initialize_WorkspaceTest.InspectorTest.dumpUISourceCode.didRequestContent):
      (initialize_WorkspaceTest.InspectorTest.dumpUISourceCode):
      (initialize_WorkspaceTest):
      * inspector/debugger/breakpoint-manager.html:
      * inspector/debugger/dynamic-script-tag-expected.txt:
      * inspector/debugger/dynamic-script-tag.html:
      * inspector/debugger/network-uisourcecode-provider-expected.txt: Added.
      * inspector/debugger/network-uisourcecode-provider.html: Added.
      * inspector/debugger/raw-source-code-expected.txt: Removed.
      * inspector/debugger/raw-source-code.html: Removed.
      * inspector/debugger/resource-script-mapping-expected.txt: Added.
      * inspector/debugger/resource-script-mapping.html: Added.
      * inspector/debugger/scripts-panel.html:
      * inspector/debugger/source-frame-count.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      192582ad
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r127447. · 9a34e845
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/127447
      https://bugs.webkit.org/show_bug.cgi?id=95726
      
      Mistake, did not reliably pass yet. (Requested by drott on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-04
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a34e845
    • commit-queue@webkit.org's avatar
      Web Inspector: [WebGL] Save gl.getError() status before taking a WebGL state... · a51c95d7
      commit-queue@webkit.org authored
      Web Inspector: [WebGL] Save gl.getError() status before taking a WebGL state snapshot and restore it afterwards
      https://bugs.webkit.org/show_bug.cgi?id=95443
      
      Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-04
      Reviewed by Vsevolod Vlasov.
      
      Source/WebCore:
      
      Save gl.getError() status before taking the GL snapshot and restore it afterwards.
      
      * inspector/InjectedScriptWebGLModuleSource.js:
      (.):
      
      LayoutTests:
      
      Adds a test to check that we properly save the WebGL getError() status while doing the instrumentation.
      
      * inspector/profiler/webgl/webgl-profiler-get-error-expected.txt: Added.
      * inspector/profiler/webgl/webgl-profiler-get-error.html: Added.
      * inspector/profiler/webgl/webgl-profiler-test.js: Added.
      (initialize_WebGLProfilerTest.InspectorTest.enableWebGLAgent):
      (initialize_WebGLProfilerTest):
      (createWebGLContext):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a51c95d7
    • apavlov@chromium.org's avatar
      Web Inspector: More directional control characters for debugging in inspector · c95edc26
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95696
      
      Reviewed by Vsevolod Vlasov.
      
      Source/WebCore:
      
      Entities for text directionality-related characters added (LRE, RLE, LRO, RLO, PDF).
      
      * inspector/front-end/ElementsTreeOutline.js:
      
      LayoutTests:
      
      * inspector/elements/elements-panel-structure-expected.txt:
      * inspector/elements/elements-panel-structure.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c95edc26
    • dominik.rottsches@intel.com's avatar
      [EFL] Unreviewed gardening. · e58a1ca1
      dominik.rottsches@intel.com authored
      Removing http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
      from skipped crashers section, after https://bugs.webkit.org/show_bug.cgi?id=94458#c14
      
      * platform/efl/TestExpectations: Previously crashing test removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e58a1ca1
  2. 03 Sep, 2012 1 commit