1. 09 Dec, 2010 13 commits
    • commit-queue@webkit.org's avatar
      2010-12-09 Joone Hur <joone@kldp.org> · 7a9a1855
      commit-queue@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Support for viewport meta tag
              https://bugs.webkit.org/show_bug.cgi?id=45443
      
              Included viewport test cases for WebKitGtk
      
              * platform/gtk/Skipped: Unskip fast/viewport except viewport-45.html.
      2010-12-09  Joone Hur  <joone@kldp.org>
      
              Reviewed by Martin Robinson.
      
              [GTK] Support for viewport meta tag
              https://bugs.webkit.org/show_bug.cgi?id=45443
      
              This patch adds a new gobject to offer the viewport properties to user agents.
              It is WebKitViewportAttributes that contains the viewport size, initial scale with limits,
              and information about whether a user is able to scale the contents in the viewport.
      
              This feature was introduced by Safari on the iPhone. For more information on
              the viewport properties, refer to the Safari reference library at
              http://developer.apple.com/safari/library/documentation/appleapplications/reference/safarihtmlref/articles/metatags.html
      
              * GNUmakefile.am: Added webkitviewportattributes.h webkitviewportattributes.cpp.
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::dispatchViewportDataDidChange): Added this callback to know whether the viewport arguments is available.
              * WebCoreSupport/ChromeClientGtk.h:
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): Added this function to compute the viewport attributes with the given availableWidth and availableHeight.
              * WebCoreSupport/DumpRenderTreeSupportGtk.h:
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::postCommitFrameViewSetup): Invalidate the viewport attributes.
              * webkit/webkit.h:
              * webkit/webkitdefines.h:
              * webkit/webkitprivate.h: Added webkitViewportAttributesRecompute as a private function.
              * webkit/webkitviewportattributes.cpp: Added.
              (webkit_viewport_attributes_class_init):
              (webkit_viewport_attributes_init):
              (webkit_viewport_attributes_get_property):
              (webkit_viewport_attributes_set_property):
              (webkitViewportAttributesRecompute): Recompute the optimal viewport attributes and emit the viewport-attributes-changed signal.
              (webkit_viewport_attributes_recompute): a public API for calling webkitViewportAttributesRecompute.
              * webkit/webkitviewportattributes.h: Added.
              * webkit/webkitwebview.cpp:
              (webkit_web_view_get_property): Added PROP_VIEWPORT_ATTRIBUTES.
              (webkit_web_view_dispose): Deallocate the WebKitViewportAttributes instance.
              (webkit_web_view_class_init): Added the viewport-attributes-recompute-requested and viewport-attributes-changed signals.
              (webkit_web_view_init): Set the WebKitViewportAttributes instance.
              (webkit_web_view_get_viewport_attributes): Added a getter to obtain the WebKitViewportAttributes instance held by the given WebKitWebView.
              * webkit/webkitwebview.h:
              * webkit/webkitwebviewprivate.h: Added WebKitViewportAttributes as a private variable.
      2010-12-09  Joone Hur  <joone@kldp.org>
      
               Reviewed by Martin Robinson.
      
               [GTK] Support for viewport meta tag
               https://bugs.webkit.org/show_bug.cgi?id=45443
      
               Add support for testing the viewport properties for WebKitGtk.
      
               * DumpRenderTree/LayoutTestController.cpp:
               (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
               (LayoutTestController::staticFunctions):
               * DumpRenderTree/LayoutTestController.h:
               * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
               (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
               * DumpRenderTree/mac/LayoutTestControllerMac.mm:
               (LayoutTestController::dumpConfigurationForViewport): Ditto.
               * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
               (LayoutTestController::dumpConfigurationForViewport): Ditto.
               * DumpRenderTree/win/LayoutTestControllerWin.cpp:
               (LayoutTestController::dumpConfigurationForViewport): Ditto.
               * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
               (LayoutTestController::dumpConfigurationForViewport): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a9a1855
    • yurys@chromium.org's avatar
      2010-12-09 Yury Semikhatsky <yurys@chromium.org> · bb594650
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Console records for failed XHRs should contain call stack and request method
              https://bugs.webkit.org/show_bug.cgi?id=50390
      
              The expectations needed update ue to log format changes.
      
              * http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
              * http/tests/inspector/console-resource-errors-expected.txt:
              * http/tests/inspector/console-xhr-logging-expected.txt:
              * platform/chromium/http/tests/inspector/console-resource-errors-expected.txt: Added.
              * platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Copied from LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt.
      2010-12-09  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: Console records for failed XHRs should contain call stack and request method
              https://bugs.webkit.org/show_bug.cgi?id=50390
      
              When inspector front-end is open we capture call stack at the place where request is sent and
              pass the stack along with other request data. There is a new type of console messages which
              is NetworkErrorMessageType, all messages of that type will have requestId field initialized
              with the corresponding network request identifier so that later on when we need to display
              that message in the front-end we could pull request data from the Network panel using
              this identifier. If there are no data for given requestId message formatting falls back to
              the old implementation which lacks such things as call stack, request method and exact
              source location.
      
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::ConsoleMessage):
              (WebCore::ConsoleMessage::addToFrontend):
              (WebCore::ConsoleMessage::isEqual):
              * inspector/ConsoleMessage.h:
              * inspector/Inspector.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::didReceiveResponse):
              (WebCore::InspectorController::didFailLoading):
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::identifierForInitialRequest):
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype.updateMessageRepeatCount):
              (WebInspector.ConsoleMessage):
              (WebInspector.ConsoleMessage.prototype._formatMessage):
              (WebInspector.ConsoleMessage.prototype.toMessageElement):
              (WebInspector.ConsoleMessage.prototype.toString):
              (WebInspector.ConsoleMessage.prototype.isEqual):
              * inspector/front-end/ResourceManager.js:
              (WebInspector.ResourceManager.prototype.identifierForInitialRequest):
              * inspector/front-end/inspector.js:
              (WebInspector.addConsoleMessage):
              * page/Console.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb594650
    • commit-queue@webkit.org's avatar
      2010-12-09 Dai Mikurube <dmikurube@google.com> · a259a13f
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              Implement "required" attribute for select tags
              https://bugs.webkit.org/show_bug.cgi?id=50380
      
              Added tests for require attributes, valueMissing and vadility check for select elements.
      
              * fast/forms/ValidityState-valueMissing-001-expected.txt:
              * fast/forms/ValidityState-valueMissing-001.html:
              * fast/forms/ValidityState-valueMissing-002-expected.txt:
              * fast/forms/ValidityState-valueMissing-002.html:
              * fast/forms/ValidityState-valueMissing-003-expected.txt:
              * fast/forms/ValidityState-valueMissing-003.html:
              * fast/forms/checkValidity-002-expected.txt:
              * fast/forms/checkValidity-002.html:
              * fast/forms/required-attribute-001-expected.txt:
              * fast/forms/required-attribute-001.html:
              * fast/forms/required-attribute-002-expected.txt:
              * fast/forms/required-attribute-002.html:
              * fast/forms/resources/select-live-pseudo-selectors.js: Added.
              (makeInvalid):
              (appendOption):
              (backgroundOf):
              * fast/forms/script-tests/validationMessage.js:
              * fast/forms/select-live-pseudo-selectors-expected.txt: Added.
              * fast/forms/select-live-pseudo-selectors.html: Added.
              * fast/forms/validationMessage-expected.txt:
              * platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html: Added.
              * platform/mac/fast/objc/dom-html-select-live-pseudo-selectors-expected.txt: Added.
      2010-12-09  Dai Mikurube  <dmikurube@google.com>
      
              Reviewed by Kent Tamura.
      
              Implement "required" attribute for select tags
              https://bugs.webkit.org/show_bug.cgi?id=50380
      
              Test: fast/forms/select-live-pseudo-selectors.html
                    platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html
      
              * dom/SelectElement.cpp:
              (WebCore::SelectElement::updateValidity): Added. It's a pure virtual function which is prepared so that HTMLSelectElement::updateValidity() calls HTMLSelectElement::setNeedsValidityCheck().
              (WebCore::SelectElement::parseMultipleAttribute): Added calling updateValidity().
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::deselectItems): Added calling setNeedsValidityCheck() to enable validity check after changing. No tests for this change since this function is not exposed to JavaScript or any web interface.
              (WebCore::HTMLSelectElement::setSelectedIndex): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::setSelectedIndexByUser): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::valueMissing): Added valueMissing() to check if selecting an invalid or placeholder label option when a valid required attribute is specified.
              (WebCore::HTMLSelectElement::listBoxSelectItem): Added calling setNeedsValidityCheck(). No tests for this change since it is not called yet. Look at the bug 36177 and the changeset 56180.
              (WebCore::HTMLSelectElement::add): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::remove): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::restoreFormControlState): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::parseMappedAttribute): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::selectAll): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::reset): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::updateListBoxSelection): Added calling setNeedsValidityCheck(). Skipped adding tests for this change as too complicated..
              (WebCore::HTMLSelectElement::setLength): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::isRequiredFormControl): Check if required or not.
              (WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Added.
              (WebCore::HTMLSelectElement::updateValidity): Added. It calls setNeedsValidityCheck().
              * html/HTMLSelectElement.h:
              (WebCore::HTMLSelectElement::isOptionalFormControl): Check if not required.
              * html/HTMLSelectElement.idl: Added a required attribute to select elements..
              * html/ValidityState.cpp:
              (WebCore::ValidityState::valueMissing): Added valueMissing check for select elements into the global checker, ValidityState::valueMissing().
              * wml/WMLSelectElement.h:
              (WebCore::WMLSelectElement::updateValidity): Added. It does nothing.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a259a13f
    • jorlow@chromium.org's avatar
      2010-12-07 Jeremy Orlow <jorlow@chromium.org> · bc913b3c
      jorlow@chromium.org authored
              Reviewed by Steve Block.
      
              IndexedDB returns the wrong exceptions
              https://bugs.webkit.org/show_bug.cgi?id=50632
      
              * storage/indexeddb/constants-expected.txt:
              * storage/indexeddb/constants.html:
              * storage/indexeddb/objectstore-removeobjectstore-expected.txt:
              * storage/indexeddb/objectstore-removeobjectstore.html:
      2010-12-07  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Steve Block.
      
              IndexedDB returns the wrong exceptions
              https://bugs.webkit.org/show_bug.cgi?id=50632
      
              IndexedDB exceptions need to have an offset so they can
              be distinguished from DOM exceptions.  We also need to
              add strings for the various exceptions.  Lastly, make
              IDBDatabaseException use the common exception base class.
      
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::setDOMException):
              * bindings/v8/V8Proxy.cpp:
              (WebCore::V8Proxy::setDOMException):
              * dom/ExceptionCode.cpp:
              (WebCore::getExceptionCodeDescription):
              * dom/ExceptionCode.h:
              * storage/IDBDatabaseError.h:
              (WebCore::IDBDatabaseError::code):
              * storage/IDBDatabaseException.h:
              (WebCore::IDBDatabaseException::create):
              (WebCore::IDBDatabaseException::ErrorCodeToExceptionCode):
              (WebCore::IDBDatabaseException::IDBDatabaseException):
              * storage/IDBDatabaseException.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc913b3c
    • xan@webkit.org's avatar
      2010-12-09 Xan Lopez <xlopez@igalia.com> · baa76e9e
      xan@webkit.org authored
              Reviewed by Martin Robinson.
      
              Fix 'make install' woes with some versions of automake.
      
              * GNUmakefile.am: use $(top_builddir) instead of $(builddir),
              since we actually want a valid path for the file regardless of the
              place from where the script is called.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      baa76e9e
    • kov@webkit.org's avatar
      2010-12-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 3aaa4603
      kov@webkit.org authored
              Build fix for GTK+3. Use functions added for GTK+ 2.24 to get the
              GDK window size.
      
              * plugins/gtk/gtk2xtbin.c:
              (gtk_xtbin_realize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3aaa4603
    • commit-queue@webkit.org's avatar
      2010-12-09 Siddharth Mathur <siddharth.mathur@nokia.com> · 6ef982cd
      commit-queue@webkit.org authored
              Reviewed by Laszlo Gombos.
      
              Use BUILDING_WEBKIT like other ports
              https://bugs.webkit.org/show_bug.cgi?id=50713
      
              * WebCore.pro: Change BUILD_WEBKIT to BUILDING_WEBKIT
      2010-12-09  Siddharth Mathur  <siddharth.mathur@nokia.com>
      
              Reviewed by Laszlo Gombos.
      
              Use BUILDING_WEBKIT like other ports
              https://bugs.webkit.org/show_bug.cgi?id=50713
      
              * Api/qwebkitglobal.h: change BUILD_WEBKIT to BUILDING_WEBKIT
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ef982cd
    • pfeldman@chromium.org's avatar
      2010-12-09 Pavel Feldman <pfeldman@chromium.org> · c1f6b443
      pfeldman@chromium.org authored
              Not reviewed. Rebaselined Chromium expectations.
              Reverts r73518 and r73522.
      
              * platform/chromium-linux/fast/forms/placeholder-position-expected.checksum: Added.
              * platform/chromium-linux/fast/forms/placeholder-position-expected.png: Added.
              * platform/chromium-mac/fast/forms/placeholder-position-expected.checksum: Added.
              * platform/chromium-mac/fast/forms/placeholder-position-expected.png: Added.
              * platform/chromium-win/fast/forms/placeholder-position-expected.checksum: Added.
              * platform/chromium-win/fast/forms/placeholder-position-expected.png: Added.
              * platform/chromium-win/fast/forms/placeholder-position-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1f6b443
    • philn@webkit.org's avatar
      2010-12-09 Philippe Normand <pnormand@igalia.com> · c1f6dcbe
      philn@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] configure: error out if video is enabled and gstreamer pkg-config check fails
              https://bugs.webkit.org/show_bug.cgi?id=50741
      
              * configure.ac:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1f6dcbe
    • ossy@webkit.org's avatar
      Unreviewed. Add Qt specific expected results for tests introduced in r73529. · e86855e0
      ossy@webkit.org authored
      * platform/qt/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
      * platform/qt/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e86855e0
    • mrobinson@webkit.org's avatar
      2010-12-09 Martin Robinson <mrobinson@igalia.com> · 7489e34d
      mrobinson@webkit.org authored
              Update GTK+ baselines after r73561.
      
              * platform/gtk/fast/css/input-search-padding-expected.txt:
              * platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
              * platform/gtk/fast/forms/box-shadow-override-expected.txt:
              * platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
              * platform/gtk/fast/forms/input-appearance-height-expected.txt:
              * platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
              * platform/gtk/fast/forms/placeholder-set-value-expected.txt:
              * platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
              * platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
              * platform/gtk/fast/forms/search-rtl-expected.txt:
              * platform/gtk/fast/forms/search-styled-expected.txt:
              * platform/gtk/fast/forms/search-transformed-expected.txt:
              * platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
              * platform/gtk/fast/forms/search-zoomed-expected.txt:
              * platform/gtk/fast/forms/searchfield-heights-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7489e34d
    • philn@webkit.org's avatar
      2010-12-09 Philippe Normand <pnormand@igalia.com> · bc083c76
      philn@webkit.org authored
              Unreviewed, update test baselines as asked by MORITA Hajime.
      
              [GTK] r73488 broke fast/dom/HTMLProgressElement/progress-element.html
              https://bugs.webkit.org/show_bug.cgi?id=50687
      
              * platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc083c76
    • yutak@chromium.org's avatar
      2010-12-09 Yuta Kitamura <yutak@chromium.org> · 336bbe7c
      yutak@chromium.org authored
              Unreviewed.
      
              Chromium rebaselines for r73488.
      
              * platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.txt:
              * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
              * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
              * platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
              * platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
              * platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
              * platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
              * platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      336bbe7c
  2. 08 Dec, 2010 27 commits