1. 03 May, 2011 21 commits
    • adamk@chromium.org's avatar
      2011-05-02 Adam Klein <adamk@chromium.org> · 7a8e2c4d
      adamk@chromium.org authored
              Reviewed by Tony Chang.
      
              Roll chromium DEPS to r83722, add new crypto directory to DEPS
              https://bugs.webkit.org/show_bug.cgi?id=59992
      
              * .gitignore:
              Ignore new chromium/crypto directory.
      2011-05-02  Adam Klein  <adamk@chromium.org>
      
              Reviewed by Tony Chang.
      
              Roll chromium DEPS to r83722, add new crypto directory to DEPS
              https://bugs.webkit.org/show_bug.cgi?id=59992
      
              * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a8e2c4d
    • caseq@chromium.org's avatar
      2011-05-03 Andrey Kosyakov <caseq@chromium.org> · b037aa7b
      caseq@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              [Chromium] toV8(Node*) will enter infinite recursion when called with a node of type SHADOW_ROOT_NODE
              https://bugs.webkit.org/show_bug.cgi?id=60026
      
              Return a wrapper for Node in toV8(Node*) when called with a node of type
              SHADOW_ROOT_NODE instead of entering infinite recursion.
      
              * bindings/v8/custom/V8NodeCustom.cpp:
              (WebCore::toV8Slow):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b037aa7b
    • jberlin@webkit.org's avatar
      Revert r85550 and r85575. · 3d6b4681
      jberlin@webkit.org authored
      Rubber-stamped by Adam Roben.
      
      Variables cannot be exported via the .def file. Instead, they should be annotated with
      JS_EXPORTDATA.
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * runtime/Structure.cpp:
      (JSC::Structure::materializePropertyMap):
      * runtime/Structure.h:
      (JSC::Structure::typeInfo):
      (JSC::Structure::previousID):
      (JSC::Structure::propertyStorageCapacity):
      (JSC::Structure::propertyStorageSize):
      (JSC::Structure::get):
      (JSC::Structure::materializePropertyMapIfNecessary):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d6b4681
    • satish@chromium.org's avatar
      2011-05-03 Satish Sampath <satish@chromium.org> · dfb0c714
      satish@chromium.org authored
              Reviewed by Tony Gentilcore.
      
              Rebaseline speech input layout test expectations for chromium.
              https://bugs.webkit.org/show_bug.cgi?id=59742
      
              * platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
              * platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
              * platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
              * platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
              * platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
              * platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
              * platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
              * platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
              * platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
              * platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfb0c714
    • aroben@apple.com's avatar
      Allow implicit conversion from nullptr_t to PassOwnPtr · 71e211b2
      aroben@apple.com authored
      This makes it a lot easier to write code that just wants a null PassOwnPtr, especially in
      strict PassOwnPtr mode.
      
      Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
      doesn't work, but should
      
      Reviewed by Adam Barth.
      
      Source/JavaScriptCore:
      
      * wtf/PassOwnPtr.h:
      (WTF::PassOwnPtr::PassOwnPtr): Added a non-explicit constructor that takes a nullptr_t.
      
      * wtf/MessageQueue.h:
      (WTF::::waitForMessageFilteredWithTimeout):
      (WTF::::tryGetMessage):
      Use the new implicit conversion.
      
      Source/WebCore:
      
      Take advantage of implicit conversion from nullptr_t to PassOwnPtr
      
      * bindings/js/ScheduledAction.cpp:
      * css/CSSStyleSelector.cpp:
      * css/MediaList.cpp:
      * css/MediaQueryMatcher.cpp:
      * css/SVGCSSStyleSelector.cpp:
      * dom/MessagePort.cpp:
      * html/InputType.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      * inspector/InspectorStyleSheet.cpp:
      * page/ContextMenuController.cpp:
      * page/Page.cpp:
      * platform/PlatformGestureRecognizer.cpp:
      * platform/PurgeableBuffer.h:
      * platform/graphics/ImageBuffer.h:
      * platform/leveldb/LevelDBDatabase.cpp:
      * platform/mac/PurgeableBufferMac.cpp:
      * platform/text/RegularExpression.cpp:
      * rendering/RenderTheme.cpp:
      * rendering/RenderThemeMac.mm:
      * rendering/style/RenderStyle.h:
      * rendering/style/SVGRenderStyleDefs.cpp:
      * rendering/style/ShadowData.cpp:
      * rendering/style/StyleRareInheritedData.cpp:
      * rendering/style/StyleRareNonInheritedData.cpp:
      * rendering/svg/RenderSVGResourcePattern.cpp:
      
      Source/WebKit/chromium:
      
      Take advantage of implicit conversion from nullptr_t to PassOwnPtr
      
      * src/WebMediaPlayerClientImpl.cpp:
      
      Source/WebKit/mac:
      
      Take advantage of implicit conversion from nullptr_t to PassOwnPtr
      
      * History/WebHistory.mm:
      * Plugins/WebNetscapePluginEventHandler.mm:
      * WebView/WebView.mm:
      
      Source/WebKit2:
      
      Take advantage of implicit conversion from nullptr_t to PassOwnPtr
      
      * Platform/CoreIPC/Connection.cpp:
      * UIProcess/qt/WebContextMenuProxyQt.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/WebPage/DrawingArea.cpp:
      
      Tools:
      
      Take advantage of implicit nullptr_t -> PassOwnPtr conversion
      
      * DumpRenderTree/chromium/CppBoundClass.h:
      * DumpRenderTree/chromium/WebViewHost.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71e211b2
    • pfeldman@chromium.org's avatar
      2011-05-03 Pavel Feldman <pfeldman@google.com> · 5c6b7b07
      pfeldman@chromium.org authored
              Not reviewed: fix inspector status bar image glyph reference in network panel.
      
              * inspector/front-end/networkPanel.css:
              (.network-larger-resources-status-bar-item .glyph):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c6b7b07
    • yurys@chromium.org's avatar
      2011-05-03 Yury Semikhatsky <yurys@chromium.org> · 1ca15950
      yurys@chromium.org authored
              Unreviewed. Provide Chromium test expectaions for new test.
      
              * platform/chromium/inspector/console/console-log-document-proto-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ca15950
    • pfeldman@chromium.org's avatar
      2011-05-03 Pavel Feldman <pfeldman@google.com> · 974a8a81
      pfeldman@chromium.org authored
              Not reviewed: rebaseline inspector test.
      
              * inspector/storage-panel-dom-storage-expected.txt:
              * inspector/storage-panel-dom-storage.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      974a8a81
    • rgabor@webkit.org's avatar
      [Qt] Add failing tests to ARM specific Skipped list · 152c1e8c
      rgabor@webkit.org authored
      Rubber-stamped by Csaba Osztrogonác.
      
      * platform/qt-arm/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      152c1e8c
    • pfeldman@chromium.org's avatar
      2011-05-03 Pavel Feldman <pfeldman@google.com> · d8bd33ac
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: rename BrowserDebugger agent to DOMDebugger.
              https://bugs.webkit.org/show_bug.cgi?id=60019
      
              * inspector/CodeGeneratorInspector.pm:
              * inspector/Inspector.json:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::connectFrontend):
              * inspector/front-end/BreakpointsSidebarPane.js:
              (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
              (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
              (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
              (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
              (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
              * inspector/generate-inspector-idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8bd33ac
    • yurys@chromium.org's avatar
      2011-05-03 Yury Semikhatsky <yurys@chromium.org> · 5eb3347d
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: remove special logic for type of document.__proto__
              https://bugs.webkit.org/show_bug.cgi?id=60014
      
              * inspector/console/console-log-document-proto-expected.txt: Added.
              * inspector/console/console-log-document-proto.html: Added.
              * inspector/console/console-log-toString-object-expected.txt:
              * inspector/console/console-log-toString-object.html:
      2011-05-03  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: remove special logic for type of document.__proto__
              https://bugs.webkit.org/show_bug.cgi?id=60014
      
              Test: inspector/console/console-log-document-proto.html
      
              * inspector/InjectedScriptSource.js: removed unnecessary check nodeType === undefined
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5eb3347d
    • carlosgc@webkit.org's avatar
      2011-05-03 Carlos Garcia Campos <cgarcia@igalia.com> · 4643e48a
      carlosgc@webkit.org authored
              Reviewed by Eric Seidel.
      
              [GTK] Build webkit1 even when webkit2 is enabled
              https://bugs.webkit.org/show_bug.cgi?id=59695
      
              * GNUmakefile.am:
              * configure.ac:
      2011-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
      
              Reviewed by Eric Seidel.
      
              [GTK] Build webkit1 even when webkit2 is enabled
              https://bugs.webkit.org/show_bug.cgi?id=59695
      
              * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4643e48a
    • philn@webkit.org's avatar
      2011-05-03 Philippe Normand <pnormand@igalia.com> · 187c26f7
      philn@webkit.org authored
              Unreviewed, unskip now passing test.
      
              [GTK] media/video-controls-transformed.html fails
              https://bugs.webkit.org/show_bug.cgi?id=50706
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      187c26f7
    • pfeldman@chromium.org's avatar
      2011-05-03 Pavel Feldman <pfeldman@google.com> · 359731bf
      pfeldman@chromium.org authored
              Not reviewed: fixed typo in inspector style.
      
              * inspector/front-end/inspector.css:
              (.status-bar-item > .glyph):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      359731bf
    • pfeldman@chromium.org's avatar
      2011-05-03 Pavel Feldman <pfeldman@google.com> · f8285652
      pfeldman@chromium.org authored
              Not reviewed: re-applied r85589.
      
              * src/js/DevTools.js:
              (.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8285652
    • pfeldman@chromium.org's avatar
      2011-05-03 Pavel Feldman <pfeldman@chromium.org> · 1db0b467
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: revision history storage is too slow.
              https://bugs.webkit.org/show_bug.cgi?id=59939
      
              It turns out that iterating localStorage keys is very
              expensive (results in slow inspector start), refactor revision
              history in order not to rely upon that operation.
      
              * inspector/front-end/Resource.js:
              (WebInspector.Resource):
              (WebInspector.Resource._resourceRevisionRegistry):
              (WebInspector.Resource.restoreRevisions.persist):
              (WebInspector.Resource.restoreRevisions):
              (WebInspector.Resource.persistRevision):
              (WebInspector.Resource.prototype._persistRevision):
              * inspector/front-end/ResourceTreeModel.js:
              (WebInspector.ResourceTreeModel.prototype._processCachedResources):
              (WebInspector.ResourceTreeModel.prototype._frameNavigated):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1db0b467
    • mario@webkit.org's avatar
      2011-05-03 Mario Sanchez Prada <msanchez@igalia.com> · fb1d4202
      mario@webkit.org authored
              Unreviewed, needed rebaseline after revision r85499.
      
              * platform/gtk/fast/replaced/table-percent-height-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb1d4202
    • pfeldman@chromium.org's avatar
      2011-05-03 Pavel Feldman <pfeldman@google.com> · f89b3eeb
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: [remote debugging] use document.title to set window name.
              https://bugs.webkit.org/show_bug.cgi?id=60012
      
              * src/js/DevTools.js:
              (WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f89b3eeb
    • pfeldman@chromium.org's avatar
      2011-05-03 Pavel Feldman <pfeldman@chromium.org> · 69d5d7d6
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: combine toolbar icon images.
              https://bugs.webkit.org/show_bug.cgi?id=59931
      
              * WebCore.gypi:
              * inspector/front-end/Images/auditsIcon.png: Removed.
              * inspector/front-end/Images/consoleIcon.png: Removed.
              * inspector/front-end/Images/elementsIcon.png: Removed.
              * inspector/front-end/Images/networkIcon.png: Removed.
              * inspector/front-end/Images/profilesIcon.png: Removed.
              * inspector/front-end/Images/resourcesIcon.png: Removed.
              * inspector/front-end/Images/scriptsIcon.png: Removed.
              * inspector/front-end/Images/timelineIcon.png: Removed.
              * inspector/front-end/Images/toolbarIcons.png: Added.
              * inspector/front-end/Images/toolbarIconsSmall.png: Added.
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.css:
              (.toolbar-icon):
              (#toolbar-dropdown .toolbar-icon):
              (.toolbar-item:active .toolbar-icon):
              (#toolbar-dropdown .toolbar-item:active .toolbar-icon):
              (.toolbar-item.elements .toolbar-icon):
              (.toolbar-item.resources .toolbar-icon):
              (#toolbar-dropdown .toolbar-item.resources .toolbar-icon):
              (.toolbar-item.network .toolbar-icon):
              (#toolbar-dropdown .toolbar-item.network .toolbar-icon):
              (.toolbar-item.scripts .toolbar-icon):
              (#toolbar-dropdown .toolbar-item.scripts .toolbar-icon):
              (.toolbar-item.timeline .toolbar-icon):
              (#toolbar-dropdown .toolbar-item.timeline .toolbar-icon):
              (.toolbar-item.profiles .toolbar-icon):
              (#toolbar-dropdown .toolbar-item.profiles .toolbar-icon):
              (.toolbar-item.audits .toolbar-icon):
              (#toolbar-dropdown .toolbar-item.audits .toolbar-icon):
              (.toolbar-item.console .toolbar-icon):
              (#toolbar-dropdown .toolbar-item.console .toolbar-icon):
              (.status-bar-item > .glyph):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69d5d7d6
    • pfeldman@chromium.org's avatar
      2011-05-03 Pavel Feldman <pfeldman@chromium.org> · 709a76f4
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: combine status bar button glyphs.
              https://bugs.webkit.org/show_bug.cgi?id=59885
      
              * WebCore.gypi:
              * inspector/front-end/Images/breakpointsActivateButtonGlyph.png: Removed.
              * inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png: Removed.
              * inspector/front-end/Images/clearConsoleButtonGlyph.png: Removed.
              * inspector/front-end/Images/consoleButtonGlyph.png: Removed.
              * inspector/front-end/Images/dockButtonGlyph.png: Removed.
              * inspector/front-end/Images/enableOutlineButtonGlyph.png: Removed.
              * inspector/front-end/Images/enableSolidButtonGlyph.png: Removed.
              * inspector/front-end/Images/excludeButtonGlyph.png: Removed.
              * inspector/front-end/Images/focusButtonGlyph.png: Removed.
              * inspector/front-end/Images/garbageCollectButtonGlyph.png: Removed.
              * inspector/front-end/Images/gearButtonGlyph.png: Removed.
              * inspector/front-end/Images/helpButtonGlyph.png: Removed.
              * inspector/front-end/Images/largerResourcesButtonGlyph.png: Removed.
              * inspector/front-end/Images/nodeSearchButtonGlyph.png: Removed.
              * inspector/front-end/Images/pauseOnExceptionButtonGlyph.png: Removed.
              * inspector/front-end/Images/percentButtonGlyph.png: Removed.
              * inspector/front-end/Images/prettyPrintButtonGlyph.png: Removed.
              * inspector/front-end/Images/recordButtonGlyph.png: Removed.
              * inspector/front-end/Images/recordToggledButtonGlyph.png: Removed.
              * inspector/front-end/Images/reloadButtonGlyph.png: Removed.
              * inspector/front-end/Images/statusBarButtonGlyphs.png: Added.
              * inspector/front-end/Images/undockButtonGlyph.png: Removed.
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.css:
              (.status-bar-item > .glyph):
              (#dock-status-bar-item .glyph):
              (body.detached #dock-status-bar-item .glyph):
              (#console-status-bar-item .glyph):
              (.clear-status-bar-item .glyph):
              (button.enable-toggle-status-bar-item .glyph):
              (button.enable-toggle-status-bar-item.toggled-on .glyph):
              (.scripts-pause-on-exceptions-status-bar-item .glyph):
              (.scripts-toggle-pretty-print-status-bar-item .glyph):
              (.toggle-breakpoints .glyph):
              (.toggle-breakpoints.toggled-on .glyph):
              (.resources-larger-resources-status-bar-item .glyph):
              (.timeline-filter-status-bar-item .glyph):
              (.garbage-collect-status-bar-item .glyph):
              (.record-profile-status-bar-item .glyph):
              (.record-profile-status-bar-item.toggled-on .glyph):
              (.heap-snapshot-status-bar-item .glyph):
              (.node-search-status-bar-item .glyph):
              (.percent-time-status-bar-item .glyph):
              (.focus-profile-node-status-bar-item .glyph):
              (.exclude-profile-node-status-bar-item .glyph):
              (.reset-profile-status-bar-item .glyph):
              (.delete-storage-status-bar-item .glyph):
              (.refresh-storage-status-bar-item .glyph):
              * inspector/front-end/inspector.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      709a76f4
    • simon.fraser@apple.com's avatar
      2011-05-02 Simon Fraser <simon.fraser@apple.com> · 6057998b
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein.
      
              Possible crash when removing elements with reflections
              https://bugs.webkit.org/show_bug.cgi?id=60009
      
              RenderLayer's destructor deleted its z-order list Vector pointers
              before removing the reflection layer. However, the reflection cleanup
              code could call back into the RenderLayer to dirty z-order lists,
              so move reflection cleanup to before z-order vector deletion.
      
              The test crashes when run manually a few times with MallocScribble enabled,
              but I was not able to create a test that crashed reliably.
      
              Test: fast/reflections/remove-reflection-crash.html
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::~RenderLayer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6057998b
  2. 02 May, 2011 19 commits