1. 12 Dec, 2010 2 commits
    • morrita@google.com's avatar
      2010-10-28 MORITA Hajime <morrita@google.com> · 7a18feed
      morrita@google.com authored
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              * editing/spelling/script-tests/spellcheck-paste.js: Added.
              * editing/spelling/spellcheck-paste.html: Added.
              * editing/spelling/spellcheck-paste-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/mac-leopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              - Introduced SpellChecker class to encapsulate asynchronous spell
                checker state: sequence id, requesting text and target node.
                This is also the first step to decompose spell-check related
                code to a separate class.
              - Added EditorClient::isAsynchronousSpellCheckingEnabled()
                to use async spellcheck API on the platform.
                These APIs are touched by SpellChecker.
              - Used SpellChecker to check a pasted test. Text to check is
                collected from the subtree under the editingRoot.
              - Added Setting::m_asynchronousSpellCheckingEnabled to control
                async spell checking.
      
              Test: editing/spelling/spellcheck-paste.html
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * dom/DocumentMarkerController.cpp:
              (WebCore::DocumentMarkerController::showMarkers):
              (showDocumentMarkers):
              * dom/DocumentMarkerController.h:
              * dom/PositionIterator.cpp:
              (WebCore::PositionIterator::setOffsetInLeafNode):
              * dom/PositionIterator.h:
              * editing/Editor.cpp:
              (WebCore::Editor::replaceSelectionWithFragment):
              (WebCore::Editor::Editor):
              (WebCore::findFirstMarkable):
              (WebCore::Editor::selectionStartHasSpellingMarkerFor):
              * editing/Editor.h:
              (WebCore::Editor::spellChecker):
              * editing/SpellChecker.cpp: Added.
              (WebCore::SpellChecker::SpellChecker):
              (WebCore::SpellChecker::~SpellChecker):
              (WebCore::SpellChecker::initRequest):
              (WebCore::SpellChecker::clearRequest):
              (WebCore::SpellChecker::isAsynchronousEnabled):
              (WebCore::SpellChecker::canCheckAsynchronously):
              (WebCore::SpellChecker::isBusy):
              (WebCore::SpellChecker::isValid):
              (WebCore::SpellChecker::isCheckable):
              (WebCore::SpellChecker::requestCheckingFor):
              (WebCore::forwardIterator):
              (WebCore::SpellChecker::didCheck):
              * editing/SpellChecker.h: Added.
              (WebCore::SpellCheckingResult::SpellCheckingResult):
              (WebCore::SpellCheckingResult::type):
              (WebCore::SpellCheckingResult::location):
              (WebCore::SpellCheckingResult::length):
              * loader/EmptyClients.h:
              (WebCore::EmptyEditorClient::requestCheckingOfString):
              * page/EditorClient.h:
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              * page/Settings.h:
              (WebCore::Settings::setAsynchronousSpellCheckingEnabled):
              (WebCore::Settings::asynchronousSpellCheckingEnabled):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * src/EditorClientImpl.h:
              (WebKit::EditorClientImpl::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientEfl.h:
              (WebCore::EditorClientEfl::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientGtk.h:
              (WebKit::EditorClient::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientHaiku.h:
              (WebCore::EditorClientHaiku::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added asynchronous spell checking API to WebEditorClient using
              -[NSSpellChecker requestCheckingOfString].
              Note that WebEditorSpellCheckResponder is a small class to receive
              requested spell-checking result. Note that this feature is
              disabled at default.
      
              Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
              enable the feature from LayoutTestController.
      
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
              (-[WebEditorSpellCheckResponder perform]):
              (toCoreSpellingResult):
              (-[WebEditorSpellCheckResponder WTF::WebCore::]):
              (WebEditorClient::requestCheckingOfString):
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]):
              (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
              (-[WebPreferences asynchronousSpellCheckingEnabled]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientQt.h:
              (WebCore::EditorClientQt::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/WebEditorClient.h:
              (WebEditorClient::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientWinCE.h:
              (WebKit::EditorClient::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebKitSupport/EditorClientWx.h:
              (WebCore::EditorClientWx::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebProcess/WebCoreSupport/WebEditorClient.cpp:
              (WebKit::WebEditorClient::requestCheckingOfString):
              * WebProcess/WebCoreSupport/WebEditorClient.h:
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
              to control the setting.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (setAsynchronousSpellCheckingEnabledCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a18feed
    • weinig@apple.com's avatar
      Update WebKit2 skipped list. · 42b320f2
      weinig@apple.com authored
      * platform/mac-wk2/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42b320f2
  2. 08 Dec, 2010 1 commit
    • xji@chromium.org's avatar
      2010-12-08 Xiaomei Ji <xji@chromium.org> · bebfbc9b
      xji@chromium.org authored
              Reviewed by David Hyatt.
      
              Fix backward mouse wheeling not working when scroll position is below 0.
              https://bugs.webkit.org/show_bug.cgi?id=50370
      
              Tests: fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html
                     fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html
      
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::wheelEvent):
      2010-12-08  Xiaomei Ji  <xji@chromium.org>
      
              Reviewed by David Hyatt.
      
              Fix backward mouse wheeling not working when scroll position is below 0.
              https://bugs.webkit.org/show_bug.cgi?id=50370
      
              * fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
              * fast/dom/horizontal-scrollbar-in-rtl.html:
              * fast/dom/vertical-scrollbar-in-rtl-expected.txt:
              * fast/dom/vertical-scrollbar-in-rtl.html:
              * fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
              * fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html: Added.
              * fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
              * fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html: Added.
              * platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
              * platform/chromium/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
              * platform/chromium/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
              * platform/chromium/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
              * platform/gtk/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/qt-wk2/Skipped:
              * platform/qt/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
              * platform/qt/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
              * platform/win/Skipped:
              * platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
              * platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bebfbc9b
  3. 07 Dec, 2010 1 commit
    • philn@webkit.org's avatar
      2010-12-07 Philippe Normand <pnormand@igalia.com> · 6b4764ec
      philn@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              [GStreamer] ::buffered() should return multiple ranges in some cases
              https://bugs.webkit.org/show_bug.cgi?id=45101
      
              Improved the ::buffered() method thanks to the new buffering query
              support that landed in GStreamer 0.10.31. The method now
              queries the media buffered-ranges on the pipeline and queue2
              handles it if it's buffering the media to disk.
      
              The webkitwebsrc element also gained BYTES duration query
              support. This is needed in the rare cases where uridecodebin
              configures its queue before the HTTP server returns the media
              Content-Length.
      
              Test: http/tests/media/video-buffered.html
      
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::MediaPlayerPrivateGStreamer::buffered):
              * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
              (webkit_web_src_init):
              (webKitWebSrcQuery): Make webkitwebsrc handle the duration queries
              if it's aware of the media content-length.
              * platform/gtk/RenderThemeGtk.cpp:
              (WebCore::RenderThemeGtk::paintMediaSliderTrack): Fix position of
              the second and next buffered ranges.
      
      LayoutTests:
      
              Reviewed by Gustavo Noronha Silva.
      
              [GStreamer] ::buffered() should return multiple ranges in some cases
              https://bugs.webkit.org/show_bug.cgi?id=45101
      
              New test for video.buffered attribute. The test is skipped for
              ports not returning multiple timeranges for video.buffered.
      
              * http/tests/media/video-buffered-expected.txt: Added.
              * http/tests/media/video-buffered.html: Added.
              * http/tests/resources/counting-captioned.mov: Added.
              * http/tests/media/video-throttled-load.cgi: added Range
              requests/responses support.
              * platform/chromium/test_expectations.txt:
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/mac/Skipped:
              * platform/qt-mac/Skipped:
              * platform/qt-win/Skipped:
              * platform/qt-wk2/Skipped:
              * platform/qt/Skipped:
              * platform/win-wk2/Skipped:
              * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b4764ec
  4. 03 Dec, 2010 1 commit
  5. 02 Dec, 2010 2 commits
  6. 01 Dec, 2010 2 commits
    • darin@apple.com's avatar
      2010-12-01 Jia Pu <jpu@apple.com> · a5f05c0a
      darin@apple.com authored
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * src/EditorClientImpl.cpp:
              (WebKit::EditorClientImpl::getGuessesForWord):
              * src/EditorClientImpl.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::getGuessesForWord):
              * WebCoreSupport/EditorClientQt.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::EditorClient::getGuessesForWord):
              * WebCoreSupport/EditorClientGtk.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/WebEditorClient.cpp:
              (WebEditorClient::getGuessesForWord):
              * WebCoreSupport/WebEditorClient.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebKitSupport/EditorClientWx.cpp:
              (WebCore::EditorClientWx::getGuessesForWord):
              * WebKitSupport/EditorClientWx.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              This patch is for supporting multiple correction suggestion panel on Mac OS X.
              The behavior and implementation is similar to that of reversion candiate panel.
      
              * WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
      
              * WebCoreSupport/WebEditorClient.mm:  Adopted new signatures defined in base class.
                Added code to handle new multiple suggestion canidate panel type.
              (WebEditorClient::showCorrectionPanel):
              (WebEditorClient::getGuessesForWord):
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientHaiku.cpp:
              (WebCore::EditorClientHaiku::getGuessesForWord):
              * WebCoreSupport/EditorClientHaiku.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientWinCE.cpp:
              (WebKit::EditorClientWinCE::getGuessesForWord):
              * WebCoreSupport/EditorClientWinCE.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientEfl.cpp:
              (WebCore::EditorClientEfl::getGuessesForWord):
              * WebCoreSupport/EditorClientEfl.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Test: platform/mac/editing/spelling/delete-autocorrected-word-1.html
              Manual test: WebCore/manual-tests/autocorrection/dismiss-multiple-guesses.html
                           WebCore/manual-tests/autocorrection/select-from-multiple-guesses.html
      
              This patch is for supporting multiple correction suggestion panel on Mac OS X.
              The behavior and implementation is similar to that of reversion candiate panel.
      
              * WebCore.exp.in: Added and removed symbols.
      
              * editing/CorrectionPanelInfo.h: Added new correction panel type, PanelTypeSpellingSuggestions.
      
              * editing/Editor.cpp:
              (WebCore::markerTypesForAutocorrection): Convenient function for getting marker types to
                be added to autocorrected word.
              (WebCore::boundingBoxForRange): Convenient function for calculating the bounding box of a range.
              (WebCore::markerTypesForReplacement): Convenient function for getting marker types to
                be added to word that has been replaced by various correction panel.
              (WebCore::Editor::respondToChangedSelection): Added code to trigger timer for multiple
                suggestion panel.
              (WebCore::Editor::guessesForMisspelledSelection): Adopted new signature of EditorClient::getGuessesForWord().
              (WebCore::Editor::markMisspellingsAfterTypingToWord): Adopted new signature of applyCorrectionPanelInfo().
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
              (WebCore::Editor::correctionPanelTimerFired): Added code to handle new multiple suggestion panel.
              (WebCore::Editor::handleCorrectionPanelResult): Replaced handleRejectedCorrection(), since
                with new AppKit correction panel API, not only rejection, but also confirmation can be
                handled in callback.
              (WebCore::Editor::stopCorrectionPanelTimer): Moved the code that clears correction panel info
                from dismissCorrectionPanel() to this function to fix a bug that would occur when deleting
                autocorrected word.
              (WebCore::Editor::dismissCorrectionPanel): Ditto.
              (WebCore::Editor::applyCorrectionPanelInfo): Added code to handle new multiple suggestion panel.
      
              * editing/Editor.h: Replaced handleRejectedCorrection() with handleCorrectionPanelResult().
                Changed the signature of applyCorrectionPanelInfo() to hanlde new correction panel type.
      
              * editing/TextCheckingHelper.cpp:
              (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): Adopted new EditorClient::getGuessesForWord().
      
              * editing/TextCheckingHelper.h: Made paragraphRange() public.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyEditorClient::showCorrectionPanel): Adopted new signature defined in base class.
              (WebCore::EmptyEditorClient::getGuessesForWord): Ditto.
      
              * manual-tests/autocorrection/dismiss-multiple-guesses.html: Added.
      
              * manual-tests/autocorrection/select-from-multiple-guesses.html: Added.
      
              * page/EditorClient.h:  Changed showCorrectionPanel() to allow passing multiple correction
                candidates. Changed getGuessesForWord() to allow passing in contextual text for better
                correction suggestions (for those spellcheckers that utilizes such contextual information).
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt: Added.
              * platform/mac/editing/spelling/delete-autocorrected-word-1.html: Added.
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signatures defined in base class.
      
              * WebProcess/WebCoreSupport/WebEditorClient.cpp:
              (WebKit::WebEditorClient::getGuessesForWord):
              * WebProcess/WebCoreSupport/WebEditorClient.h:
              * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
              (WebKit::WebEditorClient::showCorrectionPanel):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5f05c0a
    • hayato@chromium.org's avatar
      2010-12-01 Hayato Ito <hayato@chromium.org> · 1f72959e
      hayato@chromium.org authored
              Unreviewed trivial fix.
      
              Removed fast/regex/{test1,test4}.html because they were removed from tree by r72990
      
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/qt-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f72959e
  7. 30 Nov, 2010 3 commits
  8. 29 Nov, 2010 2 commits
  9. 22 Nov, 2010 1 commit
  10. 21 Nov, 2010 1 commit
  11. 20 Nov, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-11-19 Jia Pu <jpu@apple.com> · a563e17c
      commit-queue@webkit.org authored
              Reviewed by Dan Bernstein.
      
              Regression: contraction is considered misspelling.
              https://bugs.webkit.org/show_bug.cgi?id=49423
              <rdar://problem/8654206>
      
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/mac/editing/spelling/autocorrection-contraction-expected.checksum: Added.
              * platform/mac/editing/spelling/autocorrection-contraction-expected.png: Added.
              * platform/mac/editing/spelling/autocorrection-contraction-expected.txt: Added.
              * platform/mac/editing/spelling/autocorrection-contraction.html: Added.
      2010-11-19  Jia Pu  <jpu@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Regression: contraction is considered misspelling.
              https://bugs.webkit.org/show_bug.cgi?id=49423
              <rdar://problem/8654206>
      
              Test: platform/mac/editing/spelling/autocorrection-contraction.html
                    manual-tests/autocorrection/autocorrection-contraction.html
      
              * editing/Editor.cpp:
              (WebCore::isAmbiguousBoundaryCharacter): Moved function to the top of the file so that it can
                be used by all other functions in the file.
              (WebCore::Editor::markMisspellingsAfterTypingToWord): Renamed markMisspellingsAfterTypingToPosition()
                to improve readability, and to pass in additional argument. Before we apply pending
                autocorrection, we check to see if currently typed character makes current word a partial
                contraction, for instance "wouldn'". If that's the case, we would not apply the pending
                correction.
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Make sure currently typed word
                is not a partial contraction, such as "wouldn'", before mark it as misspelled. Also update
                the location of ambiguous boundary if other replacements have changed the length of the
                paragraph.
              * editing/Editor.h:
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::markMisspellingsAfterTyping): Adopt renamed function.
              * manual-tests/autocorrection/autocorrection-contraction.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a563e17c
  12. 18 Nov, 2010 1 commit
    • jianli@chromium.org's avatar
      Move fileapi test files under http/tests/local to a new subdirectory under it · 7a064a56
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=49709
      
      Reviewed by David Levin.
      
      * http/tests/local/fileapi/resources/setup-file-input-element-for-drag.js: Renamed from LayoutTests/http/tests/local/resources/setup-file-input-element-for-drag.js.
      * http/tests/local/fileapi/script-tests/TEMPLATE.html: Added.
      * http/tests/local/fileapi/script-tests/send-dragged-file.js: Renamed from LayoutTests/http/tests/local/resources/send-dragged-file.js.
      * http/tests/local/fileapi/script-tests/send-sliced-dragged-file.js: Renamed from LayoutTests/http/tests/local/resources/send-sliced-dragged-file.js.
      * http/tests/local/fileapi/send-dragged-file-expected.txt: Renamed from LayoutTests/http/tests/local/send-dragged-file-expected.txt.
      * http/tests/local/fileapi/send-dragged-file.html: Renamed from LayoutTests/http/tests/local/send-dragged-file.html.
      * http/tests/local/fileapi/send-sliced-dragged-file-expected.txt: Renamed from LayoutTests/http/tests/local/send-sliced-dragged-file-expected.txt.
      * http/tests/local/fileapi/send-sliced-dragged-file.html: Renamed from LayoutTests/http/tests/local/send-sliced-dragged-file.html.
      * platform/gtk/Skipped:
      * platform/mac-tiger/Skipped:
      * platform/mac-wk2/Skipped:
      * platform/qt-wk2/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a064a56
  13. 17 Nov, 2010 1 commit
  14. 16 Nov, 2010 1 commit
  15. 08 Nov, 2010 3 commits
  16. 05 Nov, 2010 2 commits
    • cmarrin@apple.com's avatar
      2010-11-05 Chris Marrin <cmarrin@apple.com> · 97af3e1c
      cmarrin@apple.com authored
              Reviewed by Simon Fraser.
      
              suspendAnimations/resumeAnimations not present in WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=49109
      
              Got 4 tests out of the Skipped list that now pass
      
              * platform/mac-wk2/Skipped:
      2010-11-05  Chris Marrin  <cmarrin@apple.com>
      
              Reviewed by Simon Fraser.
      
              suspendAnimations/resumeAnimations not present in WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=49109
      
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::suspendAnimations):
              (WTR::LayoutTestController::resumeAnimations):
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      2010-11-05  Chris Marrin  <cmarrin@apple.com>
      
              Reviewed by Simon Fraser.
      
              suspendAnimations/resumeAnimations not present in WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=49109
      
              * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
              (WKBundleFrameSuspendAnimations):
              (WKBundleFrameResumeAnimations):
              * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
              * WebProcess/WebPage/WebFrame.cpp:
              (WebKit::WebFrame::suspendAnimations):
              (WebKit::WebFrame::resumeAnimations):
              * WebProcess/WebPage/WebFrame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97af3e1c
    • andersca@apple.com's avatar
      Implement NP_RemoveProperty and NP_Enumerate · 46e6d372
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49046
      
      Reviewed by Oliver Hunt.
      
      WebKit2:
      
      * Shared/Plugins/NPObjectMessageReceiver.cpp:
      (WebKit::NPObjectMessageReceiver::removeProperty):
      Call the removeProperty NPClass function.
      
      (WebKit::NPObjectMessageReceiver::enumerate):
      Call the enumerate NPClass function.
      
      * Shared/Plugins/NPObjectMessageReceiver.messages.in:
      Add RemoveProperty and Enumerate messages.
      
      * Shared/Plugins/NPObjectProxy.cpp:
      (WebKit::NPObjectProxy::removeProperty):
      Send the RemoveProperty message.
      
      (WebKit::NPObjectProxy::enumerate):
      Send the Enumerate message.
      
      (WebKit::NPObjectProxy::NP_RemoveProperty):
      Call removeProperty.
      
      (WebKit::NPObjectProxy::NP_Enumerate):
      Call enumerate.
      
      LayoutTests:
      
      Remove now passing tests.
      
      * platform/mac-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46e6d372
  17. 03 Nov, 2010 1 commit
    • andersca@apple.com's avatar
      Implement NP_SetProperty · f8ce5158
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48956
      
      Reviewed by Adam Roben.
      
      WebKit2:
      
      * Shared/Plugins/NPObjectMessageReceiver.cpp:
      (WebKit::NPObjectMessageReceiver::setProperty):
      Call the NPClass setProperty function.
      
      * Shared/Plugins/NPObjectMessageReceiver.messages.in:
      Add SetProperty message.
      
      * Shared/Plugins/NPObjectProxy.cpp:
      (WebKit::NPObjectProxy::setProperty):
      Send a SetProperty message.
      
      (WebKit::NPObjectProxy::NP_SetProperty):
      Call NPObjectProxy::setProperty.
      
      LayoutTests:
      
      Remove now passing test.
      
      * platform/mac-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8ce5158
  18. 02 Nov, 2010 3 commits
  19. 01 Nov, 2010 1 commit
  20. 28 Oct, 2010 2 commits
    • commit-queue@webkit.org's avatar
      2010-10-28 Jia Pu <jpu@apple.com> · 08abac67
      commit-queue@webkit.org authored
              Reviewed by Dan Bernstein.
      
              Editing a word with misspell or autocorrection underline should remove the underline when the editing changes the word.
              https://bugs.webkit.org/show_bug.cgi?id=48078
              <rdar://problem/8579155>
      
              * platform/mac-leopard/Skipped: New tests don't apply to this platform.
              * platform/mac-snowleopard/Skipped: Ditto.
              * platform/mac-tiger/Skipped: Ditto.
              * platform/mac-wk2/Skipped: Ditto.
              * platform/mac/editing/spelling/autocorrection-delete-expected.checksum: Updated expected test result.
              * platform/mac/editing/spelling/autocorrection-delete-expected.png: Ditto.
              * platform/mac/editing/spelling/editing-multiple-words-with-markers-expected.txt: Added.
              * platform/mac/editing/spelling/editing-multiple-words-with-markers.html: Added.
              * platform/mac/editing/spelling/editing-word-with-marker-1-expected.txt: Added.
              * platform/mac/editing/spelling/editing-word-with-marker-1.html: Added.
              * platform/mac/editing/spelling/editing-word-with-marker-2-expected.txt: Added.
              * platform/mac/editing/spelling/editing-word-with-marker-2.html: Added.
      2010-10-28  Jia Pu  <jpu@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Editing a word with misspell or autocorrection underline should remove the underline when the editing changes the word.
              https://bugs.webkit.org/show_bug.cgi?id=48078
              <rdar://problem/8579155>
      
              Tests: platform/mac/editing/spelling/editing-multiple-words-with-markers.html
                     platform/mac/editing/spelling/editing-word-with-marker-1.html
                     platform/mac/editing/spelling/editing-word-with-marker-2.html
      
              This patch is part of on-going improvement of autocorrection feature on Mac OS X. When an editing
              occurs, if it affects words (by deleting/inserting characters, spliting word, merging words) that
              have Spelling and/or CorrectionIndicator markers, we want to remove the markers. If subsequntial
              spelling checking finds spelling error in newlly formed words, it will add the markers back in.
      
              * dom/DocumentMarker.h: Changed MarkerType to bit masks to make search multiple types easier.
      
              * dom/DocumentMarkerController.cpp: Refactored two removeMarkers() methods to support remove
                markers with specific type from a node.
              (WebCore::DocumentMarkerController::removeMarkers): Changed signature to remove marker with specific type.
              (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): Refactoring.
              (WebCore::DocumentMarkerController::hasMarkers): Convenience method to search markers in range.
      
              * dom/DocumentMarkerController.h: Added new methods and matched new signature of removeMarkers().
      
              * editing/Editor.cpp:
              (WebCore::Editor::respondToChangedContents): Remove existing markers if the change formed new word.
              (WebCore::Editor::cut): Remove markers on words that will be modified by this editing.
              (WebCore::Editor::paste): Ditto.
              (WebCore::Editor::pasteAsPlainText): Ditto.
              (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited): Main logic for removing
                markers on words affected by editing.
      
              * editing/Editor.h: Added removeSpellAndCorrectionMarkersFromWordsToBeEdited().  Added
                REMOVE_MARKERS_UPON_EDITING and SUPPORT_AUTOCORRECTION_PANEL macro to improve readability.
      
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::insertText): Remove markers on words that will be modified by this editing.
              (WebCore::TypingCommand::deleteKeyPressed): Ditto.
              (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08abac67
    • aroben@apple.com's avatar
      Recategorize the failure of plugins/mouse-events.html for WebKit2 · 5ee06660
      aroben@apple.com authored
      This should have been done in r70685.
      
      * platform/mac-wk2/Skipped: Moved plugins/mouse-events.html into the
      "Need eventSender" category...
      * platform/win-wk2/Skipped: ...from here.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ee06660
  21. 27 Oct, 2010 1 commit
    • darin@apple.com's avatar
      2010-10-26 Darin Adler <darin@apple.com> · 3c320e40
      darin@apple.com authored
              Reviewed by Sam Weinig.
      
              WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42322
              rdar://problem/8193631
      
              WebKitTestRunner needs to support layoutTestController.clearBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42333
              rdar://problem/8193643
      
              * History/WebBackForwardList.mm:
              (core): Return BackForwardListImpl.
              (kit): Take BackForwardListImpl.
              (-[WebBackForwardList initWithBackForwardList:]): Use BackForwardListImpl.
              (-[WebBackForwardList dealloc]): Ditto.
              (-[WebBackForwardList finalize]): Ditto.
              (-[WebBackForwardList description]): Ditto.
              (-[WebBackForwardList setPageCacheSize:]): Ditto.
              (-[WebBackForwardList pageCacheSize]): Ditto.
              * History/WebBackForwardListInternal.h: Ditto.
              * WebView/WebFrameView.mm:
              (-[WebFrameView keyDown:]): Ditto.
              * WebView/WebView.mm:
              (-[WebView initWithCoder:]): Ditto.
              (-[WebView encodeWithCoder:]): Ditto.
              (-[WebView backForwardList]): Ditto.
              (-[WebView setMaintainsBackForwardList:]): Ditto.
      2010-10-26  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42322
              rdar://problem/8193631
      
              WebKitTestRunner needs to support layoutTestController.clearBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42333
              rdar://problem/8193643
      
              * WebCore.exp.in: Updated exports.
      
              * history/BackForwardList.h: Added comments about future refactoring.
              Moved functions that are not called inside WebCore into a separate
              section, to be removed later. Added an isActive function to replace the
              use of enabled() and entries().
      
              * history/BackForwardListImpl.h: Removed isBackForwardListImpl.
              Marked virtual function overrides virtual explicitly, except for the
              ones that will be non-virtual once we make the changes above.
              Added the isActive function.
      
              * history/PageCache.cpp:
              (WebCore::logCanCachePageDecision): Use isActive.
              (WebCore::PageCache::canCache): Ditto.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::checkDidPerformFirstNavigation): Check
              using currentItem, backItem, and forwardItem instead of
              using entries.
      
              * page/Settings.cpp:
              (WebCore::Settings::setUsesPageCache): Loop through the back/forward
              list entries using backListCount and forwardListCount instead of
              using entries.
      2010-10-26  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42322
              rdar://problem/8193631
      
              WebKitTestRunner needs to support layoutTestController.clearBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42333
              rdar://problem/8193643
      
              * platform/mac-wk2/Skipped: Resorted some test lists. Removed the section
              listing all the tests that were blocked by dumpBackForwardList.
      2010-10-26  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42322
              rdar://problem/8193631
      
              WebKitTestRunner needs to support layoutTestController.clearBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42333
              rdar://problem/8193643
      
              * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
              Renamed the product to WebKitTestRunnerInjectedBundle to avoid
              name conflicts in the build directory.
      
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              Added dumpBackForwardList and clearBackForwardList.
      
              * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
              (WTR::InjectedBundle::InjectedBundle): Removed initialization of m_mainPage.
              (WTR::InjectedBundle::didCreatePage): Removed unneeded underscore.
              (WTR::InjectedBundle::willDestroyPage): Ditto.
              (WTR::InjectedBundle::didReceiveMessage): Ditto.
              (WTR::InjectedBundle::initialize): Ditto.
              (WTR::InjectedBundle::didCreatePage): Changed code to use m_pages
              instead of m_mainPage and m_otherPages.
              (WTR::InjectedBundle::willDestroyPage): Ditto.
              (WTR::InjectedBundle::page): Ditto.
              (WTR::InjectedBundle::beginTesting): Ditto.
              (WTR::InjectedBundle::done): Ditto.
              (WTR::InjectedBundle::closeOtherPages): Ditto.
              (WTR::InjectedBundle::dumpBackForwardListsForAllPages): Added.
      
              * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Changed
              page function to longer be inline, and pageCount function
              to use m_pages. Added dumpBackForwardListsForAllPages, and
              removed some underscores. Replaced m_mainPage and m_otherPageas
              with m_pages.
      
              * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
              (WTR::adoptWK): Added.
              (WTR::hasPrefix): Added.
              (WTR::InjectedBundlePage::reset): Added code to set up
              m_previousTestBackForwardListItem.
              (WTR::InjectedBundlePage::dump): Added code to call
              dumpBackForwardListsForAllPages.
              (WTR::compareByTargetName): Added.
              (WTR::dumpBackForwardListItem): Added.
              (WTR::InjectedBundlePage::dumpBackForwardList): Added.
      
              * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added
              dumpBackForwardList and m_previousTestBackForwardListItem.
      
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::LayoutTestController): Initialize
              m_shouldDumpBackForwardListsForAllWindows to false.
              (WTR::LayoutTestController::clearBackForwardList): Added.
      
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
              Added dumpBackForwardList, clearBackForwardList,
              shouldDumpBackForwardListsForAllWindows, and
              m_shouldDumpBackForwardListsForAllWindows.
      
              * WebKitTestRunner/TestController.cpp:
              (WTR::TestController::initialize): Set up
              didReceiveSynchronousMessageFromInjectedBundle.
              (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
              Added.
              * WebKitTestRunner/TestController.h: Ditto.
      
              * WebKitTestRunner/TestInvocation.cpp:
              (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
              Added.
              * WebKitTestRunner/TestInvocation.h: Ditto.
      
              * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
              Renamed bundle to WebKitTestRunnerInjectedBundle (see above).
              * WebKitTestRunner/mac/TestControllerMac.mm:
              (WTR::TestController::initializeInjectedBundlePath): Ditto.
      2010-10-26  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42322
              rdar://problem/8193631
      
              WebKitTestRunner needs to support layoutTestController.clearBackForwardList
              https://bugs.webkit.org/show_bug.cgi?id=42333
              rdar://problem/8193643
      
              * Shared/API/c/WKBase.h: Added WKBundleBackForwardListRef and
              WKBundleBackForwardListItemRef.
      
              * Shared/API/c/WKURL.cpp:
              (WKURLCopyString): Added.
              * Shared/API/c/WKURL.h: Added WKURLCopyString.
      
              * Shared/API/c/cf/WKURLCF.h: Fixed incorrect argument name.
      
              * Shared/APIObject.h: Added TypeBundleBackForwardList and
              TypeBundleBackForwardListItem.
      
              * Shared/ImmutableArray.h: Marked destructor virtual explicitly.
              * Shared/ImmutableDictionary.h: Ditto.
              * UIProcess/WebBackForwardListItem.h: Ditto.
              * UIProcess/WebContext.h: Ditto.
              * UIProcess/WebFrameProxy.h: Ditto.
              * UIProcess/WebNavigationData.h: Ditto.
              * UIProcess/WebPageNamespace.h: Ditto.
              * UIProcess/WebPreferences.h: Ditto.
              * WebProcess/InjectedBundle/InjectedBundleScriptWorld.h: Ditto.
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Ditto.
              * WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h: Ditto.
      
              * UIProcess/WebBackForwardList.cpp: Removed unneeded backListWithLimit
              and forwardListWithLimit functions.
              (WebKit::WebBackForwardList::clear): Added.
              * UIProcess/WebBackForwardList.h: Marked destructor virtual explicitly.
              Added clear, removed backListWithLimit and forwardListWithLimit functions.
      
              * UIProcess/WebPageProxy.cpp: Removed unneeded backForwardBackItem,
              backForwardCurrentItem, and backForwardForwardItem functions.
              (WebKit::WebPageProxy::backForwardClear): Added.
              * UIProcess/WebPageProxy.h: Ditto.
              * UIProcess/WebPageProxy.messages.in: Ditto.
      
              * WebKit2.pro: Added new files.
              * WebKit2.xcodeproj/project.pbxproj: Ditto.
              * win/WebKit2.vcproj: Ditto.
      
              * WebProcess/InjectedBundle/API/c/WKBundleAPICast.h: Added
              WKBundleBackForwardListRef and WKBundleBackForwardListItemRef.
      
              * WebProcess/InjectedBundle/API/c/WKBundleBackForwardList.cpp:
              Started with a copy of from WebKit2/UIProcess/API/C/WKBackForwardList.cpp.
              * WebProcess/InjectedBundle/API/c/WKBundleBackForwardList.h:
              Started with a copy of WebKit2/UIProcess/API/C/WKBackForwardList.h.
      
              * WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:
              Started with a copy of WebKit2/UIProcess/API/C/WKBackForwardListItem.cpp.
              * WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h:
              Started with a copy of WebKit2/UIProcess/API/C/WKBackForwardListItem.h.
      
              * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
              (WKBundlePageGetBackForwardList): Added.
              * WebProcess/InjectedBundle/API/c/WKBundlePage.h: Ditto.
      
      
              * WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp:
              Started with a copy of WebKit2/UIProcess/WebBackForwardList.cpp.
              * WebProcess/InjectedBundle/InjectedBundleBackForwardList.h:
              Started with a copy of WebKit2/UIProcess/WebBackForwardList.h.
      
              * WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:
              Started with a copy of WebKit2/UIProcess/WebBackForwardListItem.cpp.
              * WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
              Started with a copy of WebKit2/UIProcess/WebBackForwardListItem.h.
      
              * WebProcess/WebPage/WebBackForwardListProxy.cpp: Removed
              many unneeded functions.
              (WebKit::WebBackForwardListProxy::WebBackForwardListProxy):
              Removed unneeded initialization of m_closed.
              (WebKit::WebBackForwardListProxy::addItem): Added a check for
              the case of a capacity of 0.
              (WebKit::WebBackForwardListProxy::goToItem): Added a check for
              when the proxy outlives its page.
              (WebKit::WebBackForwardListProxy::itemAtIndex): Ditto.
              (WebKit::WebBackForwardListProxy::backListCount): Ditto.
              (WebKit::WebBackForwardListProxy::forwardListCount): Ditto.
              (WebKit::WebBackForwardListProxy::close): Removed unneeded code
              setting m_closed.
              (WebKit::WebBackForwardListProxy::isActive): Added.
              (WebKit::WebBackForwardListProxy::clear): Added.
      
              * WebProcess/WebPage/WebBackForwardListProxy.h: Added clear,
              isActive, and detach functions. Removed many other unneeded
              function and data members.
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::~WebPage): Added call to detach on the
              back/forward list.
              (WebKit::WebPage::backForwardList): Added.
              * WebProcess/WebPage/WebPage.h: Added backForwardList function
              and m_backForwardList data member.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c320e40
  22. 26 Oct, 2010 2 commits
    • simon.fraser@apple.com's avatar
      2010-10-26 Simon Fraser <simon.fraser@apple.com> · c738b67f
      simon.fraser@apple.com authored
              Reviewed by Sam Weinig.
      
              Support layoutTestController.layerTreeAsText in WebKitTestRunner
              https://bugs.webkit.org/show_bug.cgi?id=42145
      
              Implement layerTreeAsText() in WebKitTestRunner.
      
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::layerTreeAsText):
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      
      2010-10-26  Simon Fraser  <simon.fraser@apple.com>
      
              Reviewed by Sam Weinig.
      
              Support layoutTestController.layerTreeAsText in WebKitTestRunner
              https://bugs.webkit.org/show_bug.cgi?id=42145
      
              Expose layerTreeAsText() as private API so that
              WebKitTestRunner can use it.
      
              * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
              (WKBundleFrameCopyLayerTreeAsText):
              * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
              * WebProcess/WebPage/WebFrame.cpp:
              (WebKit::WebFrame::numberOfActiveAnimations):
              (WebKit::WebFrame::layerTreeAsText):
              (WebKit::WebFrame::pendingUnloadCount):
              * WebProcess/WebPage/WebFrame.h:
      
      2010-10-26  Simon Fraser  <simon.fraser@apple.com>
      
              Reviewed by Sam Weinig.
      
              Support layoutTestController.layerTreeAsText in WebKitTestRunner
              https://bugs.webkit.org/show_bug.cgi?id=42145
      
              Unskip tests that relied on layerTreeAsText(), but skip
              two compositing tests that continue to be flakey.
      
              * platform/mac-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c738b67f
    • andersca@apple.com's avatar
      Enable the plug-in process on Mac · ef1e82ef
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48350
      
      Reviewed by Sam Weinig.
      
      WebKit2:
      
      * WebKit2Prefix.h:
      Flip the switch and enable the plug-in process on Mac.
      
      * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
      (WebKit::NetscapePlugin::platformDestroy):
      Fix a bogus assert.
      
      LayoutTests:
      
      * platform/mac-wk2/Skipped:
      Update WebKit2 mac skipped list.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef1e82ef
  23. 25 Oct, 2010 2 commits
  24. 23 Oct, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-10-23 Sheriff Bot <webkit.review.bot@gmail.com> · 3cdd815a
      commit-queue@webkit.org authored
              Unreviewed, rolling out r70367.
              http://trac.webkit.org/changeset/70367
              https://bugs.webkit.org/show_bug.cgi?id=48176
      
              It made 8-10 tests crash on Qt bot (Requested by Ossy on
              #webkit).
      
              * fast/loader/decide-policy-for-mime-type-async-expected.txt: Removed.
              * fast/loader/decide-policy-for-mime-type-async.html: Removed.
              * platform/gtk/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/qt-wk2/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      2010-10-23  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r70367.
              http://trac.webkit.org/changeset/70367
              https://bugs.webkit.org/show_bug.cgi?id=48176
      
              It made 8-10 tests crash on Qt bot (Requested by Ossy on
              #webkit).
      
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::MainResourceLoader):
              (WebCore::MainResourceLoader::continueAfterContentPolicy):
              (WebCore::MainResourceLoader::didReceiveResponse):
              (WebCore::MainResourceLoader::setDefersLoading):
              * loader/MainResourceLoader.h:
      2010-10-23  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r70367.
              http://trac.webkit.org/changeset/70367
              https://bugs.webkit.org/show_bug.cgi?id=48176
      
              It made 8-10 tests crash on Qt bot (Requested by Ossy on
              #webkit).
      
              * DumpRenderTree/LayoutTestController.cpp:
              (setCustomPolicyDelegateCallback):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setCustomPolicyDelegate):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setCustomPolicyDelegate):
              * DumpRenderTree/mac/PolicyDelegate.h:
              * DumpRenderTree/mac/PolicyDelegate.mm:
              (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
              (-[PolicyDelegate setPermissive:]):
              (-[PolicyDelegate setControllerToNotifyDone:]):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setCustomPolicyDelegate):
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              (LayoutTestController::setCustomPolicyDelegate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cdd815a
  25. 22 Oct, 2010 1 commit
    • andersca@apple.com's avatar
      WebCore: Using the decidePolicyForMIMEType delegate message in an asynchronous manner does not work · b600db87
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48014
      <rdar://problem/8202716>
      
      Reviewed by Adam Barth and Darin Adler.
      
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::continueAfterContentPolicy):
      Resume loading.
      
      (WebCore::MainResourceLoader::didReceiveResponse):
      Defer loading until we hear back from the policy client.
      
      WebKitTools: Using the decidePolicyForMIMEType delegate message in an asynchronous manner does not work
      https://bugs.webkit.org/show_bug.cgi?id=48014
      <rdar://problem/8202716>
      
      Reviewed by Adam Barth and Darin Adler.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (setCustomPolicyDelegateCallback):
      Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
      
      * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
      (LayoutTestController::setCustomPolicyDelegate):
      Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
      
      * DumpRenderTree/mac/LayoutTestControllerMac.mm:
      (LayoutTestController::setCustomPolicyDelegate):
      Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
      
      * DumpRenderTree/mac/PolicyDelegate.h:
      * DumpRenderTree/mac/PolicyDelegate.mm:
      (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
      If _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond is true, call [listener ignore] after one second.
      
      (-[PolicyDelegate setCallIgnoreInDecidePolicyForMIMETypeAfterOneSecond:]):
      Update _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond.
      
      * DumpRenderTree/win/LayoutTestControllerWin.cpp:
      (LayoutTestController::setCustomPolicyDelegate):
      Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
      
      * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
      (LayoutTestController::setCustomPolicyDelegate):
      Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
      
      LayoutTests: Using the decidePolicyForMIMEType delegate message in an asynchronous manner does not work
      https://bugs.webkit.org/show_bug.cgi?id=48014
      <rdar://problem/8202716>
      
      Reviewed by Adam Barth and Darin Adler.
      
      Add tests and update the skipped list.
      
      * fast/loader/decide-policy-for-mime-type-async-expected.txt: Added.
      * fast/loader/decide-policy-for-mime-type-async.html: Added.
      * platform/gtk/Skipped:
      * platform/mac-wk2/Skipped:
      * platform/qt/Skipped:
      * platform/qt-wk2/Skipped:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b600db87
  26. 21 Oct, 2010 1 commit