1. 12 Dec, 2010 1 commit
    • morrita@google.com's avatar
      2010-10-28 MORITA Hajime <morrita@google.com> · 7a18feed
      morrita@google.com authored
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              * editing/spelling/script-tests/spellcheck-paste.js: Added.
              * editing/spelling/spellcheck-paste.html: Added.
              * editing/spelling/spellcheck-paste-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/mac-leopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              - Introduced SpellChecker class to encapsulate asynchronous spell
                checker state: sequence id, requesting text and target node.
                This is also the first step to decompose spell-check related
                code to a separate class.
              - Added EditorClient::isAsynchronousSpellCheckingEnabled()
                to use async spellcheck API on the platform.
                These APIs are touched by SpellChecker.
              - Used SpellChecker to check a pasted test. Text to check is
                collected from the subtree under the editingRoot.
              - Added Setting::m_asynchronousSpellCheckingEnabled to control
                async spell checking.
      
              Test: editing/spelling/spellcheck-paste.html
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * dom/DocumentMarkerController.cpp:
              (WebCore::DocumentMarkerController::showMarkers):
              (showDocumentMarkers):
              * dom/DocumentMarkerController.h:
              * dom/PositionIterator.cpp:
              (WebCore::PositionIterator::setOffsetInLeafNode):
              * dom/PositionIterator.h:
              * editing/Editor.cpp:
              (WebCore::Editor::replaceSelectionWithFragment):
              (WebCore::Editor::Editor):
              (WebCore::findFirstMarkable):
              (WebCore::Editor::selectionStartHasSpellingMarkerFor):
              * editing/Editor.h:
              (WebCore::Editor::spellChecker):
              * editing/SpellChecker.cpp: Added.
              (WebCore::SpellChecker::SpellChecker):
              (WebCore::SpellChecker::~SpellChecker):
              (WebCore::SpellChecker::initRequest):
              (WebCore::SpellChecker::clearRequest):
              (WebCore::SpellChecker::isAsynchronousEnabled):
              (WebCore::SpellChecker::canCheckAsynchronously):
              (WebCore::SpellChecker::isBusy):
              (WebCore::SpellChecker::isValid):
              (WebCore::SpellChecker::isCheckable):
              (WebCore::SpellChecker::requestCheckingFor):
              (WebCore::forwardIterator):
              (WebCore::SpellChecker::didCheck):
              * editing/SpellChecker.h: Added.
              (WebCore::SpellCheckingResult::SpellCheckingResult):
              (WebCore::SpellCheckingResult::type):
              (WebCore::SpellCheckingResult::location):
              (WebCore::SpellCheckingResult::length):
              * loader/EmptyClients.h:
              (WebCore::EmptyEditorClient::requestCheckingOfString):
              * page/EditorClient.h:
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              * page/Settings.h:
              (WebCore::Settings::setAsynchronousSpellCheckingEnabled):
              (WebCore::Settings::asynchronousSpellCheckingEnabled):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * src/EditorClientImpl.h:
              (WebKit::EditorClientImpl::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientEfl.h:
              (WebCore::EditorClientEfl::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientGtk.h:
              (WebKit::EditorClient::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientHaiku.h:
              (WebCore::EditorClientHaiku::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added asynchronous spell checking API to WebEditorClient using
              -[NSSpellChecker requestCheckingOfString].
              Note that WebEditorSpellCheckResponder is a small class to receive
              requested spell-checking result. Note that this feature is
              disabled at default.
      
              Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
              enable the feature from LayoutTestController.
      
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
              (-[WebEditorSpellCheckResponder perform]):
              (toCoreSpellingResult):
              (-[WebEditorSpellCheckResponder WTF::WebCore::]):
              (WebEditorClient::requestCheckingOfString):
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]):
              (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
              (-[WebPreferences asynchronousSpellCheckingEnabled]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientQt.h:
              (WebCore::EditorClientQt::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/WebEditorClient.h:
              (WebEditorClient::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientWinCE.h:
              (WebKit::EditorClient::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebKitSupport/EditorClientWx.h:
              (WebCore::EditorClientWx::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebProcess/WebCoreSupport/WebEditorClient.cpp:
              (WebKit::WebEditorClient::requestCheckingOfString):
              * WebProcess/WebCoreSupport/WebEditorClient.h:
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
              to control the setting.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (setAsynchronousSpellCheckingEnabledCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a18feed
  2. 08 Dec, 2010 1 commit
    • xji@chromium.org's avatar
      2010-12-08 Xiaomei Ji <xji@chromium.org> · bebfbc9b
      xji@chromium.org authored
              Reviewed by David Hyatt.
      
              Fix backward mouse wheeling not working when scroll position is below 0.
              https://bugs.webkit.org/show_bug.cgi?id=50370
      
              Tests: fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html
                     fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html
      
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::wheelEvent):
      2010-12-08  Xiaomei Ji  <xji@chromium.org>
      
              Reviewed by David Hyatt.
      
              Fix backward mouse wheeling not working when scroll position is below 0.
              https://bugs.webkit.org/show_bug.cgi?id=50370
      
              * fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
              * fast/dom/horizontal-scrollbar-in-rtl.html:
              * fast/dom/vertical-scrollbar-in-rtl-expected.txt:
              * fast/dom/vertical-scrollbar-in-rtl.html:
              * fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
              * fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html: Added.
              * fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
              * fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html: Added.
              * platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
              * platform/chromium/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
              * platform/chromium/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
              * platform/chromium/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
              * platform/gtk/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/qt-wk2/Skipped:
              * platform/qt/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
              * platform/qt/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
              * platform/win/Skipped:
              * platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
              * platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bebfbc9b
  3. 07 Dec, 2010 1 commit
    • philn@webkit.org's avatar
      2010-12-07 Philippe Normand <pnormand@igalia.com> · 6b4764ec
      philn@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              [GStreamer] ::buffered() should return multiple ranges in some cases
              https://bugs.webkit.org/show_bug.cgi?id=45101
      
              Improved the ::buffered() method thanks to the new buffering query
              support that landed in GStreamer 0.10.31. The method now
              queries the media buffered-ranges on the pipeline and queue2
              handles it if it's buffering the media to disk.
      
              The webkitwebsrc element also gained BYTES duration query
              support. This is needed in the rare cases where uridecodebin
              configures its queue before the HTTP server returns the media
              Content-Length.
      
              Test: http/tests/media/video-buffered.html
      
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::MediaPlayerPrivateGStreamer::buffered):
              * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
              (webkit_web_src_init):
              (webKitWebSrcQuery): Make webkitwebsrc handle the duration queries
              if it's aware of the media content-length.
              * platform/gtk/RenderThemeGtk.cpp:
              (WebCore::RenderThemeGtk::paintMediaSliderTrack): Fix position of
              the second and next buffered ranges.
      
      LayoutTests:
      
              Reviewed by Gustavo Noronha Silva.
      
              [GStreamer] ::buffered() should return multiple ranges in some cases
              https://bugs.webkit.org/show_bug.cgi?id=45101
      
              New test for video.buffered attribute. The test is skipped for
              ports not returning multiple timeranges for video.buffered.
      
              * http/tests/media/video-buffered-expected.txt: Added.
              * http/tests/media/video-buffered.html: Added.
              * http/tests/resources/counting-captioned.mov: Added.
              * http/tests/media/video-throttled-load.cgi: added Range
              requests/responses support.
              * platform/chromium/test_expectations.txt:
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/mac/Skipped:
              * platform/qt-mac/Skipped:
              * platform/qt-win/Skipped:
              * platform/qt-wk2/Skipped:
              * platform/qt/Skipped:
              * platform/win-wk2/Skipped:
              * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b4764ec
  4. 01 Dec, 2010 1 commit
    • darin@apple.com's avatar
      2010-12-01 Jia Pu <jpu@apple.com> · a5f05c0a
      darin@apple.com authored
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * src/EditorClientImpl.cpp:
              (WebKit::EditorClientImpl::getGuessesForWord):
              * src/EditorClientImpl.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::getGuessesForWord):
              * WebCoreSupport/EditorClientQt.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::EditorClient::getGuessesForWord):
              * WebCoreSupport/EditorClientGtk.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/WebEditorClient.cpp:
              (WebEditorClient::getGuessesForWord):
              * WebCoreSupport/WebEditorClient.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebKitSupport/EditorClientWx.cpp:
              (WebCore::EditorClientWx::getGuessesForWord):
              * WebKitSupport/EditorClientWx.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              This patch is for supporting multiple correction suggestion panel on Mac OS X.
              The behavior and implementation is similar to that of reversion candiate panel.
      
              * WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
      
              * WebCoreSupport/WebEditorClient.mm:  Adopted new signatures defined in base class.
                Added code to handle new multiple suggestion canidate panel type.
              (WebEditorClient::showCorrectionPanel):
              (WebEditorClient::getGuessesForWord):
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientHaiku.cpp:
              (WebCore::EditorClientHaiku::getGuessesForWord):
              * WebCoreSupport/EditorClientHaiku.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientWinCE.cpp:
              (WebKit::EditorClientWinCE::getGuessesForWord):
              * WebCoreSupport/EditorClientWinCE.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientEfl.cpp:
              (WebCore::EditorClientEfl::getGuessesForWord):
              * WebCoreSupport/EditorClientEfl.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Test: platform/mac/editing/spelling/delete-autocorrected-word-1.html
              Manual test: WebCore/manual-tests/autocorrection/dismiss-multiple-guesses.html
                           WebCore/manual-tests/autocorrection/select-from-multiple-guesses.html
      
              This patch is for supporting multiple correction suggestion panel on Mac OS X.
              The behavior and implementation is similar to that of reversion candiate panel.
      
              * WebCore.exp.in: Added and removed symbols.
      
              * editing/CorrectionPanelInfo.h: Added new correction panel type, PanelTypeSpellingSuggestions.
      
              * editing/Editor.cpp:
              (WebCore::markerTypesForAutocorrection): Convenient function for getting marker types to
                be added to autocorrected word.
              (WebCore::boundingBoxForRange): Convenient function for calculating the bounding box of a range.
              (WebCore::markerTypesForReplacement): Convenient function for getting marker types to
                be added to word that has been replaced by various correction panel.
              (WebCore::Editor::respondToChangedSelection): Added code to trigger timer for multiple
                suggestion panel.
              (WebCore::Editor::guessesForMisspelledSelection): Adopted new signature of EditorClient::getGuessesForWord().
              (WebCore::Editor::markMisspellingsAfterTypingToWord): Adopted new signature of applyCorrectionPanelInfo().
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
              (WebCore::Editor::correctionPanelTimerFired): Added code to handle new multiple suggestion panel.
              (WebCore::Editor::handleCorrectionPanelResult): Replaced handleRejectedCorrection(), since
                with new AppKit correction panel API, not only rejection, but also confirmation can be
                handled in callback.
              (WebCore::Editor::stopCorrectionPanelTimer): Moved the code that clears correction panel info
                from dismissCorrectionPanel() to this function to fix a bug that would occur when deleting
                autocorrected word.
              (WebCore::Editor::dismissCorrectionPanel): Ditto.
              (WebCore::Editor::applyCorrectionPanelInfo): Added code to handle new multiple suggestion panel.
      
              * editing/Editor.h: Replaced handleRejectedCorrection() with handleCorrectionPanelResult().
                Changed the signature of applyCorrectionPanelInfo() to hanlde new correction panel type.
      
              * editing/TextCheckingHelper.cpp:
              (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): Adopted new EditorClient::getGuessesForWord().
      
              * editing/TextCheckingHelper.h: Made paragraphRange() public.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyEditorClient::showCorrectionPanel): Adopted new signature defined in base class.
              (WebCore::EmptyEditorClient::getGuessesForWord): Ditto.
      
              * manual-tests/autocorrection/dismiss-multiple-guesses.html: Added.
      
              * manual-tests/autocorrection/select-from-multiple-guesses.html: Added.
      
              * page/EditorClient.h:  Changed showCorrectionPanel() to allow passing multiple correction
                candidates. Changed getGuessesForWord() to allow passing in contextual text for better
                correction suggestions (for those spellcheckers that utilizes such contextual information).
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt: Added.
              * platform/mac/editing/spelling/delete-autocorrected-word-1.html: Added.
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signatures defined in base class.
      
              * WebProcess/WebCoreSupport/WebEditorClient.cpp:
              (WebKit::WebEditorClient::getGuessesForWord):
              * WebProcess/WebCoreSupport/WebEditorClient.h:
              * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
              (WebKit::WebEditorClient::showCorrectionPanel):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5f05c0a
  5. 20 Nov, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-11-19 Jia Pu <jpu@apple.com> · a563e17c
      commit-queue@webkit.org authored
              Reviewed by Dan Bernstein.
      
              Regression: contraction is considered misspelling.
              https://bugs.webkit.org/show_bug.cgi?id=49423
              <rdar://problem/8654206>
      
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/mac/editing/spelling/autocorrection-contraction-expected.checksum: Added.
              * platform/mac/editing/spelling/autocorrection-contraction-expected.png: Added.
              * platform/mac/editing/spelling/autocorrection-contraction-expected.txt: Added.
              * platform/mac/editing/spelling/autocorrection-contraction.html: Added.
      2010-11-19  Jia Pu  <jpu@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Regression: contraction is considered misspelling.
              https://bugs.webkit.org/show_bug.cgi?id=49423
              <rdar://problem/8654206>
      
              Test: platform/mac/editing/spelling/autocorrection-contraction.html
                    manual-tests/autocorrection/autocorrection-contraction.html
      
              * editing/Editor.cpp:
              (WebCore::isAmbiguousBoundaryCharacter): Moved function to the top of the file so that it can
                be used by all other functions in the file.
              (WebCore::Editor::markMisspellingsAfterTypingToWord): Renamed markMisspellingsAfterTypingToPosition()
                to improve readability, and to pass in additional argument. Before we apply pending
                autocorrection, we check to see if currently typed character makes current word a partial
                contraction, for instance "wouldn'". If that's the case, we would not apply the pending
                correction.
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Make sure currently typed word
                is not a partial contraction, such as "wouldn'", before mark it as misspelled. Also update
                the location of ambiguous boundary if other replacements have changed the length of the
                paragraph.
              * editing/Editor.h:
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::markMisspellingsAfterTyping): Adopt renamed function.
              * manual-tests/autocorrection/autocorrection-contraction.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a563e17c
  6. 18 Nov, 2010 1 commit
    • jianli@chromium.org's avatar
      Move fileapi test files under http/tests/local to a new subdirectory under it · 7a064a56
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=49709
      
      Reviewed by David Levin.
      
      * http/tests/local/fileapi/resources/setup-file-input-element-for-drag.js: Renamed from LayoutTests/http/tests/local/resources/setup-file-input-element-for-drag.js.
      * http/tests/local/fileapi/script-tests/TEMPLATE.html: Added.
      * http/tests/local/fileapi/script-tests/send-dragged-file.js: Renamed from LayoutTests/http/tests/local/resources/send-dragged-file.js.
      * http/tests/local/fileapi/script-tests/send-sliced-dragged-file.js: Renamed from LayoutTests/http/tests/local/resources/send-sliced-dragged-file.js.
      * http/tests/local/fileapi/send-dragged-file-expected.txt: Renamed from LayoutTests/http/tests/local/send-dragged-file-expected.txt.
      * http/tests/local/fileapi/send-dragged-file.html: Renamed from LayoutTests/http/tests/local/send-dragged-file.html.
      * http/tests/local/fileapi/send-sliced-dragged-file-expected.txt: Renamed from LayoutTests/http/tests/local/send-sliced-dragged-file-expected.txt.
      * http/tests/local/fileapi/send-sliced-dragged-file.html: Renamed from LayoutTests/http/tests/local/send-sliced-dragged-file.html.
      * platform/gtk/Skipped:
      * platform/mac-tiger/Skipped:
      * platform/mac-wk2/Skipped:
      * platform/qt-wk2/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a064a56
  7. 28 Oct, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-10-28 Jia Pu <jpu@apple.com> · 08abac67
      commit-queue@webkit.org authored
              Reviewed by Dan Bernstein.
      
              Editing a word with misspell or autocorrection underline should remove the underline when the editing changes the word.
              https://bugs.webkit.org/show_bug.cgi?id=48078
              <rdar://problem/8579155>
      
              * platform/mac-leopard/Skipped: New tests don't apply to this platform.
              * platform/mac-snowleopard/Skipped: Ditto.
              * platform/mac-tiger/Skipped: Ditto.
              * platform/mac-wk2/Skipped: Ditto.
              * platform/mac/editing/spelling/autocorrection-delete-expected.checksum: Updated expected test result.
              * platform/mac/editing/spelling/autocorrection-delete-expected.png: Ditto.
              * platform/mac/editing/spelling/editing-multiple-words-with-markers-expected.txt: Added.
              * platform/mac/editing/spelling/editing-multiple-words-with-markers.html: Added.
              * platform/mac/editing/spelling/editing-word-with-marker-1-expected.txt: Added.
              * platform/mac/editing/spelling/editing-word-with-marker-1.html: Added.
              * platform/mac/editing/spelling/editing-word-with-marker-2-expected.txt: Added.
              * platform/mac/editing/spelling/editing-word-with-marker-2.html: Added.
      2010-10-28  Jia Pu  <jpu@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Editing a word with misspell or autocorrection underline should remove the underline when the editing changes the word.
              https://bugs.webkit.org/show_bug.cgi?id=48078
              <rdar://problem/8579155>
      
              Tests: platform/mac/editing/spelling/editing-multiple-words-with-markers.html
                     platform/mac/editing/spelling/editing-word-with-marker-1.html
                     platform/mac/editing/spelling/editing-word-with-marker-2.html
      
              This patch is part of on-going improvement of autocorrection feature on Mac OS X. When an editing
              occurs, if it affects words (by deleting/inserting characters, spliting word, merging words) that
              have Spelling and/or CorrectionIndicator markers, we want to remove the markers. If subsequntial
              spelling checking finds spelling error in newlly formed words, it will add the markers back in.
      
              * dom/DocumentMarker.h: Changed MarkerType to bit masks to make search multiple types easier.
      
              * dom/DocumentMarkerController.cpp: Refactored two removeMarkers() methods to support remove
                markers with specific type from a node.
              (WebCore::DocumentMarkerController::removeMarkers): Changed signature to remove marker with specific type.
              (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): Refactoring.
              (WebCore::DocumentMarkerController::hasMarkers): Convenience method to search markers in range.
      
              * dom/DocumentMarkerController.h: Added new methods and matched new signature of removeMarkers().
      
              * editing/Editor.cpp:
              (WebCore::Editor::respondToChangedContents): Remove existing markers if the change formed new word.
              (WebCore::Editor::cut): Remove markers on words that will be modified by this editing.
              (WebCore::Editor::paste): Ditto.
              (WebCore::Editor::pasteAsPlainText): Ditto.
              (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited): Main logic for removing
                markers on words affected by editing.
      
              * editing/Editor.h: Added removeSpellAndCorrectionMarkersFromWordsToBeEdited().  Added
                REMOVE_MARKERS_UPON_EDITING and SUPPORT_AUTOCORRECTION_PANEL macro to improve readability.
      
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::insertText): Remove markers on words that will be modified by this editing.
              (WebCore::TypingCommand::deleteKeyPressed): Ditto.
              (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08abac67
  8. 19 Oct, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-10-19 Jia Pu <jpu@apple.com> · 55ac1ae2
      commit-queue@webkit.org authored
              Reviewed by Adele Peterson.
      
              Moving cursor back to autocorrected word in the same line shouldn't remove the underline
              https://bugs.webkit.org/show_bug.cgi?id=47629
              <rdar://problem/8546758>
      
              * platform/mac-leopard/Skipped: New tests don't apply to this Mac OSX version.
              * platform/mac-snowleopard/Skipped: Ditto.
              * platform/mac-tiger/Skipped: Ditto.
              * platform/mac-wk2/Skipped: Ditto.
              * platform/mac/editing/spelling/autocorrection-delete-expected.checksum:
              * platform/mac/editing/spelling/autocorrection-delete-expected.png:
              * platform/mac/editing/spelling/click-autocorrected-word-expected.checksum: Added.
              * platform/mac/editing/spelling/click-autocorrected-word-expected.png: Added.
              * platform/mac/editing/spelling/click-autocorrected-word-expected.txt: Added.
              * platform/mac/editing/spelling/click-autocorrected-word.html: Added.
              * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.checksum: Added.
              * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png: Added.
              * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt: Added.
              * platform/mac/editing/spelling/delete-into-autocorrected-word.html: Added.
              * platform/mac/editing/spelling/delete-into-misspelled-word-expected.txt: Added.
              * platform/mac/editing/spelling/delete-into-misspelled-word.html: Added.
              * platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.checksum: Added.
              * platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png: Added.
              * platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt: Added.
              * platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html: Added.
              * platform/mac/editing/spelling/move-cursor-around-misspelled-word-expected.txt: Added.
              * platform/mac/editing/spelling/move-cursor-around-misspelled-word.html: Added.
              * platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.checksum: Added.
              * platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png: Added.
              * platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt: Added.
              * platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html: Added.
              * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.checksum: Added.
              * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png: Added.
              * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt: Added.
              * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html: Added.
      2010-10-19  Jia Pu  <jpu@apple.com>
      
              Reviewed by Adele Peterson.
      
              Moving cursor back to autocorrected word in the same line shouldn't remove the underline
              https://bugs.webkit.org/show_bug.cgi?id=47629
              <rdar://problem/8546758>
      
              Tests: platform/mac/editing/spelling/click-autocorrected-word.html
                     platform/mac/editing/spelling/delete-into-autocorrected-word.html
                     platform/mac/editing/spelling/delete-into-misspelled-word.html
                     platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
                     platform/mac/editing/spelling/move-cursor-around-misspelled-word.html
                     platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
                     platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html
      
              * editing/Editor.cpp:
              (WebCore::Editor::respondToChangedSelection): Don't remove misspelling or autocorrection
                underlines when cursor is moved onto a word.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55ac1ae2
  9. 14 Oct, 2010 1 commit
  10. 07 Oct, 2010 1 commit
    • bweinstein@apple.com's avatar
      Autocorrection panel regression tests fail on Windows · ef59d712
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=47341
      <rdar://problem/8523631>
      
      Patch by Jia Pu <jpu@apple.com> on 2010-10-07
      Reviewed by Adele Peterson.
      
      Move Mac specific tests to platform/mac directory.
      
      * editing/spelling/autocorrection-delete.html: Removed.
      * editing/spelling/autocorrection-removing-underline-after-paste.html: Removed.
      * editing/spelling/autocorrection-removing-underline.html: Removed.
      * editing/spelling/autocorrection-simple.html: Removed.
      * platform/mac-leopard/Skipped:
      * platform/mac-snowleopard/Skipped:
      * platform/mac-tiger/Skipped:
      * platform/mac-wk2/Skipped:
      * platform/mac/editing/spelling/autocorrection-delete.html: Added.
      * platform/mac/editing/spelling/autocorrection-removing-underline-after-paste.html: Added.
      * platform/mac/editing/spelling/autocorrection-removing-underline.html: Added.
      * platform/mac/editing/spelling/autocorrection-simple.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef59d712
  11. 06 Oct, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-10-06 Jia Pu <jpu@apple.com> · 17a21c69
      commit-queue@webkit.org authored
              Reviewed by Adele Peterson.
      
              Add regression tests for autocorrection panel
              https://bugs.webkit.org/show_bug.cgi?id=47308
              <rdar://problem/8521243>
      
              Added regression tests for recently added autocorrection panel on Mac platform, as implemented in <https://bugs.webkit.org/show_bug.cgi?id=44958>.
      
              * editing/spelling/autocorrection-delete.html: Added.
              * editing/spelling/autocorrection-removing-underline-after-paste.html: Added.
              * editing/spelling/autocorrection-removing-underline.html: Added.
              * editing/spelling/autocorrection-simple.html: Added.
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/mac/editing/spelling/autocorrection-delete-expected.checksum: Added.
              * platform/mac/editing/spelling/autocorrection-delete-expected.png: Added.
              * platform/mac/editing/spelling/autocorrection-delete-expected.txt: Added.
              * platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.checksum: Added.
              * platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.png: Added.
              * platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt: Added.
              * platform/mac/editing/spelling/autocorrection-removing-underline-expected.checksum: Added.
              * platform/mac/editing/spelling/autocorrection-removing-underline-expected.png: Added.
              * platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt: Added.
              * platform/mac/editing/spelling/autocorrection-simple-expected.checksum: Added.
              * platform/mac/editing/spelling/autocorrection-simple-expected.png: Added.
              * platform/mac/editing/spelling/autocorrection-simple-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17a21c69
  12. 11 Aug, 2010 1 commit
    • abarth@webkit.org's avatar
      2010-08-11 Adam Barth <abarth@webkit.org> · 3d3ef33c
      abarth@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              fast/encoding/japanese-encoding-mix.html fails on Tiger after enabling HTML5 Lexer
              https://bugs.webkit.org/show_bug.cgi?id=40725
      
              Qt and Tiger seem to have encoding problems that swallow the --
              characters that terminate the comment.  We can avoid those problems by
              inserting a space before the -->.  We're losing coverage of these
              issues, but I'm not sure we should be in the business of debugging
              these encoders unless there's a security problem.
      
              Thanks to ap for investigating and finding this workaround.
      
              * fast/encoding/japanese-encoding-mix.html:
              * platform/mac-tiger/Skipped:
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d3ef33c
  13. 14 Jul, 2010 2 commits
  14. 12 Jul, 2010 1 commit
  15. 07 Jul, 2010 2 commits
  16. 21 Jun, 2010 2 commits
  17. 18 Jun, 2010 1 commit
  18. 16 Jun, 2010 1 commit
  19. 03 Jun, 2010 1 commit
    • ukai@chromium.org's avatar
      2010-06-03 Fumitoshi Ukai <ukai@chromium.org> · 481223cc
      ukai@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
              https://bugs.webkit.org/show_bug.cgi?id=39058
      
              * platform/mac-tiger/Skipped:
              - remove websocket/tests from skipped list.
      2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
              https://bugs.webkit.org/show_bug.cgi?id=39058
      
              * Scripts/ensure-valid-python:
                - Perl 5.8 doesn't have File::Temp->newdir().  Use File::Temp->tempdir() instead.
                - Add --check-only and --help option.
                - --check-only option only checks python version and don't try to install Python 2.5.
                - Set executable bit.
              * Scripts/old-run-webkit-tests:
                - Check if it can run the websocket tests by calling ensure-valid-python --check-only.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      481223cc
  20. 02 Jun, 2010 1 commit
  21. 26 May, 2010 2 commits
  22. 25 May, 2010 1 commit
  23. 17 May, 2010 1 commit
    • jorlow@chromium.org's avatar
      2010-05-14 Jeremy Orlow <jorlow@chromium.org> · 6ef2affa
      jorlow@chromium.org authored
              Reviewed by Nate Chapin.
      
              Finish up IndexedDB events
              https://bugs.webkit.org/show_bug.cgi?id=39117
      
              Add the beginnings of a test for IndexedDB.  It currently fails, but we'll
              update this (and/or add other tests) as things start passing.
      
              Disable it on all !Chromium platforms since none of them compile it
              in.  (Note that Chromium keeps it behind a runtime flag at the moment,
              despite compiling it in...so don't worry.)
      
              This also makes evalAndLog return the result of the evaluation.  I think
              this was just an oversight when I originally added it, and it's going to
              come in useful for these tests.
      
              * fast/js/resources/js-test-pre.js:
              (evalAndLog):
              * platform/gtk/Skipped:
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
              * storage/indexeddb/basics-expected.txt: Added.
              * storage/indexeddb/basics.html: Added.
              * storage/indexeddb/script-tests/TEMPLATE.html: Copied from LayoutTests/storage/domstorage/script-tests/TEMPLATE.html.
              * storage/indexeddb/script-tests/basics.js: Added.
              (eventShared):
              (successFunction):
              (errorFunction):
              (test):
      2010-05-14  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Nate Chapin.
      
              Finish up IndexedDB events
              https://bugs.webkit.org/show_bug.cgi?id=39117
      
              Implement the indexed database event interfaces as proposed by Mozilla.
              Refactor the run time type detection code that was in IDBRequest into its own
              class named IDBAny.  Use this new class within the new event classes and
              IDBResults.
      
              Test: storage/indexeddb/basics.html
      
              * DerivedSources.cpp:
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.gyp/WebCore.gyp:
              * WebCore.gypi:
              * WebCore.pri:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSEventCustom.cpp:
              (WebCore::toJS):
              * bindings/js/JSEventTarget.cpp:
              (WebCore::toJS):
              * bindings/js/JSIDBAnyCustom.cpp: Added.
              (WebCore::toJS):
              * bindings/js/JSIDBRequestCustom.cpp: Removed.
              * bindings/v8/custom/V8EventCustom.cpp:
              (WebCore::toV8):
              * bindings/v8/custom/V8IDBAnyCustom.cpp: Added.
              (WebCore::toV8):
              * bindings/v8/custom/V8IDBRequestCustom.cpp: Removed.
              * dom/Event.cpp:
              (WebCore::Event::isIDBErrorEvent):
              (WebCore::Event::isIDBSuccessEvent):
              * dom/Event.h:
              * storage/IDBAny.cpp: Added.
              (WebCore::IDBAny::create):
              (WebCore::IDBAny::IDBAny):
              (WebCore::IDBAny::~IDBAny):
              (WebCore::IDBAny::idbDatabaseRequest):
              (WebCore::IDBAny::indexedDatabaseRequest):
              (WebCore::IDBAny::serializedScriptValue):
              (WebCore::IDBAny::set):
              * storage/IDBAny.h: Added.
              (WebCore::IDBAny::):
              (WebCore::IDBAny::type):
              * storage/IDBAny.idl: Added.
              * storage/IDBErrorEvent.cpp: Added.
              (WebCore::IDBErrorEvent::create):
              (WebCore::IDBErrorEvent::IDBErrorEvent):
              (WebCore::IDBErrorEvent::~IDBErrorEvent):
              * storage/IDBErrorEvent.h: Added.
              (WebCore::IDBErrorEvent::code):
              (WebCore::IDBErrorEvent::message):
              (WebCore::IDBErrorEvent::isIDBErrorEvent):
              * storage/IDBErrorEvent.idl: Added.
              * storage/IDBEvent.cpp: Added.
              (WebCore::IDBEvent::IDBEvent):
              (WebCore::IDBEvent::~IDBEvent):
              (WebCore::IDBEvent::source):
              * storage/IDBEvent.h: Added.
              * storage/IDBEvent.idl: Added.
              * storage/IDBRequest.cpp:
              (WebCore::IDBRequest::IDBRequest):
              (WebCore::IDBRequest::onSuccess):
              (WebCore::IDBRequest::timerFired):
              (WebCore::IDBRequest::onEventCommon):
              * storage/IDBRequest.h:
              (WebCore::IDBRequest::create):
              (WebCore::IDBRequest::result):
              * storage/IDBRequest.idl:
              * storage/IDBSuccessEvent.cpp: Added.
              (WebCore::IDBSuccessEvent::create):
              (WebCore::IDBSuccessEvent::IDBSuccessEvent):
              (WebCore::IDBSuccessEvent::~IDBSuccessEvent):
              (WebCore::IDBSuccessEvent::result):
              * storage/IDBSuccessEvent.h: Added.
              (WebCore::IDBSuccessEvent::isIDBSuccessEvent):
              * storage/IDBSuccessEvent.idl: Added.
              * storage/IndexedDatabaseImpl.cpp:
              (WebCore::IndexedDatabaseImpl::open):
              * storage/IndexedDatabaseRequest.cpp:
              (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest):
              (WebCore::IndexedDatabaseRequest::open):
              * storage/IndexedDatabaseRequest.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ef2affa
  24. 14 May, 2010 1 commit
    • ap@apple.com's avatar
      Inspired by Simon Fraser, rubber-stamped by Geoff Garen. · e9dca985
      ap@apple.com authored
              Disabled Sputnik tests that take over 10 seconds in debug builds on my MacBook Pro.
      
              * platform/mac-tiger/Skipped: These tests were alrady skipped on Tiger, no need to skip
              explicitly any more.
      
              * fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html: Removed.
              * fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html-disabled: Copied from fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html.
              * fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html: Removed.
              * fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html-disabled: Copied from fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html.
              * fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.1.html: Removed.
              * fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.1.html-disabled: Copied from fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.1.html.
              * fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.2.html: Removed.
              * fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.2.html-disabled: Copied from fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.2.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9dca985
  25. 13 May, 2010 1 commit
    • ukai@chromium.org's avatar
      WebKitTools: Unreviewed fix. Revert previous change. · d7bdc72b
      ukai@chromium.org authored
      Even if with-statments are changed in websocket_server.py, it also claims syntax error for with statement in http_server.py.
      Until python 2.5 is installed on tiger bot, skips websocket/tests on tiger.
      
      * Scripts/webkitpy/layout_tests/port/websocket_server.py: use with statement
      
      LayoutTests: Unreviewed.
      
      Skip websocket/tests on tiger, until Python 2.5 is installed on tiger bot.
      
      * platform/mac-tiger/Skipped: Add websocket/tests
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7bdc72b
  26. 07 May, 2010 1 commit
  27. 05 May, 2010 1 commit
  28. 30 Apr, 2010 3 commits
  29. 29 Apr, 2010 2 commits
    • ap@apple.com's avatar
      Not reviewed. · b819bd08
      ap@apple.com authored
              * platform/mac-tiger/Skipped: Accidentally committed with a commented out line.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b819bd08
    • ap@apple.com's avatar
      Re-enable Sputnik tests on Leopard and Snow Leopard. · ef003765
      ap@apple.com authored
              * fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Applying_the_percent_Operator/S11.5.3_A4_T2-expected.txt:
              * fast/js/sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.12_Array_prototype_splice/S15.4.4.12_A2.1_T3-expected.txt:
              Changed expectation to PASS.
      
              * platform/mac-snowleopard/Skipped: Skip the above tests, since they fail in 64 bit, and
              DRT may run 64 bit on Snow Leopard.
      
              * platform/mac-leopard/fast/js: Added.
              * platform/mac-leopard/fast/js/sputnik: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.2-expected.txt: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.16_A1-expected.txt: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.18_A1-expected.txt: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T1-expected.txt: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T2-expected.txt: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T1-expected.txt: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T2-expected.txt: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.3-expected.txt: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T1-expected.txt: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T2-expected.txt: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T7-expected.txt: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T8-expected.txt: Added.
              * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T9-expected.txt: Added.
              Added platform specific results for tests that depend on supported Unicode version.
      
              * platform/mac-tiger/Skipped: Skipped Sputnik on Tiger.
      
              * platform/mac/Skipped: Unskipped Sputnik.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef003765
  30. 28 Apr, 2010 1 commit
    • jchaffraix@webkit.org's avatar
      [XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR · 5ace159f
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=37781
      <rdar://problem/7905150>
      
      Reviewed by Alexey Proskuryakov.
      
      WebCore:
      
      Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html
             http/tests/xmlhttprequest/access-control-preflight-credential-sync.html
      
      Rolling the patch in as I could not reproduce Qt results locally.
      
      * loader/DocumentThreadableLoader.cpp:
      (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the
      credential from the request here to avoid forgetting to do so in the different code path.
      (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the
      "Origin" header.
      (WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have
      been removed so that we don't leak them. Also tweaked a comment to make it clear that
      the URL check has issue when credential is involved.
      
      LayoutTests:
      
      Test that doing a cross-origin request with a preflight check does
      not raise a NETWORK_ERR exception and does not send the credentials.
      
      * http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Added.
      * http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Added.
      * http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Added.
      * http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Added.
      * http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Added.
      
      * platform/mac-tiger/Skipped:
      * platform/qt/Skipped:
      Added those 2 tests to the Skipped lists.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ace159f
  31. 22 Apr, 2010 1 commit
  32. 13 Apr, 2010 1 commit
  33. 25 Mar, 2010 1 commit
    • mitz@apple.com's avatar
      <rdar://problem/7728903> Support color bitmap fonts · 713cc9e3
      mitz@apple.com authored
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Test: platform/mac/fonts/color-bitmap.html
      
      * platform/graphics/mac/FontMac.mm:
      (WebCore::showGlyphsWithAdvances): Added. Calls CGContextShowGlyphsWithAdvances()
      or CTFontShowGlyphs() depending on whether the font is a color bitmap font.
      (WebCore::Font::drawGlyphs): Use showGlyphsWithAdvances(). Don’t include the font’s matrix in
      the context’s text matrix when drawing with a color bitmap font, because CTFontShowGlyphs()
      factors it in.
      * platform/graphics/mac/FontPlatformData.h:
      (WebCore::FontPlatformData::FontPlatformData): Added m_isColorBitmapFont member
      and initialized it in constructors.
      (WebCore::FontPlatformData::isColorBitmapFont): Added this getter.
      * platform/graphics/mac/FontPlatformDataMac.mm:
      (WebCore::FontPlatformData::FontPlatformData): Initialize m_isColorBitmapFont.
      (WebCore::FontPlatformData::operator=): Copy m_isColorBitmapFont.
      (WebCore::FontPlatformData::setFont): Set m_isColorBitmapFont.
      
      WebKitTools: 
      
      * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added ColorBits.ttf
      and ColorBits-A.png.
      * DumpRenderTree/fonts/ColorBits-A.png: Copied from WebCore/inspector/front-end/Images/successGreenDot.png.
      * DumpRenderTree/fonts/ColorBits.ttf: Added.
      * DumpRenderTree/mac/DumpRenderTree.mm:
      (activateFonts): Activate ColorBits.ttf.
      
      LayoutTests: 
      
      * platform/mac-leopard/Skipped:
      * platform/mac-snowleopard/Skipped:
      * platform/mac-tiger/Skipped:
      * platform/mac/fonts/color-bitmap-expected.checksum: Added.
      * platform/mac/fonts/color-bitmap-expected.png: Added.
      * platform/mac/fonts/color-bitmap-expected.txt: Added.
      * platform/mac/fonts/color-bitmap.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      713cc9e3