1. 12 Dec, 2010 2 commits
    • morrita@google.com's avatar
      2010-10-28 MORITA Hajime <morrita@google.com> · 7a18feed
      morrita@google.com authored
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              * editing/spelling/script-tests/spellcheck-paste.js: Added.
              * editing/spelling/spellcheck-paste.html: Added.
              * editing/spelling/spellcheck-paste-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/mac-leopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              - Introduced SpellChecker class to encapsulate asynchronous spell
                checker state: sequence id, requesting text and target node.
                This is also the first step to decompose spell-check related
                code to a separate class.
              - Added EditorClient::isAsynchronousSpellCheckingEnabled()
                to use async spellcheck API on the platform.
                These APIs are touched by SpellChecker.
              - Used SpellChecker to check a pasted test. Text to check is
                collected from the subtree under the editingRoot.
              - Added Setting::m_asynchronousSpellCheckingEnabled to control
                async spell checking.
      
              Test: editing/spelling/spellcheck-paste.html
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * dom/DocumentMarkerController.cpp:
              (WebCore::DocumentMarkerController::showMarkers):
              (showDocumentMarkers):
              * dom/DocumentMarkerController.h:
              * dom/PositionIterator.cpp:
              (WebCore::PositionIterator::setOffsetInLeafNode):
              * dom/PositionIterator.h:
              * editing/Editor.cpp:
              (WebCore::Editor::replaceSelectionWithFragment):
              (WebCore::Editor::Editor):
              (WebCore::findFirstMarkable):
              (WebCore::Editor::selectionStartHasSpellingMarkerFor):
              * editing/Editor.h:
              (WebCore::Editor::spellChecker):
              * editing/SpellChecker.cpp: Added.
              (WebCore::SpellChecker::SpellChecker):
              (WebCore::SpellChecker::~SpellChecker):
              (WebCore::SpellChecker::initRequest):
              (WebCore::SpellChecker::clearRequest):
              (WebCore::SpellChecker::isAsynchronousEnabled):
              (WebCore::SpellChecker::canCheckAsynchronously):
              (WebCore::SpellChecker::isBusy):
              (WebCore::SpellChecker::isValid):
              (WebCore::SpellChecker::isCheckable):
              (WebCore::SpellChecker::requestCheckingFor):
              (WebCore::forwardIterator):
              (WebCore::SpellChecker::didCheck):
              * editing/SpellChecker.h: Added.
              (WebCore::SpellCheckingResult::SpellCheckingResult):
              (WebCore::SpellCheckingResult::type):
              (WebCore::SpellCheckingResult::location):
              (WebCore::SpellCheckingResult::length):
              * loader/EmptyClients.h:
              (WebCore::EmptyEditorClient::requestCheckingOfString):
              * page/EditorClient.h:
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              * page/Settings.h:
              (WebCore::Settings::setAsynchronousSpellCheckingEnabled):
              (WebCore::Settings::asynchronousSpellCheckingEnabled):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * src/EditorClientImpl.h:
              (WebKit::EditorClientImpl::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientEfl.h:
              (WebCore::EditorClientEfl::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientGtk.h:
              (WebKit::EditorClient::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientHaiku.h:
              (WebCore::EditorClientHaiku::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added asynchronous spell checking API to WebEditorClient using
              -[NSSpellChecker requestCheckingOfString].
              Note that WebEditorSpellCheckResponder is a small class to receive
              requested spell-checking result. Note that this feature is
              disabled at default.
      
              Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
              enable the feature from LayoutTestController.
      
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
              (-[WebEditorSpellCheckResponder perform]):
              (toCoreSpellingResult):
              (-[WebEditorSpellCheckResponder WTF::WebCore::]):
              (WebEditorClient::requestCheckingOfString):
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]):
              (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
              (-[WebPreferences asynchronousSpellCheckingEnabled]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientQt.h:
              (WebCore::EditorClientQt::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/WebEditorClient.h:
              (WebEditorClient::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientWinCE.h:
              (WebKit::EditorClient::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebKitSupport/EditorClientWx.h:
              (WebCore::EditorClientWx::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebProcess/WebCoreSupport/WebEditorClient.cpp:
              (WebKit::WebEditorClient::requestCheckingOfString):
              * WebProcess/WebCoreSupport/WebEditorClient.h:
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
              to control the setting.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (setAsynchronousSpellCheckingEnabledCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a18feed
    • alex@webkit.org's avatar
      2010-12-12 Alejandro G. Castro <alex@igalia.com> · b39c90f7
      alex@webkit.org authored
              Unreviewed, skipping failing tests in the bots.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b39c90f7
  2. 11 Dec, 2010 5 commits
  3. 10 Dec, 2010 9 commits
    • alex@webkit.org's avatar
      2010-12-09 Alejandro G. Castro <alex@igalia.com> · 26df767f
      alex@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Add hasSpellingMarker support to the DRT
              https://bugs.webkit.org/show_bug.cgi?id=50739
      
              Added a new private API function to support the spelling marker
              tests in the DRT.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              (DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker):
              * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      
      2010-12-10  Alejandro G. Castro  <alex@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Add hasSpellingMarker support to the DRT
              https://bugs.webkit.org/show_bug.cgi?id=50739
      
              Implemented the hasSpellingMarker to support spelling tests.
      
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::hasSpellingMarker):
      
      2010-12-10  Alejandro G. Castro  <alex@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Add hasSpellingMarker support to the DRT
              https://bugs.webkit.org/show_bug.cgi?id=50739
      
              Unskipped spelling tests and added a bug for the one failing,
              added results for a new ones also.
      
              * platform/gtk/Skipped:
              * platform/gtk/editing/spelling/inline_spelling_markers-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26df767f
    • commit-queue@webkit.org's avatar
      2010-12-10 Joone Hur <joone@kldp.org> · 1e6a1849
      commit-queue@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
              https://bugs.webkit.org/show_bug.cgi?id=50808
      
              Unskipping the following test cases:
              userscripts/mixed-case-stylesheet.html
              userscripts/simple-stylesheet.html
              userscripts/user-style-all-frames.html
      
              * platform/gtk/Skipped:
      2010-12-10  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Gustavo Noronha Silva.
      
              Remove unnecessary variable names from DumpRenderTreeSupportGtk
              https://bugs.webkit.org/show_bug.cgi?id=50815
      
              There were some unnecessary variable names in DumpRenderTreeSupportGtk,
              so remove them.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.h: Do it.
      2010-12-10  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Ojan Vafai.
      
              webkit-patch: not possible to use build-and-test with local commits
              https://bugs.webkit.org/show_bug.cgi?id=33378
      
              Make --no-clean not even check if we have local commits.
              It's unclear to me why the code was originally written this way.
              I was unable to dig up a reason from svn history.
      
              * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
              * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e6a1849
    • mario@webkit.org's avatar
      2010-12-10 Mario Sanchez Prada <msanchez@igalia.com> · 8e07cd4f
      mario@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] AX: implement isEnabled in DRT
              https://bugs.webkit.org/show_bug.cgi?id=50814
      
              Unskip passing accessibility/aria-disabled.html test.
      
              * platform/gtk/Skipped: Unskip test.
      2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] AX: implement isEnabled in DRT
              https://bugs.webkit.org/show_bug.cgi?id=50814
      
              Implement AccessibilityUIElement::isEnabled() for GTK.
      
              * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
              (checkElementState): New function to refactor common code.
              (AccessibilityUIElement::isEnabled): Implement this by checking
              the current state of the AtkObject.
              (AccessibilityUIElement::isSelected): Use the new
              checkElementState function.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e07cd4f
    • ossy@webkit.org's avatar
      Unreviewed. Remove platform specific expected files after r73720. · c19e900e
      ossy@webkit.org authored
      * platform/gtk/fast/forms/ValidityState-patternMismatch-expected.txt: Removed.
      * platform/qt/fast/forms/ValidityState-patternMismatch-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c19e900e
    • mario@webkit.org's avatar
      2010-12-10 Mario Sanchez Prada <msanchez@igalia.com> · 7044b94e
      mario@webkit.org authored
              Unreviewed, unskip passing accessibility tests on GTK.
      
              * platform/gtk/Skipped: Unskip passing tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7044b94e
    • ossy@webkit.org's avatar
      Unreviewed. Add platform specific expected files after r73715. · a7c49d2b
      ossy@webkit.org authored
      * platform/gtk/fast/forms/ValidityState-patternMismatch-expected.txt: Added.
      * platform/qt/fast/forms/ValidityState-patternMismatch-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7c49d2b
    • commit-queue@webkit.org's avatar
      2010-12-10 Joone Hur <joone@kldp.org> · 1778ddbf
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
              https://bugs.webkit.org/show_bug.cgi?id=50783
      
              Unskip the following test cases:
              printing/page-rule-selection.html
              printing/page-format-data.html
              * platform/gtk/Skipped:
      2010-12-10  Joone Hur  <joone@kldp.org>
      
              Reviewed by Eric Seidel.
      
              [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
              https://bugs.webkit.org/show_bug.cgi?id=50783
      
              This patch allows to unskip the following test cases:
              printing/page-rule-selection.html
              printing/page-format-data.html
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              (DumpRenderTreeSupportGtk::pageProperty): Added.
              (DumpRenderTreeSupportGtk::isPageBoxVisible): Ditto.
              (DumpRenderTreeSupportGtk::pageSizeAndMarginsInPixels): Ditto.
              (DumpRenderTreeSupportGtk::addUserStyleSheet): Ditto.
              * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      2010-12-10  Joone Hur  <joone@kldp.org>
      
              Reviewed by Eric Seidel.
      
              [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
              https://bugs.webkit.org/show_bug.cgi?id=50783
      
              This patch allows to unskip the following test cases:
              printing/page-rule-selection.html
              printing/page-format-data.html
      
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::pageProperty): Added.
              (LayoutTestController::isPageBoxVisible): Ditto.
              (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
              (LayoutTestController::addUserStyleSheet): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1778ddbf
    • philn@webkit.org's avatar
      2010-12-10 Philippe Normand <pnormand@igalia.com> · 7a878367
      philn@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              [GStreamer] data: source could also support non-base64 encoded URIs
              https://bugs.webkit.org/show_bug.cgi?id=30007
      
              Removed our ancient implementation of dataurisrc. We should now
              use the one in gst-plugins-bad which is more mature.
      
              * GNUmakefile.am:
              * platform/graphics/gstreamer/DataSourceGStreamer.cpp: Removed.
              * platform/graphics/gstreamer/DataSourceGStreamer.h: Removed.
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::doGstInit):
      
      LayoutTests:
      
              Reviewed by Gustavo Noronha Silva.
      
              [GStreamer] data: source could also support non-base64 encoded URIs
              https://bugs.webkit.org/show_bug.cgi?id=30007
      
              * platform/gtk/Skipped: Unskipped media/audio-data-url.html. It
              should now be much more reliable on the bots running latest
              GStreamer versions.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a878367
    • mrobinson@webkit.org's avatar
      2010-12-10 Martin Robinson <mrobinson@igalia.com> · 7be215a5
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [Gtk] style="font-family: courier" makes text disappear
              https://bugs.webkit.org/show_bug.cgi?id=47452
      
              Added a GTK+ test for invalid fonts.
      
              * platform/gtk/fonts/font-with-no-valid-encoding-expected.checksum: Added.
              * platform/gtk/fonts/font-with-no-valid-encoding-expected.png: Added.
              * platform/gtk/fonts/font-with-no-valid-encoding-expected.txt: Added.
              * platform/gtk/fonts/font-with-no-valid-encoding.html: Added.
      2010-12-10  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [Gtk] style="font-family: courier" makes text disappear
              https://bugs.webkit.org/show_bug.cgi?id=47452
      
              Don't ever use fonts that do not have any of the three charmaps that
              Fontconfig supports (Unicode, Apple Roman and Symbol). If we select
              a font that doesn't have one of these charmaps, use the next font in
              the list.
      
              Test: platform/gtk/fonts/font-with-no-valid-encoding.html
      
              * platform/graphics/freetype/FontCacheFreeType.cpp:
              (WebCore::FontCache::createFontPlatformData): Check whether the
              font we selected has a valid Fontconfig charmap.
              * platform/graphics/freetype/FontPlatformData.h: Added new method definition.
              * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
              (WebCore::FontPlatformData::hasCompatibleCharmap): Added this method which
              verifies that a font has a valid Fontconfig charmap.
      2010-12-10  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [Gtk] style="font-family: courier" makes text disappear
              https://bugs.webkit.org/show_bug.cgi?id=47452
      
              Add a test that verifies that fonts without valid charmaps are
              never selected.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (initializeFonts): Initialize DRT with our font (derived from Ahem)
              that has no valid charmap.
              * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
              * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
              settings which may disable selection of bitmap fonts.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7be215a5
  4. 09 Dec, 2010 4 commits
    • philn@webkit.org's avatar
      2010-12-06 Philippe Normand <pnormand@igalia.com> · 9d37a571
      philn@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Support the Mozilla-style Fullscreen Javascript API
              https://bugs.webkit.org/show_bug.cgi?id=50572
      
              * configure.ac: new configure flag to disable the new Javascript
              Fullscreen API build. It is enabled by default.
      
      WebCore:
      
              Reviewed by Martin Robinson.
      
              [GTK] Support the Mozilla-style Fullscreen Javascript API
              https://bugs.webkit.org/show_bug.cgi?id=50572
      
              * GNUmakefile.am: enable the Javascript Fullscreen API feature if
              it's been requested at configure time.
      
      WebKit/gtk:
      
              Reviewed by Martin Robinson.
      
              [GTK] Support the Mozilla-style Fullscreen Javascript API
              https://bugs.webkit.org/show_bug.cgi?id=50572
      
              Fullscreen API support. It is controlled at runtime using a new
              setting called enable-fullscreen, set to FALSE by default.
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::supportsFullScreenForElement):
              (WebKit::ChromeClient::enterFullScreenForElement):
              (WebKit::ChromeClient::exitFullScreenForElement):
              * WebCoreSupport/ChromeClientGtk.h:
              * webkit/webkitwebsettings.cpp:
              (webkit_web_settings_class_init):
              (webkit_web_settings_set_property):
              (webkit_web_settings_get_property):
              (webkit_web_settings_copy):
              * webkit/webkitwebview.cpp:
              (webkit_web_view_update_settings):
      
      WebKitTools:
      
              Reviewed by Martin Robinson.
      
              [GTK] Support the Mozilla-style Fullscreen Javascript API
              https://bugs.webkit.org/show_bug.cgi?id=50572
      
              Enable the Javascript Fullscreen support in the GtkLauncher. Also
              make DRT update the Chrome when the WebView settings have been
              reset to consistent values.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (resetDefaultsToConsistentValues):
              * GtkLauncher/main.c:
              (create_window):
              * Scripts/build-webkit:
      
      LayoutTests:
      
              Reviewed by Martin Robinson.
      
              [GTK] Support the Mozilla-style Fullscreen Javascript API
              https://bugs.webkit.org/show_bug.cgi?id=50572
      
              * platform/gtk/Skipped: Unskip now passing fullscreen tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d37a571
    • commit-queue@webkit.org's avatar
      2010-12-09 Joone Hur <joone@kldp.org> · 7a9a1855
      commit-queue@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Support for viewport meta tag
              https://bugs.webkit.org/show_bug.cgi?id=45443
      
              Included viewport test cases for WebKitGtk
      
              * platform/gtk/Skipped: Unskip fast/viewport except viewport-45.html.
      2010-12-09  Joone Hur  <joone@kldp.org>
      
              Reviewed by Martin Robinson.
      
              [GTK] Support for viewport meta tag
              https://bugs.webkit.org/show_bug.cgi?id=45443
      
              This patch adds a new gobject to offer the viewport properties to user agents.
              It is WebKitViewportAttributes that contains the viewport size, initial scale with limits,
              and information about whether a user is able to scale the contents in the viewport.
      
              This feature was introduced by Safari on the iPhone. For more information on
              the viewport properties, refer to the Safari reference library at
              http://developer.apple.com/safari/library/documentation/appleapplications/reference/safarihtmlref/articles/metatags.html
      
              * GNUmakefile.am: Added webkitviewportattributes.h webkitviewportattributes.cpp.
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::dispatchViewportDataDidChange): Added this callback to know whether the viewport arguments is available.
              * WebCoreSupport/ChromeClientGtk.h:
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): Added this function to compute the viewport attributes with the given availableWidth and availableHeight.
              * WebCoreSupport/DumpRenderTreeSupportGtk.h:
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::postCommitFrameViewSetup): Invalidate the viewport attributes.
              * webkit/webkit.h:
              * webkit/webkitdefines.h:
              * webkit/webkitprivate.h: Added webkitViewportAttributesRecompute as a private function.
              * webkit/webkitviewportattributes.cpp: Added.
              (webkit_viewport_attributes_class_init):
              (webkit_viewport_attributes_init):
              (webkit_viewport_attributes_get_property):
              (webkit_viewport_attributes_set_property):
              (webkitViewportAttributesRecompute): Recompute the optimal viewport attributes and emit the viewport-attributes-changed signal.
              (webkit_viewport_attributes_recompute): a public API for calling webkitViewportAttributesRecompute.
              * webkit/webkitviewportattributes.h: Added.
              * webkit/webkitwebview.cpp:
              (webkit_web_view_get_property): Added PROP_VIEWPORT_ATTRIBUTES.
              (webkit_web_view_dispose): Deallocate the WebKitViewportAttributes instance.
              (webkit_web_view_class_init): Added the viewport-attributes-recompute-requested and viewport-attributes-changed signals.
              (webkit_web_view_init): Set the WebKitViewportAttributes instance.
              (webkit_web_view_get_viewport_attributes): Added a getter to obtain the WebKitViewportAttributes instance held by the given WebKitWebView.
              * webkit/webkitwebview.h:
              * webkit/webkitwebviewprivate.h: Added WebKitViewportAttributes as a private variable.
      2010-12-09  Joone Hur  <joone@kldp.org>
      
               Reviewed by Martin Robinson.
      
               [GTK] Support for viewport meta tag
               https://bugs.webkit.org/show_bug.cgi?id=45443
      
               Add support for testing the viewport properties for WebKitGtk.
      
               * DumpRenderTree/LayoutTestController.cpp:
               (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
               (LayoutTestController::staticFunctions):
               * DumpRenderTree/LayoutTestController.h:
               * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
               (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
               * DumpRenderTree/mac/LayoutTestControllerMac.mm:
               (LayoutTestController::dumpConfigurationForViewport): Ditto.
               * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
               (LayoutTestController::dumpConfigurationForViewport): Ditto.
               * DumpRenderTree/win/LayoutTestControllerWin.cpp:
               (LayoutTestController::dumpConfigurationForViewport): Ditto.
               * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
               (LayoutTestController::dumpConfigurationForViewport): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a9a1855
    • mrobinson@webkit.org's avatar
      2010-12-09 Martin Robinson <mrobinson@igalia.com> · 7489e34d
      mrobinson@webkit.org authored
              Update GTK+ baselines after r73561.
      
              * platform/gtk/fast/css/input-search-padding-expected.txt:
              * platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
              * platform/gtk/fast/forms/box-shadow-override-expected.txt:
              * platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
              * platform/gtk/fast/forms/input-appearance-height-expected.txt:
              * platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
              * platform/gtk/fast/forms/placeholder-set-value-expected.txt:
              * platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
              * platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
              * platform/gtk/fast/forms/search-rtl-expected.txt:
              * platform/gtk/fast/forms/search-styled-expected.txt:
              * platform/gtk/fast/forms/search-transformed-expected.txt:
              * platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
              * platform/gtk/fast/forms/search-zoomed-expected.txt:
              * platform/gtk/fast/forms/searchfield-heights-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7489e34d
    • philn@webkit.org's avatar
      2010-12-09 Philippe Normand <pnormand@igalia.com> · bc083c76
      philn@webkit.org authored
              Unreviewed, update test baselines as asked by MORITA Hajime.
      
              [GTK] r73488 broke fast/dom/HTMLProgressElement/progress-element.html
              https://bugs.webkit.org/show_bug.cgi?id=50687
      
              * platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc083c76
  5. 08 Dec, 2010 10 commits
  6. 07 Dec, 2010 2 commits
    • dbates@webkit.org's avatar
      2010-12-07 Daniel Bates <dbates@rim.com> · 9473601e
      dbates@webkit.org authored
              Reviewed by Martin Robinson.
      
              Implement focus ring support for image maps
              https://bugs.webkit.org/show_bug.cgi?id=50371
      
              Implement GraphicsContext::drawFocusRing(const Path&, ...) so as to support
              drawing a focus ring for image maps.
      
              Tests: fast/images/imagemap-circle-focus-ring.html
                     fast/images/imagemap-polygon-focus-ring.html
      
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              (WebCore::adjustFocusRingColor): Added.
              (WebCore::adjustFocusRingLineWidth): Added.
              (WebCore::focusRingStrokeStyle): Added.
              (WebCore::GraphicsContext::drawFocusRing): Moved code for determining focus ring- color,
              line width and stroke style into functions adjustFocusRingColor(), adjustFocusRingLineWidth(),
              and focusRingStrokeStyle(), respectively. Implemented GraphicsContext::drawFocusRing(const Path&, ...).
      2010-12-07  Daniel Bates  <dbates@rim.com>
      
              Reviewed by Martin Robinson.
      
              Implement focus ring support for image maps
              https://bugs.webkit.org/show_bug.cgi?id=50371
      
              Tests to ensure that we support drawing a focus ring for an image map.
              In particular, that the GTK port can draw a focus ring for an image map.
      
              * fast/images/imagemap-circle-focus-ring.html: Added.
              * fast/images/imagemap-polygon-focus-ring.html: Added.
              * platform/gtk/fast/images/imagemap-circle-focus-ring-expected.checksum: Added.
              * platform/gtk/fast/images/imagemap-circle-focus-ring-expected.png: Added.
              * platform/gtk/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
              * platform/gtk/fast/images/imagemap-focus-ring-expected.checksum: Rebase result since we 
              now support drawing a focus ring for imagemaps.
              * platform/gtk/fast/images/imagemap-focus-ring-expected.png: Ditto.
              * platform/gtk/fast/images/imagemap-focus-ring-outline-color-expected.checksum: Added.
              * platform/gtk/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
              * platform/gtk/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.checksum: Added.
              * platform/gtk/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
              * platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
              * platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
              * platform/gtk/fast/images/imagemap-polygon-focus-ring-expected.checksum: Added.
              * platform/gtk/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
              * platform/gtk/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
              * platform/mac/fast/images/imagemap-circle-focus-ring-expected.checksum: Added.
              * platform/mac/fast/images/imagemap-circle-focus-ring-expected.png: Added.
              * platform/mac/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
              * platform/mac/fast/images/imagemap-polygon-focus-ring-expected.checksum: Added.
              * platform/mac/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
              * platform/mac/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9473601e
    • mrobinson@webkit.org's avatar
      2010-12-07 Martin Robinson <mrobinson@igalia.com> · bf9e286d
      mrobinson@webkit.org authored
              Rebaseline GTK+ results after r73385.
      
              * platform/gtk/css1/box_properties/margin-expected.txt:
              * platform/gtk/css1/box_properties/margin_right-expected.txt:
              * platform/gtk/css1/classification/white_space-expected.txt:
              * platform/gtk/css1/color_and_background/background_attachment-expected.txt:
              * platform/gtk/css1/color_and_background/background_repeat-expected.txt:
              * platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
              * platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
              * platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
              * platform/gtk/fast/backgrounds/size/backgroundSize15-expected.txt:
              * platform/gtk/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
              * platform/gtk/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
              * platform/gtk/fast/blockflow/block-level-images-expected.txt:
              * platform/gtk/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
              * platform/gtk/fast/blockflow/box-shadow-vertical-lr-expected.txt:
              * platform/gtk/fast/blockflow/box-shadow-vertical-rl-expected.txt:
              * platform/gtk/fast/blockflow/floats-in-block-layout-expected.txt:
              * platform/gtk/fast/borders/fieldsetBorderRadius-expected.txt:
              * platform/gtk/fast/box-shadow/basic-shadows-expected.txt:
              * platform/gtk/fast/css/negative-leading-expected.txt:
              * platform/gtk/fast/forms/basic-textareas-expected.txt:
              * platform/gtk/fast/forms/file-input-direction-expected.txt:
              * platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
              * platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
              * platform/gtk/fast/frames/flattening/frameset-flattening-grid-expected.txt:
              * platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.txt:
              * platform/gtk/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
              * platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
              * platform/gtk/fast/frames/frame-scrolling-attribute-expected.txt:
              * platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt:
              * platform/gtk/fast/frames/inline-object-inside-frameset-expected.txt:
              * platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
              * platform/gtk/fast/images/gif-large-checkerboard-expected.txt:
              * platform/gtk/fast/lists/001-vertical-expected.txt:
              * platform/gtk/fast/lists/003-vertical-expected.txt:
              * platform/gtk/fast/multicol/float-multicol-expected.txt:
              * platform/gtk/fast/multicol/float-paginate-complex-expected.txt:
              * platform/gtk/fast/multicol/float-paginate-expected.txt:
              * platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
              * platform/gtk/fast/multicol/paginate-block-replaced-expected.txt:
              * platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt:
              * platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt:
              * platform/gtk/fast/multicol/table-vertical-align-expected.txt:
              * platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:
              * platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
              * platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
              * platform/gtk/fast/table/height-percent-test-vertical-expected.txt:
              * platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
              * platform/gtk/svg/custom/text-xy-updates-SVGList-expected.txt:
              * platform/gtk/svg/custom/text-zoom-expected.txt:
              * platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
              * platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt:
              * platform/gtk/transforms/svg-vs-css-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf9e286d
  7. 04 Dec, 2010 4 commits
  8. 03 Dec, 2010 3 commits
    • mrobinson@webkit.org's avatar
      2010-12-03 Martin Robinson <mrobinson@igalia.com> · ecd086e8
      mrobinson@webkit.org authored
              Add a platform-specific baseline for GTK+ after r73128. This test
              just click at a predetermined location in the middle of the text field.
              Since GTK+ font sizes differ from other ports, the text selected differs.
      
              * platform/gtk/fast/forms/onselect-textarea-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecd086e8
    • philn@webkit.org's avatar
      2010-12-02 Philippe Normand <pnormand@igalia.com> · 5615320f
      philn@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GStreamer] hasVideo/Audio return false until the pipeline reaches PAUSED
              https://bugs.webkit.org/show_bug.cgi?id=50382
      
              Go to PAUSED even if preload is deactivated. In that case don't
              process the GStreamer state changes until commitLoad() has been
              called. This patch also fixes hasVideo and hasAudio methods,
              making them reactive to the playbin2 audio/video tags-changed
              signals.
      
              Test: media/controls-without-preload.html
      
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::mediaPlayerPrivateMessageCallback):
              (WebCore::mediaPlayerPrivateVideoTagsChangedCallback):
              (WebCore::mediaPlayerPrivateAudioTagsChangedCallback):
              (WebCore::mediaPlayerPrivateAudioTagsChangeTimeoutCallback):
              (WebCore::mediaPlayerPrivateVideoTagsChangeTimeoutCallback):
              (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
              (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
              (WebCore::MediaPlayerPrivateGStreamer::load):
              (WebCore::MediaPlayerPrivateGStreamer::commitLoad):
              (WebCore::MediaPlayerPrivateGStreamer::videoTagsChanged):
              (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideoTags):
              (WebCore::MediaPlayerPrivateGStreamer::audioTagsChanged):
              (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudioTags):
              (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
              (WebCore::MediaPlayerPrivateGStreamer::hasVideo):
              (WebCore::MediaPlayerPrivateGStreamer::hasAudio):
              (WebCore::MediaPlayerPrivateGStreamer::loadDelayed):
      
      LayoutTests:
      
              Reviewed by Martin Robinson.
      
              hasVideo/hasAudio reimplementations
      
              [GStreamer] hasVideo/Audio return false until the pipeline reaches PAUSED
              https://bugs.webkit.org/show_bug.cgi?id=50382
      
              * media/controls-without-preload.html: Added.
              * platform/gtk/media/controls-without-preload-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5615320f
    • philn@webkit.org's avatar
      2010-12-03 Philippe Normand <pnormand@igalia.com> · aef14dd2
      philn@webkit.org authored
              Unreviewed, skipping failing media test on GTK.
      
              * platform/gtk/Skipped: Skip media/controls-drag-timebar.html
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aef14dd2
  9. 02 Dec, 2010 1 commit
    • jnd@chromium.org's avatar
      2010-12-02 Johnny Ding <jnd@chromium.org> · ae563165
      jnd@chromium.org authored
              Reviewed by Adam Barth.
      
              Set the right gesture status for URL redirections.
              https://bugs.webkit.org/show_bug.cgi?id=47817
      
              * fast/frames/location-redirect-user-gesture-expected.txt: Added.
              * fast/frames/location-redirect-user-gesture.html: Added.
              * fast/frames/meta-refresh-user-gesture-expected.txt: Added.
              * fast/frames/meta-refresh-user-gesture.html: Added.
              * fast/frames/resources/meta-refresh-target.html: Added.
              * platform/gtk/Skipped:
              * platform/win/Skipped:
      2010-12-02  Johnny Ding  <jnd@chromium.org>
      
              Reviewed by Adam Barth.
      
              Set the right gesture status for URL redirections.
              https://bugs.webkit.org/show_bug.cgi?id=47817
      
              Tests: fast/frames/location-redirect-user-gesture.html
                     fast/frames/meta-refresh-user-gesture.html
      
              * loader/NavigationScheduler.cpp:
              (WebCore::ScheduledNavigation::clearUserGesture):
              (WebCore::ScheduledRedirect::ScheduledRedirect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae563165