Skip to content

GitLab

W
webkit
Switch branch/tag
  1. 12 Dec, 2010 19 commits
    • morrita@google.com's avatar
      2010-10-28 MORITA Hajime <morrita@google.com> · 7a18feed
      morrita@google.com authored 
              Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        * editing/spelling/script-tests/spellcheck-paste.js: Added.
        * editing/spelling/spellcheck-paste.html: Added.
        * editing/spelling/spellcheck-paste-expected.txt: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac-leopard/Skipped:
        * platform/mac-tiger/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        - Introduced SpellChecker class to encapsulate asynchronous spell
          checker state: sequence id, requesting text and target node.
          This is also the first step to decompose spell-check related
          code to a separate class.
        - Added EditorClient::isAsynchronousSpellCheckingEnabled()
          to use async spellcheck API on the platform.
          These APIs are touched by SpellChecker.
        - Used SpellChecker to check a pasted test. Text to check is
          collected from the subtree under the editingRoot.
        - Added Setting::m_asynchronousSpellCheckingEnabled to control
          async spell checking.

        Test: editing/spelling/spellcheck-paste.html

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/DocumentMarkerController.cpp:
        (WebCore::DocumentMarkerController::showMarkers):
        (showDocumentMarkers):
        * dom/DocumentMarkerController.h:
        * dom/PositionIterator.cpp:
        (WebCore::PositionIterator::setOffsetInLeafNode):
        * dom/PositionIterator.h:
        * editing/Editor.cpp:
        (WebCore::Editor::replaceSelectionWithFragment):
        (WebCore::Editor::Editor):
        (WebCore::findFirstMarkable):
        (WebCore::Editor::selectionStartHasSpellingMarkerFor):
        * editing/Editor.h:
        (WebCore::Editor::spellChecker):
        * editing/SpellChecker.cpp: Added.
        (WebCore::SpellChecker::SpellChecker):
        (WebCore::SpellChecker::~SpellChecker):
        (WebCore::SpellChecker::initRequest):
        (WebCore::SpellChecker::clearRequest):
        (WebCore::SpellChecker::isAsynchronousEnabled):
        (WebCore::SpellChecker::canCheckAsynchronously):
        (WebCore::SpellChecker::isBusy):
        (WebCore::SpellChecker::isValid):
        (WebCore::SpellChecker::isCheckable):
        (WebCore::SpellChecker::requestCheckingFor):
        (WebCore::forwardIterator):
        (WebCore::SpellChecker::didCheck):
        * editing/SpellChecker.h: Added.
        (WebCore::SpellCheckingResult::SpellCheckingResult):
        (WebCore::SpellCheckingResult::type):
        (WebCore::SpellCheckingResult::location):
        (WebCore::SpellCheckingResult::length):
        * loader/EmptyClients.h:
        (WebCore::EmptyEditorClient::requestCheckingOfString):
        * page/EditorClient.h:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
        (WebCore::Settings::setAsynchronousSpellCheckingEnabled):
        (WebCore::Settings::asynchronousSpellCheckingEnabled):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * src/EditorClientImpl.h:
        (WebKit::EditorClientImpl::requestCheckingOfString):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * WebCoreSupport/EditorClientEfl.h:
        (WebCore::EditorClientEfl::requestCheckingOfString):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * WebCoreSupport/EditorClientGtk.h:
        (WebKit::EditorClient::requestCheckingOfString):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * WebCoreSupport/EditorClientHaiku.h:
        (WebCore::EditorClientHaiku::requestCheckingOfString):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added asynchronous spell checking API to WebEditorClient using
        -[NSSpellChecker requestCheckingOfString].
        Note that WebEditorSpellCheckResponder is a small class to receive
        requested spell-checking result. Note that this feature is
        disabled at default.

        Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
        enable the feature from LayoutTestController.

        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
        (-[WebEditorSpellCheckResponder perform]):
        (toCoreSpellingResult):
        (-[WebEditorSpellCheckResponder WTF::WebCore::]):
        (WebEditorClient::requestCheckingOfString):
        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
        (-[WebPreferences asynchronousSpellCheckingEnabled]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * WebCoreSupport/EditorClientQt.h:
        (WebCore::EditorClientQt::requestCheckingOfString):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * WebCoreSupport/WebEditorClient.h:
        (WebEditorClient::requestCheckingOfString):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * WebCoreSupport/EditorClientWinCE.h:
        (WebKit::EditorClient::requestCheckingOfString):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * WebKitSupport/EditorClientWx.h:
        (WebCore::EditorClientWx::requestCheckingOfString):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        (WebKit::WebEditorClient::requestCheckingOfString):
        * WebProcess/WebCoreSupport/WebEditorClient.h:
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
        to control the setting.

        * DumpRenderTree/LayoutTestController.cpp:
        (setAsynchronousSpellCheckingEnabledCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::setAsynchronousSpellCheckingEnabled):
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setAsynchronousSpellCheckingEnabled):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setAsynchronousSpellCheckingEnabled):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setAsynchronousSpellCheckingEnabled):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setAsynchronousSpellCheckingEnabled):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::setAsynchronousSpellCheckingEnabled):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a18feed
    • tonikitoo@webkit.org's avatar
      2010-12-09 Antonio Gomes <agomes@rim.com> · 237c1ea4
      tonikitoo@webkit.org authored 
              Reviewed by Daniel Bates.

        Spatial Navigation: code clean up (part II)
        https://bugs.webkit.org/show_bug.cgi?id=50666

        No new tests needed.

        * page/FocusController.cpp: Removed static declaration of updateFocusCandidateIfNeeded() from
        the top of FocusController.cpp, and added the 'static' keyword where the function is implemented;
        * page/SpatialNavigation.cpp: In FocusCandidate constructor, renamed 'n' to 'node', and added an assert to it;
        (WebCore::FocusCandidate::FocusCandidate):
        (WebCore::virtualRectForAreaElementAndDirection): Added an assert to 'node';
        * page/SpatialNavigation.h:I reordered the declaration of some methods in order to group related ones;
        Removed isScrollableContainerNode() function declaration since it is not used outside SpatialNavigation.cpp;
        And removed the declaration of isNodeDeepDescendantOfDocument() since it does not exist anymore.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      237c1ea4
    • bweinstein@apple.com's avatar
      WebKit2: Implement WebInspector::localizedStringsURL on Windows · b0a37b0b
      bweinstein@apple.com authored 
      https://bugs.webkit.org/show_bug.cgi?id=50896
        
Reviewed by Tim Hatcher.

Find the localized strings file using CFBundleCopyResourceURL.

* WebProcess/WebPage/win/WebInspectorWin.cpp:
(WebKit::WebInspector::localizedStringsURL):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0a37b0b
    • weinig@apple.com's avatar
      Update WebKit2 skipped list. · 42b320f2
      weinig@apple.com authored 
      * platform/mac-wk2/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42b320f2
    • weinig@apple.com's avatar
      Give LogTextInput a sensible flag value. · 86a4c695
      weinig@apple.com authored 
      Reviewed by Anders Carlsson.

* Platform/Logging.cpp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86a4c695
    • weinig@apple.com's avatar
      Add missing bugzilla URL. · d397848a
      weinig@apple.com authored 
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d397848a
    • weinig@apple.com's avatar
      Fix failing API test. It turns out that a pop-state event · c52050f8
      weinig@apple.com authored 
      is sent before every fragment navigation, so we have to test
for it in addition in PageLoadDidChangeLocationWithinPageForFrame.

Reviewed by Anders Carlsson.

* TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
(TestWebKitAPI::didSameDocumentNavigationForFrame):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c52050f8
    • weinig@apple.com's avatar
      Remove incorrect assertion that has been firing in the API tester. · a9eb6221
      weinig@apple.com authored 
      Reviewed by Anders Carlsson.

* UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::~WebDatabaseManagerProxy):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9eb6221
    • weinig@apple.com's avatar
      Disable WebKit2 logging by default. · 6db0fa3a
      weinig@apple.com authored 
      Reviewed by Anders Carlsson.

* Platform/Logging.cpp:
(initializeLogChannelsIfNecessary):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6db0fa3a
    • bweinstein@apple.com's avatar
      Web Inspector: Make inspector on Windows show and be usable in WebKit2 · 67a46dba
      bweinstein@apple.com authored 
      https://bugs.webkit.org/show_bug.cgi?id=50877
        
Reviewed by Sam Weinig.

Hook up the unimplemented methods in WebInspectorProxyWin to get the web inspector
showing and usable in WebKit2 on Windows.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::WebInspectorProxy): Initialize Windows-specific variables to 0.
* UIProcess/WebInspectorProxy.h:
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::registerInspectorViewWindowClass): Sets up the inspector view class.
(WebKit::WebInspectorProxy::InspectorViewWndProc): Calls through to the WebInspectorProxy's non-static
    WndProc.
(WebKit::WebInspectorProxy::wndProc): Handles WM_SIZE, WM_CLOSE, and WM_GETMINMAXINFO, the rest go to 
    ::DefWindowProc.
(WebKit::WebInspectorProxy::onSizeEvent): Resize the WKView that has the inspector page to match the
    outer window that was just resized.
(WebKit::WebInspectorProxy::onMinMaxInfoEvent): Set the minimum size the window can be resized to.
(WebKit::WebInspectorProxy::onCloseEvent): Hide the window, and call WebInspectorProxy::close.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create a WKView and return its page.
(WebKit::WebInspectorProxy::platformOpen): Create an HWND for the inspector, put the inspector's WKView
    inside of it, and show the window.
(WebKit::WebInspectorProxy::platformClose): Destroy the inspector's window (which destroys the child WKView), 
    and 0 out instance variables.
(WebKit::WebInspectorProxy::inspectorPageURL): Finds inspector/inspector.html in the WebKit bundle.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67a46dba
    • kbalazs@webkit.org's avatar
      [Qt][WK2] Crash in WebPage constructor. · 04da2a5b
      kbalazs@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=50892

Reviewed by Andreas Kling.

* WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
Disable runtime enabled features that have no WebKit2 implementation yet.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04da2a5b
    • xan@webkit.org's avatar
      2010-12-12 Xan Lopez <xlopez@igalia.com> · 2ed84233
      xan@webkit.org authored 
              Rubber-stamped by Martin Robinson.

        * webkit/webkitwebplugin.h: add a note about the extension list
        being a NULL-terminated array.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ed84233
    • xan@webkit.org's avatar
      2010-12-12 Xan Lopez <xlopez@igalia.com> · 6933f0b2
      xan@webkit.org authored 
              Rubber-stamped by Gustavo Noronha.

        Stop checking for glib >= 2.16, we have dependend on a newer
        version for a long time now.

        * tests/testatk.c: Stop checking for glib >= 2.16.
        * tests/testatkroles.c: ditto.
        * tests/testdomdocument.c: ditto.
        * tests/testdomdomwindow.c: ditto.
        * tests/testdomnode.c: ditto.
        * tests/testglobals.c: ditto.
        * tests/testhttpbackend.c: ditto.
        * tests/testloading.c: ditto.
        * tests/testmimehandling.c: ditto.
        * tests/testnetworkrequest.c: ditto.
        * tests/testnetworkresponse.c: ditto.
        * tests/testwebbackforwardlist.c: ditto.
        * tests/testwebdatasource.c: ditto.
        * tests/testwebframe.c: ditto.
        * tests/testwebhistoryitem.c: ditto.
        * tests/testwebresource.c: ditto.
        * tests/testwebsettings.c: ditto.
        * tests/testwebview.c: ditto.
        * tests/testwindow.c: ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6933f0b2
    • commit-queue@webkit.org's avatar
      2010-12-12 Alejandro G. Castro <alex@igalia.com> · 11c4da89
      commit-queue@webkit.org authored 
              Reviewed by Eric Seidel.

        [GTK] Add new-run-webkit-tests support to gtk
        https://bugs.webkit.org/show_bug.cgi?id=50681

        Adding the basic support to run the new-run-webkit-tests.

        * Scripts/webkitpy/layout_tests/port/gtk.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11c4da89
    • philn@webkit.org's avatar
      2010-12-12 Philippe Normand <pnormand@igalia.com> · 1927b01a
      philn@webkit.org authored 
              Reviewed by Xan Lopez.

        build-webkit --gtk --minimal fails
        https://bugs.webkit.org/show_bug.cgi?id=46267

        No new tests, build fix only.

        * GNUmakefile.am: Include some JS bindings generated headers in
        the build even if their corresponding feature is disabled. They
        are needed to make the DOM bindings build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1927b01a
    • alex@webkit.org's avatar
      2010-12-12 Alejandro G. Castro <alex@igalia.com> · b39c90f7
      alex@webkit.org authored 
              Unreviewed, skipping failing tests in the bots.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b39c90f7
    • commit-queue@webkit.org's avatar
      2010-12-12 Sam Magnuson <smagnuso@gmail.com> · 6bb27075
      commit-queue@webkit.org authored 
              Reviewed by Eric Seidel.

        [Qt] Compile with QT_NO_QUUID_STRING.
        https://bugs.webkit.org/show_bug.cgi?id=49745

        * platform/UUID.cpp:
        (WebCore::createCanonicalUUIDString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bb27075
    • commit-queue@webkit.org's avatar
      2010-12-12 Ragner Magalhaes <ragner.magalhaes@openbossa.org> · 50f82858
      commit-queue@webkit.org authored 
              Reviewed by Eric Seidel.

        [Qt] Missing style for date pickers on Qt Mobile theme
        https://bugs.webkit.org/show_bug.cgi?id=50628

        * css/themeQtMobile.css:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50f82858
    • alice.liu@apple.com's avatar
      Mac build fix. · cbdcddca
      alice.liu@apple.com authored 
      * platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):
Resolve string[0] ambiguity by passing 0U.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbdcddca
  3. 11 Dec, 2010 21 commits