1. 30 Apr, 2009 40 commits
    • bdakin@apple.com's avatar
      2009-04-30 Beth Dakin <bdakin@apple.com> · 793ea993
      bdakin@apple.com authored
              Reviewed by Oliver Hunt.
      
              Fix for <rdar://problem/6841106> REGRESSION: Crash drag selecting 
              To Do's in a Mail note (excessive recursion in mouse drag tracking)
      
              Oliver's recent change to dragging seems to have revealed a long-
              time bug in passSubframeEventToSubframe where we did not set 
              m_sendingEventToSubview to true before calling 
              handleMouseMoveEvent() in the NSMouseMoved case. This patch fixes 
              that and adds ASSERTions around all of the places where 
              m_sendingEventToSubview is set to true and then false to make sure 
              we are not trampling its state.
      
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::eventLoopHandleMouseDragged):
              (WebCore::EventHandler::eventLoopHandleMouseUp):
              (WebCore::EventHandler::passSubframeEventToSubframe):
              (WebCore::EventHandler::passWheelEventToWidget):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      793ea993
    • barraclough@apple.com's avatar
      JavaScriptCore: · 33fd41d8
      barraclough@apple.com authored
      2009-04-30  Gavin Barraclough  <barraclough@apple.com>
      
              Reviewed by Geoff Garen.
      
              Bug fix for rdar:/68455379.  If a case-insensitive regex contains
              a character class containing a range with an upper bound of \uFFFF
              the parser will infinite-loop whist adding other-case characters
              for characters in the range that do have another case.
      
              * yarr/RegexCompiler.cpp:
              (JSC::Yarr::CharacterClassConstructor::putRange):
      
      LayoutTests:
      
      2009-04-30  Gavin Barraclough  <barraclough@apple.com>
      
              Reviewed by Geoff Garen.
      
              Add layout test for rdar:/68455379.
      
              * fast/js/regexp-range-bound-ffff-expected.txt: Added.
              * fast/js/regexp-range-bound-ffff.html: Added.
              * fast/js/resources/regexp-range-bound-ffff.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33fd41d8
    • eric.carlson@apple.com's avatar
      2009-04-30 Eric Carlson <eric.carlson@apple.com> · 040cbce0
      eric.carlson@apple.com authored
              Reviewed by Simon Fraser.
              
              MediaDocument falls back to plug-in unnecessarily
              https://bugs.webkit.org/show_bug.cgi?id=25504
              <rdar://problem/6844702>
              
              Don't allow harmless media types to cause a MediaDocument to fall
              back to PluginDocument.
      
              Test: media/video-document-types.html
      
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::disableUnsupportedTracks): add timecode, timecode 64,
              odsm, and sdsm to allowed track types.
      
              * platform/graphics/win/QTMovieWin.cpp:
              (QTMovieWin::disableUnsupportedTracks): Ditto.
      
      2009-04-30  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Simon Fraser.
      
              MediaDocument falls back to plug-in unnecessarily
              https://bugs.webkit.org/show_bug.cgi?id=25504
              <rdar://problem/6844702>
      
              Test case for MediaDocument with previously unsupported track
              types. Disabled on Windows for now until https://bugs.webkit.org/show_bug.cgi?id=25220
              has been fixed.
          
              * media/content/counting.mp4: Added.
              * media/video-document-types-expected.txt: Added.
              * media/video-document-types.html: Added.
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      040cbce0
    • kevino@webkit.org's avatar
    • mrowe@apple.com's avatar
      Roll out r43106 as it introduced four regression test failures. · 0e71664c
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e71664c
    • darin@apple.com's avatar
      WebCore: · 12f9bb8b
      darin@apple.com authored
      2009-04-30  Darin Adler  <darin@apple.com>
      
              Reviewed by Brady Eidson.
      
              Bug 25491: WebFrame leak when a subframe removes itself
              https://bugs.webkit.org/show_bug.cgi?id=25491
              rdar://problem/6833859
      
              Test: fast/loading/subframe-removes-itself.html
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::checkLoadCompleteForThisFrame): When isStopping is true,
              treat load as complete, even if isLoadingInAPISense is still returning true.
      
      LayoutTests:
      
      2009-04-30  Darin Adler  <darin@apple.com>
      
              Reviewed by Brady Eidson.
      
              Bug 25491: WebFrame leak when a subframe removes itself
              https://bugs.webkit.org/show_bug.cgi?id=25491
              rdar://problem/6833859
      
              * fast/loading: Added.
              * fast/loading/resources: Added.
              * fast/loading/resources/subframe-that-removes-itself.html: Added.
              * fast/loading/subframe-removes-itself-expected.txt: Added.
              * fast/loading/subframe-removes-itself.html: Added.
      
              * platform/gtk/Skipped: Skip loading tests.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12f9bb8b
    • barraclough@apple.com's avatar
      2009-04-30 Gavin Barraclough <barraclough@apple.com> · 2945305f
      barraclough@apple.com authored
              Reviewed by Oliver Hunt.
      
              OPCODE_SAMPLING without CODEBLOCK_SAMPLING is currently broken,
              since SamplingTool::Sample::isNull() checks the m_codeBlock
              member (which is always null without CODEBLOCK_SAMPLING).
      
              Restructure the checks so make this work again.
      
              * bytecode/SamplingTool.cpp:
              (JSC::SamplingTool::doRun):
              * bytecode/SamplingTool.h:
              (JSC::SamplingTool::Sample::isNull):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2945305f
    • mjs@apple.com's avatar
      2009-04-30 Maciej Stachowiak <mjs@apple.com> · db5e0319
      mjs@apple.com authored
              Reviewed by Gavin Barraclough.
      
              - Concatenate final three strings in simple replace case at one go
      
              ~0.2% SunSpider speedup
      
              * runtime/StringPrototype.cpp:
              (JSC::stringProtoFuncReplace): Use new replaceRange helper instead of
              taking substrings and concatenating three strings.
              * runtime/UString.cpp:
              (JSC::UString::replaceRange): New helper function.
              * runtime/UString.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db5e0319
    • ggaren@apple.com's avatar
      2009-04-30 Geoffrey Garen <ggaren@apple.com> · 5368abca
      ggaren@apple.com authored
              Rubber Stamped by Gavin Barraclough.
              
              Changed JSValueEncodedAsPtr* => EncodedJSValuePtr to support a non-pointer
              encoding for JSValuePtrs.
      
              * API/APICast.h:
              (toJS):
              * bytecompiler/BytecodeGenerator.h:
              (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue):
              (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
              * interpreter/Register.h:
              (JSC::Register::):
              * jit/JIT.cpp:
              (JSC::):
              * jit/JIT.h:
              * jit/JITCode.h:
              (JSC::):
              * jit/JITStubs.cpp:
              (JSC::JITStubs::cti_op_add):
              (JSC::JITStubs::cti_op_pre_inc):
              (JSC::JITStubs::cti_op_get_by_id_generic):
              (JSC::JITStubs::cti_op_get_by_id):
              (JSC::JITStubs::cti_op_get_by_id_second):
              (JSC::JITStubs::cti_op_get_by_id_self_fail):
              (JSC::JITStubs::cti_op_get_by_id_proto_list):
              (JSC::JITStubs::cti_op_get_by_id_proto_list_full):
              (JSC::JITStubs::cti_op_get_by_id_proto_fail):
              (JSC::JITStubs::cti_op_get_by_id_array_fail):
              (JSC::JITStubs::cti_op_get_by_id_string_fail):
              (JSC::JITStubs::cti_op_instanceof):
              (JSC::JITStubs::cti_op_del_by_id):
              (JSC::JITStubs::cti_op_mul):
              (JSC::JITStubs::cti_op_call_NotJSFunction):
              (JSC::JITStubs::cti_op_resolve):
              (JSC::JITStubs::cti_op_construct_NotJSConstruct):
              (JSC::JITStubs::cti_op_get_by_val):
              (JSC::JITStubs::cti_op_get_by_val_string):
              (JSC::JITStubs::cti_op_get_by_val_byte_array):
              (JSC::JITStubs::cti_op_sub):
              (JSC::JITStubs::cti_op_lesseq):
              (JSC::JITStubs::cti_op_negate):
              (JSC::JITStubs::cti_op_resolve_base):
              (JSC::JITStubs::cti_op_resolve_skip):
              (JSC::JITStubs::cti_op_resolve_global):
              (JSC::JITStubs::cti_op_div):
              (JSC::JITStubs::cti_op_pre_dec):
              (JSC::JITStubs::cti_op_not):
              (JSC::JITStubs::cti_op_eq):
              (JSC::JITStubs::cti_op_lshift):
              (JSC::JITStubs::cti_op_bitand):
              (JSC::JITStubs::cti_op_rshift):
              (JSC::JITStubs::cti_op_bitnot):
              (JSC::JITStubs::cti_op_mod):
              (JSC::JITStubs::cti_op_less):
              (JSC::JITStubs::cti_op_neq):
              (JSC::JITStubs::cti_op_urshift):
              (JSC::JITStubs::cti_op_bitxor):
              (JSC::JITStubs::cti_op_bitor):
              (JSC::JITStubs::cti_op_call_eval):
              (JSC::JITStubs::cti_op_throw):
              (JSC::JITStubs::cti_op_next_pname):
              (JSC::JITStubs::cti_op_typeof):
              (JSC::JITStubs::cti_op_is_undefined):
              (JSC::JITStubs::cti_op_is_boolean):
              (JSC::JITStubs::cti_op_is_number):
              (JSC::JITStubs::cti_op_is_string):
              (JSC::JITStubs::cti_op_is_object):
              (JSC::JITStubs::cti_op_is_function):
              (JSC::JITStubs::cti_op_stricteq):
              (JSC::JITStubs::cti_op_nstricteq):
              (JSC::JITStubs::cti_op_to_jsnumber):
              (JSC::JITStubs::cti_op_in):
              (JSC::JITStubs::cti_op_del_by_val):
              (JSC::JITStubs::cti_vm_throw):
              * jit/JITStubs.h:
              * runtime/JSValue.h:
              (JSC::JSValuePtr::encode):
              (JSC::JSValuePtr::decode):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5368abca
    • dglazkov@chromium.org's avatar
      2009-04-30 Dimitri Glazkov <dglazkov@chromium.org> · 854f39b7
      dglazkov@chromium.org authored
              Reviewed by Eric Seidel.
      
              Add CHROMIUM guard to unfork Document.cpp
      
              * dom/Document.cpp:
              (WebCore::Document::setFocusedNode): Added guard.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      854f39b7
    • ddkilzer@apple.com's avatar
      Use OwnPtr<HTMLParserQuirks> for m_parserQuirks · 119772a0
      ddkilzer@apple.com authored
              Reviewed by Geoff Garen.
      
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::~HTMLParser): Removed unneeded code.
              * html/HTMLParser.h: Made m_parserQuirks an OwnPtr.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      119772a0
    • barraclough@apple.com's avatar
      2009-04-30 Gavin Barraclough <barraclough@apple.com> · 87994d91
      barraclough@apple.com authored
              Reviewed by Oliver "Abandon Ship!" Hunt.
      
              Fix a leak in Yarr.
      
              All Disjunctions should be recorded in RegexPattern::m_disjunctions,
              so that they can be freed at the end of compilation - copyDisjunction
              is failing to do so.
      
              * yarr/RegexCompiler.cpp:
              (JSC::Yarr::RegexPatternConstructor::copyDisjunction):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87994d91
    • ojan@chromium.org's avatar
      2009-04-30 Ojan Vafai <ojan@chromium.org> · ac0e1aca
      ojan@chromium.org authored
              Reviewed by Eric Seidel.
      
              Fix tests that depend on Mac-specific metrics now that text controls
              are sized according to font metrics (r43007).
      
              Fixes https://bugs.webkit.org/show_bug.cgi?id=25474.
      
              * fast/forms/textarea-appearance-wrap-expected.txt:
              * fast/forms/textarea-appearance-wrap.html:
              This test only really cares that a line-wrap character is submitted
              with forms that have the appropriate wrap value and not with other forms.
              So checking that the submit contents have a line-wrap character, instead of
              looking for it in a specific place, is sufficient. This gets around that we
              wrap in a different place in some cases on Mac and Windows.
      
              * fast/forms/textarea-hard-linewrap-expected.txt: Removed.
              * fast/forms/textarea-hard-linewrap.html: Removed.
              This test is redundant with fast/forms/textarea-appearance-wrap.html.
      
              * fast/replaced/table-percent-height-expected.txt:
              * fast/replaced/table-percent-height-text-controls-expected.txt: Added.
              * fast/replaced/table-percent-height-text-controls.html: Added.
              * fast/replaced/table-percent-height.html:
              Pulled out the cases in table-percent-height.html that had text controls and moved
              them into their own test. The new test doesn't assert specific metrics, it just
              spits them out. This allows us to have different expected results for Windows and
              Mac without having "FAIL" messages in the expected results. It's not perfect, but
              it seems better than any alternatives I could come up with. We do still print "FAIL"
              if the results don't match any platform.
      
              * platform/win/Skipped:
              * platform/win/fast/replaced/table-percent-height-text-controls-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac0e1aca
    • oliver@apple.com's avatar
      Add function to CallFrame for dumping the current JS caller · 4476dccf
      oliver@apple.com authored
      Reviewed by Gavin Barraclough.
      
      Added debug only method CallFrame::dumpCaller() that provide the call location
      of the deepest currently executing JS function.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4476dccf
    • dglazkov@chromium.org's avatar
      Fixed ChangeLog entry, added comments. · e2a6ecae
      dglazkov@chromium.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43093 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2a6ecae
    • ddkilzer@apple.com's avatar
      Provide a mechanism to create a quirks delegate for HTMLParser · b11a768c
      ddkilzer@apple.com authored
              Reviewed by David Hyatt.
      
      WebCore:
      
              No tests since there is no change in behavior.
      
              HTMLParserQuirks.h defines an abstract base class that may be
              extended as needed.  The ChromeClient::createHTMLParserQuirks()
              factory method should be used to return an HTMLParserQuirks
              subclassed object when needed.
      
              * WebCore.xcodeproj/project.pbxproj: Added HTMLParserQuirks.h.
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::HTMLParser): Initialize m_parserQuirks
              using ChromeClient::createHTMLParserQuirks().
              (WebCore::HTMLParser::~HTMLParser): Delete m_parserQuirks if
              set.
              (WebCore::HTMLParser::reset): Call HTMLParserQuirks::reset() if
              m_parserQuirks is set.
              (WebCore::HTMLParser::insertNode): Call
              HTMLParserQuirks::shouldInsertNode() if m_parserQuirks is set,
              and return early if it returns false.
              (WebCore::HTMLParser::popBlock): Call
              HTMLParserQuirks::shouldPopBlock() if m_parserQuirks is set, and
              return early if it returns false.
              * html/HTMLParser.h: Added m_parserQuirks.
              * html/HTMLParserQuirks.h: Added.
              (WebCore::HTMLParserQuirks::HTMLParserQuirks):
              (WebCore::HTMLParserQuirks::~HTMLParserQuirks):
              * loader/EmptyClients.h:
              (WebCore::EmptyChromeClient::createHTMLParserQuirks): Added.
              * page/ChromeClient.h:
              (WebCore::ChromeClient::createHTMLParserQuirks): Added.
      
      WebKit/gtk:
      
              * WebCoreSupport/ChromeClientGtk.h:
              (WebKit::ChromeClient::createHTMLParserQuirks): Added.  The
              default implementation of this factory method returns 0.
      
      WebKit/mac:
      
              * WebCoreSupport/WebChromeClient.h:
              (WebChromeClient::createHTMLParserQuirks): Added.  The default
              implementation of this factory method returns 0.
      
      WebKit/qt:
      
              * WebCoreSupport/ChromeClientQt.h:
              (WebCore::ChromeClientQt::createHTMLParserQuirks): Added.  The
              default implementation of this factory method returns 0.
      
      WebKit/win:
      
              * WebCoreSupport/WebChromeClient.h:
              (WebChromeClient::createHTMLParserQuirks): Added.  The default
              implementation of this factory method returns 0.
      
      WebKit/wx:
      
              * WebKitSupport/ChromeClientWx.h:
              (WebCore::ChromeClientWx::createHTMLParserQuirks): Added.  The
              default implementation of this factory method returns 0.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b11a768c
    • dglazkov@chromium.org's avatar
      2009-04-30 Dimitri Glazkov <dglazkov@chromium.org> · 45c1fab5
      dglazkov@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=25492
              Add JSC guards around node wrapper cache calls. These are not used by V8.
      
              * dom/Document.cpp:
              (WebCore::Document::~Document): Added JSC guard.
              * dom/Node.cpp:
              (WebCore::Node::setDocument): Ditto and removed JSDOMBinding include.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43091 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45c1fab5
    • mjs@apple.com's avatar
      2009-04-30 Maciej Stachowiak <mjs@apple.com> · a69a0598
      mjs@apple.com authored
              Reviewed by Geoff Garen.
      
              - make BaseStrings have themselves as a base, instead of nothing, to remove common branches
      
              ~0.7% SunSpider speedup
      
              * runtime/UString.h:
              (JSC::UString::Rep::Rep): For the constructor without a base, set self as base instead of null.
              (JSC::UString::Rep::baseString): Just read m_baseString - no more branching.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a69a0598
    • timothy@apple.com's avatar
      Versioning. · 40aa03d1
      timothy@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40aa03d1
    • dglazkov@chromium.org's avatar
      2009-04-30 Dimitri Glazkov <dglazkov@chromium.org> · e77695bc
      dglazkov@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=25493
              Remove debugger/profiler custom method stubs, catching V8 bindings up to
              http://trac.webkit.org/changeset/43072.
      
              * bindings/v8/custom/V8InspectorControllerCustom.cpp: Removed method stubs.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e77695bc
    • barraclough@apple.com's avatar
      2009-04-30 Gavin Barraclough <barraclough@apple.com> · 066b94ec
      barraclough@apple.com authored
              Reviewed by Oliver Hunt.
      
              Two quick improvements to SamplingFlags mechanism.
      
              SamplingFlags::ScopedFlag class to provide support for automagically
              clearing a flag as it goes out of scope, and add a little more detail
              to the output generated by the tool.
      
              * bytecode/SamplingTool.cpp:
              (JSC::SamplingFlags::stop):
              * bytecode/SamplingTool.h:
              (JSC::SamplingFlags::ScopedFlag::ScopedFlag):
              (JSC::SamplingFlags::ScopedFlag::~ScopedFlag):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      066b94ec
    • simon.fraser@apple.com's avatar
      2009-04-30 Simon Fraser <simon.fraser@apple.com> · 96ce357e
      simon.fraser@apple.com authored
              Reviewed by Darin Adler
      
              <rdar://problem/6839338> VoiceOver does not take into account transforms when drawing outlines
      
              Use transform-aware quad methods when computing the boundingBoxRect for
              an AccessibilityRenderObject. The code follows RenderObject::absoluteBoundingBoxRect().
      
              Test: accessibility/transformed-element.html
      
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::boundingBoxRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96ce357e
    • aroben@apple.com's avatar
      Restore build event steps that were truncated in r43082 · fdaaee68
      aroben@apple.com authored
              Rubber-stamped by Steve Falkenburg.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
              * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
              * JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
              Re-copied the command lines for the build events from the pre-r43082
              .vcproj files.
      
              * JavaScriptCore.vcproj/jsc/jsc.vcproj: Removed an unnecessary
              attribute.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdaaee68
    • jmalonzo@webkit.org's avatar
      2009-04-30 Jan Michael Alonzo <jmalonzo@webkit.org> · 17fc6f83
      jmalonzo@webkit.org authored
              Unreviewed build GTK build fix
      
              * configure.ac: typo fix - javascript_debugger should be enable_javascript_debugger
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17fc6f83
    • aroben@apple.com's avatar
      Move settings from .vcproj files to .vsprops files within the JavaScriptCore directory · d989e771
      aroben@apple.com authored
              Moving the settings to a .vsprops file means that we will only have to
              change a single setting to affect all configurations, instead of one
              setting per configuration.
      
              Reviewed by Steve Falkenburg.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.vcproj/WTF/WTF.vcproj:
              * JavaScriptCore.vcproj/jsc/jsc.vcproj:
              * JavaScriptCore.vcproj/testapi/testapi.vcproj:
              Moved settings from these files to the new .vsprops files. Note that
              testapi.vcproj had a lot of overrides of default settings that were
              the same as the defaults, which I've removed.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Added.
              * JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Added.
              * JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added.
              * JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d989e771
    • dglazkov@chromium.org's avatar
      2009-04-30 Dimitri Glazkov <dglazkov@chromium.org> · 4557b4e0
      dglazkov@chromium.org authored
              Unreviewed, Chromium build fix.
      
              Catch up to ScriptObject changes from http://trac.webkit.org/changeset/42512.
      
              * bindings/v8/ScriptObject.cpp:
              (WebCore::ScriptGlobalObject::get): Renamed from getObject.
              (WebCore::ScriptGlobalObject::remove): Added.
              * bindings/v8/ScriptObject.h: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4557b4e0
    • dglazkov@chromium.org's avatar
      2009-04-30 Dimitri Glazkov <dglazkov@chromium.org> · f9e21ed6
      dglazkov@chromium.org authored
              Unreviewed, build fix.
      
              https://bugs.webkit.org/show_bug.cgi?id=25470
              Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
      
              * WebCore.pro: Fix copy-paste error.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9e21ed6
    • dglazkov@chromium.org's avatar
      2009-04-30 Dimitri Glazkov <dglazkov@chromium.org> · e8d9546e
      dglazkov@chromium.org authored
              Unreviewed, build fix.
      
              https://bugs.webkit.org/show_bug.cgi?id=25470
              Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
      
              * GNUmakefile.am: Add ENABLE_JAVASCRIPT_DEBUGGER definitions.
              * WebCore.pro: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43079 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8d9546e
    • ariya@webkit.org's avatar
      2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com> · 5098e301
      ariya@webkit.org authored
              Unreviewed build fix after r43072.
      
              * Api/qwebframe.cpp:
              (qt_drt_setJavaScriptProfilingEnabled): Enclose with JAVASCRIPT_DEBUGGER.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5098e301
    • ariya@webkit.org's avatar
      2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com> · 6cda6ac0
      ariya@webkit.org authored
              Unreviewed build fix after r43063.
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::addMessageToConsole):
              * WebCoreSupport/ChromeClientQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cda6ac0
    • darin@apple.com's avatar
      2009-04-30 Darin Adler <darin@apple.com> · cbb45ab5
      darin@apple.com authored
              Reviewed by Sam Weinig.
      
              Add a first text iterator test. We'll add more later.
              This test includes some known expected failures. At some point we'll fix those.
      
              * editing/text-iterator: Added.
              * editing/text-iterator/basic-iteration-expected.txt: Added.
              * editing/text-iterator/basic-iteration.html: Added.
              * editing/text-iterator/resources: Added.
              * editing/text-iterator/resources/TEMPLATE.html: Copied from editing/selection/resources/TEMPLATE.html.
              * editing/text-iterator/resources/basic-iteration.js: Added.
      
              * platform/gtk/Skipped: Skip editing/text-iterator since only Mac DumpRenderTree has this at the moment.
              * platform/qt/Skipped: Ditto.
              * platform/win/Skipped: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbb45ab5
    • eric@webkit.org's avatar
      Reviewed by Darin Adler. · ec7202e8
      eric@webkit.org authored
              Change Position to pre-compute the AnchorType and store it.
              Also store a "legacy editing mode" bit on the Position.
              https://bugs.webkit.org/show_bug.cgi?id=24763
      
              The old Postion(node, offset) constructor creates legacy positions
              but there are new constructors to create explicitly anchored positions
              which the next patch will use.
      
              Once we fix all the "position-fixup" functions (like rangeCompliantEquivalent) to
              only affect legacy positions, we will be able to distinguish
              between [table, 1] and [table, after] in the code correctly!
      
              * WebCore.base.exp:
              * WebCore.xcodeproj/project.pbxproj:
              * dom/Position.cpp:
              (WebCore::Position::Position):
              (WebCore::Position::moveToPosition):
              (WebCore::Position::moveToOffset):
              (WebCore::Position::anchorTypeForLegacyEditingPosition):
              (WebCore::Position::element):
              * dom/Position.h:
              (WebCore::Position::):
              (WebCore::Position::Position):
              (WebCore::Position::anchorType):
              (WebCore::Position::deprecatedEditingOffset):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec7202e8
    • dglazkov@chromium.org's avatar
      2009-04-30 Dimitri Glazkov <dglazkov@chromium.org> · 9b13658b
      dglazkov@chromium.org authored
              Unreviewed, build fix.
      
              https://bugs.webkit.org/show_bug.cgi?id=25470
              Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
      
              * configure.ac: Add autoconfig options, missed in the first commit.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b13658b
    • weinig@apple.com's avatar
      WebCore: · 8e9ecad1
      weinig@apple.com authored
      2009-04-30  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Fix bug where the WorkerLocation and WorkerNavigator wrappers would be
              collected even if the WorkerContext is still alive.
      
              Test: fast/workers/worker-context-gc.html
      
              * bindings/js/JSWorkerContextCustom.cpp:
              (WebCore::JSWorkerContext::mark):
              * workers/WorkerContext.cpp:
              (WebCore::WorkerContext::WorkerContext):
              (WebCore::WorkerContext::completeURL):
              (WebCore::WorkerContext::location):
              * workers/WorkerContext.h:
              (WebCore::WorkerContext::optionalNavigator):
              (WebCore::WorkerContext::optionalLocation):
      
      LayoutTests:
      
      2009-04-30  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Test for bug where the WorkerLocation and WorkerNavigator wrappers would be
              collected even if the WorkerContext is still alive.
      
              * fast/workers/worker-context-gc-expected.txt: Added.
              * fast/workers/worker-context-gc.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e9ecad1
    • dglazkov@chromium.org's avatar
      JavaScriptCore: · 18a33936
      dglazkov@chromium.org authored
      2009-04-30  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              https://bugs.webkit.org/show_bug.cgi?id=25470
              Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
      
              * Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER define.
      
      WebCore:
      
      2009-04-30  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              https://bugs.webkit.org/show_bug.cgi?id=25470
              Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
      
              * Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER.
              * WebCore.vcproj/build-generated-files.sh: Ditto.
              * bindings/js/JSConsoleCustom.cpp: Added ENABLE(JAVASCRIPT_DEBUGGER) guard.
              * bindings/js/JSDOMWindowBase.cpp: Ditto.
              * bindings/js/JSInspectorControllerCustom.cpp: Ditto.
              * inspector/InspectorController.cpp: Moved profiler/debugger methods under
                  ENABLE(JAVASCRIPT_DEBUGGER) flag.
              * inspector/InspectorController.h: Ditto.
              * inspector/InspectorController.idl: Added ENABLE(JAVASCRIPT_DEBUGGER) guard.
              * page/Console.cpp: Replaced USE(JSC) with ENABLE(JAVASCRIPT_DEBUGGER) guard.
      
      WebKit/mac:
      
      2009-04-30  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              https://bugs.webkit.org/show_bug.cgi?id=25470
              Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
      
              * Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER define.
      
      WebKitTools:
      
      2009-04-30  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              https://bugs.webkit.org/show_bug.cgi?id=25470
              Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
      
              * Scripts/build-webkit: Added ENABLE_JAVASCRIPT_DEBUGGER define.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18a33936
    • kdecker@apple.com's avatar
      Reviewed by Anders Carlson. · 97f7e444
      kdecker@apple.com authored
              <rdar://problem/6823049>
              
              Fix an issue where some plug-ins would cause the application icon to constantly bounce
              up and down in the Dock.
              
              * Plugins/Hosted/NetscapePluginHostProxy.h: Change m_placeholderWindow ivar to be
              a subclass of NSWindow, WebPlaceholderModalWindow.
              * Plugins/Hosted/NetscapePluginHostProxy.mm:  Added WebPlaceholderModalWindow NSWindow subclass.
              (-[WebPlaceholderModalWindow _wantsUserAttention]): Prevent NSApp from calling requestUserAttention:
               when the window is shown modally, even if the app is inactive.
              (WebKit::NetscapePluginHostProxy::beginModal): NSWindow -> WebPlaceholderModalWindow.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97f7e444
    • dglazkov@chromium.org's avatar
      2009-04-30 Dimitri Glazkov <dglazkov@chromium.org> · 6cc34fd0
      dglazkov@chromium.org authored
              Unreviewed, build fix.
      
              https://bugs.webkit.org/show_bug.cgi?id=25275
              This patch snuck in a re-definition of a local.
      
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              (WebCore::NAMED_PROPERTY_GETTER): Removed re-definition.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cc34fd0
    • weinig@apple.com's avatar
      2009-04-30 Sam Weinig <sam@webkit.org> · bcd18838
      weinig@apple.com authored
              Reviewed by Mark Rowe.
      
              Fix a leak introduced yesterday.  Don't allocate a ScheduledAction
              if the toString()ing throws an exception.
      
              * bindings/js/ScheduledAction.cpp:
              (WebCore::ScheduledAction::create):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcd18838
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · 2827d623
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=25379
              <rdar://problem/6809460> REGRESSION (r41772): Selecting a bank in American Express Pay Bill fails
      
              Test: fast/forms/multiple-selected-options-innerHTML.html
      
              This problem was caused by an inconsistency at when Node::instertedIntoTree() is called.
              For normal HTML parsing, it is called immediately after an element is inserted, but for
              innerHTML, it is only called after the whole subtree is inserted into a document.
      
              It may make sense to harmonize these cases one day, but for now, I only made the minimal
              changes necessary to fix the bug.
      
              * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::insertedIntoTree):
              * html/HTMLSelectElement.h:
              Recalculate list items when a SELECT element is inserted. OPTION elements cannot decide
              which one to keep selected themselves, because their logic assumes normal parsing, with
              insertedIntoTree() called after each element is inserted.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2827d623
    • dglazkov@chromium.org's avatar
      WebCore: · 2ea1395d
      dglazkov@chromium.org authored
      2009-04-30  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              https://bugs.webkit.org/show_bug.cgi?id=25342
              Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.
      
              Chromium async/out-of-process version of WebInspector is currently not based on
              InspectorController. The reason was that we did not want to interfere with
              the unforking effort, yet wanted to experiment. So we came up with these
              agents concept that basically mimic InspectorController, but separating 'agent'
              nature from the 'transport'. Now that InspectorController is unforked, I am
              planning to bring these concepts into the WebKit land and use what we have in
              Chromium as a proof of concept / experimental playground.
      
              * loader/EmptyClients.h: added MessageSource and MessageLevel parameters.
              (WebCore::EmptyChromeClient::addMessageToConsole): ditto
              * page/ChromeClient.h: ditto
              * page/Console.cpp: Used new method signature.
              (WebCore::Console::addMessage): ditto
      
      WebKit/gtk:
      
      2009-04-30  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              https://bugs.webkit.org/show_bug.cgi?id=25342
              Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::addMessageToConsole):
              * WebCoreSupport/ChromeClientGtk.h:
      
      WebKit/mac:
      
      2009-04-30  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              https://bugs.webkit.org/show_bug.cgi?id=25342
              Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::addMessageToConsole):
      
      WebKit/win:
      
      2009-04-30  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              https://bugs.webkit.org/show_bug.cgi?id=25342
              Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.
      
              * WebCoreSupport/WebChromeClient.cpp:
              (WebChromeClient::addMessageToConsole):
              * WebCoreSupport/WebChromeClient.h:
      
      WebKit/wx:
      
      2009-04-30  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              https://bugs.webkit.org/show_bug.cgi?id=25342
              Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.
      
              * WebKitSupport/ChromeClientWx.cpp:
              (WebCore::ChromeClientWx::addMessageToConsole):
              * WebKitSupport/ChromeClientWx.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ea1395d