1. 13 Nov, 2007 18 commits
    • ggaren@apple.com's avatar
      JavaScriptCore: · 7911af29
      ggaren@apple.com authored
              Reviewed by Sam Weinig.
      
              Moved Shared.h into wtf so it could be used in more places. Deployed
              Shared in places where JSCore previously had hand-rolled ref-counting
              classes.
      
              * API/JSClassRef.cpp:
              (OpaqueJSClass::OpaqueJSClass):
              * API/JSClassRef.h:
              * API/JSObjectRef.cpp:
              (JSClassRetain):
              (JSClassRelease):
              * JavaScriptCore.vcproj/WTF/WTF.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * kjs/interpreter.cpp:
              (KJS::Interpreter::init):
              * kjs/interpreter.h:
              * kjs/regexp.cpp:
              (KJS::RegExp::RegExp):
              * kjs/regexp.h:
              * wtf/Shared.h: Copied from WebCore/platform/Shared.h.
      
      JavaScriptGlue:
      
              Reviewed by Sam Weinig.
      
              Moved Shared.h into wtf so it could be used in more places.
      
              * ForwardingHeaders/wtf/Shared.h: Added.
      
      WebCore:
      
              Reviewed by Sam Weinig.
      
              Moved Shared.h into wtf so it could be used in more places. Retained 
              TreeShared, but moved it to its own file, TreeShared.h.
      
              * ForwardingHeaders/wtf/Shared.h: Added.
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSSVGPODTypeWrapper.h:
              * css/CSSFontFace.h:
              * css/CSSRuleList.h:
              * css/Counter.h:
              * css/Pair.h:
              * css/Rect.h:
              * css/StyleBase.h:
              * css/StyleSheetList.h:
              * dom/Clipboard.h:
              * dom/DOMImplementation.h:
              * dom/Event.h:
              * dom/EventListener.h:
              * dom/NamedNodeMap.h:
              * dom/NodeFilterCondition.h:
              * dom/NodeList.h:
              * dom/Range.h:
              * dom/RangeException.h:
              * dom/RegisteredEventListener.h:
              * dom/Traversal.h:
              * history/BackForwardList.h:
              * history/CachedPage.h:
              * history/HistoryItem.h:
              * html/CanvasGradient.h:
              * html/CanvasPattern.h:
              * html/HTMLCollection.h:
              * html/MediaError.h:
              * html/TimeRanges.h:
              * html/VoidCallback.h:
              * ksvg2/css/SVGRenderStyleDefs.h:
              * ksvg2/svg/SVGAnimatedTemplate.h:
              * ksvg2/svg/SVGElementInstanceList.h:
              * ksvg2/svg/SVGList.h:
              * ksvg2/svg/SVGPathSeg.h:
              * ksvg2/svg/SVGPreserveAspectRatio.h:
              * ksvg2/svg/SVGRenderingIntent.h:
              * ksvg2/svg/SVGTransform.h:
              * ksvg2/svg/SVGUnitTypes.h:
              * loader/DocumentLoader.h:
              * loader/FormState.h:
              * loader/ResourceLoader.h:
              * loader/TextResourceDecoder.h:
              * loader/icon/IconRecord.h:
              * page/BarInfo.h:
              * page/Console.h:
              * page/DOMSelection.h:
              * page/DOMWindow.h:
              * page/History.h:
              * page/InspectorController.cpp:
              * page/Plugin.h:
              * page/Screen.h:
              * platform/ArrayImpl.h:
              * platform/CString.h:
              * platform/DeprecatedValueListImpl.cpp:
              * platform/FontFallbackList.h:
              * platform/FontFamily.h:
              * platform/FontSelector.h:
              * platform/GlyphPageTreeNode.h:
              * platform/PopupMenu.h:
              * platform/RegularExpression.cpp:
              * platform/ScrollBar.h:
              * platform/Shared.h: Removed.
              * platform/SharedBuffer.h:
              * platform/StringImpl.h:
              * platform/graphics/Icon.h:
              * platform/graphics/svg/SVGResource.h:
              * platform/network/FormData.h:
              * platform/network/ResourceHandleClient.h:
              * rendering/RenderStyle.h:
              * rendering/SVGCharacterLayoutInfo.h:
              * storage/SQLResultSetRowList.h:
              * xml/DOMParser.h:
              * xml/XMLSerializer.h:
              * xml/XPathEvaluator.h:
              * xml/XPathExpression.h:
              * xml/XPathNSResolver.h:
              * xml/XPathResult.h:
      
      WebKit/mac:
      
              Reviewed by Sam Weinig.
      
              Moved Shared.h into wtf so it could be used in more places.
      
              * ChangeLog:
              * WebCoreSupport/WebContextMenuClient.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7911af29
    • beidson@apple.com's avatar
      Squashed commit of the following: · effd1c72
      beidson@apple.com authored
      commit 3e6cb737b3b823b4bf177b9e0c2fcfcc38baf46d
      Author: Brady Eidson <beidson@apple.com>
      Date:   Tue Nov 13 16:22:36 2007 -0800
      
          Changelog for commit
      
      commit 4be13a5ef17685368e68a76292b785c99da1d7f2
      Author: Brady Eidson <beidson@apple.com>
      Date:   Tue Nov 13 16:19:34 2007 -0800
      
          Make inspector work with new API
      
      commit c500ed90c32b31fbc37a183c8ae5427f36b9ccc2
      Author: Brady Eidson <beidson@apple.com>
      Date:   Tue Nov 13 14:37:16 2007 -0800
      
          Woops!
      
      commit c61b147f35a2801c340f82054d177914da6ccde5
      Author: Brady Eidson <beidson@apple.com>
      Date:   Tue Nov 13 11:45:40 2007 -0800
      
          Ander's review comments
      
      commit f3dc2683acc5730cbab8758226adae3e35f7263b
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Nov 12 18:05:21 2007 -0800
      
          Initial vcproj changes after the rebase
      
      commit c8cf9be275479ff1fb39b911e5165f07fcd5ae34
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Nov 12 18:02:30 2007 -0800
      
          Fixed Changelog a bit
      
      commit c9790cde9b79e25690f1c0b34b9c1e77d2f4449f
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Nov 12 16:53:48 2007 -0800
      
          Finish the rebase/trunk merge
      
      commit 663ad85619ec677eb5c52bed3c59b8b3f50de624
      Author: Brady Eidson <beidson@apple.com>
      Date:   Tue Nov 6 11:54:26 2007 -0800
      
          VCProj changes for new SQL api + blind attempt at keeping qt/gtk going
      
      commit 2aceeb3bdfa6894bb4e93c0b129867059e9cdad7
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Nov 5 15:27:55 2007 -0800
      
          Changelog edit cleanup
      
      commit a05f11fa4fa0ba935eb28df6d9628f29a4074d7a
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Nov 5 15:25:27 2007 -0800
      
          Changelog entries and small style cleanup
      
      commit a2d34a78d06f446f4bdb6ea1797dfb91cfc336fe
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Nov 5 13:37:10 2007 -0800
      
          Minor edit
      
      commit eaf0aa9c07cfeb54df312c130677ecbc60728c5f
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Nov 5 13:32:20 2007 -0800
      
          Do version check at time of executeSql
      
      commit 3bac84615badcc810f44ebf14d1679bffd4cc8fb
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Nov 5 13:04:14 2007 -0800
      
          Newline = t3h gone
      
      commit de7cfcf737b1a6143b74f1cc60955c317877ca27
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Nov 5 13:02:11 2007 -0800
      
          Example + inspector fixes
      
      commit 536b119c219de72c97fe6756e226a36bef5e6880
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Nov 5 11:47:30 2007 -0800
      
          DatabaseExample works
      
      commit fff79aa99dbf47955bc37ca325928460fc41a59e
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Nov 5 10:36:59 2007 -0800
      
          Remove the old, now unused DatabaseCallback
      
      commit 06bc8e16ad346b755f767ce8e7849da819ccf96f
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Nov 5 09:57:36 2007 -0800
      
          Sort project file
      
      commit 741084d108ec994ff513e18c3d7a3153f6dd6bb5
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Nov 5 09:30:37 2007 -0800
      
          Sort the project file
      
      commit 2e77cec4337db174f56269b7fb406d81ebb1de7d
      Author: Brady Eidson <beidson@apple.com>
      Date:   Thu Nov 1 16:01:03 2007 -0700
      
          Yay!  Change version even works!
      
      commit 05c2ed1f22e3b689dd453ea300154492937f46db
      Author: Brady Eidson <beidson@apple.com>
      Date:   Thu Nov 1 15:19:56 2007 -0700
      
          Nuke some DRT changes
      
      commit 9b5b9b25c45d7d4720e4ddf4a31f163fb4f7faf2
      Author: Brady Eidson <beidson@apple.com>
      Date:   Thu Nov 1 15:05:59 2007 -0700
      
          Nuke some printfs
      
      commit 8503eecdefa95278a15246bb4eed2dccb69af12a
      Author: Brady Eidson <beidson@apple.com>
      Date:   Thu Nov 1 13:44:32 2007 -0700
      
          Added "current transaction" to Database and reworked how scheduling goes
      
      commit f70354c9a84d654d28894ab3c6b13679ce494fc3
      Author: Brady Eidson <beidson@apple.com>
      Date:   Thu Nov 1 11:49:26 2007 -0700
      
          Things are largely working.  Still need to clean up loose ends in the sticky notes demo and do further testing
      
      commit 417665cd15f020c22af5691577e5c8a072630839
      Author: Brady Eidson <beidson@apple.com>
      Date:   Thu Nov 1 00:00:47 2007 -0700
      
          Transaction steps are almost locked up completely.  Still need the SQLError for the transaction error callback and actually implementing ::execute() on the SQLStatement
      
      commit 752d572acd4d1d9832976b4869284e554845205a
      Author: Anders Carlsson <andersca@apple.com>
      Date:   Wed Oct 31 18:52:55 2007 -0700
      
          Forgot this.
      
      commit 2c8f2689d212296961a841c579a2f93609858862
      Author: Anders Carlsson <andersca@apple.com>
      Date:   Wed Oct 31 18:31:05 2007 -0700
      
          Merge.
      
      commit 7540d4fa7ef858400d9f834cba976a439394412d
      Author: Brady Eidson <beidson@apple.com>
      Date:   Wed Oct 31 17:14:30 2007 -0700
      
          Even closer!
      
      commit 143a70a5d026ab9fab1b5de91f826effcd481527
      Author: Brady Eidson <beidson@apple.com>
      Date:   Wed Oct 31 16:43:31 2007 -0700
      
          Merge project file correctly
      
      commit 11207e7b6e391a4052fc41f6db42ce30449c7e3e
      Author: Anders Carlsson <andersca@apple.com>
      Date:   Wed Oct 31 11:04:35 2007 -0700
      
          Remove more unused methods.
      
      commit 9a0d306d467eb9aa8c19825da03b7abe318c609c
      Author: Anders Carlsson <andersca@apple.com>
      Date:   Wed Oct 31 11:01:35 2007 -0700
      
          Add SQLTransactionCallback.idl
      
      commit 12e2fa2858145e3895320293462ec441c35a7e3d
      Author: Anders Carlsson <andersca@apple.com>
      Date:   Wed Oct 31 10:47:17 2007 -0700
      
          Fix build.
      
      commit 02f4631705b0f6e0bd3c715c64f4938ea53f4670
      Author: Brady Eidson <beidson@apple.com>
      Date:   Tue Oct 30 23:36:24 2007 -0700
      
          All steps now take place in the right order, following the right rules - only thing missing is the actual SQL executing!
      
      commit 6a8c0d7d2beb745c070c55b14beac9a47d373fc4
      Author: Brady Eidson <beidson@apple.com>
      Date:   Tue Oct 30 18:20:35 2007 -0700
      
          Closer and closer we roll
      
      commit f945446453ae48a28d6e2f3dcce4660feae0da79
      Author: Brady Eidson <beidson@apple.com>
      Date:   Tue Oct 30 17:59:25 2007 -0700
      
          Things are really rolling - transaction steps 1-5 are called as expected.  Downhill from here
      
      commit 138b49b62bc8f3d05b1171e280d403e8b15ef9c4
      Author: Brady Eidson <beidson@apple.com>
      Date:   Tue Oct 30 14:50:14 2007 -0700
      
          Use pointer-to-member functions for the transaction steps...  !!!
      
      commit 3eb4f794861827f5c88cd8c36efb144cdc537bd5
      Author: Anders Carlsson <andersca@apple.com>
      Date:   Tue Oct 30 14:45:59 2007 -0700
      
          Remove more old cruft.
      
      commit f18835f0709b4aff00903738974dbebb11a224f0
      Author: Brady Eidson <beidson@apple.com>
      Date:   Tue Oct 30 13:55:05 2007 -0700
      
          Restore that comment
      
      commit 35b2eac5ac3ec338cc2a8a4fe611f85e62c72dd6
      Author: Brady Eidson <beidson@apple.com>
      Date:   Tue Oct 30 12:08:29 2007 -0700
      
          Closer, still, to the new model working.  Lotsa little tweaks
      
      commit a8476702a7d9bb38b8e15966e837ceca5858e9b2
      Author: Anders Carlsson <andersca@apple.com>
      Date:   Tue Oct 30 11:23:02 2007 -0700
      
          Wrap changeVersion.
      
      commit aa0d8cc6aaaf674de341996555306eb9f122de3c
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Oct 29 22:35:16 2007 -0700
      
          Dummy callback as part of transaction steps acheived!  And other architectural changes
      
      commit 01c0a92daf764375be79753bc7bc417aa0205168
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Oct 29 18:23:00 2007 -0700
      
          Have a the first chunk of transaction steps occuring asynchronously with stubs and printf()s - should be downhill from here.  Also updated the DatabaseExample.html for the portion of the new API that works so far.
      
      commit 6b6e9e7a064424cd6b70489de80c79e7ae950b38
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Oct 29 17:32:30 2007 -0700
      
          Made DatabaseTasks create mutex/conditions on demand, and renamed the internal sqlitedatabase
      
      commit 99d06513090c2b4e04edda82d82108cf97da245a
      Author: Anders Carlsson <andersca@apple.com>
      Date:   Mon Oct 29 16:30:52 2007 -0700
      
          Fix bug.
      
      commit 83def2ce73fa001f5bda3e152ca60e58c563dbed
      Author: Anders Carlsson <andersca@apple.com>
      Date:   Mon Oct 29 15:17:45 2007 -0700
      
          Remove some cruft.
      
      commit 9f2c8c21d06d6b379426449357f1ee00a25faeee
      Author: Anders Carlsson <andersca@apple.com>
      Date:   Mon Oct 29 14:45:54 2007 -0700
      
          More bindings.
      
      commit 9eae9135ed17179b7bcd225648272d24b76de8b9
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Oct 29 14:19:34 2007 -0700
      
          Adapt to new openDatabase() method
      
      commit 2e1dad857b190634f4394475e925d2dc518ae1fe
      Author: Brady Eidson <beidson@apple.com>
      Date:   Mon Oct 29 12:05:53 2007 -0700
      
          More infrastructure changes for the new spec, getting really close now!
      
      commit b0d8ca9dc7ffe1a424070d5f8587346eca56b76b
      Author: Brady Eidson <beidson@apple.com>
      Date:   Fri Oct 26 17:25:41 2007 -0700
      
          More stubbing of infrastructure
      
      commit bb8c6528208a24f129af9a8c09763989e5723157
      Author: Anders Carlsson <andersca@apple.com>
      Date:   Fri Oct 26 15:38:16 2007 -0700
      
          Remove SQLVersionChangeCallback.h
      
      commit c77ec8b1d2a7c8cb7a6a0bc42b089c34541cdf83
      Author: Brady Eidson <beidson@apple.com>
      Date:   Fri Oct 26 15:28:08 2007 -0700
      
          Make it build (removed the old changeVersion)
      
      commit e205fd2d6cb0cd4e6dd47cf4b6609196d0d8e87d
      Author: Brady Eidson <beidson@apple.com>
      Date:   Fri Oct 26 14:53:15 2007 -0700
      
          Even more progress in the architecture change
      
      commit 322f576e2ed8c584244335f918302169c81ea39f
      Author: Anders Carlsson <andersca@apple.com>
      Date:   Fri Oct 26 14:52:22 2007 -0700
      
          Add JSSQLTransactionCustom.cpp.
      
      commit 22d0b184e1d5d92574b5caf2b73eb6c7faae84be
      Author: Anders Carlsson <andersca@apple.com>
      Date:   Fri Oct 26 13:21:55 2007 -0700
      
          Add new API to Database.
      
      commit 910660c7668f2728850990f8984045de9e41423f
      Author: Anders Carlsson <andersca@apple.com>
      Date:   Fri Oct 26 11:48:33 2007 -0700
      
          Add more .IDL files
      
      commit 4d0cbb5b3e8c57076ce0cb743f8a52a5e31c0219
      Author: Brady Eidson <beidson@apple.com>
      Date:   Fri Oct 26 11:20:54 2007 -0700
      
          Further groundwork for new API (does not build)
      
      commit d6420aacd1bf610ca53eced12e61ecd074f31bd7
      Author: Brady Eidson <beidson@apple.com>
      Date:   Thu Oct 25 18:02:23 2007 -0700
      
          Further stubs and adaptations to the new API
      
      commit ea80b0c14037cfbdccf322146b26b62df2aa8211
      Author: Brady Eidson <beidson@apple.com>
      Date:   Thu Oct 25 15:51:43 2007 -0700
      
          Remove closeTransaction()
      
      commit 4e701837674e07111da80a476135f5b73e25210f
      Author: Brady Eidson <beidson@apple.com>
      Date:   Thu Oct 25 14:05:40 2007 -0700
      
          Further stubbing and API-matching cleanup
      
      commit f667cf3c7847069a6720296710876394954611bd
      Author: Anders Carlsson <andersca@apple.com>
      Date:   Wed Oct 24 16:32:58 2007 -0700
      
          Add extra arguments to Window.openDatabase.
      
      commit efbbe3016a31a9c4a717de25d831406288f8126d
      Author: Anders Carlsson <andersca@apple.com>
      Date:   Wed Oct 24 14:21:22 2007 -0700
      
          cleanup.
      
      commit b70a8252a588eee36d06835bad5793361ced35c5
      Author: Anders Carlsson <andersca@apple.com>
      Date:   Wed Oct 24 12:31:06 2007 -0700
      
          Stub out a couple of new classes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      effd1c72
    • mitz@apple.com's avatar
      Reviewed by Beth Dakin. · 64accf64
      mitz@apple.com authored
              - fix <rdar://problem/5551163> REGRESSION: Cursor does not change to arrow on "X" button in google maps, making it hard to click
      
              * css/html4.css: Added a 'cursor: auto' rule for links.
              * manual-tests/link-cursor-auto.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64accf64
    • mitz@apple.com's avatar
      Reviewed by Beth Dakin. · b718ab8a
      mitz@apple.com authored
              - fix <rdar://problem/5516272> Reproducible crash in RenderObject::setStyle involving going Back from a non-HTML document (Bookmarks view, PDF view)
      
              The root cause for the crash is that when a non-HTML view enters the
              frame, the frame's document pointer keeps pointing at the last HTML-type
              document it contained. This patch does not address the root cause, but
              makes changes to account for that condition.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::receivedMainResourceError): Do not change the
              frame's current document's page cache state here.
              (WebCore::FrameLoader::invalidateCurrentItemCachedPage): If the frame's
              current document is in fact the history item being invalidated, then
              set its page cache state here.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b718ab8a
    • eric@webkit.org's avatar
      2007-11-13 Eric Seidel <eric@webkit.org> · 9b5a2031
      eric@webkit.org authored
              Reviewed by Maciej.
      
              Add an ASSERT to getTruncatedInt32 to enforce proper usage.
              Best part about this patch?  It doesn't break the web!
      
              * kjs/JSImmediate.h:
              (KJS::JSImmediate::getTruncatedInt32):
              (KJS::JSImmediate::toDouble):
              (KJS::JSImmediate::getUInt32):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b5a2031
    • antti@apple.com's avatar
      WebCore: · 49ca7acf
      antti@apple.com authored
              Reviewed by Adele.
      
              Fix that 'timeupdate' and 'waiting' events were never dispatched.
              
              Add explicit m_paused attribute instead of trying to derive paused state from
              underlying media. Call updatePlayState() to start/stop media playback
              when any attribute that affects active playback state changes. This matches 
              specification text.
              
              Test: http/tests/media/video-play-stall.html
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::HTMLMediaElement):
              (WebCore::HTMLMediaElement::setReadyState):
              (WebCore::HTMLMediaElement::paused):
              (WebCore::HTMLMediaElement::play):
              (WebCore::HTMLMediaElement::pause):
              (WebCore::HTMLMediaElement::checkIfSeekNeeded):
              (WebCore::HTMLMediaElement::movieDidEnd):
              (WebCore::HTMLMediaElement::updatePlayState):
              * html/HTMLMediaElement.h:
      
      LayoutTests:
      
              Reviewed by Adele.
              
              - add HTTP media test for stalling load
              - update tests that don't specifically test autoplay feature to not use autoplay 
                attribute since playback may start before event listeners are registered
      
              * http/tests/media: Added.
              * http/tests/media/video-load-and-stall.cgi: Added.
              * http/tests/media/video-play-stall-expected.txt: Added.
              * http/tests/media/video-play-stall.html: Added.
              * media/video-autoplay.html:
              * media/video-dom-loopstart.html:
              * media/video-end.html:
              * media/video-loopcount.html:
              * media/video-loopend.html:
              * media/video-loopstart.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49ca7acf
    • antti@apple.com's avatar
      Reviewed by Adele. · 17087274
      antti@apple.com authored
              
              Add support for http media tests
      
              * Scripts/run-webkit-tests:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17087274
    • ap@webkit.org's avatar
      Windows build fix. · fea413a1
      ap@webkit.org authored
              * bindings/c/c_utility.cpp:
              (KJS::Bindings::convertUTF8ToUTF16):
              * kjs/ustring.cpp:
              (KJS::UString::UTF8String):
              * wtf/unicode/UTF8.cpp:
              (WTF::Unicode::ConvertUTF8ToUTF16):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fea413a1
    • sfalken@apple.com's avatar
      Add IDOMElementPrivate::font() to get an element's font · e9252181
      sfalken@apple.com authored
              as a WebFontDescription.
              
              Reviewed by Darin.
      
              * DOMCoreClasses.cpp:
              (DOMElement::font):
              * DOMCoreClasses.h:
              * Interfaces/DOMPrivate.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9252181
    • sullivan@apple.com's avatar
      WebCore: · ef53d94a
      sullivan@apple.com authored
              Reviewed by Darin.
      
              removed recently-added PreferredType concept; we found a better way to do what
              ths was accomplishing
      
              * bridge/WindowFeatures.h:
              (WebCore::WindowFeatures::WindowFeatures):
              removed definition of PreferredType
                              
              * page/ContextMenuController.cpp:
              (WebCore::openNewWindow):
              removed use of PreferredType
      
      WebKit/mac:
      
              Reviewed by Darin.
      
              removed recently-added PreferredType concept; we found a better way to do what
              ths was accomplishing
      
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::createWindow):
              removed use of PreferredType
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef53d94a
    • sullivan@apple.com's avatar
      Reviewed by Dan Bernstein. · f25caf3a
      sullivan@apple.com authored
              
              - fixed <rdar://problem/5567954> REGRESSION (Safari 2-3): Autofill no longer automatically fills in 
              form fields other than the one you're typing into
      
              * WebCoreSupport/WebEditorClient.mm:
              (selectorForKeyEvent):
              correct the key identifier strings for Tab and Esc; these were updated in WebCore as part of r21445
              but didn't get updated here.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f25caf3a
    • darin@apple.com's avatar
      JavaScriptCore: · 030a6c0e
      darin@apple.com authored
              Reviewed by Geoff.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=11231
                RegExp bug when handling newline characters
                and a number of other differences between PCRE behvior
                and JavaScript regular expressions:
      
                + single-digit sequences like \4 should be treated as octal
                  character constants, unless there is a sufficient number
                  of brackets for them to be treated as backreferences
      
                + \8 turns into the character "8", not a binary zero character
                  followed by "8" (same for 9)
      
                + only the first 3 digits should be considered part of an
                  octal character constant (the old behavior was to decode
                  an arbitrarily long sequence and then mask with 0xFF)
      
                + if \x is followed by anything other than two valid hex digits,
                  then it should simply be treated a the letter "x"; that includes
                  not supporting the \x{41} syntax
      
                + if \u is followed by anything less than four valid hex digits,
                  then it should simply be treated a the letter "u"
      
                + an extra "+" should be a syntax error, rather than being treated
                  as the "possessive quantifier"
      
                + if a "]" character appears immediately after a "[" character that
                  starts a character class, then that's an empty character class,
                  rather than being the start of a character class that includes a
                  "]" character
      
                + a "$" should not match a terminating newline; we could have gotten
                  PCRE to handle this the way we wanted by passing an appropriate option
      
              Test: fast/js/regexp-no-extensions.html
      
              * pcre/pcre_compile.cpp:
              (check_escape): Check backreferences against bracount to catch both
              overflows and things that should be treated as octal. Rewrite octal
              loop to not go on indefinitely. Rewrite both hex loops to match and
              remove \x{} support.
              (compile_branch): Restructure loops so that we don't special-case a "]"
              at the beginning of a character class. Remove code that treated "+" as
              the possessive quantifier.
              (jsRegExpCompile): Change the "]" handling here too.
      
              * pcre/pcre_exec.cpp: (match): Changed CIRC to match the DOLL implementation.
              Changed DOLL to remove handling of "terminating newline", a Perl concept
              which we don't need.
      
              * tests/mozilla/expected.html: Two tests are fixed now:
              ecma_3/RegExp/regress-100199.js and ecma_3/RegExp/regress-188206.js.
              One test fails now: ecma_3/RegExp/perlstress-002.js -- our success before
              was due to a bug (we treated all 1-character numeric escapes as backreferences).
              The date tests also now both expect success -- whatever was making them fail
              before was probably due to the time being close to a DST shift; maybe we need
              to get rid of those tests.
      
      LayoutTests:
      
              Reviewed by Geoff.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=11231
                RegExp bug when handling newline characters and other regular expression
                behavior that is different for JavaScript and PCRE
      
              * fast/js/regexp-no-extensions-expected.txt: Added.
              * fast/js/regexp-no-extensions.html: Added.
              * fast/js/resources/regexp-no-extensions.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      030a6c0e
    • darin@apple.com's avatar
      * kjs/JSImmediate.h: (KJS::JSImmediate::getTruncatedInt32): · 07a09047
      darin@apple.com authored
              Remove too-strong assert that was firing constantly and preventing even basic
              web browsing from working in a debug build. This function is used in many
              cases where the immediate value is not a number; the assertion could perhaps
              be added back later with a bit of reorganization.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07a09047
    • alp@webkit.org's avatar
      2007-11-13 Alp Toker <alp@atoker.com> · f4917c66
      alp@webkit.org authored
              Build fix for breakage to non-Mac builds introduced in r27746.
      
              * kjs/ustring.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4917c66
    • eric@webkit.org's avatar
      2007-11-13 Eric Seidel <eric@webkit.org> · eb641294
      eric@webkit.org authored
              Reviewed by Maciej.
      
              Clean up evaluateToBoolean functions to use inlines instead of copy/paste code
      
              * kjs/JSImmediate.h:
              * kjs/nodes.cpp:
              (KJS::GreaterNode::inlineEvaluateToBoolean):
              (KJS::GreaterNode::evaluate):
              (KJS::LessEqNode::inlineEvaluateToBoolean):
              (KJS::LessEqNode::evaluate):
              (KJS::GreaterEqNode::inlineEvaluateToBoolean):
              (KJS::GreaterEqNode::evaluate):
              (KJS::InNode::evaluateToBoolean):
              (KJS::EqualNode::inlineEvaluateToBoolean):
              (KJS::EqualNode::evaluate):
              (KJS::NotEqualNode::inlineEvaluateToBoolean):
              (KJS::NotEqualNode::evaluate):
              (KJS::StrictEqualNode::inlineEvaluateToBoolean):
              (KJS::StrictEqualNode::evaluate):
              (KJS::NotStrictEqualNode::inlineEvaluateToBoolean):
              (KJS::NotStrictEqualNode::evaluate):
              * kjs/nodes.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb641294
    • ggaren@apple.com's avatar
      Reviewed by Sam Weinig. · 2cffc2c2
      ggaren@apple.com authored
              
              Fixed http://bugs.webkit.org/show_bug.cgi?id=15958
              base64 spends 1.1% of total time checking for special Infinity case
              
              Use a fast character test instead of calling strncmp.
              
              1.1% speedup on string-base64. SunSpider reports a .4% speedup overall;
              Sharks reports only .1%. Who are you going to believe? Huh?
      
              * kjs/ustring.cpp:
              (KJS::UString::toDouble):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2cffc2c2
    • eric@webkit.org's avatar
      2007-11-12 Eric Seidel <eric@webkit.org> · dcb807d9
      eric@webkit.org authored
              Reviewed by Oliver.
      
              Add evaluateToInt32 and evaluateUInt32 methods and deploy them.
              Fix a few missing evaluateToBoolean methods
              Deploy all evaluateTo* functions to more nodes to avoid slowdowns
              http://bugs.webkit.org/show_bug.cgi?id=15950
      
              SunSpider claims this is at least a 1.4% speedup.
      
              * kjs/JSImmediate.h:
              (KJS::JSImmediate::getTruncatedInt32):
              (KJS::JSImmediate::toDouble):
              (KJS::JSImmediate::getUInt32):
              * kjs/nodes.cpp:
              (KJS::ExpressionNode::evaluateToNumber):
              (KJS::ExpressionNode::evaluateToInt32):
              (KJS::ExpressionNode::evaluateToUInt32):
              (KJS::NumberNode::evaluateToInt32):
              (KJS::NumberNode::evaluateToUInt32):
              (KJS::ImmediateNumberNode::evaluateToInt32):
              (KJS::ImmediateNumberNode::evaluateToUInt32):
              (KJS::ResolveNode::evaluate):
              (KJS::ResolveNode::evaluateToNumber):
              (KJS::ResolveNode::evaluateToBoolean):
              (KJS::ResolveNode::evaluateToInt32):
              (KJS::ResolveNode::evaluateToUInt32):
              (KJS::LocalVarAccessNode::evaluateToInt32):
              (KJS::LocalVarAccessNode::evaluateToUInt32):
              (KJS::BracketAccessorNode::evaluateToNumber):
              (KJS::BracketAccessorNode::evaluateToBoolean):
              (KJS::BracketAccessorNode::evaluateToInt32):
              (KJS::BracketAccessorNode::evaluateToUInt32):
              (KJS::DotAccessorNode::inlineEvaluate):
              (KJS::DotAccessorNode::evaluate):
              (KJS::DotAccessorNode::evaluateToNumber):
              (KJS::DotAccessorNode::evaluateToBoolean):
              (KJS::DotAccessorNode::evaluateToInt32):
              (KJS::DotAccessorNode::evaluateToUInt32):
              (KJS::NewExprNode::inlineEvaluate):
              (KJS::NewExprNode::evaluate):
              (KJS::NewExprNode::evaluateToNumber):
              (KJS::NewExprNode::evaluateToBoolean):
              (KJS::NewExprNode::evaluateToInt32):
              (KJS::NewExprNode::evaluateToUInt32):
              (KJS::FunctionCallResolveNode::inlineEvaluate):
              (KJS::FunctionCallResolveNode::evaluate):
              (KJS::FunctionCallResolveNode::evaluateToNumber):
              (KJS::FunctionCallResolveNode::evaluateToBoolean):
              (KJS::FunctionCallResolveNode::evaluateToInt32):
              (KJS::FunctionCallResolveNode::evaluateToUInt32):
              (KJS::LocalVarFunctionCallNode::evaluate):
              (KJS::LocalVarFunctionCallNode::evaluateToNumber):
              (KJS::LocalVarFunctionCallNode::evaluateToBoolean):
              (KJS::LocalVarFunctionCallNode::evaluateToInt32):
              (KJS::LocalVarFunctionCallNode::evaluateToUInt32):
              (KJS::FunctionCallDotNode::evaluate):
              (KJS::FunctionCallDotNode::evaluateToNumber):
              (KJS::FunctionCallDotNode::evaluateToBoolean):
              (KJS::FunctionCallDotNode::evaluateToInt32):
              (KJS::FunctionCallDotNode::evaluateToUInt32):
              (KJS::PostDecLocalVarNode::inlineEvaluateToNumber):
              (KJS::PostDecLocalVarNode::evaluateToNumber):
              (KJS::PostDecLocalVarNode::evaluateToBoolean):
              (KJS::PostDecLocalVarNode::evaluateToInt32):
              (KJS::PostDecLocalVarNode::evaluateToUInt32):
              (KJS::typeStringForValue):
              (KJS::UnaryPlusNode::evaluate):
              (KJS::UnaryPlusNode::evaluateToBoolean):
              (KJS::UnaryPlusNode::evaluateToNumber):
              (KJS::UnaryPlusNode::evaluateToInt32):
              (KJS::BitwiseNotNode::inlineEvaluateToInt32):
              (KJS::BitwiseNotNode::evaluate):
              (KJS::BitwiseNotNode::evaluateToNumber):
              (KJS::BitwiseNotNode::evaluateToBoolean):
              (KJS::BitwiseNotNode::evaluateToInt32):
              (KJS::MultNode::evaluateToBoolean):
              (KJS::MultNode::evaluateToInt32):
              (KJS::MultNode::evaluateToUInt32):
              (KJS::DivNode::evaluateToInt32):
              (KJS::DivNode::evaluateToUInt32):
              (KJS::ModNode::evaluateToBoolean):
              (KJS::ModNode::evaluateToInt32):
              (KJS::ModNode::evaluateToUInt32):
              (KJS::AddNode::evaluateToNumber):
              (KJS::AddNode::evaluateToInt32):
              (KJS::AddNode::evaluateToUInt32):
              (KJS::AddNumbersNode::evaluateToInt32):
              (KJS::AddNumbersNode::evaluateToUInt32):
              (KJS::SubNode::evaluateToInt32):
              (KJS::SubNode::evaluateToUInt32):
              (KJS::LeftShiftNode::inlineEvaluateToInt32):
              (KJS::LeftShiftNode::evaluate):
              (KJS::LeftShiftNode::evaluateToNumber):
              (KJS::LeftShiftNode::evaluateToInt32):
              (KJS::RightShiftNode::inlineEvaluateToInt32):
              (KJS::RightShiftNode::evaluate):
              (KJS::RightShiftNode::evaluateToNumber):
              (KJS::RightShiftNode::evaluateToInt32):
              (KJS::UnsignedRightShiftNode::inlineEvaluateToUInt32):
              (KJS::UnsignedRightShiftNode::evaluate):
              (KJS::UnsignedRightShiftNode::evaluateToNumber):
              (KJS::UnsignedRightShiftNode::evaluateToInt32):
              (KJS::LessNode::inlineEvaluateToBoolean):
              (KJS::LessNode::evaluate):
              (KJS::LessNode::evaluateToBoolean):
              (KJS::LessNumbersNode::inlineEvaluateToBoolean):
              (KJS::LessNumbersNode::evaluate):
              (KJS::LessNumbersNode::evaluateToBoolean):
              (KJS::LessStringsNode::inlineEvaluateToBoolean):
              (KJS::LessStringsNode::evaluate):
              (KJS::BitAndNode::evaluate):
              (KJS::BitAndNode::inlineEvaluateToInt32):
              (KJS::BitAndNode::evaluateToNumber):
              (KJS::BitAndNode::evaluateToBoolean):
              (KJS::BitAndNode::evaluateToInt32):
              (KJS::BitXOrNode::inlineEvaluateToInt32):
              (KJS::BitXOrNode::evaluate):
              (KJS::BitXOrNode::evaluateToNumber):
              (KJS::BitXOrNode::evaluateToBoolean):
              (KJS::BitXOrNode::evaluateToInt32):
              (KJS::BitOrNode::inlineEvaluateToInt32):
              (KJS::BitOrNode::evaluate):
              (KJS::BitOrNode::evaluateToNumber):
              (KJS::BitOrNode::evaluateToBoolean):
              (KJS::BitOrNode::evaluateToInt32):
              (KJS::ConditionalNode::evaluateToNumber):
              (KJS::ConditionalNode::evaluateToInt32):
              (KJS::ConditionalNode::evaluateToUInt32):
              (KJS::valueForReadModifyAssignment):
              (KJS::AssignExprNode::evaluate):
              (KJS::AssignExprNode::evaluateToBoolean):
              (KJS::AssignExprNode::evaluateToNumber):
              (KJS::AssignExprNode::evaluateToInt32):
              (KJS::VarDeclNode::handleSlowCase):
              * kjs/nodes.h:
              (KJS::FunctionCallResolveNode::precedence):
              (KJS::AddNode::precedence):
              (KJS::AddNode::):
              (KJS::LessNumbersNode::):
              (KJS::LessStringsNode::):
              * kjs/value.cpp:
              (KJS::JSValue::toInt32SlowCase):
              (KJS::JSValue::toUInt32SlowCase):
              * kjs/value.h:
              (KJS::JSValue::asCell):
              (KJS::JSValue::toInt32):
              (KJS::JSValue::toUInt32):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcb807d9
    • ap@webkit.org's avatar
      Reviewed by Darin. · f263e7d9
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=15953
              Add UTF-8 encoding/decoding to WTF
      
              * kjs/ustring.h: Moved UTF8SequenceLength() and decodeUTF8Sequence() to wtf/unicode.
              * kjs/ustring.cpp: (KJS::UString::UTF8String): Changed this function to take a strict/lenient
              parameter. Callers are not interested in getting decoding results in strict mode, so 
              this allows for bailing out as soon as an error is seen.
      
              * kjs/function.cpp:
              (KJS::encode): Updated for new UString::UTF8String() signature.
      
              * API/JSStringRef.cpp:
              (JSStringCreateWithCharacters): Disambiguate UChar.
              (JSStringCreateWithUTF8CString): Actually use UTF-8 when creating the string!
              * bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Use ConvertUTF8ToUTF16().
      
              * wtf/unicode/UTF8.cpp: Added.
              (WTF::Unicode::inlineUTF8SequenceLengthNonASCII):
              (WTF::Unicode::inlineUTF8SequenceLength):
              (WTF::Unicode::UTF8SequenceLength):
              (WTF::Unicode::decodeUTF8Sequence):
              (WTF::Unicode::):
              (WTF::Unicode::ConvertUTF16ToUTF8):
              (WTF::Unicode::isLegalUTF8):
              (WTF::Unicode::ConvertUTF8ToUTF16):
              * wtf/unicode/UTF8.h: Added.
              (WTF::Unicode::):
              Some code moved from ustring.h, some adapted from unicode.org sources.
      
              * JavaScriptCore.exp:
              * JavaScriptCore.pri:
              * JavaScriptCore.vcproj/WTF/WTF.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * JavaScriptCoreSources.bkl:
              Added UTF8.{h,cpp}
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f263e7d9
  2. 12 Nov, 2007 22 commits
    • weinig@apple.com's avatar
      JavaScriptCore: · 16d9491e
      weinig@apple.com authored
              Reviewed by Darin.
      
              - http://bugs.webkit.org/show_bug.cgi?id=15946
                add NPPValue NPPVpluginDrawingModel (Mozilla bug 403418 compat)
      
              * bindings/npapi.h:
      
      WebKit/mac:
      
              Reviewed by Darin.
      
              - http://bugs.webkit.org/show_bug.cgi?id=15946
                add NPPValue NPPVpluginDrawingModel (Mozilla bug 403418 compat)
      
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView setVariable:value:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16d9491e
    • ap@webkit.org's avatar
      Reviewed by Darin. · fbc55832
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=15954
              Move DOM Selection operations out of SelectionController
      
              No change in functionality.
      
      WebCore:
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::setSelectedRange):
              * editing/SelectionController.h:
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::anchorNode):
              (WebCore::DOMSelection::baseNode):
              (WebCore::DOMSelection::anchorOffset):
              (WebCore::DOMSelection::baseOffset):
              (WebCore::DOMSelection::focusNode):
              (WebCore::DOMSelection::extentNode):
              (WebCore::DOMSelection::focusOffset):
              (WebCore::DOMSelection::extentOffset):
              (WebCore::DOMSelection::isCollapsed):
              (WebCore::DOMSelection::type):
              (WebCore::DOMSelection::rangeCount):
              (WebCore::DOMSelection::collapse):
              (WebCore::DOMSelection::collapseToEnd):
              (WebCore::DOMSelection::collapseToStart):
              (WebCore::DOMSelection::empty):
              (WebCore::DOMSelection::setBaseAndExtent):
              (WebCore::DOMSelection::setPosition):
              (WebCore::DOMSelection::modify):
              (WebCore::DOMSelection::extend):
              (WebCore::DOMSelection::getRangeAt):
              (WebCore::DOMSelection::removeAllRanges):
              (WebCore::DOMSelection::addRange):
              (WebCore::DOMSelection::deleteFromDocument):
              (WebCore::DOMSelection::containsNode):
              (WebCore::DOMSelection::selectAllChildren):
              (WebCore::DOMSelection::toString):
              * page/DOMSelection.h:
              Moved all DOM API methods to DOMSelection; changed SelectionController::setSelectedRange()
              to return its result directly instead of via an ExceptionCode that no caller wanted.
      
              * editing/Editor.cpp:
              (WebCore::Editor::deleteRange):
              (WebCore::Editor::removeFormattingAndStyle):
              (WebCore::Editor::selectComposition):
              (WebCore::Editor::setComposition):
              * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
              Adapted for SelectionController::setSelectedRange() now returning a bool.
              SelectionController::toString() is no longer avasilable, use plainText() explicitly.
      
              * WebCore.base.exp: Changed SelectionController::setSelectedRange() signature.
      
      WebKit:
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _expandSelectionToGranularity:]):
              (-[WebHTMLView selectToMark:]):
              (-[WebHTMLView swapWithMark:]):
              * WebView/WebView.mm:
              (-[WebView setSelectedDOMRange:affinity:]):
              Adapted for SelectionController::setSelectedRange() now returning a bool.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbc55832
    • mitz@apple.com's avatar
      WebCore: · 698099cc
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - <http://bugs.webkit.org/show_bug.cgi?id=15890>
                Most of www.aol.com still redraws unnecessarily when headline/photo section changes
      
              Test: fast/repaint/invisible-objects.html
      
              Avoid repainting invisible blocks if they are enclosed in a layer that
              contains no visible objects.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::layoutBlock):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::absoluteClippedOverflowRect):
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - no-repaint test for <http://bugs.webkit.org/show_bug.cgi?id=15890>
                Most of www.aol.com still redraws unnecessarily when headline/photo section changes
      
              * fast/repaint/invisible-objects.html: Added.
              * platform/mac/fast/repaint/invisible-objects-expected.checksum: Added.
              * platform/mac/fast/repaint/invisible-objects-expected.png: Added.
              * platform/mac/fast/repaint/invisible-objects-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      698099cc
    • oliver@apple.com's avatar
      <rdar://problem/5537289> REGRESSION: Dragging a link or an image from an... · 346107ea
      oliver@apple.com authored
      <rdar://problem/5537289> REGRESSION: Dragging a link or an image from an IFrame causes the page to not respond to clicks afterwards (15460)
      
      Reviewed by John S.
      
      EventHandler needs to reset these fields when a drag terminates, otherwise
      EventHandler is left in an inconsistent state when a drag is initiated on a
      page with multiple frames.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      346107ea
    • wsiegrist@apple.com's avatar
      · 6778a7f1
      wsiegrist@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6778a7f1
    • wsiegrist@apple.com's avatar
      test 4 · bcf6d8be
      wsiegrist@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcf6d8be
    • wsiegrist@apple.com's avatar
      3 · 2a1d80c6
      wsiegrist@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27739 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a1d80c6
    • wsiegrist@apple.com's avatar
      2++ · 5462d1e1
      wsiegrist@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5462d1e1
    • wsiegrist@apple.com's avatar
      take 2 · 3daf975e
      wsiegrist@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3daf975e
    • wsiegrist@apple.com's avatar
      testing post-commit. · c58e50d9
      wsiegrist@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c58e50d9
    • timothy@apple.com's avatar
      Reviewed by Mark Rowe. · ce64f8a3
      timothy@apple.com authored
              Prevent selecting a word in the breadcrumb or the styles section when double
              clicking on a DOM node in the outline tree.
      
              * page/inspector/DocumentPanel.js: Call preventDefault() when a mousedown event
                with a detail of 2 or higher comes in. This prevents the selection.
              * page/inspector/inspector.css: Mark the breadcrumb as user-select: none.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce64f8a3
    • weinig@apple.com's avatar
      WebKitTools: · 3962570f
      weinig@apple.com authored
              Reviewed by Adam Roben.
      
              Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
      
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (runTest):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setPrivateBrowsingEnabled):
      
      LayoutTests:
      
              Reviewed by Adam Roben.
      
              * platform/win/Skipped: Remove http/tests/security/cross-frame-acdcess-private-browsing.html 
              from the windows skipped list now that LayoutTestController.setPrivateBrowsingEnabled has 
              been implmented.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3962570f
    • darin@apple.com's avatar
      JavaScriptCore: · 0856b869
      darin@apple.com authored
              Reviewed by Sam.
      
              - http://bugs.webkit.org/show_bug.cgi?id=15951
                REGRESSION: assertion failure in regexp match() when running JS tests
      
              Test: fast/js/regexp-many-brackets.html
      
              * pcre/pcre_exec.cpp: (match): Added back accidentally-removed case for
              the BRANUMBER opcode.
      
      LayoutTests:
      
              Reviewed by Sam.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=15951
                REGRESSION: assertion failure in regexp match() when running JS tests
      
              * fast/js/regexp-many-brackets-expected.txt: Added.
              * fast/js/regexp-many-brackets.html: Added.
              * fast/js/resources/regexp-many-brackets.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0856b869
    • oliver@apple.com's avatar
      Return behaviour for 0 sized pattern back to what it was prior to r27704 · 9c61d803
      oliver@apple.com authored
      Reviewed by Darin and Antti.
      
      This change in behaviour broke two layout tests in DRT, so correcting it
      corrects existing tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c61d803
    • timothy@apple.com's avatar
      Reviewed by John. · 8af3894b
      timothy@apple.com authored
              <rdar://problem/5268311> REGRESSION (Safari 2-3): Exception thrown when calling -[WebDataSource subresources]
      
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
              If the SharedBuffer is null insert an empty NSData instead of nil.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8af3894b
    • darin@apple.com's avatar
      Reviewed by Geoff. · 7f984871
      darin@apple.com authored
              - fix use of prefix and config.h, got rid of a few unneeded things in
                the PCRE code; no behavior changes
      
              * API/JSBase.cpp: Added include of config.h.
              * API/JSCallbackConstructor.cpp: Ditto.
              * API/JSCallbackFunction.cpp: Ditto.
              * API/JSCallbackObject.cpp: Ditto.
              * API/JSClassRef.cpp: Ditto.
              * API/JSContextRef.cpp: Ditto.
              * API/JSObjectRef.cpp: Ditto.
              * API/JSStringRef.cpp: Ditto.
              * API/JSValueRef.cpp: Ditto.
      
              * JavaScriptCorePrefix.h: Removed obsolete <ctype.h> workaround.
              Moved new/delete macros after includes, as they are in WebCore's prefix.
              Removed "config.h".
      
              * pcre/dftables.cpp: (main): Changed back to not use a separate maketables
              function. This is needed for PCRE, but not helpful for our use. Also changed
              the tables to all be 128 entries long instead of 256, since only the first
              128 are ever used.
      
              * pcre/pcre_compile.cpp: Added include of config.h. Eliminated digitab,
              which was only being used to check hex digits. Changed all uses of TRUE and
              FALSE to use the C++ true and false instead.
              (check_escape): Just the TRUE/FALSE thing.
              (is_counted_repeat): Ditto.
              (could_be_empty_branch): Ditto.
              (get_othercase_range): Ditto.
              (compile_branch): Ditto.
              (compile_regex): Ditto.
              (is_anchored): Ditto.
              (is_startline): Ditto.
              (find_firstassertedchar): Ditto.
              (jsRegExpCompile): Ditto.
      
              * pcre/pcre_exec.cpp: Added include of config.h. Changed all uses of TRUE and
              FALSE to use the C++ true and false instead.
              (match_ref): Just the TRUE/FALSE thing.
              (match): Ditto. Removed some unneeded braces.
              (jsRegExpExecute): Just the TRUE/FALSE thing.
      
              * pcre/pcre_internal.h: Moved the constants needed by dftables.cpp to the top
              of the file instead of the bottom, so they can be used. Also changed the table
              sizes to 128 instead of 256. Removed macro definitions of FALSE and TRUE.
              Set array sizes for all the const arrays. Changed _pcre_utf8_table1_size to
              be a macro instead of a extern int.
      
              * pcre/pcre_maketables.cpp: Removed. It's all in dftables.cpp now.
      
              * pcre/pcre_tables.cpp: Made table sizes explicit.
      
              * pcre/pcre_xclass.cpp: Just the TRUE/FALSE thing.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f984871
    • darin@apple.com's avatar
      Reviewed by Tim. · 34fea3a8
      darin@apple.com authored
              - http://bugs.webkit.org/show_bug.cgi?id=15947
                speed up page loading a bit by inlining
      
              * loader/FrameLoader.cpp: (WebCore::FrameLoader::isLocationChange):
              Factored out the slow case of isScheduledLocationChangePending into this.
      
              * loader/FrameLoader.h:
              (WebCore::FrameLoader::isScheduledLocationChangePending): Added an
              inline check of the far and away most common case, where m_scheduledRedirection
              is 0; the rest is in the isLocationChange function.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34fea3a8
    • oliver@apple.com's avatar
      Appease geoff :D · 91ffc099
      oliver@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91ffc099
    • ggaren@apple.com's avatar
      Rubber-stamped by Oliver Hunt. · 1a1474ef
      ggaren@apple.com authored
              
              Landing a few layout tests from http://bugs.webkit.org/show_bug.cgi?id=14868
              Import variable lookup optimizations from KJS
      
              * fast/js/kde/completion-expected.txt:
              * fast/js/kde/resources/completion.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a1474ef
    • oliver@apple.com's avatar
      <rdar://problem/5522011> The content of the password field of Safari is displayed by reconversion. · 0c86647c
      oliver@apple.com authored
      Reviewed by Darin.
      
      Some input methods (notably Kotoeri) can incorrectly provide
      access to the raw text of a password field.  To work around
      this we forcefully override the inputContext whenever a password
      field is active.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c86647c
    • ggaren@apple.com's avatar
      Rubber-stamped by Oliver Hunt. · d9fffcca
      ggaren@apple.com authored
              
              Landing a few layout tests from http://bugs.webkit.org/show_bug.cgi?id=14868
              Import variable lookup optimizations from KJS
      
              * fast/js/kde/lval-exceptions-expected.txt: Added.
              * fast/js/kde/lval-exceptions.html: Added.
              * fast/js/kde/operators-expected.txt:
              * fast/js/kde/resources/lval-exceptions.js: Added.
              * fast/js/kde/resources/operators.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9fffcca
    • ggaren@apple.com's avatar
      Rubber-stamped by Oliver Hunt. · c7c3a535
      ggaren@apple.com authored
              
              Landing a few layout tests from http://bugs.webkit.org/show_bug.cgi?id=14868
              Import variable lookup optimizations from KJS
      
              * fast/js/kde/func-decl-expected.txt: Added.
              * fast/js/kde/func-decl.html: Added.
              * fast/js/kde/resources/func-decl.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7c3a535