1. 19 May, 2010 25 commits
    • mrobinson@webkit.org's avatar
      2010-05-19 Martin Robinson <mrobinson@igalia.com> · 78b17a64
      mrobinson@webkit.org authored
              Not reviewed.
      
              Add baselines for new multi-column tests.
      
              * platform/gtk/fast/multicol/column-count-with-rules-expected.txt: Added.
              * platform/gtk/fast/multicol/layers-in-multicol-expected.txt: Added.
              * platform/gtk/fast/multicol/nested-columns-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78b17a64
    • yaar@chromium.org's avatar
      2010-05-19 Justin Schuh <jschuh@chromium.org> · a4b82d8b
      yaar@chromium.org authored
              Reviewed by Adam Barth.
      
              Moving frame.src checks out of the bindings
              https://bugs.webkit.org/show_bug.cgi?id=37815
      
              Moved JavaScript frame.src checks out of bindings and into
              HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
              so ExecState is available inside core DOM. Updated affected bindings
              (except for GObject, which will need to be updated to avoid origin
              failures inside native code).
      
              * Android.jscbindings.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSBindingsAllInOne.cpp:
              * bindings/js/JSCallbackData.cpp:
              (WebCore::JSCallbackData::invokeCallback):
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSEventListener::handleEvent):
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::createInjectedScript):
              * bindings/js/JSMainThreadExecState.cpp: Added.
              * bindings/js/JSMainThreadExecState.h: Added.
              (WebCore::JSMainThreadExecState::currentState):
              (WebCore::JSMainThreadExecState::call):
              (WebCore::JSMainThreadExecState::evaluate):
              (WebCore::JSMainThreadExecState::JSMainThreadExecState):
              (WebCore::JSMainThreadExecState::~JSMainThreadExecState):
              (WebCore::JSMainThreadNullState::JSMainThreadNullState):
              * bindings/js/ScheduledAction.cpp:
              (WebCore::ScheduledAction::executeFunctionInContext):
              (WebCore::ScheduledAction::execute):
              * bindings/js/ScheduledAction.h:
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::evaluateInWorld):
              (WebCore::ScriptController::canAccessFromCurrentOrigin):
              * bindings/js/ScriptController.h:
              * bindings/js/ScriptFunctionCall.cpp:
              (WebCore::ScriptFunctionCall::call):
              * bindings/objc/ObjCEventListener.mm:
              * bindings/objc/WebScriptObject.mm:
              (-[WebScriptObject callWebScriptMethod:withArguments:]):
              (-[WebScriptObject evaluateWebScript:]):
              * bindings/scripts/CodeGeneratorObjC.pm:
              * bindings/scripts/test/ObjC/DOMTestCallback.mm:
              (-[DOMTestCallback callbackWithClass1Param:]):
              (-[DOMTestCallback callbackWithClass2Param:strArg:]):
              (-[DOMTestCallback callbackWithNonBoolReturnType:]):
              (-[DOMTestCallback customCallback:class6Param:]):
              * bindings/scripts/test/ObjC/DOMTestInterface.mm:
              * bindings/scripts/test/ObjC/DOMTestObj.mm:
              (-[DOMTestObj readOnlyIntAttr]):
              (-[DOMTestObj readOnlyStringAttr]):
              (-[DOMTestObj readOnlyTestObjAttr]):
              (-[DOMTestObj intAttr]):
              (-[DOMTestObj setIntAttr:]):
              (-[DOMTestObj longLongAttr]):
              (-[DOMTestObj setLongLongAttr:]):
              (-[DOMTestObj unsignedLongLongAttr]):
              (-[DOMTestObj setUnsignedLongLongAttr:]):
              (-[DOMTestObj stringAttr]):
              (-[DOMTestObj setStringAttr:]):
              (-[DOMTestObj testObjAttr]):
              (-[DOMTestObj setTestObjAttr:]):
              (-[DOMTestObj attrWithException]):
              (-[DOMTestObj setAttrWithException:]):
              (-[DOMTestObj attrWithSetterException]):
              (-[DOMTestObj setAttrWithSetterException:]):
              (-[DOMTestObj attrWithGetterException]):
              (-[DOMTestObj setAttrWithGetterException:]):
              (-[DOMTestObj customAttr]):
              (-[DOMTestObj setCustomAttr:]):
              (-[DOMTestObj scriptStringAttr]):
              (-[DOMTestObj voidMethod]):
              (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj intMethod]):
              (-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj objMethod]):
              (-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj methodThatRequiresAllArgs:objArg:]):
              (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
              (-[DOMTestObj serializedValue:]):
              (-[DOMTestObj methodWithException]):
              (-[DOMTestObj customMethod]):
              (-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj customArgsAndException:]):
              (-[DOMTestObj addEventListener:listener:useCapture:]):
              (-[DOMTestObj removeEventListener:listener:useCapture:]):
              (-[DOMTestObj withDynamicFrame]):
              (-[DOMTestObj withDynamicFrameAndArg:]):
              (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
              (-[DOMTestObj withDynamicFrameAndUserGesture:]):
              (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
              (-[DOMTestObj withScriptStateVoid]):
              (-[DOMTestObj withScriptStateObj]):
              (-[DOMTestObj withScriptStateVoidException]):
              (-[DOMTestObj withScriptStateObjException]):
              (-[DOMTestObj methodWithOptionalArg:]):
              (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
              (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::canAccessFromCurrentOrigin):
              * bindings/v8/ScriptController.h:
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::isURLAllowed):
      2010-05-19  Justin Schuh  <jschuh@chromium.org>
      
              Reviewed by Adam Barth.
      
              Moving frame.src checks out of the bindings
              https://bugs.webkit.org/show_bug.cgi?id=37815
      
              * http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
              * http/tests/security/xss-DENIED-iframe-src-alias.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4b82d8b
    • chang.shu@nokia.com's avatar
      2010-05-19 Andreas Kling <andreas.kling@nokia.com> · cf579f5e
      chang.shu@nokia.com authored
              Reviewed by Darin Adler.
      
              CanvasRenderingContext2D's property getters that return colors should
              serialize them in accordance with the HTML5 spec (4.8.11.1.4)
              Setters should ignore invalid colors.
      
              Also, shadowColor should initially be transparent black (4.8.11.1.6)
      
              https://bugs.webkit.org/show_bug.cgi?id=38845
      
              Refactored CanvasStyle to store an RGBA32 instead of RGBA components and/or the color string.
      
              Spec links:
              http://www.whatwg.org/specs/web-apps/current-work/#serialization-of-a-color
              http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-shadowcolor
      
              * html/canvas/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::State::State):
              (WebCore::CanvasRenderingContext2D::shadowColor):
              (WebCore::CanvasRenderingContext2D::setShadowColor):
              (WebCore::CanvasRenderingContext2D::setShadow):
              (WebCore::CanvasRenderingContext2D::clearShadow):
              (WebCore::CanvasRenderingContext2D::applyShadow):
              * html/canvas/CanvasRenderingContext2D.h:
              * html/canvas/CanvasStyle.cpp:
              (WebCore::CanvasStyle::CanvasStyle):
              (WebCore::CanvasStyle::create):
              (WebCore::CanvasStyle::applyStrokeColor):
              (WebCore::CanvasStyle::applyFillColor):
              * html/canvas/CanvasStyle.h:
              (WebCore::CanvasStyle::create):
              (WebCore::CanvasStyle::color):
              (WebCore::CanvasStyle::):
              (WebCore::CanvasStyle::CMYKAValues::CMYKAValues):
              * platform/graphics/Color.cpp:
              (WebCore::Color::serialized):
              * platform/graphics/Color.h:
      
      
      2010-05-19  Andreas Kling  <andreas.kling@nokia.com>
      
              Reviewed by Darin Adler.
      
              Added a test to verify proper color serialization in CanvasRenderingContext2D's getters.
              https://bugs.webkit.org/show_bug.cgi?id=38845
      
              Spec link:
              http://www.whatwg.org/specs/web-apps/current-work/#serialization-of-a-color
      
              * fast/canvas/canvas-color-serialization-expected.txt: Added.
              * fast/canvas/canvas-color-serialization.html: Added.
              * fast/canvas/canvas-set-properties-with-non-invertible-ctm-expected.txt: Updated baseline.
              * fast/canvas/script-tests/canvas-color-serialization.js: Added.
              (trySettingStrokeStyle):
              (trySettingFillStyle):
              (trySettingShadowColor):
              (trySettingColor):
              (trySettingStrokeColorWithSetter):
              (trySettingFillColorWithSetter):
              (trySettingShadowWithSetter):
              (trySettingColorWithSetter):
              (trySettingFillColorRGBA):
              (trySettingStrokeColorRGBA):
              (trySettingShadowRGBA):
              (trySettingRGBA):
              (trySettingFillColorCMYKA):
              (trySettingStrokeColorCMYKA):
              (trySettingShadowCMYKA):
              (trySettingCMYKA):
              (trySettingFillColorWithOverrideAlpha):
              (trySettingStrokeColorWithOverrideAlpha):
              (trySettingShadowWithOverrideAlpha):
              (trySettingColorWithOverrideAlpha):
              (trySettingFillColorGrayLevel):
              (trySettingStrokeColorGrayLevel):
              (trySettingShadowGrayLevel):
              (trySettingGrayLevel):
              (trySettingFillColorGrayLevelWithAlpha):
              (trySettingStrokeColorGrayLevelWithAlpha):
              (trySettingShadowGrayLevelWithAlpha):
              (trySettingGrayLevelWithAlpha):
              (tryClearShadowAfterSettingColor):
              (checkDefaultValue):
              * fast/canvas/script-tests/canvas-set-properties-with-non-invertible-ctm.js:
              * fast/dom/canvasContext2d-element-attribute-js-null-expected.txt: Updated baseline.
              * fast/dom/canvasContext2d-element-attribute-js-null.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf579f5e
    • chang.shu@nokia.com's avatar
      2010-05-19 Andreas Kling <andreas.kling@nokia.com> · 92749a8e
      chang.shu@nokia.com authored
              Reviewed by Simon Hausmann.
      
              [Qt] REGRESSION: CoolClock isn't rendered properly
      
              https://bugs.webkit.org/show_bug.cgi?id=38526
      
              CanvasRenderingContext2D's arc() should connect to the previous point
              with a straight line (HTML5 spec 4.8.11.1.8), but if the path is empty
              to begin with, we don't want a line back to (0,0)
              This also fixes the rendering artifact discussed in bug 36226.
      
              Spec link:
              http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc
      
              Test: fast/canvas/canvas-arc-connecting-line.html
      
              * platform/graphics/qt/PathQt.cpp:
              (WebCore::Path::addArc):
      
      2010-05-19  Andreas Kling  <andreas.kling@nokia.com>
      
              Reviewed by Simon Hausmann.
      
              Add test to verify that CanvasRenderingContext2D's arc() connects arcs
              by a straight line (unless it's the first element in the path.)
              https://bugs.webkit.org/show_bug.cgi?id=38526
      
              * fast/canvas/canvas-arc-connecting-line-expected.txt: Added.
              * fast/canvas/canvas-arc-connecting-line.html: Added.
              * fast/canvas/script-tests/canvas-arc-connecting-line.js: Added.
              (deg2rad):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92749a8e
    • abecsi@webkit.org's avatar
      The backtrackParenthesesOnceEnd function should store the start position · a3e99255
      abecsi@webkit.org authored
      of the subpattern's non-greedy match at the place of the subpattern's
      start index in the output array instead of the place of the
      subpattern's end index.
      Add layout test for checking of non-greedy matching of subpattern in
      regular expressions.
      https://bugs.webkit.org/show_bug.cgi?id=39289
      
      Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-05-19
      Reviewed by Darin Adler.
      
      JavaScriptCore: 
      
      * yarr/RegexInterpreter.cpp:
      (JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):
      
      LayoutTests: 
      
      * fast/js/regexp-non-greedy-parentheses-expected.txt: Added.
      * fast/js/regexp-non-greedy-parentheses.html: Added.
      * fast/js/script-tests/regexp-non-greedy-parentheses.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3e99255
    • antti.j.koivisto@nokia.com's avatar
      [Qt] TiledBackingStore updates broken when not using resizesToContents mode · 821a6300
      antti.j.koivisto@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=39359
              
      Rubber-stamped by Kenneth Rohde Christiansen.
      
      Put the back logic that was lost in refactoring.
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::visibleRectForTiledBackingStore):
      * WebCoreSupport/PageClientQt.cpp:
      (WebCore::PageClientQGraphicsWidget::graphicsItemVisibleRect):
      * WebCoreSupport/PageClientQt.h:
      (WebCore::PageClientQWidget::viewResizesToContentsEnabled):
      (WebCore::PageClientQGraphicsWidget::viewResizesToContentsEnabled):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      821a6300
    • eric@webkit.org's avatar
      2010-05-19 Sheriff Bot <webkit.review.bot@gmail.com> · 1f931caa
      eric@webkit.org authored
              Unreviewed, rolling out r59758.
              http://trac.webkit.org/changeset/59758
              https://bugs.webkit.org/show_bug.cgi?id=39361
      
              This patch adds a test that fails on Leopard (Requested by
              abarth on #webkit).
      
              * fast/canvas/webgl/texture-npot-expected.txt:
              * fast/canvas/webgl/texture-npot.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f931caa
    • hausmann@webkit.org's avatar
      Symbian build fix. · ffa75e6f
      hausmann@webkit.org authored
      [Qt] Updated the def file with exports needed for DumpRenderTree.
      
      * symbian/eabi/QtWebKitu.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffa75e6f
    • apavlov@chromium.org's avatar
      2010-05-19 Alexander Pavlov <apavlov@chromium.org> · d946bee4
      apavlov@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              Fix whitespace for the bug 38906
              https://bugs.webkit.org/show_bug.cgi?id=39351
      
              No new tests required (no code change).
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::~CSSParser):
              (WebCore::CSSParser::setupParser):
              (WebCore::CSSParser::parseSheet):
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseSelector):
              (WebCore::unitFromString):
              (WebCore::CSSParser::checkForOrphanedUnits):
              (WebCore::CSSParser::parseWCSSInputProperty):
              (WebCore::CSSParser::parseFillShorthand):
              (WebCore::CSSParser::parseAnimationShorthand):
              (WebCore::CSSParser::parseTransitionShorthand):
              (WebCore::CSSParser::parseShorthand):
              (WebCore::CSSParser::parse4Values):
              (WebCore::CSSParser::parseAttr):
              (WebCore::CSSParser::parseFillPositionXY):
              (WebCore::CSSParser::parseFillPosition):
              (WebCore::CSSParser::parseFillRepeat):
              (WebCore::CSSParser::parseFillProperty):
              (WebCore::CSSParser::parseAnimationTimingFunction):
              (WebCore::CSSParser::parseAnimationProperty):
              (WebCore::CSSParser::parseDashboardRegions):
              (WebCore::CSSParser::parseCounterContent):
              (WebCore::CSSParser::parseShape):
              (WebCore::CSSParser::parseFont):
              (WebCore::CSSParser::parseFontFamily):
              (WebCore::CSSParser::parseFontFaceSrc):
              (WebCore::parseInt):
              (WebCore::CSSParser::parseColor):
              (WebCore::CSSParser::parseShadow):
              (WebCore::CSSParser::parseReflect):
              (WebCore::BorderImageParseContext::commitNumber):
              (WebCore::BorderImageParseContext::commitBorderImage):
              (WebCore::CSSParser::parseBorderImage):
              (WebCore::CSSParser::parseCounter):
              (WebCore::parseGradientPoint):
              (WebCore::parseGradientColorStop):
              (WebCore::CSSParser::parseGradient):
              (WebCore::CSSParser::parseCanvas):
              (WebCore::CSSParser::parseTransform):
              (WebCore::CSSParser::parseTransformOrigin):
              (WebCore::CSSParser::parsePerspectiveOrigin):
              (WebCore::CSSParser::text):
              (WebCore::CSSParser::createRuleList):
              (WebCore::CSSParser::createVariablesRule):
              (WebCore::CSSParser::parseVariable):
              (WebCore::CSSParser::parsePropertyWithResolvedVariables):
              (WebCore::CSSParser::checkForVariables):
              (WebCore::CSSParser::createKeyframeRule):
              * css/CSSParser.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::setFrontend):
              (WebCore::InspectorController::show):
              (WebCore::InspectorController::unbindAllResources):
              (WebCore::InspectorController::didCommitLoad):
              (WebCore::InspectorController::scriptImported):
              (WebCore::InspectorController::getCurrentUserInitiatedProfileName):
              (WebCore::InspectorController::removeBreakpoint):
              (WebCore::drawOutlinedQuad):
              (WebCore::InspectorController::stopTiming):
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::didRemoveDOMNode):
              (WebCore::InspectorDOMAgent::getStyles):
              (WebCore::InspectorDOMAgent::applyStyleText):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d946bee4
    • kenneth@webkit.org's avatar
      When creating the UA, do not sassmue the language code is a · 3bd9398d
      kenneth@webkit.org authored
      two-letter iso639-1 code.
      
      Patch by Denis Dzyubenko <denis.dzyubenko@nokia.com> on 2010-05-19
      Reviewed by Kenneth Rohde Christiansen.
      
      * Api/qwebpage.cpp:
      (QWebPage::userAgentForUrl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bd9398d
    • antti.j.koivisto@nokia.com's avatar
      [Qt] Move visible rect calculation from QGraphicsWebViewPrivate to PageClientQGraphicsWidget · 1e528ad5
      antti.j.koivisto@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=39294
      
      Reviewed by Kenneth Rohde Christiansen.
      
      * Api/qgraphicswebview.cpp:
      * WebCoreSupport/PageClientQt.cpp:
      (WebCore::PageClientQGraphicsWidget::graphicsItemVisibleRect):
      * WebCoreSupport/PageClientQt.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e528ad5
    • eric@webkit.org's avatar
      2010-05-19 Dan Winship <danw@gnome.org> · 75797eb6
      eric@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Install introspection files in our prefix, not
              gobject-introspection's prefix
      
              * GNUmakefile.am:
              * configure.ac:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75797eb6
    • eric@webkit.org's avatar
      2010-05-19 Zhenyao Mo <zmo@google.com> · c32d3816
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              fast/canvas/webgl/texture-npot.html failed on leopard bot
              https://bugs.webkit.org/show_bug.cgi?id=39128
      
              * fast/canvas/webgl/texture-npot-expected.txt: Skip pixel (0, 0); print out actual color when failing.
              * fast/canvas/webgl/texture-npot.html: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c32d3816
    • eric@webkit.org's avatar
      2010-05-19 Steve Block <steveblock@google.com> · 11eb0070
      eric@webkit.org authored
              Reviewed by Nate Chapin.
      
              V8 code generator does not add ENABLE guards around attribute getters and setters
              https://bugs.webkit.org/show_bug.cgi?id=39222
      
              No new tests, build fix only.
      
              * bindings/scripts/CodeGeneratorV8.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11eb0070
    • jorlow@chromium.org's avatar
      2010-05-19 Jeremy Orlow <jorlow@chromium.org> · 950c1a58
      jorlow@chromium.org authored
              Unreviewed build fix for Chromium.
      
              * storage/IndexedDatabaseImpl.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      950c1a58
    • jorlow@chromium.org's avatar
      2010-05-17 Jeremy Orlow <jorlow@chromium.org> · cf3ce045
      jorlow@chromium.org authored
              Reviewed by Darin Fisher.
      
              Hook Chromium's WebIndexedDatabaseImpl up to IndexedDatabaseImpl
              https://bugs.webkit.org/show_bug.cgi?id=39216
      
              All of these functions are supposed to be passing around the origin since
              the caller of IndexedDatabaseImpl might not be able to pass in a Frame*
              object.  I tried to fix this in an ealier patch, but obviously messed up.
      
              Also change passing security origin strings to passing SecurityOrigin
              objects.
      
              No behavior change because Chromium was emulating the old behavior before
              even though the code wasn't properly hooked up.
      
              * storage/IndexedDatabase.h:
              * storage/IndexedDatabaseImpl.cpp:
              (WebCore::IndexedDatabaseImpl::open):
              * storage/IndexedDatabaseImpl.h:
              * storage/IndexedDatabaseRequest.cpp:
              (WebCore::IndexedDatabaseRequest::open):
      2010-05-17  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Darin Fisher.
      
              Hook Chromium's WebIndexedDatabaseImpl up to IndexedDatabaseImpl
              https://bugs.webkit.org/show_bug.cgi?id=39216
      
              Web____Impl is for re-entering the WebKit layer from the browser layer.
              Thus the previous IDBCallbacksProxy was mis-named (and should have been
              WebIDBCallbacksImpl).  This patch renames it and then implements the
              proper proxy (which is for going from WebCore to WebKit).
      
              Also change using security origin strings to using WebSecurityOrigin
              objects.
      
              This patch also implements the glue between WebIndexedDatabaseImpl and
              IndexedDatabaseImpl.
      
              * WebKit.gyp:
              * src/IDBCallbacksProxy.cpp:
              (WebCore::IDBCallbacksProxy::create):
              (WebCore::IDBCallbacksProxy::IDBCallbacksProxy):
              (WebCore::IDBCallbacksProxy::onError):
              (WebCore::IDBCallbacksProxy::onSuccess):
              * src/IDBCallbacksProxy.h:
              * src/IndexedDatabaseProxy.cpp:
              (WebCore::IndexedDatabaseProxy::open):
              * src/IndexedDatabaseProxy.h:
              * src/WebIDBCallbacksImpl.cpp: Added.
              (WebCore::WebIDBCallbacksImpl::WebIDBCallbacksImpl):
              (WebCore::WebIDBCallbacksImpl::~WebIDBCallbacksImpl):
              (WebCore::WebIDBCallbacksImpl::onError):
              (WebCore::WebIDBCallbacksImpl::onSuccess):
              * src/WebIDBCallbacksImpl.h: Added.
              * src/WebIDBDatabaseImpl.cpp: Added.
              (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
              (WebKit::WebIDBDatabaseImpl::~WebIDBDatabaseImpl):
              * src/WebIDBDatabaseImpl.h: Added.
              * src/WebIndexedDatabaseImpl.cpp:
              (WebKit::WebIndexedDatabaseImpl::WebIndexedDatabaseImpl):
              (WebKit::WebIndexedDatabaseImpl::open):
              * src/WebIndexedDatabaseImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf3ce045
    • eric@webkit.org's avatar
      2010-05-19 Ben Murdoch <benm@google.com> · 7aa1ae77
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Touch events are marked DontEnum in DOMWindow.idl
              https://bugs.webkit.org/show_bug.cgi?id=39118
      
              Update the expected results for enumerating the window object
              properties now touch event listeners are no longer marked DontEnum.
      
              * platform/qt/fast/dom/Window/window-properties-expected.txt:
      2010-05-19  Ben Murdoch  <benm@google.com>
      
              Reviewed by Darin Adler.
      
              Touch events are marked DontEnum in DOMWindow.idl
              https://bugs.webkit.org/show_bug.cgi?id=39118
      
              Touch events are the only attribute event listeners on the
              window object that are marked DontEnum. For consistency allow
              them to be enumerated.
      
              * page/DOMWindow.idl: Remove DontEnum from touchcancel, touchend,
                  touchstart and touchmove attributes.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7aa1ae77
    • hausmann@webkit.org's avatar
      [Qt] Fix build warning · 2b3ad06a
      hausmann@webkit.org authored
      NamedAttrMap.h has been renamed to NamedNodeMap.h
      
      * WebCore.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b3ad06a
    • eric@webkit.org's avatar
      2010-05-19 Eric Seidel <eric@webkit.org> · a1aedc1a
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Add an HTML parsing benchmark
              https://bugs.webkit.org/show_bug.cgi?id=39338
      
              This benchmark parses the HTML5 specification 10 times and
              reports how long it takes.  It does this 21 times, discarding
              the first warm-up run, and then prints the average time and
              standard deviation.
      
              Sharking the benchmark correctly shows over 60% of the time spent under HTMLTokenizer::write().
              The numbers from the benchmark are rather consistent.  On my
              Mac Book Pro, I consistently see standard deviations < 2% of total time.
      
              * benchmarks/parser/html-parser.html: Added.
              * benchmarks/parser/resources/html5.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1aedc1a
    • yuzo@google.com's avatar
      2010-05-18 Yuzo Fujishima <yuzo@google.com> · 87d4a841
      yuzo@google.com authored
              Reviewed by Shinichiro Hamaji.
      
              Make CSS Parser properly handle only-for-pages pseudo-classes.
      
              https://bugs.webkit.org/show_bug.cgi?id=38731
      
              * fast/css/misplaced-paged-media-pseudo-expected.txt: Removed.
              * fast/css/misplaced-paged-media-pseudo.html: Removed.
              * printing/page-rule-css-text-expected.txt:
              * printing/page-rule-css-text.html:
              * printing/pseudo-class-outside-page-expected.txt:
              * printing/pseudo-class-outside-page.html:
      2010-05-18  Yuzo Fujishima  <yuzo@google.com>
      
              Reviewed by Shinichiro Hamaji.
      
              Make CSS Parser properly handle only-for-pages pseudo-classes.
      
              A new Match category, PagePseudoClass, is introduced to distinguish
              only-for-pages pseudo-classes from others. A new symbol, pseudo_page,
              is introduced to handle them separately.
      
              https://bugs.webkit.org/show_bug.cgi?id=38731
      
              * css/CSSGrammar.y:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::createMarginAtRule):
              * css/CSSParser.h:
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::extractPseudoType):
              (WebCore::CSSSelector::selectorText):
              * css/CSSSelector.h:
              (WebCore::CSSSelector::):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87d4a841
    • abarth@webkit.org's avatar
      2010-05-19 Adam Barth <abarth@webkit.org> · c0b247de
      abarth@webkit.org authored
              Reviewed by David Hyatt.
      
              Change the API of nextToken to distinguish between emitting a token and just running out of input
              https://bugs.webkit.org/show_bug.cgi?id=39349
      
              I'm not sure there's a functional difference with this patch yet, but
              as discussed with Eric, we need this to handle attributes.
      
              * html/HTML5Lexer.cpp:
              (WebCore::HTML5Lexer::reset):
              (WebCore::HTML5Lexer::nextToken):
              * html/HTML5Lexer.h:
              * html/HTML5Token.h:
              (WebCore::HTML5Token::HTML5Token):
              (WebCore::HTML5Token::clear):
              (WebCore::HTML5Token::beginStartTag):
              (WebCore::HTML5Token::beginEndTag):
              (WebCore::HTML5Token::beginCharacter):
              * html/HTML5Tokenizer.cpp:
              (WebCore::HTML5Tokenizer::write):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0b247de
    • eric@webkit.org's avatar
      2010-05-18 Eric Seidel <eric@webkit.org> · 01c1ac1e
      eric@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Refactor HTMLTokenizer::write to make it more readable and split out the lexer bits from flow control bits
              https://bugs.webkit.org/show_bug.cgi?id=39318
      
              No functional changes, only moving code into smaller functions.
      
              This code is already covered by numerous layout tests.
      
              HTML parsing benchmark shows this to be a wash.
      
              * dom/Tokenizer.h:
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::advance):
               - New funtion to encapulate code which will move into HTMLLexer eventually.
               - Use ALWAYS_INLINE to make sure compilers inline this large
                 function (otherwise this patch is a regression).
              (WebCore::HTMLTokenizer::willWriteHTML):
               - New function to handle calling any pre-write delegates.
              (WebCore::HTMLTokenizer::didWriteHTML):
               - New function to handle calling any post-write delegates.
              (WebCore::HTMLTokenizer::write):
               - Call the new functions.
              * html/HTMLTokenizer.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01c1ac1e
    • alex@webkit.org's avatar
      2010-05-18 Alejandro G. Castro <alex@igalia.com> · b6e58433
      alex@webkit.org authored
              Unreviewed, skip test.
      
              Skipping fast/workers/storage
              https://bugs.webkit.org/show_bug.cgi?id=39346
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6e58433
    • abarth@webkit.org's avatar
      2010-05-18 Adam Barth <abarth@webkit.org> · c2f2b026
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Make the HTML5 parser correctly parse <div>Hello</div>
              https://bugs.webkit.org/show_bug.cgi?id=39345
      
              Again, this patch is covered by a large number of LayoutTests.
      
              * html/HTML5Lexer.cpp:
              (WebCore::HTML5Lexer::HTML5Lexer):
              (WebCore::HTML5Lexer::reset):
              (WebCore::HTML5Lexer::nextToken):
              (WebCore::HTML5Lexer::emitCommentToken):
              (WebCore::HTML5Lexer::emitCharacter):
              (WebCore::HTML5Lexer::emitCurrentTagToken):
              * html/HTML5Lexer.h:
              * html/HTML5Token.h:
              (WebCore::HTML5Token::beginCharacter):
              (WebCore::HTML5Token::appendToCharacter):
              (WebCore::HTML5Token::characters):
              * html/HTML5Tokenizer.cpp:
              (WebCore::convertToOldStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2f2b026
    • barraclough@apple.com's avatar
      Bug 39343 - Dynamically generate a native call thunk per NativeFunction · 8cc46690
      barraclough@apple.com authored
              
      Reviewed by Geoff Garen.
      
      https://bugs.webkit.org/show_bug.cgi?id=39252 regressed performance on i386,
      by adding an extra indirection to making a native call.  By introducing per-
      NativeFunction thunks we can hard code the function pointer into the thunk
      so that it need not be loaded from the callee.
      
      * jit/JIT.h:
      (JSC::JIT::compileCTINativeCall):
      * jit/JITOpcodes.cpp:
      (JSC::JIT::privateCompileCTINativeCall):
      * jit/JITOpcodes32_64.cpp:
      (JSC::JIT::privateCompileCTINativeCall):
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::emitSlow_op_get_by_val):
      * jit/JITPropertyAccess32_64.cpp:
      (JSC::JIT::emitSlow_op_get_by_val):
      * jit/JITStubs.cpp:
      (JSC::JITThunks::ctiStub):
      (JSC::JITThunks::hostFunctionStub):
      * jit/JITStubs.h:
      * jit/SpecializedThunkJIT.h:
      (JSC::SpecializedThunkJIT::finalize):
      * jit/ThunkGenerators.cpp:
      (JSC::charCodeAtThunkGenerator):
      (JSC::charAtThunkGenerator):
      (JSC::fromCharCodeThunkGenerator):
      (JSC::sqrtThunkGenerator):
      (JSC::powThunkGenerator):
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::JSFunction):
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::getHostFunction):
      * runtime/JSGlobalData.h:
      (JSC::JSGlobalData::getCTIStub):
      * runtime/Lookup.cpp:
      (JSC::setUpStaticFunctionSlot):
      * runtime/StringConstructor.cpp:
      (JSC::StringConstructor::StringConstructor):
      * wtf/Platform.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cc46690
  2. 18 May, 2010 15 commits
    • abarth@webkit.org's avatar
      2010-05-18 Adam Barth <abarth@webkit.org> · 59e0d55f
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Make the HTML5 parser actually parse <div></div>
              https://bugs.webkit.org/show_bug.cgi?id=39342
      
              This patch is covered by every LayoutTest.  Yes.  All of them.  :)
      
              * html/HTML5Lexer.cpp:
              (WebCore::toLowerCase):
              (WebCore::HTML5Lexer::HTML5Lexer):
              (WebCore::HTML5Lexer::nextToken):
              (WebCore::HTML5Lexer::emitCharacter):
              * html/HTML5Lexer.h:
              * html/HTML5Token.h:
              (WebCore::HTML5Token::HTML5Token):
              (WebCore::HTML5Token::beginStartTag):
              (WebCore::HTML5Token::beginEndTag):
              (WebCore::HTML5Token::appendToName):
              (WebCore::HTML5Token::type):
              (WebCore::HTML5Token::name):
              (WebCore::HTML5Token::selfClosing):
              (WebCore::HTML5Token::attrs):
              * html/HTML5Tokenizer.cpp:
              (WebCore::convertToOldStyle):
              (WebCore::HTML5Tokenizer::write):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59e0d55f
    • tkent@chromium.org's avatar
      [DRT/Chromium] Fix a repaint issue and textarea tests · d31b2683
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=39054
      
      Reviewed by Dimitri Glazkov.
      
      WebKit/chromium:
      
      * DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion
        and textAreaResizeCorner.png
      * WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
      
      WebKitTools:
      
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::canvas): Remove m_paintRect initialization in canvas().
       This line updated m_paintRect unexpectedly during paintRect().
       We don't need to initialize m_paintRect because show() does it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d31b2683
    • tony@chromium.org's avatar
      2010-05-18 Tony Chang <tony@chromium.org> · 15099a32
      tony@chromium.org authored
              Reviewed by Kent Tamura.
      
              [chromium] new-run-webkit-tests --use-drt should run on Linux
              https://bugs.webkit.org/show_bug.cgi?id=37845
      
              * Scripts/webkitpy/layout_tests/port/chromium.py:
              * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
              * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
              * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
              * Scripts/webkitpy/layout_tests/port/chromium_win.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15099a32
    • ggaren@apple.com's avatar
      JavaScriptCore: Simplified handling of 'arguments' -- 1.2% SunSpider speedup · 83ce11ca
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=39200
              
      Reviewed by Darin Adler.
      
      Removed the reserved OptionalCalleeArguments slot from the CallFrame.
      Now, slots for 'arguments' are allocated and initialized only by
      functions that might need them.
              
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::dump): Updated for new bytecode operands.
      
      (JSC::CodeBlock::CodeBlock):
      * bytecode/CodeBlock.h:
      (JSC::unmodifiedArgumentsRegister): Added a helper function for mapping
      from the arguments register to its unmodified counterpart.
      
      (JSC::CodeBlock::setArgumentsRegister):
      (JSC::CodeBlock::argumentsRegister):
      (JSC::CodeBlock::usesArguments):  Changed from a "usesArguments" bool to
      an optional int index representing the arguments register.
      
      * bytecode/Opcode.h: Updated for new bytecode operands.
      
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::addVar): Factored out a helper function for
      allocating an anonymous var.
      
      (JSC::BytecodeGenerator::BytecodeGenerator): Merged / simplified some
      arguments vs activation logic, and added code to allocate the arguments
      registers when needed.
      
      (JSC::BytecodeGenerator::createArgumentsIfNecessary): Updated for new bytecode operands.
      
      (JSC::BytecodeGenerator::emitCallEval): No need to create the arguments
      object before calling eval; the activation object will lazily create the
      arguments object if eval resolves it.
      
      (JSC::BytecodeGenerator::emitReturn): Updated for new bytecode operands.
      
      (JSC::BytecodeGenerator::emitPushScope):
      (JSC::BytecodeGenerator::emitPushNewScope): Ditto emitCallEval.
      
      * bytecompiler/BytecodeGenerator.h:
      (JSC::BytecodeGenerator::addVar): Factored out a helper function for
      allocating an anonymous var.
      
      (JSC::BytecodeGenerator::registerFor): No more need for special handling
      of the arguments registers; they're allocated just like normal registers
      now.
      
      * interpreter/CallFrame.h:
      (JSC::ExecState::callerFrame):
      (JSC::ExecState::init):
      * interpreter/CallFrameClosure.h:
      (JSC::CallFrameClosure::resetCallFrame): Nixed optionalCalleeArguments.
      
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::dumpRegisters):
      (JSC::Interpreter::unwindCallFrame):
      (JSC::Interpreter::privateExecute):
      (JSC::Interpreter::retrieveArguments): Opcodes accessing 'arguments' now
      take operands specifying registers, just like all other opcodes.
      JSActivation::copyRegisters is no longer responsible for tearing off the
      arguments object; instead, the VM is responsible for both.
      
      Also, a behavior change: Each access to f.arguments creates a new object,
      unless f itself uses 'arguments'. This matches Chrome, and is necessary
      for the optimization. f.arguments is a nonstandard, deprecated feature,
      so high fidelity to a given implementation is not necessarily a goal.
      Also, as illustrated by the new test case, the identity of f.arguments
      has been broken since 2008, except in the case where f itself accesses
      f.arguments -- but nobody seemed to notice. So, hopefully this change won't
      break the web.
              
      * interpreter/Register.h: Nixed the special arguments accessor. It's no
      longer needed.
      
      * interpreter/RegisterFile.h:
      (JSC::RegisterFile::):
      * jit/JITCall.cpp:
      (JSC::JIT::compileOpCallInitializeCallFrame):
      (JSC::JIT::compileOpCall):
      * jit/JITOpcodes.cpp:
      (JSC::JIT::emit_op_tear_off_activation):
      (JSC::JIT::emit_op_tear_off_arguments):
      (JSC::JIT::emit_op_create_arguments):
      (JSC::JIT::emit_op_init_arguments):
      * jit/JITOpcodes32_64.cpp:
      (JSC::JIT::emit_op_tear_off_activation):
      (JSC::JIT::emit_op_tear_off_arguments):
      (JSC::JIT::emit_op_create_arguments):
      (JSC::JIT::emit_op_init_arguments): The actual optimization: Removed
      OptionalCalleeArguments from the callframe slot. Now, it doesn't need
      to be initialized for most calls.
      
      * jit/JITStubs.cpp:
      (JSC::DEFINE_STUB_FUNCTION):
      * jit/JITStubs.h:
      (JSC::): Updated stubs to support arbitrary 'arguments' registers,
      instead of hard-coding something in the call frame.
      
      * runtime/Arguments.h:
      (JSC::JSActivation::copyRegisters): Removed some obfuscatory abstraction.
      
      * runtime/Executable.h:
      (JSC::FunctionExecutable::generatedByteCode): Added a helper for accessing
      the 'arguments' register. In a future patch, that kind of data should
      probably move out of CodeBlock and into Executable.
      
      * runtime/JSActivation.cpp:
      (JSC::JSActivation::getOwnPropertySlot):
      (JSC::JSActivation::argumentsGetter):
      * runtime/JSActivation.h: Simplified / fixed access to 'arguments' via
      the activation object. It now implements the same behavior implemented
      by optimized variable access in the VM. This simplifies some other
      things, too -- like eval code generation.
      
      LayoutTests: Simplified handling of 'arguments' -- 1.2% SunSpider speedup
      https://bugs.webkit.org/show_bug.cgi?id=39200
      
      Reviewed by Darin Adler.
      
      * fast/js/function-dot-arguments-expected.txt:
      * fast/js/script-tests/function-dot-arguments.js:
      (argumentsIdentity): Updated to match new behavior.
      
      * fast/js/function-dot-arguments2-expected.txt:
      * fast/js/function-dot-arguments2.html: New tests for some things that
      weren't covered before.
      
      * fast/js/global-recursion-on-full-stack.html: Rejiggered the stack
      usage in this test. Since stack usage is more efficient now, you
      need a slightly different usage pattern to hit the exact thing this
      test wanted to test.
      
      * fast/js/kde/script-tests/function_arguments.js:
      (f): Updated to more specifically test what this was trying to test,
      to avoid just testing the identity of f.arguments.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83ce11ca
    • tkent@chromium.org's avatar
      Unreviewed test fix. · d2d2f504
      tkent@chromium.org authored
      fast/css/pseudo-required-optional-unapplied.html failure with ENABLE_METER_TAG
      https://bugs.webkit.org/show_bug.cgi?id=39341
      
      Remove test elements at the end of the test because dumpAsText() output
      for <meter> depends on ENABLE_METER_TAG.
      
      * fast/css/pseudo-required-optional-unapplied-expected.txt:
      * fast/css/pseudo-required-optional-unapplied.html:
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2d2f504
    • tkent@chromium.org's avatar
    • tony@chromium.org's avatar
      2010-05-18 Tony Chang <tony@chromium.org> · b50d9cb2
      tony@chromium.org authored
              Reviewed by Ojan Vafai.
      
              REGRESSION: crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting in an empty li
              https://bugs.webkit.org/show_bug.cgi?id=38232
      
              * editing/execCommand/crash-indenting-list-item-expected.txt: Added.
              * editing/execCommand/crash-indenting-list-item.html: Added.
      2010-05-18  Tony Chang  <tony@chromium.org>
      
              Reviewed by Ojan Vafai.
      
              REGRESSION: crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting in an empty li
              https://bugs.webkit.org/show_bug.cgi?id=38232
      
              Test: editing/execCommand/crash-indenting-list-item.html
      
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::tryIndentingAsListItem):
              (WebCore::IndentOutdentCommand::indentIntoBlockquote):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59739 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b50d9cb2
    • tkent@chromium.org's avatar
      ':optional' pseudo selector should not be applied to <keygen> and <progress> · 51999eeb
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=39292
      
      Reviewed by Darin Adler.
      
      WebCore:
      
      Test: fast/css/pseudo-required-optional-unapplied.html
      
      * html/HTMLKeygenElement.h:
      (WebCore::HTMLKeygenElement::isOptionalFormControl):
        Add isOptionalFormControl() returning false.
        HTMLKeygenElement inherits HTMLSelectElement, which should return true
        for isOptionalFormControl(). However, <keygen> is not :optional
        according to the standard.
      * html/HTMLProgressElement.h:
        Remove isOptionalFormControl().
      
      LayoutTests:
      
      Add a test for non-optional form elements.
      
      * fast/css/pseudo-required-optional-unapplied-expected.txt: Added.
      * fast/css/pseudo-required-optional-unapplied.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51999eeb
    • tkent@chromium.org's avatar
      2010-05-18 Kent Tamura <tkent@chromium.org> · 97346b66
      tkent@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              [DRT/Chromium] Fix some initialization/reset issues
              https://bugs.webkit.org/show_bug.cgi?id=39281
      
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::reset): Reset m_userStyleSheetLocation.
              * DumpRenderTree/chromium/LayoutTestController.h:
                Remove unused variable, m_workQueueFrozen.
              (LayoutTestController::WorkQueue::WorkQueue): Initialize m_frozen.
              * DumpRenderTree/chromium/TestShell.cpp:
              (TestShell::resetTestController): Reset WebSettings too.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97346b66
    • abarth@webkit.org's avatar
      2010-05-18 Adam Barth <abarth@webkit.org> · e7f162ce
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Implement the DOCTYPE states for the HTML5 lexer
              https://bugs.webkit.org/show_bug.cgi?id=39335
      
              * html/HTML5Lexer.cpp:
              (WebCore::HTML5Lexer::nextToken):
              (WebCore::emitCurrentDoctypeToken):
              * html/HTML5Lexer.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7f162ce
    • tony@chromium.org's avatar
      2010-05-18 Tony Chang <tony@chromium.org> · a4ac98e1
      tony@chromium.org authored
              Reviewed by Ojan Vafai.
      
              [chromium] ignore IME events if the keydown event was prevented
              https://bugs.webkit.org/show_bug.cgi?id=37692
      
              A manual test to verify the IME behavior since the existing methods of
              textInputController test at a lower level than the fix.
      
              * manual-tests/ime-keydown-preventdefault.html: Added.
      2010-05-18  Tony Chang  <tony@chromium.org>
      
              Reviewed by Ojan Vafai.
      
              [chromium] ignore IME events if the keydown event was prevented
              https://bugs.webkit.org/show_bug.cgi?id=37692
      
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::handleCompositionEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4ac98e1
    • weinig@apple.com's avatar
      Fix the build for platforms that don't always include UnusedParam.h · fc68fffb
      weinig@apple.com authored
      * dom/Attribute.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc68fffb
    • morrita@google.com's avatar
      2010-05-18 MORITA Hajime <morrita@google.com> · 2c89b8ce
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              [Chromium] Windows: Determinate progress bar should have glossy overlay
              https://bugs.webkit.org/show_bug.cgi?id=39269
      
              - Moved animation code from RenderThemeChromiumWin to chromium tree
                because it should be behind the theme implementation, which lives
                in chromium tree.
              - Passed current time to the bridge, which will be used to compute
                the state of the theme animation.
      
              No new tests, animation effect can be confirmed only manually.
      
              * platform/chromium/ChromiumBridge.h:
              * rendering/RenderProgress.h:
              (WebCore::RenderProgress::animationStartTime): Added.
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::animationDurationForProgressBar):
              (WebCore::RenderThemeChromiumWin::paintProgressBar):
      2010-05-18  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Kent Tamura.
      
              [Chromium] Windows: Determinate progress bar should have glossy overlay
              https://bugs.webkit.org/show_bug.cgi?id=39269
      
              Changed WebThemeEngine::drawProgressBar() signature to delegate
              theme implementation detail to the engine.
              Chromium side will come to http://crbug.com/44430.
      
              No new tests, animation effect can be confirmed only manually.
      
              * public/WebThemeEngine.h:
              (WebKit::WebThemeEngine::paintProgressBar):
              * src/ChromiumBridge.cpp:
              (WebCore::ChromiumBridge::paintProgressBar):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c89b8ce
    • weinig@apple.com's avatar
      Fix release build. · 9d01a021
      weinig@apple.com authored
      * dom/Attribute.cpp:
      (WebCore::Attribute::unbindAttr):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d01a021
    • weinig@apple.com's avatar
      Move Attr pointer from Attribute to a global HashMap. · cbbbbde5
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=39337
      <rdar://problem/8001168>
      
      Reviewed by Maciej Stachowiak.
      
      Shaves another word off of Attribute.
      
      * dom/Attr.cpp:
      (WebCore::Attr::Attr):
      (WebCore::Attr::~Attr):
      * dom/Attribute.cpp:
      (WebCore::attributeAttrMap):
      (WebCore::Attribute::attr):
      (WebCore::Attribute::createAttrIfNeeded):
      (WebCore::Attribute::bindAttr):
      (WebCore::Attribute::unbindAttr):
      * dom/Attribute.h:
      (WebCore::Attribute::Attribute):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbbbbde5