- 05 Apr, 2013 40 commits
-
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=114028 Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-04-05 Reviewed by Ryosuke Niwa. Source/WebCore: The only remaining usage of the USE(GOOGLEURL) guards is in LinkHashChromium.cpp that will get removed when purging the Source/WebCore/platform/chromium directory. * config.h: Remove the define that was Chromium-specific. * platform/KURL.cpp: (WebCore): (WebCore::KURL::reportMemoryUsage): (WebCore::KURL::isSafeToSendToAnotherThread): * platform/KURL.h: (KURL): * platform/KURLGoogle.cpp: Removed. * platform/KURLGooglePrivate.h: Removed. Source/WebKit/blackberry: * WebCoreSupport/AboutDataUseFeatures.in: Remove GOOGLEURL from the list. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zoltan@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=111594 Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-04-05 Reviewed by David Hyatt. Source/WebCore: Swapping the bases was causing any floats in the right base to be lost, so change the code so that it no longer swaps the bases. Test: fast/ruby/float-object-doesnt-crash.html * rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::removeChild): Don't swap the bases anymore. LayoutTests: Add test to verify that the use-after-free is fixed. Note that it will only crash when run under a memory checking tool like ASAN. * fast/ruby/float-object-doesnt-crash-expected.txt: Added. * fast/ruby/float-object-doesnt-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=114043 Reviewed by Beth Dakin. * platform/PublicSuffix.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=114039 Reviewed by Antti Koivisto. * workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts): * workers/WorkerLoaderProxy.h: * workers/WorkerMessagingProxy.cpp: (WebCore::WorkerContextProxy::create): * workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::WorkerScriptLoader): (WebCore::WorkerScriptLoader::createResourceRequest): * workers/WorkerScriptLoader.h: * workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): * workers/chromium/WorkerContextProxyChromium.cpp: Removed. * workers/chromium/WorkerContextProxyChromium.h: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=114015 Reviewed by Andreas Kling. Removed. * plugins/chromium: Removed. * plugins/chromium/PluginDataChromium.cpp: Removed. * plugins/chromium/PluginDataChromium.h: Removed. * plugins/chromium/PluginListBuilder.cpp: Removed. * plugins/chromium/PluginListBuilder.h: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
ASSERTION FAILED: m_repaintRect == renderer()->clippedOverflowRectForRepaint(renderer()->containerForRepaint()) after r135816 https://bugs.webkit.org/show_bug.cgi?id=103432 Reviewed by Allan Sandfeld Jensen. Remove optimization added in r99752 that attempted to avoid clip rect updates for table cells. As the assertions show, this optimization is not always correct, so remove it. Bug 108272 tracks adding it back in. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositionsAfterScroll): Remove m_canSkipRepaintRectsUpdateOnScroll check when updating clip rects. * rendering/RenderLayer.h: Remove the m_canSkipRepaintRectsUpdateOnScroll bit. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
betravis@adobe.com authored
[css exclusions] Dynamically removing shape-inside should cause relayout of child blocks' inline content https://bugs.webkit.org/show_bug.cgi?id=111029 Reviewed by David Hyatt. Source/WebCore: Preserve a removed ExclusionShapeInsideInfo for one additional layout pass so that it can notify descendant inline content to relayout. This patch adds a new 'needsRemoval' boolean to ExclusionShapeInsideInfo, which is set when a style change removes but does not replace a shape-inside. When determining whether a block needs to relayout inline children, ExclusionShapeInsideInfos with the needsRemoval boolean set are included, but at other times (such as during inline layout), they are ignored. Added tests to the existing dynamic shape testfile fast/exclusions/shape-inside/shape-inside-dynamic-nested.html * rendering/ExclusionShapeInsideInfo.h: (WebCore::ExclusionShapeInsideInfo::setNeedsRemoval): Get/Set the needsRemoval boolean. (WebCore::ExclusionShapeInsideInfo::needsRemoval): Ditto. (ExclusionShapeInsideInfo): (WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo): Initialize the needsRemoval boolean. * rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): Propagate removed shape insides for layout correctly. You only need to track one at a time, and a removed shape inside should not take precedence over a set shape-inside. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): Set the ExclusionShapeInsideInfo needsRemoval boolean, rather than immediately removing the info. (WebCore::exclusionInfoRequiresRelayout): Account for the needsRemoval boolean as another way of requiring relayout. (WebCore::RenderBlock::updateRegionsAndExclusionsBeforeChildLayout): Look up whether an ExclusionShapeInsideInfo has been removed. (WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout): Remove any ExclusionShapeInsides marked for removal after a layout pass. (WebCore): (WebCore::RenderBlock::layoutBlock): Call the new updateRegionsAndExclusions Before/After methods. * rendering/RenderBlock.h: (WebCore::RenderBlock::exclusionShapeInsideInfo): Filter the result based on whether it should include removed infos. (RenderBlock): * rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Ditto. * rendering/RenderDeprecatedFlexibleBox.cpp: (WebCore::RenderDeprecatedFlexibleBox::layoutBlock): Same as RenderBlock::layoutBlock. * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Ditto. * rendering/RenderGrid.cpp: (WebCore::RenderGrid::layoutBlock): Ditto. LayoutTests: Test that removed shape-insides correctly cause relayout in their blocks' inline content. * fast/exclusions/shape-inside/shape-inside-dynamic-nested-expected.html: * fast/exclusions/shape-inside/shape-inside-dynamic-nested.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cfleizach@apple.com authored
* Scripts/webkitpy/common/config/committers.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=74144 Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-04-05 Reviewed by David Hyatt. Source/WebCore: DOM children of a region must not be rendered as children of the region, but can be collected in flow threads. NodeRenderingContext::parentRenderer now creates the parent render flow thread if it doesn't exist. Element::moveToFlowThreadIsNeeded is a virtual method that is overriden in PseudoElement to return false and in SVGElement so only svg root elements can directly be collected by a render flow thread. RenderObject::canDOMChildrenHaveRenderParent exists to optimize the code so nodes inside regions (and maybe other types of renderers in the future) can still have renderers if they need to be in a flow thread while the rest of renderers that can't have children skip the new instructions. Tests: fast/regions/flow-body-in-html.html . To test the duplicate bug #103685. fast/regions/region-content-flown-into-region.html fast/regions/universal-selector-children-to-the-same-region.html . To test the duplicate bug #103685. * dom/Element.cpp: (WebCore::Element::moveToFlowThreadIsNeeded): * dom/Element.h: * dom/NodeRenderingContext.cpp: (WebCore::NodeRenderingContext::parentRenderer): the renderer that will be the parent for this node's renderer. In the case of RenderFlowThreads, it may need to create it. (WebCore::NodeRenderingContext::shouldCreateRenderer): In a region, only the children that need to be in a flow thread should have a renderer. (WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded): (WebCore::NodeRenderingContext::moveToFlowThread): * dom/NodeRenderingContext.h: (NodeRenderingContext): * dom/PseudoElement.h: pseudo-elements cannot be directly collected into a named flow. * dom/Text.cpp: (WebCore::Text::textRendererIsNeeded): (WebCore::Text::updateTextRenderer): Because calling textRendererIsNeeded(NodeRenderingContext(...)) on a non-const l-value NodeRenderingContext cannot be done on a temporary object on the stack. * dom/Text.h: * rendering/FlowThreadController.cpp: (WebCore::FlowThreadController::isContentNodeRegisteredWithAnyNamedFlow): * rendering/FlowThreadController.h: * rendering/RenderObject.h: (WebCore::RenderObject::canDOMChildrenHaveRenderParent): Even if this render object can't have render children, the children in the DOM tree may have a render parent (that is different from this render object). * rendering/RenderRegion.h: * svg/SVGElement.cpp: (WebCore::SVGElement::moveToFlowThreadIsNeeded): Allow only svg root elements to be directly collected by a render flow thread. * svg/SVGElement.h: (SVGElement): LayoutTests: * fast/regions/flow-body-in-html-expected.txt: Added. * fast/regions/flow-body-in-html.html: Added. To test the duplicate bug #103685. * fast/regions/region-content-flown-into-region-expected.html: Added. * fast/regions/region-content-flown-into-region.html: Added. * fast/regions/universal-selector-children-to-the-same-region-expected.txt: Added. * fast/regions/universal-selector-children-to-the-same-region.html: Added. To test the duplicate bug #103685. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=114037 Reviewed by Allan Sandfeld Jensen. * wtf/CurrentTime.cpp: (WTF): * wtf/DisallowCType.h: * wtf/ExportMacros.h: * wtf/MainThread.cpp: * wtf/Platform.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy@apple.com authored
This fixes an exception on load in the Safari Web Inspector. https://webkit.org/b/114040 rdar://problem/13581422 Reviewed by Anders Carlsson. Source/WebKit/mac: * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Added. Source/WebKit2: * UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::exceededDatabaseQuota): Added. (WebKit::WebInspectorProxy::platformCreateInspectorPage): Hook up exceededDatabaseQuota. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson@apple.com authored
<rdar://problem/13450908> and https://bugs.webkit.org/show_bug.cgi?id=113958 Reviewed by Andy Estes. Add the new accessor: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::contextMenuAtPoint): * WebProcess/WebPage/WebPage.h: Expose the new SPI: * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageCopyContextMenuAtPoint): * WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
allan.jensen@digia.com authored
https://bugs.webkit.org/show_bug.cgi?id=111579 Reviewed by Anders Carlsson. If the destructor is private, MemoryInstrumentation can not create an inherited class. * css/PropertySetCSSStyleDeclaration.h: (StyleRuleCSSStyleDeclaration): * dom/ShadowRoot.h: (ShadowRoot): * loader/SubresourceLoader.h: (SubresourceLoader): * platform/Timer.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
allan.jensen@digia.com authored
https://bugs.webkit.org/show_bug.cgi?id=113506 Reviewed by Noam Rosenthal. This patch creates ShadowBlur objects on demand instead of keeping a single one alive for each GraphicsContext. This matches what other platforms does and fixes the problem with an active shadowblur being affected by changing shadow settings on the GraphicsContext. The method mustUseShadowBlur is moved from ShadowBlur to GraphcisContext, so that it can be used to determine if a ShadowBlur object should even be generated. * platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::hasBlurredShadow): (WebCore::GraphicsContext::mustUseShadowBlur): * platform/graphics/GraphicsContext.h: (GraphicsContext): * platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::ShadowBlur): * platform/graphics/ShadowBlur.h: * platform/graphics/cairo/FontCairo.cpp: (WebCore::drawGlyphsShadow): * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::fillRectWithRoundedHole): * platform/graphics/qt/FontQt.cpp: (WebCore::drawQtGlyphRun): * platform/graphics/qt/GraphicsContextQt.cpp: (GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::fillRectWithRoundedHole): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::clearPlatformShadow): * platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw): * platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=114013 Reviewed by Anders Carlsson. Removed. * page/Console.cpp: (WebCore::Console::time): (WebCore::Console::timeEnd): * page/EventHandler.cpp: (WebCore::shouldGesturesTriggerActive): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore): (WebCore::EventHandler::sendScrollEventToView): * page/FeatureObserver.cpp: (WebCore::FeatureObserver::updateMeasurements): * page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::useSlowRepaints): * page/PageConsole.cpp: * page/PageGroup.cpp: (WebCore::PageGroup::isLinkVisited): (WebCore::PageGroup::addVisitedLink): * page/Settings.cpp: (WebCore): * page/android: Removed. * page/chromium: Removed. * page/chromium/ChromeClientChromium.h: Removed. * page/chromium/DragControllerChromium.cpp: Removed. * page/chromium/EventHandlerChromium.cpp: Removed. * page/scrolling/ScrollingCoordinator.cpp: (WebCore::ScrollingCoordinator::create): (WebCore): * page/scrolling/ScrollingCoordinator.h: (ScrollingCoordinator): * page/scrolling/ScrollingTree.cpp: (WebCore): * page/scrolling/ScrollingTree.h: (ScrollingTree): * page/scrolling/chromium: Removed. * page/scrolling/chromium/ScrollingCoordinatorChromium.cpp: Removed. * page/scrolling/chromium/ScrollingCoordinatorChromium.h: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=114017 Reviewed by Simon Fraser. Removed. * rendering/RenderBlockLineLayout.cpp: (WebCore::setLogicalWidthForTextRun): * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer): (WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer): (WebCore::RenderLayerBacking::requiresScrollCornerLayer): * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::paintContents): (WebCore::shouldCompositeOverflowControls): (WebCore::RenderLayerCompositor::requiresOverhangAreasLayer): * rendering/RenderMediaControlsChromium.cpp: Removed. * rendering/RenderMediaControlsChromium.h: Removed. * rendering/RenderObject.cpp: (WebCore::RenderObject::shouldRespectImageOrientation): * rendering/RenderText.cpp: (WebCore): (WebCore::RenderText::previousOffsetForBackwardDeletion): * rendering/RenderThemeChromiumAndroid.cpp: Removed. * rendering/RenderThemeChromiumAndroid.h: Removed. * rendering/RenderThemeChromiumCommon.cpp: Removed. * rendering/RenderThemeChromiumCommon.h: Removed. * rendering/RenderThemeChromiumDefault.cpp: Removed. * rendering/RenderThemeChromiumDefault.h: Removed. * rendering/RenderThemeChromiumFontProvider.cpp: Removed. * rendering/RenderThemeChromiumFontProvider.h: Removed. * rendering/RenderThemeChromiumFontProviderLinux.cpp: Removed. * rendering/RenderThemeChromiumFontProviderWin.cpp: Removed. * rendering/RenderThemeChromiumMac.h: Removed. * rendering/RenderThemeChromiumMac.mm: Removed. * rendering/RenderThemeChromiumSkia.cpp: Removed. * rendering/RenderThemeChromiumSkia.h: Removed. * rendering/RenderThemeChromiumWin.cpp: Removed. * rendering/RenderThemeChromiumWin.h: Removed. * rendering/RenderThemeMacShared.mm: (WebCore::RenderThemeMacShared::paintSliderThumb): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zhajiang@rim.com authored
https://bugs.webkit.org/show_bug.cgi?id=113963 Patch by Jacky Jiang <zhajiang@rim.com>. Reviewed by Rob Buis. Internally reviewed by Jakob Petsovits. On www.bbc.com/news, we blit wrong rect during the second restoration of the view states when we navigate back from stories to the main page. Update the contents size and scroll position before we render and blit if we failed to zoomAboutPoint so that UI thread can still get the correct rect during blit. * Api/WebPage.cpp: (BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=114026 Patch by Noam Rosenthal <noam@webkit.org> on 2013-04-05 Reviewed by Allan Sandfeld Jensen. Allow the filter's blending function to take place when animating from/to none. * platform/graphics/GraphicsLayerAnimation.cpp: (WebCore::applyFilterAnimation): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=114027 Patch by Noam Rosenthal <noam@webkit.org> on 2013-04-05 Reviewed by Allan Sandfeld Jensen. Allow CoordinatedGraphicsLayer to serialize filter animations to the UI process. Covered by animation tests in css3/filters. * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: (WebCore::CoordinatedGraphicsLayer::addAnimation): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=113449 Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-04-05 Reviewed by Rob Buis. This removes the WebPage/BackingStoreClient family of coordinate transformation functions, which were widely disliked for their naming, with ViewportAccessor API that had previously been introduced for limited use cases. This commit takes care of the remaining call sites and leaves us with a single API to use. No new tests, only a clean-up/refactor of existing code & functionality. * Api/BackingStore.cpp: (BlackBerry::WebKit::BackingStorePrivate::repaint): (BlackBerry::WebKit::BackingStorePrivate::slowScroll): (BlackBerry::WebKit::BackingStorePrivate::visibleContentsRect): (BlackBerry::WebKit::BackingStorePrivate::unclippedVisibleContentsRect): (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents): (BlackBerry::WebKit::BackingStorePrivate::expandedContentsSize): * Api/InRegionScroller.cpp: (BlackBerry::WebKit::InRegionScrollerPrivate::clipToRect): * Api/WebPage.cpp: (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): (BlackBerry::WebKit::WebPagePrivate::init): (BlackBerry::WebKit::WebPagePrivate::scrollPosition): (BlackBerry::WebKit::WebPagePrivate::maximumScrollPosition): (BlackBerry::WebKit::WebPagePrivate::setScrollPosition): (BlackBerry::WebKit::WebPagePrivate::viewportSize): (BlackBerry::WebKit::WebPagePrivate::actualVisibleSize): (BlackBerry::WebKit::WebPagePrivate::layoutFinished): (BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged): (BlackBerry::WebKit::WebPagePrivate::updateCursor): (BlackBerry::WebKit::WebPagePrivate::focusNodeRect): (BlackBerry::WebKit::WebPagePrivate::contextNode): (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode): (BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished): (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent): (BlackBerry::WebKit::WebPage::blockZoom): * Api/WebPage_p.h: (WebPagePrivate): * WebKitSupport/BackingStoreClient.cpp: (BlackBerry::WebKit::BackingStoreClient::transformedScrollPosition): (BlackBerry::WebKit::BackingStoreClient::transformedMaximumScrollPosition): (BlackBerry::WebKit::BackingStoreClient::actualVisibleSize): (BlackBerry::WebKit::BackingStoreClient::transformedActualVisibleSize): * WebKitSupport/BackingStoreClient.h: (BackingStoreClient): * WebKitSupport/FatFingers.cpp: (BlackBerry::WebKit::FatFingers::fingerRectForPoint): (BlackBerry::WebKit::FatFingers::FatFingers): (BlackBerry::WebKit::FatFingers::findBestPoint): (BlackBerry::WebKit::FatFingers::findIntersectingRegions): (BlackBerry::WebKit::FatFingers::getNodesFromRect): * WebKitSupport/InRegionScrollableArea.cpp: (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea): * WebKitSupport/InputHandler.cpp: (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible): * WebKitSupport/TouchEventHandler.cpp: (BlackBerry::WebKit::TouchEventHandler::sendClickAtFatFingersPoint): (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint): (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed): * WebKitSupport/WebKitThreadViewportAccessor.cpp: (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelContentsSize): (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelScrollPosition): (BlackBerry::WebKit::WebKitThreadViewportAccessor::documentViewportSize): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rakuco@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=114031 Reviewed by Alexis Menard. Follow what some other ports already do and avoid globally overriding the `new' and `delete' operators with the ones in FastMalloc. In many cases, third-party or client code allocates memory with standard library calls but the memory gets deleted by FastMalloc, causing a crash. The reverse (ie. memory being allocated by FastMalloc and freed by the system libraries) is also possible. Commits 135666 and 121018 provide more information about this, as well as comment 6 in bug 89358. * wtf/Platform.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ch.dumez@sisa.samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=114030 Reviewed by Noam Rosenthal. Use Vector::add() and leverage its returned AddResult value instead of calling Vector::find() then Vector::set() if the key does not already exist in the map. This results in a single hash lookup instead of two in this case. No new tests, no behavior change. * platform/graphics/texmap/TextureMapperGL.cpp: (WebCore::TextureMapperGLData::SharedGLData::getShaderProgram): (WebCore::TextureMapperGLData::getStaticVBO): (WebCore::TextureMapperGL::drawUsingCustomFilter): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mikhail.pozdnyakov@intel.com authored
https://bugs.webkit.org/show_bug.cgi?id=111075 Reviewed by Andreas Kling. View content position and content scale factor should belong to WebView rather than to EwkView as it decreases EwkView usage inside EFL-agnostic WebView and improves WebView encapsulation. * UIProcess/API/C/efl/WKView.cpp: (WKViewGetContentScaleFactor): (WKViewSetContentScaleFactor): New WKView API was added to set and get content scale factor. The view content scale factor is not the same as page scale factor: it always applies to content but not necessarily applies to the page. The view content scale factor is calculated by viewport controller and applies immediately for painting in UI process. Page scale factor is updated later after the frame is rendered to accomplish the pending scale change. (WKViewGetContentPosition): (WKViewSetContentPosition): New WKView API was added to set and get content position. Content position is set in UI units. * UIProcess/API/C/efl/WKView.h: * UIProcess/API/efl/EwkView.cpp: (EwkView::EwkView): * UIProcess/API/efl/EwkView.h: (EwkView): * UIProcess/efl/PageViewportControllerClientEfl.cpp: (WebKit::PageViewportControllerClientEfl::setViewportPosition): (WebKit::PageViewportControllerClientEfl::setPageScaleFactor): * UIProcess/efl/WebView.cpp: (WebKit::WebView::WebView): (WebKit::WebView::paintToCairoSurface): (WebKit::WebView::transformToScene): (WebKit::WebView::updateViewportSize): (WebKit::WebView::pageDidRequestScroll): * UIProcess/efl/WebView.h: (WebKit::WebView::setContentScaleFactor): (WebKit::WebView::contentScaleFactor): (WebView): (WebKit::WebView::setContentPosition): (WebKit::WebView::contentPosition): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=114022 Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05 Reviewed by Carlos Garcia Campos. Naming the 'time' and 'inClip' unused parameters only produces compiler warnings. * Api/WebOverlay_p.h: (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted): (WebOverlayPrivateWebKitThread): * Api/WebPage_p.h: (BlackBerry::WebKit::WebPagePrivate::notifyAnimationStarted): (BlackBerry::WebKit::WebPagePrivate::paintContents): * WebKitSupport/DefaultTapHighlight.h: (BlackBerry::WebKit::DefaultTapHighlight::notifyAnimationStarted): * WebKitSupport/InspectorOverlayBlackBerry.cpp: (BlackBerry::WebKit::InspectorOverlay::paintContents): * WebKitSupport/InspectorOverlayBlackBerry.h: (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted): (InspectorOverlay): * WebKitSupport/SelectionOverlay.h: (BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=101857 Patch by Aivo Paas <aivopaas@gmail.com> on 2013-04-05 Reviewed by Allan Sandfeld Jensen. Mouse cursor changes in styles used to be reflected in UI through dispatching a fake mousemove event. The old approach has some flaws: it emits a mousemove event in javascript when there is no mouse movement involved (bug 85343); the fake mousemove event is cancelled while there is a mouse button held down - cursor won't change until mouse is moved or the button released (bug 53341). The new approach does not use the fake mousemove event. Instead, it uses only the logic needed for the actual cursor change to happen. EventHandler::selectCursor was refactored to not take a whole mouse event but instead work with HitTestResult so that EventHandler::updateCursor must not create a useless PlatformEvent. Fixes: https://bugs.webkit.org/show_bug.cgi?id=85343 (mousemove event on cursor...
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=114003 Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05 Reviewed by Rob Buis. m_client was replace by m_overlay in r146058. * Api/WebOverlay.cpp: (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jocelyn.turcotte@digia.com authored
https://bugs.webkit.org/show_bug.cgi?id=114020 Reviewed by Simon Hausmann. Both XGetImage and QPainter::drawImage would apply the offset. Since the XImage will only contain the exposed rect, no need to specify the source rect to drawImage. * plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paintUsingXPixmap): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=114009 Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05 Reviewed by Carlos Garcia Campos. These methods were removed in r133517 but were accidentally introduced again in r145968. The previous patch didn't remove them all. * WebKitSupport/DefaultTapHighlight.cpp: * WebKitSupport/DefaultTapHighlight.h: (DefaultTapHighlight): * WebKitSupport/InspectorOverlayBlackBerry.cpp: * WebKitSupport/InspectorOverlayBlackBerry.h: (InspectorOverlay): * WebKitSupport/SelectionOverlay.cpp: * WebKitSupport/SelectionOverlay.h: (SelectionOverlay): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=113991 Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-05 Reviewed by Joseph Pecoraro. * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::innerHighlightQuad): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=113294 Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-05 Reviewed by Xan Lopez. In r145279 NamedGetter extended attribute is added to RTCStatsResponse.idl which makes the code generator to add prototypes for JSRTCStatsResponse::nameGetter and JSRTCStatsResponse::canGetItemsForName to the generated JSRTCStatsResponse header, but they are not implemented anywhere. We need to provide a JSRTCStatsResponseCustom file with the implementation of both functions. * GNUmakefile.list.am: Add JSRTCStatsResponseCustom.cpp to compilation. * Target.pri: Ditto. * UseJSC.cmake: Ditto. * WebCore.vcproj/WebCore.vcproj: Ditto. * WebCore.vcxproj/WebCore.vcxproj: Ditto. * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto. * bindings/js/JSRTCStatsResponseCustom.cpp: Added. (WebCore): (WebCore::JSRTCStatsResponse::canGetItemsForName): (WebCore::JSRTCStatsResponse::nameGetter): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=114011 Reviewed by Benjamin Poulain. Removed. * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::responseReceived): * loader/DocumentThreadableLoader.h: * loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::defaultObjectContentType): (WebCore): * loader/FrameLoader.h: (FrameLoader): * loader/FrameLoaderClient.h: (FrameLoaderClient): * loader/PingLoader.cpp: (WebCore::PingLoader::loadImage): (WebCore::PingLoader::sendPing): (WebCore::PingLoader::sendViolationReport): * loader/ResourceLoadScheduler.cpp: (WebCore): (WebCore::ResourceLoadScheduler::ResourceLoadScheduler): (WebCore::ResourceLoadScheduler::scheduleLoad): * loader/ResourceLoader.h: * loader/SubresourceLoader.h: * loader/ThreadableLoaderClient.h: (ThreadableLoaderClient): * loader/ThreadableLoaderClientWrapper.h: (ThreadableLoaderClientWrapper): * loader/appcache/ApplicationCacheHost.h: (WebCore): (ApplicationCacheHost): * loader/cache/CachedRawResource.h: (CachedRawResource): (WebCore::CachedRawResourceClient::redirectReceived): * loader/cache/CachedResource.cpp: (WebCore): (WebCore::CachedResource::load): * loader/cache/CachedResource.h: (WebCore::CachedResource::didSendData): * loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestResource): (WebCore::CachedResourceLoader::preload): * loader/chromium: Removed. * loader/chromium/CachedRawResourceChromium.cpp: Removed. * loader/chromium/DocumentThreadableLoaderChromium.cpp: Removed. * loader/chromium/ResourceLoaderChromium.cpp: Removed. * loader/chromium/SubresourceLoaderChromium.cpp: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
allan.jensen@digia.com authored
https://bugs.webkit.org/show_bug.cgi?id=112239 Reviewed by Filip Pizlo. Implements LLInt floating point operations in x87, to ensure we support x86 without SSE2. X86 (except 64bit) now defaults to using x87 instructions in order to support all 32bit x86 back to i686. The implementation uses the fucomi instruction from i686 which sets the new minimum. * offlineasm/x86.rb: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=114009 Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05 Reviewed by Carlos Garcia Campos. These methods were removed in r133517 but were accidentally introduced again in r145968. * Api/WebOverlay_p.h: (WebOverlayPrivateWebKitThread): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
* platform/gtk/TestExpectations: Removing a couple of expectations for tests that are now passing. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=114005 Patch by Anthony Scian <ascian@blackberry.com> on 2013-04-05 Reviewed by Carlos Garcia Campos. RIM PR 256522 Internally reviewed by Mike Lattanzio. The pointer returned by lockBufferDrawable can be null, so it needs to be checked first before being used. * Api/WebOverlay.cpp: (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=112961 Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05 Reviewed by Carlos Garcia Campos. There are two new attributes: pluginLoadPolicy and pluginDidFail. * UIProcess/API/gtk/WebKitLoaderClient.cpp: (attachLoaderClientToView): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
benjamin@webkit.org authored
Reviewed by Ryosuke Niwa. .: * GNUmakefile.am: * Source/Platform: Added. * Source/Platform/GNUmakefile.am: Added. Source/Platform: * GNUmakefile.am: Added. * Platform: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mikhail.pozdnyakov@intel.com authored
https://bugs.webkit.org/show_bug.cgi?id=110877 Reviewed by Benjamin Poulain. View states set-up is encapsulated within WebView. This change reduces both usage of EwkView inside WebView class and usage of WebPageProxy inside EwkView class. New WKView API was added so that EwkView can define whether or not the view is visible and focused. * UIProcess/API/C/efl/WKView.cpp: (WKViewIsFocused): (WKViewSetIsFocused): (WKViewIsVisible): (WKViewSetIsVisible): * UIProcess/API/C/efl/WKView.h: * UIProcess/API/efl/EwkView.cpp: (::handleEvent): (EwkView::handleEvasObjectShow): (EwkView::handleEwkViewFocusIn): (EwkView::handleEwkViewFocusOut): * UIProcess/API/efl/EwkView.h: * UIProcess/efl/WebView.cpp: (WebKit::WebView::WebView): (WebKit::WebView::setFocused): (WebKit): (WebKit::WebView::setVisible): (WebKit::WebView::isViewFocused): (WebKit::WebView::isViewVisible): * UIProcess/efl/WebView.h: (WebKit::WebView::isFocused): (WebView): (WebKit::WebView::isVisible): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=114006 Unreviewed, EFL gardening. Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-04-05 * platform/efl-wk1/TestExpectations: * platform/efl-wk2/TestExpectations: * platform/efl/accessibility/aria-option-role-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=114008 Reviewed by Benjamin Poulain. Removed. * editing/EditingBehavior.h: (WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection): * editing/FrameSelection.h: (WebCore): * editing/chromium: Removed. * editing/chromium/EditorChromium.cpp: Removed. * editing/chromium/FrameSelectionChromium.cpp: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-