1. 04 Feb, 2010 40 commits
    • sullivan@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=34611 · 786a5248
      sullivan@apple.com authored
      WebLocalizedString() could use an assertion that it is being called on the main thread
      
      Reviewed by Tim Hatcher.
      
      WebKit: 
      
      * WebKit.xcodeproj/project.pbxproj:
      Updated for renamed file (WebLocalizableStrings.m -> WebLocalizableStrings.mm)
      
      WebKit/mac: 
      
      * Misc/WebLocalizableStrings.m: Removed.
      * Misc/WebLocalizableStrings.mm: Copied from mac/Misc/WebLocalizableStrings.m.
      Renamed to use .mm extension so it can include a C++ header.
      (WebLocalizedString):
      Added an assertion that this is being called on the main thread.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      786a5248
    • eric@webkit.org's avatar
      2010-02-04 Steve Block <steveblock@google.com> · f37d4c0e
      eric@webkit.org authored
              Reviewed by Nate Chapin.
      
              Fix bug in V8 convertNPVariantToJValue when converting float and double types
              https://bugs.webkit.org/show_bug.cgi?id=34593
      
              No new tests, build fix only.
      
              * bridge/jni/v8/JNIUtilityPrivate.cpp: Modified.
              (JSC::Bindings::convertNPVariantToJValue): Modified. Use correct members of 'result' enum.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f37d4c0e
    • darin@chromium.org's avatar
      2010-02-04 Chris Guillory <chris.guillory@google.com> · 45cccd4b
      darin@chromium.org authored
              Reviewed by Darin Fisher.
      
              [Chromium] Notify ChromeClientChromium of AccessibilityObject state
              change notifications.
              
              https://bugs.webkit.org/show_bug.cgi?id=34464
      
              * accessibility/chromium/AXObjectCacheChromium.cpp:
              (WebCore::toChromeClientChromium):
              (WebCore::AXObjectCache::postPlatformNotification):
              * page/chromium/ChromeClientChromium.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45cccd4b
    • eric@webkit.org's avatar
      2010-02-04 Jeremy Moskovich <jeremy@chromium.org> · 9f4bb43e
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Update comments to better document the possible values of the
              writing direction menu state variables.
      
              * public/WebContextMenuData.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f4bb43e
    • loki@webkit.org's avatar
      Use an easily appendable structure for trampolines instead of pointer parameters. · f55a24f5
      loki@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34424
      
      Patch by Tamas Szirbucz <szirbucz@inf.u-szeged.hu> on 2010-02-04
      Reviewed by Gavin Barraclough.
      
      * assembler/ARMAssembler.cpp:
      (JSC::ARMAssembler::executableCopy):
      * jit/JIT.h:
      (JSC::JIT::compileCTIMachineTrampolines):
      * jit/JITOpcodes.cpp:
      (JSC::JIT::privateCompileCTIMachineTrampolines):
      * jit/JITStubs.cpp:
      (JSC::JITThunks::JITThunks):
      * jit/JITStubs.h:
      (JSC::JITThunks::ctiStringLengthTrampoline):
      (JSC::JITThunks::ctiVirtualCallLink):
      (JSC::JITThunks::ctiVirtualCall):
      (JSC::JITThunks::ctiNativeCallThunk):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f55a24f5
    • senorblanco@chromium.org's avatar
      2010-02-04 Stephen White <senorblanco@chromium.org> · 856d9cde
      senorblanco@chromium.org authored
              Unreviewed, build fix for Chromium.
      
              Revert r54341 ("[v8] Remove clear method from DOM object maps"),
              since it causes the worker tests to fail on Chromium.
      
              * bindings/v8/DOMData.h:
              (WebCore::DOMData::removeObjectsFromWrapperMap):
              * bindings/v8/DOMDataStore.h:
              (WebCore::ChunkedTable::clear):
              (WebCore::ChunkedTable::clearEntries):
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clear):
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear):
              * bindings/v8/V8DOMMap.cpp:
              (WebCore::removeAllDOMObjectsInCurrentThreadHelper):
              (WebCore::removeAllDOMObjectsInCurrentThread):
              * bindings/v8/V8DOMMap.h:
              (WebCore::WeakReferenceMap::clear):
              * bindings/v8/WorkerScriptController.cpp:
              (WebCore::WorkerScriptController::~WorkerScriptController):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      856d9cde
    • kevino@webkit.org's avatar
      Build fix after changes in r54345. · fa6547bc
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa6547bc
    • eric@webkit.org's avatar
      2010-02-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 9a588b1e
      eric@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Crashes when an invalid hostname is pre-fetched
              https://bugs.webkit.org/show_bug.cgi?id=34602
      
              * http/tests/misc/dns-prefetch-control-expected.txt:
              * http/tests/misc/dns-prefetch-control.html: Add broken hostname test case.
      2010-02-04  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
      
              Reviewed by Xan Lopez.
      
              [GTK] Crashes when an invalid hostname is pre-fetched
              https://bugs.webkit.org/show_bug.cgi?id=34602
      
              * platform/network/soup/DNSSoup.cpp:
              (WebCore::prefetchDNS): NULL-check the SoupURI that is created
              from the hostname; that will happen for invalid hostnames.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a588b1e
    • bweinstein@apple.com's avatar
      Rubber-stamped by Dan Bernstein. · 5ac6a134
      bweinstein@apple.com authored
      Add Windows expected results to the new scrollbar test because Windows was trying
      to compare to platform/mac first instead of cross-platform.
      
      * platform/win/fast/events/scrollbar-double-click-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ac6a134
    • kenneth@webkit.org's avatar
      Rubberstamped by Oliver Hunt. · 4cf2f20a
      kenneth@webkit.org authored
      [Qt] QtLauncher cleanup.
      
      Refactor option handling out in utility functions and make the
      arguments more Qt compatible.
      
      * QtLauncher/main.cpp:
      (requiresGraphicsView):
      (LauncherApplication::handleUserOptions):
      * QtLauncher/utils.cpp:
      (takeOptionValue):
      (formatKeys):
      (enumToKeys):
      (appQuit):
      * QtLauncher/utils.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cf2f20a
    • bfulgham@webkit.org's avatar
      Properly handle margin settings in WinCairo. · 677ad35f
      bfulgham@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34545
      
      Reviewed by Adam Roben.
      
      * WebFrame.cpp:
      (scaleFactor): Require the margin information as an input
        parameter, and use them when computing the scaling factor.
      (WebFrame::drawHeader): Pass margin size to scaleFactor.
      (WebFrame::drawFooter): Pass margin size to scaleFactor.
      (WebFrame::spoolPage):
        1. Pass margin size to scaleFactor.
        2. Recognize that the return value of printerMarginRect is
           already in device units, and therefore scale it so that
           the Cairo drawing is correct.
        3. Remove scaling call for margins in GDI code, as it is
           already in scaled units.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      677ad35f
    • eric@webkit.org's avatar
      2010-02-04 José Millán Soto <jmillan@igalia.com> · d6b8450e
      eric@webkit.org authored
              Reviewed by Xan Lopez.
      
              [Gtk] webkitgtk crashed when Orca open
              https://bugs.webkit.org/show_bug.cgi?id=34463
      
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (textForObject):
              Checking if render objects are texts before calling toRenderText
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6b8450e
    • xan@webkit.org's avatar
      2010-02-04 Xan Lopez <xlopez@igalia.com> · 501b5efa
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Bump minimum libsoup requirement to 2.29.90
      
              * configure.ac:
      
      WebCore:
      
      2010-02-04  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha.
      
              Set first party URI in all SoupMessages. This allows libsoup to
              implement a "no third party cookies" policy in case it wants
              to. Also start a non-JSC-specific, gtk-specific GOwnPtr module and
              use it for SoupURI.
      
              * platform/network/soup/CookieJarSoup.cpp:
              (WebCore::setCookies):
              * platform/network/soup/ResourceHandleSoup.cpp:
              (WebCore::restartedCallback):
              (WebCore::startHttp):
              * platform/network/soup/ResourceRequestSoup.cpp:
              (WebCore::ResourceRequest::toSoupMessage):
              (WebCore::ResourceRequest::updateFromSoupMessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      501b5efa
    • pfeldman@chromium.org's avatar
      2010-02-04 Pavel Feldman <pfeldman@chromium.org> · cd9d256d
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: group cookies by domains, not frame's domains.
      
              https://bugs.webkit.org/show_bug.cgi?id=34599
      
              * inspector/front-end/CookieItemsView.js:
              (WebInspector.CookieItemsView.prototype._cookiesForDomain):
              * inspector/front-end/inspector.js:
              (WebInspector.updateResource):
              (WebInspector._addCookieDomain):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd9d256d
    • japhet@chromium.org's avatar
      2010-02-04 Nate Chapin <japhet@chromium.org> · 92383b0f
      japhet@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              [V8] Delete V8CustomBinding.h and all references to V8Custom
      
              https://bugs.webkit.org/show_bug.cgi?id=32638
      
              * bindings/v8/NPV8Object.cpp:
              * bindings/v8/V8DOMWindowShell.h:
              * bindings/v8/V8NPObject.cpp:
              * bindings/v8/V8Utilities.cpp:
              * bindings/v8/custom/V8AbstractWorkerCustom.cpp:
              * bindings/v8/custom/V8AttrCustom.cpp:
              * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
              * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
              * bindings/v8/custom/V8ClipboardCustom.cpp:
              * bindings/v8/custom/V8CoordinatesCustom.cpp:
              * bindings/v8/custom/V8CustomBinding.h: Removed.
              * bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              * bindings/v8/custom/V8DataGridColumnListCustom.cpp:
              * bindings/v8/custom/V8DatabaseCustom.cpp:
              * bindings/v8/custom/V8ElementCustom.cpp:
              * bindings/v8/custom/V8EventSourceConstructor.cpp:
              * bindings/v8/custom/V8EventSourceCustom.cpp:
              * bindings/v8/custom/V8GeolocationCustom.cpp:
              * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
              * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
              (WebCore::v8HTMLAudioElementConstructorCallback):
              (WebCore::V8HTMLAudioElementConstructor::GetTemplate):
              * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
              * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp:
              * bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
              * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
              * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
              (WebCore::v8HTMLImageElementConstructorCallback):
              (WebCore::V8HTMLImageElementConstructor::GetTemplate):
              * bindings/v8/custom/V8HTMLInputElementCustom.cpp:
              * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
              (WebCore::v8HTMLOptionElementConstructorCallback):
              (WebCore::V8HTMLOptionElementConstructor::GetTemplate):
              * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
              * bindings/v8/custom/V8HistoryCustom.cpp:
              * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
              * bindings/v8/custom/V8LocationCustom.cpp:
              * bindings/v8/custom/V8MessagePortCustom.cpp:
              * bindings/v8/custom/V8NodeCustom.cpp:
              * bindings/v8/custom/V8NodeFilterCustom.cpp:
              * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
              * bindings/v8/custom/V8SQLTransactionCustom.cpp:
              * bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
              * bindings/v8/custom/V8SVGLengthCustom.cpp:
              * bindings/v8/custom/V8SharedWorkerCustom.cpp:
              * bindings/v8/custom/V8StorageCustom.cpp:
              * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
              * bindings/v8/custom/V8WebGLArrayCustom.h:
              * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
              * bindings/v8/custom/V8WebKitPointConstructor.cpp:
              * bindings/v8/custom/V8WorkerContextCustom.cpp:
              * bindings/v8/custom/V8WorkerCustom.cpp:
              * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
              * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
              * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92383b0f
    • sfalken@apple.com's avatar
      3e1b8a25
    • ariya@webkit.org's avatar
      2010-02-04 Ariya Hidayat <ariya.hidayat@gmail.com> · 212502d0
      ariya@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Unnecessary QBrush construction for doing a solid fill
              https://bugs.webkit.org/show_bug.cgi?id=34559
      
              Use the similar trick like r37421, i.e. use the special brush for
              solid color to avoid creating QBrush again and again.
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::setPlatformFillColor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      212502d0
    • mitz@apple.com's avatar
      REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big · 49682035
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=34371
      
      Reviewed by Simon Fraser.
      
      * platform/mac/fast/events/scrollbar-double-click-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49682035
    • mitz@apple.com's avatar
      REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big · ed850038
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=34371
      
      Reviewed by Simon Fraser.
      
      WebCore: 
      
      Allow ScrollbarTheme to cap the overlap between pages, and set a cap of
      40 in ScrollbarThemeMac.
      
      * WebCore.base.exp: Export Scrollbar::maxOverlapBetweenPages().
      * editing/EditorCommand.cpp:
      (WebCore::verticalScrollDistance): Use Scrollbar methods instead of
      constants, and cap the scroll distance if needed.
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::updateScrollbars): Ditto.
      (WebCore::ScrollView::wheelEvent): Ditto.
      * platform/Scrollbar.cpp:
      (WebCore::Scrollbar::maxOverlapBetweenPages): Added. Returns the
      value from the native scrollbar theme.
      * platform/Scrollbar.h: Replaced scroll amount constants with static methods.
      (WebCore::Scrollbar::pixelsPerLineStep): Replaces cScrollbarPixelsPerLineStep.
      (WebCore::Scrollbar::minFractionToStepWhenPaging): Replaces cFractionToStepWhenPaging.
      * platform/ScrollbarTheme.h:
      (WebCore::ScrollbarTheme::maxOverlapBetweenPages): A base implementation
      that returns the largest int.
      * platform/gtk/WheelEventGtk.cpp:
      (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
      constants.
      * platform/haiku/PlatformWheelEventHaiku.cpp:
      (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
      constants.
      * platform/mac/ScrollbarThemeMac.h:
      (WebCore::ScrollbarThemeMac::maxOverlapBetweenPages): An override
      that returns 40.
      * platform/mac/WheelEventMac.mm:
      (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use
      Scrollbar::pixelsPerLineStep() instead of cScrollbarPixelsPerLineStep.
      * platform/wx/MouseWheelEventWx.cpp:
      (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
      constants.
      * platform/wx/ScrollViewWx.cpp:
      (WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents): Use Scrollbar
      methods instead of constants, and cap the scroll distance if needed.
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::updateScrollInfoAfterLayout): Ditto.
      
      WebKit/mac: 
      
      * WebView/WebFrameView.mm:
      (-[WebFrameView _verticalPageScrollDistance]): Use Scrollbar methods instead of
      constants, and cap the scroll distance.
      (-[WebFrameView initWithFrame:]): Use Scrollbar::pixelsPerLineStep() instead of
      cScrollbarPixelsPerLineStep.
      (-[WebFrameView _horizontalPageScrollDistance]):Use Scrollbar methods instead of
      constants, and cap the scroll distance.
      
      WebKit/wx: 
      
      * WebView.cpp:
      (wxWebView::OnKeyEvents): Use Scrollbar method instead of constant.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed850038
    • eric@webkit.org's avatar
      2010-02-04 No'am Rosenthal <noam.rosenthal@nokia.com> · 09926688
      eric@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              [Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary
              recaching, remove QTimer::singleShot and QPixmap::scaled, more
              accurate strategy of handling transform operation blends. Rotating a
              bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5.
      
              https://bugs.webkit.org/show_bug.cgi?id=34062
      
              This is tested by https://bugs.webkit.org/show_bug.cgi?id=34450, fps measurements.
      
              * platform/graphics/qt/GraphicsLayerQt.cpp:
              (WebCore::GraphicsLayerQtImpl::flushChanges): Fine-tune caching
              (WebCore::TransformAnimationQt::TransformAnimationQt): transform bugs
              (WebCore::OpacityAnimationQt::updateState): style change
      2010-02-04  No'am Rosenthal  <noam.rosenthal@nokia.com>
      
              Reviewed by Ariya Hidayat.
      
              [Qt] Tuning and optimizations to GraphicsLayerQt. Mainly reduced usage
              of QTimer::singleShot, and moved syncLayers() from paint() to update()
              https://bugs.webkit.org/show_bug.cgi?id=34062
      
              * Api/qgraphicswebview.cpp:
              (QGraphicsWebViewPrivate::update): Moved the sync operation to update
              (QGraphicsWebView::paint): Moved the sync operation to update
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09926688
    • pfeldman@chromium.org's avatar
      2010-02-04 Pavel Feldman <pfeldman@chromium.org> · cd102986
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Cookies for resources are not shown in storage panel.
      
              https://bugs.webkit.org/show_bug.cgi?id=34594
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::getCookies):
              * inspector/InspectorResource.cpp:
              (WebCore::InspectorResource::updateScriptObject):
              (WebCore::InspectorResource::cachedResource):
              * inspector/InspectorResource.h:
              (WebCore::InspectorResource::requestURL):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd102986
    • abecsi@webkit.org's avatar
      2010-02-04 Andras Becsi <abecsi@inf.u-szeged.hu> · 648b8512
      abecsi@webkit.org authored
              
              Reviewed by Tor Arne Vestbø.
      
              Implement a locking and scheduling mechanism for http testing sessions to be able
              to run multiple instances of run-webkit-tests parallel on the same machine.
              If a test session wants to run http tests and this feature is enabled, the pending
              sessions create lockfiles with sequential lock numbers. These locks are used to schedule
              the running test sessions in first come first served order. An exclusive lock ensures
              that the lock numbers are sequential to avoid deadlocks and starvation.
              Because the buildbot master specifies the flags used by slaves we need an environment
              variable too to be able to use the feature per-slave.
              Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
              flag enables this feature, otherwise this patch has no effect on the testing whatsoever.
      
              https://bugs.webkit.org/show_bug.cgi?id=33153
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      648b8512
    • eric@webkit.org's avatar
      2010-02-04 Anton Muhin <antonm@chromium.org> · b33af377
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              [v8] Remove clear method from DOM object maps
              https://bugs.webkit.org/show_bug.cgi?id=34530
      
              No new tests. Should be covered by existent testing infrastructure.
      
              * bindings/v8/DOMData.h:
              * bindings/v8/DOMDataStore.h:
              * bindings/v8/V8DOMMap.cpp:
              * bindings/v8/V8DOMMap.h:
              * bindings/v8/WorkerScriptController.cpp:
              (WebCore::WorkerScriptController::~WorkerScriptController):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b33af377
    • eric@webkit.org's avatar
      2010-02-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com> · aa0122fc
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Increase test coverage for the QScriptValue.
      
              https://bugs.webkit.org/show_bug.cgi?id=34533
      
              * qt/tests/qscriptvalue/qscriptvalue.pro:
              * qt/tests/qscriptvalue/tst_qscriptvalue.cpp:
              (tst_QScriptValue::tst_QScriptValue):
              (tst_QScriptValue::~tst_QScriptValue):
              (tst_QScriptValue::dataHelper):
              (tst_QScriptValue::newRow):
              (tst_QScriptValue::testHelper):
              (tst_QScriptValue::ctor):
              * qt/tests/qscriptvalue/tst_qscriptvalue.h: Added.
              * qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: Added.
              (tst_QScriptValue::initScriptValues):
              (tst_QScriptValue::isValid_initData):
              (tst_QScriptValue::isValid_makeData):
              (tst_QScriptValue::isValid_test):
              (tst_QScriptValue::isBool_initData):
              (tst_QScriptValue::isBool_makeData):
              (tst_QScriptValue::isBool_test):
              (tst_QScriptValue::isBoolean_initData):
              (tst_QScriptValue::isBoolean_makeData):
              (tst_QScriptValue::isBoolean_test):
              (tst_QScriptValue::isFunction_initData):
              (tst_QScriptValue::isFunction_makeData):
              (tst_QScriptValue::isFunction_test):
              (tst_QScriptValue::isNull_initData):
              (tst_QScriptValue::isNull_makeData):
              (tst_QScriptValue::isNull_test):
              (tst_QScriptValue::isString_initData):
              (tst_QScriptValue::isString_makeData):
              (tst_QScriptValue::isString_test):
              (tst_QScriptValue::isUndefined_initData):
              (tst_QScriptValue::isUndefined_makeData):
              (tst_QScriptValue::isUndefined_test):
              (tst_QScriptValue::isObject_initData):
              (tst_QScriptValue::isObject_makeData):
              (tst_QScriptValue::isObject_test):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa0122fc
    • vestbo@webkit.org's avatar
      Make run-webkit-tests work under Cygwin for the Qt port · ac3c3e0a
      vestbo@webkit.org authored
      Reviewed by Simon Hausmann.
      
      setPathForRunningWebKitApp() is implemented for the Qt port
      by using qmake to query for the location of the Qt libraries.
      
      This requires the original environment (%ENV) to be untouched,
      so launchWithCurrentEnv() was refactored to launchWithEnv(),
      and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
      instead. This has the added benefit of getting rid of the temp
      variables used for storing the current env.
      
      openDumpTool() is also refactored a bit into platform-spesific,
      port-spesific, and generic environment variables.
      
      Checks for undef was added a few places to fix Perl concat
      warnings when run-webkit-tests is aborted.
      
      https://bugs.webkit.org/show_bug.cgi?id=33895
      
      * Scripts/run-webkit-tests:
      * Scripts/webkitdirs.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac3c3e0a
    • ossy@webkit.org's avatar
      [Qt] fast/workers/shared-worker-frame-lifecycle.html failed on Qt Bot · f597f4df
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34281
      
      * platform/qt/Skipped: fast/workers/shared-worker-frame-lifecycle.html skipped until fix.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f597f4df
    • zecke@webkit.org's avatar
      [Gtk] Check if the renderer() exists in textForObject. · e159d715
      zecke@webkit.org authored
      This is fixing a crash in the textForObject method. It can
      happen when inspecting AtkObjects in the accerciser, then
      navigating to a new page and still inspecting the old tree.
      
      In this case the AccessibilityObjectWrapperAtk was still
      valid but the included renderer() was returning 0. Add a
      check for the accObject->renderer() before trying to use
      the result.
      
      * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
      (textForObject):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e159d715
    • yuzo@google.com's avatar
      2010-02-04 Yuzo Fujishima <yuzo@google.com> · 33abbc12
      yuzo@google.com authored
              Unreviewed.
      
              Add Yuzo to the committers list.
      
              * Scripts/webkitpy/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33abbc12
    • yurys@chromium.org's avatar
      2010-02-04 Yury Semikhatsky <yurys@chromium.org> · bc73633a
      yurys@chromium.org authored
              Unreviewed. Revert 54333 which broke Chromium build.
      
              * WebKit.gyp:
              * tests/TransparencyWinTest.cpp: Removed.
              * tests/UniscribeHelperTest.cpp: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc73633a
    • yurys@chromium.org's avatar
      2010-02-04 Yury Semikhatsky <yurys@chromium.org> · 3cd77106
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Provide strongly typed C++ interface for inspector's injected script.
      
              https://bugs.webkit.org/show_bug.cgi?id=33616
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::injectedScriptFor):
              * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::injectedScriptFor):
              * inspector/InjectedScript.cpp: Added.
              (WebCore::InjectedScript::InjectedScript):
              (WebCore::InjectedScript::dispatch):
              (WebCore::InjectedScript::callFrames):
              (WebCore::InjectedScript::wrapAndStringifyForConsole):
              (WebCore::InjectedScript::releaseWrapperObjectGroup):
              * inspector/InjectedScript.h: Added.
              (WebCore::InjectedScript::InjectedScript):
              (WebCore::InjectedScript::~InjectedScript):
              (WebCore::InjectedScript::hasNoValue):
              * inspector/InjectedScriptHost.cpp:
              (WebCore::InjectedScriptHost::injectedScriptForId):
              (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
              * inspector/InjectedScriptHost.h:
              * inspector/InspectorBackend.cpp:
              (WebCore::InspectorBackend::dispatchOnInjectedScript):
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::~InspectorController):
              (WebCore::InspectorController::inspectedPageDestroyed):
              (WebCore::InspectorController::windowScriptObjectAvailable):
              (WebCore::InspectorController::scriptObjectReady):
              (WebCore::InspectorController::setFrontendProxyObject):
              (WebCore::InspectorController::close):
              (WebCore::InspectorController::getProfile):
              (WebCore::InspectorController::enableDebugger):
              (WebCore::InspectorController::didPause):
              (WebCore::InspectorController::injectedScriptForNodeId):
              * inspector/InspectorController.h:
              (WebCore::InspectorController::frontendScriptState):
              * inspector/InspectorFrontend.cpp:
              (WebCore::InspectorFrontend::addConsoleMessage):
              * inspector/front-end/InjectedScript.js:
              (injectedScriptConstructor):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cd77106
    • eric@webkit.org's avatar
      2010-02-04 Yaar Schnitman <yaar@chromium.org> · f171f5d2
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin.
              https://bugs.webkit.org/show_bug.cgi?id=34509
      
              * WebKit.gyp:
              * tests/TransparencyWinTest.cpp: Added.
              (WebCore::RECTToFloatRect):
              (WebCore::drawNativeRect):
              (WebCore::getPixelAt):
              (WebCore::clearTopLayerAlphaChannel):
              (WebCore::clearTopLayerAlphaPixel):
              (WebCore::operator<<):
              (WebCore::TEST):
              * tests/UniscribeHelperTest.cpp: Added.
              (WebCore::UniscribeTest::UniscribeTest):
              (WebCore::UniscribeTest::MakeFont):
              (WebCore::UniscribeTest::SetUp):
              (WebCore::UniscribeTest::TearDown):
              (WebCore::TEST_F):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f171f5d2
    • philn@webkit.org's avatar
      2010-02-04 Philippe Normand <pnormand@igalia.com> · fd4c808f
      philn@webkit.org authored
              Rubber stamped by Xan Lopez.
      
              Missing include, build fix after landing of patch from the bug 34435.
      
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd4c808f
    • eric@webkit.org's avatar
      2010-02-04 Jeremy Moskovich <jeremy@chromium.org> · aea2b68c
      eric@webkit.org authored
              Reviewed by David Levin.
      
              [Chromium] WebKit side of "Writing direction" context menu on OS X.
              https://bugs.webkit.org/show_bug.cgi?id=34524
      
              * public/WebContextMenuData.h:
              (WebKit::WebContextMenuData::):
              * src/ContextMenuClientImpl.cpp:
              (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aea2b68c
    • philn@webkit.org's avatar
      2010-02-02 Philippe Normand <pnormand@igalia.com> · 59e6a21c
      philn@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              [Gtk] libsoup critical warning in media player http cookies injection code
              https://bugs.webkit.org/show_bug.cgi?id=34435
      
              Fixed the critical warning and refactored the
              User-Agent/Referer/cookies injection code, in that order. Previous
              order (cookies first) was wrong because if cookies injection could
              not be done neither the User-Agent nor Referer were injected. Also
              started a non-JSC-specific, gtk-specific GOwnPtr module.
      
              * GNUmakefile.am:
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::mediaPlayerPrivateSourceChangedCallback):
              * platform/gtk/GOwnPtrGtk.cpp: Added.
              (WTF::SoupURI):
              (WTF::GstElement):
              * platform/gtk/GOwnPtrGtk.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59e6a21c
    • eric@webkit.org's avatar
      2010-02-04 Mikhail Naganov <mnaganov@chromium.org> · 6806da15
      eric@webkit.org authored
              Reviewed by Timothy Hatcher.
      
              Put JSC-specific debugger & profiler code under "USE(JSC)" defines.
              The plan is to enable "JAVASCRIPT_DEBUGGER" in Chromium and then
              make this code engine-agnostic.
      
              https://bugs.webkit.org/show_bug.cgi?id=34531
      
              * inspector/InjectedScriptHost.cpp:
              * inspector/InjectedScriptHost.h:
              * inspector/InspectorBackend.cpp:
              * inspector/InspectorBackend.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::setWindowVisible):
              (WebCore::InspectorController::scriptObjectReady):
              (WebCore::InspectorController::close):
              (WebCore::InspectorController::didCommitLoad):
              * inspector/InspectorController.h:
              * inspector/InspectorFrontend.cpp:
              * inspector/InspectorFrontend.h:
              * inspector/JavaScriptCallFrame.cpp:
              * inspector/JavaScriptCallFrame.h:
              * inspector/JavaScriptDebugListener.h:
              * inspector/JavaScriptDebugServer.cpp:
              * inspector/JavaScriptDebugServer.h:
              * inspector/JavaScriptProfile.cpp:
              * inspector/JavaScriptProfile.h:
              * inspector/JavaScriptProfileNode.cpp:
              * inspector/JavaScriptProfileNode.h:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
              * page/Page.cpp:
              (WebCore::Page::Page):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6806da15
    • dpranke@chromium.org's avatar
      2010-02-03 Dirk Pranke <dpranke@chromium.org> · 478ec5f8
      dpranke@chromium.org authored
              Rubber-stamped by Eric Seidel.
      
              Change "the Chromium name" to "the name of Google Inc." in the licenses
      
              https://bugs.webkit.org/show_bug.cgi?id=34511
      
              * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
              * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
              * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
              * Scripts/webkitpy/layout_tests/port/__init__.py:
              * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
              * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
              * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
              * Scripts/webkitpy/layout_tests/port/chromium_win.py:
              * Scripts/webkitpy/layout_tests/port/http_server.py:
              * Scripts/webkitpy/layout_tests/port/http_server_base.py:
              * Scripts/webkitpy/layout_tests/port/path_utils.py:
              * Scripts/webkitpy/layout_tests/port/websocket_server.py:
              * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
              * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
              * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
              * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
              * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
              * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      478ec5f8
    • dpranke@chromium.org's avatar
      2010-02-03 Dirk Pranke <dpranke@chromium.org> · e1aba0da
      dpranke@chromium.org authored
              Rubber-stamped by Eric Siedel.
      
              Rename files as part of refactoring the layout_tests package. All
              the platform_utils* module, the path_utils.py module, and
              the http server and web socket server modules are moved into a new
              port/ package.
      
              https://bugs.webkit.org/show_bug.cgi?id=34511
      
              * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
              * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
              * Scripts/webkitpy/layout_tests/port/__init__.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
              * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
              * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
              * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
              * Scripts/webkitpy/layout_tests/port/chromium_win.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
              * Scripts/webkitpy/layout_tests/port/http_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/http_server.py.
              * Scripts/webkitpy/layout_tests/port/http_server_base.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
              * Scripts/webkitpy/layout_tests/port/httpd2.pem: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
              * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
              * Scripts/webkitpy/layout_tests/port/path_utils.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
              * Scripts/webkitpy/layout_tests/port/websocket_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
              * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
              * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
              * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
              * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
              * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
              * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1aba0da
    • eric@webkit.org's avatar
      2010-02-03 Nicholas Young <nicholas.young@nokia.com> · c46d2b77
      eric@webkit.org authored
              Reviewed by Eric Carlson.
      
              Defer formatting of times displayed on media controls to the current theme.
              https://bugs.webkit.org/show_bug.cgi?id=34405
      
              No new tests needed. Refactoring Only.
      
              * rendering/MediaControlElements.cpp: Removed formatTime()
              (WebCore::MediaControlTimeDisplayElement::setCurrentValue): No longer sets inner text
              * rendering/MediaControlElements.h:
              * rendering/RenderMedia.cpp:
              (WebCore::RenderMedia::updateTimeDisplay): Asks the theme to format the time display elements
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::formatMediaControlsTime): new virtual method
              (WebCore::RenderTheme::formatMediaControlsCurrentTime): new virtual method
              (WebCore::RenderTheme::formatMediaControlsRemainingTime): new virtual method
              * rendering/RenderTheme.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c46d2b77
    • ukai@chromium.org's avatar
      Unreviewed fix. · 64b8ef61
      ukai@chromium.org authored
      websocket/tests/close-on-unload.html and
      close-on-navigate-new-location.html will fail on mac tiger,
      because python on the platform doesn't support set(), which is
      used in websocket handler for these tests.
      
      * platform/mac-tiger/Skipped: skip websocket/tests/close-on-unload.html and websocket/tests/close-on-navigate-new-location.html
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64b8ef61
    • ukai@chromium.org's avatar
      2010-02-03 Fumitoshi Ukai <ukai@chromium.org> · 73073506
      ukai@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              navigating a frame to new location closes websocket in the frame
              https://bugs.webkit.org/show_bug.cgi?id=34557
      
              * websocket/tests/close-on-navigate-new-location-expected.txt: Added.
              * websocket/tests/close-on-navigate-new-location.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73073506