1. 15 Aug, 2009 2 commits
    • jhoneycutt@apple.com's avatar
      WebCore: · 784612d0
      jhoneycutt@apple.com authored
      2009-08-13  Jon Honeycutt  <jhoneycutt@apple.com>
      
              Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
              nightly (20866)
      
              https://bugs.webkit.org/show_bug.cgi?id=20866
      
              Reviewed by Oliver Hunt.
      
              * accessibility/AXObjectCache.cpp:
              (WebCore::AXObjectCache::AXObjectCache):
              Changed to take a pointer to its owner document. This is used by
              AXObjectCache::handleFocusedUIElementChanged().
              (WebCore::AXObjectCache::focusedUIElementForPage):
              Code moved from AccessibilityRenderObject::focusedUIElement(). Modified
              to be a static function and to take a pointer to a Page.
              (WebCore::AXObjectCache::platformGenerateAXID):
              Moved the code to generate the next AXID from getAXID() to here. Added
              a #if to make this non-WIN only, because Windows has its own
              implementation.
              (WebCore::AXObjectCache::getAXID):
              Ensure that we generate a positive AXID, ranging from 1 to LONG_MAX.
      
              * accessibility/AXObjectCache.h:
              Add a declaration for Document and Page. Removed the declaration of
              AccessibilityObject, because we include the header. Reordered the
              declaration of Node alphabetically. Moved the typedef for AXID to
              AccessibilityObject. Removed some trailing whitespace. Added a member
              variable to hold a pointer to the owner Document.
              (WebCore::AXObjectCache::AXObjectCache):
              Changed to take a pointer to its owner Document.
              (WebCore::AXObjectCache::focusedUIElementForPage):
              Added; code moved from AccessiblityRenderObject::focusedUIElement().
              Returns the focused element with respect to accessibility.
              (WebCore::AXObjectCache::platformGenerateAXID):
              Declare a function to generate an AXID.
              (WebCore::AXObjectCache::objectFromAXID):
              Return the AccessibilityObject with the given AXID.
      
              * accessibility/AccessibilityObject.h:
              Moved the typedef for AXID from AXObjectCache to here. Made the m_id
              member use the typedef.
              (WebCore::AccessibilityObject::axObjectID):
              Changed the return type to use the typedef.
              (WebCore::AccessibilityObject::setAXObjectID):
              Changed the argument type to use the typedef.
      
              * accessibility/AccessibilityRenderObject.cpp:
              Removed some unneeded #includes.
              (WebCore::AccessibilityRenderObject::focusedUIElement):
              Moved the code to AXObjectCache::focusedUIElementForPage(), which we now
              call.
      
              * accessibility/win/AXObjectCacheWin.cpp:
              (WebCore::AXObjectCache::platformGenerateAXID):
              Ensure that we generate an AXID that is in the range 1 to LONG_MAX.
              (WebCore::AXObjectCache::handleFocusedUIElementChanged):
              If the Document has no Page, return. If the Page has not focused
              element (respecting accessibility), return. Assert that the
              accessibility of the focused element is not ignored, and that the
              object's AXID will be negative and fit into a LONG when negated.
              Broadcast a focus event for the object.
      
              * dom/Document.cpp:
              (WebCore::Document::axObjectCache):
              Pass this when creating the AXObjectCache.
              (WebCore::Document::setFocusedNode):
              Call AXObjectCache::handleFocusedUIElementChanged() on Windows.
      
      WebKit/win:
      
      2009-08-13  Jon Honeycutt  <jhoneycutt@apple.com>
      
              Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
              nightly (20866)
      
              https://bugs.webkit.org/show_bug.cgi?id=20866
      
              Reviewed by Oliver Hunt.
      
              * AccessibleBase.cpp:
              (AccessibleBase::getAccessibilityObjectForChild):
              If the child ID is negative, negate it and treat it as an AXID.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      784612d0
    • jmalonzo@webkit.org's avatar
      2009-08-14 Jiahua Huang <jhuangjiahua@gmail.com> · 2e861b43
      jmalonzo@webkit.org authored
              Reviewed by Jan Alonzo.
      
              [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
              https://bugs.webkit.org/show_bug.cgi?id=27028
      
              Remove the improper set of enum WebKitWebViewTargetInfo
              by grabbing the target infos via m_helper.
      
              * manual-tests/gtk/copy-htmltext.html: Added.
              * platform/Pasteboard.h:
              * platform/gtk/PasteboardGtk.cpp:
              (WebCore::clipboard_get_contents_cb):
              * platform/gtk/PasteboardHelper.h:
      
              Add a function in WebKit::PasteboardHelperGtk that will return the
              value of WEBKIT_WEB_VIEW_TARGET_INFO_HTML,
              and WebCore::clipboard_get_contents_cb will use that.
      
              * WebCoreSupport/PasteboardHelperGtk.cpp:
              (WebKit::PasteboardHelperGtk::getWebViewTargetInfoHtml):
              * WebCoreSupport/PasteboardHelperGtk.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e861b43
  2. 14 Aug, 2009 38 commits
    • jmalonzo@webkit.org's avatar
      2009-08-14 Jan Michael Alonzo <jmalonzo@webkit.org> · cbc9843a
      jmalonzo@webkit.org authored
              Rubber-stamped by Gustavo Noronha.
      
              Initialize CFLAGS and CXXFLAGS before the main body of the
              WEBKIT_INIT macro so C files don't get built with "-g -O2".
      
              * autotools/webkit.m4:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbc9843a
    • dimich@chromium.org's avatar
      Not reviewed, adding new test to Skipped on gtk and Qt. · eabe02c8
      dimich@chromium.org authored
      DRT on these ports does not yet support layoutTestController.overridePreference.
      
      * platform/gtk/Skipped: skip LayoutTests/fast/harness/use-page-cache.html
      * platform/qt/Skipped: ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eabe02c8
    • barraclough@apple.com's avatar
      * parser/Parser.h: · 06d67ca0
      barraclough@apple.com authored
      (JSC::EvalExecutable::parse):
      (JSC::ProgramExecutable::parse):
      * runtime/Executable.h:
      
      Reviewed by NOBODY (build fix).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06d67ca0
    • dimich@chromium.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=28324 · d2c9d9fe
      dimich@chromium.org authored
      First ever test using page cache!
      The test verifies that override setting that enables page cache works correctly.
      It navigates forward and then back and checks that onload is not fired again
      but the timer continues firing.
      
      Reviewed by Eric Seidel.
      
      * fast/harness/resources/cached-page-1.html: Added.
      * fast/harness/resources/cached-page-2.html: Added.
      * fast/harness/use-page-cache-expected.txt: Added.
      * fast/harness/use-page-cache.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2c9d9fe
    • simon.fraser@apple.com's avatar
      2009-08-14 Simon Fraser <simon.fraser@apple.com> · d8881fd2
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt.
      
              Fix an assertion when bringing up the Inspector.
              https://bugs.webkit.org/show_bug.cgi?id=28318
      
              The fix for bug 28295 assumed that image clients count the number of times
              addClient/removeClient is called. That was true for CachedResource clients,
              but not StyleGeneratedImage clients, which pass the call onto CSSImageGeneratorValue.
      
              Fix by making CSSImageGeneratorValue count the number of times a client is
              added/removed.
      
              * css/CSSCanvasValue.cpp:
              (WebCore::CSSCanvasValue::canvasChanged):
              (WebCore::CSSCanvasValue::canvasResized):
              * css/CSSImageGeneratorValue.cpp:
              (WebCore::CSSImageGeneratorValue::addClient):
              (WebCore::CSSImageGeneratorValue::removeClient):
              (WebCore::CSSImageGeneratorValue::getImage):
              * css/CSSImageGeneratorValue.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8881fd2
    • barraclough@apple.com's avatar
      Remove AST nodes from use within the Runtime (outside of parsing), stage 1 · 83651156
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=28330
      
      Reviewed by Oliver Hunt.
      
      Remove the EvalNode and ProgramNode from use in the runtime.  They still exist
      after this patch, but are hidden behind EvalExecutable and FunctionExecutable,
      and are also still reachable behind CodeBlock::m_ownerNode.
      
      The next step will be to beat back FunctionBodyNode in the same fashion.
      Then remove the usage via CodeBlock, then only construct these nodes only on
      demand during bytecode generation.
      
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * bytecode/CodeBlock.h:
      (JSC::GlobalCodeBlock::GlobalCodeBlock):
      (JSC::GlobalCodeBlock::~GlobalCodeBlock):
      (JSC::ProgramCodeBlock::ProgramCodeBlock):
      (JSC::EvalCodeBlock::EvalCodeBlock):
      (JSC::FunctionCodeBlock::FunctionCodeBlock):
      (JSC::NativeCodeBlock::NativeCodeBlock):
      * bytecode/EvalCodeCache.h:
      (JSC::EvalCodeCache::get):
      * debugger/Debugger.cpp:
      (JSC::evaluateInGlobalCallFrame):
      * debugger/DebuggerCallFrame.cpp:
      (JSC::DebuggerCallFrame::evaluate):
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::callEval):
      (JSC::Interpreter::execute):
      * interpreter/Interpreter.h:
      * parser/Nodes.cpp:
      (JSC::FunctionBodyNode::createNativeThunk):
      (JSC::FunctionBodyNode::generateBytecode):
      (JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse):
      * parser/Parser.h:
      (JSC::Parser::parse):
      (JSC::Parser::reparse):
      (JSC::Parser::parseFunctionFromGlobalCode):
      (JSC::::parse):
      * runtime/Completion.cpp:
      (JSC::checkSyntax):
      (JSC::evaluate):
      * runtime/Error.cpp:
      (JSC::throwError):
      * runtime/Error.h:
      * runtime/Executable.h: Added.
      (JSC::TemplateExecutable::TemplateExecutable):
      (JSC::TemplateExecutable::markAggregate):
      (JSC::TemplateExecutable::sourceURL):
      (JSC::TemplateExecutable::lineNo):
      (JSC::TemplateExecutable::bytecode):
      (JSC::TemplateExecutable::jitCode):
      (JSC::EvalExecutable::EvalExecutable):
      (JSC::ProgramExecutable::ProgramExecutable):
      * runtime/FunctionConstructor.cpp:
      (JSC::constructFunction):
      * runtime/FunctionConstructor.h:
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::numericCompareFunction):
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::~JSGlobalObject):
      (JSC::JSGlobalObject::markChildren):
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::codeBlocks):
      * runtime/JSGlobalObjectFunctions.cpp:
      (JSC::globalFuncEval):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83651156
    • mrowe@apple.com's avatar
      Build fix. · c574285a
      mrowe@apple.com authored
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::enumerate):  Add the necessary .get() calls.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c574285a
    • beidson@apple.com's avatar
      WebKit/mac: <rdar://problem/7091546> - Assertion failure in... · bbcc5109
      beidson@apple.com authored
      WebKit/mac: <rdar://problem/7091546> - Assertion failure in plugins/return-error-from-new-stream-doesnt-invoke-destroy-stream.html 
      on 64-bit SnowLeopard
      
      Reviewed by Anders Carlsson.
      
      * Plugins/Hosted/HostedNetscapePluginStream.mm:
      (WebKit::HostedNetscapePluginStream::cancelLoad): Since this might be called while the FrameLoader is switching DocumentLoaders
        during the brief moment where there is no activeDocumentLoader(), accept and handle a validly null DocumentLoader.
      
      LayoutTests: <rdar://problem/7091546> - Re-enable 3 plugins tests that now won't crash
      
      Reviewed by Anders Carlsson.
      
      * platform/mac-snowleopard/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbcc5109
    • mrowe@apple.com's avatar
      Fix leaks of NSNumber and NSMutableArray objects seen during layout tests. · adaaf80d
      mrowe@apple.com authored
      Reviewed by Brady Eidson.
      
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::enumerate): Don't leak an NSMutableArray that we allocate.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adaaf80d
    • mrowe@apple.com's avatar
      Fix leaks of HostedNetscapePluginStream and NetscapePlugInStreamLoader objects... · d7b6bac4
      mrowe@apple.com authored
      Fix leaks of HostedNetscapePluginStream and NetscapePlugInStreamLoader objects seen during layout tests.
      
      Reviewed by Anders Carlsson.
      
      * Plugins/Hosted/HostedNetscapePluginStream.mm:
      (WebKit::HostedNetscapePluginStream::didFail): Disconnect the stream from the plug-in instance proxy
      when the load fails.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7b6bac4
    • bfulgham@webkit.org's avatar
      Correct libcurl crash when downloading local files. · 8dd52ce5
      bfulgham@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28312
      
      Reviewed by Kevin Ollivier.
      
      No new tests. Test is covered by fast/encoding/char-encoding-mac.html.
      
      * platform/network/curl/ResourceHandleManager.cpp:
      (WebCore::handleLocalReceiveResponse): New static function that
        performs the local setting of valid URL and firing didReceiveResponse.
        This code was moved from writeCallback.
      (WebCore::writeCallback): Move local file handling to static function
        (above) and use the function instead.
      (WebCore::readCallback): Add check
        for responseFired, and handle as a local file if it was not.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8dd52ce5
    • beidson@apple.com's avatar
      Adding two more to the skipped list. · c7ff06fd
      beidson@apple.com authored
      Radars 7144571 and 7144583 track exploring them.
      
      * platform/mac-snowleopard/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7ff06fd
    • beidson@apple.com's avatar
      Disable media/controls-drag-timebar.html on SnowLeopard. · 47e6752d
      beidson@apple.com authored
      <rdar://problem/7144385> tracks exploring the failure.
      
      * platform/mac-snowleopard/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47e6752d
    • eric@webkit.org's avatar
      2009-08-14 Maxime Simon <simon.maxime@gmail.com> · c58eaf15
      eric@webkit.org authored
              Reviewed by Oliver Hunt.
      
              [Haiku] Fix RenderThemeHaiku build.
              https://bugs.webkit.org/show_bug.cgi?id=28307
      
              * platform/haiku/RenderThemeHaiku.cpp: Included RenderThemeHaiku.h
              instead of RenderTheme.h.
              (WebCore::RenderThemeHaiku::paintCheckbox): Removed the wrong 'virtual'
              before the function.
              (WebCore::RenderThemeHaiku::paintRadio): Removed the wrong 'virtual'
              before the function.
              * platform/haiku/RenderThemeHaiku.h: Corrected wrong function definitions.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c58eaf15
    • eric@webkit.org's avatar
      2009-08-14 Maxime Simon <simon.maxime@gmail.com> · b63e584a
      eric@webkit.org authored
              Reviewed by Oliver Hunt.
      
              [Haiku] Adding SharedBufferHaiku to WebCore.
              https://bugs.webkit.org/show_bug.cgi?id=28309
      
              * platform/haiku/SharedBufferHaiku.cpp: Added.
              (WebCore::SharedBuffer::createWithContentsOfFile):
              * platform/haiku/TemporaryLinkStubs.cpp: Removed unnecessary headers
              and functions.
              (WebCore::signedPublicKeyAndChallengeString):
              (WebCore::getSupportedKeySizes):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b63e584a
    • eric@webkit.org's avatar
      2009-08-14 Eric Seidel <eric@webkit.org> · 5dcb8075
      eric@webkit.org authored
              No review.  Fix 5-space indent to be 4-spaces.
      
              * Scripts/bugzilla-tool:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5dcb8075
    • japhet@chromium.org's avatar
      2009-08-14 Nate Chapin <japhet@chromium.org> · 559dd745
      japhet@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Ensure we're getting the right v8 context in the V8 DOMWindowEvent custom getter.
      
              https://bugs.webkit.org/show_bug.cgi?id=28311
      
              This should fix Chromium failing LayoutTests/fast/events/set-event-in-another-frame.html.
      
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              (WebCore::ACCESSOR_GETTER):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      559dd745
    • oliver@apple.com's avatar
      [ES5] Arguments object should inherit from Array · c16e7f17
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=28298
      
      Reviewed by Gavin Barraclough
      
      Make the Arguments object conform to the behaviour specified in ES5.
      The simple portion of this is to make Arguments use Array.prototype
      as its prototype rather than Object.prototype.
      
      The spec then requires us to set instance.constructor to the pristine
      Object constructor, and instance.toString and instance.toLocaleString
      to the pristine versions from Object.prototype.  To do this we now
      make the ObjectPrototype constructor return its toString and
      toLocaleString functions (similar to the call and apply functions
      from FunctionPrototype).
      
      Oddly enough this reports itself as a slight win, but given the code
      isn't hit in the tests that claim to have improved I put this down to
      code motion.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c16e7f17
    • eric@webkit.org's avatar
      2009-08-14 Aaron Boodman <aa@chromium.org> · fba1b6bc
      eric@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              BUG 28134: Move the remaining parts of Access Control from XMLHttpRequest to ThreadableDocumentLoader.
              https://bugs.webkit.org/show_bug.cgi?id=28134
      
              No new tests added since Access Control was already well tested and this is a pure refactor.
      
              * loader/DocumentThreadableLoader.cpp: Move a lot of the access control code from XHR in, preserving its
              basic strategy. Also, modify the synchronous path to not be a special case, but reuse more of the async
              path.
      
              (WebCore::DocumentThreadableLoader::loadResourceSynchronously): Go through the async path and pass additional flags.
              (WebCore::DocumentThreadableLoader::create): Group enum params into an options struct.
              (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Ditto.
              (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Brought mostly from XHR.
              (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight): Ditto.
              (WebCore::DocumentThreadableLoader::willSendRequest): Handle preflight case.
              (WebCore::DocumentThreadableLoader::didReceiveResponse): Ditto.
              (WebCore::DocumentThreadableLoader::didFinishLoading): Ditto.
              (WebCore::DocumentThreadableLoader::getShouldUseCredentialStorage): Ditto.
              (WebCore::DocumentThreadableLoader::preflightSuccess): Preflight handling.
              (WebCore::DocumentThreadableLoader::preflightFailure): Ditto.
              (WebCore::DocumentThreadableLoader::loadRequest): Common request function that handles async/sync.
              * loader/DocumentThreadableLoader.h: Group enum params into an options struct.
              * loader/ThreadableLoader.cpp: Ditto.
              (WebCore::ThreadableLoader::create): Ditto.
              (WebCore::ThreadableLoader::loadResourceSynchronously): Ditto.
              * loader/ThreadableLoader.h: Ditto.
              (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Ditto.
              * loader/WorkerThreadableLoader.cpp: Ditto.
              (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):Ditto.
              (WebCore::WorkerThreadableLoader::loadResourceSynchronously): Ditto.
              (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): Ditto.
              (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader): Ditto.
              * loader/WorkerThreadableLoader.h: Ditto.
              (WebCore::WorkerThreadableLoader::create): Ditto.
              * platform/CrossThreadCopier.h: Allow ThreadableLoaderOptions to be copied across threads.
              (WebCore::):
              * workers/WorkerScriptLoader.cpp: More enum->struct grouping.
              (WebCore::WorkerScriptLoader::loadSynchronously): More enum->struct grouping.
              (WebCore::WorkerScriptLoader::loadAsynchronously): More enum->struct grouping.
              * xml/XMLHttpRequest.cpp: Remove all the access control code and some supporting state.
              (WebCore::XMLHttpRequest::XMLHttpRequest): Ditto.
              (WebCore::XMLHttpRequest::createRequest): Ditto.
              (WebCore::XMLHttpRequest::didFinishLoading): Ditto.
              (WebCore::XMLHttpRequest::didReceiveResponse): Ditto.
              (WebCore::XMLHttpRequest::didReceiveData): Ditto.
              * xml/XMLHttpRequest.h: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fba1b6bc
    • darin@apple.com's avatar
      Rename the confusing isObject(<class>) to inherits(<class>). · c3cd4d24
      darin@apple.com authored
      It still works on non-objects, returning false.
      
      Patch by Darin Adler <darin@apple.com> on 2009-08-14
      Reviewed by Sam Weinig.
      
      * JSUtils.cpp:
      (KJSValueToJSObject):
      (KJSValueToCFTypeInternal):
      Changed from isObject to inherits.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3cd4d24
    • eric.carlson@apple.com's avatar
      2009-08-14 Eric Carlson <eric.carlson@apple.com> · 5862bf72
      eric.carlson@apple.com authored
              Reviewed by Adam Roben.
      
              Remove media/video-played.html from the Windows skipped list, fixed
              as part of https://bugs.webkit.org/show_bug.cgi?id=28275. Add 
              media/video-played-collapse.html for now.
              
              https://bugs.webkit.org/show_bug.cgi?id=28275
      
              * platform/win/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5862bf72
    • darin@apple.com's avatar
      JavaScriptCore: Rename the confusing isObject(<class>) to inherits(<class>). · c8c110d2
      darin@apple.com authored
      It still works on non-objects, returning false.
      
      Patch by Darin Adler <darin@apple.com> on 2009-08-14
      Reviewed by Sam Weinig.
      
      * runtime/ArrayConstructor.cpp:
      (JSC::arrayConstructorIsArray): Removed unneeded isObject call
      and updated remaining isObject call to new name, inherits.
      
      * runtime/JSCell.h: Renamed isObject(<class>) to inherits(<class>)
      but more importantly, made it non-virtual (it was already inline)
      so it is now as fast as JSObject::inherits was.
      
      * runtime/JSObject.h: Removed inherits function since the one
      in the base class is fine as-is. Also made various JSCell functions
      that should not be called on JSObject uncallable by making them
      both private and not implemented.
      (JSC::JSCell::inherits): Updated name.
      (JSC::JSValue::inherits): Ditto.
      
      * debugger/Debugger.cpp:
      (JSC::Debugger::recompileAllJSFunctions):
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::unwindCallFrame):
      * runtime/ArrayPrototype.cpp:
      (JSC::arrayProtoFuncToString):
      (JSC::arrayProtoFuncToLocaleString):
      (JSC::arrayProtoFuncConcat):
      * runtime/BooleanPrototype.cpp:
      (JSC::booleanProtoFuncToString):
      (JSC::booleanProtoFuncValueOf):
      * runtime/DateConstructor.cpp:
      (JSC::constructDate):
      * runtime/DatePrototype.cpp:
      (JSC::dateProtoFuncToString):
      (JSC::dateProtoFuncToUTCString):
      (JSC::dateProtoFuncToISOString):
      (JSC::dateProtoFuncToDateString):
      (JSC::dateProtoFuncToTimeString):
      (JSC::dateProtoFuncToLocaleString):
      (JSC::dateProtoFuncToLocaleDateString):
      (JSC::dateProtoFuncToLocaleTimeString):
      (JSC::dateProtoFuncGetTime):
      (JSC::dateProtoFuncGetFullYear):
      (JSC::dateProtoFuncGetUTCFullYear):
      (JSC::dateProtoFuncToGMTString):
      (JSC::dateProtoFuncGetMonth):
      (JSC::dateProtoFuncGetUTCMonth):
      (JSC::dateProtoFuncGetDate):
      (JSC::dateProtoFuncGetUTCDate):
      (JSC::dateProtoFuncGetDay):
      (JSC::dateProtoFuncGetUTCDay):
      (JSC::dateProtoFuncGetHours):
      (JSC::dateProtoFuncGetUTCHours):
      (JSC::dateProtoFuncGetMinutes):
      (JSC::dateProtoFuncGetUTCMinutes):
      (JSC::dateProtoFuncGetSeconds):
      (JSC::dateProtoFuncGetUTCSeconds):
      (JSC::dateProtoFuncGetMilliSeconds):
      (JSC::dateProtoFuncGetUTCMilliseconds):
      (JSC::dateProtoFuncGetTimezoneOffset):
      (JSC::dateProtoFuncSetTime):
      (JSC::setNewValueFromTimeArgs):
      (JSC::setNewValueFromDateArgs):
      (JSC::dateProtoFuncSetYear):
      (JSC::dateProtoFuncGetYear):
      * runtime/FunctionPrototype.cpp:
      (JSC::functionProtoFuncToString):
      * runtime/JSActivation.cpp:
      (JSC::JSActivation::argumentsGetter):
      * runtime/JSValue.h:
      * runtime/RegExpConstructor.cpp:
      (JSC::constructRegExp):
      * runtime/RegExpPrototype.cpp:
      (JSC::regExpProtoFuncTest):
      (JSC::regExpProtoFuncExec):
      (JSC::regExpProtoFuncCompile):
      (JSC::regExpProtoFuncToString):
      * runtime/ScopeChain.cpp:
      (JSC::ScopeChain::localDepth):
      * runtime/StringPrototype.cpp:
      (JSC::stringProtoFuncReplace):
      (JSC::stringProtoFuncToString):
      (JSC::stringProtoFuncMatch):
      (JSC::stringProtoFuncSearch):
      (JSC::stringProtoFuncSplit):
      Updated to new name, inherits, from old name, isObject.
      
      WebCore: Rename the confusing isObject(<class>) to inherits(<class>).
      It still works on non-objects, returning false.
      
      Patch by Darin Adler <darin@apple.com> on 2009-08-14
      Reviewed by Sam Weinig.
      
      * bindings/js/JSEventTarget.cpp:
      (WebCore::toEventTarget):
      * bindings/js/JSGeolocationCustom.cpp:
      (WebCore::createPositionCallback):
      (WebCore::createPositionErrorCallback):
      * bindings/js/JSNodeFilterCustom.cpp:
      (WebCore::toNodeFilter):
      * bindings/js/JSXMLHttpRequestCustom.cpp:
      (WebCore::JSXMLHttpRequest::send):
      * bindings/js/JSXSLTProcessorCustom.cpp:
      (WebCore::JSXSLTProcessor::importStylesheet):
      (WebCore::JSXSLTProcessor::transformToFragment):
      (WebCore::JSXSLTProcessor::transformToDocument):
      * bindings/scripts/CodeGeneratorJS.pm:
      * bridge/objc/objc_runtime.mm:
      (JSC::Bindings::callObjCFallbackObject):
      * bridge/runtime_method.cpp:
      (JSC::callRuntimeMethod):
      Updated to new name, inherits, from old name, isObject.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8c110d2
    • eric.carlson@apple.com's avatar
      2009-08-14 Eric Carlson <eric.carlson@apple.com> · 533efe65
      eric.carlson@apple.com authored
              Reviewed by Simon Fraser.
      
              media/video-played.html always times out on Windows
              https://bugs.webkit.org/show_bug.cgi?id=28275
      
              * media/video-played-collapse.html:
                  Make sub-test assumptions obvious for someone reading this later.
      
              * media/video-played.html: Removed.
              * media/video-played-expected.txt: Removed.
              * media/video-played-ranges-1-expected.txt: Copied from LayoutTests/media/video-played-expected.txt.
              * media/video-played-ranges-1.html: Copied from LayoutTests/media/video-played.html.
                  Split video-played.html into video-played-ranges-1.html and video-played-ranges-2.html.
      
              * media/video-played-reset.html:
                  Make sub-test assumptions obvious for someone reading this later.
      
              * media/video-played.js:
              (logRanges):
                  New but not currently called. Allows all ranges to be logged for debugging.
              (testRanges):
                  Log ranges and the amount of time each test takes when logTestTiming != 0.
              (nextTest):
                  Record test start time when logTestTiming is true;
              (startPlaying):
                  Run each sub-test for 100ms instead of 250ms to decrease overall test time.
              (playForMillisecs.callPauseIfTimeIsReached):
              (playForMillisecs):
                  Make error conditions trigger immediate failure instead of just logging.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      533efe65
    • kov@webkit.org's avatar
      2009-08-14 Benjamin Otte <otte@gnome.org> · 42caa947
      kov@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Fix webkit_web_view_set_highlight_text_matches() so that highlighting
              works properly in documents with frames.
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_set_highlight_text_matches):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42caa947
    • hausmann@webkit.org's avatar
      RVCT elftran fails to resolve QPainter::staticMetaObject coming with · 59ea43e3
      hausmann@webkit.org authored
      QWebView::RenderHints property.
      
      Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-08-14
      Reviewed by Simon Hausmann.
      
      This is a temporary fix and will be revereted when the right symbols
      exported from Qt lib in S60.
      
      https://bugs.webkit.org/show_bug.cgi?id=28181
      
      * Api/qwebview.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59ea43e3
    • hausmann@webkit.org's avatar
      Adding QNX as a platform. Currently only tested with Qt. · 8dc89b43
      hausmann@webkit.org authored
      Patch by Harald Fernengel <harald.fernengel@nokia.com> on 2009-07-31
      Reviewed by Simon Hausmann.
      
      https://bugs.webkit.org/show_bug.cgi?id=27885
      
      * JavaScriptCore/runtime/Collector.cpp: Added retrieving of stack base
        since QNX doesn't have the pthread _nt functions
      * JavaScriptCore/wtf/Platform.h: Added WTF_PLATFORM_QNX and corresponding
        defines
      * WebCore/bridge/npapi.h: Build fix for missing typedefs on QNX
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8dc89b43
    • hausmann@webkit.org's avatar
      WebKit/qt: [Qt] Public API to configure the storage path for HTML5 localStorage · e34be5e3
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28036
      
      Patch by Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2009-08-14
      Reviewed by Simon Hausmann.
      
      Disables LocalStorage for QtWebKit by default by setting
      QWebSettings::LocalStorageEnabled to false.
      
      Sets up a default for the LocalStorage path so that clients would only
      need to enable the LocalStorageEnabled setting to turn on LocalStoragre
      support.
      
      Turn on LocalStorage support for QtLauncher and the relevant test
      since LocalStorage is now disabled by default for QtWebkit.
      
      * Api/qwebpage.cpp:
      (defaultCachePath):
      (initializeApplicationCachePathIfNecessary):
      (QWebPagePrivate::QWebPagePrivate):
      * Api/qwebsettings.cpp:
      (QWebSettingsPrivate::apply):
      (QWebSettings::QWebSettings):
      (QWebSettings::setLocalStoragePath):
      (QWebSettings::localStoragePath):
      * Api/qwebsettings.h:
      * QtLauncher/main.cpp:
      (main):
      * tests/qwebpage/tst_qwebpage.cpp:
      (tst_QWebPage::multiplePageGroupsAndLocalStorage):
      
      WebKitTools: [Qt] Public API to configure the storage path for HTML5 localStorage
      https://bugs.webkit.org/show_bug.cgi?id=28036
      
      Patch by Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2009-08-14
      Reviewed by Simon Hausmann.
      
      Turn on LocalStorage support for Qt DumpRenderTree since
      LocalStorage is now disabled by defult for QtWebkit.
      
      * DumpRenderTree/qt/DumpRenderTree.cpp:
      (WebCore::WebPage::WebPage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47283 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e34be5e3
    • yael.aharon@nokia.com's avatar
      WebCore: Allow Qt API to list and to remove URL schemes that were registered as · 439ff31d
      yael.aharon@nokia.com authored
      local URL schemes.
      [Qt] Allow applications to register their own local URL scheme.
      https://bugs.webkit.org/show_bug.cgi?id=28240
      
      Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-08-14
      Reviewed by Simon Hausmann.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      439ff31d
    • hausmann@webkit.org's avatar
      Add the blog of University of Szeged. · 82ae39e4
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28301
      
      Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-08-14
      Reviewed by Simon Hausmann.
      
      * config.ini:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82ae39e4
    • xan@webkit.org's avatar
      2009-08-14 Xan Lopez <xlopez@igalia.com> · edba340d
      xan@webkit.org authored
              Reviewed by Jan Alonzo.
      
              Do not unref the main webview, it's owned by its parent
              container. Instead destroy the container, which should take care
              of everything (not terribly important since we exit right after
              that, but still).
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edba340d
    • ariya@webkit.org's avatar
      2009-08-14 Ariya Hidayat <ariya.hidayat@nokia.com> · a1679c88
      ariya@webkit.org authored
              Rubber-stamped by Tor Arne Vestbø.
      
              [Qt] Add test result after r47255.
      
              * platform/qt/fast/block/float/avoidance-percent-width-compat-expected.txt: Added.
              * platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1679c88
    • hausmann@webkit.org's avatar
      Currently generic ARM and ARMv7 platforms work only with JSVALUE32 · d1ac5de5
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28300
      
      Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-08-14
      Reviewed by Simon Hausmann.
      
      * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1ac5de5
    • pfeldman@chromium.org's avatar
      2009-08-14 Pavel Feldman <pfeldman@chromium.org> · d0ea3bbe
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              WebInspector: Wrap console objects late (in the frontend) so that injected
              script was already in place.
      
              https://bugs.webkit.org/show_bug.cgi?id=28297
      
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::ConsoleMessage):
              * inspector/ConsoleMessage.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::addMessageToConsole):
              (WebCore::InspectorController::startGroup):
              (WebCore::InspectorController::setFrontendProxyObject):
              * inspector/InspectorController.h:
              * inspector/InspectorFrontend.cpp:
              (WebCore::InspectorFrontend::InspectorFrontend):
              (WebCore::InspectorFrontend::addMessageToConsole):
              * inspector/InspectorFrontend.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0ea3bbe
    • vestbo@webkit.org's avatar
      Try to fix the build when !JIT_OPTIMIZE_NATIVE_CALL · d1fed699
      vestbo@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1fed699
    • ariya@webkit.org's avatar
      2009-08-14 Ariya Hidayat <ariya.hidayat@nokia.com> · 7bc3acf6
      ariya@webkit.org authored
              Reviewed by Tor Arne Vestbø.
      
              [Qt] Update test result after r47255.
              Also while I am at it, add pixel test result.
      
              * platform/qt/fast/block/float/035-expected.checksum: Added.
              * platform/qt/fast/block/float/035-expected.png: Added.
              * platform/qt/fast/block/float/035-expected.txt: Adjusted.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bc3acf6
    • hausmann@webkit.org's avatar
      Enable JIT on ARM for QT by default · 9c647d27
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28259
      
      Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-08-14
      Reviewed by Simon Hausmann.
      
      * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c647d27
    • hausmann@webkit.org's avatar
      Enable YARR_JIT on ARM for QT by default · e649fcc2
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28259
      
      Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-08-14
      Reviewed by Simon Hausmann.
      
      * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e649fcc2
    • oliver@apple.com's avatar
      Remove MarkStack::drain from the JSC exports file · 82e51437
      oliver@apple.com authored
      MarkStack::drain is now marked inline, the including it in the exports file
      produces an ld warning
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82e51437