Commits · 78354ef147984027984498322feba10dbb3c8c58 · App_Technologies / webkit

10 Sep, 2005 8 commits

darin authored Sep 10, 2005

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4806
          REGRESSION <area> elements misnested inside <div> elements not working

        Test cases added:
        * layout-tests/fast/parser/area-in-div.html: Added.
        * layout-tests/fast/parser/area-in-div-expected.txt: Added.

        * khtml/html/htmlparser.h: Declared mapCreateErrorCheck.
        * khtml/html/htmlparser.cpp:
        (HTMLParser::handleError): Fix formatting and indentation.
        (HTMLParser::formCreateErrorCheck): Added code to create the form too, so we can
        squirrel the form pointer away. Return false to prevent the factory from creating it.
        (HTMLParser::mapCreateErrorCheck): Added. Same kind of thing here, but without the logic
        that prevents creating a form if there's already a form open.
        (HTMLParser::getNode): Added the code to put the map function into the table. Also
        removed the form special-case code here that accomplishes what is now done inside the
        formCreateErrorCheck above instead.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

78354ef1

Reviewed by Maciej. · 928af691

darin authored Sep 10, 2005

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4367
          Crash when executing setTimeout / Date / document.write Javascript (bugtraq)

        Test cases added:
        * layout-tests/fast/dom/document-write-infinite-recursion.html: Added.
        * layout-tests/fast/dom/document-write-infinite-recursion-expected.txt: Added.

        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::implicitClose): Simplify a bit to make more readable. Remove the
        code to delete the tokenizer an extra time -- that can end up deleting the newly
        created tokenizer that's still needed for the newly opened page.
        (DocumentImpl::write): Added an assertion to catch the badness that caused
        infinite recursion so it's easier to recognize next time.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

928af691

- fixed compilation for WebCore (another try) · ae6be78d

darin authored Sep 10, 2005

        * kjs/simple_number.h: Added more "using" lines.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ae6be78d

- fixed compilation for WebCore · ec1c1085

darin authored Sep 10, 2005

        * kjs/simple_number.h: Have to include <cmath> here to work around a bug in the GCC
        standard C++ library headers.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ec1c1085

Windows changes by Krzysztof Kowalczyk <kkowalczyk@gmail.com>. · 1e72652b

darin authored Sep 10, 2005

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4870
          win portability: fix IS_NEGATIVE_ZERO macro in simple_number.h

        * kjs/simple_number.h:
        (KJS::isNegativeZero): Added. Inline function. Has a case for Windows that
        uses _fpclass and a case for other platforms that uses signbit.
        (KJS::SimpleNumber::fits): Use inline isNegativeZero instead of macro IS_NEGATIVE_ZERO.

        * kjs/internal.cpp: Remove definition of now-unneeded negZero global.

        * kjs/value.cpp: Touched the file because Xcode didn't know it needed to
        recompile it.

        - improved test engine

        * tests/mozilla/jsDriver.pl: Sort tests in numeric order instead of using
        a plain-ASCII sort; now test 33 will be after test 5 in any given set of
        numbered tests.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1e72652b

Reviewed and landed by Darin. · d66d9465

darin authored Sep 10, 2005

        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
        Removed unused local variable.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d66d9465

- add expected success result for newly-enabled test · 103e63f3

darin authored Sep 10, 2005

        * layout-tests/dom/html/level2/html/HTMLIFrameElement11-expected.txt: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

103e63f3

Reviewed by Dave Hyatt. · 9c9148f9

vicki authored Sep 10, 2005

	- fix <rdar://problem/4234256> REGRESSION: image tag broken in TOT

        Test cases added:
        * layout-tests/fast/replaced/image-tag-expected.checksum: Added.
        * layout-tests/fast/replaced/image-tag-expected.png: Added.
        * layout-tests/fast/replaced/image-tag-expected.txt: Added.
        * layout-tests/fast/replaced/image-tag.html: Added.

	* khtml/html/htmlnames.h:
        * khtml/html/htmlfactory.cpp:
        (DOM::HTMLElementFactory::createHTMLElement):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9c9148f9

09 Sep, 2005 2 commits

Reviewed by John Sullivan. · 7eea642d

tomernic authored Sep 09, 2005

        * History.subproj/WebBackForwardList.m:
        (-[WebBackForwardList removeItem:]):
	SPI to remove a given WebHistoryItem.

        * History.subproj/WebBackForwardListPrivate.h: Added.

        * WebKit.xcodeproj/project.pbxproj:
	Added WebBackForwardListPrivate.h as a private header.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7eea642d

WebCore: · 1dcf67dc

sullivan authored Sep 09, 2005

        Reviewed by Tim Omernick.

        Test cases added: none, doesn't affect layout

        - fixed <rdar://problem/4250792> Find in HTML doesn't reveal match if only match was already selected

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::findString):
        If we end up finding the previously-selected text, just go through the normal success code path
        instead of bailing out early.

WebKit:

        Reviewed by Tim Omernick.

        fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4070:
        Find in plain text won't find only occurrence if it overlaps selection

        * Misc.subproj/WebSearchableTextView.m:
        (-[NSString findString:selectedRange:options:wrap:]):
        in the wrap case, extend the search range far enough that text overlapping the
        selection (including the exact-match case) will be considered.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1dcf67dc

08 Sep, 2005 10 commits

- fixed overloaded versions of throwError so that they substitute *all* · da1e1fe7

darin authored Sep 09, 2005

          expected parameters into the message string -- some versions used to
          skip parameters, resulting in "%s" being printed in the error message.

        Reviewed by Geoff.

        * kjs/nodes.h: Updated declarations to use "const &" and not to name parameters
        * kjs/nodes.cpp: (Node::throwError): Updated to match above and add one missing
        call to substitute.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

da1e1fe7

Reviewed by Geoff. · d7737ab5

darin authored Sep 09, 2005

        - updated to PCRE 6.1

        The original PCRE 6.1 sources are checked into the tree with the tag
        "pcre-6-1" for reference. What we're checking in right now is the original
        plus our changes to make it support UTF-16 and at least one other tweak
        (vertical tab considered whitespace). Our work to get our changes was
        done on "pcre-6-1-branch", with an anchor at "pcre-6-1-anchor" so you can
        see the evolution of the UTF-16 changes.

        Note also that there was one small change made here that's not on the branch
        in pcre_compile.c.

        * Info.plist: Updated the part of the copyright message that's about PCRE.

        * JavaScriptCore.xcodeproj/project.pbxproj: Added new PCRE source files,
        removed obsolete ones.

        * pcre/AUTHORS: Updated to PCRE 6.1. Includes credits for Apple's UTF-16
        changes, but not the credits for Google's C++ wrapper, since we don't include that.
        * pcre/COPYING: Updat...

d7737ab5

Reviewed by John Sullivan. · 245ed0b2

vicki authored Sep 08, 2005

	- fixed <rdar://problem/4168089> CRASH: Using A9 Maps new interface (also occurs on google maps)

        * khtml/xml/dom_elementimpl.cpp:
        (ElementImpl::getAttributeNS): add a check for the document, before checking to see if this is an HTML document


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

245ed0b2

Reviewed by darin · 5009cfdd

justing authored Sep 08, 2005

        * Scripts/update-webkitsysteminterface: Added.
        Builds webkitsysteminterface and moves the built product and header into WebKitLibraries


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5009cfdd

Reviewed by darin · 9ca5ce30

justing authored Sep 08, 2005

        WebCore portion of multipart/x-mixed-replace support

        * khtml/misc/loader.cpp:
        (Request::Request):
        (Loader::slotReceivedResponse):
        Only allow a multipart load for images, clear out the old multipart section to prepare for a replace
        (Loader::slotData):
        Multipart sections are delivered to the coreLoader by WebKit all at once, send eof to CachedImage::data
        * khtml/misc/loader.h:
        (khtml::CachedObject::isImage): Added
        (khtml::CachedImage::isImage):
        * kwq/KWQKJobClasses.h:
        * kwq/KWQKJobClasses.mm:
        (KIO::TransferJob::cancel):
        Added a way to cancel a subresource loader from WebCore
        * kwq/KWQLoader.h:
        * kwq/KWQLoader.mm:
        (KWQResponseIsMultipart):
        * kwq/KWQResourceLoader.h:
        * kwq/KWQResourceLoader.mm:
        (-[KWQResourceLoader jobCanceledLoad]):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9ca5ce30

Reviewed by darin · 828f5fb9

justing authored Sep 08, 2005

        WebKit portion of multipart/x-mixed-replace support

        * WebCoreSupport.subproj/WebSubresourceLoader.m:
        (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]):
        Subresource case: Check for Foundation level multipart support
        (-[WebSubresourceLoader didReceiveResponse:]):
        Send previously received data in a multipart section to the coreLoader
        (-[WebSubresourceLoader didReceiveData:lengthReceived:]):
        Don't send data to the coreLoader until it has been completely received
        * WebView.subproj/WebDataSource.m:
        (-[WebDataSource _startLoading:]):
        Main resource case: check for Foundation level multipart support
        (+[WebDataSource _repTypesAllowImageTypeOmission:]):
        Some server apps send data right after declaring content multipart/x-mixed-replace, and expect it to be treated as html
        (-[WebDataSource _commitIfReady:]):
        Don't ask the WebFrame to close its old WebDataSource when loading a multipart section, because we're going to reuse it
        (-[WebDataSource _receivedData:]):
        For non text/html multipart sections, we commit the data all at once, at the end
        (-[WebDataSource _doesProgressiveLoadWithMIMEType:]):
        Added heuristic for when to commit the load incrementally
        (-[WebDataSource _commitLoadWithData:]):
        Moved from _receivedData into its own function
        (-[WebDataSource _revertToProvisionalState]):
        (-[WebDataSource _setupForReplaceByMIMEType:]):
        Commits the data received for the previous multipart section if it wasn't loaded progresively, clears out the WebFrame and WebDatasource for the next multipart section
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _transitionToCommitted:]):
        The very first multipart section is treated as a normal load, so that the back/forward list and history are updated.
        All later sections have a new load type, WebFrameLoadTypeReplace, and are treated like reloads
        (-[WebFrame _checkLoadCompleteForThisFrame]): Ditto
        (-[WebFrame _itemForRestoringDocState]): Ditto
        (-[WebFrame _setupForReplace]):
        Clears out the WebFrame for the next multipart section
        * WebView.subproj/WebFrameInternal.h:
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFrameView.m:
        (+[WebFrameView _viewTypesAllowImageTypeOmission:]): See above
        * WebView.subproj/WebLoader.h:
        * WebView.subproj/WebLoader.m:
        (-[NSURLProtocol clearResourceData]):
        (-[NSURLProtocol setSupportsMultipartContent:]):
        * WebView.subproj/WebMainResourceLoader.m: Straightforward
        (-[WebMainResourceLoader didReceiveResponse:]):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

828f5fb9

* WebKitSystemInterface.h: Update to latest · 2753a96f

justing authored Sep 08, 2005

        * libWebKitSystemInterface.a: ditto


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2753a96f

Reviewed by Don Melton. · 988c4474

vicki authored Sep 08, 2005

	- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4891 (HTMLIFrameElement11.js checks for
	wrong title, causes false failure) and enabled HTMLIFrameElement11.html

        * layout-tests/dom/html/level2/html/HTMLIFrameElement11.js: check for correct title of resources/frame.html

        * layout-tests/dom/html/level2/html/HTMLIFrameElement11.html: Added.
        * layout-tests/dom/html/level2/html/HTMLIFrameElement11.html-disabled: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

988c4474

-fixed gcc 4.0 build bustage due to inconsitent return type · 9fb526fc

ggaren authored Sep 08, 2005

        Reviewed by john.

        * kwq/KWQTextField.mm:
        (-[NSTextField _KWQ_currentEditor]): editor is now cast as an NSTextView
        instead of an NSText (which makes sense regardless of build bustage,
        given that we first test for isKindOfClass:[NSTextView class] before defining editor)


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9fb526fc

Bug #: 4863 · a7b0e9b8

eseidel authored Sep 08, 2005

Submitted by: eseidel
Reviewed by: darin
        Merged various changes from KDE, including:
        Qt3->Qt4 change: QWMatrix -> QMatrix
        A few remaining DOMString -> DOMStringImpl changes
        KRenderingDevicePaintServer now inherits KCanvasResource
        Various whitespace adjustments.
        Fewer, clearer logs from kcanvas/device/quartz code.
        DOM exception support.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4863

        * ForwardingHeaders/qmatrix.h: Added.
        * WebCore+SVG/DrawDocument.mm:
        (-[DrawDocumentPrivate init]):
        (-[DrawDocumentPrivate dealloc]):
        (-[DrawDocumentPrivate setPrimaryView:]):
        * WebCore.xcodeproj/project.pbxproj:
        * kcanvas/KCanvas.cpp:
        (KCanvas::~KCanvas):
        (KCanvas::reset):
        * kcanvas/KCanvasContainer.cpp:
        (KCanvasContainer::bbox):
        (KCanvasContainer::collisions):
        (KCanvasContainer::first):
        (KCanvasContainer::last):
        * kcanvas/KCanvasContainer.h:
        * kcanvas/KCanvasFilters.cpp:
        * kcanvas/KCanvasFilters.h:
        * kcanvas/KCanvasMatrix.cpp:
        (KCanvasMatrix::KCanvasMatrix):
        (KCanvasMatrix::operator=):
        (KCanvasMatrix::operator==):
        (KCanvasMatrix::operator!=):
        (KCanvasMatrix::translate):
        (KCanvasMatrix::multiply):
        (KCanvasMatrix::scale):
        (KCanvasMatrix::rotate):
        (KCanvasMatrix::rotateFromVector):
        (KCanvasMatrix::skewX):
        (KCanvasMatrix::skewY):
        (KCanvasMatrix::qmatrix):
        * kcanvas/KCanvasMatrix.h:
        * kcanvas/KCanvasRegistry.cpp:
        (operator<<):
        * kcanvas/KCanvasRegistry.h:
        * kcanvas/KCanvasResources.cpp:
        (KCanvasResource::KCanvasResource):
        (KCanvasMarker::draw):
        * kcanvas/KCanvasResources.h:
        * kcanvas/KCanvasTreeDebug.cpp:
        (operator<<):
        * kcanvas/KCanvasView.cpp:
        (KCanvasView::setCanvas):
        * kcanvas/KCanvasView.h:
        * kcanvas/device/KRenderingFillPainter.cpp:
        (KRenderingFillPainter::draw):
        * kcanvas/device/KRenderingPaintServer.h:
        (KRenderingPaintServer::KRenderingPaintServer):
        * kcanvas/device/KRenderingPaintServerGradient.cpp:
        (KRenderingPaintServerGradient::Private::Private):
        (KRenderingPaintServerGradient::KRenderingPaintServerGradient):
        (KRenderingPaintServerGradient::listener):
        (KRenderingPaintServerGradient::setListener):
        * kcanvas/device/KRenderingPaintServerGradient.h:
        * kcanvas/device/KRenderingPaintServerPattern.cpp:
        (KRenderingPaintServerPattern::Private::Private):
        (KRenderingPaintServerPattern::KRenderingPaintServerPattern):
        (KRenderingPaintServerPattern::listener):
        (KRenderingPaintServerPattern::setListener):
        * kcanvas/device/KRenderingPaintServerPattern.h:
        * kcanvas/device/KRenderingStrokePainter.cpp:
        (KRenderingStrokePainter::setPaintServer):
        (KRenderingStrokePainter::draw):
        * kcanvas/device/KRenderingStyle.cpp:
        (KRenderingStyle::Private::Private):
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (KCanvasFilterQuartz::prepareFilter):
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        (cgGradientCallback):
        (KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
        (KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
        (KRenderingPaintServerLinearGradientQuartz::draw):
        (KRenderingPaintServerRadialGradientQuartz::draw):
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
        (KRenderingPaintServerPatternQuartz::draw):
        (KRenderingPaintServerImageQuartz::draw):
        * kdom/KDOMSettings.cpp:
        (KDOMSettings::init):
        (KDOMSettings::strToAdvice):
        * kdom/Shared.h:
        (KDOM::KDOM_SAFE_SET):
        * kdom/backends/libxml/LibXMLParser.cpp:
        (sax_start_doc):
        (sax_internal_subset):
        (sax_entity_decl):
        * kdom/bindings/IDLParser.pm:
        * kdom/bindings/IDLStructure.pm:
        * kdom/cache/KDOMCache.h:
        * kdom/cache/KDOMCachedObject.h:
        * kdom/cache/KDOMLoader.cpp:
        (DocumentLoader::setAutoloadImages):
        * kdom/cache/KDOMLoader.h:
        * kdom/core/AttrImpl.cpp:
        (AttrImpl::value):
        (AttrImpl::setPrefix):
        * kdom/core/DOMConfigurationImpl.cpp:
        (DOMConfigurationImpl::normalizeCharacters):
        * kdom/core/DOMImplementationImpl.cpp:
        (DOMImplementationImpl::DOMImplementationImpl):
        (DOMImplementationImpl::createDocument):
        (DOMImplementationImpl::idToType):
        * kdom/core/DOMImplementationImpl.h:
        * kdom/core/DocumentImpl.cpp:
        (DocumentImpl::removeListenerType):
        (DocumentImpl::getId):
        * kdom/core/DocumentTypeImpl.cpp:
        (DocumentTypeImpl::internalSubset):
        * kdom/core/NamedAttrMapImpl.cpp:
        (NamedAttrMapImpl::setValue):
        (NamedAttrMapImpl::dispatchAttrMutationEvent):
        * kdom/core/NamedNodeMapImpl.cpp:
        (RONamedNodeMapImpl::getNamedItem):
        * kdom/core/NodeImpl.cpp:
        (NodeBaseImpl::removeChildren):
        (NodeImpl::lookupNamespaceURI):
        * kdom/core/ProcessingInstructionImpl.cpp:
        (ProcessingInstructionImpl::ProcessingInstructionImpl):
        (ProcessingInstructionImpl::~ProcessingInstructionImpl):
        * kdom/core/ProcessingInstructionImpl.h:
        * kdom/core/domattrs.c:
        * kdom/css/CSSPrimitiveValueImpl.cpp:
        (FontFamilyValueImpl::FontFamilyValueImpl):
        * kdom/css/CSSStyleRuleImpl.cpp:
        (CSSStyleRuleImpl::parseString):
        * kdom/css/CSSStyleRuleImpl.h:
        * kdom/css/CSSStyleSelector.cpp:
        (CSSStyleSelector::CSSStyleSelector):
        (CSSStyleSelector::styleForElement):
        (CSSStyleSelector::applyRule):
        (CSSStyleSelector::getLangAttribute):
        * kdom/css/CSSStyleSelector.h:
        * kdom/css/CSSStyleSheetImpl.cpp:
        (CSSStyleSheetImpl::type):
        * kdom/css/CSSValueImpl.cpp:
        (ShadowValueImpl::cssText):
        * kdom/css/Font.h:
        * kdom/css/LinkStyleImpl.cpp: Added.
        (LinkStyleImpl::LinkStyleImpl):
        (LinkStyleImpl::~LinkStyleImpl):
        (LinkStyleImpl::sheet):
        * kdom/css/LinkStyleImpl.h: Added.
        * kdom/css/MediaListImpl.cpp:
        (MediaListImpl::setMediaText):
        * kdom/css/RectImpl.cpp:
        * kdom/css/RectImpl.h:
        (KDOM::RectImpl::top):
        (KDOM::RectImpl::right):
        (KDOM::RectImpl::bottom):
        (KDOM::RectImpl::left):
        * kdom/css/RenderStyle.cpp:
        (RenderStyle::diff):
        * kdom/css/RenderStyle.h:
        * kdom/css/RenderStyleDefs.cpp:
        (StyleInheritedData::StyleInheritedData):
        (StyleInheritedData::operator==):
        * kdom/css/RenderStyleDefs.h:
        * kdom/css/StyleBaseImpl.cpp:
        (CSSSelector::print):
        (CSSSelector::extractPseudoType):
        * kdom/events/EventTargetImpl.cpp:
        (EventTargetImpl::addEventListener):
        * kdom/kdom.h:
        (KDOM::):
        * kdom/ls/DOMImplementationLSImpl.cpp: Added.
        (DOMImplementationLSImpl::DOMImplementationLSImpl):
        (DOMImplementationLSImpl::~DOMImplementationLSImpl):
        (DOMImplementationLSImpl::createLSParser):
        (DOMImplementationLSImpl::createLSInput):
        (DOMImplementationLSImpl::createLSOutput):
        (DOMImplementationLSImpl::createLSSerializer):
        * kdom/ls/DOMImplementationLSImpl.h: Added.
        * kdom/ls/LSParserImpl.cpp:
        (LSParserImpl::parseURI):
        * kdom/ls/LSParserImpl.h:
        * kdom/ls/LSResourceResolverImpl.cpp:
        (LSResourceResolverImpl::resolveResource):
        * kdom/ls/LSResourceResolverImpl.h:
        * kdom/ls/LSSerializerImpl.cpp:
        (LSSerializerImpl::newLine):
        (LSSerializerImpl::writeToString):
        (LSSerializerImpl::escape):
        (LSSerializerImpl::escapeAttribute):
        * kdom/ls/LSSerializerImpl.h:
        * kdom/parser/KDOMParser.cpp:
        (Parser::handleError):
        (Parser::bufferForUrl):
        * kdom/range/RangeImpl.cpp:
        (RangeImpl::toString):
        * kdom/range/RangeImpl.h:
        * kdom/scripts/cssmakeprops:
        * kdom/scripts/cssmakevalues:
        * kdom/xpointer/PointerPartImpl.cpp:
        (PointerPartImpl::PointerPartImpl):
        * kdom/xpointer/ShortHandImpl.cpp:
        (ShortHandImpl::ShortHandImpl):
        * kdom/xpointer/XPointerEvaluatorImpl.cpp:
        (XPointerEvaluatorImpl::createXPointer):
        * kdom/xpointer/XPointerResultImpl.h:
        * kdom/xpointer/kdomxpointer.h:
        (KDOM::XPointer::):
        * ksvg2/KSVGFactory.cpp:
        (KSVGFactory::createPartObject):
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        * ksvg2/events/SVGEventImpl.cpp:
        (SVGEventImpl::SVGEventImpl):
        (SVGEventImpl::initEvent):
        * ksvg2/events/SVGEventImpl.h:
        (KSVG::):
        * ksvg2/events/SVGZoomEventImpl.cpp:
        (SVGZoomEventImpl::SVGZoomEventImpl):
        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        (KCanvasRenderingStyle::updateFill):
        (KCanvasRenderingStyle::updateStroke):
        (KCanvasRenderingStyle::startMarker):
        (KCanvasRenderingStyle::midMarker):
        (KCanvasRenderingStyle::endMarker):
        (KCanvasRenderingStyle::filter):
        * ksvg2/misc/KSVGTimeScheduler.cpp:
        (SVGTimer::notifyAll):
        * ksvg2/svg/SVGAnimateColorElementImpl.cpp:
        (SVGAnimateColorElementImpl::handleTimerEvent):
        * ksvg2/svg/SVGAnimateElementImpl.cpp:
        (SVGAnimateElementImpl::handleTimerEvent):
        * ksvg2/svg/SVGAnimationElementImpl.cpp:
        (SVGAnimationElementImpl::targetAttribute):
        (SVGAnimationElementImpl::setTargetAttribute):
        * ksvg2/svg/SVGAnimationElementImpl.h:
        * ksvg2/svg/SVGCursorElementImpl.cpp: Added.
        (SVGCursorElementImpl::SVGCursorElementImpl):
        (SVGCursorElementImpl::~SVGCursorElementImpl):
        (SVGCursorElementImpl::x):
        (SVGCursorElementImpl::y):
        (SVGCursorElementImpl::parseAttribute):
        (SVGCursorElementImpl::notifyFinished):
        * ksvg2/svg/SVGCursorElementImpl.h: Added.
        (KSVG::SVGCursorElementImpl::pixmap):
        * ksvg2/svg/SVGDOMImplementationImpl.cpp:
        (SVGDOMImplementationImpl::hasFeature):
        (SVGDOMImplementationImpl::createDocumentType):
        (SVGDOMImplementationImpl::createDocument):
        (SVGDOMImplementationImpl::typeToId):
        (SVGDOMImplementationImpl::idToType):
        * ksvg2/svg/SVGDocumentImpl.cpp:
        (SVGDocumentImpl::SVGDocumentImpl):
        (SVGDocumentImpl::createSVGElement):
        (SVGDocumentImpl::createElement):
        (SVGDocumentImpl::createElementNS):
        (SVGDocumentImpl::createEvent):
        (SVGDocumentImpl::notifyFinished):
        (SVGDocumentImpl::defaultNS):
        (SVGDocumentImpl::executeScripts):
        (SVGDocumentImpl::prepareMouseEvent):
        (SVGDocumentImpl::dispatchUIEvent):
        (SVGDocumentImpl::dispatchMouseEvent):
        * ksvg2/svg/SVGDocumentImpl.h:
        * ksvg2/svg/SVGElementImpl.cpp:
        (SVGElementImpl::getId):
        (SVGElementImpl::xmlbase):
        (SVGElementImpl::tryGetAttribute):
        (SVGElementImpl::tryGetAttributeNS):
        (SVGElementImpl::parseAttribute):
        (SVGElementImpl::addSVGEventListener):
        * ksvg2/svg/SVGElementImpl.h:
        * ksvg2/svg/SVGGradientElementImpl.cpp:
        (SVGGradientElementImpl::parseAttribute):
        * ksvg2/svg/SVGHelper.cpp:
        (SVGHelper::PercentageOfViewport):
        * ksvg2/svg/SVGImageElementImpl.cpp:
        (SVGImageElementImpl::notifyFinished):
        * ksvg2/svg/SVGLengthListImpl.cpp:
        (SVGLengthListImpl::parse):
        * ksvg2/svg/SVGLinearGradientElementImpl.cpp:
        (SVGLinearGradientElementImpl::x2):
        * ksvg2/svg/SVGMatrixImpl.cpp:
        (SVGMatrixImpl::SVGMatrixImpl):
        (SVGMatrixImpl::postMultiply):
        (SVGMatrixImpl::postTranslate):
        (SVGMatrixImpl::postScale):
        (SVGMatrixImpl::postScaleNonUniform):
        (SVGMatrixImpl::postRotate):
        (SVGMatrixImpl::postRotateFromVector):
        (SVGMatrixImpl::postFlipX):
        (SVGMatrixImpl::postFlipY):
        (SVGMatrixImpl::postSkewX):
        (SVGMatrixImpl::postSkewY):
        (SVGMatrixImpl::multiply):
        (SVGMatrixImpl::setMatrix):
        (SVGMatrixImpl::qmatrix):
        * ksvg2/svg/SVGMatrixImpl.h:
        * ksvg2/svg/SVGPatternElementImpl.cpp:
        (SVGPatternElementImpl::parseAttribute):
        * ksvg2/svg/SVGSVGElementImpl.cpp:
        (SVGSVGElementImpl::width):
        (SVGSVGElementImpl::height):
        (SVGSVGElementImpl::contentScriptType):
        (SVGSVGElementImpl::contentStyleType):
        (SVGSVGElementImpl::setContentStyleType):
        (SVGSVGElementImpl::createEvent):
        * ksvg2/svg/SVGSVGElementImpl.h:
        * ksvg2/svg/SVGScriptElementImpl.cpp:
        (SVGScriptElementImpl::parseAttribute):
        (SVGScriptElementImpl::executeScript):
        * ksvg2/svg/SVGScriptElementImpl.h:
        * ksvg2/svg/SVGSetElementImpl.cpp:
        (SVGSetElementImpl::handleTimerEvent):
        * ksvg2/svg/SVGStyleElementImpl.cpp:
        (SVGStyleElementImpl::xmlspace):
        (SVGStyleElementImpl::type):
        (SVGStyleElementImpl::media):
        (SVGStyleElementImpl::title):
        (SVGStyleElementImpl::childrenChanged):
        * ksvg2/svg/SVGStyledElementImpl.cpp:
        (SVGStyledElementImpl::attach):
        * ksvg2/svg/SVGTransformableImpl.cpp:
        (SVGTransformableImpl::updateSubtreeMatrices):
        (SVGTransformableImpl::parseAttribute):
        (SVGTransformableImpl::parseTransformAttribute):
        * ksvg2/svg/SVGTransformableImpl.h:
        * kwq/KWQNamespace.h:
        (Qt::): Added LayoutDirection for Qt4 support
        * kwq/KWQWMatrix.h: #define mapping QMatrix to QWMatrix


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a7b0e9b8

07 Sep, 2005 5 commits

-added layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4781 · 09a70254

ggaren authored Sep 07, 2005

        Date.setMonth fails with big values due to overflow

        Fix is in JavaScriptCore.

        Test cases added:

        * layout-tests/fast/js/date-big-setmonth-expected.txt: Added.
        * layout-tests/fast/js/date-big-setmonth.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

09a70254

-fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4781 · 40ab0748

ggaren authored Sep 07, 2005

        Date.setMonth fails with big values due to overflow

        Reviewed by darin.

        * kjs/date_object.cpp:
        (timetUsingCF): for consistency, changed return statement to invalidDate instead of LONG_MAX
        (KJS::fillStructuresUsingTimeArgs): modified for readability
        (KJS::fillStructuresUsingDateArgs): new function analogous to fillStructuresUsingTimeArgs
        (KJS::DateProtoFuncImp::callAsFunction): modified to use fillStructuresUsingDateArgs
        (KJS::DateObjectImp::construct): moved variable declaration to proper scope
        (KJS::DateObjectFuncImp::callAsFunction): moved variable declaration to proper scope


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

40ab0748

-updated expected test results to reflect fix for · e6891592

ggaren authored Sep 07, 2005

        http://bugzilla.opendarwin.org/show_bug.cgi?id=4698
        kjs does not allow named functions in function expressions

        * tests/mozilla/expected.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e6891592

Reviewed by Justin. · a286d2f5

vicki authored Sep 07, 2005

        - fix <rdar://problem/4246096> REGRESSION links to named anchors don't scroll to the right place (4825)

        This is really just a better fix for 4233844. Also consolidated manual-tests/scrollToAnchorWithNewline.html
	and the test case from Bugzilla bug 4825 into manual-tests/scrollToAnchor.html.

        Test cases added:
        * manual-tests/scrollToAnchor.html: Added.

        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::ContainerNodeImpl::getUpperLeftCorner): when calculating scroll position, skip child nodes of the anchor
        if they do not have text boxes.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a286d2f5

Bug #: 4868 · 8ef8e05d

eseidel authored Sep 07, 2005

Submitted by: Tobias Lidskog <tobiaslidskog@mac.com>
Reviewed by: eseidel
        * kcanvas/KCanvasCreator.cpp:
        (KCanvasCreator::createCanvasPathData):
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        (KRenderingDeviceQuartz::contextForImage):
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        (KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
        * ksvg2/svg/SVGDocumentImpl.cpp:
        (SVGDocumentImpl::~SVGDocumentImpl):
        Fixed several leaks.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4868


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8ef8e05d

06 Sep, 2005 5 commits

Reviewed by John Sullivan. · cfc43863

darin authored Sep 07, 2005

        - fixed storage leaks; one of the leaks caused these 3 bugs:

        <rdar://problem/4231952> leaks of DOMStringImpl called from HTMLTokenizer::processToken, seen running WebKit tests
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4797>

        <rdar://problem/4233800> leak inside DOM::DocumentImpl::DocumentImpl, seen running webkit tests
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4795>

        <rdar://problem/4232812> leaks of NodeImpl called from HTMLParser::textCreateErrorCheck, seen running webkit tests
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4796>

        * khtml/html/html_elementimpl.cpp:
        (HTMLElementImpl::setOuterHTML): Put ref/deref around call to replaceChild to avoid leaking the node being replaced.
        (HTMLElementImpl::setOuterText): Put ref/deref around call to replaceChild to avoid leaking the node being replaced.
        Also changed removeChild calls to use remove instead, both for simplicity and to fix the leak without having
        to add a SharedPtr or ref/deref pair.

        * khtml/html/html_tableimpl.cpp:
        (DOM::HTMLTableElementImpl::setCaption): Put ref/deref around call to replaceChild to avoid leaking the node being
        replaced.
        (DOM::HTMLTableElementImpl::setTHead): Ditto.
        (DOM::HTMLTableElementImpl::setTFoot): Ditto.
        (DOM::HTMLTableElementImpl::setTBody): Tweaked a bit to match the other functions as closely as possible.
        No leak here.

        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::NodeImpl::remove): Added ref/deref to avoid leaking the node being removed.
        (DOM::NodeImpl::normalize): Changed two calls to removeChild to calls to remove to prevent leaks.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

cfc43863

Reviewed by harrison · a8e2408d

justing authored Sep 06, 2005

        Fixes <rdar://problem/3976872> REGRESSION (Mail): Pasted lines of plain text don't get the proper style if pasted into newlines

        For style matched paste, style information was gathered incorrectly.

        Test cases added:
        * layout-tests/editing/pasteboard/3976872-expected.txt: Added.
        * layout-tests/editing/pasteboard/3976872.html: Added.

        * khtml/editing/replace_selection_command.cpp:
        (khtml::ReplaceSelectionCommand::doApply):
        Even though the startBlock (selection.start().node()->enclosingBlockFlowElement) is where manipulation
        begins on a paste, it can be missing necessary style information.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a8e2408d

- fixed build bustage from last checkin. · 3c771d7c

ggaren authored Sep 06, 2005

        Reviewed by haytt.

        * History.subproj/WebBackForwardList.m:
        (-[WebBackForwardList pageCacheSize]): updated debug printf since we no
        longer have a variable called 'multiplier'


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3c771d7c

Reduce the # of cached pages for a back/forward list. The old cache would cache the · 4f2369d6

hyatt authored Sep 06, 2005

	following per tab:
	> 1gb memory = 16 pages per tab/window
	> 512mb memory = 8 pages per tab/window
	<= 512mb memory = 4 pages per tab/window

	This consumes far too much memory and is way too aggressive.  The new cache sizes are
	as follows:
	>= 1gb memory = 3 pages per tab/window
	>= 512mb memory = 2 pages per tab/window
	< 512mb memory = 1 page per tab/window

        Reviewed by john

        * History.subproj/WebBackForwardList.m:
        (-[WebBackForwardList pageCacheSize]):
        * WebView.subproj/WebPreferences.m:
        (+[WebPreferences initialize]):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4f2369d6

Bug #: 4864 · eae32a37

eseidel authored Sep 06, 2005

Submitted by: Tobias Lidskog <tobiaslidskog@mac.com>
Reviewed by: eseidel
        Don't create empty fill/stroke servers if fill/stroke
        are specified as "none".
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4864

        Test cases updated:
        * svg-tests/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/coords-units-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/filters-color-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/filters-example-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/linkingCircle-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/linkingToc-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-02-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-03-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-04-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/rects-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/rects_b-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/text-align-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/text-align-02-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/text-align-03-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/text-intro-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/text-tref-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/text-ws-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/toc-sv-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/toc-svcmp-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/color-prof-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/color-prop-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/color-prop-02-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/color-prop-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-units-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-units-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-units-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-example-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-image-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-light-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/interact-events-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/interact-order-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/interact-order-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/interact-order-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/linking-a-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/linking-a-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/linking-a-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/linking-a-04-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/masking-path-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/masking-path-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/masking-path-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/masking-path-04-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/masking-path-05-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-render-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/paths-data-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/paths-data-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/paths-data-03-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/paths-data-04-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/paths-data-05-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/paths-data-06-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/paths-data-07-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/render-elems-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/render-elems-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/render-elems-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/render-elems-06-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/render-elems-07-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/render-elems-08-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/render-groups-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/render-groups-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/script-handle-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/script-handle-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/script-handle-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/script-handle-04-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-group-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-group-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-image-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-image-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-image-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-image-04-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-image-05-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/styling-css-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/styling-css-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/styling-css-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-align-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-align-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-align-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-align-04-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-align-05-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-align-06-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-deco-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-intro-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-intro-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-intro-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-intro-04-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-path-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-text-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-text-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-tref-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-ws-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-ws-02-t-expected.txt:

        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        (KCanvasRenderingStyle::updateFill):
        (KCanvasRenderingStyle::updateStroke):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

eae32a37

05 Sep, 2005 7 commits

Reviewed by John Sullivan. · 261a5302

darin authored Sep 05, 2005

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4846
          REGRESSION: Carbon WebKit applications don't work at all

        * Carbon.subproj/HIWebView.m: Remove lots of unneeded declarations of private stuff.
        (Draw): Call WKNSWindowOverrideCGContext and WKNSWindowRestoreCGContext rather
        than calling a non-existent setCGContext: method on the context.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

261a5302

Reviewed by John Sullivan. · 88272553

darin authored Sep 05, 2005

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4822
          REGRESSION dragging does not stop when you release the mouse button in Google Maps

        Test cases added:
        * layout-tests/fast/dom/Window/window-remove-event-listener.html: Added.
        * layout-tests/fast/dom/Window/window-remove-event-listener-expected.txt: Added.

        * khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
        Fixed typo where window.removeEventListener would call addEventListener!


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

88272553

Reviewed by John Sullivan. · 1566f8a8

darin authored Sep 05, 2005

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4493
          add qualifiedName checking for empty string

        * khtml/xml/dom_docimpl.cpp:
        (qualifiedNameIsValid): Added.
        (qualifiedNameIsMalformed): Added.
        (DOMImplementationImpl::createDocumentType): Added checks and exceptions using above functions.
        (DOMImplementationImpl::createDocument): Ditto.

        * layout-tests/dom/html/level2/core/createDocument08-expected.txt: Updated to expect success.
        * layout-tests/dom/html/level2/core/createDocumentType04-expected.txt: Ditto.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1566f8a8

WebCore: · c367dcab

sullivan authored Sep 05, 2005

        Reviewed by Dave Hyatt.

        Test cases added: none, doesn't affect layout

        - fixed <rdar://problem/4211999> Safari quits when click-drag-hold an image that is
        set to automatically change.

        * khtml/khtmlview.cpp:
        (KHTMLView::updateDragAndDrop):
        add missing nil check

WebKit:

        Reviewed by Dave Hyatt.

        - change related to <rdar://problem/4211999> Safari quits when click-drag-hold an image
        that is set to automatically change.

        * WebView.subproj/WebHTMLView.m:
        (-[NSArray namesOfPromisedFilesDroppedAtDestination:]):
        handle nil wrapper with ERROR and early return rather than ASSERT, since we now know
        of a way to reproduce this (written up as 4244861)


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c367dcab

Reviewed by John Sullivan. · d2fc6de9

darin authored Sep 05, 2005

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4357
          crash related to animated GIFs, reproducible in non-Safari WebKit application

        * WebCoreSupport.subproj/WebImageData.m:
        (removeAnimatingRendererFromView): Added.
        (removeFromDictionary): Added.
        (-[WebImageData removeAnimatingRenderer:]): Rewrote using CF functions rather than
        NS functions so that we never retain the views, since this can be called from
        a view's dealloc method.
        (setNeedsDisplayInAnimationRect): Added.
        (-[WebImageData _nextFrame:]): Rewrote as above, even though in this case it can't
        be called from the dealloc method.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d2fc6de9

Reviewed by John Sullivan. · ba566dd9

darin authored Sep 05, 2005

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4025
          Reproducible crash (infinite recursion?) choosing Make Link from text field's contextual menu

        * kwq/KWQTextField.mm:
        (-[KWQTextFieldController textView:shouldChangeTextInRange:replacementString:]):
        Allow a replacement string of nil.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ba566dd9

Reviewed and landed by Darin. · 4d653499

darin authored Sep 05, 2005

        - added a test case that covers 8-digit hexadecimal entities

        * layout-tests/fast/parser/hex-entities-length.html: Added.
        * layout-tests/fast/parser/hex-entities-length-expected.txt: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4d653499

04 Sep, 2005 3 commits

Reviewed by John Sullivan. · 248f0901

darin authored Sep 05, 2005

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4274
          REGRESSION: canvas draws when window loses focus (flipped and in wrong position!)
        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4755
          "CGContext*: invalid context" messages dumped to the console (may indicate a performance hit)

        * khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::paint):
        Don't try to paint if painting is disabled.

        * kwq/KWQPainter.mm:
        (QPainter::addClip): Do nothing if painting is disabled.
        (QPainter::addRoundedRectClip): Ditto.
        (QPainter::currentContext): Assert that painting is not disabled.
        (QPainter::beginTransparencyLayer): Do nothing if painting is disabled.
        (QPainter::endTransparencyLayer): Ditto.
        (QPainter::setShadow): Ditto.
        (QPainter::clearShadow): Ditto.
        (QPainter::initFocusRing): Ditto.
        (QPainter::addFocusRingRect): Ditto.
        (QPainter::drawFocusRing): Ditto.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

248f0901

Reviewed by John Sullivan. · 3409aaee

darin authored Sep 05, 2005

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4393
          REGRESSION: Unconfirmed text ignored in input type=text

        Test cases added:
        * manual-tests/input-type-text-unconfirmed-inline-input.html: Added.

        * kwq/KWQTextField.mm:
        (-[KWQTextFieldController controlTextDidBeginEditing:]): Call
        setWantsNotificationForMarkedText:YES on the field editor so we get
        "text did change" calls even for changes to the marked text.
        (-[KWQTextFieldController controlTextDidChange:]): Only call the bridge
        when we have changes and there is no marked text -- this is good because
        the bridge is used to implement form auto-fill and preserves the existing
        behavior. A more elegant future fix would be to notify the bridge more often
        and have the auto-fill code itself implement the "don't auto-fill when there
        is marked text" rule.
        (-[NSTextField _KWQ_currentEditor]): Change type to NSTextView so we can
        use this function to code NSTextView-specific stuff. The field editors are
        always subclasses of NSTextView.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3409aaee

* kjs/identifier.cpp: Fix comment, add missing include. · eb94983d

darin authored Sep 04, 2005

        (Follow-on to changes from yesterday.)


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

eb94983d