Reviewed by Oliver Hunt.

        Bug 24596: ASSERT in JSC::PropertySlot::slotBase @ iGoogle homepage
        <https://bugs.webkit.org/show_bug.cgi?id=24596>
        <rdar://problem/6686493>

        JSDOMWindow::customGetOwnPropertySlot() does an access check after calling
        JSGlobalObject::getOwnPropertySlot(). This causes the PropertySlot to be
        set twice, once to the value that is illegal to access, and then to undefined
        This causes an assertion failure in property access caching code.

        The fix is to do the access check before calling JSGlobalObject::getOwnPropertySlot().

        WebCore:

        * bindings/js/JSDOMWindowCustom.h:
        (WebCore::JSDOMWindow::customGetOwnPropertySlot):

        LayoutTests:

        * http/tests/security/cross-frame-access-get-custom-property-cached-expected.txt: Added.
        * http/tests/security/cross-frame-access-get-custom-property-cached.html: Added.
        * http/tests/security/resources/cross-frame-access-get-custom-property-cached-iframe.html: Added.
        * http/tests/security/resources/cross-frame-access.js:
        (shouldBeUndefined):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        https://bugs.webkit.org/show_bug.cgi?id=24676
        Simple cross-origin requests shouldn't dispatch upload progress events

        Test: http/tests/xmlhttprequest/simple-cross-origin-progress-events.html

        * loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck): Added a comment
        explaining the somewhat unexpected behavior of this function.

        * xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::hasListeners):
        * xml/XMLHttpRequestUpload.h:
        Report whether there are any event listeners registered.

        * xml/XMLHttpRequest.h: Added m_uploadEventsAllowed.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::createRequest): Set m_uploadEventsAllowed flag.
        (WebCore::XMLHttpRequest::makeSameOriginRequest): Ditto.
        (WebCore::XMLHttpRequest::makeCrossOriginAccessRequest): Ditto.
        (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest): Set request body - it can be
        non-empty for POST requests.
        (WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight): Set m_uploadEventsAllowed flag.
        (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult): Ditto.
        (WebCore::XMLHttpRequest::abort): Only dispatch upload progress events if allowed.
        (WebCore::XMLHttpRequest::networkError): Ditto.
        (WebCore::XMLHttpRequest::abortError): Ditto.
        (WebCore::XMLHttpRequest::didSendData): Ditto.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24398
        Fix a crash when loading a svg file in Chromium's test_shell and
        then reloading the page.

        * history/BackForwardListChromium.cpp:
        (WebCore::BackForwardList::BackForwardList):
        (WebCore::BackForwardList::close):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Error: ..\..\runtime\DatePrototype.cpp(30) : fatal error C1083: Cannot open include file: 'langinfo.h': No such file or directory

        * runtime/DatePrototype.cpp:
        (JSC::formatLocaleDate):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Sam Weinig.

* platform/mac-snowleopard/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

what it was designed to test for some time, and is failing on some machines.
Fixing the test is tracked by <https://bugs.webkit.org/show_bug.cgi?id=24690>.

Rubber-stamped by Dan Bernstein.

* platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html-disabled: Renamed from LayoutTests/platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Oliver Hunt.

        WebKit side of <rdar://problem/6688244>.
        
        Try reinitializing the vendor port if it's invalid.
        
        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::spawnPluginHost):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Dan Bernstein.

Switch from using printf to using the NPAPI to invoke console.log so that plug-in messages appear
in test results even when the plug-in's stdout differs from DumpRenderTree's stdout.

* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(log): Invoke console.log via the NPAPI.
(NPP_Destroy): Call log instead of printf.
(NPP_SetWindow): Ditto.
(handleEventCarbon): Ditto.
(handleEventCocoa): Ditto.
(NPP_HandleEvent): Pass the instance in to the event handler.

Update test results for change to address <rdar://problem/6693300>.

* plugins/mouse-events-expected.txt:
* plugins/netscape-destroy-plugin-script-objects-expected.txt:
* plugins/netscape-plugin-setwindow-size-2-expected.txt:
* plugins/netscape-plugin-setwindow-size-expected.txt:
* plugins/open-and-close-window-with-plugin-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-18  Gustavo Noronha Silva  <gns@gnome.org> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24674
        Crashes in !PLATFORM(MAC)'s formatLocaleDate, in very specific situations

        Make sure strftime never returns 2-digits years to avoid ambiguity and
        a crash.

        * runtime/DatePrototype.cpp:
        (JSC::formatLocaleDate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Roben.

        * Interfaces/IWebUIDelegatePrivate.idl:
        * Interfaces/WebKit.idl:
        * WebView.cpp:
        (WebView::close):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Simon Fraser.

        Fix for <rdar://problem/6685235>
        <video> element poster cannot be set dynamically if not originally set up in HTML
        
        Allocate the media engine immediately so the plug-in proxy is available for
        scripting right away.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::MediaPlayer):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Rubber-stamped by Dan Bernstein.

        Updating test to reflect our joy.

        * fast/dom/offset-parent-positioned-and-inline-expected.txt:
        * fast/dom/offset-parent-positioned-and-inline.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-18  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dave Hyatt.

        Fix for <rdar://problem/6636747> REGRESSION (Safari 4 PB-r41326): 
        Popup menu appears at the wrong location on page at http://
        www.signonsandiego.com/

        This was a regression from http://trac.webkit.org/changeset/40769, 
        which changed the base class of RenderInline to 
        RenderBoxModelObject rather than RenderBox.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::offsetParent): offsetParent should return a 
        RenderBoxModelObject rather than just a RenderBox, which is more 
        restrictive. 

LayoutTests:

2009-03-18  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dave Hyatt.

        Test for <rdar://problem/6636747> REGRESSION (Safari 4 PB-r41326): 
        Popup menu appears at the wrong location on page at http://
        www.signonsandiego.com/

        * fast/dom/offset-parent-positioned-and-inline-expected.txt: Added.
        * fast/dom/offset-parent-positioned-and-inline.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6504776> 
        CrashTracer: [USER] 188 crashes in Safari at com.apple.WebCore • WTF::HashTableIterator<WTF::RefPtr<WebCore::ResourceLoader>, ...

        Return early in case calling the client ends up spinning the run loop and completing/cancelling the load.
        
        * loader/NetscapePlugInStreamLoader.cpp:
        (WebCore::NetscapePlugInStreamLoader::didCancel):

WebKit/mac:

2009-03-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6504776> 
        CrashTracer: [USER] 188 crashes in Safari at com.apple.WebCore • WTF::HashTableIterator<WTF::RefPtr<WebCore::ResourceLoader>, ...
        
        If the m_pluginView member was zeroed out as a result of making a call into the plug-in, the pluginFunctionCallDepth would be off
        causing the plug-in never to be stopped. Simplify the code by using a RAII object.

        * Plugins/WebBaseNetscapePluginStream.mm:
        (PluginStopDeferrer::PluginStopDeferrer):
        (PluginStopDeferrer::~PluginStopDeferrer):
        (WebNetscapePluginStream::startStream):
        (WebNetscapePluginStream::wantsAllStreams):
        (WebNetscapePluginStream::destroyStream):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24664
        Upstreaming v8 collection.h

        No change in behavior, so no test.

        * bindings/v8/V8Collection.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-18  Sam Weinig  <sam@webkit.org>

        Reviewed by Simon Fraser.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23966
        REGRESSION: Custom arrow navigation functionality doesn't work at dropular.net
        <rdar://problem/6589657>

        Match the CSSOM spec for getClientRects and getBoundingClientRect by
        returning a 0x0 rect at the correct top/left position for empty inline
        boxes.

        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::absoluteRects):
        (WebCore::RenderInline::absoluteQuads):

LayoutTests:

2009-03-18  Sam Weinig  <sam@webkit.org>

        Reviewed by Simon Fraser.

        Update test results for https://bugs.webkit.org/show_bug.cgi?id=23966
        REGRESSION: Custom arrow navigation functionality doesn't work at dropular.net
        <rdar://problem/6589657>

        * fast/dom/getBoundingClientRect-expected.txt:
        * fast/dom/getClientRects-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        https://bugs.webkit.org/show_bug.cgi?id=24670
        Add tests for XHR progress events during cross-origin requests.

        * http/tests/xmlhttprequest/redirect-cross-origin-2-expected.txt: Added.
        * http/tests/xmlhttprequest/redirect-cross-origin-2.html: Added.
        * http/tests/xmlhttprequest/redirect-cross-origin-expected.txt: Added.
        * http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt: Added.
        * http/tests/xmlhttprequest/redirect-cross-origin-post-sync-expected.txt: Added.
        * http/tests/xmlhttprequest/redirect-cross-origin-post-sync.html: Added.
        * http/tests/xmlhttprequest/redirect-cross-origin-post.html: Added.
        * http/tests/xmlhttprequest/redirect-cross-origin-sync-double-expected.txt: Added.
        * http/tests/xmlhttprequest/redirect-cross-origin-sync-double.html: Added.
        * http/tests/xmlhttprequest/redirect-cross-origin-sync-expected.txt: Added.
        * http/tests/xmlhttprequest/redirect-cross-origin-sync.html: Added.
        * http/tests/xmlhttprequest/redirect-cross-origin.html: Added.
        * http/tests/xmlhttprequest/simple-cross-origin-denied-events-expected.txt: Added.
        * http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-expected.txt: Added.
        * http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-sync-expected.txt: Added.
        * http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-sync.html: Added.
        * http/tests/xmlhttprequest/simple-cross-origin-denied-events-post.html: Added.
        * http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync-expected.txt: Added.
        * http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync.html: Added.
        * http/tests/xmlhttprequest/simple-cross-origin-denied-events.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        Match the changes done for windows in the bug
        https://bugs.webkit.org/show_bug.cgi?id=24530.

        No change in behavior, so no test.

        * rendering/RenderThemeChromiumLinux.cpp:
        (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Holger Freyther.

        Added support for SVG's stroked texts to Qt.

        [Qt] SVGs stroked text support missing
        https://bugs.webkit.org/show_bug.cgi?id=24262

        * platform/graphics/qt/FontQt.cpp:
        (WebCore::Font::drawComplexText):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Alexey Proskuryakov.

* platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::decode): Look for gb18030 case-insensitively,
as newer versions of ICU use GB18030 as the canonical name.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

<rdar://problem/6692138> REGRESSION (Safari 4): Incorrect function return value when using IE "try ... finally" memory leak work-around (24654)
<https://bugs.webkit.org/show_bug.cgi?id=24654>

Reviewed by Cameron Zwarich.

If the return value for a function is in a local register we need
to copy it before executing any finalisers, otherwise it is possible
for the finaliser to clobber the result.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24662
        Chromium build fixes.

        Bug https://bugs.webkit.org/show_bug.cgi?id=24663 tracks
        the invalid implementation of ScriptCallStack.

        No change in behavior, so no test.

        * bindings/v8/ScriptCallStack.h:
        (WebCore::ScriptCallStack::state):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::drawRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Oliver Hunt.

This allows tests inside the platform directory to have different results
on different versions of Mac OS X.

* Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rubber-stamped by Dan Bernstein.

The attributes aren't important to the test.

* platform/mac/fast/text/attributed-substring-from-range-001-expected.txt:
* platform/mac/fast/text/attributed-substring-from-range-001.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rubber-stamped by Dan Bernstein.

* platform/mac-leopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum.
* platform/mac-leopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png.
* platform/mac-leopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt.
* platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum.
* platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.png.
* platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.txt.
* platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum.
* platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png.
* platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt.
* platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum.
* platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-CS-after-AN-expected.png.
* platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt.
* platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.checksum.
* platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.png.
* platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.txt.
* platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
* platform/mac/fast/text/international/bidi-neutral-run-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

and non-Mac platforms are already skipping the tests.

Rubber-stamped by Dan Bernstein.

* fast/dom/Window/window-properties-expected.txt:
* fast/dom/navigator-detached-no-crash-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt: Removed.
* platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rubber-stamped by Sam Weinig.

* fast/xsl/mozilla-tests-expected.txt:
* platform/mac-leopard/fast/xsl/mozilla-tests-expected.txt: Copied from LayoutTests/fast/xsl/mozilla-tests-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Sam Weinig.

* platform/mac-leopard/fast/dom/Window/window-properties-expected.txt: Copied from LayoutTests/fast/dom/Window/window-properties-expected.txt.
* platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt.
* platform/mac/fast/dom/Window/window-properties-expected.txt: Copied from LayoutTests/fast/dom/Window/window-properties-expected.txt.
* platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Sam Weinig.

* geolocation/geolocation-not-implemented-expected.txt: Removed.
* geolocation/geolocation-not-implemented.html: Removed.
* geolocation/geolocation-test.js: Removed.
* platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rubber-stamped by Sam Weinig.

* platform/mac-leopard/css1/text_properties/text_transform-expected.checksum: Renamed from LayoutTests/platform/mac/css1/text_properties/text_transform-expected.checksum.
* platform/mac-leopard/css1/text_properties/text_transform-expected.png: Renamed from LayoutTests/platform/mac/css1/text_properties/text_transform-expected.png.
* platform/mac-leopard/css1/text_properties/text_transform-expected.txt: Copied from LayoutTests/platform/mac/css1/text_properties/text_transform-expected.txt.
* platform/mac-leopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.checksum: Renamed from LayoutTests/platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.checksum.
* platform/mac-leopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Renamed from LayoutTests/platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.png.
* platform/mac-leopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt.
* platform/mac/css1/text_properties/text_transform-expected.txt:
* platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by David Hyatt.

        Add anchor elements to the simple style sheet so that applications that
        are using WebKit just for simple text and links will also take advantage
        of the fast path.

        * css/CSSStyleSelector.cpp:
        (WebCore::elementCanUseSimpleDefaultStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Roben.

        Fixes the following bug in resolve-ChangeLogs:

            Use of uninitialized value in -e at ./WebKitTools/Scripts/resolve-ChangeLogs line 132.
            Died at ./WebKitTools/Scripts/resolve-ChangeLogs line 164.

        * Scripts/resolve-ChangeLogs:
        (findUnmergedChangeLogs): Check the result of findChangeLog() to
        make sure we don't add undef values to the list of files being
        returned.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-17  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        <rdar://problem/6687005> Need support for new move-left/right selectors.

        * editing/EditorCommand.cpp:
        (WebCore::executeMoveToLeftEndOfLine): Added.
        (WebCore::executeMoveToLeftEndOfLineAndModifySelection): Added.
        (WebCore::executeMoveToRightEndOfLine): Added.
        (WebCore::executeMoveToRightEndOfLineAndModifySelection): Added.
        Added command entries for the functions above.

WebKit/mac:

2009-03-17  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        <rdar://problem/6687005> Need support for new move-left/right selectors.

        * WebView/WebHTMLView.mm: Added the four new selectors to the command-forwarding list.
        * WebView/WebView.mm: Ditto.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adele Peterson.

        Bug 24477: REGRESSION (r41467): Page Down key scrolls two pages
        https://bugs.webkit.org/show_bug.cgi?id=24477
        rdar://problem/6674184

        * WebView/WebHTMLView.mm:
        (responderChainRespondsToSelector): Added.
        (-[WebHTMLView doCommandBySelector:]): Set eventWasHandled based on whether we
        can find a responder that responds to this selector rather than always assuming
        the selector will not be handled.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adele Peterson.

        Put the padding inside scrollbars on textareas.
        https://bugs.webkit.org/show_bug.cgi?id=24370

        Put the padding inside the scrollbars on textareas. This is done by moving the
        overflow from the shadowNode to the RenderTextControlMultiline. As a result,
        all of the scroll handing methods that RenderTextControl overrides can be moved
        down into RenderTextControlSingleLine since RenderTextControlMultiline can now
        just use RenderBlock's versions. This also allows RenderTextControlMultiLine to
        no longer need a custom layout method since the shadowNode can now just size
        like a regular DIV.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::styleDidChange):
        (WebCore::RenderTextControl::selection):
        (WebCore::RenderTextControl::calcHeight):
        (WebCore::RenderTextControl::hitInnerTextElement):
        * rendering/RenderTextControl.h:
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::nodeAtPoint):
        (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
        * rendering/RenderTextControlMultiLine.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::styleDidChange):
        (WebCore::RenderTextControlSingleLine::autoscroll):
        (WebCore::RenderTextControlSingleLine::scrollWidth):
        (WebCore::RenderTextControlSingleLine::scrollHeight):
        (WebCore::RenderTextControlSingleLine::scrollLeft):
        (WebCore::RenderTextControlSingleLine::scrollTop):
        (WebCore::RenderTextControlSingleLine::setScrollLeft):
        (WebCore::RenderTextControlSingleLine::setScrollTop):
        (WebCore::RenderTextControlSingleLine::scroll):
        * rendering/RenderTextControlSingleLine.h:
        * rendering/TextControlInnerElements.cpp:
        (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
        (WebCore::RenderTextControlInnerBlock::positionForPoint):
        (WebCore::TextControlInnerTextElement::createRenderer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by David Hyatt.

        Bug 24517: REGRESSION (r41552): innerHTML does an updateLayout -- unneeded and can be slow
        https://bugs.webkit.org/show_bug.cgi?id=24517

        * editing/DeleteButtonController.cpp:
        (WebCore::DeleteButtonController::enable): Added a call to updateRendering, since
        determining whether to display the delete button involves style and updateRendering
        also updates style (should probably be named updateStyle, in fact). Not needed to fix
        this bug, but would have prevented the crash that led to this bug in the first place.

        * editing/EditCommand.cpp:
        (WebCore::EditCommand::EditCommand): Get rid of unneeded null check. All frames have
        delete button controllers.
        * editing/Editor.cpp:
        (WebCore::Editor::rangeForPoint): Ditto.

        * editing/markup.cpp:
        (WebCore::appendStartMarkup): Changed a "&" to a "&&" so that generating markup
        doesn't depend on renderers at all when the convertBlocksToInlines boolean is false.
        This allows us to omit the call to updateLayoutIgnorePendingStylesheets in the
        createMarkup function that's called by innerHTML.
        (WebCore::MarkupAccumulator::appendMarkup): Turned this into a class with a member
        function. Added a feature where the accumulator will skip a node. Moved arguments
        that don't change during recursion into an object. This function still is a bit
        inefficient, since it creates a new HashMap at every level as it recurses, but for now
        I did not tackle that. Also replaced the onlyIncludeChildren boolean with EChildrenOnly
        for consistency and clarity.
        (WebCore::createMarkup): Removed the call to updateLayoutIgnorePendingStylesheets.
        Instead of calling disable/enable on the delete button controller's container element,
        pass it in to the markup accumulator as a node to skip.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Simon Fraser.

        Fix the usage of the $architecture variable for non-Apple-Mac
        ports.

        * Scripts/webkitdirs.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24651
        Skia does not always render text fill/stroke pattern/gradient/color correctly

        Changes Skia's font rendering to only render gradient/pattern if current
        color space indicates the gradient/pattern should be used.
        This is covered by LayoutTests/fast/canvas/canvas-text-alignment.html .

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::strokeColorSpace):
        (WebCore::GraphicsContext::fillColorSpace):
        * platform/graphics/GraphicsContext.h:
        (WebCore::):
        * platform/graphics/GraphicsContextPrivate.h:
        * platform/graphics/skia/SkiaFontWin.cpp:
        (WebCore::paintSkiaText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-17  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=24655
        <rdar://problem/6633727> Hitting return at the end of a line with an anchor jumps me to the bottom of the message

        Test: editing/inserting/6633727.html

        This changes does a few things:
        1) Renames pos to insertionPosition.
        2) Eliminates "startNode".  It doesn't work well to consider the node separately from the insertionPosition.  
           The insertionPosition gets updated at various times, and it seems likely that startNode can get out of sync.
        3) Before building up a list of ancestors to move around when we insert the new block, make sure to use the deepest
           representation of the insertionPosition, so all ancestor nodes are correctly included.

        * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):

LayoutTests:

2009-03-17  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Test for https://bugs.webkit.org/show_bug.cgi?id=24655
        <rdar://problem/6633727> Hitting return at the end of a line with an anchor jumps me to the bottom of the message

        * editing/inserting/6633727.html: Added.
        * platform/mac/editing/inserting/6633727-expected.checksum: Added.
        * platform/mac/editing/inserting/6633727-expected.png: Added.
        * platform/mac/editing/inserting/6633727-expected.txt: Added.

        Updated results.  The behavior for these tests doesn't change, but the render tree is slightly different.

        * platform/mac/editing/inserting/insert-div-021-expected.txt:
        * platform/mac/editing/style/block-styles-007-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* Plugins/Hosted/HostedNetscapePluginStream.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41787 268f45cc-cd09-0410-ab3c-d52691b4dbfc