1. 09 Jul, 2006 12 commits
    • darin's avatar
      77e51565
    • ddkilzer's avatar
      LayoutTests: · 6c3030b2
      ddkilzer authored
              Reviewed by Darin.
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=9797
                Make description() in fast/js/resources/js-test-pre.js work with MSIE 6
      
              * fast/js/resources/js-test-pre.js: Change description() to work with MSIE 6.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c3030b2
    • darin's avatar
      - move 4 files out of kwq directory · 494ede16
      darin authored
              - make some minor project adjustments for the WebCore project
      
              * WebCore.xcodeproj/project.pbxproj: Link libsqlite3 the same way we do other
              libraries, rather than using a custom linker option. Moved the files from their
              old locations to the new ones. Removed "khtml" from the list of header search
              paths since that directory doesn't exist any more. Eliminated STYLE_LDFLAGS
              and just put -umbrella WebKit in OTHER_LDFLAGS in the Production configuration
              (was a leftover from "build styles" in Xcode 1). Changed to use EXPORTED_SYMBOLS_FILE
              instead of using -exported_symbols_list directly again now that Xcode has fixed the
              "strip twice" bug. Removed unneeded explicit SECTORDER_FLAGS = "" settings.
              Removed the explicit -Y,3 option now that Xcode does that by default.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj: Removed some obsolete uneeded files,
              many of which didn't exist any more. Moved the files from their old locations
              to the new ones.
      
              * WebCoreSources.bkl: Moved the files from their old locations to the new ones.
      
              * kwq/DeprecatedCString.cpp: Removed.
              * kwq/DeprecatedCString.h: Removed.
              * kwq/TextStream.cpp: Removed.
              * kwq/TextStream.h: Removed.
              * platform/DeprecatedCString.cpp: Added.
              * platform/DeprecatedCString.h: Added.
              * platform/TextStream.cpp: Added.
              * platform/TextStream.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      494ede16
    • ddkilzer's avatar
      WebKitTools: · 095ec63b
      ddkilzer authored
              Reviewed by NOBODY (build fix).
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=7802
                devenv.com not available in VC++ Express installations
      
              * Scripts/webkitdirs.pm: Restore Hyatt's original logic to make buildbot
              work again.  Add VC++ Express check as the fallback.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      095ec63b
    • darin's avatar
      Rubber stamped by Maciej (kinda). · b53ebdcb
      darin authored
              - did the next pass of renaming (used do-webcore-rename script)
                this takes care of most of the remaining KWQ names (almost all)
      
              * WebCore+SVG/DOMList.h:
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * bindings/js/kjs_dom.cpp:
              * bindings/js/kjs_window.cpp:
              * bindings/objc/DOMHTML.mm:
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              * bridge/mac/WebCoreFrameBridge.mm:
              * bridge/mac/WebCoreSettings.h:
              * bridge/mac/WebCoreSettings.mm:
              * bridge/win/FrameWin.cpp:
              * css/CSSPrimitiveValue.cpp:
              * css/CSSValueKeywords.in:
              * css/MediaQueryEvaluator.cpp:
              * css/cssparser.cpp:
              * css/cssstyleselector.cpp:
              * css/cssstyleselector.h:
              * dom/CharacterData.cpp:
              * dom/CharacterData.h:
              * dom/Document.cpp:
              * dom/Element.cpp:
              * dom/Element.h:
              * dom/EventTargetNode.cpp:
              * dom/EventTargetNode.h:
              * dom/Node.cpp:
              * dom/Node.h:
              * dom/Position.cpp:
              * dom/ProcessingInstruction.cpp:
              * dom/QualifiedName.cpp:
              * dom/QualifiedName.h:
              * dom/XMLTokenizer.cpp: Added.
              * dom/xml_tokenizer.cpp: Removed.
              * dom/xml_tokenizer.h: Removed.
              * editing/EditAction.h:
              * editing/HTMLInterchange.cpp:
              * editing/HTMLInterchange.h:
              * editing/Selection.h:
              * editing/SelectionController.h:
              * editing/TextAffinity.h:
              * editing/TextIterator.cpp:
              * editing/TextIterator.h:
              * editing/VisiblePosition.h:
              * editing/htmlediting.cpp:
              * editing/markup.cpp:
              * editing/markup.h:
              * editing/visible_units.cpp:
              * editing/visible_units.h:
              * html/HTMLDocument.cpp:
              * html/HTMLFontElement.cpp:
              * html/HTMLInputElement.cpp:
              * html/HTMLKeygenElement.cpp:
              * html/HTMLSelectElement.h:
              * html/HTMLTextAreaElement.cpp:
              * html/HTMLTextFieldInnerElement.cpp:
              * html/HTMLTokenizer.cpp:
              * html/HTMLTokenizer.h:
              * kcanvas/KCanvasContainer.cpp: Removed.
              * kcanvas/KCanvasContainer.h: Removed.
              * kcanvas/KCanvasCreator.cpp:
              * kcanvas/KCanvasFilters.cpp:
              * kcanvas/KCanvasFilters.h:
              * kcanvas/KCanvasMatrix.cpp:
              * kcanvas/KCanvasMatrix.h:
              * kcanvas/KCanvasPath.cpp:
              * kcanvas/KCanvasPath.h:
              * kcanvas/KCanvasResources.cpp:
              * kcanvas/KCanvasResources.h:
              * kcanvas/KCanvasTreeDebug.cpp:
              * kcanvas/KCanvasTreeDebug.h:
              * kcanvas/RenderForeignObject.cpp:
              * kcanvas/RenderForeignObject.h:
              * kcanvas/RenderPath.cpp:
              * kcanvas/RenderPath.h:
              * kcanvas/RenderSVGContainer.cpp: Added.
              * kcanvas/RenderSVGContainer.h: Added.
              * kcanvas/RenderSVGImage.cpp:
              * kcanvas/RenderSVGImage.h:
              * kcanvas/RenderSVGText.cpp:
              * kcanvas/RenderSVGText.h:
              * kcanvas/device/KRenderingPaintServer.h:
              * kcanvas/device/KRenderingPaintServerGradient.cpp:
              * kcanvas/device/KRenderingPaintServerGradient.h:
              * kcanvas/device/KRenderingPaintServerPattern.cpp:
              * kcanvas/device/KRenderingPaintServerPattern.h:
              * kcanvas/device/KRenderingPaintServerSolid.cpp:
              * kcanvas/device/KRenderingPaintServerSolid.h:
              * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
              * kcanvas/device/quartz/KCanvasItemQuartz.h:
              * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
              * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
              * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
              * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
              * ksvg2/css/CSSValueKeywords.in:
              * ksvg2/css/SVGRenderStyleDefs.cpp:
              * ksvg2/misc/KCanvasRenderingStyle.cpp:
              * ksvg2/misc/KSVGTimeScheduler.cpp:
              * ksvg2/svg/SVGAElement.cpp:
              * ksvg2/svg/SVGAnimateTransformElement.cpp:
              * ksvg2/svg/SVGAnimateTransformElement.h:
              * ksvg2/svg/SVGGElement.cpp:
              * ksvg2/svg/SVGHelper.cpp:
              * ksvg2/svg/SVGHelper.h:
              * ksvg2/svg/SVGImageElement.cpp:
              * ksvg2/svg/SVGLinearGradientElement.cpp:
              * ksvg2/svg/SVGMarkerElement.cpp:
              * ksvg2/svg/SVGMaskElement.cpp:
              * ksvg2/svg/SVGMatrix.cpp:
              * ksvg2/svg/SVGMatrix.h:
              * ksvg2/svg/SVGPatternElement.cpp:
              * ksvg2/svg/SVGRadialGradientElement.cpp:
              * ksvg2/svg/SVGSVGElement.cpp:
              * ksvg2/svg/SVGStyledElement.h:
              * ksvg2/svg/SVGStyledTransformableElement.cpp:
              * ksvg2/svg/SVGStyledTransformableElement.h:
              * ksvg2/svg/SVGSwitchElement.cpp:
              * ksvg2/svg/SVGTextElement.cpp:
              * ksvg2/svg/SVGTransformable.h:
              * ksvg2/svg/SVGUseElement.cpp:
              * kwq/AffineTransform.cpp: Added.
              * kwq/AffineTransform.h: Added.
              * kwq/DeprecatedCString.cpp: Added.
              * kwq/DeprecatedCString.h: Added.
              * kwq/DeprecatedPtrQueue.h: Added.
              * kwq/FileButton.h: Added.
              * kwq/FileButton.mm: Added.
              * kwq/FormDataMac.mm: Added.
              * kwq/KWQCString.cpp: Removed.
              * kwq/KWQCString.h: Removed.
              * kwq/KWQComboBox.h: Removed.
              * kwq/KWQComboBox.mm: Removed.
              * kwq/KWQEditCommand.h: Removed.
              * kwq/KWQEditCommand.mm: Removed.
              * kwq/KWQFileButton.h: Removed.
              * kwq/KWQFileButton.mm: Removed.
              * kwq/KWQFormData.h: Removed.
              * kwq/KWQFormData.mm: Removed.
              * kwq/KWQKHTMLSettings.h: Removed.
              * kwq/KWQKIOGlobal.h: Removed.
              * kwq/KWQKSSLKeyGen.h: Removed.
              * kwq/KWQKSSLKeyGen.mm: Removed.
              * kwq/KWQLineEdit.h: Removed.
              * kwq/KWQLineEdit.mm: Removed.
              * kwq/KWQListBox.h: Removed.
              * kwq/KWQListBox.mm: Removed.
              * kwq/KWQLoader.h: Removed.
              * kwq/KWQLoader.mm: Removed.
              * kwq/KWQPageState.h: Removed.
              * kwq/KWQPageState.mm: Removed.
              * kwq/KWQPtrQueue.h: Removed.
              * kwq/KWQResourceLoader.h: Removed.
              * kwq/KWQResourceLoader.mm: Removed.
              * kwq/KWQScrollBar.h: Removed.
              * kwq/KWQScrollBar.mm: Removed.
              * kwq/KWQSlider.h: Removed.
              * kwq/KWQSlider.mm: Removed.
              * kwq/KWQTextEdit.h: Removed.
              * kwq/KWQTextEdit.mm: Removed.
              * kwq/KWQTextStream.cpp: Removed.
              * kwq/KWQTextStream.h: Removed.
              * kwq/KWQWMatrix.cpp: Removed.
              * kwq/KWQWMatrix.h: Removed.
              * kwq/ListBox.h: Added.
              * kwq/ListBox.mm: Added.
              * kwq/LoaderFunctions.h: Added.
              * kwq/LoaderFunctions.mm: Added.
              * kwq/PopUpButton.h: Added.
              * kwq/PopUpButton.mm: Added.
              * kwq/SSLKeyGenerator.h: Added.
              * kwq/SSLKeyGenerator.mm: Added.
              * kwq/Settings.h: Added.
              * kwq/TextBox.h: Added.
              * kwq/TextBox.mm: Added.
              * kwq/TextField.h: Added.
              * kwq/TextField.mm: Added.
              * kwq/TextStream.cpp: Added.
              * kwq/TextStream.h: Added.
              * kwq/WebCoreEditCommand.h: Added.
              * kwq/WebCoreEditCommand.mm: Added.
              * kwq/WebCorePageState.h: Added.
              * kwq/WebCorePageState.mm: Added.
              * kwq/WebCoreResourceLoaderImp.h: Added.
              * kwq/WebCoreResourceLoaderImp.mm: Added.
              * kwq/WebCoreScrollBar.h: Added.
              * kwq/WebCoreScrollBar.mm: Added.
              * kwq/WebCoreSlider.h: Added.
              * kwq/WebCoreSlider.mm: Added.
              * loader/Cache.h:
              * loader/CachedCSSStyleSheet.cpp:
              * loader/CachedImage.cpp:
              * loader/CachedObject.h:
              * loader/CachedObjectClientWalker.h:
              * loader/CachedResource.h:
              * loader/CachedResourceClientWalker.h:
              * loader/CachedScript.h:
              * loader/CachedXBLDocument.h:
              * loader/Decoder.h:
              * loader/DocLoader.cpp:
              * loader/DocLoader.h:
              * loader/FormData.h:
              * loader/ImageDocument.cpp:
              * loader/PluginDocument.cpp:
              * loader/TextDocument.cpp:
              * loader/loader.cpp:
              * loader/loader.h:
              * page/Frame.cpp:
              * page/Frame.h:
              * page/FramePrivate.h:
              * page/Page.cpp:
              * page/Page.h:
              * platform/DeprecatedPtrList.h:
              * platform/DeprecatedPtrListImpl.cpp:
              * platform/DeprecatedPtrListImpl.h:
              * platform/DeprecatedString.cpp:
              * platform/DeprecatedString.h:
              * platform/DeprecatedStringList.cpp:
              * platform/DeprecatedStringList.h:
              * platform/DeprecatedValueList.h:
              * platform/DeprecatedValueListImpl.cpp:
              * platform/DeprecatedValueListImpl.h:
              * platform/FloatSize.h:
              * platform/Font.cpp:
              * platform/KURL.cpp:
              * platform/RegularExpression.cpp:
              * platform/RegularExpression.h:
              * platform/SegmentedString.h:
              * platform/StreamingTextDecoder.cpp:
              * platform/String.cpp:
              * platform/StringImpl.cpp:
              * platform/TextEncoding.cpp:
              * platform/TransferJob.cpp:
              * platform/TransferJob.h:
              * platform/TransferJobInternal.h:
              * platform/gdk/FrameGdk.cpp:
              * platform/gdk/TemporaryLinkStubs.cpp:
              * platform/mac/ClipboardMac.h:
              * platform/mac/ClipboardMac.mm:
              * platform/mac/CursorMac.mm:
              * platform/mac/DeprecatedStringMac.mm: Added.
              * platform/mac/FontCacheMac.mm:
              * platform/mac/FontMac.mm:
              * platform/mac/FoundationExtras.h:
              * platform/mac/ImageMac.mm:
              * platform/mac/KURLMac.mm:
              * platform/mac/MouseEventMac.mm: Removed.
              * platform/mac/QStringListMac.mm: Removed.
              * platform/mac/QStringMac.mm: Removed.
              * platform/mac/TransferJobMac.mm:
              * platform/mac/WebCoreTextArea.h:
              * platform/mac/WebCoreTextArea.mm:
              * platform/mac/WebCoreTextField.h:
              * platform/mac/WebCoreTextField.mm:
              * platform/mac/WidgetMac.mm:
              * platform/win/TemporaryLinkStubs.cpp:
              * rendering/DataRef.h:
              * rendering/DeprecatedRenderSelect.cpp:
              * rendering/DeprecatedRenderSelect.h:
              * rendering/DeprecatedSlider.cpp:
              * rendering/InlineFlowBox.cpp:
              * rendering/RenderApplet.cpp:
              * rendering/RenderBlock.cpp:
              * rendering/RenderBlock.h:
              * rendering/RenderContainer.cpp:
              * rendering/RenderFileButton.cpp:
              * rendering/RenderFlexibleBox.cpp:
              * rendering/RenderFlow.cpp:
              * rendering/RenderFormElement.cpp:
              * rendering/RenderFrameSet.cpp:
              * rendering/RenderFrameSet.h:
              * rendering/RenderImage.cpp:
              * rendering/RenderInline.cpp:
              * rendering/RenderLayer.cpp:
              * rendering/RenderLayer.h:
              * rendering/RenderLineEdit.cpp:
              * rendering/RenderListItem.cpp:
              * rendering/RenderListMarker.cpp:
              * rendering/RenderObject.cpp:
              * rendering/RenderObject.h:
              * rendering/RenderPartObject.cpp:
              * rendering/RenderReplaced.cpp:
              * rendering/RenderStyle.cpp: Added.
              * rendering/RenderStyle.h: Added.
              * rendering/RenderTable.cpp:
              * rendering/RenderTable.h:
              * rendering/RenderTableCell.cpp:
              * rendering/RenderTableCell.h:
              * rendering/RenderTableCol.cpp:
              * rendering/RenderTableCol.h:
              * rendering/RenderTableRow.cpp:
              * rendering/RenderTableSection.cpp:
              * rendering/RenderTableSection.h:
              * rendering/RenderText.cpp:
              * rendering/RenderText.h:
              * rendering/RenderTextArea.cpp:
              * rendering/RenderTextControl.cpp: Added.
              * rendering/RenderTextControl.h: Added.
              * rendering/RenderTextField.cpp: Removed.
              * rendering/RenderTextField.h: Removed.
              * rendering/RenderTheme.cpp:
              * rendering/RenderThemeMac.mm:
              * rendering/RenderTreeAsText.cpp:
              * rendering/RenderTreeAsText.h:
              * rendering/RenderView.cpp:
              * rendering/RenderWidget.cpp:
              * rendering/bidi.cpp:
              * rendering/render_style.cpp: Removed.
              * rendering/render_style.h: Removed.
              * xml/XSLStyleSheet.cpp:
              * xml/XSLTProcessor.cpp:
              * xml/xmlhttprequest.cpp:
              * xpath/impl/XPathParser.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b53ebdcb
    • ddkilzer's avatar
      WebKitTools: · aef91fd0
      ddkilzer authored
              Reviewed by Timothy Hatcher.
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=7802
                devenv.com not available in VC++ Express installations
      
              * Scripts/webkitdirs.pm: Make Windows build work with Visual C++ Express.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aef91fd0
    • jdevalk's avatar
      Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=9804 · 493a8251
      jdevalk authored
      In the congratulations message, "capatibilies" should be "capabilities".
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      493a8251
    • ddkilzer's avatar
      Tweaked bug title in last comment to be correct. · 6be31f12
      ddkilzer authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6be31f12
    • ddkilzer's avatar
      WebCore: · 9ad333ec
      ddkilzer authored
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8251
              navigator.product incorrect in WebKit.app on Intel Macs
      
              For navigator.platform return "MacIntel" for Intel processors, "MacPPC"
              otherwise.
      
              * bindings/js/kjs_navigator.cpp:
              (KJS::Navigator::getValueProperty):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ad333ec
    • ddkilzer's avatar
      WebKitTools: · 25d78b5f
      ddkilzer authored
              Reviewed by Timothy Hatcher.
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=9794
                Teach run-webkit-tests how to ignore tests with performance improvements
      
              * Scripts/run-webkit-tests: Speed up test list generation, implement --ignore-tests
              feature, and minor clean up.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25d78b5f
    • thatcher's avatar
      LayoutTests: · e6e3e565
      thatcher authored
              Reviewed by Maciej.
      
              Bug 5312: comments aren't available via DOM
              http://bugzilla.opendarwin.org/show_bug.cgi?id=5312
      
              New tests for DOM comment nodes. Updated results to account for new
              nodes in the DOM (editing offsets changed.)
      
              * editing/deleting/delete-line-013-expected.txt:
              * editing/deleting/delete-line-014-expected.txt:
              * editing/inserting/insert-3907422-fix-expected.txt:
              * editing/inserting/insert-div-009-expected.txt:
              * editing/inserting/insert-div-010-expected.txt:
              * editing/selection/extend-by-character-006-expected.txt:
              * editing/selection/move-between-blocks-no-001-expected.txt:
              * editing/selection/move-between-blocks-yes-001-expected.txt:
              * fast/dom/HTMLDocument/object-by-name-or-id-expected.txt:
              * fast/dom/HTMLDocument/object-by-name-or-id.html:
              * fast/dom/comment-document-fragment-expected.txt: Added.
              * fast/dom/comment-document-fragment.html: Added.
              * fast/dom/comment-dom-node-expected.txt: Added.
              * fast/dom/comment-dom-node.html: Added.
              * fast/dom/comment-not-documentElement-expected.checksum: Added.
              * fast/dom/comment-not-documentElement-expected.png: Added.
              * fast/dom/comment-not-documentElement-expected.txt: Added.
              * fast/dom/comment-not-documentElement.html: Added.
              * fast/text/atsui-pointtooffset-calls-cg-expected.txt:
              * fast/text/atsui-rtl-override-selection-expected.txt:
      
      WebCore:
      
              Reviewed by Maciej.
      
              Bug 5312: comments aren't available via DOM
              http://bugzilla.opendarwin.org/show_bug.cgi?id=5312
      
              <rdar://problem/4564414> getting comments via DOM isn't working (5312)
              <rdar://problem/4545691> DOM_COMMENT node masking out real DOM elements
      
              * dom/Document.cpp:
              (WebCore::Document::removedLastRef): set m_documentElement to 0
              (WebCore::Document::childrenChanged): invalidate the document element we have cached in case it was replaced
              (WebCore::Document::documentElement): cache the first element as the document node if m_documentElement is 0
              * dom/Document.h: added m_documentElement
              * html/HTMLDocument.cpp: removed documentElement(), HTML documents just use Document's documentElement()
              * html/HTMLDocument.h: ditto
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::handleError): make a new HTML node is the document's firstChild is NULL or
              the firstChild is not a HTML element (like a comment)
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::parseComment): removed the #ifdef to include comment nodes
      
      WebKit:
      
              Reviewed by Maciej.
      
              Bug 5312: comments aren't available via DOM
              http://bugzilla.opendarwin.org/show_bug.cgi?id=5312
      
              Makes the Web Inspector show comment node contents.
      
              * WebInspector/WebInspector.m:
              (-[DOMNode _displayName]): return the contents of the comment
              * WebInspector/webInspector/inspector.js: check for comment nodes
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6e3e565
    • ap's avatar
      Reviewed by Darin. · f3cdbab5
      ap authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=9572
              Add application/xhtml+xml to the Accept header
      
              * WebView/WebFrame.m:
              (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): Add an Accept header
              to main resource requests.
              * English.lproj/StringsNotToBeLocalized.txt: Added new strings.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3cdbab5
  2. 08 Jul, 2006 14 commits
  3. 07 Jul, 2006 14 commits
    • ggaren's avatar
      - build fix · b2a04bbe
      ggaren authored
              * JSUtils.cpp:
              (KJSValueToCFTypeInternal):
              * JSValueWrapper.cpp:
              (JSValueWrapper::JSObjectCopyPropertyNames):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2a04bbe
    • justing's avatar
      LayoutTests: · acef81d1
      justing authored
              Reviewed by levi
      
              * editing/selection/editable-non-editable-crash-expected.checksum: Added.
              * editing/selection/editable-non-editable-crash-expected.png: Added.
              * editing/selection/editable-non-editable-crash-expected.txt: Added.
              * editing/selection/editable-non-editable-crash.html: Added.
              * editing/selection/skip-non-editable-1-expected.txt:
              * editing/selection/skip-non-editable-1.html:
      
      WebCore:
      
              Reviewed by levi
              
              Fix Mail ToDo crashers.
      
              * dom/Range.cpp:
              (WebCore::Range::compareBoundaryPoints): Added an ASSERT that both
              containers are non-null and an early return.
              * editing/Selection.cpp:
              (WebCore::Selection::validate): Fix a dangling start/end.
              (WebCore::Selection::adjustForEditableContent): Added an early return if
              m_start or m_end are null.
              (WebCore::Selection::isContentEditable): Use isRichlyEditablePosition.
              (WebCore::Selection::isCont...
      acef81d1
    • ggaren's avatar
      Reviewed by Maciej. · 2564df29
      ggaren authored
              
              - Standardized which functions take a JSContext as an argument. The rule is:
              if you might execute JavaScript, you take a JSContext, otherwise you don't.
              
              The FIXME in JSObjectRef.h requires refactoring some parts of Interpreter,
              but not API changes, so I'm putting it off until later.
      
              * API/JSCallbackObject.cpp:
              (KJS::JSCallbackObject::JSCallbackObject):
              (KJS::JSCallbackObject::init):
              * API/JSCallbackObject.h:
              * API/JSContextRef.cpp:
              (JSContextCreate):
              * API/JSContextRef.h:
              * API/JSObjectRef.cpp:
              (JSObjectMake):
              (JSPropertyEnumeratorGetNext):
              * API/JSObjectRef.h:
              * API/testapi.c:
              (MyObject_initialize):
              (main):
              * JavaScriptCore.exp:
              * kjs/array_object.cpp:
              (ArrayInstance::setLength):
              (ArrayInstance::pushUndefinedObjectsToEnd):
              * kjs/nodes.cpp:
              (ForInNode::execute):
              * kjs/reference.cpp:
              (KJS::Reference::getPropertyName):
              (KJS::Reference::getValue):
              * kjs/reference.h:
              * kjs/scope_chain.cpp:
              (KJS::ScopeChain::print):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2564df29
    • ggaren's avatar
      Reviewed by Maciej. · 554ad6fb
      ggaren authored
              
              More API action.
              
              - Headerdoc finished
      
              Semantic Changes:
              - Added a JSContextRef argument to many functions, because you need a 
              JSContextRef for doing virtually anything. I expect to add this argument
              to even more functions in a future patch.
              
              - Removed the globalObjectPrototype argument to JSContextCreate because
              you can't create an object until you have a context, so it's impossible
              to pass a prototype object to JSContextCreate. That's OK because (1) there's
              no reason to give the global object a prototype and (2) if you really want
              to, you can just use a separate call to JSObjectSetPrototype.
              
              - Removed the JSClassRef argument to JSClassCreate because it was unnecessary,
              and you need to be able to make the global object's class before you've
              created a JSContext.
              
              - Added an optional exception parameter to JSFunctionMakeWithBody because anything
              less would be uncivilized.
              
              - Made the return value parameter to JSObjectGetProperty optional to match
              all other return value parameters in the API.
              
              - Made JSObjectSetPrivate/JSObjectGetPrivate work on JSCallbackFunctions
              and JSCallbackConstructors. You could use an abstract base class or strategic
              placement of m_privateData in the class structure to implement this, but 
              the former seemed like overkill, and the latter seemed too dangerous.
              
              - Fixed a bug where JSPropertyEnumeratorGetNext would skip the first property.
      
              Cosmetic Changes:
              - Reversed the logic of the JSChar #ifdef to avoid confusing headerdoc
              
              - Removed function names from @function declarations because headeroc
              can parse them automatically, and I wanted to rule out manual mismatch.
      
              - Changed Error::create to take a const UString& instead of a UString*
              because it was looking at me funny.
              
              - Renamed JSStringBufferCreateWithCFString to JSStringBufferCreateCF
              because the latter is more concise and it matches JSStringBufferCreateUTF8.
              
              * API/JSCallbackObject.cpp:
              (KJS::JSCallbackObject::getOwnPropertySlot):
              (KJS::JSCallbackObject::put):
              (KJS::JSCallbackObject::deleteProperty):
              (KJS::JSCallbackObject::getPropertyList):
              (KJS::JSCallbackObject::toBoolean):
              (KJS::JSCallbackObject::toNumber):
              (KJS::JSCallbackObject::toString):
              * API/JSClassRef.cpp:
              (JSClassCreate):
              * API/JSContextRef.cpp:
              (JSContextCreate):
              (JSContextSetException):
              * API/JSContextRef.h:
              * API/JSNode.c:
              (JSNodePrototype_class):
              (JSNode_class):
              * API/JSNodeList.c:
              (JSNodeListPrototype_class):
              (JSNodeList_class):
              * API/JSObjectRef.cpp:
              (JSObjectGetProperty):
              (JSObjectGetPrivate):
              (JSObjectSetPrivate):
              (JSObjectCallAsFunction):
              (JSObjectCallAsConstructor):
              (JSPropertyEnumeratorGetNext):
              * API/JSObjectRef.h:
              * API/JSStringBufferRef.cpp:
              (JSStringBufferCreateCF):
              * API/JSStringBufferRef.h:
              * API/JSValueRef.cpp:
              (JSValueIsInstanceOf):
              * API/JSValueRef.h:
              * API/minidom.c:
              (main):
              * API/minidom.js:
              * API/testapi.c:
              (MyObject_hasProperty):
              (MyObject_setProperty):
              (MyObject_deleteProperty):
              (MyObject_getPropertyList):
              (MyObject_convertToType):
              (MyObject_class):
              (main):
              * JavaScriptCore.exp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      554ad6fb
    • lweintraub's avatar
      Reviewed by NOBODY · bec59b8c
      lweintraub authored
              Missed a few in the last update...
      
              * fast/forms/input-delete-expected.txt:
              * fast/repaint/inline-outline-repaint-expected.txt:
              * fast/repaint/selection-after-delete-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bec59b8c
    • lweintraub's avatar
      LayoutTests: · 1bb7d0bf
      lweintraub authored
              Reviewed by justin
      
              Deletion editing deligates now show up!
      
              * editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
              * editing/deleting/delete-3608430-fix-expected.txt:
              * editing/deleting/delete-3608445-fix-expected.txt:
              * editing/deleting/delete-3608462-fix-expected.txt:
              * editing/deleting/delete-3775172-fix-expected.txt:
              * editing/deleting/delete-3800834-fix-expected.txt:
              * editing/deleting/delete-3857753-fix-expected.txt:
              * editing/deleting/delete-3865854-fix-expected.txt:
              * editing/deleting/delete-3928305-fix-expected.txt:
              * editing/deleting/delete-3959464-fix-expected.txt:
              * editing/deleting/delete-4038408-fix-expected.txt:
              * editing/deleting/delete-4083333-fix-expected.txt:
              * editing/deleting/delete-after-span-ws-001-expected.txt:
              * editing/deleting/delete-after-span-ws-002-expected.txt:
              * editing/deleting/delete-after-span-ws-003-expected.txt:
              * editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
              * editing/deleting/delete-and-undo-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
              * editing/deleting/delete-block-contents-001-expected.txt:
              * editing/deleting/delete-block-contents-002-expected.txt:
              * editing/deleting/delete-block-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-001-expected.txt:
              * editing/deleting/delete-block-merge-contents-002-expected.txt:
              * editing/deleting/delete-block-merge-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-004-expected.txt:
              * editing/deleting/delete-block-merge-contents-005-expected.txt:
              * editing/deleting/delete-block-merge-contents-006-expected.txt:
              * editing/deleting/delete-block-merge-contents-007-expected.txt:
              * editing/deleting/delete-block-merge-contents-008-expected.txt:
              * editing/deleting/delete-block-merge-contents-009-expected.txt:
              * editing/deleting/delete-block-merge-contents-010-expected.txt:
              * editing/deleting/delete-block-merge-contents-012-expected.txt:
              * editing/deleting/delete-block-merge-contents-013-expected.txt:
              * editing/deleting/delete-block-merge-contents-014-expected.txt:
              * editing/deleting/delete-block-merge-contents-015-expected.txt:
              * editing/deleting/delete-block-merge-contents-016-expected.txt:
              * editing/deleting/delete-block-merge-contents-017-expected.txt:
              * editing/deleting/delete-block-merge-contents-018-expected.txt:
              * editing/deleting/delete-block-merge-contents-019-expected.txt:
              * editing/deleting/delete-block-merge-contents-020-expected.txt:
              * editing/deleting/delete-block-merge-contents-021-expected.txt:
              * editing/deleting/delete-block-merge-contents-022-expected.txt:
              * editing/deleting/delete-block-merge-contents-023-expected.txt:
              * editing/deleting/delete-block-merge-contents-024-expected.txt:
              * editing/deleting/delete-br-001-expected.txt:
              * editing/deleting/delete-br-002-expected.txt:
              * editing/deleting/delete-br-003-expected.txt:
              * editing/deleting/delete-br-004-expected.txt:
              * editing/deleting/delete-br-005-expected.txt:
              * editing/deleting/delete-br-006-expected.txt:
              * editing/deleting/delete-br-007-expected.txt:
              * editing/deleting/delete-br-008-expected.txt:
              * editing/deleting/delete-br-009-expected.txt:
              * editing/deleting/delete-br-010-expected.txt:
              * editing/deleting/delete-br-011-expected.txt:
              * editing/deleting/delete-character-001-expected.txt:
              * editing/deleting/delete-contiguous-ws-001-expected.txt:
              * editing/deleting/delete-image-001-expected.txt:
              * editing/deleting/delete-image-002-expected.txt:
              * editing/deleting/delete-image-003-expected.txt:
              * editing/deleting/delete-image-004-expected.txt:
              * editing/deleting/delete-leading-ws-001-expected.txt:
              * editing/deleting/delete-line-001-expected.txt:
              * editing/deleting/delete-line-002-expected.txt:
              * editing/deleting/delete-line-003-expected.txt:
              * editing/deleting/delete-line-004-expected.txt:
              * editing/deleting/delete-line-005-expected.txt:
              * editing/deleting/delete-line-006-expected.txt:
              * editing/deleting/delete-line-007-expected.txt:
              * editing/deleting/delete-line-008-expected.txt:
              * editing/deleting/delete-line-009-expected.txt:
              * editing/deleting/delete-line-010-expected.txt:
              * editing/deleting/delete-line-011-expected.txt:
              * editing/deleting/delete-line-012-expected.txt:
              * editing/deleting/delete-line-013-expected.txt:
              * editing/deleting/delete-line-014-expected.txt:
              * editing/deleting/delete-line-015-expected.txt:
              * editing/deleting/delete-line-016-expected.txt:
              * editing/deleting/delete-line-017-expected.txt:
              * editing/deleting/delete-line-end-ws-001-expected.txt:
              * editing/deleting/delete-line-end-ws-002-expected.txt:
              * editing/deleting/delete-listitem-001-expected.txt:
              * editing/deleting/delete-listitem-002-expected.txt:
              * editing/deleting/delete-select-all-001-expected.txt:
              * editing/deleting/delete-select-all-002-expected.txt:
              * editing/deleting/delete-select-all-003-expected.txt:
              * editing/deleting/delete-selection-001-expected.txt:
              * editing/deleting/delete-tab-001-expected.txt:
              * editing/deleting/delete-tab-002-expected.txt:
              * editing/deleting/delete-tab-003-expected.txt:
              * editing/deleting/delete-tab-004-expected.txt:
              * editing/deleting/delete-trailing-ws-001-expected.txt:
              * editing/deleting/delete-trailing-ws-002-expected.txt:
              * editing/deleting/delete-ws-fixup-001-expected.txt:
              * editing/deleting/delete-ws-fixup-002-expected.txt:
              * editing/deleting/delete-ws-fixup-003-expected.txt:
              * editing/deleting/delete-ws-fixup-004-expected.txt:
              * editing/deleting/forward-delete-expected.txt:
              * editing/deleting/merge-different-styles-expected.txt:
              * editing/deleting/merge-endOfParagraph-expected.txt:
              * editing/deleting/merge-into-empty-block-1-expected.txt:
              * editing/deleting/merge-into-empty-block-2-expected.txt:
              * editing/deleting/merge-no-br-expected.txt:
              * editing/deleting/merge-unrendered-space-expected.txt:
              * editing/deleting/pruning-after-merge-1-expected.txt:
              * editing/deleting/pruning-after-merge-2-expected.txt:
              * editing/deleting/smart-delete-001-expected.txt:
              * editing/deleting/smart-delete-002-expected.txt:
              * editing/deleting/table-cells-expected.txt:
              * editing/execCommand/insertHTML-expected.txt:
              * editing/input/text-input-controller-expected.txt:
              * editing/inserting/insert-3775316-fix-expected.txt:
              * editing/inserting/insert-3851164-fix-expected.txt:
              * editing/inserting/insert-after-delete-001-expected.txt:
              * editing/inserting/insert-div-021-expected.txt:
              * editing/inserting/insert-div-026-expected.txt:
              * editing/pasteboard/4076267-2-expected.txt:
              * editing/pasteboard/4076267-3-expected.txt:
              * editing/pasteboard/4076267-expected.txt:
              * editing/pasteboard/paste-table-002-expected.txt:
              * editing/pasteboard/paste-text-015-expected.txt:
              * editing/selection/move-between-blocks-no-001-expected.txt:
              * editing/selection/select-all-iframe-expected.txt:
              * editing/style/block-style-005-expected.txt:
              * editing/style/smoosh-styles-001-expected.txt:
              * editing/style/smoosh-styles-002-expected.txt:
              * editing/style/style-3681552-fix-002-expected.txt:
              * editing/style/typing-style-001-expected.txt:
              * editing/style/typing-style-002-expected.txt:
              * editing/unsupported-content/list-delete-001-expected.txt:
              * editing/unsupported-content/list-delete-002-expected.txt:
              * editing/unsupported-content/list-delete-003-expected.txt:
              * editing/unsupported-content/table-delete-001-expected.txt:
              * editing/unsupported-content/table-delete-002-expected.txt:
              * editing/unsupported-content/table-delete-003-expected.txt:
              * fast/forms/input-text-option-delete-expected.checksum:
              * fast/forms/input-text-option-delete-expected.txt:
      
      WebCore:
      
              Reviewed by justin
      
              Allowed deletion typing commands to take in a granularity
      
              * bridge/mac/WebCoreFrameBridge.h: Pass granularity across the bridge
              * bridge/mac/WebCoreFrameBridge.mm: Ditto
              (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
              (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
              * editing/TypingCommand.cpp: Constructors take in a granularity
              (WebCore::TypingCommand::TypingCommand):
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/TypingCommand.h: ditto
              * page/Frame.h: Fixed bug that shouldDeleteSelection wasn't virtual
      
      WebKit:
      
              Reviewed by justin
      
              Finished moving deletion selection expansion across the bridge... say that 3 times fast.
      
              * WebView/WebHTMLView.m:  Pass granularity to WebCore to handle expansion
              (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
              (-[WebHTMLView _deleteSelection]):
              (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):
              (-[NSArray deleteToMark:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bb7d0bf
    • beidson's avatar
      Reviewed by Anders and Tim Hatcher · f39c2c2e
      beidson authored
              Added an accessor to a SQLite config option to change its disk-syncing behavior.
              Used this accessor to significantly speed up writes to the Icon DB.
      
              * icon/IconDatabase.cpp:
              (WebCore::IconDatabase::open):  Disable full syncing to the SQLite db to speed up writes to the icondb
      
              * icon/SQLDatabase.cpp:
              (SQLDatabase::setFullsync):
              (SQLDatabase::setSynchronous):
              * icon/SQLDatabase.h:
              (WebCore::SQLDatabase::):  Added accessor to the SQLite config pragma "synchronous"
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f39c2c2e
    • darin's avatar
      Reviewed by Maciej. · f6420c4e
      darin authored
              - fixed a storage leak noticed by the buildbot
      
              * dom/Document.cpp: (WebCore::Document::removedLastRef):
              Call delete on the markers before clearing the map containing them.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6420c4e
    • andersca's avatar
      2006-07-08 Anders Carlsson <acarlsson@apple.com> · ee9cb8ce
      andersca authored
              Reviewed by Brady.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9777
              Reproducible crash in Loading/Frames in ToT.
              
              The problem was that the renderpart destructor resets the frame's 
              owner element. For iframes, this should only be done when the element is 
              going to be removed from the document.
              
              * html/HTMLIFrameElement.cpp:
              (WebCore::HTMLIFrameElement::~HTMLIFrameElement):
              (WebCore::HTMLIFrameElement::willRemove):
              (WebCore::HTMLIFrameElement::removedFromDocument):
              (WebCore::HTMLIFrameElement::detach):        
              * html/HTMLIFrameElement.h:
              Remove the frame in willRemove instead.
              
              * rendering/RenderPart.cpp:
              (WebCore::RenderPart::RenderPart):
              (WebCore::RenderPart::~RenderPart):
              * rendering/RenderPart.h:
              Don't call setFrame(0) in the destructor when the element is an iframe element.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15219 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee9cb8ce
    • darin's avatar
      Reviewed by Anders. · ffcfdbfc
      darin authored
              - fixed a storage leak noticed by the buildbot
      
              * page/FrameView.cpp: (WebCore::FrameViewPrivate::~FrameViewPrivate):
              Delete m_scheduledEvents.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffcfdbfc
    • sullivan's avatar
      Added a bug number to an existing entry. · 022d8cc6
      sullivan authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      022d8cc6
    • darin's avatar
      Reviewed by Adele. · 3e71c118
      darin authored
              - fixed a couple of storage leaks noticed by the buildbot
      
              * html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::attach):
              Call deref on the style after calling setRenderStyle, since styleForRenderer
              returns us a "ref'd" RenderStyle object.
              * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::attach): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e71c118
    • darin's avatar
      Reviewed by Adele. · 22a690e4
      darin authored
              - fix some license mistakes
      
              * LICENSE-APPLE: Added more years of publication to the copyright here.
      
              * html/CanvasGradient.idl: Corrected license on this file. It had the wrong one.
              * html/CanvasPattern.idl: Ditto.
              * html/CanvasRenderingContext2D.idl: Ditto.
              * html/HTMLCanvasElement.idl: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22a690e4
    • beidson's avatar
      Reviewed by John · cc1903cb
      beidson authored
              Changed an ASSERT to a LOG_ERROR for an error that could be handled gracefully, but
              whose assertion was reproducibly causing a build bot failure
      
              * Misc/WebIconDatabase.m:
              (-[WebIconDatabase _releaseIconForIconURLString:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc1903cb