1. 16 Jan, 2003 2 commits
    • rjw's avatar
      Fixed 3148932. Account for zero width characters · 77a985bc
      rjw authored
              in <pre> fixed-width optimization.
              Reviewed by hyatt.
              * khtml/rendering/render_text.cpp:
              Reviewed by Richard (written by Mike S.)  'Clean' implementations of these
              functions that were too similar to the Qt implementations.
              * kwq/KWQString.mm:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mjs's avatar
      Reviewed by Darin. · bfdaa330
      mjs authored
      	- fixed 3144771 - Crash in KJS::WindowFunc::tryCall leaving www.smogcheck.org
      	I fixed this by making sure we couldn't send the unload event twice, which was
      	happening before in certain circumstances.
              * khtml/khtml_part.cpp:
              (KHTMLPart::closeURL): When emitting load event, note that unload
      	event has not yet been sent.
              (KHTMLPart::checkEmitLoadEvent): Note when unload event has been
      	sent to avoid sending it twice.
              * khtml/khtmlpart_p.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. 15 Jan, 2003 1 commit
    • trey's avatar
      3144458 - user's credentials are present in a form that is revisited via b/f or history · 2c65ac11
      trey authored
      	We now never save/restore password fields.  Also if the page has a form with a password
      	field that would be submitted securely, we do not save anything on that page.
              Reviewed by Darin.
              * force-clean-timestamp:  PB isn't smart enough to know what to rebuild.
              * khtml/html/html_formimpl.cpp:
              (HTMLFormElementImpl::formWouldHaveSecureSubmission):  Utility function.
              (HTMLFormElementImpl::attach):  Tell doc if we've added a secure form.
              (HTMLFormElementImpl::parseAttribute):  Tell doc if form became secure.
              (HTMLInputElementImpl::state):  Assert that we never save password fields.
              (HTMLInputElementImpl::restoreState):  Assert that we never restore password fields.
              (HTMLInputElementImpl::attach):  Tell doc if we've added a password field.
              * khtml/html/html_formimpl.h:
              * khtml/xml/dom_docimpl.cpp:
              (DocumentImpl::DocumentImpl):  Init count of secure forms, password fields.
              (DocumentImpl::hasPasswordField):  New methods to count password fields.
              (DocumentImpl::hasSecureForm):  New methods to count secure forms.
              * khtml/xml/dom_docimpl.h:
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::canCachePage):   Never let pages with password fields in the page cache.
              (KWQKHTMLPart::saveDocumentState):  Do not save form state if page has a form with
      	a password field that would be submitted securely
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. 14 Jan, 2003 4 commits
    • darin's avatar
      Reviewed by Maciej. · 5c611c4d
      darin authored
      	- fixed 3147036 -- words separated only by newlines are getting rammed together on XML page
      	- fixed 3147032 -- preformatted text is missing much whitespace on XML page
              * khtml/xml/xml_tokenizer.cpp: (XMLHandler::characters): Don't try to strip whitespace at all,
      	because it needs to be in the DOM.
      	- add support for more MIME types
              * khtml/khtml_part.cpp: (KHTMLPart::begin): Add "application/xml" and "application/xhtml+xml".
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Make FOUC work with XML. · bcb09ec8
      hyatt authored
              Reviewed by darin.
              * khtml/html/html_baseimpl.cpp:
              * khtml/xml/dom_xmlimpl.cpp:
              * khtml/xml/dom_xmlimpl.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Maciej. · 0bb44c36
      darin authored
      	- first cut at XML parsing with expat
              * khtml/khtml_part.cpp: (KHTMLPart::begin): Remove APPLE_CHANGES and use the XML
      	code for text/xml documents.
              * WebCore.pbproj/project.pbxproj: Added the ForwardingHeaders to the project.
      	Added new QXml files, removed old ones.
              * kwq/KWQXml.h: Removed.
              * kwq/KWQXml.mm: Removed.
              * kwq/KWQXmlAttributes.h: Added.
              * kwq/KWQXmlAttributes.mm: Added.
              * kwq/KWQXmlDefaultHandler.h: Added.
              * kwq/KWQXmlDefaultHandler.mm: Added.
              * kwq/KWQXmlSimpleReader.h: Added.
              * kwq/KWQXmlSimpleReader.mm: Added.
              * kwq/KWQString.h: Add fromUtf8 functions.
              * kwq/KWQString.mm: (QString::fromUtf8): Added. Simple implementation just
      	calls fromStringWithEncoding. We may need something more efficient later,
      	at least for all-ASCII text.
      	- other changes
              * khtml/khtml_part.h: Fix spelling of occurrence.
              * khtml/misc/decoder.cpp: (Decoder::decode): Turn on Japanese auto-detect.
      	It doesn't seem to work yet, but this does no harm.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      Fix for 3139120. This patch was contributed by Mitz Pettel. It correctly · 2028aa44
      rjw authored
              handles the visually ordered encodings.  The patch also picks up changes
              from kde that accounts for european numbers correctly in bidiReorderLine().
              Reviewed by Dave.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  4. 12 Jan, 2003 3 commits
    • darin's avatar
      Reviewed by Dave. · d8d3bd9d
      darin authored
      	- minor cleanup of plug-in-related classes in ECMA directory
              * khtml/ecma/kjs_navigator.cpp: Remove unneeded PluginBase member functions
      	ref() and deref(). Instead just make Plugin and MimeType both derive from
      	PluginBase and remove APPLE_CHANGES.
              (Navigator::getValueProperty): Don't use "Konqueror" for the fallback.
      	Just return Undefined() for that case since we will never reach it anyway.
      	- simplify the logic in khtmlMoveMouseEvent so it's easier to decipher
              * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): By merging two
      	identical if statements, the logic of this function becomes much clearer.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Dave. · 50560aa1
      darin authored
      	- fixed a bunch of places where KHTML did !x == y instead of !(x == y) or x != y.
              * khtml/css/cssstyleselector.cpp: (CSSStyleSelector::applyRule):
              * khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
              * khtml/misc/loader.cpp: (Cache::requestImage), (Cache::requestStyleSheet):
              * khtml/rendering/render_flow.cpp: (RenderFlow::setStyle):
      	Changed !x == y to x != y. In each case, there's a reason that this does not create
      	any problem in practice, which is why we didn't rush to get this in for beta 1.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by John. · 895eae19
      darin authored
      	- fixed 3144789 -- reproducible crash in KHTMLParser::freeBlock on a page at www.library.arizona.edu
              * khtml/html/htmlparser.cpp: (KHTMLParser::finished): Call freeBlock here rather than
      	waiting until the parser is destroyed. This fixes the bug because when the parser is
              destroyed, the document is already destroyed, so we have a dangling current pointer to an
      	already-destroyed node.
      	- fixed 3142024 -- crash/hang/assert on java.sun.com in HTMLTokenizer
      	The bug was caused by an erroneous clicked signal that was being emitted by
      	QListBox at just the wrong time.
              * kwq/KWQListBox.h: Added _changingSelection boolean.
              * kwq/KWQListBox.mm: (QListBox::QListBox): Set _changingSelection to false.
              (QListBox::setSelected): Set _changingSelection to true.
              (-[KWQListBoxTableViewDelegate tableViewSelectionDidChange:]): Only emit the "clicked"
      	signal if _changingSelection is false.
              * khtml/html/htmltokenizer.h: Add debug-only boolean inWrite.
              * khtml/html/htmltokenizer.cpp: (HTMLTokenizer::HTMLTokenizer): Set inWrite to false.
      	(HTMLTokenizer::write): Set inWrite to true.
      	(HTMLTokenizer::~HTMLTokenizer): Assert that inWrite is not true.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  5. 09 Jan, 2003 4 commits
  6. 08 Jan, 2003 2 commits
    • trey's avatar
      3136213 - Page loads stopped by backtracking don't finish when moving forward · 8807f2f1
      trey authored
      	We need to remove the entry from the KHTML image cache when a load
      	has an error, so it will be reloaded next time we try.
              Reviewed by Darin,
              * khtml/misc/loader.cpp:
              (Loader::slotFinished):  Remove cache entry on job error.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Dave. · e94e43ff
      darin authored
      	- fixed 96/72 dpi snafu; no need to do something different for AppKit,
                because it always uses pixel sizes, not font size
              * khtml/css/css_valueimpl.cpp:
              * khtml/css/css_valueimpl.h:
              * khtml/css/cssstyleselector.cpp:
              * kwq/KWQPaintDeviceMetrics.mm:
      	Rolled out change from 2002-12-05
      	- a cut at implementing heretofore unimplemented QTextStream classes
              * kwq/KWQTextStream.h:
              * kwq/KWQTextStream.mm:
      	First cut implementation.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  7. 04 Jan, 2003 2 commits
  8. 03 Jan, 2003 4 commits
    • rjw's avatar
      Fix for 3138425. Don't open a new window when document.open() is called · 5f65a093
      rjw authored
              with < 2 parameters.
              Reviewed by darin.
              * khtml/ecma/kjs_html.cpp:
              * khtml/ecma/kjs_window.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      WebCore: · b026936c
      rjw authored
              Fixed 3138743, 3138678, and 3138854.  Removed the RenderText
              widths cache, replaced it with a much simply monospace character
              cache.  Should be much faster for covered cases too!  Also fixed
              buffer overrun problem causing the crash in 3138854.
              Reviewed by darin.
              * khtml/rendering/font.cpp:
              * khtml/rendering/font.h:
              * khtml/rendering/render_text.cpp:
              * khtml/rendering/render_text.h:
              * kwq/KWQFont.h:
              * kwq/KWQFont.mm:
              * kwq/WebCoreTextRendererFactory.h:
              * kwq/WebCoreTextRendererFactory.m:
              (-[WebCoreTextRendererFactory isFontFixedPitch:]):
              Support for fixes to 3138743, 3138678.  Added
              isFontFixedPitch used to determine if font is fixed
              pitch.  Makes use of appkit private _isFakeFixedPitch
              (detects courier and monoca).  Updated our fakey test
              to use the appkit's version.
              Reviewed by darin.
              * WebCoreSupport.subproj/WebTextRenderer.m:
              * WebCoreSupport.subproj/WebTextRendererFactory.m:
              (-[WebTextRendererFactory isFontFixedPitch:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sullivan's avatar
      - fixed 3138673 -- reproducible crash in JavaScript · 70d94889
      sullivan authored
              Reviewed by Darin, OK'ed by Don.
              * khtml/xml/dom_docimpl.cpp:
      	Check for nil view or nil part before dereferencing.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for percentage table heights. A check was missing to · 7c6e5520
      hyatt authored
      	look for a fixed height on the containing block.
              Reviewed by darin
              * khtml/rendering/render_table.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  9. 02 Jan, 2003 4 commits
    • hyatt's avatar
      Fix for 3136473. <object>s with no specified size should be · b30fb841
      hyatt authored
      	0x0.  They should not be 300x200.  Fixes thinker.org.
              Reviewed by john and darin.
              * khtml/rendering/render_frames.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Maciej and Trey. · ba021ece
      darin authored
      	- fixed 3138063 -- REGRESSION: JavaScript-submitted form activates input type=image (webmail.mac.com)
      	JavaScript-submitted forms must not get a submit button activated as return-key-submitted ones do.
              * khtml/html/html_formimpl.h: Add boolean activateSubmitButton parameter to submit.
              * khtml/html/html_formimpl.cpp:
              (HTMLFormElementImpl::prepareSubmit): Pass true for activateSubmitButton.
              (HTMLFormElementImpl::submit): Only activate a button if activateSubmitButton is true.
              * khtml/dom/html_form.cpp: (HTMLFormElement::submit): Pass false for activateSubmitButton.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for the 3137790. This patch passes the mouse event x and y as · 559ff05c
      hyatt authored
      	distinct arguments to constructZTree, so that the damageRect can
      	really reflect your clip rect.
      	This allows me to prune out layers that are clipped so
      	that if x,y aren't inside the clip rect, the layer doesn't get added to
      	the list.
      	This patch also makes the "clip" property apply to the element that specifies the clip instead of to the element's kids.  This is ambiguous in the spec, but it turns out other browsers do it this way, so there really is an interpretation that must be followed. :)
      	Reviewed by darin
              * khtml/rendering/render_layer.cpp:
              * khtml/rendering/render_layer.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for bug #3137935. When a float causes a line to get · a14d1741
      hyatt authored
      	moved down past the float, the line would incorrectly break
      	rather than expanding to use the newly-available width.
              Reviewed by darin.
              * khtml/rendering/bidi.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  10. 01 Jan, 2003 1 commit
  11. 31 Dec, 2002 1 commit
    • darin's avatar
      Reviewed by Trey. · c67613fa
      darin authored
      	- fixed 3132141 -- enter key does not work with input type=image
      	Made the logic handle image and submit type inputs in the same way.
              * khtml/html/html_formimpl.h: Remove unused m_clicked flags.
              * khtml/html/html_formimpl.cpp:
              (HTMLButtonElementImpl::HTMLButtonElementImpl): Remove code to set the m_clicked flag.
      	The only place this flag was looked at is better handled by the m_activeSubmit flag.
              (HTMLButtonElementImpl::defaultEventHandler): Remove more m_clicked flag code.
              (HTMLInputElementImpl::HTMLInputElementImpl): Remove more m_clicked flag code.
              (HTMLInputElementImpl::isSuccessfulSubmitButton): An image is also a successful submit
      	button, and unlike a submit element, it doesn't require a name because it will just submit
              x and y with no name in that case. I suppose we could rename this function, but I think it's
              still a pretty clear name even if not 100% accurate.
              (HTMLInputElementImpl::encoding): Remove use of m_clicked and use m_activeSubmit instead.
      	This was the only place using m_clicked at all. Also remove bogus check for a -1 coordinate.
      	The coordinate defaults to 0, not -1, and it was never happening.
              (HTMLInputElementImpl::defaultEventHandler): Remove more m_clicked flag code.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  12. 30 Dec, 2002 4 commits
    • hyatt's avatar
      Fix for 3129016, make sure that zero-height tables and lists · 5873ea08
      hyatt authored
      	will be skipped in a search for floats that occur before
      	them.  Makes usatoday work.
              Reviewed by gramps
              * khtml/rendering/render_flow.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Maciej. · 58521793
      darin authored
      	- fixed 3135642 -- ad frames are missing at channels.netscape.com
              * khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): Updated to use the
      	same rule as Mozilla: Empty URL for an iframe means "about:blank".
              * khtml/ecma/kjs_window.cpp: (Window::isSafeScript): Loosen things so that it's safe for
      	a frame to manipulate an empty child frame, as well as an empty opened window. Also remove
      	the useless check for an empty document -- it never happens in practice.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      WebCore: · 477551a4
      darin authored
              Reviewed by Don.
      	- fixed 3103287 -- body of page not rendered (page uses JavaScript trick to be both a frameset and a frame)
      	Our self-reference protection prevented this page from working.
      	To fix the bug, I did three things:
         	    1) fixed the hole in the WebCore self-reference protection, so we could remove the WebKit one
                     (the hole was that it didn't ignore #xxx suffixes)
       	    2) moved the self-reference protection into a single function so it wasn't copied and pasted all over
      	    3) allowed one level of self-reference; still enough to prevent infinite recursion
      	Then I tested with the site from bug 3103287 and the one from bug 3083732 to make sure that was still OK.
              * khtml/html/html_baseimpl.h: Added isURLAllowed().
              * khtml/html/html_baseimpl.cpp:
              (HTMLFrameElementImpl::isURLAllowed): Added. Does the self-reference check and the "local only" check.
      	This logic was repeated in three different places before. Note that since we don't use the "local only"
              feature, it's not too risky to slightly change how it works.
              (HTMLFrameElementImpl::updateForNewURL): Use isURLAllowed.
              (HTMLFrameElementImpl::attach): Ditto.
              (HTMLIFrameElementImpl::attach): Ditto.
              Reviewed by Don.
      	- fixed 3103287 -- body of page not rendered (page uses JavaScript trick to be both a frameset and a frame)
      	Our self-reference checks prevented this page from working.
      	I just removed the WebKit one, since it was really just working around a problem with the WebCore
      	one that I fixed (didn't ignore #xxx suffixes).
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
      	Remove self-reference check.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Don. · c5764f8d
      darin authored
      	- fixed 3130566 -- REGRESSION: list item numbers are overlapping the text of the list items
      	Moved the hack that handles list items that are not in lists out of the parser and into
      	the DOM and Render tree code itself. This fixes the issue where the parser doesn't know which
      	will be the parent node of the list item, and other problems with the old hack.
              * khtml/html/html_listimpl.cpp: (HTMLLIElementImpl::attach): Find the parent list (OL or UL).
      	If there is no parent list, set a "not in list" flag on the render object so it knows to render
      	"inside" no matter what the style says. Also use this parent and a safer check to make the
      	start attribute work even when there is an intervening DOM element in the hierarchy.
              * khtml/html/htmlparser.cpp: (KHTMLParser::getElement): Remove the code that tries to set
      	the style of an LI based on the current node at the time it's parsed, because the current node
      	is now often not the OL or the UL due to our DTD fix to allow other nodes in lists.
              * khtml/rendering/render_list.h: Add isInside() to RenderListMarker, setNotInList(), notInList(),
      	and _notInList to RenderListItem.
              * khtml/rendering/render_list.cpp:
              (RenderListItem::RenderListItem): Initialize _notInList to false.
              (RenderListMarker::paintObject): Use isInside() instead of checking listStylePosition().
              (RenderListMarker::calcMinMaxWidth): Ditto.
              (RenderListMarker::baselinePosition): Ditto.
              (RenderListMarker::isInside): Return true if we are not in a list, or if "inside" style is requested.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  13. 29 Dec, 2002 2 commits
    • darin's avatar
      Reviewed by Maciej. · 45f34810
      darin authored
      	- fixed 3136391 -- PianoNanny.com screens turn to garbage when resized
      	Turns out browsers pass open calls to the window object if they show up at the document
      	with parameters. We now emulate that too.
              * khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::tryCall): If we get an open call with
      	parameters, pass it on to the window.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Ken. · 65e464a5
      darin authored
      	- fixed 3134560 -- Lord of the Rings desktops don't load
              * khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Removed the APPLE_CHANGES here.
      	The comment claims that we don't need the code because "JavaScript will do the work
      	below on demand", but that's not true for setting the base URL. Also, the comment
      	claims that this "adds an extra entry to the back/forward list", but testing does not
      	bear that out.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  14. 28 Dec, 2002 2 commits
    • kocienda's avatar
      WebCore: · 11bb1581
      kocienda authored
              Reviewed by Gramps and Richard.
      	Fix for this bug:
      	Radar 3112233 (400 response when attaching files at mail.yahoo.com)
      	KHTML multipart form code called into KMimeType class to determine
      	the mime type for file attachments, however, our implementation of
      	KMimeType has only stubs which call ERROR.
      	I added some code into KWQKHTMLPart and WebCoreBridge so that the
      	code in html_formimpl can call through to the WebFoundation mime
      	file map we maintain.
              * khtml/html/html_formimpl.cpp:
              * kwq/KWQKHTMLPart.h:
              * kwq/KWQKHTMLPart.mm:
              * kwq/WebCoreBridge.h:
               Reviewed by Gramps and Richard
               Fix for this bug:
               Radar 3112233 (400 response when attaching files at mail.yahoo.com)
               I added the MIMETypeForPath method which accesses the WebFoundation mime
               file map we maintain. KHTML can now access this map by using the bridge.
               * WebCoreSupport.subproj/WebBridge.m:
               (-[WebBridge MIMETypeForPath:])
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Don. · ee114f40
      darin authored
      	- fixed 3136262 -- Shockwave Flash at movies.yahoo.com does not work
              * khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
      	Moved the class ID special case MIME types out of the if statement so they can be shared
      	in the case where we have an embed tag but no MIME type.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  15. 25 Dec, 2002 1 commit
    • rjw's avatar
      Fix for 3134543 (and widely reported dupes). Don't use render_text · 8f03ce2d
      rjw authored
              widths cache except for whitespace == PRE.  The problem was that additional
              spaces in the RenderText's string were being inappropiately measured.
              An alternate, more complex and risky, fix would account for the whitespace
              properties during scanning of the RenderText width buffer.  Considering
              the scenario for which this optimization was added (3133261), this
              simpler fix is adequate.
              Reviewed by Darin and Don.
              * khtml/rendering/render_text.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  16. 24 Dec, 2002 2 commits
    • darin's avatar
      Reviewed by Don. · 523f0cbf
      darin authored
      	- fixed 3135010 -- nil-dereference in KHTMLPart::xmlDocImpl() at channels.netscape.com
              * khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::contentDocument):
              Add missing nil check. Also added lots of FIXME comments about problems I observed here.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Richard and Don. · a02ae6d8
      darin authored
      	- fixed 3133207 -- crash in HTMLFrameElementImpl updateForNewURL at home.real.com
      	My previous attempt to fix this dealt with the case where a RenderFrame object was
      	not yet created, but not with the case where a RenderFrame object was created without
      	a corresponding part. Somehow I overlooked this last time when I was doing testing.
      	Testing this time confirms this takes care of the remaining problem at movies.real.com.
              * khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL):
      	Use the same kind of requestFrame call here as in attach when there's a RenderFrame,
      	but no corresponding part. Maybe we can fix this an even more elegant way later.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  17. 20 Dec, 2002 1 commit
    • darin's avatar
      Reviewed by Trey and Don. · 5de7095d
      darin authored
      	- fixed 3132160 -- meta refresh does not work if there's a space after the refresh interval value
              * khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv):
      	Added a call to stripWhiteSpace here. The other places that processes delays for
      	meta refresh already had the stripWhiteSpace call, but this was missing it.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3168 268f45cc-cd09-0410-ab3c-d52691b4dbfc