- 09 Jun, 2006 6 commits
-
-
hyatt authored
Rework selection coloring. Rename displaysWithFocusAttributes to isActive. Move the white-blending code onto the Color API to make it more convenient to mutate colors for selection blending. Eliminate all the selection state from the GraphicsContext and move it to the RenderTheme. Implement both Win32 and Mac theme selection colors. Reviewed by sfalken * bridge/mac/FrameMac.h: * bridge/mac/FrameMac.mm: (WebCore::FrameMac::setIsActive): * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]): (-[WebCoreFrameBridge setIsActive:]): (-[WebCoreFrameBridge selectionColor]): * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): * page/Frame.cpp: (WebCore::Frame::isActive): (WebCore::Frame::setIsActive): * page/Frame.h: * platform/Color.cpp: (WebCore::blend): (WebCore::Color::blendWithWhite): * platform/Color.h: (WebCore::Color::hasAlpha): * platform/GraphicsContext.cpp: (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): * platform/GraphicsContext.h: * platform/mac/GraphicsContextMac.mm: * platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::endTransparencyLayer): * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSelection): * rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillHorizontalSelectionGap): (WebCore::RenderBlock::fillVerticalSelectionGap): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap): * rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paint): * rendering/RenderImage.cpp: (WebCore::RenderImage::paint): * rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): * rendering/RenderListMarker.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::selectionColor): * rendering/RenderObject.h: * rendering/RenderReplaced.cpp: * rendering/RenderReplaced.h: * rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeSelectionColor): (WebCore::RenderTheme::inactiveSelectionColor): (WebCore::RenderTheme::platformActiveSelectionColor): (WebCore::RenderTheme::platformInactiveSelectionColor): * rendering/RenderTheme.h: * rendering/RenderThemeMac.h: * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::platformActiveSelectionColor): (WebCore::RenderThemeMac::platformInactiveSelectionColor): * rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::platformActiveSelectionColor): (WebCore::RenderThemeWin::platformInactiveSelectionColor): * rendering/RenderThemeWin.h: * rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): WebKit: Rename displaysWithFocusAttributes to isActive. Reviewed by sfalken * WebKit.xcodeproj/project.pbxproj: * WebView/WebHTMLView.m: (-[WebHTMLView _updateFocusState]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14784 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
justing authored
Reviewed by levi <rdar://problem/4549980> REGRESSION: "Find Again" can get stuck when searching for string with a trailing space * editing/execCommand/findString-expected.checksum: Added. * editing/execCommand/findString-expected.png: Added. * editing/execCommand/findString-expected.txt: Added. * editing/execCommand/findString.html: Added. WebCore: Reviewed by levi <rdar://problem/4549980> REGRESSION: "Find Again" can get stuck when searching for string with a trailing space * bridge/mac/FrameMac.h: Moved findString to Frame. * bridge/mac/FrameMac.mm: Ditto. * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge searchFor:direction:caseSensitive:wrap:]): Convert the NSString to a String. * editing/JSEditor.cpp: Added execCommand(FindString, ...) * editing/Selection.cpp: Added a constructor for Ranges (WebCore::Selection::Selection): * editing/Selection.h: * page/Frame.cpp: (WebCore::Frame::findString): Moved from FrameMac. Compare a selection created using the found range with the current selection in case the current selection is the found range minus some collapsed whitespace on the edges. * page/Frame.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14782 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ggaren authored
http://bugzilla.opendarwin.org/show_bug.cgi?id=9350 Use pathcmp() when sorting paths in svn-create-patch * Scripts/run-webkit-tests: Fixed splitpath() to use File::Basename subroutines instead of regex. * Scripts/svn-create-patch: Copied numericcmp(), pathcmp() and splitpath() from run-webkit-tests. Changed sort() functions to use pathcmp(). Added subroutine prototypes. Added -h command-line switch and printUsage() subroutine. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14781 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sfalken authored
Fix build break * WebCore.vcproj/WebCore/WebCore.vcproj: * css/MediaQueryEvaluator.cpp: * platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::addRoundedRectClip): (GraphicsContext::addInnerRoundedRectClip): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14780 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
bdakin authored
Landed by Beth. CSS3 Media Queries implementation. <http://bugzilla.opendarwin.org/show_bug.cgi?id=4127> * WebCore.xcodeproj/project.pbxproj: * bindings/js/kjs_css.cpp: (KJS::DOMMediaList::put): (KJS::KJS::DOMMediaListProtoFunc::callAsFunction): * bindings/objc/DOMCSS.mm: (-[DOMMediaList setMediaText:]): (-[DOMMediaList deleteMedium:]): (-[DOMMediaList appendMedium:]): * css/CSSGrammar.y: * css/MediaFeatureNames.cpp: Added. (WebCore::MediaFeatureNames::init): * css/MediaFeatureNames.h: Added. * css/MediaList.cpp: (WebCore::MediaList::MediaList): (WebCore::MediaList::~MediaList): (WebCore::parseMediaDescriptor): (WebCore::MediaList::deleteMedium): (WebCore::MediaList::mediaText): (WebCore::MediaList::setMediaText): (WebCore::MediaList::item): (WebCore::MediaList::appendMedium): (WebCore::MediaList::appendMediaQuery): * css/MediaList.h: (WebCore::MediaList::MediaList): (WebCore::MediaList::length): (WebCore::MediaList::mediaQueries): * css/MediaQuery.cpp: Added. (WebCore::MediaQuery::MediaQuery): (WebCore::MediaQuery::~MediaQuery): (WebCore::MediaQuery::operator==): (WebCore::MediaQuery::cssText): * css/MediaQuery.h: Added. (WebCore::MediaQuery::): (WebCore::MediaQuery::restrictor): (WebCore::MediaQuery::expressions): (WebCore::MediaQuery::mediaType): (WebCore::MediaQuery::append): * css/MediaQueryEvaluator.cpp: Added. (WebCore::): (WebCore::MediaQueryEvaluator): (WebCore::MediaQueryEvaluator::~MediaQueryEvaluator): (WebCore::MediaQueryEvaluator::mediaTypeMatch): (WebCore::applyRestrictor): (WebCore::MediaQueryEvaluator::eval): (WebCore::parseAspectRatio): (WebCore::cmpvalue): (WebCore::numberValue): (WebCore::colorMediaFeatureEval): (WebCore::monochromeMediaFeatureEval): (WebCore::device_aspect_ratioMediaFeatureEval): (WebCore::gridMediaFeatureEval): (WebCore::device_heightMediaFeatureEval): (WebCore::device_widthMediaFeatureEval): (WebCore::heightMediaFeatureEval): (WebCore::widthMediaFeatureEval): (WebCore::min_colorMediaFeatureEval): (WebCore::max_colorMediaFeatureEval): (WebCore::min_monochromeMediaFeatureEval): (WebCore::max_monochromeMediaFeatureEval): (WebCore::min_device_aspect_ratioMediaFeatureEval): (WebCore::max_device_aspect_ratioMediaFeatureEval): (WebCore::min_heightMediaFeatureEval): (WebCore::max_heightMediaFeatureEval): (WebCore::min_widthMediaFeatureEval): (WebCore::max_widthMediaFeatureEval): (WebCore::min_device_heightMediaFeatureEval): (WebCore::max_device_heightMediaFeatureEval): (WebCore::min_device_widthMediaFeatureEval): (WebCore::max_device_widthMediaFeatureEval): (WebCore::createFunctionMap): * css/MediaQueryEvaluator.h: Added. * css/MediaQueryExp.cpp: Added. (WebCore::MediaQueryExp::MediaQueryExp): (WebCore::MediaQueryExp::~MediaQueryExp): * css/MediaQueryExp.h: Added. (WebCore::MediaQueryExp::mediaFeature): (WebCore::MediaQueryExp::value): (WebCore::MediaQueryExp::operator==): * css/StyleSheet.cpp: (WebCore::StyleSheet::setMedia): * css/cssparser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::setupParser): (WebCore::CSSParser::parseMediaQuery): (WebCore::CSSParser::createFloatingMediaQueryExp): (WebCore::CSSParser::sinkFloatingMediaQueryExp): (WebCore::CSSParser::createFloatingMediaQueryExpList): (WebCore::CSSParser::sinkFloatingMediaQueryExpList): (WebCore::CSSParser::createFloatingMediaQuery): (WebCore::CSSParser::sinkFloatingMediaQuery): * css/cssparser.h: * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::~CSSStyleSelector): (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::matchUARules): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::updateFont): (WebCore::CSSStyleSelector::cacheBorderAndBackground): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSRuleSet::addRulesFromSheet): * css/cssstyleselector.h: * css/maketokenizer: * css/tokenizer.flex: * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createCSSStyleSheet): * html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::setStyleSheet): * html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::childrenChanged): * ksvg2/svg/SVGDOMImplementation.cpp: (SVGDOMImplementation::createCSSStyleSheet): * ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::childrenChanged): * page/Frame.cpp: (WebCore::Frame::Frame): * platform/Screen.h: * platform/mac/ScreenMac.mm: (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14779 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
justing authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 08 Jun, 2006 9 commits
-
-
justing authored
Reviewed by levi <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468> Implement execCommand(Insert{Un}OrderedList) Added: * editing/execCommand/create-list-from-range-selection-expected.checksum: Added. * editing/execCommand/create-list-from-range-selection-expected.png: Added. * editing/execCommand/create-list-from-range-selection-expected.txt: Added. * editing/execCommand/create-list-from-range-selection.html: Added. * editing/execCommand/insert-list-and-stitch-expected.checksum: Added. * editing/execCommand/insert-list-and-stitch-expected.png: Added. * editing/execCommand/insert-list-and-stitch-expected.txt: Added. * editing/execCommand/insert-list-and-stitch.html: Added. * editing/execCommand/insert-list-with-id-expected.checksum: Added. * editing/execCommand/insert-list-with-id-expected.png: Added. * editing/execCommand/insert-list-with-id-expected.txt: Added. * editing/execCommand/insert-list-with-id.html: Added. * editing/execCommand/remove-list-from-range-selection-expected.checksum: Added. * editing/execCommand/remove-list-from-range-selection-expected.png: Added. * editing/execCommand/remove-list-from-range-selection-expected.txt: Added. * editing/execCommand/remove-list-from-range-selection.html: Added. * editing/execCommand/remove-list-items-expected.checksum: Added. * editing/execCommand/remove-list-items-expected.png: Added. * editing/execCommand/remove-list-items-expected.txt: Added. * editing/execCommand/remove-list-items.html: Added. * editing/execCommand/switch-list-type-expected.checksum: Added. * editing/execCommand/switch-list-type-expected.png: Added. * editing/execCommand/switch-list-type-expected.txt: Added. * editing/execCommand/switch-list-type.html: Added. Fixes: * editing/pasteboard/drag-drop-modifies-page-expected.txt: * editing/pasteboard/paste-list-001-expected.txt: * editing/selection/drag-to-contenteditable-iframe-expected.checksum: * editing/selection/drag-to-contenteditable-iframe-expected.png: * editing/selection/drag-to-contenteditable-iframe-expected.txt: * editing/style/block-style-005-expected.txt: * fast/text/textIteratorNilRenderer-expected.checksum: * fast/text/textIteratorNilRenderer-expected.png: * fast/text/textIteratorNilRenderer-expected.txt: * editing/deleting/delete-line-016-expected.checksum: * editing/deleting/delete-line-016-expected.png: * editing/deleting/delete-line-016-expected.txt: WebCore: Reviewed by levi <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468> Implement execCommand(Insert{Un}OrderedList) * WebCore.xcodeproj/project.pbxproj: Added InsertListCommand.{h,cpp} to the project. * dom/Position.cpp: (WebCore::hasRenderedNonAnonymousDescendantsWithHeight): Added. A block with height is only a candidate if this is false. This should fix the problems getting carets into empty blocks. (WebCore::Position::inRenderedContent): * editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::doApply): * editing/CompositeEditCommand.cpp: (WebCore::hasARenderedDescendant): (WebCore::CompositeEditCommand::prune): A node can have DOM descendants that are rendered, yet have no rendered descendants. Fixed the pruning rule to avoid removing a node like this. (WebCore::CompositeEditCommand::mergeIdenticalElements): Put the two elements next to each other if they aren't already, as a convenience. (WebCore::CompositeEditCommand::moveParagraph): Added code to preserve the current selection. (WebCore::CompositeEditCommand::moveParagraphs): Ditto. * editing/CompositeEditCommand.h: * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): Expansion for special elements should continue to happen until it is no longer possible. (WebCore::DeleteSelectionCommand::handleGeneralDelete): The code to adjust the start node wouldn't always avoid removing the start block. * editing/InsertListCommand.cpp: Added. (WebCore::InsertListCommand::fixOrphanedListChild): Puts a list item that isn't inside a list into a list. (WebCore::InsertListCommand::InsertListCommand): (WebCore::InsertListCommand::modifyRange): (WebCore::InsertListCommand::doApply): * editing/InsertListCommand.h: Added. (WebCore::InsertListCommand::): * editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply): * editing/InsertParagraphSeparatorCommand.cpp: * editing/JSEditor.cpp: * editing/TextIterator.cpp: (WebCore::TextIterator::advance): Don't handle a node if the end of the range used to create the iterator ends at the start of that node. used to create the iterator. * editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous): * editing/VisiblePosition.h: Added a parameter to next/previous to prevent them from going outside the current editable region. * editing/htmlediting.cpp: (WebCore::highestAncestor): (WebCore::enclosingList): (WebCore::enclosingListChild): (WebCore::outermostEnclosingList): (WebCore::createListItemElement): * editing/htmlediting.h: * page/Frame.cpp: (WebCore::Frame::selectionListState): Added. * page/Frame.h: WebKit: Reviewed by levi <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468> Implement execCommand(Insert{Un}OrderedList) * WebView/WebFrame.m: (-[WebFrame _findFrameWithSelection]): Removed an assertion that we only have one frame with a selection. * WebView/WebView.m: (-[WebView selectedFrame]): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14777 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
thatcher authored
Include our own copies of the BSD and LGPL licenses. * coding/bsd-license.html: Added. * coding/lgpl-license.html: Added. * nav.inc: link to our copies of the licenses git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14776 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
harrison authored
Reviewed by Geoff and John. <rdar://problem/4558879> -[DOMCSSPrimitiveValue setStringValue:] throws an exception (12) * fast/dom/setPrimitiveValue-expected.checksum: Added. * fast/dom/setPrimitiveValue-expected.png: Added. * fast/dom/setPrimitiveValue-expected.txt: Added. * fast/dom/setPrimitiveValue.html: Added. WebCore: Reviewed by Geoff and John. <rdar://problem/4558879> -[DOMCSSPrimitiveValue setStringValue:] throws an exception (12) Problem was the primitive value was getting reset to a generic state before the parameter check that relies on that state. Test: fast/dom/setPrimitiveValue.html * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::setFloatValue): (WebCore::CSSPrimitiveValue::setStringValue): Move parameter checks ahead of call to cleanup(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14775 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
aliceli1 authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aliceli1 authored
- fixed <rdar://problem/4578115> support Range.isPointInRange - fixed <rdar://problem/4578123> support Range.comparePoint * dom/Range.cpp: (WebCore::Range::isPointInRange): added implementation (WebCore::Range::comparePoint): added implementation * dom/Range.h: added prototypes * dom/Range.idl: added bindings git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14773 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
thatcher authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
thatcher authored
<rdar://problem/3600734> API: please add a way to turn vertical scrollbar always on (for Mail, to avoid reflow when typing) Adds new methods to lock the scrolling mode on WebDynamicScrollBarsView. Locking the scroll mode prevents WebCore from changing it as needed. Also adds an SPI on WebView that will lock the "always on" mode for each scroller. * WebKit.xcodeproj/project.pbxproj: * WebView/WebDynamicScrollBarsView.h: * WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView setAllowsScrolling:]): (-[WebDynamicScrollBarsView allowsScrolling]): (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): (-[WebDynamicScrollBarsView setScrollingMode:]): (-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]): (-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]): (-[WebDynamicScrollBarsView setScrollingModesLocked:]): (-[WebDynamicScrollBarsView horizontalScrollingModeLocked]): (-[WebDynamicScrollBarsView verticalScrollingModeLocked]): * WebView/WebView.m: (-[WebView setAlwaysShowVerticalScroller:]): (-[WebView alwaysShowVerticalScroller]): (-[WebView setAlwaysShowHorizontalScroller:]): (-[WebView alwaysShowHorizontalScroller]): * WebView/WebViewPrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14771 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
Reviewed by Justin. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8616 REGRESSION: TinyMCE: Crash on Undo * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getInnerNonSharedNode:innerNode:URLElement:atPoint:allowShadowContent:]): Changed to call nodeInfoAtPoint directly. (-[WebCoreFrameBridge _visiblePositionForPoint:]): Changed to call nodeInfoAtPoint directly. Also added code to convert coordinates so it works for points that are in nodes in subframes. * page/Frame.cpp: (WebCore::Frame::setMark): Added assertions to catch if we attempt to set selection endpoints in another document. (WebCore::Frame::setSelection): Ditto. WebKit: Reviewed by Justin. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8616 REGRESSION: TinyMCE: Crash on Undo * WebView/WebHTMLView.m: (-[WebHTMLView _topHTMLView]): Added. (-[WebHTMLView _isTopHTMLView]): Added. (-[WebHTMLView _insideAnotherHTMLView]): Changed to use _topHTMLView. (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Forward to the top HTML view, so that only the top view ever starts a dragging operation. Change dragging code to not assume that the dragged node is in the current view's document. Added checks that the node is an element in a couple places and coordinate conversions. (-[WebHTMLView _mayStartDragAtEventLocation:]): Forward to the top HTML view. (-[NSArray addMouseMovedObserver]): Change to do nothing when the dataSource field is 0, since we now use the dataSource field to get to the WebView. (-[NSArray removeMouseMovedObserver]): Added a comment. (-[NSArray dragImage:at:offset:event:pasteboard:source:slideBack:]): Forward to the top HTML view. (-[NSArray draggingSourceOperationMaskForLocal:]): Assert that it's the top HTML view. (-[NSArray draggedImage:movedTo:]): Ditto. (-[NSArray draggedImage:endedAt:operation:]): Ditto. (-[NSArray namesOfPromisedFilesDroppedAtDestination:]): Ditto. (-[NSArray _canProcessDragWithDraggingInfo:]): Ditto. (-[NSArray _isMoveDrag]): Ditto. (-[NSArray draggingUpdatedWithDraggingInfo:actionMask:]): Ditto. (-[NSArray draggingCancelledWithDraggingInfo:]): Ditto. (-[NSArray concludeDragForDraggingInfo:actionMask:]): Ditto. Also added code to work with the appropriate bridge when receiving a drag. This fixes the problem where the top level frame got a selection intended for the inner frame; the source of the bug. (-[NSArray elementAtPoint:allowShadowContent:]): Added code to convert the coordinates so this works properly when returning an element from an inner frame. (-[NSArray setDataSource:]): Added a call to addMouseMovedObserver, needed now that addMouseMovedObserver won't do anything if called when dataSource is nil. (-[WebHTMLView _delegateDragSourceActionMask]): Forward to the top HTML view. * WebView/WebView.m: (-[WebViewPrivate dealloc]): Removed code to release dragCaretBridge since that field is now gone. (-[WebView moveDragCaretToPoint:]): Always call the main frame's bridge, since the drag caret is now a page-level item. Later we'll move it to the page bridge. (-[WebView removeDragCaret]): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14770 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 07 Jun, 2006 10 commits
-
-
justing authored
Reviewed by levi * editing/deleting/delete-4038408-fix-expected.txt: * editing/input/attributed-substring-from-range-lines-expected.txt: * editing/inserting/insert-3654864-fix-expected.txt: * editing/inserting/insert-3659587-fix-expected.txt: * editing/inserting/insert-3775316-fix-expected.txt: * editing/inserting/insert-at-end-01-expected.txt: * editing/inserting/insert-at-end-02-expected.txt: * editing/inserting/insert-br-001-expected.txt: * editing/inserting/insert-br-005-expected.txt: WebCore: Reviewed by levi Fixed some comments and removed an unused variable. * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeBlockPlaceholder): Don't remove a br if it isn't at the start of a block, since it isn't really a "block placeholder". * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply): * editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): * editing/htmlediting.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14768 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
hyatt authored
Reviewed by justin * WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge paintCustomHighlight:forBox:onLine:behindText:]): * WebView/WebHTMLView.m: (-[WebHTMLView _highlighterForType:]): * WebView/WebHTMLViewInternal.h: * WebView/WebHTMLViewPrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14767 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
hyatt authored
Reviewed by justin * WebCore.xcodeproj/project.pbxproj: * bridge/mac/FrameMac.h: * bridge/mac/FrameMac.mm: (WebCore::FrameMac::paintCustomHighlight): * bridge/mac/WebCoreFrameBridge.h: * platform/mac/ClipboardMac.h: * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintCustomHighlight): * rendering/InlineTextBox.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14766 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Reviewed by Hyatt Added support for cross-platform resize property. * platform/PlatformMouseEvent.h: Removed isMouseButtonDown, since we already cache this info when we handle mouse down and mouse up. * platform/mac/MouseEventMac.mm: ditto. * platform/win/TemporaryLinkStubs.cpp: ditto. * page/Frame.cpp: (WebCore::Frame::autoscrollTimerFired): Use d->m_bMousePressed instead of isMouseButtonDown. * page/FrameView.cpp: (WebCore::FrameView::handleMouseMoveEvent): Passes event to layer resize method. (WebCore::FrameView::mousePressed): Added. * page/FrameView.h: Added mousePressed. * rendering/RenderTheme.h: Removed paintResizeControl. Since its not dependent on the theme, the layer can just paint this. * rendering/RenderTheme.cpp: ditto. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): Initializes m_resizeCornerImage. (WebCore::RenderLayer::~RenderLayer): Deletes m_resizeCornerImage. (WebCore::RenderLayer::resize): Uses passed in event instead of creating a new one. (WebCore::RenderLayer::paintResizeControl): Now loads and paints the resize image. * rendering/RenderLayer.h: Added m_resizeCornerImage. Important to have one per-layer for when we allow more customization. * platform/cairo/ImageCairo.cpp: (WebCore::Image::loadResource): Loads image resources. WebKit: Reviewed by Hyatt. Added resources for missingImage and textAreaResizeCorner. * COM/WebKitDLL.cpp: (loadResourceIntoArray): Added. Returns a DeprecatedByteArray with the resource's data. * WebKit.vcproj/WebKit.rc: Added missing image and resize pngs as resources. * WebKit.vcproj/WebKit.vcproj: Added pngs. * WebKit.vcproj/missingImage.png: Added. * WebKit.vcproj/resource.h: Added entries for pngs. * WebKit.vcproj/textAreaResizeCorner.png: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14765 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
hyatt authored
Reviewed by Tim H * WebView/WebHTMLView.m: (-[WebTextCompleteController dealloc]): (-[WebHTMLView _setHighlighter:ofType:]): (-[WebHTMLView _removeHighlighterOfType:]): * WebView/WebHTMLViewInternal.h: * WebView/WebHTMLViewPrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14764 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
hyatt authored
adds support for the parsing of the property. It doesn't do anything yet. Reviewed by beth * css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): * css/CSSPropertyNames.in: * css/cssparser.cpp: (WebCore::CSSParser::parseValue): * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): * rendering/render_style.cpp: (WebCore::StyleCSS3InheritedData::StyleCSS3InheritedData): (WebCore::StyleCSS3InheritedData::operator==): (WebCore::RenderStyle::diff): * rendering/render_style.h: (WebCore::RenderStyle::highlight): (WebCore::RenderStyle::setHighlight): (WebCore::RenderStyle::initialHighlight): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14763 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ggaren authored
* API: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14762 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9341 REGRESSION: Repro crash caused by style="font:bold" Test: fast/css/font-shorthand-weight-only.html * css/cssparser.cpp: (WebCore::CSSParser::parseFont): Revert part of the change made to fix bug 5564. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14761 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
Reviewed by Hyatt, tweaked by Mitz. - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9122 REGRESSION: Incorrect vertical position for text fields in a "display: table" block * fast/table/text-field-baseline-expected.checksum: Added. * fast/table/text-field-baseline-expected.png: Added. * fast/table/text-field-baseline-expected.txt: Added. * fast/table/text-field-baseline.html: Added. WebCore: Reviewed by Hyatt. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9122 REGRESSION: Incorrect vertical position for text fields in a "display: table" block Test: fast/table/text-field-baseline.html * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::baselinePosition): Do not descend into replaced objects, just use their baseline. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14760 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
Reviewed by Hyatt. - pixel test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4334 REGRESSION: Flickering when css-hover should change opacity on floating elements * fast/block/float/nopaint-after-layer-destruction-expected.checksum: Added. * fast/block/float/nopaint-after-layer-destruction-expected.png: Added. * fast/block/float/nopaint-after-layer-destruction-expected.txt: Added. * fast/block/float/nopaint-after-layer-destruction.html: Added. WebCore: Reviewed by Hyatt (concept) and Darin (some coding details). - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4334 REGRESSION: Flickering when css-hover should change opacity on floating elements Pixel test: fast/block/float/nopaint-after-layer-destruction.html * rendering/RenderBlock.cpp: (WebCore::RenderBlock::setPaintsFloatingObject): Added. Changes the noPaint flag in the block's FloatingObject for the given float and calls setChildNeedsLayout. * rendering/RenderBlock.h: * rendering/RenderBox.cpp: (WebCore::blockThatPaintsFloat): Added this helper function. (WebCore::RenderBox::setStyle): Added. Calls to setPaintsFloatingObject when a float gains or loses its layer. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 06 Jun, 2006 9 commits
-
-
ddkilzer authored
Reviewed by darin. http://bugzilla.opendarwin.org/show_bug.cgi?id=9322 Teach svn-create-patch to sort its output * Scripts/svn-create-patch: Clean up perl code. Sort patch output alphabetically by text files first, then by binary files. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14758 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
Reviewed by Hyatt. - repaint test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9121 REGRESSION: [Incremental Repaint] DHTML movement test failures * fast/repaint/containing-block-position-change-expected.checksum: Added. * fast/repaint/containing-block-position-change-expected.png: Added. * fast/repaint/containing-block-position-change-expected.txt: Added. * fast/repaint/containing-block-position-change.html: Added. WebCore: Reviewed by Hyatt. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9121 REGRESSION: [Incremental Repaint] DHTML movement test failures Test (repaint): fast/repaint/containing-block-position-change.html * manual-tests/containing-block-position-chage.html: Added. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Unrelated change: fixed typo from the RenderCanvas to RenderView rename. (WebCore::RenderBlock::removePositionedObject): Added a return immediately after removing the object. (WebCore::RenderBlock::removePositionedObjects): Added. * rendering/RenderBlock.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Added code to remove absolutely positioned descendants from the positioned objects list of their current containing block when they are going to have a new one as a result of this block's position property changing. * rendering/RenderObject.h: (WebCore::RenderObject::removePositionedObjects): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14757 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
* fast/repaint/table-extra-bottom-grow-expected.png: Regenerated. * fast/repaint/table-extra-bottom-grow-expected.checksum: Regenerated. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14756 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
justing authored
Reviewed by levi Added to demonstrate fixes: * editing/pasteboard/merge-after-delete-expected.checksum: Added. * editing/pasteboard/merge-after-delete-expected.png: Added. * editing/pasteboard/merge-after-delete-expected.txt: Added. * editing/pasteboard/merge-after-delete.html: Added. * editing/inserting/line-break-expected.checksum: Added. * editing/inserting/line-break-expected.png: Added. * editing/inserting/line-break-expected.txt: Added. * editing/inserting/line-break.html: Added. * editing/inserting/multiple-lines-selected-expected.checksum: Added. * editing/inserting/multiple-lines-selected-expected.png: Added. * editing/inserting/multiple-lines-selected-expected.txt: Added. * editing/inserting/multiple-lines-selected.html: Added. Fixed: * editing/deleting/collapse-whitespace-3587601-fix-expected.txt: * editing/deleting/delete-3775172-fix-expected.txt: * editing/deleting/delete-3928305-fix-expected.txt: * editing/deleting/delete-3959464-fix-expected.checksum: * editing/deleting/delete-3959464-fix-expected.png: * editing/deleting/delete-3959464-fix-expected.txt: * editing/deleting/delete-4038408-fix-expected.checksum: * editing/deleting/delete-4038408-fix-expected.png: * editing/deleting/delete-4038408-fix-expected.txt: * editing/deleting/delete-4038408-fix.html: * editing/deleting/delete-at-paragraph-boundaries-002-expected.txt: * editing/deleting/delete-at-paragraph-boundaries-011-expected.checksum: * editing/deleting/delete-at-paragraph-boundaries-011-expected.png: * editing/deleting/delete-at-paragraph-boundaries-011-expected.txt: * editing/deleting/delete-block-contents-001-expected.txt: * editing/deleting/delete-block-contents-002-expected.txt: * editing/deleting/delete-block-contents-003-expected.txt: * editing/deleting/delete-br-011-expected.checksum: * editing/deleting/delete-br-011-expected.png: * editing/deleting/delete-br-011-expected.txt: * editing/deleting/delete-image-004-expected.txt: * editing/deleting/delete-line-010-expected.txt: * editing/deleting/delete-line-015-expected.txt: * editing/deleting/delete-select-all-001-expected.checksum: * editing/deleting/delete-select-all-001-expected.png: * editing/deleting/delete-select-all-001-expected.txt: * editing/deleting/delete-select-all-002-expected.txt: * editing/deleting/delete-select-all-003-expected.checksum: * editing/deleting/delete-select-all-003-expected.png: * editing/deleting/delete-select-all-003-expected.txt: * editing/execCommand/insertImage-expected.checksum: * editing/execCommand/insertImage-expected.png: * editing/input/attributed-substring-from-range-lines-expected.txt: * editing/input/text-input-controller-expected.txt: * editing/inserting/insert-3654864-fix-expected.txt: * editing/inserting/insert-3659587-fix-expected.txt: * editing/inserting/insert-3775316-fix-expected.txt: * editing/inserting/insert-after-delete-001-expected.txt: * editing/inserting/insert-at-end-01-expected.txt: * editing/inserting/insert-at-end-02-expected.txt: * editing/inserting/insert-br-001-expected.txt: * editing/inserting/insert-br-005-expected.txt: * editing/pasteboard/4076267-3-expected.txt: * editing/pasteboard/4076267-expected.txt: * editing/pasteboard/drag-drop-modifies-page-expected.txt: * editing/pasteboard/paste-4035648-fix-expected.txt: * editing/pasteboard/paste-4039777-fix-expected.checksum: * editing/pasteboard/paste-4039777-fix-expected.png: * editing/pasteboard/paste-4039777-fix-expected.txt: * editing/pasteboard/paste-match-style-001-expected.txt: * editing/pasteboard/paste-match-style-002-expected.txt: * editing/pasteboard/smart-paste-006-expected.txt: * editing/pasteboard/smart-paste-007-expected.txt: * editing/selection/drag-to-contenteditable-iframe-expected.txt: * editing/style/block-style-005-expected.txt: * editing/style/typing-style-002-expected.txt: * editing/unsupported-content/list-delete-001-expected.checksum: * editing/unsupported-content/list-delete-001-expected.png: * editing/unsupported-content/list-delete-001-expected.txt: * editing/unsupported-content/list-delete-002-expected.checksum: * editing/unsupported-content/list-delete-002-expected.png: * editing/unsupported-content/list-delete-002-expected.txt: * editing/unsupported-content/table-delete-001-expected.checksum: * editing/unsupported-content/table-delete-001-expected.png: * editing/unsupported-content/table-delete-001-expected.txt: * editing/unsupported-content/table-delete-003-expected.checksum: * editing/unsupported-content/table-delete-003-expected.png: * editing/unsupported-content/table-delete-003-expected.txt: * fast/text/attributed-substring-from-range.html: WebCore: Reviewed by levi * dom/Node.cpp: (WebCore::Node::firstDescendant): Added. * dom/Node.h: * dom/Range.cpp: Added a constructor that takes in Positions. (WebCore::Range::Range): * dom/Range.h: * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt): Let this function insert children into empty containers. Calls canHaveChildrenForEditing. (WebCore::CompositeEditCommand::appendNode): Assert that the parent canHaveChildrenForEditing. (WebCore::CompositeEditCommand::moveParagraph): Tell ReplaceSelectionCommand to select the replacement so that moveParagraph's callers have a valid destination after the move. * editing/CompositeEditCommand.h: Moved removeFullySelectedNode to DeleteSelectionCommand, made deleteTextFromNode virtual so that DeleteSelectionCommand can update it's endingPosition. * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Removed m_startNode, used a local variable. (WebCore::DeleteSelectionCommand::initializeStartEnd): Fixed special element expansion. (WebCore::DeleteSelectionCommand::initializePositionData): Compute the endingPosition up front and keep track of it as nodes and text are removed. (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Removed use of m_startNode. (WebCore::DeleteSelectionCommand::removeFullySelectedNode): Moved from CompositeEditCommand. Update m_endingPosition as we remove nodes. (WebCore::DeleteSelectionCommand::deleteTextFromNode): Update m_endingPosition as we delete text. (WebCore::DeleteSelectionCommand::handleGeneralDelete): Retain the start block. Cleaned up. (WebCore::DeleteSelectionCommand::mergeParagraphs): Recompute m_endingPosition since moveParagraph clobbers the old one. (WebCore::DeleteSelectionCommand::doApply): Fixed the logic for placeholder insertion after deletion. Make the placeholder decision before we do special element expansion. * editing/DeleteSelectionCommand.h: * editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Fixed a bug where an extra br was inserted and cleaned up the code. * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Deletion of the current selection should do a merge (added a testcase). * editing/RebalanceWhitespaceCommand.cpp: (WebCore::RebalanceWhitespaceCommand::doUnapply): Remove/insert in a way that will trigger a layout. * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Ditto. Merge even when the incoming fragment has interchange newlines (added a testcase). Merge when the selection being pasted into starts at the start of a block because not doing so would leave one or more hanging empty blocks. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Rebalance whitespace using rebalanceWhitespaceAt because rebalanceWhitespace requires a selection, and a selection can't be created until whitespace has been rebalanced. * editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): Added. * editing/htmlediting.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14751 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
bdakin authored
Fix for <rdar://problem/4570475> Dashboard regions do not scale for non-1.0 scale factors. No test cases added since this only affects non-1.0 resolution scale factors. * platform/FloatRect.cpp: (WebCore::FloatRect::scale): Added new function that scales a rect's origin and size by a given factor. * platform/FloatRect.h: * platform/IntRect.cpp: (WebCore::IntRect::scale): Same as above. * platform/IntRect.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::addDashboardRegions): After the bounds and clip rects on the Dashboard region have been calculated, get the user space scale factor, and if it is not 1.0, scale the rects. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14750 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sullivan authored
- fixed <rdar://problem/4566087> REGRESSION (420+): Crash occurs while completing a find again query at http://www.apple.com/ (RenderObject::repaint(bool)) This wasn't a new problem in the code, but the recent use of DocumentMarkers for find results brought it to the surface. * dom/Document.h: Use a RefPtr<Node> instead of a Node* in MarkerMap, so the node will be retained * dom/Document.cpp: (WebCore::Document::removeMarkers): Add a .get() to compensate for using RefPtr. Also, only repaint if this node actually had a marker removed. (WebCore::Document::repaintMarkers): Add a .get() to compensate for using RefPtr. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14748 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
* COM/WebView.cpp: (WebView::keyPress): Added case for VK_RETURN. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14747 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
andersca authored
2006-06-06 Anders Carlsson <acarlsson@apple.com> Reviewed by Darin. http://bugzilla.opendarwin.org/show_bug.cgi?id=9325 clientWidth/clientHeight on document element in strict mode should return visible frame size * dom/Element.cpp: (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): If we're the document element, and in strict mode, return the visible size of the frame. LayoutTests: 2006-06-06 Anders Carlsson <acarlsson@apple.com> Reviewed by Darin. http://bugzilla.opendarwin.org/show_bug.cgi?id=9325 clientWidth/clientHeight on document element in strict mode should return visible frame size * fast/dom/client-width-height-expected.txt: Added. * fast/dom/client-width-height.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14744 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
andersca authored
2006-06-06 Anders Carlsson <acarlsson@apple.com> Reviewed by John. * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge containsPlugins]): * page/Frame.cpp: (WebCore::Frame::containsPlugins): * page/Frame.h: Add containsPlugins function which returns whether a frame contains plugins or not. WebKit: 2006-06-06 Anders Carlsson <acarlsson@apple.com> Reviewed by John. * WebView/WebFrame.m: (-[WebFrame _reloadForPluginChanges]): Don't traverse the view hierarchy looking for plugin views. Instead, just ask the frame whether it contains any plugins. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 05 Jun, 2006 6 commits
-
-
ggaren authored
- fix a regression in ecma_3/String/regress-104375.js * kjs/string_object.cpp: (substituteBackreferences): If a 2-digit back reference is out of range, parse it as a 1-digit reference (followed by the other digit). This matches Firefox's behavior. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14742 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sfalken authored
Fix build break * platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::roundToDevicePixels): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14741 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ddkilzer authored
Reviewed by mjs. testcases for http://bugzilla.opendarwin.org/show_bug.cgi?id=5564 'font' shorthand parsing should be more tolerant in quirks mode * fast/css/font_property_compatibility-expected.checksum: Added. * fast/css/font_property_compatibility-expected.png: Added. * fast/css/font_property_compatibility-expected.txt: Added. * fast/css/font_property_compatibility.html: Added. * fast/css/font_property_normal-expected.checksum: Added. * fast/css/font_property_normal-expected.png: Added. * fast/css/font_property_normal-expected.txt: Added. * fast/css/font_property_normal.html: Added. WebCore: Reviewed by mjs. http://bugzilla.opendarwin.org/show_bug.cgi?id=5564 'font' shorthand parsing should be more tolerant in quirks mode When not in strict mode accept font property specifications lacking a font family part, like WinIE does. * css/cssparser.cpp: (WebCore::CSSParser::parseFont): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14740 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
bdakin authored
Fix for <rdar://problem/4567520> Pixel cracks in weather widget at 1.83 scaling To prevent pixel cracks at non-integral scaling factors, before we call into CG to draw an image, we have to convert the rect to device space, round the origin and size to integers in device space, and convert back to user space. No test cases added since this only affects non-1.0 resolution scale factors. * bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::drawImage): drawImage() now takes FloatRects. * html/CanvasPattern.cpp: (WebCore::patternCallback): Call roundToDevicePixels() * html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): drawImage() now takes FloatRects and call roundToDevicePixels() * html/CanvasRenderingContext2D.h: drawImage() now takes FloatRects. * html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): Call roundToDevicePixels() * kcanvas/device/quartz/QuartzSupport.mm: (WebCore::debugDumpCGImageToFile): Same as above. * platform/GraphicsContext.h: * platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::roundToDevicePixels): Takes care of converting between coordinate spaces and rounding. (WebCore::GraphicsContext::drawLineForText): * platform/mac/ImageMac.mm: Call roundToDevicePixels() (WebCore::Image::draw): Same as above. (WebCore::drawPattern): Same as above. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14739 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ddkilzer authored
Reviewed by ggaren. - Test results for http://bugzilla.opendarwin.org/show_bug.cgi?id=9310 Add missing DOM prototypes and other DOM cleanup * fast/dom/global-constructors-expected.txt: Fixed test results. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14738 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
