- 04 Jun, 2010 40 commits
-
-
eric@webkit.org authored
Reviewed by Dimitri Glazkov. Accessibility focus change notifications are now sent from ChromeClientImpl::focusedNodeChanged(). https://bugs.webkit.org/show_bug.cgi?id=39792 * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::focus): (WebKit::ChromeClientImpl::focusedNodeChanged): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Eric Seidel. Make HTML5Lexer go fast https://bugs.webkit.org/show_bug.cgi?id=40048 We're going to do this patch in small steps to make it easier to verify correctness. * html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by David Hyatt. Make the editing/spelling/context-menu-suggestions.html test more robust https://bugs.webkit.org/show_bug.cgi?id=40178 * editing/spelling/context-menu-suggestions-expected.txt: Added. Add new expected test result. * editing/spelling/context-menu-suggestions.html: Instead of dumping the menu item titles, check the length and check that the number of items is greater when there are spell checker suggestions. * platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt: Removed. * platform/mac-snowleopard/editing/spelling/context-menu-suggestions-expected.txt: Removed. * platform/mac-tiger/editing/spelling/context-menu-suggestions-expected.txt: Removed. Remove platform specific versions. 2010-06-04 Anders Carlsson <andersca@apple.com> Reviewed by David Hyatt. Make the editing/spelling/context-menu-suggestions.html test more robust https://bugs.webkit.org/show_bug.cgi?id=40178 Change the contextClick method to return an array of strings describing the context menu items. * DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController contextClick]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by David Levin. [chromium] Adding support for the left and right Windows keys to the NativeWebKeyboardEvent. https://bugs.webkit.org/show_bug.cgi?id=39752 * platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent): 2010-06-04 Jay Civelli <jcivelli@chromium.org> Reviewed by David Levin. [chromium] Adding support for the left and right Windows keys to the NativeWebKeyboardEvent. https://bugs.webkit.org/show_bug.cgi?id=39752 * src/gtk/WebInputEventFactory.cpp: (WebKit::gdkEventToWindowsKeyCode): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adachan@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=40152 Need to remove the WebView from WindowMessageBroadcaster's listeners list when the WebView is destroyed. * UIProcess/API/win/WKView.cpp: (WKViewSetHostWindow): Expose API to change the host window of a WKView. (WKViewWindowAncestryDidChange): Expose API to allow clients to notify WebKit when a WKView's window ancestry has changed. * UIProcess/API/win/WKView.h: * UIProcess/win/WebView.cpp: (WebKit::WebView::wndProc): Set the WebView's host window to 0 when it's destroyed. setHostWindow() will call windowAncestryDidChange(), which will remove this WebView from the WindowMessageBroadcaster's listeners list. (WebKit::WebView::WebView): Initialize m_isBeingDestroyed. (WebKit::WebView::setHostWindow): Update the window's parent window and call windowAncestryDidChange(). (WebKit::WebView::close): Set the host window to 0. * UIProcess/win/WebView.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kinuko@chromium.org authored
Reviewed by Shinichiro Hamaji. Clean up chromium-specific code from json_results_generator.py. https://bugs.webkit.org/show_bug.cgi?id=39665 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/chromium.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
krit@webkit.org authored
Reviewed by Nikolas Zimmermann. SVG filter on filter don't work https://bugs.webkit.org/show_bug.cgi?id=32708 Any child of <text> was not allowed to use the same filter as the text root. I couldn't found any reason in the SVG specification that legimitate this. Only batik also doesn't allow the same filter on the text root as on it's childs, while any other effect is still allowed. I removed this limitation so that the result looks like the result on Firefox. Test: svg/filters/filter-on-filter-for-text.svg * rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): * rendering/SVGRenderSupport.h: * rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback): (WebCore::SVGRootInlineBox::paint): 2010-06-04 Dirk Schulze <krit@webkit.org> Reviewed by Nikolas Zimmermann. SVG filter on filter don't work https://bugs.webkit.org/show_bug.cgi?id=32708 Test that a filter can be used by the text root as well as on it's childs. * platform/mac/svg/filters/filter-on-filter-for-text-expected.checksum: Added. * platform/mac/svg/filters/filter-on-filter-for-text-expected.png: Added. * platform/mac/svg/filters/filter-on-filter-for-text-expected.txt: Added. * svg/filters/filter-on-filter-for-text.svg: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
japhet@chromium.org authored
Reviewed by Adam Barth. Factor PageCache functionality out of FrameLoader and into PageCache itself. https://bugs.webkit.org/show_bug.cgi?id=39382 Refactor only, so no new tests. * history/PageCache.cpp: (WebCore::pageCacheLogPrefix): (WebCore::pageCacheLog): (WebCore::logCanCacheFrameDecision): (WebCore::logCanCachePageDecision): (WebCore::PageCache::canCachePageContainingThisFrame): (WebCore::PageCache::canCache): (WebCore::PageCache::add): (WebCore::PageCache::get): * history/PageCache.h: * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitIfReady): * loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::prepareForCachedPageRestore): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): (WebCore::FrameLoader::navigateToDifferentDocument): * loader/FrameLoader.h: (WebCore::FrameLoader::quickRedirectComing): * svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
loislo@chromium.org authored
Reviewed by Pavel Feldman. WebInspector: Web Inspector: it would be better to push object properties to JSON string in order of insertion. https://bugs.webkit.org/show_bug.cgi?id=40140 * inspector/InspectorValues.cpp: (WebCore::InspectorObject::writeJSON): * inspector/InspectorValues.h: (WebCore::InspectorObject::setBool): (WebCore::InspectorObject::setNumber): (WebCore::InspectorObject::setString): (WebCore::InspectorObject::set): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
laszlo.1.gombos@nokia.com authored
Symbian build fix. [Qt] Updated the def file with recent new exports. * symbian/eabi/QtWebKitu.def: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
Unskip fast/dom/Window/window-properties-geolocation.html - a comment says it should be enabled once bug 34025 is fixed, which happened long ago. The test passes for me. * platform/mac/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Adam Barth. Persist V8's ScriptData to the memory cache. https://bugs.webkit.org/show_bug.cgi?id=38661 This stores V8's ScriptData in the memory cache and also causes the network platform layer to be notified of the available cacheable metadata. Chromium's morejs benchmark shows a 3-4% improvement on fast hardware. No new tests because no new functionality. * bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::cachedScript): * bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::precompileScript): (WebCore::V8Proxy::evaluate): * bindings/v8/V8Proxy.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Adam Barth. Add a takeFirst() method to Deque and use it where appropriate. https://bugs.webkit.org/show_bug.cgi?id=40089 * wtf/Deque.h: (WTF::::takeFirst): * wtf/MainThread.cpp: (WTF::dispatchFunctionsFromMainThread): * wtf/MessageQueue.h: (WTF::::tryGetMessage): 2010-06-04 Tony Gentilcore <tonyg@chromium.org> Reviewed by Adam Barth. Utilize new takeFirst() method where appropriate. https://bugs.webkit.org/show_bug.cgi?id=40089 No new tests because no new functionality. * css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addSubresourceStyleURLs): * dom/XMLTokenizerLibxml2.cpp: (WebCore::PendingCallbacks::callAndRemoveFirstCallback): * html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::executeExternalScriptsIfReady): * platform/text/SegmentedString.cpp: (WebCore::SegmentedString::advanceSubstring): * storage/Database.cpp: (WebCore::Database::scheduleTransaction): * storage/SQLTransaction.cpp: (WebCore::SQLTransaction::getNextStatement): * storage/SQLTransactionCoordinator.cpp: (WebCore::SQLTransactionCoordinator::processPendingTransactions): 2010-06-04 Tony Gentilcore <tonyg@chromium.org> Reviewed by Adam Barth. Utilize new takeFirst() method where appropriate. https://bugs.webkit.org/show_bug.cgi?id=40089 * Platform/CoreIPC/ArgumentDecoder.cpp: (CoreIPC::ArgumentDecoder::removeAttachment): 2010-06-04 Tony Gentilcore <tonyg@chromium.org> Reviewed by Adam Barth. Utilize new takeFirst() method where appropriate. https://bugs.webkit.org/show_bug.cgi?id=40089 * DumpRenderTree/chromium/EventSender.cpp: (EventSender::replaySavedEvents): * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::WorkQueue::processWork): (LayoutTestController::WorkQueue::reset): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Pavel Feldman. Web Inspector: better Function.prototype.bind for the internal code. In the "Event Listeners" pane show handler function instead of Function.prototype.bind. https://bugs.webkit.org/show_bug.cgi?id=40080 * inspector/front-end/utilities.js: (Function.prototype.bind.bound): (Function.prototype.bind.bound.toString): (Function.prototype.bind): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
apavlov@chromium.org authored
Unreviewed, fix Qt build. Add references to a new file. * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/front-end/WebKit.qrc: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
apavlov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: Eliminate direct dependency of StylesSidebarPane on InspectorBackend https://bugs.webkit.org/show_bug.cgi?id=40069 No new tests are needed, as this is a refactoring. * inspector/front-end/CSSStyleModel.js: Added. (WebInspector.CSSStyleModel): (WebInspector.CSSStyleModel.prototype.getStylesAsync): (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype.toggleStyleEnabled): (WebInspector.CSSStyleModel.prototype.setCSSText): (WebInspector.CSSStyleModel.prototype.applyStyleText): * inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.stylesCallback): (WebInspector.StylesSidebarPane.prototype.update.computedStyleCallback): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._arrayContainsInheritedProperty): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype): * inspector/front-end/inspector.html: * inspector/front-end/inspector.js: (WebInspector.loaded): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: Create resource for DebuggerScript.js. https://bugs.webkit.org/show_bug.cgi?id=40122 * WebKit.grd: * public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::debuggerScriptSource): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yael.aharon@nokia.com authored
https://bugs.webkit.org/show_bug.cgi?id=40078 Reviewed by Simon Hausmann. * QtTestBrowser/main.cpp: (NotificationsPermissionController::NotificationsPermissionController): (NotificationsPermissionController::checkPermission): (NotificationsPermissionController::requestPermission): (LauncherWindow::LauncherWindow): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hausmann@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=40116 Reviewed by Tor Arne Vestbø. CONFIG += mobility has the side-effect of pulling in mobility includes, which conflict with Qt 4.7's bearer managenent includes and break the build. * WebCore.pro: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Dimitri Glazkov. [chromium] Fix scrolling bug with pages using accelerated compositing. https://bugs.webkit.org/show_bug.cgi?id=40037 * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::drawLayers): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Darin Adler. CG implementation needed for compression quality in canvas.toDataURL https://bugs.webkit.org/show_bug.cgi?id=38492 * platform/mac/Skipped: 2010-06-04 Matthew Delaney <mdelaney@apple.com> Reviewed by Darin Adler. CG implementation needed for compression quality in canvas.toDataURL https://bugs.webkit.org/show_bug.cgi?id=38492 Took toDataURL.jpeg.quality.basic.html test off of Skipped list. Passes. Went the route of avoiding in-band signaling to flag the use of a quality parameter or not. So, instead of simply passing the quality down as a double, instead I pass a reference to the quality parameter from where it comes in just after the JS bindings. Thus, no need for any global constants to signify when the quality is not specified. Updated the other platforms to support this (qt was on the only one currently with any implementation). * bindings/js/JSHTMLCanvasElementCustom.cpp: Moved range check logic for quality parameter down lower. Updated call to toDataURL to use double* instead of just passing the quality directly. (WebCore::JSHTMLCanvasElement::toDataURL): * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Updated toDataURL call to pass double* (WebCore::V8HTMLCanvasElement::toDataURLCallback): * dom/CanvasSurface.cpp: Updated method prototype. (WebCore::CanvasSurface::toDataURL): * dom/CanvasSurface.h: Updated method prototype. (WebCore::CanvasSurface::toDataURL): * platform/graphics/ImageBuffer.h: Updated method signature to use double* for quality param. * platform/graphics/cairo/ImageBufferCairo.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL): * platform/graphics/cg/ImageBufferCG.cpp: Implemented support for quality parametejr when jpeg MIME type used. (WebCore::jpegUTI): (WebCore::utiFromMIMEType): (WebCore::ImageBuffer::toDataURL): * platform/graphics/haiku/ImageBufferHaiku.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL): * platform/graphics/qt/ImageBufferQt.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL): * platform/graphics/skia/ImageBufferSkia.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL): * platform/graphics/wince/ImageBufferWince.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL): * platform/graphics/wx/ImageBufferWx.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
failures on Chromium. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alex@webkit.org authored
Reviewed by Xan Lopez. Leaks in listDirectory https://bugs.webkit.org/show_bug.cgi?id=40008 Fixed both leaks. * platform/gtk/FileSystemGtk.cpp: (WebCore::listDirectory): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
steveblock@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=40153 * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by David Levin. Modifying the WebMediaPlayer interface to be compatible with a change in chrome. This is a part 2 of 3 one-sided changes to chrome and WebKit. Chrome has been updated, so this commit should NOT break chromium anymore. https://bugs.webkit.org/show_bug.cgi?id=39445 * public/WebMediaPlayer.h: Changed buffered() to be non-const. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Nate Chapin. [Chromium] get rid of named interceptor on HTMLDocument and introduce/remove accessors when named items get deleted/removed https://bugs.webkit.org/show_bug.cgi?id=39877 This patch makes callbacks invoked on named items addition/removal install API accessors and thus there is no more need in named and indexed interceptors on HTMLDocument which speeds up invocation of methods on document. * bindings/scripts/CodeGeneratorV8.pm: * bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved): * bindings/v8/V8DOMWindowShell.cpp: (WebCore::checkDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::getter): (WebCore::V8DOMWindowShell::namedItemAdded): (WebCore::V8DOMWindowShell::namedItemRemoved): * bindings/v8/V8DOMWindowShell.h: * bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): * bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::WrapInShadowObject): (WebCore::V8HTMLDocument::GetNamedProperty): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
steveblock@google.com authored
Reviewed by Jeremy Orlow. Geolocation needs more LayoutTests to test making callbacks to remote frames https://bugs.webkit.org/show_bug.cgi?id=40146 This test is similar to callback-to-remote-context.html in that it test making a callback from a Geolocation object to a remote frame. In callback-to-remote-context.html, the call chain to the Geolocation method is started from the owning frame. In this test, however, the call chain is started from the remote frame. * fast/dom/Geolocation/callback-to-remote-context2-expected.txt: Added. * fast/dom/Geolocation/callback-to-remote-context2.html: Added. * fast/dom/Geolocation/script-tests/callback-to-remote-context2.js: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kent Tamura. Change filenameFromString to return CString https://bugs.webkit.org/show_bug.cgi?id=39494 filenameFromString returns a newly allocated string and the caller must free the string. GTK and EFL ports use g_free while all others ports use fastFree. This is confusing because the same function behaves differently with respect to ports. Change filenameFromString to return CString. * platform/FileSystem.cpp: (WebCore::filenameFromString): * platform/FileSystem.h: * platform/efl/FileSystemEfl.cpp: (WebCore::filenameFromString): * platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth): * platform/gtk/FileSystemGtk.cpp: (WebCore::filenameFromString): (WebCore::filenameForDisplay): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::makeAllDirectories): (WebCore::pathGetFileName): (WebCore::directoryName): (WebCore::listDirectory): * platform/gtk/SharedBufferGtk.cpp: (WebCore::SharedBuffer::createWithContentsOfFile): * platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp): * platform/posix/SharedBufferPOSIX.cpp: (WebCore::SharedBuffer::createWithContentsOfFile): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
steveblock@google.com authored
Reviewed by Jeremy Orlow. Geolocation LayoutTests should make more careful use of LayoutTestController https://bugs.webkit.org/show_bug.cgi?id=39994 Guards calls to LayoutTestController methods with 'if (window.layoutTestController)' and adds test output to make it clear if the test can not pass without LayoutTestController. Also removes superfluous calls to LayoutTestController.waitUntilDone(), which are now made by js-test-post.js. * fast/dom/Geolocation/callback-exception-expected.txt: * fast/dom/Geolocation/script-tests/callback-exception.js: * fast/dom/Geolocation/script-tests/error.js: * fast/dom/Geolocation/script-tests/maximum-age.js: * fast/dom/Geolocation/script-tests/notimer-after-unload.js: * fast/dom/Geolocation/script-tests/permission-denied-already-clear-watch.js: * fast/dom/Geolocation/script-tests/permission-denied-already-error.js: * fast/dom/Geolocation/script-tests/permission-denied-already-success.js: * fast/dom/Geolocation/script-tests/permission-denied-stops-watches.js: * fast/dom/Geolocation/script-tests/permission-denied.js: * fast/dom/Geolocation/script-tests/position-string.js: * fast/dom/Geolocation/script-tests/reentrant-error.js: * fast/dom/Geolocation/script-tests/reentrant-success.js: * fast/dom/Geolocation/script-tests/success.js: * fast/dom/Geolocation/script-tests/timeout-clear-watch.js: * fast/dom/Geolocation/script-tests/timeout-zero.js: * fast/dom/Geolocation/script-tests/timeout.js: * fast/dom/Geolocation/script-tests/watch.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Adam Barth. Detect whether the user's environment can open a browser. https://bugs.webkit.org/show_bug.cgi?id=40136 Some environments like cygwin silently fail webbrowser.open() causing webkit-patch upload not to display any diff. This detects environments where webbrowser.open() would fail by testing if webbrowser.get() raises an exception. * Scripts/webkitpy/common/system/user.py: * Scripts/webkitpy/tool/mocktool.py: * Scripts/webkitpy/tool/steps/confirmdiff.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Fix compilation with QT_NO_FEATURE https://bugs.webkit.org/show_bug.cgi?id=38324 The #ifdef QT_NO_GRAPHICSEFFECT was in the wrong place, would have made AC not work at all. No new tests. * platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Laszlo Gombos. [Qt] Failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.ensuresubpath.1.html https://bugs.webkit.org/show_bug.cgi?id=38645 Remove 2d.path.arcTo.ensuresubpath.1.html from Skipped. * platform/qt/Skipped: 2010-06-04 Qi Zhang <qi.2.zhang@nokia.com> Reviewed by Laszlo Gombos. [Qt] Failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.ensuresubpath.1.html https://bugs.webkit.org/show_bug.cgi?id=38645 Path arcto function need to ensure there is subpath before it. * platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArcTo): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Laszlo Gombos. [Qt] failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arc.angle.3.html https://bugs.webkit.org/show_bug.cgi?id=38537 Remove canvas/philip/tests/2d.path.arcTo.2d.path.arc.angle.3.html and canvas/philip/tests/2d.path.arcTo.2d.path.arc.angle.5.html from Skipped. * platform/qt/Skipped: 2010-06-04 Qi Zhang <qi.2.zhang@nokia.com> Reviewed by Laszlo Gombos. [Qt] failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arc.angle.3.html https://bugs.webkit.org/show_bug.cgi?id=38537 For path.arc function handle span > 2PI * platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. Remove a QEXPECT_FAIL flag from an autotest. Test tst_QScriptEngine::globalObject pass after 36600 bug fix have been applied. [Qt] Expected fail in the tst_QScriptEngine::globalObject should be removed. https://bugs.webkit.org/show_bug.cgi?id=40114 * qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::globalObject): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. Fix QScriptValue::equals. Handling for a few edge cases were added. Now comparison between NaN, an invalid objects should works as supposed. [Qt] QScriptValue::equals problems https://bugs.webkit.org/show_bug.cgi?id=40110 * qt/api/qscriptvalue.cpp: (QScriptValue::equals): * qt/api/qscriptvalue_p.h: (QScriptValuePrivate::equals): * qt/tests/qscriptvalue/tst_qscriptvalue.h: * qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: (tst_QScriptValue::equals_initData): (tst_QScriptValue::equals_makeData): (tst_QScriptValue::equals_test): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Dimitri Glazkov. Set attributes.stencil to false by default at context creation https://bugs.webkit.org/show_bug.cgi?id=40090 * fast/canvas/webgl/context-attributes-expected.txt: Check if the default attributes.stencil == false. * fast/canvas/webgl/context-attributes.html: Ditto. 2010-06-04 Zhenyao Mo <zmo@google.com> Reviewed by Dimitri Glazkov. Set attributes.stencil to false by default at context creation https://bugs.webkit.org/show_bug.cgi?id=40090 * platform/graphics/GraphicsContext3D.h: Set default attributes.stencil to false. (WebCore::GraphicsContext3D::Attributes::Attributes): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
websocket/tests/reload-crash.html sometimes crash. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
Reviewed by Eric Carlson. Fix a crash when trying to use an invalid media src url by moving the isValid url checks to a central location in isSafeToLoadURL function. Also added an empty string check in DocumentLoader::didTellClientAboutLoad. Test: media/invalid-media-url-crash.html * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::getPluginProxyParams): * loader/DocumentLoader.h: (WebCore::DocumentLoader::didTellClientAboutLoad): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Reviewed by Eric Carlson. Tests that invalid media src url does not result in crash. * media/invalid-media-url-crash-expected.txt: Added. * media/invalid-media-url-crash.html: Added. * platform/gtk/Skipped: * platform/qt/Skipped: 2010-06-03 Abhishek Arya <inferno@chromium.org> Reviewed by Eric Carlson. Fix a crash when trying to use an invalid media src url by moving the isValid url checks to a central location in isSafeToLoadURL function. Also added an empty string check in DocumentLoader::didTellClientAboutLoad. Test: media/invalid-media-url-crash.html * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::getPluginProxyParams): * loader/DocumentLoader.h: (WebCore::DocumentLoader::didTellClientAboutLoad): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by David Levin. Add dependencies required to link with VS Express 2005. https://bugs.webkit.org/show_bug.cgi?id=40038 Visual Studio implicitly links against these libs. VC++ Express does not. * WebKitAPITest/WebKitAPITestCommon.vsprops: * WinLauncher/WinLauncher.vcproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-