1. 11 Jun, 2010 40 commits
    • weinig@apple.com's avatar
      Move WKRetain and WKRelease overloaded functions out of WKRetainPtr · 7525795e
      weinig@apple.com authored
      and into the files of the type they overload (eg, WKRetain(WKFrameRef 
      moves to WKFrame.h)).
      
      Reviewed by Anders Carlsson.
      
      * UIProcess/API/C/WKBase.h:
      * UIProcess/API/C/WKContext.h:
      * UIProcess/API/C/WKFrame.h:
      * UIProcess/API/C/WKFramePolicyListener.h:
      * UIProcess/API/C/WKNavigationData.h:
      * UIProcess/API/C/WKPage.h:
      * UIProcess/API/C/WKPageNamespace.h:
      * UIProcess/API/C/WKPreferences.h:
      * UIProcess/API/C/WKString.h:
      * UIProcess/API/C/WKURL.h:
      * UIProcess/API/cpp/WKRetainPtr.h:
      * UIProcess/API/win/WKView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7525795e
    • ojan@chromium.org's avatar
      2010-06-10 Ojan Vafai <ojan@chromium.org> · e8ac5661
      ojan@chromium.org authored
              Reviewed by Eric Seidel.
      
              upload all patches that lack in-rietveld to rietveld
              https://bugs.webkit.org/show_bug.cgi?id=40444
      
              If it's a patch, then we'll try to upload it as long as it
              doesn't have in-rietveld set. No longer set in-rietveld? since
              it's not needed.
      
              * Scripts/webkitpy/common/net/bugzilla.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8ac5661
    • kbr@google.com's avatar
      2010-06-11 Kenneth Russell <kbr@google.com> · 8d54d6d3
      kbr@google.com authored
              Reviewed by Dimitri Glazkov.
      
              getParameter with UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL is buggy
              https://bugs.webkit.org/show_bug.cgi?id=40506
      
              Return the data members of WebGLRenderingContext for these
              parameter queries rather than asking OpenGL, which knows nothing
              about them.
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::getParameter):
      2010-06-11  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              getParameter with UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL is buggy
              https://bugs.webkit.org/show_bug.cgi?id=40506
      
              Return the data members of WebGLRenderingContext for these
              parameter queries rather than asking OpenGL, which knows nothing
              about them.
      
              * fast/canvas/webgl/gl-get-calls-expected.txt:
              * fast/canvas/webgl/gl-get-calls.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d54d6d3
    • simon.fraser@apple.com's avatar
      2010-06-11 Simon Fraser <simon.fraser@apple.com> · a1fea851
      simon.fraser@apple.com authored
              Reviewed by Dr Dan Bernstein.
      
              REGRESSION: crash when unloading an iFrame with Flash from the DOM
              https://bugs.webkit.org/show_bug.cgi?id=40161
              <rdar://problem/7994710>
      
              Null-check the ownerElement of the RenderView's document when unhooking the compositing
              root of an iframe whose layers are parented via the enclosing document. Fixes a crash when
              dynamically removing such an iframe.
      
              Test: compositing/iframes/remove-iframe-crash.html
      
              * rendering/RenderLayerCompositor.cpp:
              (WebCore::RenderLayerCompositor::detachRootPlatformLayer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1fea851
    • jhawkins@chromium.org's avatar
      2010-06-11 Abhishek Arya <inferno@chromium.org> · 7788449f
      jhawkins@chromium.org authored
              Reviewed by David Hyatt.
      
              Don't process floats if parent node is not a RenderBlock.
              https://bugs.webkit.org/show_bug.cgi?id=40033
      
              Test: svg/text/clear-floats-crash.svg
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::clearFloats):
      2010-06-11  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by David Hyatt.
      
              Tests that we do not crash when clearing floats during SVG load.
              https://bugs.webkit.org/show_bug.cgi?id=40033
      
              * svg/text/clear-floats-crash-expected.txt: Added.
              * svg/text/clear-floats-crash.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7788449f
    • dimich@chromium.org's avatar
      Unreviewed, fixing Chromium test bots. · 13e1f9b6
      dimich@chromium.org authored
      * platform/chromium/test_expectations.txt:
      Adding MISSING expectation for the fast/css/nested-rounded-corners.html
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13e1f9b6
    • kbr@google.com's avatar
      2010-06-11 Kenneth Russell <kbr@google.com> · 0ea3dd95
      kbr@google.com authored
              Unreviewed, test fix.
      
              gl-get-calls failing apparently due to UNPACK_ALIGNMENT test
              https://bugs.webkit.org/show_bug.cgi?id=40502
      
              Disabled new test of UNPACK_ALIGNMENT which appears to be failing
              on some of the bots.
      
              * fast/canvas/webgl/gl-get-calls-expected.txt:
              * fast/canvas/webgl/gl-get-calls.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ea3dd95
    • eric@webkit.org's avatar
      2010-06-11 Sheriff Bot <webkit.review.bot@gmail.com> · e5803d4e
      eric@webkit.org authored
              Unreviewed, rolling out r61036.
              http://trac.webkit.org/changeset/61036
              https://bugs.webkit.org/show_bug.cgi?id=40499
      
              broke chromium compile (Requested by jamesr on #webkit).
      
              * bindings/v8/SerializedScriptValue.cpp:
              * bindings/v8/SerializedScriptValue.h:
              (WebCore::SerializedScriptValue::deserializeAndSetProperty):
              (WebCore::SerializedScriptValue::create):
              (WebCore::SerializedScriptValue::createFromWire):
              (WebCore::SerializedScriptValue::release):
              (WebCore::SerializedScriptValue::SerializedScriptValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5803d4e
    • jamesr@google.com's avatar
      2010-06-11 James Robinson <jamesr@chromium.org> · dc5fec92
      jamesr@google.com authored
              Unreviewed baselines for new test on Qt/Gtk.
      
              https://bugs.webkit.org/show_bug.cgi?id=40456
      
              Qt and Gtk appear to produce layers of slightly different sizes
              for blocks with rounded corners, probably due to roundoff difference
              in the graphics layers.  Since the diffs are +/- 1 pixel, just
              rebaselining.
      
              * platform/gtk/fast/css/nested-rounded-corners-expected.txt: Added.
              * platform/qt/fast/css/nested-rounded-corners-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc5fec92
    • kbr@google.com's avatar
      2010-06-11 Kenneth Russell <kbr@google.com> · 607bc03d
      kbr@google.com authored
              Reviewed by Dimitri Glazkov.
      
              Add texImage2D and texSubImage2D signatures with internal format, etc.
              https://bugs.webkit.org/show_bug.cgi?id=40318
      
              Added new texImage2D and texSubImage2D entry points following
              WebGL specification changes. Added UNPACK_FLIP_Y_WEBGL and
              UNPACK_PREMULTIPLY_ALPHA_WEBGL pixelStorei parameters, honored
              them for the new entry points taking HTML elements, and added
              support to getParameter. Added warnings to the console for calls
              to the obsolete entry points, which will be removed in a few
              weeks.  Updated all layout tests to use the new entry points and
              pixelStorei parameters, and associated expectations. No other new
              tests.
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::WebGLRenderingContext):
              (WebCore::WebGLRenderingContext::getParameter):
              (WebCore::WebGLRenderingContext::pixelStorei):
              (WebCore::WebGLRenderingContext::texImage2DImpl):
              (WebCore::WebGLRenderingContext::texImage2D):
              (WebCore::WebGLRenderingContext::texSubImage2DImpl):
              (WebCore::WebGLRenderingContext::texSubImage2D):
              (WebCore::WebGLRenderingContext::printWarningToConsole):
              * html/canvas/WebGLRenderingContext.h:
              * html/canvas/WebGLRenderingContext.idl:
              * platform/graphics/GraphicsContext3D.h:
              (WebCore::GraphicsContext3D::):
      2010-06-11  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Add texImage2D and texSubImage2D signatures with internal format, etc.
              https://bugs.webkit.org/show_bug.cgi?id=40318
      
              Added new texImage2D and texSubImage2D entry points following
              WebGL specification changes. Added UNPACK_FLIP_Y_WEBGL and
              UNPACK_PREMULTIPLY_ALPHA_WEBGL pixelStorei parameters, honored
              them for the new entry points taking HTML elements, and added
              support to getParameter. Added warnings to the console for calls
              to the obsolete entry points, which will be removed in a few
              weeks. Updated all layout tests to use the new entry points and
              pixelStorei parameters, and associated expectations. No other new
              tests.
      
              * fast/canvas/webgl/bug-32364-expected.txt:
              * fast/canvas/webgl/bug-32364.html:
              * fast/canvas/webgl/bug-32888.html:
              * fast/canvas/webgl/gl-get-calls-expected.txt:
              * fast/canvas/webgl/gl-get-calls.html:
              * fast/canvas/webgl/resources/utils3d.js:
              (doLoadImageTexture):
              * fast/canvas/webgl/script-tests/texImageTest.js:
              * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt:
              * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html:
              * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt:
              * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html:
              * fast/canvas/webgl/texImage2DImageDataTest.html:
              * fast/canvas/webgl/texImageTest-expected.txt:
              * fast/canvas/webgl/texture-npot.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      607bc03d
    • zmo@google.com's avatar
    • jamesr@google.com's avatar
      2010-06-11 James Robinson <jamesr@chromium.org> · e34e2832
      jamesr@google.com authored
              Reviewed by Dimitri Glazkov.
      
              [chromium] Skia mispaints pages with border-radius
              https://bugs.webkit.org/show_bug.cgi?id=40456
      
              Skia mispaints pages that have border radius set in some cases. The bug is in the anti aliased
              clip path logic used to implement anti aliased curves in Skia.  Since Skia internally only supports
              1-bit clips, anti aliased clipping is emulated by creating a new alpha layer, storing a set of
              clip paths on the side, and then 'erasing' the regions outside the clip.  See r49641.
              PlatformContextSkia maintains a stack of PlatformContextSkia::State objects that preserve information
              like fill color, drawing mode, etc that is manipulated by GraphicsContext::save() / 
              GraphicsContext::restore() calls as well some internal functions.  Whenever a new State object is pushed
              a new copy of the current State object is pushed onto the top of this stack using the copy c'tor.  The
              set of anti alias clip paths is also stored on the State object, but not copied when new entries are
              added as the paths only apply to that entry on the stack.
      
              The bug is that the state stack is stored in a WTF::Vector.  When this vector exceeds its capacity
              (by default at 16 elements) all of the existing State entries are copied into the new buffer using
              State's copy constructor.  This does not preserve the anti alias clip paths, so when the State entries
              are popped the anti aliasing info is lost.  This corrupts all further paint operations since it results
              in inbalanced save/restore calls to the underlying SkCanvas.
      
              The fix is to make the PlatformContextSkia::State copy constructor copy all fields and to add a new
              function PlatformContextSkia::State::cloneInheritedProperties to use when pushing new State entries
              that copies everything except for the anti aliased clip paths.
      
              Test: fast/css/nested-rounded-corners.html
      
              * platform/graphics/skia/PlatformContextSkia.cpp:
              (PlatformContextSkia::State::State):
              (PlatformContextSkia::State::cloneInheritedProperties):
              (PlatformContextSkia::save):
      2010-06-11  James Robinson  <jamesr@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              [chromium] Skia mispaints pages with border-radius
              https://bugs.webkit.org/show_bug.cgi?id=40456
      
              Tests deeply nested divs with border-radius.
      
              * fast/css/nested-rounded-corners-expected.txt: Added.
              * fast/css/nested-rounded-corners.html: Added.
              * platform/chromium/test_expectations.txt
              * platform/chromium-linux/fast/css/nested-rounded-corners-expected.checksum: Added.
              * platform/chromium-linux/fast/css/nested-rounded-corners-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e34e2832
    • eric@webkit.org's avatar
      2010-06-11 Jeremy Orlow <jorlow@chromium.org> · 7f626ecf
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              [V8] Clean up SerializedScriptValue
              https://bugs.webkit.org/show_bug.cgi?id=40482
      
              SerializedScriptValue doesn't follow WebKit's style guidelines very well
              and needlessly inlines quite a bit within the .h file. This change cleans
              things up. No funcitonal changes.
      
              No change in behavior.
      
              * bindings/v8/SerializedScriptValue.cpp:
              (WebCore::SerializedScriptValue::deserializeAndSetProperty):
              (WebCore::SerializedScriptValue::create):
              (WebCore::SerializedScriptValue::createFromWire):
              (WebCore::SerializedScriptValue::release):
              (WebCore::SerializedScriptValue::SerializedScriptValue):
              * bindings/v8/SerializedScriptValue.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f626ecf
    • eric@webkit.org's avatar
      2010-06-11 James Hawkins <jhawkins@chromium.org> · e95bdbf5
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              [Chromium] Notify the WebView when the AutoFill popup hides.
      
              https://bugs.webkit.org/show_bug.cgi?id=40459
      
              * src/AutoFillPopupMenuClient.cpp:
              (WebKit::AutoFillPopupMenuClient::selectionCleared):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e95bdbf5
    • eric@webkit.org's avatar
      2010-06-11 Jesus Sanchez-Palencia <jesus@webkit.org> · b73a2249
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Typo error in QWebPluginFactory Documentation
              https://bugs.webkit.org/show_bug.cgi?id=40490
      
              * Api/qwebpluginfactory.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b73a2249
    • eric@webkit.org's avatar
      2010-06-11 Eric Seidel <eric@webkit.org> · 65a32cf7
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              tables/mozilla/bugs/bug1188.html needlessly depends on HTML Parser text node handling
              https://bugs.webkit.org/show_bug.cgi?id=40485
      
              The old HTMLTokenizer handled invalid close tags like "< /A>" as part
              of the lexing step.  The HTML5 parser specification dictates that
              the tokenization/lexing step is to output each character token in sequence
              and that the parser is to insert emitted character tokens into the last
              parser-created text node.  In our current HTML5Lexer-with-old-HTMLParser
              setup, we gather up character tokens and output them all in one bunch
              (to match the expectations of the old parser).
      
              In the case of "foo< /A>" the HTML5Lexer sees the '<', switched out of the
              "data" state and emits all pending characters assuming the start of a close tag.
              When it sees the ' ' it switches back to the "data" state.  The HTML5Lexer
              expects that the parser will coalesce the separate characters it emitted
              into one text node.  Since we haven't implemented the parser side of the
              HTML5 spec, for now we don't.  This is a known issue we will address after
              enabling the HTML5Lexer, as we start to write an HTML5-compliant parser.
      
              This text-node-coalescing behavior is already tested by numerous html5lib
              tests, however this was the only layout test which hit this quirk.  I've
              added yet another html5lib test of this exact case just for good measure.
      
              * html5lib/resources/webkit01.dat:
               - Add a test of this exact case to make sure we don't miss it when implementing
                 an HTML5-compliant parser.
              * tables/mozilla/bugs/bug1188.html:
               - Replace "< /A>" with "&lt /A>" to avoid hitting this lexing quirk.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65a32cf7
    • eric@webkit.org's avatar
      2010-06-11 Tony Gentilcore <tonyg@chromium.org> · d57a013b
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Roll chromium DEPS 49376:49521
              https://bugs.webkit.org/show_bug.cgi?id=40488
      
              * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d57a013b
    • eric@webkit.org's avatar
      2010-06-11 Anton Muhin <antonm@chromium.org> · b597969d
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              [v8] Introduce single element caches for WebCore::String to v8::String conversions
              https://bugs.webkit.org/show_bug.cgi?id=40435
              Measurements show that for some web apps (GMail, Wave) and some scenarios
              (intensive reading and/or keeping a tab open for a long time),
              hit rate lies in 30--50% interval.
              Inlining fast case gives another minor performance win.
      
              * bindings/v8/V8Binding.cpp:
              (WebCore::getStringCache):
              (WebCore::v8ExternalStringSlow):
              * bindings/v8/V8Binding.h:
              (WebCore::v8ExternalString):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b597969d
    • eric@webkit.org's avatar
      2010-06-11 Leandro Pereira <leandro@profusion.mobi> · 7a9771ca
      eric@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              [EFL] Build fix: remove unneeded file (npapi.cpp) and add
              other files that got added to the tree.
              http://webkit.org/b/40331
      
              * CMakeLists.txt:
              * CMakeListsEfl.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a9771ca
    • dimich@chromium.org's avatar
      Unreviewed, update Chromium test expectations. · 711c2bc1
      dimich@chromium.org authored
      * platform/chromium/test_expectations.txt:
      http://trac.webkit.org/changeset/60999 regressed acid3.html image match on Chromium Mac.
      http://trac.webkit.org/changeset/61020 modified get-active-test.html that now fails on Chromium Mac.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      711c2bc1
    • eric@webkit.org's avatar
      2010-06-11 Tony Gentilcore <tonyg@chromium.org> · d4c31dd0
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Fix fast/forms/preserveFormDuringResidualStyle.html for HTML5 Parser.
              https://bugs.webkit.org/show_bug.cgi?id=40454
      
              This required exposing the HTMLParser which we definitely don't want to
              do, but the good news is that it can go away when the HTMLParser goes
              away.
      
              No new tests because covered by fast/forms/preserve/FormDuringResidualStyle.html.
      
              * dom/Tokenizer.h:
              (WebCore::Tokenizer::htmlParser):
              * html/HTML5Tokenizer.cpp:
              (WebCore::HTML5Tokenizer::htmlParser):
              * html/HTML5Tokenizer.h:
              * html/HTML5TreeBuilder.h:
              (WebCore::HTML5TreeBuilder::htmlParser):
              * html/HTMLFormControlElement.cpp:
              (WebCore::HTMLFormControlElement::removedFromTree):
              * html/HTMLTokenizer.h:
              (WebCore::HTMLTokenizer::htmlParser):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4c31dd0
    • kbr@google.com's avatar
      2010-06-11 Kenneth Russell <kbr@google.com> · 6a0c5800
      kbr@google.com authored
              Reviewed by Dimitri Glazkov.
      
              Delete custom JSC bindings for bufferData, texImage2D and texSubImage2D
              https://bugs.webkit.org/show_bug.cgi?id=40443
      
              Deleted custom JSC bindings for bufferData, texImage2D and
              texSubImage2D and fixed minor associated issues in code generator
              and IDL. Updated fast/canvas/webgl/texImageTest-expected.txt,
              which now runs as intended. Ran all layout tests, including WebGL
              tests, in Safari.
      
              * bindings/js/JSWebGLRenderingContextCustom.cpp:
               - Deleted custom bindings.
              * bindings/scripts/CodeGeneratorJS.pm:
               - Made overload helper functions static to fix compiler warnings.
               - Added needed isObject check for overloads between object and non-object arguments.
               - Added JSValue::encode to exception return path, needed on Leopard in particular.
              * html/HTMLCanvasElement.idl:
              * html/HTMLImageElement.idl:
              * html/HTMLVideoElement.idl:
               - Added GenerateNativeConverter extended attribute.
              * html/canvas/WebGLRenderingContext.idl:
               - Deleted #ifdefs for custom JSC bindings.
      2010-06-11  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Delete custom JSC bindings for bufferData, texImage2D and texSubImage2D
              https://bugs.webkit.org/show_bug.cgi?id=40443
      
              Deleted custom JSC bindings for bufferData, texImage2D and
              texSubImage2D and fixed minor associated issues in code generator
              and IDL. Updated fast/canvas/webgl/texImageTest-expected.txt,
              which now runs as intended. Ran all layout tests, including WebGL
              tests, in Safari.
      
              * fast/canvas/webgl/script-tests/texImageTest.js:
              * fast/canvas/webgl/texImageTest-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a0c5800
    • ap@apple.com's avatar
      Written by Dave Moore <davemoore@google.com>. · 7d23e361
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=22741
              innerHTML, forms and images don't play well together
      
              This was fixed already (in bug 34076), just landing an additional test.
      
              * fast/forms/form-image-access-by-name-expected.txt: Added.
              * fast/forms/form-image-access-by-name.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d23e361
    • kevino@webkit.org's avatar
      5266e5af
    • ojan@chromium.org's avatar
      2010-06-10 Ojan Vafai <ojan@chromium.org> · 99a68f68
      ojan@chromium.org authored
              Reviewed by Darin Fisher.
      
              Fix rietveld upload when message length > 100 characters
              https://bugs.webkit.org/show_bug.cgi?id=40457
      
              * Scripts/webkitpy/common/net/rietveld.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99a68f68
    • eric@webkit.org's avatar
      2010-06-11 Hans Wennborg <hans@chromium.org> · 5776947b
      eric@webkit.org authored
              Reviewed by Jeremy Orlow.
      
              DOM storage should only create databases when needed
              https://bugs.webkit.org/show_bug.cgi?id=40301
      
              As soon as a page attempts to use localstorage, StorageAreaSync will
              create an empty database if one doesn't already exist. This can lead to
              lots of unnecessary database files. In particular, they are created
              even when the privacy settings or private browsing mode disallow
              localstorage data, which may seem odd to the user.
      
              Database creation should be put off in StorageAreaSync until it is time
              to actually write something to the database.
      
              Tests:
               manual-tests/localstorage-empty-database.html
      
              * manual-tests/localstorage-empty-database.html: Added.
              * storage/StorageAreaSync.cpp:
              (WebCore::StorageAreaSync::StorageAreaSync):
              (WebCore::StorageAreaSync::openDatabase):
              (WebCore::StorageAreaSync::performImport):
              (WebCore::StorageAreaSync::sync):
              * storage/StorageAreaSync.h:
              (WebCore::StorageAreaSync::):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5776947b
    • eric@webkit.org's avatar
      2010-06-11 Ilya Tikhonovsky <loislo@chromium.org> · 1bf6eb7d
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Perl scripts for bindings don't use strict keyword.
              As result some problems in the script code were not detected at compile stage.
              https://bugs.webkit.org/show_bug.cgi?id=40468
      
              * bindings/scripts/CodeGenerator.pm:
              * bindings/scripts/IDLParser.pm:
              * bindings/scripts/IDLStructure.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bf6eb7d
    • eric@webkit.org's avatar
      2010-06-11 Eric Seidel <eric@webkit.org> · 2d45ae78
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              HTML5Tokenizer should not delete itself while running scripts
              https://bugs.webkit.org/show_bug.cgi?id=40458
      
              Tested by fast/dom/document-clear.html
      
              * html/HTML5Tokenizer.cpp:
              (WebCore::HTML5Tokenizer::attemptToEnd):
               - Don't ever end() while running scripts.
                 This matches the old HTMLTokenizer.cpp
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d45ae78
    • eric@webkit.org's avatar
      2010-06-11 Zhenyao Mo <zmo@google.com> · 7278aaef
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              getActiveUniform must ensure names of arrays end in "[0]"
              https://bugs.webkit.org/show_bug.cgi?id=38709
      
              * fast/canvas/webgl/get-active-test-expected.txt: Copied from LayoutTests/fast/canvas/webgl/getActiveTest-expected.txt, modified to test array names.
              * fast/canvas/webgl/get-active-test.html: Copied from LayoutTests/fast/canvas/webgl/getActiveTest.html.
              * fast/canvas/webgl/getActiveTest-expected.txt: Removed.
              * fast/canvas/webgl/getActiveTest.html: Removed.
              * fast/canvas/webgl/resources/intArrayUniformShader.vert: Added, with array uniform.
              * fast/canvas/webgl/script-tests/get-active-test.js: Copied from LayoutTests/fast/canvas/webgl/script-tests/getActiveTest.js, modified to test array names.
              * fast/canvas/webgl/script-tests/getActiveTest.js: Removed.
      2010-06-11  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              getActiveUniform must ensure names of arrays end in "[0]"
              https://bugs.webkit.org/show_bug.cgi?id=38709
      
              Test: fast/canvas/webgl/get-active-test.html
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::getActiveAttrib): Append "[0]" to the name if needed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7278aaef
    • eric@webkit.org's avatar
      2010-06-11 Zhenyao Mo <zmo@google.com> · 7198759c
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              readPixels with negative width/height should generate INVALID_VALUE and return
              https://bugs.webkit.org/show_bug.cgi?id=39704
      
              * fast/canvas/webgl/read-pixels-expected.txt: Add test cases for non-positive width/height.
              * fast/canvas/webgl/read-pixels.html: Ditto.
      2010-06-11  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              readPixels with negative width/height should generate INVALID_VALUE and return
              https://bugs.webkit.org/show_bug.cgi?id=39704
      
              * html/canvas/WebGLRenderingContext.cpp: Deal with negative width/height.
              (WebCore::WebGLRenderingContext::readPixels):
              * html/canvas/WebGLRenderingContext.h: Change width/height type from unsigned long to long.
              * html/canvas/WebGLRenderingContext.idl: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7198759c
    • eric@webkit.org's avatar
      2010-06-11 Zhenyao Mo <zmo@google.com> · 8e3f63ce
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              uniform* entry points must ignore the call if a null WebGLUniformLocation is passed
              https://bugs.webkit.org/show_bug.cgi?id=38707
      
              * fast/canvas/webgl/null-uniform-location-expected.txt: No error is generated if a null WebGLUniformLocation is passed to uniform*().
              * fast/canvas/webgl/script-tests/null-uniform-location.js: Ditto.
              * fast/canvas/webgl/script-tests/uniform-location.js: Ditto.
              * fast/canvas/webgl/uniform-location-expected.txt: Ditto.
      2010-06-11  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              uniform* entry points must ignore the call if a null WebGLUniformLocation is passed
              https://bugs.webkit.org/show_bug.cgi?id=38707
      
              * html/canvas/WebGLRenderingContext.cpp: uniform* entry points ignore the call if a null WebGLUniformLocation is passed.
              (WebCore::WebGLRenderingContext::uniform1f):
              (WebCore::WebGLRenderingContext::uniform1fv):
              (WebCore::WebGLRenderingContext::uniform1i):
              (WebCore::WebGLRenderingContext::uniform1iv):
              (WebCore::WebGLRenderingContext::uniform2f):
              (WebCore::WebGLRenderingContext::uniform2fv):
              (WebCore::WebGLRenderingContext::uniform2i):
              (WebCore::WebGLRenderingContext::uniform2iv):
              (WebCore::WebGLRenderingContext::uniform3f):
              (WebCore::WebGLRenderingContext::uniform3fv):
              (WebCore::WebGLRenderingContext::uniform3i):
              (WebCore::WebGLRenderingContext::uniform3iv):
              (WebCore::WebGLRenderingContext::uniform4f):
              (WebCore::WebGLRenderingContext::uniform4fv):
              (WebCore::WebGLRenderingContext::uniform4i):
              (WebCore::WebGLRenderingContext::uniform4iv):
              (WebCore::WebGLRenderingContext::uniformMatrix2fv):
              (WebCore::WebGLRenderingContext::uniformMatrix3fv):
              (WebCore::WebGLRenderingContext::uniformMatrix4fv):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e3f63ce
    • eric@webkit.org's avatar
      2010-06-11 Zhenyao Mo <zmo@google.com> · 214cd521
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              drawElements/drawArrays should validate input parameters according to GLES2 spec
              https://bugs.webkit.org/show_bug.cgi?id=38700
      
              * fast/canvas/webgl/draw-arrays-out-of-bounds-expected.txt: Copied from LayoutTests/fast/canvas/webgl/drawArraysOutOfBounds-expected.txt, and fix a few test cases.
              * fast/canvas/webgl/draw-arrays-out-of-bounds.html: Copied from LayoutTests/fast/canvas/webgl/drawArraysOutOfBounds.html, and fix a few test cases.
              * fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt: Copied from LayoutTests/fast/canvas/webgl/drawElementssOutOfBounds-expected.txt, and fix a few test cases.
              * fast/canvas/webgl/draw-elements-out-of-bounds.html: Copied from LayoutTests/fast/canvas/webgl/drawElementssOutOfBounds.html, and fix a few test cases.
              * fast/canvas/webgl/drawArraysOutOfBounds-expected.txt: Removed.
              * fast/canvas/webgl/drawArraysOutOfBounds.html: Removed.
              * fast/canvas/webgl/drawElementssOutOfBounds-expected.txt: Removed.
              * fast/canvas/webgl/drawElementssOutOfBounds.html: Removed.
              * fast/canvas/webgl/resources/webgl-test.js: Add helper functions for easy test of gl function errors.
              (getGLErrorAsString):
              (shouldGenerateGLError):
      2010-06-11  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              drawElements/drawArrays should validate input parameters according to GLES2 spec
              https://bugs.webkit.org/show_bug.cgi?id=38700
      
              Tests: fast/canvas/webgl/draw-arrays-out-of-bounds.html
                     fast/canvas/webgl/draw-elements-out-of-bounds.html
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::drawArrays): Validate input parameters.
              (WebCore::WebGLRenderingContext::drawElements): Ditto.
              (WebCore::WebGLRenderingContext::validateDrawMode): Validate mode for draw{Arrays/Elements}.
              * html/canvas/WebGLRenderingContext.h: Add validateDrawMode, fix incorrect parameter types.
              * html/canvas/WebGLRenderingContext.idl: Fix incorrect parameter types.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      214cd521
    • eric@webkit.org's avatar
      2010-06-11 Luiz Agostini <luiz.agostini@openbossa.org>, Kenneth Rohde... · a4343b76
      eric@webkit.org authored
      2010-06-11  Luiz Agostini  <luiz.agostini@openbossa.org>, Kenneth Rohde Christiansen <kenneth@webkit.org>
      
              Reviewed by Antti Koivisto.
      
              CSS3 Media Queries are not serialized according to CSSOM
              https://bugs.webkit.org/show_bug.cgi?id=39220
      
              Added test for testing the serialization, plus updated current
              tests to take serialization into account.
      
              * fast/css/insertRule-media-expected.txt:
              * fast/css/insertRule-media.html:
              * fast/css/resources/insertRule-media.js:
              * fast/media/media-query-serialization-expected.txt: Added.
              * fast/media/media-query-serialization.html: Added.
      2010-06-11  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Antti Koivisto.
      
              CSS3 Media Queries are not serialized according to CSSOM
              https://bugs.webkit.org/show_bug.cgi?id=39220
      
              MediaQuery serialization according to specification
              http://dev.w3.org/csswg/cssom/#serializing-media-queries.
      
              MediaQuery objects now ignore duplicated expressions. MediaQueryEvaluator::eval()
              now does not proccess MediaQuery objects that are known to be invalid.
      
              Test: fast/media/media-query-serialization.html
      
              * css/MediaQuery.cpp:
              (WebCore::stringCompare):
              (WebCore::MediaQuery::serialize):
              (WebCore::MediaQuery::MediaQuery):
              (WebCore::MediaQuery::~MediaQuery):
              (WebCore::MediaQuery::operator==):
              (WebCore::MediaQuery::cssText):
              (WebCore::MediaQuery::append):
              * css/MediaQuery.h:
              (WebCore::MediaQuery::ignored):
              (WebCore::MediaQuery::begin):
              (WebCore::MediaQuery::end):
              * css/MediaQueryExp.cpp:
              (WebCore::MediaQueryExp::serialize):
              * css/MediaQueryExp.h:
              * css/MediaQueryEvaluator.cpp:
              (WebCore::MediaQueryEvaluator::eval):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4343b76
    • jorlow@chromium.org's avatar
      2010-06-10 Jeremy Orlow <jorlow@chromium.org> · dd927772
      jorlow@chromium.org authored
              Reviewed by Steve Block.
      
              Implement more of IndexedDB's Indexes and ObjectStores
              https://bugs.webkit.org/show_bug.cgi?id=40424
      
              Clean up both of these classes a bit and add create/open/remove
              methods as needed.
      
              Tests in a future patch (promise).
      
              * storage/IDBDatabase.h:
              * storage/IDBDatabaseImpl.cpp:
              (WebCore::IDBDatabaseImpl::objectStores):
              (WebCore::IDBDatabaseImpl::createObjectStore):
              (WebCore::IDBDatabaseImpl::objectStore):
              (WebCore::IDBDatabaseImpl::removeObjectStore):
              * storage/IDBDatabaseImpl.h:
              (WebCore::IDBDatabaseImpl::name):
              (WebCore::IDBDatabaseImpl::description):
              (WebCore::IDBDatabaseImpl::version):
              * storage/IDBDatabaseRequest.cpp:
              (WebCore::IDBDatabaseRequest::IDBDatabaseRequest):
              (WebCore::IDBDatabaseRequest::createObjectStore):
              (WebCore::IDBDatabaseRequest::objectStore):
              (WebCore::IDBDatabaseRequest::removeObjectStore):
              * storage/IDBDatabaseRequest.h:
              (WebCore::IDBDatabaseRequest::create):
              (WebCore::IDBDatabaseRequest::name):
              (WebCore::IDBDatabaseRequest::description):
              (WebCore::IDBDatabaseRequest::version):
              (WebCore::IDBDatabaseRequest::objectStores):
              * storage/IDBDatabaseRequest.idl:
              * storage/IDBObjectStore.h:
              * storage/IDBObjectStoreImpl.h:
              * storage/IDBObjectStoreRequest.cpp:
              (WebCore::IDBObjectStoreRequest::get):
              (WebCore::IDBObjectStoreRequest::add):
              (WebCore::IDBObjectStoreRequest::modify):
              (WebCore::IDBObjectStoreRequest::addOrModify):
              (WebCore::IDBObjectStoreRequest::remove):
              (WebCore::IDBObjectStoreRequest::createIndex):
              (WebCore::IDBObjectStoreRequest::index):
              (WebCore::IDBObjectStoreRequest::removeIndex):
              * storage/IDBObjectStoreRequest.h:
              * storage/IDBObjectStoreRequest.idl:
      2010-06-10  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Steve Block.
      
              Implement more of IndexedDB's Indexes and ObjectStores
              https://bugs.webkit.org/show_bug.cgi?id=40424
      
              Add plumbing for both of these classes.
      
              * public/WebIDBDatabase.h:
              (WebKit::WebIDBDatabase::name):
              (WebKit::WebIDBDatabase::description):
              (WebKit::WebIDBDatabase::version):
              (WebKit::WebIDBDatabase::objectStores):
              (WebKit::WebIDBDatabase::objectStore):
              (WebKit::WebIDBDatabase::removeObjectStore):
              * public/WebIDBObjectStore.h:
              (WebKit::WebIDBObjectStore::indexNames):
              (WebKit::WebIDBObjectStore::createIndex):
              (WebKit::WebIDBObjectStore::index):
              (WebKit::WebIDBObjectStore::removeIndex):
              * src/IDBDatabaseProxy.cpp:
              (WebCore::IDBDatabaseProxy::name):
              (WebCore::IDBDatabaseProxy::description):
              (WebCore::IDBDatabaseProxy::version):
              (WebCore::IDBDatabaseProxy::objectStores):
              (WebCore::IDBDatabaseProxy::objectStore):
              (WebCore::IDBDatabaseProxy::removeObjectStore):
              * src/IDBDatabaseProxy.h:
              * src/IDBObjectStoreProxy.cpp:
              (WebCore::IDBObjectStoreProxy::indexNames):
              (WebCore::IDBObjectStoreProxy::createIndex):
              (WebCore::IDBObjectStoreProxy::index):
              (WebCore::IDBObjectStoreProxy::removeIndex):
              * src/IDBObjectStoreProxy.h:
              * src/WebIDBDatabaseImpl.cpp:
              (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
              (WebKit::WebIDBDatabaseImpl::name):
              (WebKit::WebIDBDatabaseImpl::description):
              (WebKit::WebIDBDatabaseImpl::version):
              (WebKit::WebIDBDatabaseImpl::objectStores):
              (WebKit::WebIDBDatabaseImpl::createObjectStore):
              (WebKit::WebIDBDatabaseImpl::objectStore):
              (WebKit::WebIDBDatabaseImpl::removeObjectStore):
              * src/WebIDBDatabaseImpl.h:
              * src/WebIDBObjectStoreImpl.cpp:
              (WebKit::WebIDBObjectStoreImpl::WebIDBObjectStoreImpl):
              (WebKit::WebIDBObjectStoreImpl::name):
              (WebKit::WebIDBObjectStoreImpl::keyPath):
              (WebKit::WebIDBObjectStoreImpl::indexNames):
              (WebKit::WebIDBObjectStoreImpl::createIndex):
              (WebKit::WebIDBObjectStoreImpl::index):
              (WebKit::WebIDBObjectStoreImpl::removeIndex):
              * src/WebIDBObjectStoreImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd927772
    • apavlov@chromium.org's avatar
      2010-06-11 Alexander Pavlov <apavlov@chromium.org> · b3424550
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Enable serialization/deserialization of the frontend state
              https://bugs.webkit.org/show_bug.cgi?id=40228
      
              WebCore:
              * inspector/InspectorBackend.cpp:
              (WebCore::InspectorBackend::saveApplicationSettings):
              (WebCore::InspectorBackend::saveSessionSettings):
              * inspector/InspectorBackend.h:
              * inspector/InspectorBackend.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::setSessionSettings):
              (WebCore::InspectorController::populateScriptObjects):
              (WebCore::InspectorController::didCommitLoad):
              * inspector/InspectorController.h:
              * inspector/InspectorFrontend.cpp:
              (WebCore::InspectorFrontend::populateApplicationSettings):
              (WebCore::InspectorFrontend::populateSessionSettings):
              * inspector/InspectorFrontend.h:
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype._settingsLoaded):
              (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult):
              (WebInspector.ConsoleView.prototype._enterKeyPressed):
              * inspector/front-end/EventListenersSidebarPane.js:
              (WebInspector.EventListenersSidebarPane.prototype._settingsLoaded):
              (WebInspector.EventListenersSidebarPane.prototype):
              ():
              * inspector/front-end/InspectorBackendStub.js:
              (.WebInspector.InspectorBackendStub.prototype.saveApplicationSettings):
              (.WebInspector.InspectorBackendStub.prototype.saveSessionSettings):
              * inspector/front-end/ResourceView.js:
              (WebInspector.ResourceView.prototype._selectTab):
              (WebInspector.ResourceView.prototype._selectHeadersTab):
              (WebInspector.ResourceView.prototype.selectContentTab):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel.prototype._createStatusbarButtons):
              (WebInspector.ResourcesPanel.prototype._settingsLoaded):
              (WebInspector.ResourcesPanel.prototype._toggleLargerResources):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
              (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
              * inspector/front-end/Settings.js:
              (WebInspector.populateApplicationSettings):
              (WebInspector.populateSessionSettings):
              (WebInspector.Settings):
              (WebInspector.Settings.prototype.reset):
              (WebInspector.Settings.prototype._load):
              (WebInspector.Settings.prototype._set):
              * inspector/front-end/StylesSidebarPane.js:
              (WebInspector.StylesSidebarPane.prototype._settingsLoaded):
              (WebInspector.StylesSidebarPane.prototype.update):
              (WebInspector.StylesSidebarPane.prototype._changeSetting):
              (WebInspector.StylesSidebarPane.prototype._changeColorFormat):
              (WebInspector.ComputedStyleSidebarPane.settingsLoaded):
              (WebInspector.ComputedStyleSidebarPane.showInheritedToggleFunction):
              (WebInspector.ComputedStyleSidebarPane):
              * inspector/front-end/WatchExpressionsSidebarPane.js:
              (WebInspector.WatchExpressionsSidebarPane):
              (WebInspector.WatchExpressionsSidebarPane.prototype._settingsLoaded):
              (WebInspector.WatchExpressionsSection):
              (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
              * inspector/front-end/inspector.js:
              (WebInspector.loaded):
              (WebInspector.reset):
      
              Webkit/chromium:
              * src/js/InspectorControllerImpl.js:
              (devtools.InspectorBackendImpl):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3424550
    • pfeldman@chromium.org's avatar
      2010-06-10 S√∏ren Gjesse <sgjesse@chromium.org> · abb198ef
      pfeldman@chromium.org authored
              Reviewed by Pavel Feldman.
      
              V8: Chromium test expectations not matching improved V8 JavaScript stepping
              https://bugs.webkit.org/show_bug.cgi?id=40419
      
              Update test expetations to match chaged V8 break locations.
      
              * src/js/Tests.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abb198ef
    • pfeldman@chromium.org's avatar
      2010-06-10 Pavel Feldman <pfeldman@chromium.org> · acdf1aad
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Port performSearch from InjectedScript to InspectorDOMAgent.
      
              https://bugs.webkit.org/show_bug.cgi?id=40422
      
              * inspector/InjectedScriptHost.cpp:
              (WebCore::InjectedScriptHost::addNodesToSearchResult):
              * inspector/InspectorBackend.cpp:
              (WebCore::InspectorBackend::performSearch):
              (WebCore::InspectorBackend::searchCanceled):
              * inspector/InspectorBackend.h:
              * inspector/InspectorBackend.idl:
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::):
              (WebCore::InspectorDOMAgent::InspectorDOMAgent):
              (WebCore::InspectorDOMAgent::~InspectorDOMAgent):
              (WebCore::InspectorDOMAgent::performSearch):
              (WebCore::InspectorDOMAgent::searchCanceled):
              (WebCore::InspectorDOMAgent::onMatchJobsTimer):
              (WebCore::InspectorDOMAgent::reportNodesAsSearchResults):
              * inspector/InspectorDOMAgent.h:
              (WebCore::MatchJob::~MatchJob):
              (WebCore::MatchJob::MatchJob):
              (WebCore::MatchJob::addNodesToResults):
              * inspector/InspectorFrontend.cpp:
              (WebCore::InspectorFrontend::addNodesToSearchResult):
              * inspector/InspectorFrontend.h:
              * inspector/InspectorResource.cpp:
              (WebCore::InspectorResource::updateScriptObject):
              * inspector/front-end/ElementsPanel.js:
              (WebInspector.ElementsPanel.prototype.searchCanceled):
              (WebInspector.ElementsPanel.prototype.performSearch):
              (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
              * inspector/front-end/InjectedScript.js:
              (injectedScriptConstructor):
              * inspector/front-end/InjectedScriptAccess.js:
      2010-06-10  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Port performSearch from InjectedScript to InspectorDOMAgent.
      
              https://bugs.webkit.org/show_bug.cgi?id=40422
      
              * src/js/InspectorControllerImpl.js:
              (devtools.InspectorBackendImpl):
      2010-06-10  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Port performSearch from InjectedScript to InspectorDOMAgent.
      
              https://bugs.webkit.org/show_bug.cgi?id=40422
      
              * inspector/elements-panel-search.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      acdf1aad
    • mnaganov@chromium.org's avatar
      2010-06-11 Mikhail Naganov <mnaganov@chromium.org> · 5de3048d
      mnaganov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              [Chromium] Restore 'console.profiles' access.
      
              https://bugs.webkit.org/show_bug.cgi?id=39840
      
              * bindings/v8/ScriptProfiler.cpp:
              (WebCore::ScriptProfiler::stop):
              * bindings/v8/custom/V8ConsoleCustom.cpp:
              (WebCore::V8Console::profilesAccessorGetter):
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::stopUserInitiatedProfiling):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5de3048d
    • pfeldman@chromium.org's avatar
      2010-06-07 Pavel Feldman <pfeldman@chromium.org> · 9981d8af
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: add a test for dumping global object in the console.
      
              https://bugs.webkit.org/show_bug.cgi?id=40241
      
              * http/tests/inspector/inspector-test.js:
              (frontend_dumpTreeOutline):
              (frontend_dumpTreeItem):
              * inspector/console-dir-global-expected.txt: Added.
              * inspector/console-dir-global.html: Added.
              * inspector/elements-tests.js:
              (frontend_dumpStyleTreeItem):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9981d8af
    • pfeldman@chromium.org's avatar
      2010-06-10 Nikita Vasilyev <me@elv1s.ru> · aebfa8a0
      pfeldman@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Make a close brace in Styles pane selectable.
              https://bugs.webkit.org/show_bug.cgi?id=40157
      
              * inspector/front-end/inspector.css:
              (.styles-selector):
              (.styles-section .properties li):
              (.styles-section):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aebfa8a0