1. 15 Nov, 2011 40 commits
    • commit-queue@webkit.org's avatar
      REGRESSION (r91125): Polyline tool in google docs is broken · 747b3304
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65796
      
      This adds test to ensure that the bug does not reappear unnoticed.
      
      Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-15
      Reviewed by Nikolas Zimmermann.
      
      * svg/custom/zero-path-square-cap-rendering3-expected.png: Added.
      * svg/custom/zero-path-square-cap-rendering3-expected.txt: Added.
      * svg/custom/zero-path-square-cap-rendering3.svg: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      747b3304
    • andersca@apple.com's avatar
      HostWindow invalidation functions should use root view coordinates · fdd25eb3
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=72338
      
      Reviewed by Dan Bernstein.
      
      Source/WebCore:
      
      Rename invalidateWindow to invalidateRootView, and invalidateContentsAndWindow
      to invalidateContentsAndRootView. Make sure that the rects passed to the renamed functions
      are in root view coordinates by changing contentsToWindow calls to contentsToRootView.
      
      In practice this doesn't matter because for all platforms except Mac WebKit1, root view coordinates
      and window coordinates are equivalent, and Mac WebKit1 doesn't use these invalidation functions.
      
      * loader/EmptyClients.h:
      * page/Chrome.cpp:
      (WebCore::Chrome::invalidateRootView):
      (WebCore::Chrome::invalidateContentsAndRootView):
      * page/Chrome.h:
      * page/ChromeClient.h:
      * page/Frame.cpp:
      (WebCore::Frame::tiledBackingStorePaintEnd):
      * page/FrameView.cpp:
      (WebCore::FrameView::invalidateRect):
      (WebCore::FrameView::scrollContentsFastPath):
      * platform/HostWindow.h:
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::rectToCopyOnScroll):
      (WebCore::ScrollView::scrollContents):
      (WebCore::ScrollView::wheelEvent):
      * platform/chromium/FramelessScrollView.cpp:
      (WebCore::FramelessScrollView::invalidateRect):
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImageChromeClient::invalidateContentsAndRootView):
      
      Source/WebKit/chromium:
      
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::invalidateRootView):
      (WebKit::ChromeClientImpl::invalidateContentsAndRootView):
      (WebKit::ChromeClientImpl::invalidateContentsForSlowScroll):
      * src/ChromeClientImpl.h:
      * src/WebPopupMenuImpl.cpp:
      (WebKit::WebPopupMenuImpl::invalidateRootView):
      (WebKit::WebPopupMenuImpl::invalidateContentsAndRootView):
      (WebKit::WebPopupMenuImpl::invalidateContentsForSlowScroll):
      * src/WebPopupMenuImpl.h:
      
      Source/WebKit/efl:
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::invalidateRootView):
      (WebCore::ChromeClientEfl::invalidateContentsAndRootView):
      (WebCore::ChromeClientEfl::invalidateContentsForSlowScroll):
      * WebCoreSupport/ChromeClientEfl.h:
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::invalidateRootView):
      (WebKit::ChromeClient::invalidateContentsAndRootView):
      (WebKit::ChromeClient::invalidateContentsForSlowScroll):
      * WebCoreSupport/ChromeClientGtk.h:
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::invalidateRootView):
      (WebChromeClient::invalidateContentsAndRootView):
      (WebChromeClient::invalidateContentsForSlowScroll):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::invalidateRootView):
      (WebCore::ChromeClientQt::invalidateContentsAndRootView):
      (WebCore::ChromeClientQt::invalidateContentsForSlowScroll):
      * WebCoreSupport/ChromeClientQt.h:
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::invalidateRootView):
      (WebChromeClient::invalidateContentsAndRootView):
      * WebCoreSupport/WebChromeClient.h:
      
      Source/WebKit/wince:
      
      * WebCoreSupport/ChromeClientWinCE.cpp:
      (WebKit::ChromeClientWinCE::invalidateRootView):
      (WebKit::ChromeClientWinCE::invalidateContentsAndRootView):
      (WebKit::ChromeClientWinCE::invalidateContentsForSlowScroll):
      (WebKit::ChromeClientWinCE::scroll):
      * WebCoreSupport/ChromeClientWinCE.h:
      
      Source/WebKit/wx:
      
      * WebKitSupport/ChromeClientWx.cpp:
      (WebCore::ChromeClientWx::invalidateRootView):
      (WebCore::ChromeClientWx::invalidateContentsForSlowScroll):
      (WebCore::ChromeClientWx::invalidateContentsAndRootView):
      * WebKitSupport/ChromeClientWx.h:
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::invalidateRootView):
      (WebKit::WebChromeClient::invalidateContentsAndRootView):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdd25eb3
    • arv@chromium.org's avatar
      Fix invalid markup in some tests · 20e19320
      arv@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72391
      
      Reviewed by Ojan Vafai.
      
      These tests had <div id="console"></p> in them which causes a lot of extra whitespace.
      
      * fast/dom/HTMLElement/attr-dir-auto-change-before-text-node-expected.txt:
      * fast/dom/HTMLElement/attr-dir-auto-change-before-text-node.html:
      * fast/dom/HTMLElement/attr-dir-auto-change-child-node-expected.txt:
      * fast/dom/HTMLElement/attr-dir-auto-change-child-node.html:
      * fast/dom/HTMLElement/attr-dir-auto-change-text-expected.txt:
      * fast/dom/HTMLElement/attr-dir-auto-change-text-form-control-expected.txt:
      * fast/dom/HTMLElement/attr-dir-auto-change-text-form-control.html:
      * fast/dom/HTMLElement/attr-dir-auto-change-text.html:
      * fast/dom/HTMLElement/attr-dir-auto-children-expected.txt:
      * fast/dom/HTMLElement/attr-dir-auto-children.html:
      * fast/dom/HTMLElement/attr-dir-auto-expected.txt:
      * fast/dom/HTMLElement/attr-dir-auto-remove-add-children-expected.txt:
      * fast/dom/HTMLElement/attr-dir-auto-remove-add-children.html:
      * fast/dom/HTMLElement/attr-dir-auto-text-form-control-child-expected.txt:
      * fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html:
      * fast/dom/HTMLElement/attr-dir-auto-text-form-control-expected.txt:
      * fast/dom/HTMLElement/attr-dir-auto-text-form-control.html:
      * fast/dom/HTMLElement/attr-dir-auto.html:
      * fast/dom/HTMLElement/attr-dir-value-change-expected.txt:
      * fast/dom/HTMLElement/attr-dir-value-change.html:
      * fast/dom/HTMLElement/attr-empty-string-expected.txt:
      * fast/dom/HTMLElement/attr-empty-string.html:
      * fast/dom/HTMLElement/attr-false-string-expected.txt:
      * fast/dom/HTMLElement/attr-false-string.html:
      * fast/dom/HTMLElement/attr-invalid-string-expected.txt:
      * fast/dom/HTMLElement/attr-invalid-string.html:
      * fast/dom/HTMLElement/attr-missing-ancestor-false-expected.txt:
      * fast/dom/HTMLElement/attr-missing-ancestor-false.html:
      * fast/dom/HTMLElement/attr-missing-ancestor-true-expected.txt:
      * fast/dom/HTMLElement/attr-missing-ancestor-true.html:
      * fast/dom/HTMLElement/attr-missing-parent-ancestor-missing-expected.txt:
      * fast/dom/HTMLElement/attr-missing-parent-ancestor-missing.html:
      * fast/dom/HTMLElement/attr-missing-parent-false-expected.txt:
      * fast/dom/HTMLElement/attr-missing-parent-false.html:
      * fast/dom/HTMLElement/attr-missing-parent-true-expected.txt:
      * fast/dom/HTMLElement/attr-missing-parent-true.html:
      * fast/dom/HTMLElement/attr-true-string-expected.txt:
      * fast/dom/HTMLElement/attr-true-string.html:
      * fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-expected.txt:
      * fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe-expected.txt:
      * fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html:
      * fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html:
      * fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor-expected.txt:
      * fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html:
      * fast/dom/HTMLElement/iscontenteditable-designmodeon-expected.txt:
      * fast/dom/HTMLElement/iscontenteditable-designmodeon.html:
      * fast/dom/HTMLElement/set-false-expected.txt:
      * fast/dom/HTMLElement/set-false.html:
      * fast/dom/HTMLElement/set-inherit-parent-false-expected.txt:
      * fast/dom/HTMLElement/set-inherit-parent-false.html:
      * fast/dom/HTMLElement/set-inherit-parent-true-expected.txt:
      * fast/dom/HTMLElement/set-inherit-parent-true.html:
      * fast/dom/HTMLElement/set-invalid-value-expected.txt:
      * fast/dom/HTMLElement/set-invalid-value.html:
      * fast/dom/HTMLElement/set-true-expected.txt:
      * fast/dom/HTMLElement/set-true.html:
      * fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt:
      * fast/dom/HTMLElement/set-value-caseinsensitive.html:
      * fast/dom/Orientation/create-event-orientationchange.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20e19320
    • philn@webkit.org's avatar
      Unreviewed, GTK rebaseline. · 39b3be26
      philn@webkit.org authored
      * platform/gtk/fast/dom/Window/window-properties-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39b3be26
    • ddkilzer@apple.com's avatar
      Don't use File::Slurp for run-leaks unit tests · 4cedb559
      ddkilzer@apple.com authored
      <http://webkit.org/b/72356>
      
      Reviewed by Daniel Bates.
      
      * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
      * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
      Extracted common package logic into RunLeaks.pm.  Fixed call to
      RunLeaks::parseLeaksOutput().
      * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
      * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cedb559
    • commit-queue@webkit.org's avatar
      Handle svn 1.7 when detecting whether a directory is in an svn checkout. · dcb85cf1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72349
      
      Patch by Peter Kasting <pkasting@google.com> on 2011-11-15
      Reviewed by Adam Roben.
      
      * Scripts/VCSUtils.pm:
      (isSVNDirectory):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcb85cf1
    • commit-queue@webkit.org's avatar
      Implement maxWidth for fillText and strokeText, fixing the... · dba3b139
      commit-queue@webkit.org authored
      Implement maxWidth for fillText and strokeText, fixing the canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html test.
      https://bugs.webkit.org/show_bug.cgi?id=61528
      
      Patch by Philip Rogers <pdr@google.com> on 2011-11-15
      Reviewed by Stephen White.
      
      Source/WebCore:
      
      Tests: fast/canvas/2d.text.draw.fill.maxWidth.gradient.html
             fast/canvas/2d.text.draw.fill.maxWidth.negative.html
             fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html
             fast/canvas/2d.text.draw.fill.maxWidth.verySmall.html
      
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::drawTextInternal):
      
      LayoutTests:
      
      * fast/canvas/2d.text.draw.fill.maxWidth.gradient-expected.txt: Added.
      * fast/canvas/2d.text.draw.fill.maxWidth.gradient.html: Added.
      * fast/canvas/2d.text.draw.fill.maxWidth.negative-expected.txt: Added.
      * fast/canvas/2d.text.draw.fill.maxWidth.negative.html: Added.
      * fast/canvas/2d.text.draw.fill.maxWidth.veryLarge-expected.txt: Added.
      * fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html: Added.
      * fast/canvas/2d.text.draw.fill.maxWidth.verySmall-expected.txt: Added.
      * fast/canvas/2d.text.draw.fill.maxWidth.verySmall.html: Added.
      * platform/chromium/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt: Removed.
      * platform/chromium/test_expectations.txt:
      * platform/gtk/Skipped:
      * platform/mac-leopard/Skipped:
      * platform/mac/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt:
      * platform/qt/Skipped:
      * resources/Ahem.ttf: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dba3b139
    • carlosgc@webkit.org's avatar
      [GTK] Implement download support in WebKit2 · 97dc098c
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72258
      
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Add common download errors to ErrorsGtk.
      
      * platform/gtk/ErrorsGtk.cpp:
      (WebCore::downloadNetworkError):
      (WebCore::downloadCancelledByUserError):
      (WebCore::downloadDestinationError):
      * platform/gtk/ErrorsGtk.h:
      
      Source/WebKit/gtk:
      
      Use errors from WebCore to emit the error signals.
      
      * webkit/webkitdownload.cpp:
      (webkitDownloadEmitError): Helper function that emits the error
      signal for the given ResourceError.
      (webkit_download_open_stream_for_uri): Use webkitDownloadEmitError().
      (webkit_download_cancel): Ditto.
      (webkit_download_set_destination_uri): Ditto.
      (webkit_download_received_data): Ditto.
      (webkit_download_error): Ditto.
      
      Source/WebKit2:
      
      * WebProcess/Downloads/Download.h:
      * WebProcess/Downloads/soup/DownloadSoup.cpp:
      (WebKit::DownloadClient::DownloadClient):
      (WebKit::DownloadClient::downloadFailed):
      (WebKit::DownloadClient::didReceiveResponse):
      (WebKit::DownloadClient::didReceiveData):
      (WebKit::DownloadClient::didFinishLoading):
      (WebKit::DownloadClient::didFail):
      (WebKit::DownloadClient::wasBlocked):
      (WebKit::DownloadClient::cannotShowURL):
      (WebKit::Download::start):
      (WebKit::Download::startWithHandle):
      (WebKit::Download::cancel):
      (WebKit::Download::platformInvalidate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97dc098c
    • caryclark@google.com's avatar
      [chromium-mac] Enable vertical text using Skia · 29c4406c
      caryclark@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=72137
      
      Source/WebCore:
      
      Use Skia to draw vertical text. This is much
      faster and has higher fidelity than the old method
      of drawing text on a path.
      
      The graphics context passed to Skia has been
      rotated 90 degrees but the character advances
      have not, so it is necessary to unrotate the canvas,
      and re-rotate the positions.
      
      This generates correct output (or, at least,
      consistent with Chromium CG on Mac) for all vertical
      text tests, one of which is mentioned below.
      
      Reviewed by Stephen White.
      
      Test: fast/writing-mode/text-orientation-basic.html
      
      * platform/graphics/skia/FontSkia.cpp:
      (WebCore::setupPaint):
      (WebCore::Font::drawGlyphs):
      
      LayoutTests:
      
      Ignore vertical text tests on Skia on Mac for now.
      
      Reviewed by Stephen White.
      
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100283 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29c4406c
    • eric.carlson@apple.com's avatar
      media-blocked-by-willsendrequest.html is flaky · 513d4873
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=72381
      
      Reviewed by Tony Gentilcore.
      
      * media/media-blocked-by-willsendrequest.html:
          Don't assume the media events will be dispatched before the window 'load' event.
      * platform/chromium/test_expectations.txt:
          Don't skip media/media-blocked-by-willsendrequest.html. 
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      513d4873
    • ossy@webkit.org's avatar
      [Qt] Enable skipped but now passing tests (http/tests) · 7e060099
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71911
      
      Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-11-15
      Reviewed by Csaba Osztrogonác.
      
      * platform/qt/Skipped: Unskip 24 tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e060099
    • commit-queue@webkit.org's avatar
      Fix SVG hit testing when padding is present · 874881cb
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=37325
      
      Patch by Philip Rogers <pdr@google.com> on 2011-11-15
      Reviewed by Nikolas Zimmermann.
      
      Source/WebCore:
      
      Test: svg/hittest/svg-padding.xhtml
      
      * rendering/svg/RenderSVGRoot.cpp:
      (WebCore::RenderSVGRoot::nodeAtPoint):
      
      LayoutTests:
      
      * svg/hittest/svg-padding-expected.txt: Added.
      * svg/hittest/svg-padding.xhtml: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      874881cb
    • philn@webkit.org's avatar
      Unreviewed, marked · 8d25fc96
      philn@webkit.org authored
      fast/frames/flattening/frameset-flattening-simple.html as flaky on GTK.
      
      * platform/gtk/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d25fc96
    • tonyg@chromium.org's avatar
      Tests occasionally report missing expectations · 5733d2a0
      tonyg@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72039
      
      * platform/chromium/test_expectations.txt: Add 3 more tests which flakily report missing.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5733d2a0
    • pfeldman@chromium.org's avatar
      Web Inspector: move generic code from DevTools.js into the WebCore. · 11c5e981
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72377
      
      re-landing r100269.
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      * English.lproj/localizedStrings.js:
      * inspector/front-end/InspectorFrontendHostStub.js:
      (.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
      * inspector/front-end/ProfilesPanel.js:
      * inspector/front-end/Resource.js:
      * inspector/front-end/Settings.js:
      * inspector/front-end/UIUtils.js:
      (WebInspector.setToolbarColors):
      (WebInspector.resetToolbarColors):
      * inspector/front-end/inspector.js:
      
      Source/WebKit/chromium:
      
      * src/js/DevTools.js:
      (WebInspector.setInspectedTabId):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11c5e981
    • reed@google.com's avatar
      [skia] mark to rebaseline aft cr104128 lands (colorfilter optimization) · 436f5e76
      reed@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=72270
      
      Reviewed by NOBODY.
      
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      436f5e76
    • tonyg@chromium.org's avatar
      media-blocked-by-willsendrequest.html is flaky · b0d69f4a
      tonyg@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72381
      
      * platform/chromium/test_expectations.txt: Mark test as flaky.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0d69f4a
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r100269. · 656cc6fb
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/100269
      https://bugs.webkit.org/show_bug.cgi?id=72383
      
      "Broke dozens of tests due to exception in loadingFinished"
      (Requested by tonyg-cr on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-15
      
      Source/WebCore:
      
      * English.lproj/localizedStrings.js:
      * inspector/front-end/InspectorFrontendHostStub.js:
      (.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
      * inspector/front-end/ProfilesPanel.js:
      * inspector/front-end/Resource.js:
      * inspector/front-end/Settings.js:
      * inspector/front-end/UIUtils.js:
      * inspector/front-end/inspector.js:
      
      Source/WebKit/chromium:
      
      * src/js/DevTools.js:
      ():
      (devtools.domContentLoaded):
      (WebInspector.UIString):
      (WebInspector.setToolbarColors):
      (WebInspector.resetToolbarColors):
      (.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      656cc6fb
    • apavlov@chromium.org's avatar
      font property does not show up as "shorthand" in inspector · d9fbbe2c
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=15598
      
      Reviewed by Nikolas Zimmermann.
      
      Source/WebCore:
      
      The "font" CSS property is turned into a real shorthand, as its longhands used to float around
      in the resulting style declaration without any reference to their underlying "font" property.
      
      Test: fast/css/font-shorthand.html
      
      * css/CSSMutableStyleDeclaration.cpp:
      (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Extracted the "font" value building into fontValue().
      (WebCore::CSSMutableStyleDeclaration::appendFontLonghandValueIfExplicit): Added
      (WebCore::CSSMutableStyleDeclaration::fontValue): Build the "font" value from longhands.
      * css/CSSMutableStyleDeclaration.h:
      * css/CSSParser.cpp:
      (WebCore::CSSParser::addProperty): Added optional "implicit" parameter.
      (WebCore::CSSParser::parseFont): Build respective longhands instead of the shorthand "font" property.
      * css/CSSParser.h: Added optional "implicit" parameter to addProperty().
      * css/CSSPropertyLonghand.cpp:
      (WebCore::initShorthandMap): Added "font" shorthand map entry.
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyPropertyToStyle): Separated the property application from the instance setup.
      (WebCore::CSSStyleSelector::applyPropertyToCurrentStyle): Added.
      * css/CSSStyleSelector.h: Made updateFont() public.
      * css/FontValue.cpp:
      (WebCore::FontValue::customCssText): Made use of StringBuilder.
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::setFont): Apply "font" longhands rather than the (non-existent) "font" property.
      * inspector/front-end/StylesSidebarPane.js:
      (WebInspector.StylesSidebarPane.prototype._markUsedProperties): Removed a workaround for "font" not being a shorthand.
      * page/animation/AnimationBase.cpp:
      (WebCore::addShorthandProperties): Removed a workaround for "font" not being a shorthand.
      
      LayoutTests:
      
      * fast/css/font-shorthand-expected.txt: Added.
      * fast/css/font-shorthand.html: Added.
      * fast/inspector-support/style-expected.txt:
      * fast/inspector-support/style.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9fbbe2c
    • philn@webkit.org's avatar
      REGRESSION (r100158-r100162): 5 fast tests failing on GTK Linux 64-bit Debug · f7e9fa72
      philn@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72297
      
      Unreviewed, GTK rebaseline after r100159.
      
      * platform/gtk/Skipped:
      * platform/gtk/fast/dom/Window/window-properties-expected.txt:
      * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
      * platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Added.
      * platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
      * platform/gtk/fast/js/global-constructors-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7e9fa72
    • philn@webkit.org's avatar
      Unreviewed, skipping some new GTK test failures. · c220c5df
      philn@webkit.org authored
      * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c220c5df
    • commit-queue@webkit.org's avatar
      [Qt] Clean up the remaining duplicate code after the RenderThemeQt refactoring. · 69553f90
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72262
      
      Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-11-15
      Reviewed by Antonio Gomes.
      
      No new tests needed, this is purely cosmetic.
      
      * platform/qt/RenderThemeQStyle.cpp:
      (WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
      * platform/qt/RenderThemeQStyle.h:
      * platform/qt/RenderThemeQt.cpp:
      (WebCore::RenderThemeQt::adjustMenuListButtonStyle): remove the call to resetBorderRadius()
      since the mobile theme actually didn't do this.
      * platform/qt/RenderThemeQtMobile.cpp:
      (WebCore::RenderThemeQtMobile::adjustMenuListStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69553f90
    • pfeldman@chromium.org's avatar
      Web Inspector: move generic code from DevTools.js into the WebCore. · 7da2ff3f
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72377
      
      This includes support for themed toolbar, remote debugging routines,
      removes a couple of obsolete overrides from the DevTools.js
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      * English.lproj/localizedStrings.js:
      * inspector/front-end/InspectorFrontendHostStub.js:
      (.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
      * inspector/front-end/ProfilesPanel.js:
      * inspector/front-end/Resource.js:
      * inspector/front-end/Settings.js:
      * inspector/front-end/UIUtils.js:
      (WebInspector.setToolbarColors):
      (WebInspector.resetToolbarColors):
      * inspector/front-end/inspector.js:
      
      Source/WebKit/chromium:
      
      * src/js/DevTools.js:
      (WebInspector.setInspectedTabId):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7da2ff3f
    • ossy@webkit.org's avatar
      REGRESSION(r100182): It broke 2 http/tests/security tests · a034662b
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72364
      
      * platform/qt/Skipped: Skip failing tests until fix.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a034662b
    • tonyg@chromium.org's avatar
      [chromium] fast/forms/file/input-file-label.html is flaky on win · 19213c5b
      tonyg@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72376
      
      * platform/chromium/test_expectations.txt: Mark test flaky on win.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19213c5b
    • hausmann@webkit.org's avatar
      [Qt] Centralize hide_symbols and ensure all libs are built with symbol... · a94b42fa
      hausmann@webkit.org authored
      [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
      
      Reviewed by Tor Arne Vestbø.
      
      .:
      
      * Source/api.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
      
      Source/JavaScriptCore:
      
      * Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
      
      Source/WebCore:
      
      * Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
      
      Tools:
      
      * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
      magic here where we handle all TEMPLATE = lib .pro files.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a94b42fa
    • hausmann@webkit.org's avatar
      [Qt] Unreviewed prospective --minimal build fix. · 844253b5
      hausmann@webkit.org authored
      * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
      and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      844253b5
    • noel.gordon@gmail.com's avatar
      Rebaseline gray-scale-jpeg-with-color-profile.html · 4569bac9
      noel.gordon@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=72240
      
      Reviewed by Eric Seidel.
      
      * fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Renamed from LayoutTests/platform/gtk/fast/images/gray-scale-jpeg-with-color-profile-expected.txt.
      * platform/chromium-linux/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
      * platform/chromium-win/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
      * platform/chromium/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
      * platform/chromium/test_expectations.txt:
      * platform/qt/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4569bac9
    • tonyg@chromium.org's avatar
      [chromium] perf/document-contains.html is flaky on win · 11ce4a9e
      tonyg@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72372
      
      * platform/chromium/test_expectations.txt: Marking flaky on WIN.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11ce4a9e
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r100213. · 1040deab
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/100213
      https://bugs.webkit.org/show_bug.cgi?id=72371
      
      "Breaks test_shell_tests" (Requested by tonyg-cr on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-15
      
      Source/WebCore:
      
      * page/SecurityOrigin.cpp:
      (WebCore::SecurityOrigin::SecurityOrigin):
      * platform/SchemeRegistry.cpp:
      (WebCore::schemesWithUniqueOrigins):
      
      LayoutTests:
      
      * fast/filesystem/async-operations-expected.txt:
      * fast/filesystem/not-enough-arguments-expected.txt:
      * fast/filesystem/read-directory-expected.txt:
      * fast/filesystem/simple-persistent-expected.txt:
      * fast/filesystem/simple-readonly-expected.txt:
      * fast/filesystem/simple-temporary-expected.txt:
      * fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
      * fast/frames/sandboxed-iframe-attribute-parsing.html:
      * fast/frames/sandboxed-iframe-forms-dynamic.html:
      * fast/frames/sandboxed-iframe-forms.html:
      * fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html:
      * fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html:
      * fast/frames/sandboxed-iframe-navigation-top-by-name.html:
      * fast/frames/sandboxed-iframe-navigation-top.html:
      * media/video-controls-no-scripting.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1040deab
    • commit-queue@webkit.org's avatar
      [EFL] Use EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks instead of... · c3a7bac1
      commit-queue@webkit.org authored
      [EFL] Use EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks instead of EINA_SAFETY_ON_FALSE_RETURN_VAL.
      https://bugs.webkit.org/show_bug.cgi?id=70091
      
      Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-11-15
      Reviewed by Filip Pizlo.
      
      Replaces EINA_SAFETY_ON_FALSE_RETURN_VAL by EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks in compliance
      with WebKit-EFL functions.
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_contents_set):
      (ewk_frame_contents_alternate_set):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3a7bac1
    • yuqiang.xian@intel.com's avatar
      Remove DFGJITCompilerInlineMethods · 5b6fcdd0
      yuqiang.xian@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=72366
      
      Reviewed by Filip Pizlo.
      
      Those methods are actually seldom used. Modify the few such places and
      remove DFGJITCompilerInlineMethods stuffs totally.
      
      * GNUmakefile.list.am:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * dfg/DFGJITCompiler.h:
      (JSC::DFG::JITCompiler::addressOfDoubleConstant):
      * dfg/DFGJITCompilerInlineMethods.h: Removed.
      * dfg/DFGSpeculativeJIT.cpp:
      * dfg/DFGSpeculativeJIT.h:
      (JSC::DFG::SpeculativeJIT::silentFillFPR):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::fillJSValue):
      (JSC::DFG::SpeculativeJIT::cachedGetMethod):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b6fcdd0
    • ossy@webkit.org's avatar
      [Qt] Unviewed fix after r100254, because committed results was incorrect. · 1de98ab9
      ossy@webkit.org authored
      * platform/qt/fast/dom/Window/window-properties-expected.png:
      * platform/qt/fast/dom/Window/window-properties-expected.txt:
      * platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
      * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
      * platform/qt/fast/dom/constructed-objects-prototypes-expected.png: Added.
      * platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Added.
      * platform/qt/fast/js/global-constructors-expected.png:
      * platform/qt/fast/js/global-constructors-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1de98ab9
    • hclam@chromium.org's avatar
      [chromium] scroll deltas are cleared during commit to the main thread · c1225ede
      hclam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71916
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Patch is covered by unit test.
      
      Add a member m_sentScrollDelta to CCLayerImpl to keep track of the scroll delta being
      sent to the main thread during commit. This gives a simpler approach to keep tracking of a
      layer's scroll delta in impl thread.
      
      * platform/graphics/chromium/LayerChromium.h:
      (WebCore::LayerChromium::sentScrollDelta):
      * platform/graphics/chromium/cc/CCLayerImpl.h:
      (WebCore::CCLayerImpl::sentScrollDelta):
      (WebCore::CCLayerImpl::setSentScrollDelta):
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
      (WebCore::CCLayerTreeHostImpl::processScrollDeltas):
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
      
      Source/WebKit/chromium:
      
      Modify test to verify sentScrollDeltas() values of CCLayerImpl during commit.
      
      * tests/CCLayerTreeHostImplTest.cpp:
      (WebKit::TEST_F):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1225ede
    • tonyg@chromium.org's avatar
      media/track/track-webvtt-tc003-newlines.html is flaky · 7395b656
      tonyg@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72369
      
      * platform/chromium/test_expectations.txt: Marked test flaky.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7395b656
    • hausmann@webkit.org's avatar
      [Qt] REGRESSION(100123): It made inspector tests crash... · 0beb15bc
      hausmann@webkit.org authored
      [Qt] REGRESSION(100123): It made inspector tests crash https://bugs.webkit.org/show_bug.cgi?id=72274
      
      Reviewed by Tor Arne Vestbø.
      
      Source/WebCore:
      
      * platform/qt/RenderThemeQStyle.h: Remove uninitialized and duplicated
      m_page member that should really come from RenderThemeQt.
      
      LayoutTests:
      
      * platform/qt/Skipped: Unskip passing tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0beb15bc
    • gyuyoung.kim@samsung.com's avatar
      Unreviewed. Fix build breaks when EFL port is built. · 369fa09b
      gyuyoung.kim@samsung.com authored
      * CMakeLists.txt:
      * UseJSC.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      369fa09b
    • reni@webkit.org's avatar
      Unviewed gardening after r100159. · e5c3dbb3
      reni@webkit.org authored
      Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-11-15
      
      * platform/qt/fast/dom/Window/window-properties-expected.png:
      * platform/qt/fast/dom/Window/window-properties-expected.txt:
      * platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
      * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
      * platform/qt/fast/dom/prototype-inheritance-2-expected.png:
      * platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
      * platform/qt/fast/js/global-constructors-expected.png:
      * platform/qt/fast/js/global-constructors-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5c3dbb3
    • hausmann@webkit.org's avatar
      [Qt] Unreviewed --minimal build fix. · 31f71d66
      hausmann@webkit.org authored
      * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
      a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
      to make moc's preprocessor abort.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31f71d66
    • noel.gordon@gmail.com's avatar
      Make ImageFrame member getAddr() public · 7554e430
      noel.gordon@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=72321
      
      Reviewed by Adam Barth.
      
      Make ImageFrame member getAddr() public to allow ImageFrame users access to the
      underlying frame pixels if needed. Image decoders, for example, could with care
      use this service to write decoded pixels direct to the ImageFrame pixel buffer,
      avoiding intermeadiate data copies from temporary decoded pixel row buffers and
      the decoding performance loss that that entails.
      
      No new tests, refactoring only.
      
      * platform/image-decoders/ImageDecoder.h:
      (WebCore::ImageFrame::getAddr):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7554e430