1. 01 Oct, 2009 16 commits
    • kenneth@webkit.org's avatar
      Rubberstamped by Simon Hausmann. · 73e707be
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
      Disable HTTP loading tests that fail on the buildbot.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73e707be
    • atwilson@chromium.org's avatar
      REGRESSION: fast/workers/dedicated-worker-lifecycle.html failing intermittently on leopard bot · ac8b946a
      atwilson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=29344
      
      Reviewed by Eric Seidel.
      
      * fast/workers/resources/dedicated-worker-lifecycle.js:
      (runTests):
      Allocate objects on the stack to try to force a GC to eliminate flakiness.
      * fast/workers/resources/worker-util.js:
      (gc):
      Added an optional "forceAlloc" parameter which causes a more extensive stack-clobbering algorithm to be run.
      (waitUntilThreadCountMatches):
      Pass the forceAlloc flag to gc() to try to force unreferenced workers to get GC'd.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac8b946a
    • kenneth@webkit.org's avatar
      Rubberstamped by Simon Hausmann. · 409426a4
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
      Enable Local tests for Qt.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      409426a4
    • kenneth@webkit.org's avatar
      Rubberstamped by Simon Hausmann. · 70842645
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
      Enable HTTP loading tests for Qt.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70842645
    • bdakin@apple.com's avatar
      WebCore: Fix for <rdar://problem/6934421> Support CSS for Text Kerning and · 3a72daae
      bdakin@apple.com authored
      ligature
      -and corresponding-
      https://bugs.webkit.org/show_bug.cgi?id=6136
      
      Reviewed by Dave Hyatt.
      
      This patch makes the SVG CSS property text-rendering work with any 
      HTML, much like it does in Firefox. It accepts four possible input 
      values: auto, optimizeSpeed, optimizeLegibility, and 
      geometricPrecision. Right now, in this implementation, here is what 
      those values correspond to:
      
      auto = optimizeSpeed = what we normally when the value's not set
      optimizeLegibility = geometricPrecision = ligatures + kerning
      
      Add new file TextRenderingMode.h to the project files.
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      
      CSS support for the new CSSPropertyTextRendering
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      (WebCore::CSSPrimitiveValue::operator TextRenderingMode):
      * css/CSSPropertyNames.in:
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      * css/CSSValueKeywords.in:
      
      All the old SVG CSS support for this property can go away. When 
      it's used in SVG, it will just fall into the normal HTML case.
      * css/SVGCSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
      * css/SVGCSSParser.cpp:
      (WebCore::CSSParser::parseSVGValue):
      * css/SVGCSSPropertyNames.in:
      * css/SVGCSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applySVGProperty):
      * css/SVGCSSValueKeywords.in:
      
      FontDescription stores the m_textRendering bit.
      * platform/graphics/FontDescription.h:
      (WebCore::FontDescription::FontDescription):
      (WebCore::FontDescription::textRenderingMode):
      (WebCore::FontDescription::setTextRenderingMode):
      (WebCore::FontDescription::operator==):
      
      We want to fall into the complex text rendering code path if 
      kerning and ligatures have been enabled with this property.
      * platform/graphics/FontFastPath.cpp:
      (WebCore::Font::canUseGlyphCache):
      
      Now takes a TextRenderingMode as a parameter.
      * platform/graphics/SimpleFontData.h:
      
      New header for the enum.
      * platform/graphics/TextRenderingMode.h: Added.
      (WebCore::):
      
      getCFStringAttributes() now takes a TextRenderingMode as an 
      attribute.
      * platform/graphics/mac/CoreTextController.cpp:
      (WebCore::CoreTextController::collectCoreTextRunsForCharacters):
      
      Enable kerning and ligatures whenever the TextRenderingMode is 
      OptimizeLegibility or GeometricPrecision
      * platform/graphics/mac/FontMacATSUI.mm:
      (WebCore::disableLigatures):
      (WebCore::initializeATSUStyle):
      (WebCore::ATSULayoutParameters::initialize):
      * platform/graphics/mac/SimpleFontDataMac.mm:
      (WebCore::SimpleFontData::getCFStringAttributes):
      
      More SVG CSS stuff that isn't needed anymore since SVG will use the 
      new HTML CSS implementation.
      * rendering/style/SVGRenderStyle.h:
      (WebCore::SVGRenderStyle::InheritedFlags::operator==):
      (WebCore::SVGRenderStyle::setBitDefaults):
      * rendering/style/SVGRenderStyleDefs.h:
      
      LayoutTests: Tests for <rdar://problem/6934421> Support CSS for Text Kerning and 
      ligature
      -and corresponding-
      https://bugs.webkit.org/show_bug.cgi?id=6136
      
      Reviewed by Dave Hyatt.
      
      New tests.
      * fast/css/parsing-text-rendering-expected.txt: Added.
      * fast/css/parsing-text-rendering.html: Added.
      * fast/css/resources/parsing-text-rendering.js: Added.
      (test):
      * fast/css/text-rendering.html: Added.
      * platform/mac/fast/css/text-rendering-expected.checksum: Added.
      * platform/mac/fast/css/text-rendering-expected.png: Added.
      * platform/mac/fast/css/text-rendering-expected.txt: Added.
      
      New and improved results.
      * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
      * platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
      * platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
      * svg/css/getComputedStyle-basic-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a72daae
    • kenneth@webkit.org's avatar
      Rubberstamped by Simon Hausmann. · b539bdb8
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
      Enable URI tests for Qt, skip the single test we don't pass.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b539bdb8
    • japhet@chromium.org's avatar
      2009-10-01 Nate Chapin <japhet@chromium.org> · 1368ffd3
      japhet@chromium.org authored
              Reviewed by Darin Adler.
      
              Add baseline pngs for a couple of tests that currently only have checksums.
      
              https://bugs.webkit.org/show_bug.cgi?id=28322
      
              * platform/mac/fast/borders/border-radius-constraints-expected.png: Added.
              * platform/mac/fast/borders/border-radius-split-inline-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1368ffd3
    • kenneth@webkit.org's avatar
      Rubberstamped by Simon Hausmann. · e365adab
      kenneth@webkit.org authored
      WebKitTools:
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
      Enable HTTP tests for Qt
      
      * Scripts/run-webkit-tests:
      
      LayoutTests:
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
      Enable HTTP tests for Qt, and skip the subdirs we don't pass yet.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e365adab
    • simon.fraser@apple.com's avatar
      2009-10-01 Simon Fraser <simon.fraser@apple.com> · f478d5f7
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt.
      
              Odd color transitions on anchors with transition-property: all
              https://bugs.webkit.org/show_bug.cgi?id=29911
      
              When transitioning maybe-invalid colors, if the source and destination
              color are both invalid, then don't animate.
      
              This fixes an issue where a child element of an element running a color
              transition, with -webkit-transition-property:all, would show a color change.
              This happened because the "maybe invalid color" logic copied the color style
              into -webkit-text-fill-color for both endpoints, causing -webkit-text-fill-color
              to animate while the transition ran, and to then to disappear when the transition
              finished.
      
              Test: transitions/color-transition-all.html
      
              * page/animation/AnimationBase.cpp:
              (WebCore::PropertyWrapperMaybeInvalidColor::equals):
              (WebCore::PropertyWrapperMaybeInvalidColor::blend):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f478d5f7
    • eric@webkit.org's avatar
      2009-10-01 Victor Wang <victorw@chromium.org> · fb4d844b
      eric@webkit.org authored
              Reviewed by Oliver Hunt.
      
              Allow dragging a node who has child nodes.
      
              https://bugs.webkit.org/show_bug.cgi?id=28632
      
              * fast/events/drag-parent-node-expected.txt: Added.
              * fast/events/drag-parent-node.html: Added.
              * fast/events/resources/bookmark.gif: Added.
      2009-10-01  Victor Wang  <victorw@chromium.org>
      
              Reviewed by Oliver Hunt.
      
              Allow dragging a node who has child nodes.
      
              https://bugs.webkit.org/show_bug.cgi?id=28632
      
              Test: fast/events/drag-parent-node.html
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::shouldDragAutoNode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb4d844b
    • aroben@apple.com's avatar
      Land expected failure results for two tests on Windows · 80aa186c
      aroben@apple.com authored
      These failures are covered by <http://webkit.org/b/29963> and
      <http://webkit.org/b/29964>.
      
      Rubber-stamped in advance by Eric Carlson.
      
      * platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt:
      Added.
      * platform/win/fast/forms/basic-inputs-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80aa186c
    • zoltan@webkit.org's avatar
      2009-10-01 Andras Becsi <becsi.andras@stud.u-szeged.hu> · ac3beb0b
      zoltan@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Skip fast/table/008.html until a solution for the crash on the buildbot is found.
      
              * platform/qt/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac3beb0b
    • eric@webkit.org's avatar
      2009-10-01 Jakub Wieczorek <faw217@gmail.com> · 9cf66854
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Implement eventSender.scheduleAsynchronousClick().
      
              https://bugs.webkit.org/show_bug.cgi?id=29931
      
              * platform/qt/Skipped:
      2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Implement eventSender.scheduleAsynchronousClick().
      
              https://bugs.webkit.org/show_bug.cgi?id=29931
      
              * DumpRenderTree/qt/jsobjects.cpp:
              (EventSender::scheduleAsynchronousClick):
              * DumpRenderTree/qt/jsobjects.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cf66854
    • eric@webkit.org's avatar
      2009-10-01 Jakub Wieczorek <faw217@gmail.com> · 83760042
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
              fast/events/open-window-from-another-frame.html from the Skipped list.
      
              https://bugs.webkit.org/show_bug.cgi?id=29930
      
              * platform/qt/Skipped:
      2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
              fast/events/open-window-from-another-frame.html from the Skipped list.
      
              https://bugs.webkit.org/show_bug.cgi?id=29930
      
              * DumpRenderTree/qt/jsobjects.cpp:
              (LayoutTestController::setPopupBlockingEnabled):
              * DumpRenderTree/qt/jsobjects.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83760042
    • eric@webkit.org's avatar
      2009-10-01 Martin Robinson <martin.james.robinson@gmail.com> · 4f864b9b
      eric@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] GtkIMContext filtering interferes with DOM key events
              https://bugs.webkit.org/show_bug.cgi?id=28733
      
              Add new key event test ensuring that IME keypresses are handled.
      
              * GNUmakefile.am:
      2009-10-01  Martin Robinson  <martin.james.robinson@gmail.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] GtkIMContext filtering interferes with DOM key events
              https://bugs.webkit.org/show_bug.cgi?id=28733
      
              Re-enable skipped tests which were previously failing.
      
              * platform/gtk/Skipped:
      2009-10-01  Martin Robinson  <martin.james.robinson@gmail.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] GtkIMContext filtering interferes with DOM key events
              https://bugs.webkit.org/show_bug.cgi?id=28733
      
              Ensure that keyboard events filtered by the GtkIMContext still create
              the proper DOM events.
      
              No tests added. Instead previously skipped tests have been enabled.
      
              * platform/gtk/KeyEventGtk.cpp:
              (WebCore::keyIdentifierForGdkKeyCode):
              (WebCore::singleCharacterString):
      2009-10-01  Martin Robinson  <martin.james.robinson@gmail.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] GtkIMContext filtering interferes with DOM key events
              https://bugs.webkit.org/show_bug.cgi?id=28733
      
              Ensure that keyboard events filtered by the GtkIMContext still create
              the proper DOM events.
      
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::clearPendingIMData):
              (WebKit::imContextCommitted):
              (WebKit::imContextPreeditChanged):
              (WebKit::EditorClient::shouldBeginEditing):
              (WebKit::EditorClient::shouldEndEditing):
              (WebKit::interpretEditorCommandKeyEvent):
              (WebKit::handleCaretBrowsingKeyboardEvent):
              (WebKit::EditorClient::handleKeyboardEvent):
              (WebKit::EditorClient::handleInputMethodKeydown):
              * tests/testkeyevents.c: Added.
              (test_info_new):
              (test_info_destroy):
              (key_event_fixture_setup):
              (key_event_fixture_teardown):
              (key_press_event_cb):
              (key_release_event_cb):
              (load_status_cb):
              (map_event_cb):
              (test_keypress):
              (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f864b9b
    • eric@webkit.org's avatar
      2009-10-01 Philippe Normand <pnormand@igalia.com> · 9d150a2a
      eric@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] data: uri support in media player
              https://bugs.webkit.org/show_bug.cgi?id=29842
      
              Check presence of gstreamer-pbutils-0.10.
      
              * configure.ac:
      2009-10-01  Philippe Normand  <pnormand@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] data: uri support in media player
              https://bugs.webkit.org/show_bug.cgi?id=29842
      
              Re-enable media/audio-data-url.html.
      
              * platform/gtk/Skipped:
      2009-10-01  Philippe Normand  <pnormand@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] data: uri support in media player
              https://bugs.webkit.org/show_bug.cgi?id=29842
      
              New GStreamer element to handle data: uris. For now only base64
              encoded data is supported. Decoded data is handed over to
              giostreamsrc.
      
              * GNUmakefile.am:
              * platform/graphics/gtk/DataSourceGStreamer.cpp: Added.
              (_do_init):
              (webkit_data_src_base_init):
              (webkit_data_src_class_init):
              (webkit_data_src_reset):
              (webkit_data_src_init):
              (webkit_data_src_finalize):
              (webkit_data_src_uri_get_type):
              (webkit_data_src_uri_get_protocols):
              (webkit_data_src_uri_get_uri):
              (webkit_data_src_uri_set_uri):
              (webkit_data_src_uri_handler_init):
              * platform/graphics/gtk/DataSourceGStreamer.h: Added.
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::do_gst_init):
              (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
              (WebCore::MediaPlayerPrivate::mimeTypeCache):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d150a2a
  2. 30 Sep, 2009 12 commits
    • dbates@webkit.org's avatar
      2009-09-30 Daniel Bates <dbates@webkit.org> · c1377e2a
      dbates@webkit.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=29944
              
              Reduces false positives in the XSSAuditor by explicitly allowing requests
              that do not contain illegal URI characters.
              
              As a side effect of this change, the tests property-inject.html, 
              property-escape-noquotes.html, and property-escape-noquotes-tab-slash-chars.html 
              fail because these attacks do not contain any illegal URI characters and 
              thus are now allowed by the XSSAuditor, where previously they weren't. A future
              change may reinstate this functionality.
      
              Tests: http/tests/security/xssAuditor/script-tag-safe2.html
                     http/tests/security/xssAuditor/script-tag-safe3.html
      
              * page/XSSAuditor.cpp:
              (WebCore::isIllegalURICharacter): Added method.
              (WebCore::XSSAuditor::canEvaluate):
              (WebCore::XSSAuditor::canCreateInlineEventListener):
              (WebCore::XSSAuditor::findInRequest): Added parameter 
              allowRequestIfNoIllegalURICharacters.
              * page/XSSAuditor.h:
      2009-09-30  Daniel Bates  <dbates@webkit.org>
      
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=29944
              
              Tests that the XSSAuditor allows requests that do not contain illegal URI 
              characters.
              
              Added a notice regarding the failure of tests property-inject.html, 
              property-escape-noquotes.html and property-escape-noquotes-tab-slash-chars.html, 
              and rebased the expected results of these tests.
      
              * http/tests/security/xssAuditor/property-escape-noquotes-expected.txt:
              * http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars-expected.txt:
              * http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars.html:
              * http/tests/security/xssAuditor/property-escape-noquotes.html:
              * http/tests/security/xssAuditor/property-inject-expected.txt:
              * http/tests/security/xssAuditor/property-inject.html:
              * http/tests/security/xssAuditor/resources/safe-script-noquotes.js: Added.
              * http/tests/security/xssAuditor/resources/script-tag-safe2.html: Added.
              * http/tests/security/xssAuditor/resources/script-tag-safe3.html: Added.
              * http/tests/security/xssAuditor/script-tag-safe2-expected.txt: Added.
              * http/tests/security/xssAuditor/script-tag-safe2.html: Added.
              * http/tests/security/xssAuditor/script-tag-safe3-expected.txt: Added.
              * http/tests/security/xssAuditor/script-tag-safe3.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1377e2a
    • eric@webkit.org's avatar
      2009-09-30 Kent Tamura <tkent@chromium.org> · 03159e8a
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Add ValidityState.tooLong support for <input> and <textarea>.
              https://bugs.webkit.org/show_bug.cgi?id=27454
      
              * fast/forms/ValidityState-tooLong-input-expected.txt: Added.
              * fast/forms/ValidityState-tooLong-input.html: Added.
              * fast/forms/ValidityState-tooLong-textarea-expected.txt: Added.
              * fast/forms/ValidityState-tooLong-textarea.html: Added.
              * fast/forms/script-tests/ValidityState-tooLong-input.js: Added.
              * fast/forms/script-tests/ValidityState-tooLong-textarea.js: Added.
      2009-09-30  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Darin Adler.
      
              Adds ValidityState.tooLong support for <input> and <textarea>.
      
              Introduces tooLong() in HTMLFormControlElement and it always returns false.
              HTMLInputElement and HTMLTextAreaElement overrides it and checks the text
              length and maxLength.  tooLong() should work only for `dirty' values.
              So, introduces m_isDirty flag for HTMLTextAreaElement, and
              !m_data.value().isNull() works as a dirty flag for HTMLInputElement.
      
              Renames parameter names of setMaxLength().
      
              https://bugs.webkit.org/show_bug.cgi?id=27454
      
              Tests: fast/forms/ValidityState-tooLong-input.html
                     fast/forms/ValidityState-tooLong-textarea.html
      
              * html/HTMLFormControlElement.h:
              (WebCore::HTMLFormControlElement::tooLong):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::tooLong):
              (WebCore::HTMLInputElement::setMaxLength):
              * html/HTMLInputElement.h:
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
              (WebCore::HTMLTextAreaElement::reset):
              (WebCore::HTMLTextAreaElement::updateValue):
              (WebCore::HTMLTextAreaElement::setMaxLength):
              (WebCore::HTMLTextAreaElement::tooLong):
              * html/HTMLTextAreaElement.h:
              * html/ValidityState.h:
              (WebCore::ValidityState::tooLong):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03159e8a
    • mjs@apple.com's avatar
      2009-09-30 Maciej Stachowiak <mjs@apple.com> · 67d34954
      mjs@apple.com authored
              Reviewed by Brady Eidson.
      
              307 redirects should pass along http body and Content-Type header
              https://bugs.webkit.org/show_bug.cgi?id=29943
      
              Follow-up fix for:
              <rdar://problem/3802660> SAP: 307 (Temporary Redirect) responses should use POST, not GET
              
              Test: http/tests/loading/resources/redirect-methods-result.php
      
              * platform/network/cf/ResourceHandleCFNet.cpp:
              (WebCore::willSendRequest): Pass along http body and Content-Type header.
              * platform/network/mac/ResourceHandleMac.mm:
              (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): ditto
      2009-09-30  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Brady Eidson.
      
              307 redirects should pass along http body and Content-Type header
              https://bugs.webkit.org/show_bug.cgi?id=29943
      
              Follow-up fix for:
              <rdar://problem/3802660> SAP: 307 (Temporary Redirect) responses should use POST, not GET
      
              * http/tests/loading/redirect-methods.html: Updated test to show the http body and content-type header.
              * http/tests/loading/redirect-methods-expected.txt:
              * http/tests/loading/resources/redirect-methods-result.php: 
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67d34954
    • jorlow@chromium.org's avatar
      2009-09-30 Jeremy Orlow <jorlow@chromium.org> · a24eed18
      jorlow@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Use a script-tests directory rather than a resources directory for DOM Storage
              https://bugs.webkit.org/show_bug.cgi?id=29938
      
              Use a script-tests directory rather than a resources directory for DOM Storage.
              This matches up with what's been done elsewhere in the tree.
      
              * storage/domstorage/localstorage/clear.html:
              * storage/domstorage/resources: Removed.
              * storage/domstorage/resources/clear.js: Removed.
              * storage/domstorage/script-tests: Copied from LayoutTests/storage/domstorage/resources.
              * storage/domstorage/sessionstorage/clear.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a24eed18
    • mitz@apple.com's avatar
      REGRESSION(r47440): drop down menus at americanexpress.com disappear on mouse out · 66bc5f4e
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=29209
      
      Reviewed by Sam Weinig.
      
      WebCore: 
      
      Test: fast/inline/relative-positioned-overflow.html
      
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::computeVerticalOverflow): Add self-painting
      inlines to overflow to ensure that they are included in hit-testing.
      
      LayoutTests: 
      
      * fast/inline/relative-positioned-overflow-expected.txt: Added.
      * fast/inline/relative-positioned-overflow.html: Added.
      * platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66bc5f4e
    • jianli@chromium.org's avatar
      Need to check NULL frame in EventHandler::updateDragAndDrop. · 00364e3d
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=29929
      
      Reviewed by Darin Adler.
      
      WebCore:
      
      Test: http/tests/misc/drag-over-iframe-invalid-source-crash.html
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::updateDragAndDrop):
      
      LayoutTests:
      
      Add a new test for the bug.
      
      * http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt: Added.
      * http/tests/misc/drag-over-iframe-invalid-source-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00364e3d
    • simon.fraser@apple.com's avatar
      2009-09-29 Simon Fraser <simon.fraser@apple.com> · 195d0d67
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein.
      
              ASSERTION FAILED: !repaintContainer || repaintContainer == this
              https://bugs.webkit.org/show_bug.cgi?id=29755
      
              Generalize the fix for this bug to account for cases where there may be multiple
              containing blocks between the repaint container, and the container of the element
              being repainted.
      
              Test: compositing/repaint/opacity-between-absolute2.html
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::mapLocalToContainer):
              Call offsetFromAncestorContainer() to get the correct offset.
      
              (WebCore::RenderBox::computeRectForRepaint): Ditto
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::computeRectForRepaint): Ditto.
      
              * rendering/RenderObject.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::offsetFromAncestorContainer):
              New method that computes an offset from some object in the ancestor container() chain.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      195d0d67
    • hausmann@webkit.org's avatar
      [Qt] Update Skipped after #48873 and some expected files, whose · a4200b64
      hausmann@webkit.org authored
      problems are the same (default font size reconciliation
      16px/13px), but the previous update didn't contain them.
      
      Patch by Renata Hodovan <hodovan.renata@stud.u-szeged.hu> on 2009-09-30
      Reviewed by Simon Hausmann.
      
      * platform/qt/Skipped:
      * platform/qt/css2.1/t040103-ident-04-c-expected.txt:
      * platform/qt/css2.1/t0402-c71-fwd-parsing-00-f-expected.txt:
      * platform/qt/css2.1/t040304-c64-uri-00-a-g-expected.txt:
      * platform/qt/css2.1/t040306-syntax-01-f-expected.txt:
      * platform/qt/css2.1/t1202-counter-05-b-expected.txt:
      * platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
      * platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.txt:
      * platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4200b64
    • eric@webkit.org's avatar
      2009-09-30 Shinichiro Hamaji <hamaji@chromium.org> · e7501510
      eric@webkit.org authored
              Reviewed by David Levin.
      
              Move message-port-multi.js from resources to script-tests
              https://bugs.webkit.org/show_bug.cgi?id=29798
      
              Revert r48823. message-port-multi.js needs custom HTML.
      
              * fast/events/message-port-multi-expected.txt:
              * fast/events/message-port-multi.html:
              * fast/events/resources/message-port-multi.js: Added.
              (channel.port2.onmessage):
              * fast/events/script-tests/message-port-multi.js: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7501510
    • eric@webkit.org's avatar
      2009-09-30 Shinichiro Hamaji <hamaji@chromium.org> · f670f333
      eric@webkit.org authored
              Reviewed by David Kilzer.
      
              Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
              https://bugs.webkit.org/show_bug.cgi?id=12140
      
              Fixes for JS files.
      
              * fast/js/date-preserve-milliseconds-expected.txt:
              * fast/js/script-tests/array-float-delete.js:
              * fast/js/script-tests/array-tostring-ignore-separator.js:
              * fast/js/script-tests/date-big-setmonth.js:
              * fast/js/script-tests/date-negative-setmonth.js:
              * fast/js/script-tests/date-preserve-milliseconds.js:
              * fast/js/script-tests/number-tofixed.js:
              * fast/js/script-tests/object-extra-comma.js:
              * fast/js/script-tests/object-prototype-constructor.js:
              * fast/js/script-tests/object-prototype-toLocaleString.js:
              * fast/js/script-tests/regexp-lastindex.js:
              * fast/js/script-tests/regexp-stack-overflow.js:
              * fast/js/script-tests/string-split-ignore-case.js:
              * fast/js/script-tests/toString-exception.js:
              * fast/js/script-tests/toString-overrides.js:
              * fast/js/script-tests/toString-stack-overflow.js:
              * fast/js/toString-stack-overflow-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f670f333
    • eric@webkit.org's avatar
      2009-09-30 Steve Block <steveblock@google.com> · 98a05b0a
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Geolocation LayoutTests should use an HTML template.
              https://bugs.webkit.org/show_bug.cgi?id=29179
      
              Updates Geolocation LayoutTests to correctly use an HTML template so that
              individual HTML files can be generated using make-script-test-wrappers.
              This requires a new js-test-post.js which allows for asynchronous tests.
      
              * fast/dom/Geolocation/resources/TEMPLATE.html: Modified. Updated to use new js-test-post.js.
              * fast/dom/Geolocation/resources/js-test-post.js: Added. Allows for asynchronous tests.
      
              * fast/dom/Geolocation/resources/argument-types.js: Modified. Sepcifies synchronous test.
              * fast/dom/Geolocation/argument-types.html: Modified. Updated to use new js-test-post.js.
      
              * fast/dom/Geolocation/resources/callback-exception.js: Modified. Specifies asynchronous test.
              * fast/dom/Geolocation/callback-exception.html: Modified. Updated to use new js-test-post.js.
              * fast/dom/Geolocation/callback-exception-expected.txt: Modified. Adds successfullyParsed.
      
              * fast/dom/Geolocation/resources/enabled.js: Modified. Sepcifies synchronous test.
              * fast/dom/Geolocation/enabled.html: Modified. Updated to use new js-test-post.js.
      
              * fast/dom/Geolocation/resources/error.js: Modified. Specifies asynchronous test.
              * fast/dom/Geolocation/error.html: Modified. Updated to use new js-test-post.js.
              * fast/dom/Geolocation/error-expected.txt: Modified. Adds successfullyParsed.
      
              * fast/dom/Geolocation/resources/permission-denied.js: Modified. Specifies asynchronous test.
              * fast/dom/Geolocation/permission-denied.html: Modified. Updated to use new js-test-post.js.
              * fast/dom/Geolocation/permission-denied-expected.txt: Modified. Adds successfullyParsed.
      
              * fast/dom/Geolocation/resources/permission-denied-stops-watches.js: Modified. Specifies asynchronous test.
              * fast/dom/Geolocation/permission-denied-stops-watches.html: Modified. Updated to use new js-test-post.js.
              * fast/dom/Geolocation/permission-denied-stops-watches-expected.txt: Modified. Adds successfullyParsed.
      
              * fast/dom/Geolocation/resources/position-string.js: Modified. Specifies asynchronous test.
              * fast/dom/Geolocation/position-string.html: Modified. Updated to use new js-test-post.js.
              * fast/dom/Geolocation/position-string-expected.txt: Modified. Adds successfullyParsed.
      
              * fast/dom/Geolocation/resources/reentrant-error.js: Modified. Specifies asynchronous test.
              * fast/dom/Geolocation/reentrant-error.html: Modified. Updated to use new js-test-post.js.
              * fast/dom/Geolocation/reentrant-error-expected.txt: Modified. Adds successfullyParsed.
      
              * fast/dom/Geolocation/resources/reentrant-success.js: Modified. Specifies asynchronous test.
              * fast/dom/Geolocation/reentrant-success.html: Modified. Updated to use new js-test-post.js.
              * fast/dom/Geolocation/reentrant-success-expected.txt: Modified. Adds successfullyParsed.
      
              * fast/dom/Geolocation/resources/success.js: Modified. Specifies asynchronous test.
              * fast/dom/Geolocation/success.html: Modified. Updated to use new js-test-post.js.
              * fast/dom/Geolocation/success-expected.txt: Modified. Adds successfullyParsed.
      
              * fast/dom/Geolocation/resources/timeout.js: Modified. Specifies asynchronous test.
              * fast/dom/Geolocation/timeout.html: Modified. Updated to use new js-test-post.js.
              * fast/dom/Geolocation/timeout-expected.txt: Modified. Adds successfullyParsed.
      
              * fast/dom/Geolocation/resources/timeout-zero.js: Modified. Specifies asynchronous test.
              * fast/dom/Geolocation/timeout-zero.html: Modified. Updated to use new js-test-post.js.
              * fast/dom/Geolocation/timeout-zero-expected.txt: Modified. Adds successfullyParsed.
      
              * fast/dom/Geolocation/resources/watch.js: Modified. Specifies asynchronous test.
              * fast/dom/Geolocation/watch.html: Updated to use new js-test-post.js.
              * fast/dom/Geolocation/watch-expected.txt: Modified. Adds successfullyParsed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98a05b0a
    • hamaji@chromium.org's avatar
      2009-09-29 Shinichiro Hamaji <hamaji@chromium.org> · b1658259
      hamaji@chromium.org authored
              Reviewed by Eric Seidel.
      
              Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
              https://bugs.webkit.org/show_bug.cgi?id=12140
      
              Remove opendarwin URLs from href="".
              This change doesn't change pixel test results.
      
              * editing/pasteboard/display-block-on-spans.html:
              * editing/pasteboard/drop-text-without-selection.html:
              * editing/pasteboard/paste-text-019.html:
              * editing/selection/6476.html:
              * editing/selection/7152-1.html:
              * editing/selection/7152-2.html:
              * editing/selection/after-line-wrap.html:
              * editing/selection/click-start-of-line.html:
              * editing/selection/leave-requested-block.html:
              * editing/selection/select-from-textfield-outwards.html:
              * fast/block/basic/text-indent-rtl.html:
              * fast/block/float/nopaint-after-layer-destruction.html:
              * fast/block/float/nopaint-after-layer-destruction2.html:
              * fast/block/float/table-relayout.html:
              * fast/block/float/vertical-move-relayout.html:
              * fast/block/positioning/height-change.html:
              * fast/block/positioning/relayout-on-position-change.html:
              * fast/block/positioning/window-height-change.html:
              * fast/css-generated-content/hover-style-change.html: Added property allow-tabs.
              * fast/css/error-in-last-decl.html:
              * fast/css/ex-after-font-variant.html:
              * fast/css/find-next-layer.html:
              * fast/css/first-letter-detach.html:
              * fast/css/font-shorthand-weight-only.html:
              * fast/css/hover-subselector.html:
              * fast/css/invalidation-errors-2.html:
              * fast/css/invalidation-errors-3.html:
              * fast/css/invalidation-errors.html:
              * fast/css/resize-corner-tracking.html:
              * fast/css/rtl-ordering.html:
              * fast/css/universal-hover-quirk.html:
              * fast/dom/Element/class-attribute-whitespace.html: Added property allow-tabs.
              * fast/dom/HTMLHeadElement/head-link-style-href-check.html:
              * fast/dom/HTMLLinkElement/pending-stylesheet-count.html:
              * fast/dynamic/layer-hit-test-crash.html:
              * fast/dynamic/selection-highlight-adjust.html:
              * fast/encoding/resources/%25%u0435 0 %xx%%%ulike.html:
              * fast/events/event-sender-mouse-moved.html:
              * fast/events/resources/drag-outside-window-frame.html:
              * fast/forms/button-cannot-be-nested.html:
              * fast/forms/button-generated-content.html:
              * fast/forms/button-inner-block-reuse.html:
              * fast/forms/button-white-space.html:
              * fast/forms/floating-textfield-relayout.html:
              * fast/forms/form-hides-table.html:
              * fast/forms/visual-hebrew-text-field.html:
              * fast/history/clicked-link-is-visited.html:
              * fast/history/resources/clicked-link-is-visited-2.html:
              * fast/inline-block/overflow-clip.html:
              * fast/invalid/missing-address-end-tag.html:
              * fast/invalid/missing-dl-end-tag.html:
              * fast/invalid/missing-dt-end-tag.html:
              * fast/invalid/missing-font-end-tag.html:
              * fast/js/exception-linenums-in-html-3.html:
              * fast/js/missing-style-end-tag-js.html:
              * fast/layers/opacity-outline.html:
              * fast/lists/list-style-none-crash.html:
              * fast/lists/markers-in-selection.html:
              * fast/lists/scrolled-marker-paint.html:
              * fast/overflow/image-selection-highlight.html:
              * fast/overflow/overflow-rtl-inline-scrollbar.html:
              * fast/parser/broken-comments-vs-parsing-mode.html:
              * fast/parser/nofoo-tags-inside-paragraph.html:
              * fast/parser/remove-block-in-residual-style.html:
              * fast/repaint/backgroundSizeRepaint.html:
              * fast/repaint/border-repaint-glitch.html:
              * fast/repaint/bugzilla-3509.html:
              * fast/repaint/bugzilla-5699.html:
              * fast/repaint/bugzilla-6278.html:
              * fast/repaint/bugzilla-6388.html:
              * fast/repaint/bugzilla-6473.html:
              * fast/repaint/bugzilla-7235.html:
              * fast/repaint/clipped-relative.html:
              * fast/repaint/containing-block-position-change.html:
              * fast/repaint/flexible-box-overflow-horizontal.html:
              * fast/repaint/flexible-box-overflow.html:
              * fast/repaint/float-move-during-layout.html:
              * fast/repaint/inline-outline-repaint.html:
              * fast/repaint/layer-outline-horizontal.html:
              * fast/repaint/layer-outline.html:
              * fast/repaint/line-overflow.html:
              * fast/repaint/outline-repaint-glitch.html:
              * fast/repaint/outline-shrinking.html:
              * fast/repaint/repaint-resized-overflow.html:
              * fast/repaint/static-to-positioned.html:
              * fast/repaint/table-cell-move.html:
              * fast/repaint/table-extra-bottom-grow.html:
              * fast/repaint/text-shadow-horizontal.html:
              * fast/repaint/text-shadow.html:
              * fast/replaced/applet-rendering-java-disabled.html:
              * fast/replaced/image-solid-color-with-alpha.html:
              * fast/replaced/inline-box-wrapper-handover.html:
              * fast/replaced/pdf-as-image.html:
              * fast/table/absolute-table-at-bottom.html:
              * fast/table/add-before-anonymous-child.html:
              * fast/table/border-collapsing/003.html:
              * fast/table/border-collapsing/border-collapsing-head-foot.html:
              * fast/table/border-collapsing/rtl-border-collapsing.html:
              * fast/table/cell-absolute-child.html:
              * fast/table/click-near-anonymous-table.html:
              * fast/table/edge-offsets.html:
              * fast/table/empty-section-crash.html:
              * fast/table/fixed-table-non-cell-in-row.html:
              * fast/table/form-with-table-style.html:
              * fast/table/row-height-recalc.html:
              * fast/table/rtl-cell-display-none-assert.html:
              * fast/table/text-field-baseline.html:
              * fast/text/atsui-small-caps-punctuation-size.html:
              * fast/text/atsui-spacing-features.html:
              * fast/text/basic/015.html:
              * fast/text/capitalize-empty-generated-string.html:
              * fast/text/in-rendered-text-rtl.html:
              * fast/text/international/rtl-caret.html:
              * fast/text/midword-break-hang.html:
              * fast/text/whitespace/pre-wrap-overflow-selection.html:
              * fast/text/whitespace/pre-wrap-spaces-after-newline.html:
              * fast/tokenizer/missing-style-end-tag-1.html:
              * fast/tokenizer/missing-style-end-tag-2.html:
              * fast/tokenizer/missing-title-end-tag-1.html:
              * fast/tokenizer/missing-title-end-tag-2.html:
              * http/tests/misc/iframe404.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1658259
  3. 29 Sep, 2009 12 commits
    • beidson@apple.com's avatar
      WebKit Mac API should provide a delegate interface for global history. · b0b8ef70
      beidson@apple.com authored
      <rdar://problem/7042773> and https://webkit.org/b/29904
      
      Reviewed by John Sullivan.
      
      WebKit: 
      
      * WebKit.xcodeproj/project.pbxproj:
      
      WebKit/mac: 
      
      * WebView/WebHistoryDelegate.h: Added. New interface for WebKit clients to implement to manage 
        their own global history store.
      
      Object to store all of the bits of data relevant to a page visit:
      * WebView/WebNavigationData.h: Added.
      * WebView/WebNavigationData.mm: Added.
      (-[WebNavigationDataPrivate dealloc]):
      (-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
      (-[WebNavigationData url]):
      (-[WebNavigationData title]):
      (-[WebNavigationData originalRequest]):
      (-[WebNavigationData response]):
      (-[WebNavigationData hasSubstituteData]):
      (-[WebNavigationData clientRedirectSource]):
      (-[WebNavigationData dealloc]):
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::updateGlobalHistory): If the delegate exists, don't use the built-in WebHistory.
        If the implementation for this method exists, call it.
      (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Ditto
      
      * WebView/WebDelegateImplementationCaching.h:
      * WebView/WebDelegateImplementationCaching.mm:
      (WebViewGetHistoryDelegateImplementations):
      (CallHistoryDelegate):
      
      * WebView/WebView.mm:
      (-[WebView _cacheHistoryDelegateImplementations]):
      (-[WebView setHistoryDelegate:]):
      (-[WebView historyDelegate]):
      * WebView/WebViewData.h:
      * WebView/WebViewPrivate.h:
      
      WebKitTools: 
      
      Adding the dumping of global history delegate callbacks.
      
      * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
      
      Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
      * DumpRenderTree/mac/DumpRenderTree.mm:
      (createWebViewAndOffscreenWindow):
      (allocateGlobalControllers):
      (shouldLogFrameLoadDelegates):
      (shouldLogHistoryDelegates):
      (runTest):
      
      Dump history delegate callbacks:
      * DumpRenderTree/mac/HistoryDelegate.h: Added.
      * DumpRenderTree/mac/HistoryDelegate.mm: Added.
      (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
      (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
      (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
      
      LayoutTests: 
      
      * http/tests/globalhistory: Added.
      * http/tests/globalhistory/history-delegate-basic-302-redirect-expected.txt: Added.
      * http/tests/globalhistory/history-delegate-basic-302-redirect.html: Added.
      * http/tests/globalhistory/history-delegate-basic-refresh-redirect-expected.txt: Added.
      * http/tests/globalhistory/history-delegate-basic-refresh-redirect.html: Added.
      * http/tests/resources/notify-done.html: Added.
      * http/tests/resources/redirect.php: Augment to optionally do "Refresh:"-style redirects.
      
      Skip these new tests on all platforms that don't have history delegates (yet):
      * platform/gtk/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0b8ef70
    • dbates@webkit.org's avatar
      2009-09-29 Daniel Bates <dbates@webkit.org> · 59ac2d39
      dbates@webkit.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=29837
              
              More tests for the XSSAuditor.
      
              * http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt: Added.
              * http/tests/security/xssAuditor/embed-tag-javascript-url.html: Added.
              * http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt: Added.
              * http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url.html: Added.
              * http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt: Added.
              * http/tests/security/xssAuditor/object-tag-javascript-url.html: Added.
              * http/tests/security/xssAuditor/property-escape-noquotes-expected.txt: Added.
              * http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars-expected.txt: Added.
              * http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars.html: Added.
              * http/tests/security/xssAuditor/property-escape-noquotes.html: Added.
              * http/tests/security/xssAuditor/property-inject-expected.txt: Added.
              * http/tests/security/xssAuditor/property-inject.html: Added.
              * http/tests/security/xssAuditor/resources/echo-head.pl: Added.
              * http/tests/security/xssAuditor/resources/echo-inner-tag.pl: Added.
              * http/tests/security/xssAuditor/resources/echo-property-noquotes.pl: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59ac2d39
    • eric@webkit.org's avatar
      2009-09-29 Enrica Casucci <enrica@apple.com> · 5fbc25ce
      eric@webkit.org authored
              Reviewed by Adele Peterson.
      
              Test case for <rdar://problem/7085453>.
      
              * editing/selection/blockquote-crash-expected.txt: Added.
              * editing/selection/blockquote-crash.html: Added.
      2009-09-29  Enrica Casucci  <enrica@apple.com>
      
              Reviewed by Adele Peterson.
      
              Reproducible crash pressing return inside quoted content
              at WebCore::BreakBlockquoteCommand::doApply.
              <rdar://problem/7085453>
              In some case, like the one provided in the test case, m_downStreamEnd
              refers to a node that gets deleted when executing the DeleteSelectionCommand.
              We shouldn't use m_downStreamEnd to recalculate the new m_endPosition when
              pruning is needed, because it may be point to a node that has been deleted, but
              rather rely on removeNode in CompositeEditCommand to update m_endPosition correctly.
      
              Test: editing/selection/blockquote-crash.html
      
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockquoteCommand::doApply): Added check for invalid position
              to avoid dereferencing a null node pointer.
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::mergeParagraphs): Don't reset m_endPosition
              using the value in m_downStreamEnd when it is necessary to prune the start block.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fbc25ce
    • eric@webkit.org's avatar
      2009-09-29 Kent Tamura <tkent@chromium.org> · d71be72a
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Update for .maxLength behavior change.
              https://bugs.webkit.org/show_bug.cgi?id=29796
      
              * fast/forms/input-maxlength-expected.txt:
              * fast/forms/input-maxlength.html:
              * fast/forms/script-tests/textarea-maxlength.js:
              * fast/forms/textarea-maxlength-expected.txt:
      2009-09-29  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Darin Adler.
      
              Follows HTML5's maxLength change in September 2009.
              - Change HTMLTextAreaElement.maxLength type to signed.
              - HTMLTextAreaElement.maxLength returns -1 if maxlength= attribute is missing.
              - HTMLTextAreaElement.maxLength and HTMLInputElement.maxLength
                throw INDEX_SIZE_ERR for setting negative values.
              https://bugs.webkit.org/show_bug.cgi?id=29796
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::setMaxLength):
              * html/HTMLInputElement.h:
              * html/HTMLInputElement.idl:
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
              (WebCore::HTMLTextAreaElement::maxLength):
              (WebCore::HTMLTextAreaElement::setMaxLength):
              * html/HTMLTextAreaElement.h:
              * html/HTMLTextAreaElement.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d71be72a
    • krit@webkit.org's avatar
      2009-09-29 Dirk Schulze <krit@webkit.org> · 42b5c8a6
      krit@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              SVG Filter feComposite implementation is missing
              [https://bugs.webkit.org/show_bug.cgi?id=28362]
      
              feComposite implementation for SVG.
      
              Test: svg/filters/feComposite.svg
      
              * platform/graphics/filters/FEComposite.cpp:
              (WebCore::arithmetic):
              (WebCore::FEComposite::apply):
      
              Tests the feComposite implementation for SVG.
      
              * platform/mac/svg/filters/feComposite-expected.checksum: Added.
              * platform/mac/svg/filters/feComposite-expected.png: Added.
              * platform/mac/svg/filters/feComposite-expected.txt: Added.
              * svg/filters/feComposite.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42b5c8a6
    • eric@webkit.org's avatar
      2009-09-29 Shinichiro Hamaji <hamaji@chromium.org> · b5c79938
      eric@webkit.org authored
              Reviewed by David Kilzer.
      
              Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
              https://bugs.webkit.org/show_bug.cgi?id=12140
      
              Change the URLs in dumpAsText tests.
      
              * editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
              * editing/deleting/delete-all-text-in-text-field-assertion.html:
              * fast/dom/Document/doc-open-while-parsing.html:
              * fast/dom/Document/document-reopen.html:
              * fast/dom/Element/setAttribute-case-insensitivity.html:
              * fast/dom/HTMLHeadElement/head-check.html:
              * fast/dom/HTMLImageElement/image-without-renderer-width-expected.txt:
              * fast/dom/HTMLImageElement/image-without-renderer-width.html:
              * fast/dom/HTMLScriptElement/script-load-events-expected.txt:
              * fast/dom/HTMLScriptElement/script-load-events.html:
              * fast/dom/clone-node-form-elements-with-attr.html:
              * fast/dom/document-dir-property-expected.txt:
              * fast/dom/document-dir-property.html:
              * fast/dom/everything-to-string.html:
              * fast/dom/generic-form-element-assert-expected.txt:
              * fast/dom/generic-form-element-assert.html:
              * fast/dom/inner-text-rtl-expected.txt:
              * fast/dom/inner-text-rtl.html:
              * fast/dom/navigator-vendorSub.html:
              * fast/dom/option-properties-expected.txt:
              * fast/dom/option-properties.html:
              * fast/dom/replace-child-siblings-expected.txt:
              * fast/dom/replace-child-siblings.html:
              * fast/dom/replace-first-child.html:
              * fast/dom/setAttribute-using-initial-input-value.html:
              * fast/dom/space-to-text.html:
              * fast/dynamic/hovered-detach-expected.txt:
              * fast/dynamic/hovered-detach.html:
              * fast/encoding/charset-koi8-u.html:
              * fast/encoding/css-charset-dom.html:
              * fast/encoding/css-charset-evil.html:
              * fast/encoding/css-charset.html:
              * fast/encoding/latin1-winlatin.html:
              * fast/encoding/mispositioned-meta.html:
              * fast/encoding/percent-escaping.html:
              * fast/encoding/pseudo-xml-2.html:
              * fast/encoding/pseudo-xml-3.html:
              * fast/encoding/pseudo-xml-4.html:
              * fast/encoding/pseudo-xml.html:
              * fast/events/init-event-null-view.html:
              * fast/events/mouseover-mouseout.html:
              * fast/events/mouseover-mouseout2.html:
              * fast/events/onload-webkit-before-webcore.html:
              * fast/forms/button-in-forms-collection.html:
              * fast/forms/document-write.html:
              * fast/forms/domstring-replace-crash-expected.txt:
              * fast/forms/domstring-replace-crash.html:
              * fast/forms/element-by-name.html:
              * fast/forms/empty-get.html:
              * fast/forms/form-data-encoding-normalization-overrun.html:
              * fast/forms/radio-button-no-change-event.html:
              * fast/forms/selected-index-assert-expected.txt:
              * fast/forms/selected-index-assert.html:
              * fast/forms/textarea-hard-linewrap-empty-expected.txt:
              * fast/forms/textarea-hard-linewrap-empty.html:
              * fast/forms/textfield-focus-out-expected.txt:
              * fast/forms/textfield-focus-out.html:
              * fast/frames/empty-frame-document-expected.txt:
              * fast/frames/empty-frame-document.html:
              * fast/frames/frame-name-reset.html:
              * fast/frames/frame-set-same-location.html:
              * fast/frames/frame-set-same-src.html:
              * fast/frames/frameElement-widthheight.html:
              * fast/frames/iframe-name-and-id-expected.txt:
              * fast/frames/iframe-name-and-id.html:
              * fast/frames/iframe-set-same-location.html:
              * fast/frames/iframe-set-same-src.html:
              * fast/frames/repaint-display-none-crash-expected.txt:
              * fast/frames/repaint-display-none-crash.html:
              * fast/js/exception-linenums-in-html-2.html:
              * fast/js/missing-title-end-tag-js.html:
              * fast/loader/link-no-URL.html:
              * fast/loader/url-strip-cr-lf-tab.html:
              * fast/overflow/generated-content-crash-expected.txt:
              * fast/overflow/generated-content-crash.html:
              * fast/parser/number-sign-in-map-name.html:
              * fast/parser/remove-current-node-parent.html:
              * fast/parser/script-after-frameset-assert.html:
              * fast/tokenizer/image-empty-crash-expected.txt:
              * fast/tokenizer/image-empty-crash.html:
              * fast/tokenizer/nested-cached-scripts-expected.txt:
              * fast/tokenizer/nested-cached-scripts.html:
              * fast/tokenizer/write-unclosed-script-expected.txt:
              * fast/tokenizer/write-unclosed-script.html:
              * fast/xsl/transformToFragment-XML-declaration.html:
              * http/tests/misc/text-refresh.html:
              * http/tests/plugins/npapi-response-headers.html:
              * http/tests/uri/utf8-path.html:
              * http/tests/xmlhttprequest/cache-override.html:
              * http/tests/xmlhttprequest/event-listener-gc-expected.txt:
              * http/tests/xmlhttprequest/event-listener-gc.html:
              * http/tests/xmlhttprequest/event-target.html:
              * http/tests/xmlhttprequest/frame-load-cancelled-abort.html:
              * http/tests/xmlhttprequest/interactive-state.html:
              * http/tests/xmlhttprequest/methods-async.html:
              * http/tests/xmlhttprequest/methods-lower-case.html:
              * http/tests/xmlhttprequest/methods.html:
              * http/tests/xmlhttprequest/post-content-type.html:
              * http/tests/xmlhttprequest/readystatechange.html:
              * http/tests/xmlhttprequest/supported-xml-content-types.html:
              * http/tests/xmlhttprequest/xhr-onunload.html:
              * http/tests/xmlhttprequest/zero-length-response.html:
              * platform/mac/fast/events/objc-event-api.html:
              * platform/mac/fast/events/objc-keyboard-event-creation.html:
              * plugins/get-empty-url.html:
              * plugins/geturl-replace-query.html:
              * plugins/invoke.html:
              * plugins/mouse-events.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5c79938
    • japhet@chromium.org's avatar
      2009-09-29 Nate Chapin <japhet@chromium.org> · f0ef993c
      japhet@chromium.org authored
              Reviewed by Eric Seidel.
      
              Ensure that we don't scroll lock to an anchor node after a
              user-initiated scroll, even if that scroll doesn't propagate
              all the way up to FrameView.
      
              Test: fast/events/node-event-anchor-lock.html
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0ef993c
    • ap@apple.com's avatar
      Reviewed by Darin Adler and Sam Weinig. · 06431f3d
      ap@apple.com authored
              Onclick not fired for an element copied with cloneContents() or cloneNode()
              https://bugs.webkit.org/show_bug.cgi?id=25130
      
              The change here is that JS event listeners don't keep a reference to a global object from
              where they were created, and instead take it as a parameter when parsing source code. Also,
              the listener creation won't fail just because it happens for an element in a frameless
              document.
              Thus, moving nodes between documents no longer results in having incorrect registered
              lazy event listeners on them.
      
              Tests: fast/events/attribute-listener-cloned-from-frameless-doc-context-2.html
                     fast/events/attribute-listener-cloned-from-frameless-doc-context.html
                     fast/events/attribute-listener-cloned-from-frameless-doc.xhtml
                     fast/events/attribute-listener-extracted-from-frameless-doc-context-2.html
                     fast/events/attribute-listener-extracted-from-frameless-doc-context.html
      
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSEventListener::JSEventListener): Don't take a reference to JSDOMGlobalObject.
              (WebCore::JSEventListener::jsFunction): Take ScriptExecutionContext as a parameter for
              getting to JSDOMGlobalObject. It's not used in base class, but is in JSLazyEventListner.
              (WebCore::JSEventListener::markJSFunction): Don't mark the global object.
              (WebCore::JSEventListener::handleEvent): Get global object from ScriptExecutionContext.
              (WebCore::JSEventListener::reportError): Ditto.
      
              * bindings/js/JSEventListener.h: (WebCore::JSEventListener::create): Don't keep a reference
              to JSDOMGlobalObject.
      
              * bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Listener
              creation was split between this function and ScriptEventListener; moved it here, as JS
              global object can be different now.
      
              * bindings/js/JSLazyEventListener.h: (WebCore::JSLazyEventListener::create): Keep source URL,
              which can not be determined at parsing time.
      
              * bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Moved code
              for listener creation to JSLazyEventListener. XSSAuditor code remains here, because tests
              expect that errors are logged at document parsing time, and because I don't know what other
              side effects moving it vould have.
      
              * dom/EventListener.h: handleEvent() and reportError() now take ScriptExecutionContext,
              because JSC needs a global context here.
      
              * bindings/js/JSAbstractWorkerCustom.cpp:
              (WebCore::JSAbstractWorker::addEventListener):
              (WebCore::JSAbstractWorker::removeEventListener):
              * bindings/js/JSDOMApplicationCacheCustom.cpp:
              (WebCore::JSDOMApplicationCache::addEventListener):
              (WebCore::JSDOMApplicationCache::removeEventListener):
              * bindings/js/JSDOMGlobalObject.cpp:
              (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::addEventListener):
              (WebCore::JSDOMWindow::removeEventListener):
              * bindings/js/JSEventSourceCustom.cpp:
              (WebCore::JSEventSource::addEventListener):
              (WebCore::JSEventSource::removeEventListener):
              * bindings/js/JSMessagePortCustom.cpp:
              (WebCore::JSMessagePort::addEventListener):
              (WebCore::JSMessagePort::removeEventListener):
              * bindings/js/JSNodeCustom.cpp:
              (WebCore::JSNode::addEventListener):
              (WebCore::JSNode::removeEventListener):
              * bindings/js/JSSVGElementInstanceCustom.cpp:
              (WebCore::JSSVGElementInstance::addEventListener):
              (WebCore::JSSVGElementInstance::removeEventListener):
              * bindings/js/JSWorkerContextCustom.cpp:
              (WebCore::JSWorkerContext::addEventListener):
              (WebCore::JSWorkerContext::removeEventListener):
              * bindings/js/JSXMLHttpRequestCustom.cpp:
              (WebCore::JSXMLHttpRequest::addEventListener):
              (WebCore::JSXMLHttpRequest::removeEventListener):
              * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
              (WebCore::JSXMLHttpRequestUpload::addEventListener):
              (WebCore::JSXMLHttpRequestUpload::removeEventListener):
              * bindings/objc/ObjCEventListener.h:
              * bindings/objc/ObjCEventListener.mm:
              (WebCore::ObjCEventListener::handleEvent):
              * bindings/scripts/CodeGeneratorJS.pm:
              * dom/EventTarget.cpp:
              (WebCore::EventTarget::fireEventListeners):
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::handleEvent):
              * inspector/InspectorDOMAgent.h:
              * inspector/InspectorDOMStorageResource.cpp:
              (WebCore::InspectorDOMStorageResource::handleEvent):
              * inspector/InspectorDOMStorageResource.h:
              * loader/ImageDocument.cpp:
              (WebCore::ImageEventListener::handleEvent):
              * svg/animation/SVGSMILElement.cpp:
              (WebCore::ConditionEventListener::handleEvent):
              * workers/WorkerContext.cpp:
              (WebCore::WorkerContext::reportException):
              Don't pass global object to JSEventListener::create(), which no longer needs it.
              Note that some of these functions still have an early return for null global object, which
              can probably be removed in a later patch.
              Pass ScriptExecutionContext to EventListener methods that now need it.
      
              * bindings/scripts/CodeGeneratorCOM.pm: Don't force EventTarget implementation on Node -
              it doesn't work yet (it didn't quite work before this patch, too, because it assumed that
              any object implementing EventTarget COM interface originated from WebCore).
      
              * dom/EventListener.idl: Just like in ObjC, EventListener should be a pure interface in
              COM bindings.
      
      WebKit/win:
              * DOMCreateInstance.cpp: GEN_DOMEventListener is a pure interface now.
      
              * WebKit.vcproj/WebKit.vcproj: Removed GEN_DOMEventListener.cpp.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06431f3d
    • ap@apple.com's avatar
      Reviewed by Brady Eidson. · 549845e7
      ap@apple.com authored
              <rdar://problem/7259965> REGRESSION: http/tests/xmlhttprequest/cross-origin-authorization.html
              is failing/crashing intermittently
              https://bugs.webkit.org/show_bug.cgi?id=29322
      
              This was caused by CStringBuffer::encodeBase64() returning a buffer that wasn't zero terminated.
              The code had other issues as well, so I removed it altogether:
              - it claimed to avoid some buffer copies, but it didn't;
              - and I don't think that base64 encoding should be part of CString interface.
      
      
      WebCore:
              * platform/network/mac/ResourceHandleMac.mm:
              (WebCore::encodeBasicAuthorization): Encode username and password using Base64.h directly.
              (WebCore::ResourceHandle::start): Use encodeBasicAuthorization().
              (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Ditto.
              (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Extended logging
              to synchronous case.
              (-[WebCoreSynchronousLoader connectionShouldUseCredentialStorage:]): Ditto.
              (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
              (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): Ditto.
              (-[WebCoreSynchronousLoader connection:didReceiveData:]): Ditto.
              (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): Ditto.
              (-[WebCoreSynchronousLoader connection:didFailWithError:]): Ditto.
      
              * platform/network/cf/ResourceHandleCFNet.cpp: Matched Mac changes.
      
              * platform/text/CString.cpp:
              * platform/text/CString.h:
              (WebCore::CStringBuffer::create):
              (WebCore::CStringBuffer::CStringBuffer):
              Removed code that was added for Base64 in r48363.
      
      LayoutTests:
              * http/tests/xmlhttprequest/cross-origin-authorization.html: While at it, made the test
              detect more error conditions
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      549845e7
    • vestbo@webkit.org's avatar
      [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard. · 6fa1358e
      vestbo@webkit.org authored
      This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
      
      Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-29
      Reviewed by Tor Arne Vestbø.
      
      Done together with Renata Hodovan <renata.hodovan@stud.u-szeged.hu>
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fa1358e
    • zoltan@webkit.org's avatar
      2009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu> · 2bbc434f
      zoltan@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Update Skipped list after test refactoring done in r48806.
      
              * platform/qt/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bbc434f
    • eric@webkit.org's avatar
      2009-09-29 Jakub Wieczorek <faw217@gmail.com> · 86b72436
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Unskip the passing tests that make use of eventSender.contextClick().
              https://bugs.webkit.org/show_bug.cgi?id=29821
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86b72436