GitLab

https://bugs.webkit.org/show_bug.cgi?id=97342

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-09-21
Reviewed by Yong Li.

As platformPlayer will notify MediaPlayerPrivate for size change
when loading metadata failed (in this case hasVideo() is false),
we should prevent MediaPlayerPrivate to set width and height
attribute of media element, otherwise we won't get the correct
dimension for the following media sources.

Internally reviewed by Max Feil.

Test case: media/video-size.html

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::resizeSourceDimensions):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=90687

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-09-21
Reviewed by Luiz Agostini.

When sending null data via POST method in  XMLHttpRequest the
expected Content-Type "application/x-www-form-urlencoded",
instead of "application/octet-stream". In fact that was the previously
expected value for Qt, but was changed to conform to Qt 4.8 results.

The cookie test result was updated to follow RFC 6265 behavior, as
already does chromium, gtk, and efl.

* platform/qt-5.0/Skipped:
* platform/qt/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt: Added.
* platform/qt/http/tests/xmlhttprequest/methods-expected.txt:
* platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt:
* platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt:
* platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97280

Reviewed by Adele Peterson.

Source/WebCore: 

Font::width() never applies word spacing to the first character in the TextRun. The
TextLayout optimization tried to achieve this behavior by not applying word spacing to
any character, which led to this bug.

Test: fast/text/word-space-with-kerning-2.html

* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::TextLayout::TextLayout): Changed to use the given font rather than a version
without word spacing.
(WebCore::TextLayout::width): Added a check if the run starts with a space at a non-zero
offset. If that is the case, then the ComplexTextController has added word spacing to that
space, so subtract it here in order to maintain the behavior described above.

LayoutTests: 

* fast/text/word-space-with-kerning-2-expected.html: Added.
* fast/text/word-space-with-kerning-2.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97329

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-21
Reviewed by Alexey Proskuryakov.

Fix leaks in InjectedBundleController::initialize() by adopting
strings created with WKStringCreateWithUTF8CString().

* TestWebKitAPI/InjectedBundleController.cpp:
(TestWebKitAPI::InjectedBundleController::initialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97235

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-09-21
Reviewed by Luiz Agostini.

* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::keyDown):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97340

Unreviewed EFL gardening. Skip flaky tests
in order to make the bots green.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-21

* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=96713

Patch by Gergely Kis <gergely@homejinni.com> on 2012-09-21
Reviewed by Csaba Osztrogonác.

Added a build slave for MIPS, and enabled a builder for
Qt Linux MIPS32R2 little-endian release build.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97313

Reviewed by Yong Li.

The valid seperator for viewport meta is ',' instead of ';'.

* WebCoreSupport/PagePopupBlackBerry.cpp:
(WebCore::PagePopupBlackBerry::generateHTML):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://trac.webkit.org/changeset/129219
https://bugs.webkit.org/show_bug.cgi?id=97338

Presumably broke Apple Mac compilation (Requested by yurys_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-21

* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* inspector/InjectedScriptCanvasModule.cpp:
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore):
* inspector/InjectedScriptCanvasModule.h:
(InjectedScriptCanvasModule):
* inspector/InspectorCanvasAgent.cpp:
* inspector/InspectorCanvasAgent.h:
* inspector/InspectorCanvasInstrumentation.h:
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97230

Reviewed by Tony Chang.

Because not all external storage cards will be formated using a file
system that supports named pipes, Chromium has been changed to creating
the pipes in a temporary folder on the internal storage. Adapt this in
WebKit so we can continue to run layout tests.

This also includes an *unreviewed* fix for a breakage in the webkitpy
tests I made in r129221. Two lines and related to this code, so I decided
to include it in this change.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._update_version):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=96657

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-09-21
Reviewed by James Robinson.

Add tests for ScrollingCoordinatorChromium. These tests mainly verify that
fast (non-main thread) scrolling is enabled when necessary and that a proper
compositing layer structure is created for fixed position and accelerated
scrolling layers.

Tests: ScrollingCoordinatorChromiumTest.fastScrollingByDefault
       ScrollingCoordinatorChromiumTest.fastScrollingForFixedPosition
       ScrollingCoordinatorChromiumTest.nonFastScrollableRegion
       ScrollingCoordinatorChromiumTest.wheelEventHandler
       ScrollingCoordinatorChromiumTest.touchOverflowScrolling

* WebKit.gypi:
* tests/ScrollingCoordinatorChromiumTest.cpp: Added.
(WebKit):
(MockWebViewClient):
(ScrollingCoordinatorChromiumTest):
(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(WebKit::ScrollingCoordinatorChromiumTest::createCompositedWebViewImpl):
(WebKit::ScrollingCoordinatorChromiumTest::registerMockedHttpURLLoad):
(WebKit::ScrollingCoordinatorChromiumTest::getRootScrollLayer):
(WebKit::TEST_F):
* tests/data/fixed_position.html: Added.
* tests/data/non_fast_scrollable.html: Added.
* tests/data/touch_overflow_scrolling.html: Added.
* tests/data/wheel_event_handler.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Skip a test because layoutTestController.setBackingScaleFactor() is missing
on Qt. This test timeouts at the moment, which considerably increase the testing time.

* platform/qt/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97330

Reviewed by Xan Lopez.

WebKitWebView:is-loading property allows to monitor when the view
is loading something without having to deal with load-changed
signal and all the details of the load status. This also allows to
know when a new load is started before it goes to STARTED status.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewGetProperty): Implement getter for is-loading
property.
(webkit_web_view_class_init): Add is-loading property.
(webkitWebViewSetIsLoading): Set whether web view is loading a
page and emit notify signal if the is-loading property has
changed. Also update the active URI when a new load operation has
started.
(webkitWebViewEmitLoadChanged): Set is-loading to FALSE when load
finishes.
(webkitWebViewLoadFailed): Set is-loading to FALSE when load fails.
(webkit_web_view_load_uri): Set is-loading to TRUE.
(webkit_web_view_load_html): Ditto.
(webkit_web_view_load_alternate_html): Ditto.
(webkit_web_view_load_plain_text): Ditto.
(webkit_web_view_load_request): Ditto.
(webkit_web_view_reload): Ditto.
(webkit_web_view_reload_bypass_cache): Ditto.
(webkit_web_view_is_loading): Return whether the view is loading a
page.
(webkit_web_view_go_back): Set is-loading to TRUE.
(webkit_web_view_go_forward): Ditto.
(webkit_web_view_go_to_back_forward_list_item): Ditto.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
* UIProcess/API/gtk/tests/LoadTrackingTest.cpp:
(loadChangedCallback):
(loadFailedCallback):
* UIProcess/API/gtk/tests/TestLoaderClient.cpp:
(testWebViewIsLoading):
(beforeAll):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97314

Reviewed by Antonio Gomes.

Source/WebKit:

Remove compositing surface code from build system.

PR 208038.

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

The removed code allowed rendering of sublayers to a separate offscreen
surface.

Now that we composite root layer and all sublayers to the window
surface, this code is not needed anymore. In addition, we save some
memory by not allocating the unused offscreen surface.

PR 208038.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
* Api/BackingStore_p.h:
(BackingStorePrivate):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::suspendBackingStore):
(BlackBerry::WebKit::WebPagePrivate::resizeSurfaceIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
(BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebKitSupport/BackingStoreCompositingSurface.cpp: Removed.
* WebKitSupport/BackingStoreCompositingSurface.h: Removed.
* WebKitSupport/GLES2Context.cpp:
(BlackBerry::WebKit::GLES2Context::buffer):
(BlackBerry::WebKit::GLES2Context::surfaceSize):
(BlackBerry::WebKit::GLES2Context::swapBuffers):
* WebKitSupport/GLES2Context.h:
(GLES2Context):
* WebKitSupport/SurfacePool.cpp:
(WebKit):
(BlackBerry::WebKit::SurfacePool::SurfacePool):
(BlackBerry::WebKit::SurfacePool::initialize):
* WebKitSupport/SurfacePool.h:
(SurfacePool):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97227

Reviewed by Tony Chang.

Source/WebKit/chromium:

Remove all fifo-related code together with the io_stream_forwarder_android
target defined in WebKitUnitTests.gyp.

* WebKitUnitTests.gyp:
* tests/ForwardIOStreamsAndroid.cpp: Removed.
* tests/ForwardIOStreamsAndroid.h: Removed.
* tests/RunAllTests.cpp:
(main):

Tools:

We switched Chromium to using FIFOs in order to achieve better consistency,
which was done by Marcus in r157541. Remove all custom WebKit code in
favor of Chromium's implementation.

Remove more FIFO code in the test runner itself, including the code in
DumpRenderTree that invoked it. We can now switch to Chromium's brand
new FIFO-creating code, which is being set-up for all test targets build
for Android, including DumpRenderTree, TestWebKitAPI and webkit_unit_tests.

This also changes the ChromiumAndroidDriver._remove_all_pipes method to
delete the files individually. "rm" would fail if one of the earlier files
does not exist, and the "-f" argument doesn't seem to be reliable.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/chromium/TestShellAndroid.cpp:
(platformInit):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._get_external_storage):
(ChromiumAndroidDriver._drt_cmd_line):
(ChromiumAndroidDriver._remove_all_pipes):
(ChromiumAndroidDriver.stop):
* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97326

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.

Tools:

Implement scheduleAsynchronousClick() in WebKitTestRunner's
EventSender by sending a "MouseDown" and a "MouseUp" message
asynchronously to the WebProcess.

* WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::createMouseMessageBody):
(WTR):
(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::scheduleAsynchronousClick):
* WebKitTestRunner/InjectedBundle/EventSendingController.h:
(EventSendingController):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveMessageFromInjectedBundle):

LayoutTests:

Unskip fast/events/popup-blocking-click-in-iframe.html for
WebKit2 now that WKTR's EventSender implements
scheduleAsynchronousClick.

* platform/efl-wk2/TestExpectations:
* platform/gtk-wk2/TestExpectations:
* platform/mac-wk2/Skipped:
* platform/qt-5.0-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97203

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-21
Reviewed by Yury Semikhatsky.

Implements wrapping a 2D canvas context through the injected canvas module script facility.

* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* inspector/InjectedScriptCanvasModule.cpp:
(WebCore::InjectedScriptCanvasModule::wrapCanvas2DContext):
(WebCore):
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore::InjectedScriptCanvasModule::callWrapContextFunction):
* inspector/InjectedScriptCanvasModule.h:
(InjectedScriptCanvasModule):
* inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):
* inspector/InspectorCanvasAgent.h:
(InspectorCanvasAgent):
* inspector/InspectorCanvasInstrumentation.h:
(WebCore::InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97226

Reviewed by Yury Semikhatsky.

Source/WebCore:

- change OutputStream interface to match that of stream;
- fix OutputStream implementations (FileOutputStream and those in heap profiler);
- fix usages in Timeline and HeapProfiler.

* inspector/front-end/FileUtils.js:
(WebInspector.OutputStream.prototype.write):
(WebInspector.OutputStream.prototype.close):
(WebInspector.ChunkedFileReader.prototype.start):
(WebInspector.ChunkedFileReader.prototype._onChunkLoaded):
(WebInspector.ChunkedXHRReader.prototype.start):
(WebInspector.ChunkedXHRReader.prototype._onProgress):
(WebInspector.ChunkedXHRReader.prototype._onLoad):
(WebInspector.FileOutputStream):
(WebInspector.FileOutputStream.prototype.open.callbackWrapper):
(WebInspector.FileOutputStream.prototype.open):
(WebInspector.FileOutputStream.prototype.write):
(WebInspector.FileOutputStream.prototype.close):
(WebInspector.FileOutputStream.prototype._onAppendDone):
* inspector/front-end/HeapSnapshotLoader.js:
(WebInspector.HeapSnapshotLoader.prototype.close):
(WebInspector.HeapSnapshotLoader.prototype.write):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotLoaderProxy.prototype.startTransfer):
(WebInspector.HeapSnapshotLoaderProxy.prototype.write):
(WebInspector.HeapSnapshotLoaderProxy.prototype.close):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._setupWorker):
(WebInspector.HeapProfileHeader.prototype.dispose):
(WebInspector.HeapProfileHeader.prototype.transferChunk.callback):
(WebInspector.HeapProfileHeader.prototype.transferChunk):
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.saveToFile.onOpen):
(WebInspector.HeapProfileHeader.prototype.saveToFile):
* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.prototype._createFileWriter):
(WebInspector.TimelineModel.prototype.saveToFile.callback):
(WebInspector.TimelineModel.prototype.saveToFile):
(WebInspector.TimelineModelLoader):
(WebInspector.TimelineModelLoader.prototype.write):
(WebInspector.TimelineModelLoader.prototype.close):
(WebInspector.TimelineSaver):
(WebInspector.TimelineSaver.prototype.save):
(WebInspector.TimelineSaver.prototype._writeNextChunk):

LayoutTests:

- adjust tests to new FileOutputStream interface;

* inspector/profiler/heap-snapshot-loader.html:
* inspector/timeline/timeline-load.html:
* inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.start):
(initialize_Timeline.InspectorTest.StringOutputStream):
(initialize_Timeline.InspectorTest.StringOutputStream.prototype.write):
(initialize_Timeline.InspectorTest.StringOutputStream.prototype.close):
(initialize_Timeline):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Tor Arne Vestbø.

Source/WTF:

* WTF.pri:

Tools:

* qmake/mkspecs/features/configure.prf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97217

Reviewed by Dirk Schulze.

Source/WebCore:

The clip-path was set on the GraphicsContext, but was never restored, thus making all the layers
rendered in the same "group" of save/restore state use the same clip-path.

Test: css3/masking/clip-path-restore.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
clip-path property should create a stacking-context, otherwise the RenderLayers will not be nested,
meaning that the clip-path of the parent is not going to apply correctly.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):

LayoutTests:

Added a test to check that the clip-path is removed from the GraphicsContext in the second paint call.
clip-path-circle-relative-overflow had incorrect result before, so I've udpated the results on Mac
and added test expectations for the others.

* css3/masking/clip-path-restore-expected.html: Added.
* css3/masking/clip-path-restore.html: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/css3/masking/clip-path-circle-relative-overflow-expected.png:
* platform/qt/TestExpectations:
* platform/win/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Tor Arne Vestbø.

Moved check for Qt version out of default_pre into top-level WebKit.pro,
because we never reach default_pre.prf due to the lack of .qmake.conf support
in older versions of Qt/QMake.

.:

* WebKit.pro:

Tools:

* qmake/mkspecs/features/default_pre.prf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=42705

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.

Tools:

Added missing dumping from WTR::InjectedBundlePage::didFailLoadWithErrorForFrame.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):

LayoutTests:

Unskipped corresponding test cases from wk2/Skipped, put those which still fail to an appropriate
group in wk2/Skipped.
Moved couple of http/tests/loading tests from platform/efl-wk1/TestExpectations to
platform/efl/TestExpectations as they actually fail for both WK1 EFL and WK2 EFL.

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:
* platform/wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97224

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/efl:

Fix bad use of temporary object causing wrong editing
callback dumping.

* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::shouldInsertText):

Tools:

Add support for mimicking CTRL+o emacs shortcut in EFL's
EventSender in DumpRenderTree and WebKitTestRunner.

* DumpRenderTree/efl/EventSender.cpp:
(sendKeyDown):
* WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::EventSenderProxy::keyDown):

LayoutTests:

Rebaseline editing/input/emacs-ctrl-o.html test now
that EFL's EventSender supports mimicking CTRL+o
emacs keyboard shortcut and unskip the test for
EFL WK2 now that the output matches the one for
EFL WK1.

* platform/efl-wk2/TestExpectations:
* platform/efl/editing/input/emacs-ctrl-o-expected.png:
* platform/efl/editing/input/emacs-ctrl-o-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97317

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-21

* platform/efl/TestExpectations:
* platform/efl/fast/text/atsui-rtl-override-selection-expected.png:
* platform/efl/fast/text/atsui-rtl-override-selection-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Tor Arne Vestbø.

Re-introduce the sanitization for LIBS when creating a module to use
LIBS_PRIVATE and otherwise do _not_ use LIBS_PRIVATE. We decided to
continue to use QT, LIBS and PKGCONFIG instead of their _PRIVATE variants
throughout the code base, so just using LIBS_PRIVATE in linkAgainstLibrary()
causes build issues when depending system libraries end up in LIBS before
LIBS_PRIVATE.

* qmake/mkspecs/features/default_post.prf:
* qmake/mkspecs/features/functions.prf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97315

Unreviewed EFL gardening.

Generate baselines for frame flattening tests using WK2 since the tests
are passing with it, and move the tests to WebKit1-specific
TestExpectations.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-21

* platform/efl-wk1/TestExpectations:
* platform/efl/Skipped:
* platform/efl/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
* platform/efl/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
* platform/efl/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
* platform/efl/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
* platform/efl/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
* platform/efl/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
* platform/efl/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
* platform/efl/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-simple-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97311

Reviewed by Kentaro Hara.

WebCore::localizedTimeFormatText, WebCore::localizedShortTimeFormatText,
and WebCore::timeAMPMLabels are not used any more because we switched to
the corresponding functions of Localizer.

No new tests because of no behavior changes.

* platform/text/Localizer.h:
(Localizer): Moved comments from LocalizedDate.h.
* platform/text/LocalizedDate.h:
(WebCore): Removed localizedTimeFormatText,
localizedShortTimeFormatText, and timeAMPMLabels.
* platform/text/LocalizedDateICU.cpp:
(WebCore): ditto.
* platform/text/LocalizedDateWin.cpp:
(WebCore): ditto.
* platform/text/mac/LocalizedDateMac.cpp:
(WebCore): ditto.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97292

Reviewed by Kent Tamura.

Source/WebCore:

We read datalist suggestions, add them to DateTimeChooserParameters,
and pass them to the page popup.

No new tests. No behavior change yet.

* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::openPopup): Read datalist suggestions and add them to DateTimeChooserParameters
* platform/DateTimeChooser.h:
(DateTimeChooserParameters): Added localizedSuggestionValues so we can show localized values inside the page popup.

Source/WebKit/chromium:

* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): Add the necessary parameters for SuggestionPicker.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97300

Reviewed by Kent Tamura.

This patch introduces DateTimeEditElement::LayoutParameters struct for
passing four parameters to DateTimeEditElement::layout() for passing
date time format from client of DateTimeEditElement instead of
DateTimeEditElement::layout() takes time or short time format.

This patch is a part of preparation of introducing multiple fields
date/datetime/month/week input UI.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch doesn't change behavior.

* html/TimeInputType.cpp:
(WebCore::TimeInputType::updateInnerTextValue): Changed to use LayoutParmeters.
* html/shadow/DateTimeEditElement.cpp:  Removed unused include files, LocalizedDate.h and LocalizedNumber.h.
(DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Changed parameters to LayoutParmeters.
(WebCore::DateTimeEditElement::LayoutParameters::shouldHaveSecondField): Moved from DateTimeEditBuilder::needSecondField().
(WebCore::DateTimeEditElement::layout): Changed to take LayoutParameters.
(WebCore::DateTimeEditElement::setValueAsDate): ditto
(WebCore::DateTimeEditElement::setEmptyValue): ditto
* html/shadow/DateTimeEditElement.h: Removed unused classe declarations DateComponents and DateTimeEditLayouter.
(LayoutParameters):  Added to bundle parameters for layout().
(WebCore::DateTimeEditElement::LayoutParameters::LayoutParameters): Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97219

Reviewed by Vsevolod Vlasov.

Otherwise, it is hard to inspect objects close to (0, 0)

* inspector/InspectorOverlayPage.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://trac.webkit.org/changeset/129086
https://bugs.webkit.org/show_bug.cgi?id=97312

Broke input rendering (Requested by shinyak on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-21

* html/BaseButtonInputType.cpp:
(WebCore):
* html/BaseButtonInputType.h:
(WebCore::BaseButtonInputType::BaseButtonInputType):
(BaseButtonInputType):
* html/FileInputType.cpp:
(WebCore::UploadButtonElement::create):
(WebCore::UploadButtonElement::createForMultiple):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
* html/InputType.cpp:
* html/InputType.h:
(InputType):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::RenderButton):
(WebCore::RenderButton::styleDidChange):
(WebCore::RenderButton::updateFromElement):
(WebCore):
(WebCore::RenderButton::setText):
(WebCore::RenderButton::text):
* rendering/RenderButton.h:
(RenderButton):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97304

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-09-21
Reviewed by Kentaro Hara.

Remove two useless class prototype statements in the Vibration.h

* Modules/vibration/Vibration.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

from Failure to ImageOnlyFailure to match the actual results.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97157

Patch by Chao-ying Fu <fu@mips.com> on 2012-09-21
Reviewed by Gavin Barraclough.

Add a missing or32 function.

* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::or32): New function.
(MacroAssemblerMIPS):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

intermittently on Linux in addition to Win and Mac.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rebaselining MathML tests after r129146.

* platform/gtk/mathml/presentation/attributes-expected.png:
* platform/gtk/mathml/presentation/attributes-expected.txt:
* platform/gtk/mathml/presentation/fenced-expected.png:
* platform/gtk/mathml/presentation/fenced-expected.txt:
* platform/gtk/mathml/presentation/fenced-mi-expected.png:
* platform/gtk/mathml/presentation/fenced-mi-expected.txt:
* platform/gtk/mathml/presentation/fractions-expected.png:
* platform/gtk/mathml/presentation/fractions-expected.txt:
* platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/gtk/mathml/presentation/mo-expected.png:
* platform/gtk/mathml/presentation/mo-expected.txt:
* platform/gtk/mathml/presentation/mo-stretch-expected.png:
* platform/gtk/mathml/presentation/mo-stretch-expected.txt:
* platform/gtk/mathml/presentation/mroot-pref-width-expected.png:
* platform/gtk/mathml/presentation/mroot-pref-width-expected.txt:
* platform/gtk/mathml/presentation/over-expected.png:
* platform/gtk/mathml/presentation/over-expected.txt:
* platform/gtk/mathml/presentation/roots-expected.png:
* platform/gtk/mathml/presentation/roots-expected.txt:
* platform/gtk/mathml/presentation/row-alignment-expected.png:
* platform/gtk/mathml/presentation/row-alignment-expected.txt:
* platform/gtk/mathml/presentation/row-expected.png:
* platform/gtk/mathml/presentation/row-expected.txt:
* platform/gtk/mathml/presentation/style-expected.png:
* platform/gtk/mathml/presentation/style-expected.txt:
* platform/gtk/mathml/presentation/sub-expected.txt:
* platform/gtk/mathml/presentation/subsup-expected.png:
* platform/gtk/mathml/presentation/subsup-expected.txt:
* platform/gtk/mathml/presentation/sup-expected.png:
* platform/gtk/mathml/presentation/sup-expected.txt:
* platform/gtk/mathml/presentation/tokenElements-expected.png:
* platform/gtk/mathml/presentation/tokenElements-expected.txt:
* platform/gtk/mathml/presentation/under-expected.txt:
* platform/gtk/mathml/presentation/underover-expected.png:
* platform/gtk/mathml/presentation/underover-expected.txt:
* platform/gtk/mathml/xHeight-expected.png:
* platform/gtk/mathml/xHeight-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97193

Reviewed by Kent Tamura.

Preparation so we can add another picker to CalendarPicker and switch
between them.

No new tests. No behavior change.

* Resources/pagepopups/calendarPicker.css:
(.calendar-picker): Added so we can apply these styles just to calendar picker.
* Resources/pagepopups/calendarPicker.js:
(CalendarPicker.validateConfig): Renamed so each picker can validate the config object.
(initialize):
(closePicker): Call Picker.cleanup().
(openCalendarPicker):
(CalendarPicker):
(CalendarPicker.prototype.cleanup): Cleanup event listener on document.body.
* Resources/pagepopups/pickerCommon.js:
(Picker.prototype.cleanup):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/chromium/TestExpectations: Assigned new bug entry for
fast/text/international/hebrew-selection.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=96903

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-20
Reviewed by Kenneth Rohde Christiansen.

The applications will use this API to feed touch event to the view
when they want to generate touch event from their own event processor.
WTR also will use this API to generate touch event with multiple touch
points for passing test cases of touch event in the WebKit2/EFL.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_feed_touch_event):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129196 268f45cc-cd09-0410-ab3c-d52691b4dbfc