1. 01 Nov, 2010 40 commits
    • andersca@apple.com's avatar
      Add ArgumentCoder specialization for WTF::CString · 734aad70
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48796
      
      Reviewed by Sam Weinig.
      
      * Platform/CoreIPC/ArgumentCoders.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      734aad70
    • dpranke@chromium.org's avatar
      2010-11-01 Dirk Pranke <dpranke@chromium.org> · af1b8a2a
      dpranke@chromium.org authored
              Reviewed by James Robinson.
      
              new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default
              https://bugs.webkit.org/show_bug.cgi?id=48790
      
              * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
              * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af1b8a2a
    • hyatt@apple.com's avatar
      Fix SVG bustage. · 0cf2782f
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cf2782f
    • mdelaney@apple.com's avatar
      2010-11-01 Matthew Delaney <mdelaney@apple.com> · 069db487
      mdelaney@apple.com authored
              Reviewed by Simon Fraser.
      
              Setting attr repeatDur=0 on SVG element causes hang
              https://bugs.webkit.org/show_bug.cgi?id=48785
      
              Test: svg/animations/repeatDur-zero.xhtml
      
              * svg/animation/SVGSMILElement.cpp: Fixing bound checking for legal repeatDur values.
      2010-11-01  Matthew Delaney  <mdelaney@apple.com>
      
              Reviewed by Simon Fraser.
      
              Setting attr repeatDur=0 on SVG element causes hang
              https://bugs.webkit.org/show_bug.cgi?id=48785
      
              * svg/animations/repeatDur-zero.xhtml: Added. Tests if setting attr repeatDur=0 causes a hang or not.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      069db487
    • abarth@webkit.org's avatar
      2010-10-31 Adam Barth <abarth@webkit.org> · 6e06aa03
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Chromium] Add ICC support for PNG on Mac
              https://bugs.webkit.org/show_bug.cgi?id=48170
      
              This just pipes the ICC profile from libpng to CoreGraphics.  This
              patch would have been a lot prettier on Snow Leopard, but we have to
              use a somewhat ugly API to get this to work on Leopard.
      
              This is covered by about infinite tests.
      
              * platform/image-decoders/ImageDecoder.cpp:
              (WebCore::RGBA32Buffer::setColorProfile):
              * platform/image-decoders/ImageDecoder.h:
              * platform/image-decoders/cg/ImageDecoderCG.cpp:
              (WebCore::RGBA32Buffer::asNewNativeImage):
              * platform/image-decoders/png/PNGImageDecoder.cpp:
              (WebCore::PNGImageDecoder::headerAvailable):
              (WebCore::PNGImageDecoder::rowAvailable):
              * platform/image-decoders/qt/RGBA32BufferQt.cpp:
              (WebCore::RGBA32Buffer::setColorProfile):
              * platform/image-decoders/skia/ImageDecoderSkia.cpp:
              (WebCore::RGBA32Buffer::setColorProfile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e06aa03
    • abarth@webkit.org's avatar
      2010-11-01 Adam Barth <abarth@webkit.org> · 30777845
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Teach check-webkit-style how to accept a list of files to diff on the
              command line
              https://bugs.webkit.org/show_bug.cgi?id=48784
      
              In a future patch, webkit-patch will use this option to improve
              performance.  I'm landing this in two pieces to avoid causing a version
              skew problem for the style-bot.
      
              * Scripts/check-webkit-style:
              * Scripts/webkitpy/style/optparser.py:
              * Scripts/webkitpy/style/optparser_unittest.py:
              * Scripts/webkitpy/style_references.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30777845
    • dimich@chromium.org's avatar
      [Chromium] Unreviewed test rebaseline. · b8e20db6
      dimich@chromium.org authored
      * platform/chromium-linux/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.checksum: Removed.
      * platform/chromium-linux/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Removed.
      * platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum:
      * platform/chromium-mac/fast/repaint/inline-horizontal-bt-overflow-expected.checksum: Added.
      * platform/chromium-mac/fast/repaint/inline-horizontal-bt-overflow-expected.png: Added.
      * platform/chromium-mac/fast/repaint/inline-vertical-lr-overflow-expected.checksum: Added.
      * platform/chromium-mac/fast/repaint/inline-vertical-lr-overflow-expected.png: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8e20db6
    • mihaip@chromium.org's avatar
      2010-11-01 Mihai Parparita <mihaip@chromium.org> · 0022f454
      mihaip@chromium.org authored
              Update the pixel expectations for fast/body-propagation, fast/borders, fast/box-shadow, fast/box-sizing, fast/clip, and fast/compact for the Mac port.
      
              For the tests that currently fail on Snow Leopard with --pixel-tests
              --tolerance 0, this moves the current pixel results to mac-leopard and
              adds new Snow Leopard-specific results to platform/mac.
      
              List of files omitted due to length but composed entirely of moves from
              platform/mac to platform/mac-leopard and newly added files in
              platform/mac.
      
              platform/mac/test_expectations.txt was also modified to remove two
              now-passing tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0022f454
    • senorblanco@chromium.org's avatar
      2010-11-01 Stephen White <senorblanco@chromium.org> · ca1b66c6
      senorblanco@chromium.org authored
              Unreviewed; test expectations update.
      
              Update chromium-gpu test expectations to reflect test_shell
              timeouts on ~35 tests.
      
              * platform/chromium-gpu/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca1b66c6
    • andersca@apple.com's avatar
      Fix build. · 647698af
      andersca@apple.com authored
      * WebKit2.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      647698af
    • simon.fraser@apple.com's avatar
      2010-11-01 Simon Fraser <simon.fraser@apple.com> · 578ea6f8
      simon.fraser@apple.com authored
              Fix test failures on Qt by avoiding references to external image files.
      
              * fast/backgrounds/multiple-backgrounds-computed-style-expected.txt:
              * fast/backgrounds/script-tests/multiple-backgrounds-computed-style.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      578ea6f8
    • andersca@apple.com's avatar
      Add NPObjectMessageReceiver.messages.in · 8ae9316e
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48782
      
      Reviewed by Adam Roben.
      
      * DerivedSources.make:
      Add NPObjectMessageReceiver.
      
      * Platform/CoreIPC/MessageID.h:
      Add MessageClassNPObjectMessageReceiver message class.
      
      * Shared/Plugins/NPObjectMessageReceiver.cpp:
      (WebKit::NPObjectMessageReceiver::deallocate):
      Add stubbed out deallocate member function.
      
      * Shared/Plugins/NPObjectMessageReceiver.messages.in: Added.
      
      * WebKit2.xcodeproj/project.pbxproj:
      Add NPObjectMessageReceiver.messages.in.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ae9316e
    • mihaip@chromium.org's avatar
      2010-11-01 Mihai Parparita <mihaip@chromium.org> · 77225896
      mihaip@chromium.org authored
              Update the pixel expectations for fast/selectors for the Mac port.
      
              For the tests that currently fail on Snow Leopard with --pixel-tests
              --tolerance 0, this moves the current pixel results to mac-leopard and
              adds new Snow Leopard-specific results to platform/mac.
      
              List of files omitted due to length but composed entirely of moves from
              platform/mac to platform/mac-leopard and newly added files in
              platform/mac.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77225896
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=48776 · 6bd34681
      hyatt@apple.com authored
              
      Reviewed by Dan Bernstein.
      
      Change isVertical() on InlineBox to isHorizontal() instead.  This makes the horizontal code path come
      first if you branch on isHorizontal() and makes the code read better (since that's the more common code
      path).
      
      * rendering/InlineBox.cpp:
      (WebCore::InlineBox::logicalHeight):
      * rendering/InlineBox.h:
      (WebCore::InlineBox::InlineBox):
      (WebCore::InlineBox::isHorizontal):
      (WebCore::InlineBox::setIsHorizontal):
      (WebCore::InlineBox::width):
      (WebCore::InlineBox::height):
      (WebCore::InlineBox::logicalLeft):
      (WebCore::InlineBox::setLogicalLeft):
      (WebCore::InlineBox::logicalTop):
      (WebCore::InlineBox::setLogicalTop):
      (WebCore::InlineBox::baselinePosition):
      (WebCore::InlineBox::lineHeight):
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::addToLine):
      (WebCore::InlineFlowBox::placeBoxesInInlineDirection):
      (WebCore::InlineFlowBox::computeBlockDirectionOverflow):
      (WebCore::InlineFlowBox::paintFillLayer):
      (WebCore::InlineFlowBox::paintBoxDecorations):
      (WebCore::InlineFlowBox::paintMask):
      * rendering/InlineFlowBox.h:
      (WebCore::InlineFlowBox::marginLogicalLeft):
      (WebCore::InlineFlowBox::marginLogicalRight):
      (WebCore::InlineFlowBox::borderLogicalLeft):
      (WebCore::InlineFlowBox::borderLogicalRight):
      (WebCore::InlineFlowBox::paddingLogicalLeft):
      (WebCore::InlineFlowBox::paddingLogicalRight):
      (WebCore::InlineFlowBox::setInlineDirectionOverflowPositions):
      (WebCore::InlineFlowBox::setBlockDirectionOverflowPositions):
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::selectionRect):
      (WebCore::InlineTextBox::applyShadowToGraphicsContext):
      (WebCore::paintTextWithShadows):
      (WebCore::InlineTextBox::paint):
      (WebCore::InlineTextBox::paintDecoration):
      * rendering/InlineTextBox.h:
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::createLineBoxes):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::blockDirectionOverflow):
      * rendering/RenderBox.h:
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::paintFillLayerExtended):
      * rendering/RenderLineBoxList.cpp:
      (WebCore::RenderLineBoxList::hitTest):
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::RootInlineBox):
      (WebCore::RootInlineBox::placeEllipsis):
      * rendering/RootInlineBox.h:
      (WebCore::RootInlineBox::baselinePosition):
      (WebCore::RootInlineBox::lineHeight):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bd34681
    • andersca@apple.com's avatar
      Start stubbing out NPClass functions in NPObjectProxy · 004117f4
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48778
      
      Reviewed by Adam Roben.
      
      * PluginProcess/PluginControllerProxy.cpp:
      (WebKit::PluginControllerProxy::windowScriptNPObject):
      getOrCreateNPObjectProxy is now createNPObjectProxy.
      
      * Shared/Plugins/NPObjectProxy.cpp:
      (WebKit::NPObjectProxy::create):
      Allocate and initialize an NPObjectProxy object.
      
      (WebKit::NPObjectProxy::NPObjectProxy):
      Initialize m_npObjectID to 0.
      
      (WebKit::NPObjectProxy::isNPObjectProxy):
      Check the class.
      
      (WebKit::NPObjectProxy::initialize):
      Set m_npObjectID.
      
      (WebKit::NPObjectProxy::npClass):
      Return the NPClass with all functions filled in.
      
      (WebKit::NPObjectProxy::NP_Allocate):
      Create a new NPObjectProxy object.
      
      (WebKit::NPObjectProxy::NP_Deallocate):
      Deallocate the NPObjectProxy object.
      
      (WebKit::NPObjectProxy::NP_HasMethod):
      (WebKit::NPObjectProxy::NP_Invoke):
      (WebKit::NPObjectProxy::NP_InvokeDefault):
      (WebKit::NPObjectProxy::NP_HasProperty):
      (WebKit::NPObjectProxy::NP_GetProperty):
      (WebKit::NPObjectProxy::NP_SetProperty):
      (WebKit::NPObjectProxy::NP_RemoveProperty):
      (WebKit::NPObjectProxy::NP_Enumerate):
      (WebKit::NPObjectProxy::NP_Construct):
      Add stubs.
      
      * Shared/Plugins/NPRemoteObjectMap.cpp:
      (WebKit::NPRemoteObjectMap::createNPObjectProxy):
      * Shared/Plugins/NPRemoteObjectMap.h:
      Rename getOrCreateNPObjectProxy to createNPObjectProxy.
      
      * WebProcess/Plugins/Netscape/NPJSObject.cpp:
      (WebKit::NPJSObject::NP_Allocate):
      Remove unused parameter.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      004117f4
    • dimich@chromium.org's avatar
      [Chromium] Unreviewed update of test expectations. · 5cd79318
      dimich@chromium.org authored
      Add baseline for a new test added in http://trac.webkit.org/changeset/71043
      
      * platform/chromium-mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Added.
      * platform/chromium-mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Added.
      * platform/chromium-mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
      * platform/chromium-win/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cd79318
    • mario@webkit.org's avatar
      2010-11-01 Mario Sanchez Prada <msanchez@igalia.com> · 8e3dca8d
      mario@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Cleanup needed in testatk.c file
              https://bugs.webkit.org/show_bug.cgi?id=48759
      
              Cleanup done in testatk.c, mainly addressing the following issues:
      
              - Removed any trace of extra main loops in tests, so now we just
              spin the original main loop in all of them to get the a11y
              objects.
      
              - As we no longer use the extra main loops, removed the bail_out
              function, used along with g_idle_add() to stop those extra loops.
      
              - As we now spin the loop in every test, created a new function
              waitForAccessibilityObjects() to write the loop just once.
      
              - Fixed name in incorrectly named test testWekitAtkTextSelections.
      
              - Alphabetically sorted the list of includes.
      
              - Renamed all identifiers to camel Case notation.
      
              - Declare variables when needed only (instead of declaring all of
              them at the beginning of the function).
      
              - Don't declare two variables of the same type in the same line.
      
              - No more short names like 'obj', 'textObj' or 'alloc'. Use names
              like 'object', 'textObject' and 'allocation' instead.
      
              - Fixed indentation.
      
              - Make sure all comments finish with '.'
      
              - Replace NULL's with 0's.
      
              * tests/testatk.c:
              (waitForAccessibleObjects): New, manually spins the main context
              to make sure accessible objects are created before continuing.
              (testGetTextFunction): Fixed this function to be compliant with
              the WebKit's coding style.
              (runGetTextTests): Ditto.
              (testWebkitAtkGetTextAtOffsetForms): Ditto.
              (testWebkitAtkGetTextAtOffset): Ditto.
              (testWebkitAtkGetTextAtOffsetNewlines): Ditto.
              (testWebkitAtkGetTextAtOffsetTextarea): Ditto.
              (testWebkitAtkGetTextAtOffsetTextInput): Ditto.
              (testWebkitAtkGetTextInParagraphAndBodySimple): Ditto.
              (testWebkitAtkGetTextInParagraphAndBodyModerate): Ditto.
              (testWebkitAtkGetTextInTable): Ditto.
              (testWebkitAtkGetHeadersInTable): Ditto.
              (compAtkAttribute): Ditto.
              (atkAttributeSetAttributeNameHasValue): Ditto.
              (testWebkitAtkTextAttributes): Ditto.
              (testWebkitAtkTextSelections): Ditto.
              (testWebkitAtkGetExtents): Ditto.
              (testWebkitAtkLayoutAndDataTables): Ditto.
              (testWebkitAtkLinksWithInlineImages): Ditto.
              (testWebkitAtkHypertextAndHyperlinks): Ditto.
              (testWebkitAtkListsOfItems): Ditto.
              (testWebkitAtkTextChangedNotifications): Ditto.
              (main): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e3dca8d
    • andersca@apple.com's avatar
      Both the WebProcessConnection and PluginProcessConnection should have NPRemoteObjectMaps · e8573036
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48775
      
      Reviewed by Adam Roben.
      
      * PluginProcess/PluginControllerProxy.cpp:
      (WebKit::PluginControllerProxy::windowScriptNPObject):
      Ask for an NPObjectProxy for the window script NPObject.
      
      * PluginProcess/WebProcessConnection.cpp:
      (WebKit::WebProcessConnection::WebProcessConnection):
      Initialize m_npRemoteObjectMap.
      
      * Shared/Plugins/NPObjectMessageReceiver.cpp:
      (WebKit::NPObjectMessageReceiver::create):
      Add a create member function that takes an NPObject.
      
      (WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver):
      Retain the NPObject.
      
      (WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
      Release the NPObject.
      
      * Shared/Plugins/NPRemoteObjectMap.cpp:
      (WebKit::generateNPObjectID):
      Generate a unique 64-bit NPObject ID.
      
      (WebKit::NPRemoteObjectMap::getOrCreateNPObjectProxy):
      Add stub.
      
      (WebKit::NPRemoteObjectMap::registerNPObject):
      Create a NPObjectMessageReceiver and add it to the map.
      
      * WebKit2.xcodeproj/project.pbxproj:
      Set the correct target for NPRuntime related files.
      
      * WebProcess/Plugins/PluginProcessConnection.cpp:
      (WebKit::PluginProcessConnection::PluginProcessConnection):
      Initialize m_npRemoteObjectMap
      
      * WebProcess/Plugins/PluginProxy.cpp:
      (WebKit::PluginProxy::getWindowScriptNPObject):
      Ask the real plug-in controller for the window script NPObject and register it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8573036
    • dimich@chromium.org's avatar
      [Chromium] Unreviewed, update test expectations. · 8ae96912
      dimich@chromium.org authored
      Updated render tree dumps after http://trac.webkit.org/changeset/71043.
      
      * platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.txt:
      * platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.txt:
      * platform/chromium-win/fast/blockflow/basic-vertical-line-expected.txt:
      * platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
      * platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.txt:
      * platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.txt:
      * platform/chromium-win/fast/blockflow/english-lr-text-expected.txt:
      * platform/chromium-win/fast/blockflow/english-rl-text-expected.txt:
      * platform/chromium-win/fast/blockflow/japanese-lr-text-expected.txt:
      * platform/chromium-win/fast/blockflow/japanese-rl-text-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ae96912
    • simon.fraser@apple.com's avatar
      2010-11-01 Simon Fraser <simon.fraser@apple.com> · 8987f0b7
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt.
      
              Multiple background properties are not retrievable via DOM method getComputedStyle
              https://bugs.webkit.org/show_bug.cgi?id=23203
      
              Return lists of values from getComputedStyle() for multiple backgrounds,
              and multiple masks.
      
              Test: fast/backgrounds/multiple-backgrounds-computed-style.html
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::fillSizeToCSSValue):
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8987f0b7
    • sullivan@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=48774 · 87cddddd
      sullivan@apple.com authored
      minimFontSize preference needs to be exposed in WebKit2
      
      Reviewed by Anders Carlsson.
      
      * UIProcess/WebPreferences.cpp:
      (WebKit::WebPreferences::setMinimumFontSize):
      New function, parallel to existing functions for other preferences.
      (WebKit::WebPreferences::minimumFontSize):
      Ditto.
      
      * UIProcess/WebPreferences.h:
      Declared new function.
      
      * UIProcess/API/C/WKPreferences.cpp:
      (WKPreferencesSetMinimumFontSize):
      New UI process wrapper for new function.
      (WKPreferencesGetMinimumFontSize):
      Ditto.
      
      * UIProcess/API/C/WKPreferences.h:
      Declared new functions.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87cddddd
    • mihaip@chromium.org's avatar
      2010-11-01 Mihai Parparita <mihaip@chromium.org> · 75d12309
      mihaip@chromium.org authored
              Update the pixel expectations for fast/block/positioning for the Mac port.
      
              For the tests that currently fail on Snow Leopard with --pixel-tests
              --tolerance 0, this moves the current pixel results to mac-leopard and
              adds new Snow Leopard-specific results to platform/mac.
      
              List of files omitted due to length but composed entirely of moves from
              platform/mac to platform/mac-leopard and newly added files in
              platform/mac.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75d12309
    • dimich@chromium.org's avatar
      [Chromium] Unreviewed update of test expectations. · ce8fb8d3
      dimich@chromium.org authored
      svg-as-background.html now fails on debug mac 10.5 bots.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce8fb8d3
    • andersca@apple.com's avatar
      Tear down the related WebProcessProxy when a WebContext is deallocated · c207acf1
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48769
      
      Reviewed by John Sullivan.
      
      WebKit2:
      
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::~WebContext):
      Call WebProcessManager::contextWasDestroyed.
      
      (WebKit::WebContext::didNavigateWithNavigationData):
      (WebKit::WebContext::didPerformClientRedirect):
      (WebKit::WebContext::didPerformServerRedirect):
      (WebKit::WebContext::didUpdateHistoryTitle):
      It is valid for a frame to have a null page here, if the frame has outlived
      its page.
      
      * UIProcess/WebProcessManager.cpp:
      (WebKit::WebProcessManager::contextWasDestroyed):
      Remove the context from the map.
      
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::~WebProcessProxy):
      It's OK for the connection to be non-null here if the process goes away because
      the context has been deallocated.
      
      WebKitTools:
      
      * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
      (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
      We don't support empty URLs anymore, update test to expect a null URL instead.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c207acf1
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=48663 · 46ed5559
      hyatt@apple.com authored
      Reviewed by Dan Bernstein.
      
      Make repaint invalidation work with vertical lines.  Rewrite linesBoundingBox for RenderText and
      RenderInline to give the correct rectangle back for vertical lines.  Also patch linesVisibleOverflowBoundingBox
      to give back the correct rectangle for vertical lines.
      
      Fix bugs in the overflow accessors of InlineFlowBox when m_overflow was 0.
              
      Patch hit testing to also account for "rt" and "bt" blocks.
      
      WebCore: 
      
      * rendering/InlineBox.cpp:
      (WebCore::InlineBox::adjustForFlippedBlocksWritingMode):
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::nodeAtPoint):
      * rendering/InlineFlowBox.h:
      (WebCore::InlineFlowBox::logicalLeftVisibleOverflow):
      (WebCore::InlineFlowBox::logicalRightVisibleOverflow):
      (WebCore::InlineFlowBox::bottomLayoutOverflow):
      (WebCore::InlineFlowBox::rightLayoutOverflow):
      (WebCore::InlineFlowBox::bottomVisualOverflow):
      (WebCore::InlineFlowBox::rightVisualOverflow):
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::nodeAtPoint):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::hitTestFloats):
      (WebCore::RenderBlock::hitTestContents):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::computeRectForRepaint):
      (WebCore::RenderBox::adjustForFlippedBlocksWritingMode):
      * rendering/RenderBox.h:
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::linesBoundingBox):
      (WebCore::RenderInline::linesVisibleOverflowBoundingBox):
      (WebCore::RenderInline::clippedOverflowRectForRepaint):
      * rendering/RenderText.cpp:
      (WebCore::RenderText::linesBoundingBox):
      
      LayoutTests: 
      
      * fast/repaint/inline-horizontal-bt-overflow.html: Added.
      * fast/repaint/inline-vertical-lr-overflow.html: Added.
      * fast/repaint/inline-vertical-rl-overflow.html: Copied from fast/repaint/inline-vertical-rl-overflow.html.
      * platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
      * platform/mac/fast/blockflow/background-vertical-rl-expected.txt:
      * platform/mac/fast/blockflow/basic-vertical-line-expected.txt:
      * platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
      * platform/mac/fast/blockflow/border-image-vertical-rl-expected.txt:
      * platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
      * platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
      * platform/mac/fast/blockflow/border-vertical-lr-expected.png:
      * platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
      * platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
      * platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt:
      * platform/mac/fast/blockflow/english-lr-text-expected.txt:
      * platform/mac/fast/blockflow/english-rl-text-expected.txt:
      * platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
      * platform/mac/fast/blockflow/japanese-rl-text-expected.txt:
      * platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.checksum: Added.
      * platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.png: Added.
      * platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.txt: Added.
      * platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.checksum: Added.
      * platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.png: Added.
      * platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.txt: Added.
      * platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Copied from platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum.
      * platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Copied from platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46ed5559
    • beidson@apple.com's avatar
      Windows build fix. · 5269b927
      beidson@apple.com authored
      * UIProcess/win/WebView.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5269b927
    • beidson@apple.com's avatar
      <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699 · 3a0329aa
      beidson@apple.com authored
      Context menu support for WebKit 2.
      
      Reviewed by Anders Carlsson.
      
      WebCore: 
      
      Add a "showContextMenu" call to Chrome/ChromeClient:
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::showContextMenu):
      * page/Chrome.cpp:
      (WebCore::Chrome::showContextMenu):
      * page/Chrome.h:
      * page/ChromeClient.h:
      
      Add a "platform description to ContextMenuItem" creator, will be needed by WebKit2
      * platform/ContextMenu.h:
      * platform/mac/ContextMenuMac.mm:
      (WebCore::contextMenuItemVector):
      
      * platform/mac/ContextMenuItemMac.mm:
      (WebCore::ContextMenuItem::checked): WebKit2 ports now need this implemented.
      
      Stub these out to keep their WK2 ports building:
      * platform/qt/ContextMenuItemQt.cpp:
      (WebCore::ContextMenuItem::checked):
      * platform/qt/ContextMenuQt.cpp:
      (WebCore::contextMenuItemVector):
      * platform/win/ContextMenuItemWin.cpp:
      (WebCore::ContextMenuItem::checked):
      * platform/win/ContextMenuWin.cpp:
      (WebCore::contextMenuItemVector):
      
      WebKit/chromium: 
      
      * src/ChromeClientImpl.h:
      (WebKit::ChromeClientImpl::showContextMenu):
      
      WebKit/efl: 
      
      * WebCoreSupport/ChromeClientEfl.h:
      (WebCore::ChromeClientEfl::showContextMenu):
      
      WebKit/gtk: 
      
      * WebCoreSupport/ChromeClientGtk.h:
      (WebKit::ChromeClient::showContextMenu):
      
      WebKit/haiku: 
      
      * WebCoreSupport/ChromeClientHaiku.h:
      (WebCore::ChromeClientHaiku::showContextMenu):
      
      WebKit/mac: 
      
      * WebCoreSupport/WebChromeClient.h:
      (WebChromeClient::showContextMenu):
      
      WebKit/qt: 
      
      * WebCoreSupport/ChromeClientQt.h:
      (WebCore::ChromeClientQt::showContextMenu):
      
      WebKit/win: 
      
      * WebCoreSupport/WebChromeClient.h:
      (WebChromeClient::showContextMenu):
      
      WebKit/wx: 
      
      * WebKitSupport/ChromeClientWx.h:
      (WebCore::ChromeClientWx::showContextMenu):
      
      WebKit2: 
      
      * WebKit2.pro:
      * WebKit2.xcodeproj/project.pbxproj:
      * win/WebKit2.vcproj:
      
      * Shared/WebContextMenuItem.cpp: Added.
      (WebKit::WebContextMenuItem::WebContextMenuItem):
      (WebKit::WebContextMenuItem::encode):
      (WebKit::WebContextMenuItem::decode):
      (WebKit::kitItems):
      * Shared/WebContextMenuItem.h: Added.
      
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::createContextMenuProxy):
      * UIProcess/API/qt/qwkpage.cpp:
      (QWKPagePrivate::createContextMenuProxy): Stub to keep the build working.
      * UIProcess/API/qt/qwkpage_p.h:
      * UIProcess/PageClient.h:
      
      * UIProcess/WebContextMenuProxy.cpp: Added.
      (WebKit::WebContextMenuProxy::~WebContextMenuProxy):
      (WebKit::WebContextMenuProxy::WebContextMenuProxy):
      * UIProcess/WebContextMenuProxy.h: Added.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::showContextMenu): Shows the menu after receiving the message from the WebProcess.
      (WebKit::WebPageProxy::contextMenuItemSelected): Sends info about the selected menu item to the WebProcess
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      
      * UIProcess/mac/WebContextMenuProxyMac.h: Added.
      (WebKit::WebContextMenuProxyMac::create):
      * UIProcess/mac/WebContextMenuProxyMac.mm: Added.
      (+[WebMenuTarget sharedMenuTarget]):
      (-[WebMenuTarget WebKit::]):
      (-[WebMenuTarget setMenuProxy:WebKit::]):
      (-[WebMenuTarget forwardContextMenuAction:]):
      (WebKit::WebContextMenuProxyMac::WebContextMenuProxyMac):
      (WebKit::WebContextMenuProxyMac::~WebContextMenuProxyMac):
      (WebKit::WebContextMenuProxyMac::contextMenuItemSelected):
      (WebKit::populateNSMenu):
      (WebKit::nsMenuItemVector):
      (WebKit::WebContextMenuProxyMac::populate):
      (WebKit::WebContextMenuProxyMac::showContextMenu):
      (WebKit::WebContextMenuProxyMac::hideContextMenu):
      
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::createContextMenuProxy): Stub for now.
      * UIProcess/win/WebView.h:
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::showContextMenu):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      (WebKit::WebContextMenuClient::getCustomMenuFromDefaultItems): Return the WebCore-provided default
        menu for now. Embedding app customization will come later (see bug 48720)
      
      * WebProcess/WebPage/WebContextMenu.cpp: Added.
      (WebKit::WebContextMenu::WebContextMenu):
      (WebKit::WebContextMenu::~WebContextMenu):
      (WebKit::WebContextMenu::show):
      (WebKit::WebContextMenu::itemSelected):
      * WebProcess/WebPage/WebContextMenu.h: Added.
      (WebKit::WebContextMenu::create):
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::contextMenu):
      (WebKit::handleMouseEvent): Pass right mouse presses along to WebCore as both a mouse event and context menu event, 
        the same way WebKit1 does.
      (WebKit::WebPage::didSelectItemFromActiveContextMenu):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a0329aa
    • pfeldman@chromium.org's avatar
      2010-11-01 Pavel Feldman <pfeldman@chromium.org> · 2c6f4ae9
      pfeldman@chromium.org authored
              Not reviewed: Chromium build fix.
      
              * src/WebDevToolsAgentImpl.cpp:
              (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c6f4ae9
    • eric.carlson@apple.com's avatar
      2010-11-01 Eric Carlson <eric.carlson@apple.com> · 501c3c94
      eric.carlson@apple.com authored
              Reviewed by Adam Roben.
      
              Seeking by very small increment doesn't generate 'seeked' event
              https://bugs.webkit.org/show_bug.cgi?id=48530
      
              Test: media/video-seek-by-small-increment.html
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::seek): Ask the media engine for its closest time value so we can
              avoid asking it to seek to the current time.
      
              * platform/graphics/MediaPlayer.cpp:
              (WebCore::MediaPlayer::mediaTimeForTimeValue): New.
              * platform/graphics/MediaPlayer.h:
              * platform/graphics/MediaPlayerPrivate.h:
              (WebCore::MediaPlayerPrivateInterface::mediaTimeForTimeValue): Ditto.
      
              * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::mediaTimeForTimeValue): Return the closest value in the movie's time scale.
      
              * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
              (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue): Ditto
              * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
      
              * platform/graphics/win/QTMovie.cpp:
              (QTMovie::timeScale): Return the movie's time scale.
              * platform/graphics/win/QTMovie.h:
      
      2010-11-01  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Adam Roben.
      
              Seeking by very small increment doesn't generate 'seeked' event
              https://bugs.webkit.org/show_bug.cgi?id=48530
      
              * media/video-seek-by-small-increment-expected.txt: Added.
              * media/video-seek-by-small-increment.html: Added.
      
              * platform/qt/Skipped: Skip new test as it fails.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      501c3c94
    • pfeldman@chromium.org's avatar
      2010-11-01 Pavel Feldman <pfeldman@chromium.org> · 4aa07655
      pfeldman@chromium.org authored
              Not reviewed: Chromium build fix. Adding missing transitive dependency.
      
              * inspector/InspectorResourceAgent.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4aa07655
    • mihaip@chromium.org's avatar
      2010-11-01 Mihai Parparita <mihaip@chromium.org> · 6d253d29
      mihaip@chromium.org authored
              Update the pixel expectations for fast/block/margin-collapse for the Mac port.
      
              For the tests that currently fail on Snow Leopard with --pixel-tests
              --tolerance 0, this moves the current pixel results to mac-leopard and
              adds new Snow Leopard-specific results to platform/mac.
      
              List of files omitted due to length but composed entirely of moves from
              platform/mac to platform/mac-leopard and newly added files in
              platform/mac.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d253d29
    • pfeldman@chromium.org's avatar
      2010-11-01 Pavel Feldman <pfeldman@chromium.org> · 65ed0cfb
      pfeldman@chromium.org authored
              Not reviewed. Removing references to removed file from project files.
      
              * WebCore.gypi:
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.css:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65ed0cfb
    • pfeldman@chromium.org's avatar
      2010-11-01 Pavel Feldman <pfeldman@chromium.org> · 3e75f054
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: remove old resources panel.
              https://bugs.webkit.org/show_bug.cgi?id=45657
      
              * CMakeLists.txt:
              * English.lproj/localizedStrings.js:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              * inspector/InjectedScriptHost.cpp:
              * inspector/Inspector.idl:
              * inspector/InspectorCSSStore.cpp:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::~InspectorController):
              (WebCore::InspectorController::connectFrontend):
              (WebCore::InspectorController::releaseFrontendLifetimeAgents):
              (WebCore::InspectorController::populateScriptObjects):
              (WebCore::InspectorController::unbindAllResources):
              (WebCore::InspectorController::didCommitLoad):
              (WebCore::InspectorController::frameDetachedFromParent):
              (WebCore::InspectorController::didLoadResourceFromMemoryCache):
              (WebCore::InspectorController::identifierForInitialRequest):
              (WebCore::InspectorController::willSendRequest):
              (WebCore::InspectorController::markResourceAsCached):
              (WebCore::InspectorController::didReceiveResponse):
              (WebCore::InspectorController::didReceiveContentLength):
              (WebCore::InspectorController::didFinishLoading):
              (WebCore::InspectorController::didFailLoading):
              (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
              (WebCore::InspectorController::scriptImported):
              (WebCore::InspectorController::didCreateWebSocket):
              (WebCore::InspectorController::willSendWebSocketHandshakeRequest):
              (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse):
              (WebCore::InspectorController::didCloseWebSocket):
              * inspector/InspectorController.h:
              * inspector/InspectorFrontendHost.cpp:
              * inspector/InspectorResource.cpp: Removed.
              * inspector/InspectorResource.h: Removed.
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::setOverrideContent):
              * inspector/InspectorResourceAgent.h:
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype.addMessage):
              (WebInspector.ConsoleView.prototype.clearMessages):
              * inspector/front-end/ExtensionServer.js:
              (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
              * inspector/front-end/Images/resourcesSilhouette.png: Removed.
              * inspector/front-end/Resource.js:
              * inspector/front-end/ResourceManager.js:
              (WebInspector.ResourceManager.getContent):
              * inspector/front-end/ResourcesPanel.js: Removed.
              * inspector/front-end/Settings.js:
              * inspector/front-end/StoragePanel.js:
              (WebInspector.StoragePanel):
              (WebInspector.StoragePanel.prototype.get toolbarItemLabel):
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.html:
              * inspector/front-end/inspector.js:
              (WebInspector._createPanels):
              (WebInspector.get networkResources):
              (WebInspector.forAllResources):
              (WebInspector.resourceForURL):
              (WebInspector.doLoadedDone.populateInspectorState):
              (WebInspector.openResource):
              (WebInspector.domContentEventFired):
              (WebInspector.loadEventFired):
              (WebInspector.reset):
              (WebInspector._choosePanelToShowSourceLine):
      
      2010-11-01  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              Web Inspector: remove old resources panel.
              https://bugs.webkit.org/show_bug.cgi?id=45657
      
              * src/WebDevToolsAgentImpl.cpp:
              (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):
              * src/WebDevToolsAgentImpl.h:
      
      2010-11-01  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              Web Inspector: remove old resources panel.
              https://bugs.webkit.org/show_bug.cgi?id=45657
      
              * http/tests/inspector/inspector-test2.js:
              * http/tests/inspector/resource-har-conversion.html:
              * http/tests/inspector/resource-parameters.html:
              * inspector/audits-panel-functional.html:
              * inspector/extensions-test.js:
              * inspector/report-protocol-errors-expected.txt:
              * inspector/report-protocol-errors.html:
              * inspector/styles-source-offsets.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e75f054
    • zmo@google.com's avatar
      2010-10-28 Zhenyao Mo <zmo@google.com> · 1b9e28b2
      zmo@google.com authored
              Reviewed by Kenneth Russell.
      
              Fix enum naming style violation in GraphicsContext3D
              https://bugs.webkit.org/show_bug.cgi?id=48441
      
              * platform/graphics/GraphicsContext3D.cpp:
              (WebCore::GraphicsContext3D::extractImageData):
              (WebCore::GraphicsContext3D::extractTextureData):
              (WebCore::doPacking):
              (WebCore::GraphicsContext3D::packPixels):
              * platform/graphics/GraphicsContext3D.h:
              * platform/graphics/cg/GraphicsContext3DCG.cpp:
              (WebCore::getSourceDataFormat):
              (WebCore::GraphicsContext3D::getImageData):
              * platform/graphics/skia/GraphicsContext3DSkia.cpp:
              (WebCore::GraphicsContext3D::getImageData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b9e28b2
    • aroben@apple.com's avatar
      Cancel main resource loads after we hand them off to the media engine · df968144
      aroben@apple.com authored
      This is the WebKit2 equivalent of r51104. Clearly this code should be
      moved to a cross-platform location someday.
      
      Fixes <http://webkit.org/b/48561> <rdar://problem/8606679> Assertion
      failure in DocumentLoader::commitData when loading a media document in
      WebKit2
      
      Reviewed by Eric Carlson.
      
      * WebProcess/WebCoreSupport/WebErrors.h: Added pluginWillHandleLoadError.
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::committedLoad): Cancel the main resource load
      after handing off the load to the media engine. This code originally
      came from -[WebHTMLRepresentation receivedData:withDataSource:].
      (WebKit::WebFrameLoaderClient::pluginWillHandleLoadError): Call through to WebErrors.
      (WebKit::WebFrameLoaderClient::shouldFallBack): Implemented. We fall
      back for all errors except when the load was cancelled or we handed it
      off to the media engine or a plugin.
      
      * WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
      (WebKit::pluginWillHandleLoadError): Implemented.
      
      * WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:
      (WebKit::pluginWillHandleLoadError): Stubbed out.
      
      * WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
      (WebKit::pluginWillHandleLoadError): Implemented.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df968144
    • aroben@apple.com's avatar
      Cancel main resource loads after we hand them off to the media engine · d3161aa7
      aroben@apple.com authored
      This is the Windows equivalent of r51104. Clearly this code should be
      moved to a cross-platform location someday.
      
      Fixes <http://webkit.org/b/48531> <rdar://problem/8606635> Assertion
      failure in DocumentLoader::commitData when loading a media document in
      WebKit1 on Windows
      
      Reviewed by Dan Bernstein.
      
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::committedLoad): Cancel the main resource load
      after handing off the load to the media engine. This code originally
      came from -[WebHTMLRepresentation receivedData:withDataSource:].
      
      * WebFrame.cpp:
      (WebFrame::shouldFallBack): Don't fall back when handing the resource
      load off to the media engine or a plugin. Added error domain checking
      so that we don't rely on error codes being unique.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3161aa7
    • mrobinson@webkit.org's avatar
      2010-11-01 Martin Robinson <mrobinson@igalia.com> · 83caf5cb
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Pasting markup into Thunderbird compose window produces no text
              https://bugs.webkit.org/show_bug.cgi?id=43737
      
              Include a content-type meta tag prefix on all clipboard markup. Programs like
              Thunderbird expect this meta tag and will not paste anything unless it is there.
      
              This is covered by changes to WebKit/gtk/tests/testcopyandpaste.c. This patch was
              written in such a way as to not affect layout test results, otherwise there
              would be many new GTK+-specific results that say "FAIL").
      
              * platform/gtk/PasteboardHelper.cpp:
              (WebCore::removeMarkupPrefix): Added this helper which removes the prefix
              when found on incoming clipboard and drag-and-drop text.
              (WebCore::PasteboardHelper::getClipboardContents): Remove the meta tag prefix.
              (WebCore::PasteboardHelper::fillSelectionData): Add the meta tag prefix.
              (WebCore::PasteboardHelper::fillDataObjectFromDropData): Remove the meta tag prefix
      2010-11-01  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] Pasting markup into Thunderbird compose window produces no text
              https://bugs.webkit.org/show_bug.cgi?id=43737
      
              Added a test verifying that the meta tag prefix on markup data exists.
      
              * tests/testcopyandpaste.c:
              (load_status_cb): Add a check for the meta tag prefix.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83caf5cb
    • commit-queue@webkit.org's avatar
      2010-11-01 Søren Gjesse <sgjesse@chromium.org> · 30748d5c
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              Fix warning when compiling the chromium port of DumpRenderShell
              with clang.
              https://bugs.webkit.org/show_bug.cgi?id=48414
      
              * DumpRenderTree/chromium/TestShell.h:
              (TestShell::javaScriptFlagsForLoad):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30748d5c
    • andreas.kling@nokia.com's avatar
      2010-11-01 Andreas Kling <kling@webkit.org> · 5e10ea5f
      andreas.kling@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt][WK2] Cleanup viewportAttributesForSize API
      
              Change QSize argument to a const QSize&.
      
              * UIProcess/API/qt/qwkpage.cpp:
              (QWKPage::viewportAttributesForSize):
              * UIProcess/API/qt/qwkpage.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e10ea5f
    • ossy@webkit.org's avatar
      Unreviewed. · 7d75cd3f
      ossy@webkit.org authored
      [Qt] DRT sideeffect revealed by r71004
      https://bugs.webkit.org/show_bug.cgi?id=48758
      
      * platform/qt/Skipped: fast/dom/nodesFromRect-basic.html added until fix.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d75cd3f