- 25 Jan, 2011 6 commits
-
-
antti@apple.com authored
Try to fix windows build. * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=53061 Reviewed by Oliver Hunt. Cache did not know about the subclass so failed to fully delete the items. Got rid of the subclass and moved the classes to separate files. * CMakeLists.txt: * GNUmakefile.am: * JavaScriptCore.exp: * JavaScriptCore.gypi: * JavaScriptCore.pro: * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: * JavaScriptCore.xcodeproj/project.pbxproj: * parser/JSParser.cpp: (JSC::JSParser::Scope::saveFunctionInfo): (JSC::JSParser::Scope::restoreFunctionInfo): (JSC::JSParser::findCachedFunctionInfo): (JSC::JSParser::parseFunctionInfo): * parser/SourceProvider.h: * parser/SourceProviderCache.cpp: Added. (JSC::SourceProviderCache::~SourceProviderCache): (JSC::SourceProviderCache::byteSize): * parser/SourceProviderCache.h: Added. (JSC::SourceProviderCache::SourceProviderCache): (JSC::SourceProviderCache::add): (JSC::SourceProviderCache::get): * parser/SourceProviderCacheItem.h: Added. (JSC::SourceProviderCacheItem::SourceProviderCacheItem): (JSC::SourceProviderCacheItem::approximateByteSize): (JSC::SourceProviderCacheItem::closeBraceToken): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Darin Adler. Bug 53087: Refactoring: replaced a hanging "else" with a "return" statement https://bugs.webkit.org/show_bug.cgi?id=53087. Refactoring work: Replaced a hanging "else" within an #if PLATFORM(M with a "return" so that the code is more readable and less error pro (e.g., "else" doesn't use braces so adding extra lines to the else block won't have any effect; even worse, code still compiles successfully. * wtf/Assertions.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cmarrin@apple.com authored
Reviewed by Eric Seidel. Change ENABLE_3D_CANVAS to ENABLE_WEBGL https://bugs.webkit.org/show_bug.cgi?id=53041 * configure.ac: 2011-01-24 Chris Marrin <cmarrin@apple.com> Reviewed by Eric Seidel. Change ENABLE_3D_CANVAS to ENABLE_WEBGL https://bugs.webkit.org/show_bug.cgi?id=53041 * Configurations/FeatureDefines.xcconfig: 2011-01-24 Chris Marrin <cmarrin@apple.com> Reviewed by Eric Seidel. Change ENABLE_3D_CANVAS to ENABLE_WEBGL https://bugs.webkit.org/show_bug.cgi?id=53041 * WebKit.gyp: * features.gypi: * src/Extensions3DChromium.cpp: * src/GraphicsContext3DChromium.cpp: * src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableWebGL): (WebKit::WebRuntimeFeatures::isWebGLEnabled): 2011-01-24 Chris Marrin <cmarrin@apple.com> Reviewed by Eric Seidel. Change ENABLE_3D_CANVAS to ENABLE_WEBGL https://bugs.webkit.org/show_bug.cgi?id=53041 * Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): 2011-01-24 Chris Marrin <cmarrin@apple.com> Reviewed by Eric Seidel. Change ENABLE_3D_CANVAS to ENABLE_WEBGL https://bugs.webkit.org/show_bug.cgi?id=53041 * WebView.cpp: (WebView::notifyPreferencesChanged): 2011-01-24 Chris Marrin <cmarrin@apple.com> Reviewed by Eric Seidel. Change ENABLE_3D_CANVAS to ENABLE_WEBGL https://bugs.webkit.org/show_bug.cgi?id=53041 * Configurations/FeatureDefines.xcconfig: 2011-01-24 Chris Marrin <cmarrin@apple.com> Reviewed by Eric Seidel. Change ENABLE_3D_CANVAS to ENABLE_WEBGL https://bugs.webkit.org/show_bug.cgi?id=53041 * Configurations/FeatureDefines.xcconfig: * DerivedSources.cpp: * GNUmakefile.am: * WebCore.pro: * bindings/generic/RuntimeEnabledFeatures.h: * bindings/js/JSArrayBufferCustom.cpp: * bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::toJS): * bindings/js/JSDOMWindowCustom.cpp: * bindings/js/JSDataViewCustom.cpp: * bindings/js/JSDocumentCustom.cpp: * bindings/js/JSFloat32ArrayCustom.cpp: * bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::getContext): * bindings/js/JSInt16ArrayCustom.cpp: * bindings/js/JSInt32ArrayCustom.cpp: * bindings/js/JSInt8ArrayCustom.cpp: * bindings/js/JSUint16ArrayCustom.cpp: * bindings/js/JSUint32ArrayCustom.cpp: * bindings/js/JSUint8ArrayCustom.cpp: * bindings/js/JSWebGLRenderingContextCustom.cpp: * bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::markChildren): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::response): * bindings/v8/custom/V8ArrayBufferCustom.cpp: * bindings/v8/custom/V8ArrayBufferViewCustom.h: * bindings/v8/custom/V8DataViewCustom.cpp: * bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::V8Document::getCSSCanvasContextCallback): * bindings/v8/custom/V8Float32ArrayCustom.cpp: * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback): * bindings/v8/custom/V8Int16ArrayCustom.cpp: * bindings/v8/custom/V8Int32ArrayCustom.cpp: * bindings/v8/custom/V8Int8ArrayCustom.cpp: * bindings/v8/custom/V8Uint16ArrayCustom.cpp: * bindings/v8/custom/V8Uint32ArrayCustom.cpp: * bindings/v8/custom/V8Uint8ArrayCustom.cpp: * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: * bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::responseAccessorGetter): (WebCore::V8XMLHttpRequest::sendCallback): * features.pri: * html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): (WebCore::HTMLCanvasElement::reset): * html/HTMLCanvasElement.h: * html/canvas/ArrayBuffer.cpp: * html/canvas/ArrayBuffer.idl: * html/canvas/ArrayBufferView.cpp: * html/canvas/ArrayBufferView.idl: * html/canvas/DataView.cpp: * html/canvas/DataView.idl: * html/canvas/Float32Array.cpp: * html/canvas/Float32Array.idl: * html/canvas/Int16Array.cpp: * html/canvas/Int16Array.idl: * html/canvas/Int32Array.cpp: * html/canvas/Int32Array.idl: * html/canvas/Int8Array.cpp: * html/canvas/Int8Array.idl: * html/canvas/OESStandardDerivatives.cpp: * html/canvas/OESStandardDerivatives.idl: * html/canvas/OESTextureFloat.cpp: * html/canvas/OESTextureFloat.idl: * html/canvas/Uint16Array.cpp: * html/canvas/Uint16Array.idl: * html/canvas/Uint32Array.cpp: * html/canvas/Uint32Array.idl: * html/canvas/Uint8Array.cpp: * html/canvas/Uint8Array.idl: * html/canvas/WebGLActiveInfo.idl: * html/canvas/WebGLBuffer.cpp: * html/canvas/WebGLBuffer.idl: * html/canvas/WebGLContextAttributes.cpp: * html/canvas/WebGLContextAttributes.idl: * html/canvas/WebGLContextEvent.idl: * html/canvas/WebGLExtension.cpp: * html/canvas/WebGLFramebuffer.cpp: * html/canvas/WebGLFramebuffer.idl: * html/canvas/WebGLGetInfo.cpp: * html/canvas/WebGLObject.cpp: * html/canvas/WebGLProgram.cpp: * html/canvas/WebGLProgram.idl: * html/canvas/WebGLRenderbuffer.cpp: * html/canvas/WebGLRenderbuffer.idl: * html/canvas/WebGLRenderingContext.cpp: * html/canvas/WebGLRenderingContext.idl: * html/canvas/WebGLShader.cpp: * html/canvas/WebGLShader.idl: * html/canvas/WebGLTexture.cpp: * html/canvas/WebGLTexture.idl: * html/canvas/WebGLUniformLocation.cpp: * html/canvas/WebGLUniformLocation.idl: * html/canvas/WebKitLoseContext.cpp: * html/canvas/WebKitLoseContext.idl: * page/DOMWindow.idl: * platform/graphics/ANGLEWebKitBridge.cpp: * platform/graphics/GraphicsContext3D.cpp: * platform/graphics/cg/GraphicsContext3DCG.cpp: * platform/graphics/gpu/DrawingBuffer.cpp: * platform/graphics/gpu/mac/DrawingBufferMac.mm: * platform/graphics/mac/GraphicsContext3DMac.mm: * platform/graphics/mac/WebGLLayer.mm: * platform/graphics/opengl/Extensions3DOpenGL.cpp: * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: * platform/graphics/qt/Extensions3DQt.cpp: * platform/graphics/qt/GraphicsContext3DQt.cpp: * platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges): * platform/graphics/qt/GraphicsLayerQt.h: * platform/graphics/skia/GraphicsContext3DSkia.cpp: * platform/graphics/texmap/GraphicsLayerTextureMapper.h: * rendering/RenderLayerBacking.cpp: (WebCore::isAcceleratedCanvas): (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): (WebCore::RenderLayerBacking::containsPaintedContent): (WebCore::RenderLayerBacking::contentChanged): * webaudio/AudioBuffer.cpp: * webaudio/AudioBuffer.idl: * webaudio/RealtimeAnalyser.cpp: * webaudio/RealtimeAnalyser.h: * webaudio/RealtimeAnalyserNode.h: * webaudio/RealtimeAnalyserNode.idl: * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::setResponseType): (WebCore::XMLHttpRequest::clearResponse): (WebCore::XMLHttpRequest::didReceiveData): * xml/XMLHttpRequest.h: 2011-01-24 Chris Marrin <cmarrin@apple.com> Reviewed by Eric Seidel. Change ENABLE_3D_CANVAS to ENABLE_WEBGL https://bugs.webkit.org/show_bug.cgi?id=53041 * Configurations/FeatureDefines.xcconfig: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
* JavaScriptCore.vcproj/JavaScriptCore.make: Added a missing "set". git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
Reviewed by Eric Seidel. Add missing defines for COMPILER(RVCT) && CPU(ARM_THUMB2) https://bugs.webkit.org/show_bug.cgi?id=52949 * jit/JITStubs.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 24 Jan, 2011 3 commits
-
-
aroben@apple.com authored
Source/JavaScriptCore: * JavaScriptCore.vcproj/JavaScriptCore.make: Update for move of JavaScriptCore into Source. Source/WebCore: * WebCore.vcproj/WebCore.make: Update for move of WebCore into Source. Source/WebKit/win: * WebKit.vcproj/WebKit.make: Update for move of WebKit into Source. Source/WebKit2: * win/WebKit2.make: Update for move of WebKit2 into Source. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pvarga@webkit.org authored
Reviewed by Oliver Hunt. Optimize regex patterns which contain empty alternatives https://bugs.webkit.org/show_bug.cgi?id=51395 Eliminate the empty alternatives from the regex pattern and convert it to do the matching in an easier way. * fast/regex/script-tests/slow.js: * fast/regex/slow-expected.txt: 2011-01-24 Peter Varga <pvarga@webkit.org> Reviewed by Oliver Hunt. Optimize regex patterns which contain empty alternatives https://bugs.webkit.org/show_bug.cgi?id=51395 Eliminate the empty alternatives from the regex pattern and convert it to do the matching in an easier way. * yarr/YarrPattern.cpp: (JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abecsi@webkit.org authored
Reviewed by Csaba Osztrogonác. [Qt] Move project files into Source https://bugs.webkit.org/show_bug.cgi?id=52891 * Source/DerivedSources.pro: Copied from DerivedSources.pro. * Source/WebKit.pri: Renamed from WebKit.pri. * Source/WebKit.pro: Added. * Source/common.pri: Renamed from common.pri. * WebKit.pro: Removed. 2011-01-24 Andras Becsi <abecsi@webkit.org> Reviewed by Csaba Osztrogonác. [Qt] Move project files into Source https://bugs.webkit.org/show_bug.cgi?id=52891 * JavaScriptCore.pri: * JavaScriptCore.pro: * jsc.pro: 2011-01-24 Andras Becsi <abecsi@webkit.org> Reviewed by Csaba Osztrogonác. [Qt] Move project files into Source https://bugs.webkit.org/show_bug.cgi?id=52891 No new tests needed. * WebCore.pri: * WebCore.pro: 2011-01-24 Andras Becsi <abecsi@webkit.org> Reviewed by Csaba Osztrogonác. [Qt] Move project files into Source https://bugs.webkit.org/show_bug.cgi?id=52891 * declarative/declarative.pro: * docs/docs.pri: * tests/tests.pri: 2011-01-24 Andras Becsi <abecsi@webkit.org> Reviewed by Csaba Osztrogonác. [Qt] Move project files into Source https://bugs.webkit.org/show_bug.cgi?id=52891 * DerivedSources.pro: * WebKit2.pro: * WebProcess.pro: 2011-01-24 Andras Becsi <abecsi@webkit.org> Reviewed by Csaba Osztrogonác. [Qt] Move project files into Source https://bugs.webkit.org/show_bug.cgi?id=52891 * DerivedSources.pro: Renamed from DerivedSources.pro. * DumpRenderTree/qt/DumpRenderTree.pro: * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: * MiniBrowser/DerivedSources.pro: * MiniBrowser/qt/MiniBrowser.pro: * QtTestBrowser/QtTestBrowser.pro: * Scripts/webkitdirs.pm: * Tools.pro: Added. * WebKitTestRunner/DerivedSources.pro: * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: * WebKitTestRunner/qt/WebKitTestRunner.pro: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 23 Jan, 2011 5 commits
-
-
mrowe@apple.com authored
Fix the scripts that detect problematic code such as static initializers and destructors, weak vtables, inappropriate files in the framework wrappers, and public headers including private headers. These had all been broken since the projects were moved in to the Source directory as the paths to the scripts were not updated at that time. Source/JavaScriptCore: * JavaScriptCore.xcodeproj/project.pbxproj: Source/JavaScriptGlue: * JavaScriptGlue.xcodeproj/project.pbxproj: Source/WebCore: Stop copying an IDL file in to the framework wrapper. Doing that doesn't even make sense. * WebCore.xcodeproj/project.pbxproj: Source/WebKit: * WebKit.xcodeproj/project.pbxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
Reviewed by Darin Adler. Use WTF::StringHasher in WebCore https://bugs.webkit.org/show_bug.cgi?id=52934 Add an additional function to calculate the hash of data with a runtimedependent size. * wtf/StringHasher.h: (WTF::StringHasher::createBlobHash): 2011-01-23 Patrick Gansterer <paroga@webkit.org> Reviewed by Darin Adler. Use WTF::StringHasher in WebCore https://bugs.webkit.org/show_bug.cgi?id=52934 * loader/appcache/ApplicationCacheStorage.cpp: (WebCore::urlHostHash): * platform/LinkHash.cpp: (WebCore::visitedLinkHashInline): * platform/cf/BinaryPropertyList.cpp: (WebCore::IntegerArrayHash::hash): * platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::computeHash): * platform/network/ProtectionSpaceHash.h: (WebCore::ProtectionSpaceHash::hash): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
Reviewed by David Kilzer. Fix comment in String::ascii() https://bugs.webkit.org/show_bug.cgi?id=52980 * wtf/text/WTFString.cpp: (WTF::String::ascii): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
Reviewed by David Kilzer. Add String::containsOnlyLatin1() https://bugs.webkit.org/show_bug.cgi?id=52979 * wtf/text/WTFString.h: (WTF::String::containsOnlyLatin1): (WTF::charactersAreAllLatin1): 2011-01-23 Patrick Gansterer <paroga@webkit.org> Reviewed by David Kilzer. Add String::containsOnlyLatin1() https://bugs.webkit.org/show_bug.cgi?id=52979 Use String::containsOnlyLatin1() instead of isSafeToConvertCharList(). * page/DOMWindow.cpp: (WebCore::DOMWindow::btoa): (WebCore::DOMWindow::atob): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
Reviewed by Oliver Hunt. Remove obsolete JSVALUE32 code https://bugs.webkit.org/show_bug.cgi?id=52948 r70111 removed support for JSVALUE32. ARM, MIPS and X86 support JSVALUE32_64 only. * jit/JITStubs.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 22 Jan, 2011 4 commits
-
-
ggaren@apple.com authored
Reviewed by Dan Bernstein. ASSERT running run-webkit-tests --threaded. https://bugs.webkit.org/show_bug.cgi?id=52971 SunSpider and v8 report no change. * runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow): (JSC::ConservativeSet::add): * runtime/ConservativeSet.h: Tweaked the inline capacity to 128, and the growth policy to 2X, to make SunSpider and v8 happy. (JSC::ConservativeSet::ConservativeSet): (JSC::ConservativeSet::~ConservativeSet): (JSC::ConservativeSet::mark): Use OSAllocator directly, instead of malloc. Malloc is forbidden during a multi-threaded mark phase because it can cause deadlock. 2011-01-22 Geoffrey Garen <ggaren@apple.com> Reviewed by Dan Bernstein. Beefed up --threaded mode to catch even more kinds of errors. https://bugs.webkit.org/show_bug.cgi?id=52971 * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared context group to force JSC to mark multiple threads. (This used to be the default, but it changed in SnowLeopard.) (runJavaScriptThread): Do more locking and unlocking, and more allocation, to give threading mistakes more chances to show themselves. (startJavaScriptThreads): (stopJavaScriptThreads): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren@apple.com authored
Reviewed by Geoffrey Garen. Rubber-stamped by Maciej Stachowiak. A few of Maciej's review suggestions for my last patch. https://bugs.webkit.org/show_bug.cgi?id=52946 SunSpider reports no change. * Android.mk: * CMakeLists.txt: * GNUmakefile.am: * JavaScriptCore.gypi: * JavaScriptCore.pro: * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: * JavaScriptCore.xcodeproj/project.pbxproj: Updated build systems. * runtime/ConservativeSet.cpp: Added. (JSC::isPointerAligned): (JSC::ConservativeSet::add): * runtime/ConservativeSet.h: Added. (JSC::ConservativeSet::ConservativeSet): (JSC::ConservativeSet::mark): Split ConservativeSet out into its own file, and moved the conservative check into ConservativeSet::add, making ConservativeSet's responsibility clearer. * runtime/Heap.cpp: (JSC::Heap::markRoots): * runtime/MachineStackMarker.cpp: (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal): (JSC::MachineStackMarker::markOtherThreadConservatively): * runtime/MachineStackMarker.h: * runtime/MarkStack.h: Updated for changes above. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
Unreviewed WinCE build fix for r76430. * runtime/MachineStackMarker.cpp: (JSC::swapIfBackwards): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren@apple.com authored
Reviewed by Beth Dakin. * runtime/JSCell.h: (JSC::JSCell::Heap::heap): * runtime/MarkedSpace.h: (JSC::MarkedSpace::globalData): (JSC::MarkedSpace::heap): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 21 Jan, 2011 8 commits
-
-
ggaren@apple.com authored
* runtime/MachineStackMarker.cpp: (JSC::swapIfBackwards): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=52946 Rubber-stamped by Maciej Stachowiak. SunSpider reports no change. * runtime/MachineStackMarker.cpp: (JSC::swapIfBackwards): Added a helper function for handling platforms where the stack can grow in any direction. (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal): (JSC::MachineStackMarker::markOtherThreadConservatively): Use the helper function. (JSC::isPointerAligned): Use "!" instead of "==0" because a robot told me to. (JSC::MachineStackMarker::markConservatively): Changed to use a more standard looping idiom, and to use the helper function above. * runtime/MarkedSpace.h: (JSC::MarkedSpace::isCellAligned): Use "!" instead of "==0" because a robot told me to. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren@apple.com authored
Reviewed by Maciej Stachowiak. Cleaned up some conservative marking code. https://bugs.webkit.org/show_bug.cgi?id=52946 SunSpider reports no change. * interpreter/RegisterFile.h: No need for a special marking function, since we already expose a start() and end(). * runtime/Heap.cpp: (JSC::Heap::registerFile): (JSC::Heap::markRoots): * runtime/Heap.h: (JSC::Heap::contains): Migrated markConservatively() to the machine stack marker class. Now, Heap just provides a contains() function, which the machine stack marker uses for checking whether a pointer points into the heap. * runtime/MachineStackMarker.cpp: (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal): (JSC::MachineStackMarker::markOtherThreadConservatively): (JSC::isPointerAligned): (JSC::MachineStackMarker::markConservatively): * runtime/MachineStackMarker.h: Move the conservative marking code here. * runtime/MarkStack.h: (JSC::ConservativeSet::add): (JSC::ConservativeSet::mark): Changed to using a vector instead of hash set. Vector seems to be a bit faster, and it generates smaller code. * runtime/MarkedSpace.cpp: (JSC::MarkedSpace::containsSlowCase): * runtime/MarkedSpace.h: (JSC::MarkedSpace::isCellAligned): (JSC::MarkedSpace::isPossibleCell): (JSC::MarkedSpace::contains): Kept the code for determining whether a pointer pointed into marked space, and moved the code for marking a set of conservative pointers into the machine stack marker. * wtf/HashSet.h: (WTF::::add): Added two missing inlines that I noticed while testing vector vs hash set. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/8876150mrowe@apple.com authored
control warning when a client tries to use operator bool exposed above via "using PageBlock::operator bool". Reviewed by Sam Weinig. * wtf/PageAllocation.h: (WTF::PageAllocation::operator bool): * wtf/PageReservation.h: (WTF::PageReservation::operator bool): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
msaboff@apple.com authored
Reviewed by Oliver Hunt. [RegexFuzz] Hang with forward assertion https://bugs.webkit.org/show_bug.cgi?id=52825 <rdar://problem/8894332> The backtrackTo label from the first term in a list of terms is being overwritten by processing of subsequent terms. Changed copyBacktrackToLabel() to check for an existing bcaktrackTo label before copying and renamed it to propagateBacktrackToLabel() since it no longer copies. * yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::BacktrackDestination::propagateBacktrackToLabel): (JSC::Yarr::YarrGenerator::generateParenthesesSingle): 2011-01-21 Michael Saboff <msaboff@apple.com> Reviewed by Oliver Hunt. [RegexFuzz] Hang with forward assertion https://bugs.webkit.org/show_bug.cgi?id=52825 <rdar://problem/8894332> New tests to check for functionality and future regression. * fast/regex/parentheses-expected.txt: * fast/regex/script-tests/parentheses.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren@apple.com authored
Reviewed by Sam Weinig. Moved the mark stack from global data to the heap, since it pertains to the heap, and not the virtual machine as a whole. https://bugs.webkit.org/show_bug.cgi?id=52930 SunSpider reports no change. * runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::markRoots): * runtime/Heap.h: * runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): * runtime/JSGlobalData.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Darin Adler. REGRESSION(r76177): All JavaScriptCore tests fail on ARM https://bugs.webkit.org/show_bug.cgi?id=52814 Get the approximateByteSize value before releasing the OwnPtr. * parser/JSParser.cpp: (JSC::JSParser::parseFunctionInfo): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xan@webkit.org authored
Reviewed by Martin Robinson. Remove unnecessary <stdio.h> include https://bugs.webkit.org/show_bug.cgi?id=52884 * jit/JIT.cpp: remove unnecessary include. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 20 Jan, 2011 8 commits
-
-
rniwa@webkit.org authored
Reviewed by Maciej Stachowiak. Added OwnPtrCommon.h because OwnArrayPtr::set calls deleteOwnedPtr. * wtf/OwnArrayPtr.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
Reviewed by Oliver Hunt. [WINCE] Remove obsolete JSVALUE32 code https://bugs.webkit.org/show_bug.cgi?id=52450 Remove the "offset hack" in create_jit_stubs, since we only support JSVALUE32_64 in the meantime. * create_jit_stubs: Removed offset argument * jit/JITStubs.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren@apple.com authored
Reviewed by Oliver Hunt. When marking conservatively, guard against reviving dead objects. https://bugs.webkit.org/show_bug.cgi?id=52840 SunSpider and v8 say no change. * interpreter/RegisterFile.h: (JSC::RegisterFile::markCallFrames): Updated to use the ConservativeSet API. * runtime/Heap.cpp: (JSC::Heap::recordExtraCost): No need to guard against conservative marking reviving dead objects anymore, since the conservative marking mechanism guards against this now. (JSC::Heap::markConservatively): (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): Don't drain the mark stack inside a marking function. We want to establish a separation of concerns between visiting roots and draining the mark stack. (JSC::Heap::markRoots): Gather the set of conservative references before clearning mark bits, because conservative marking now uses the mark bits to determine if a reference is valid, and avoid reviving dead objects. (JSC::Heap::collectAllGarbage): No need to guard against conservative marking reviving dead objects anymore, since the conservative marking mechanism guards against this now. * runtime/Heap.h: Updated to use the ConservativeSet API. * runtime/MachineStackMarker.cpp: (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal): (JSC::MachineStackMarker::markCurrentThreadConservatively): (JSC::MachineStackMarker::markOtherThreadConservatively): (JSC::MachineStackMarker::markMachineStackConservatively): * runtime/MachineStackMarker.h: Ditto. * runtime/MarkStack.h: (JSC::ConservativeSet::add): (JSC::ConservativeSet::mark): Added ConservativeSet, for gathering the set of conservative references. This is different from MarkStack, since we don't mark the set until it is completely gathered. * runtime/MarkedSpace.cpp: (JSC::MarkedSpace::freeBlock): (JSC::MarkedSpace::resizeBlocks): (JSC::MarkedSpace::markConservatively): * runtime/MarkedSpace.h: When marking conservatively, guard against reviving dead objects. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Geoffrey Garen. [Symbian] Fix StackBounds::initialize() https://bugs.webkit.org/show_bug.cgi?id=52842 * wtf/StackBounds.cpp: (WTF::StackBounds::initialize): Use TThreadStackInfo.iLimit for stack limit git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
msaboff@apple.com authored
Reviewed by Oliver Hunt. <rdar://problem/8890203> [RegexFuzz] Crash in generated code (52773) https://bugs.webkit.org/show_bug.cgi?id=52773 Fixed case where an existing DataLabelPtr is overwritten. The replacing DataLabelPtr is now resolved immediately in linkDataLabelToBacktrackIfExists(). Cleanup - eliminated bool return value for the routine as it was never used. * yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists): 2011-01-20 Michael Saboff <msaboff@apple.com> Reviewed by Oliver Hunt. <rdar://problem/8890203> [RegexFuzz] Crash in generated code (52773) https://bugs.webkit.org/show_bug.cgi?id=52773 New test to validate fix. * fast/regex/parentheses-expected.txt: * fast/regex/script-tests/parentheses.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abecsi@webkit.org authored
Reviewed by Csaba Osztrogonác. [Qt][WK2] WebKit2 enabled build fails to link Work around undefined reference linking issues until the buildsystem gets redesigned. These issues first occured in minimal builds (see BUG 50519). * JavaScriptCore.pri: link as whole-archive for WebKit2 builds git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=49897 Patch by Zoltan Horvath <zoltan@webkit.org> on 2011-01-20 Reviewed by Csaba Osztrogonác. Source/JavaScriptCore: Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589). The modification replaces Noncopyable and FastAllocBase classes and these inherits with their equivalent macro implementation at the necessary places. * wtf/FastAllocBase.h: Turn FastAllocBase's implementation into a macro. Source/WebCore: Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589). The modification replaces Noncopyable and FastAllocBase classes and these inherits with their equivalent macro implementation at the necessary places. Source/WebKit: Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589). The modification replaces Noncopyable and FastAllocBase classes and these inherits with their equivalent macro implementation at the necessary places. Source/WebKit2: Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589). The modification replaces Noncopyable and FastAllocBase classes and these inherits with their equivalent macro implementation at the necessary places. Tools: Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589). The modification replaces Noncopyable and FastAllocBase classes and these inherits with their equivalent macro implementation at the necessary places. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/5469576mrowe@apple.com authored
Reviewed by Maciej Stachowiak. We were failing to initialize the key, causing all sorts of unexpected behavior. * wtf/FastMalloc.cpp: (WTF::setThreadHeap): (WTF::TCMalloc_ThreadCache::GetThreadHeap): (WTF::TCMalloc_ThreadCache::InitTSD): Ensure that the key is initialized. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 19 Jan, 2011 6 commits
-
-
ggaren@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=52668 Reviewed by Darin Adler. * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::markChildren): Account for the fact that the global object moves its variables into and out of the register file. While out of the register file, the symbol table's size is not an accurate count for the size of the register array, since the BytecodeGenerator might be compiling, adding items to the symbol table. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
Reviewed by Geoffrey Garen. Stack overflow when converting an Error object to string https://bugs.webkit.org/show_bug.cgi?id=46410 * fast/js/script-tests/toString-recursion.js: Added. * fast/js/toString-recursion-expected.txt: Added. * fast/js/toString-recursion.html: Added. 2011-01-18 Darin Adler <darin@apple.com> Reviewed by Geoffrey Garen. Stack overflow when converting an Error object to string https://bugs.webkit.org/show_bug.cgi?id=46410 * Android.mk: Added StringRecursionChecker.cpp and StringRecursionChecker.h. * CMakeLists.txt: Ditto. * GNUmakefile.am: Ditto. * JavaScriptCore.gypi: Ditto. * JavaScriptCore.pro: Ditto. * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto. * JavaScriptCore.xcodeproj/project.pbxproj: Ditto. * runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString): Use StringRecursionChecker instead of the older hand-written code to do the same thing. (JSC::arrayProtoFuncToLocaleString): Ditto. (JSC::arrayProtoFuncJoin): Ditto. * runtime/ErrorPrototype.cpp: (JSC::errorProtoFuncToString): Use StringRecursionChecker. * runtime/JSGlobalData.h: Renamed arrayVisitedElements to stringRecursionCheckVisitedObjects. * runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString): Use StringRecursionChecker. * runtime/StringRecursionChecker.cpp: Added. * runtime/StringRecursionChecker.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
Reviewed by Gavin Barraclough. Remove non-spec support for callable RegExp https://bugs.webkit.org/show_bug.cgi?id=28285 Update test results for new behaviour. * fast/js/sputnik/Conformance/11_Expressions/11.4_Unary_Operators/11.4.3_The_typeof_Operator/S11.4.3_A3.6-expected.txt: * fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.7/S15.10.7_A1_T1-expected.txt: * fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.7/S15.10.7_A1_T2-expected.txt: * fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.7/S15.10.7_A3_T1-expected.txt: * fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.7/S15.10.7_A3_T2-expected.txt: * fast/loader/stateobjects/pushstate-object-types-expected.txt: * fast/regex/cross-frame-callable-expected.txt: * fast/regex/script-tests/cross-frame-callable.js: (doTest): 2011-01-19 Oliver Hunt <oliver@apple.com> Reviewed by Gavin Barraclough. Remove non-spec support for callable RegExp https://bugs.webkit.org/show_bug.cgi?id=28285 Remove support for callable regexps. If it breaks sites we can just roll this out. * runtime/RegExpObject.cpp: * runtime/RegExpObject.h: * tests/mozilla/expected.html: update results. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=52622 Reviewed by Oliver Hunt. Use cache to save function offsets and some other info. This avoids quite a bit of work when reparsing the source. Source/JavaScriptCore: * parser/ASTBuilder.h: * parser/JSParser.cpp: (JSC::JSParser::CachedFunctionInfo::CachedFunctionInfo): (JSC::JSParser::CachedFunctionInfo::approximateByteSize): (JSC::JSParser::CachedFunctionInfo::closeBraceToken): (JSC::JSParser::Scope::copyCapturedVariablesToVector): (JSC::JSParser::Scope::saveFunctionInfo): (JSC::JSParser::Scope::restoreFunctionInfo): (JSC::JSParser::findCachedFunctionInfo): (JSC::JSParser::JSParser): (JSC::JSParser::parseProgram): (JSC::JSParser::parseFunctionInfo): * parser/Lexer.h: (JSC::Lexer::setOffset): (JSC::Lexer::setLineNumber): (JSC::Lexer::sourceProvider): * parser/SourceProvider.h: (JSC::SourceProviderCache::SourceProviderCache): (JSC::SourceProviderCache::~SourceProviderCache): (JSC::SourceProviderCache::byteSize): (JSC::SourceProviderCache::add): (JSC::SourceProviderCache::get): (JSC::SourceProvider::SourceProvider): (JSC::SourceProvider::~SourceProvider): (JSC::SourceProvider::cache): (JSC::SourceProvider::notifyCacheSizeChanged): (JSC::SourceProvider::cacheSizeChanged): * parser/SyntaxChecker.h: Source/WebCore: * bindings/js/CachedScriptSourceProvider.h: (WebCore::CachedScriptSourceProvider::cache): (WebCore::CachedScriptSourceProvider::cacheSizeChanged): (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider): * bindings/js/ScriptSourceProvider.h: (WebCore::ScriptSourceProvider::ScriptSourceProvider): * loader/cache/CachedScript.cpp: (WebCore::CachedScript::destroyDecodedData): (WebCore::CachedScript::sourceProviderCache): (WebCore::CachedScript::sourceProviderCacheSizeChanged): * loader/cache/CachedScript.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/5469576mrowe@apple.com authored
Reviewed by Darin Adler. * DerivedSources.make: Evaluate the SDKROOT variable correctly. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76176 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
Reviewed by Gavin Barraclough. [jsfunfuzz] Defining a function called __proto__ inside an eval triggers an assertion https://bugs.webkit.org/show_bug.cgi?id=52672 Add tests to ensure that we disallow __proto__ as a function name. * fast/js/parser-syntax-check-expected.txt: * fast/js/script-tests/parser-syntax-check.js: 2011-01-19 Oliver Hunt <oliver@apple.com> Reviewed by Gavin Barraclough. [jsfunfuzz] Defining a function called __proto__ inside an eval triggers an assertion https://bugs.webkit.org/show_bug.cgi?id=52672 Rather than coming up with a somewhat convoluted mechanism to ensure that developers can override the global objects prototype with a function named __proto__ and expect it to work, we just disallow it at the syntax level. * parser/JSParser.cpp: (JSC::JSParser::parseFunctionInfo): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-