- 23 May, 2007 2 commits
-
-
lars authored
when redirecting and clean up qHash forward declaration a bit. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hausmann authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 22 May, 2007 18 commits
-
-
weinig authored
Fix license. * bindings/js/JSHTMLAnchorElementCustom.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig authored
Reviewed by Adam. Update tests for http://bugs.webkit.org/show_bug.cgi?id=13833 Add ObjC DOM binding for HTMLMarqeeElement * fast/dom/wrapper-classes-expected.txt: * fast/dom/wrapper-classes.html: HTMLMarqueeElement now is a DOMHTMLMarqueeElement WebCore: Reviewed by Adam. Patch for http://bugs.webkit.org/show_bug.cgi?id=13833 Add ObjC DOM binding for HTMLMarqeeElement - Also adds missing DOMHTMLFramePrivate. * DerivedSources.make: * WebCore.xcodeproj/project.pbxproj: * bindings/objc/DOM.mm: (WebCore::createElementClassMap): * bindings/objc/DOMHTML.h: * bindings/objc/DOMInternal.h: * bindings/objc/DOMPrivate.h: * bindings/objc/PublicDOMInterfaces.h: WebKit: Reviewed by Adam. Patch for http://bugs.webkit.org/show_bug.cgi?id=13833 Add ObjC DOM binding for HTMLMarqeeElement - Also adds missing DOMHTMLFramePrivate. * MigrateHeaders.make: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
justing authored
Reviewed by darin http://bugs.webkit.org/show_bug.cgi?id=13804 REGRESSION(r21611): Several new layout test pixel failures (misspelling markers) * editing/selection/13804-expected.checksum: Added. * editing/selection/13804-expected.png: Added. * editing/selection/13804-expected.txt: Added. * editing/selection/13804.html: Added. These were missing: * editing/selection/5076323-1-expected.png: Added. * editing/selection/5076323-2-expected.png: Added. * editing/selection/5076323-3-expected.png: Added. WebCore: Reviewed by darin, who found the fix independently. http://bugs.webkit.org/show_bug.cgi?id=13804 REGRESSION(r21611): Several new layout test pixel failures (misspelling markers) r21611 exposed a bug in the way removeMarkers computes the end of the range to remove markers from. It also introduced a bug: removeMarkers expects a startOffset and a length, not a startOffset and an endOffset (added a layout test). * dom/Document.cpp: (WebCore::Document::removeMarkers): The other removeMarkers expects a startOffset and a length, not a startOffset and an endOffset. (WebCore::Document::removeMarkers): Fixed the endOffset from length and startOffset calculation. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
color. Fix the value cssText method to do the right thing for background and background-position values. Reviewed by beth fast/dom/background-shorthand-csstext.html * css/CSSInitialValue.h: (WebCore::CSSInitialValue:::m_implicit): (WebCore::CSSInitialValue::isImplicitInitialValue): * css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): * css/CSSMutableStyleDeclaration.h: * css/CSSValue.h: (WebCore::CSSValue::isImplicitInitialValue): * css/cssparser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBackgroundShorthand): (WebCore::CSSParser::parseShorthand): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
Reviewed by Geoff. - test for <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong * fast/dom/iframe-document.html: Updated test to expect no document property. * fast/dom/iframe-document-expected.txt: Updated. * fast/forms/focus2.html: Changed test to use ownerDocument instead of document. WebCore: Reviewed by Geoff. - fix <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong The code on ebay was looking for the "document" property on a iframe. We changed that to be the ownerDocument rather than the contentDocument, which was not what ebay was expecting. The best fix seems to be removing the document property altogether. Test: fast/dom/iframe-document.html * bindings/js/kjs_html.h: Remove ElementDocument. * bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): Ditto. WebKit: Reviewed by Geoff. * WebInspector/webInspector/treeoutline.js: Use ownerDocument instead of non-standard document property. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adele authored
A little cleanup from my last checkin. * page/Chrome.h: Formatting change. * page/mac/ChromeMac.mm: Fixed copyright. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adele authored
Reviewed by Darin. Test for http://bugs.webkit.org/show_bug.cgi?id=13796 Crash in [NSInputContext currentInputContext] when you click on this map * fast/frames/frame-display-none-focus-expected.txt: Added. * fast/frames/frame-display-none-focus.html: Added. * fast/frames/resources/iframe-focus.html: Added. WebCore: Reviewed by Darin. Fix for http://bugs.webkit.org/show_bug.cgi?id=13796 Crash in [NSInputContext currentInputContext] when you click on this map This is another case of <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts Test: fast/frames/frame-display-none-focus.html * WebCore.xcodeproj/project.pbxproj: Added ChromeMac.mm * page/Chrome.h: * page/mac/ChromeMac.mm: Added. (WebCore::Chrome::focusNSView): Moved code from Widget::setFocus so it can be used whenever we need to make a view the first responder. * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView): Calls focusNSView. * platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): Calls focusNSView. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
justing authored
Reviewed by darin <rdar://problem/4875189> List is deleted when replacing contents with Chinese/Japanese characters Moved from unsupported-content because we've supported editing lists for a while now: * editing/deleting/4875189-expected.checksum: Added. * editing/deleting/4875189-expected.png: Added. * editing/deleting/4875189-expected.txt: Added. * editing/deleting/4875189.html: Added. * editing/unsupported-content/list-delete-002-expected.checksum: Removed. * editing/unsupported-content/list-delete-002-expected.png: Removed. * editing/unsupported-content/list-delete-002-expected.txt: Removed. * editing/unsupported-content/list-delete-002.html: Removed. Reflects new behavior: * editing/deleting/delete-select-all-003-expected.checksum: * editing/deleting/delete-select-all-003-expected.png: * editing/deleting/delete-select-all-003-expected.txt: Ditto and also removed a FIXME: * editing/deleting/list-item-1-expected.checksum: * editing/deleting/list-item-1-expected.png: * editing/deleting/list-item-1-expected.txt: * editing/deleting/list-item-1.html: WebCore: Reviewed by darin <rdar://problem/4875189> List is deleted when replacing contents with Chinese/Japanese characters * editing/htmlediting.cpp: (WebCore::isSpecialElement): Lists are no longer special. They can be removed by removing their content and then then hitting delete inside of the empty list item that's left over. Even when that list item is the first thing in the editable region. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adele authored
Adding some asserts to help detect other cases of <rdar://problem/5171145> * WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge makeFirstResponder:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- fix <rdar://problem/5206089> REGRESSION: hovering over amazon.com "product categories" tab makes page content disappear The contentWindow property was doing a cross-frame security check, but it shouldn't. Window objects are responsible for protecting themselves from cross-frame activity. Because contentWindow returned undefined, we then ended up setting visibility on the body of the main frame to "hidden". No layout test yet. When we make cross-domain tests, we should include this one. * html/HTMLFrameElement.idl: Removed CheckFrameSecurity attribute from contentWindow. * html/HTMLIFrameElement.idl: Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kmccullo authored
- Forgot to checkin for fix for rdar://problem/4981886 * fast/dom/open-and-close-by-DOM-expected.txt: Added. * fast/dom/open-and-close-by-DOM.html: Added. * fast/dom/resources/close.html: Added. * fast/dom/resources/middle.html: Added. * http/tests/security/local-image-from-remote.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
justing authored
Reviewed by oliver <rdar://problem/5213963> REGRESSION(r21467): Active selection remains in text field after clicking on a button Demonstrates bug: * editing/selection/5213963-expected.checksum: Added. * editing/selection/5213963-expected.png: Added. * editing/selection/5213963-expected.txt: Added. * editing/selection/5213963.html: Added. We now clear the selection on mouse down (but not before the mousedown event is fired): * fast/forms/focus-selection-input-expected.txt: * fast/forms/focus-selection-textarea-expected.txt: WebCore: Reviewed by oliver <rdar://problem/5213963> REGRESSION(r21467): Active selection remains in text field after clicking on a button * page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Call FocusController::setFocusedNode, because Document::setFocusedNode no longer clears the selection. Begin passing the new focused frame to FocusController::setFocusedNode, because when the new focus node is null, the selection should only be cleared if the focused frame isn't changing. (WebCore::Element::focus): Begin passing the new focused frame. (WebCore::Element::blur): Ditto. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): Ditto. * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::focus): Ditto. * page/Frame.cpp: (WebCore::Frame::setFocusedNodeIfNeeded): Ditto. * page/FocusController.cpp: (WebCore::clearSelectionIfNeeded): Take in the new focused frame. If it's not changing, don't clear the selection. (WebCore::FocusController::setFocusedNode): Take in the new focused frame. * page/FocusController.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson authored
<rdar://problem/5219885> - Crash after closing a inline popup ad at http://news.yahoo.com/ This regressed in http://trac.webkit.org/projects/webkit/changeset/21618 * WebView/WebFrame.mm: (-[WebFrame dataSource]): Null check the frameloader git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
staikos authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zack authored
Adding implementations of some of the missing methods. r=me git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hausmann authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
justing authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 21 May, 2007 20 commits
-
-
oliver authored
LayoutTests: Reviewed by Sam. Layout test for http://bugs.webkit.org/show_bug.cgi?id=13789 * svg/custom/getscreenctm-in-mixed-content-expected.checksum: Added. * svg/custom/getscreenctm-in-mixed-content-expected.png: Added. * svg/custom/getscreenctm-in-mixed-content-expected.txt: Added. * svg/custom/getscreenctm-in-mixed-content.xhtml: Added. WebCore: Reviewed by Sam. Fix for http://bugs.webkit.org/show_bug.cgi?id=13789 -- SVGLocatable::getScreenCTM() faulty Needed to update SVGLength to handle the case where the SVGElement is not the root document element -- we do this by falling back on the renderer for the context. For <svg> elements embedded as mixed content in xhtml we consider the absolutePosition of the parent to be the origin for the <svg> element. * ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport): * ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getScreenCTM): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
thatcher authored
<rdar://problem/5084400> -[DOMRange lineBoxRects] returns an empty array when the DOM nodes have just been created Do a updateLayoutIgnorePendingStylesheets before asking the Node or Range for it's box rects. * bindings/objc/DOM.mm: (-[DOMNode boundingBox]): (-[DOMNode lineBoxRects]): (-[DOMRange boundingBox]): (-[DOMRange lineBoxRects]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig authored
Fix Qt build. * WebCore.pro: add missing IDL files. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig authored
Reviewed by Darin. - update tests and results for http://bugs.webkit.org/show_bug.cgi?id=13803 to account for the new JSHTMLMarquee that is being autogenerated and can now produce a constructor. * fast/dom/Window/element-constructors-on-window-expected.txt: * fast/dom/Window/element-constructors-on-window.html: * fast/dom/Window/window-properties-expected.txt: WebCore: Reviewed by Darin. Patch for http://bugs.webkit.org/show_bug.cgi?id=13803 Autogenerate the JS bindings for the HTMLMarqueeElement. * DerivedSources.make: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSHTMLElementWrapperFactory.cpp: * bindings/js/kjs_css.cpp: (KJS::DOMCSSRule::getOwnPropertySlot): Fix possible null pointer issue. (KJS::DOMCSSRule::put): Fix possible null pointer issue. * bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot): Fix null pointer issue. (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::put): * bindings/js/kjs_html.h: (KJS::JSHTMLElement::): * html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::start): (WebCore::HTMLMarqueeElement::stop): * html/HTMLMarqueeElement.h: Add start() and stop() functions. * html/HTMLMarqueeElement.idl: Added. * page/DOMWindow.idl: Add marquee constructor. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adele authored
Fix by Darin, reviewed by me. Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts * platform/mac/WidgetMac.mm: (WebCore::safeRemoveFromSuperview): Added. If the view is the window's first responder, then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it. (WebCore::Widget::setFocus): Don't attempt to focus the view if it has no window. (WebCore::Widget::removeFromSuperview): Call safeRemoveFromSuperview. (WebCore::Widget::afterMouseDown): ditto. WebKit: Fix by Darin, reviewed by me. Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts * WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): If the old view is the first responder, then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
bad. Reviewed by aroben * css/view-source.css: * html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
real links (anchors) in view source mode. Reviewed by aroben * css/view-source.css: * html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addLink): * html/HTMLViewSourceDocument.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson authored
* WebView/WebViewPrivate.h: "Leave for Dashboard, people!" git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson authored
<rdar://problem/5217124> - Re-add mistakenly removed SPI * WebView/WebView.mm: (-[WebView handleAuthenticationForResource:challenge:fromDataSource:]): * WebView/WebViewPrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig authored
Reviewed by Adam and Darin. - update results for http://bugs.webkit.org/show_bug.cgi?id=13791 to account for new JSHTMLElements that are being autogenerated and can now produce constructors. * fast/dom/Window/element-constructors-on-window-expected.txt: * fast/dom/Window/window-properties-expected.txt: WebCore: Reviewed by Adam and Darin. Patch for http://bugs.webkit.org/show_bug.cgi?id=13791 Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement. * DerivedSources.make: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSHTMLAnchorElementCustom.cpp: * bindings/js/JSHTMLElementWrapperFactory.cpp: * bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::HTMLElementFunction::callAsFunction): * bindings/js/kjs_html.h: (KJS::JSHTMLElement::): * bindings/scripts/CodeGeneratorJS.pm: * html/HTMLFrameElement.idl: * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::location): * html/HTMLFrameElementBase.h: * html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::contentWindow): * html/HTMLIFrameElement.idl: * page/DOMWindow.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca authored
<rdar://problem/5200816> REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com ) Null check the request. * WebView/WebView.mm: (+[WebView _canHandleRequest:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
lars authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
lars authored
Remove the userHandle methods from QWebnetworkJob again. They don't really give us anything and just clutter the API. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hausmann authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
lars authored
Add an API layer for network downloads. Basically QWebnetworkInterface is an interface class for downloading resources. QWebnetworkJob describes the actual object to download. QWebNetworkInterface has a default implementation that replaces the old ResourceHandleManager class in the Qt port. Remove the ResourceHandleManager class, it is now part of QWebNetworkInterface. Adapt ResourceHandle to the new way of things. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
<rdar://problem/5205358> REGRESSION (r21367): All messages appear entirely blank when running Mail off of tip of tree WebKit The fix is to return nil from [WebFrame dataSource] when it has not loaded anything but the fake empty initial document. However, WebKit still needs the real data source internally, so I also added a [WebFrame _dataSource] method that skips this check, and made WebKit use it throughout. * Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement): * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView dataSource]): * Plugins/WebNullPluginView.mm: (-[WebNullPluginView viewDidMoveToWindow]): * Plugins/WebPluginController.mm: (-[WebPluginController URLPolicyCheckReferrer]): * WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge dataSource]): (-[WebFrameBridge redirectDataToPlugin:]): * WebCoreSupport/...
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
spanning colgroups. Also make sure colgroups get an actual span of 1 (instead of incorrectly giving them a span of 0). Reviewed by mitz fast/table/colgroup-spanning-groups-rules.html * html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::HTMLTableColElement): * rendering/RenderTable.cpp: (WebCore::RenderTable::colElement): * rendering/RenderTable.h: * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): (WebCore::RenderTableCell::collapsedRightBorder): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-