Commits · 71fb663043acac33e3a60ade335e2848025cff9c · App_Technologies / webkit

21 Jun, 2007 3 commits

aroben authored Jun 21, 2007

More Gdk build fixing.

* WebKit.pro:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

71fb6630

Speculative Gdk build fix. · 5bd3f6ef

aroben authored Jun 21, 2007

* WebCore.pro: Don't try to build WebKitQt/Plugins on Gdk.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5bd3f6ef

Windows build fix. · 6a5d6781

aroben authored Jun 21, 2007

* WebCore.vcproj/WebCore.vcproj: Include ForwardingHeaders after
everything but $WebKitLibrariesDir so that we will pick up
JavaScriptCore headers directly.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6a5d6781

20 Jun, 2007 25 commits

add missing symbol · 102c1905

staikos authored Jun 21, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

102c1905

More missing files for building with Qt · 5fd049f1

staikos authored Jun 21, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5fd049f1

Merge fix from r23692. · 87f9c790

sfalken authored Jun 21, 2007

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

87f9c790

Patch from Adam Treat to add ICO support to the Qt build. · a933d565

staikos authored Jun 21, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a933d565

Reviewed by Anders. · c1c68091

ap authored Jun 21, 2007

        One more test for XHR header injection.

        * http/tests/xmlhttprequest/inject-header-expected.txt: Added.
        * http/tests/xmlhttprequest/inject-header.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c1c68091

One last build fix - now it runs again · 166b14de

staikos authored Jun 21, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

166b14de

Repair the Qt build · 7a272f78

staikos authored Jun 21, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7a272f78

WebCore: · 44bfe8fe

aroben authored Jun 21, 2007

        More speculative Qt/Gdk build fixes.

        * WebCore.pro: Add new files.

WebKitQt:

        More speculative Qt build fixes.

        Add a stub implementation of InspectorClientQt.

        * WebCoreSupport/InspectorClientQt.cpp: Added.
        (WebCore::InspectorClientQt::inspectorDestroyed):
        (WebCore::InspectorClientQt::createPage):
        (WebCore::InspectorClientQt::showWindow):
        (WebCore::InspectorClientQt::closeWindow):
        (WebCore::InspectorClientQt::attachWindow):
        (WebCore::InspectorClientQt::detachWindow):
        (WebCore::InspectorClientQt::highlight):
        (WebCore::InspectorClientQt::hideHighlight):
        * WebCoreSupport/InspectorClientQt.h: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

44bfe8fe

Speculative Qt/Gdk build fix. · 74485a30

aroben authored Jun 21, 2007

Added forwarding headers for JavaScriptCore. We may eventually move
InspectorController off of the JSC API, but for now this is the
quickest way to a working build.

* ForwardingHeaders/JavaScriptCore/JSBase.h: Added.
* ForwardingHeaders/JavaScriptCore/JSContextRef.h: Added.
* ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Added.
* ForwardingHeaders/JavaScriptCore/JSStringRef.h: Added.
* ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Added.
* ForwardingHeaders/JavaScriptCore/JSValueRef.h: Added.
* ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

74485a30

Rubber stamped by Adam Roben. · b8b38a7f

weinig authored Jun 21, 2007

        Add licenses.

        * page/inspector/ConsolePanel.js:
        * page/inspector/NetworkPanel.js:
        * page/inspector/Resource.js:
        * page/inspector/ResourceCategory.js:
        * page/inspector/ResourcePanel.js:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b8b38a7f

Add Bugzilla info to ChangeLog entry. · 503f8309

bdash authored Jun 21, 2007

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

503f8309

2007-06-20 Mark Rowe <mrowe@apple.com> · 7e189f5d

bdash authored Jun 21, 2007

        Reviewed by Adam.

        Reinstate the WebInspector class so WebKit clients that currently depend on it
        will build and run correctly.

        * WebInspector/WebInspector.h: Added.
        * WebInspector/WebInspector.mm: Added.
        (+[WebInspector webInspector]):
        (-[WebInspector dealloc]):
        (-[WebInspector setWebFrame:]):
        (-[WebInspector showWindow:]):
        * WebKit.exp:
        * WebKit.xcodeproj/project.pbxproj:

2007-06-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Adam.

        * WebCore.exp: Export InspectorController::inspect so WebKit can see it.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7e189f5d

Addressed some of Geoff's comments. · 5c08ceb0

aroben authored Jun 21, 2007

* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::handleContextMenuEvent): Added a
FIXME.
* platform/ContextMenu.cpp:
(WebCore::ContextMenu::addInspectElementItem): Null-check
frame->page().


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5c08ceb0

WebCore: · 007c6565

ggaren authored Jun 21, 2007

        Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.

        Fixed <rdar://problem/5222911> Leopard9A446 : VitalSource Bookshelf 4.5: 
        Crashes when you click on sign in (stringByEvaluatingJavaScriptFromString 
        returning nil instead of "")

        I'm basically rolling out the change for <rdar://problem/4782422> because
        my testing shows that it was backwards.
        
        * html/HTMLElement.cpp:
        (dumpInnerHTML): New debug-only function to work around gdb being 
        perpetually suck-tastic.

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
        
        Return "", not nil. This function never used to return nil, so let's not
        start now. I've filed <rdar://problem/5283271> to cover the documentation bug,

WebKitTools:

        Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.

        Added tests for stringByEvaluatingJavaScriptFromString.

        * DumpRenderTree/DumpRenderTree.m:
        (testStringByEvaluatingJavaScriptFromString):
        (dumpRenderTree):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

007c6565

Fix crash in fast/dom/dir-no-body.html · 46b9a999

aroben authored Jun 21, 2007

Reviewed by Mark.

* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::createTokenizer): Don't assume we have a
Frame, since we won't if someone creates an HTMLDocument from JS.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

46b9a999

Reviewed by Geoff. · c3581fd4

andersca authored Jun 21, 2007

		Make sure that the test case tests '\n' and '\r' too.
		
        * fast/dom/xmlhttprequest-invalid-values.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c3581fd4

Land the new Inspector. · dfc5666e

aroben authored Jun 21, 2007

WebCore:

        Land the new Inspector.

        Co-written with Tim Hatcher.

        Reviewed by Anders, Adele, Hyatt, and Sam.

        No regression tests possible.

        Add a new InspectorController that is in charge of the Inspector. It
        has an InspectorClient that controls the Inspector's window and node
        highlight.

        * page/InspectorClient.h: Added.
        (WebCore::InspectorClient::~InspectorClient):
        * page/InspectorController.cpp: Added.
        (WebCore::ConsoleMessage::ConsoleMessage):
        (WebCore::InspectorResource::): Represents a single resource that the
        Inspector knows about.
        (WebCore::InspectorResource::InspectorResource):
        (WebCore::InspectorResource::~InspectorResource):
        (WebCore::InspectorResource::type):
        (WebCore::InspectorResource::setScriptObject):
        (WebCore::addSourceToFrame): Callback available from JS.
        (WebCore::getResourceDocumentNode): Ditto.
        (WebCore::highlightDOMNode): Ditto.
        (WebCore::hideDOMNodeHighlight): Ditto.
        (WebCore::loaded): Ditto.
        (WebCore::unloading): Ditto.
        (WebCore::attach): Ditto.
        (WebCore::detach): Ditto.
        (WebCore::log): Ditto.
        (WebCore::search): Ditto.
        (WebCore::inspectedWindow): Ditto.
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::inspect): Called by
        ContextMenuController to inspect a node.
        (WebCore::InspectorController::focusNode):
        (WebCore::InspectorController::highlight):
        (WebCore::InspectorController::hideHighlight):
        (WebCore::InspectorController::windowVisible):
        (WebCore::InspectorController::setWindowVisible):
        (WebCore::InspectorController::addMessageToConsole):
        (WebCore::InspectorController::attachWindow):
        (WebCore::InspectorController::detachWindow):
        (WebCore::InspectorController::windowScriptObjectAvailable):
        (WebCore::InspectorController::scriptObjectReady):
        (WebCore::InspectorController::windowUnloading):
        (WebCore::addHeaders): Static helper function.
        (WebCore::objectForRequest): Ditto.
        (WebCore::objectForResponse): Ditto.
        (WebCore::InspectorController::addScriptResource):
        (WebCore::InspectorController::addAndUpdateScriptResource):
        (WebCore::InspectorController::removeScriptResource):
        (WebCore::InspectorController::updateScriptResource):
        (WebCore::InspectorController::populateScriptResources):
        (WebCore::InspectorController::addScriptConsoleMessage):
        (WebCore::callClearFunction): Static helper function.
        (WebCore::InspectorController::clearScriptResources):
        (WebCore::InspectorController::clearScriptConsoleMessages):
        (WebCore::InspectorController::clearNetworkTimeline):
        (WebCore::InspectorController::pruneResources):
        (WebCore::InspectorController::didCommitLoad): Callback from
        FrameLoader.
        (WebCore::InspectorController::frameDetachedFromParent): Ditto.
        (WebCore::InspectorController::addResource): Ditto.
        (WebCore::InspectorController::removeResource): Ditto.
        (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
        (WebCore::InspectorController::identifierForInitialRequest): Ditto.
        (WebCore::InspectorController::willSendRequest): Ditto.
        (WebCore::InspectorController::didReceiveResponse): Ditto.
        (WebCore::InspectorController::didReceiveContentLength): Ditto.
        (WebCore::InspectorController::didFinishLoading): Ditto.
        (WebCore::InspectorController::didFailLoading): Ditto.
        * page/InspectorController.h: Added.
        (WebCore::InspectorController::inspectedPage):
        (WebCore::InspectorController::scriptContext):
        (WebCore::InspectorController::setScriptContext):
        (WebCore::InspectorController::resources):
        (WebCore::InspectorController::removeAllResources):

        Add the JavaScript that defines most of the behavior of the Inspector.

        * page/inspector/ConsolePanel.js: Added.
        * page/inspector/NetworkPanel.js: Added.
        * page/inspector/Resource.js: Added.
        * page/inspector/ResourceCategory.js: Added.
        * page/inspector/ResourcePanel.js: Added.
        * page/inspector/inspector.js: Added.
        * page/inspector/treeoutline.js: Renamed from WebKit/WebInspector/webInspector/treeoutline.js.
        * page/inspector/utilities.js: Added.

        Add the Inspector's CSS and HTML.

        * page/inspector/inspector.css: Added.
        * page/inspector/inspector.html: Added.

        Hang the InspectorController off of Page. We only create an
        InspectorController if an InspectorClient is given to the Page.

        * page/Page.cpp:
        (WebCore::Page::Page):
        * page/Page.h:
        (WebCore::Page::inspectorController):

        Use FrameLoader to notify the InspectorController of resource loads.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::begin):
        (WebCore::FrameLoader::transitionToCommitted):
        (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
        (WebCore::FrameLoader::detachFromParent):
        (WebCore::FrameLoader::assignIdentifierToInitialRequest):
        (WebCore::FrameLoader::willSendRequest):
        (WebCore::FrameLoader::didReceiveResponse):
        (WebCore::FrameLoader::didReceiveData):
        (WebCore::FrameLoader::sendRemainingDelegateMessages):
        (WebCore::FrameLoader::requestFromDelegate):
        (WebCore::FrameLoader::didFinishLoad):
        (WebCore::FrameLoader::dispatchWindowObjectAvailable):
        (WebCore::FrameLoader::dispatchDidCommitLoad):
        (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
        (WebCore::FrameLoader::dispatchWillSendRequest):
        (WebCore::FrameLoader::dispatchDidReceiveResponse):
        (WebCore::FrameLoader::dispatchDidReceiveContentLength):
        (WebCore::FrameLoader::dispatchDidFinishLoading):
        (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache):
        * loader/FrameLoader.h:

        Send console messages to the InspectorController.

        * page/Chrome.cpp:
        (WebCore::Chrome::addMessageToConsole): Send all console messages to
        the InspectorController.
        * page/Chrome.h: Add a new MessageLevel and MessageSource that are
        used in the Inspector JS.

        Report HTML errors when the Inspector window is open.
        We don't report errors when the window is closed because we don't want
        to slow down the HTMLTokenizer.

        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::createTokenizer):
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::HTMLParser):
        * html/HTMLParser.h:
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::HTMLTokenizer):
        * html/HTMLTokenizer.h:

        Append the "Inspect Element" context menu item after passing the
        context menu to the ContextMenuClient. This work used to be done in
        WebKit.

        * page/ContextMenuClient.h:
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::handleContextMenuEvent): Add the
        "Inspect Element" item.
        (WebCore::ContextMenuController::contextMenuItemSelected): Handle the
        "Inspect Element" item.
        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::addInspectElementItem):
        (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for "Inspect
        Element" item.
        * platform/ContextMenu.h:
        * platform/ContextMenuItem.h:
        (WebCore::): Add ContextMenuItemTagInspectElement.
        * platform/graphics/svg/SVGImageEmptyClients.h:
        * page/mac/WebCoreViewFactory.h: Add the "Inspect Element" localized
        string.
        * platform/LocalizedStrings.h: Ditto.
        * platform/mac/LocalizedStringsMac.mm:
        (WebCore::contextMenuItemTagInspectElement): Ditto.

        Miscellaneous changes:

        * css/view-source.css: Add message bubble styles.
        * loader/DocumentLoader.h: Add a frame getter.
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::updateScrollbars): Respect
        Frame::prohibitsScrolling.

        Add new images needed for the Inspector.

        * page/inspector/Images/attachedShadow.png: Added.
        * page/inspector/Images/bottomShadow.png: Added.
        * page/inspector/Images/breadcrumbBackground.png: Added.
        * page/inspector/Images/checker.png: Added.
        * page/inspector/Images/console.png: Added.
        * page/inspector/Images/darkShadow.png: Added.
        * page/inspector/Images/disclosureDownPressed.png: Added.
        * page/inspector/Images/disclosureRightDown.png: Added.
        * page/inspector/Images/disclosureRightPressed.png: Added.
        * page/inspector/Images/document.png: Added.
        * page/inspector/Images/domViewButton.png: Added.
        * page/inspector/Images/domViewButtonSelected.png: Added.
        * page/inspector/Images/downTriangle.png: Added.
        * page/inspector/Images/errorIcon.png: Added.
        * page/inspector/Images/errorMediumIcon.png: Added.
        * page/inspector/Images/folder.png: Added.
        * page/inspector/Images/goArrow.png: Added.
        * page/inspector/Images/gradient.png: Added.
        * page/inspector/Images/gradientHighlight.png: Added.
        * page/inspector/Images/gradientHighlightBottom.png: Added.
        * page/inspector/Images/hideStatusWidget.png: Added.
        * page/inspector/Images/hideStatusWidgetPressed.png: Added.
        * page/inspector/Images/network.png: Added.
        * page/inspector/Images/paneBottomGrow.png: Added.
        * page/inspector/Images/paneBottomGrowActive.png: Added.
        * page/inspector/Images/paneGrowHandleLine.png: Added.
        * page/inspector/Images/paneHeader.png: Added.
        * page/inspector/Images/paneHeaderActive.png: Added.
        * page/inspector/Images/plainDocument.png: Added.
        * page/inspector/Images/popupArrows.png: Added.
        * page/inspector/Images/rightTriangle.png: Added.
        * page/inspector/Images/segment.png: Added.
        * page/inspector/Images/segmentEnd.png: Added.
        * page/inspector/Images/segmentHover.png: Added.
        * page/inspector/Images/segmentHoverEnd.png: Added.
        * page/inspector/Images/segmentSelected.png: Added.
        * page/inspector/Images/segmentSelectedEnd.png: Added.
        * page/inspector/Images/showStatusWidget.png: Added.
        * page/inspector/Images/showStatusWidgetPressed.png: Added.
        * page/inspector/Images/sidbarItemBackground.png: Added.
        * page/inspector/Images/sidebarActionWidget.png: Added.
        * page/inspector/Images/sidebarActionWidgetPressed.png: Added.
        * page/inspector/Images/sidebarAttachWidget.png: Added.
        * page/inspector/Images/sidebarAttachWidgetPressed.png: Added.
        * page/inspector/Images/sidebarDetachWidget.png: Added.
        * page/inspector/Images/sidebarDetachWidgetPressed.png: Added.
        * page/inspector/Images/sidebarResizeWidget.png: Added.
        * page/inspector/Images/sidebarSelection.png: Added.
        * page/inspector/Images/sidebarSelectionBlurred.png: Added.
        * page/inspector/Images/sidebarSelectionBlurredTall.png: Added.
        * page/inspector/Images/sidebarSelectionGray.png: Added.
        * page/inspector/Images/sidebarSelectionGrayTall.png: Added.
        * page/inspector/Images/sidebarSelectionTall.png: Added.
        * page/inspector/Images/sidebarStatusAreaBackground.png: Added.
        * page/inspector/Images/sourceViewButton.png: Added.
        * page/inspector/Images/sourceViewButtonSelected.png: Added.
        * page/inspector/Images/splitviewDimple.png: Added.
        * page/inspector/Images/splitviewDividerBackground.png: Added.
        * page/inspector/Images/tab.png: Added.
        * page/inspector/Images/tabSelected.png: Added.
        * page/inspector/Images/timelinePillBlue.png: Added.
        * page/inspector/Images/timelinePillGray.png: Added.
        * page/inspector/Images/timelinePillGreen.png: Added.
        * page/inspector/Images/timelinePillOrange.png: Added.
        * page/inspector/Images/timelinePillPurple.png: Added.
        * page/inspector/Images/timelinePillRed.png: Added.
        * page/inspector/Images/timelinePillYellow.png: Added.
        * page/inspector/Images/tipBalloon.png: Added.
        * page/inspector/Images/tipBalloonBottom.png: Added.
        * page/inspector/Images/tipIcon.png: Added.
        * page/inspector/Images/tipIconPressed.png: Added.
        * page/inspector/Images/toggleDown.png: Added.
        * page/inspector/Images/toggleUp.png: Added.
        * page/inspector/Images/toolbarBackground.png: Added.
        * page/inspector/Images/toolbarBackgroundInactive.png: Added.
        * page/inspector/Images/toolbarButton.png: Added.
        * page/inspector/Images/toolbarButtonInactive.png: Added.
        * page/inspector/Images/toolbarButtonPressed.png: Added.
        * page/inspector/Images/toolbarButtonPressedInactive.png: Added.
        * page/inspector/Images/toolbarSplitButtonDivider.png: Added.
        * page/inspector/Images/toolbarSplitButtonDividerInactive.png: Added.
        * page/inspector/Images/treeDownTriangleBlack.png: Added.
        * page/inspector/Images/treeDownTriangleWhite.png: Added.
        * page/inspector/Images/treeLeftTriangleBlack.png: Added.
        * page/inspector/Images/treeRightTriangleBlack.png: Added.
        * page/inspector/Images/treeRightTriangleWhite.png: Added.
        * page/inspector/Images/warningIcon.png: Added.
        * page/inspector/Images/warningMediumIcon.png: Added.
        * page/inspector/Images/warningsErrors.png: Added.

        Build-fu:

        * WebCore.exp: Added new symbols.
        * WebCore.xcodeproj/project.pbxproj: Added new source files and
        resources.
        * WebCore.vcproj/WebCore.vcproj: Ditto, and copy the resources to
        $WebKitOutputDir.

        Windows build fixes:

        * history/HistoryItem.h: ResourceRequest is a struct.
        * loader/FrameLoaderClient.h: Ditto.

WebKit:

        Land the new Inspector.

        Co-written with Tim Hatcher.

        Reviewed by Anders, Adele, Hyatt, and Sam.

        Implement the InspectorClient interface.

        * WebCoreSupport/WebInspectorClient.h: Added.
        * WebCoreSupport/WebInspectorClient.mm: Added.
        (WebInspectorClient::WebInspectorClient):
        (WebInspectorClient::inspectorDestroyed):
        (WebInspectorClient::createPage):
        (WebInspectorClient::showWindow):
        (WebInspectorClient::closeWindow):
        (WebInspectorClient::attachWindow):
        (WebInspectorClient::detachWindow):
        (WebInspectorClient::highlight):
        (WebInspectorClient::hideHighlight):
        (WebInspectorClient::inspectedURLChanged):
        (WebInspectorClient::updateWindowTitle):
        (-[WebInspectorWindowController init]):
        (-[WebInspectorWindowController initWithInspectedWebView:]):
        (-[WebInspectorWindowController dealloc]):
        (-[WebInspectorWindowController inspectorVisible]):
        (-[WebInspectorWindowController webView]):
        (-[WebInspectorWindowController window]):
        (-[WebInspectorWindowController windowShouldClose:]):
        (-[WebInspectorWindowController close]):
        (-[WebInspectorWindowController showWindow:]):
        (-[WebInspectorWindowController attach]):
        (-[WebInspectorWindowController detach]):
        (-[WebInspectorWindowController highlightAndScrollToNode:]):
        (-[WebInspectorWindowController highlightNode:]):
        (-[WebInspectorWindowController hideHighlight]):
        (-[WebInspectorWindowController animationDidEnd:]):

        Add an easier-to-see highlight.

        * Misc/WebNSViewExtras.h:
        * Misc/WebNSViewExtras.m:
        (-[NSView _web_convertRect:toView:]):
        * WebInspector/WebNodeHighlight.h:
        * WebInspector/WebNodeHighlight.m:
        (-[WebNodeHighlightFadeInAnimation setCurrentProgress:]):
        (-[WebNodeHighlight initWithTargetView:]):
        (-[WebNodeHighlight setHighlightedNode:]):
        (-[WebNodeHighlight highlightedNode]):
        (-[WebNodeHighlight dealloc]):
        (-[WebNodeHighlight attachHighlight]):
        (-[WebNodeHighlight delegate]):
        (-[WebNodeHighlight detachHighlight]):
        (-[WebNodeHighlight show]):
        (-[WebNodeHighlight hide]):
        (-[WebNodeHighlight animationDidEnd:]):
        (-[WebNodeHighlight ignoresMouseEvents]):
        (-[WebNodeHighlight highlightView]):
        (-[WebNodeHighlight setDelegate:]):
        (-[WebNodeHighlight setHolesNeedUpdateInTargetViewRect:]):
        (-[WebNodeHighlight setIgnoresMouseEvents:]):
        (-[WebNodeHighlight targetView]):
        (-[WebNodeHighlight _computeHighlightWindowFrame]):
        (-[WebNodeHighlight _repositionHighlightWindow]):
        * WebInspector/WebNodeHighlightView.h:
        * WebInspector/WebNodeHighlightView.m:
        (-[WebNodeHighlightView initWithWebNodeHighlight:]):
        (-[WebNodeHighlightView dealloc]):
        (-[WebNodeHighlightView detachFromWebNodeHighlight]):
        (-[WebNodeHighlightView drawRect:]):
        (-[WebNodeHighlightView webNodeHighlight]):
        (-[WebNodeHighlightView fractionFadedIn]):
        (-[WebNodeHighlightView setFractionFadedIn:]):
        (-[WebNodeHighlightView setHolesNeedUpdateInRect:]):
        (-[WebNodeHighlightView _holes]):

        WebView changes needed for the new Inspector.

        * WebView/WebView.mm: Remove the old _inspectElement method now that
        this is handled by WebCore.
        (-[WebView _isClosed]): Added.
        (-[WebView initWithFrame]): Give each Page an InspectorClient to
        enable the Inspector.
        * WebView/WebViewPrivate.h:

        Updates needed for WebCore changes.

        * WebCoreSupport/WebContextMenuClient.h:
        * WebCoreSupport/WebContextMenuClient.mm:
        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory contextMenuItemTagInspectElement]):
        * WebView/WebUIDelegatePrivate.h:

        Remove old Inspector code.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
        (WebFrameLoaderClient::assignIdentifierToInitialRequest):
        (WebFrameLoaderClient::dispatchDidFinishLoading):
        * WebInspector/WebInspector.m: Removed.
        * WebInspector/WebInspectorPanel.h: Removed.
        * WebInspector/WebInspectorPanel.m: Removed.
        * WebInspector/webInspector/Images/button.png: Removed.
        * WebInspector/webInspector/Images/buttonDivider.png: Removed.
        * WebInspector/webInspector/Images/buttonPressed.png: Removed.
        * WebInspector/webInspector/Images/close.png: Removed.
        * WebInspector/webInspector/Images/closePressed.png: Removed.
        * WebInspector/webInspector/Images/downTriangle.png: Removed.
        * WebInspector/webInspector/Images/menu.png: Removed.
        * WebInspector/webInspector/Images/menuPressed.png: Removed.
        * WebInspector/webInspector/Images/popup.png: Removed.
        * WebInspector/webInspector/Images/popupPressed.png: Removed.
        * WebInspector/webInspector/Images/resize.png: Removed.
        * WebInspector/webInspector/Images/rightTriangle.png: Removed.
        * WebInspector/webInspector/Images/scrollThumbBottom.png: Removed.
        * WebInspector/webInspector/Images/scrollThumbMiddle.png: Removed.
        * WebInspector/webInspector/Images/scrollTrackBottom.png: Removed.
        * WebInspector/webInspector/Images/upTriangle.png: Removed.
        * WebInspector/webInspector/inspector.css: Removed.
        * WebInspector/webInspector/inspector.html: Removed.
        * WebInspector/webInspector/inspector.js: Removed.
        * WebInspector/webInspector/scrollarea.js: Removed.
        * WebInspector/webInspector/scrollbar.js: Removed.
        * WebInspector/webInspector/utilities.js: Removed.
        * WebView/WebFrame.mm:
        (-[WebFramePrivate dealloc]):
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView menuForEvent:]):

        Build-fu:

        * WebKit.exp:
        * WebKit.xcodeproj/project.pbxproj:

WebKit/win:

        Land the new Inspector.

        Co-written with Tim Hatcher.

        Reviewed by Anders, Adele, Hyatt, and Sam.

        Implement the InspectorClient interface.

        * WebInspectorClient.cpp: Added.
        (WebInspectorClient::WebInspectorClient):
        (WebInspectorClient::~WebInspectorClient):
        (WebInspectorClient::inspectorDestroyed):
        (WebInspectorClient::createPage):
        (WebInspectorClient::showWindow):
        (WebInspectorClient::closeWindow):
        (WebInspectorClient::windowVisible):
        (WebInspectorClient::attachWindow):
        (WebInspectorClient::detachWindow):
        (WebInspectorClient::highlight):
        (WebInspectorClient::hideHighlight):
        (WebInspectorClient::inspectedURLChanged):
        (WebInspectorClient::updateWindowTitle):
        (WebInspectorClient::onSize):
        (WebInspectorClient::onClose):
        (WebInspectorClient::onWebViewWindowPosChanging):
        (WebInspectorWndProc):
        (SubclassedWebViewWndProc):
        (registerWindowClass):
        * WebInspectorClient.h: Added.

        Add an easier-to-see highlight.

        * WebNodeHighlight.cpp: Added.
        (WebNodeHighlight::WebNodeHighlight):
        (WebNodeHighlight::~WebNodeHighlight):
        (WebNodeHighlight::highlight):
        (WebNodeHighlight::hide):
        (WebNodeHighlight::visible):
        (WebNodeHighlight::updateWindow):
        (WebNodeHighlight::removeSubclass):
        (registerOverlayClass):
        (OverlayWndProc):
        (SubclassedWndProc):
        * WebNodeHighlight.h: Added.

        WebView changes needed for the new Inspector.

        * WebView.cpp: Removed old inspectElement method now that this is
        handled by WebCore.
        (WebView::WebView):
        (WebView::close):
        (WebView::performContextMenuAction): Removed handling of the Inspect
        Element context menu item.
        (WebView::initWithFrame): Give each Page an InspectorClient to enable
        the Inspector.
        (WebView::setProhibitsMainFrameScrolling): Added.
        * WebView.h:

        Updates needed for WebCore changes.

        * Interfaces/IWebUIDelegate.idl:
        * WebContextMenuClient.cpp:
        (WebContextMenuClient::getCustomMenuFromDefaultItems):
        * WebContextMenuClient.h:
        * WebCoreLocalizedStrings.cpp:

        Remove old Inspector code.

        * WebFrame.cpp:
        * WebFrame.h:
        * WebInspector/WebInspector.cpp: Removed.
        * WebInspector/WebInspector.h: Removed.
        * WebInspector/webInspector/Images/button.png: Removed.
        * WebInspector/webInspector/Images/buttonDivider.png: Removed.
        * WebInspector/webInspector/Images/buttonPressed.png: Removed.
        * WebInspector/webInspector/Images/close.png: Removed.
        * WebInspector/webInspector/Images/closePressed.png: Removed.
        * WebInspector/webInspector/Images/downTriangle.png: Removed.
        * WebInspector/webInspector/Images/menu.png: Removed.
        * WebInspector/webInspector/Images/menuPressed.png: Removed.
        * WebInspector/webInspector/Images/popup.png: Removed.
        * WebInspector/webInspector/Images/popupPressed.png: Removed.
        * WebInspector/webInspector/Images/resize.png: Removed.
        * WebInspector/webInspector/Images/rightTriangle.png: Removed.
        * WebInspector/webInspector/Images/scrollThumbBottom.png: Removed.
        * WebInspector/webInspector/Images/scrollThumbMiddle.png: Removed.
        * WebInspector/webInspector/Images/scrollTrackMiddle.png: Removed.
        * WebInspector/webInspector/Images/upTriangle.png: Removed.
        * WebInspector/webInspector/inspector.css: Removed.
        * WebInspector/webInspector/inspector.html: Removed.
        * WebInspector/webInspector/inspector.js: Removed.
        * WebInspector/webInspector/scrollarea.js: Removed.
        * WebInspector/webInspector/scrollbar.js: Removed.
        * WebInspector/webInspector/treeoutline.js: Removed.
        * WebInspector/webInspector/utilities.js: Removed.

        Build-fu:

        * WebKit.vcproj/WebKit.vcproj:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

dfc5666e

2007-06-20 Mitz Pettel <mitz@webkit.org> · 941fec3a

bdash authored Jun 21, 2007

        Reviewed by Beth.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14056
          REGRESSION (r21113-21143): TR background not repainted via style class change

        Test: fast/repaint/table-row.html

        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::layout): Added a repaint to make up for the case where the
        table row also needs layout, so it doesn't get a repaint in setStyle().

2007-06-20  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Beth.

        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=14056
          REGRESSION (r21113-21143): TR background not repainted via style class change

        * fast/repaint/table-row-expected.checksum: Added.
        * fast/repaint/table-row-expected.png: Added.
        * fast/repaint/table-row-expected.txt: Added.
        * fast/repaint/table-row.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

941fec3a

2007-06-20 Mark Rowe <mrowe@apple.com> · 7891c027

bdash authored Jun 21, 2007

        Reviewed by Mitz.

        Fix http://bugs.webkit.org/show_bug.cgi?id=14244
        Bug 14244: Data corruption when using a replace() callback function with data containing "$"

        * kjs/string_object.cpp:
        (KJS::replace):  When 'replacement' is a function, do not replace $n placeholders in its return value.
        This matches the behaviour described in ECMA 262 3rd Ed section 15.5.4.1, and as implemented in Firefox.

2007-06-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Mitz.

        Test for http://bugs.webkit.org/show_bug.cgi?id=14244
        Bug 14244: Data corruption when using a replace() callback function with data containing "$"

        * fast/js/resources/string-replace-2.js: Update to test with 'replaceValue' being a function returning strings with "$n" placeholders.
        * fast/js/string-replace-2-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7891c027

LayoutTests: · 16ff661c

adele authored Jun 20, 2007

        Reviewed by Adele.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=14040
          Top and bottom border images flipped when using -webkit-border-image when border end up tiled

        * fast/borders/border-image-01-expected.checksum: Added.
        * fast/borders/border-image-01-expected.png: Added.
        * fast/borders/border-image-01-expected.txt: Added.
        * fast/borders/border-image-01.html: Added.
        * fast/borders/resources/border-image.png: Added.

WebCore:

        Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14040
          Top and bottom border images flipped when using -webkit-border-image when border end up tiled

        Test: fast/borders/border-image-01.html

        Correctly account for the fact that "pattern space" is flipped.

        * platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::Image::drawPatternCallback):
        (WebCore::Image::drawPattern):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16ff661c

Reviewed by Darin. · 40095992

andersca authored Jun 20, 2007

        <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
        
        Check for either '\r' or '\n' in the header value.
        
        * xml/xmlhttprequest.cpp:
        (WebCore::isValidHeaderValue):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

40095992

Reviewed by Darin. · 48c5af23

justing authored Jun 20, 2007

        
        <rdar://problem/5263541> REGRESSION (Safari 3 Beta 1): Pressing Delete doesn't delete an HTML message in Mail
        
        Mail wasn't receiving the keyDown event because WebFrameView was blocking it.
        It blocks the event and moves back/forward on Delete/Shift+Delete if the
        back/forward list is enabled.

        * WebView/WebFrameView.mm:
        (-[WebFrameView keyDown:]): Check to see if the BackForwardList is
        enabled.  It always exists.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

48c5af23

<rdar://problem/4882527 > VO should speak URL of image links that lack tags · 2c5b5366

pyeh authored Jun 20, 2007

        Add additional change from review
        
        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityAttributeValue:]):
        Check if the element has imgTag before asking for its url


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2c5b5366

<rdar://problem/4882527 > VO should speak URL of image links that lack tags · d87902fe

pyeh authored Jun 20, 2007

        
        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityAttributeNames]):
        (-[WebCoreAXObject accessibilityAttributeValue:]):
        Return the url of images.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d87902fe

Remove the XPath tests, they all pass now. · 58e46279

andersca authored Jun 20, 2007

		
        * win/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

58e46279

19 Jun, 2007 12 commits

WebCore: · e8946322

andersca authored Jun 20, 2007

        Reviewed by Kevin Decker.

        <rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed
        
        Add a new m_deferMainResourceDataLoad that can be used to control whether a data load should be deferred using a timer or not.
        
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::DocumentLoader):
        * loader/DocumentLoader.h:
        (WebCore::DocumentLoader::deferMainResourceDataLoad):
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::handleDataLoadSoon):
        (WebCore::MainResourceLoader::loadNow):
        (WebCore::MainResourceLoader::setDefersLoading):

WebKit:

        Reviewed by Kevin Decker.

        <rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed

        * WebView/WebDocumentLoaderMac.mm:
        (needsAppKitWorkaround):
        New function which checks if the frame load delegate belongs to AppKit.
        
        (WebDocumentLoaderMac::setDataSource):
        If the frame load delegate belongs to AppKit, set m_deferMainResourceDataLoad to false.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e8946322

Reviewed by Mark Rowe. · b98e6d25

andrew authored Jun 20, 2007

        
        Support applications with spaces or special characters in their names

        * Scripts/run-webkit-app:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b98e6d25

Add support to Windows for Backspace back/forward navigation and for... · aed3b497

hyatt authored Jun 19, 2007

Add support to Windows for Backspace back/forward navigation and for Ctrl+arrow key back/forward navigation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

aed3b497

Reviewed by Sam Weinig. · e2bddfbc

ggaren authored Jun 19, 2007

        
        Fixed up these tests because they broke the bot.
        
        - Removed reliance on suppressConsoleMessages because I never checked
        that in and I decided it would just be a headache on other platforms.
        - Removed call to frames[0].stop() because it was nonsense.
        - Added console messages to results.

        * http/tests/security/cross-frame-access-expected.txt:
        * http/tests/security/cross-frame-access-first-time-expected.txt:
        * http/tests/security/cross-frame-access-first-time.html:
        * http/tests/security/cross-frame-access.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e2bddfbc

<rdar://problem/5237325 > Incorrect... · 3e0081a1

pyeh authored Jun 19, 2007

<rdar://problem/5237325> Incorrect AXLeftLineTextMarkerRangeForTextMarker/AXPreviousLineStartTextMarkerForTextMarker for non-editable text
        
        * editing/visible_units.cpp:
        (WebCore::startPositionForLine):
        (WebCore::startOfLine):
        (WebCore::endPositionForLine):
        (WebCore::endOfLine):
        Break down the line routines to allow another try to ask for start/end of line if the returned position is not valid.
        An example would be when lineStart/lineEnd at different line than the input position.
        This can happen if the input position is before the space character at the end of a soft-wrapped non-editable line, 
        specifically a line without webkit-line-break:after-white-space style.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3e0081a1

<rdar://problem/3992645 > VO view bounds misplaced when reading text after a line wrap · a9cb8ab1

pyeh authored Jun 19, 2007

        
        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
        Improve the accuracy of the bounds for a given range


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a9cb8ab1

Reviewed by Darin. · 6659d85e

andersca authored Jun 19, 2007

        <rdar://problem/5130630>
        XPath fails LayoutTests on Windows
        
        * xml/XPathPredicate.cpp:
        Include MathExtras.h here so we get a version of fmod that works around a bug in the Microsoft CRT.
        
        * xml/XPathValue.cpp:
        (WebCore::XPath::Value::toNumber):
        Instead of using NAN, which isn't really the NaN value on Windows, use numeric_limits.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6659d85e

LayoutTests: · 05b5224d

ggaren authored Jun 19, 2007

        Reviewed by Darin Adler.

        Tests for cross-frame access. <rdar://problem/5251309>.

        * http/tests/security/cross-frame-access-expected.txt: Added.
        * http/tests/security/cross-frame-access-first-time-expected.txt: Added.
        * http/tests/security/cross-frame-access-first-time.html: Added.
        * http/tests/security/cross-frame-access.html: Added.
        * http/tests/security/resources/cross-frame-iframe.html: Added.

WebCore:

        Reviewed by Darin Adler.

        Fixed cross-frame access. <rdar://problem/5251309>. 

        * bindings/js/kjs_window.cpp:
        (KJS::Window::getValueProperty):
        * bindings/scripts/CodeGeneratorJS.pm:
        * page/DOMWindow.idl:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

05b5224d

Build fix. · b426b227

andersca authored Jun 19, 2007

        
        * platform/win/PopupMenuWin.cpp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b426b227

Add https support · 62156c69

staikos authored Jun 19, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

62156c69

Reviewed by Tim Hatcher · c7e588b1

sullivan authored Jun 19, 2007

        - fixed <rdar://problem/5272011> Hole for find-on-page match in subframe isn't clipped by frame bounds

        * WebView/WebView.mm:
        (-[WebView rectsForTextMatches]):
        intersect the HTMLView's computed rect with the visible rect for that view



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c7e588b1

Implement these methods correctly. · 2f296352

lars authored Jun 19, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2f296352