1. 27 Mar, 2013 2 commits
    • rakuco@webkit.org's avatar
      [jhbuild] Correctly specify an alternate number of make jobs. · 71459c91
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113396
      
      Reviewed by Philippe Normand.
      
      So far, we were using the `MAKEFLAGS' environment variable to pass the
      number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
      other hand, prefers to use the `jobs' variable from jhbuildrc for that.
      
      We now behave more closely to the rest of the WebKit tools by first
      checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
      not set, just letting jhbuild itself figure out how many jobs to use.
      
      * efl/jhbuildrc:
      * gtk/jhbuildrc:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71459c91
    • zeno.albisser@digia.com's avatar
      [Qt] Remove Qt specific WorkQueueItem definitions. · a5f4a612
      zeno.albisser@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112891
      
      This patch is preparation work for removing
      WorkQueue related code from TestRunnerQt and
      replacing it with generic TestRunner code.
      
      Reviewed by Benjamin Poulain.
      
      Source/JavaScriptCore:
      
      * API/JSStringRefQt.cpp:
      (JSStringCreateWithQString):
          Adding a convenience function to create a
          JSStringRef from a QString.
      * API/JSStringRefQt.h:
      
      Tools:
      
      * DumpRenderTree/qt/TestRunnerQt.cpp:
      (TestRunnerQt::queueBackNavigation):
      (TestRunnerQt::queueForwardNavigation):
      (TestRunnerQt::queueLoadHTMLString):
      (TestRunnerQt::queueReload):
      (TestRunnerQt::queueLoadingScript):
      (TestRunnerQt::queueNonLoadingScript):
      (TestRunner::queueLoad):
      * DumpRenderTree/qt/TestRunnerQt.h:
      (TestRunnerQt):
      * DumpRenderTree/qt/WorkQueueItemQt.cpp:
      (LoadItem::invoke):
      (LoadHTMLStringItem::invoke):
      (LoadAlternateHTMLStringItem::invoke):
      (ReloadItem::invoke):
      (ScriptItem::invoke):
      (BackForwardItem::invoke):
      * DumpRenderTree/qt/WorkQueueItemQt.h:
      (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
      (LoadAlternateHTMLStringItem):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5f4a612
  2. 26 Mar, 2013 8 commits
  3. 25 Mar, 2013 8 commits
    • tkent@chromium.org's avatar
      Rename ENABLE_INPUT_TYPE_DATETIME · 866ba1bd
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113254
      
      Reviewed by Kentaro Hara.
      
      Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
      Actually I'd like to remove the code, but we shouldn't remove it yet
      because we shipped products with it on some platforms.
      
      .:
      
      * Source/autotools/SetupWebKitFeatures.m4:
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore:
      
      * Configurations/FeatureDefines.xcconfig:
      * bindings/generic/RuntimeEnabledFeatures.cpp:
      (WebCore):
      * bindings/generic/RuntimeEnabledFeatures.h:
      (RuntimeEnabledFeatures):
      * css/html.css:
      * html/DateTimeInputType.cpp:
      * html/DateTimeInputType.h:
      * html/InputType.cpp:
      (WebCore::createInputTypeFactoryMap):
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/AboutDataEnableFeatures.in:
      
      Source/WebKit/chromium:
      
      * src/WebRuntimeFeatures.cpp:
      (WebKit::WebRuntimeFeatures::enableInputTypeDateTime):
      (WebKit::WebRuntimeFeatures::isInputTypeDateTimeEnabled):
      * tests/WebViewTest.cpp:
      
      Source/WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WTF:
      
      * wtf/FeatureDefines.h:
      
      Tools:
      
      * Scripts/webkitperl/FeatureList.pm:
      * qmake/mkspecs/features/features.pri:
      
      WebKitLibraries:
      
      * win/tools/vsprops/FeatureDefines.props:
      * win/tools/vsprops/FeatureDefines.vsprops:
      * win/tools/vsprops/FeatureDefinesCairo.props:
      * win/tools/vsprops/FeatureDefinesCairo.vsprops:
      
      LayoutTests:
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      866ba1bd
    • rniwa@webkit.org's avatar
      Remove one more line that was intended to be removed in r146657. · 1a699a70
      rniwa@webkit.org authored
      * Scripts/webkitpy/layout_tests/models/test_run_results.py:
      (summarize_results):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a699a70
    • roger_fong@apple.com's avatar
      No longer run bindings tests on WinEWS bots which are causing hangs on the bots. · 7e767f42
      roger_fong@apple.com authored
      Re-enable WinEWS tests.
      
      * Scripts/webkitpy/common/config/ports.py:
      (WinPort.run_bindings_tests_command):
      * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
      (WinEWS):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e767f42
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r146793. · 6460b29e
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/146793
      https://bugs.webkit.org/show_bug.cgi?id=113248
      
      Fix did not work (Requested by rfong on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-25
      
      Source/WebCore:
      
      * bindings/scripts/preprocessor.pm:
      (applyPreprocessor):
      
      Tools:
      
      * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
      (WinEWS):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6460b29e
    • rniwa@webkit.org's avatar
      REGRESSION(r146657): Test failures reported incorrectly · 5cfb3d21
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113223
      
      Reviewed by Dirk Pranke.
      
      The bug was caused by BuildBotPrinter not taking the new behavior into account.
      
      Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
      treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
      
      * Scripts/webkitpy/layout_tests/controllers/manager.py:
      (Manager.run):
      
      * Scripts/webkitpy/layout_tests/models/test_run_results.py:
      (RunDetails.__init__):
      (summarize_results): Remove the line I intended to remove in r146657.
      
      * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
      (logging_run): Return details instead of the exit code.
      (run_and_capture): Ditto.
      
      (RunTest.test_full_results_html):
      (RunTest.test_hung_thread):
      (RunTest.test_no_tests_found):
      (RunTest.test_no_tests_found_2):
      (RunTest.test_repeat_each_iterations_num_tests):
      (RunTest.test_run_singly_actually_runs_tests):
      (RunTest.test_test_list):
      (RunTest.test_missing_and_unexpected_results):
      (RunTest.test_pixel_test_directories):
      (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
      (RunTest.test_crash_with_stderr):
      (RunTest.test_no_image_failure_with_image_diff):
      (RunTest.test_crash_log):
      (RunTest.test_exit_after_n_failures_upload):
      (RunTest.test_results_directory_absolute):
      (RunTest.test_results_directory_relative):
      (RunTest.test_retrying_and_flaky_tests):
      (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
      (RunTest.test_retrying_uses_retries_directory):
      (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
      (RunTest.test_output_diffs):
      (EndToEndTest.test_reftest_with_two_notrefs):
      (RebaselineTest.test_reset_results):
      (RebaselineTest.test_missing_results):
      (RebaselineTest.test_new_baseline):
      
      * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
      (BuildBotPrinter.print_results):
      (BuildBotPrinter.print_unexpected_results):
      (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
      when we forced pixel tests in retry (i.e. pixel test was initially disabled).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cfb3d21
    • jparent@chromium.org's avatar
      Dashboard refactor: Move cross dashboard history related code into history.js. · d7e6518c
      jparent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113104
      
      Reviewed by Ojan Vafai.
      
      All functions relating to cross dashboard behavior move from being
      globals to methods on the history.History object. Names stay the same,
      except many are made private, ones that should have been constants now
      are, and the long standing TODO to change "currentState" to
      dashboardSpecificState is done.
      
      We now create a global history object in dashboard_base, as an
      intermediate measure.  Once the dashboard specific code is
      added to history, each DB will need to create its own, and this
      global will be eliminated.
      
      * TestResultServer/static-dashboards/aggregate_results.js:
      (handleValidHashParameter):
      (htmlForBuilder):
      (rawValuesHTML):
      * TestResultServer/static-dashboards/dashboard_base.js:
      (parseDashboardSpecificParameters):
      (defaultValue):
      (currentBuilderGroupCategory):
      (currentBuilderGroupName):
      (handleLocationChange):
      (expectationsMap):
      * TestResultServer/static-dashboards/flakiness_dashboard.js:
      (generatePage):
      (.switch.return):
      (platformAndBuildType):
      (individualTests):
      (substringList):
      (processMissingAndExtraExpectations):
      (pathToFailureLog):
      (showPopupForBuild):
      (htmlForTestsWithExpectationsButNoFailures):
      (shouldHideTest):
      (isCrossBuilderView):
      (tableHeaders):
      (htmlForSingleTestRow):
      (htmlForTableColumnHeader):
      (generatePageForExpectationsUpdate):
      (handleUpdate):
      (nextUpdate):
      (setUpdateIndex):
      (htmlForIndividualTestOnAllBuildersWithResultsLinks):
      (.appendExpectationsItem):
      (loadExpectations):
      (.dummyNode.onload):
      (loadExpectationsLayoutTests):
      (appendExpectations):
      (htmlForNavBar):
      (checkBoxToToggleState):
      (linkHTMLToToggleState):
      (generatePageForBuilder):
      (isInvalidKeyForCrossBuilderView):
      (handleQueryParameterChange):
      (showLegend):
      * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
      (resetGlobals):
      (test):
      * TestResultServer/static-dashboards/history.js:
      (.):
      * TestResultServer/static-dashboards/history_unittests.js:
      * TestResultServer/static-dashboards/loader.js:
      (.):
      * TestResultServer/static-dashboards/loader_unittests.js:
      * TestResultServer/static-dashboards/timeline_explorer.js:
      (generatePage):
      (initCurrentBuilderTestResults):
      (selectBuild):
      (showResultsDelta):
      * TestResultServer/static-dashboards/treemap.js:
      (generatePage):
      (.switch.return):
      (handleFocus):
      * TestResultServer/static-dashboards/ui.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7e6518c
    • roger_fong@apple.com's avatar
      Unreviewed. Remove some suspicious looking code in an attempt to fix EWS bots. · c12d7fc4
      roger_fong@apple.com authored
      Enable WinEWS test again.
      
      * bindings/scripts/preprocessor.pm:
      (applyPreprocessor):
      * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
      (WinEWS):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c12d7fc4
    • dominik.rottsches@intel.com's avatar
      [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround · b08fb0c6
      dominik.rottsches@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112166
      
      HarfBuzz 0.9.14 merged my patch for icu detection without
      pkg-config files, as needed by for example Ubuntu 12.04.
      This obsoletes our local workaround. Removed it for GTK and EFL.
      
      Reviewed by Martin Robinson.
      
      * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
      * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
      * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
      * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b08fb0c6
  4. 22 Mar, 2013 8 commits
    • cmuppala@apple.com's avatar
      Unreviewed. Move self from contributor to committer list. · 1962e61d
      cmuppala@apple.com authored
      * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1962e61d
    • rniwa@webkit.org's avatar
      EWS should use a human readable port name when uploading layout test archives · add4ad5b
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113099
      
      Reviewed by Dirk Pranke.
      
      Use new port's object's name() method to report human readable port names.
      This will also help us resolving the bug to apply layout test results posted by EWS.
      
      * Scripts/webkitpy/tool/bot/botinfo.py:
      (BotInfo.__init__): Take port's name.
      (BotInfo.summary_text):
      
      * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
      (BotInfoTest.test_summary_text):
      
      * Scripts/webkitpy/tool/bot/flakytestreporter.py:
      (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
      
      * Scripts/webkitpy/tool/commands/queues.py:
      (PatchProcessingQueue.__init__): Initialize self._port.
      (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
      and use that for the attachment filename and the comment posted.
      
      * Scripts/webkitpy/tool/commands/queues_unittest.py:
      (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
      "mac-snowleopard" as expected for TestPort.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      add4ad5b
    • roger_fong@apple.com's avatar
      Unreviewed. Fix AppleWin port following https://bugs.webkit.org/show_bug.cgi?id=113100. · f2461ee1
      roger_fong@apple.com authored
      Patch by Alexey Proskuryakov.
      
      * platform/network/cf/ResourceHandleCFNet.cpp:
      (WebCore::ResourceHandle::platformLoadResourceSynchronously):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2461ee1
    • rniwa@webkit.org's avatar
      NRWT: Enable pixel tests when retrying tests · 429520cf
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112898
      
      Reviewed by Dirk Pranke.
      
      Tools: 
      
      * Scripts/webkitpy/layout_tests/controllers/manager.py:
      (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
      if we've forced pixel tests in the retry.
      (Manager._run_tests):
      (Manager._clean_up_run): Fixed the capitalizations.
      (Manager._force_pixel_tests_if_needed): Added.
      
      * Scripts/webkitpy/layout_tests/models/test_run_results.py:
      (_interpret_test_failures): Now that this function maybe called multiple times, only set
      'image_diff_percent' if it doesn't already exist.
      
      (summarize_results): When the first attempt resulted in a text failure and the second attempt
      resulted in image and text failures and we've forced to run pixel tests in the retry run,
      treat this as a regular regression instead of a flakiness.
      
      Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
      run had image diffs.
      
      * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
      (summarized_results):
      
      * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
      (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
      Also removed some dead code.
      
      (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
      pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
      is set and pixel_tests_enabled is set to false.
      (EndToEndTest.test_reftest_with_two_notrefs):
      
      LayoutTests: 
      
      Link to images and image diff in retries when they're only available in retries.
      
      * fast/harness/resources/results-test.js: Added a test case.
      * fast/harness/results-expected.txt:
      * fast/harness/results.html:
      (imageResultsCell): Extracted from tableRow.
      (tableRow): Split the actual result into two tokens (first attempt and retry),
      and then check if the image failure was detected in the first attempt. If not,
      add hyperlinks to the actual results in the retry run.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      429520cf
    • timothy_horton@apple.com's avatar
      Make it possible to run layout tests on Retina MBP · 084f0f24
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=93673
      
      Reviewed by Ryosuke Niwa.
      
      Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
      windows on 2x machines still run at 1x.
      
      * DumpRenderTree/mac/DumpRenderTree.mm:
      (createWebViewAndOffscreenWindow):
      Reset the window resolution to 1x on creation.
      * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
      * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
      (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
      * WebKitTestRunner/mac/PlatformWebViewMac.mm:
      (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
      (WTR::PlatformWebView::PlatformWebView):
      Add NSWindow details, reset the window resolution to 1x on creation.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      084f0f24
    • rniwa@webkit.org's avatar
      Leak bots shouldn't build · 98d43559
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112774
      
      Reviewed by Simon Fraser.
      
      Since leak bots use regular debug builds, there is no need to build on these bots.
      Simply downloading builds will dramatically improve the cycle time of these bots.
      
      * BuildSlaveSupport/build.webkit.org-config/config.json:
      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
      TestFactory instead of BuildAndTestFactory.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98d43559
    • jocelyn.turcotte@digia.com's avatar
      [Qt] Fix the TestWebKitAPI build · 19a878ca
      jocelyn.turcotte@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113044
      
      Reviewed by Tor Arne Vestbø.
      
      The generate-forwarding-headers script would only be run
      after the targets in InjectedBundle.pri since the second
      addStrictSubdirOrderBetween call in
      Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
      the derived_sources -> injected_bundle order in SUBDIRS.
      
      Fix it by only moving the dependent target at the end of
      SUBDIRS, don't touch its dependency.
      
      * qmake/mkspecs/features/functions.prf:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19a878ca
    • commit-queue@webkit.org's avatar
      [EFL][WK2] View is not focused when fullscreen mode toggled · 9e479af5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113009
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-22
      Reviewed by Laszlo Gombos.
      
      Set focus on view when fullscreen mode enabled/disabled
      by FullScreen API.
      
      * MiniBrowser/efl/main.c:
      (on_fullscreen_accept):
      (on_fullscreen_deny):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e479af5
  5. 21 Mar, 2013 14 commits