- 20 Sep, 2005 12 commits
-
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
when name and type change (make them pick up the correct new group). Also fix a bug in the tokenizer where trailing spaces/newlines at the end of a document were getting lost. Messed up .innerHTML on DHTML sites. Reviewed by darin * khtml/css/html4.css: * khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::radioButtonChecked): (DOM::HTMLGenericFormElementImpl::name): (DOM::HTMLInputElementImpl::name): (DOM::HTMLInputElementImpl::setInputType): (DOM::HTMLInputElementImpl::parseMappedAttribute): (DOM::HTMLInputElementImpl::attach): (DOM::HTMLInputElementImpl::preDispatchEventHandler): (DOM::HTMLInputElementImpl::postDispatchEventHandler): (DOM::HTMLIsIndexElementImpl::HTMLIsIndexElementImpl): * khtml/html/html_formimpl.h: * khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::finish): * khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchGenericEvent): * khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::preDispatchEventHandler): (DOM::NodeImpl::postDispatchEventHandler): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10579 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sullivan authored
- fixed <rdar://problem/3228554> We should enforce one selection per WebView instead of per window Note that this checkin does not mean that we will always maintain a selection in a WebView when the focus is elsewhere. Instead it means that there should never be more than one frame containing a selection in a WebView, and that it's possible to maintain a selection in a WebView when the focus is elsewhere. * WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): removed unnecessary and somewhat confusing comment (-[WebView selectedFrame]): now calls the extracted method -_focusedFrame (-[WebView _focusedFrame]): new method, extracted from -selectedFrame; returns frame containing first responder, if any (-[WebView _findSelectedFrameStartingFromFrame:skippingFrame:]): added skippingFrame parameter, which is never returned (-[WebView _findSelectedFrameSkippingFrame:]): new method, starts from main frame and passes a frame to skip (-[WebView _findSelectedFrame]): now calls _findSelectedFrameSkippingFrame:nil (-[WebView _selectedFrameDidChange]): new method, called by WebDocumentText protocol implementors; calls -deselectAll on frame that formerly displayed a selection, if any * WebView.subproj/WebViewInternal.h: added category WebDocumentSelectionExtras, with the one method _selectedFrameDidChange * WebView.subproj/WebHTMLView.m: (-[WebHTMLView becomeFirstResponder]): call -[WebView _selectedFrameDidChange] * WebView.subproj/WebPDFView.m: (-[WebPDFView becomeFirstResponder]): call -[WebView _selectedFrameDidChange] (-[WebPDFView resignFirstResponder]): deselect all unless webview says not to; note that this doesn't work in all cases due to: <rdar://problem/4265966> PDFs continue to show a (secondary) selection when the focus moves elsewhere * WebView.subproj/WebTextView.m: (-[WebTextView becomeFirstResponder]): call -[WebView _selectedFrameDidChange] (-[WebTextView resignFirstResponder]): deselect all unless webview says not to git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10578 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eseidel authored
Submitted by: eseidel Reviewed by: mjs Pickup latest Ecma changes from KDE, including adding in the SVG ecma bindings and DOM 3 LS bindings. http://bugzilla.opendarwin.org/show_bug.cgi?id=4946 * WebCore.xcodeproj/project.pbxproj: * kdom/bindings/IDLCodeGenerator.pm: * kdom/bindings/IDLCodeGeneratorCpp.pm: * kdom/bindings/IDLCodeGeneratorEcmaInterface.pm: Added. * kdom/bindings/IDLCodeGeneratorJs.pm: * kdom/bindings/idl/core/Attr.idl: * kdom/bindings/idl/core/CharacterData.idl: * kdom/bindings/idl/core/DOMConfiguration.idl: * kdom/bindings/idl/core/DOMException.idl: * kdom/bindings/idl/core/DOMImplementation.idl: * kdom/bindings/idl/core/DOMImplementationList.idl: Removed. * kdom/bindings/idl/core/DOMImplementationSource.idl: Removed. * kdom/bindings/idl/core/DOMString.idl: Removed. * kdom/bindings/idl/core/Document.idl: * kdom/bindings/idl/core/Element.idl: * kdom/bindings/idl/core/NameList.idl: Removed. * kdom/bindings/idl/core/NamedNodeMap.idl: * kdom/bindings/idl/core/Node.idl: * kdom/bindings/idl/core/ProcessingInstruction.idl: * kdom/bindings/idl/core/Text.idl: * kdom/bindings/idl/core/UserDataHandler.idl: Removed. * kdom/bindings/idl/css/CSSCharsetRule.idl: * kdom/bindings/idl/css/CSSMediaRule.idl: * kdom/bindings/idl/css/CSSPageRule.idl: * kdom/bindings/idl/css/CSSPrimitiveValue.idl: * kdom/bindings/idl/css/CSSRule.idl: * kdom/bindings/idl/css/CSSStyleDeclaration.idl: * kdom/bindings/idl/css/CSSStyleRule.idl: * kdom/bindings/idl/css/CSSStyleSheet.idl: * kdom/bindings/idl/css/CSSValue.idl: * kdom/bindings/idl/css/ViewCSS.idl: Removed. * kdom/bindings/idl/events/DocumentEvent.idl: * kdom/bindings/idl/events/EventException.idl: * kdom/bindings/idl/events/EventTarget.idl: * kdom/bindings/idl/ls/DOMImplementationLS.idl: Added. * kdom/bindings/idl/ls/LSException.idl: Added. * kdom/bindings/idl/ls/LSInput.idl: Added. * kdom/bindings/idl/ls/LSOutput.idl: Added. * kdom/bindings/idl/ls/LSParser.idl: Added. * kdom/bindings/idl/ls/LSParserFilter.idl: Added. * kdom/bindings/idl/ls/LSResourceResolver.idl: Added. * kdom/bindings/idl/ls/LSSerializer.idl: Added. * kdom/bindings/idl/ls/LSSerializerFilter.idl: Added. * kdom/bindings/idl/ls/kdomdefs.idl: Added. * kdom/bindings/idl/range/Range.idl: * kdom/bindings/idl/range/RangeException.idl: * kdom/bindings/idl/stylesheets/LinkStyle.idl: * kdom/bindings/idl/stylesheets/MediaList.idl: * kdom/bindings/idl/traversal/DocumentTraversal.idl: * kdom/bindings/idl/traversal/NodeIterator.idl: * kdom/bindings/idl/traversal/TreeWalker.idl: * kdom/bindings/idl/xpath/XPathEvaluator.idl: * kdom/bindings/idl/xpath/XPathException.idl: * kdom/bindings/idl/xpath/XPathExpression.idl: * kdom/bindings/idl/xpath/XPathNSResolver.idl: * kdom/bindings/idl/xpath/XPathNamespace.idl: * kdom/bindings/idl/xpath/XPathResult.idl: * kdom/bindings/idl/xpointer/XPointerException.idl: * kdom/bindings/kdombinder.sh: * kdom/bindings/kdomidl.pl: * kdom/core/CDFInterface.cpp: (CDFInterface::ecmaInterface): * kdom/core/CDFInterface.h: * kdom/ecma/DOMBridge.h: (KDOM::DOMRWBridge::put): * kdom/ecma/DOMLookup.h: * kdom/ecma/Ecma.cpp: (Ecma::Private::Private): (Ecma::setup): (Ecma::setupDocument): (Ecma::interface): (Ecma::createEventListener): (KDOM::getDOMNode): (KDOM::getDOMEvent): * kdom/ecma/Ecma.h: * kdom/ecma/EcmaInterface.h: Removed. * kdom/ecma/GlobalObject.cpp: (GlobalObject::get): (GlobalObjectFunc::callAsFunction): (ScheduledAction::execute): (GlobalQObject::parentDestroyed): (GlobalQObject::clearTimeout): (GlobalQObject::timerEvent): * kdom/ecma/GlobalObject.h: (KDOM::GlobalObject::): * kdom/ecma/ScriptInterpreter.cpp: * khtml/khtml_part.cpp: (KHTMLPart::begin): * khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createKDOMDocument): * khtml/xml/dom_docimpl.h: * ksvg2/bindings/idl/svg/GetSVGDocument.idl: Added. * ksvg2/bindings/idl/svg/SVGAElement.idl: Added. * ksvg2/bindings/idl/svg/SVGAngle.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimateColorElement.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimateElement.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimateTransformElement.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimatedAngle.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimatedBoolean.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimatedEnumeration.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimatedInteger.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimatedLength.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimatedLengthList.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimatedNumberList.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimatedPathData.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimatedPoints.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimatedPreserveAspectRatio.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimatedRect.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimatedString.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimatedTransformList.idl: Added. * ksvg2/bindings/idl/svg/SVGAnimationElement.idl: Added. * ksvg2/bindings/idl/svg/SVGCircleElement.idl: Added. * ksvg2/bindings/idl/svg/SVGClipPathElement.idl: Added. * ksvg2/bindings/idl/svg/SVGColor.idl: Added. * ksvg2/bindings/idl/svg/SVGComponentTransferFunctionElement.idl: Added. * ksvg2/bindings/idl/svg/SVGCursorElement.idl: Added. * ksvg2/bindings/idl/svg/SVGDOMImplementation.idl: Added. * ksvg2/bindings/idl/svg/SVGDefsElement.idl: Added. * ksvg2/bindings/idl/svg/SVGDescElement.idl: Added. * ksvg2/bindings/idl/svg/SVGDocument.idl: Added. * ksvg2/bindings/idl/svg/SVGElement.idl: Added. * ksvg2/bindings/idl/svg/SVGElementInstance.idl: Added. * ksvg2/bindings/idl/svg/SVGElementInstanceList.idl: Added. * ksvg2/bindings/idl/svg/SVGEllipseElement.idl: Added. * ksvg2/bindings/idl/svg/SVGEvent.idl: Added. * ksvg2/bindings/idl/svg/SVGException.idl: Added. * ksvg2/bindings/idl/svg/SVGExternalResourcesRequired.idl: Added. * ksvg2/bindings/idl/svg/SVGFEBlendElement.idl: Added. * ksvg2/bindings/idl/svg/SVGFEColorMatrixElement.idl: Added. * ksvg2/bindings/idl/svg/SVGFEComponentTransferElement.idl: Added. * ksvg2/bindings/idl/svg/SVGFECompositeElement.idl: Added. * ksvg2/bindings/idl/svg/SVGFEFloodElement.idl: Added. * ksvg2/bindings/idl/svg/SVGFEFuncAElement.idl: Added. * ksvg2/bindings/idl/svg/SVGFEFuncBElement.idl: Added. * ksvg2/bindings/idl/svg/SVGFEFuncGElement.idl: Added. * ksvg2/bindings/idl/svg/SVGFEFuncRElement.idl: Added. * ksvg2/bindings/idl/svg/SVGFEGaussianBlurElement.idl: Added. * ksvg2/bindings/idl/svg/SVGFEImageElement.idl: Added. * ksvg2/bindings/idl/svg/SVGFEMergeElement.idl: Added. * ksvg2/bindings/idl/svg/SVGFEMergeNodeElement.idl: Added. * ksvg2/bindings/idl/svg/SVGFEOffsetElement.idl: Added. * ksvg2/bindings/idl/svg/SVGFETileElement.idl: Added. * ksvg2/bindings/idl/svg/SVGFETurbulenceElement.idl: Added. * ksvg2/bindings/idl/svg/SVGFilterElement.idl: Added. * ksvg2/bindings/idl/svg/SVGFilterPrimitiveStandardAttributes.idl: Added. * ksvg2/bindings/idl/svg/SVGFitToViewBox.idl: Added. * ksvg2/bindings/idl/svg/SVGGElement.idl: Added. * ksvg2/bindings/idl/svg/SVGGradientElement.idl: Added. * ksvg2/bindings/idl/svg/SVGICCColor.idl: Added. * ksvg2/bindings/idl/svg/SVGImageElement.idl: Added. * ksvg2/bindings/idl/svg/SVGLangSpace.idl: Added. * ksvg2/bindings/idl/svg/SVGLength.idl: Added. * ksvg2/bindings/idl/svg/SVGLengthList.idl: Added. * ksvg2/bindings/idl/svg/SVGLineElement.idl: Added. * ksvg2/bindings/idl/svg/SVGLinearGradientElement.idl: Added. * ksvg2/bindings/idl/svg/SVGLocatable.idl: Added. * ksvg2/bindings/idl/svg/SVGMarkerElement.idl: Added. * ksvg2/bindings/idl/svg/SVGMatrix.idl: Added. * ksvg2/bindings/idl/svg/SVGNumber.idl: Added. * ksvg2/bindings/idl/svg/SVGNumberList.idl: Added. * ksvg2/bindings/idl/svg/SVGPaint.idl: Added. * ksvg2/bindings/idl/svg/SVGPathElement.idl: Added. * ksvg2/bindings/idl/svg/SVGPathSeg.idl: Added. * ksvg2/bindings/idl/svg/SVGPathSegArc.idl: Added. * ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl: Added. * ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl: Added. * ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl: Added. * ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl: Added. * ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl: Added. * ksvg2/bindings/idl/svg/SVGPathSegLineto.idl: Added. * ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl: Added. * ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl: Added. * ksvg2/bindings/idl/svg/SVGPathSegList.idl: Added. * ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl: Added. * ksvg2/bindings/idl/svg/SVGPatternElement.idl: Added. * ksvg2/bindings/idl/svg/SVGPoint.idl: Added. * ksvg2/bindings/idl/svg/SVGPointList.idl: Added. * ksvg2/bindings/idl/svg/SVGPolygonElement.idl: Added. * ksvg2/bindings/idl/svg/SVGPolylineElement.idl: Added. * ksvg2/bindings/idl/svg/SVGPreserveAspectRatio.idl: Added. * ksvg2/bindings/idl/svg/SVGRadialGradientElement.idl: Added. * ksvg2/bindings/idl/svg/SVGRect.idl: Added. * ksvg2/bindings/idl/svg/SVGRectElement.idl: Added. * ksvg2/bindings/idl/svg/SVGRenderingIntent.idl: Added. * ksvg2/bindings/idl/svg/SVGSVGElement.idl: Added. * ksvg2/bindings/idl/svg/SVGScriptElement.idl: Added. * ksvg2/bindings/idl/svg/SVGSetElement.idl: Added. * ksvg2/bindings/idl/svg/SVGStopElement.idl: Added. * ksvg2/bindings/idl/svg/SVGStringList.idl: Added. * ksvg2/bindings/idl/svg/SVGStylable.idl: Added. * ksvg2/bindings/idl/svg/SVGStyleElement.idl: Added. * ksvg2/bindings/idl/svg/SVGSwitchElement.idl: Added. * ksvg2/bindings/idl/svg/SVGSymbolElement.idl: Added. * ksvg2/bindings/idl/svg/SVGTSpanElement.idl: Added. * ksvg2/bindings/idl/svg/SVGTests.idl: Added. * ksvg2/bindings/idl/svg/SVGTextContentElement.idl: Added. * ksvg2/bindings/idl/svg/SVGTextElement.idl: Added. * ksvg2/bindings/idl/svg/SVGTextPositioningElement.idl: Added. * ksvg2/bindings/idl/svg/SVGTitleElement.idl: Added. * ksvg2/bindings/idl/svg/SVGTransform.idl: Added. * ksvg2/bindings/idl/svg/SVGTransformList.idl: Added. * ksvg2/bindings/idl/svg/SVGTransformable.idl: Added. * ksvg2/bindings/idl/svg/SVGURIReference.idl: Added. * ksvg2/bindings/idl/svg/SVGUnitTypes.idl: Added. * ksvg2/bindings/idl/svg/SVGUseElement.idl: Added. * ksvg2/bindings/idl/svg/SVGViewElement.idl: Added. * ksvg2/bindings/idl/svg/SVGZoomAndPan.idl: Added. * ksvg2/bindings/idl/svg/SVGZoomEvent.idl: Added. * ksvg2/bindings/idl/svg/kdomdefs.idl: Added. * ksvg2/ecma/EcmaInterface.h: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10577 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eseidel authored
Submitted by: Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com> Reviewed by: eseidel * kdom/ecma/Ecma.cpp: ProtectedValue -> ProtectedPtr<ValueImp> build fix after mjs' recent ProtectedValue removal. http://bugzilla.opendarwin.org/show_bug.cgi?id=5058 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10576 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eseidel authored
Submitted by: eseidel Reviewed by: mjs Moved MIME type support from a hard coded list (in two places) to single lists in the corresponding *Representation classes. Also moved the list of types supported by WebCore (WebHTMLRepresentation) into WebCore. http://bugzilla.opendarwin.org/show_bug.cgi?id=5037 * WebView.subproj/WebDataSource.m: (addTypesFromClass): new inline function (+[WebDataSource _repTypesAllowImageTypeOmission:]): * WebView.subproj/WebFrameView.m: (addTypesFromClass): new inline function (+[WebFrameView _viewTypesAllowImageTypeOmission:]): * WebView.subproj/WebHTMLRepresentation.h: * WebView.subproj/WebHTMLRepresentation.m: (+[WebHTMLRepresentation supportedMIMETypes]): * WebView.subproj/WebHTMLView.m: (+[WebHTMLView supportedMIMETypes]): * WebView.subproj/WebHTMLViewPrivate.h: * WebView.subproj/WebImageRepresentation.h: * WebView.subproj/WebImageRepresentation.m: (+[WebImageRepresentation supportedMIMETypes]): * WebView.subproj/WebImageView.h: * WebView.subproj/WebImageView.m: (+[WebImageView supportedMIMETypes]): * WebView.subproj/WebPDFRepresentation.h: * WebView.subproj/WebPDFRepresentation.m: (+[WebPDFRepresentation supportedMIMETypes]): * WebView.subproj/WebPDFView.h: * WebView.subproj/WebPDFView.m: (+[WebPDFView supportedMIMETypes]): * WebView.subproj/WebTextRepresentation.h: * WebView.subproj/WebTextRepresentation.m: (+[WebTextRepresentation supportedMIMETypes]): * WebView.subproj/WebTextView.h: * WebView.subproj/WebTextView.m: (+[WebTextView supportedMIMETypes]): * WebView.subproj/WebView.m: (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): (+[WebView MIMETypesShownAsHTML]): updated to match style (+[WebView setMIMETypesShownAsHTML:]): ditto git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10575 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eseidel authored
Submitted by: eseidel Reviewed by: mjs Moved MIME types list from WebKit into WebCore. http://bugzilla.opendarwin.org/show_bug.cgi?id=5037 * kwq/WebCoreBridge.h: * kwq/WebCoreBridge.mm: (+[WebCoreBridge supportedMIMETypes]): added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10574 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
http://bugzilla.opendarwin.org/show_bug.cgi?id=4892ggaren authored
Date constructor has problems with months larger than 11 Test cases added: * layout-tests/fast/js/date-big-constructor-expected.txt: Added. * layout-tests/fast/js/date-big-constructor.html: Added. Reviewed by darin. * kjs/date_object.cpp: (KJS::fillStructuresUsingDateArgs): (KJS::makeTime): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10573 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
http://bugzilla.opendarwin.org/show_bug.cgi?id=4892ggaren authored
Date constructor has problems with months larger than 11 Test cases added: * layout-tests/fast/js/date-big-constructor-expected.txt: Added. * layout-tests/fast/js/date-big-constructor.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10572 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
http://bugzilla.opendarwin.org/show_bug.cgi?id=5053ggaren authored
Need to restore int/long changes to simple_number.h Test cases added: * layout-tests/fast/js/date-big-constructor-expected.txt: Added. * layout-tests/fast/js/date-big-constructor.html: Added. Reviewed by darin. * kjs/date_object.cpp: (KJS::fillStructuresUsingDateArgs): (KJS::makeTime): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10571 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
http://bugzilla.opendarwin.org/show_bug.cgi?id=4247ggaren authored
addEventListener in Obj-C does not work No layout test because we don't have test machinery for the Obj-C bindings yet. Reviewed by eric. * kwq/DOM.mm: (-[DOMNode addEventListener:::]): (-[DOMNode removeEventListener:::]): (ObjCEventListener::find): (ObjCEventListener::create): (ObjCEventListener::ObjCEventListener): (ObjCEventListener::~ObjCEventListener): (ObjCEventListener::handleEvent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10570 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
http://bugzilla.opendarwin.org/show_bug.cgi?id=4849ggaren authored
htmltokenizer.cpp won't compile with TOKEN_DEBUG defined No test case because this is a build fix. Reviewed by darin. * khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseComment): (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::processToken): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 19 Sep, 2005 6 commits
-
-
eseidel authored
Submitted by: eseidel Reviewed by: darin * Scripts/run-webkit-tests: added --guard-malloc option http://bugzilla.opendarwin.org/show_bug.cgi?id=4613 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10568 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
http://bugzilla.opendarwin.org/show_bug.cgi?id=5028ggaren authored
9 layout tests fail following the change from long to int - Rolled out changes to simple_number.h, and added fits(long long) and SimpleNumber::fits(unsigned long long) to the old system. Reviewed by mjs. * kjs/simple_number.h: (KJS::SimpleNumber::): (KJS::SimpleNumber::value): (KJS::SimpleNumber::fits): (KJS::SimpleNumber::integerFits): (KJS::SimpleNumber::make): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10567 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
bdakin authored
Submitted by: Reviewed by: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
- fixed <rdar://problem/4214783> REGRESSION: kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer) Make sure to lock using the InterpreterLock class in all places that need it (including anything that uses the collector, the parser, the protect count hash table, and anything that allocates via fast_malloc). Added assertions to ensure that main_thread_malloc and friends are only called on the main thread. Also changed main_thread_free to schedule a free on the main thread if called from a background thread. This contingency is rare, but unavoidable in the case that JavaScript runs on background threads, since then objects can be garbage collected on any thread. Test cases added: Node, this is impossible to reproduce in Safari without the use of PAC files. * Makefile.am: * khtml/dom/dom_misc.h: * khtml/ecma/kjs_events.cpp: (JSAbstractEventListener::handleEvent): (JSLazyEventListener::parseCode): (KJS::getDOMEvent): * khtml/ecma/kjs_events.h: * khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::~KJSProxyImpl): (KJSProxyImpl::evaluate): (KJSProxyImpl::clear): (KJSProxyImpl::createHTMLEventHandler): (KJSProxyImpl::initScript): * khtml/ecma/kjs_traversal.cpp: (JSNodeFilterCondition::acceptNode): * khtml/ecma/kjs_traversal.h: * khtml/ecma/kjs_window.cpp: (Window::clear): (ScheduledAction::execute): * khtml/ecma/kjs_window.h: * khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::slotFinished): * khtml/misc/main_thread_malloc.cpp: (khtml::main_thread_malloc): (khtml::main_thread_calloc): (khtml::main_thread_free): (khtml::main_thread_realloc): (khtml::initialize_scheduled_free_list): (khtml::drain_scheduled_free_list): (khtml::schedule_free_on_main_thread): (khtml::public_fREe): * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::bindingRootObject): (KWQKHTMLPart::windowScriptObject): (KWQKHTMLPart::saveLocationProperties): (KWQKHTMLPart::restoreLocationProperties): (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::cleanupPluginRootObjects): * kwq/KWQPageState.mm: (-[KWQPageState clear]): * kwq/KWQTimer.h: * kwq/KWQTimer.mm: (-[KWQMainThreadPerformTarget initWithFunction:]): (-[KWQMainThreadPerformTarget callFunction:]): (QTimer::immediateSingleShotOnMainThread): * kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]): * kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript rootObjectClasses]): (+[WebCoreJavaScript garbageCollect]): * kwq/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
Submitted by: Reviewed by: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10564 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
- fixed <rdar://problem/4214783> REGRESSION: kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer) Make sure to lock using the InterpreterLock class in all places that need it (including anything that uses the collector, the parser, the protect count hash table, and anything that allocates via fast_malloc). Also added assertions to ensure that the locking rules are followed for the relevant resources. * Makefile.am: * bindings/NP_jsobject.cpp: (identifierFromNPIdentifier): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_SetException): * bindings/jni/jni_jsobject.cpp: (JSObject::call): (JSObject::eval): (JSObject::getMember): (JSObject::setMember): (JSObject::removeMember): (JSObject::getSlot): (JSObject::setSlot): (JSObject::toString): (JSObject::convertJObjectToValue): * bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject removeWebScriptKey:]): (-[WebScriptObject stringRepresentation]): (-[WebScriptObject webScriptValueAtIndex:]): (-[WebScriptObject setWebScriptValueAtIndex:value:]): (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]): * bindings/runtime.cpp: (Instance::createRuntimeObject): * bindings/runtime_root.h: * bindings/testbindings.cpp: (main): * bindings/testbindings.mm: (main): * kjs/fast_malloc.cpp: (KJS::kjs_fast_malloc): (KJS::kjs_fast_calloc): (KJS::kjs_fast_free): (KJS::kjs_fast_realloc): * kjs/fast_malloc.h: * kjs/identifier.h: * kjs/internal.cpp: (InterpreterImp::InterpreterImp): (InterpreterImp::clear): (InterpreterImp::mark): (InterpreterImp::checkSyntax): (InterpreterImp::evaluate): * kjs/internal.h: (KJS::InterpreterImp::globalObject): * kjs/interpreter.cpp: (Interpreter::evaluate): * kjs/interpreter.h: (KJS::InterpreterLock::InterpreterLock): (KJS::InterpreterLock::~InterpreterLock): * kjs/nodes.h: * kjs/protect.h: (KJS::ProtectedValue::ProtectedValue): (KJS::ProtectedValue::~ProtectedValue): (KJS::ProtectedValue::operator=): (KJS::ProtectedObject::ProtectedObject): (KJS::ProtectedObject::~ProtectedObject): (KJS::ProtectedObject::operator=): (KJS::ProtectedReference::ProtectedReference): (KJS::ProtectedReference::~ProtectedReference): (KJS::ProtectedReference::operator=): * kjs/protected_object.h: * kjs/protected_values.cpp: (KJS::ProtectedValues::getProtectCount): (KJS::ProtectedValues::increaseProtectCount): (KJS::ProtectedValues::decreaseProtectCount): * kjs/string_object.cpp: (StringObjectImp::StringObjectImp): * kjs/testkjs.cpp: (main): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 18 Sep, 2005 1 commit
-
-
eseidel authored
Submitted by: eseidel Reviewed by: none needed, svg build fix only. * WebCore+SVG/DrawDocument.mm: (-[DrawView primaryView]): cast to DrawView * (newer gcc fix) * kdom/cache/KDOMLoader.cpp: (Loader::slotFinished): toLong -> toInt * ksvg2/svg/SVGAngleImpl.cpp: (SVGAngleImpl::setValueAsString): toFloat -> toDouble * ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp: (SVGComponentTransferFunctionElementImpl::parseAttribute): ditto * ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp: (SVGFEGaussianBlurElementImpl::parseAttribute): ditto * ksvg2/svg/SVGFEOffsetElementImpl.cpp: (SVGFEOffsetElementImpl::parseAttribute): ditto * ksvg2/svg/SVGFETurbulenceElementImpl.cpp: (SVGFETurbulenceElementImpl::parseAttribute): ditto * ksvg2/svg/SVGFitToViewBoxImpl.cpp: (SVGFitToViewBoxImpl::parseViewBox): ditto * ksvg2/svg/SVGNumberListImpl.cpp: (SVGNumberListImpl::parse): ditto * ksvg2/svg/SVGStopElementImpl.cpp: (SVGStopElementImpl::parseAttribute): ditto git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 16 Sep, 2005 8 commits
-
-
sullivan authored
(-[WebImageView copy:]): fixed build-breaking silly error in previous checkin git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10561 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sullivan authored
- fixed <rdar://problem/4256557> CrashTracer: 238 crashes in Safari at com.apple.AppKit: -[NSPasteboard setData:forType:] + 188 * WebView.subproj/WebImageView.m: (-[WebImageView copy:]): declare types to pasteboard before starting to set their data (-[WebImageView writeSelectionToPasteboard:types:]): ditto git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10560 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
justing authored
Removed a script that is only used by apple internal developers * Scripts/update-webkitsysteminterface: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10559 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Rolling out the fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4924 QPainter should use CGContext as much as possible rather than NSGraphicsContext since it caused a performance regression. WebKit: Rolling out the fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4924 QPainter should use CGContext as much as possible rather than NSGraphicsContext since it caused a performance regression. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10558 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
* Scripts/prepare-ChangeLog: Allow semicolons for protocols too. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10557 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Change by Darin, reviewed by me and Maciej. Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=4547 use int instead of long for 32-bit (to prepare for LP64 compiling) * bindings/c/c_class.h: (KJS::Bindings::CClass::constructorAt): (KJS::Bindings::CClass::numConstructors): * bindings/c/c_runtime.h: (KJS::Bindings::CMethod::numParameters): * bindings/jni/jni_class.cpp: (JavaClass::JavaClass): * bindings/jni/jni_class.h: (KJS::Bindings::JavaClass::constructorAt): (KJS::Bindings::JavaClass::numConstructors): * bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod): * bindings/jni/jni_jsobject.cpp: (JSObject::convertJObjectToValue): (JSObject::listFromJArray): * bindings/jni/jni_runtime.cpp: (JavaMethod::JavaMethod): * bindings/jni/jni_runtime.h: (KJS::Bindings::JavaConstructor::_commonCopy): (KJS::Bindings::JavaConstructor::parameterAt): (KJS::Bindings::JavaConstructor::numParameters): (KJS::Bindings::JavaMethod::_commonCopy): (KJS::Bindings::JavaMethod::parameterAt): (KJS::Bindings::JavaMethod::numParameters): * bindings/npapi.h: * bindings/objc/WebScriptObject.mm: (listFromNSArray): * bindings/objc/objc_class.h: (KJS::Bindings::ObjcClass::constructorAt): (KJS::Bindings::ObjcClass::numConstructors): * bindings/objc/objc_instance.h: * bindings/objc/objc_runtime.h: * bindings/objc/objc_runtime.mm: (ObjcMethod::numParameters): * bindings/runtime.h: * kjs/identifier.h: * kjs/internal.h: * kjs/property_slot.h: (KJS::PropertySlot::setCustomIndex): (KJS::PropertySlot::index): (KJS::PropertySlot::): * kjs/regexp_object.cpp: (RegExpObjectImp::backrefGetter): (RegExpObjectImp::getOwnPropertySlot): * kjs/simple_number.h: (KJS::SimpleNumber::): (KJS::SimpleNumber::value): (KJS::SimpleNumber::fits): (KJS::SimpleNumber::integerFits): (KJS::SimpleNumber::make): * kjs/string_object.cpp: (substituteBackreferences): * kjs/ustring.cpp: (KJS::UString::from): (KJS::UString::toUInt32): (KJS::UString::find): (KJS::UString::rfind): * kjs/ustring.h: * kjs/value.cpp: (KJS::jsNumber): * kjs/value.h: WebCore: Change by Darin, reviewed by me and Maciej. Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=4547 use int instead of long for 32-bit (to prepare for LP64 compiling) Changed longs (which IDL files use as 32-bit) to ints * ForwardingHeaders/khtml_pagecache.h: * khtml/css/css_base.h: (DOM::StyleListImpl::length): (DOM::StyleListImpl::item): * khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::length): (DOM::CSSComputedStyleDeclarationImpl::item): * khtml/css/css_computedstyle.h: * khtml/css/css_ruleimpl.cpp: (CSSMediaRuleImpl::append): (CSSMediaRuleImpl::insertRule): (CSSMediaRuleImpl::cssText): (CSSRuleListImpl::CSSRuleListImpl): (CSSRuleListImpl::deleteRule): (CSSRuleListImpl::insertRule): * khtml/css/css_ruleimpl.h: (DOM::CSSRuleListImpl::length): (DOM::CSSRuleListImpl::item): (DOM::CSSMediaRuleImpl::deleteRule): * khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::insertRule): (CSSStyleSheetImpl::addRule): (CSSStyleSheetImpl::deleteRule): (StyleSheetListImpl::length): (StyleSheetListImpl::item): * khtml/css/css_stylesheetimpl.h: (DOM::MediaListImpl::length): (DOM::MediaListImpl::item): * khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::length): (DOM::CSSMutableStyleDeclarationImpl::item): * khtml/css/css_valueimpl.h: (DOM::CSSValueListImpl::length): (DOM::CSSValueListImpl::item): * khtml/dom/css_rule.h: * khtml/dom/css_stylesheet.h: * khtml/dom/css_value.h: * khtml/dom/dom2_events.cpp: (DOM::UIEvent::detail): (DOM::UIEvent::initUIEvent): (DOM::MouseEvent::screenX): (DOM::MouseEvent::screenY): (DOM::MouseEvent::clientX): (DOM::MouseEvent::clientY): (DOM::MouseEvent::initMouseEvent): (DOM::KeyboardEvent::keyLocation): (DOM::KeyboardEvent::initKeyboardEvent): * khtml/dom/dom2_events.h: * khtml/dom/dom2_range.h: * khtml/dom/dom2_traversal.cpp: (DOM::NodeIterator::whatToShow): (DOM::TreeWalker::whatToShow): * khtml/dom/dom2_traversal.h: * khtml/dom/dom_node.h: * khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::getOwnPropertySlot): (KJS::DOMStyleSheetList::getOwnPropertySlot): (KJS::DOMMediaList::getOwnPropertySlot): (KJS::DOMCSSStyleSheetProtoFunc::callAsFunction): (KJS::DOMCSSRuleList::getOwnPropertySlot): (KJS::DOMCSSValueList::getOwnPropertySlot): * khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::getOwnPropertySlot): (KJS::DOMNodeList::callAsFunction): (KJS::DOMNamedNodeMap::getOwnPropertySlot): (KJS::DOMNamedNodesCollection::getOwnPropertySlot): * khtml/ecma/kjs_events.cpp: (KJS::DOMEvent::getValueProperty): * khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getOwnPropertySlot): (KJS::KJS::HTMLElement::put): (KJS::HTMLCollection::getOwnPropertySlot): (KJS::KJS::HTMLCollection::callAsFunction): (KJS::KJS::HTMLSelectCollection::put): * khtml/ecma/kjs_navigator.cpp: (KJS::Plugins::getOwnPropertySlot): (KJS::MimeTypes::getOwnPropertySlot): (KJS::Plugin::getOwnPropertySlot): * khtml/editing/apply_style_command.cpp: (khtml::ApplyStyleCommand::splitTextAtStartIfNeeded): (khtml::ApplyStyleCommand::splitTextElementAtStartIfNeeded): (khtml::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): * khtml/editing/break_blockquote_command.cpp: (khtml::BreakBlockquoteCommand::doApply): * khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::insertNodeAt): (khtml::CompositeEditCommand::splitTextNode): (khtml::CompositeEditCommand::splitTextNodeContainingElement): (khtml::CompositeEditCommand::insertTextIntoNode): (khtml::CompositeEditCommand::deleteTextFromNode): (khtml::CompositeEditCommand::replaceTextInNode): (khtml::CompositeEditCommand::deleteInsignificantText): * khtml/editing/composite_edit_command.h: * khtml/editing/delete_from_text_node_command.cpp: (khtml::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand): * khtml/editing/delete_from_text_node_command.h: (khtml::DeleteFromTextNodeCommand::offset): (khtml::DeleteFromTextNodeCommand::count): * khtml/editing/insert_into_text_node_command.cpp: (khtml::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand): * khtml/editing/insert_into_text_node_command.h: (khtml::InsertIntoTextNodeCommand::offset): * khtml/editing/insert_paragraph_separator_command.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): * khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::input): (khtml::InsertTextCommand::insertSpace): * khtml/editing/insert_text_command.h: (khtml::InsertTextCommand::charactersAdded): * khtml/editing/join_text_nodes_command.h: * khtml/editing/markup.cpp: (khtml::startMarkup): (khtml::completeURLs): * khtml/editing/move_selection_command.cpp: (khtml::MoveSelectionCommand::doApply): * khtml/editing/rebalance_whitespace_command.cpp: (khtml::RebalanceWhitespaceCommand::doApply): * khtml/editing/rebalance_whitespace_command.h: * khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted): * khtml/editing/replace_selection_command.h: * khtml/editing/selection.cpp: (khtml::Selection::debugPosition): * khtml/editing/split_text_node_command.cpp: (khtml::SplitTextNodeCommand::SplitTextNodeCommand): * khtml/editing/split_text_node_command.h: (khtml::SplitTextNodeCommand::offset): * khtml/editing/split_text_node_containing_element.cpp: (khtml::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand): * khtml/editing/split_text_node_containing_element_command.h: * khtml/editing/visible_position.cpp: (khtml::VisiblePosition::VisiblePosition): (khtml::VisiblePosition::deepEquivalent): (khtml::VisiblePosition::rangeCompliantEquivalent): (khtml::VisiblePosition::maxOffset): (khtml::VisiblePosition::character): (khtml::VisiblePosition::debugPosition): * khtml/editing/visible_position.h: * khtml/editing/visible_range.h: * khtml/editing/visible_text.cpp: (khtml::CircularSearchBuffer::length): (khtml::TextIterator::TextIterator): (khtml::TextIterator::handleTextNode): (khtml::TextIterator::handleTextBox): (khtml::TextIterator::emitCharacter): (khtml::TextIterator::range): (khtml::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): (khtml::SimplifiedBackwardsTextIterator::handleReplacedElement): (khtml::SimplifiedBackwardsTextIterator::emitCharacter): (khtml::SimplifiedBackwardsTextIterator::emitNewlineForBROrText): (khtml::CharacterIterator::range): (khtml::CharacterIterator::advance): (khtml::CharacterIterator::string): (khtml::WordAwareIterator::length): (khtml::CircularSearchBuffer::append): (khtml::CircularSearchBuffer::neededCharacters): (khtml::CircularSearchBuffer::isMatch): (khtml::TextIterator::rangeLength): (khtml::TextIterator::rangeFromLocationAndLength): (khtml::plainText): (khtml::findPlainText): * khtml/editing/visible_text.h: (khtml::TextIterator::length): (khtml::SimplifiedBackwardsTextIterator::length): (khtml::CharacterIterator::length): (khtml::CharacterIterator::characterOffset): * khtml/editing/visible_units.cpp: (khtml::startOfLine): (khtml::endOfLine): (khtml::startOfParagraph): (khtml::endOfParagraph): * khtml/html/html_blockimpl.cpp: (HTMLPreElementImpl::width): (HTMLPreElementImpl::setWidth): * khtml/html/html_blockimpl.h: * khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::length): (DOM::HTMLGenericFormElementImpl::tabIndex): (DOM::HTMLGenericFormElementImpl::setTabIndex): (DOM::HTMLInputElementImpl::selectionStart): (DOM::HTMLInputElementImpl::selectionEnd): (DOM::HTMLInputElementImpl::setSelectionStart): (DOM::HTMLInputElementImpl::setSelectionEnd): (DOM::HTMLInputElementImpl::setSelectionRange): (DOM::HTMLInputElementImpl::setMaxLength): (DOM::HTMLInputElementImpl::setSize): (DOM::HTMLSelectElementImpl::selectedIndex): (DOM::HTMLSelectElementImpl::setSelectedIndex): (DOM::HTMLSelectElementImpl::length): (DOM::HTMLSelectElementImpl::remove): (DOM::HTMLSelectElementImpl::setSize): (DOM::HTMLOptionElementImpl::index): (DOM::HTMLOptionElementImpl::setIndex): (DOM::HTMLTextAreaElementImpl::selectionStart): (DOM::HTMLTextAreaElementImpl::selectionEnd): (DOM::HTMLTextAreaElementImpl::setSelectionStart): (DOM::HTMLTextAreaElementImpl::setSelectionEnd): (DOM::HTMLTextAreaElementImpl::setSelectionRange): (DOM::HTMLTextAreaElementImpl::setCols): (DOM::HTMLTextAreaElementImpl::setRows): (DOM::HTMLOptionsCollectionImpl::length): (DOM::HTMLOptionsCollectionImpl::setLength): (DOM::HTMLOptionsCollectionImpl::item): * khtml/html/html_formimpl.h: (DOM::HTMLInputElementImpl::maxLength): (DOM::HTMLInputElementImpl::maxResults): (DOM::HTMLSelectElementImpl::minWidth): (DOM::HTMLSelectElementImpl::size): (DOM::HTMLTextAreaElementImpl::cols): (DOM::HTMLTextAreaElementImpl::rows): * khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::width): (HTMLImageElementImpl::height): (HTMLImageElementImpl::border): (HTMLImageElementImpl::setBorder): (HTMLImageElementImpl::setHeight): (HTMLImageElementImpl::hspace): (HTMLImageElementImpl::setHspace): (HTMLImageElementImpl::vspace): (HTMLImageElementImpl::setVspace): (HTMLImageElementImpl::setWidth): (HTMLImageElementImpl::x): (HTMLImageElementImpl::y): (HTMLAreaElementImpl::tabIndex): (HTMLAreaElementImpl::setTabIndex): * khtml/html/html_imageimpl.h: * khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::tabIndex): (DOM::HTMLAnchorElementImpl::setTabIndex): * khtml/html/html_inlineimpl.h: * khtml/html/html_listimpl.cpp: (DOM::HTMLOListElementImpl::setStart): (DOM::HTMLLIElementImpl::value): (DOM::HTMLLIElementImpl::setValue): * khtml/html/html_listimpl.h: (DOM::HTMLUListElementImpl::start): (DOM::HTMLOListElementImpl::start): * khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::calcLength): (DOM::HTMLCollectionImpl::length): (DOM::HTMLCollectionImpl::item): (DOM::HTMLFormCollectionImpl::calcLength): (DOM::HTMLFormCollectionImpl::item): * khtml/html/html_miscimpl.h: * khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::tabIndex): (DOM::HTMLObjectElementImpl::setTabIndex): * khtml/html/html_objectimpl.h: * khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::insertRow): (DOM::HTMLTableElementImpl::deleteRow): (DOM::HTMLTableSectionElementImpl::insertRow): (DOM::HTMLTableSectionElementImpl::deleteRow): (DOM::HTMLTableRowElementImpl::rowIndex): (DOM::HTMLTableRowElementImpl::sectionRowIndex): (DOM::HTMLTableRowElementImpl::insertCell): (DOM::HTMLTableRowElementImpl::deleteCell): (DOM::HTMLTableCellElementImpl::cellIndex): (DOM::HTMLTableCellElementImpl::setColSpan): (DOM::HTMLTableCellElementImpl::setRowSpan): (DOM::HTMLTableColElementImpl::setSpan): * khtml/html/html_tableimpl.h: (DOM::HTMLTableColElementImpl::span): * khtml/html/htmlparser.cpp: (HTMLParser::handleError): * khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::processToken): * khtml/khtml_events.cpp: (khtml::MouseEvent::offset): * khtml/khtml_events.h: (khtml::MouseReleaseEvent::MouseReleaseEvent): * khtml/khtml_part.cpp: (KHTMLPart::restoreURL): (KHTMLPart::stopLoading): (KHTMLPart::receivedFirstData): (KHTMLPart::slotFinished): (KHTMLPart::begin): (KHTMLPart::slotViewFrameSource): (KHTMLPart::selectFrameElementInParentIfFullySelected): * khtml/khtml_part.h: * khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): * khtml/misc/loader.h: * khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionForRenderer): * khtml/rendering/render_br.cpp: (RenderBR::caretMinOffset): (RenderBR::caretMaxOffset): (RenderBR::caretMaxRenderedOffset): (RenderBR::inlineBox): * khtml/rendering/render_br.h: * khtml/rendering/render_form.cpp: (RenderLineEdit::selectionStart): (RenderLineEdit::selectionEnd): (RenderLineEdit::setSelectionStart): (RenderLineEdit::setSelectionEnd): (RenderLineEdit::setSelectionRange): (RenderTextArea::calcMinMaxWidth): (RenderTextArea::selectionStart): (RenderTextArea::selectionEnd): (RenderTextArea::setSelectionStart): (RenderTextArea::setSelectionEnd): (RenderTextArea::setSelectionRange): * khtml/rendering/render_form.h: * khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): * khtml/rendering/render_line.cpp: (khtml::InlineBox::caretMinOffset): (khtml::InlineBox::caretMaxOffset): (khtml::InlineBox::caretMaxRenderedOffset): * khtml/rendering/render_line.h: * khtml/rendering/render_list.cpp: (RenderListMarker::calcMinMaxWidth): * khtml/rendering/render_list.h: (khtml::RenderListItem::value): (khtml::RenderListItem::setValue): * khtml/rendering/render_object.cpp: (RenderObject::caretMinOffset): (RenderObject::caretMaxOffset): (RenderObject::caretMaxRenderedOffset): (RenderObject::previousOffset): (RenderObject::nextOffset): (RenderObject::inlineBox): * khtml/rendering/render_object.h: * khtml/rendering/render_replaced.cpp: (RenderReplaced::caretMinOffset): (RenderReplaced::caretMaxOffset): (RenderReplaced::caretMaxRenderedOffset): * khtml/rendering/render_replaced.h: * khtml/rendering/render_table.h: (khtml::RenderTableCell::cellIndex): (khtml::RenderTableCell::setCellIndex): * khtml/rendering/render_text.cpp: (InlineTextBox::paintMarker): (InlineTextBox::paintMarkedTextUnderline): (InlineTextBox::caretMinOffset): (InlineTextBox::caretMaxOffset): (InlineTextBox::caretMaxRenderedOffset): (RenderText::previousOffset): (RenderText::nextOffset): (InlineTextBox::positionForOffset): (RenderText::caretMinOffset): (RenderText::caretMaxOffset): (RenderText::caretMaxRenderedOffset): (RenderText::inlineBox): * khtml/rendering/render_text.h: * khtml/xml/dom2_eventsimpl.cpp: (DOM::EventImpl::timeStamp): (DOM::UIEventImpl::UIEventImpl): (DOM::UIEventImpl::initUIEvent): (DOM::UIEventImpl::layerX): (DOM::UIEventImpl::layerY): (DOM::UIEventImpl::pageX): (DOM::UIEventImpl::pageY): (DOM::UIEventImpl::which): (DOM::MouseRelatedEventImpl::MouseRelatedEventImpl): (DOM::MouseRelatedEventImpl::pageX): (DOM::MouseRelatedEventImpl::pageY): (DOM::MouseEventImpl::MouseEventImpl): (DOM::MouseEventImpl::initMouseEvent): (DOM::MouseEventImpl::which): (DOM::KeyboardEventImpl::KeyboardEventImpl): (DOM::KeyboardEventImpl::initKeyboardEvent): (DOM::KeyboardEventImpl::which): (DOM::WheelEventImpl::WheelEventImpl): * khtml/xml/dom2_eventsimpl.h: (DOM::UIEventImpl::detail): (DOM::UIEventWithKeyStateImpl::UIEventWithKeyStateImpl): (DOM::MouseRelatedEventImpl::screenX): (DOM::MouseRelatedEventImpl::screenY): (DOM::MouseRelatedEventImpl::clientX): (DOM::MouseRelatedEventImpl::clientY): (DOM::MouseRelatedEventImpl::layerX): (DOM::MouseRelatedEventImpl::layerY): (DOM::KeyboardEventImpl::keyLocation): (DOM::WheelEventImpl::wheelDelta): * khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::RangeImpl): (DOM::RangeImpl::startOffset): (DOM::RangeImpl::endOffset): (DOM::RangeImpl::setStart): (DOM::RangeImpl::setEnd): (DOM::RangeImpl::compareBoundaryPoints): (DOM::RangeImpl::processContents): (DOM::RangeImpl::checkNodeWOffset): * khtml/xml/dom2_rangeimpl.h: * khtml/xml/dom2_traversalimpl.cpp: (DOM::TraversalImpl::TraversalImpl): (DOM::TreeWalkerImpl::TreeWalkerImpl): * khtml/xml/dom2_traversalimpl.h: (DOM::TraversalImpl::whatToShow): * khtml/xml/dom_docimpl.cpp: (DocumentImpl::createNodeIterator): (DocumentImpl::createTreeWalker): (DocumentImpl::processHttpEquiv): (DocumentImpl::removeMarkers): (DocumentImpl::copyMarkers): (DocumentImpl::markersForNode): (DocumentImpl::shiftMarkers): * khtml/xml/dom_docimpl.h: * khtml/xml/dom_elementimpl.cpp: (ElementImpl::openTagStartToString): (NamedAttrMapImpl::item): (NamedAttrMapImpl::getAttributeItem): (NamedAttrMapImpl::removeAttribute): * khtml/xml/dom_elementimpl.h: (DOM::NamedAttrMapImpl::length): (DOM::NamedAttrMapImpl::attributeItem): (DOM::NamedMappedAttrMapImpl::attributeItem): * khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::normalize): (DOM::NodeImpl::nodeIndex): (DOM::NodeImpl::childNodeCount): (DOM::NodeImpl::childNode): (DOM::NodeImpl::maxOffset): (DOM::NodeImpl::maxDeepOffset): (DOM::NodeImpl::caretMinOffset): (DOM::NodeImpl::caretMaxOffset): (DOM::NodeImpl::caretMaxRenderedOffset): (DOM::NodeImpl::previousOffset): (DOM::NodeImpl::nextOffset): (DOM::ContainerNodeImpl::childNodeCount): (DOM::ContainerNodeImpl::childNode): (DOM::NodeListImpl::recursiveLength): (DOM::NodeListImpl::recursiveItem): (DOM::NodeListImpl::itemById): (DOM::ChildNodeListImpl::length): (DOM::ChildNodeListImpl::item): (DOM::TagNodeListImpl::length): (DOM::TagNodeListImpl::item): (DOM::NameNodeListImpl::length): (DOM::NameNodeListImpl::item): * khtml/xml/dom_nodeimpl.h: * khtml/xml/dom_position.cpp: (DOM::Position::Position): (DOM::Position::previous): (DOM::Position::next): (DOM::Position::renderedOffset): (DOM::Position::equivalentRangeCompliantPosition): (DOM::Position::rendersInDifferentPosition): (DOM::Position::trailingWhitespacePosition): (DOM::Position::debugPosition): * khtml/xml/dom_position.h: (DOM::Position::offset): * khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::length): (CharacterDataImpl::substringData): (CharacterDataImpl::insertData): (CharacterDataImpl::deleteData): (CharacterDataImpl::replaceData): (CharacterDataImpl::checkCharDataOperation): (CharacterDataImpl::maxOffset): (CharacterDataImpl::caretMinOffset): (CharacterDataImpl::caretMaxOffset): (CharacterDataImpl::caretMaxRenderedOffset): (TextImpl::splitText): * khtml/xml/dom_textimpl.h: * kwq/DOM-CSS.mm: (-[DOMStyleSheetList length]): (-[DOMStyleSheetList item:]): (-[DOMCSSStyleSheet insertRule::]): (-[DOMCSSStyleSheet deleteRule:]): (-[DOMMediaList length]): (-[DOMMediaList item:]): (-[DOMCSSRuleList length]): (-[DOMCSSRuleList item:]): (-[DOMCSSMediaRule insertRule::]): (-[DOMCSSMediaRule deleteRule:]): (-[DOMCSSStyleDeclaration length]): (-[DOMCSSStyleDeclaration item:]): (-[DOMCSSValueList length]): (-[DOMCSSValueList item:]): * kwq/DOM.mm: (-[DOMNamedNodeMap item:]): (-[DOMNamedNodeMap length]): (-[DOMNodeList item:]): (-[DOMNodeList length]): (-[DOMCharacterData length]): (-[DOMCharacterData substringData::]): (-[DOMCharacterData insertData::]): (-[DOMCharacterData deleteData::]): (-[DOMCharacterData replaceData:::]): (-[DOMText splitText:]): (-[DOMRange description]): (-[DOMRange startOffset]): (-[DOMRange endOffset]): (-[DOMRange setStart::]): (-[DOMRange setEnd::]): (-[DOMNodeIterator whatToShow]): (-[DOMTreeWalker whatToShow]): (-[DOMDocument createNodeIterator::::]): (-[DOMDocument createTreeWalker::::]): * kwq/DOMCSS.h: * kwq/DOMCore.h: * kwq/DOMEvents.h: (-[DOMMouseEvent initMouseEvent:::::::::::::::]): * kwq/DOMEvents.mm: (-[DOMMouseEvent screenX]): (-[DOMMouseEvent screenY]): (-[DOMMouseEvent clientX]): (-[DOMMouseEvent clientY]): (-[DOMMouseEvent initMouseEvent:::::::::::::::]): (-[DOMUIEvent detail]): (-[DOMUIEvent initUIEvent:::::]): * kwq/DOMExtensions.h: * kwq/DOMHTML.h: * kwq/DOMHTML.mm: (-[DOMHTMLCollection length]): (-[DOMHTMLCollection item:]): (-[DOMHTMLOptionsCollection length]): (-[DOMHTMLOptionsCollection setLength:]): (-[DOMHTMLOptionsCollection item:]): (-[DOMHTMLFormElement length]): (-[DOMHTMLSelectElement selectedIndex]): (-[DOMHTMLSelectElement setSelectedIndex:]): (-[DOMHTMLSelectElement length]): (-[DOMHTMLSelectElement setLength:]): (-[DOMHTMLSelectElement size]): (-[DOMHTMLSelectElement setSize:]): (-[DOMHTMLSelectElement tabIndex]): (-[DOMHTMLSelectElement setTabIndex:]): (-[DOMHTMLSelectElement remove:]): (-[DOMHTMLOptionElement index]): (-[DOMHTMLInputElement maxLength]): (-[DOMHTMLInputElement setMaxLength:]): (-[DOMHTMLInputElement size]): (-[DOMHTMLInputElement setSize:]): (-[DOMHTMLInputElement tabIndex]): (-[DOMHTMLInputElement setTabIndex:]): (-[DOMHTMLTextAreaElement cols]): (-[DOMHTMLTextAreaElement setCols:]): (-[DOMHTMLTextAreaElement rows]): (-[DOMHTMLTextAreaElement setRows:]): (-[DOMHTMLTextAreaElement tabIndex]): (-[DOMHTMLTextAreaElement setTabIndex:]): (-[DOMHTMLButtonElement tabIndex]): (-[DOMHTMLButtonElement setTabIndex:]): (-[DOMHTMLOListElement start]): (-[DOMHTMLOListElement setStart:]): (-[DOMHTMLLIElement value]): (-[DOMHTMLLIElement setValue:]): (-[DOMHTMLPreElement width]): (-[DOMHTMLPreElement setWidth:]): (-[DOMHTMLAnchorElement tabIndex]): (-[DOMHTMLAnchorElement setTabIndex:]): (-[DOMHTMLImageElement height]): (-[DOMHTMLImageElement setHeight:]): (-[DOMHTMLImageElement hspace]): (-[DOMHTMLImageElement setHspace:]): (-[DOMHTMLImageElement vspace]): (-[DOMHTMLImageElement setVspace:]): (-[DOMHTMLImageElement width]): (-[DOMHTMLImageElement setWidth:]): (-[DOMHTMLObjectElement hspace]): (-[DOMHTMLObjectElement setHspace:]): (-[DOMHTMLObjectElement tabIndex]): (-[DOMHTMLObjectElement setTabIndex:]): (-[DOMHTMLObjectElement vspace]): (-[DOMHTMLObjectElement setVspace:]): (-[DOMHTMLAppletElement hspace]): (-[DOMHTMLAppletElement setHspace:]): (-[DOMHTMLAppletElement vspace]): (-[DOMHTMLAppletElement setVspace:]): (-[DOMHTMLAreaElement tabIndex]): (-[DOMHTMLAreaElement setTabIndex:]): (-[DOMHTMLTableSectionElement insertRow:]): (-[DOMHTMLTableSectionElement deleteRow:]): (-[DOMHTMLTableElement insertRow:]): (-[DOMHTMLTableElement deleteRow:]): (-[DOMHTMLTableColElement span]): (-[DOMHTMLTableColElement setSpan:]): (-[DOMHTMLTableRowElement rowIndex]): (-[DOMHTMLTableRowElement sectionRowIndex]): (-[DOMHTMLTableRowElement insertCell:]): (-[DOMHTMLTableRowElement deleteCell:]): (-[DOMHTMLTableCellElement cellIndex]): (-[DOMHTMLTableCellElement colSpan]): (-[DOMHTMLTableCellElement setColSpan:]): (-[DOMHTMLTableCellElement rowSpan]): (-[DOMHTMLTableCellElement setRowSpan:]): (-[DOMHTMLEmbedElement height]): (-[DOMHTMLEmbedElement setHeight:]): (-[DOMHTMLEmbedElement width]): (-[DOMHTMLEmbedElement setWidth:]): * kwq/DOMRange.h: * kwq/DOMStylesheets.h: * kwq/DOMTraversal.h: * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::markMisspellings): * kwq/KWQString.h: * kwq/KWQString.mm: (QString::toShort): (QString::toUShort): (QString::toInt): (QString::toUInt): * kwq/KWQTextEdit.h: * kwq/KWQTextEdit.mm: (QTextEdit::selectionStart): (QTextEdit::selectionEnd): (QTextEdit::setSelectionStart): (QTextEdit::setSelectionEnd): (QTextEdit::setSelectionRange): * kwq/WebCoreBridge.mm: (-[WebCoreBridge convertToNSRange:DOM::]): WebKit: Change by Darin, reviewed by me and Maciej. Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=4547 use int instead of long for 32-bit (to prepare for LP64 compiling) * Plugins.subproj/npapi.m: changed types to match those defined in npapi.h (NPN_MemAlloc): (NPN_MemFlush): (NPN_PostURLNotify): (NPN_PostURL): (NPN_Write): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10556 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
tomernic authored
<rdar://problem/3572507> Flash in div with display:none style will not redraw when style changed to display:block (3479) Test cases added: * manual-tests/show-hide-object.html: Added. * manual-tests/resources/spinbox.swf: Added. * khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::detach): Set needWidgetUpdate to true so that the widget is updated on the next attach(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eseidel authored
Submitted by: eseidel Reviewed by: mjs * khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded): One line change to prevent adding text objects as direct children to FrameSet objects in the render tree. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 15 Sep, 2005 1 commit
-
-
harrison authored
<rdar://problem/4244976> reproducible hang at ocharleys.com in VisiblePosition::initDownstream Problem is that RenderText::nextOffset() passes an empty string the UBreakIterator, which returns UBRK_DONE (-1) from ubrk_following, and that -1 is used without question as return result of nextOffset(). Fixed by checking for UBRK_DONE and returning offset+1 in that case. Similar change in RenderText::previousOffset(). Test cases added: * layout-tests/editing/selection/extend-by-word-002-expected.checksum: Added. * layout-tests/editing/selection/extend-by-word-002-expected.png: Added. * layout-tests/editing/selection/extend-by-word-002-expected.txt: Added. * layout-tests/editing/selection/extend-by-word-002.html: Added. * khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter): Added comments. Slight format adjustments. * khtml/rendering/render_text.cpp: (getCharacterBreakIterator): Slight format adjustment. (RenderText::previousOffset): (RenderText::nextOffset): Check for UBRK_DONE. (RenderTextFragment::RenderTextFragment) (RenderTextFragment::RenderTextFragment) Fixed parameter names. (m_generatedContentStr): * khtml/rendering/render_text.h: Fixed parameter names in the two RenderTextFragment constructors. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 14 Sep, 2005 10 commits
-
-
darin authored
- fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3809 Should default to UTF-8 or UTF-16 for application/xml documents with omitted charset and encoding declaration Test cases added: * layout-tests/fast/encoding/xml-utf-8-default.xml: Added. * layout-tests/fast/encoding/xml-utf-8-default-expected.txt: Added. * khtml/misc/decoder.cpp: (Decoder::decode): Always set encoding when we see an XML header. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10540 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
* layout-tests/fast/dom/set-innerHTML-expected.txt: Updated test result now that DumpRenderTree handles this case properly. The old expected result just had the word "error"! git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10539 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
http://bugzilla.opendarwin.org/show_bug.cgi?id=4291darin authored
dumpAsText doesn't work with XHTML documents * DumpRenderTree/DumpRenderTree.m: (dump): Dump the innerText of the document element rather than of the body element. This works with typical XHTML documents. We can probably do something even better in the long run, but this fixes the immediate issue. - separate tweak * Scripts/run-webkit-tests: Show the results in the current built Safari by using run-safari instead of just using "open", which often runs another copy of Safari instead. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10538 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
justing authored
Fixes <rdar://problem/4237479> REGRESSION (Cambridge-Denver): old QuickTime movie continues to play sound after reload We were adding the movie to the document twice after the changes were added to handle fallback content. There are some errors for which we should not render fall back content * Misc.subproj/WebKitErrorsPrivate.h: Introduced WebKitErrorPlugInWillHandleLoad to represent the cancel we do to prevent loading plugin content twice * Plugins.subproj/WebPluginDocumentView.m: (-[WebPluginDocumentView dataSourceUpdated:]): Ditto * WebView.subproj/WebDataSource.m: (-[WebDataSource _receivedMainResourceError:complete:]): Don't handleFallbackContent on WebKitErrorPlugInWillHandleLoad or on a user cancel git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10537 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
justing authored
Test cases added: none, method rename Part of fix for <rdar://problem/4237479> REGRESSION (Cambridge-Denver): old QuickTime movie continues to play sound after reload * kwq/WebCoreBridge.h: * kwq/WebCoreBridge.mm: (-[WebCoreBridge handleFallbackContent]): Renamed bridge method mainResourceError to handleFallbackContent, since there are some main resource errors for which we should not render fallback content. E.G user cancels and the cancel we do to prevent loading plugin content twice (see <rdar://problem/4258008>) git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10536 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
harrison authored
<rdar://problem/4057623> AX: Dictionary Panel crash in AXAttributeStringSetStyle in Safari (Dictionary has workaround) Test cases added: None. Manual testing is way to awkward, and automated testing is not possible. Filed following bug to get automation. <rdar://problem/4256882> Need automated testing support for accessibility APIs * kwq/KWQAccObject.mm: (AXAttributedStringAppendText): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10535 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
vicki authored
- fixed <rdar://problem/4255274> REGRESSION: in some cases, link jumping to images is broken (4964) * khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getUpperLeftCorner): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
thatcher authored
* WebKit.xcodeproj/project.pbxproj: made WebDashboardRegion.h a private header git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10533 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
No easy way to test this in layout tests, so no test added. - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4984 REGRESSION placeholder border left behind after image finishes loading - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4985 REGRESSION assertion failure in KWQPainter.mm:841 * kwq/KWQPainter.mm: (QPainter::save): Do nothing if painting is disabled. (QPainter::restore): Ditto. (QPainter::drawRect): Inset so that we "frame" the rectangle rather than "stroking" the rectangle. The former draws inside the rectangle but the latter draws centered on the edge of the rectangle. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10532 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
Reviewed by Maciej. - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4924 QPainter should use CGContext as much as possible rather than NSGraphicsContext * kwq/KWQPainter.h: Made no-op xForm be an inline. Reformatted to remove extraneous spaces. Removed clearFocusRing. Changed the name of various private functions to remove underscore prefix, and reorganize them. * kwq/KWQPainter.mm: (QPainterPrivate::QPainterPrivate): Remove the NSBezierPath for focus. (QPainterPrivate::~QPainterPrivate): Ditto. (QPainter::save): Use CGContext instead of NSGraphicsContext. (QPainter::restore): Ditto. (QPainter::drawRect): Use CGContextFillRect instead of _fillRectXX, and CGContextStrokeRect instead of NSFrameRect. (QPainter::setFillColor): Added. Sets CGContext fill color based on brush. (QPainter::setFillColorFromCurrentBrush): Added. Sets CGContext fill color based on QPainter's current brush. (QPainter::setFillColorFromCurrentPen): Added. Sets CGContext fill color based on QPainter's current pen. (QPainter::setStrokeColorAndLineWidthFromCurrentPen): Added. Set CGContext stroke color and line width based on QPainter's current pen. (QPainter::drawLine): Use CGContextStrokeLineSegments instead of NSBezierPath. (QPainter::drawEllipse): Use CGContextFillEllipseInRect instead of CGContextFillPath and CGContextStrokeEllipseInRect instead of CGContextStrokePath. (QPainter::drawArc): Removed some uneeded type casts, changed to call the new private functions, currentContext and setStrokeColorAndLineWidthFromCurrentPen. (QPainter::drawConvexPolygon): Use new private functions, also use CGContextDrawPath in the case where we want to both fill and stroke the polygon. (QPainter::getCompositeOperation): Remove unneeded cast. (QPainter::setCompositeOperation): Map from name to operation here rather than relying on the code on the WebKit side to do it (allows us to remove names entirely from the WebKit side). (QPainter::compositeOperatorFromString): Remove a local variable and some casts. (getBlendedColorComponent): Rewrote to do the same computation without any conversion to float. (QPainter::fillRect): Use CGContextFillRect instead of _fillRectXXX. (QPainter::addClip): Use CGContextClipToRect instead of NSBezierPath. (QPainter::addRoundedRectClip): Add missing call to CGContextBeginPath. (QPainter::beginTransparencyLayer): Use CGContextSaveGState instead of NSGraphicsContext. (QPainter::endTransparencyLayer): Use CGContextRestoreGState instead of NSGraphicsContext. (QPainter::initFocusRing): Use CGContextBeginPath instead of creating an NSBezierPath. (QPainter::addFocusRingRect): Use CGContextAddRect instead of NSBezierPath. (QPainter::drawFocusRing): Use CGContextFillPath instead of NSBezierPath. * khtml/rendering/render_flow.cpp: (RenderFlow::paintFocusRing): Remove call to clearFocusRing. No longer exists. * khtml/rendering/render_object.cpp: (RenderObject::paintOutline): Ditto. * kwq/WebCoreImageRendererFactory.h: Remove setCGCompositeOperationFromString method. WebKit: Reviewed by Maciej. - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4924 QPainter should use CGContext as much as possible rather than NSGraphicsContext * WebCoreSupport.subproj/WebImageRendererFactory.m: Remove setCGCompositeOperationFromString method, no longer needed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 13 Sep, 2005 2 commits
-
-
harrison authored
<rdar://problem/4204892> Correcting incorrect spelling in Mail causes others to lose their red squiggles Fixed by having SplitTextNodeCommand::doApply copy the markers to the new node, and having SplitTextNodeCommand::doUnapply copy the markers from the merged-in node to the combined node. btw - filed <rdar://problem/4256492> "WebCore editing automated layout tests verify spelling markers" so that we can automate tests for this. Test cases added: * manual-tests/keep_spelling_markers.html: Added. * khtml/editing/split_text_node_command.cpp: (khtml::SplitTextNodeCommand::doApply): (khtml::SplitTextNodeCommand::doUnapply): Call new copyMarkers() function. * khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeMarkers): (DocumentImpl::addMarker): (DocumentImpl::copyMarkers): (DocumentImpl::markersForNode): (DocumentImpl::shiftMarkers): * khtml/xml/dom_docimpl.h: (DOM::DocumentMarker::): Added copyMarkers() function. Reorganized code for clarity. * khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::setData): (CharacterDataImpl::deleteData): (CharacterDataImpl::replaceData): * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::respondToChangedSelection): * kwq/WebCoreBridge.mm: (-[WebCoreBridge unmarkAllMisspellings]): Update calls to marker functions. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10530 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
tomernic authored
- <rdar://problem/3163393> Safari does not support Windowless mode in Flash * Plugins.subproj/WebBaseNetscapePluginView.h: Added 'isTransparent' instance variable. * Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): When updating a plugin in "windowless" (transparent) mode, clip drawing to the dirty region of the opaque ancestor. This means that a partially-transparent plugin, which by definition does not clear its port on redraw, will not overdraw the valid parts of its port. (-[WebBaseNetscapePluginView sendEvent:]): Disabled the "green debug background" for transparent plugins -- since they are not expected to cover their entire port every redraw, this debug code makes no sense. (-[WebBaseNetscapePluginView setVariable:value:]): Implemented -setVariable:value:, which is called from NPN_SetValue() (previously unimplemented). Right now we only handle NPPVpluginTransparentBool; if we choose to handle the other plugin variables, then we may do so here. * Plugins.subproj/WebBaseNetscapePluginViewPrivate.h: Added SPI for -[WebBaseNetscapePluginView setVariable:value]. * Plugins.subproj/npapi.m: (NPN_SetValue): Implemented this function so that plugins may set state (such as window mode). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
