1. 30 Jul, 2009 40 commits
    • barraclough@apple.com's avatar
      2009-07-30 Gavin Barraclough <barraclough@apple.com> · 70dfd9a0
      barraclough@apple.com authored
              Reviewed by NOBODY (build fix).
      
              Temporarily revert r46618 since this is b0rking on Linux.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70dfd9a0
    • mrowe@apple.com's avatar
      Teach buildbot to detect test cases that are missing results. · a7ff952f
      mrowe@apple.com authored
      Reviewed by Cameron Zwarich.
      
      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7ff952f
    • barraclough@apple.com's avatar
      2009-07-23 Gavin Barraclough <barraclough@apple.com> · 7c0daf05
      barraclough@apple.com authored
              Reviewed by Oliver Hunt.
      
              Make get_by_id/put_by_id/method_check/call defer optimization using a data flag rather than a code modification.
              ( https://bugs.webkit.org/show_bug.cgi?id=27635 )
      
              This improves performance of ENABLE(ASSEMBLER_WX_EXCLUSIVE) builds by 2-2.5%, reducing the overhead to about 2.5%.
              (No performance impact with ASSEMBLER_WX_EXCLUSIVE disabled).
      
              * bytecode/CodeBlock.cpp:
              (JSC::printStructureStubInfo):
                  - Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
      
              * bytecode/CodeBlock.h:
              (JSC::):
              (JSC::CallLinkInfo::seenOnce):
              (JSC::CallLinkInfo::setSeen):
              (JSC::MethodCallLinkInfo::seenOnce):
              (JSC::MethodCallLinkInfo::setSeen):
                  - Change a pointer in CallLinkInfo/MethodCallLinkInfo to use a PtrAndFlags, use a flag to track when an op has been executed once.
      
              * bytecode/StructureStubInfo.cpp:
              (JSC::StructureStubInfo::deref):
                  - Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
      
              * bytecode/StructureStubInfo.h:
              (JSC::StructureStubInfo::StructureStubInfo):
              (JSC::StructureStubInfo::initGetByIdSelf):
              (JSC::StructureStubInfo::initGetByIdProto):
              (JSC::StructureStubInfo::initGetByIdChain):
              (JSC::StructureStubInfo::initGetByIdSelfList):
              (JSC::StructureStubInfo::initGetByIdProtoList):
              (JSC::StructureStubInfo::initPutByIdTransition):
              (JSC::StructureStubInfo::initPutByIdReplace):
              (JSC::StructureStubInfo::seenOnce):
              (JSC::StructureStubInfo::setSeen):
                  - Make StructureStubInfo store the type as an integer, rather than an OpcodeID, add a flag to track when an op has been executed once.
      
              * bytecompiler/BytecodeGenerator.cpp:
              (JSC::BytecodeGenerator::emitGetById):
              (JSC::BytecodeGenerator::emitPutById):
                  - Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
      
              * jit/JIT.cpp:
              (JSC::JIT::privateCompileCTIMachineTrampolines):
              (JSC::JIT::unlinkCall):
                  - Remove the "don't lazy link" stage of calls.
      
              * jit/JIT.h:
              (JSC::JIT::compileCTIMachineTrampolines):
                  - Remove the "don't lazy link" stage of calls.
      
              * jit/JITCall.cpp:
              (JSC::JIT::compileOpCallSlowCase):
                  - Remove the "don't lazy link" stage of calls.
      
              * jit/JITStubs.cpp:
              (JSC::JITThunks::JITThunks):
              (JSC::JITThunks::tryCachePutByID):
              (JSC::JITThunks::tryCacheGetByID):
              (JSC::JITStubs::DEFINE_STUB_FUNCTION):
              (JSC::JITStubs::getPolymorphicAccessStructureListSlot):
                  - Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
      
              * jit/JITStubs.h:
              (JSC::JITThunks::ctiStringLengthTrampoline):
              (JSC::JITStubs::):
                  - Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
      
              * wtf/PtrAndFlags.h:
              (WTF::PtrAndFlags::PtrAndFlags):
              (WTF::PtrAndFlags::operator!):
              (WTF::PtrAndFlags::operator->):
                  - Add ! and -> operators, add constuctor with pointer argument.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c0daf05
    • mrowe@apple.com's avatar
      Bug 27828: Title attribute is not respected on option elements · 576af270
      mrowe@apple.com authored
      Fix <https://bugs.webkit.org/show_bug.cgi?id=27828> for Mac.
      
      Reviewed by Adele Peterson and Jon Honeycutt.
      
      No tests added as it is not clear how to test a tool tip from DumpRenderTree.
      
      * platform/PopupMenuClient.h: Add a method for retrieving the tool tip of an item.
      * platform/mac/PopupMenuMac.mm:
      (WebCore::PopupMenu::populate): Set the tool tip of the menu item to that of the represented item.
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::itemToolTip): Expose the title attribute of the element as the tool tip.
      * rendering/RenderMenuList.h:
      * rendering/RenderTextControlSingleLine.h:
      (WebCore::RenderTextControlSingleLine::itemToolTip): Return an empty string, indicating no tool tip, for
      the popup menu in RenderTextControlSingleLine.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      576af270
    • mrowe@apple.com's avatar
      Things work better when you create the correct directories. · f9ed178f
      mrowe@apple.com authored
      * Scripts/run-webkit-tests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9ed178f
    • mrowe@apple.com's avatar
      Include some information about the error when we die. · a64dc24a
      mrowe@apple.com authored
      * Scripts/run-webkit-tests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a64dc24a
    • treat@webkit.org's avatar
      2009-07-30 Adam Treat <adam.treat@torchmobile.com> · 4a57f714
      treat@webkit.org authored
              Add expected results file for new test.
      
              * platform/gtk/fast/forms/button-style-color-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a57f714
    • mrowe@apple.com's avatar
      Ensure that the path exists before writing results to it. · e7031049
      mrowe@apple.com authored
      Hopefully this will make the Windows build bot happy.
      
      * Scripts/run-webkit-tests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7031049
    • treat@webkit.org's avatar
      2009-07-30 Adam Treat <adam.treat@torchmobile.com> · 4c080a61
      treat@webkit.org authored
              Add expected results file for new test.
      
              * platform/mac/fast/forms/button-style-color-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c080a61
    • darin@chromium.org's avatar
      2009-07-30 Xiaomei Ji <xji@chromium.org> · 35298c35
      darin@chromium.org authored
              Reviewed by Dan Bernstein.
      
              Remove ChromeClientChromium::setToolTip().
              https://bugs.webkit.org/show_bug.cgi?id=27861
      
              This patch is just to remove a temporarily introduced overloaded empty
              virtual function. No test is needed.
      
              * page/chromium/ChromeClientChromium.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35298c35
    • ggaren@apple.com's avatar
      2009-07-30 Geoffrey Garen <ggaren@apple.com> · b78a01b0
      ggaren@apple.com authored
              Reviewed by Gavin Barraclough.
      
              Fixed failing tests seen on Windows buildbot.
      
              * jit/JITStubs.cpp:
              (JSC::DEFINE_STUB_FUNCTION):
              * jit/JITStubs.h:
              (JSC::): Use "int" instead of "bool" to guarantee a 32-bit result,
              regardless of compiler. gcc on mac uses 32-bit values for bool,
              but gcc on linux and MSVC on Windows use 8-bit values.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b78a01b0
    • darin@chromium.org's avatar
      2009-07-30 Michael Nordman <michaeln@google.com> · 6042aeab
      darin@chromium.org authored
              Reviewed by Darin Fisher.
      
              https://bugs.webkit.org/show_bug.cgi?id=27821
      
              ApplicationCacheHost refactoring.
              
              1) Better encapsulate the interfaces between webcore common code
              and the appcache system within a new class ApplicationCacheHost.
      
              2) Use that interface throughout the loader system, replacing inline appcache logic.
      
              3) Implement the interface in terms of webcore's appcache system.
      
              4) Add the new files to various makefiles.
      
              5) Implement protocolHostAndPortAreEqual() in KURLGoogle.cpp
      
              No new features, no new tests. The existing layout tests all pass.
      
              * GNUmakefile.am:
              * WebCore.base.exp:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * html/HTMLHtmlElement.cpp:
              (WebCore::HTMLHtmlElement::insertedIntoDocument):
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::DocumentLoader):
              (WebCore::DocumentLoader::~DocumentLoader):
              (WebCore::DocumentLoader::mainReceivedError):
              (WebCore::DocumentLoader::detachFromFrame):
              (WebCore::DocumentLoader::setPrimaryLoadComplete):
              * loader/DocumentLoader.h:
              (WebCore::DocumentLoader::applicationCacheHost):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::canCachePageContainingThisFrame):
              (WebCore::FrameLoader::logCanCacheFrameDecision):
              (WebCore::FrameLoader::loadResourceSynchronously):
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::didReceiveResponse):
              (WebCore::MainResourceLoader::didReceiveData):
              (WebCore::MainResourceLoader::didFinishLoading):
              (WebCore::MainResourceLoader::didFail):
              (WebCore::MainResourceLoader::load):
              * loader/MainResourceLoader.h:
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::load):
              (WebCore::ResourceLoader::willSendRequest):
              (WebCore::ResourceLoader::didReceiveResponse):
              (WebCore::ResourceLoader::didFail):
              * loader/ResourceLoader.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::selectCache):
              (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
              (WebCore::ApplicationCacheGroup::finishedLoadingMainResource):
              (WebCore::ApplicationCacheGroup::failedLoadingMainResource):
              (WebCore::ApplicationCacheGroup::disassociateDocumentLoader):
              (WebCore::ApplicationCacheGroup::update):
              (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
              (WebCore::ApplicationCacheGroup::manifestNotFound):
              (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
              (WebCore::ApplicationCacheGroup::startLoadingEntry):
              (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache):
              (WebCore::CallCacheListenerTask::create):
              (WebCore::CallCacheListenerTask::performTask):
              (WebCore::CallCacheListenerTask::CallCacheListenerTask):
              (WebCore::ApplicationCacheGroup::postListenerTask):
              * loader/appcache/ApplicationCacheGroup.h:
              * loader/appcache/ApplicationCacheHost.cpp: Added.
              * loader/appcache/ApplicationCacheHost.h: Added.
              * loader/appcache/ApplicationCacheStorage.cpp:
              (WebCore::ApplicationCacheStorage::transferApplicationCache):
              * loader/appcache/ApplicationCacheStorage.h:
              * loader/appcache/DOMApplicationCache.cpp:
              (WebCore::DOMApplicationCache::DOMApplicationCache):
              (WebCore::DOMApplicationCache::disconnectFrame):
              (WebCore::DOMApplicationCache::applicationCacheHost):
              (WebCore::DOMApplicationCache::status):
              (WebCore::DOMApplicationCache::update):
              (WebCore::DOMApplicationCache::swapCache):
              (WebCore::DOMApplicationCache::addEventListener):
              (WebCore::DOMApplicationCache::removeEventListener):
              (WebCore::DOMApplicationCache::dispatchEvent):
              (WebCore::DOMApplicationCache::callListener):
              (WebCore::DOMApplicationCache::toEventName):
              (WebCore::DOMApplicationCache::toEventType):
              * loader/appcache/DOMApplicationCache.h:
              (WebCore::DOMApplicationCache::):
              (WebCore::DOMApplicationCache::setAttributeEventListener):
              (WebCore::DOMApplicationCache::getAttributeEventListener):
              (WebCore::DOMApplicationCache::clearAttributeEventListener):
              (WebCore::DOMApplicationCache::callEventListener):
              (WebCore::DOMApplicationCache::setOnchecking):
              (WebCore::DOMApplicationCache::onchecking):
              (WebCore::DOMApplicationCache::setOnerror):
              (WebCore::DOMApplicationCache::onerror):
              (WebCore::DOMApplicationCache::setOnnoupdate):
              (WebCore::DOMApplicationCache::onnoupdate):
              (WebCore::DOMApplicationCache::setOndownloading):
              (WebCore::DOMApplicationCache::ondownloading):
              (WebCore::DOMApplicationCache::setOnprogress):
              (WebCore::DOMApplicationCache::onprogress):
              (WebCore::DOMApplicationCache::setOnupdateready):
              (WebCore::DOMApplicationCache::onupdateready):
              (WebCore::DOMApplicationCache::setOncached):
              (WebCore::DOMApplicationCache::oncached):
              (WebCore::DOMApplicationCache::setOnobsolete):
              (WebCore::DOMApplicationCache::onobsolete):
              (WebCore::DOMApplicationCache::~DOMApplicationCache):
              * platform/KURLGoogle.cpp:
              (WebCore::protocolHostAndPortAreEqual):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6042aeab
    • treat@webkit.org's avatar
      2009-07-30 Adam Treat <adam.treat@torchmobile.com> · 8a7ad686
      treat@webkit.org authored
              Reviewed by Mark Rowe.
      
              Revert previous commit to test out new functionality of buildbots and
              run-webkit-tests made possible by r46607.
      
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a7ad686
    • mrowe@apple.com's avatar
      Teach run-webkit-tests to always store the actual results in the results directory for new tests. · 95b313c4
      mrowe@apple.com authored
      Reviewed by Adam Treat and Jon Honeycutt.
      
      This allows us to give a working link to the results from the result summary page, even if we're
      not generating new results in to the tree.
      
      * Scripts/run-webkit-tests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95b313c4
    • simon.fraser@apple.com's avatar
      2009-07-30 Simon Fraser <simon.fraser@apple.com> · 63b2cff9
      simon.fraser@apple.com authored
              Minor change to earlier commit suggested by Darin Adler.
              Use the variable rather than dereferencing 'it' again.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63b2cff9
    • treat@webkit.org's avatar
      2009-07-30 Adam Treat <adam.treat@torchmobile.com> · b8791122
      treat@webkit.org authored
              Reviewed by George Staikos.
      
              Add new test with platform specific results to the Skipped files of ports
              that haven't generated them yet.  This is to make the buildbot green again.
      
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8791122
    • cfleizach@apple.com's avatar
    • simon.fraser@apple.com's avatar
      2009-07-30 Simon Fraser <simon.fraser@apple.com> · ccd21477
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein.
      
              Animation with a timing function property in a keyframe eats CPU
              https://bugs.webkit.org/show_bug.cgi?id=27856
              <rdar://problem/7104476> Animation demo uses lots of CPU
      
              Don't include animation-timing-function in the list of properties to
              animate in a keyframe animation, because this property is not animated;
              instead, it describes the timing function to apply to this keyframe.
      
              This prevents the animation code from thinking that there's a property
              that it has to software-animate, and thus firing the animation timer frequently.
      
              Not testable because there is no visible impact.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::keyframeStylesForAnimation): Don't add
              CSSPropertyWebkitAnimationTimingFunction to the list of properties to animate.
      
              * page/animation/KeyframeAnimation.cpp
              (WebCore::KeyframeAnimation::getKeyframeAnimationInterval): Add a comment
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccd21477
    • mrowe@apple.com's avatar
      Add a Qt Linux build bot. · f735deef
      mrowe@apple.com authored
      * BuildSlaveSupport/build.webkit.org-config/config.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f735deef
    • ggaren@apple.com's avatar
      2009-07-30 Geoffrey Garen <ggaren@apple.com> · 34dd0c0d
      ggaren@apple.com authored
              Windows build fix: added missing symbols on Windows.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34dd0c0d
    • treat@webkit.org's avatar
      WebCore: · 17a01a28
      treat@webkit.org authored
      2009-07-30  Mike Fenton  <mike.fenton@torchmobile.com>
      
               Reviewed by Adam Treat.
      
               Apply colour style to buttons that use Theme settings in Qt.
      
               https://bugs.webkit.org/show_bug.cgi?id=27814
      
               * platform/qt/RenderThemeQt.cpp:
               (WebCore::RenderThemeQt::adjustButtonStyle):
      
      LayoutTests:
      2009-07-30  Mike Fenton  <mike.fenton@torchmobile.com>
      
               Reviewed by Adam Treat.
      
               Add Button Colour style test and results for Qt based upon fix for bug.
               Unskip tables/mozilla/bugs/bug92647-2.html which passes with bug fix.
               Update expected results for qt for test fast/dom/HTMLTableColElement/resize-table-using-col-width-expected
               which also passes with the the bug fix.
      
               https://bugs.webkit.org/show_bug.cgi?id=27814
      
               * fast/forms/button-style-color.html: Added.
               * platform/qt/Skipped:
               * platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
               * platform/qt/fast/forms/button-style-color-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17a01a28
    • ggaren@apple.com's avatar
      2009-07-30 Geoffrey Garen <ggaren@apple.com> · 14fa366c
      ggaren@apple.com authored
              Windows build fix: removed stale symbols on Windows.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14fa366c
    • ggaren@apple.com's avatar
      Merged nitro-extreme branch into trunk. · 540d71a6
      ggaren@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      540d71a6
    • treat@webkit.org's avatar
      2009-07-30 Jakob Petsovits <jakob.petsovits@torchmobile.com> · 0eb529f4
      treat@webkit.org authored
               Reviewed by Adam Roben.
      
               Add --minimal option to webkit-build.
               https://bugs.webkit.org/show_bug.cgi?id=27852
      
               This option disables all optional build features unless
               they are explicitly enabled.
      
               * Scripts/build-webkit:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0eb529f4
    • dglazkov@chromium.org's avatar
      2009-07-30 Dean McNamee <deanm@chromium.org> · 22bf6875
      dglazkov@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Don't try to hash member function pointers, instead use a precomputed value based on the field.
              https://bugs.webkit.org/show_bug.cgi?id=27843
      
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/V8SVGPODTypeWrapper.h:
              (WebCore::PODTypeWrapperCacheInfo::PODTypeWrapperCacheInfo):
              (WebCore::PODTypeWrapperCacheInfo::operator==):
              (WebCore::PODTypeWrapperCacheInfoHash::hash):
              (WebCore::V8SVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22bf6875
    • xan@webkit.org's avatar
      2009-07-30 Xan Lopez <xlopez@igalia.com> · c3eeea51
      xan@webkit.org authored
              Reviewed by Simon Fraser.
      
              Fix compiler warning.
      
              * dom/SelectElement.cpp:
              (WebCore::SelectElement::menuListDefaultEventHandler):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3eeea51
    • mpcomplete@chromium.org's avatar
      2009-07-29 Matt Perry <mpcomplete@chromium.org> · c85f87df
      mpcomplete@chromium.org authored
              Reviewed by Adam Barth.
      
              Add a way to register V8 extensions for Isolated Worlds only.
              https://bugs.webkit.org/show_bug.cgi?id=27785
      
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::evaluateInNewWorld):
              (WebCore::ScriptController::evaluateInNewContext):
              * bindings/v8/ScriptController.h:
              * bindings/v8/V8IsolatedWorld.cpp:
              (WebCore::V8IsolatedWorld::evaluate):
              * bindings/v8/V8IsolatedWorld.h:
              * bindings/v8/V8Proxy.cpp:
              (WebCore::V8Proxy::evaluateInNewWorld):
              (WebCore::V8Proxy::evaluateInNewContext):
              (WebCore::V8Proxy::createNewContext):
              (WebCore::V8Proxy::initContextIfNeeded):
              (WebCore::V8Proxy::registerExtensionWithV8):
              (WebCore::V8Proxy::registerExtension):
              * bindings/v8/V8Proxy.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c85f87df
    • treat@webkit.org's avatar
      2009-07-30 Mike Fenton <mike.fenton@torchmobile.com> · e1a6962a
      treat@webkit.org authored
               Reviewed by Adam Treat.
      
               Add previously defined out support to PopupMenuQt for marking entries as
               disabled and for selecting the desired item.
      
               https://bugs.webkit.org/show_bug.cgi?id=27772
      
               * platform/qt/PopupMenuQt.cpp:
               (WebCore::PopupMenu::populate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1a6962a
    • darin@apple.com's avatar
      2009-07-30 Darin Adler <darin@apple.com> · 9c962752
      darin@apple.com authored
              Reviewed by David Levin.
      
              Use checked casts for render tree
              https://bugs.webkit.org/show_bug.cgi?id=23522
      
              Next step: Add new toRenderWidget cast and use it everywhere.
      
              Use checked casts in all the places that were using static_cast
              but there is a checked cast available.
      
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::stringValue):
              (WebCore::AccessibilityRenderObject::widget):
              (WebCore::AccessibilityRenderObject::widgetForAttachmentView):
              (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (getPangoLayoutForAtk):
              * dom/Document.cpp:
              (WebCore::widgetForNode):
              (WebCore::Document::setFocusedNode):
              * html/HTMLEmbedElement.cpp:
              (WebCore::findWidgetRenderer):
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::defaultEventHandler):
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::renderWidgetForJSBindings):
              * html/HTMLPlugInElement.cpp:
              (WebCore::HTMLPlugInElement::defaultEventHandler):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::loadSubframe):
              * loader/PluginDocument.cpp:
              (WebCore::PluginTokenizer::writeRawData):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::hitTestResultAtPoint):
              (WebCore::subframeForTargetNode):
              (WebCore::EventHandler::handleWheelEvent):
              * page/Frame.cpp:
              (WebCore::isFrameElement):
              * page/PrintContext.cpp:
              (WebCore::PrintContext::computePageRects):
              * page/android/EventHandlerAndroid.cpp:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              * page/chromium/EventHandlerChromium.cpp:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              * page/chromium/FrameChromium.cpp:
              (WebCore::computePageRectsForFrame):
              * page/gtk/EventHandlerGtk.cpp:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              * page/haiku/EventHandlerHaiku.cpp:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              (WebCore::EventHandler::passSubframeEventToSubframe):
              * page/win/FrameWin.cpp:
              (WebCore::computePageRectsForFrame):
              * page/wx/EventHandlerWx.cpp:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              * platform/chromium/ClipboardChromium.cpp:
              (WebCore::getCachedImage):
              * platform/chromium/PasteboardChromium.cpp:
              (WebCore::Pasteboard::writeImage):
              * platform/gtk/PasteboardGtk.cpp:
              (WebCore::Pasteboard::writeImage):
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::writeImage):
              * platform/qt/ClipboardQt.cpp:
              (WebCore::getCachedImage):
              * platform/qt/PasteboardQt.cpp:
              (WebCore::Pasteboard::writeImage):
              * platform/win/ClipboardWin.cpp:
              (WebCore::getCachedImage):
              * platform/win/PasteboardWin.cpp:
              (WebCore::Pasteboard::writeImage):
              * rendering/InlineBox.h:
              (WebCore::InlineBox::boxModelObject):
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::splitInlines):
              (WebCore::RenderInline::addChildToContinuation):
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::updateImageContents):
              * rendering/TextControlInnerElements.cpp:
              (WebCore::RenderTextControlInnerBlock::positionForPoint):
              Use checked cast instead of static_cast.
              
              * rendering/RenderWidget.h: Added toRenderWidget.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c962752
    • staikos@webkit.org's avatar
      2009-07-30 Yong Li <yong.li@torchmobile.com> · d6b8e53a
      staikos@webkit.org authored
              Reviewed by George Staikos.
      
              WINCE PORT: some files modified to build for WINCE
              https://bugs.webkit.org/show_bug.cgi?id=27816
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6b8e53a
    • staikos@webkit.org's avatar
      2009-07-30 Yong Li <yong.li@torchmobile.com> · 12821597
      staikos@webkit.org authored
              Reviewed by George Staikos.
      
              WINCE PORT: modified graphics files
              https://bugs.webkit.org/show_bug.cgi?id=27779
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12821597
    • kenneth@webkit.org's avatar
      2009-07-30 Kenneth Rohde Christiansen <kenneth@webkit.org> · 9be08721
      kenneth@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              Improve efficiency by rewriting code doing three hash table
              lookups, which can be replaced by just one as pointed out
              by Darin Adler.
      
              Though being slightly less clear, this should be considerable
              faster.
      
              * plugins/PluginDatabase.cpp:
              (WebCore::PluginDatabase::remove):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9be08721
    • kov@webkit.org's avatar
      2009-07-30 Antonio Gomes <antonio.gomes@openbossa.org> · b173d663
      kov@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=27651
      
              Removed unneeded includes (gdk.h and gtk.h) and added glib.h and cairo.h instead.
      
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b173d663
    • kov@webkit.org's avatar
      2009-07-30 Antonio Gomes <antonio.gomes@openbossa.org> · 98501fcd
      kov@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h (Part 1)
              https://bugs.webkit.org/show_bug.cgi?id=27651
      
              Fixed many code style issues pointed by WebKitTools/Scripts/modules/cpplint.py
              No functionality change at all.
      
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
              * platform/graphics/gtk/VideoSinkGStreamer.cpp:
              * platform/graphics/gtk/VideoSinkGStreamer.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98501fcd
    • kenneth@webkit.org's avatar
      Allow to explicitly choose a preferred plugin for a mimetype. · b360c5f8
      kenneth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=27651
      
      When the preferred plugin is set for a specific MIME type, it will be
      always picked up, regardless of its version, quirks etc.
      
      Client applications may want to use that API to resolve mimetype
      ambiguity in a custom way, rather than in the default way that is
      currently used in WebKit.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b360c5f8
    • kenneth@webkit.org's avatar
      [Qt] Fix build with GCC 4.4. · c4e8143a
      kenneth@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4e8143a
    • kenneth@webkit.org's avatar
      [Qt] Fix build with Qt 4.4 after r46535. · a5b7b57e
      kenneth@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5b7b57e
    • kenneth@webkit.org's avatar
      2009-07-30 Kenneth Rohde Christiansen <kenneth@webkit.org> · 88a86670
      kenneth@webkit.org authored
              Reviewed by Adam Treat.
      
              Add missing Q_OBJECT to class inheriting from QObject.
      
              * tests/qwebframe/tst_qwebframe.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88a86670
    • kenneth@webkit.org's avatar
      2009-07-30 Kenneth Rohde Christiansen <kenneth@webkit.org> · 9a975856
      kenneth@webkit.org authored
              Reviewed by Adam Treat.
      
              Fix indentation.
      
              * tests/qwebframe/tst_qwebframe.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a975856
    • eric.carlson@apple.com's avatar
      2009-07-30 Eric Carlson <eric.carlson@apple.com> · 4b4c0fcb
      eric.carlson@apple.com authored
              Reviewed by Simon Fraser.
      
              Video elements fires another "load" event when attached to DOM
              https://bugs.webkit.org/show_bug.cgi?id=27623
      
              Test: media/media-load-event.html
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::insertedIntoDocument):
                  Only schedule load when element's network state is NETWORK_EMPTY.
      
      2009-07-30  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Simon Fraser.
      
              Video elements fires another "load" event when attached to DOM
              https://bugs.webkit.org/show_bug.cgi?id=27623
      
              * media/media-load-event-expected.txt: Added.
              * media/media-load-event.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b4c0fcb