1. 02 Dec, 2009 3 commits
    • timothy@apple.com's avatar
      Expose setValueForUser for the COM DOMHTMLInputElement. · 706a8f92
      timothy@apple.com authored
      <rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript
      
      Reviewed by Dan Bernstein.
      
      * DOMHTMLClasses.cpp:
      (DOMHTMLInputElement::setValueForUser):
      * Interfaces/DOMHTML.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      706a8f92
    • timothy@apple.com's avatar
      WebCore: Expose a function to set the value of an input element on behalf of the user. · 7157c6d7
      timothy@apple.com authored
      This function will dispatch the change event so the page is notified when autofill
      happens. Also dispatch a change event when a select element is changed by autofill.
      
      <rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript
      
      Reviewed by Darin Adler.
      
      * WebCore.xcodeproj/project.pbxproj: Added the DOMHTMLInputElementPrivate.h header.
      * bindings/objc/DOMHTML.mm:
      (-[DOMHTMLSelectElement _activateItemAtIndex:]): Call setSelectedIndexByUser instead so
      a change event is fired. This method is called by Safari autofill.
      * dom/Document.cpp:
      (WebCore::Document::setFocusedNode): Use dispatchFormControlChangeEvent instead
      of dispatching the change event directly to be consistent.
      * html/HTMLFormControlElement.cpp:
      (WebCore::HTMLInputElement::setValueForUser): Added. Calls setValue with the sendChangeEvent
      (WebCore::HTMLInputElement::setValue): Added the optional sendChangeEvent argument. Mimics setChecked.
      * html/HTMLInputElement.h:
      * html/HTMLInputElement.idl: Added setValueForUser for non-JS languages.
      * html/InputElement.h: Added setValueForUser.
      
      WebKit/mac: Migrate DOMHTMLInputElementPrivate.h as a private header.
      
      Reviewed by Darin Adler.
      
      * MigrateHeaders.make:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7157c6d7
    • eric@webkit.org's avatar
      2009-12-02 Anton Muhin <antonm@chromium.org> · f822b905
      eric@webkit.org authored
              Reviewed by Adam Barth.:w
      
              Allow to skip thread checks when accessing DOMDataStore for processes
              which run V8 in single thread mode.
              https://bugs.webkit.org/show_bug.cgi?id=31877
      
              Should be covered by buildbots.
      
              * bindings/v8/V8DOMMap.cpp:
              (WebCore::getDOMDataStore):
              (WebCore::enableFasterDOMStoreAccess):
              (WebCore::getDOMNodeMap):
              (WebCore::getDOMObjectMap):
              (WebCore::getActiveDOMObjectMap):
              (WebCore::getDOMSVGElementInstanceMap):
              (WebCore::getDOMSVGObjectWithContextMap):
              * bindings/v8/V8DOMMap.h:
      2009-12-02  Anton Muhin  <antonm@chromium.org>
      
              Reviewed by Adam Barth.
      
              Allow to skip thread checks when accessing DOMDataStore for processes
              which run V8 in single thread mode.
              https://bugs.webkit.org/show_bug.cgi?id=31877
      
              * src/WebScriptController.cpp:
              (WebKit::WebScriptController::enableV8SingleThreadMode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f822b905
  2. 01 Dec, 2009 8 commits
    • bweinstein@apple.com's avatar
      16df50a8
    • bweinstein@apple.com's avatar
      Build fix by using DOMNode::node() to go from a DOMNode to a node, and · 7abd0d56
      bweinstein@apple.com authored
      added svg/animation in the WebCore.vcproj list of headers to be copied 
      over on build.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7abd0d56
    • zimmermann@webkit.org's avatar
      Not reviewed. Try to fix qt/win builds. · 8e195f83
      zimmermann@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e195f83
    • zimmermann@webkit.org's avatar
      2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> · 840d1766
      zimmermann@webkit.org authored
              Reviewed by Simon Fraser.
      
              Add SVG animation test framework with 'snapshot' functionality
              https://bugs.webkit.org/show_bug.cgi?id=31897
      
              Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
              forwarding the call to SVGDocumentExtensions, if SVG is enabled.
      
              Implemented just like the existing pauseAnimation* methods for CSS animations.
      
              * Api/qwebframe.cpp:
              (qt_drt_pauseSVGAnimation):
      2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Simon Fraser.
      
              Add SVG animation test framework with 'snapshot' functionality
              https://bugs.webkit.org/show_bug.cgi?id=31897
      
              Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
              forwarding the call to SVGDocumentExtensions, if SVG is enabled.
      
              Implemented just like the existing pauseAnimation* methods for CSS animations.
      
              * webkit/webkitprivate.h:
              * webkit/webkitwebframe.cpp:
              (webkit_web_frame_pause_svg_animation):
      2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Simon Fraser.
      
              Add SVG animation test framework with 'snapshot' functionality
              https://bugs.webkit.org/show_bug.cgi?id=31897
      
              Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
              forwarding the call to SVGDocumentExtensions, if SVG is enabled.
      
              Implemented just like the existing pauseAnimation* methods for CSS animations.
      
              * Interfaces/IWebFramePrivate.idl:
              * WebFrame.cpp:
              (WebFrame::pauseSVGAnimation):
              * WebFrame.h:
      2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Simon Fraser.
      
              Add SVG animation test framework with 'snapshot' functionality
              https://bugs.webkit.org/show_bug.cgi?id=31897
      
              Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
              forwarding the call to SVGDocumentExtensions, if SVG is enabled.
      
              Implemented just like the existing pauseAnimation* methods for CSS animations.
      
              * WebView/WebFrame.mm:
              (-[WebFrame _pauseSVGAnimation:onSMILNode:atTime:]):
              * WebView/WebFramePrivate.h:
      2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Simon Fraser.
      
              Add SVG animation test framework with 'snapshot' functionality
              https://bugs.webkit.org/show_bug.cgi?id=31897
      
              Add 'sampleSVGAnimationForElementAtTime' method to the LayoutTestController,
              for the use within the new SVG animation test framework (LayoutTests/svg/animations/)
      
              layoutTestController.sampleAnimationAtTime(<svg animation id>, <absolute time>, <svg element id>);
              to sample a svg animateMotion/animateColor/animate/set element at certain times.
      
              After the desired SVG animation starts and calling the method above, it's immediately forwarded to
              the desired sampling time. After JS returns from the 'sampleSVGAnimationForElementAtTime' method
              a callback is fired used to sample the animation value at the target time. It's modelled similar
              to the CSS animation/transition testing framework, inspired by
              LayoutTests/animations/animation-test-helpers.js.
      
              Though it has been extended to integrate within the fast/js/js-test-* framework, that's used for
              the SVG dynamic-updates tests, to simplify test creation, by utilizing script-tests/* only.
      
              Adding a simple testcase testing the DRT methods, it will soon be extended to test animVal/baseVal
              interaction, while animating.
      
              Test: svg/animations/animVal-basics.html
      
              * WebCore.base.exp:
              * WebCore.xcodeproj/project.pbxproj:
              * svg/SVGDocumentExtensions.cpp:
              (WebCore::SVGDocumentExtensions::sampleAnimationAtTime):
              * svg/SVGDocumentExtensions.h:
              * svg/animation/SMILTimeContainer.cpp:
              (WebCore::SMILTimeContainer::SMILTimeContainer):
              (WebCore::SMILTimeContainer::sampleAnimationAtTime):
              (WebCore::SMILTimeContainer::updateAnimations):
              * svg/animation/SMILTimeContainer.h:
      2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Simon Fraser.
      
              Add SVG animation test framework with 'snapshot' functionality
              https://bugs.webkit.org/show_bug.cgi?id=31897
      
              Add LayoutTests/svg/animations directory, containing a new
              framework for SVG animation test with sampling at certain times.
      
              Added one example test, which will be extended soon to cover animVal
              support, once basic support has been implemented.
      
              * svg/animations: Added.
              * svg/animations/animVal-basics-expected.txt: Added.
              * svg/animations/animVal-basics.html: Added.
              * svg/animations/resources: Added.
              * svg/animations/resources/SVGAnimationTestCase.js: Added.
              (isCloseEnough):
              (moveAnimationTimelineAndSample):
              (startTest):
              (sampleAnimation):
              (runAnimationTest):
              * svg/animations/script-tests: Added.
              * svg/animations/script-tests/TEMPLATE.html: Added.
              * svg/animations/script-tests/animVal-basics.js: Added.
              (sample1):
              (sample2):
              (sample3):
              (executeTest):
      2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Simon Fraser.
      
              Add SVG animation test framework with 'snapshot' functionality
              https://bugs.webkit.org/show_bug.cgi?id=31897
      
              Add new 'sampleSVGAnimationForElementAtTime' DRT method,
              used by the new SVG animation testing framework, implemented
              for qt/gtk/win/mac.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (sampleSVGAnimationForElementAtTimeCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::sampleSVGAnimationForElementAtTime):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::sampleSVGAnimationForElementAtTime):
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::sampleSVGAnimationForElementAtTime):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::sampleSVGAnimationForElementAtTime):
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              (LayoutTestController::sampleSVGAnimationForElementAtTime):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      840d1766
    • weinig@apple.com's avatar
      Simplify [WebView userAgentForURL:]. No need to call into helper function. · 02c9476f
      weinig@apple.com authored
      Reviewed by Mark Rowe.
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::userAgent):
      * WebView/WebView.mm:
      (-[WebView userAgentForURL:]):
      * WebView/WebViewInternal.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02c9476f
    • pkasting@chromium.org's avatar
      [Chromium] Simplify zoom-related APIs and add a zoom level getter, · 7fbcd16a
      pkasting@chromium.org authored
      part one: Add new APIs.  (Old APIs will be removed in a second pass.)
      https://bugs.webkit.org/show_bug.cgi?id=31893
      
      Reviewed by Darin Fisher.
      
      * public/WebView.h:
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::zoomLevel):
      (WebKit::WebViewImpl::setZoomLevel):
      * src/WebViewImpl.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fbcd16a
    • eric@webkit.org's avatar
      2009-12-01 Daniel Bates <dbates@webkit.org> · a82ec714
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              https://bugs.webkit.org/show_bug.cgi?id=31898
      
              Makes QtLauncher default to the http scheme for URLs.
      
              * QtLauncher/main.cpp:
              (MainWindow::MainWindow):
              (MainWindow::changeLocation):
              (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a82ec714
    • eric@webkit.org's avatar
      2009-12-01 Xiyuan Xia <xiyuan@chromium.org> · e6dd2557
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Only fire start/stop events when main frame is not loading.
      
              https://bugs.webkit.org/show_bug.cgi?id=31838
      
              * src/FrameLoaderClientImpl.cpp:
              (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6dd2557
  3. 30 Nov, 2009 10 commits
    • eric@webkit.org's avatar
      2009-11-30 Abhinav Mithal <abhinav.mithal@nokia.com> · e1dd094e
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt][Symbian] Report SymbianOS in user agent string for Symbian
              https://bugs.webkit.org/show_bug.cgi?id=31961
      
              * Api/qwebpage.cpp:
              (QWebPage::userAgentForUrl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1dd094e
    • mrowe@apple.com's avatar
      Use the correct path to Info.plist to avoid creating an empty file at the top... · 5a35b872
      mrowe@apple.com authored
      Use the correct path to Info.plist to avoid creating an empty file at the top of the WebKit directory.
      
      * WebKit.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a35b872
    • barraclough@apple.com's avatar
      Bug 31859 - Make world selection for JSC IsolatedWorlds automagical. · 6539bbe2
      barraclough@apple.com authored
      Reviewed by Geoff Garen.
      
      JavaScriptCore: 
      
      WebCore presently has to explicitly specify the world before entering into JSC,
      which is a little fragile (particularly since property access via a
      getter/setter might invoke execution). Instead derive the current world from
      the lexical global object.
              
      Remove the temporary duct tape of willExecute/didExecute virtual hooks on the JSGlobalData::ClientData - these are no longer necessary.
      
      * API/JSBase.cpp:
      (JSEvaluateScript):
      * API/JSObjectRef.cpp:
      (JSObjectCallAsFunction):
      * JavaScriptCore.exp:
      * runtime/JSGlobalData.cpp:
      * runtime/JSGlobalData.h:
      
      WebCore: 
      
      WebCore presently has to explicitly specify the world before entering into JSC,
      which is a little fragile (particularly since property access via a
      getter/setter might invoke execution). Instead derive the current world from
      the lexical global object.
      
      Remove the last uses of mainThreadCurrentWorld(), so the world is always obtained via
      currentWorld().  Switch this to obtain the world from the ExecsState's lexical global
      object instead.  Remove the call/construct/evaluate 'InWorld' methods, since these
      are no longer necessary.
      
      * WebCore.base.exp:
      * bindings/js/JSCallbackData.cpp:
      (WebCore::JSCallbackData::invokeCallback):
      * bindings/js/JSCallbackData.h:
      (WebCore::JSCallbackData::JSCallbackData):
      * bindings/js/JSCustomXPathNSResolver.cpp:
      (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
      * bindings/js/JSDOMBinding.cpp:
      (WebCore::currentWorld):
      (WebCore::mainThreadNormalWorld):
      * bindings/js/JSDOMBinding.h:
      (WebCore::WebCoreJSClientData::WebCoreJSClientData):
      * bindings/js/JSDOMWindowBase.cpp:
      (WebCore::JSDOMWindowBase::updateDocument):
      * bindings/js/JSDOMWindowBase.h:
      * bindings/js/JSEventListener.cpp:
      (WebCore::JSEventListener::handleEvent):
      (WebCore::JSEventListener::reportError):
      * bindings/js/JSHTMLDocumentCustom.cpp:
      (WebCore::JSHTMLDocument::open):
      * bindings/js/JSNodeFilterCondition.cpp:
      (WebCore::JSNodeFilterCondition::acceptNode):
      * bindings/js/JSQuarantinedObjectWrapper.cpp:
      (WebCore::JSQuarantinedObjectWrapper::construct):
      (WebCore::JSQuarantinedObjectWrapper::call):
      * bindings/js/ScheduledAction.cpp:
      (WebCore::ScheduledAction::executeFunctionInContext):
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::evaluateInWorld):
      (WebCore::ScriptController::initScript):
      (WebCore::ScriptController::updateDocument):
      * bindings/js/ScriptFunctionCall.cpp:
      (WebCore::ScriptFunctionCall::call):
      (WebCore::ScriptFunctionCall::construct):
      * bindings/js/ScriptObjectQuarantine.cpp:
      (WebCore::getQuarantinedScriptObject):
      * bindings/js/ScriptState.cpp:
      (WebCore::scriptStateFromNode):
      (WebCore::scriptStateFromPage):
      * bindings/js/ScriptState.h:
      * bindings/js/WorkerScriptController.cpp:
      (WebCore::WorkerScriptController::evaluate):
      * bindings/objc/WebScriptObject.mm:
      (-[WebScriptObject callWebScriptMethod:withArguments:]):
      (-[WebScriptObject evaluateWebScript:]):
      * bridge/NP_jsobject.cpp:
      (_NPN_InvokeDefault):
      (_NPN_Invoke):
      (_NPN_Evaluate):
      (_NPN_Construct):
      * bridge/jni/jni_jsobject.mm:
      (JavaJSObject::call):
      (JavaJSObject::eval):
      * dom/NodeFilter.h:
      (WebCore::NodeFilter::acceptNode):
      * dom/NodeIterator.h:
      (WebCore::NodeIterator::nextNode):
      (WebCore::NodeIterator::previousNode):
      * dom/TreeWalker.h:
      (WebCore::TreeWalker::parentNode):
      (WebCore::TreeWalker::firstChild):
      (WebCore::TreeWalker::lastChild):
      (WebCore::TreeWalker::previousSibling):
      (WebCore::TreeWalker::nextSibling):
      (WebCore::TreeWalker::previousNode):
      (WebCore::TreeWalker::nextNode):
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::windowScriptObjectAvailable):
      (WebCore::InspectorController::didEvaluateForTestInFrontend):
      * inspector/JavaScriptCallFrame.cpp:
      (WebCore::JavaScriptCallFrame::evaluate):
      
      WebKit/mac: 
      
      WebCore presently has to explicitly specify the world before entering into JSC,
      which is a little fragile (particularly since property access via a
      getter/setter might invoke execution). Instead derive the current world from
      the lexical global object.
      
      Since WebCore no longer needs to explicitly specify the world on entry to JSC DebuggerCallFrame::evaluate can be called directly.
      
      * WebView/WebScriptDebugDelegate.mm:
      (-[WebScriptCallFrame evaluateWebScript:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6539bbe2
    • aroben@apple.com's avatar
      Fix double-free of BSTRs passed to WebNavigationData::createInstance · 391d91e9
      aroben@apple.com authored
      WebFrameLoaderClient::updateGlobalHistory was converting
      WebCore::Strings to WebCore::BStrings, then passing them to
      WebNavigationData::createInstance. But the latter function takes BSTR
      parameters and adopts them into WebCore::BStrings. So the end result
      was that two WebCore::BStrings would end up freeing each underlying
      BSTR.
      
      The fix is to only convert to WebCore::BString inside
      WebNavigationData.
      
      Fixes <http://webkit.org/b/31998> <rdar://problem/7383452> REGRESSION
      (r49564): Crash in updateGlobalHistory when running Javascript iBench
      test
      
      I couldn't find a way to reproduce this in DumpRenderTree.
      
      Reviewed by Steve Falkenburg.
      
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::updateGlobalHistory): Pass WebCore::Strings to
      WebNavigationData::createInstance.
      
      * WebNavigationData.cpp:
      (WebNavigationData::WebNavigationData):
      (WebNavigationData::createInstance):
      * WebNavigationData.h:
      Changed to take const WebCore::String&s instead of BSTRs and to
      convert the Strings to BStrings at this level.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      391d91e9
    • joepeck@webkit.org's avatar
      Remove file git invisibly added · 0edf8337
      joepeck@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0edf8337
    • joepeck@webkit.org's avatar
      2009-11-30 Joseph Pecoraro <joepeck@webkit.org> · 723f16eb
      joepeck@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Wrong console output for Regexp escape sequence
              https://bugs.webkit.org/show_bug.cgi?id=31538
      
              Updated inspector/console-format.html
      
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.createDividerElement): style issues.
              (WebInspector.ConsoleView.createFilterElement): style issues.
              (WebInspector.ConsoleView): added _customFormatters table.
              (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): style isses.
              (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): style issues.
              (WebInspector.ConsoleView.prototype._format): simplified delegation to formatter logic.
              (WebInspector.ConsoleView.prototype._formatobject):
              (WebInspector.ConsoleView.prototype._formatnode):
              (WebInspector.ConsoleView.prototype._printArray):
              (WebInspector.ConsoleMessage.prototype._format): commented and broke down the algorithm into parts.
              (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append): handle substitution string formatting.
              (WebInspector.ConsoleMessage.prototype._formatIndividualValue): handling individual value formatting.
              (WebInspector.ConsoleCommandResult):
              * inspector/front-end/InjectedScript.js: simplified regex formatting.
              * inspector/front-end/inspector.js:
              (WebInspector.linkifyStringAsFragment): converted new RegExp to literal for performance benefits.
              * inspector/front-end/utilities.js:
              (Element.prototype.hasStyleClass): update inaccurate comment.
              (String.prototype.trimURL): converted new RegExp to literal for performance benefits.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      723f16eb
    • sfalken@apple.com's avatar
      WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld... · 18e1477d
      sfalken@apple.com authored
      WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should fall back to didClearWindowObject
      https://bugs.webkit.org/show_bug.cgi?id=31986
      
      Reviewed by Adam Roben.
      
      * WebFrame.cpp:
      (WebFrame::dispatchDidClearWindowObjectInWorld): Fall back if E_NOTIMPL returned.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18e1477d
    • eric@webkit.org's avatar
      2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 9e1d35df
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Fix minor waning in QtWebKit
              https://bugs.webkit.org/show_bug.cgi?id=31963
      
              * tests/qwebpage/tst_qwebpage.cpp:
              (ErrorPage::extension): Remove info wariable as it is
              not used.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e1d35df
    • mrowe@apple.com's avatar
      Versioning. · e2f9debf
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2f9debf
    • xan@webkit.org's avatar
      2009-11-30 Xan Lopez <xlopez@igalia.com> · 22674493
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Bump versions for 1.1.17 release.
      
              * configure.ac:
      
      WebCore:
      
      2009-11-30  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha.
      
              Add new headers to sources list.
      
              * GNUmakefile.am:
      
      WebKit/gtk:
      
      2009-11-30  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha.
      
              Prepare for 1.1.17 release.
      
              * NEWS:
              * docs/webkitgtk-docs.sgml:
              * docs/webkitgtk-sections.txt:
              * webkit/webkitwebsettings.cpp:
              (webkit_web_settings_class_init):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22674493
  4. 28 Nov, 2009 2 commits
  5. 27 Nov, 2009 1 commit
    • yurys@chromium.org's avatar
      2009-11-27 Yury Semikhatsky <yurys@chromium.org> · 2c3be838
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              This is a WebCore part of the fix that allows to view plugin
              resources loaded by plugins.
      
              https://bugs.webkit.org/show_bug.cgi?id=31832
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::willSendRequest):
              (WebCore::InspectorController::didReceiveResponse):
              (WebCore::InspectorController::didReceiveContentLength):
              (WebCore::InspectorController::didFinishLoading):
              (WebCore::InspectorController::didFailLoading):
              * inspector/InspectorController.h:
              * inspector/InspectorResource.cpp:
              (WebCore::InspectorResource::addLength):
              * loader/ResourceLoadNotifier.cpp:
              (WebCore::ResourceLoadNotifier::didFailToLoad):
              (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
              (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
              (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
              (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
      2009-11-27  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              WebCore part of the fix that allows to view plugin
              resources loaded by plugins. Methods that for resource
              loading notifications are exposed through WebDevToolsAgent
              interface to the glue code to allow Chromium's plugin
              implementation to notify InspectorController about resource
              loading in plugins.
      
              https://bugs.webkit.org/show_bug.cgi?id=31832
      
              * public/WebDevToolsAgent.h:
              * public/WebView.h:
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::createUniqueIdentifierForRequest):
              * src/WebViewImpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c3be838
  6. 26 Nov, 2009 5 commits
    • laszlo.1.gombos@nokia.com's avatar
      2009-11-26 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 7e391fb3
      laszlo.1.gombos@nokia.com authored
              Reviewed by Oliver Hunt.
      
              Move GOwnPtr* from wtf to wtf/gtk
              https://bugs.webkit.org/show_bug.cgi?id=31793
      
              * GNUmakefile.am: Change the path for GOwnPtr.*.
              * JavaScriptCore.gyp/JavaScriptCore.gyp: Remove
                GOwnPtr.cpp from the exclude list.
              * JavaScriptCore.gypi: Change the path for GOwnPtr.*.
              * wscript: Remove GOwnPtr.cpp from the exclude list.
              * wtf/GOwnPtr.cpp: Removed.
              * wtf/GOwnPtr.h: Removed.
              * wtf/Threading.h: Change the path for GOwnPtr.h.
              * wtf/gtk/GOwnPtr.cpp: Copied from JavaScriptCore/wtf/GOwnPtr.cpp.
              * wtf/gtk/GOwnPtr.h: Copied from JavaScriptCore/wtf/GOwnPtr.h.
              * wtf/unicode/glib/UnicodeGLib.h: Change the path for GOwnPtr.h.
      
      2009-11-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
      
              Reviewed by Oliver Hunt.
      
              Move GOwnPtr* from wtf to wtf/gtk
              https://bugs.webkit.org/show_bug.cgi?id=31793
      
              * webkit/webkitwebview.cpp: Change the path for GOwnPtr.h.
      
      2009-11-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
      
              Reviewed by Oliver Hunt.
      
              Move GOwnPtr* from wtf to wtf/gtk
              https://bugs.webkit.org/show_bug.cgi?id=31793
      
              No new tests as there is no functional change.
      
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Change the
                path for GOwnPtr.h.
              * platform/text/TextEncoding.cpp: Ditto.
              * platform/text/gtk/TextCodecGtk.cpp: Ditto.
      
      2009-11-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
      
              Reviewed by Oliver Hunt.
      
              Move GOwnPtr* from wtf to wtf/gtk
              https://bugs.webkit.org/show_bug.cgi?id=31793
      
              * GNUmakefile.am: Add JavaScriptCore/wtf/gtk to
                the include path.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e391fb3
    • yurys@chromium.org's avatar
      2009-11-26 Yury Semikhatsky <yurys@chromium.org> · edbee9da
      yurys@chromium.org authored
              Not reviewed. Build fix: revert r51421.
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::willSendRequest):
              (WebCore::InspectorController::didReceiveResponse):
              (WebCore::InspectorController::didReceiveContentLength):
              (WebCore::InspectorController::didFinishLoading):
              (WebCore::InspectorController::didFailLoading):
              * inspector/InspectorController.h:
              * inspector/InspectorResource.cpp:
              (WebCore::InspectorResource::addLength):
              * loader/ResourceLoadNotifier.cpp:
              (WebCore::ResourceLoadNotifier::didFailToLoad):
              (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
              (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
              (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
              (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
      
      2009-11-26  Yury Semikhatsky  <yurys@chromium.org>
      
              Not reviewed. Build fix: revert r51421.
      
              * public/WebDevToolsAgent.h:
              * public/WebView.h:
              * src/WebViewImpl.cpp:
              * src/WebViewImpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edbee9da
    • yurys@chromium.org's avatar
      2009-11-26 Yury Semikhatsky <yurys@chromium.org> · 71495490
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              This is a WebCore part of the fix that allows to view plugin
              resources loaded by plugins.
      
              https://bugs.webkit.org/show_bug.cgi?id=31832
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::willSendRequest):
              (WebCore::InspectorController::didReceiveResponse):
              (WebCore::InspectorController::didReceiveContentLength):
              (WebCore::InspectorController::didFinishLoading):
              (WebCore::InspectorController::didFailLoading):
              * inspector/InspectorController.h: Remove unused DocumentLoader parameters from inspector methods.
              * inspector/InspectorResource.cpp:
              (WebCore::InspectorResource::addLength): Update loading end time when new data are received.
              * loader/ResourceLoadNotifier.cpp:
              (WebCore::ResourceLoadNotifier::didFailToLoad): Notify InspectorController about the failure.
              (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
              (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
              (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
              (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
      
      2009-11-26  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              WebCore part of the fix that allows to view plugin
              resources loaded by plugins. Methods that for resource
              loading notifications are exposed through WebDevToolsAgent
              interface to the glue code to allow Chromium's plugin
              implementation to notify InspectorController about resource
              loading in plugins.
      
              https://bugs.webkit.org/show_bug.cgi?id=31832
      
              * public/WebDevToolsAgent.h:
              * public/WebView.h:
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::createUniqueIdentifierForRequest):
              * src/WebViewImpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71495490
    • hausmann@webkit.org's avatar
      Rubber-stamped by Holger Freyther. · abcc2e3d
      hausmann@webkit.org authored
      Removed unused ICO image plugin handler.
      
      * Plugins/ICOHandler.cpp: Removed.
      * Plugins/ICOHandler.h: Removed.
      * Plugins/Plugins.pro: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abcc2e3d
    • zecke@webkit.org's avatar
      [Qt] Call Widget::setSelfVisible from hide/show · ce8bed67
      zecke@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=31203
      
      Call Widget::setSelfVisible from Widget::show and
      Widget::hide and use isParentVisible to decide
      if the widget should be shown. This way client
      code can rely on isVisible.
      
      Change PluginViewQt::show, PluginViewQt::hide to
      call the base class as it is doing the right thing
      now. Add an assert verify that platfomWidget and
      platformPluginWidget are the same.
      
      * manual-tests/qt/qtplugin.html: Modify manual test
      * platform/qt/WidgetQt.cpp:
      (WebCore::Widget::show):
      (WebCore::Widget::hide):
      
      [Qt] Do not show the QWidget when the WebCore::Widget is hidden
      
      https://bugs.webkit.org/show_bug.cgi?id=31203
      
      The clipping code was making a QWidget visible even if the
      WebCore::Widget was hidden. Fix the bug by calling setVisible
      only if the WebCore::Widget Widget::isSelfVisible.
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::QtPluginWidget::show): Override WebCore::Widget::show to call handleVisibility
      (WebCore::QtPluginWidget::handleVisibility): New method to call setVisible when we are visible
      (FrameLoaderClientQt::createPlugin): Hide the QWidget by default
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce8bed67
  7. 25 Nov, 2009 5 commits
  8. 24 Nov, 2009 6 commits