1. 02 Oct, 2009 1 commit
    • abarth@webkit.org's avatar
      2009-10-01 Adam Barth <abarth@webkit.org> · 6ff51a17
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Move RedirectScheduler to its own file
              https://bugs.webkit.org/show_bug.cgi?id=29952
      
              This change is purely code motion.
      
              No behavior change.
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * loader/FrameLoader.cpp:
              * loader/FrameLoader.h:
              * loader/RedirectScheduler.cpp: Added.
              (WebCore::ScheduledRedirection::):
              (WebCore::ScheduledRedirection::ScheduledRedirection):
              (WebCore::RedirectScheduler::RedirectScheduler):
              (WebCore::RedirectScheduler::~RedirectScheduler):
              (WebCore::RedirectScheduler::redirectScheduledDuringLoad):
              (WebCore::RedirectScheduler::clear):
              (WebCore::RedirectScheduler::scheduleRedirect):
              (WebCore::RedirectScheduler::mustLockBackForwardList):
              (WebCore::RedirectScheduler::scheduleLocationChange):
              (WebCore::RedirectScheduler::scheduleFormSubmission):
              (WebCore::RedirectScheduler::scheduleRefresh):
              (WebCore::RedirectScheduler::locationChangePending):
              (WebCore::RedirectScheduler::scheduleHistoryNavigation):
              (WebCore::RedirectScheduler::timerFired):
              (WebCore::RedirectScheduler::schedule):
              (WebCore::RedirectScheduler::startTimer):
              (WebCore::RedirectScheduler::cancel):
              * loader/RedirectScheduler.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ff51a17
  2. 01 Oct, 2009 1 commit
    • abarth@webkit.org's avatar
      2009-10-01 Adam Barth <abarth@webkit.org> · 5d1a968f
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Remove FrameLoader::schedule* APIs
              https://bugs.webkit.org/show_bug.cgi?id=29950
      
              Change clients of FrameLoader::schedule* to call redirectScheduler
              directly.
      
              No behavior change.
      
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setLocation):
              (WebCore::createWindow):
              (WebCore::JSDOMWindow::open):
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::setLocation):
              * bindings/js/JSLocationCustom.cpp:
              (WebCore::navigateIfAllowed):
              (WebCore::JSLocation::reload):
              * bindings/v8/V8Utilities.cpp:
              (WebCore::navigateIfAllowed):
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              (WebCore::createWindow):
              (WebCore::CALLBACK_FUNC_DECL):
              * bindings/v8/custom/V8LocationCustom.cpp:
              (WebCore::CALLBACK_FUNC_DECL):
              * dom/Document.cpp:
              (WebCore::Document::implicitClose):
              (WebCore::Document::processHttpEquiv):
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::write):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::submitForm):
              (WebCore::FrameLoader::receivedFirstData):
              * loader/FrameLoader.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::selectCache):
              * page/History.cpp:
              (WebCore::History::back):
              (WebCore::History::forward):
              (WebCore::History::go):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48994 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d1a968f
  3. 30 Sep, 2009 1 commit
    • abarth@webkit.org's avatar
      2009-09-30 Adam Barth <abarth@webkit.org> · 43d36a30
      abarth@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Factor RedirectScheduler out of FrameLoader
              https://bugs.webkit.org/show_bug.cgi?id=29948
      
              This change introduces a new sub-object of Frame, redirectScheduler.
              The redirectScheduler is responsible for scheduling redirects.
      
              This change leaves the code for the redirectScheduler in
              FrameLoader.cpp.  A future change will move the class into its own
              file.
      
              No behavior change (hopefully!).
      
              * loader/FrameLoader.cpp:
              (WebCore::RedirectScheduler::RedirectScheduler):
              (WebCore::RedirectScheduler::~RedirectScheduler):
              (WebCore::RedirectScheduler::redirectScheduledDuringLoad):
              (WebCore::RedirectScheduler::clear):
              (WebCore::FrameLoader::FrameLoader):
              (WebCore::FrameLoader::setDefersLoading):
              (WebCore::FrameLoader::stopLoading):
              (WebCore::FrameLoader::didOpenURL):
              (WebCore::FrameLoader::didExplicitOpen):
              (WebCore::FrameLoader::cancelAndClear):
              (WebCore::FrameLoader::clear):
              (WebCore::FrameLoader::checkCompleted):
              (WebCore::FrameLoader::isScheduledLocationChangePending):
              (WebCore::FrameLoader::scheduleHTTPRedirection):
              (WebCore::RedirectScheduler::scheduleRedirect):
              (WebCore::RedirectScheduler::mustLockBackForwardList):
              (WebCore::FrameLoader::scheduleLocationChange):
              (WebCore::RedirectScheduler::scheduleLocationChange):
              (WebCore::FrameLoader::scheduleFormSubmission):
              (WebCore::RedirectScheduler::scheduleFormSubmission):
              (WebCore::FrameLoader::scheduleRefresh):
              (WebCore::RedirectScheduler::scheduleRefresh):
              (WebCore::RedirectScheduler::locationChangePending):
              (WebCore::FrameLoader::scheduleHistoryNavigation):
              (WebCore::RedirectScheduler::scheduleHistoryNavigation):
              (WebCore::RedirectScheduler::timerFired):
              (WebCore::FrameLoader::provisionalLoadStarted):
              (WebCore::RedirectScheduler::schedule):
              (WebCore::RedirectScheduler::startTimer):
              (WebCore::RedirectScheduler::cancel):
              (WebCore::FrameLoader::completed):
              (WebCore::FrameLoader::open):
              * loader/FrameLoader.h:
              (WebCore::FrameLoader::committedFirstRealDocumentLoad):
              * page/Frame.cpp:
              (WebCore::Frame::Frame):
              (WebCore::Frame::redirectScheduler):
              * page/Frame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43d36a30
  4. 23 Sep, 2009 1 commit
    • darin@apple.com's avatar
      Crash when website does a history.back() followed by an alert() · f53381bf
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=29686
      rdar://problem/6984996
      
      Patch by Darin Adler <darin@apple.com> on 2009-09-23
      Reviewed by Sam Weinig.
      
      When loading is deferred, we need to defer timer-based loads
      too, not just networking-driven loads. Otherwise we can get
      syncronouse navigation while running a script, which leads to
      crashes and other badness.
      
      This patch includes a manual test; an automated test may be
      possible some time in the future.
      
      * dom/Document.cpp:
      (WebCore::Document::processHttpEquiv): Use scheduleLocationChange
      instead of scheduleHTTPRedirection to implement the navigation
      needed for x-frame-options.
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::FrameLoader): Updated for data members with
      new names and new data members.
      (WebCore::FrameLoader::setDefersLoading): When turning deferral
      off, call startRedirectionTimer and startCheckCompleteTimer, since
      either of them might have been fired and ignored while defersLoading
      was true.
      (WebCore::FrameLoader::clear): Updated for replacement of the
      m_checkCompletedTimer and m_checkLoadCompleteTimer timers.
      (WebCore::FrameLoader::allAncestorsAreComplete): Added.
      (WebCore::FrameLoader::checkCompleted): Added code to set
      m_shouldCallCheckCompleted to false. Changed code that calls
      startRedirectionTimer to call it unconditionally, since that
      function now knows when to do work and doesn't expect callers
      to handle that any more.
      (WebCore::FrameLoader::checkTimerFired): Added. Replaces the old
      timer fired callbacks. Calls checkCompleted and checkLoadComplete
      as appropriate, but not when defersLoading is true.
      (WebCore::FrameLoader::startCheckCompleteTimer): Added. Replaces
      the two different calls to start timers before. Only starts the
      timers if they are needed.
      (WebCore::FrameLoader::scheduleCheckCompleted): Changed to call
      startCheckCompleteTimer after setting boolean.
      (WebCore::FrameLoader::scheduleCheckLoadComplete): Ditto.
      (WebCore::FrameLoader::scheduleHistoryNavigation): Removed
      canGoBackOrForward check. The logic works more naturally when
      we don't do anything until the timer fires.
      (WebCore::FrameLoader::redirectionTimerFired): Do nothing if
      defersLoading is true. Also moved canGoBackOrForward check here.
      (WebCore::FrameLoader::scheduleRedirection): Changed code that
      calls startRedirectionTimer to do so unconditionally. That
      function now handles the rules about when to start the timer
      rather than expecting the caller to do so.
      (WebCore::FrameLoader::startRedirectionTimer): Added code to
      handle the case where there is no redirection scheduled,
      where the timer is already active, or where this is a classic
      redirection and there is an ancestor that has not yet completed
      loading.
      (WebCore::FrameLoader::completed): Call startRedirectionTimer
      here directly instead of calling a cover named parentCompleted.
      Hooray! One less function in the giant FrameLoader class!
      (WebCore::FrameLoader::checkLoadComplete): Added code to set
      m_shouldCallCheckLoadComplete to false.
      
      * loader/FrameLoader.h: Replaced the two functions
      checkCompletedTimerFired and checkLoadCompleteTimerFired with
      one function, checkTimerFired. Removed the parentCompleted
      function. Added the startCheckCompleteTimer and
      allAncestorsAreComplete functions. Replaced the
      m_checkCompletedTimer and m_checkLoadCompleteTimer data
      members with m_checkTimer, m_shouldCallCheckCompleted, and
      m_shouldCallCheckLoadComplete.
      
      * manual-tests/go-back-after-alert.html: Added.
      * manual-tests/resources/alert-and-go-back.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f53381bf
  5. 22 Sep, 2009 1 commit
    • darin@apple.com's avatar
      Tighten up the ScheduledRedirection machinery to prepare for a bug fix · 4d9d718c
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=29663
      
      Patch by Darin Adler <darin@apple.com> on 2009-09-22
      Reviewed by Sam Weinig.
      
      WebCore: 
      
      * loader/FrameLoader.cpp:
      (WebCore::ScheduledRedirection::ScheduledRedirection): Added a boolean,
      initialized to false, to keep track if the redirection has been
      communicated to the client.
      (WebCore::FrameLoader::stopLoading): Tweaked a comment.
      (WebCore::FrameLoader::cancelRedirection): Removed code to clear
      m_scheduledRedirection.clear since stopRedirectionTimer does that now.
      (WebCore::FrameLoader::allChildrenAreComplete): Added.
      (WebCore::FrameLoader::checkCompleted): Use allChildrenAreComplete
      function for clarity.
      (WebCore::FrameLoader::checkCallImplicitClose): Ditto.
      (WebCore::FrameLoader::scheduleRedirection): Changed to take a PassOwnPtr.
      (WebCore::FrameLoader::startRedirectionTimer): Added code to set the
      toldClient flag and not call clientRedirected a second time if it is set.
      (WebCore::FrameLoader::stopRedirectionTimer): Changed so this can be safely
      called multiple times and it will call clientRedirectCancelledOrFinished
      only once.
      
      * loader/FrameLoader.h: Changed scheduleRedirection to be a PassOwnPtr.
      Added allChildrenAreComplete function.
      
      LayoutTests: 
      
      * http/tests/loading/deleted-host-in-resource-load-delegate-callback-expected.txt:
      Updated test to reflect progression. The willPerformClientRedirectToURL
      call was called an extra time before.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d9d718c
  6. 10 Sep, 2009 1 commit
    • abarth@webkit.org's avatar
      2009-09-10 Adam Barth <abarth@webkit.org> · 0f9b3026
      abarth@webkit.org authored
              Reviewed by Sam Weinig.
      
              Detect mixed content
              https://bugs.webkit.org/show_bug.cgi?id=29003
      
              Add some tests for mixed content.  All but one of these tests pass
              currently.  The one that fails is pretty tricky, but I wanted to get it
              into the tree with a FIXME so we won't forget it.  I'll file a followup
              bug about fixing it.
      
              * http/tests/security/mixedContent/about-blank-iframe-in-main-frame-expected.txt: Added.
              * http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html: Added.
              * http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt: Added.
              * http/tests/security/mixedContent/data-url-iframe-in-main-frame.html: Added.
              * http/tests/security/mixedContent/data-url-script-in-iframe-expected.txt: Added.
              * http/tests/security/mixedContent/data-url-script-in-iframe.html: Added.
              * http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt: Added.
              * http/tests/security/mixedContent/insecure-css-in-iframe.html: Added.
              * http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt: Added.
              * http/tests/security/mixedContent/insecure-css-in-main-frame.html: Added.
              * http/tests/security/mixedContent/insecure-iframe-in-iframe-expected.txt: Added.
              * http/tests/security/mixedContent/insecure-iframe-in-iframe.html: Added.
              * http/tests/security/mixedContent/insecure-iframe-in-main-frame-expected.txt: Added.
              * http/tests/security/mixedContent/insecure-iframe-in-main-frame.html: Added.
              * http/tests/security/mixedContent/insecure-image-in-iframe-expected.txt: Added.
              * http/tests/security/mixedContent/insecure-image-in-iframe.html: Added.
              * http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt: Added.
              * http/tests/security/mixedContent/insecure-image-in-main-frame.html: Added.
              * http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt: Added.
              * http/tests/security/mixedContent/insecure-script-in-iframe.html: Added.
              * http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt: Added.
              * http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html: Added.
              * http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt: Added.
              * http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html: Added.
              * http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt: Added.
              * http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html: Added.
              * http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe-expected.txt: Added.
              * http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html: Added.
              * http/tests/security/mixedContent/resources/boring.html: Added.
              * http/tests/security/mixedContent/resources/frame-with-about-blank-frame.html: Added.
              * http/tests/security/mixedContent/resources/frame-with-data-url-frame.html: Added.
              * http/tests/security/mixedContent/resources/frame-with-data-url-script.html: Added.
              * http/tests/security/mixedContent/resources/frame-with-insecure-css.html: Added.
              * http/tests/security/mixedContent/resources/frame-with-insecure-frame.html: Added.
              * http/tests/security/mixedContent/resources/frame-with-insecure-image.html: Added.
              * http/tests/security/mixedContent/resources/frame-with-insecure-script.html: Added.
              * http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-frame.html: Added.
              * http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-script.html: Added.
              * http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-frame.html: Added.
              * http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-script.html: Added.
              * http/tests/security/mixedContent/resources/script.js: Added.
              * http/tests/security/mixedContent/resources/style.css: Added.
      2009-09-10  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Sam Weinig.
      
              Detect mixed content
              https://bugs.webkit.org/show_bug.cgi?id=29003
      
              Detect some basic kinds of mixed content (HTTP content loaded into an
              HTTPS context).  This new detection logic isn't perfect, but it's a
              place to start.
      
              Tests: http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html
                     http/tests/security/mixedContent/data-url-iframe-in-main-frame.html
                     http/tests/security/mixedContent/data-url-script-in-iframe.html
                     http/tests/security/mixedContent/insecure-css-in-iframe.html
                     http/tests/security/mixedContent/insecure-css-in-main-frame.html
                     http/tests/security/mixedContent/insecure-iframe-in-iframe.html
                     http/tests/security/mixedContent/insecure-iframe-in-main-frame.html
                     http/tests/security/mixedContent/insecure-image-in-iframe.html
                     http/tests/security/mixedContent/insecure-image-in-main-frame.html
                     http/tests/security/mixedContent/insecure-script-in-iframe.html
                     http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html
                     http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
                     http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
                     http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html
      
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::canRequest):
              (WebCore::DocLoader::requestResource):
              (WebCore::DocLoader::checkCacheObjectStatus):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::isMixedContent):
              (WebCore::FrameLoader::checkIfDisplayInsecureContent):
              (WebCore::FrameLoader::checkIfRunInsecureContent):
              * loader/FrameLoader.h:
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::willSendRequest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f9b3026
  7. 02 Sep, 2009 4 commits
    • beidson@apple.com's avatar
      More partial work towards "Page Cache should support pages with Frames" · 212b784b
      beidson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=13631
      
      Reviewed by Darin Adler.
      
      No new tests. (No change in behavior, current tests pass).
      
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::stopLoading): Adopt the new enum form for FrameLoader::stopLoading().
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::stopLoading): Take an enum to decide whether to dispatch no unload events,
        only unload, or unload and pagehide.
      (WebCore::FrameLoader::closeURL):
      (WebCore::FrameLoader::scheduleRedirection):
      (WebCore::FrameLoader::cachePageForHistoryItem): Call pageHidden().
      (WebCore::FrameLoader::pageHidden): Add to dispatch the pagehide event to all frames in the case
        where a page is added to the PageCache.
      * loader/FrameLoader.h:
      
      * loader/FrameLoaderTypes.h: Add an UnloadEventPolicy enum.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      212b784b
    • beidson@apple.com's avatar
      WebCore: More partial work towards "Page Cache should support pages with Frames" · 24f92a52
      beidson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=13631
      
      Reviewed by Darin Adler.
      
      - More CachedFrame destruction work.
      - Including related Frame and FrameLoader changes and cleanup.
      
      No new tests. (No change in behavior, current tests pass).
      
      * history/CachedFrame.cpp:
      (WebCore::CachedFrameBase::restore): Rebuild up the whole FrameTree when restoring.
      (WebCore::CachedFrame::CachedFrame): Tear down the entire FrameTree when caching.
      (WebCore::CachedFrame::destroy): For child frames that are being destroyed while in
        the PageCache, do lightweight cleanup to:
        A - Prevent referring to a stale Page object.
        B - Prevent World Leaks of WebKit objects.
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::stopAllLoaders): stopAllLoaders() should never be called on Frames that are
        in the PageCache. ASSERT that fact.
      (WebCore::FrameLoader::open): Remove a bogus release-build workaround, as the comment right above it
        explains it is not effective, and it'd be better to see the crash locally instead of downstream.
      (WebCore::FrameLoader::closeAndRemoveChild): Make sure the owner element has a page pointer before
        referencing it.
      (WebCore::FrameLoader::detachFromParent): Use the new detachViewsAndDocumentLoader() call
      (WebCore::FrameLoader::detachViewsAndDocumentLoader): Does lightweight cleanup of client (WebKit) objects.
      * loader/FrameLoader.h:
      
      * page/Frame.cpp:
      (WebCore::Frame::detachFromPage): Simply clear the Page pointer without doing any other work.
      (WebCore::Frame::pageDestroyed): Use the new detachFromPage().
      * page/Frame.h:
      
      WebKit/mac: More partial work towards "Page Cache should support pages with Frames"
      https://bugs.webkit.org/show_bug.cgi?id=13631
      
      Reviewed by Darin Adler.
      
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _topHTMLView]): Rework the ASSERT in this method to reflect the
        reality of calling this method for pages currently in the PageCache.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47999 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24f92a52
    • beidson@apple.com's avatar
      In http://trac.webkit.org/changeset/47943 I added new header dependencies to FrameLoader.h. · 913c7f8a
      beidson@apple.com authored
      Removing them is a little trouble, but worth it going forward.
      The pattern of creating a "CachedFrameBase" as the interface CachedFrame provides to FrameLoader
      was suggested by Darin Adler.
      
      Reviewed by Darin Adler.
      
      No new tests. (No change in behavior)
      
      Make CachedFrame inherit privately from CachedFrameBase, which becomes the interface FrameLoader uses:
      * history/CachedFrame.cpp:
      (WebCore::CachedFrameBase::CachedFrameBase):
      (WebCore::CachedFrameBase::~CachedFrameBase):
      (WebCore::CachedFrameBase::restore):
      (WebCore::CachedFrame::CachedFrame):
      (WebCore::CachedFrame::openInFrameLoader):
      * history/CachedFrame.h:
      (WebCore::CachedFrameBase::document):
      (WebCore::CachedFrameBase::view):
      (WebCore::CachedFrameBase::domWindow):
      (WebCore::CachedFrame::create):
      (WebCore::CachedFrame::documentLoader):
      (WebCore::CachedFrame::mousePressNode):
      
      Call the new ::openInFrameLoader() method on the CachedFrame, as CachedFrameBase is now the only
      thing capable of interacting with FrameLoader::open(CachedFrameBase):
      * history/CachedPage.cpp:
      (WebCore::CachedPage::restore):
      * history/CachedPage.h:
      (WebCore::CachedPage::documentLoader):
      
      Make ::open(CachedFrame) public, and change it to ::open(CachedFrameBase):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::open):
      * loader/FrameLoader.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      913c7f8a
    • beidson@apple.com's avatar
      More partial work towards "Page Cache should support pages with Frames" · f845d1e8
      beidson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=13631
      
      Reviewed by Sam Weinig.
      
      This patch is primarily about the "CachedFrame tree" and making slightly different decisions
      based on whether a CachedFrame is the main frame or a subframe.
      
      - Store whether a CachedFrame represents the main frame or a subframe.
      - "Chop off the frame tree" for the main frame when creating its CachedFrame, as main frames 
        are reused and need to start new page loads with an empty frame tree.
      - Reattach the frame tree to the main frame when restoring it.
      - open() the cached subframes in their respective loaders when restoring.
      - Properly clear() and destroy() cached subframes.
      - When committing to a new page load, and after caching the previous page, only clear the
        FrameView for the main frame.
      
      Note that all of above will eventually be necessary as I continue to land this work in pieces,
      but doesn't actually change any behavior right now because we still refuse to even *try* to
      cache pages with frames.
      
      No new tests. No change in behavior, and current tests continue to pass.
      
      * history/CachedFrame.cpp:
      (WebCore::CachedFrame::CachedFrame):
      (WebCore::CachedFrame::restore):
      (WebCore::CachedFrame::clear):
      (WebCore::CachedFrame::destroy):
      * history/CachedFrame.h:
      (WebCore::CachedFrame::isMainFrame):
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::clear):
      (WebCore::FrameLoader::open):
      * loader/FrameLoader.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f845d1e8
  8. 01 Sep, 2009 1 commit
    • beidson@apple.com's avatar
      Page Cache should support pages with frames · 00113e61
      beidson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=13631
      
      Reviewed by Sam Weinig.
      
      Things learned in the full task that this patch addresses:
      - The notions of clearing a CachedFrame and destroying a CachedFrame were two concepts that 
        needed to be managed separately.
      - Once we start restoring pages with multiple CachedFrames, we'll have to be calling
        FrameLoader::open(CachedFrame&) multiple times with different CachedFrames, and this process
        will be guided by the CachedFrames themselves.
      
      No new tests. (No change in behavior, current layout tests pass)
              
      * history/CachedFrame.cpp:
      (WebCore::CachedFrame::CachedFrame):
      (WebCore::CachedFrame::~CachedFrame):
      (WebCore::CachedFrame::clear): Only clear pointers out.
      (WebCore::CachedFrame::destroy): Perform the destructive cleanup work here - Things that shouldn't
        occur simply by navigating back to a page with a CachedFrame.
      * history/CachedFrame.h:
      
      * history/CachedPage.cpp:
      (WebCore::CachedPage::~CachedPage):
      (WebCore::CachedPage::restore): Call clear() after restoring.
      (WebCore::CachedPage::clear):
      (WebCore::CachedPage::destroy):
      * history/CachedPage.h:
      
      * history/PageCache.cpp:
      (WebCore::PageCache::releaseAutoreleasedPagesNow): destroy() CachedPages that are being pruned,
        instead of clearing them.
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::commitProvisionalLoad): Let the CachedPage clear() itself after restoring.
      (WebCore::FrameLoader::open): Don't ::open() the CachedFrame, as the CachedPage does that now.
      * loader/FrameLoader.h:  Add the friending so CachedPage and CachedFrame can better guide the process.
        Even though CachedFrame::restore() isn't used for now, it will be soon.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00113e61
  9. 17 Aug, 2009 1 commit
    • beidson@apple.com's avatar
      Some cleanup towards https://bugs.webkit.org/show_bug.cgi?id=13631 · ac095c08
      beidson@apple.com authored
      Page Cache should support pages with frames.
      
      Reviewed by Sam Weinig.
      
      - Re-factor all remaining page cache code out of DocumentLoader, as CachedPage/CacheFrame loads
        are solely the responsibility of FrameLoader.
      - Enhance some page cache related Logging to help development.
      
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::didCommitLoad):
      (WebCore::InspectorController::identifierForInitialRequest):
      
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::DocumentLoader):
      * loader/DocumentLoader.h:
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::FrameLoader):
      (WebCore::FrameLoader::commitProvisionalLoad):
      (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
      (WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
      * loader/FrameLoader.h:
      (WebCore::FrameLoader::isLoadingFromCachedPage):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac095c08
  10. 27 Jul, 2009 1 commit
  11. 14 Jul, 2009 1 commit
    • bfulgham@webkit.org's avatar
      JavaScriptCore: · 8a8a2f45
      bfulgham@webkit.org authored
      2009-07-14  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>
      
              Reviewed by Darin Adler.
      
              Change all Noncopyable inheriting visibility to public.
              https://bugs.webkit.org/show_bug.cgi?id=27225
      
              Change all Noncopyable inheriting visibility to public because
              it is needed to the custom allocation framework (bug #20422).
      
              * bytecode/SamplingTool.h:
              * bytecompiler/RegisterID.h:
              * interpreter/CachedCall.h:
              * interpreter/RegisterFile.h:
              * parser/Lexer.h:
              * parser/Parser.h:
              * runtime/ArgList.h:
              * runtime/BatchedTransitionOptimizer.h:
              * runtime/Collector.h:
              * runtime/CommonIdentifiers.h:
              * runtime/JSCell.h:
              * runtime/JSGlobalObject.h:
              * runtime/JSLock.h:
              * runtime/JSONObject.cpp:
              * runtime/SmallStrings.cpp:
              * runtime/SmallStrings.h:
              * wtf/CrossThreadRefCounted.h:
              * wtf/GOwnPtr.h:
              * wtf/Locker.h:
              * wtf/MessageQueue.h:
              * wtf/OwnArrayPtr.h:
              * wtf/OwnFastMallocPtr.h:
              * wtf/OwnPtr.h:
              * wtf/RefCounted.h:
              * wtf/ThreadSpecific.h:
              * wtf/Threading.h:
              * wtf/Vector.h:
              * wtf/unicode/Collator.h:
      
      WebCore:
      
      2009-07-14  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>
      
              Reviewed by Darin Adler.
      
              Change all Noncopyable inheriting visibility to public.
              https://bugs.webkit.org/show_bug.cgi?id=27225
      
              Change all Noncopyable inheriting visibility to public because
              it is needed to the custom allocation framework (bug #20422).
      
              * bindings/js/GCController.h:
              * bindings/js/WorkerScriptController.h:
              * bindings/v8/V8DOMMap.cpp:
              (WebCore::):
              * bridge/runtime.h:
              * css/CSSSelector.h:
              * css/CSSSelectorList.h:
              * css/CSSStyleSelector.h:
              * dom/ClassNames.h:
              * dom/MessagePortChannel.h:
              * dom/XMLTokenizerLibxml2.cpp:
              * dom/XMLTokenizerScope.h:
              * editing/ReplaceSelectionCommand.cpp:
              * editing/SelectionController.h:
              * editing/TextIterator.cpp:
              * history/PageCache.h:
              * html/CanvasRenderingContext2D.h:
              * html/HTMLParser.h:
              * html/HTMLParserQuirks.h:
              * html/PreloadScanner.h:
              * loader/Cache.h:
              * loader/CrossOriginPreflightResultCache.h:
              * loader/FrameLoader.h:
              * loader/ProgressTracker.h:
              * loader/ThreadableLoader.h:
              * loader/appcache/ApplicationCacheGroup.h:
              * loader/archive/ArchiveResourceCollection.h:
              * loader/icon/IconDatabase.h:
              * loader/icon/IconLoader.h:
              * loader/icon/PageURLRecord.h:
              * loader/loader.h:
              * page/ContextMenuController.h:
              * page/EventHandler.h:
              * page/FrameTree.h:
              * page/Page.h:
              * page/PageGroup.h:
              * page/PageGroupLoadDeferrer.h:
              * page/mac/EventHandlerMac.mm:
              * platform/AutodrainedPool.h:
              * platform/ContextMenu.h:
              * platform/EventLoop.h:
              * platform/HostWindow.h:
              * platform/Pasteboard.h:
              * platform/PurgeableBuffer.h:
              * platform/RunLoopTimer.h:
              * platform/ThreadGlobalData.h:
              * platform/ThreadTimers.h:
              * platform/Timer.h:
              * platform/TreeShared.h:
              * platform/graphics/FontData.h:
              * platform/graphics/GlyphWidthMap.h:
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/ImageBuffer.h:
              * platform/graphics/ImageSource.h:
              * platform/graphics/MediaPlayer.h:
              * platform/graphics/skia/GraphicsContextPlatformPrivate.h:
              * platform/graphics/skia/PlatformContextSkia.h:
              * platform/graphics/win/QTMovieWin.cpp:
              * platform/mac/LocalCurrentGraphicsContext.h:
              * platform/network/FormDataBuilder.h:
              * platform/network/ResourceHandleInternal.h:
              * platform/network/soup/ResourceHandleSoup.cpp:
              * platform/text/StringBuffer.h:
              * platform/text/TextCodec.h:
              * platform/win/WindowMessageBroadcaster.h:
              * rendering/CounterNode.h:
              * rendering/LayoutState.h:
              * rendering/RenderFrameSet.h:
              * rendering/RenderView.h:
              * rendering/TransformState.h:
              * svg/SVGAnimatedProperty.h:
              * svg/SynchronizableTypeWrapper.h:
              * workers/WorkerMessagingProxy.h:
              * workers/WorkerRunLoop.cpp:
              * xml/XPathExpressionNode.h:
              * xml/XPathParser.h:
              * xml/XPathPredicate.h:
              * xml/XPathStep.h:
      
      WebKit/gtk:
      
      2009-07-14  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>
      
              Reviewed by Darin Adler.
      
              Change all Noncopyable inheriting visibility to public.
              https://bugs.webkit.org/show_bug.cgi?id=27225
      
              Change all Noncopyable inheriting visibility to public because
              it is needed to the custom allocation framework (bug #20422).
      
              * webkit/webkitdownload.cpp:
      
      WebKit/win:
      
      2009-07-14  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>
      
              Reviewed by Darin Adler.
      
              Change all Noncopyable inheriting visibility to public.
              https://bugs.webkit.org/show_bug.cgi?id=27225
      
              Change all Noncopyable inheriting visibility to public because
              it is needed to the custom allocation framework (bug #20422).
      
              * COMEnumVariant.h:
              * WebDatabaseManager.cpp:
              * WebInspector.h:
              * WebLocalizableStrings.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a8a2f45
  12. 09 Jul, 2009 1 commit
    • bdakin@apple.com's avatar
      WebCore: · 33a4d05b
      bdakin@apple.com authored
      2009-07-09  Beth Dakin and Jon Honeycutt <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Make Widget RefCounted to fix or make fixable:
      
              <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs 
              at WebCore::Widget::afterMouseDown() after clicking To Do's close 
              box
              <rdar://problem/6978804> WER #16: Repro Access Violation in 
              WebCore::PluginView::bindingInstance (1310178023)
              -and-
              <rdar://problem/6991251> WER #13: Crash in WebKit!
              WebCore::PluginView::performRequest+203 (1311461169) 
      
              * loader/EmptyClients.h:
              (WebCore::EmptyFrameLoaderClient::createPlugin):
              Changed to return PassRefPtr
              (WebCore::EmptyFrameLoaderClient::createJavaAppletWidget):
              Ditto.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::loadSubframe):
              (WebCore::FrameLoader::loadPlugin):
              Make the widget variable a RefPtr. Use .get() when passing it to
              RenderPart::setWidget().
              (WebCore::FrameLoader::createJavaAppletWidget):
              Make the widget variable a RefPtr.
      
              * loader/FrameLoader.h:
              Changed the return type of createJavaAppletWidget().
      
              * loader/FrameLoaderClient.h:
              Change the return types of createPlugin() and 
              createJavaAppletWidget().
      
              * page/Frame.cpp:
              (WebCore::Frame::createView):
              No need to call .get() since setWidget() takes a RefPtr.
      
              * page/FrameView.cpp:
              (WebCore::FrameView::layoutIfNeededRecursive):
              children() now returns a HashSet of RefPtrs.
      
              * page/FrameView.h:
              Remove inheritance from RefCounted; we pick this up from ScrollView
              through Widget.
      
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::addChild):
              addChild() now takes a PassRefPtr and m_children now keeps a 
              HashSet of RefPtrs.
      
              * platform/ScrollView.h:
              ScrollView constructor is now protected.
              (WebCore::ScrollView::children):
              m_children is now a HashSet of RefPtrs.
      
              * platform/Scrollbar.h:
              Remove inheritance from RefCounted; we pick this up from ScrollView
              through Widget.
      
              * platform/Widget.h:
              Inherit from RefCounted. Cleaned up some whitespace. Make m_widget 
              a RefPtr.
      
              * plugins/PluginView.cpp:
              (WebCore::PluginView::create):
              Adopt the PluginView when returning it.
      
              * plugins/PluginView.h:
              Changed create() to return a PassRefPtr.
      
              * rendering/RenderApplet.cpp:
              Receive result in a RefPtr when calling createJavaAppletWidget().
      
              * rendering/RenderPart.cpp:
              (WebCore::RenderPart::setWidget): 
              setWidget() now takes a PassRefPtr. Also removed the manual ref of 
              FrameViews. This is handled by having m_widget be a RefPtr. Removed 
              deleteWidget().
      
              * rendering/RenderPart.h:
              Removed override of deleteWidget().
      
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::destroy):
              (WebCore::RenderWidget::setWidget):
              (WebCore::RenderWidget::paint):
              (WebCore::RenderWidget::setOverlapTestResult):
              (WebCore::RenderWidget::updateWidgetPosition):
              Use .get().
              (WebCore::RenderWidget::clearWidget):
              Don't call deleteWidget(). It was removed. 
      
              * rendering/RenderWidget.h:
              Removed deleteWidget(). Made m_widget a RefPtr.
              (WebCore::RenderWidget::widget):
              Use .get().
      
      WebKit/gtk:
      
      2009-07-09  Beth Dakin and Jon Honeycutt <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Make Widget RefCounted to fix:
      
              <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs 
              at WebCore::Widget::afterMouseDown() after clicking To Do's close 
              box
              <rdar://problem/6978804> WER #16: Repro Access Violation in 
              WebCore::PluginView::bindingInstance (1310178023)
              -and-
              <rdar://problem/6991251> WER #13: Crash in WebKit!
              WebCore::PluginView::performRequest+203 (1311461169) 
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::createPlugin):
              (WebKit::FrameLoaderClient::createJavaAppletWidget):
              * WebCoreSupport/FrameLoaderClientGtk.h:
      
      WebKit/mac:
      
      2009-07-09  Beth Dakin and Jon Honeycutt <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Make Widget RefCounted to fix:
      
              <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs 
              at WebCore::Widget::afterMouseDown() after clicking To Do's close 
              box
              <rdar://problem/6978804> WER #16: Repro Access Violation in 
              WebCore::PluginView::bindingInstance (1310178023)
              -and-
              <rdar://problem/6991251> WER #13: Crash in WebKit!
              WebCore::PluginView::performRequest+203 (1311461169) 
      
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::createPlugin):
      
      WebKit/qt:
      
      2009-07-09  Beth Dakin  <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Make Widget RefCounted to fix:
      
              <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs 
              at WebCore::Widget::afterMouseDown() after clicking To Do's close 
              box
              <rdar://problem/6978804> WER #16: Repro Access Violation in 
              WebCore::PluginView::bindingInstance (1310178023)
              -and-
              <rdar://problem/6991251> WER #13: Crash in WebKit!
              WebCore::PluginView::performRequest+203 (1311461169) 
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::createPlugin):
              (WebCore::FrameLoaderClientQt::createJavaAppletWidget):
              * WebCoreSupport/FrameLoaderClientQt.h:
      
      WebKit/win:
      
      2009-07-09  Beth Dakin and Jon Honeycutt <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Make Widget RefCounted to fix:
      
              <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs 
              at WebCore::Widget::afterMouseDown() after clicking To Do's close 
              box
              <rdar://problem/6978804> WER #16: Repro Access Violation in 
              WebCore::PluginView::bindingInstance (1310178023)
              -and-
              <rdar://problem/6991251> WER #13: Crash in WebKit!
              WebCore::PluginView::performRequest+203 (1311461169) 
      
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::createPlugin):
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebFrame.cpp:
              (WebFrame::createJavaAppletWidget):
              * WebFrame.h:
      
      WebKit/wx:
      
      2009-07-09  Beth Dakin and Jon Honeycutt <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Make Widget RefCounted to fix:
      
              <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs 
              at WebCore::Widget::afterMouseDown() after clicking To Do's close 
              box
              <rdar://problem/6978804> WER #16: Repro Access Violation in 
              WebCore::PluginView::bindingInstance (1310178023)
              -and-
              <rdar://problem/6991251> WER #13: Crash in WebKit!
              WebCore::PluginView::performRequest+203 (1311461169) 
      
              * WebKitSupport/FrameLoaderClientWx.cpp:
              (WebCore::FrameLoaderClientWx::createPlugin):
              (WebCore::FrameLoaderClientWx::createJavaAppletWidget):
              * WebKitSupport/FrameLoaderClientWx.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33a4d05b
  13. 08 Jul, 2009 2 commits
    • bolsinga@apple.com's avatar
      WebCore: · 2c174ef2
      bolsinga@apple.com authored
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c174ef2
    • ap@webkit.org's avatar
      Reviewed (an earlier version) by Geoff Garen. · a4637ec6
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=27090
              Remove lockBackForwardList argument from HTMLFormElement::submit()
      
              No change in behavior, so no tests.
      
              * bindings/js/JSHTMLFormElementCustom.cpp:
              (WebCore::JSHTMLFormElement::submit):
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::submit):
              * html/HTMLFormElement.h:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::submitForm):
              (WebCore::FrameLoader::scheduleFormSubmission):
              * loader/FrameLoader.h:
              Don't pass lockBackForwardList around when it's known to be false.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4637ec6
  14. 13 Jun, 2009 1 commit
    • abarth@webkit.org's avatar
      WebCore: · 116c0883
      abarth@webkit.org authored
      2009-06-13  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Fisher.
      
              https://bugs.webkit.org/show_bug.cgi?id=24492
      
              Moved registerURLSchemeAsLocal and registerURLSchemeAsNoAccess from
              FrameLoader to SecurityOrigin.
      
              * WebCore.base.exp:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::loadFrameRequest):
              (WebCore::FrameLoader::canLoad):
              * loader/FrameLoader.h:
              * page/SecurityOrigin.cpp:
              (WebCore::localSchemes):
              (WebCore::noAccessSchemes):
              (WebCore::SecurityOrigin::SecurityOrigin):
              (WebCore::SecurityOrigin::isLocal):
              (WebCore::SecurityOrigin::registerURLSchemeAsLocal):
              (WebCore::SecurityOrigin::shouldTreatURLAsLocal):
              (WebCore::SecurityOrigin::shouldTreatURLSchemeAsLocal):
              (WebCore::SecurityOrigin::registerURLSchemeAsNoAccess):
              (WebCore::SecurityOrigin::shouldTreatURLSchemeAsNoAccess):
              * page/SecurityOrigin.h:
      
      WebKit/mac:
      
      2009-06-13  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Fisher.
      
              https://bugs.webkit.org/show_bug.cgi?id=24492
      
              Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin
      
              * WebView/WebView.mm:
              (+[WebView registerURLSchemeAsLocal:]):
      
      WebKit/qt:
      
      2009-06-13  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Fisher.
      
              https://bugs.webkit.org/show_bug.cgi?id=24492
      
              Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin.
      
              * Api/qwebpage.cpp:
              (QWebPage::acceptNavigationRequest):
      
      WebKit/win:
      
      2009-06-13  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Fisher.
      
              https://bugs.webkit.org/show_bug.cgi?id=24492
      
              Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin.
      
              * WebView.cpp:
              (WebView::registerURLSchemeAsLocal):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      116c0883
  15. 05 Jun, 2009 1 commit
    • oliver@apple.com's avatar
      2009-06-03 Ben Murdoch <benm@google.com> · 0af4830e
      oliver@apple.com authored
              <https://bugs.webkit.org/show_bug.cgi?id=25710> HTML5 Database stops executing transactions if the URL hash changes while a transaction is open and an XHR is in progress.
      
              Reviewed by Alexey Proskuryakov.
      
              Fix a bug that causes database transactions to fail if a history navigation to a hash fragment of the same document is made while resources (e.g. an XHR) are loading
              https://bugs.webkit.org/show_bug.cgi?id=25710
      
              Test: storage/hash-change-with-xhr.html
      
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::stopLoading):
              * loader/DocumentLoader.h:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::stopLoading):
              (WebCore::FrameLoader::stopAllLoaders):
              * loader/FrameLoader.h:
              * loader/FrameLoaderTypes.h:
              (WebCore::):
              * page/Page.cpp:
              (WebCore::Page::goToItem):
              * WebCore.base.exp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0af4830e
  16. 02 Jun, 2009 2 commits
    • abarth@webkit.org's avatar
      Revert 44351. · dbd34173
      abarth@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbd34173
    • abarth@webkit.org's avatar
      WebCore: · 9b55666f
      abarth@webkit.org authored
      2009-06-01  Ben Murdoch  <benm@google.com>
      
              Reviewed by Darin Adler.  Landed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=25710
      
              Fix a bug that causes database transactions to fail if a history navigation to a hash fragment of the same document is made while resources (e.g. an XHR) are loading.
      
              Test: storage/hash-change-with-xhr.html
      
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::stopLoading):
              * loader/DocumentLoader.h:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::stopLoading):
              (WebCore::FrameLoader::stopAllLoaders):
              * loader/FrameLoader.h:
              * loader/FrameLoaderTypes.h:
              (WebCore::):
              * page/Page.cpp:
              (WebCore::Page::goToItem):
      
      LayoutTests:
      
      2009-06-02  Ben Murdoch  <benm@google.com>
      
              Reviewed by Darin Alder.  Landed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=25710
      
              Fix a bug that causes database transactions to fail if a history navigation to a hash fragment of the same document is made while resources (e.g. an XHR) are loading.
      
              * storage/hash-change-with-xhr-expected.txt: Added.
              * storage/hash-change-with-xhr.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b55666f
  17. 27 May, 2009 1 commit
  18. 22 May, 2009 1 commit
    • abarth@webkit.org's avatar
      2009-05-22 Adam Barth <abarth@webkit.org> · 622d9dff
      abarth@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Rename policyBaseURL and mainDocumentURL to firstPartyForCookies.  The
              previous names were confusing and inaccurate.
      
              * WebCore.order:
              * dom/Document.cpp:
              (WebCore::Document::setCookie):
              * dom/Document.h:
              (WebCore::Document::firstPartyForCookies):
              (WebCore::Document::setFirstPartyForCookies):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::begin):
              (WebCore::FrameLoader::updateFirstPartyForCookies):
              (WebCore::FrameLoader::setFirstPartyForCookies):
              (WebCore::FrameLoader::open):
              (WebCore::FrameLoader::addExtraFieldsToRequest):
              (WebCore::FrameLoader::loadResourceSynchronously):
              * loader/FrameLoader.h:
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::willSendRequest):
              * platform/CookieJar.h:
              * platform/mac/CookieJar.mm:
              (WebCore::setCookies):
              * platform/network/ResourceRequestBase.cpp:
              (WebCore::ResourceRequestBase::adopt):
              (WebCore::ResourceRequestBase::copyData):
              (WebCore::ResourceRequestBase::firstPartyForCookies):
              (WebCore::ResourceRequestBase::setFirstPartyForCookies):
              (WebCore::equalIgnoringHeaderFields):
              * platform/network/ResourceRequestBase.h:
              * platform/network/cf/ResourceRequestCFNet.cpp:
              (WebCore::ResourceRequest::doUpdatePlatformRequest):
              (WebCore::ResourceRequest::doUpdateResourceRequest):
              * platform/network/chromium/CookieJarChromium.cpp:
              (WebCore::setCookies):
              * platform/network/mac/ResourceRequestMac.mm:
              (WebCore::ResourceRequest::doUpdateResourceRequest):
              (WebCore::ResourceRequest::doUpdatePlatformRequest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      622d9dff
  19. 19 May, 2009 1 commit
    • beidson@apple.com's avatar
      2009-05-19 Brady Eidson <beidson@apple.com> · ee54c99b
      beidson@apple.com authored
              Reviewed by Antti Koivisto. 
      
              <rdar://problem/6886382> REGRESSION (Safari 4PB -> ToT): HTTP cache revalidation broken.
      
              This was caused in http://trac.webkit.org/changeset/41425, which fixed an image caching bug
              in QuickLooks (rdar://problem/6619630).
      
              We need to respect the DocumentLoader's request cache policy when deciding the cache policy
              for subresources, but the check (originally removed in r39304 and added back in in the same
              place in r41424) needs to be tweaked and relocated a bit.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::subresourceCachePolicy): Renamed from cachePolicy().  Move checking
                the DocumentLoader's request to a more appropriate place. Add code to handle the recently 
                added FIXME regarding POSTs. Add a new FIXME describing a great way to make this code 
                cleaner in the future.
              * loader/FrameLoader.h:
      
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::cachePolicy): Calls the newly renamed subresourceCachePolicy().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee54c99b
  20. 05 May, 2009 1 commit
  21. 01 May, 2009 1 commit
    • dglazkov@chromium.org's avatar
      WebCore: · 8ac9b855
      dglazkov@chromium.org authored
      2009-05-01  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
              This is the only resource-related information that is available in InspectorController
              and is missing in the FrameLoaderClient.
      
              https://bugs.webkit.org/show_bug.cgi?id=25347
      
              * WebCore.xcodeproj/project.pbxproj: Made ScriptSource private.
              * dom/Document.cpp: Made a call to a client along with the call to the InspectorController.
              (WebCore::Document::resourceRetrievedByXMLHttpRequest):
              * loader/EmptyClients.h: Added stub implementation.
              (WebCore::EmptyFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
              * loader/FrameLoader.cpp: Call initiating dispatches.
              (WebCore::FrameLoader::resourceRetrievedByXMLHttpRequest):
              * loader/FrameLoader.h:
              * loader/FrameLoaderClient.h:
      
      WebKit/gtk:
      
      2009-05-01  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
      
              https://bugs.webkit.org/show_bug.cgi?id=25347
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
              * WebCoreSupport/FrameLoaderClientGtk.h:
      
      WebKit/mac:
      
      2009-05-01  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
      
              https://bugs.webkit.org/show_bug.cgi?id=25347
      
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
      
      WebKit/qt:
      
      2009-05-01  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
      
              https://bugs.webkit.org/show_bug.cgi?id=25347
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::dispatchDidLoadResourceByXMLHttpRequest):
              * WebCoreSupport/FrameLoaderClientQt.h:
      
      WebKit/win:
      
      2009-05-01  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
      
              https://bugs.webkit.org/show_bug.cgi?id=25347
      
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
              * WebCoreSupport/WebFrameLoaderClient.h:
      
      WebKit/wx:
      
      2009-05-01  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
      
              https://bugs.webkit.org/show_bug.cgi?id=25347
      
              * WebKitSupport/FrameLoaderClientWx.cpp:
              (WebCore::FrameLoaderClientWx::dispatchDidLoadResourceByXMLHttpRequest):
              * WebKitSupport/FrameLoaderClientWx.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ac9b855
  22. 14 Apr, 2009 1 commit
    • ap@webkit.org's avatar
      Reviewed by Sam Weinig. · d43a9928
      ap@webkit.org authored
              <rdar://problem/6698851> Implement XMLHttpRequest withCredentials attribute
      
              Tests: http/tests/xmlhttprequest/cross-origin-authorization.html
                     http/tests/xmlhttprequest/cross-origin-no-authorization.html
      
              * WebCore.xcodeproj/project.pbxproj: Made ThreadableLoader.h private, as enum definitions
              from it are now used in otehr private headers.
      
              * xml/XMLHttpRequest.h:
              * xml/XMLHttpRequest.idl:
              Added withCredentials attribute. When it is false (default), neither credentials nor cookies
              are sent with cross origin requests, When it is true, those are sent, but the server needs
              to allow handling results via Access-Control-Allow-Credentials header. It was always possible
              to send a cross-site request with credentials via IFRAME or IMG, so this just adds a way to
              read results, as long as the server reports that it's allowed.
              Having the default set to false ensures that requests won't fail unexpectedly because of
              stored credentials and cookies for other resources in the target protection space.
      
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::loadRequestSynchronously): Allow stored credentials for same origin
              requests, and for cross origin ones that have withCredentials attribute set. Such code already
              existed for cookies (but it's simpler, because we could just set a ResourceRequest flag).
              (WebCore::XMLHttpRequest::loadRequestAsynchronously): Ditto.
      
              * platform/network/ResourceHandle.h: Added willSendRequest() - just like for other callbacks,
              is is easier to have code in the class. Also, loadResourceSynchronously() now takes a
              StoredCredentials option, matching async case.
      
              * platform/network/ResourceHandleClient.h:
              (WebCore::ResourceHandleClient::receivedCredential): Removed. This method could never be
              called, and no client used it.
              (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential): Ditto.
      
              * platform/network/ResourceHandleInternal.h:
              (WebCore::ResourceHandleInternal::ResourceHandleInternal): Split username and password out
              of request URL. We want to always get a callback for credentials to manage them in WebCore,
              so network back-end shouldn't see them too early.
      
              * platform/network/ResourceRequestBase.cpp:
              (WebCore::ResourceRequestBase::removeCredentials):
              * platform/network/ResourceRequestBase.h:
              Added a removeCredentials() method that removes login and password parts from request URL.
      
              * platform/network/mac/ResourceHandleMac.mm:
              (WebCoreCredentialStorage): Added a simple storage class for per-session credentials.
              (WebCore::ResourceHandle::loadResourceSynchronously): Pass allowStoredCredentials through.
              (WebCore::ResourceHandle::willSendRequest): On a redirect, credentials should be replaced.
              (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Try credentials from the URL
              and per-session credentials. Code was partially moved from Obj-C callback.
              (WebCore::ResourceHandle::receivedCredential): Intercept per-session credentials and store
              them in WebCore storage.
              (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Don't
              store the redirected URL - we only needed credentials, which are now stored separately.
              (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Removed
              code that was setting credentials from URL. First, the code is now in ResourceHandle, and
              also, it wasn't actually needed in Leopard release before this patch, see <rdar://problem/5298142>.
              (-[WebCoreSynchronousLoader dealloc]): Release credentials. Note that unlike ResourceHandle,
              this class still needs to track URL for checking whether a redirect is allowed. This is
              not a great solution, and we should unify client code to use the same checks in sync and
              async cases.
              (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Just like in
              async case, put credentials aside to ensure that network back-end asks for them.
              (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use credentials
              from URL, or from WebCore storage.
              (-[WebCoreSynchronousLoader connectionShouldUseCredentialStorage:]): Don't use stored
              credentials when not allowed to.
              (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):
              Put credentials aside to ensure that network back-end asks for them.
      
              * platform/network/cf/ResourceHandleCFNet.cpp:
              (WebCore::WebCoreCredentialStorage::set):
              (WebCore::WebCoreCredentialStorage::get):
              (WebCore::willSendRequest):
              (WebCore::ResourceHandle::start):
              (WebCore::ResourceHandle::willSendRequest):
              (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
              (WebCore::ResourceHandle::receivedCredential):
              (WebCore::ResourceHandle::loadResourceSynchronously):
              (WebCore::WebCoreSynchronousLoader::willSendRequest):
              (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
              (WebCore::WebCoreSynchronousLoader::shouldUseCredentialStorage):
              (WebCore::WebCoreSynchronousLoader::load):
              Same changes as in Mac case.
      
              * platform/network/curl/ResourceHandleCurl.cpp:
              (WebCore::ResourceHandle::loadResourceSynchronously):
              * platform/network/qt/ResourceHandleQt.cpp:
              (WebCore::ResourceHandle::loadResourceSynchronously):
              * platform/network/soup/ResourceHandleSoup.cpp:
              (WebCore::ResourceHandle::loadResourceSynchronously):
              Trying not to break the build.
      
              * dom/XMLTokenizerLibxml2.cpp: (WebCore::openFunc):
              * xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
              Unconditionally allow stored credentials for these, as they only support same origin loads.
      
              * workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
              WorkerContext.importScripts() can be cross-origin, but sending credentials with it is no worse
              than sending them with <script src=...>, so this is also unconditionally allowed.
      
              * loader/DocumentThreadableLoader.cpp:
              (WebCore::DocumentThreadableLoader::loadResourceSynchronously): Pass through storedCredentials.
              (WebCore::DocumentThreadableLoader::create): Ditto.
              (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Save storedCredentials and
              sameOrigin flags foruse in callbacks.
              (WebCore::DocumentThreadableLoader::willSendRequest): Assert that loaders aren't all confused.
              (WebCore::DocumentThreadableLoader::didSendData): Ditto.
              (WebCore::DocumentThreadableLoader::didReceiveResponse): Ditto.
              (WebCore::DocumentThreadableLoader::didReceiveData): Ditto.
              (WebCore::DocumentThreadableLoader::didFinishLoading): Ditto.
              (WebCore::DocumentThreadableLoader::didFail): Ditto.
              (WebCore::DocumentThreadableLoader::getShouldUseCredentialStorage): Don't use credential
              storage if that's not allowed by the code that invoked DocumentThreadableLoader.
              (WebCore::DocumentThreadableLoader::didReceiveAuthenticationChallenge): Simulate a failure
              and cancel the request if we are about to ask the user for credentials for a cross-origin
              request, which is forbidden by CORS (and would have been very confusing if allowed).
              (WebCore::DocumentThreadableLoader::receivedCancellation): Assert that loaders aren't all confused.
      
              * loader/DocumentThreadableLoader.h: Updated for the new flags (storedCredentials and
              sameOrigin) that affect the loader. Eventually, we need to move all CORS logic from XHR here.
      
              * loader/ThreadableLoader.h: (StoredCredentials): Added another flag that affects loader
              behavior. We should combine all of these into a structure, and use it for sync requests, too.
      
              * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously):
              * loader/FrameLoader.h:
              * loader/ThreadableLoader.cpp:
              (WebCore::ThreadableLoader::create):
              (WebCore::ThreadableLoader::loadResourceSynchronously):
              * loader/WorkerThreadableLoader.cpp:
              (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
              (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
              (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
              (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
              * loader/WorkerThreadableLoader.h:
              (WebCore::WorkerThreadableLoader::create):
              Pass through storedCredentials.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d43a9928
  23. 09 Apr, 2009 1 commit
    • weinig@apple.com's avatar
      WebCore: · f239bbf9
      weinig@apple.com authored
      2009-04-08  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Geoffrey "Big Boy" Garen.
      
              Fix for <rdar://problem/5745677> Possible to stop load during an unload event
              Also fixes https://bugs.webkit.org/show_bug.cgi?id=20605
      
              Tests: fast/events/stop-load-in-unload-handler-using-document-write.html
                     fast/events/stop-load-in-unload-handler-using-window-stop.html
      
              Don't allow calling methods that would stop the new load inside the unload
              event.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::FrameLoader):
              (WebCore::FrameLoader::stopLoading):
              (WebCore::FrameLoader::stopAllLoaders):
              * loader/FrameLoader.h:
      
      LayoutTests:
      
      2009-04-08  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Geoffrey "Big Boy" Garen.
      
              Tests for <rdar://problem/5745677> Possible to stop load during an unload event
      
              * fast/events/resources/pass.html: Added.
              * fast/events/resources/subframe-stop-load-in-unload-handler-using-document-write.html: Added.
              * fast/events/resources/subframe-stop-load-in-unload-handler-using-window-stop.html: Added.
              * fast/events/stop-load-in-unload-handler-using-document-write-expected.txt: Added.
              * fast/events/stop-load-in-unload-handler-using-document-write.html: Added.
              * fast/events/stop-load-in-unload-handler-using-window-stop-expected.txt: Added.
              * fast/events/stop-load-in-unload-handler-using-window-stop.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f239bbf9
  24. 08 Apr, 2009 1 commit
    • weinig@apple.com's avatar
      WebCore: · 5af461c2
      weinig@apple.com authored
      2009-04-08  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Fix for <rdar://problem/6226200> Implement Microsoft's X-FRAME-OPTIONS anti-framing defense
      
              Tests: http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
                     http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
                     http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
                     http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html
                     http/tests/security/XFrameOptions/x-frame-options-deny.html
                     http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
                     http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
      
              * dom/Document.cpp:
              (WebCore::Document::processHttpEquiv): Stop the current load and redirect to about:blank
              if an X-FRAME-OPTIONS <meta> tag http-equiq dictates we should.
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions): Add logic to parse
              the X-FRAME-OPTIONS parameter.
              * loader/FrameLoader.h:
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::didReceiveResponse): Stop the current load if framed and
              a X-FRAME-OPTIONS header and its parameter dictate that we should.
      
      LayoutTests:
      
      2009-04-08  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Tests for <rdar://problem/6226200> Implement Microsoft's X-FRAME-OPTIONS anti-framing defense
      
              * http/tests/security/XFrameOptions: Added.
              * http/tests/security/XFrameOptions/resources: Added.
              * http/tests/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe-in-body.html: Added.
              * http/tests/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe-parent-same-origin-allow.html: Added.
              * http/tests/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe-parent-same-origin-deny.html: Added.
              * http/tests/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe.html: Added.
              * http/tests/security/XFrameOptions/resources/x-frame-options-deny.cgi: Added.
              * http/tests/security/XFrameOptions/resources/x-frame-options-parent-same-origin-allow.cgi: Added.
              * http/tests/security/XFrameOptions/resources/x-frame-options-parent-same-origin-deny.cgi: Added.
              * http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
              * http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
              * http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
              * http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html: Added.
              * http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Added.
              * http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html: Added.
              * http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
              * http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html: Added.
              * http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html: Added.
              * http/tests/security/XFrameOptions/x-frame-options-deny.html: Added.
              * http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Added.
              * http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html: Added.
              * http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
              * http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5af461c2
  25. 03 Apr, 2009 1 commit
  26. 01 Apr, 2009 1 commit
    • darin@apple.com's avatar
      WebCore: · 0f88bda0
      darin@apple.com authored
      2009-04-01  Darin Adler  <darin@apple.com>
      
              Reviewed by Geoff Garen.
      
              Bug 22378: Crash submitting a form when parsing an XHTML document
              https://bugs.webkit.org/show_bug.cgi?id=22378
              rdar://problem/6388377
      
              Tests: fast/loader/submit-form-while-parsing-1.xhtml
                     fast/loader/submit-form-while-parsing-2.html
      
              * WebCore.base.exp: Updated.
      
              * history/HistoryItem.cpp:
              (WebCore::HistoryItem::HistoryItem): Renamed m_subItems to m_children.
              Used uncheckedAppend because we reserveInitialCapacity.
              (WebCore::HistoryItem::addChildItem): Renamed m_subItems to m_children.
              Added an assertion that this is only used to add items that don't have
              duplicate frame names.
              (WebCore::HistoryItem::setChildItem): Added. Replaces an existing item
              if any, preserving the isTargetItem flag.
              (WebCore::HistoryItem::childItemWithTarget): Renamed from childItemWithName
              for consistency with the other functions here that all call the frame name the
              "target". Also updated for rename of m_subItems to m_children.
              (WebCore::HistoryItem::findTargetItem): Renamed from recurseToFindTargetItem.
              Removed unneeded size check.
              (WebCore::HistoryItem::targetItem): Changed to always return the top item
              if no item has the isTargetItem flag set. The old version would instead return
              0 in some cases, but return the top item if it had no children.
              (WebCore::HistoryItem::children): Renamed m_subItems to m_children.
              (WebCore::HistoryItem::hasChildren): Ditto.
              (WebCore::HistoryItem::showTreeWithIndent): Ditto.
      
              * history/HistoryItem.h: Name changes.
      
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::submit): Create and pass a FormState instead of
              attaching "recorded form values" and "form about to be submitted" to the frame
              loader. Parameter work fine for this; there's no need to store state on the
              FrameLoader.
      
              * loader/FormState.cpp:
              (WebCore::FormState::FormState): Adopt a vector instead of copying a hash map.
              (WebCore::FormState::create): Ditto.
              * loader/FormState.h: Update to use a vector that we adopt instead of hash map
              that we copy for auto-fill text field values.
      
              * loader/FrameLoader.cpp:
              (WebCore::ScheduledRedirection::ScheduledRedirection): Added a new case for
              form submissions and turned the "wasDuringLoad" state into a separate boolean
              instead of using a special redirection type to track it.
              (WebCore::FrameLoader::createWindow): Updated for name and argument change of
              loadFrameRequest.
              (WebCore::FrameLoader::urlSelected): Ditto.
              (WebCore::FrameLoader::submitForm): Removed the "deferred form submission"
              machinery, replacing it with the "scheduled redirection" mechanism, shared
              with other kinds of redirection and navigation. Moved frame targeting here
              so we can schedule the redirection on the right frame. Moved the multiple
              form submission protection here. Moved the code to implement the rule that
              m_navigationDuringLoad was used for here too.
              (WebCore::FrameLoader::didOpenURL): Use the new wasDuringLoad flag instead
              of the locationChangeDuringLoad type to detect location change during a load.
              (WebCore::FrameLoader::executeScript): Removed call to now-obsolete function,
              submitFormAgain.
              (WebCore::FrameLoader::scheduleLocationChange): Moved the code to stop loading
              out of this function into scheduleRedirection, so it can be shared with the
              new scheduleFormSubmission function.
              (WebCore::FrameLoader::scheduleFormSubmission): Added. Almost the same as
              scheduleLocationChange, but with the arguments for a form submission.
              (WebCore::FrameLoader::scheduleRefresh): Updated for the change to the
              duringLoad flag.
              (WebCore::FrameLoader::isLocationChange): Added case for formSubmission
              and removed case for locationChangeDuringLoad.
              (WebCore::FrameLoader::redirectionTimerFired): Ditto. Also removed unneeded
              completeURL call and just use KURL constructor to match the other cases.
              (WebCore::FrameLoader::provisionalLoadStarted): Removed the code to set up
              the m_navigationDuringLoad, which is no longer needed. The new version of
              this is in the submitForm function and sets the lockHistory boolean.
              (WebCore::FrameLoader::scheduleRedirection): Moved the code to stop a load
              in here that used to be in scheduleLocationChange.
              (WebCore::FrameLoader::startRedirectionTimer): Added case for formSubmission
              and removed case for locationChangeDuringLoad.
              (WebCore::FrameLoader::stopRedirectionTimer): Ditto.
              (WebCore::FrameLoader::completed): Removed call to now-obsolete function,
              submitFormAgain.
              (WebCore::FrameLoader::loadFrameRequest): Renamed from
              loadFrameRequestWithFormAndValues. Replaced form element and form values
              argument with a single FormState argument. Changed frame targeting code
              to use the source frame in the case of a form submission to better match
              the actual target frame.
              (WebCore::FrameLoader::loadURL): Don't search for existing frames in the
              form submission case since we already did that in the submitForm function.
              (WebCore::FrameLoader::clientRedirected): Changed to work with the
              m_isExecutingJavaScriptFormAction data member directly instead of taking
              it as a function parameter.
              (WebCore::FrameLoader::loadPostRequest): Don't search for existing frames
              in the form submission case since we already did that in the submitForm
              function.
              (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Moved comment
              in here that was misplaced elsewhere in the file.
              (WebCore::FrameLoader::findFrameForNavigation): Changed to use the early
              return idiom.
              (WebCore::FrameLoader::recursiveGoToItem): Updated for HistoryItem changes.
              (WebCore::FrameLoader::childFramesMatchItem): Ditto.
              (WebCore::FrameLoader::updateHistoryForStandardLoad): Removed the
              m_navigationDuringLoad logic; that's now handled by setting lockHistory
              to true in the submitForm function.
              (WebCore::FrameLoader::updateHistoryForRedirectWithLockedBackForwardList):
              Use the new setChildItem function so we don't get multiple items for the
              same frame name in the history item tree in the back/forward list.
      
              * loader/FrameLoader.h: Renamed loadFrameRequestWithFormAndValues to
              loadFrameRequest and made it take a form state object instead of the
              form element and form values. Removed the unused functions
              loadEmptyDocumentSynchronously, provisionalDocumentLoader,
              notifyIconChnaged, and updateBaseURLForEmptyDocument. Changed the
              submitForm function to take a form state argument. Eliminated the
              clearRecordedFormValues, setFormAboutToBeSubmitted, and recordFormValue
              functions, which are replaced by the form state arguments to submitForm
              and loadFrameRequest. Removed the isJavaScriptFormAction argument from
              the clientRedirected function; instead it looks at a data member directly.
              Eliminated the submitFormAgain and overload of the submitForm function;
              these are now subsumed into the remaining submitForm function and the
              scheduleFormSubmission function. Removed unused and obsolete data
              members m_navigationDuringLoad, m_deferredFormSubmission,
              m_formAboutToBeSubmitted and m_formValuesAboutToBeSubmitted.
      
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::contextMenuItemSelected):
              Updated for name and argument change of loadFrameRequest.
      
              * page/Frame.cpp:
              (WebCore::Frame::~Frame): Removed call to the now-unneeded
              clearRecordedFormValues function.
      
      WebKit/mac:
      
      2009-04-01  Darin Adler  <darin@apple.com>
      
              Reviewed by Geoff Garen.
      
              Bug 22378: Crash submitting a form when parsing an XHTML document
              https://bugs.webkit.org/show_bug.cgi?id=22378
              rdar://problem/6388377
      
              * History/WebHistoryItem.mm:
              (-[WebHistoryItem targetItem]): Call targetItem directly instead of callling
              isTargetItem, hasChildren, and recurseToFindTargetItem.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::dispatchWillSubmitForm): Updated for the new
              textFieldValues function in FormState.
      
              * WebView/WebPDFView.mm:
              (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for name and
              argument change of loadFrameRequest.
      
      WebKit/win:
      
      2009-04-01  Darin Adler  <darin@apple.com>
      
              Reviewed by Geoff Garen.
      
              Bug 22378: Crash submitting a form when parsing an XHTML document
              https://bugs.webkit.org/show_bug.cgi?id=22378
              rdar://problem/6388377
      
              * WebFrame.cpp:
              (WebFrame::dispatchWillSubmitForm): Updated for the new
              textFieldValues function in FormState.
      
      LayoutTests:
      
      2009-04-01  Darin Adler  <darin@apple.com>
      
              Reviewed by Geoff Garen.
      
              Bug 22378: Crash submitting a form when parsing an XHTML document
              https://bugs.webkit.org/show_bug.cgi?id=22378
              rdar://problem/6388377
      
              * fast/loader/onunload-form-submit-crash-2-expected.txt: Updated for change to the test.
              * fast/loader/onunload-form-submit-crash-2.html: Updated test to expect the form submission
              during the onunload handler to be ineffective.
              * fast/loader/onunload-form-submit-crash-expected.txt: Updated for change to the test.
              * fast/loader/onunload-form-submit-crash.html: Updated test to expect the form submission
              during the onunload handler to be ineffective.
      
              * fast/loader/resources/onunload-form-submit-crash2.html: Removed.
              * fast/loader/resources/onunload-form-submit-failure.html: Copied from
              LayoutTests/fast/loader/resources/onunload-form-submit-crash2.html.
              * fast/loader/resources/onunload-form-submit-success.html: Copied from
              LayoutTests/fast/loader/resources/onunload-form-submit-crash2.html.
      
              * fast/loader/resources/submit-form-while-parsing-subframe.html: Added.
              * fast/loader/resources/submit-form-while-parsing-success.html: Added.
              * fast/loader/submit-form-while-parsing-1-expected.txt: Added.
              * fast/loader/submit-form-while-parsing-1.xhtml: Added.
              * fast/loader/submit-form-while-parsing-2-expected.txt: Added.
              * fast/loader/submit-form-while-parsing-2.html: Added.
      
              * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt: Updated
              to expect proper results, without the duplicate history items for the same frame name
              that were present before.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f88bda0
  27. 31 Mar, 2009 1 commit
  28. 27 Mar, 2009 1 commit
    • darin@apple.com's avatar
      2009-03-27 Darin Adler <darin@apple.com> · 4cd1b24d
      darin@apple.com authored
              Reviewed by Sam Weinig.
      
              To prepare for work on a form loading fix, remove some unused functions,
              consolidate some functions, and make many more functions private in
              FrameLoader.
      
              * WebCore.base.exp: Remove some unused entry points, update another.
      
              * dom/Document.cpp:
              (WebCore::Document::detach): Clear m_frame directly instead of using
              clearFramePointer.
              * dom/Document.h: Ditto.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::urlSelected): Consolidate the two functions
              of this name into a single function. Also changed the event argument
              to be PassRefPtr<Event>.
              (WebCore::FrameLoader::submitForm): Changed the event argument to
              be PassRefPtr<Event>.
              (WebCore::FrameLoader::scheduleLocationChange): Call completeURL
              explicitly so we can remove the version of changeLocation that does
              completeURL for us.
              (WebCore::FrameLoader::redirectionTimerFired): Ditto.
              (WebCore::FrameLoader::loadURLIntoChildFrame): Set m_provisionalHistoryItem
              directly so we don't need a setProvisionalHistoryItem function.
              (WebCore::FrameLoader::canCachePageContainingThisFrame): Get at
              m_quickRedirectComing directly so we don't need a isQuickRedirectComing
              function.
              (WebCore::FrameLoader::logCanCacheFrameDecision): Ditto.
              (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Changed the
              event argument to be PassRefPtr<Event>.
              (WebCore::FrameLoader::loadURL): Move the logic of the continueLoadWithData
              function here because this is the only caller. If we want to make the
              resulting function smaller we should refactor some other way. Also
              streamlined the user-chosen encoding logic, but did not change what it does.
              (WebCore::FrameLoader::finishedLoadingDocument): Changed the event argument
              to be PassRefPtr<Event>.
              (WebCore::FrameLoader::loadPostRequest): Ditto.
              (WebCore::FrameLoader::receivedMainResourceError): Moved the logic from
              the didNotOpenURL function here, since this was the only caller.
      
              * loader/FrameLoader.h: Removed include of FormState.h and used a forward
              declaration instead. Removed unneeded forward declation of Element.
              Moved many functions into the private section, and removed some other
              unused or uneeded functions.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cd1b24d
  29. 10 Mar, 2009 1 commit
    • darin@chromium.org's avatar
      2009-03-06 Darin Fisher <darin@chromium.org> · 7b9e861d
      darin@chromium.org authored
              Reviewed by Sam Weinig.
      
              https://bugs.webkit.org/show_bug.cgi?id=24437
      
              Add support for registering noAccess URL schemes:
              1-  Add FrameLoader::registerURLSchemeAsNoAccess, and have SecurityOrigin check
              that list upon construction (similar to how isLocal is implemented).
              2-  Make InspectorController call grantUniversalAccess on its Document's
              SecurityOrigin at the time when windowScriptObjectAvailable is called.
      
              This enables content such as the inspector to be loaded from a custom (non-file)
              URL, which is how Chromium loads the inspector.  It also allows other URL schemes
              to be treated like data: URLs, which Chromium utilizes for its various HTML-based
              UI panels.
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::windowScriptObjectAvailable):
              * loader/FrameLoader.cpp:
              (WebCore::localSchemes):
              (WebCore::noAccessSchemes):
              (WebCore::FrameLoader::loadItem):
              * loader/FrameLoader.h:
              * page/SecurityOrigin.cpp:
              (WebCore::SecurityOrigin::SecurityOrigin):
              (WebCore::SecurityOrigin::isLocal):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b9e861d
  30. 08 Mar, 2009 1 commit
  31. 04 Mar, 2009 1 commit
    • weinig@apple.com's avatar
      2009-03-04 Sam Weinig <sam@webkit.org> · 42c22dbd
      weinig@apple.com authored
              Rubber-stamped by Antti Koivisto.
      
              Remove LOW_BANDWIDTH_DISPLAY as it is not being used by any platforms.
      
              * dom/Document.cpp:
              (WebCore::Document::Document):
              * dom/Document.h:
              (WebCore::Document::haveStylesheetsLoaded):
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::scriptHandler):
              * loader/Cache.cpp:
              (WebCore::Cache::requestResource):
              * loader/CachedCSSStyleSheet.cpp:
              (WebCore::CachedCSSStyleSheet::checkNotify):
              * loader/DocLoader.h:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::FrameLoader):
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::stopLoading):
              (WebCore::FrameLoader::begin):
              (WebCore::FrameLoader::write):
              (WebCore::FrameLoader::endIfNotLoadingMainResource):
              (WebCore::FrameLoader::checkCompleted):
              (WebCore::FrameLoader::requestObject):
              (WebCore::FrameLoader::loadItem):
              * loader/FrameLoader.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42c22dbd
  32. 11 Feb, 2009 1 commit
    • beidson@apple.com's avatar
      2009-02-11 Brady Eidson <beidson@apple.com> · 028c7a74
      beidson@apple.com authored
              Reviewed by Darin Adler
      
              <rdar://problem/3541409> - Further FrameLoader and page cache cleanup
      
              * history/CachedFrame.cpp:
              (WebCore::CachedFrame::restore): Moved updatePlatformScriptObjects() here.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::commitProvisionalLoad): Rolled opened() into this method.  This method was
                the only caller and - in the future - will benefit from doing parts of opened()'s work differently.
              (WebCore::FrameLoader::open): Split off per-frame logic into open(CachedFrame&) method.
              (WebCore::FrameLoader::closeAndRemoveChild): Added.  Do the non-tree related cleanup that
                FrameTree::removeChild() used to do.
              (WebCore::FrameLoader::detachFromParent): Call ::closeAndRemoveChild() instead.
              (WebCore::FrameLoader::cachePageForHistoryItem): Perform the "can cache page" check here.
              * loader/FrameLoader.h:
      
              * page/FrameTree.cpp:
              (WebCore::FrameTree::removeChild): Just remove the Frame from the tree.  Closing it and other
                cleanup is the responsibility of the FrameLoader.
              * page/FrameTree.h:
              (WebCore::FrameTree::detachFromParent): Added to just clear a Frame's parent pointer
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      028c7a74
  33. 06 Feb, 2009 1 commit
    • ggaren@apple.com's avatar
      WebCore: · 858c1b45
      ggaren@apple.com authored
      2009-02-06  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Part III of <rdar://problem/6552272>.
              
              Make redirect data available to WebKit. (I tried having WebKit track this
              data for itself, but that went wrong -- it's just too hard to figure
              out the weird corners of the WebCore loader from within another framework.)
      
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::DocumentLoader):
              * loader/DocumentLoader.h: Store a flag indicating whether we created
              a global history entry. If we didn't, then we know that the next redirect
              should not link to us, since we're not in history.
              
              (WebCore::DocumentLoader::clientRedirectSourceForHistory):
              (WebCore::DocumentLoader::clientRedirectDestinationForHistory):
              (WebCore::DocumentLoader::setClientRedirectSourceForHistory):
              (WebCore::DocumentLoader::serverRedirectSourceForHistory):
              (WebCore::DocumentLoader::serverRedirectDestinationForHistory):
              (WebCore::DocumentLoader::didCreateGlobalHistoryEntry):
              (WebCore::DocumentLoader::setDidCreateGlobalHistoryEntry): Added accessors
              to help WebKit wade through the muck of WebCore history.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryRedirectLinks): Renamed
              this client function to say what it does, instead of when it's called.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::load):
              (WebCore::FrameLoader::loadWithNavigationAction): In the case of a redirect,
              store a link to the previous history URL in the new DocumentLoader, so
              it can update WebKit with that link when the load commits.
      
              (WebCore::FrameLoader::updateHistory*): Use our new flags and names,
              described above.
      
              * loader/FrameLoader.h:
              (WebCore::FrameLoader::documentLoader):
              (WebCore::FrameLoader::policyDocumentLoader):
              (WebCore::FrameLoader::provisionalDocumentLoader):
              (WebCore::FrameLoader::state): Inlined a few trivial functions because
              performance mistakes give me the itches.
              
              * loader/FrameLoaderClient.h: Renamed this client function to say what
              it does, instead of when it's called.
      
      WebKit/mac:
      
      2009-02-06  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Part III of <rdar://problem/6552272>.
              
              Refactored to use the redirect data WebCore makes available, instead of
              tracking loading state in WebKit.
              
              * History/WebHistory.mm:
              (-[WebHistoryPrivate dealloc]):
              (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
              (-[WebHistory _visitedURLForRedirectWithoutHistoryItem:]):
              * History/WebHistoryInternal.h:
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::updateGlobalHistory):
              (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
      
      WebKit/win:
      
      2009-02-06  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Part III of <rdar://problem/6552272>.
              
              Refactored to use the redirect data WebCore makes available, instead of
              tracking loading state in WebKit.
              
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::updateGlobalHistory):
              (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebHistory.cpp:
              (WebHistory::visitedURL):
              * WebHistory.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      858c1b45
  34. 05 Feb, 2009 1 commit
    • dglazkov@chromium.org's avatar
      WebCore: · f6fd3217
      dglazkov@chromium.org authored
      2009-02-05  Aaron Boodman  <aa@chromium.org>
      
              Reviewed by Dave Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=23708
              Adds documentElementAvailable() callback to FrameLoaderClient.
      
              * dom/XMLTokenizerLibxml2.cpp:
              (WebCore::XMLTokenizer::startElementNs):
              Add call to dispatchDocumentElementAvailable()
              * dom/XMLTokenizerQt.cpp:
              (WebCore::XMLTokenizer::parseStartElement):
              Ditto.
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::insertNode):
              Ditto.
              * loader/EmptyClients.h:
              (WebCore::EmptyFrameLoaderClient::documentElementAvailable):
              Stub out documentElementAvailable().
              * loader/FrameLoader.cpp:
              documentElementAvailable() callback plumbing.
              * loader/FrameLoader.h:
              Ditto.
              * loader/FrameLoaderClient.h:
              Add new documentElementAvailable() callback.
      
      WebKit/gtk:
      
      2009-02-05  Aaron Boodman <aa@chromium.org>
      
              Reviewed by Dave Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=23708
              Adds documentElementAvailable() callback to FrameLoaderClient.
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::documentElementAvailable):
              Stub out documentElementAvailable()
              * WebCoreSupport/FrameLoaderClientGtk.h:
              Ditto.
      
      WebKit/mac:
      
      2009-02-05  Aaron Boodman  <aa@chromium.org>
      
              Reviewed by Dave Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=23708
              Adds documentElementAvailable() callback to FrameLoaderClient.
      
              * WebCoreSupport/WebFrameLoaderClient.h:
              Stub out documentElementAvailable().
              * WebCoreSupport/WebFrameLoaderClient.mm:
              Ditto.
      
      WebKit/qt:
      
      2009-02-05  Aaron Boodman  <aa@chromium.org>
      
              Reviewed by Dave Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=23708
              Adds documentElementAvailable() callback to FrameLoaderClient.
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClient::documentElementAvailable):
              Stub out documentElementAvailable().
              * WebCoreSupport/FrameLoaderClientQt.h:
              Ditto.
      
      WebKit/win:
      
      2009-02-05  Aaron Boodman  <aa@chromium.org>
      
              Reviewed by Dave Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=23708
              Adds documentElementAvailable() callback to FrameLoaderClient.
      
              * WebFrame.cpp:
              (WebFrame::documentElementAvailable):
              Stub out documentElementAvailable()
              * WebFrame.h:
              Ditto.
      
      WebKit/wx:
      
      2009-02-05  Aaron Boodman  <aa@chromium.org>
      
              Reviewed by Dave Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=23708
              Adds documentElementAvailable() callback to FrameLoaderClient.
      
              * WebKitSupport/FrameLoaderClientWx.cpp:
              (WebCore::FrameLoaderClientWx::documentElementAvailable):
              Stub out documentElementAvailable().
              * WebKitSupport/FrameLoaderClientWx.h:
              Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6fd3217
  35. 02 Feb, 2009 1 commit
    • ggaren@apple.com's avatar
      WebCore: · b6b2bfc9
      ggaren@apple.com authored
      2009-02-02  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Track redirects in global history.
      
              * WebCore.base.exp: Renamed some exports.
              
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::createWindow):
              (windowProtoFuncOpen):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setLocation):
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::setLocation):
              * bindings/js/JSHTMLFormElementCustom.cpp:
              (WebCore::JSHTMLFormElement::submit):
              * bindings/js/JSLocationCustom.cpp:
              (WebCore::JSLocation::setHref):
              (WebCore::JSLocation::setProtocol):
              (WebCore::JSLocation::setHost):
              (WebCore::JSLocation::setHostname):
              (WebCore::JSLocation::setPort):
              (WebCore::JSLocation::setPathname):
              (WebCore::JSLocation::setSearch):
              (WebCore::JSLocation::setHash):
              (WebCore::JSLocation::assign): Treat any navigation that is not initiated
              by the user as a redirect from the perspective of global history.
      
              * history/HistoryItem.cpp:
              (WebCore::HistoryItem::addRedirectURL): Store the last URL in the redirect
              chain.
      
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::DocumentLoader):
              * loader/DocumentLoader.h:
              (WebCore::DocumentLoader::urlForHistoryReflectsServerRedirect):
              (WebCore::DocumentLoader::urlForHistoryReflectsClientRedirect):
              (WebCore::DocumentLoader::setURLForHistoryReflectsClientRedirect): Sadly,
              added yet another way to track redirect state during loading, since none
              of the others did what I wanted, and I didn't want to cause behavior
              changes in existing code.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
              Stubbed out a client function to keep things building.
              
              * loader/FrameLoader.cpp:
              (WebCore::isBackForwardLoadType):
              (WebCore::FrameLoader::restoreDocumentState): Renamed FrameLoadTypeRedirect =>
              FrameLoadTypeRedirectWithLockedBackForwardList, to distinguish from all
              the other meanings of "redirect" in the loading code.
      
              (WebCore::FrameLoader::scheduleHTTPRedirection): Treat any HTTP refresh
              redirect as a redirect from the perspective of global history.
      
              (WebCore::FrameLoader::loadURLIntoChildFrame): Updated for rename and extra
              parameter.
      
              (WebCore::FrameLoader::startRedirectionTimer): Removed unused parameter.
      
              (WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
              (WebCore::FrameLoader::loadURL):
              (WebCore::FrameLoader::load): Updated for rename and extra parameter.
      
              (WebCore::FrameLoader::loadWithNavigationAction): Track redirect status
              in the DocumentLoader, so it's accessible to WebKit's global history code.
      
              (WebCore::FrameLoader::clientRedirected): Ignore lockHistory, since it
              only has meaning to global history, and m_quickRedirectComing pertains
              to other kinds of history.
      
              (WebCore::FrameLoader::loadPostRequest):
              (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
              (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
              (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
              (WebCore::FrameLoader::loadItem): Updated for extra parameter and rename.
              
              (WebCore::FrameLoader::updateHistory*): Notify WebKit about redirect
              navigations even if they don't create new history items, so we can track
              the redirect in the existing history item.
      
              * loader/FrameLoader.h: See above.
              
              * loader/FrameLoaderClient.h: New client interface used by
              FrameLoader::updateHistory* to record a redirect even if it doesn't create
              a new history item of its own.
      
              * loader/FrameLoaderTypes.h: See above.
              (WebCore::):
      
              * page/DragController.cpp:
              (WebCore::DragController::performDrag):
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::dataChanged): Updated for extra parameter.
      
      WebKit/gtk:
      
      2009-02-02  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
              
              Track redirects in global history.
      
              Keep GTK building.
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::createFrame):
              (WebKit::FrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
              * WebCoreSupport/FrameLoaderClientGtk.h:
      
      WebKit/mac:
      
      2009-02-02  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Track redirects in global history.
      
              * History/WebHistory.mm:
              (-[WebHistoryPrivate dealloc]):
              (-[WebHistoryPrivate lastVisitedEntry]):
              (-[WebHistoryPrivate setLastVisitedEntry:]): Remember the last global history
              entry in case we're asked to add redirect information to it later.
      
              (-[WebHistory _visitedURL:withTitle:method:wasFailure:serverRedirectURL:isClientRedirect:]):
              (-[WebHistory _visitedURLForRedirectWithoutHistoryItem:]): Record redirect
              information in global history.
      
              * History/WebHistoryInternal.h:
              * WebCoreSupport/WebFrameLoaderClient.h: See above and below.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::updateGlobalHistory):
              (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Record redirect
              information in global history.
      
              * WebView/WebFrame.mm:
              (-[WebFrame loadRequest:]):
              (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
              * WebView/WebFramePrivate.h: Updated for rename and extra parameter.
      
      WebKit/qt:
      
      2009-02-02  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Track redirects in global history.
      
              Keep Qt building.
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::updateGlobalHistoryForRedirectWithoutHistoryItem):
              (WebCore::FrameLoaderClientQt::createFrame):
              * WebCoreSupport/FrameLoaderClientQt.h:
      
      WebKit/win:
      
      2009-02-02  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Track redirects in global history.
      
              * Interfaces/IWebFramePrivate.idl: Updated for WebCore rename.
      
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::updateGlobalHistory):
              (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
              Store redirect information in global history.
      
              (WebFrameLoaderClient::loadURLIntoChild): Updated for extra parameter.
      
              * WebCoreSupport/WebFrameLoaderClient.h: See above.
      
              * WebFrame.cpp:
              (WebFrame::loadRequest):
              (WebFrame::loadData): Updated for extra parameter.
      
              * WebHistory.cpp:
              (WebHistory::visitedURL):
              (WebHistory::visitedURLForRedirectWithoutHistoryItem): Store redirect
              information in global history.
      
              * WebHistory.h: See above.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6b2bfc9