1. 15 Nov, 2013 17 commits
    • timothy_horton@apple.com's avatar
      Layout Test editing/selection/5057506.html frequently times out on Mac WK2 · 6fec6783
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124437
      
      * platform/mac-wk2/TestExpectations:
      Mark aforementioned test as a flaky-timeout.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fec6783
    • achicu@adobe.com's avatar
      Web Inspector: DOM.performSearch should accept a list of context nodes · 1aa38677
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124390
      
      Reviewed by Timothy Hatcher.
      
      Source/WebCore:
      
      Extracted the code in InspectorDOMAgent::performSearch into its own helper class
      called InspectorNodeFinder. Also added a new array parameter called "nodeIds"
      that can be used to limit the search results to just partial subtrees.
      
      Tests: inspector-protocol/dom/dom-search-crash.html
             inspector-protocol/dom/dom-search-with-context.html
             inspector-protocol/dom/dom-search.html
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * inspector/protocol/DOM.json:
      * inspector/InspectorAllInOne.cpp:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::performSearch):
      * inspector/InspectorDOMAgent.h:
      * inspector/InspectorNodeFinder.cpp: Added.
      (WebCore::stripCharacters):
      (WebCore::InspectorNodeFinder::InspectorNodeFinder):
      (WebCore::InspectorNodeFinder::performSearch):
      (WebCore::InspectorNodeFinder::searchUsingDOMTreeTraversal):
      (WebCore::InspectorNodeFinder::matchesAttribute):
      (WebCore::InspectorNodeFinder::matchesElement):
      (WebCore::InspectorNodeFinder::searchUsingXPath):
      (WebCore::InspectorNodeFinder::searchUsingCSSSelectors):
      * inspector/InspectorNodeFinder.h: Added.
      (WebCore::InspectorNodeFinder::results):
      
      LayoutTests:
      
      Added new inspector-protocol tests to check for the DOM.performSearch implementation.
      Also, ported an existing test from the old "inspector" format.
      
      * http/tests/inspector-protocol/resources/InspectorDOMListener.js: Added boilerplate code that
      can be used to track node ids and class names.
      (createDOMListener.createNodeAttributesMap):
      (createDOMListener.collectNode):
      (createDOMListener.onSetChildNodes):
      (createDOMListener.onChildNodeRemoved):
      (createDOMListener.onChildNodeInserted):
      (createDOMListener.return.getNodeById):
      (createDOMListener.return.getNodeIdentifier):
      * http/tests/inspector-protocol/resources/InspectorTest.js:
      (InspectorFrontendAPI.dispatchMessageAsync): Added a way to catch all the messages received in the inspector.
      It is useful for debugging the test file.
      (InspectorTest.addEventListener): Helper method to register multiple handlers for the same event.
      * inspector-protocol/dom/dom-search-crash-expected.txt: Added.
      * inspector-protocol/dom/dom-search-crash.html: Added.
      * inspector-protocol/dom/dom-search-expected.txt: Added.
      * inspector-protocol/dom/dom-search-with-context-expected.txt: Added.
      * inspector-protocol/dom/dom-search-with-context.html: Added.
      * inspector-protocol/dom/dom-search.html: Added.
      * inspector-protocol/dom/resources/dom-search-crash-iframe.html: Cloned from inspector/dom/resources/dom-search-crash-iframe.html
      * inspector-protocol/dom/resources/dom-search-iframe.html: Added.
      * inspector-protocol/dom/resources/dom-search-queries.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1aa38677
    • timothy_horton@apple.com's avatar
      Make lint-test-expectations pass for platform/win · 7e740e9f
      timothy_horton@apple.com authored
      * platform/win/TestExpectations:
      I always kept the stronger expectation in the case of duplicates.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e740e9f
    • timothy_horton@apple.com's avatar
      Layout Test fast/dom/Geolocation/notimer-after-unload.html is flaky and crashy on Mac WK2 · 53227d60
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124425
      
      * platform/mac-wk2/TestExpectations:
      Mark as crash/pass/fail, since it does all three :(
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53227d60
    • commit-queue@webkit.org's avatar
      Modifying RTCIceCandidate object construction to match the spec · a1366a09
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124369
      
      Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-15
      Reviewed by Eric Carlson.
      
      According to the spec the RTCIceCandidateInit parameter in RTCSessionDescription constructor is optional,
      which must not be nullable, and, if passed, must be a valid Dictionary. If the keys are not present, the string
      object that stores them in the RTCIceCandidate class, must be null in those cases. Also, if a key is present
      and its value is not valid an exception must be raised.
      
      Source/WebCore:
      
      Existing test was updated.
      
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCIceCandidate.cpp:
      (WebCore::RTCIceCandidate::create):
      * Modules/mediastream/RTCIceCandidate.idl:
      * UseJSC.cmake:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSRTCIceCandidateCustom.cpp: Added.
      (WebCore::JSRTCIceCandidateConstructor::constructJSRTCIceCandidate):
      
      LayoutTests:
      
      * fast/mediastream/RTCIceCandidate-expected.txt:
      * fast/mediastream/RTCIceCandidate.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1366a09
    • timothy_horton@apple.com's avatar
      Layout Test webgl/1.0.2/conformance/ogles/GL/tan/tan_001_to_006.html fails on Intel · 38f1f6b2
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124424
      
      * platform/mac/TestExpectations:
      Mark as flaky everywhere, since I have no way to mark it as failing on Intel
      and passing elsewhere.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38f1f6b2
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r159337. · 37afb394
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/159337
      https://bugs.webkit.org/show_bug.cgi?id=124423
      
      broke a bunch of fast/regions tests on EFL/GTK (Requested by
      philn on #webkit).
      
      Source/WebCore:
      
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::setLayoutOverflow):
      (WebCore::InlineFlowBox::setVisualOverflow):
      * rendering/InlineFlowBox.h:
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::addOverflowFromChildren):
      (WebCore::RenderBlock::paint):
      (WebCore::RenderBlock::paintObject):
      (WebCore::RenderBlock::estimateRegionRangeForBoxChild):
      (WebCore::RenderBlock::updateRegionRangeForBoxChild):
      * rendering/RenderBlockFlow.cpp:
      (WebCore::RenderBlockFlow::hasNextPage):
      (WebCore::RenderBlockFlow::relayoutForPagination):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlockFlow::positionNewFloatOnLine):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::borderBoxRectInRegion):
      (WebCore::RenderBox::computeRectForRepaint):
      (WebCore::RenderBox::addLayoutOverflow):
      (WebCore::RenderBox::addVisualOverflow):
      (WebCore::RenderBox::isUnsplittableForPagination):
      (WebCore::RenderBox::overflowRectForPaintRejection):
      * rendering/RenderBox.h:
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::paintFillLayerExtended):
      * rendering/RenderBoxModelObject.h:
      * rendering/RenderBoxRegionInfo.h:
      (WebCore::RenderBoxRegionInfo::createOverflow):
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
      (WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):
      (WebCore::RenderFlowThread::checkRegionsWithStyling):
      (WebCore::RenderFlowThread::mapFromLocalToFlowThread):
      (WebCore::RenderFlowThread::mapFromFlowThreadToLocal):
      (WebCore::RenderFlowThread::addRegionsOverflowFromChild):
      (WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
      * rendering/RenderFlowThread.h:
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::updateLayerPositions):
      (WebCore::expandClipRectForDescendantsAndReflection):
      (WebCore::RenderLayer::paintLayer):
      (WebCore::RenderLayer::paintLayerContents):
      (WebCore::RenderLayer::updatePaintingInfoForFragments):
      (WebCore::RenderLayer::paintForegroundForFragments):
      (WebCore::RenderLayer::hitTest):
      (WebCore::RenderLayer::hitTestLayer):
      (WebCore::RenderLayer::calculateClipRects):
      (WebCore::RenderLayer::parentClipRects):
      (WebCore::RenderLayer::calculateRects):
      (WebCore::RenderLayer::intersectsDamageRect):
      (WebCore::RenderLayer::repaintIncludingDescendants):
      * rendering/RenderLayer.h:
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::computeCompositingRequirements):
      * rendering/RenderListItem.cpp:
      (WebCore::RenderListItem::addOverflowFromChildren):
      * rendering/RenderMultiColumnSet.cpp:
      (WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
      (WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
      * rendering/RenderMultiColumnSet.h:
      * rendering/RenderNamedFlowFragment.cpp:
      (WebCore::RenderNamedFlowFragment::createStyle):
      * rendering/RenderNamedFlowFragment.h:
      * rendering/RenderOverflow.h:
      * rendering/RenderRegion.cpp:
      (WebCore::RenderRegion::flowThreadPortionOverflowRect):
      (WebCore::RenderRegion::overflowRectForFlowThreadPortion):
      (WebCore::shouldPaintRegionContentsInPhase):
      (WebCore::RenderRegion::paintObject):
      (WebCore::RenderRegion::hitTestContents):
      (WebCore::RenderRegion::computeOverflowFromFlowThread):
      (WebCore::RenderRegion::repaintFlowThreadContent):
      (WebCore::RenderRegion::repaintFlowThreadContentRectangle):
      (WebCore::RenderRegion::insertedIntoTree):
      (WebCore::RenderRegion::ensureOverflowForBox):
      (WebCore::RenderRegion::rectFlowPortionForBox):
      (WebCore::RenderRegion::addLayoutOverflowForBox):
      (WebCore::RenderRegion::addVisualOverflowForBox):
      (WebCore::RenderRegion::layoutOverflowRectForBox):
      (WebCore::RenderRegion::visualOverflowRectForBox):
      (WebCore::RenderRegion::visualOverflowRectForBoxForPropagation):
      * rendering/RenderRegion.h:
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::shouldPaint):
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::paint):
      
      LayoutTests:
      
      * fast/regions/bottom-overflow-out-of-first-region-expected.html:
      * fast/regions/bottom-overflow-out-of-first-region.html:
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html:
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html:
      * fast/regions/element-in-named-flow-absolute-from-fixed-expected.txt:
      * fast/regions/element-in-named-flow-fixed-from-absolute-expected.txt:
      * fast/regions/element-inflow-fixed-from-outflow-static-expected.txt:
      * fast/regions/element-outflow-static-from-inflow-fixed-expected.txt:
      * fast/regions/float-pushed-width-change-2-expected.html:
      * fast/regions/float-pushed-width-change-2.html:
      * fast/regions/float-pushed-width-change-expected.html:
      * fast/regions/float-pushed-width-change.html:
      * fast/regions/layers/dynamic-layer-added-with-no-layout-expected.txt: Removed.
      * fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.txt: Removed.
      * fast/regions/layers/regions-promoted-to-layers-expected.txt: Removed.
      * fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.txt: Removed.
      * fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.txt: Removed.
      * fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.txt: Removed.
      * fast/regions/outline-sides-in-region-expected.html:
      * fast/regions/outline-sides-in-region.html:
      * fast/regions/overflow-first-and-last-regions-expected.html: Removed.
      * fast/regions/overflow-first-and-last-regions-in-container-hidden-expected.html: Removed.
      * fast/regions/overflow-first-and-last-regions-in-container-hidden.html: Removed.
      * fast/regions/overflow-first-and-last-regions.html: Removed.
      * fast/regions/overflow-last-region-expected.html: Added.
      * fast/regions/overflow-last-region.html: Added.
      * fast/regions/overflow-nested-regions-expected.html: Removed.
      * fast/regions/overflow-nested-regions.html: Removed.
      * fast/regions/overflow-region-float-expected.html: Removed.
      * fast/regions/overflow-region-float.html: Removed.
      * fast/regions/overflow-region-inline-expected.html: Removed.
      * fast/regions/overflow-region-inline.html: Removed.
      * fast/regions/overflow-region-transform-expected.html: Removed.
      * fast/regions/overflow-region-transform.html: Removed.
      * fast/regions/overflow-scrollable-rotated-fragment-expected.html:
      * fast/regions/overflow-scrollable-rotated-fragment.html:
      * fast/regions/top-overflow-out-of-second-region-expected.html: Removed.
      * fast/regions/top-overflow-out-of-second-region.html:
      * fast/regions/webkit-flow-float-unable-to-push-expected.html:
      * fast/regions/webkit-flow-float-unable-to-push.html:
      * fast/repaint/increasing-region-content-height-expected.txt:
      * fast/repaint/increasing-region-content-height.html:
      * platform/gtk/fast/regions/text-region-split-vertical-rl-expected.txt: Added.
      * platform/mac-wk2/TestExpectations:
      * platform/mac/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
      * platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37afb394
    • antti@apple.com's avatar
      Hovering over text using simple line path should not cause switch to line boxes · 52e1a9f3
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124418
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Test: fast/text/simple-lines-hover.html
      
      * rendering/RenderText.cpp:
      (WebCore::RenderText::absoluteRects):
      (WebCore::RenderText::absoluteQuadsClippedToEllipsis):
      (WebCore::RenderText::absoluteQuads):
              
          Collect quads and rects directly from simple lines without requiring the line box switch.
      
      * rendering/SimpleLineLayoutFunctions.cpp:
      (WebCore::SimpleLineLayout::collectTextAbsoluteRects):
      (WebCore::SimpleLineLayout::collectTextAbsoluteQuads):
              
          Add these.
      
      * rendering/SimpleLineLayoutFunctions.h:
      * rendering/SimpleLineLayoutResolver.h:
      (WebCore::SimpleLineLayout::RunResolver::Run::start):
      (WebCore::SimpleLineLayout::RunResolver::Run::end):
              
          For future use.
      
      LayoutTests: 
      
      * fast/text/simple-lines-hover-expected.html: Added.
      * fast/text/simple-lines-hover.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52e1a9f3
    • zoltan@webkit.org's avatar
      [CSS Shapes][CSS Regions] Simplify shape-inside-on-multiple-regions-with-negative-shape-top.html · 17aa01ca
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123808
      
      Reviewed by Mihnea Ovidenie.
      
      Use a rectangle instead of a complex polygon in the test.
      
      * fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top-expected.html:
      * fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17aa01ca
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 0ae08b42
      m.pakula@samsung.com authored
      Add failure test expectations for failing tests.
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ae08b42
    • timothy_horton@apple.com's avatar
      results.html should have a link to historical results for a test/all failing tests · e1ccad9e
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124402
      
      Reviewed by Simon Fraser.
      
      * fast/harness/results.html:
      Add a new rightmost column, 'history'.
      Clicking on the column header will open the flakiness dashboard
      for the entire set of failing tests; clicking on the link
      in a particular test's row will open it just for that single test.
      
      * fast/harness/resources/results-test.js:
      Update the harness test to expect the new number of columns.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1ccad9e
    • stavila@adobe.com's avatar
      [CSS Regions] Implement visual overflow for first & last regions · 81613fc9
      stavila@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118665
      
      Source/WebCore:
      
      In order to properly propagate the visual overflow of elements flowed inside regions,
      the responsiblity of painting and hit-testing content inside flow threads has been
      moved to the flow thread layer's level.
      Each region keeps the associated overflow with each box in the RenderBoxRegionInfo
      structure, including one for the flow thread itself. This data is used during
      painting and hit-testing.
      
      Reviewed by David Hyatt.
      
      Tests: fast/regions/overflow-first-and-last-regions-in-container-hidden.html
             fast/regions/overflow-first-and-last-regions.html
             fast/regions/overflow-nested-regions.html
             fast/regions/overflow-region-float.html
             fast/regions/overflow-region-inline.html
             fast/regions/overflow-region-transform.html
      
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::setLayoutOverflow):
      (WebCore::InlineFlowBox::setVisualOverflow):
      * rendering/InlineFlowBox.h:
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::addOverflowFromChildren):
      (WebCore::RenderBlock::paint):
      (WebCore::RenderBlock::paintObject):
      (WebCore::RenderBlock::estimateRegionRangeForBoxChild):
      (WebCore::RenderBlock::updateRegionRangeForBoxChild):
      * rendering/RenderBlockFlow.cpp:
      (WebCore::RenderBlockFlow::hasNextPage):
      (WebCore::RenderBlockFlow::relayoutForPagination):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlockFlow::positionNewFloatOnLine):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::borderBoxRectInRegion):
      (WebCore::RenderBox::computeRectForRepaint):
      (WebCore::RenderBox::addLayoutOverflow):
      (WebCore::RenderBox::addVisualOverflow):
      (WebCore::RenderBox::isUnsplittableForPagination):
      (WebCore::RenderBox::overflowRectForPaintRejection):
      * rendering/RenderBox.h:
      (WebCore::RenderBox::canHaveOutsideRegionRange):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
      (WebCore::RenderBoxModelObject::paintFillLayerExtended):
      * rendering/RenderBoxModelObject.h:
      * rendering/RenderBoxRegionInfo.h:
      (WebCore::RenderBoxRegionInfo::createOverflow):
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::objectShouldPaintInFlowRegion):
      (WebCore::RenderFlowThread::mapFromLocalToFlowThread):
      (WebCore::RenderFlowThread::mapFromFlowThreadToLocal):
      (WebCore::RenderFlowThread::decorationsClipRectForBoxInRegion):
      (WebCore::RenderFlowThread::flipForWritingModeLocalCoordinates):
      (WebCore::RenderFlowThread::addRegionsOverflowFromChild):
      (WebCore::RenderFlowThread::addRegionsVisualOverflow):
      (WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
      * rendering/RenderFlowThread.h:
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::updateLayerPositions):
      (WebCore::expandClipRectForRegionAndReflection):
      (WebCore::expandClipRectForDescendantsAndReflection):
      (WebCore::RenderLayer::paintLayer):
      (WebCore::RenderLayer::paintLayerContents):
      (WebCore::RenderLayer::updatePaintingInfoForFragments):
      (WebCore::RenderLayer::paintForegroundForFragments):
      (WebCore::RenderLayer::hitTest):
      (WebCore::RenderLayer::hitTestLayer):
      (WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
      (WebCore::RenderLayer::calculateClipRects):
      (WebCore::RenderLayer::parentClipRects):
      (WebCore::RenderLayer::calculateRects):
      (WebCore::RenderLayer::intersectsDamageRect):
      (WebCore::RenderLayer::updateDescendantsLayerListsIfNeeded):
      (WebCore::RenderLayer::repaintIncludingDescendants):
      (WebCore::RenderLayer::paintNamedFlowThreadInsideRegion):
      (WebCore::RenderLayer::paintFlowThreadIfRegion):
      (WebCore::RenderLayer::hitTestFlowThreadIfRegion):
      * rendering/RenderLayer.h:
      (WebCore::ClipRect::inflateX):
      (WebCore::ClipRect::inflateY):
      (WebCore::ClipRect::inflate):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::computeCompositingRequirements):
      * rendering/RenderListItem.cpp:
      (WebCore::RenderListItem::addOverflowFromChildren):
      * rendering/RenderMultiColumnSet.cpp:
      (WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
      (WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
      * rendering/RenderMultiColumnSet.h:
      * rendering/RenderNamedFlowFragment.cpp:
      (WebCore::RenderNamedFlowFragment::createStyle):
      (WebCore::RenderNamedFlowFragment::namedFlowThread):
      * rendering/RenderNamedFlowFragment.h:
      * rendering/RenderOverflow.h:
      * rendering/RenderRegion.cpp:
      (WebCore::RenderRegion::flowThreadPortionOverflowRect):
      (WebCore::RenderRegion::flowThreadPortionLocation):
      (WebCore::RenderRegion::regionContainerLayer):
      (WebCore::RenderRegion::overflowRectForFlowThreadPortion):
      (WebCore::RenderRegion::computeOverflowFromFlowThread):
      (WebCore::RenderRegion::repaintFlowThreadContent):
      (WebCore::RenderRegion::repaintFlowThreadContentRectangle):
      (WebCore::RenderRegion::insertedIntoTree):
      (WebCore::RenderRegion::ensureOverflowForBox):
      (WebCore::RenderRegion::rectFlowPortionForBox):
      (WebCore::RenderRegion::addLayoutOverflowForBox):
      (WebCore::RenderRegion::addVisualOverflowForBox):
      (WebCore::RenderRegion::layoutOverflowRectForBox):
      (WebCore::RenderRegion::visualOverflowRectForBox):
      (WebCore::RenderRegion::visualOverflowRectForBoxForPropagation):
      * rendering/RenderRegion.h:
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::shouldPaint):
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::paint):
      
      LayoutTests:
      
      Rebased some tests due to regions layers changes.
      Updated some tests to increase clarity. Some of them were only passing because two
      regions were close together and the fact that an element was being painted
      inside the wrong region was not visible. Floats are now also unsplittable.
              - bottom-overflow-out-of-first-region
              - float-pushed-width-change-2
              - float-pushed-width-change
              - webkit-flow-float-unable-to-push
      
      Changed top-overflow-out-of-second-region to reftest.
      
      Added new tests for testing the visual overflow in different situations
      (transformed, inline, opacity, floating).
      
      Reviewed by David Hyatt.
      
      * fast/regions/bottom-overflow-out-of-first-region-expected.html:
      * fast/regions/bottom-overflow-out-of-first-region.html:
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html:
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html:
      * fast/regions/element-in-named-flow-absolute-from-fixed-expected.txt:
      * fast/regions/element-in-named-flow-fixed-from-absolute-expected.txt:
      * fast/regions/element-inflow-fixed-from-outflow-static-expected.txt:
      * fast/regions/element-outflow-static-from-inflow-fixed-expected.txt:
      * fast/regions/float-pushed-width-change-2-expected.html:
      * fast/regions/float-pushed-width-change-2.html:
      * fast/regions/float-pushed-width-change-expected.html:
      * fast/regions/float-pushed-width-change.html:
      * fast/regions/layers/dynamic-layer-added-with-no-layout-expected.txt: Added.
      * fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.txt: Added.
      * fast/regions/layers/regions-promoted-to-layers-expected.txt: Added.
      * fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.txt: Added.
      * fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.txt: Added.
      * fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.txt: Added.
      * fast/regions/outline-sides-in-region-expected.html:
      * fast/regions/outline-sides-in-region.html:
      * fast/regions/overflow-first-and-last-regions-expected.html: Added.
      * fast/regions/overflow-first-and-last-regions-in-container-hidden-expected.html: Added.
      * fast/regions/overflow-first-and-last-regions-in-container-hidden.html: Added.
      * fast/regions/overflow-first-and-last-regions.html: Added.
      * fast/regions/overflow-last-region-expected.html: Removed.
      * fast/regions/overflow-last-region.html: Removed.
      * fast/regions/overflow-nested-regions-expected.html: Added.
      * fast/regions/overflow-nested-regions.html: Added.
      * fast/regions/overflow-region-float-expected.html: Added.
      * fast/regions/overflow-region-float.html: Added.
      * fast/regions/overflow-region-inline-expected.html: Added.
      * fast/regions/overflow-region-inline.html: Added.
      * fast/regions/overflow-region-transform-expected.html: Added.
      * fast/regions/overflow-region-transform.html: Added.
      * fast/regions/overflow-scrollable-rotated-fragment-expected.html:
      * fast/regions/overflow-scrollable-rotated-fragment.html:
      * fast/regions/top-overflow-out-of-second-region-expected.html: Copied from LayoutTests/fast/regions/top-overflow-out-of-second-region.html.
      * fast/regions/top-overflow-out-of-second-region.html:
      * fast/regions/webkit-flow-float-unable-to-push-expected.html:
      * fast/regions/webkit-flow-float-unable-to-push.html:
      * platform/gtk/fast/regions/text-region-split-vertical-rl-expected.txt: Removed.
      * platform/mac-wk2/TestExpectations:
      * platform/mac/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
      * platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81613fc9
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 6408b319
      m.pakula@samsung.com authored
      Update TestExpectations files with failing tests.
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6408b319
    • commit-queue@webkit.org's avatar
      [GStreamer] Add support for Media Source API · 4ce17731
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99065
      
      Source/WebCore:
      
      The patch integrate a Media Source player for the GStreamer backend. The implementented architecture is:
      - MediaPlayerPrivateGStreamer engine is modified to support Media Source URIs (change blob:// to mediasourceblob://), in addition to the existing support for web (http/https/blob) URIs
      - Similar to the existing WebKitWebSrc gstreamer element that handles web URIs, a new gstreamer element named WebKitMediaSrc is implemented to handle Media Source URIs
      - WebKitMediaSrc registers its URI protocol handler, allowing uridecodebin to dynamically create the appropriate source element.
      - The WebKitMediaSrc element creates a bin with 2 appsrc: One for Audio and One for Video. Pads are dynamically linked at the reception of first video and audio buffers.
      
      Patch by Stephane Jadaud <sjadaud@sii.fr> on 2013-11-15
      Reviewed by Philippe Normand.
      
      Tests: Activate http/tests/media/media-source and media/media-source tests
      
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      (WebCore::initializeGStreamerAndRegisterWebKitElements):
      (WebCore::MediaPlayerPrivateGStreamer::load):
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
      * platform/graphics/gstreamer/MediaSourceGStreamer.cpp: Added.
      (WebCore::MediaSourceGStreamer::open):
      (WebCore::MediaSourceGStreamer::MediaSourceGStreamer):
      (WebCore::MediaSourceGStreamer::~MediaSourceGStreamer):
      (WebCore::MediaSourceGStreamer::addSourceBuffer):
      (WebCore::MediaSourceGStreamer::setDuration):
      (WebCore::MediaSourceGStreamer::markEndOfStream):
      (WebCore::MediaSourceGStreamer::unmarkEndOfStream):
      * platform/graphics/gstreamer/MediaSourceGStreamer.h: Added.
      * platform/graphics/gstreamer/SourceBufferPrivateGStreamer.cpp: Added.
      (WebCore::SourceBufferPrivateGStreamer::SourceBufferPrivateGStreamer):
      (WebCore::SourceBufferPrivateGStreamer::append):
      (WebCore::SourceBufferPrivateGStreamer::abort):
      (WebCore::SourceBufferPrivateGStreamer::removedFromMediaSource):
      * platform/graphics/gstreamer/SourceBufferPrivateGStreamer.h: Added.
      * platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp: Added.
      (webKitMediaSrcAddSrc):
      (webkit_media_src_init):
      (webKitMediaSrcFinalize):
      (webKitMediaSrcSetProperty):
      (webKitMediaSrcGetProperty):
      (webKitMediaVideoSrcStop):
      (webKitMediaAudioSrcStop):
      (webKitMediaVideoSrcStart):
      (webKitMediaAudioSrcStart):
      (webKitMediaSrcChangeState):
      (webKitMediaSrcQueryWithParent):
      (webKitMediaSrcUriGetType):
      (webKitMediaSrcGetProtocols):
      (webKitMediaSrcGetUri):
      (webKitMediaSrcSetUri):
      (webKitMediaSrcUriHandlerInit):
      (webKitMediaVideoSrcNeedDataMainCb):
      (webKitMediaAudioSrcNeedDataMainCb):
      (webKitMediaVideoSrcNeedDataCb):
      (webKitMediaAudioSrcNeedDataCb):
      (webKitMediaVideoSrcEnoughDataMainCb):
      (webKitMediaAudioSrcEnoughDataMainCb):
      (webKitMediaVideoSrcEnoughDataCb):
      (webKitMediaAudioSrcEnoughDataCb):
      (webKitMediaVideoSrcSeekMainCb):
      (webKitMediaAudioSrcSeekMainCb):
      (webKitMediaVideoSrcSeekDataCb):
      (webKitMediaAudioSrcSeekDataCb):
      (webKitMediaSrcSetMediaPlayer):
      (webKitMediaSrcSetPlayBin):
      (MediaSourceClientGstreamer::MediaSourceClientGstreamer):
      (MediaSourceClientGstreamer::~MediaSourceClientGstreamer):
      (MediaSourceClientGstreamer::didReceiveDuration):
      (MediaSourceClientGstreamer::didReceiveData):
      (MediaSourceClientGstreamer::didFinishLoading):
      (MediaSourceClientGstreamer::didFail):
      * platform/graphics/gstreamer/WebKitMediaSourceGStreamer.h: Added.
      
      Tools:
      
      Patch by Stephane Jadaud <sjadaud@sii.fr> on 2013-11-15
      Reviewed by Philippe Normand.
      
      * Scripts/webkitperl/FeatureList.pm:
      
      LayoutTests:
      
      Patch by Stephane Jadaud <sjadaud@sii.fr> on 2013-11-15
      Reviewed by Philippe Normand.
      
      * platform/gtk/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ce17731
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · eda0878f
      m.pakula@samsung.com authored
      Mark flaky and incorrectly passing tests.
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Removed wrong test expectation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eda0878f
    • calvaris@igalia.com's avatar
      [GTK] Bumping GStreamer version to 1.2.1 for the dependencies · edbc9d25
      calvaris@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124360
      
      Reviewed by Philippe Normand.
      
      Tools:
      
      * gtk/jhbuild.modules: Bumped GStreamer version up to 1.2.1
      
      LayoutTests:
      
      * platform/gtk/TestExpectations: Flagged
      media/video-canvas-drawing-output.html
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edbc9d25
    • commit-queue@webkit.org's avatar
      [EFL] Layout tests with international text properties need to be rebaselined. · 3608dfdd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124389
      
      Unreviewed, EFL rabaseline.
      
      EFL international text rebaselined after r147668.
      Move some expectation files to efl common place because those files in wk1 are
      in exact accordance with files in wk2, and then delete the files in wk1 and wk2.
      
      Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-15
      
      * platform/efl-wk1/fast/text/international/003-expected.txt: Removed.
      * platform/efl-wk1/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
      * platform/efl-wk2/TestExpectations:
      * platform/efl/fast/text/international/002-expected.txt:
      * platform/efl/fast/text/international/003-expected.txt:
      Renamed from LayoutTests/platform/efl-wk2/fast/text/international/003-expected.txt.
      * platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt:
      Renamed from LayoutTests/platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3608dfdd
  2. 14 Nov, 2013 15 commits
    • ap@apple.com's avatar
      Update WebCrypto tests · df32d58c
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124388
      
      Reviewed by Anders Carlsson.
      
      Updated tests for newer common.js. Changed some tests from just dumping results
      to comparing them to known expected ones. Fixed a syntax error in
      aes-cbc-invalid-length.html, so it now actually runs.
      
      * crypto/subtle/resources/common.js: Update to a new version from Blink, because
      it's much nicer than the old one, and it's good to be compatible at test level.
      Moved crypto.subtle definition from webkitSubtle here to avoid repeating it in all
      tests. Added a quick and dirty Promise.all implementation.
      
      * crypto/subtle/aes-cbc-192-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-192-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-256-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-256-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt:
      * crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html:
      * crypto/subtle/aes-cbc-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-generate-key.html:
      * crypto/subtle/aes-cbc-import-jwk-expected.txt:
      * crypto/subtle/aes-cbc-import-jwk.html:
      * crypto/subtle/aes-cbc-invalid-length-expected.txt:
      * crypto/subtle/aes-cbc-invalid-length.html:
      * crypto/subtle/aes-cbc-wrong-key-class.html:
      * crypto/subtle/aes-export-key-expected.txt:
      * crypto/subtle/aes-export-key.html:
      * crypto/subtle/argument-conversion-expected.txt:
      * crypto/subtle/argument-conversion.html:
      * crypto/subtle/hmac-export-key-expected.txt:
      * crypto/subtle/hmac-export-key.html:
      * crypto/subtle/hmac-generate-key.html:
      * crypto/subtle/hmac-import-jwk-expected.txt:
      * crypto/subtle/hmac-import-jwk.html:
      * crypto/subtle/hmac-sign-verify-empty-key-expected.txt:
      * crypto/subtle/hmac-sign-verify-empty-key.html:
      * crypto/subtle/hmac-sign-verify-expected.txt:
      * crypto/subtle/hmac-sign-verify.html:
      * crypto/subtle/import-jwk-expected.txt:
      * crypto/subtle/import-jwk.html:
      * crypto/subtle/rsassa-pkcs1-v1_5-generate-key-expected.txt:
      * crypto/subtle/rsassa-pkcs1-v1_5-generate-key.html:
      * crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt:
      * crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html:
      * crypto/subtle/rsassa-pkcs1-v1_5-sign-verify-expected.txt:
      * crypto/subtle/rsassa-pkcs1-v1_5-sign-verify.html:
      * crypto/subtle/sha-1-expected.txt:
      * crypto/subtle/sha-1.html:
      * crypto/subtle/sha-224-expected.txt:
      * crypto/subtle/sha-224.html:
      * crypto/subtle/sha-256-expected.txt:
      * crypto/subtle/sha-256.html:
      * crypto/subtle/sha-384-expected.txt:
      * crypto/subtle/sha-384.html:
      * crypto/subtle/sha-512-expected.txt:
      * crypto/subtle/sha-512.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df32d58c
    • commit-queue@webkit.org's avatar
      XMLSerializer escapes < > & correctly inside <script> and <style> tags. · d9eb969a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123914
      
      Patch by Victor Costan <costan@gmail.com> on 2013-11-14
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Test: fast/dom/XMLSerializer-entities.html
      
      * editing/MarkupAccumulator.cpp:
      (WebCore::MarkupAccumulator::serializeNodesWithNamespaces): vim removed some whitespace.
      (WebCore::MarkupAccumulator::entityMaskForText): Fixed the returned value for <script> etc in XML.
      
      LayoutTests:
      
      * fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt: fix incorrect expectations.
      * fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml: use CDATA consistently.
      * fast/dom/XMLSerializer-entities-expected.txt: Added.
      * fast/dom/XMLSerializer-entities.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9eb969a
    • commit-queue@webkit.org's avatar
      Clean up sequence handling in Blob constructor · 933bf408
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124343
      
      Patch by Victor Costan <costan@gmail.com> on 2013-11-14
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore:
      
      Added test case to LayoutTests/fast/files/blob-constructor.html
      
      * bindings/js/JSBlobCustom.cpp:
      (WebCore::JSBlobConstructor::constructJSBlob):
          Handle exceptions in sequences, eliminate double type-checking for
          ArrayBuffer, ArrayBufferView and Blob parts.
      
      LayoutTests:
      
      * fast/files/blob-constructor-expected.txt:
      * fast/files/script-tests/blob-constructor.js:
          Add test with sequence that throws an error on property access.
      (get Object):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      933bf408
    • timothy_horton@apple.com's avatar
      Change Fail->Failure in some recent expectations. · 16cf6054
      timothy_horton@apple.com authored
      Suddenly, everything is clear.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16cf6054
    • timothy_horton@apple.com's avatar
      http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow,... · 650c6280
      timothy_horton@apple.com authored
      http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow, frequently > 30 second timeout
      https://bugs.webkit.org/show_bug.cgi?id=124373
      
      * platform/mac/TestExpectations:
      Mark test as flaky on Mountain Lion Release bot.
      Marking as slow seems to have no effect on the notifyDone timeout, just the outer timeouts.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      650c6280
    • ap@apple.com's avatar
      Implement raw format for WebCrypto key export · 32fdefdd
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124376
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Tests: crypto/subtle/aes-export-key.html
             crypto/subtle/hmac-export-key.html
      
      A CryptoKey just exports its native CryptoKeyData, which will also work nicely for
      JWK format soon. For spki and pkcs8, we'll need to figure out the best way to
      utilize platform library support for ASN.1, but we are not there yet.
      
      * bindings/js/JSSubtleCryptoCustom.cpp:
      (WebCore::JSSubtleCrypto::exportKey):
      * crypto/CryptoKey.h:
      * crypto/SubtleCrypto.idl:
      * crypto/keys/CryptoKeyAES.cpp:
      (WebCore::CryptoKeyAES::exportData):
      * crypto/keys/CryptoKeyAES.h:
      * crypto/keys/CryptoKeyHMAC.cpp:
      (WebCore::CryptoKeyHMAC::exportData):
      * crypto/keys/CryptoKeyHMAC.h:
      
      * crypto/keys/CryptoKeyRSA.h:
      * crypto/mac/CryptoKeyRSAMac.cpp:
      (WebCore::CryptoKeyRSA::exportData):
      Added a dummy implementation for RSA.
      
      LayoutTests: 
      
      * crypto/subtle/aes-export-key-expected.txt: Added.
      * crypto/subtle/aes-export-key.html: Added.
      * crypto/subtle/hmac-export-key-expected.txt: Added.
      * crypto/subtle/hmac-export-key.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32fdefdd
    • betravis@adobe.com's avatar
      [CSS Shapes] Accept the new <box> value for shape-outside · edfb6516
      betravis@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124227
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      The shape-outside property can now be set to the box values [margin/border/padding/content]-box.
      This patch adds the parsing code required to accept the new values, and the layout code
      to create a rectangle shape that has the size and position of the appropriate box.
      
      Tests: fast/shapes/shape-outside-floats/shape-outside-boxes-001.html
             fast/shapes/shape-outside-floats/shape-outside-boxes-002.html
             fast/shapes/shape-outside-floats/shape-outside-boxes-003.html
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::ComputedStyleExtractor::propertyValue): Output the new box values.
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue): Accept the new box values.
      * css/CSSValueKeywords.in: Add margin-box value.
      * css/DeprecatedStyleBuilder.cpp:
      (WebCore::ApplyPropertyShape::applyValue): Accept the new box values.
      * rendering/RenderBoxModelObject.h:
      (WebCore::RenderBoxModelObject::borderLogicalWidth): Added new utility methods to help
      with box sizing.
      (WebCore::RenderBoxModelObject::borderLogicalHeight): Ditto.
      (WebCore::RenderBoxModelObject::paddingLogicalWidth): Ditto.
      (WebCore::RenderBoxModelObject::paddingLogicalHeight): Ditto.
      * rendering/shapes/Shape.cpp:
      (WebCore::Shape::createShape): You can create a shape from a box's dimensions, rather
      than always using a BasicShape or RasterShape value.
      * rendering/shapes/Shape.h:
      * rendering/shapes/ShapeInfo.cpp:
      (WebCore::::computedShape): Create the appropriate shape based on the box values.
      * rendering/shapes/ShapeInfo.h:
      (WebCore::ShapeInfo::setShapeSize): Adjust for the box size when using a box value.
      (WebCore::ShapeInfo::logicalTopOffset): Ditto.
      (WebCore::ShapeInfo::logicalLeftOffset): Ditto.
      * rendering/shapes/ShapeInsideInfo.cpp:
      (WebCore::ShapeInsideInfo::isEnabledFor): Enable for the box values.
      * rendering/shapes/ShapeOutsideInfo.cpp:
      (WebCore::ShapeOutsideInfo::isEnabledFor): Disable for shape-inside.
      * rendering/style/ShapeValue.h:
      (WebCore::ShapeValue::createBoxValue): Create the appropriate shape value for a box.
      (WebCore::ShapeValue::box): Return the box value for this ShapeValue.
      (WebCore::ShapeValue::ShapeValue): Create a ShapeValue from a box value.
      
      LayoutTests:
      
      Test the different box values with different writing modes.
      
      * fast/shapes/parsing/parsing-shape-inside-expected.html: Adding box values as invalid.
      * fast/shapes/parsing/parsing-shape-inside.html: Ditto.
      * fast/shapes/parsing/parsing-shape-outside-expected.html: Adding box values as valid.
      * fast/shapes/parsing/parsing-shape-outside.html: Ditto.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-001-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-001.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-002-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-002.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-003-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-003.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edfb6516
    • jer.noble@apple.com's avatar
      Flaky Test: media/video-fast-seek.html · 61593d79
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124298
      
      Reviewed by Eric Carlson.
      
      Don't check for the precise results of currentTime, as MediaTime -> double
      rounding will occasionally result in errors.
      
      * media/video-fast-seek-expected.txt:
      * media/video-fast-seek.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61593d79
    • timothy_horton@apple.com's avatar
      fullscreen/anonymous-block-merge-crash.html often times out in WebKit1 · f6b179b7
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124318
      
      * platform/mac/TestExpectations:
      Used the wrong kind of failure for a notifyDone timeout.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6b179b7
    • timothy_horton@apple.com's avatar
      http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow,... · 7cfe8de7
      timothy_horton@apple.com authored
      http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow, frequently > 30 second timeout
      https://bugs.webkit.org/show_bug.cgi?id=124373
      
      * platform/mac/TestExpectations:
      Mark test as slow on Mountain Lion Release bot.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cfe8de7
    • ap@apple.com's avatar
      [Mac] HMAC sign/verify crashes when key is empty · 46bab23a
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124372
      
      Reviewed by Sam Weinig.
      
      Source/WebCore: 
      
      Test: crypto/subtle/hmac-sign-verify-empty-key.html
      
      * crypto/mac/CryptoAlgorithmHMACMac.cpp: (WebCore::calculateSignature): Give it
      a non-null pointer then.
      
      LayoutTests: 
      
      * crypto/subtle/hmac-sign-verify-empty-key-expected.txt: Added.
      * crypto/subtle/hmac-sign-verify-empty-key.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46bab23a
    • samuel_white@apple.com's avatar
      AX: Calling NSAccessibilityColumnsAttribute and NSAccessibilityRowsAttribute... · 6c469be7
      samuel_white@apple.com authored
      AX: Calling NSAccessibilityColumnsAttribute and NSAccessibilityRowsAttribute simply to get column/row count can be very expensive.
      https://bugs.webkit.org/show_bug.cgi?id=124293
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Added ability to get accessibility table column or row count without fetching all columns or rows.
      
      Test: platform/mac/accessibility/table-column-and-row-count.html
      
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
      
      LayoutTests:
      
      Added test to ensure NSAccessibilityColumnsAttribute and NSAccessibilityRowsAttribute
      behave as expected. Also updated existing table tests to reflect this additional API.
      
      * platform/mac/accessibility/table-column-and-row-count-expected.txt: Added.
      * platform/mac/accessibility/table-column-and-row-count.html: Added.
      * platform/mac/accessibility/table-detection-expected.txt:
      * platform/mac/accessibility/table-with-rules-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c469be7
    • ap@apple.com's avatar
      Implement RSASSA-PKCS1-v1_5 sign/verify · cbf00156
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124335
      
      Reviewed by Sam Weinig.
      
      Source/WebCore:
      
      Test: crypto/subtle/rsassa-pkcs1-v1_5-sign-verify.html
      
      * WebCore.xcodeproj/project.pbxproj: Added new files, removed Mac SHA algorithm files.
      
      * crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
      (WebCore::getCommonCryptoDigestAlgorithm):
      (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
      (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
      Implemented. These take two steps, first a digest is computed, and then it's signed.
      
      * crypto/CryptoDigest.h: Added.
      * crypto/mac/CryptoDigestMac.cpp: Added.
      (WebCore::CryptoDigest::CryptoDigest):
      (WebCore::CryptoDigest::~CryptoDigest):
      (WebCore::CryptoDigest::create):
      (WebCore::CryptoDigest::addBytes):
      (WebCore::CryptoDigest::computeHash):
      Added a cross-platform interface and Mac implementation to compute a digest. It
      should be possible to use it outside WebCrypto if we need to (perhaps even merge
      with  WTF SHA-1 class).
      The Mac implementation is kind of ugly, but at least it encapsulates the ugliness.
      
      * crypto/algorithms/CryptoAlgorithmSHA1.cpp: (WebCore::CryptoAlgorithmSHA1::digest):
      * crypto/algorithms/CryptoAlgorithmSHA224.cpp: (WebCore::CryptoAlgorithmSHA224::digest):
      * crypto/algorithms/CryptoAlgorithmSHA256.cpp: (WebCore::CryptoAlgorithmSHA256::digest):
      * crypto/algorithms/CryptoAlgorithmSHA384.cpp: (WebCore::CryptoAlgorithmSHA384::digest):
      * crypto/algorithms/CryptoAlgorithmSHA512.cpp: (WebCore::CryptoAlgorithmSHA512::digest):
      * crypto/mac/CryptoAlgorithmSHA1Mac.cpp: Removed.
      * crypto/mac/CryptoAlgorithmSHA224Mac.cpp: Removed.
      * crypto/mac/CryptoAlgorithmSHA256Mac.cpp: Removed.
      * crypto/mac/CryptoAlgorithmSHA384Mac.cpp: Removed.
      * crypto/mac/CryptoAlgorithmSHA512Mac.cpp: Removed.
      These are all cross-platform now.
      
      LayoutTests:
      
      * crypto/subtle/rsassa-pkcs1-v1_5-sign-verify-expected.txt: Added.
      * crypto/subtle/rsassa-pkcs1-v1_5-sign-verify.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbf00156
    • hmuller@adobe.com's avatar
      [CSS Shapes] Empty polygons with non-zero shape-padding cause an ASSERT crash · ae389127
      hmuller@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124324
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      PolygonShape::shapePaddingBounds() and PolygonShape::shapeMarginBounds() no
      longer attempt to compute a new FloatPolygon when the original is empty, i.e.
      when it has less than three vertices.
      
      Tests: fast/shapes/shape-inside/shape-inside-empty-polygon-crash.html
             fast/shapes/shape-outside-floats/shape-outside-floats-empty-polygon-crash.html
      
      * rendering/shapes/PolygonShape.cpp:
      (WebCore::PolygonShape::shapePaddingBounds): Don't compute a padding FloatPolygon if the original polygon is empty.
      (WebCore::PolygonShape::shapeMarginBounds): Don't compute a margin FloatPolygon if the original polygon is empty.
      
      LayoutTests:
      
      * fast/shapes/shape-inside/shape-inside-empty-polygon-crash-expected.txt: Added.
      * fast/shapes/shape-inside/shape-inside-empty-polygon-crash.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-floats-empty-polygon-crash-expected.txt: Added.
      * fast/shapes/shape-outside-floats/shape-outside-floats-empty-polygon-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae389127
    • commit-queue@webkit.org's avatar
      [EFL] Layout tests with text areas need to be rebaselined. · 58f400b0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124337
      
      Unreviewed, EFL gatdening.
      
      EFL text areas rebaselined after r129492.
      
      Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-14
      
      * platform/efl/TestExpectations:
      * platform/efl/fast/forms/basic-textareas-expected.txt:
      * platform/efl/fast/forms/basic-textareas-quirks-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58f400b0
  3. 13 Nov, 2013 8 commits