1. 28 Oct, 2013 33 commits
    • simon.fraser@apple.com's avatar
      Last few Mavericks WK2 failures. · 6fb86316
      simon.fraser@apple.com authored
      * platform/mac-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fb86316
    • commit-queue@webkit.org's avatar
      Web Inspector: Remove unused inspector/inline-javascript-imports.py · 0dd57297
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123425
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-10-28
      Reviewed by Timothy Hatcher.
      
      * inspector/inline-javascript-imports.py: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0dd57297
    • commit-queue@webkit.org's avatar
      Web Inspector: Remove unused "externs" files and generators · 98dbdafa
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123427
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-10-28
      Reviewed by Timothy Hatcher.
      
      * inspector/InjectedScriptExterns.js: Removed.
      * inspector/generate_protocol_externs.py: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98dbdafa
    • simon.fraser@apple.com's avatar
      Mark some more Mavericks/WK2 tests as failing. · f24ce5c4
      simon.fraser@apple.com authored
      We have no way currently to land new results for just
      WK2 on Mavericks.
      
      * platform/mac-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f24ce5c4
    • fpizlo@apple.com's avatar
      OSRExit::m_watchpointIndex should be in OSRExitCompilationInfo · e8af48ca
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123423
      
      Reviewed by Mark Hahnenberg.
              
      Also enable ExitKind to tell you if it's a watchpoint.
      
      * bytecode/ExitKind.cpp:
      (JSC::exitKindToString):
      * bytecode/ExitKind.h:
      (JSC::isWatchpoint):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::setLocal):
      (JSC::DFG::ByteCodeParser::setArgument):
      (JSC::DFG::ByteCodeParser::handleCall):
      (JSC::DFG::ByteCodeParser::handleGetById):
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGJITCompiler.cpp:
      (JSC::DFG::JITCompiler::linkOSRExits):
      (JSC::DFG::JITCompiler::link):
      * dfg/DFGJITCompiler.h:
      (JSC::DFG::JITCompiler::appendExitInfo):
      * dfg/DFGOSRExit.cpp:
      (JSC::DFG::OSRExit::OSRExit):
      * dfg/DFGOSRExit.h:
      * dfg/DFGOSRExitCompilationInfo.h:
      (JSC::DFG::OSRExitCompilationInfo::OSRExitCompilationInfo):
      * dfg/DFGOSRExitCompiler.cpp:
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::speculationWatchpoint):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8af48ca
    • commit-queue@webkit.org's avatar
      Upstream remaining PLATFORM(IOS) and ENABLE(REMOTE_INSPECTOR) pieces · 5d05e88f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123411
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-10-28
      Reviewed by Timothy Hatcher.
      
      Source/WebCore:
      
      Include an InspectorClient hook for when node searching is enabled / disabled.
      
      * inspector/InspectorClient.h:
      (WebCore::InspectorClient::didSetSearchingForNode):
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::setSearchingForNode):
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::didSetSearchingForNode):
      * inspector/InspectorOverlay.h:
      
      Source/WebKit:
      
      * WebKit.xcodeproj/project.pbxproj:
      
      Source/WebKit/mac:
      
      Upstream iOS node highlighting and view indication.
      
      * WebCoreSupport/WebInspectorClient.h:
      * WebInspector/WebInspector.h:
      * WebInspector/WebInspector.mm:
      * WebInspector/WebNodeHighlight.h:
      * WebInspector/WebNodeHighlight.mm:
      (-[WebHighlightLayer initWithHighlightView:webView:]):
      (-[WebHighlightLayer layoutSublayers]):
      (-[WebHighlightLayer actionForKey:]):
      (-[WebNodeHighlight initWithTargetView:inspectorController:]):
      (-[WebNodeHighlight dealloc]):
      (-[WebNodeHighlight attach]):
      * WebInspector/WebNodeHighlightView.h:
      * WebInspector/WebNodeHighlightView.mm:
      (-[WebNodeHighlightView initWithWebNodeHighlight:]):
      (-[WebNodeHighlightView dealloc]):
      (-[WebNodeHighlightView _attach:numLayers:]):
      (findIntersectionOnLineBetweenPoints):
      (quadIntersection):
      (layerPathWithHole):
      (layerPath):
      (-[WebNodeHighlightView _layoutForNodeHighlight:parent:]):
      (-[WebNodeHighlightView _layoutForRectsHighlight:parent:]):
      (-[WebNodeHighlightView layoutSublayers:]):
      * WebInspector/WebNodeHighlighter.mm:
      (-[WebNodeHighlighter highlight]):
      * WebView/WebIndicateLayer.h: Added.
      * WebView/WebIndicateLayer.mm: Added.
      (-[WebIndicateLayer layoutSublayers]):
      (-[WebIndicateLayer actionForKey:]):
      * WebView/WebView.mm:
      (-[WebView setIndicatingForRemoteInspector:]):
      (-[WebView setHostApplicationBundleId:name:]):
      (-[WebView hostApplicationBundleId]):
      (-[WebView hostApplicationName]):
      * WebView/WebViewData.h:
      * WebView/WebViewData.mm:
      (-[WebViewPrivate dealloc]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d05e88f
    • simon.fraser@apple.com's avatar
      Allow explicit sort order for Dashboard platforms · 14aa4aa0
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123419
      
      Reviewed by Tim Hatcher.
      
      Assign a specific sort order to Dashboard platforms, rather than
      just using object property order.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
      (BuildbotQueue):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
      (documentReady):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14aa4aa0
    • simon.fraser@apple.com's avatar
      Add skipped or failing expectations for Mavericks WK2. · ea5fee0c
      simon.fraser@apple.com authored
      * platform/mac-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea5fee0c
    • simon.fraser@apple.com's avatar
      WebGL flake. · f8ef67d4
      simon.fraser@apple.com authored
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8ef67d4
    • simon.fraser@apple.com's avatar
      Tidy up main http://build.webkit.org page · c7bdeb92
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123413
      
      Reviewed by Alexey Proskuryakov.
      
      Break the list of links into sections. Add some font style.
      
      * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7bdeb92
    • benjamin@webkit.org's avatar
      Rename applyPageScaleFactorInCompositor to delegatesPageScaling · 2dfd9905
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123417
      
      Reviewed by Simon Fraser.
      
      Source/WebCore: 
      
      * page/Frame.cpp:
      (WebCore::Frame::frameScaleFactor):
      * page/FrameView.cpp:
      (WebCore::FrameView::visibleContentScaleFactor):
      * page/Page.cpp:
      (WebCore::Page::setPageScaleFactor):
      * page/Settings.in:
      * platform/ScrollView.h:
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::addToOverlapMap):
      
      Source/WebKit2: 
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::setUseFixedLayout):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2dfd9905
    • commit-queue@webkit.org's avatar
      Parsing support for -webkit-text-decoration-skip: ink · 0171920a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123358
      
      Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-28
      Reviewed by Dean Jackson.
      
      Source/JavaScriptCore:
      
      Adding ENABLE(CSS3_TEXT_DECORATION)
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore:
      
      Adds initial parsing support for parsing -webkit-text-decoration-skip with
      values of "none" and "ink". This work is behind the new
      ENABLE(CSS3_TEXT_DECORATION) compile-time flag.
      
      Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html
      
      * Configurations/FeatureDefines.xcconfig: Adding ENABLE(CSS3_TEXT_DECORATION)
      * css/CSSComputedStyleDeclaration.cpp: Mapping internal representation of text-decoration-skip
      to a CSSValue
      (WebCore::renderTextDecorationSkipFlagsToCSSValue):
      (WebCore::ComputedStyleExtractor::propertyValue):
      * css/CSSParser.cpp: Actually parsing tokens
      (WebCore::CSSParser::parseValue):
      (WebCore::CSSParser::parseTextDecorationSkip):
      * css/CSSParser.h:
      * css/CSSPropertyNames.in: adding -webkit-text-decoration-skip
      * css/CSSValueKeywords.in: adding ink
      * css/DeprecatedStyleBuilder.cpp: Mapping from CSSValue to internal representation
      (WebCore::ApplyPropertyTextDecorationSkip::valueToDecorationSkip):
      (WebCore::ApplyPropertyTextDecorationSkip::applyValue):
      (WebCore::ApplyPropertyTextDecorationSkip::createHandler):
      (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
      * css/StyleResolver.cpp: decoration-skip uses DeprecatedStyleBuilder
      (WebCore::StyleResolver::applyProperty):
      * rendering/style/RenderStyle.h: Adding functions for modifying and accessing decoration-skip properties
      * rendering/style/RenderStyleConstants.h: Definition of internal representation
      * rendering/style/StyleRareInheritedData.cpp: Setting up constructors and comparators
      (WebCore::StyleRareInheritedData::StyleRareInheritedData):
      (WebCore::StyleRareInheritedData::operator==):
      * rendering/style/StyleRareInheritedData.h: Holds actual value of internal representation
      
      Source/WebKit/mac:
      
      Adding ENABLE(CSS3_TEXT_DECORATION)
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2:
      
      Adding ENABLE(CSS3_TEXT_DECORATION)
      
      * Configurations/FeatureDefines.xcconfig:
      
      Tools:
      
      Adding ENABLE(CSS3_TEXT_DECORATION)
      
      * Scripts/webkitperl/FeatureList.pm:
      
      LayoutTests:
      
      Adds a test which makes sure that we can parse the
      -webkit-text-decoration-skip CSS property, as well
      as values for "ink" and "none". We can use the CSSOM
      to test the roundtrip of these values
      
      * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0171920a
    • andersca@apple.com's avatar
      RunLoop::dispatch should take an std::function · 706feea9
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123407
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * platform/RunLoop.cpp:
      (WebCore::RunLoop::performWork):
      (WebCore::RunLoop::dispatch):
      * platform/RunLoop.h:
      
      Source/WTF:
      
      * wtf/FunctionDispatcher.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      706feea9
    • timothy_horton@apple.com's avatar
      Make TileController manipulate PlatformCALayers instead of CALayers · dca7a0af
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123279
      
      Reviewed by Simon Fraser.
      
      In the interest of making TileController more platform-independent
      (so that it can be used with the remote layer tree, and maybe Windows),
      move TileController onto our PlatformCALayer abstraction instead of
      direct manipulation of CALayers.
      
      Some fallout from this includes getting rid of special Mac-specific
      TileController-specific CALayer subclasses, and reworking tile
      painting to work in a more generic way.
      
      This is a first step, and doesn't get us all the way to a platform independent
      TileController, but more patches are forthcoming.
      
      No new tests, just a (largeish) refactor.
      
      * WebCore.exp.in:
      The signature of some methods has changed.
      
      * WebCore.xcodeproj/project.pbxproj:
      Remove WebTileLayer.*
      
      * page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
      (WebCore::ScrollingTreeScrollingNodeMac::logExposedUnfilledArea):
      Use the "isTile" key on the CALayer dictionary instead of the layer's
      class to determine if it's a tile. TileController will set this on a tile
      when it is created, for now.
      
      * platform/graphics/TiledBacking.h:
      tiledScrollingIndicatorLayer() should return a PlatformCALayer.
      
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::platformCALayerPaintContents):
      * platform/graphics/ca/GraphicsLayerCA.h:
      (WebCore::GraphicsLayerCA::platformCALayerIncrementRepaintCount):
      * platform/graphics/ca/PlatformCALayerClient.h:
      The PlatformCALayerClient paintContents and incrementRepaintCount callbacks
      should include the platformCALayer that caused the callback.
      
      * platform/graphics/ca/PlatformCALayer.h:
      Add LayerTypeSimpleLayer, which is similar to LayerTypeWebLayer
      except it just calls back its client to paint, instead of doing
      complicated things with repaint rects. This is so that TileController
      doesn't re-enter drawLayerContents when asking its GraphicsLayer
      to paint for each PlatformCALayer (it will be entering drawLayerContents
      for the first time for each layer). It also happens to be useful
      for things like the tile controller overlay, which don't need
      all that complication.
      
      Add LayerTypeTiledBackingTileLayer, which is used simply to distinguish
      TileController Tile layers from other LayerTypeSimpleLayers.
      
      * platform/graphics/ca/mac/LayerPool.h:
      * platform/graphics/ca/mac/LayerPool.mm:
      (WebCore::LayerPool::addLayer):
      (WebCore::LayerPool::takeLayerWithSize):
      LayerPool should operate on PlatformCALayers now.
      
      * platform/graphics/ca/mac/PlatformCALayerMac.h:
      * platform/graphics/ca/mac/PlatformCALayerMac.mm:
      (PlatformCALayerMac::PlatformCALayerMac):
      Set the "isTile" key on the CALayer to true for TiledBackingTileLayers,
      so that the scrolling performance logging can tell a tile apart from
      any other layer, on the scrolling thread, without touching PlatformCALayers
      or the TileController or any other main-thread data structures.
      
      (PlatformCALayerMac::setEdgeAntialiasingMask): Added.
      * platform/graphics/ca/mac/TileController.h:
      Remove references to Objective-C classes; instead use PlatformCALayer everywhere.
      TileController is now a PlatformCALayerClient, and the layers it owns are
      all PlatformCALayers (and it is constructed with a PlatformCALayer, etc.).
      Hand in the tile debug border color as a WebCore color, instead of a CGColorRef.
      blankPixelCountForTiles() now operates on a list of PlatformLayers instead of
      WebTileLayers specifically, since WebTileLayer is gone.
      Make drawTileMapContents private because WebTileCacheMapLayer no longer exists.
      
      (WebCore::TileController::platformCALayerDrawsContent):
      All of the layers who have TileController as their client paint their contents.
      
      (WebCore::TileController::platformCALayerContentsOpaque):
      This will only be called for layers which paint via drawLayerContents,
      so it's OK that we don't special-case the debugging overlay here.
      
      (WebCore::TileController::owningGraphicsLayer):
      Return the GraphicsLayer that owns the TileController's main
      layer, via its conformance to PlatformCALayerClient. This is
      a bit strange (because it's not strictly a GraphicsLayer, despite
      always being so at the moment), but is done for clarity inside
      TileController itself.
      
      * platform/graphics/ca/mac/TileController.mm:
      Remove CALayer (WebCALayerDetails), WebTiledScrollingIndicatorLayer,
      and a bunch of includes that we don't need anymore.
      
      (WebCore::TileController::create):
      (WebCore::TileController::TileController):
      TileController is passed a PlatformCALayer for the tile cache root layer,
      instead of a WebTiledBackingLayer. It also creates a PlatformCALayer with
      LayerTypeLayer instead of a bare CALayer for the container layer.
      It's OK to remove the transaction because it was only used to stop
      the implicit animation, which PlatformCALayer will do for us.
      
      (WebCore::TileController::~TileController):
      Clear the owner of the PlatformCALayers which the TileController previously owned,
      so they don't try to call back a destroyed TileController.
      
      (WebCore::TileController::tileCacheLayerBoundsChanged):
      (WebCore::TileController::setNeedsDisplay):
      Straightforward adjustments towards use of PlatformCALayer.
      
      (WebCore::TileController::setTileNeedsDisplayInRect):
      Adjustments towards use of PlatformCALayer; we need FloatRects so we can
      pass pointers to PlatformCALayer::setNeedsDisplay.
      
      (WebCore::TileController::platformCALayerPaintContents):
      Replace drawLayer with platformCALayerPaintContents, which will be called
      back from our various WebSimpleLayers. If the PlatformCALayer is our
      tiled scrolling debug indicator, paint that. Otherwise, it's a tile.
      Make use of drawLayerContents() to paint the tile contents.
      Make use of drawRepaintIndicator() to paint the repaint indicator if needed.
      Move scrolling performance logging code that used to be in WebTileLayer here.
      
      (WebCore::TileController::platformCALayerDeviceScaleFactor):
      (WebCore::TileController::platformCALayerShowDebugBorders):
      (WebCore::TileController::platformCALayerShowRepaintCounter):
      Forward these to the owning GraphicsLayerCA, because it will have the right answers.
      
      (WebCore::TileController::setScale):
      Adjustments towards use of PlatformCALayer; remove some code that Simon
      caused to be unused in 156291 but did not remove.
      
      (WebCore::TileController::setAcceleratesDrawing):
      (WebCore::TileController::setTilesOpaque):
      (WebCore::TileController::setVisibleRect):
      (WebCore::TileController::revalidateTiles):
      (WebCore::TileController::setTileDebugBorderWidth):
      (WebCore::TileController::setTileDebugBorderColor):
      (WebCore::TileController::bounds):
      (WebCore::TileController::blankPixelCount):
      (WebCore::TileController::blankPixelCountForTiles):
      (WebCore::queueTileForRemoval):
      (WebCore::TileController::setNeedsRevalidateTiles):
      (WebCore::TileController::ensureTilesForRect):
      (WebCore::TileController::retainedTileBackingStoreMemory):
      Straightforward adjustments towards use of PlatformCALayer.
      
      (WebCore::TileController::updateTileCoverageMap):
      Adjustments towards use of PlatformCALayer; rename backgroundColor
      to visibleRectIndicatorColor, since it's actually a border, not a background.
      
      (WebCore::TileController::tiledScrollingIndicatorLayer):
      Create a LayerTypeSimpleLayer PlatformCALayer for the tiled scrolling indicator.
      It will be asked to paint straightforwardly, like a CALayer would.
      Create a LayerTypeLayer PlatformCALayer for the visible rect indicator.
      It doesn't need to paint anything, so it doesn't get an owner.
      
      (WebCore::TileController::createTileLayer):
      When creating a new tile layer, adopt it by setting its owner.
      Otherwise, straightforward adjustments towards use of PlatformCALayer.
      
      (WebCore::TileController::platformCALayerIncrementRepaintCount):
      Manage repaint counts for tiles in TileController now.
      
      (WebCore::TileController::drawTileMapContents):
      Adjustments towards use of PlatformCALayer.
      
      * platform/graphics/ca/mac/WebTileLayer.h: Removed.
      * platform/graphics/ca/mac/WebTileLayer.mm: Removed.
      We don't need WebTileLayer anymore, tiles are now just WebSimpleLayers
      owned by TileController. Its behavior has been moved into TileController.
      
      * platform/graphics/ca/mac/WebTiledBackingLayer.h:
      * platform/graphics/ca/mac/WebTiledBackingLayer.mm:
      (-[WebTiledBackingLayer createTileController:]):
      Add createTileController: so that the WebTiledBackingLayer's owner can
      hand the TileController the PlatformCALayer for the WebTiledBackingLayer
      without propagating additional usage of PlatformCALayer::platformCALayer(),
      which we need to remove in light of the remote layer tree work.
      
      (-[WebTiledBackingLayer setBorderColor:]):
      
      * platform/graphics/ca/win/PlatformCALayerWin.h:
      Add an empty implementation of setEdgeAntialiasingMask.
      We'll probably want to implement it before adopting TileController on Windows.
      
      * platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
      (PlatformCALayerWinInternal::displayCallback):
      * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
      (WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerPaintContents):
      (WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerIncrementRepaintCount):
      * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
      (WebCore::LayerClient::platformCALayerPaintContents):
      (WebCore::LayerClient::platformCALayerIncrementRepaintCount):
      Adjust for new parameters on PlatformCALayerClient callbacks.
      
      * platform/graphics/mac/WebLayer.h:
      Add WebSimpleLayer, which inherits directly from CALayer, and make
      our standard WebLayer (which is used for compositing layers in web content)
      inherit from that.
      
      * platform/graphics/mac/WebLayer.mm:
      Move most of the behavior of WebLayer onto WebSimpleLayer, except for its
      complex painting code. That stays as an override on WebLayer.
      
      (WebCore::drawLayerContents):
      Use the PlatformCALayer's PlatformLayer - if it exists - to extract
      fine-grained repaint rects. If it doesn't, we'll just use the CGContext's
      clip rect as our single repaint rect.
      Rename platformLayer to platformCALayer for accuracy.
      Remove special code for CATiledLayer since we ought not use it on Mac anymore.
      
      (WebCore::drawRepaintIndicator):
      Factor repaint indicator code out into its own function so that TileController
      can use it. It can't be called from drawLayerContents for TileController, since
      the PlatformCALayer that TileController passes in to drawLayerContents is actually
      that of the tile cache's root layer, not the tile itself.
      Also, add a custom background color parameter so TileController can override
      the default green color with its own standard purple.
      
      (-[WebLayer drawInContext:]):
      (-[WebSimpleLayer drawInContext:]):
      * platform/graphics/mac/WebTiledLayer.mm:
      (-[WebTiledLayer drawInContext:]):
      Removed a param from drawLayerContents because it's trivially acquirable
      from the PlatformCALayer.
      
      * FullscreenVideoController.cpp:
      (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
      (FullscreenVideoController::LayerClient::platformCALayerIncrementRepaintCount):
      Adjust for new parameters on PlatformCALayerClient callbacks.
      
      * Shared/mac/RemoteLayerTreeTransaction.mm:
      (WebKit::RemoteLayerTreeTransaction::dump):
      Support the new LayerTypes.
      
      * WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
      (PlatformCALayerRemote::setEdgeAntialiasingMask):
      * WebProcess/WebPage/mac/PlatformCALayerRemote.h:
      Add an empty implementation of setEdgeAntialiasingMask.
      
      * WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:
      (RemoteLayerBackingStore::display):
      Removed a parameter from drawLayerContents.
      
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::updateDebugInfoLayer):
      TiledCoreAnimationDrawingArea still operates in terms of CALayers, so
      grab the PlatformLayer out from TileController's indicator.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dca7a0af
    • weinig@apple.com's avatar
      Move RenderBlock functions only used by RenderBlockFlow to RenderBlockFlow · 31324fda
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123318
      
      Reviewed by David Hyatt.
      
      * rendering/LineLayoutState.h:
      Move FloatWithRect from RenderBlock.
      
      * rendering/RenderBlock.cpp:
      * rendering/RenderBlock.h:
      * rendering/RenderBlockFlow.cpp:
      * rendering/RenderBlockFlow.h:
      * rendering/RenderBlockLineLayout.cpp:
      Move pagination and float functions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31324fda
    • simon.fraser@apple.com's avatar
      Expunge Lion and SnowLeopard from TestExpectations. · 14238fbc
      simon.fraser@apple.com authored
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14238fbc
    • simon.fraser@apple.com's avatar
      Some test expectations for Mavericks. · 8641d576
      simon.fraser@apple.com authored
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8641d576
    • lforschler@apple.com's avatar
      Add additional Apple Mavericks test bots. · 090865c2
      lforschler@apple.com authored
              
      Unreviewed.
              
      * BuildSlaveSupport/build.webkit.org-config/config.json:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      090865c2
    • fpizlo@apple.com's avatar
      Get rid of InlineStart so that I don't have to implement it in FTL · f5be8c90
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123302
      
      Reviewed by Geoffrey Garen.
              
      InlineStart was a special instruction that we would insert at the top of inlined code,
      so that the backend could capture the OSR state of arguments to an inlined call. It used
      to be that only the backend had this information, so this instruction was sort of an ugly
      callback from the backend for filling in some data structures.
              
      But in the time since when that code was written (two years ago?), we rationalized how
      variables work. It's now the case that variables that the runtime must know about are
      treated specially in IR (they are "flushed") and we know how we will represent them even
      before we get to the backend. The last place that makes changes to their representation
      is the StackLayoutPhase.
              
      So, this patch gets rid of InlineStart, but keeps around the special meta-data that the
      instruction had. Instead of handling the bookkeeping in the backend, we handle it in
      StackLayoutPhase. This means that the DFG and FTL can share code for handling this
      bookkeeping. This also means that now the FTL can compile code blocks that had inlining.
              
      Of course, giving the FTL the ability to handle code blocks that had inlining means that
      we're going to have new bugs. Sure enough, the FTL's linker didn't handle inline call
      frames. This patch also fixes that.
      
      * dfg/DFGAbstractInterpreterInlines.h:
      (JSC::DFG::::executeEffects):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::handleInlining):
      (JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
      * dfg/DFGClobberize.h:
      (JSC::DFG::clobberize):
      * dfg/DFGFixupPhase.cpp:
      (JSC::DFG::FixupPhase::fixupNode):
      * dfg/DFGGraph.h:
      * dfg/DFGNode.h:
      * dfg/DFGNodeType.h:
      * dfg/DFGPredictionPropagationPhase.cpp:
      (JSC::DFG::PredictionPropagationPhase::propagate):
      * dfg/DFGSafeToExecute.h:
      (JSC::DFG::safeToExecute):
      * dfg/DFGSpeculativeJIT.cpp:
      * dfg/DFGSpeculativeJIT.h:
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGStackLayoutPhase.cpp:
      (JSC::DFG::StackLayoutPhase::run):
      * ftl/FTLLink.cpp:
      (JSC::FTL::link):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5be8c90
    • svillar@igalia.com's avatar
      [CSS Grid Layout] Add support for order inside grid items · e3280cb3
      svillar@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123208
      
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      Based on Blink r153457 and r153536 by <jchaffraix@chromium.org>
      
      Added support for sorting grid items by using -webkit-order
      property. Used OrderIterator to implement it so it had to be moved
      out of RenderFlexibleBox to be shared with RenderGrid.
      
      Tests: fast/css-grid-layout/grid-item-order-auto-flow-resolution.html
             fast/css-grid-layout/grid-item-order-paint-order.html
      
      * CMakeLists.txt: Added new file.
      * GNUmakefile.list.am: Ditto.
      * WebCore.vcxproj/WebCore.vcxproj: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      * rendering/OrderIterator.cpp: Added. Ripped out of RenderFlexibleBox.
      (WebCore::OrderIterator::OrderIterator):
      (WebCore::OrderIterator::setOrderValues): Use std::move semantics.
      (WebCore::OrderIterator::first): Use an integer as iterator.
      (WebCore::OrderIterator::next): Ditto.
      (WebCore::OrderIterator::reset): Ditto.
      * rendering/OrderIterator.h: Added.
      (WebCore::OrderIterator::currentChild):
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::RenderFlexibleBox):
      (WebCore::RenderFlexibleBox::layoutBlock):
      * rendering/RenderFlexibleBox.h:
      * rendering/RenderGrid.cpp:
      (WebCore::RenderGrid::RenderGrid):
      (WebCore::RenderGrid::placeItemsOnGrid):
      (WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
      (WebCore::RenderGrid::paintChildren):
      * rendering/RenderGrid.h:
      
      LayoutTests:
      
      From Blink r153536 by <jchaffraix@chromium.org>
      
      Added a couple of tests to verify that we respect the specified
      order of grid items both in the auto-placement algorithm and in
      the final painting.
      
      * fast/css-grid-layout/grid-item-order-auto-flow-resolution-expected.txt: Added.
      * fast/css-grid-layout/grid-item-order-auto-flow-resolution.html: Added.
      * fast/css-grid-layout/grid-item-order-paint-order-expected.html: Added.
      * fast/css-grid-layout/grid-item-order-paint-order.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3280cb3
    • fpizlo@apple.com's avatar
      The GetById->GetByOffset AI-based optimization should actually do things · ac5a874e
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123299
      
      Reviewed by Oliver Hunt.
              
      20% speed-up on Octane/gbemu.
      
      * bytecode/GetByIdStatus.cpp:
      (JSC::GetByIdStatus::computeFor): Actually finish filling in the Status by setting the state. Previously it would remain set to NoInformation, meaning that this whole method was a no-op.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac5a874e
    • commit-queue@webkit.org's avatar
      Methods on window.internals shouldn't pass a document. · 3e466981
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107301
      
      Patch by Afonso R. Costa Jr. <afonso.costa@samsung.com> on 2013-10-28
      Reviewed by Alexey Proskuryakov.
      
      Each 'Internals' instance is associated with a 'Document'. So, it
      is not necessary to pass a document as argument. Only nodesFromRect and
      layerTreeAsText methods were kept because, in some Layout Tests, the
      'Document' object is not the same used by Internals::contextDocument.
      
      Source/WebCore:
      
      * testing/Internals.cpp: Removed 'document' parameter.
      (WebCore::Internals::animationsAreSuspended):
      (WebCore::Internals::suspendAnimations):
      (WebCore::Internals::resumeAnimations):
      (WebCore::Internals::inspectorHighlightRects):
      (WebCore::Internals::inspectorHighlightObject):
      (WebCore::Internals::setScrollViewPosition):
      (WebCore::Internals::setPagination):
      (WebCore::Internals::configurationForViewport):
      (WebCore::Internals::paintControlTints):
      (WebCore::Internals::setDelegatesScrolling):
      (WebCore::Internals::touchPositionAdjustedToBestClickableNode):
      (WebCore::Internals::touchNodeAdjustedToBestClickableNode):
      (WebCore::Internals::touchPositionAdjustedToBestContextMenuNode):
      (WebCore::Internals::touchNodeAdjustedToBestContextMenuNode):
      (WebCore::Internals::bestZoomableAreaForTouchPoint):
      (WebCore::Internals::lastSpellCheckRequestSequence):
      (WebCore::Internals::lastSpellCheckProcessedSequence):
      (WebCore::Internals::wheelEventHandlerCount):
      (WebCore::Internals::touchEventHandlerCount):
      (WebCore::Internals::setBatteryStatus):
      (WebCore::Internals::setNetworkInformation):
      (WebCore::Internals::setDeviceProximity):
      (WebCore::Internals::hasSpellingMarker):
      (WebCore::Internals::hasAutocorrectedMarker):
      (WebCore::Internals::isOverwriteModeEnabled):
      (WebCore::Internals::toggleOverwriteModeEnabled):
      (WebCore::Internals::consoleMessageArgumentCounts):
      (WebCore::Internals::hasGrammarMarker):
      (WebCore::Internals::numberOfScrollableAreas):
      (WebCore::Internals::isPageBoxVisible):
      (WebCore::Internals::repaintRectsAsText):
      (WebCore::Internals::scrollingStateTreeAsText):
      (WebCore::Internals::mainThreadScrollingReasons):
      (WebCore::Internals::nonFastScrollableRects):
      (WebCore::Internals::garbageCollectDocumentResources):
      (WebCore::Internals::insertAuthorCSS):
      (WebCore::Internals::insertUserCSS):
      (WebCore::Internals::shortcutIconURLs):
      (WebCore::Internals::allIconURLs):
      (WebCore::Internals::setHeaderHeight):
      (WebCore::Internals::setFooterHeight):
      (WebCore::Internals::webkitWillEnterFullScreenForElement):
      (WebCore::Internals::webkitDidEnterFullScreenForElement):
      (WebCore::Internals::webkitWillExitFullScreenForElement):
      (WebCore::Internals::webkitDidExitFullScreenForElement):
      (WebCore::Internals::startTrackingRepaints):
      (WebCore::Internals::stopTrackingRepaints):
      (WebCore::Internals::getCurrentCursorInfo):
      * testing/Internals.h:
      (WebCore::Internals::setPagination):
      * testing/Internals.idl:
      
      LayoutTests:
      
      * animations/added-while-suspended.html: Removed 'document' parameter.
      * animations/play-state-suspend.html:
      * animations/stop-animation-on-suspend.html:
      * animations/suspend-resume-animation-events.html:
      * animations/suspend-resume-animation.html:
      * animations/suspend-transform-animation.html:
      * batterystatus/resources/event-after-navigation-new.html:
      * batterystatus/script-tests/add-listener-from-callback.js:
      (firstListener):
      * batterystatus/script-tests/basic-all-types-of-events.js:
      * batterystatus/script-tests/basic-operation.js:
      * batterystatus/script-tests/multiple-frames.js:
      * batterystatus/script-tests/updates.js:
      (setBatteryStatus):
      * compositing/columns/ancestor-clipped-in-paginated.html:
      * compositing/columns/clipped-in-paginated.html:
      * compositing/columns/composited-columns-vertical-rl.html:
      * compositing/columns/composited-in-paginated-rl.html:
      * compositing/columns/composited-in-paginated-writing-mode-rl.html:
      * compositing/columns/composited-in-paginated.html:
      * compositing/columns/composited-lr-paginated-repaint.html:
      * compositing/columns/composited-rl-paginated-repaint.html:
      * compositing/columns/geometry-map-paginated-assert.html:
      * compositing/columns/hittest-composited-in-paginated.html:
      * compositing/columns/rotated-in-paginated.html:
      * compositing/columns/untransformed-composited-in-paginated.html:
      * compositing/iframes/iframe-composited-scrolling.html:
      * compositing/layer-creation/fixed-position-in-view-dynamic.html:
      * compositing/layer-creation/fixed-position-no-content-scroll-reason.html:
      * compositing/layer-creation/fixed-position-out-of-view-dynamic.html:
      * compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html:
      * compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html:
      * compositing/overflow/dynamic-composited-scrolling-status.html:
      * compositing/overflow/scrolling-without-painting.html:
      * compositing/overflow/updating-scrolling-content.html:
      * compositing/repaint/absolute-painted-into-composited-ancestor.html:
      * compositing/repaint/fixed-background-scroll.html:
      * compositing/repaint/invalidations-on-composited-layers.html:
      * compositing/repaint/positioned-movement.html:
      * compositing/repaint/repaint-on-layer-grouping-change.html:
      * compositing/repaint/resize-repaint.html:
      * compositing/repaint/scroll-fixed-layer-no-content.html:
      * compositing/repaint/scroll-fixed-layer-out-of-view.html:
      * editing/caret/selection-with-caret-type-progress.html:
      * editing/execCommand/overtype.html:
      * editing/selection/block-cursor-overtype-mode.html:
      * editing/spelling/design-mode-spellcheck-off.html:
      * editing/spelling/grammar-edit-word-expected.txt:
      * editing/spelling/grammar-edit-word.html:
      * editing/spelling/grammar-markers-hidpi.html:
      * editing/spelling/grammar-markers.html:
      * editing/spelling/grammar.html:
      * editing/spelling/script-tests/spellcheck-paste.js:
      (verifyMarker):
      * editing/spelling/script-tests/spelling-attribute-at-child.js:
      (childHasSpellingMarker):
      * editing/spelling/script-tests/spelling-attribute-change.js:
      (testSpellCheckingEnabled):
      * editing/spelling/script-tests/spelling-backspace-between-lines.js:
      (testWithDelete):
      (testWithForwardDelete):
      * editing/spelling/script-tests/spelling-hasspellingmarker.js:
      (hasMarked):
      * editing/spelling/spellcheck-async-mutation.html:
      * editing/spelling/spellcheck-attribute-expected.txt:
      * editing/spelling/spellcheck-attribute.html:
      * editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
      * editing/spelling/spellcheck-paste-continuous-disabled.html:
      * editing/spelling/spellcheck-paste-disabled-expected.txt:
      * editing/spelling/spellcheck-paste-disabled.html:
      * editing/spelling/spellcheck-sequencenum.html:
      * editing/spelling/spelling-attribute-change-expected.txt:
      * editing/spelling/spelling-backspace-between-lines-expected.txt:
      * editing/spelling/spelling-linebreak.html:
      * fast/box-shadow/shadow-repaint.html:
      * fast/css/webkit-mask-crash-fieldset-legend.html:
      * fast/css/webkit-mask-crash-figure.html:
      * fast/css/webkit-mask-crash-table.html:
      * fast/css/webkit-mask-crash-td-2.html:
      * fast/css/webkit-mask-crash-td.html:
      * fast/dom/icon-url-change.html:
      * fast/dom/icon-url-list-apple-touch.html:
      * fast/dom/icon-url-list.html:
      * fast/dom/icon-url-property.html:
      * fast/events/mouse-cursor-change.html:
      * fast/events/mouse-cursor-image-set.html:
      * fast/events/mouse-cursor-multiframecur.html:
      * fast/events/mouse-cursor-no-mousemove.html:
      * fast/events/mouse-cursor.html:
      * fast/events/touch/touch-handler-count-expected.txt:
      * fast/events/touch/touch-handler-count.html:
      * fast/events/touch/touch-input-element-change-documents-expected.txt:
      * fast/events/touch/touch-input-element-change-documents.html:
      * fast/multicol/hit-test-gap-between-pages-flipped.html:
      * fast/multicol/hit-test-gap-between-pages.html:
      * fast/multicol/pagination-h-horizontal-bt.html:
      * fast/multicol/pagination-h-horizontal-tb.html:
      * fast/multicol/pagination-h-vertical-lr.html:
      * fast/multicol/pagination-h-vertical-rl.html:
      * fast/multicol/pagination-v-horizontal-bt.html:
      * fast/multicol/pagination-v-horizontal-tb.html:
      * fast/multicol/pagination-v-vertical-lr.html:
      * fast/multicol/pagination-v-vertical-rl.html:
      * fast/multicol/pagination/BottomToTop-bt.html:
      * fast/multicol/pagination/BottomToTop-lr.html:
      * fast/multicol/pagination/BottomToTop-rl.html:
      * fast/multicol/pagination/BottomToTop-tb.html:
      * fast/multicol/pagination/LeftToRight-bt.html:
      * fast/multicol/pagination/LeftToRight-lr.html:
      * fast/multicol/pagination/LeftToRight-rl.html:
      * fast/multicol/pagination/LeftToRight-tb.html:
      * fast/multicol/pagination/RightToLeft-bt.html:
      * fast/multicol/pagination/RightToLeft-lr.html:
      * fast/multicol/pagination/RightToLeft-rl.html:
      * fast/multicol/pagination/RightToLeft-tb.html:
      * fast/multicol/pagination/TopToBottom-bt.html:
      * fast/multicol/pagination/TopToBottom-lr.html:
      * fast/multicol/pagination/TopToBottom-rl.html:
      * fast/multicol/pagination/TopToBottom-tb.html:
      * fast/multicol/shrink-to-column-height-for-pagination.html:
      * fast/repaint/background-shorthand-with-gradient-and-height-changes.html:
      * fast/repaint/obscured-background-no-repaint.html:
      * fast/repaint/resources/text-based-repaint.js:
      (runRepaintTest):
      * fast/scrolling/resources/scrollable-area.js:
      (end):
      * fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html:
      * fast/viewport/viewport-1.html:
      * fast/viewport/viewport-10.html:
      * fast/viewport/viewport-100.html:
      * fast/viewport/viewport-101.html:
      * fast/viewport/viewport-102.html:
      * fast/viewport/viewport-103.html:
      * fast/viewport/viewport-104.html:
      * fast/viewport/viewport-105.html:
      * fast/viewport/viewport-106.html:
      * fast/viewport/viewport-107.html:
      * fast/viewport/viewport-108.html:
      * fast/viewport/viewport-109.html:
      * fast/viewport/viewport-11.html:
      * fast/viewport/viewport-110.html:
      * fast/viewport/viewport-111.html:
      * fast/viewport/viewport-112.html:
      * fast/viewport/viewport-113.html:
      * fast/viewport/viewport-114.html:
      * fast/viewport/viewport-115.html:
      * fast/viewport/viewport-116.html:
      * fast/viewport/viewport-117.html:
      * fast/viewport/viewport-118.html:
      * fast/viewport/viewport-119.html:
      * fast/viewport/viewport-12.html:
      * fast/viewport/viewport-120.html:
      * fast/viewport/viewport-121.html:
      * fast/viewport/viewport-122.html:
      * fast/viewport/viewport-123.html:
      * fast/viewport/viewport-124.html:
      * fast/viewport/viewport-125.html:
      * fast/viewport/viewport-126.html:
      * fast/viewport/viewport-127.html:
      * fast/viewport/viewport-128.html:
      * fast/viewport/viewport-129.html:
      * fast/viewport/viewport-13.html:
      * fast/viewport/viewport-130.html:
      * fast/viewport/viewport-131.html:
      * fast/viewport/viewport-132.html:
      * fast/viewport/viewport-133.html:
      * fast/viewport/viewport-134.html:
      * fast/viewport/viewport-14.html:
      * fast/viewport/viewport-15.html:
      * fast/viewport/viewport-16.html:
      * fast/viewport/viewport-17.html:
      * fast/viewport/viewport-18.html:
      * fast/viewport/viewport-19.html:
      * fast/viewport/viewport-2.html:
      * fast/viewport/viewport-20.html:
      * fast/viewport/viewport-21.html:
      * fast/viewport/viewport-22.html:
      * fast/viewport/viewport-23.html:
      * fast/viewport/viewport-24.html:
      * fast/viewport/viewport-25.html:
      * fast/viewport/viewport-26.html:
      * fast/viewport/viewport-27.html:
      * fast/viewport/viewport-28.html:
      * fast/viewport/viewport-29.html:
      * fast/viewport/viewport-3.html:
      * fast/viewport/viewport-30.html:
      * fast/viewport/viewport-31.html:
      * fast/viewport/viewport-32.html:
      * fast/viewport/viewport-33.html:
      * fast/viewport/viewport-34.html:
      * fast/viewport/viewport-35.html:
      * fast/viewport/viewport-36.html:
      * fast/viewport/viewport-37.html:
      * fast/viewport/viewport-38.html:
      * fast/viewport/viewport-39.html:
      * fast/viewport/viewport-4.html:
      * fast/viewport/viewport-40.html:
      * fast/viewport/viewport-41.html:
      * fast/viewport/viewport-42.html:
      * fast/viewport/viewport-43.html:
      * fast/viewport/viewport-44.html:
      * fast/viewport/viewport-45.html:
      * fast/viewport/viewport-46.html:
      * fast/viewport/viewport-47.html:
      * fast/viewport/viewport-48.html:
      * fast/viewport/viewport-49.html:
      * fast/viewport/viewport-5.html:
      * fast/viewport/viewport-50.html:
      * fast/viewport/viewport-51.html:
      * fast/viewport/viewport-52.html:
      * fast/viewport/viewport-53.html:
      * fast/viewport/viewport-54.html:
      * fast/viewport/viewport-55.html:
      * fast/viewport/viewport-56.html:
      * fast/viewport/viewport-57.html:
      * fast/viewport/viewport-58.html:
      * fast/viewport/viewport-59.html:
      * fast/viewport/viewport-6.html:
      * fast/viewport/viewport-60.html:
      * fast/viewport/viewport-61.html:
      * fast/viewport/viewport-62.html:
      * fast/viewport/viewport-63.html:
      * fast/viewport/viewport-64.html:
      * fast/viewport/viewport-65.html:
      * fast/viewport/viewport-66.html:
      * fast/viewport/viewport-67.html:
      * fast/viewport/viewport-68.html:
      * fast/viewport/viewport-69.html:
      * fast/viewport/viewport-7.html:
      * fast/viewport/viewport-70.html:
      * fast/viewport/viewport-71.html:
      * fast/viewport/viewport-72.html:
      * fast/viewport/viewport-73.html:
      * fast/viewport/viewport-74.html:
      * fast/viewport/viewport-75.html:
      * fast/viewport/viewport-76.html:
      * fast/viewport/viewport-77.html:
      * fast/viewport/viewport-78.html:
      * fast/viewport/viewport-79.html:
      * fast/viewport/viewport-8.html:
      * fast/viewport/viewport-80.html:
      * fast/viewport/viewport-81.html:
      * fast/viewport/viewport-82.html:
      * fast/viewport/viewport-83.html:
      * fast/viewport/viewport-84.html:
      * fast/viewport/viewport-85.html:
      * fast/viewport/viewport-86.html:
      * fast/viewport/viewport-87.html:
      * fast/viewport/viewport-88.html:
      * fast/viewport/viewport-9.html:
      * fast/viewport/viewport-90.html:
      * fast/viewport/viewport-91.html:
      * fast/viewport/viewport-legacy-handheldfriendly.html:
      * fast/viewport/viewport-legacy-mobileoptimized-2.html:
      * fast/viewport/viewport-legacy-mobileoptimized-3.html:
      * fast/viewport/viewport-legacy-mobileoptimized.html:
      * fast/viewport/viewport-legacy-ordering-1.html:
      * fast/viewport/viewport-legacy-ordering-2.html:
      * fast/viewport/viewport-legacy-ordering-3.html:
      * fast/viewport/viewport-legacy-ordering-4.html:
      * fast/viewport/viewport-legacy-ordering-5.html:
      * fast/viewport/viewport-legacy-ordering-6.html:
      * fast/viewport/viewport-legacy-ordering-7.html:
      * fast/viewport/viewport-legacy-ordering-8.html:
      * fast/viewport/viewport-legacy-ordering-9.html:
      * fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html:
      * fast/viewport/viewport-legacy-xhtmlmp-ordering.html:
      * fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html:
      * fast/viewport/viewport-legacy-xhtmlmp.html:
      * fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html:
      * fast/viewport/viewport-limits-adjusted-for-no-user-scale.html:
      * fast/viewport/viewport-warnings-1.html:
      * fast/viewport/viewport-warnings-2.html:
      * fast/viewport/viewport-warnings-3.html:
      * fast/viewport/viewport-warnings-4.html:
      * fast/viewport/viewport-warnings-5.html:
      * fast/viewport/viewport-warnings-6.html:
      * fullscreen/video-cursor-auto-hide-expected.txt:
      * fullscreen/video-cursor-auto-hide.html:
      * http/tests/inspector-enabled/resources/console-clear-arguments-test.js:
      (dumpConsoleMessageArgumentCounts):
      * http/tests/inspector/elements-test.js:
      * networkinformation/resources/event-after-navigation-new.html:
      * networkinformation/script-tests/add-listener-from-callback.js:
      (firstListener):
      * networkinformation/script-tests/basic-all-types-of-events.js:
      * networkinformation/script-tests/basic-operation.js:
      * networkinformation/script-tests/multiple-frames.js:
      * networkinformation/script-tests/updates.js:
      (setNetworkInformation):
      * platform/efl-wk2/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
      * platform/mac-wk2/tiled-drawing/clamp-out-of-bounds-scrolls.html:
      * platform/mac-wk2/tiled-drawing/fixed/absolute-inside-fixed.html:
      * platform/mac-wk2/tiled-drawing/fixed/absolute-inside-out-of-view-fixed.html:
      * platform/mac-wk2/tiled-drawing/fixed/fixed-in-overflow.html:
      * platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex.html:
      * platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view.html:
      * platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html:
      * platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed.html:
      * platform/mac-wk2/tiled-drawing/fixed/four-bars.html:
      * platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view.html:
      * platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset.html:
      * platform/mac-wk2/tiled-drawing/fixed/nested-fixed.html:
      * platform/mac-wk2/tiled-drawing/fixed/percentage-inside-fixed.html:
      * platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-in-frame.html:
      * platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-with-page-scale.html:
      * platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing.html:
      * platform/mac-wk2/tiled-drawing/scrolling-tree-after-scroll.html:
      * platform/mac-wk2/tiled-drawing/scrolling-tree-slow-scrolling.html:
      * platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle.html:
      * platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle.html:
      * platform/mac-wk2/tiled-drawing/slow-scrolling.html:
      * platform/mac-wk2/tiled-drawing/sticky/negative-scroll-offset.html:
      * platform/mac-wk2/tiled-drawing/sticky/sticky-horizontal.html:
      * platform/mac-wk2/tiled-drawing/sticky/sticky-vertical.html:
      * platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
      * platform/mac/editing/spelling/autocorrection-blockquote-crash.html:
      * platform/mac/editing/spelling/delete-into-misspelled-word.html:
      * platform/mac/editing/spelling/editing-multiple-words-with-markers.html:
      * platform/mac/editing/spelling/editing-word-with-marker-1.html:
      * platform/mac/editing/spelling/editing-word-with-marker-2.html:
      * platform/mac/editing/spelling/move-cursor-around-misspelled-word.html:
      * platform/win/editing/spelling/spelling-backspace-between-lines-expected.txt:
      * printing/page-format-data-expected.txt:
      * printing/page-format-data.html:
      * proximity/add-listener-from-callback.html:
      * proximity/basic-operation.html:
      * proximity/multiple-frames.html:
      * proximity/resources/event-after-navigation-new.html:
      * proximity/updates.html:
      * scrollingcoordinator/resources/non-fast-scrollable-region-testing.js:
      (runNonFastScrollableRegionTest):
      * touchadjustment/big-div.html:
      * touchadjustment/event-triggered-widgets.html:
      * touchadjustment/iframe.html:
      * touchadjustment/nested-shadow-node.html:
      * touchadjustment/resources/touchadjustment.js:
      (testTouchPoint):
      (testTouchPointContextMenu):
      (adjustTouchPoint):
      (adjustTouchPointContextMenu):
      * touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset.html:
      * touchadjustment/scroll-offset.html:
      * touchadjustment/search-cancel.html:
      * touchadjustment/zoom-basic.html:
      * touchadjustment/zoom-fatfinger.html:
      * transitions/created-while-suspended.html:
      * transitions/started-while-suspended.html:
      * transitions/suspend-transform-transition.html:
      * userscripts/insert-stylesheets.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e466981
    • calvaris@igalia.com's avatar
      Remove HTMLMediaElement.startTime · 7269308e
      calvaris@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123264
      
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      Patch based on one by: philipj@opera.com
      Blink review URL: https://codereview.chromium.org/32583003
      
      startTime has been removed from the HTMLMediaElement and its use
      in the rest of components.
      
      * Modules/mediacontrols/mediaControlsApple.js:
      (Controller.prototype.handleRewindButtonClicked):
      (Controller.prototype.handleTimelineMouseMove):
      (Controller.prototype.updateDuration):
      (Controller.prototype.updateTime): Removed used of startTime().
      * bindings/gobject/WebKitDOMCustom.cpp:
      (webkit_dom_html_media_element_get_start_time):
      * bindings/gobject/WebKitDOMCustom.h:
      * bindings/gobject/WebKitDOMCustom.symbols: Added phony function.
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
      (WebCore::HTMLMediaElement::isBlockedOnMediaController): Removed
      use of startTime()
      * html/HTMLMediaElement.h:
      * html/HTMLMediaElement.idl: Removed startTime()
      * rendering/RenderThemeWinCE.cpp:
      (WebCore::RenderThemeWinCE::paintSliderThumb): Removed use of
      startTime()
      
      LayoutTests:
      
      Removed test about startTime.
      
      Blink review URL: https://codereview.chromium.org/32583003
      
      * media/media-startTime-expected.txt: Removed.
      * media/media-startTime.html: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7269308e
    • akling@apple.com's avatar
      RenderElement::m_style should be a Ref. · 57c582cf
      akling@apple.com authored
      <https://webkit.org/b/123401>
      
      Source/WebCore:
      
      Made RenderElement::m_style a Ref. This codifies the fact that it
      can never be null after construction.
      
      Removed a couple of unnecessary null checks that were exposed as
      compilation failures.
      
      Reviewed by Antti Koivisto.
      
      Source/WTF:
      
      Added a Ref::replace() so we can Indiana Jones the new style in
      RenderElement::setStyle() while keeping a handle on the old style
      for a while longer.
      
      Reviewed by Antti Koivisto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57c582cf
    • commit-queue@webkit.org's avatar
      Name all the GLib timeout sources · 47e30f37
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123229
      
      Patch by Bastien Nocera <hadess@hadess.net> on 2013-10-28
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      Give a name to GLib timeout sources, this is helpful when
      profiling WebKitGTK applications.
      
      No new tests, no change in functionality.
      
      Source/WebKit/gtk:
      
      Give a name to GLib timeout sources, this is helpful when
      profiling WebKitGTK applications.
      
      Source/WebKit2:
      
      Give a name to GLib timeout sources, this is helpful when
      profiling WebKitGTK applications.
      
      Tools:
      
      Give a name to GLib timeout sources, this is helpful when
      profiling WebKitGTK applications.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47e30f37
    • philn@webkit.org's avatar
      MediaStreamTrackPrivate's m_client uninitialized · ea7ffb14
      philn@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123403
      
      Reviewed by Eric Carlson.
      
      No new tests, no change in functionality.
      
      * platform/mediastream/MediaStreamTrackPrivate.cpp:
      (WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate):
      Initialize the m_client member variable.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea7ffb14
    • carlosgc@webkit.org's avatar
      Unreviewed. Fix make distcheck. · d4b2f78b
      carlosgc@webkit.org authored
      Source/JavaScriptCore:
      
      * GNUmakefile.list.am: Add missing files to compilation.
      
      Source/WebCore:
      
      * GNUmakefile.am: Add crypto idl files to EXTRA_DIST and remove
      css/fullscreenQuickTime.css that was removed.
      
      Source/WebKit2:
      
      * GNUmakefile.am: Add messages.in files in
      UIProcess/Network/CustomProtocols/ to EXTRA_DIST.
      * GNUmakefile.list.am: Remove
      WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp from
      compilation because it depends on code generated only when
      database process is enabled.
      
      Source/WTF:
      
      * GNUmakefile.list.am: Remove unexistent file from compilation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4b2f78b
    • antti@apple.com's avatar
      Prepare simple line layout to support multiple runs per line · fea51996
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123400
      
      Reviewed by Andreas Kling.
      
      Bunch of renaming and some refactoring for future support for text runs.
      
      SimpleLineLayout::Lines -> SimpleLineLayout::Layout and becomes a class instead of a typedef.
      SimpleLineLayout::Resolver::Line -> SimpleLineLayout::Resolver::Run
      SimpleLineLayout::createLines() -> SimpleLineLayout::create()
      RenderBlockFlow::simpleLines() -> RenderBlockFlow::simpleLineLayout()
      RenderText::simpleLines() -> RenderText::simpleLineLayout()
              
      Added resolver construction functions:
              
      SimpleLineLayout::runResolver()
      SimpleLineLayout::lineResolver()
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fea51996
    • gyuyoung.kim@samsung.com's avatar
      Unreviewed, EFL gardening. · 0931c9ef
      gyuyoung.kim@samsung.com authored
      fast/canvas/webgl/drawingbuffer-test.html is passing on efl-wk2.
      Move it to efl-wk1 TestExpectations file.
      
      * platform/efl-wk1/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0931c9ef
    • berto@igalia.com's avatar
      [WK2] [GTK] Allow running the web process with an arbitrary prefix command · f3db2ace
      berto@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123201
      
      Reviewed by Carlos Garcia Campos.
      
      Launch the web process using WEB_PROCESS_CMD_PREFIX as a
      prefix. Useful for debugging the web process with gdb, valgrind,
      etc.
      
      * UIProcess/Launcher/ProcessLauncher.h:
      * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
      (WebKit::ProcessLauncher::launchProcess):
      * UIProcess/gtk/WebProcessProxyGtk.cpp:
      (WebKit::WebProcessProxy::platformGetLaunchOptions):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3db2ace
    • mario@webkit.org's avatar
      [GTK] Expose title and alternative text for links in image maps · 815faaca
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84045
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Change the way we decide when the title attribute should be
      used for the accessible description, by not relying in the
      titleTagShouldBeUsedInDescriptionField() helper function but
      in whether we have found a visible text for it or not.
      
      This actually mimics what the Mac port does and so makes possible
      to share both the layout test and its expected results.
      
      * accessibility/atk/WebKitAccessibleUtil.cpp:
      (accessibilityDescription): Update the method to determine
      whether the title attribute should be used for the description.
      
      LayoutTests:
      
      Share test expectations among Mac, GTK and EFL ports and
      remove expected failures for GTK and EFL.
      
      * accessibility/image-map1-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/image-map1-expected.txt.
      * platform/gtk/accessibility/image-map1-expected.txt: Removed.
      * platform/efl/TestExpectations: Removed failure expectations.
      * platform/gtk/TestExpectations: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      815faaca
    • commit-queue@webkit.org's avatar
      Replace 0 timeouts g_timeout_add() by g_idle_add() · 19cb1b7c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123260
      
      Patch by Bastien Nocera <hadess@hadess.net> on 2013-10-28
      Reviewed by Carlos Garcia Campos.
      
      A zero timeout should be equivalent to using g_idle_add_full(G_PRIORITY_DEFAULT, ...)
      without the nagging feeling that the wrong API was used.
      
      Source/WebCore:
      
      No new tests, no change in functionality.
      
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Use g_idle_add() instead
      of 0-timer.
      (WebCore::MediaPlayerPrivateGStreamer::videoChanged):
      (WebCore::MediaPlayerPrivateGStreamer::audioChanged):
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: Ditto.
      (WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
      (WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):
      * platform/gtk/GtkDragAndDropHelper.cpp: Ditto.
      (WebCore::GtkDragAndDropHelper::handleDragLeave):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ChromeClientGtk.cpp: Use g_idle_add() instead
      of 0-timer.
      (WebKit::ChromeClient::closeWindowSoon):
      (WebKit::ChromeClient::widgetSizeChanged):
      * WebCoreSupport/GtkAdjustmentWatcher.cpp: Ditto.
      (WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater):
      * webkit/webkitwebview.cpp: Ditto.
      (webkit_web_view_get_subresources):
      
      Source/WTF:
      
      * wtf/gtk/MainThreadGtk.cpp: Use g_idle_add() instead
      of 0-timer.
      (WTF::scheduleDispatchFunctionsOnMainThread):
      
      Tools:
      
      * DumpRenderTree/gtk/DumpRenderTree.cpp: Use g_idle_add() instead
      of 0-timer.
      (topLoadingFrameLoadFinished):
      * DumpRenderTree/gtk/EventSender.cpp: Ditto.
      (scheduleAsynchronousClickCallback):
      (scheduleAsynchronousKeyDownCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19cb1b7c
    • zandobersek@gmail.com's avatar
      Re-enable simple line layout for GTK · 4e0287df
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123388
      
      Reviewed by Andreas Kling.
      
      Source/WebCore: 
      
      * rendering/SimpleLineLayout.cpp:
      (WebCore::SimpleLineLayout::canUseFor): 8-bit TextRun support is now enabled for the GTK port, so the port
      can use the simple line layout.
      
      Source/WTF: 
      
      * wtf/FeatureDefines.h: Enable the 8-bit TextRun support for the GTK port.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e0287df
  2. 27 Oct, 2013 5 commits
    • beidson@apple.com's avatar
      WebIconDatabase can miss private browsing state changes. · e4e18b25
      beidson@apple.com authored
      <rdar://problem/15322318> and https://bugs.webkit.org/show_bug.cgi?id=123375
      
      Reviewed by Alexey Proskuryakov.
      
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::willStartUsingPrivateBrowsing): Call setAnyPageGroupMightHavePrivateBrowsingEnabled(true) on each context.
      (WebKit::WebContext::willStopUsingPrivateBrowsing): Call setAnyPageGroupMightHavePrivateBrowsingEnabled(false) on each context.
      (WebKit::WebContext::setPrivateBrowsingEnabled): In addition to notifying other processes about private browsing
        sessions, notify the context’s WebIconDatabase about the change in value.
      * UIProcess/WebContext.h:
      
      * UIProcess/WebIconDatabase.cpp:
      (WebKit::WebIconDatabase::setDatabasePath): Prime the IconDatabase with an initial private browsing value.
      (WebKit::WebIconDatabase::setAnyPageGroupMightHavePrivateBrowsingEnabled):
      * UIProcess/WebIconDatabase.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4e18b25
    • akling@apple.com's avatar
      Fix 4 asserting SVG tests after r158097. · 2cc5242a
      akling@apple.com authored
      RenderElement::setStyle() is, quite surprisingly, a virtual function
      with a single override in RenderSVGBlock.
      To match the old behavior, we have to rewrite the display type from
      any inline type to block instead.
      
      * rendering/RenderElement.cpp:
      (WebCore::RenderElement::initializeStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2cc5242a
    • akling@apple.com's avatar
      Tone down overzealous assertion from r158097. · 6fdcfde9
      akling@apple.com authored
      RenderElement::initializeStyle() really only cares that there are no
      text renderers that we should be calling styleDidChange() on.
      
      Tweak the code to only check that there are no text children.
      
      * rendering/RenderElement.cpp:
      (WebCore::RenderElement::initializeStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fdcfde9
    • antti@apple.com's avatar
      Enable center and right text alignment for simple lines · 048b6ceb
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123398
      
      Reviewed by Andreas Kling.
      
      Support text-align:center and text-align:right on simple line layout path.
      
      * rendering/SimpleLineLayout.cpp:
      (WebCore::SimpleLineLayout::canUseFor):
              
          text-align:justify is still not supported.
      
      (WebCore::SimpleLineLayout::computeLineLeft):
      (WebCore::SimpleLineLayout::createLines):
              
          Do a rounding dance that matches the line boxes.
      
      * rendering/SimpleLineLayout.h:
              
          Add left position to lines.
      
      * rendering/SimpleLineLayoutResolver.h:
      (WebCore::SimpleLineLayout::Resolver::Line::rect):
              
          We now do rounding during layout.
      
      (WebCore::SimpleLineLayout::Resolver::Line::baseline):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      048b6ceb
    • akling@apple.com's avatar
      Renderers should receive their style at construction. · 8f40c5bc
      akling@apple.com authored
      <https://webkit.org/b/123396>
      
      Pass the RenderStyle to all non-text renderer constructors.
      After construction, initializeStyle() must be called (as a stopgap
      measure) until we are able to do style-derived initialization
      without virtual function calls.
      
      With this change, RenderElement::m_style is never null. Subsequent
      patches will add enforcement for this and also make style() return
      a RenderStyle&.
      
      I'm adding three FIXME's in this patch:
      
          - createRendererIfNeeded() calls AnimationController to set up
            the initial style manually instead of asking RenderElement's
            setAnimatedStyle() to do it. This can probably be done in a
            nicer way, but it's not clear yet how.
      
          - ImageContentData::createRenderer() does a bit of unnecessary
            work. This should be easy to clean up but got too distracting
            to be part of this patch.
      
          - Document::createRenderTree() creates the RenderView with an
            initial dummy RenderStyle. I've done this because resolving
            the document style assumes we already have a RenderView.
      
      For styleWillChange() implementations to detect that they are
      reacting to the initial style, I've added a hasInitializedStyle()
      function on RenderElement. This will return false until you've
      called initializeStyle() on the renderer. This should go away
      along with initializeStyle() eventually.
      
      Reviewed by Antti Koivisto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f40c5bc
  3. 26 Oct, 2013 2 commits
    • timothy_horton@apple.com's avatar
      [mac] Remove WebTiledLayer · a4d0b2fb
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123395
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      Mac doesn't use CATiledLayer at all anymore. We have to keep
      LayerTypeTiledLayer around for Windows, for now, but we can
      get rid of WebTiledLayer and some related Mac-specific code.
      
      No new tests, just removing dead code.
      
      * WebCore.xcodeproj/project.pbxproj:
      Remove WebTiledLayer.*
      
      * platform/graphics/ca/PlatformCALayer.h:
      * platform/graphics/ca/mac/PlatformCALayerMac.h:
      * platform/graphics/ca/mac/PlatformCALayerMac.mm:
      (PlatformCALayerMac::PlatformCALayerMac):
      Remove synchronouslyDisplayTilesInRect, which was only used for WebTiledLayer on Mac.
      Remove WebTiledLayer instantiation and setup code.
      
      * platform/graphics/mac/WebTiledLayer.h: Removed.
      * platform/graphics/mac/WebTiledLayer.mm: Removed.
      
      Source/WebKit2:
      
      * WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
      * WebProcess/WebPage/mac/PlatformCALayerRemote.h:
      Remove synchronouslyDisplayTilesInRect.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4d0b2fb
    • rniwa@webkit.org's avatar
      Make new bug link in flakiness dashboard configurable · 8a0a4379
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123386
      
      Reviewed by Alexey Proskuryakov.
      
      * config.json: Added Bugzilla as the default destination for new bugs.
      * public/api/manifest.php: Include newBugLinks in the manifest.
      * public/index.html:
      (TestResultsView): Initialize _newBugLinks.
      (TestResultsView.setNewBugLinks): Added.
      (TestResultsView._populateTestPane):
      (TestResultsView._createTestResultRow): Replaced the hard-coded Bugzilla URL by the code
      to generate hyper-links based on _newBugLinks. Also added a nullity check while formatting
      revision checks so that we don't blow up when some build doesn't contain all revision info.
      (TestResultsView._populateBuilderPane):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a0a4379