1. 14 Feb, 2011 1 commit
  2. 13 Feb, 2011 27 commits
    • simon.fraser@apple.com's avatar
      2011-02-13 Simon Fraser <simon.fraser@apple.com> · 6e04ec61
      simon.fraser@apple.com authored
              Change previous test to dump as text, with pixel output, to fix
              Qt failure.
      
              * fast/gradients/css3-repeating-end-fill-expected.txt:
              * fast/gradients/css3-repeating-end-fill.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e04ec61
    • mrowe@apple.com's avatar
      Versioning. · 944a0489
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      944a0489
    • darin@apple.com's avatar
      2011-02-12 Darin Adler <darin@apple.com> · 41dacc54
      darin@apple.com authored
              Reviewed by Alexey Proskuryakov.
      
              Add built-in decoder for UTF-8 for improved performance
              https://bugs.webkit.org/show_bug.cgi?id=53898
      
              Covered by existing tests; not adding new tests at this time.
      
              This patch now handles errors in the same way the existing codecs do,
              and so passes our tests. The previous version failed some tests because
              of incorrect error handling.
      
              * platform/text/TextCodecICU.cpp:
              (WebCore::create): Renamed from newTextCodecICU, made a static member
              function, and added a call to adoptPtr.
              (WebCore::TextCodecICU::registerEncodingNames): Renamed from
              registerExtendedEncodingNames since this class is no longer used for
              base codecs. Removed aliases for UTF-8; now handled by TextCodecUTF8.
              (WebCore::TextCodecICU::registerCodecs): Renamed.
              (WebCore::fallbackForGBK): Renamed to conform to our current style.
      
              * platform/text/TextCodecICU.h: Updated for above changes. Changed
              indentation. Made most functions private, including virtual function
              overrides. Marked ICUConverterWrapper noncopyable.
      
              * platform/text/TextCodecUTF8.cpp:
              (WebCore::TextCodecUTF8::registerEncodingNames): Added the UTF-8 aliases
              that were formerly added by TextCodecICU.
              (WebCore::nonASCIISequenceLength): Fixed bug where this would return 4 for
              bytes F5-FF instead of failing.
              (WebCore::decodeNonASCIISequence): Tweaked coding style.
              (WebCore::appendCharacter): Added. Makes it easier to share code between
              the partial-character handling and main loop.
              (WebCore::TextCodecUTF8::decode): Fixed buffer size computation for case
              where there is a partial sequence. Fixed partial sequence handling so that
              goto is no longer needed, since compilers sometimes make poor code when
              goto is involved. Added a loop for partial sequences since we consume only
              one byte when a partial sequence is invalid. Fixed logic in main decoding
              loop so goto is not needed. Used early-exit style in both loops so the main
              flow is not nested inside if statements. Added correct error handling for
              flush when a partial sequence remains, which involved wrapping the function
              in yet another loop.
      
              * platform/text/TextCodecUTF8.h: Made virtual function overrides private.
      
              * platform/text/TextEncodingRegistry.cpp:
              (WebCore::buildBaseTextCodecMaps): Added calls to TextCodecUTF8. Removed
              calls to TextCodecICU. Added FIXMEs for other codecs that no longer need
              to be included here.
              (WebCore::extendTextCodecMaps): Updated for the name change of the
              TextCodecICU functions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41dacc54
    • mrowe@apple.com's avatar
      <rdar://problem/8995490> WebCoreAuthenticationClientAsChallengeSender doesn't... · 96b1c28b
      mrowe@apple.com authored
      <rdar://problem/8995490> WebCoreAuthenticationClientAsChallengeSender doesn't implement some necessary methods.
      
      Reviewed by Maciej Stachowiak.
      
      * platform/network/mac/AuthenticationMac.mm:
      (-[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:]):
      (-[WebCoreAuthenticationClientAsChallengeSender rejectProtectionSpaceAndContinueWithChallenge:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96b1c28b
    • simon.fraser@apple.com's avatar
      2011-02-13 Simon Fraser <simon.fraser@apple.com> · ff2414b7
      simon.fraser@apple.com authored
              Reviewed by Andreas Kling.
      
              Repeating gradients drawn incorrectly
              https://bugs.webkit.org/show_bug.cgi?id=53502
      
              The 'forward-fill' logic for repeating gradients used the wrong
              starting stop index (0 rather than the original first index), which
              resulted in incorrect gradients if backwards-fill had already been
              applied.
      
              Test: fast/gradients/css3-repeating-end-fill.html
      
              * css/CSSGradientValue.cpp:
              (WebCore::CSSGradientValue::addStops):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff2414b7
    • benjamin.poulain@nokia.com's avatar
      2011-02-13 Benjamin Poulain <benjamin.poulain@nokia.com> · 7825d882
      benjamin.poulain@nokia.com authored
              Reviewed by Andreas Kling.
      
              Unused variable result in RenderBlock::addOverflowFromFloats()
              https://bugs.webkit.org/show_bug.cgi?id=54363
      
              Remove the unused variable.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::addOverflowFromFloats):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7825d882
    • cwzwarich@webkit.org's avatar
      Reviewed by Anders Carlsson. · 668deb6a
      cwzwarich@webkit.org authored
      WebCore fails to build with Clang's -Woverloaded-virtual
      https://bugs.webkit.org/show_bug.cgi?id=54367
      
      * loader/PingLoader.h:
      (WebCore::PingLoader::didReceiveData): Change the method signature to match the signature
      in the base class.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      668deb6a
    • andreas.kling@nokia.com's avatar
      2011-02-13 Andreas Kling <kling@webkit.org> · bc737368
      andreas.kling@nokia.com authored
              Unreviewed, remove unnecessary platform expectations for now-passing test.
      
              * platform/chromium/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Removed.
              * platform/mac/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc737368
    • andersca@apple.com's avatar
      Speculative fix for · 524684e3
      andersca@apple.com authored
      Reviewed by Maciej Stachowiak.
      
      <rdar://problem/8995361>
      CrashTracer: [USER] 47 crashes in WebProcess at com.apple.WebKit2: WebKit::WebPage::layoutIfNeeded + 4
      
      * WebProcess/WebPage/DrawingAreaImpl.cpp:
      (WebKit::DrawingAreaImpl::~DrawingAreaImpl):
      Invalidate the layer tree host.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      524684e3
    • andersca@apple.com's avatar
      2011-02-13 Nico Weber <thakis@chromium.org> · 47f18736
      andersca@apple.com authored
              Reviewed by Anders Carlsson.
      
              RenderBR::width() tries but fails to override RenderText::width()
              https://bugs.webkit.org/show_bug.cgi?id=54301
      
              The superclass method's signature changed, e.g. in
              http://trac.webkit.org/changeset/57215, but the subclass was not
              updated.
      
              * rendering/RenderBR.h:
              (WebCore::RenderBR::width):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47f18736
    • hamaji@chromium.org's avatar
      2011-02-13 Shinichiro Hamaji <hamaji@chromium.org> · bde673f9
      hamaji@chromium.org authored
              Fix chromium's test_expectations
      
              - fast/inline/inline-box-background-* should be IMAGE instead of IMAGE+TEXTfor Mac
              - fast/css/test-setting-canvas-color.html is failing
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bde673f9
    • andreas.kling@nokia.com's avatar
      2011-02-13 Andreas Kling <kling@webkit.org> · b0132124
      andreas.kling@nokia.com authored
              Reviewed by Dirk Schulze.
      
              Canvas: 2d.fillStyle.parse.system.html fails
              https://bugs.webkit.org/show_bug.cgi?id=39168
      
              Based on previous work by Julien Chaffraix <jchaffraix@codeaurora.org>
              and Jan Erik Hanssen <jhanssen@sencha.com>
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseColor): Changed the function to better match our
              early return policy. Also we now return false when we don't parse the color.
              This is needed for createFromString to fallback to using parseSystemColor.
      
              (WebCore::CSSParser::parseSystemColor): Made use of the RenderTheme to get
              the system colors.
      
              * css/CSSParser.h: Added the new parseSystemColor method.
      
              * html/canvas/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::setStrokeColor): Pass the document to createFromString.
              (WebCore::CanvasRenderingContext2D::setFillColor): Ditto.
      
              * html/canvas/CanvasStyle.cpp:
              (WebCore::parseColor):
              (WebCore::parseColorOrCurrentColor):
              (WebCore::CanvasStyle::createFromString): Try to parse the color using CSSParser::parseColor
              and fall back to parseSystemColor if it did not work.
      
              * html/canvas/CanvasStyle.h: Added the new Document* parameter to createFromString.
      2011-02-13  Andreas Kling  <kling@webkit.org>
      
              Reviewed by Dirk Schulze.
      
              Canvas: 2d.fillStyle.parse.system.html fails
              https://bugs.webkit.org/show_bug.cgi?id=39168
      
              * fast/css/test-setting-canvas-color-expected.txt: Added.
              * fast/css/test-setting-canvas-color.html: Added.
              * platform/gtk/Skipped:
              * platform/mac-leopard/Skipped:
              * platform/qt/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0132124
    • andersca@apple.com's avatar
      2011-02-13 Anders Carlsson <andersca@apple.com> · 0718bb49
      andersca@apple.com authored
              Reviewed by Dan Bernstein.
      
              The plug-in process heap should be executable by default
              https://bugs.webkit.org/show_bug.cgi?id=54364
              <rdar://problem/8990563>
      
              * UIProcess/Launcher/ProcessLauncher.h:
              Add executableHeap flag.
              
              * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
              (WebKit::ProcessLauncher::launchProcess):
              Set the right posix_spawn flag if executableHeap is true.
      
              * UIProcess/Plugins/PluginProcessProxy.cpp:
              (WebKit::PluginProcessProxy::PluginProcessProxy):
              Initialize executableHeap to true.
      
              * UIProcess/WebProcessProxy.cpp:
              (WebKit::WebProcessProxy::connect):
              Initialize executableHeap to false.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0718bb49
    • andersca@apple.com's avatar
      2011-02-13 Anders Carlsson <andersca@apple.com> · 199f2c40
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Messages waited on are never dispatched
              https://bugs.webkit.org/show_bug.cgi?id=54362
              <rdar://problem/8995051>
      
              * Platform/CoreIPC/Connection.cpp:
              (CoreIPC::Connection::processIncomingMessage):
              Get the argument encoder from the incoming message.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      199f2c40
    • jeremy@chromium.org's avatar
      2011-02-13 Jeremy Moskovich <jeremy@chromium.org> · c4b86e33
      jeremy@chromium.org authored
              Reviewed by Adam Barth.
      
              Add a compile-time option to completely disable WebArchive support.
              https://bugs.webkit.org/show_bug.cgi?id=52712
      
              Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.
              Ports Affected:
                  WebArchive support is currently enabled for all ports that define PLATFORM(CF) apart from Qt.
                  This patch preserves this behavior except that it also disables support in the Chromium port.
      
              * wtf/Platform.h: Add ENABLE_WEB_ARCHIVE definition and turn it off explicitly for Qt & Chromium ports.
      2011-02-13  Jeremy Moskovich  <jeremy@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add a compile-time option to completely disable WebArchive support.
              https://bugs.webkit.org/show_bug.cgi?id=52712
      
              Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.
      
              ArchiveResource and ArchiveResourceCollection are notably still compiled in. They are used
              in Safari for functionality such as "Save Image As" and Image copy & paste independent of
              WebArchive support.
      
              Ports Affected:
                  WebArchive support is currently enabled for all ports that define PLATFORM(CF) apart from Qt.
                  This patch preserves this behavior except that it also disables support in the Chromium port.
      
              No behavior changes so no new tests.
      
              * WebCore.gyp/WebCore.gyp: Don't compile LegacyWebArchive.cpp and friends.
              * WebCore.pro: Don't compile ArchiveFactory.cpp in Qt port.
              * loader/DocumentLoader.cpp: Surround WebArchive code with #ifdef.
              (WebCore::DocumentLoader::commitLoad):
              (WebCore::DocumentLoader::setupForReplaceByMIMEType):
              (WebCore::DocumentLoader::archiveResourceForURL):
              * loader/DocumentLoader.h:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::loadURLIntoChildFrame):
              (WebCore::FrameLoader::stopAllLoaders):
              (WebCore::FrameLoader::finishedLoadingDocument):
              * loader/FrameLoader.h:
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::start):
              * loader/archive/ArchiveFactory.cpp: Remove #ifdef since feature is now enabled/disabled wholesale.
              (WebCore::archiveMIMETypes):
              * page/Settings.cpp:
              * page/Settings.h:
              * platform/MIMETypeRegistry.cpp:
              (WebCore::initializeSupportedNonImageMimeTypes):
      2011-02-13  Jeremy Moskovich  <jeremy@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add a compile-time option to completely disable WebArchive support.
              https://bugs.webkit.org/show_bug.cgi?id=52712
      
              Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::updatePreferences):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4b86e33
    • andreas.kling@nokia.com's avatar
      2011-02-13 Aparna Nandyal <aparna.nand@wipro.com> · dbe25632
      andreas.kling@nokia.com authored
              Reviewed by Andreas Kling.
      
              [Qt] QtWebKit does not properly handle D&D of a percent-encoded URL.
              https://bugs.webkit.org/show_bug.cgi?id=53320
      
              The encoding that was done is corrected in the fix.  
              Replaced the KURL encoding function with QUrl API.
      
              * platform/qt/DragDataQt.cpp:
              (WebCore::DragData::asURL):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78438 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbe25632
    • commit-queue@webkit.org's avatar
      2011-02-13 Leo Yang <leo.yang.c@gmail.com> · fa081ee1
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              Unnecessary call of containingBlock() in RenderBoxModelObject::relativePositionOffsetX()
              https://bugs.webkit.org/show_bug.cgi?id=54351
      
              We were calling containingBlock() twice if the left is not auto. We only need to call it
              once because we can use 'cb' variable in the following line.
      
              No functionality change, no new tests.
      
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::relativePositionOffsetX):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa081ee1
    • commit-queue@webkit.org's avatar
      2011-02-13 Jarred Nicholls <jarred@sencha.com> · 1284031b
      commit-queue@webkit.org authored
              Reviewed by Simon Fraser.
      
              getComputedStyle returns wrong value for margin-right
              https://bugs.webkit.org/show_bug.cgi?id=13343
      
              Matching IE, Firefox, and Opera behavior by returning the computed margin
              values as specified, rather than the used/auto values (calculated via RenderBox).
              Also CSS 2.1+ compliant by returning margin percentage as specified, if applicable.
              Note: Firefox and Opera return calculated fixed lengths for percentage margins, IE
              returns the specified percentage.
      
              * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
              * platform/chromium-mac/fast/css/computed-style-without-renderer-expected.txt
              * platform/chromium-win/fast/css/computed-style-without-renderer-expected.txt
              * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
              * platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
              * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
              * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
              * fast/css/getComputedStyle/getComputedStyle-margin-auto-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle/marginComputedStyle-expected.txt.
              * fast/css/getComputedStyle/getComputedStyle-margin-auto.html: Copied from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.
              * fast/css/getComputedStyle/getComputedStyle-margin-length-expected.txt: Added.
              * fast/css/getComputedStyle/getComputedStyle-margin-length.html: Copied from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.
              * fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Added.
              * fast/css/getComputedStyle/getComputedStyle-margin-percentage.html: Renamed from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.
      2011-02-13  Jarred Nicholls  <jarred@sencha.com>
      
              Reviewed by Simon Fraser.
      
              getComputedStyle returns wrong value for margin-right
              https://bugs.webkit.org/show_bug.cgi?id=13343
      
              Matching IE, Firefox, and Opera behavior by returning the computed margin
              values as specified, rather than the used/auto values (calculated via RenderBox).
              Also CSS 2.1+ compliant by returning margin percentage as specified, if applicable.
              Note: Firefox and Opera return calculated fixed lengths for percentage margins, IE
              returns the specified percentage.
      
              Tests: fast/css/getComputedStyle/getComputedStyle-margin-auto.html
                     fast/css/getComputedStyle/getComputedStyle-margin-length.html
                     fast/css/getComputedStyle/getComputedStyle-margin-percentage.html
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1284031b
    • abarth@webkit.org's avatar
      2011-02-13 Adam Barth <abarth@webkit.org> · 42d9cab1
      abarth@webkit.org authored
              Reviewed by Sam Weinig.
      
              crypto.getRandomValues should throw TYPE_MISMATCH_ERR
              https://bugs.webkit.org/show_bug.cgi?id=54346
      
              * security/crypto-random-values-types-expected.txt:
      2011-02-13  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Sam Weinig.
      
              crypto.getRandomValues should throw TYPE_MISMATCH_ERR
              https://bugs.webkit.org/show_bug.cgi?id=54346
      
              As requested by Sam.
      
              * page/Crypto.cpp:
              (WebCore::Crypto::getRandomValues):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42d9cab1
    • ap@apple.com's avatar
      2011-02-13 Alexey Proskuryakov <ap@apple.com> · 7f38bfec
      ap@apple.com authored
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=54349
              Inline some accessors in PrintContext
      
              No change in behavior, so no tests.
      
              * WebCore.exp.in:
              * page/PrintContext.cpp:
              * page/PrintContext.h:
              (WebCore::PrintContext::pageCount):
              (WebCore::PrintContext::pageRect):
              Inline pageCount() and pageRect() to match pageRects().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f38bfec
    • weinig@apple.com's avatar
      Roll r78424 [Extra scrolling required when scrolling with a scroll wheel (Mighty Mouse)] back · 503480b0
      weinig@apple.com authored
      in with fixes to make it work with render layers.
      
      * platform/mac/ScrollAnimatorMac.h:
      * platform/mac/ScrollAnimatorMac.mm:
      (WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
      (WebCore::ScrollAnimatorMac::adjustScrollXPositionIfNecessary):
      (WebCore::ScrollAnimatorMac::adjustScrollYPositionIfNecessary):
      (WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):
      (WebCore::ScrollAnimatorMac::immediateScrollToPoint):
      (WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
      (WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::RenderLayer):
      (WebCore::RenderLayer::contentsSize):
      (WebCore::RenderLayer::visibleHeight):
      (WebCore::RenderLayer::visibleWidth):
      (WebCore::RenderLayer::updateScrollInfoAfterLayout):
      * rendering/RenderLayer.h:
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::visibleHeight):
      (WebCore::RenderListBox::visibleWidth):
      * rendering/RenderListBox.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      503480b0
    • ap@apple.com's avatar
      2011-02-13 Alexey Proskuryakov <ap@apple.com> · 5bb68f82
      ap@apple.com authored
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=54348
              Crash when printing a document with no pages
      
              * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawPagesToPDF): Don't fail on a fake
              page that computePagesForPrinting() added to a pageless document.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5bb68f82
    • weinig@apple.com's avatar
      Some Scrollbar functions assume an attached ScrollableArea but can be called without one · a739e9b5
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=54262
      
      Reviewed by Dan Bernstein.
      
      Make sure that all calls to the scrollable area are null checked.
      
      * platform/Scrollbar.cpp:
      (WebCore::Scrollbar::autoscrollPressedPart):
      (WebCore::Scrollbar::moveThumb):
      (WebCore::Scrollbar::mouseMoved):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a739e9b5
    • weinig@apple.com's avatar
      Roll out r78424. It broke a bunch of tests. · 4313a929
      weinig@apple.com authored
      * platform/mac/ScrollAnimatorMac.h:
      * platform/mac/ScrollAnimatorMac.mm:
      (WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
      (WebCore::ScrollAnimatorMac::immediateScrollToPoint):
      (WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
      (WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayer.h:
      (WebCore::RenderLayer::contentsSize):
      * rendering/RenderListBox.cpp:
      * rendering/RenderListBox.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4313a929
    • weinig@apple.com's avatar
      Reviewed and landed by Sam Weinig. · 1b06948d
      weinig@apple.com authored
      Patch by Chris Fleizach <cfleizach@apple.com> on 2011-02-13
      AX: Update WK2 usage of remote accessibility api
      https://bugs.webkit.org/show_bug.cgi?id=54220
      
      Rename some of the remote accessibility methods to be more accurate.
      Make sure to unregister the AccessibilityWebPageObject on dealloc.
      Send the window remote token along with the WKView remote token.
      
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::accessibilityWebProcessTokenReceived):
      * UIProcess/API/mac/WKView.mm:
      (-[WKView _updateRemoteAccessibilityRegistration:]):
      (-[WKView initWithFrame:contextRef:pageGroupRef:]):
      (-[WKView viewDidMoveToWindow]):
      (-[WKView _processDidCrash]):
      (-[WKView _pageClosed]):
      (-[WKView _setAccessibilityWebProcessToken:]):
      * UIProcess/API/mac/WKViewInternal.h:
      * UIProcess/PageClient.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
      (WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      * WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
      (-[AccessibilityWebPageObject dealloc]):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::platformInitialize):
      (WebKit::WebPage::registerUIProcessAccessibilityTokens):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b06948d
    • cwzwarich@webkit.org's avatar
      Reviewed by Dan Bernstein. · a6edc612
      cwzwarich@webkit.org authored
      Bug 53760 - JSC fails to build with TOT Clang
      https://bugs.webkit.org/show_bug.cgi?id=53760
      
      Fix -Woverloaded-virtual warnings. This is also a 6% speedup on the v8 raytrace
      benchmark; it is nothing-to-noise on everything else.
      
      JavaScriptCore:
      
      * API/JSCallbackObject.h: Remove pointlessly overloaded method.
      * API/JSCallbackObjectFunctions.h: Ditto.
      * runtime/Arguments.cpp: 
      (JSC::Arguments::put): Change signature to match the base class. This implementation
      was no longer being called by anyone. This wasn't noticed because it is merely an
      optimization of the base class' implementation.
      * runtime/Arguments.h: Ditto.
      
      JavaScriptGlue:
      
      * UserObjectImp.cpp:
      (UserObjectImp::toPrimitive): Use PreferredPrimitiveType instead of JSType to
      match the base class.
      * UserObjectImp.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6edc612
    • hamaji@chromium.org's avatar
      2011-02-13 Shinichiro Hamaji <hamaji@chromium.org> · 8d9d25a3
      hamaji@chromium.org authored
              Update chromium's test expectations for fast/inline/inline-box-background-*
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d9d25a3
  3. 12 Feb, 2011 12 commits
    • ap@apple.com's avatar
      Reviewed by Anders Carlsson. · 7fcbeb16
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=54335
              <rdar://problem/8895141> Make window.print() work with WebKit2
      
              * Platform/CoreIPC/Connection.h: Corrected a typo in FIXME comment.
      
              * UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
              (WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible):
              (WebKit::ChunkedUpdateDrawingAreaProxy::update):
              (WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
              * UIProcess/TiledDrawingAreaProxy.cpp:
              (WebKit::TiledDrawingAreaProxy::sizeDidChange):
              (WebKit::TiledDrawingAreaProxy::setPageIsVisible):
              (WebKit::TiledDrawingAreaProxy::takeSnapshot):
              (WebKit::TiledDrawingAreaProxy::removeTile):
              * UIProcess/LayerBackedDrawingAreaProxy.cpp:
              (WebKit::LayerBackedDrawingAreaProxy::sizeDidChange):
              (WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible):
              (WebKit::LayerBackedDrawingAreaProxy::update):
              * UIProcess/WebContext.cpp:
              (WebKit::WebContext::ensureWebProcess):
              (WebKit::WebContext::postMessageToInjectedBundle):
              Updated for send() -> deprecatedSend() rename.
      
              * UIProcess/WebPageProxy.h:
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::WebPageProxy): Added a flag that's true while serving window.print().
              (WebKit::WebPageProxy::printFrame): Set and unset m_isPerformingDOMPrintOperation.
              (WebKit::WebPageProxy::beginPrinting): Force message processing in web process when serving
              window.print().
              (WebKit::WebPageProxy::endPrinting): Ditto.
              (WebKit::WebPageProxy::computePagesForPrinting): Ditto.
              (WebKit::WebPageProxy::drawRectToPDF): Ditto.
              (WebKit::WebPageProxy::drawPagesToPDF): Ditto.
      
              * UIProcess/WebProcessProxy.cpp:
              (WebKit::WebProcessProxy::~WebProcessProxy):
              (WebKit::WebProcessProxy::sendMessage):
              (WebKit::WebProcessProxy::didFinishLaunching):
              When waiting for a web process to launch, store message flags, too. This is not practically
              important for DispatchMessageEvenWhenWaitingForSyncReply, but it's easier to store flags
              than to remember about this pitfall.
      
              * UIProcess/WebProcessProxy.h:
              (WebKit::WebProcessProxy::send): Added a flags argument, matching Connection::send().
              (WebKit::WebProcessProxy::deprecatedSend): Renamed one of send() overloads, because it was
              conflicting with the other one after adding a flags argument. This matches a change previously
              made to CoreIPC::Connection.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fcbeb16
    • cmarrin@apple.com's avatar
      2011-02-12 Chris Marrin <cmarrin@apple.com> · 5a69b8b2
      cmarrin@apple.com authored
              Reviewed by Dan Bernstein.
      
              Crash in RenderLayerCompositor::updateCompositingLayers when loading some sites
              https://bugs.webkit.org/show_bug.cgi?id=54345
      
              Some sites flip between composited and non-comosited state while loading. When the timing is
              right, when we flip out of compositing we will need to do a display while tossing all the
              compositing layers. This causes us to reenter RenderLayerCompositor::computeCompositingRequirements()
              while we are in the middle of tossing layers, which leads to a crash.
      
              The solution is to defer the logic of exiting compositing mode until the DrawingArea is finished
              doing its display, using a timer.
      
              * WebProcess/WebPage/DrawingAreaImpl.cpp:
              (WebKit::DrawingAreaImpl::DrawingAreaImpl):
              (WebKit::DrawingAreaImpl::setRootCompositingLayer):
              (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
              (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
              (WebKit::DrawingAreaImpl::exitAcceleratedCompositingModeSoon):
              * WebProcess/WebPage/DrawingAreaImpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a69b8b2
    • weinig@apple.com's avatar
      WK2: Extra scrolling required when scrolling with a scroll wheel (Mighty Mouse) · e71fbf3d
      weinig@apple.com authored
      <rdar://problem/8984760> 
      
      Reviewed by Dan Bernstein.
      
      When going down the smooth scroll path, constrained scrolls (such as those from a
      Mighty Mouse) were being correctly constrained at the ScrollView level, but the 
      duplicate values being stored by the animator were not being constrained correctly.
      
      In order to implement the constraint at this level, more of the ScrollableArea's API
      needed to be filled in for RenderLayer and RenderListBox.
      
      * platform/mac/ScrollAnimatorMac.h:
      * platform/mac/ScrollAnimatorMac.mm:
      (WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation): Call immediateScrollToPoint to stay
      consistent and get the desired behavior.
      
      (WebCore::ScrollAnimatorMac::adjustScrollXPositionIfNecessary):
      (WebCore::ScrollAnimatorMac::adjustScrollYPositionIfNecessary):
      (WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):
      (WebCore::ScrollAnimatorMac::immediateScrollToPoint):
      (WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
      (WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
      Ensure that the scroll animators view of the current scroll position is the
      same as the scrollable areas by correctly clamping the value.
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::contentsSize): Correct implementation
      to use the scroll size, not the visible size.
      (WebCore::RenderLayer::visibleHeight):
      (WebCore::RenderLayer::visibleWidth):
      * rendering/RenderLayer.h:
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::visibleHeight):
      (WebCore::RenderListBox::visibleWidth):
      * rendering/RenderListBox.h:
      Add implementations for visibleHeight/visibleWidth.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e71fbf3d
    • kdecker@apple.com's avatar
      Reviewed by Dan Bernstein. · b1782934
      kdecker@apple.com authored
              Follow up fix to:
              https://bugs.webkit.org/show_bug.cgi?id=54341 - optionally scale snapshots in document view coordinates
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::scaledSnapshotInDocumentCoordinates): Fixed the order of the scale and translate.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1782934
    • abarth@webkit.org's avatar
      2011-02-12 Adam Barth <abarth@webkit.org> · d8a1138c
      abarth@webkit.org authored
              Reviewed by Sam Weinig.
      
              crypto.getRandomValues should support all integer array types
              https://bugs.webkit.org/show_bug.cgi?id=54342
      
              Test which types of arrays work with crypto.getRandomValues.
      
              * security/crypto-random-values-types-expected.txt: Added.
              * security/crypto-random-values-types.html: Added.
      2011-02-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Sam Weinig.
      
              crypto.getRandomValues should support all integer array types
              https://bugs.webkit.org/show_bug.cgi?id=54342
      
              As discussed on whatwg, we should support all the integer array types.
      
              Test: security/crypto-random-values-types.html
      
              * page/Crypto.cpp:
              (WebCore::Crypto::getRandomValues):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8a1138c
    • abarth@webkit.org's avatar
      2011-02-12 Adam Barth <abarth@webkit.org> · ca9201fd
      abarth@webkit.org authored
              Reviewed by Mark Rowe.
      
              Use /dev/urandom as the OSRandomSource on OS(DARWIN)
              https://bugs.webkit.org/show_bug.cgi?id=54279
      
              I'm not sure it makes much of a difference whether we use arc4random or
              /dev/urandom on Mac.  However, there's some aesthetic benefit to using
              the same underlying API on as many platforms as reasonable.
      
              * config.h:
              * wtf/OSRandomSource.cpp:
              (WTF::cryptographicallyRandomValuesFromOS):
      2011-02-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Mark Rowe.
      
              Use /dev/urandom as the OSRandomSource on OS(DARWIN)
              https://bugs.webkit.org/show_bug.cgi?id=54279
      
              Update the ifdef.  OS(UNIX) includes OS(DARWIN), so this change is
              should be a NOP.
      
              * config.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca9201fd
    • chang.shu@nokia.com's avatar
      2011-02-12 Chang Shu <cshu@webkit.org> · 4b331957
      chang.shu@nokia.com authored
              Unreviewed.
      
              Update my own email addresses and IRC nickname.
      
              * Scripts/webkitpy/common/config/committers.py:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78420 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b331957
    • zmo@google.com's avatar
      2011-02-11 Zhenyao Mo <zmo@google.com> · 25ef79dc
      zmo@google.com authored
              Reviewed by Kenneth Russell.
      
              [chromium] Allow turning off multisampling through web preference settings
              https://bugs.webkit.org/show_bug.cgi?id=54321
      
              * public/WebSettings.h: Add a flag for multisampling setting.
              * src/WebSettingsImpl.cpp: Ditto.
              (WebKit::WebSettingsImpl::setOpenGLMultisamplingEnabled):
              * src/WebSettingsImpl.h: Ditto.
      2011-02-11  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Kenneth Russell.
      
              [chromium] Allow turning off multisampling through web preference settings
              https://bugs.webkit.org/show_bug.cgi?id=54321
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::create): Disable multisampling in WebGL if web reference says so.
              * page/Settings.cpp: Add a flag for multisampling preference.
              (WebCore::Settings::Settings):
              (WebCore::Settings::setOpenGLMultisamplingEnabled):
              * page/Settings.h: Ditto.
              (WebCore::Settings::openGLMultisamplingEnabled):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25ef79dc
    • kdecker@apple.com's avatar
      Reviewed by Dan Bernstein. · ab7176c2
      kdecker@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=54341 - optionally scale snapshots in document view coordinates
              <rdar://problem/8990069>
              
              * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
              (WKBundlePageCreateScaledSnapshotInDocumentCoordinates): Added.
              * WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added above new function.
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::scaledSnapshotInDocumentCoordinates): Added.
              (WebKit::WebPage::snapshotInDocumentCoordinates): Call scaledSnapshotInDocumentCoordinates with a scale of 1.
              * WebProcess/WebPage/WebPage.h: Added scaledSnapshotInDocumentCoordinates().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab7176c2
    • rniwa@webkit.org's avatar
      2011-02-12 Ryosuke Niwa <rniwa@webkit.org> · 33a9ab25
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              Deploy EditingStyle in applyBlockStyle and applyInlineStyle
              https://bugs.webkit.org/show_bug.cgi?id=53911
      
              Deployed EditingStyle in ApplyStyleCommand::applyBlockStyle and ApplyStyleCommand::applyInlineStyle.
              Extracted EditingStyle::extractAndRemoveTextDirection from applyInlineStyle.
              Also added propertiesToInclude to the argument list of EditingStyle's constructor that takes Node*
              so that splitAncestorsWithUnicodeBidi can call EditingStyle::textDirection to obtain the text direction.
      
              No new tests are added since this is a refactoring.
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::doApply): Passes EditingStyle* to applyBlockStyle and applyInlineStyle.
              (WebCore::ApplyStyleCommand::applyBlockStyle): Takes EditingStyle*.
              (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Changed the type of allowedDirection
              from int to WritingDirection. Uses EditingStyle's textDirection to obtain the writing direction.
              (WebCore::ApplyStyleCommand::applyInlineStyle): Takes EditingStyle*.
              (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Allows style to be null; exit early instead.
              (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Asserts that style is not null.
              (WebCore::ApplyStyleCommand::removeInlineStyle): Allows style to be null.
              * editing/ApplyStyleCommand.h: Includes WritingDirection.h; prototype changes.
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::EditingStyle): Added PropertiesToInclude to the argument.
              (WebCore::EditingStyle::init): Supports PropertiesToInclude.
              (WebCore::EditingStyle::extractAndRemoveTextDirection): Extracted from applyInlineStyle.
              * editing/EditingStyle.h:
              (WebCore::EditingStyle::create): Supports PropertiesToInclude.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33a9ab25
    • jochen@chromium.org's avatar
      2011-02-12 Jochen Eisinger <jochen@chromium.org> · b1d45628
      jochen@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              Implement IDBObjectStore::clear
              https://bugs.webkit.org/show_bug.cgi?id=54193
      
              * storage/indexeddb/objectstore-clear-expected.txt: Added.
              * storage/indexeddb/objectstore-clear.html: Added.
      2011-02-12  Jochen Eisinger  <jochen@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              Implement IDBObjectStore::clear
              https://bugs.webkit.org/show_bug.cgi?id=54193
      
              Test: storage/indexeddb/objectstore-clear.html
      
              * storage/IDBObjectStore.cpp:
              (WebCore::IDBObjectStore::clear):
              * storage/IDBObjectStore.h:
              * storage/IDBObjectStore.idl:
              * storage/IDBObjectStoreBackendImpl.cpp:
              (WebCore::IDBObjectStoreBackendImpl::clear):
              (WebCore::doDelete):
              (WebCore::IDBObjectStoreBackendImpl::clearInternal):
              * storage/IDBObjectStoreBackendImpl.h:
              * storage/IDBObjectStoreBackendInterface.h:
      2011-02-12  Jochen Eisinger  <jochen@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              Implement IDBObjectStore::clear
              https://bugs.webkit.org/show_bug.cgi?id=54193
      
              * src/IDBObjectStoreProxy.cpp:
              (WebCore::IDBObjectStoreProxy::clear):
              * src/IDBObjectStoreProxy.h:
              * src/WebIDBObjectStoreImpl.cpp:
              (WebKit::WebIDBObjectStoreImpl::clear):
              * src/WebIDBObjectStoreImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1d45628
    • abarth@webkit.org's avatar
      2011-02-12 Adam Barth <abarth@webkit.org> · d4cd0dd8
      abarth@webkit.org authored
              Another attempt to fix the EFL build.  Looks like we're missing one
              more file.
      
              * CMakeLists.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4cd0dd8