1. 26 Mar, 2013 40 commits
    • commit-queue@webkit.org's avatar
      [BlackBerry] Include accelerated compositing layers in screen captures. · 6f270615
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113335
      
      Patch by Mike Lattanzio <mlattanzio@blackberry.com> on 2013-03-26
      Reviewed by Rob Buis.
      
      PR# 280374
      Include accelerated compositing layers in screen captures.
      Reviewed Internally By: Jakob Petsovits
      
      * Api/BackingStore.cpp:
      (BlackBerry::WebKit::BackingStorePrivate::render):
      (BlackBerry::WebKit::BackingStorePrivate::renderContents):
      (BlackBerry::WebKit::BackingStore::drawContents):
      * Api/BackingStore_p.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f270615
    • fpizlo@apple.com's avatar
      JSC_enableProfiler=true should also cause JSGlobalData to save the profiler output somewhere · a6734fcb
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113144
      
      Reviewed by Geoffrey Garen.
              
      Forgot to include Geoff's requested change in the original commit.
      
      * profiler/ProfilerDatabase.cpp:
      (Profiler):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6734fcb
    • fpizlo@apple.com's avatar
      JSC_enableProfiler=true should also cause JSGlobalData to save the profiler output somewhere · 7183460c
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113144
      
      Source/JavaScriptCore: 
      
      Reviewed by Geoffrey Garen.
              
      Added the ability to save profiler output with JSC_enableProfiler=true. It will save it
      to the current directory, or JSC_PROFILER_PATH if the latter was specified.
              
      This works by saving the Profiler::Database either when it is destroyed or atexit(),
      whichever happens first.
              
      This allows use of the profiler from any WebKit client.
      
      * jsc.cpp:
      (jscmain):
      * profiler/ProfilerDatabase.cpp:
      (Profiler):
      (JSC::Profiler::Database::Database):
      (JSC::Profiler::Database::~Database):
      (JSC::Profiler::Database::registerToSaveAtExit):
      (JSC::Profiler::Database::addDatabaseToAtExit):
      (JSC::Profiler::Database::removeDatabaseFromAtExit):
      (JSC::Profiler::Database::performAtExitSave):
      (JSC::Profiler::Database::removeFirstAtExitDatabase):
      (JSC::Profiler::Database::atExitCallback):
      * profiler/ProfilerDatabase.h:
      (JSC::Profiler::Database::databaseID):
      (Database):
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData):
      
      Source/WTF: 
      
      Reviewed by Geoffrey Garen.
              
      I got tired of the fact that getpid(2) is not a syscall on Windows (unless you do
      _getpid() I believe), so I wrote a header that abstracts it. I also changed existing
      code that uses getpid() to use WTF::getCurrentProcessID().
      
      * GNUmakefile.list.am:
      * WTF.gypi:
      * WTF.pro:
      * WTF.vcproj/WTF.vcproj:
      * WTF.xcodeproj/project.pbxproj:
      * wtf/CMakeLists.txt:
      * wtf/MetaAllocator.cpp:
      (WTF::MetaAllocator::dumpProfile):
      * wtf/ProcessID.h: Added.
      (WTF):
      (WTF::getCurrentProcessID):
      * wtf/text/StringImpl.cpp:
      (WTF::StringStats::printStats):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7183460c
    • ap@apple.com's avatar
      Follow-up to: · efab0e3d
      ap@apple.com authored
              <rdar://problem/13194263> Crashes in NetworkProcess due to threading issues
              https://bugs.webkit.org/show_bug.cgi?id=113256
      
              Reviewed by Mark Rowe.
      
              * NetworkProcess/NetworkResourceLoader.h: Added some forgotten OVERRIDEs.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efab0e3d
    • commit-queue@webkit.org's avatar
      [BlackBerry] Set mouse document position for mouse event in updateCursor · 0e61ec9b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109094
      
      Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-03-26
      Reviewed by Rob Buis.
      
      Internally Reviewed by Jakob Petsovits.
      
      Mouse content position should be in document coordinate.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::updateCursor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e61ec9b
    • ap@apple.com's avatar
      <rdar://problem/13194263> Crashes in NetworkProcess due to threading issues · cd1fa45e
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=113256
      
              Reviewed by Brady Eidson.
      
              Added a new code path in ResourceHandle/ResourceHandleClient that doesn't need
              blocking calls. Implemented it for NSURLConnection by changing NSOperationQueue
              version to forward calls to main thread.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd1fa45e
    • timothy_horton@apple.com's avatar
      [wk2] Don't send intrinsic content size updates more than once per runloop · 9ea07bb5
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113258
      <rdar://problem/13492038>
      
      Reviewed by Simon Fraser.
      
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
      Only start the zero-delay timer if it's not already active.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ea07bb5
    • csaavedra@igalia.com's avatar
      Convert test from UTF-16 to UTF-8 · 5f297c9e
      csaavedra@igalia.com authored
      Rubber stamped by James Robinson.
      
      * fast/dom/34176.html: Convert from little endian UTF-16 to UTF-8
      to make git diff happy.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f297c9e
    • jparent@chromium.org's avatar
      Flakiness dashboard: simplify logic around which tests to show. · 7c901662
      jparent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113250
      
      Reviewed by Ojan Vafai.
      
      The different filters for showing results are only used for layout
      tests, otherwise, we show everything.
      
      Change the defaults to false (what layout tests used), and only
      look at the values when viewing layout tests.
      
      * TestResultServer/static-dashboards/flakiness_dashboard.js:
      (htmlForTestsWithExpectationsButNoFailures):
      (shouldHideTest):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c901662
    • alokp@chromium.org's avatar
      Rebaseline text output for opaque GraphicsLayers · 5b2faeab
      alokp@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109507
      
      Unreviewed rebaseline.
      
      * platform/chromium-linux-x86/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Removed.
      * platform/chromium-linux/compositing/overflow/composited-scrolling-paint-phases-expected.txt:
      * platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
      * platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
      * platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
      * platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt:
      * platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt:
      * platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
      * platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
      * platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
      * platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-mac/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt.
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
      * platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-win/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt.
      * platform/chromium/TestExpectations:
      * platform/chromium/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt.
      * platform/chromium/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt.
      * platform/chromium/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt.
      * platform/chromium/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt.
      * platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt:
      * platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt:
      * platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt.
      * platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt.
      * platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt.
      * platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b2faeab
    • tony@chromium.org's avatar
      Autogenerate the scrollAnimatorEnabled setting in Settings.in · 82972d0f
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113253
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Convert scrollAnimatorEnabled into an autogenerated setting. This involves renaming
      the setter from setEnableScrollAnimator(bool) to setScrollAnimatorEnabled(bool) and
      updating the callers. I didn't change any WebKit API methods.
      
      Also remove the code in InternalSettings since it's never used and will now be
      autogenerated with proper resetting code.
      
      No new tests, this is a refactor and should compile.
      
      * page/Settings.cpp:
      (WebCore::Settings::Settings): Remove code that is now autogenerated.
      * page/Settings.h:
      (Settings): Remove code that is now autogenerated.
      * page/Settings.in: Add entry for scrollAnimatorEnabled.
      * testing/InternalSettings.cpp: Remove unused code.
      * testing/InternalSettings.h: Remove unused code.
      * testing/InternalSettings.idl: Remove unused code.
      
      Source/WebKit/chromium:
      
      * src/WebSettingsImpl.cpp:
      (WebKit::WebSettingsImpl::setEnableScrollAnimator): Update call to WebCore to use setScrollAnimatorEnabled(bool).
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebview.cpp:
      (webkit_web_view_update_settings): Update call to WebCore to use setScrollAnimatorEnabled(bool).
      (webkit_web_view_settings_notify): Update call to WebCore to use setScrollAnimatorEnabled(bool).
      
      Source/WebKit/qt:
      
      * Api/qwebsettings.cpp:
      (QWebSettingsPrivate::apply): Update call to WebCore to use setScrollAnimatorEnabled(bool).
      
      Source/WebKit2:
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::setUseFixedLayout): Update call to WebCore to use setScrollAnimatorEnabled(bool).
      (WebKit::WebPage::updatePreferences): Update call to WebCore to use setScrollAnimatorEnabled(bool).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82972d0f
    • rafaelw@chromium.org's avatar
      Remove stray newline. This newline is messing up mozilla's test harness · 7fb5e702
      rafaelw@chromium.org authored
      and we share this file with them via html5lib.
      
      * html5lib/resources/template.dat:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fb5e702
    • commit-queue@webkit.org's avatar
      [BlackBerry] In RSSFilterStream, don't swallow headers when there's no body · 95e1ba28
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113334
      
      Patch by Joe Mason <jmason@blackberry.com> on 2013-03-26
      Reviewed by Rob Buis.
      
      RIM PR 316345
      
      When receiving an HTTP response that has a Content-Type header such as text/xml, but no
      body, RSSFilterStream::notifyHeadersReceived reads the Content-Type as "potential RSS", and
      calls saveHeaders. It expects to sniff the body in notifyDataReceived to see if it's RSS,
      and then call sendSavedHeaders to pass on the headers. But since there is no body,
      notifyDataReceived is never called. So call sendSavedHeaders in notifyClose too (it will not
      send them again if they were already sent.)
      
      * platform/network/blackberry/rss/RSSFilterStream.cpp:
      (WebCore::RSSFilterStream::notifyClose):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95e1ba28
    • commit-queue@webkit.org's avatar
      Update bots on test-results.appspot · db5d7e2f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113333
      
      Patch by Isaac Levy <ilevy@google.com> on 2013-03-26
      Reviewed by Ojan Vafai.
      
      * TestResultServer/static-dashboards/builders.jsonp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db5d7e2f
    • commit-queue@webkit.org's avatar
      Web Inspector: Faster drawer animation. · c3cb279b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113330
      
      250ms -> 100ms
      
      Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-26
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/inspector.css:
      (.animate #main):
      (.animate #floating-status-bar-container):
      (.animate #drawer):
      (.animate #bottom-status-bar-container > *):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3cb279b
    • tony@chromium.org's avatar
      [chromium] Expose setSelectionIncludesAltImageText in WebSettings · 35db81ac
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113316
      
      Reviewed by Dimitri Glazkov.
      
      Enabling this setting allows plain text clipboard content to include alt
      text like on Firefox and IE10.
      
      * public/WebSettings.h:
      (WebSettings):
      * src/WebSettingsImpl.cpp:
      (WebKit::WebSettingsImpl::setSelectionIncludesAltImageText):
      * src/WebSettingsImpl.h:
      (WebSettingsImpl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35db81ac
    • rniwa@webkit.org's avatar
      Remove some entries since those tests have been passing. · 9f73ae37
      rniwa@webkit.org authored
      Also update the test expectations for the bug 113227 flaky since they're passing most of the time.
      
      * platform/mac/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f73ae37
    • abecsi@webkit.org's avatar
      [Qt][WK2] Fails to start QtWebProcess.exe if installed in a path containing spaces · f5389721
      abecsi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113328
      
      Reviewed by Jocelyn Turcotte.
      
      Downstream bugreport: https://bugreports.qt-project.org/browse/QTBUG-30249
      
      We use QProcess::start() with a commandline string to start the web process
      and the string is treated by QProcess as a whitespace delimeted list of the
      command and the arguments, thus we have to escape the path to the process
      binaries so that if the path contains spaces we still run the appropriate
      command.
      
      * UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
      (WebKit::ProcessLauncher::launchProcess):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5389721
    • abecsi@webkit.org's avatar
      [Qt][WK2] QML WebView asserts when double clicking a link · 86ae9002
      abecsi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113329
      
      Reviewed by Jocelyn Turcotte.
      
      Downstream bugreport: https://bugreports.qt-project.org/browse/QTBUG-30288
      
      Remove an erroneous assert which is no longer valid if
      mouse gestures are enabled.
      
      * UIProcess/qt/QtWebPageEventHandler.cpp:
      (WebKit::QtWebPageEventHandler::handleInputEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86ae9002
    • timothy_horton@apple.com's avatar
      [wk2] Don't send intrinsic content size updates more than once per runloop · 07ab50b1
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113258
      <rdar://problem/13492038>
      
      Reviewed by Anders Carlsson.
      
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
      (TiledCoreAnimationDrawingArea):
      Add a zero-delay timer for intrinsic content size updates.
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
      Add a zero-delay timer for intrinsic content size updates.
      (WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
      Start our new one-shot zero-delay timer.
      (WebKit::TiledCoreAnimationDrawingArea::updateIntrinsicContentSizeTimerFired):
      Inform the WebPage that the intrinsic content size has changed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07ab50b1
    • bfulgham@webkit.org's avatar
      [WinCairo] Unreviewed Build fix. · a869baca
      bfulgham@webkit.org authored
      * platform/graphics/win/FontCustomPlatformDataCairo.h:
      (FontCustomPlatformData): Correct signature in header to match
      required implementation.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a869baca
    • anilsson@rim.com's avatar
      [BlackBerry] Scrolling up and down can cause the screen to flash black · cd289bab
      anilsson@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113269
      
      Reviewed by Rob Buis.
      
      PR 296106
      
      Source/WebCore:
      
      The LayerRenderer should never clear before drawing the layers, from
      now on that's the responsibility of the caller.
      
      Only manually testable.
      
      * platform/graphics/blackberry/LayerRenderer.cpp:
      (WebCore::LayerRenderer::setViewport):
      * platform/graphics/blackberry/LayerRendererClient.h:
      (LayerRendererClient):
      
      Source/WebKit/blackberry:
      
      Various flaws in the code could conspire to make the screen cleared to
      black before rendering the web page. This only happened when the
      BackingStore was inactive, and the LayerTiler takes on the job of
      drawing the root layer. When tiles are missing, this made the
      "checkerboard" effect especially noticeable since black color was seen
      where the tile should have been. It would be better to clear to the web
      page background color.
      
      This was actually the intent of the code, but when the document
      background color was invalid, we would still use it instead of the
      background color from settings. Also, the LayerRenderer would clear to
      black when WebPageCompositorPrivate::drawsRootLayer() was true.
      
      Fixed by falling back to the settings background color when the
      document background color is invalid, and removing the clearing code
      from the LayerRenderer entirely. The appropriate clear already happens
      near the beginning of BackingStorePrivate::blitVisibleContents().
      
      Also slightly cleaned up the code for managing the background color.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::setLoadState):
      (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
      (BlackBerry::WebKit::WebPagePrivate::updateBackgroundColor):
      (WebKit):
      (BlackBerry::WebKit::WebPagePrivate::documentBackgroundColor):
      * Api/WebPageCompositor.cpp:
      * Api/WebPageCompositor_p.h:
      (WebPageCompositorPrivate):
      * Api/WebPage_p.h:
      (WebPagePrivate):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd289bab
    • allan.jensen@digia.com's avatar
      [Qt] editing/pasteboard/can-read-in-dragstart-event.html and... · 7bc0f8b1
      allan.jensen@digia.com authored
      [Qt] editing/pasteboard/can-read-in-dragstart-event.html and /can-read-in-copy-and-cut-events.html are crashing
      https://bugs.webkit.org/show_bug.cgi?id=113126
      
      Reviewed by Jocelyn Turcotte.
      
      Source/WebCore:
      
      Make it possible to read from a writable Clipboard.
      
      Test: editing/pasteboard/can-read-in-copy-and-cut-events.html
      
      * platform/qt/ClipboardQt.cpp:
      (WebCore::ClipboardQt::getData):
      (WebCore::ClipboardQt::types):
      (WebCore::ClipboardQt::files):
      (WebCore::ClipboardQt::readClipboardData):
      (WebCore::ClipboardQt::hasData):
      (WebCore::ClipboardQt::items):
      * platform/qt/ClipboardQt.h:
      (ClipboardQt):
      
      LayoutTests:
      
      Unskip now working editing/pasteboard/can-read-in-copy-and-cut-events.html.
      The other test still needs better drag-and-drop support in DRT.
      
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bc0f8b1
    • bfulgham@webkit.org's avatar
      [WinCairo] Unreviewed build correction. · 7e43ef59
      bfulgham@webkit.org authored
      * platform/graphics/win/FontCustomPlatformDataCairo.cpp:
      (WebCore::FontCustomPlatformData::fontPlatformData): Update
      method signature to match CG variant.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e43ef59
    • ch.dumez@sisa.samsung.com's avatar
      Code duplication between HTTPParsers and HTTPValidation · 3855a916
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113283
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore:
      
      Merged isValidHTTPToken() from HTTPValidation.h and isRFC2616Token() from
      HTTPParsers.h. They were doing exactly the same thing and their
      implementation was almost the same.
      
      Removed HTTPValidation.* and moved remaining code to HTTPParsers.* as this
      seems like the proper place and it seems odd to keep HTTPValidation for
      just one function.
      
      No new tests, no behavior change for layout tests.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/network/HTTPParsers.cpp:
      (WebCore::isValidHTTPHeaderValue):
      (WebCore):
      (WebCore::isValidHTTPToken): Implementation is slightly simplified based on
      isValidHTTPToken() from HTTPValidation.cpp. (c >= 0x80 || c == 0x7F) is
      replaced by (c >= 0x7F). (c <= 0x1F ||  c == ' ' || c == '\t') is replaced
      by (c <= 0x20). Those expressions are shorter but equivalent.
      (WebCore::contentDispositionType):
      * platform/network/HTTPParsers.h:
      * platform/network/HTTPValidation.cpp: Removed.
      * platform/network/HTTPValidation.h: Removed.
      * xml/XMLHttpRequest.cpp: Stop including HTTPValidation.h.
      
      Source/WebKit/chromium:
      
      * src/AssociatedURLLoader.cpp: Include HTTPParsers.h instead
      of HTTPValidation.h to use isValidHTTPToken().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3855a916
    • sergio@webkit.org's avatar
      Implement overtype mode for editable content · 1874d7a9
      sergio@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112126
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Tests: editing/execCommand/overtype-support.html
             editing/execCommand/overtype.html
      
      Add a new Overwrite command to the editor. This command will
      perform overtype operations when enabled instead of "normal" text
      insertions. As IE does, we maintain a single toggle state in the
      editor (enabled/disabled) for all the editable content in the
      page.
      
      This new command will be only available for richly editable
      content via keybindings or the context menu. For testing purposes
      it is also accessible via internals.
      
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::replaceTextInNode): Use RefPtr for
      local variables.
      * editing/Editor.cpp:
      (WebCore::Editor::Editor):
      * editing/Editor.h:
      (WebCore::Editor::isOverwriteModeEnabled):
      (WebCore::Editor::toggleOverwriteModeEnabled):
      (Editor): Added two new functions and a new attribute.
      * editing/EditorCommand.cpp:
      (WebCore::executeToggleOverwrite): Enables/disables overwrite mode.
      (WebCore):
      (WebCore::createCommandMap): New OverWrite command.
      * editing/InsertTextCommand.cpp:
      (WebCore::InsertTextCommand::setEndingSelectionWithoutValidation):
      Refactored from performTrivialReplace(), shared by
      performOverwrite().
      (WebCore):
      (WebCore::InsertTextCommand::performTrivialReplace):
      (WebCore::InsertTextCommand::performOverwrite):
      (WebCore::InsertTextCommand::doApply): Perform overwrite if enabled.
      * editing/InsertTextCommand.h:
      (InsertTextCommand):
      * testing/Internals.cpp:
      (WebCore::Internals::resetToConsistentState): Reset OverWrite mode
      to false.
      (WebCore::Internals::isOverwriteModeEnabled):
      (WebCore):
      (WebCore::Internals::toggleOverwriteModeEnabled): Provide access
      to overwrite functionality in Editor for testing purposes.
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit/mac:
      
      Added the OverWrite editing command to the WebCore editing
      commands lists.
      
      * WebView/WebHTMLView.mm:
      * WebView/WebView.h:
      * WebView/WebView.mm:
      
      LayoutTests:
      
      Two new layout tests for the new overtype mode. We use
      overtype-support.html to check that the Overwrite command is not
      exported to JavaScript but accessible through Internals. The
      overtype.html one is used to test the actual behaviour of the
      command.
      
      The new command was also added to enabling-and-selection-2.js to
      check that it is only available for richly editable content.
      
      * editing/execCommand/enabling-and-selection-2-expected.txt:
      Updated expectations for OverWrite command.
      * editing/execCommand/overtype-expected.txt: Added.
      * editing/execCommand/overtype-support-expected.txt: Added.
      * editing/execCommand/overtype-support.html: Added.
      * editing/execCommand/overtype.html: Added.
      * editing/execCommand/script-tests/enabling-and-selection-2.js:
      Added a check for OverWrite command.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1874d7a9
    • anilsson@rim.com's avatar
      [BlackBerry] WebOverlay::pixelViewportRect() should return pixel viewport coordinates · 302250bc
      anilsson@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113263
      
      Reviewed by Rob Buis.
      
      PR 312404
      
      Source/WebCore:
      
      Fix WebOverlay::pixelViewportRect() to return the pixel viewport rect
      instead of the window rect. These are different if the web page is
      rendered starting at a window coordinate other than 0,0. The clip rect
      encodes the position we're rendered at, and can be used to translate
      the rect expressed in window coordinates to the pixel viewport
      coordinate system.
      
      Also perform some cleanup of related code.
      
      Only manually testable.
      
      * platform/graphics/blackberry/LayerCompositingThread.cpp:
      (WebCore::LayerCompositingThread::getTransformedHolePunchRect):
      (WebCore::LayerCompositingThread::drawTextures):
      * platform/graphics/blackberry/LayerRenderer.cpp:
      (WebCore::toPixelCoordinates):
      (WebCore):
      (WebCore::LayerRenderer::toWindowCoordinates):
      (WebCore::LayerRenderer::toPixelViewportCoordinates):
      (WebCore::LayerRenderer::toDocumentViewportCoordinates):
      (WebCore::LayerRenderer::updateLayersRecursive):
      * platform/graphics/blackberry/LayerRenderer.h:
      (LayerRenderer):
      
      Source/WebKit/blackberry:
      
      Fixed by returning pixel viewport coordinates instead of window
      coordinates.
      
      * Api/WebOverlay.cpp:
      (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      302250bc
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r146901. · 72190cac
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/146901
      https://bugs.webkit.org/show_bug.cgi?id=113321
      
      Was landed to soon (Requested by pfeldman on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-26
      
      Source/WebCore:
      
      * inspector/front-end/ConsoleView.js:
      (WebInspector.ConsoleView.prototype.):
      (WebInspector.ConsoleView.prototype.filter):
      (WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView):
      (WebInspector.ConsoleView.prototype._scheduleScrollIntoView):
      (WebInspector.ConsoleView.prototype._consoleMessageAdded):
      (WebInspector.ConsoleView.prototype._appendConsoleMessage):
      (WebInspector.ConsoleView.prototype._consoleCleared):
      (WebInspector.ConsoleView.prototype._handleContextMenuEvent.monitoringXHRItemAction):
      (WebInspector.ConsoleView.prototype._handleContextMenuEvent.get preserveLogItemAction):
      (WebInspector.ConsoleView.prototype._shouldBeVisible):
      (WebInspector.ConsoleView.prototype._updateMessageList):
      (WebInspector.ConsoleView.prototype._promptKeyDown):
      (WebInspector.ConsoleView.prototype._printResult):
      (WebInspector.ConsoleCommand.prototype.highlightSearchResults):
      * inspector/front-end/inspector.css:
      (.console-warning-level, .console-error-level, .console-log-level, .console-debug-level):
      (.filter-all .console-debug-level, .filter-debug .console-debug-level):
      (.filter-all .console-debug-level.repeated-message, .filter-debug .console-debug-level.repeated-message):
      
      LayoutTests:
      
      * inspector/console/console-preserve-log.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72190cac
    • rafaelw@chromium.org's avatar
      HTMLStackItem should include <template> as a special tag · 16bce4e9
      rafaelw@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113016
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      New test added to html5lib suite.
      
      * html/parser/HTMLStackItem.h:
      (WebCore::HTMLStackItem::isSpecialNode):
      
      LayoutTests:
      
      * html5lib/resources/template.dat:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16bce4e9
    • vsevik@chromium.org's avatar
      Web Inspector: Distinguish breakpoints and breakpoint locations in BreakpointManager API · ccde99ef
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113311
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Made independent handling of breakpoints and breakpoint location in breakpoint manager consistent.
      JavaScriptSourceFrame now removes breakpoints originally set in it based on primary UI location.
      
      * inspector/front-end/BreakpointManager.js:
      (WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
      (WebInspector.BreakpointManager.prototype.allBreakpoints):
      (WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
      (WebInspector.BreakpointManager.prototype.allBreakpointLocations):
      (WebInspector.BreakpointManager.prototype._projectWillReset.get for):
      (WebInspector.BreakpointManager.prototype._projectWillReset):
      * inspector/front-end/JavaScriptSourceFrame.js:
      (WebInspector.JavaScriptSourceFrame.prototype.onUISourceCodeContentChanged):
      (WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
      (WebInspector.JavaScriptSourceFrame.prototype._removeAllBreakpoints):
      
      LayoutTests:
      
      * inspector/debugger/live-edit-breakpoints-expected.txt:
      * inspector/debugger/live-edit-breakpoints.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccde99ef
    • commit-queue@webkit.org's avatar
      bundle-ids need to be sanitized before using them in filesystem paths · d6ec122f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113030
      <rdar://problem/13300254>
      
      Patch by Simon Cooper <scooper@apple.com> on 2013-03-26
      Reviewed by Alexey Proskuryakov.
      
      When choosing / looking for a specialized Sandbox for a Plugin the
      bundle-id needs to be sanitized before using it to construct a
      filesystem name to look up. The “/“ character should not be allowed
      and transformed into something else, in this case a “:”
      
      * PluginProcess/mac/PluginProcessMac.mm:
      (WebKit::loadSandboxProfile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6ec122f
    • commit-queue@webkit.org's avatar
      Web Inspector: Remove remainings of CSS-based console message filtering. · 8a1b945c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112710
      
      Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-26
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      * inspector/front-end/ConsoleView.js:
      (WebInspector.ConsoleView.get this):
      (WebInspector.ConsoleView.prototype.):
      (WebInspector.ConsoleView.prototype.filter):
      (WebInspector.ConsoleView.prototype._consoleMessageAdded):
      (WebInspector.ConsoleView.prototype._appendConsoleMessage):
      (WebInspector.ConsoleView.prototype._consoleCleared):
      (WebInspector.ConsoleView.prototype._shouldBeVisible):
      (WebInspector.ConsoleView.prototype._updateMessageList):
      (WebInspector.ConsoleView.prototype._promptKeyDown):
      (WebInspector.ConsoleView.prototype._printResult):
      (WebInspector.ConsoleCommand.prototype.highlightSearchResults):
      * inspector/front-end/inspector.css:
      (.console-debug-level.repeated-message):
      
      LayoutTests:
      
      * inspector/console/console-preserve-log.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a1b945c
    • commit-queue@webkit.org's avatar
      Web Inspector: refactor code duplication:... · 9eb13207
      commit-queue@webkit.org authored
      Web Inspector: refactor code duplication: WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements
      https://bugs.webkit.org/show_bug.cgi?id=113211
      
      Patch by Peter Rybin <prybin@chromium.org> on 2013-03-26
      Reviewed by Yury Semikhatsky.
      
      A new method WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements is added and used
      from 2 sites.
      
      * inspector/front-end/ObjectPropertiesSection.js:
      (WebInspector.ObjectPropertiesSection.prototype.update.callback):
      (WebInspector.ObjectPropertiesSection.prototype.update):
      (WebInspector.ObjectPropertiesSection.prototype.updateProperties):
      (.callback):
      (WebInspector.ObjectPropertyTreeElement.populate):
      (WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements):
      * inspector/front-end/WatchExpressionsSidebarPane.js:
      (WebInspector.WatchExpressionsSection.prototype.update.appendResult):
      (WebInspector.WatchExpressionsSection.prototype.update):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9eb13207
    • ch.dumez@sisa.samsung.com's avatar
      HTTPHeaderMap::copyData() could call uncheckedAppend() · 2a66fcac
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113279
      
      Reviewed by Alexey Proskuryakov.
      
      HTTPHeaderMap::copyData() calls reserveInitialCapacity() on the Vector
      but then appends items using append() function. Since we already know
      the capacity is sufficient, it is more efficient to call uncheckedAppend()
      instead to bypass capacity checks.
      
      No new tests, no behavior change for layout tests.
      
      * platform/network/HTTPHeaderMap.cpp:
      (WebCore::HTTPHeaderMap::copyData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a66fcac
    • vsevik@chromium.org's avatar
      Web Inspector: UISourceCodes are leaking on reload sometimes. · a9284923
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113310
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/BreakpointManager.js:
      (WebInspector.BreakpointManager.prototype._projectWillReset.get for):
      (WebInspector.BreakpointManager.prototype._projectWillReset):
      * inspector/front-end/ConsoleModel.js:
      (WebInspector.ConsoleModel.prototype.clearMessages):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9284923
    • apavlov@chromium.org's avatar
      Web Inspector: [Elements] Unable to "Edit as HTML" XHTML/SVG documents. · e2f25b07
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113290
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      DOMPatchSupport has been slightly augmented to handle XML (XHTML and SVG) documents.
      
      Test: inspector/elements/set-outer-html-for-xhtml.xhtml
      
      * inspector/DOMPatchSupport.cpp:
      (WebCore::DOMPatchSupport::patchDocument):
      (WebCore::DOMPatchSupport::patchNode):
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::setOuterHTML): Let HTML, XHTML, and SVG documents through.
      
      LayoutTests:
      
      * inspector/elements/set-outer-html-for-xhtml-expected.txt: Added.
      * inspector/elements/set-outer-html-for-xhtml.xhtml: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2f25b07
    • morrita@google.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=113164 · 85bdf051
      morrita@google.com authored
      Custom Elements: readyCallback should be called for outerHTML and insertAdjecentHTML
      
      Source/WebCore:
      
      These APIs also create new elements thus should have V8DeliverCustomElementCallbacks attribute.
      
      Reviewed by Dimitri Glazkov.
      
      Test: Updated lifecycle-ready-creation-api.html.
      
      * html/HTMLElement.idl:
      
      LayoutTests:
      
      Reviewed by Dimitri Glazkov.
      
      * fast/dom/custom/lifecycle-ready-creation-api-expected.txt:
      * fast/dom/custom/lifecycle-ready-creation-api.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85bdf051
    • jochen@chromium.org's avatar
      Fix incorrect test name in content shell expectations · cd773224
      jochen@chromium.org authored
      Unreviewed. Typing is hard.
      
      * platform/chromium/ContentShellTestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd773224
    • commit-queue@webkit.org's avatar
      Convert WebInputEvent::GestureDoubleTap to PlatformEvent::NoType · 78db6a47
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113215
      
      In bug 93045 we removed PlatformEvent::GestureDoubleTap since now DoubleTap gesture
      is implemented as a Tap gesture with tap_count = 2.
      
      In WebViewImpl::handleGestureEvent(), a PlatformEvent is built from the WebGestureEvent
      regardless, even though the PlatfromEvent will never reach the WebCore. DoubleTap, in
      our case, is only handled in WebViewImpl for doube-tap-to-zoom, will also go through
      conversion in WebInpuEventConversion.cpp::PlatformGestureEventBuilder() and reach
      ASSERT_NOT_REACHED()
      
      This patch converts WebGestureEvent::DoubleTap to PlatformEvent::NoType, this makes the
      conversion list from WebInputEvent to PlatformEvent complete and we don't need a special
      handling for the DoubleTap event in WebViewImpl::handleGestureEvent()
      
      Patch by Yufeng Shen <miletus@chromium.org> on 2013-03-26
      Reviewed by Antonio Gomes.
      
      * src/WebInputEventConversion.cpp:
      (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78db6a47
    • loislo@chromium.org's avatar
      Unreviewed. WebInspector: remove unnecessary method. · afacdc7d
      loislo@chromium.org authored
      * inspector/front-end/OverviewGrid.js:
      (WebInspector.OverviewGrid.Window):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afacdc7d