1. 27 Jan, 2010 32 commits
  2. 26 Jan, 2010 8 commits
    • ap@apple.com's avatar
      More Windows build fixing. · c42e54d8
      ap@apple.com authored
              * wtf/HashTraits.h: _msize takes void*, remove const qualifier from type.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ap@apple.com's avatar
      Windows build fix. · 8376e356
      ap@apple.com authored
              * wtf/HashTraits.h: Include malloc.h for _msize().
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ap@apple.com's avatar
      Build fix. · f6512a62
      ap@apple.com authored
              * wtf/HashTable.h: (WTF::HashTable::checkTableConsistencyExceptSize): Remove const from a
              static (empty) version of this function.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • dbates@webkit.org's avatar
      2010-01-26 Daniel Bates <dbates@webkit.org> · 7032f465
      dbates@webkit.org authored
              Unreviewed. Updated expected failing results for table-percent-height.html
              to reflect one pixel difference between the results generated by the Qt bot
              and my machine. Added failing test fast/css/button-height.html to GTK Skipped
              file as we need to look into this. See bug #33936 for more details.
              * platform/gtk/Skipped: Added failing test fast/css/button-height.html.
              * platform/qt/fast/replaced/table-percent-height-expected.txt: Updated result.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ap@apple.com's avatar
      Reviewed by Darin Adler. · 3260d484
      ap@apple.com authored
              WebKit needs a mechanism to catch stale HashMap entries
              It is very difficult to catch stale pointers that are HashMap keys - since a pointer's hash
              is just its value, it is very unlikely that any observable problem is reproducible.
              This extends hash table consistency checks to check that pointers are referencing allocated
              memory blocks, and makes it possible to invoke the checks explicitly (it is not feasible
              to enable CHECK_HASHTABLE_CONSISTENCY by default, because that affects performance too much).
              * wtf/HashMap.h: (WTF::::checkConsistency): Call through to HashTable implementation. We can
              add similar calls to HashSet and HashCountedSet, but I haven't seen hard to debug problems
              with those yet.
              * wtf/HashSet.h: (WTF::::remove): The version of checkTableConsistency that's guarded by
              CHECK_HASHTABLE_CONSISTENCY is now called internalCheckTableConsistency().
              * wtf/HashTable.h:
              Expose checkTableConsistency() even if CHECK_HASHTABLE_CONSISTENCY is off.
              (WTF::::add): Updated for checkTableConsistency renaming.
              (WTF::::addPassingHashCode): Ditto.
              (WTF::::removeAndInvalidate): Ditto.
              (WTF::::remove): Ditto.
              (WTF::::rehash): Ditto.
              (WTF::::checkTableConsistency): The assertion for !shouldExpand() was not correct - this
              function returns true for tables with m_table == 0.
              (WTF::::checkTableConsistencyExceptSize): Call checkValueConsistency for key. Potentially,
              we could do the same for values.
              * wtf/HashTraits.h:
              (WTF::GenericHashTraits::checkValueConsistency): An empty function that can be overridden
              to add checks. Currently, the only override is for pointer hashes.
              * wtf/RefPtrHashMap.h: (WTF::::remove): Updated for checkTableConsistency renaming.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • eric@webkit.org's avatar
      2010-01-26 Yaar Schnitman <yaar@chromium.org> · 5529f39e
      eric@webkit.org authored
              Reviewed by Darin Fisher.
              Add KeyboardTest to WebKit API tests
              * WebKit.gyp:
              * tests/KeyboardTest.cpp: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • dbates@webkit.org's avatar
      2010-01-26 Daniel Bates <dbates@webkit.org> · c9561791
      dbates@webkit.org authored
              Reviewed by Tor Arne Vestbø.
              [Qt] Fixes an issue where the height of <button>- and
              <input type="button">- elements are fixed to the height of the
              button label font plus padding. That is, the CSS height property
              is being ignored.
              Instead, we should honor the user-specified height, if appropriate
              for the platform and context. Notice, the Mac ports do not honor the
              height for <input type="button"> elements unless a border and/or
              background is also specified.
              Test: fast/css/button-height.html
              * platform/qt/RenderThemeQt.cpp:
      2010-01-26  Daniel Bates  <dbates@webkit.org>
              Reviewed by Tor Arne Vestbø.
              Tests that the user-specified height for <button>- and <input type="button">-
              elements are honored, if appropriate for the platform and context.
              * fast/css/button-height-expected.txt: Added.
              * fast/css/button-height.html: Added.
              * fast/replaced/table-percent-height-expected.txt: Added notice about failing tests
              in Windows ports.
              * fast/replaced/table-percent-height.html: Ditto.
              * platform/qt/fast/replaced/table-percent-height-expected.txt: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • dbates@webkit.org's avatar
      2010-01-26 Daniel Bates <dbates@webkit.org> · d8e88b05
      dbates@webkit.org authored
              Reviewed by Adam Barth.
              Moves the try/catch for OSError exceptions in Executive.run_command
              to Credentials.read_credentials() so that the unit test
              webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
              assert that Executive.run_command throws an OSError exception.
              * Scripts/webkitpy/credentials.py:
              * Scripts/webkitpy/executive.py: Moved try/catch for OSError to
              method Credentials.read_credentials().
              * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer
              apply: test_run_command_with_bad_command_check_return_code and
              test_run_command_with_bad_command_check_calls_error_handler. Added new
              test to assert that run_command throws OSError exceptions.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53896 268f45cc-cd09-0410-ab3c-d52691b4dbfc