1. 02 Dec, 2013 1 commit
  2. 13 Nov, 2013 2 commits
    • joepeck@webkit.org's avatar
      Web Inspector: Generate Individual InspectorBackendDispatchers, add base InspectorBackendDispatcher · 143537cc
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124296
      
      Reviewed by Timothy Hatcher.
      
      No new tests, this is just refactoring without changing functionality.
      Set of changes made:
      
        - Add inspector/InspectorBackendDispatcher.{h,cpp}. This used to be almost entirely
          written in the code generator strings file, but make it actual source files
          because there is nothing changing in the code. Also clean this up a bit.
        - Give the base dispatcher a list of domain dispatchers and a way to register.
        - Make InspectorBackendDispatcher::dispatch read the domain of incoming request
          and pass the request on to the domain dispatcher.
        - Create per-domain dispatcher classes named "InspectorFooBackendDispatcher"
        - Convert "InspectorBackendDispatcher::FooCommandHandler" interfaces to
          "InspectorFooBackendDispatcherHandler" interfaces.
        - Convert all "InspectorBackendDispatcherImpl::FooDomain_fooMethod" methods to
          "InspectorFooBackendDispatcher::fooMethod" methods. These can also remove their
          "if (!agent)" checks because that can never be the case anymore.
        - Remove InspectorBackendDispatcherImpl, now that there are base and domain dispatchers.
        - Add ASCIILiteral in many places in generated code where possible.
        - In all agents, create dispatchers in didCreateFrontendAndBackend and clear
          them in willDestroyFrontendAndBackend, right alongside frontend dispatchers.
      
      * inspector/CodeGeneratorInspector.py:
      (DomainNameFixes.get_fixed_data.Res):
      (TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
      (Generator):
      (Generator.go):
      (Generator.process_command):
      (Generator.generate_send_method):
      * inspector/CodeGeneratorInspectorStrings.py:
      (void):
      (HashMap):
      (InspectorBackendDispatchers_h):
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorAgent.h:
      * inspector/InspectorAllInOne.cpp:
      * inspector/InspectorApplicationCacheAgent.cpp:
      (WebCore::InspectorApplicationCacheAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorApplicationCacheAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorApplicationCacheAgent.h:
      * inspector/InspectorBackendDispatcher.cpp: Added.
      (WebCore::InspectorBackendDispatcher::CallbackBase::CallbackBase):
      (WebCore::InspectorBackendDispatcher::CallbackBase::isActive):
      (WebCore::InspectorBackendDispatcher::CallbackBase::sendFailure):
      (WebCore::InspectorBackendDispatcher::CallbackBase::sendIfActive):
      (WebCore::InspectorBackendDispatcher::create):
      (WebCore::InspectorBackendDispatcher::registerDispatcherForDomain):
      (WebCore::InspectorBackendDispatcher::dispatch):
      (WebCore::InspectorBackendDispatcher::sendResponse):
      (WebCore::InspectorBackendDispatcher::reportProtocolError):
      (WebCore::InspectorBackendDispatcher::getPropertyValue):
      (WebCore::AsMethodBridges::asInt):
      (WebCore::AsMethodBridges::asDouble):
      (WebCore::AsMethodBridges::asString):
      (WebCore::AsMethodBridges::asBoolean):
      (WebCore::AsMethodBridges::asObject):
      (WebCore::AsMethodBridges::asArray):
      (WebCore::InspectorBackendDispatcher::getInt):
      (WebCore::InspectorBackendDispatcher::getDouble):
      (WebCore::InspectorBackendDispatcher::getString):
      (WebCore::InspectorBackendDispatcher::getBoolean):
      (WebCore::InspectorBackendDispatcher::getObject):
      (WebCore::InspectorBackendDispatcher::getArray):
      * inspector/InspectorBackendDispatcher.h: Added.
      (WebCore::InspectorSupplementalBackendDispatcher::InspectorSupplementalBackendDispatcher):
      (WebCore::InspectorSupplementalBackendDispatcher::~InspectorSupplementalBackendDispatcher):
      (WebCore::InspectorBackendDispatcher::~InspectorBackendDispatcher):
      (WebCore::InspectorBackendDispatcher::clearFrontend):
      (WebCore::InspectorBackendDispatcher::isActive):
      (WebCore::InspectorBackendDispatcher::InspectorBackendDispatcher):
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorCSSAgent.h:
      * inspector/InspectorCanvasAgent.cpp:
      (WebCore::InspectorCanvasAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorCanvasAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorCanvasAgent.h:
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorConsoleAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorDOMAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorDOMAgent.h:
      * inspector/InspectorDOMDebuggerAgent.cpp:
      (WebCore::InspectorDOMDebuggerAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorDOMDebuggerAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorDOMDebuggerAgent.h:
      * inspector/InspectorDOMStorageAgent.cpp:
      (WebCore::InspectorDOMStorageAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorDOMStorageAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorDOMStorageAgent.h:
      * inspector/InspectorDatabaseAgent.cpp:
      (WebCore::InspectorDatabaseAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorDatabaseAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorDatabaseAgent.h:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorDebuggerAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorHeapProfilerAgent.cpp:
      (WebCore::InspectorHeapProfilerAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorHeapProfilerAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorHeapProfilerAgent.h:
      * inspector/InspectorIndexedDBAgent.cpp:
      (WebCore::InspectorIndexedDBAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorIndexedDBAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorIndexedDBAgent.h:
      * inspector/InspectorInputAgent.cpp:
      (WebCore::InspectorInputAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorInputAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorInputAgent.h:
      * inspector/InspectorLayerTreeAgent.cpp:
      (WebCore::InspectorLayerTreeAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorLayerTreeAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorLayerTreeAgent.h:
      * inspector/InspectorMemoryAgent.cpp:
      (WebCore::InspectorMemoryAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorMemoryAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorMemoryAgent.h:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorPageAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorPageAgent::getScriptExecutionStatus):
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::InspectorProfilerAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorProfilerAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorProfilerAgent.h:
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorResourceAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorResourceAgent.h:
      * inspector/InspectorRuntimeAgent.h:
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorTimelineAgent.h:
      * inspector/InspectorWorkerAgent.cpp:
      (WebCore::InspectorWorkerAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorWorkerAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorWorkerAgent.h:
      * inspector/PageRuntimeAgent.cpp:
      (WebCore::PageRuntimeAgent::didCreateFrontendAndBackend):
      (WebCore::PageRuntimeAgent::willDestroyFrontendAndBackend):
      * inspector/PageRuntimeAgent.h:
      * inspector/WorkerRuntimeAgent.cpp:
      (WebCore::WorkerRuntimeAgent::didCreateFrontendAndBackend):
      (WebCore::WorkerRuntimeAgent::willDestroyFrontendAndBackend):
      * inspector/WorkerRuntimeAgent.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      143537cc
    • joepeck@webkit.org's avatar
      Web Inspector: Extract InspectorFrontendDispatchers from InspectorFrontend · 20fd448a
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124246
      
      Reviewed by NOBODY (OOPS!).
      
      No new tests, this is just refactoring without changing functionality.
      Set of changes made:
      
        - Remove "class InspectorFrontend" that currently does nothing but hold
          sub-frontend dispatcher classes. Catches some stale code.
        - Generate individual "class InspectorFooFrontendDispatcher" classes for
          domains that have events. Catches some unnecessary classes.
        - Simplify the Base Agent interface from optional set/clearFrontend/register
          to required didCreateFrontendAndBackend/willDestroyFrontendAndBackend.
          New agents must implement this and this will be their cue to setup
          frontend and backend dispatchers.
        - Base Agent no longer needs to be templated or have an Interface class.
        - While we are changing subclass BaseAgent superclass calls, use ASCIILiteral
        - In agents with events, convert "InspectorFrontend::Foo* m_frontend" to
          "unique_ptr<InspectorFooFrontendDispatcher> m_frontendDispatcher" and
          update uses as appropriate within the classes.
        - In agents with events, create dispatchers in didCreateFrontendAndBackend
          and clear them in willDestroyFrontendAndBackend.
      
      * inspector/CodeGeneratorInspector.py:
      (Generator):
      (Generator.go):
      (Generator.process_event):
      * inspector/CodeGeneratorInspectorStrings.py:
      (InspectorFrontendChannel):
      * inspector/ConsoleMessage.cpp:
      (WebCore::ConsoleMessage::addToFrontend):
      (WebCore::ConsoleMessage::updateRepeatCountInConsole):
      * inspector/ConsoleMessage.h:
      * inspector/InjectedScriptHost.h:
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::InspectorAgent):
      (WebCore::InspectorAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorAgent::enable):
      (WebCore::InspectorAgent::evaluateForTestInFrontend):
      (WebCore::InspectorAgent::inspect):
      * inspector/InspectorAgent.h:
      (WebCore::InspectorAgent::hasFrontend):
      * inspector/InspectorAgentRegistry.cpp:
      (WebCore::InspectorAgentRegistry::append):
      (WebCore::InspectorAgentRegistry::didCreateFrontendAndBackend):
      (WebCore::InspectorAgentRegistry::willDestroyFrontendAndBackend):
      * inspector/InspectorAgentRegistry.h:
      * inspector/InspectorApplicationCacheAgent.cpp:
      (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
      (WebCore::InspectorApplicationCacheAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorApplicationCacheAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus):
      (WebCore::InspectorApplicationCacheAgent::networkStateChanged):
      * inspector/InspectorApplicationCacheAgent.h:
      * inspector/InspectorBaseAgent.h:
      (WebCore::InspectorBaseAgent::discardAgent):
      (WebCore::InspectorBaseAgent::InspectorBaseAgent):
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::InspectorCSSAgent):
      (WebCore::InspectorCSSAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorCSSAgent::mediaQueryResultChanged):
      (WebCore::InspectorCSSAgent::didCreateNamedFlow):
      (WebCore::InspectorCSSAgent::willRemoveNamedFlow):
      (WebCore::InspectorCSSAgent::regionLayoutUpdated):
      (WebCore::InspectorCSSAgent::regionOversetChanged):
      (WebCore::InspectorCSSAgent::didRegisterNamedFlowContentElement):
      (WebCore::InspectorCSSAgent::didUnregisterNamedFlowContentElement):
      (WebCore::InspectorCSSAgent::stopSelectorProfilerImpl):
      (WebCore::InspectorCSSAgent::styleSheetChanged):
      * inspector/InspectorCSSAgent.h:
      * inspector/InspectorCanvasAgent.cpp:
      (WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
      (WebCore::InspectorCanvasAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorCanvasAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorCanvasAgent::notifyRenderingContextWasWrapped):
      (WebCore::InspectorCanvasAgent::findFramesWithUninstrumentedCanvases):
      (WebCore::InspectorCanvasAgent::frameNavigated):
      * inspector/InspectorCanvasAgent.h:
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
      (WebCore::InspectorConsoleAgent::enable):
      (WebCore::InspectorConsoleAgent::clearMessages):
      (WebCore::InspectorConsoleAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorConsoleAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorConsoleAgent::addMessageToConsole):
      (WebCore::InspectorConsoleAgent::didFinishXHRLoading):
      (WebCore::InspectorConsoleAgent::addConsoleMessage):
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      (WebCore::InspectorController::connectFrontend):
      (WebCore::InspectorController::disconnectFrontend):
      (WebCore::InspectorController::show):
      (WebCore::InspectorController::close):
      * inspector/InspectorController.h:
      (WebCore::InspectorController::hasFrontend):
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::InspectorDOMAgent):
      (WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorDOMAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorDOMAgent::setDocument):
      (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
      (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
      (WebCore::InspectorDOMAgent::focusNode):
      (WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
      (WebCore::InspectorDOMAgent::didCommitLoad):
      (WebCore::InspectorDOMAgent::didInsertDOMNode):
      (WebCore::InspectorDOMAgent::didRemoveDOMNode):
      (WebCore::InspectorDOMAgent::didModifyDOMAttr):
      (WebCore::InspectorDOMAgent::didRemoveDOMAttr):
      (WebCore::InspectorDOMAgent::styleAttributeInvalidated):
      (WebCore::InspectorDOMAgent::characterDataModified):
      (WebCore::InspectorDOMAgent::didPushShadowRoot):
      (WebCore::InspectorDOMAgent::willPopShadowRoot):
      * inspector/InspectorDOMAgent.h:
      * inspector/InspectorDOMDebuggerAgent.cpp:
      (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
      (WebCore::InspectorDOMDebuggerAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorDOMDebuggerAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
      (WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
      (WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
      (WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
      (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
      (WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
      * inspector/InspectorDOMDebuggerAgent.h:
      * inspector/InspectorDOMStorageAgent.cpp:
      (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
      (WebCore::InspectorDOMStorageAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorDOMStorageAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
      * inspector/InspectorDOMStorageAgent.h:
      * inspector/InspectorDatabaseAgent.cpp:
      (WebCore::InspectorDatabaseAgent::didOpenDatabase):
      (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
      (WebCore::InspectorDatabaseAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorDatabaseAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorDatabaseAgent::enable):
      * inspector/InspectorDatabaseAgent.h:
      * inspector/InspectorDatabaseResource.cpp:
      (WebCore::InspectorDatabaseResource::bind):
      * inspector/InspectorDatabaseResource.h:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
      (WebCore::InspectorDebuggerAgent::enable):
      (WebCore::InspectorDebuggerAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorDebuggerAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorDebuggerAgent::addMessageToConsole):
      (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
      (WebCore::InspectorDebuggerAgent::scriptExecutionBlockedByCSP):
      (WebCore::InspectorDebuggerAgent::didParseSource):
      (WebCore::InspectorDebuggerAgent::failedToParseSource):
      (WebCore::InspectorDebuggerAgent::didPause):
      (WebCore::InspectorDebuggerAgent::didContinue):
      (WebCore::InspectorDebuggerAgent::breakProgram):
      (WebCore::InspectorDebuggerAgent::clearBreakDetails):
      (WebCore::InspectorDebuggerAgent::reset):
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorHeapProfilerAgent.cpp:
      (WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
      (WebCore::InspectorHeapProfilerAgent::resetFrontendProfiles):
      (WebCore::InspectorHeapProfilerAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorHeapProfilerAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorHeapProfilerAgent::getHeapSnapshot):
      (WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):
      * inspector/InspectorHeapProfilerAgent.h:
      * inspector/InspectorIndexedDBAgent.cpp:
      (WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
      (WebCore::InspectorIndexedDBAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorIndexedDBAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorIndexedDBAgent.h:
      * inspector/InspectorInputAgent.cpp:
      (WebCore::InspectorInputAgent::InspectorInputAgent):
      (WebCore::InspectorInputAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorInputAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorInputAgent.h:
      * inspector/InspectorLayerTreeAgent.cpp:
      (WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
      (WebCore::InspectorLayerTreeAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorLayerTreeAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorLayerTreeAgent::layerTreeDidChange):
      * inspector/InspectorLayerTreeAgent.h:
      * inspector/InspectorMemoryAgent.cpp:
      (WebCore::InspectorMemoryAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorMemoryAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
      * inspector/InspectorMemoryAgent.h:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::InspectorPageAgent):
      (WebCore::InspectorPageAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorPageAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
      (WebCore::InspectorPageAgent::domContentEventFired):
      (WebCore::InspectorPageAgent::loadEventFired):
      (WebCore::InspectorPageAgent::frameNavigated):
      (WebCore::InspectorPageAgent::frameDetached):
      (WebCore::InspectorPageAgent::frameStartedLoading):
      (WebCore::InspectorPageAgent::frameStoppedLoading):
      (WebCore::InspectorPageAgent::frameScheduledNavigation):
      (WebCore::InspectorPageAgent::frameClearedScheduledNavigation):
      (WebCore::InspectorPageAgent::willRunJavaScriptDialog):
      (WebCore::InspectorPageAgent::didRunJavaScriptDialog):
      (WebCore::InspectorPageAgent::scriptsEnabled):
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
      (WebCore::InspectorProfilerAgent::addProfile):
      (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
      (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
      (WebCore::InspectorProfilerAgent::getHeapSnapshot):
      (WebCore::InspectorProfilerAgent::resetFrontendProfiles):
      (WebCore::InspectorProfilerAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorProfilerAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
      (WebCore::InspectorProfilerAgent::toggleRecordButton):
      * inspector/InspectorProfilerAgent.h:
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorResourceAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorResourceAgent::willSendRequest):
      (WebCore::InspectorResourceAgent::markResourceAsCached):
      (WebCore::InspectorResourceAgent::didReceiveResponse):
      (WebCore::InspectorResourceAgent::didReceiveData):
      (WebCore::InspectorResourceAgent::didFinishLoading):
      (WebCore::InspectorResourceAgent::didFailLoading):
      (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
      (WebCore::InspectorResourceAgent::didCreateWebSocket):
      (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
      (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
      (WebCore::InspectorResourceAgent::didCloseWebSocket):
      (WebCore::InspectorResourceAgent::didReceiveWebSocketFrame):
      (WebCore::InspectorResourceAgent::didSendWebSocketFrame):
      (WebCore::InspectorResourceAgent::didReceiveWebSocketFrameError):
      (WebCore::InspectorResourceAgent::enable):
      (WebCore::InspectorResourceAgent::InspectorResourceAgent):
      * inspector/InspectorResourceAgent.h:
      * inspector/InspectorRuntimeAgent.cpp:
      (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
      * inspector/InspectorRuntimeAgent.h:
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
      (WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorTimelineAgent::start):
      (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
      (WebCore::InspectorTimelineAgent::sendEvent):
      * inspector/InspectorTimelineAgent.h:
      * inspector/InspectorWorkerAgent.cpp:
      (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
      (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::dispatchMessageFromWorker):
      (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
      (WebCore::InspectorWorkerAgent::didCreateFrontendAndBackend):
      (WebCore::InspectorWorkerAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorWorkerAgent::enable):
      (WebCore::InspectorWorkerAgent::disable):
      (WebCore::InspectorWorkerAgent::didStartWorkerGlobalScope):
      (WebCore::InspectorWorkerAgent::workerGlobalScopeTerminated):
      (WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):
      * inspector/InspectorWorkerAgent.h:
      * inspector/PageRuntimeAgent.cpp:
      (WebCore::PageRuntimeAgent::PageRuntimeAgent):
      (WebCore::PageRuntimeAgent::didCreateFrontendAndBackend):
      (WebCore::PageRuntimeAgent::willDestroyFrontendAndBackend):
      (WebCore::PageRuntimeAgent::didCreateMainWorldContext):
      (WebCore::PageRuntimeAgent::didCreateIsolatedContext):
      (WebCore::PageRuntimeAgent::notifyContextCreated):
      * inspector/PageRuntimeAgent.h:
      * inspector/TimelineRecordFactory.h:
      * inspector/WorkerInspectorController.cpp:
      (WebCore::WorkerInspectorController::connectFrontend):
      (WebCore::WorkerInspectorController::disconnectFrontend):
      * inspector/WorkerInspectorController.h:
      (WebCore::WorkerInspectorController::hasFrontend):
      * inspector/WorkerRuntimeAgent.cpp:
      (WebCore::WorkerRuntimeAgent::didCreateFrontendAndBackend):
      (WebCore::WorkerRuntimeAgent::willDestroyFrontendAndBackend):
      * inspector/WorkerRuntimeAgent.h:
      * inspector/protocol/Input.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20fd448a
  3. 31 Oct, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Web Inspector: Remove InspectorState · f188ae90
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123547
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-10-31
      Reviewed by Timothy Hatcher.
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::InspectorAgent):
      * inspector/InspectorAgent.h:
      (WebCore::InspectorAgent::create):
      * inspector/InspectorAllInOne.cpp:
      * inspector/InspectorApplicationCacheAgent.cpp:
      (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
      * inspector/InspectorApplicationCacheAgent.h:
      (WebCore::InspectorApplicationCacheAgent::create):
      * inspector/InspectorBaseAgent.cpp:
      (WebCore::InspectorBaseAgentInterface::InspectorBaseAgentInterface):
      * inspector/InspectorBaseAgent.h:
      (WebCore::InspectorBaseAgent::InspectorBaseAgent):
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::InspectorCSSAgent):
      * inspector/InspectorCSSAgent.h:
      (WebCore::InspectorCSSAgent::create):
      * inspector/InspectorCanvasAgent.cpp:
      (WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
      * inspector/InspectorCanvasAgent.h:
      (WebCore::InspectorCanvasAgent::create):
      * inspector/InspectorClient.h:
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      (WebCore::InspectorController::connectFrontend):
      (WebCore::InspectorController::disconnectFrontend):
      * inspector/InspectorController.h:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::InspectorDOMAgent):
      * inspector/InspectorDOMAgent.h:
      (WebCore::InspectorDOMAgent::create):
      * inspector/InspectorDOMDebuggerAgent.cpp:
      (WebCore::InspectorDOMDebuggerAgent::create):
      (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
      * inspector/InspectorDOMDebuggerAgent.h:
      * inspector/InspectorDOMStorageAgent.cpp:
      (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
      * inspector/InspectorDOMStorageAgent.h:
      (WebCore::InspectorDOMStorageAgent::create):
      * inspector/InspectorDatabaseAgent.cpp:
      (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
      * inspector/InspectorDatabaseAgent.h:
      (WebCore::InspectorDatabaseAgent::create):
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorHeapProfilerAgent.cpp:
      (WebCore::InspectorHeapProfilerAgent::create):
      (WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
      * inspector/InspectorHeapProfilerAgent.h:
      * inspector/InspectorIndexedDBAgent.cpp:
      (WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
      * inspector/InspectorIndexedDBAgent.h:
      (WebCore::InspectorIndexedDBAgent::create):
      * inspector/InspectorInputAgent.cpp:
      (WebCore::InspectorInputAgent::InspectorInputAgent):
      * inspector/InspectorInputAgent.h:
      (WebCore::InspectorInputAgent::create):
      * inspector/InspectorLayerTreeAgent.cpp:
      (WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
      * inspector/InspectorLayerTreeAgent.h:
      (WebCore::InspectorLayerTreeAgent::create):
      * inspector/InspectorMemoryAgent.cpp:
      (WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
      (WebCore::InspectorMemoryAgent::create):
      * inspector/InspectorMemoryAgent.h:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::create):
      (WebCore::InspectorPageAgent::InspectorPageAgent):
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::PageProfilerAgent::PageProfilerAgent):
      (WebCore::InspectorProfilerAgent::create):
      (WebCore::WorkerProfilerAgent::WorkerProfilerAgent):
      (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
      * inspector/InspectorProfilerAgent.h:
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::InspectorResourceAgent):
      * inspector/InspectorResourceAgent.h:
      (WebCore::InspectorResourceAgent::create):
      * inspector/InspectorRuntimeAgent.cpp:
      (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
      * inspector/InspectorRuntimeAgent.h:
      * inspector/InspectorState.cpp: Removed.
      * inspector/InspectorState.h: Removed.
      * inspector/InspectorStateClient.h: Removed.
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
      * inspector/InspectorTimelineAgent.h:
      (WebCore::InspectorTimelineAgent::create):
      * inspector/InspectorWorkerAgent.cpp:
      (WebCore::InspectorWorkerAgent::create):
      (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
      * inspector/InspectorWorkerAgent.h:
      * inspector/PageConsoleAgent.cpp:
      (WebCore::PageConsoleAgent::PageConsoleAgent):
      * inspector/PageConsoleAgent.h:
      (WebCore::PageConsoleAgent::create):
      * inspector/PageDebuggerAgent.cpp:
      (WebCore::PageDebuggerAgent::create):
      (WebCore::PageDebuggerAgent::PageDebuggerAgent):
      * inspector/PageDebuggerAgent.h:
      * inspector/PageRuntimeAgent.cpp:
      (WebCore::PageRuntimeAgent::PageRuntimeAgent):
      * inspector/PageRuntimeAgent.h:
      (WebCore::PageRuntimeAgent::create):
      * inspector/WorkerConsoleAgent.cpp:
      (WebCore::WorkerConsoleAgent::WorkerConsoleAgent):
      * inspector/WorkerConsoleAgent.h:
      (WebCore::WorkerConsoleAgent::create):
      * inspector/WorkerDebuggerAgent.cpp:
      (WebCore::WorkerDebuggerAgent::create):
      (WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
      * inspector/WorkerDebuggerAgent.h:
      * inspector/WorkerInspectorController.cpp:
      (WebCore::WorkerInspectorController::WorkerInspectorController):
      (WebCore::WorkerInspectorController::connectFrontend):
      (WebCore::WorkerInspectorController::disconnectFrontend):
      * inspector/WorkerInspectorController.h:
      * inspector/WorkerRuntimeAgent.cpp:
      (WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
      * inspector/WorkerRuntimeAgent.h:
      (WebCore::WorkerRuntimeAgent::create):
      * workers/DefaultSharedWorkerRepository.cpp:
      (WebCore::SharedWorkerProxy::postMessageToPageInspector):
      * workers/WorkerMessagingProxy.cpp:
      (WebCore::WorkerMessagingProxy::postMessageToPageInspector):
      * workers/WorkerMessagingProxy.h:
      * workers/WorkerReportingProxy.h:
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/InspectorClientBlackBerry.cpp:
      * WebCoreSupport/InspectorClientBlackBerry.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f188ae90
  4. 30 Oct, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Web Inspector: Remove basic uses of InspectorState from agents · d9bc7dbe
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123534
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-10-30
      Reviewed by Timothy Hatcher.
      
      * inspector/InspectorAgent.h:
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::InspectorAgent):
      (WebCore::InspectorAgent::enable):
      (WebCore::InspectorAgent::disable):
      (WebCore::InspectorAgent::evaluateForTestInFrontend):
      (WebCore::InspectorAgent::inspect):
      InspectorAgentState::inspectorAgentEnabled -> m_enabled.
      
      * inspector/InspectorApplicationCacheAgent.cpp:
      (WebCore::InspectorApplicationCacheAgent::enable):
      Remove unused state.
      
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::enable):
      (WebCore::InspectorCSSAgent::disable):
      (WebCore::InspectorCSSAgent::startSelectorProfiler):
      (WebCore::InspectorCSSAgent::stopSelectorProfilerImpl):
      Remove unused states. Make CSSAgentState::isSelectorProfiling check profile object exists or not.
      
      * inspector/InspectorCanvasAgent.cpp:
      (WebCore::InspectorCanvasAgent::enable):
      (WebCore::InspectorCanvasAgent::disable):
      Remove unused state, member variable already existed.
      
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
      (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
      (WebCore::InspectorConsoleAgent::enable):
      (WebCore::InspectorConsoleAgent::disable):
      (WebCore::InspectorConsoleAgent::didFinishXHRLoading):
      (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
      ConsoleAgentState::consoleMessagesEnabled already had m_enabled.
      ConsoleAgentState::monitoringXHR -> m_monitoringXHREnabled.
      
      * inspector/InspectorDOMAgent.h:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::InspectorDOMAgent):
      (WebCore::InspectorDOMAgent::clearFrontend):
      (WebCore::InspectorDOMAgent::setDocument):
      (WebCore::InspectorDOMAgent::getDocument):
      (WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
      DOMAgentState::documentRequested -> m_documentRequested.
      
      * inspector/InspectorDOMDebuggerAgent.h:
      * inspector/InspectorDOMDebuggerAgent.cpp:
      (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
      (WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
      (WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
      (WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
      DOMDebuggerAgentState::pauseOnAllXHRs -> m_pauseOnAllXHRsEnabled.
      
      * inspector/InspectorDOMStorageAgent.h:
      * inspector/InspectorDOMStorageAgent.cpp:
      (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
      (WebCore::InspectorDOMStorageAgent::enable):
      (WebCore::InspectorDOMStorageAgent::disable):
      (WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
      DOMStorageAgentState::domStorageAgentEnabled -> m_enabled.
      
      * inspector/InspectorDatabaseAgent.cpp:
      (WebCore::InspectorDatabaseAgent::enable):
      (WebCore::InspectorDatabaseAgent::disable):
      Remove unused state, m_enabled already existed.
      
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
      (WebCore::InspectorDebuggerAgent::enable):
      (WebCore::InspectorDebuggerAgent::disable):
      (WebCore::InspectorDebuggerAgent::enabled):
      (WebCore::InspectorDebuggerAgent::clearFrontend):
      (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsImpl):
      DebuggerAgentState::pauseOnExceptionsState removed, never read.
      DebuggerAgentState::debuggerEnabled -> m_enabled.
      
      * inspector/InspectorHeapProfilerAgent.h:
      * inspector/InspectorHeapProfilerAgent.cpp:
      (WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
      (WebCore::InspectorHeapProfilerAgent::resetFrontendProfiles):
      (WebCore::InspectorHeapProfilerAgent::clearFrontend):
      (WebCore::InspectorHeapProfilerAgent::getProfileHeaders):
      HeapProfilerAgentState::profileHeadersRequested -> m_profileHeadersRequested.
      
      * inspector/InspectorIndexedDBAgent.cpp:
      (WebCore::InspectorIndexedDBAgent::enable):
      (WebCore::InspectorIndexedDBAgent::disable):
      Remove unused state, never read.
      
      * inspector/InspectorLayerTreeAgent.cpp:
      (WebCore::InspectorLayerTreeAgent::enable):
      (WebCore::InspectorLayerTreeAgent::disable):
      Remove unused state, did not need to be read.
      
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::InspectorPageAgent):
      (WebCore::InspectorPageAgent::webViewResized):
      (WebCore::InspectorPageAgent::enable):
      (WebCore::InspectorPageAgent::disable):
      (WebCore::InspectorPageAgent::setDeviceMetricsOverride):
      (WebCore::InspectorPageAgent::deviceMetricsChanged):
      (WebCore::InspectorPageAgent::setShowPaintRects):
      (WebCore::InspectorPageAgent::setShowDebugBorders):
      (WebCore::InspectorPageAgent::setShowFPSCounter):
      (WebCore::InspectorPageAgent::setContinuousPaintingEnabled):
      (WebCore::InspectorPageAgent::setScriptExecutionDisabled):
      (WebCore::InspectorPageAgent::applyScreenWidthOverride):
      (WebCore::InspectorPageAgent::applyScreenHeightOverride):
      (WebCore::InspectorPageAgent::didPaint):
      (WebCore::InspectorPageAgent::didLayout):
      (WebCore::InspectorPageAgent::updateTouchEventEmulationInPage):
      (WebCore::InspectorPageAgent::setTouchEmulationEnabled):
      (WebCore::InspectorPageAgent::setEmulatedMedia):
      (WebCore::InspectorPageAgent::applyEmulatedMedia):
      PageAgentState::pageAgentScreenWidthOverride -> m_screenWidthOverride.
      PageAgentState::pageAgentScreenHeightOverride -> m_screenHeightOverride.
      PageAgentState::pageAgentFontScaleFactorOverride -> m_fontScaleFactorOverride.
      PageAgentState::pageAgentFitWindow -> m_fitWindowOverride.
      PageAgentState::pageAgentShowPaintRects -> m_showPaintRects.
      PageAgentState::pageAgentEmulatedMedia -> m_emulatedMedia.
      Remove other unused states.
      
      * inspector/InspectorProfilerAgent.h:
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
      (WebCore::InspectorProfilerAgent::addProfile):
      (WebCore::InspectorProfilerAgent::enable):
      (WebCore::InspectorProfilerAgent::disable):
      (WebCore::InspectorProfilerAgent::getProfileHeaders):
      (WebCore::InspectorProfilerAgent::resetFrontendProfiles):
      (WebCore::InspectorProfilerAgent::start):
      (WebCore::InspectorProfilerAgent::stop):
      (WebCore::InspectorProfilerAgent::enabled):
      ProfilerAgentState::profileHeadersRequested -> m_profileHeadersRequested.
      Remove other unused states.
      
      * inspector/InspectorResourceAgent.h:
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::~InspectorResourceAgent):
      (WebCore::InspectorResourceAgent::willSendRequest):
      (WebCore::InspectorResourceAgent::applyUserAgentOverride):
      (WebCore::InspectorResourceAgent::enable):
      (WebCore::InspectorResourceAgent::disable):
      (WebCore::InspectorResourceAgent::setUserAgentOverride):
      (WebCore::InspectorResourceAgent::setCacheDisabled):
      (WebCore::InspectorResourceAgent::mainFrameNavigated):
      (WebCore::InspectorResourceAgent::InspectorResourceAgent):
      ResourceAgentState::resourceAgentEnabled -> m_enabled.
      ResourceAgentState::cacheDisabled -> m_cacheDisabled.
      ResourceAgentState::userAgentOverride -> m_userAgentOverride (this already existed and was unused).
      
      * inspector/InspectorTimelineAgent.h:
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::start):
      (WebCore::InspectorTimelineAgent::stop):
      (WebCore::InspectorTimelineAgent::setDOMCounters):
      (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
      TimelineAgentState::timelineAgentEnabled -> m_enabled.
      TimelineAgentState::includeDomCounters -> m_includeDOMCounters.
      Remove other unused states.
      
      * inspector/InspectorWorkerAgent.h:
      * inspector/InspectorWorkerAgent.cpp:
      (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
      (WebCore::InspectorWorkerAgent::clearFrontend):
      (WebCore::InspectorWorkerAgent::enable):
      (WebCore::InspectorWorkerAgent::disable):
      (WebCore::InspectorWorkerAgent::setAutoconnectToWorkers):
      (WebCore::InspectorWorkerAgent::shouldPauseDedicatedWorkerOnStart):
      (WebCore::InspectorWorkerAgent::didStartWorkerGlobalScope):
      (WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):
      WorkerAgentState::workerInspectionEnabled -> m_enabled.
      WorkerAgentState::autoconnectToWorkers -> m_shouldPauseDedicatedWorkerOnStart.
      
      * inspector/PageRuntimeAgent.cpp:
      (WebCore::PageRuntimeAgent::enable):
      (WebCore::PageRuntimeAgent::disable):
      Remove unused state, not read.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9bc7dbe
  5. 02 Oct, 2013 1 commit
    • weinig@apple.com's avatar
      CTTE: DOMWrapperWorlds should be passed around by reference · 8f716033
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122206
      
      Reviewed by Andreas Kling.
      
      ../WebCore: 
      
      * bindings/js/DOMWrapperWorld.cpp:
      (WebCore::DOMWrapperWorld::DOMWrapperWorld):
      (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
      (WebCore::DOMWrapperWorld::clearWrappers):
      (WebCore::normalWorld):
      (WebCore::mainThreadNormalWorld):
      * bindings/js/DOMWrapperWorld.h:
      (WebCore::debuggerWorld):
      (WebCore::pluginWorld):
      (WebCore::currentWorld):
      * bindings/js/JSCSSStyleDeclarationCustom.cpp:
      (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
      * bindings/js/JSCSSValueCustom.cpp:
      (WebCore::JSCSSValueOwner::finalize):
      * bindings/js/JSDOMBinding.h:
      (WebCore::wrapperOwner):
      (WebCore::wrapperContext):
      (WebCore::getInlineCachedWrapper):
      (WebCore::setInlineCachedWrapper):
      (WebCore::clearInlineCachedWrapper):
      (WebCore::getCachedWrapper):
      (WebCore::cacheWrapper):
      (WebCore::uncacheWrapper):
      (WebCore::jsStringWithCache):
      * bindings/js/JSDOMGlobalObject.cpp:
      (WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
      (WebCore::toJSDOMGlobalObject):
      * bindings/js/JSDOMGlobalObject.h:
      (WebCore::JSDOMGlobalObject::world):
      * bindings/js/JSDOMWindowBase.cpp:
      (WebCore::JSDOMWindowBase::JSDOMWindowBase):
      (WebCore::toJSDOMWindow):
      * bindings/js/JSDOMWindowBase.h:
      * bindings/js/JSDOMWindowShell.cpp:
      (WebCore::JSDOMWindowShell::JSDOMWindowShell):
      (WebCore::JSDOMWindowShell::setWindow):
      (WebCore::toJSDOMWindowShell):
      * bindings/js/JSDOMWindowShell.h:
      (WebCore::JSDOMWindowShell::create):
      (WebCore::JSDOMWindowShell::world):
      * bindings/js/JSErrorHandler.cpp:
      (WebCore::JSErrorHandler::JSErrorHandler):
      * bindings/js/JSErrorHandler.h:
      (WebCore::JSErrorHandler::create):
      * bindings/js/JSEventListener.cpp:
      (WebCore::JSEventListener::JSEventListener):
      (WebCore::JSEventListener::handleEvent):
      * bindings/js/JSEventListener.h:
      (WebCore::JSEventListener::create):
      (WebCore::JSEventListener::isolatedWorld):
      * bindings/js/JSInjectedScriptHostCustom.cpp:
      (WebCore::getJSListenerFunctions):
      * bindings/js/JSLazyEventListener.cpp:
      (WebCore::JSLazyEventListener::JSLazyEventListener):
      * bindings/js/JSLazyEventListener.h:
      * bindings/js/JSMutationCallback.cpp:
      (WebCore::JSMutationCallback::JSMutationCallback):
      (WebCore::JSMutationCallback::call):
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::JSNodeOwner::finalize):
      * bindings/js/JSPluginElementFunctions.h:
      (WebCore::pluginElementCustomGetOwnPropertySlot):
      * bindings/js/JSWorkerGlobalScopeBase.cpp:
      (WebCore::JSWorkerGlobalScopeBase::JSWorkerGlobalScopeBase):
      * bindings/js/ScheduledAction.cpp:
      (WebCore::ScheduledAction::create):
      (WebCore::ScheduledAction::ScheduledAction):
      (WebCore::ScheduledAction::execute):
      * bindings/js/ScheduledAction.h:
      (WebCore::ScheduledAction::ScheduledAction):
      * bindings/js/ScriptCachedFrameData.cpp:
      (WebCore::ScriptCachedFrameData::restore):
      * bindings/js/ScriptCachedFrameData.h:
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::~ScriptController):
      (WebCore::ScriptController::destroyWindowShell):
      (WebCore::ScriptController::createWindowShell):
      (WebCore::ScriptController::evaluateInWorld):
      (WebCore::ScriptController::getAllWorlds):
      (WebCore::ScriptController::initScript):
      (WebCore::ScriptController::executeScriptInWorld):
      (WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
      * bindings/js/ScriptController.h:
      (WebCore::ScriptController::windowShell):
      (WebCore::ScriptController::existingWindowShell):
      (WebCore::ScriptController::globalObject):
      * bindings/js/ScriptDebugServer.cpp:
      (WebCore::ScriptDebugServer::isContentScript):
      * bindings/js/ScriptState.cpp:
      (WebCore::execStateFromNode):
      (WebCore::execStateFromPage):
      * bindings/js/ScriptState.h:
      * bindings/js/SerializedScriptValue.cpp:
      (WebCore::SerializedScriptValue::transferArrayBuffers):
      * bindings/js/WebCoreJSClientData.h:
      (WebCore::WebCoreJSClientData::WebCoreJSClientData):
      (WebCore::WebCoreJSClientData::normalWorld):
      (WebCore::WebCoreJSClientData::getAllWorlds):
      (WebCore::WebCoreJSClientData::rememberWorld):
      (WebCore::WebCoreJSClientData::forgetWorld):
      * bindings/js/WebCoreTypedArrayController.cpp:
      (WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::finalize):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      * dom/Document.cpp:
      (WebCore::Document::ensurePlugInsInjectedScript):
      * dom/Document.h:
      * dom/DocumentStyleSheetCollection.cpp:
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::ensureIsolatedWorld):
      (WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
      (WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
      * html/HTMLMediaElement.h:
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::plugInImageElementIsolatedWorld):
      (WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::didClearWindowObjectInWorld):
      * inspector/InspectorAgent.h:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::didClearWindowObjectInWorld):
      * inspector/InspectorController.h:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::buildObjectForEventListener):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
      * inspector/InspectorInstrumentation.h:
      (WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
      * inspector/InspectorPageAgent.h:
      * loader/EmptyClients.h:
      (WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
      (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
      (WebCore::FrameLoader::dispatchGlobalObjectAvailableInAllWorlds):
      * loader/FrameLoader.h:
      * loader/FrameLoaderClient.h:
      (WebCore::FrameLoaderClient::dispatchGlobalObjectAvailable):
      * page/CaptionUserPreferencesMediaAF.cpp:
      * page/DOMWindowExtension.cpp:
      (WebCore::DOMWindowExtension::DOMWindowExtension):
      * page/DOMWindowExtension.h:
      (WebCore::DOMWindowExtension::create):
      (WebCore::DOMWindowExtension::world):
      * page/Frame.cpp:
      (WebCore::Frame::injectUserScripts):
      (WebCore::Frame::injectUserScriptsForWorld):
      * page/Frame.h:
      * page/PageGroup.cpp:
      (WebCore::PageGroup::addUserScriptToWorld):
      (WebCore::PageGroup::addUserStyleSheetToWorld):
      (WebCore::PageGroup::removeUserScriptFromWorld):
      (WebCore::PageGroup::removeUserStyleSheetFromWorld):
      (WebCore::PageGroup::removeUserScriptsFromWorld):
      (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
      * page/PageGroup.h:
      
      ../WebKit/efl: 
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
      * WebCoreSupport/FrameLoaderClientEfl.h:
      
      ../WebKit/gtk: 
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
      * WebCoreSupport/FrameLoaderClientGtk.h:
      
      ../WebKit/mac: 
      
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
      (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
      (WebKit::NetscapePluginInstanceProxy::evaluate):
      * WebCoreSupport/WebFrameLoaderClient.h:
      * WebCoreSupport/WebFrameLoaderClient.mm:
      * WebView/WebFrame.mm:
      (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
      (-[WebFrame _globalContextForScriptWorld:]):
      (-[WebFrame jsWrapperForNode:inScriptWorld:]):
      * WebView/WebScriptWorld.mm:
      (+[WebScriptWorld standardWorld]):
      (+[WebScriptWorld findOrCreateWorld:]):
      * WebView/WebScriptWorldInternal.h:
      * WebView/WebView.mm:
      (-[WebView _injectOutlookQuirksScript]):
      (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
      (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
      (+[WebView _removeUserScriptFromGroup:world:url:]):
      (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
      (+[WebView _removeUserScriptsFromGroup:world:]):
      (+[WebView _removeUserStyleSheetsFromGroup:world:]):
      
      ../WebKit/win: 
      
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
      * WebCoreSupport/WebFrameLoaderClient.h:
      * WebScriptWorld.cpp:
      (WebScriptWorld::standardWorld):
      (WebScriptWorld::findOrCreateWorld):
      * WebScriptWorld.h:
      (WebScriptWorld::world):
      
      ../WebKit/wince: 
      
      * WebCoreSupport/FrameLoaderClientWinCE.cpp:
      (WebKit::FrameLoaderClientWinCE::dispatchDidClearWindowObjectInWorld):
      * WebCoreSupport/FrameLoaderClientWinCE.h:
      
      ../WebKit2: 
      
      * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
      (WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
      (WebKit::InjectedBundlePageLoaderClient::globalObjectIsAvailableForFrame):
      * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
      * WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:
      (WebKit::InjectedBundleScriptWorld::getOrCreate):
      (WebKit::InjectedBundleScriptWorld::normalWorld):
      (WebKit::InjectedBundleScriptWorld::coreWorld):
      * WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::windowScriptNPObject):
      (WebKit::PluginView::pluginElementNPObject):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
      (WebKit::WebFrameLoaderClient::dispatchGlobalObjectAvailable):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f716033
  6. 28 Sep, 2013 1 commit
    • darin@apple.com's avatar
      Add Frame::mainFrame and Frame::isMainFrame · 0e83ab12
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122064
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      * WebCore.exp.in: Removed exports of FrameView::isMainFrameView and
      Page::frameIsMainFrame. Since the new isMainFrame function is inline, it
      does not need to be exported.
      
      * history/PageCache.cpp:
      (WebCore::PageCache::markPagesForFullStyleRecalc):
      (WebCore::PageCache::markPagesForDeviceScaleChanged):
      These two were the only functions I found that really wanted the equivalent
      of Page::frameIsMainFrame, so wrote it out here instead of using a function
      call.
      
      * inspector/InspectorAgent.cpp: Removed the unused isMainResourceLoader function.
      * inspector/InspectorAgent.h: Removed declarations of a few nonexistent or
      unused private member functions. Also removed the InjectedScriptForOriginMap
      typedef: It's mor readable to use the type directly
      
      * loader/FrameLoader.h: Removed isLoadingMainFrame. It's not better than
      calling frame().isMainFrame() directly.
      
      * page/Frame.cpp:
      (WebCore::Frame::Frame): Initialize m_mainFrame and call selfOnlyRef, keeping
      the MainFrame alive as long as any of its subframes is alive.
      (WebCore::Frame::~Frame): Call selfOnlyDeref.
      (WebCore::Frame::createView): Use isMainFrame.
      (WebCore::Frame::setPageAndTextZoomFactors): Ditto.
      
      * page/Frame.h: Added Frame::mainFrame, Frame::isMainFrame, and Frame::m_mainFrame.
      
      * page/FrameView.h: Removed the isMainFrameView function. It's not better than
      calling frame().isMainFrame() directly.
      
      * page/MainFrame.cpp:
      (WebCore::MainFrame::MainFrame): Initialize m_selfOnlyRefCount to 0.
      (WebCore::MainFrame::selfOnlyRef): Added.
      (WebCore::MainFrame::selfOnlyDeref): Added.
      (WebCore::MainFrame::dropChildren): Added. Called when the self-only reference
      count reaches 0 to avoid a reference cycle with subframes.
      
      * page/MainFrame.h: Added new data members as mentioned above. Also, the
      definition of the Frame::isMainFrame inline function goes here, since it can't
      compile without the MainFrame class definition. This means that callers of
      isMainFrame need to include MainFrame.h, which seems reasonable and is easy
      to do.
      
      * page/Page.cpp:
      * page/Page.h: Added assertion to Page::mainFrame since it returns a reference.
      Removed Page::frameIsMainFrame since it's not better than calling isMainFrame
      on the frame.
      
      * dom/Document.cpp:
      (WebCore::Document::setVisualUpdatesAllowed):
      (WebCore::Document::didBecomeCurrentDocumentInFrame):
      (WebCore::Document::updateViewportArguments):
      (WebCore::Document::setInPageCache):
      (WebCore::Document::ensurePlugInsInjectedScript):
      * history/CachedFrame.cpp:
      (WebCore::CachedFrame::CachedFrame):
      * history/CachedPage.cpp:
      (WebCore::CachedPage::restore):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):
      * html/ImageDocument.cpp:
      (WebCore::ImageDocument::shouldShrinkToFit):
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::didClearWindowObjectInWorld):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::didCommitLoadImpl):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
      (WebCore::InspectorPageAgent::frameNavigated):
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::willSendRequest):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::transitionToCommitted):
      (WebCore::FrameLoader::prepareForCachedPageRestore):
      (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
      (WebCore::FrameLoader::didLayout):
      (WebCore::FrameLoader::checkLoadComplete):
      (WebCore::FrameLoader::addExtraFieldsToRequest):
      (WebCore::FrameLoader::loadResourceSynchronously):
      (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
      (WebCore::FrameLoader::dispatchDidCommitLoad):
      (WebCore::FrameLoader::loadProgressingStatusChanged):
      * loader/HistoryController.cpp:
      (WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
      (WebCore::HistoryController::restoreScrollPositionAndViewState):
      (WebCore::HistoryController::updateForCommit):
      (WebCore::HistoryController::updateForSameDocumentNavigation):
      (WebCore::HistoryController::updateBackForwardListClippedAtTarget):
      (WebCore::HistoryController::pushState):
      * loader/icon/IconController.cpp:
      (WebCore::IconController::startLoader):
      * page/AutoscrollController.cpp:
      (WebCore::AutoscrollController::stopAutoscrollTimer):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::populate):
      * page/DOMWindow.cpp:
      (WebCore::allowsBeforeUnloadListeners):
      (WebCore::DOMWindow::focus):
      (WebCore::DOMWindow::blur):
      (WebCore::DOMWindow::close):
      (WebCore::DOMWindow::allowedToChangeWindowGeometry):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::hitTestResultAtPoint):
      (WebCore::EventHandler::selectCursor):
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::keyEvent):
      * page/FrameTree.cpp:
      (WebCore::FrameTree::find):
      (WebCore::FrameTree::traverseNextWithWrap):
      * page/FrameView.cpp:
      (WebCore::FrameView::FrameView):
      (WebCore::FrameView::setFrameRect):
      (WebCore::FrameView::createScrollbar):
      (WebCore::FrameView::applyOverflowToViewport):
      (WebCore::FrameView::setHeaderHeight):
      (WebCore::FrameView::setFooterHeight):
      (WebCore::FrameView::minimumScrollPosition):
      (WebCore::FrameView::maximumScrollPosition):
      (WebCore::FrameView::shouldUpdateFixedElementsAfterScrolling):
      (WebCore::FrameView::beginDeferredRepaints):
      (WebCore::FrameView::endDeferredRepaints):
      (WebCore::FrameView::performPostLayoutTasks):
      (WebCore::FrameView::sendResizeEventIfNeeded):
      (WebCore::FrameView::pagination):
      (WebCore::FrameView::visibleContentScaleFactor):
      (WebCore::FrameView::setVisibleScrollerThumbRect):
      (WebCore::FrameView::scrollbarStyleChanged):
      (WebCore::FrameView::paintScrollCorner):
      (WebCore::FrameView::paintScrollbar):
      (WebCore::FrameView::paintOverhangAreas):
      * page/scrolling/ScrollingCoordinator.cpp:
      (WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::RenderLayerBacking):
      Use the new functions where possible instead of Page::frameIsMainFrame,
      Page::mainFrame, FrameLoader::isLoadingMainFrame, and FrameView::isMainFrameView.
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
      Call isMainFrame.
      
      Source/WebKit/efl:
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
      (WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
      (WebCore::FrameLoaderClientEfl::updateGlobalHistory):
      Call isMainFrame.
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
      Call isMainFrame.
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::canHandleRequest):
      (WebFrameLoaderClient::transitionToCommittedForNewPage):
      * WebView/WebFrameView.mm:
      (-[WebFrameView _install]):
      Call isMainFrame.
      
      Source/WebKit2:
      
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::shouldUseTiledBackingForFrameView):
      Call isMainFrame.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e83ab12
  7. 27 Sep, 2013 1 commit
    • darin@apple.com's avatar
      rename KURL to URL · 5ffbb5c7
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=16214
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      * many files: Renamed, using script.
      
      Source/WebKit:
      
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
      Let the script to try to rename here.
      
      Source/WebKit/blackberry:
      
      * many files: Renamed, using script.
      
      Source/WebKit/efl:
      
      * many files: Renamed, using script.
      
      Source/WebKit/gtk:
      
      * many files: Renamed, using script.
      
      Source/WebKit/mac:
      
      * many files: Renamed, using script.
      
      Source/WebKit/qt:
      
      * many files: Renamed, using script.
      
      Source/WebKit/win:
      
      * many files: Renamed, using script.
      
      Source/WebKit/wince:
      
      * many files: Renamed, using script.
      
      Source/WebKit2:
      
      * many files: Renamed, using script.
      
      Tools:
      
      * many files: Renamed, using script.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ffbb5c7
  8. 25 Dec, 2012 1 commit
    • apavlov@chromium.org's avatar
      Web Inspector: Make InspectorState instances per-agent, corresponding to JSON... · c7e14331
      apavlov@chromium.org authored
      Web Inspector: Make InspectorState instances per-agent, corresponding to JSON map entries in the cookie
      https://bugs.webkit.org/show_bug.cgi?id=105722
      
      Reviewed by Yury Semikhatsky.
      
      Inspector state cookie (in JSON format) has become a map (agent name -> "properties object")
      to avoid cross-agent property name clashes in a single property namespace.
      As such, InspectorState corresponds to a single "properties object" and is now per-agent,
      managed by an InspectorCompositeState (which is owned by [Worker]InspectorController).
      Since InspectorCompositeState maps "properties objects" by their agent names, InspectorStates are created
      by InspectorCompositeState in the InspectorBaseAgentInterface ctor, using the respective agent name.
      
      No new tests, no change in visible behavior.
      
      * inspector/InspectorAgent.cpp: Pass InspectorCompositeState rather than InspectorState.
      * inspector/InspectorAgent.h: Ditto.
      * inspector/InspectorApplicationCacheAgent.cpp: Ditto.
      * inspector/InspectorApplicationCacheAgent.h: Ditto.
      * inspector/InspectorBaseAgent.cpp: Ditto.
      (WebCore::InspectorBaseAgentInterface::InspectorBaseAgentInterface):
      Create InspectorState via InspectorCompositeState::createAgentState(agentName).
      * inspector/InspectorBaseAgent.h: Pass InspectorCompositeState rather than InspectorState.
      * inspector/InspectorCSSAgent.cpp: Ditto.
      * inspector/InspectorCSSAgent.h: Ditto.
      * inspector/InspectorCanvasAgent.cpp: Ditto.
      * inspector/InspectorCanvasAgent.h: Ditto.
      * inspector/InspectorConsoleAgent.cpp: Ditto.
      * inspector/InspectorConsoleAgent.h: Ditto.
      * inspector/InspectorController.cpp: Use InspectorCompositeState rather than InspectorState.
      * inspector/InspectorController.h: Ditto.
      * inspector/InspectorDOMAgent.cpp: Pass InspectorCompositeState rather than InspectorState.
      (WebCore::InspectorDOMAgent::InspectorDOMAgent): Ditto.
      * inspector/InspectorDOMAgent.h: Ditto.
      * inspector/InspectorDOMDebuggerAgent.cpp: Ditto.
      * inspector/InspectorDOMDebuggerAgent.h: Ditto.
      * inspector/InspectorDOMStorageAgent.cpp: Ditto.
      * inspector/InspectorDOMStorageAgent.h: Ditto.
      * inspector/InspectorDatabaseAgent.cpp: Ditto.
      * inspector/InspectorDatabaseAgent.h: Ditto.
      * inspector/InspectorDebuggerAgent.cpp: Ditto.
      * inspector/InspectorDebuggerAgent.h: Ditto.
      * inspector/InspectorFileSystemAgent.cpp: Ditto.
      * inspector/InspectorFileSystemAgent.h: Ditto.
      * inspector/InspectorIndexedDBAgent.cpp: Ditto.
      * inspector/InspectorIndexedDBAgent.h: Ditto.
      * inspector/InspectorInputAgent.cpp: Ditto.
      * inspector/InspectorInputAgent.h: Ditto.
      * inspector/InspectorLayerTreeAgent.cpp: Ditto.
      * inspector/InspectorLayerTreeAgent.h: Ditto.
      * inspector/InspectorMemoryAgent.cpp: Ditto.
      * inspector/InspectorMemoryAgent.h: Ditto.
      * inspector/InspectorPageAgent.cpp: Ditto.
      * inspector/InspectorPageAgent.h: Ditto.
      * inspector/InspectorProfilerAgent.cpp: Ditto.
      * inspector/InspectorProfilerAgent.h: Ditto.
      * inspector/InspectorResourceAgent.cpp: Ditto.
      * inspector/InspectorResourceAgent.h: Ditto.
      * inspector/InspectorRuntimeAgent.cpp: Ditto.
      * inspector/InspectorRuntimeAgent.h: Ditto.
      * inspector/InspectorState.cpp: Introduce InspectorCompositeState, refactor.
      (WebCore::InspectorState::updateCookie): Delegates to the owning InspectorCompositeState instance.
      (WebCore::InspectorState::setFromCookie): Gets called from InspectorCompositeState::loadFromCookie().
      (WebCore::InspectorState::remove): Don't forget to update the cookie.
      (WebCore::InspectorCompositeState::createAgentState): Creates an InspectorState instance for a named agent.
      (WebCore::InspectorCompositeState::loadFromCookie): Restores InspectorStates from a cookie.
      (WebCore::InspectorCompositeState::inspectorStateUpdated): Delegate invoked from InspectorState::updateCookie().
      * inspector/InspectorState.h:
      (InspectorStateUpdateListener): InspectorCompositeState API exposed to InspectorState.
      * inspector/InspectorTimelineAgent.cpp: Pass InspectorCompositeState rather than InspectorState.
      * inspector/InspectorTimelineAgent.h: Ditto.
      * inspector/InspectorWorkerAgent.cpp: Ditto.
      * inspector/InspectorWorkerAgent.h: Ditto.
      * inspector/PageConsoleAgent.cpp: Ditto.
      * inspector/PageConsoleAgent.h: Ditto.
      * inspector/PageDebuggerAgent.cpp: Ditto.
      * inspector/PageDebuggerAgent.h: Ditto.
      * inspector/PageRuntimeAgent.cpp: Ditto.
      * inspector/PageRuntimeAgent.h: Ditto.
      * inspector/WorkerConsoleAgent.cpp: Ditto.
      * inspector/WorkerConsoleAgent.h: Ditto.
      * inspector/WorkerDebuggerAgent.cpp: Ditto.
      * inspector/WorkerDebuggerAgent.h: Ditto.
      * inspector/WorkerInspectorController.cpp: Ditto.
      * inspector/WorkerInspectorController.h: Ditto.
      * inspector/WorkerRuntimeAgent.cpp: Ditto.
      * inspector/WorkerRuntimeAgent.h: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7e14331
  9. 31 Oct, 2012 3 commits
    • pfeldman@chromium.org's avatar
      Web Inspector: frame chooser does not work on subsequent inspector open. · c249466f
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100771
      
      Reviewed by Yury Semikhatsky.
      
      - Make WorkerRuntimeAgent and PageRuntimeAgent register themselves in the instrumenting agents independently
      - Move pause / run worker handling from InspectorRuntimeAgent into WorkerRuntimeAgent
      - Remove remains of the front-end reused signal from InspectorAgent
      - Send execution contexts post clear window object instead of post commit load.
      
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::InspectorAgent):
      (WebCore::InspectorAgent::clearFrontend):
      (WebCore::InspectorAgent::didCommitLoad):
      * inspector/InspectorAgent.h:
      (InspectorAgent):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
      (WebCore::InspectorInstrumentation::willEvaluateWorkerScript):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::restore):
      * inspector/InspectorRuntimeAgent.cpp:
      (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
      (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
      (WebCore::InspectorRuntimeAgent::run):
      (WebCore::InspectorRuntimeAgent::setScriptDebugServer):
      * inspector/InspectorRuntimeAgent.h:
      (InspectorRuntimeAgent):
      * inspector/InstrumentingAgents.h:
      (WebCore):
      (WebCore::InstrumentingAgents::InstrumentingAgents):
      (WebCore::InstrumentingAgents::workerRuntimeAgent):
      (WebCore::InstrumentingAgents::setWorkerRuntimeAgent):
      (InstrumentingAgents):
      * inspector/PageRuntimeAgent.cpp:
      (WebCore::PageRuntimeAgent::PageRuntimeAgent):
      (WebCore::PageRuntimeAgent::~PageRuntimeAgent):
      (WebCore::PageRuntimeAgent::setFrontend):
      (WebCore::PageRuntimeAgent::clearFrontend):
      (WebCore::PageRuntimeAgent::enable):
      (WebCore::PageRuntimeAgent::didCreateMainWorldContext):
      * inspector/PageRuntimeAgent.h:
      (PageRuntimeAgent):
      * inspector/WorkerRuntimeAgent.cpp:
      (WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
      (WebCore::WorkerRuntimeAgent::~WorkerRuntimeAgent):
      (WebCore::WorkerRuntimeAgent::run):
      (WebCore):
      (WebCore::WorkerRuntimeAgent::pauseWorkerContext):
      * inspector/WorkerRuntimeAgent.h:
      (WorkerRuntimeAgent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c249466f
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r133015. · 841edfd0
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/133015
      https://bugs.webkit.org/show_bug.cgi?id=100847
      
      broke Apple Win Debug compilation (Requested by podivilov on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-31
      
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::InspectorAgent):
      (WebCore::InspectorAgent::clearFrontend):
      (WebCore::InspectorAgent::didCommitLoad):
      * inspector/InspectorAgent.h:
      (WebCore::InspectorAgent::didCommitLoadFired):
      (InspectorAgent):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
      (WebCore::InspectorInstrumentation::willEvaluateWorkerScript):
      (WebCore::InspectorInstrumentation::runtimeAgentEnabled):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::restore):
      * inspector/InspectorRuntimeAgent.cpp:
      (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
      (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
      (WebCore::InspectorRuntimeAgent::run):
      (WebCore):
      (WebCore::InspectorRuntimeAgent::pauseWorkerContext):
      * inspector/InspectorRuntimeAgent.h:
      (InspectorRuntimeAgent):
      * inspector/InstrumentingAgents.h:
      (WebCore):
      (WebCore::InstrumentingAgents::InstrumentingAgents):
      (WebCore::InstrumentingAgents::inspectorRuntimeAgent):
      (WebCore::InstrumentingAgents::setInspectorRuntimeAgent):
      (InstrumentingAgents):
      * inspector/PageRuntimeAgent.cpp:
      (WebCore::PageRuntimeAgent::PageRuntimeAgent):
      (WebCore::PageRuntimeAgent::~PageRuntimeAgent):
      (WebCore::PageRuntimeAgent::setFrontend):
      (WebCore::PageRuntimeAgent::clearFrontend):
      (WebCore::PageRuntimeAgent::enable):
      (WebCore::PageRuntimeAgent::didClearWindowObject):
      * inspector/PageRuntimeAgent.h:
      (PageRuntimeAgent):
      * inspector/WorkerRuntimeAgent.cpp:
      (WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
      (WebCore::WorkerRuntimeAgent::~WorkerRuntimeAgent):
      * inspector/WorkerRuntimeAgent.h:
      (WorkerRuntimeAgent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      841edfd0
    • pfeldman@chromium.org's avatar
      Web Inspector: frame chooser does not work on subsequent inspector open. · 9c6b8e8d
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100771
      
      Reviewed by Yury Semikhatsky.
      
      - Make WorkerRuntimeAgent and PageRuntimeAgent register themselves in the instrumenting agents independently
      - Move pause / run worker handling from InspectorRuntimeAgent into WorkerRuntimeAgent
      - Remove remains of the front-end reused signal from InspectorAgent
      - Send execution contexts post clear window object instead of post commit load.
      
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::InspectorAgent):
      (WebCore::InspectorAgent::clearFrontend):
      (WebCore::InspectorAgent::didCommitLoad):
      * inspector/InspectorAgent.h:
      (InspectorAgent):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
      (WebCore::InspectorInstrumentation::willEvaluateWorkerScript):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::restore):
      * inspector/InspectorRuntimeAgent.cpp:
      (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
      (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
      (WebCore::InspectorRuntimeAgent::run):
      (WebCore::InspectorRuntimeAgent::setScriptDebugServer):
      * inspector/InspectorRuntimeAgent.h:
      (InspectorRuntimeAgent):
      * inspector/InstrumentingAgents.h:
      (WebCore):
      (WebCore::InstrumentingAgents::InstrumentingAgents):
      (WebCore::InstrumentingAgents::workerRuntimeAgent):
      (WebCore::InstrumentingAgents::setWorkerRuntimeAgent):
      (InstrumentingAgents):
      * inspector/PageRuntimeAgent.cpp:
      (WebCore::PageRuntimeAgent::PageRuntimeAgent):
      (WebCore::PageRuntimeAgent::~PageRuntimeAgent):
      (WebCore::PageRuntimeAgent::setFrontend):
      (WebCore::PageRuntimeAgent::clearFrontend):
      (WebCore::PageRuntimeAgent::enable):
      (WebCore::PageRuntimeAgent::didCreateMainWorldContext):
      * inspector/PageRuntimeAgent.h:
      (PageRuntimeAgent):
      * inspector/WorkerRuntimeAgent.cpp:
      (WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
      (WebCore::WorkerRuntimeAgent::~WorkerRuntimeAgent):
      (WebCore::WorkerRuntimeAgent::run):
      (WebCore):
      (WebCore::WorkerRuntimeAgent::pauseWorkerContext):
      * inspector/WorkerRuntimeAgent.h:
      (WorkerRuntimeAgent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c6b8e8d
  10. 06 Sep, 2012 1 commit
    • weinig@apple.com's avatar
      Part 2 of removing PlatformString.h, remove PlatformString.h · 3f5ab024
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95931
      
      Reviewed by Adam Barth.
      
      Remove PlatformString.h
      
      Source/WebCore:
      
      * GNUmakefile.list.am:
      * Modules/filesystem/AsyncFileWriter.h:
      * Modules/filesystem/DOMFilePath.h:
      * Modules/filesystem/DOMFileSystemBase.h:
      * Modules/filesystem/DirectoryEntry.h:
      * Modules/filesystem/DirectoryEntrySync.h:
      * Modules/filesystem/DirectoryReader.h:
      * Modules/filesystem/DirectoryReaderBase.h:
      * Modules/filesystem/DirectoryReaderSync.h:
      * Modules/filesystem/EntryBase.cpp:
      * Modules/filesystem/EntrySync.h:
      * Modules/filesystem/FileEntrySync.h:
      * Modules/filesystem/FileSystemCallbacks.h:
      * Modules/filesystem/LocalFileSystem.h:
      * Modules/geolocation/GeolocationError.h:
      * Modules/geolocation/Geoposition.h:
      * Modules/geolocation/PositionError.h:
      * Modules/indexeddb/IDBAny.h:
      * Modules/indexeddb/IDBDatabaseBackendInterface.h:
      * Modules/indexeddb/IDBDatabaseCallbacks.h:
      * Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
      * Modules/indexeddb/IDBDatabaseError.h:
      * Modules/indexeddb/IDBFactory.h:
      * Modules/indexeddb/IDBFactoryBackendInterface.h:
      * Modules/indexeddb/IDBIndex.h:
      * Modules/indexeddb/IDBIndexBackendInterface.h:
      * Modules/indexeddb/IDBKey.h:
      * Modules/indexeddb/IDBKeyPath.h:
      * Modules/indexeddb/IDBMetadata.h:
      * Modules/indexeddb/IDBObjectStore.h:
      * Modules/indexeddb/IDBObjectStoreBackendInterface.h:
      * Modules/indexeddb/IDBTransactionBackendInterface.h:
      * Modules/indexeddb/IDBUpgradeNeededEvent.h:
      * Modules/indexeddb/IDBVersionChangeEvent.h:
      * Modules/mediastream/MediaStreamTrack.h:
      * Modules/networkinfo/NetworkInfoConnection.h:
      * Modules/notifications/DOMWindowNotifications.h:
      * Modules/speech/SpeechGrammar.h:
      * Modules/speech/SpeechRecognition.h:
      * Modules/speech/SpeechRecognitionAlternative.h:
      * Modules/speech/SpeechRecognitionClient.h:
      * Modules/speech/SpeechRecognitionError.h:
      * Modules/webaudio/AudioContext.cpp:
      * Modules/webaudio/AudioParam.h:
      * Modules/webdatabase/AbstractDatabase.h:
      * Modules/webdatabase/ChangeVersionWrapper.h:
      * Modules/webdatabase/DOMWindowWebDatabase.h:
      * Modules/webdatabase/Database.h:
      * Modules/webdatabase/DatabaseAuthorizer.cpp:
      * Modules/webdatabase/DatabaseAuthorizer.h:
      * Modules/webdatabase/DatabaseDetails.h:
      * Modules/webdatabase/DatabaseSync.h:
      * Modules/webdatabase/DatabaseTask.h:
      * Modules/webdatabase/DatabaseTracker.h:
      * Modules/webdatabase/OriginUsageRecord.h:
      * Modules/webdatabase/SQLError.h:
      * Modules/webdatabase/SQLStatement.h:
      * Modules/webdatabase/SQLStatementSync.h:
      * Modules/webdatabase/SQLTransaction.cpp:
      * Modules/webdatabase/SQLTransactionSync.cpp:
      * Modules/webdatabase/SQLTransactionSync.h:
      * Modules/webdatabase/WorkerContextWebDatabase.h:
      * Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:
      * Modules/webdatabase/chromium/QuotaTracker.h:
      * Modules/websockets/ThreadableWebSocketChannel.cpp:
      * Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
      * Modules/websockets/WebSocketHandshake.h:
      * Modules/websockets/WebSocketHandshakeResponse.h:
      * Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
      * Modules/websockets/WorkerThreadableWebSocketChannel.h:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/gobject/ConvertToUTF8String.cpp:
      * bindings/js/JSCSSStyleDeclarationCustom.cpp:
      * bindings/js/JSClipboardCustom.cpp:
      * bindings/js/JSImageDataCustom.cpp:
      * bindings/js/JSInspectorFrontendHostCustom.cpp:
      * bindings/js/JSLazyEventListener.h:
      * bindings/js/JSStorageCustom.cpp:
      * bindings/js/JSXSLTProcessorCustom.cpp:
      * bindings/js/JavaScriptCallFrame.cpp:
      * bindings/js/ScheduledAction.h:
      * bindings/js/ScriptDebugServer.h:
      * bindings/js/ScriptHeapSnapshot.h:
      * bindings/js/ScriptValue.h:
      * bindings/js/SerializedScriptValue.h:
      * bindings/objc/DOMCustomXPathNSResolver.mm:
      * bindings/objc/DOMXPath.mm:
      * bindings/objc/WebScriptObject.mm:
      * bindings/scripts/CodeGeneratorJS.pm:
      (AddIncludesForTypeInImpl):
      (AddIncludesForSVGAnimatedType):
      * bindings/scripts/CodeGeneratorV8.pm:
      (AddIncludesForType):
      * bindings/v8/Dictionary.h:
      * bindings/v8/JavaScriptCallFrame.h:
      * bindings/v8/NPV8Object.cpp:
      * bindings/v8/ScriptDebugServer.h:
      * bindings/v8/ScriptFunctionCall.h:
      * bindings/v8/ScriptHeapSnapshot.h:
      * bindings/v8/ScriptProfile.h:
      * bindings/v8/ScriptProfileNode.h:
      * bindings/v8/ScriptProfiler.h:
      * bindings/v8/ScriptSourceCode.h:
      * bindings/v8/V8Binding.cpp:
      * bindings/v8/V8DOMWrapper.h:
      * bindings/v8/V8LazyEventListener.h:
      * bindings/v8/V8NPUtils.cpp:
      * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
      * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
      * bindings/v8/custom/V8LocationCustom.cpp:
      * bridge/IdentifierRep.cpp:
      * bridge/NP_jsobject.cpp:
      * bridge/c/c_utility.cpp:
      * css/CSSBasicShapes.h:
      * css/CSSBorderImageSliceValue.cpp:
      * css/CSSCharsetRule.h:
      * css/CSSCursorImageValue.cpp:
      * css/CSSFontFaceSrcValue.h:
      * css/CSSGradientValue.cpp:
      * css/CSSInheritedValue.cpp:
      * css/CSSInitialValue.cpp:
      * css/CSSLineBoxContainValue.cpp:
      * css/CSSMediaRule.h:
      * css/CSSProperty.cpp:
      * css/CSSPropertySourceData.cpp:
      * css/CSSPropertySourceData.h:
      * css/CSSReflectValue.cpp:
      * css/CSSTimingFunctionValue.cpp:
      * css/CSSUnicodeRangeValue.cpp:
      * css/CSSValueList.cpp:
      * css/Counter.h:
      * css/FontFeatureValue.h:
      * css/FontValue.cpp:
      * css/MediaQuery.h:
      * css/MediaQueryEvaluator.h:
      * css/MediaQueryListListener.h:
      * css/ShadowValue.cpp:
      * css/StyleMedia.h:
      * css/StyleSheet.h:
      * css/StyleSheetList.cpp:
      * css/WebKitCSSMatrix.h:
      * css/WebKitCSSTransformValue.cpp:
      * dom/DOMStringList.h:
      * dom/DOMStringMap.h:
      * dom/DocumentMarker.h:
      * dom/ErrorEvent.h:
      * dom/ExceptionBase.h:
      * dom/MessagePortChannel.h:
      * dom/MutationRecord.h:
      * dom/TransformSource.h:
      * dom/ViewportArguments.cpp:
      * editing/DOMTransactionStep.h:
      * editing/EditingStyle.h:
      * editing/MarkupAccumulator.h:
      * editing/SmartReplaceICU.cpp:
      * editing/SpellChecker.h:
      * editing/SurroundingText.h:
      * fileapi/AsyncFileStream.cpp:
      * fileapi/Blob.h:
      * fileapi/BlobURL.cpp:
      * fileapi/File.h:
      * history/HistoryItem.h:
      * history/blackberry/HistoryItemViewState.h:
      * history/cf/HistoryPropertyList.h:
      * html/DOMFormData.cpp:
      * html/DOMURL.h:
      * html/MicroDataItemValue.h:
      * html/PublicURLManager.h:
      * html/canvas/CanvasPattern.cpp:
      * html/canvas/CanvasRenderingContext2D.h:
      * html/canvas/CanvasStyle.h:
      * html/canvas/WebGLActiveInfo.h:
      * html/canvas/WebGLGetInfo.h:
      * html/canvas/WebGLRenderingContext.h:
      * html/parser/CSSPreloadScanner.h:
      * html/parser/HTMLEntitySearch.h:
      * html/parser/HTMLEntityTable.h:
      * html/parser/HTMLMetaCharsetParser.cpp:
      * inspector/CodeGeneratorInspector.py:
      (InspectorFrontend_h):
      * inspector/ContentSearchUtils.h:
      * inspector/InjectedScript.cpp:
      * inspector/InjectedScriptBase.cpp:
      * inspector/InjectedScriptManager.h:
      * inspector/InjectedScriptModule.h:
      * inspector/InjectedScriptWebGLModule.h:
      * inspector/InspectorAgent.h:
      * inspector/InspectorCSSAgent.h:
      * inspector/InspectorController.h:
      * inspector/InspectorDOMDebuggerAgent.h:
      * inspector/InspectorDOMStorageAgent.h:
      * inspector/InspectorDatabaseAgent.h:
      * inspector/InspectorDatabaseResource.h:
      * inspector/InspectorFrontendClientLocal.cpp:
      * inspector/InspectorFrontendClientLocal.h:
      * inspector/InspectorFrontendHost.h:
      * inspector/InspectorIndexedDBAgent.h:
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorProfilerAgent.h:
      * inspector/InspectorResourceAgent.h:
      * inspector/InspectorState.h:
      * inspector/InspectorStyleSheet.h:
      * inspector/InspectorStyleTextEditor.h:
      * inspector/InspectorValues.h:
      * inspector/InspectorWebGLAgent.h:
      * inspector/InspectorWorkerResource.h:
      * inspector/ScriptArguments.h:
      * inspector/ScriptBreakpoint.h:
      * inspector/ScriptCallFrame.h:
      * inspector/ScriptDebugListener.h:
      * inspector/TimelineRecordFactory.h:
      * inspector/generate-inspector-protocol-version:
      (main):
      * loader/DocumentLoader.cpp:
      * loader/DocumentWriter.h:
      * loader/FTPDirectoryParser.h:
      * loader/FormState.h:
      * loader/HistoryController.h:
      * loader/PolicyChecker.h:
      * loader/ResourceLoadScheduler.h:
      * loader/SubframeLoader.h:
      * loader/SubstituteData.h:
      * loader/WorkerThreadableLoader.h:
      * loader/appcache/ApplicationCache.h:
      * loader/appcache/ApplicationCacheGroup.h:
      * loader/archive/ArchiveFactory.cpp:
      * loader/archive/ArchiveResourceCollection.h:
      * loader/cache/CachedResource.h:
      * loader/cache/MemoryCache.h:
      * loader/icon/IconRecord.h:
      * loader/icon/PageURLRecord.h:
      * loader/mac/LoaderNSURLExtras.mm:
      * loader/win/DocumentLoaderWin.cpp:
      * page/Console.cpp:
      * page/Coordinates.h:
      * page/DOMSelection.cpp:
      * page/EventSource.cpp:
      * page/GroupSettings.h:
      * page/NavigatorBase.cpp:
      * page/OriginAccessEntry.h:
      * page/Page.h:
      * page/SecurityOrigin.h:
      * page/SpeechInputResult.h:
      * page/UserContentURLPattern.h:
      * page/WindowFeatures.cpp:
      * page/WindowFeatures.h:
      * page/WorkerNavigator.h:
      * page/animation/AnimationControllerPrivate.h:
      * platform/AsyncFileSystem.h:
      * platform/AsyncFileSystemCallbacks.h:
      * platform/ContentType.h:
      * platform/ContextMenu.h:
      * platform/ContextMenuItem.h:
      * platform/Cookie.h:
      * platform/CrossThreadCopier.cpp:
      * platform/DateComponents.cpp:
      * platform/FileChooser.h:
      * platform/FileStream.cpp:
      * platform/FileSystem.h:
      * platform/KURL.cpp:
      (WebCore):
      * platform/KURL.h:
      * platform/KURLHash.h:
      * platform/KillRing.h:
      * platform/Language.cpp:
      * platform/Length.cpp:
      * platform/LinkHash.cpp:
      * platform/Logging.cpp:
      * platform/MIMETypeRegistry.h:
      * platform/SSLKeyGenerator.h:
      * platform/SchemeRegistry.h:
      * platform/SharedBuffer.h:
      * platform/Theme.h:
      * platform/UUID.h:
      * platform/animation/Animation.h:
      * platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
      * platform/blackberry/CookieManager.h:
      * platform/blackberry/CookieMap.h:
      * platform/blackberry/DragDataBlackBerry.cpp:
      * platform/blackberry/KURLBlackBerry.cpp:
      * platform/blackberry/LocalizedStringsBlackBerry.cpp:
      * platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:
      * platform/blackberry/TemporaryLinkStubs.cpp:
      * platform/cf/FileSystemCF.cpp:
      * platform/cf/SchedulePair.h:
      * platform/chromium/ChromiumDataObject.h:
      * platform/chromium/ClipboardUtilitiesChromium.cpp:
      * platform/chromium/DragDataChromium.cpp:
      * platform/chromium/FileSystemChromium.cpp:
      * platform/chromium/FileSystemChromiumMac.mm:
      * platform/chromium/LanguageChromium.cpp:
      * platform/chromium/SSLKeyGeneratorChromium.cpp:
      * platform/cocoa/KeyEventCocoa.mm:
      * platform/efl/ErrorsEfl.h:
      * platform/efl/LanguageEfl.cpp:
      * platform/efl/LocalizedStringsEfl.cpp:
      * platform/efl/LoggingEfl.cpp:
      * platform/efl/PasteboardEfl.cpp:
      * platform/efl/PlatformScreenEfl.cpp:
      * platform/graphics/ANGLEWebKitBridge.h:
      * platform/graphics/BitmapImage.cpp:
      * platform/graphics/FontPlatformData.cpp:
      * platform/graphics/GlyphPageTreeNode.cpp:
      * platform/graphics/GraphicsContext3D.h:
      * platform/graphics/GraphicsTypes.cpp:
      * platform/graphics/SegmentedFontData.cpp:
      * platform/graphics/blackberry/IconBlackBerry.cpp:
      * platform/graphics/blackberry/LayerData.h:
      * platform/graphics/blackberry/LayerFilterRenderer.cpp:
      * platform/graphics/blackberry/LayerRenderer.cpp:
      * platform/graphics/blackberry/skia/PlatformSupport.h:
      * platform/graphics/ca/PlatformCALayer.h:
      * platform/graphics/ca/PlatformCALayerClient.h:
      * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
      * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
      * platform/graphics/cairo/ImageBufferCairo.cpp:
      * platform/graphics/cairo/PathCairo.cpp:
      * platform/graphics/cg/ImageSourceCGMac.mm:
      * platform/graphics/cg/PathCG.cpp:
      * platform/graphics/chromium/FontUtilsChromiumWin.cpp:
      * platform/graphics/chromium/GraphicsLayerChromium.cpp:
      * platform/graphics/chromium/IconChromium.cpp:
      * platform/graphics/chromium/IconChromiumAndroid.cpp:
      * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
      * platform/graphics/efl/IconEfl.cpp:
      * platform/graphics/filters/FEComposite.h:
      * platform/graphics/filters/FEDisplacementMap.h:
      * platform/graphics/filters/SourceAlpha.cpp:
      * platform/graphics/filters/SourceAlpha.h:
      * platform/graphics/filters/SourceGraphic.cpp:
      * platform/graphics/filters/SourceGraphic.h:
      * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
      * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
      * platform/graphics/mac/IconMac.mm:
      * platform/graphics/mac/ImageMac.mm:
      * platform/graphics/opentype/OpenTypeUtilities.h:
      * platform/graphics/openvg/PathOpenVG.cpp:
      * platform/graphics/pango/FontPlatformDataPango.cpp:
      * platform/graphics/qt/FontCacheQt.cpp:
      * platform/graphics/qt/FontPlatformDataQt.cpp:
      * platform/graphics/qt/IconQt.cpp:
      * platform/graphics/qt/ImageQt.cpp:
      * platform/graphics/qt/PathQt.cpp:
      * platform/graphics/skia/FontCustomPlatformData.h:
      * platform/graphics/skia/ImageSkia.cpp:
      * platform/graphics/win/FontCustomPlatformData.h:
      * platform/graphics/win/FontPlatformDataCGWin.cpp:
      * platform/graphics/win/FontPlatformDataCairoWin.cpp:
      * platform/graphics/win/FontPlatformDataWin.cpp:
      * platform/graphics/win/IconWin.cpp:
      * platform/graphics/win/ImageCGWin.cpp:
      * platform/graphics/win/ImageCairoWin.cpp:
      * platform/graphics/win/SimpleFontDataCGWin.cpp:
      * platform/graphics/wince/FontCustomPlatformData.h:
      * platform/graphics/wince/FontPlatformData.cpp:
      * platform/graphics/wince/ImageWinCE.cpp:
      * platform/graphics/wince/MediaPlayerProxy.cpp:
      * platform/graphics/wince/PathWinCE.cpp:
      * platform/graphics/wince/PlatformPathWinCE.cpp:
      * platform/graphics/wx/FontCacheWx.cpp:
      * platform/graphics/wx/FontPlatformDataWx.cpp:
      * platform/graphics/wx/IconWx.cpp:
      * platform/graphics/wx/PathWx.cpp:
      * platform/gtk/ErrorsGtk.h:
      * platform/gtk/FileSystemGtk.cpp:
      * platform/gtk/GtkPopupMenu.h:
      * platform/gtk/KeyBindingTranslator.h:
      * platform/gtk/LanguageGtk.cpp:
      * platform/gtk/LocalizedStringsGtk.cpp:
      * platform/gtk/LoggingGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/image-decoders/ImageDecoder.h:
      * platform/leveldb/LevelDBSlice.h:
      * platform/mac/FileSystemMac.mm:
      * platform/mediastream/MediaStreamSource.h:
      * platform/mock/GeolocationClientMock.h:
      * platform/network/BlobData.h:
      * platform/network/BlobRegistryImpl.h:
      * platform/network/BlobResourceHandle.h:
      * platform/network/Credential.h:
      * platform/network/FormData.h:
      * platform/network/FormDataBuilder.h:
      * platform/network/HTTPParsers.cpp:
      * platform/network/HTTPRequest.h:
      * platform/network/HTTPValidation.cpp:
      * platform/network/ProtectionSpace.h:
      * platform/network/ResourceErrorBase.h:
      * platform/network/SocketStreamErrorBase.h:
      * platform/network/blackberry/DNSBlackBerry.cpp:
      * platform/network/blackberry/DeferredData.h:
      * platform/network/blackberry/NetworkJob.h:
      * platform/network/cf/CookieJarCFNet.cpp:
      * platform/network/curl/CookieJarCurl.cpp:
      * platform/network/curl/ResourceHandleManager.h:
      * platform/network/qt/DnsPrefetchHelper.cpp:
      * platform/network/soup/ResourceRequestSoup.cpp:
      * platform/network/soup/ResourceResponseSoup.cpp:
      * platform/network/win/CookieJarWin.cpp:
      * platform/posix/FileSystemPOSIX.cpp:
      * platform/qt/ClipboardQt.cpp:
      * platform/qt/CookieJarQt.cpp:
      * platform/qt/FileSystemQt.cpp:
      * platform/qt/LanguageQt.cpp:
      * platform/qt/LocalizedStringsQt.cpp:
      * platform/qt/LoggingQt.cpp:
      * platform/qt/PlatformSupport.h:
      * platform/sql/SQLValue.h:
      * platform/sql/SQLiteDatabase.h:
      * platform/sql/SQLiteFileSystem.h:
      * platform/text/DecodeEscapeSequences.h:
      * platform/text/LineEnding.cpp:
      * platform/text/ParserUtilities.h:
      * platform/text/PlatformString.h: Removed.
      * platform/text/RegularExpression.h:
      * platform/text/SegmentedString.h:
      * platform/text/StringWithDirection.h:
      * platform/text/SuffixTree.h:
      * platform/text/TextBreakIteratorICU.cpp:
      * platform/text/TextCodec.cpp:
      * platform/text/TextCodec.h:
      * platform/text/TextCodecLatin1.cpp:
      * platform/text/TextCodecUTF16.cpp:
      * platform/text/TextCodecUserDefined.cpp:
      * platform/text/TextEncoding.cpp:
      * platform/text/blackberry/StringBlackBerry.cpp:
      * platform/text/cf/StringCF.cpp:
      * platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp:
      * platform/text/gtk/TextCodecGtk.cpp:
      * platform/text/mac/StringMac.mm:
      * platform/text/mac/TextCodecMac.cpp:
      * platform/text/qt/TextCodecQt.cpp:
      * platform/text/win/TextCodecWin.h:
      * platform/text/wince/TextBreakIteratorWinCE.cpp:
      * platform/win/BString.cpp:
      * platform/win/DragDataWin.cpp:
      * platform/win/GDIObjectCounter.h:
      * platform/win/LoggingWin.cpp:
      * platform/win/WCDataObject.cpp:
      * platform/wince/DragDataWinCE.cpp:
      * platform/wx/ClipboardWx.cpp:
      * platform/wx/FileSystemWx.cpp:
      * platform/wx/LanguageWx.cpp:
      * platform/wx/LocalizedStringsWx.cpp:
      * platform/wx/LoggingWx.cpp:
      * platform/wx/PasteboardWx.cpp:
      * platform/wx/PopupMenuWx.cpp:
      * plugins/PluginData.h:
      * plugins/PluginDatabase.h:
      * plugins/PluginDebug.cpp:
      * plugins/PluginPackage.h:
      * plugins/PluginStream.h:
      * rendering/style/StyleDashboardRegion.h:
      * storage/Storage.cpp:
      * storage/StorageArea.h:
      * storage/StorageEvent.h:
      * storage/StorageEventDispatcher.h:
      * storage/StorageMap.h:
      * storage/StorageNamespace.h:
      * storage/StorageNamespaceImpl.h:
      * storage/StorageSyncManager.h:
      * storage/StorageTask.h:
      * storage/StorageTracker.h:
      * svg/SVGPathByteStreamBuilder.h:
      * svg/SVGPathParser.h:
      * svg/SVGPathStringSource.h:
      * svg/SVGStyledElement.cpp:
      * svg/animation/SMILTimeContainer.h:
      * svg/graphics/filters/SVGFilterBuilder.cpp:
      * svg/graphics/filters/SVGFilterBuilder.h:
      * testing/Internals.h:
      * workers/DefaultSharedWorkerRepository.cpp:
      * workers/WorkerLocation.cpp:
      * workers/WorkerThread.cpp:
      * xml/DOMParser.cpp:
      * xml/NativeXPathNSResolver.cpp:
      * xml/XMLSerializer.cpp:
      * xml/XMLSerializer.h:
      * xml/XPathExpression.cpp:
      * xml/XPathValue.h:
      * xml/XSLTUnicodeSort.cpp:
      
      Source/WebKit/blackberry:
      
      * Api/DumpRenderTreeClient.h:
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      * WebCoreSupport/InspectorClientBlackBerry.h:
      * WebCoreSupport/JavaScriptDebuggerBlackBerry.cpp:
      * WebKitSupport/AboutData.h:
      
      Source/WebKit/cf:
      
      * WebCoreSupport/WebInspectorClientCF.cpp:
      (WebInspectorClient::createFrontendSettings):
      
      Source/WebKit/chromium:
      
      * src/ContextMenuClientImpl.cpp:
      * src/EditorClientImpl.cpp:
      * src/InspectorFrontendClientImpl.cpp:
      * src/LocalFileSystemChromium.cpp:
      * src/SpeechInputClientImpl.cpp:
      * src/SpeechRecognitionClientProxy.h:
      * src/WebDevToolsAgentImpl.cpp:
      * src/WebDevToolsFrontendImpl.cpp:
      * src/WebDevToolsFrontendImpl.h:
      * src/WebEntities.h:
      * src/WebFrameImpl.h:
      * src/WorkerFileSystemCallbacksBridge.h:
      * tests/UniscribeHelperTest.cpp:
      
      Source/WebKit/efl:
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      * WebCoreSupport/InspectorClientEfl.cpp:
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      * WebCoreSupport/InspectorClientGtk.cpp:
      * gdom/ConvertToGCharPrivate.h:
      * webkit/webkitsecurityorigin.cpp:
      * webkit/webkitwebdatasource.cpp:
      * webkit/webkitwebhistoryitem.cpp:
      * webkit/webkitwebresource.cpp:
      
      Source/WebKit/mac:
      
      * History/WebHistoryItem.mm:
      * Misc/WebStringTruncator.mm:
      * Plugins/Hosted/NetscapePluginHostManager.h:
      (NetscapePluginHostManager):
      * Plugins/WebPluginController.mm:
      * Storage/WebStorageTrackerClient.mm:
      * WebCoreSupport/WebChromeClient.mm:
      * WebCoreSupport/WebEditorClient.mm:
      * WebCoreSupport/WebFrameLoaderClient.mm:
      * WebCoreSupport/WebIconDatabaseClient.mm:
      * WebCoreSupport/WebInspectorClient.h:
      (WebInspectorClient):
      (WebInspectorFrontendClient):
      * WebView/WebRenderLayer.mm:
      * WebView/WebViewData.h:
      
      Source/WebKit/qt:
      
      * Api/qwebdatabase_p.h:
      * Api/qwebframe_p.h:
      * Api/qwebhistory.cpp:
      * Api/qwebhistoryinterface.cpp:
      * Api/qwebpage_p.h:
      * Api/qwebsettings.cpp:
      * WebCoreSupport/ChromeClientQt.h:
      * WebCoreSupport/InspectorClientQt.cpp:
      
      Source/WebKit/win:
      
      * DOMCSSClasses.cpp:
      * DefaultPolicyDelegate.cpp:
      * MarshallingHelpers.cpp:
      * WebCoreSupport/WebInspectorClient.h:
      * WebDownload.h:
      * WebFrame.h:
      * WebHistoryItem.h:
      * WebIconDatabase.cpp:
      * WebKitDLL.h:
      * WebKitGraphics.cpp:
      * WebKitSystemBits.cpp:
      * WebLocalizableStrings.cpp:
      * WebNotificationCenter.cpp:
      * WebResource.h:
      
      Source/WebKit/wx:
      
      * WebFrame.cpp:
      * WebKitSupport/ChromeClientWx.cpp:
      * WebKitSupport/EditorClientWx.cpp:
      * WebKitSupport/FrameLoaderClientWx.cpp:
      * WebKitSupport/InspectorClientWx.cpp:
      * WebSettings.cpp:
      * WebView.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f5ab024
  11. 20 Jul, 2012 1 commit
    • pfeldman@chromium.org's avatar
      Web Inspector: disable fake workers inspection. · ef96b24f
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=91867
      
      Reviewed by Vsevolod Vlasov.
      
      'Fake workers' is unreliable error-prone way to debug workers. There are a
      lot of frameworks supporting it. Inspector should not do that since it has a more
      powerful native worker inspection capabilities. Port owners should enable it
      in case they want to provide workers debugging.
      
      * English.lproj/localizedStrings.js:
      * WebCore.gypi:
      * WebCore.order:
      * WebCore.vcproj/WebCore.vcproj:
      * inspector/InjectedScriptHost.cpp:
      (WebCore::InjectedScriptHost::InjectedScriptHost):
      * inspector/InjectedScriptHost.h:
      (InjectedScriptHost):
      * inspector/InjectedScriptHost.idl:
      * inspector/Inspector.json:
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::didCommitLoad):
      (WebCore::InspectorAgent::enable):
      * inspector/InspectorAgent.h:
      (WebCore):
      (InspectorAgent):
      * inspector/InspectorInstrumentation.cpp:
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      * inspector/front-end/InjectedFakeWorker.js: Removed.
      * inspector/front-end/ScriptsPanel.js:
      * inspector/front-end/WebKit.qrc:
      * inspector/front-end/WorkersSidebarPane.js:
      (WebInspector.WorkersSidebarPane):
      * inspector/front-end/externs.js:
      * inspector/front-end/inspector.html:
      * inspector/front-end/inspector.js:
      * workers/AbstractWorker.cpp:
      (WebCore::AbstractWorker::contextDestroyed):
      * workers/AbstractWorker.h:
      (AbstractWorker):
      * workers/SharedWorker.cpp:
      (WebCore::SharedWorker::create):
      * workers/Worker.cpp:
      (WebCore::Worker::create):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef96b24f
  12. 11 May, 2012 1 commit
    • yurys@chromium.org's avatar
      Web Inspector: get rid of InspectorAgent::emitCommitLoadIfNeeded method · 7711b50b
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85708
      
      Reviewed by Pavel Feldman.
      
      Instead of calling emitCommitLoadIfNeeded after all agents are restored
      required actions are performed directly in the restore() methods.
      
      * inspector/InspectorAgent.cpp:
      * inspector/InspectorAgent.h:
      (WebCore::InspectorAgent::didCommitLoadFired):
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      (WebCore::InspectorController::restoreInspectorStateFromCookie):
      * inspector/InspectorDatabaseAgent.cpp:
      (WebCore::InspectorDatabaseAgent::restore):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::create):
      (WebCore::InspectorPageAgent::InspectorPageAgent):
      (WebCore::InspectorPageAgent::restore):
      * inspector/InspectorPageAgent.h:
      (WebCore):
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::restore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7711b50b
  13. 04 Apr, 2012 1 commit
    • yurys@chromium.org's avatar
      Web Inspector: CodeGeneratorInspector.py: switch Inspector, Memory and... · b2a04bc7
      yurys@chromium.org authored
      Web Inspector: CodeGeneratorInspector.py: switch Inspector, Memory and Database domains to typed API
      https://bugs.webkit.org/show_bug.cgi?id=82958
      
      Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-02
      Reviewed by Yury Semikhatsky.
      
      Client code is switched to typed API (all InspectorObject and InspectorArray types are replaced with
      generated types from TypeBuilder according to Inspector.json).
      
      Missing array of InspectorValues specialization is added.
      
      * inspector/CodeGeneratorInspector.py:
      * inspector/InjectedScriptHost.cpp:
      (WebCore::InjectedScriptHost::inspectImpl):
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::inspect):
      * inspector/InspectorAgent.h:
      (InspectorAgent):
      * inspector/InspectorDatabaseAgent.cpp:
      (WebCore):
      (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
      * inspector/InspectorDatabaseAgent.h:
      (InspectorDatabaseAgent):
      * inspector/InspectorDatabaseResource.cpp:
      (WebCore::InspectorDatabaseResource::bind):
      * inspector/InspectorMemoryAgent.cpp:
      (WebCore::InspectorMemoryAgent::getDOMNodeCount):
      * inspector/InspectorMemoryAgent.h:
      (InspectorMemoryAgent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2a04bc7
  14. 27 Feb, 2012 1 commit
  15. 06 Feb, 2012 1 commit
    • yurys@chromium.org's avatar
      Web Inspector: CodeGeneratorInspector.py: switch domain agents to formal... · c22f745a
      yurys@chromium.org authored
      Web Inspector: CodeGeneratorInspector.py: switch domain agents to formal interfaces in BackendDispatcher
      https://bugs.webkit.org/show_bug.cgi?id=77444
      
      Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-05
      Reviewed by Yury Semikhatsky.
      
      All agent code is switched to formal interfaces. Actual agent class
      names and includes are dropped from InspectorBackendDispatcher.h.
      
      * inspector/CodeGeneratorInspector.py:
      (DomainNameFixes.get_fixed_data):
      (Generator.go):
      * inspector/InspectorAgent.h:
      * inspector/InspectorApplicationCacheAgent.h:
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::getMatchedStylesForNode):
      * inspector/InspectorCSSAgent.h:
      (InspectorCSSAgent):
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::highlightNode):
      * inspector/InspectorDOMAgent.h:
      (InspectorDOMAgent):
      * inspector/InspectorDOMDebuggerAgent.h:
      * inspector/InspectorDOMStorageAgent.h:
      * inspector/InspectorDatabaseAgent.h:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::setBreakpoint):
      (WebCore::InspectorDebuggerAgent::continueToLocation):
      * inspector/InspectorDebuggerAgent.h:
      (InspectorDebuggerAgent):
      * inspector/InspectorFileSystemAgent.h:
      * inspector/InspectorIndexedDBAgent.h:
      * inspector/InspectorMemoryAgent.h:
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::InspectorProfilerAgent::getProfile):
      (WebCore::InspectorProfilerAgent::removeProfile):
      * inspector/InspectorProfilerAgent.h:
      (InspectorProfilerAgent):
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::setExtraHTTPHeaders):
      * inspector/InspectorResourceAgent.h:
      (InspectorResourceAgent):
      * inspector/InspectorRuntimeAgent.h:
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::start):
      * inspector/InspectorTimelineAgent.h:
      (InspectorTimelineAgent):
      * inspector/InspectorWorkerAgent.cpp:
      (WebCore::InspectorWorkerAgent::sendMessageToWorker):
      * inspector/InspectorWorkerAgent.h:
      (InspectorWorkerAgent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c22f745a
  16. 20 Dec, 2011 1 commit
    • caseq@chromium.org's avatar
      Web Inspector: [Extensions API] allow setting extension API per extension security origin · a5f1c310
      caseq@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74868
      
      Reviewed by Pavel Feldman.
      
      This replaces InspectorExtensionAPI string within InspectorFrontendHost with a map by extension
      security origin, so that we can have APIs customized by extension (in particular, this is needed
      to expose experimental APIs only to certain extensions).
      
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::didClearWindowObjectInWorld):
      (WebCore::InspectorAgent::setInjectedScriptForOrigin):
      * inspector/InspectorAgent.h:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::setInjectedScriptForOrigin):
      * inspector/InspectorController.h:
      * inspector/InspectorFrontendHost.cpp:
      (WebCore::InspectorFrontendHost::setInjectedScriptForOrigin):
      * inspector/InspectorFrontendHost.h:
      * inspector/InspectorFrontendHost.idl:
      * inspector/front-end/ExtensionServer.js:
      (WebInspector.ExtensionServer.prototype._addExtensions):
      (WebInspector.ExtensionServer.prototype._addExtension):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5f1c310
  17. 30 Nov, 2011 3 commits
    • vsevik@chromium.org's avatar
      Web Inspector: Inspect element does not highlight element in elements panel... · cce0f4b3
      vsevik@chromium.org authored
      Web Inspector: Inspect element does not highlight element in elements panel when inspector is opened.
      https://bugs.webkit.org/show_bug.cgi?id=73459
      
      Reviewed by Pavel Feldman.
      
      This regressed in r101503.
      
      * inspector/InjectedScriptHost.cpp:
      (WebCore::InjectedScriptHost::InjectedScriptHost):
      (WebCore::InjectedScriptHost::disconnect):
      (WebCore::InjectedScriptHost::inspectImpl):
      * inspector/InjectedScriptHost.h:
      (WebCore::InjectedScriptHost::init):
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::enable):
      (WebCore::InspectorAgent::inspect):
      * inspector/InspectorAgent.h:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::connectFrontend):
      (WebCore::InspectorController::disconnectFrontend):
      * inspector/WorkerInspectorController.cpp:
      (WebCore::WorkerInspectorController::connectFrontend):
      (WebCore::WorkerInspectorController::disconnectFrontend):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cce0f4b3
    • pfeldman@chromium.org's avatar
      Web Inspector: get rid of deferred backend->front-end commands processing. · 0ee2cf0b
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=73439
      
      Source/WebCore:
      
      We should issue tests upon InspectorAgent::enable and should not do any deferred command processing.
      
      Reviewed by Yury Semikhatsky.
      
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::InspectorAgent):
      (WebCore::InspectorAgent::setFrontend):
      (WebCore::InspectorAgent::clearFrontend):
      (WebCore::InspectorAgent::enable):
      (WebCore::InspectorAgent::evaluateForTestInFrontend):
      * inspector/InspectorAgent.h:
      * inspector/front-end/inspector.js:
      
      Source/WebKit/chromium:
      
      Reviewed by Yury Semikhatsky.
      
      * src/WebDevToolsFrontendImpl.cpp:
      (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
      (WebKit::WebDevToolsFrontendImpl::frontendLoaded):
      (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
      * src/WebDevToolsFrontendImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ee2cf0b
    • pfeldman@chromium.org's avatar
      Web Inspector: do not report worker-related events unless inspector agent is enabled. · 01859c2d
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=73411
      
      Source/WebCore:
      
      Backend should not generate messages until the client requests that they are sent.
      
      Reviewed by Yury Semikhatsky.
      
      * inspector/Inspector.json:
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::setFrontend):
      (WebCore::InspectorAgent::clearFrontend):
      (WebCore::InspectorAgent::enable):
      (WebCore::InspectorAgent::disable):
      (WebCore::InspectorAgent::postWorkerNotificationToFrontend):
      (WebCore::InspectorAgent::didCreateWorker):
      (WebCore::InspectorAgent::didDestroyWorker):
      (WebCore::InspectorAgent::developerExtrasEnabled):
      * inspector/InspectorAgent.h:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::enabled):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
      (WebCore::InspectorInstrumentation::didCommitLoadImpl):
      (WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
      (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
      (WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
      * inspector/InspectorPageAgent.cpp:
      * inspector/PageConsoleAgent.cpp:
      (WebCore::PageConsoleAgent::developerExtrasEnabled):
      * inspector/front-end/WorkerManager.js:
      (WebInspector.WorkerManager.prototype._workerInspectorClosing):
      (WebInspector.WorkerManager.prototype._disconnectedFromWorker):
      (WebInspector.DedicatedWorkerMessageForwarder.prototype.dispatchMessageFromWorker):
      (WebInspector.DedicatedWorkerMessageForwarder.prototype.disconnectedFromWorker):
      * inspector/front-end/inspector.js:
      
      Source/WebKit/chromium:
      
      Reviewed by Yury Semikhatsky.
      
      * src/WebDevToolsAgentImpl.cpp:
      (WebKit::WebDevToolsAgent::disconnectEventAsText):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01859c2d
  18. 29 Nov, 2011 1 commit
    • pfeldman@chromium.org's avatar
      Web Inspector: put inspector agents into a vector in the InspectorController. · fb83df24
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=73225
      
      Inspector controller should maintain agents in the vector, while accessing
      them using the same base agent interface. We should not manually call
      base agent methods on their concrete instances.
      
      Reviewed by Yury Semikhatsky.
      
      * inspector/CodeGeneratorInspector.py:
      (DomainNameFixes.get_fixed_data.Res):
      (DomainNameFixes):
      (Generator.go):
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::InspectorAgent):
      (WebCore::PostWorkerNotificationToFrontendTask::performTask):
      * inspector/InspectorAgent.h:
      (WebCore::InspectorAgent::create):
      * inspector/InspectorApplicationCacheAgent.cpp:
      (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
      * inspector/InspectorApplicationCacheAgent.h:
      (WebCore::InspectorApplicationCacheAgent::create):
      * inspector/InspectorBaseAgent.cpp:
      * inspector/InspectorBaseAgent.h:
      (WebCore::InspectorBaseAgentInterface::InspectorBaseAgentInterface):
      (WebCore::InspectorBaseAgentInterface::~InspectorBaseAgentInterface):
      (WebCore::InspectorBaseAgentInterface::setFrontend):
      (WebCore::InspectorBaseAgentInterface::clearFrontend):
      (WebCore::InspectorBaseAgentInterface::restore):
      (WebCore::InspectorBaseAgentInterface::inspectedPageDestroyed):
      (WebCore::InspectorBaseAgent::~InspectorBaseAgent):
      (WebCore::InspectorBaseAgent::registerDispatcher):
      (WebCore::InspectorBaseAgent::InspectorBaseAgent):
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::InspectorCSSAgent):
      * inspector/InspectorCSSAgent.h:
      (WebCore::InspectorCSSAgent::create):
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      (WebCore::InspectorController::inspectedPageDestroyed):
      (WebCore::InspectorController::connectFrontend):
      (WebCore::InspectorController::disconnectFrontend):
      (WebCore::InspectorController::restoreInspectorStateFromCookie):
      * inspector/InspectorController.h:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::InspectorDOMAgent):
      * inspector/InspectorDOMAgent.h:
      * inspector/InspectorDOMDebuggerAgent.cpp:
      (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
      * inspector/InspectorDOMDebuggerAgent.h:
      (WebCore::InspectorDOMDebuggerAgent::inspectedPageDestroyed):
      * inspector/InspectorDOMStorageAgent.cpp:
      (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
      * inspector/InspectorDOMStorageAgent.h:
      * inspector/InspectorDatabaseAgent.cpp:
      (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
      * inspector/InspectorDatabaseAgent.h:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
      * inspector/InspectorDebuggerAgent.h:
      (WebCore::InspectorDebuggerAgent::inspectedPageDestroyed):
      * inspector/InspectorFileSystemAgent.cpp:
      (WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
      * inspector/InspectorFileSystemAgent.h:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::InspectorPageAgent):
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
      * inspector/InspectorProfilerAgent.h:
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::InspectorResourceAgent):
      * inspector/InspectorResourceAgent.h:
      (WebCore::InspectorResourceAgent::create):
      * inspector/InspectorRuntimeAgent.cpp:
      (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
      * inspector/InspectorRuntimeAgent.h:
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
      * inspector/InspectorTimelineAgent.h:
      * inspector/InspectorWorkerAgent.cpp:
      (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
      * inspector/InspectorWorkerAgent.h:
      * inspector/PageConsoleAgent.h:
      (WebCore::PageConsoleAgent::create):
      * inspector/PageRuntimeAgent.h:
      (WebCore::PageRuntimeAgent::create):
      * inspector/WorkerConsoleAgent.h:
      (WebCore::WorkerConsoleAgent::create):
      * inspector/WorkerInspectorController.cpp:
      (WebCore::WorkerInspectorController::WorkerInspectorController):
      (WebCore::WorkerInspectorController::connectFrontend):
      * inspector/WorkerRuntimeAgent.h:
      (WebCore::WorkerRuntimeAgent::create):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb83df24
  19. 28 Nov, 2011 1 commit
    • pfeldman@chromium.org's avatar
      Web Inspector: introduce InspectorBaseAgent. · ccc8cd93
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=73203
      
      Now that inspector controller does not depend on concrete inspector agent
      classes, we can collect agent instances using abstract type.
      
      Reviewed by Yury Semikhatsky.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::InspectorAgent):
      * inspector/InspectorAgent.h:
      * inspector/InspectorApplicationCacheAgent.cpp:
      (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
      * inspector/InspectorApplicationCacheAgent.h:
      * inspector/InspectorBaseAgent.cpp: Copied from Source/WebCore/inspector/InspectorFileSystemAgent.h.
      (WebCore::InspectorBaseAgent::InspectorBaseAgent):
      (WebCore::InspectorBaseAgent::~InspectorBaseAgent):
      * inspector/InspectorBaseAgent.h: Copied from Source/WebCore/inspector/InspectorFileSystemAgent.h.
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::InspectorCSSAgent):
      * inspector/InspectorCSSAgent.h:
      (WebCore::InspectorCSSAgent::setFrontend):
      (WebCore::InspectorCSSAgent::restore):
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
      (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
      (WebCore::InspectorConsoleAgent::enable):
      (WebCore::InspectorConsoleAgent::disable):
      (WebCore::InspectorConsoleAgent::clearMessages):
      (WebCore::InspectorConsoleAgent::restore):
      (WebCore::InspectorConsoleAgent::clearFrontend):
      (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
      (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
      (WebCore::InspectorConsoleAgent::addConsoleMessage):
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::InspectorDOMAgent):
      (WebCore::InspectorDOMAgent::clearFrontend):
      (WebCore::InspectorDOMAgent::setDocument):
      (WebCore::InspectorDOMAgent::getDocument):
      (WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
      * inspector/InspectorDOMAgent.h:
      * inspector/InspectorDOMStorageAgent.cpp:
      (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
      (WebCore::InspectorDOMStorageAgent::restore):
      (WebCore::InspectorDOMStorageAgent::enable):
      (WebCore::InspectorDOMStorageAgent::disable):
      * inspector/InspectorDOMStorageAgent.h:
      * inspector/InspectorDatabaseAgent.cpp:
      (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
      (WebCore::InspectorDatabaseAgent::enable):
      (WebCore::InspectorDatabaseAgent::disable):
      (WebCore::InspectorDatabaseAgent::restore):
      * inspector/InspectorDatabaseAgent.h:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
      (WebCore::InspectorDebuggerAgent::disable):
      (WebCore::InspectorDebuggerAgent::enabled):
      (WebCore::InspectorDebuggerAgent::enable):
      (WebCore::InspectorDebuggerAgent::clearFrontend):
      (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
      (WebCore::InspectorDebuggerAgent::removeBreakpoint):
      (WebCore::InspectorDebuggerAgent::didParseSource):
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorFileSystemAgent.cpp:
      (WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
      * inspector/InspectorFileSystemAgent.h:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::InspectorPageAgent):
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
      (WebCore::InspectorProfilerAgent::enable):
      (WebCore::InspectorProfilerAgent::disable):
      (WebCore::InspectorProfilerAgent::restore):
      (WebCore::InspectorProfilerAgent::restoreEnablement):
      (WebCore::InspectorProfilerAgent::start):
      (WebCore::InspectorProfilerAgent::stop):
      * inspector/InspectorProfilerAgent.h:
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::InspectorResourceAgent):
      * inspector/InspectorResourceAgent.h:
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
      * inspector/InspectorTimelineAgent.h:
      * inspector/InspectorWorkerAgent.cpp:
      (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
      (WebCore::InspectorWorkerAgent::restore):
      (WebCore::InspectorWorkerAgent::clearFrontend):
      (WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
      (WebCore::InspectorWorkerAgent::setAutoconnectToWorkers):
      (WebCore::InspectorWorkerAgent::shouldPauseDedicatedWorkerOnStart):
      (WebCore::InspectorWorkerAgent::didStartWorkerContext):
      (WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):
      * inspector/InspectorWorkerAgent.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccc8cd93
  20. 22 Nov, 2011 1 commit
    • pfeldman@chromium.org's avatar
      Web Inspector: strip unused InspectorController methods. · 6a1f9523
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72886
      
      Source/WebCore:
      
      This is a follow up to the https://bugs.webkit.org/show_bug.cgi?id=63009.
      I am now able to remove following InspectorController methods:
      ::startUserInitiatedProfiling,
      ::isRecordingUserInitiatedProfile,
      ::stopUserInitiatedProfiling,
      ::showAndEnableDebugger,
      ::debuggerEnabled,
      ::disableDebugger,
      ::startTimelineProfiler,
      ::stopTimelineProfiler,
      ::timelineProfilerEnabled,
      ::showConsole.
      
      Reviewed by Yury Semikhatsky.
      
      * WebCore.exp.in:
      * WebCore.order:
      * inspector/Inspector.json:
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::setFrontend):
      * inspector/InspectorAgent.h:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      (WebCore::InspectorController::connectFrontend):
      * inspector/InspectorController.h:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::enable):
      (WebCore::InspectorDebuggerAgent::disable):
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::didCommitLoadImpl):
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::InspectorProfilerAgent::resetState):
      (WebCore::InspectorProfilerAgent::clearFrontend):
      (WebCore::InspectorProfilerAgent::restore):
      (WebCore::InspectorProfilerAgent::start):
      (WebCore::InspectorProfilerAgent::stop):
      * inspector/InspectorProfilerAgent.h:
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::start):
      (WebCore::InspectorTimelineAgent::stop):
      * inspector/InspectorTimelineAgent.h:
      * inspector/front-end/DebuggerModel.js:
      (WebInspector.DebuggerModel.prototype.enableDebugger):
      (WebInspector.DebuggerModel.prototype.disableDebugger):
      * inspector/front-end/TimelineManager.js:
      (WebInspector.TimelineManager.prototype.start):
      (WebInspector.TimelineManager.prototype.stop):
      (WebInspector.TimelineManager.prototype._started):
      (WebInspector.TimelineManager.prototype._stopped):
      * inspector/front-end/inspector.js:
      
      Source/WebKit/gtk:
      
      Reviewed by Yury Semikhatsky.
      
      * webkit/webkitwebinspector.cpp:
      (webkit_web_inspector_set_property):
      (webkit_web_inspector_get_property):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a1f9523
  21. 12 Aug, 2011 1 commit
  22. 08 Jul, 2011 1 commit
  23. 30 May, 2011 1 commit
    • caseq@chromium.org's avatar
      011-05-30 Andrey Kosyakov <caseq@chromium.org> · ac4fa7a2
      caseq@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: do not issue frontendReused for reload or navigation.
              https://bugs.webkit.org/show_bug.cgi?id=61192
      
             - only issue frontendReused when inspector is attached after main resource committed load
             - upon committing loading main resource, reset agents before sending FrameNavigated to page agent
             - Ensure main resource is set early so that abbreviations of URLs in resource tree are consistent after reload
             - do not enable agents explicitly in frontendReused (this is done by backend when resotring state from cookie)
      
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::restore):
              (WebCore::InspectorAgent::clearFrontend):
              (WebCore::InspectorAgent::didCommitLoad):
              * inspector/InspectorAgent.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didCommitLoadImpl):
              * inspector/front-end/NetworkManager.js:
              * inspector/front-end/ResourceTreeModel.js:
              (WebInspector.ResourceTreeModel.prototype._processCachedResources):
              (WebInspector.ResourceTreeModel.prototype._frameNavigated):
              (WebInspector.ResourceTreeModel.prototype._cleanupFramesAfterNavigation):
              (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel.prototype.reset):
              (WebInspector.ResourcesPanel.prototype._resetResourcesTree):
              (WebInspector.DatabaseTreeElement.prototype.onpopulate):
              (WebInspector.SearchResultsTreeElementsTraverser.prototype._lastTreeElement):
              * inspector/front-end/inspector.js:
              (WebInspector.reset):
              (WebInspector.frontendReused):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac4fa7a2
  24. 16 May, 2011 1 commit
    • yurys@chromium.org's avatar
      2011-05-11 Yury Semikhatsky <yurys@chromium.org> · 32323477
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: use InstrumentingAgents to access agents from InspectorInstrumentation
              https://bugs.webkit.org/show_bug.cgi?id=60624
      
              InspectorInstrumentation retrieves inspector agents from corresponding InstrumentingAgents
              instance. Each agent notifies InstrumentingAgents whenever it wants to receive notifications
              about changes in WebCore.
      
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::inspectedPageDestroyed):
              * inspector/InspectorAgent.h:
              * inspector/InspectorConsoleInstrumentation.h:
              (WebCore::InspectorInstrumentation::addMessageToConsole):
              (WebCore::InspectorInstrumentation::consoleCount):
              (WebCore::InspectorInstrumentation::startConsoleTiming):
              (WebCore::InspectorInstrumentation::stopConsoleTiming):
              (WebCore::InspectorInstrumentation::consoleMarkTimeline):
              (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
              (WebCore::InspectorInstrumentation::addProfile):
              (WebCore::InspectorInstrumentation::profilerEnabled):
              (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::inspectedPageDestroyed):
              (WebCore::InspectorController::didClearWindowObjectInWorld):
              (WebCore::InspectorController::inspectedPage):
              * inspector/InspectorController.h:
              * inspector/InspectorDatabaseInstrumentation.h: FAST_RETURN_IF_NO_FRONTENDS macros
              is used for early return in common case when inspector is not opened. In this
              case inspector instrumentation costs one additional check of a static field.
              (WebCore::InspectorInstrumentation::didOpenDatabase):
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::instrumentingAgents):
              (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
              (WebCore::InspectorInstrumentation::inspectedPageDestroyedImpl):
              (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
              (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
              (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
              (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
              (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
              (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
              (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):
              (WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl):
              (WebCore::InspectorInstrumentation::handleMousePressImpl):
              (WebCore::InspectorInstrumentation::characterDataModifiedImpl):
              (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
              (WebCore::InspectorInstrumentation::didScheduleResourceRequestImpl):
              (WebCore::InspectorInstrumentation::didInstallTimerImpl):
              (WebCore::InspectorInstrumentation::didRemoveTimerImpl):
              (WebCore::InspectorInstrumentation::willCallFunctionImpl):
              (WebCore::InspectorInstrumentation::willChangeXHRReadyStateImpl):
              (WebCore::InspectorInstrumentation::willDispatchEventImpl):
              (WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl):
              (WebCore::InspectorInstrumentation::willEvaluateScriptImpl):
              (WebCore::InspectorInstrumentation::willFireTimerImpl):
              (WebCore::InspectorInstrumentation::willLayoutImpl):
              (WebCore::InspectorInstrumentation::willLoadXHRImpl):
              (WebCore::InspectorInstrumentation::willPaintImpl):
              (WebCore::InspectorInstrumentation::willRecalculateStyleImpl):
              (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
              (WebCore::InspectorInstrumentation::willSendRequestImpl):
              (WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl):
              (WebCore::InspectorInstrumentation::markResourceAsCachedImpl):
              (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
              (WebCore::InspectorInstrumentation::willReceiveResourceDataImpl):
              (WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl):
              (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
              (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
              (WebCore::InspectorInstrumentation::didFinishLoadingImpl):
              (WebCore::InspectorInstrumentation::didFailLoadingImpl):
              (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
              (WebCore::InspectorInstrumentation::scriptImportedImpl):
              (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
              (WebCore::InspectorInstrumentation::loadEventFiredImpl):
              (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
              (WebCore::InspectorInstrumentation::didCommitLoadImpl):
              (WebCore::InspectorInstrumentation::willWriteHTMLImpl):
              (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
              (WebCore::InspectorInstrumentation::consoleCountImpl):
              (WebCore::InspectorInstrumentation::startConsoleTimingImpl):
              (WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
              (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl):
              (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
              (WebCore::InspectorInstrumentation::addProfileImpl):
              (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
              (WebCore::InspectorInstrumentation::profilerEnabledImpl):
              (WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
              (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
              (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
              (WebCore::InspectorInstrumentation::didCreateWorkerImpl):
              (WebCore::InspectorInstrumentation::didDestroyWorkerImpl):
              (WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
              (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
              (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
              (WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
              (WebCore::InspectorInstrumentation::networkStateChangedImpl):
              (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
              (WebCore::InspectorInstrumentation::hasFrontend):
              (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
              (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent):
              (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::bindInstrumentingAgents):
              (WebCore::InspectorInstrumentation::unbindInstrumentingAgents):
              (WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
              (WebCore::InspectorInstrumentation::inspectedPageDestroyed):
              (WebCore::InspectorInstrumentation::willInsertDOMNode):
              (WebCore::InspectorInstrumentation::didInsertDOMNode):
              (WebCore::InspectorInstrumentation::willRemoveDOMNode):
              (WebCore::InspectorInstrumentation::willModifyDOMAttr):
              (WebCore::InspectorInstrumentation::didModifyDOMAttr):
              (WebCore::InspectorInstrumentation::didInvalidateStyleAttr):
              (WebCore::InspectorInstrumentation::mouseDidMoveOverElement):
              (WebCore::InspectorInstrumentation::handleMousePress):
              (WebCore::InspectorInstrumentation::characterDataModified):
              (WebCore::InspectorInstrumentation::willSendXMLHttpRequest):
              (WebCore::InspectorInstrumentation::didScheduleResourceRequest):
              (WebCore::InspectorInstrumentation::didInstallTimer):
              (WebCore::InspectorInstrumentation::didRemoveTimer):
              (WebCore::InspectorInstrumentation::willCallFunction):
              (WebCore::InspectorInstrumentation::willChangeXHRReadyState):
              (WebCore::InspectorInstrumentation::willDispatchEvent):
              (WebCore::InspectorInstrumentation::willDispatchEventOnWindow):
              (WebCore::InspectorInstrumentation::willEvaluateScript):
              (WebCore::InspectorInstrumentation::willFireTimer):
              (WebCore::InspectorInstrumentation::willLayout):
              (WebCore::InspectorInstrumentation::willLoadXHR):
              (WebCore::InspectorInstrumentation::willPaint):
              (WebCore::InspectorInstrumentation::willRecalculateStyle):
              (WebCore::InspectorInstrumentation::applyUserAgentOverride):
              (WebCore::InspectorInstrumentation::willSendRequest):
              (WebCore::InspectorInstrumentation::continueAfterPingLoader):
              (WebCore::InspectorInstrumentation::markResourceAsCached):
              (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):
              (WebCore::InspectorInstrumentation::willReceiveResourceData):
              (WebCore::InspectorInstrumentation::willReceiveResourceResponse):
              (WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDenied):
              (WebCore::InspectorInstrumentation::continueWithPolicyDownload):
              (WebCore::InspectorInstrumentation::continueWithPolicyIgnore):
              (WebCore::InspectorInstrumentation::didReceiveContentLength):
              (WebCore::InspectorInstrumentation::didFinishLoading):
              (WebCore::InspectorInstrumentation::didFailLoading):
              (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest):
              (WebCore::InspectorInstrumentation::scriptImported):
              (WebCore::InspectorInstrumentation::domContentLoadedEventFired):
              (WebCore::InspectorInstrumentation::loadEventFired):
              (WebCore::InspectorInstrumentation::frameDetachedFromParent):
              (WebCore::InspectorInstrumentation::didCommitLoad):
              (WebCore::InspectorInstrumentation::willWriteHTML):
              (WebCore::InspectorInstrumentation::didUseDOMStorage):
              (WebCore::InspectorInstrumentation::willStartWorkerContext):
              (WebCore::InspectorInstrumentation::didStartWorkerContext):
              (WebCore::InspectorInstrumentation::didCreateWorker):
              (WebCore::InspectorInstrumentation::didDestroyWorker):
              (WebCore::InspectorInstrumentation::didCreateWebSocket):
              (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
              (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
              (WebCore::InspectorInstrumentation::didCloseWebSocket):
              (WebCore::InspectorInstrumentation::networkStateChanged):
              (WebCore::InspectorInstrumentation::updateApplicationCacheStatus):
              (WebCore::InspectorInstrumentation::hasFrontend):
              (WebCore::InspectorInstrumentation::instrumentingAgentsForContext):
              (WebCore::InspectorInstrumentation::instrumentingAgentsForPage):
              (WebCore::InspectorInstrumentation::instrumentingAgentsForFrame):
              (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForFrame):
              (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForPage):
              (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForContext):
              (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForDocument):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86564 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32323477
  25. 12 May, 2011 1 commit
    • yurys@chromium.org's avatar
      2011-05-06 Yury Semikhatsky <yurys@chromium.org> · a5236926
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: move agents from InspectorAgent to InspectorController
              https://bugs.webkit.org/show_bug.cgi?id=60359
      
              All inspector agents are now created and owned by InspectorController which
              in turned is owned by the inspected Page. InspectorInstrumentation gets access
              to the instrumenting agents by means of InspectorAgent::instrumentingAgents().
      
              In addition to managing inspector agents lifetime InspectorController sets
              InspectorFronted on the agents when the front-end is connected.
      
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::~InspectorAgent):
              (WebCore::InspectorAgent::inspectedPageDestroyed):
              (WebCore::InspectorAgent::restore):
              (WebCore::InspectorAgent::setFrontend):
              (WebCore::InspectorAgent::clearFrontend):
              * inspector/InspectorAgent.h: all accessors to other agents were removed along with
              the agents themselves from InspectorAgent. Every agent that depends on some other agents
              receives pointers to them explicitely in its constructor. All access to the agents
              from WebCore should go through InspectorInstrumentation which retrieves corresponding
              agents using InstrumentingAgents structure which represents the set of active agents.
              (WebCore::InspectorAgent::instrumentingAgents):
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::~InspectorController):
              (WebCore::InspectorController::inspectedPageDestroyed):
              (WebCore::InspectorController::startTimelineProfiler):
              (WebCore::InspectorController::stopTimelineProfiler):
              (WebCore::InspectorController::connectFrontend):
              (WebCore::InspectorController::disconnectFrontend):
              (WebCore::InspectorController::restoreInspectorStateFromCookie):
              (WebCore::InspectorController::drawNodeHighlight):
              (WebCore::InspectorController::inspect):
              (WebCore::InspectorController::timelineProfilerEnabled):
              (WebCore::InspectorController::hideHighlight):
              (WebCore::InspectorController::highlightedNode):
              (WebCore::InspectorController::enableProfiler):
              (WebCore::InspectorController::disableProfiler):
              (WebCore::InspectorController::profilerEnabled):
              (WebCore::InspectorController::debuggerEnabled):
              (WebCore::InspectorController::disableDebugger):
              (WebCore::InspectorController::startUserInitiatedProfiling):
              (WebCore::InspectorController::stopUserInitiatedProfiling):
              (WebCore::InspectorController::isRecordingUserInitiatedProfile):
              (WebCore::InspectorController::resume):
              * inspector/InspectorController.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
              (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
              (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
              (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):
              (WebCore::InspectorInstrumentation::characterDataModifiedImpl):
              (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
              (WebCore::InspectorInstrumentation::didFailLoadingImpl):
              (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
              (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
              (WebCore::InspectorInstrumentation::consoleCountImpl):
              (WebCore::InspectorInstrumentation::startConsoleTimingImpl):
              (WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
              (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
              (WebCore::InspectorInstrumentation::addProfileImpl):
              (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
              (WebCore::InspectorInstrumentation::profilerEnabledImpl):
              (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent):
              * page/Page.cpp:
              (WebCore::Page::~Page): we send two notifications when inspected Page is being
              destroyed: one to the inspector instrumentation and another one to the InspectorController
              which is owned by the Page.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5236926
  26. 11 May, 2011 1 commit
    • weinig@apple.com's avatar
      2011-05-11 Sam Weinig <sam@webkit.org> · f25e6ff1
      weinig@apple.com authored
              Reviewed by Eric Seidel.
      
              Stop including Console.h just to get Console enum types
              https://bugs.webkit.org/show_bug.cgi?id=60607
      
              Move MessageSource, MessageType and MessageLevel into its own
              header and cleanup surrounding classes.
      
              * Api/qwebelement.cpp:
      2011-05-11  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Stop including Console.h just to get Console enum types
              https://bugs.webkit.org/show_bug.cgi?id=60607
      
              Move MessageSource, MessageType and MessageLevel into its own
              header and cleanup surrounding classes.
      
              * GNUmakefile.list.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSCustomXPathNSResolver.cpp:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/v8/V8Proxy.cpp:
              * dom/ScriptExecutionContext.h:
              * html/HTMLFormElement.cpp:
              * html/parser/XSSFilter.cpp:
              * inspector/ConsoleMessage.h:
              * inspector/InjectedScriptHost.h:
              * inspector/InspectorAgent.h:
              * inspector/InspectorConsoleAgent.h:
              * inspector/InspectorFrontendHost.h:
              * inspector/InspectorInstrumentation.cpp:
              * inspector/InspectorInstrumentation.h:
              * loader/EmptyClients.h:
              * loader/FrameLoader.cpp:
              * loader/MainResourceLoader.cpp:
              * loader/appcache/ApplicationCacheGroup.cpp:
              * page/ChromeClient.h:
              * page/Console.cpp:
              (WebCore::Console::~Console):
              * page/Console.h:
              * page/ConsoleTypes.h: Added.
              * page/ContentSecurityPolicy.cpp:
              * page/Geolocation.h:
              * workers/WorkerReportingProxy.h:
              * xml/XMLHttpRequest.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f25e6ff1
  27. 05 May, 2011 1 commit
    • loislo@chromium.org's avatar
      2011-05-05 Ilya Tikhonovsky <loislo@chromium.org> · 7ce94c06
      loislo@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: rename BrowserDebugger to DOMDebugger.
      
              https://bugs.webkit.org/show_bug.cgi?id=60256
              InspectorBrowserDebuggerAgent => InspectorDOMDebuggerAgent
              browserDebugger => domDebugger
      
              * CMakeLists.txt:
              * GNUmakefile.list.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * inspector/CodeGeneratorInspector.pm:
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::inspectedPageDestroyed):
              (WebCore::InspectorAgent::disconnectFrontend):
              * inspector/InspectorAgent.h:
              (WebCore::InspectorAgent::DOMDebuggerAgent):
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::connectFrontend):
              * inspector/InspectorDOMDebuggerAgent.cpp: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.cpp.
              (WebCore::InspectorDOMDebuggerAgent::create):
              (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
              (WebCore::InspectorDOMDebuggerAgent::~InspectorDOMDebuggerAgent):
              (WebCore::InspectorDOMDebuggerAgent::debuggerWasEnabled):
              (WebCore::InspectorDOMDebuggerAgent::debuggerWasDisabled):
              (WebCore::InspectorDOMDebuggerAgent::disable):
              (WebCore::InspectorDOMDebuggerAgent::clearFrontend):
              (WebCore::InspectorDOMDebuggerAgent::discardBindings):
              (WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
              (WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
              (WebCore::InspectorDOMDebuggerAgent::didInsertDOMNode):
              (WebCore::InspectorDOMDebuggerAgent::didRemoveDOMNode):
              (WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
              (WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
              (WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
              (WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
              (WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
              (WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
              (WebCore::InspectorDOMDebuggerAgent::hasBreakpoint):
              (WebCore::InspectorDOMDebuggerAgent::updateSubtreeBreakpoints):
              (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
              (WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
              (WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
              (WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
              (WebCore::InspectorDOMDebuggerAgent::clear):
              * inspector/InspectorDOMDebuggerAgent.h: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h.
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
              (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
              (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
              (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
              (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
              (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
              (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
              * inspector/InstrumentingAgents.h:
              (WebCore::InstrumentingAgents::InstrumentingAgents):
              (WebCore::InstrumentingAgents::inspectorDOMDebuggerAgent):
              (WebCore::InstrumentingAgents::setInspectorDOMDebuggerAgent):
              * inspector/WorkerInspectorController.cpp:
              (WebCore::WorkerInspectorController::connectFrontend):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ce94c06
  28. 25 Apr, 2011 1 commit
    • yurys@chromium.org's avatar
      2011-04-25 Yury Semikhatsky <yurys@chromium.org> · 327ecf30
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: introduce InspectorWorkerAgent
              https://bugs.webkit.org/show_bug.cgi?id=59320
      
              InspectorWorkerAgent is responsible for routing inspector messages
              between worker context inspector agents and corresponding worker
              inspector front-end.
      
              * CMakeLists.txt:
              * GNUmakefile.list.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * inspector/CodeGeneratorInspector.pm:
              * inspector/Inspector.json:
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::setFrontend):
              (WebCore::InspectorAgent::disconnectFrontend):
              * inspector/InspectorAgent.h:
              (WebCore::InspectorAgent::workerAgent):
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::connectFrontend):
              (WebCore::InspectorController::disconnectFrontend):
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::willStartWorkerContext):
              (WebCore::InspectorInstrumentation::didStartWorkerContext):
              * inspector/InspectorWorkerAgent.cpp: Added.
              (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
              (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
              (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id):
              (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy):
              (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend):
              (WebCore::InspectorWorkerAgent::create):
              (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
              (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
              (WebCore::InspectorWorkerAgent::setFrontend):
              (WebCore::InspectorWorkerAgent::clearFrontend):
              (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector):
              (WebCore::InspectorWorkerAgent::didStartWorkerContext):
              * inspector/InspectorWorkerAgent.h: Added.
              * inspector/InstrumentingAgents.h:
              (WebCore::InstrumentingAgents::InstrumentingAgents):
              (WebCore::InstrumentingAgents::inspectorWorkerAgent):
              (WebCore::InstrumentingAgents::setInspectorWorkerAgent):
              * inspector/WorkerInspectorController.cpp:
              (WebCore::WorkerInspectorController::connectFrontend):
              * inspector/generate-inspector-idl:
              * workers/Worker.cpp:
              (WebCore::Worker::notifyFinished):
              * workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector
              messages sent from the inspected page worker agent to the worker context inspector agents.
              (WebCore::WorkerContextInspectorProxy::connectFrontend):
              (WebCore::WorkerContextInspectorProxy::disconnectFrontend):
              (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector):
              (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy):
              * workers/WorkerContextProxy.h:
              (WebCore::WorkerContextProxy::inspectorProxy):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      327ecf30
  29. 12 Apr, 2011 1 commit
    • loislo@chromium.org's avatar
      2011-04-12 Ilya Tikhonovsky <loislo@chromium.org> · ec5a3513
      loislo@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: remove unnecessary method InspectorAgent.didEvaluateForTestInFrontend.
              https://bugs.webkit.org/show_bug.cgi?id=58335
      
              It was the method for Inspector layout tests.
              We can use RuntimeAgent.evaluate instead.
      
              * http/tests/inspector/inspector-test.js:
              (initialize_InspectorTest.InspectorTest.completeTest):
      2011-04-12  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: remove unnecessary method InspectorAgent.didEvaluateForTestInFrontend.
              https://bugs.webkit.org/show_bug.cgi?id=58335
      
              It was the method for Inspector layout tests.
              We can use RuntimeAgent.evaluate instead.
      
              * inspector/Inspector.json:
              * inspector/InspectorAgent.cpp:
              * inspector/InspectorAgent.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::connectFrontend):
              * inspector/front-end/TestController.js:
              (WebInspector.TestController.prototype.notifyDone):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec5a3513
  30. 04 Apr, 2011 1 commit
    • yurys@chromium.org's avatar
      2011-04-04 Yury Semikhatsky <yurys@chromium.org> · 3a661699
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: InspectorRuntimeAgent should not depend on Page
              https://bugs.webkit.org/show_bug.cgi?id=57759
      
              Descendants of InspectorRuntimeAgent should implement a method providing access to the default
              inspected state used for console evaluations.
      
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent): runtime agent is created and deleted along with other agents.
              (WebCore::InspectorAgent::setFrontend):
              * inspector/InspectorAgent.h:
              * inspector/InspectorRuntimeAgent.cpp:
              (WebCore::InspectorRuntimeAgent::create):
              (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
              (WebCore::InspectorRuntimeAgent::evaluate):
              * inspector/InspectorRuntimeAgent.h:
              (WebCore::InspectorRuntimeAgent::InspectedStateProvider::~InspectedStateProvider):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a661699
  31. 30 Mar, 2011 1 commit
  32. 29 Mar, 2011 2 commits
    • loislo@chromium.org's avatar
      2011-03-29 Ilya Tikhonovsky <loislo@chromium.org> · 0857b043
      loislo@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: extract InspectorPageAgent from InspectorAgent.
              https://bugs.webkit.org/show_bug.cgi?id=57327
      
              There are page related methods and inspector related methods in InspectorAgent.
              It would be nice to extract page specific methods for future usage the rest of methods in workers debugger.
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * inspector/CodeGeneratorInspector.pm:
              * inspector/Inspector.json:
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
              (WebCore::InspectorAgent::didClearWindowObjectInWorld):
              (WebCore::InspectorAgent::setFrontend):
              (WebCore::InspectorAgent::disconnectFrontend):
              (WebCore::InspectorAgent::didCommitLoad):
              (WebCore::InspectorAgent::domContentLoadedEventFired):
              * inspector/InspectorAgent.h:
              (WebCore::InspectorAgent::pageAgent):
              * inspector/InspectorPageAgent.cpp: Added.
              (WebCore::InspectorPageAgent::create):
              (WebCore::InspectorPageAgent::InspectorPageAgent):
              (WebCore::InspectorPageAgent::setFrontend):
              (WebCore::InspectorPageAgent::clearFrontend):
              (WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
              (WebCore::InspectorPageAgent::removeAllScriptsToEvaluateOnLoad):
              (WebCore::InspectorPageAgent::reloadPage):
              (WebCore::InspectorPageAgent::openInInspectedWindow):
              (WebCore::InspectorPageAgent::setUserAgentOverride):
              (WebCore::buildObjectForCookie):
              (WebCore::buildArrayForCookies):
              (WebCore::InspectorPageAgent::getCookies):
              (WebCore::InspectorPageAgent::deleteCookie):
              (WebCore::InspectorPageAgent::inspectedURLChanged):
              (WebCore::InspectorPageAgent::restore):
              (WebCore::InspectorPageAgent::didCommitLoad):
              (WebCore::InspectorPageAgent::domContentEventFired):
              (WebCore::InspectorPageAgent::loadEventFired):
              (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
              (WebCore::InspectorPageAgent::applyUserAgentOverride):
              * inspector/InspectorPageAgent.h: Added.
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::connectFrontend):
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
              (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
              (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
              (WebCore::InspectorInstrumentation::loadEventFiredImpl):
              (WebCore::InspectorInstrumentation::didCommitLoadImpl):
              (WebCore::InspectorInstrumentation::retrievePageAgent):
              * inspector/InspectorInstrumentation.h:
              * inspector/InstrumentingAgents.h:
              (WebCore::InstrumentingAgents::InstrumentingAgents):
              (WebCore::InstrumentingAgents::inspectorPageAgent):
              (WebCore::InstrumentingAgents::setInspectorPageAgent):
              * inspector/front-end/AuditsPanel.js:
              (WebInspector.AuditsPanel.prototype._reloadResources):
              * inspector/front-end/CookieItemsView.js:
              (WebInspector.CookieItemsView.prototype._deleteCookie):
              (WebInspector.Cookies.getCookiesAsync):
              * inspector/front-end/ExtensionServer.js:
              (WebInspector.ExtensionServer.prototype._onReload):
              * inspector/front-end/NetworkPanel.js:
              (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.FrameResourceTreeElement.prototype.ondblclick):
              * inspector/front-end/WorkersSidebarPane.js:
              (WebInspector.WorkersSidebarPane.prototype.setInstrumentation):
              * inspector/front-end/inspector.js:
              (WebInspector.openResource):
              (WebInspector.documentKeyDown):
      
      2011-03-29  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: extract InspectorPageAgent from InspectorAgent.
              https://bugs.webkit.org/show_bug.cgi?id=57327
      
              There are page related methods and inspector related methods in InspectorAgent.
              It would be nice to extract page specific methods for future usage the rest of methods in workers debugger.
      
              * http/tests/inspector/inspector-test.js:
              (initialize_InspectorTest.InspectorTest.reloadPage):
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0857b043
    • loislo@chromium.org's avatar
      2011-03-29 Ilya Tikhonovsky <loislo@chromium.org> · 1fd3dfb8
      loislo@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: InspectorDOMAgent has unnecessary dependency from InspectorAgent.
              https://bugs.webkit.org/show_bug.cgi?id=57329
      
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::setFrontend):
              * inspector/InspectorAgent.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::inspect):
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::InspectorDOMAgent):
              (WebCore::InspectorDOMAgent::setFrontend):
              (WebCore::InspectorDOMAgent::handleMousePress):
              (WebCore::InspectorDOMAgent::inspect):
              (WebCore::InspectorDOMAgent::focusNode):
              (WebCore::InspectorDOMAgent::highlight):
              (WebCore::InspectorDOMAgent::hideHighlight):
              * inspector/InspectorDOMAgent.h:
              (WebCore::InspectorDOMAgent::create):
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fd3dfb8
  33. 23 Mar, 2011 1 commit
    • loislo@chromium.org's avatar
      2011-03-23 Ilya Tikhonovsky <loislo@chromium.org> · 3c960d25
      loislo@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: move node searching and node highlight related methods from InspectorAgent to InspectorDOMAgent.
              https://bugs.webkit.org/show_bug.cgi?id=56912
      
              The next functions were moved:
                  setSearchingForNode
                  highlightDOMNode
                  hideDOMNodeHighlight
                  highlightFrame
                  hideFrameHighlight
                  mouseDidMoveOverElement
                  handleMousePress
      
              The code which does real highlight in Graphic context was moved to new files DOMNodeHighlighter.*
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * inspector/DOMNodeHighlighter.cpp: Added.
              (WebCore::DOMNodeHighlighter::DrawNodeHighlight):
              * inspector/DOMNodeHighlighter.h: Added.
              * inspector/Inspector.json:
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::~InspectorAgent):
              (WebCore::InspectorAgent::inspectedPageDestroyed):
              (WebCore::InspectorAgent::disconnectFrontend):
              * inspector/InspectorAgent.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::drawNodeHighlight):
              (WebCore::InspectorController::hideHighlight):
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::InspectorDOMAgent):
              (WebCore::InspectorDOMAgent::~InspectorDOMAgent):
              (WebCore::InspectorDOMAgent::clearFrontend):
              (WebCore::InspectorDOMAgent::handleMousePress):
              (WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
              (WebCore::InspectorDOMAgent::searchingForNodeInPage):
              (WebCore::InspectorDOMAgent::setSearchingForNode):
              (WebCore::InspectorDOMAgent::highlight):
              (WebCore::InspectorDOMAgent::highlightDOMNode):
              (WebCore::InspectorDOMAgent::highlightFrame):
              (WebCore::InspectorDOMAgent::hideHighlight):
              (WebCore::InspectorDOMAgent::drawNodeHighlight):
              * inspector/InspectorDOMAgent.h:
              (WebCore::InspectorDOMAgent::hideDOMNodeHighlight):
              (WebCore::InspectorDOMAgent::hideFrameHighlight):
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl):
              (WebCore::InspectorInstrumentation::handleMousePressImpl):
              * inspector/InstrumentingAgents.h:
              (WebCore::InstrumentingAgents::InstrumentingAgents):
              (WebCore::InstrumentingAgents::inspectorAgent):
              (WebCore::InstrumentingAgents::setInspectorAgent):
              * inspector/front-end/ElementsPanel.js:
              (WebInspector.ElementsPanel.prototype.setSearchingForNode):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.FrameTreeElement.prototype.onselect):
              (WebInspector.FrameTreeElement.prototype.set hovered):
              * inspector/front-end/inspector.js:
              (WebInspector.highlightDOMNode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c960d25
  34. 22 Mar, 2011 1 commit
    • podivilov@chromium.org's avatar
      2011-03-21 Pavel Podivilov <podivilov@chromium.org> · 853d40a0
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: [REGRESSION] scripts panel is broken when frontend is reopened.
              https://bugs.webkit.org/show_bug.cgi?id=56747
      
              Debugger should be enabled on front-end side to guarantee initialization sequence (resources come before scripts).
      
              * inspector/Inspector.json:
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::showProfilesPanel):
              * inspector/InspectorAgent.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::connectFrontend):
              (WebCore::InspectorController::showAndEnableDebugger):
              * inspector/InspectorController.h:
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::setFrontend):
              (WebCore::InspectorDebuggerAgent::clearFrontend):
              * inspector/InspectorDebuggerAgent.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      853d40a0