1. 13 Aug, 2009 40 commits
    • bweinstein@apple.com's avatar
      Build fix so JavaScriptCore builds, might fail linking WebCore or WebKit.... · 6ef016be
      bweinstein@apple.com authored
      Build fix so JavaScriptCore builds, might fail linking WebCore or WebKit. Added includes and removed a missing function from JavaScriptCore_debug.def and JavascriptCore.def.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ef016be
    • eric@webkit.org's avatar
      2009-08-13 Shinichiro Hamaji <hamaji@chromium.org> · dd254f5d
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              rename make-js-test-wrappers to make-script-test-wrappers
              https://bugs.webkit.org/show_bug.cgi?id=28212
      
              * Scripts/make-script-test-wrappers: Renamed from WebKitTools/Scripts/make-js-test-wrappers.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd254f5d
    • bweinstein@apple.com's avatar
      DRT improvements for Database stuff. · bf6707b7
      bweinstein@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf6707b7
    • darin@apple.com's avatar
      JavaScriptCore: JavaScriptCore tweaks to get ready for the parser arena · cbc86179
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=28243
      
      Patch by Darin Adler <darin@apple.com> on 2009-08-13
      Reviewed by David Levin.
      
      Eliminate dependencies on Nodes.h outside JavaScriptCore,
      and cut down on them inside JavaScriptCore.
      
      Change regular expression parsing to use identifiers as
      with other strings we parse.
      
      Fix a couple things that are needed to use const Identifier
      more, which will be part of the parser arena work.
      
      * JavaScriptCore.exp: Resorted and updated.
      
      * JavaScriptCore.xcodeproj/project.pbxproj: Changed
      CollectorHeapIterator.h to be project-internal.
      
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::emitPushNewScope): Added const.
      * bytecompiler/BytecodeGenerator.h: Ditto.
      
      * debugger/Debugger.cpp:
      (JSC::Debugger::recompileAllJSFunctions): Moved this function
      here from WebCore. Here is better since it uses so many internals.
      Removed unimportant optimization for the no listener case.
      * debugger/Debugger.h: Ditto. Also removed unneeded include
      and tweaked formatting and comments.
      
      * debugger/DebuggerCallFrame.cpp:
      (JSC::DebuggerCallFrame::functionName): Call asFunction instead
      of doing the unchecked static_cast.
      (JSC::DebuggerCallFrame::calculatedFunctionName): Ditto.
      
      * jit/JITStubs.cpp:
      (JSC::op_call_JSFunction): Call isHostFunction on the body rather
      than on the JSFunction.
      (JSC::vm_lazyLinkCall): Ditto.
      (JSC::op_construct_JSConstruct): Ditto.
      
      * parser/Grammar.y: Changed callers to use new scanRegExp with
      out arguments instead of relying on state in the Lexer. And
      callers that just want to skip a regular expression to use
      skipRegExp.
      
      * parser/Lexer.cpp:
      (JSC::Lexer::scanRegExp): Changed to use out arguments, and to
      add a prefix argument so we can add in the "=" character as needed.
      Also rewrote to streamline the logic a bit inspired by suggestions
      by David Levin.
      (JSC::Lexer::skipRegExp): Added. Version of the function above that
      does not actually put the regular expression into a string.
      (JSC::Lexer::clear): Removed code to clear m_pattern and m_flags.
      * parser/Lexer.h: Changed scanRegExp to have out arguments. Added
      skipRegExp. Eliminated pattern, flags, m_pattern, and m_flags.
      
      * parser/NodeConstructors.h:
      (JSC::RegExpNode::RegExpNode): Changed to take const Identifier&.
      * parser/Nodes.cpp:
      (JSC::RegExpNode::emitBytecode): Changed since m_pattern and
      m_flags are now Identifier instead of UString.
      (JSC::FunctionBodyNode::make): Moved this function here instead
      of putting it in the JSFunction.h header.
      * parser/Nodes.h: Changed RegExpNode to use Identifier.
      
      * profiler/Profiler.cpp:
      (JSC::Profiler::createCallIdentifier): Changed to use isHostFunction
      on the body instead of on the JSFunction object.
      * runtime/FunctionPrototype.cpp:
      (JSC::functionProtoFuncToString): Ditto.
      
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::isHostFunction): Moved here from header.
      (JSC::JSFunction::isHostFunctionNonInline): Added.
      (JSC::JSFunction::JSFunction): Removed unneeded initialization of
      m_body to 0.
      (JSC::JSFunction::setBody): Moved here from header.
      
      * runtime/JSFunction.h: Removed unneeded includes. Moved private
      constructor down to the private section. Made virtual functions
      private. Removed unneeded overload of setBody and moved the body
      of the function into the .cpp file. Changed assertions to use
      the non-inline version of isHostFunction.
      
      * runtime/PropertySlot.cpp:
      (JSC::PropertySlot::functionGetter): Use asFunction instead
      of doing the unchecked static_cast.
      
      * wtf/SegmentedVector.h:
      (WTF::SegmentedVector::isEmpty): Added.
      
      WebCore: JavaScriptCore tweaks to get ready for the parser arena
      https://bugs.webkit.org/show_bug.cgi?id=28243
      
      Patch by Darin Adler <darin@apple.com> on 2009-08-13
      Reviewed by David Levin.
      
      * ForwardingHeaders/runtime/CollectorHeapIterator.h: Removed.
      
      * WebCore.xcodeproj/project.pbxproj: Exposed a couple header
      files as Private that are now needed to compile Mac WebKit.
      
      * bindings/js/JSAudioConstructor.cpp:
      * bindings/js/JSDOMBinding.cpp:
      * bindings/js/JSDOMBinding.h:
      * bindings/js/JSDOMWindowCustom.cpp:
      * bindings/js/JSHTMLInputElementCustom.cpp:
      * bindings/js/JSHistoryCustom.cpp:
      * bindings/js/JSImageConstructor.cpp:
      * bindings/js/JSLazyEventListener.cpp:
      * bindings/js/JSLocationCustom.cpp:
      * bindings/js/JSMessageChannelConstructor.cpp:
      * bindings/js/JSOptionConstructor.cpp:
      * bindings/js/JSWebSocketConstructor.cpp:
      * bindings/js/JSWebSocketCustom.cpp:
      * bindings/js/JSWorkerConstructor.cpp:
      * bindings/js/JSXMLHttpRequestConstructor.cpp:
      * bridge/jni/jni_jsobject.mm:
      Updated includes.
      
      * inspector/JavaScriptDebugServer.cpp:
      (WebCore::JavaScriptDebugServer::sourceParsed):
      Change to not assert if this is called with no listeners.
      I don't think this was guaranteed before, and we now use
      this code path when recompiling. Slightly less efficient,
      but this is a one-time cost when turning on the debugger.
      (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
      Change to call Debugger::recompileAllJSFunctions.
      
      WebKit/mac: * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Updated includes.
      * WebView/WebScriptDebugger.mm: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbc86179
    • eric@webkit.org's avatar
      2009-08-13 Eric Seidel <eric@webkit.org> · e51d21d5
      eric@webkit.org authored
              Rubber-stamped by Adam Roben.
      
              REGRESSION: 6 media tests regressed while the windows bot was broken
              https://bugs.webkit.org/show_bug.cgi?id=28281
      
              * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e51d21d5
    • atwilson@chromium.org's avatar
      Unreviewed. · 7a681d70
      atwilson@chromium.org authored
      Patch by Drew Wilson <atwilson@chromium.org> on 2009-08-13
      Add myself to list of committers.
      
      * Scripts/modules/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a681d70
    • beidson@apple.com's avatar
      WebCore: <rdar://problem/7138591> and https://bugs.webkit.org/show_bug.cgi?id=28260 · ad915629
      beidson@apple.com authored
      onhashchange property cannot be set from javascript.
      
      Reviewed by Eric Seidel.
      
      Test: fast/loader/onhashchange-attribute-listeners.html
      
      * html/HTMLBodyElement.cpp:
      (WebCore::HTMLBodyElement::onhashchange):
      (WebCore::HTMLBodyElement::setOnhashchange):
      * html/HTMLBodyElement.h:
      * html/HTMLBodyElement.idl:
      
      * html/HTMLFrameSetElement.cpp:
      (WebCore::HTMLFrameSetElement::onhashchange):
      (WebCore::HTMLFrameSetElement::setOnhashchange):
      * html/HTMLFrameSetElement.h:
      * html/HTMLFrameSetElement.idl:
      
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::onhashchange):
      (WebCore::DOMWindow::setOnhashchange):
      * page/DOMWindow.h:
      * page/DOMWindow.idl:
      
      LayoutTests: <rdar://problem/7138591> and https://bugs.webkit.org/show_bug.cgi?id=28260
      onhashchange property cannot be set from javascript.
      
      Reviewed by Eric Seidel.
      
      * fast/dom/Window/window-properties-expected.txt:
      * fast/loader/onhashchange-attribute-listeners-expected.txt: Added.
      * fast/loader/onhashchange-attribute-listeners.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad915629
    • mrowe@apple.com's avatar
      Fix leaks of RGBColor instances from below SVGColor::rgbColor. · 00fe09c0
      mrowe@apple.com authored
      Reviewed by Geoff Garen.
      
      * svg/SVGColor.cpp:
      (WebCore::SVGColor::rgbColor): Return a PassRefPtr to ensure that the newly-allocated
      RGBColor is cleaned up by the caller.
      * svg/SVGColor.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00fe09c0
    • pfeldman@chromium.org's avatar
      2009-08-13 Pavel Feldman <pfeldman@chromium.org> · 3d9b58e2
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              WebInspector: Migrate to DOMAgent (serialized access to DOM).
      
              https://bugs.webkit.org/show_bug.cgi?id=28177
      
              * bindings/js/JSInspectorBackendCustom.cpp:
              (WebCore::JSInspectorBackend::highlightDOMNode):
              (WebCore::JSInspectorBackend::nodeForId):
              (WebCore::JSInspectorBackend::idForNode):
              (WebCore::JSInspectorBackend::wrapObject):
              (WebCore::JSInspectorBackend::unwrapObject):
              (WebCore::JSInspectorBackend::pushNodePathToFrontend):
              (WebCore::JSInspectorBackend::selectDatabase):
              (WebCore::JSInspectorBackend::selectDOMStorage):
              * bindings/js/ScriptObjectQuarantine.cpp:
              (WebCore::getQuarantinedScriptObject):
              * bindings/js/ScriptObjectQuarantine.h:
              * bindings/js/ScriptValue.cpp:
              (WebCore::ScriptValue::isObject):
              * bindings/js/ScriptValue.h:
              * bindings/v8/ScriptObjectQuarantine.cpp:
              (WebCore::getQuarantinedScriptObject):
              * bindings/v8/ScriptObjectQuarantine.h:
              * bindings/v8/ScriptValue.h:
              (WebCore::ScriptValue::isObject):
              * bindings/v8/custom/V8CustomBinding.h:
              * bindings/v8/custom/V8InspectorBackendCustom.cpp:
              (WebCore::CALLBACK_FUNC_DECL):
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::ConsoleMessage):
              * inspector/ConsoleMessage.h:
              * inspector/InspectorBackend.cpp:
              (WebCore::InspectorBackend::clearMessages):
              (WebCore::InspectorBackend::loaded):
              (WebCore::InspectorBackend::highlight):
              (WebCore::InspectorBackend::nodeForId):
              (WebCore::InspectorBackend::idForNode):
              (WebCore::InspectorBackend::wrapObject):
              (WebCore::InspectorBackend::unwrapObject):
              (WebCore::InspectorBackend::pushNodePathToFrontend):
              (WebCore::InspectorBackend::addNodesToSearchResult):
              (WebCore::InspectorBackend::selectDatabase):
              (WebCore::InspectorBackend::selectDOMStorage):
              * inspector/InspectorBackend.h:
              * inspector/InspectorBackend.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::focusNode):
              (WebCore::InspectorController::addMessageToConsole):
              (WebCore::InspectorController::clearConsoleMessages):
              (WebCore::InspectorController::startGroup):
              (WebCore::InspectorController::scriptObjectReady):
              (WebCore::InspectorController::setFrontendProxyObject):
              (WebCore::InspectorController::close):
              (WebCore::InspectorController::didCommitLoad):
              (WebCore::InspectorController::wrapObject):
              (WebCore::InspectorController::unwrapObject):
              * inspector/InspectorController.h:
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::setDocument):
              (WebCore::InspectorDOMAgent::handleEvent):
              (WebCore::InspectorDOMAgent::pushDocumentToFrontend):
              (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
              (WebCore::InspectorDOMAgent::nodeForId):
              (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
              (WebCore::InspectorDOMAgent::buildObjectForNode):
              (WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
              (WebCore::InspectorDOMAgent::innerParentElement):
              * inspector/InspectorDOMAgent.h:
              * inspector/InspectorDOMStorageResource.cpp:
              (WebCore::InspectorDOMStorageResource::bind):
              * inspector/InspectorFrontend.cpp:
              (WebCore::InspectorFrontend::clearConsoleMessages):
              (WebCore::InspectorFrontend::updateFocusedNode):
              (WebCore::InspectorFrontend::setDocument):
              (WebCore::InspectorFrontend::selectDatabase):
              (WebCore::InspectorFrontend::selectDOMStorage):
              (WebCore::InspectorFrontend::addNodesToSearchResult):
              * inspector/InspectorFrontend.h:
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype.clearMessages):
              (WebInspector.ConsoleView.prototype.completions):
              (WebInspector.ConsoleView.prototype._reportCompletions):
              (WebInspector.ConsoleView.prototype._messagesClicked):
              (WebInspector.ConsoleView.prototype.doEvalInWindow.evalCallback):
              (WebInspector.ConsoleView.prototype.doEvalInWindow):
              (WebInspector.ConsoleView.prototype._format):
              (WebInspector.ConsoleView.prototype._formatfunction):
              (WebInspector.ConsoleView.prototype._formatdate):
              (WebInspector.ConsoleView.prototype._formatregexp):
              (WebInspector.ConsoleView.prototype._formatnode):
              (WebInspector.ConsoleView.prototype._formatobject):
              * inspector/front-end/DOMAgent.js:
              (WebInspector.DOMNode):
              (WebInspector.DOMNode.prototype._renumber):
              (WebInspector.DOMDocument):
              (WebInspector.DOMAgent):
              (WebInspector.DOMAgent.prototype.getChildNodesAsync):
              (WebInspector.DOMAgent.prototype.setAttributeAsync):
              (WebInspector.DOMAgent.prototype.removeAttributeAsync):
              (WebInspector.DOMAgent.prototype.setTextNodeValueAsync):
              (WebInspector.DOMAgent.prototype.nodeForId):
              (WebInspector.DOMAgent.prototype._setDocument):
              (WebInspector.DOMAgent.prototype._setChildNodes):
              (WebInspector.DOMAgent.prototype._bindNodes):
              (WebInspector.DOMAgent.prototype._childNodeInserted):
              (WebInspector.CSSStyleDeclaration):
              (WebInspector.CSSStyleDeclaration.parseRule):
              (WebInspector.setDocument):
              (InspectorController.getStyles):
              (InspectorController.getComputedStyle):
              (InspectorController.getInlineStyle):
              (InspectorController.applyStyleText):
              (InspectorController.setStyleText):
              (InspectorController.toggleStyleEnabled):
              (InspectorController.applyStyleRuleText):
              (InspectorController.addStyleSelector):
              (InspectorController.setStyleProperty):
              (InspectorController.getPrototypes):
              (InspectorController.getProperties):
              (InspectorController.setPropertyValue):
              (InspectorController.evaluate):
              (InspectorController.addInspectedNode):
              (InspectorController.performSearch):
              (InspectorController.searchCanceled):
              * inspector/front-end/ElementsPanel.js:
              (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
              (WebInspector.ElementsPanel.prototype.searchCanceled):
              (WebInspector.ElementsPanel.prototype.performSearch):
              (WebInspector.ElementsPanel.prototype._updateMatchesCount):
              (WebInspector.ElementsPanel.prototype._updateMatchesCountSoon):
              (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
              * inspector/front-end/ElementsTreeOutline.js:
              (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode.restoreHighlightToHoveredNode):
              (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
              (WebInspector.ElementsTreeElement.prototype.updateChildren):
              (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
              * inspector/front-end/InjectedScript.js:
              (InjectedScript.applyStyleRuleText):
              (InjectedScript.addStyleSelector):
              (InjectedScript._doesSelectorAffectNode):
              (InjectedScript._serializeRule):
              (InjectedScript._serializeStyle):
              (InjectedScript.getProperties):
              (InjectedScript.evaluate):
              (InjectedScript.addInspectedNode):
              (InjectedScript.performSearch.addNodesToResults):
              (InjectedScript.performSearch.matchExactItems):
              (InjectedScript.performSearch.matchExactId.addNodesToResults.call):
              (InjectedScript.performSearch.matchExactId):
              (InjectedScript.performSearch):
              (InjectedScript.performSearch.matchExactTagNames):
              (InjectedScript.performSearch.matchExactAttributeNames):
              (InjectedScript.performSearch.matchPartialTagNames):
              (InjectedScript.performSearch.matchStartOfTagNames):
              (InjectedScript.performSearch.matchPartialTagNamesAndAttributeValues):
              (InjectedScript.performSearch.matchPartialAttributeValues):
              (InjectedScript.performSearch.matchStyleSelector):
              (InjectedScript.performSearch.matchPlainText):
              (InjectedScript.performSearch.matchXPathQuery):
              (InjectedScript.performSearch.finishedSearching):
              (InjectedScript.performSearch.processChunk):
              (InjectedScript.searchCanceled):
              (InjectedScript._ensureCommandLineAPIInstalled.inspectObject):
              (InjectedScript._ensureCommandLineAPIInstalled):
              (InjectedScript._resolveObject):
              (InjectedScript._nodeForId):
              (InjectedScript._objectForId):
              (InjectedScript._createProxyObject):
              * inspector/front-end/ObjectPropertiesSection.js:
              (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
              (WebInspector.ObjectPropertyTreeElement.prototype.update):
              * inspector/front-end/ObjectProxy.js:
              (WebInspector.ObjectProxy):
              (WebInspector.ObjectPropertyProxy):
              * inspector/front-end/PropertiesSidebarPane.js:
              (WebInspector.PropertiesSidebarPane.prototype.update.callback):
              (WebInspector.PropertiesSidebarPane.prototype.update):
              * inspector/front-end/StylesSidebarPane.js:
              (WebInspector.StylesSidebarPane.prototype.update.callback):
              (WebInspector.StylesSidebarPane.prototype.update):
              (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
              (WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled):
              (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted.callback):
              (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted):
              (WebInspector.StylePropertyTreeElement.prototype):
              * inspector/front-end/inspector.js:
              (WebInspector._updateHoverHighlight):
              (WebInspector.loaded):
              (WebInspector.clearConsoleMessages):
              (WebInspector.selectDatabase):
              (WebInspector.selectDOMStorage):
              (WebInspector.updateFocusedNode):
              (WebInspector.addNodesToSearchResult):
              * inspector/front-end/utilities.js:
              (Object.proxyType):
              * storage/Storage.h:
              (WebCore::Storage::frame):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d9b58e2
    • mrowe@apple.com's avatar
      Fix leaks of RGBColor instances from below CSSPrimitiveValue::getRGBColorValue. · d64517a5
      mrowe@apple.com authored
      Reviewed by Geoff Garen.
      
      * css/CSSPrimitiveValue.cpp:
      (WebCore::CSSPrimitiveValue::getRGBColorValue): Return a PassRefPtr to ensure that the
      newly-allocated RGBColor is cleaned up by the caller.
      * css/CSSPrimitiveValue.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d64517a5
    • eric@webkit.org's avatar
      2009-08-13 Eric Seidel <eric@webkit.org> · cb50bc6d
      eric@webkit.org authored
              Reviewed by David Hyatt.
      
              wrong font size when css font-family includes monospace
              https://bugs.webkit.org/show_bug.cgi?id=19161
      
              Update test results now that only "font-family: monospace" is 13px.
              All other combinations of font-family are 16px default size.
      
              Add two tests:
              font-family-fallback-reset: catches a bug in inheriting font-family fallback.
              computed-style-font-family-monospace: tests this bug, that only "font-family: monospace" is 13px.
      
              * fast/css/getComputedStyle/computed-style-font-family-expected.txt:
              * fast/css/getComputedStyle/computed-style-font-family-monospace-expected.txt: Added.
              * fast/css/getComputedStyle/computed-style-font-family-monospace.html: Added.
              * fast/css/getComputedStyle/font-family-fallback-reset-expected.txt: Added.
              * fast/css/getComputedStyle/font-family-fallback-reset.html: Added.
              * fast/css/getComputedStyle/resources/computed-style-font-family-monospace.js: Added.
              (fontSizeForFamilies):
              * fast/css/getComputedStyle/resources/font-family-fallback-reset.js: Added.
              * fast/js/method-check.html:
              * platform/mac/css1/font_properties/font_family-expected.txt:
              * platform/mac/css2.1/t1503-c522-font-family-00-b-expected.txt:
              * platform/mac/fast/text/monospace-width-cache-expected.txt:
      
      2009-08-13  Eric Seidel  <eric@webkit.org>
      
              Reviewed by David Hyatt.
      
              wrong font size when css font-family includes monospace
              https://bugs.webkit.org/show_bug.cgi?id=19161
      
              Firefox only uses fixed-width default size for exactly "font-family: monospace;".
              WebKit has historically used fixed-width default size any time a
              font-family includes monospace in the fallback list.
      
              This patch corrects WebKit's behavior to match Firefox.
              I also had to fix a bug in WebKit's font-family fallback behavior where
              child elements would inherit parts of their parents fallback lists.
      
              This patch is mostly just replacing all cases where we used to check for:
              fontDescription.genericFontFamily() == MonospaceFamily
              with:
              fontDescription.useFixedDefaultSize()
      
              Tests: fast/css/getComputedStyle/computed-style-font-family-monospace.html
                     fast/css/getComputedStyle/font-family-fallback-reset.html
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
                 Deploy useFixedDefaultSize().  Also fix the bug where child
                 FontDescriptions would carry part of the parent font-family fallback list.
              (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
                 It's no longer alright to just check genericFontFamily(),
                 we have to check to make sure the changed style has a matching useFixedDefaultSize().
              * platform/graphics/FontDescription.h:
              (WebCore::FontDescription::useFixedDefaultSize):
                 Only use the fixed default size if we have one font family and it is "monospace".
                 "-webkit-monospace" is the internal representation of the CSS identifier "monospace".
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb50bc6d
    • sullivan@apple.com's avatar
      Unreviewed. · f2c85a08
      sullivan@apple.com authored
      Add myself to list of committers.
      
      * Scripts/modules/committers.py:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2c85a08
    • eric@webkit.org's avatar
      2009-08-13 Christian Plesner Hansen <christian.plesner.hansen@gmail.com> · add04d95
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              [v8] Fix atomic string externalization crash.
              Atomic string externalization assumes that all non-empty strings
              can be externalized which is untrue on 64-bit.  This change fixed
              that.
      
              https://bugs.webkit.org/show_bug.cgi?id=28215
      
              This bug causes loads of test crashes, no need to add new tests
              specifically for this.
      
              * bindings/v8/V8Binding.cpp:
              (WebCore::v8StringToAtomicWebCoreString):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      add04d95
    • hausmann@webkit.org's avatar
      Doc - Some cleanup on the documentation of QWebElement · 97d0693b
      hausmann@webkit.org authored
      Patch by Kavindra Devi Palaraja <kavindra.palaraja@nokia.com> on 2009-08-13
      Reviewed by Simon Hausmann.
      
      * Api/qwebelement.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97d0693b
    • mrowe@apple.com's avatar
      Use the version of operator new that takes a JSGlobalData when allocating... · ab647bef
      mrowe@apple.com authored
      Use the version of operator new that takes a JSGlobalData when allocating FuncDeclNode and FuncExprNode
      from within the grammar to prevent these nodes from being leaked.
      
      Rubber-stamped by Darin Adler.
      
      * parser/Grammar.y:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab647bef
    • eric@webkit.org's avatar
      2009-08-13 Eric Seidel <eric@webkit.org> · 3eee5483
      eric@webkit.org authored
              Correct spelling error in file name.  No review.
      
              * Scripts/modules/committers_unittest.py: Renamed from WebKitTools/Scripts/modules/commiters_unittest.py.
              * Scripts/run-webkit-unittests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3eee5483
    • eric@webkit.org's avatar
      2009-08-13 Eric Seidel <eric@webkit.org> · 3a640d6b
      eric@webkit.org authored
              Reviewed by Simon Fraser.
      
              REGRESSION(r47175): error running run-webkit-tests
              https://bugs.webkit.org/show_bug.cgi?id=28261
      
              Fix "Use of uninitialized value in concatenation (.) or string at
              WebKitTools/Scripts/run-webkit-tests line 191." by setting
              $testsPerDumpTool to 1000 by default.
      
              * Scripts/run-webkit-tests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a640d6b
    • staikos@webkit.org's avatar
      2009-08-13 George Staikos <george.staikos@torchmobile.com> · 3b2a1dad
      staikos@webkit.org authored
              Rubberstamped by Darin Adler.
      
              Use ASSERT_UNUSED instead of UNUSED_PARAM
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b2a1dad
    • eric@webkit.org's avatar
      2009-08-13 Steve Block <steveblock@google.com> · eefc1524
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Fixes a couple of bugs in SecurityOrigin::createFromDatabaseIdentifier.
              https://bugs.webkit.org/show_bug.cgi?id=28262
      
              No new tests possible.
      
              * page/SecurityOrigin.cpp:
              (WebCore::SecurityOrigin::createFromDatabaseIdentifier):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eefc1524
    • japhet@chromium.org's avatar
      2009-08-13 Nate Chapin <japhet@chromium.org> · 2486db6e
      japhet@chromium.org authored
              Unreviewed.
      
              Add myself to list of committers.
      
              * Scripts/modules/committers.py:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2486db6e
    • dbates@webkit.org's avatar
      2009-08-13 Daniel Bates <dbates@webkit.org> · 60c142cd
      dbates@webkit.org authored
              Unreviewed.
              
              Added 'Daniel Bates' (myself) to the list of committers.
              
              * Scripts/modules/committers.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47219 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60c142cd
    • bfulgham@webkit.org's avatar
      Unreviewed. · cf4e8edd
      bfulgham@webkit.org authored
      Add 'Brent Fulgham' to the committers list.
      
      * Scripts/modules/committers.py:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf4e8edd
    • yong.li@torchmobile.com's avatar
      2009-08-13 Yong Li <yong.li@torchmobile.com> · c5dc1a7a
      yong.li@torchmobile.com authored
          Unreviewed.
          Added 'Yong Li' to the committers list.
      
          * Scripts/modules/committers.py 
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5dc1a7a
    • agl@chromium.org's avatar
      2009-08-13 Adam Langley <agl@chromium.org> · 62b6c6a7
      agl@chromium.org authored
              Review not required.
      
              * Scripts/modules/committers.py:
                Adding myself to this list because Eric told me to.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62b6c6a7
    • bolsinga@apple.com's avatar
      Unreviewed. · 2db5ad06
      bolsinga@apple.com authored
      Add 'Greg Bolsinga' to the committers list.
      
      * Scripts/modules/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2db5ad06
    • aroben@apple.com's avatar
      Remove media/video-test.js's redundant hang timer · f8506800
      aroben@apple.com authored
      DRT already has a timer that does the same thing.
      
      Reviewed by Mark Rowe.
      
      * media/video-test.js: Remove the hang timer, since DRT does the same
      thing.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8506800
    • aroben@apple.com's avatar
      Fix off-by-one result comparisons in media tests on Windows Debug builds · 9e10438a
      aroben@apple.com authored
      media/video-played.html seems always to time out in Windows Debug
      builds. A race condition between media/video-test.js's "hang" timer and
      DumpRenderTree's built-in "watchdog" timer was causing results for
      media/video-played.html to be printed twice, causing all future media
      tests to be compared to the previous test's results.
      
      The fix is to make the watchdog timer got through the same code path
      as calling notifyDone manually, so that the results will only get
      printed once. A subsequent patch will remove video-test.js's hang
      timer entirely, since it is redundant.
      
      Fixes <http://webkit.org/b/28265>.
      
      Reviewed by Mark Rowe.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (LayoutTestController::waitToDumpWatchdogTimerFired): Added. Code came
      from Gtk/Mac/Win's watchdog timer handlers, but we now call
      notifyDone() instead of dump() so that a subsequent call to
      notifyDone() won't print the results out again.
      
      * DumpRenderTree/LayoutTestController.h: Added
      waitToDumpWatchdogTimerFired.
      
      * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
      (waitToDumpWatchdogFired):
      * DumpRenderTree/mac/LayoutTestControllerMac.mm:
      (waitUntilDoneWatchdogFired):
      * DumpRenderTree/win/LayoutTestControllerWin.cpp:
      (waitUntilDoneWatchdogFired):
      Changed to call waitToDumpWatchdogTimerFired.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e10438a
    • eric.carlson@apple.com's avatar
      Unreviewed. · 935bfb60
      eric.carlson@apple.com authored
              Added 'Eric Carlson' to the committers list.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      935bfb60
    • eric@webkit.org's avatar
      2009-08-13 Dirk Schulze <krit@webkit.org> · 601dd907
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [CAIRO] getImageData fails on a given rect bigger than the image rect
      
              The destination image and the source image was mixed up on creating the
              imageData.
      
              This is just a clean up and doesn't affect the current behavior. It's not
              possible to test this failure in a LayoutTest. Only canvas uses getImageData
              at the moment and returns before calling getImageData, if the image rect does
              not contain the requested rect.
      
              * platform/graphics/cairo/ImageBufferCairo.cpp:
              (WebCore::getImageData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      601dd907
    • krit@webkit.org's avatar
      2009-08-13 Dirk Schulze <krit@webkit.org> · 2d44227e
      krit@webkit.org authored
              Unreviewed.
              Added 'Dirk Schulze' to the committers list.
      
              * Scripts/modules/committers.py
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d44227e
    • bweinstein@apple.com's avatar
      2009-08-13 Brian Weinstein <bweinstein@apple.com> · 9f11a5a5
      bweinstein@apple.com authored
              Rubber-stamped by Adam Roben.
      
              Due to fixes in http://trac.webkit.org/changeset/47038 and http://trac.webkit.org/changeset/47163,
              fast/events/mouse-click-events.html now passes, removing it from Skipped List.
      
              * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f11a5a5
    • eric@webkit.org's avatar
      2009-08-13 Maxime Simon <simon.maxime@gmail.com> · 73422dbe
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Haiku] Adding RenderTheme to WebCore.
              https://bugs.webkit.org/show_bug.cgi?id=28258
      
              * platform/haiku/RenderThemeHaiku.cpp: Added.
              (WebCore::RenderThemeHaiku::create):
              (WebCore::RenderTheme::themeForPage):
              (WebCore::RenderThemeHaiku::RenderThemeHaiku):
              (WebCore::RenderThemeHaiku::~RenderThemeHaiku):
              (WebCore::supportsFocus):
              (WebCore::RenderThemeHaiku::supportsFocusRing):
              (WebCore::RenderThemeHaiku::platformActiveSelectionBackgroundColor):
              (WebCore::RenderThemeHaiku::platformInactiveSelectionBackgroundColor):
              (WebCore::RenderThemeHaiku::platformActiveSelectionForegroundColor):
              (WebCore::RenderThemeHaiku::platformInactiveSelectionForegroundColor):
              (WebCore::RenderThemeHaiku::platformTextSearchHighlightColor):
              (WebCore::RenderThemeHaiku::systemFont):
              (WebCore::RenderThemeHaiku::paintCheckbox):
              (WebCore::RenderThemeHaiku::setCheckboxSize):
              (WebCore::RenderThemeHaiku::paintRadio):
              (WebCore::RenderThemeHaiku::setRadioSize):
              (WebCore::RenderThemeHaiku::adjustMenuListStyle):
              (WebCore::RenderThemeHaiku::paintMenuList):
              * platform/haiku/RenderThemeHaiku.h: Added.
              (WebCore::RenderThemeHaiku::supportsHover):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73422dbe
    • kevino@webkit.org's avatar
      wx build fix. Make sure that the wxWebKit dynamic library is rebuilt whenever... · 0fa59a67
      kevino@webkit.org authored
      wx build fix. Make sure that the wxWebKit dynamic library is rebuilt whenever webcore or jscore libs change.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fa59a67
    • eric@webkit.org's avatar
      2009-08-13 Maxime Simon <simon.maxime@gmail.com> · 77d0ffff
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Haiku] Remove the "m_point" code from ContextMenuHaiku.cpp
              https://bugs.webkit.org/show_bug.cgi?id=28256
      
              * platform/haiku/ContextMenuHaiku.cpp:
              (WebCore::ContextMenuReceiver::ContextMenuReceiver):
              (WebCore::ContextMenu::ContextMenu):
              (WebCore::ContextMenu::appendItem):
              (WebCore::ContextMenu::insertItem):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77d0ffff
    • eric@webkit.org's avatar
      2009-08-13 Joseph Pecoraro <joepeck02@gmail.com> · 6f7b16d9
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Inspector: Show Hidden Cookie Data
              https://bugs.webkit.org/show_bug.cgi?id=28185
      
                Added new file Cookie.h to the WebCore XCode
      
              * WebCore.xcodeproj/project.pbxproj:
      
                InspectorController.cookies() binding
      
              * bindings/js/JSInspectorBackendCustom.cpp:
              (WebCore::JSInspectorBackend::cookies):
              * inspector/InspectorBackend.idl:
      
                Struct for static Cookie information
                (name, value, path, domain, expires, httpOnly, secure, session)
      
              * platform/Cookie.h: Added.
              (WebCore::Cookie::Cookie):
      
                Getter for the a list of raw Cookies
                getRawCookies(., ., out Vector<Cookie>)
      
              * platform/CookieJar.h:
      
                Implementation of getRawCookies for the mac platform.
      
              * platform/mac/CookieJar.mm:
              (WebCore::getRawCookies):
      
                Stub other CookieJar implementations to satisfy the interface.
      
              * platform/haiku/CookieJarHaiku.cpp:
              (WebCore::getRawCookies):
              * platform/network/chromium/CookieJarChromium.cpp:
              (WebCore::getRawCookies):
              * platform/network/curl/CookieJarCurl.cpp:
              (WebCore::getRawCookies):
              * platform/network/soup/CookieJarSoup.cpp:
              (WebCore::getRawCookies):
              * platform/network/win/CookieJarCFNetWin.cpp:
              (WebCore::getRawCookies):
              * platform/network/win/CookieJarWin.cpp:
              (WebCore::getRawCookies):
              * platform/qt/CookieJarQt.cpp:
              (WebCore::getRawCookies):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f7b16d9
    • eric@webkit.org's avatar
      2009-08-13 Steve Block <steveblock@google.com> · 696c41f8
      eric@webkit.org authored
              Reviewed by David Levin.
      
              Disables Geolocation 'enabled' test for GTK port, as the GTK Geolocation implementation is incomplete.
              https://bugs.webkit.org/show_bug.cgi?id=27716
      
              * platform/gtk/Skipped: Modified. Disables Geolocation 'enabled' test.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      696c41f8
    • eric@webkit.org's avatar
      2009-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 73e2fc5f
      eric@webkit.org authored
              Reviewed by Xan Lopez.
      
              [Gtk][REGRESSION] XHR test failures after r45558
              https://bugs.webkit.org/show_bug.cgi?id=27143
      
              Reenable the test that is fixed by this changeset.
      
              * platform/gtk/Skipped:
      
      2009-08-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
      
              Reviewed by Xan Lopez.
      
              [Gtk][REGRESSION] XHR test failures after r45558
              https://bugs.webkit.org/show_bug.cgi?id=27143
      
              Fix one of the regressions caused by the new sniffing code -
              disable sniffing when that behavior is explicitly requested.
      
              * platform/network/soup/ResourceHandleSoup.cpp:
              (WebCore::startHttp):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73e2fc5f
    • eric@webkit.org's avatar
      2009-08-13 Patrick Mueller <Patrick_Mueller@us.ibm.com> · 20e9a6e5
      eric@webkit.org authored
              Reviewed by Timothy Hatcher.
      
              Add a new gesture in Web Inspector to remove breakpoints
              https://bugs.webkit.org/show_bug.cgi?id=19131
      
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame.prototype._documentMouseDown):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20e9a6e5
    • eric@webkit.org's avatar
      2009-08-13 Norbert Leser <norbert.leser@nokia.com> · 22378fc0
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Symbian target components (library and executable files)
              require Unique Identifiers (i.e., UID3).
              These identifiers are defined in the respective project
              file, conditionally for "symbian" platform.
      
              * WebCore.pro:
      
      2009-08-13  Norbert Leser  <norbert.leser@nokia.com>
      
              Reviewed by Simon Hausmann.
      
              Symbian target components (library and executable files)
              require Unique Identifiers (i.e., UID3).
              These identifiers are defined in the respective project
              files, conditionally for "symbian" platform.
      
              * QtLauncher/QtLauncher.pro:
              * tests/qwebelement/qwebelement.pro:
              * tests/qwebframe/qwebframe.pro:
              * tests/qwebhistory/qwebhistory.pro:
              * tests/qwebhistoryinterface/qwebhistoryinterface.pro:
              * tests/qwebpage/qwebpage.pro:
              * tests/qwebview/qwebview.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22378fc0
    • eric@webkit.org's avatar
      2009-08-13 Shinichiro Hamaji <hamaji@chromium.org> · 4ab8f461
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              wrong calculation of overflow size for flexbox and table
              https://bugs.webkit.org/show_bug.cgi?id=28064
      
              RenderFlexibleBox and RenderTable were using the width of overflow
              to update height of overflow, so height became wrong value and
              width was not updated. As the corresponding code of RenderBlock
              was sane, I factored it out and used from RenderFlexibleBox and
              RenderTable.
      
              * fast/reflections/reflection-overflow-scroll-expected.txt:
              * fast/reflections/reflection-overflow-scroll.html:
              * fast/reflections/resources/reflection-overflow-scroll.js:
      
      2009-08-13  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Eric Seidel.
      
              wrong calculation of overflow size for flexbox and table
              https://bugs.webkit.org/show_bug.cgi?id=28064
      
              RenderFlexibleBox and RenderTable were using the width of overflow
              to update height of overflow, so height became wrong value and
              width was not updated. As the corresponding code of RenderBlock
              was sane, I factored it out and used from RenderFlexibleBox and
              RenderTable.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::updateOverflowWithShadowAndReflection): created from code of layoutBlock
              (WebCore::RenderBlock::layoutBlock):
              * rendering/RenderBlock.h:
              * rendering/RenderFlexibleBox.cpp: use updateOverflowWithShadowAndReflection
              (WebCore::RenderFlexibleBox::layoutBlock):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::layout): use updateOverflowWithShadowAndReflection
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ab8f461