GitLab

https://bugs.webkit.org/show_bug.cgi?id=112850

Reviewed by Andreas Kling.

Removes direct references to WebPageProxy from QQuickWebPage and prepares the
class for the move to QRawWebView. The access to the device scale factor and
CoordinatedGraphicsScene is provided through QQuickWebViewPrivate, and therefore
accessors to these properties are temporarily added. Eventually, this access will
be provided through QRawWebView when the move is complete.

This also moves the pointer to QtWebPageEventHandler from QQuickWebPagePrivate
to QQuickWebViewPrivate as it is mainly used from there.

* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::paint):
(QQuickWebPage::updatePaintNode):
* UIProcess/API/qt/qquickwebpage_p.h:
* UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::handleMouseEvent):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewPrivate::coordinatedGraphicsScene):
(QQuickWebViewPrivate::deviceScaleFactor):
(QQuickWebViewPrivate::setIntrinsicDeviceScaleFactor):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::itemChange):
(QQuickWebView::touchEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
* UIProcess/API/qt/qquickwebview_p_p.h:
(WebCore):
(WebKit):
(QQuickWebViewPrivate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=13709

Patch by Suchit Agrawal <a.suchit@samsung.com> on 2013-04-09
Reviewed by Antti Koivisto.

Source/WebCore:

Border issue is fixed when border width is less than 0.8pt

Border width is stored as unsigned. Border width (specified by
author) is converted into pixels and some times this pixel value
goes less than 1px. In this case, border width becomes 0px when
pixel value (double type) assigned to unsigned type.
Border width should not fall to 0px unless it is specified by
author.

Test: fast/borders/border-width-less-then-a-unit-of-pt.html

* css/StyleBuilder.cpp:
ApplyPropetyComputeLength class is replaced with 3 classes :
ApplyPropertyComputeBorderWidth, ApplyPropertyComputeTextSpacing
and ApplyPropertyComputeTransformOriginZ.

(WebCore::ApplyPropertyComputeBorderWidth::applyValue):
(WebCore::ApplyPropertyComputeBorderWidth::createHandler):
This class handles all width properties like border, outline,
etc. These all properties stores value in integer types.
Pixel value rounded of to 1px if value less than 1px and greater
than 0px.

(WebCore):
(ApplyPropertyComputeTextSpacing):
(WebCore::ApplyPropertyComputeTextSpacing::setValue):
(WebCore::ApplyPropertyComputeTextSpacing::applyValue):
(WebCore::ApplyPropertyComputeTextSpacing::createHandler):
This class handles all spacing properties like word-spacing,
letter-spacing etc.

(ApplyPropertyComputeTransformOriginZ):
(WebCore::ApplyPropertyComputeTransformOriginZ::setValue):
(WebCore::ApplyPropertyComputeTransformOriginZ::applyValue):
(WebCore::ApplyPropertyComputeTransformOriginZ::createHandler):
This class handles TransformOriginZ Property.

(WebCore::StyleBuilder::StyleBuilder):
ApplyProprtyComputeLength class usage changed with defined new
classes as per class definition.

LayoutTests:

This test file have border width, outline offset, outline width, border
spacing and column rule width properties test cases.
* fast/borders/border-width-less-then-a-unit-of-pt-expected.html: Added.
* fast/borders/border-width-less-then-a-unit-of-pt.html: Added.

Test case table/mozilla_expected_failures/bug89315.html need to do rebaseline
in efl, gtk and mac.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:

Updated the test result for table/mozilla_expected_failures/bug89315.html
Border is expected for table in test table/mozilla_expected_failures/bug89315.html
* platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
* tables/mozilla_expected_failures/bugs/bug89315-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114263

Unreviewed gardening.

Removed fast/events/autoscroll.html after r147830.
Unskip inspector/timeline/timeline-animation-frame.html that is now passing.

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-09

* platform/qt/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=112810

Reviewed by Andreas Kling.

Replace the direct reference to the WebPageProxy with use of
C API.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::setNavigatorQtObjectEnabled):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unskip some tests which have stopped crashing after r147759,
147933 and others.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/efl/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=112339

Reviewed by Andreas Kling.

Replaces the existing WebOpenPanelParameters::selectedFileNames() method
to return a copy of the selected file names and exposes it through the
C API. This is done in order to reduce the direct use of WebKit2 internal
classes. The implementation is very similar to the one in
WebOpenPanelParameters::acceptMIMETypes().

This also updates the GTK port, which is the other user of selectedFileNames.

* Shared/WebOpenPanelParameters.cpp:
(WebKit::WebOpenPanelParameters::selectedFileNames):
(WebKit):
* Shared/WebOpenPanelParameters.h:
(WebOpenPanelParameters):
* UIProcess/API/C/WKOpenPanelParameters.cpp:
(WKOpenPanelParametersCopySelectedFileNames):
* UIProcess/API/C/WKOpenPanelParameters.h:
* UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
(webkit_file_chooser_request_get_selected_files):
* UIProcess/qt/QtWebPageUIClient.cpp:
(WebKit::QtWebPageUIClient::runOpenPanel):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114250

Reviewed by Laszlo Gombos.

Use the #ifdef in the source file instead of conditional adding
files to the list of source files. This allows us to remove the
information of enabled features from CMake in next step.

* wtf/CMakeLists.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114258

Reviewed by Csaba Osztrogonác.

Build fix. Adding extra block statement to avoid error C2362 on WinCario

* platform/win/DragImageCairoWin.cpp:
(WebCore::createDragImageFromImage):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/gtk/TestExpectations: Adding failure expectations for two a11y tests that regressed with r147719.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://trac.webkit.org/changeset/147995
https://bugs.webkit.org/show_bug.cgi?id=114261

Wrong gardening. (Requested by gyuyoung on #webkit).


* platform/efl/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114234

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-04-09
Reviewed by Andreas Kling.

Fix build warnings -Wunused-parameter.

Source/WebCore:

* Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::openInMemory):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::CreateIndexAbortOperation::perform):
(WebCore::DeleteIndexAbortOperation::perform):
(WebCore::CreateObjectStoreAbortOperation::perform):
(WebCore::DeleteObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):
* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::decodeBool):
(WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
* Modules/indexeddb/IDBLevelDBCoding.h:
(WebCore::IDBLevelDBCoding::encodeIntSafely):
* bindings/js/IDBBindingUtilities.cpp:
(WebCore::canSet):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
* platform/leveldb/LevelDBDatabase.cpp:
(WebCore::ComparatorAdapter::FindShortestSeparator):
(WebCore::ComparatorAdapter::FindShortSuccessor):

Source/WebKit2:

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::SessionStorageNamespace::cloneTo):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::requestNetworkingStatistics):
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
* WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::removeItem):
(WebKit::StorageAreaProxy::clear):
(WebKit::StorageAreaProxy::dispatchSessionStorageEvent):
(WebKit::StorageAreaProxy::dispatchLocalStorageEvent):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::didUninstallPageOverlay):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didFinishLoad):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/gtk/TestExpectations: Marking a bunch of CSS layout tests as flaky timeouts,
most likely due to libsoup dependency bump.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=89875

Reviewed by Maciej Stachowiak.

.:

Added the bits to EFL/CMake buildsystem to find the libseccomp
library.

* Source/cmake/FindLibSeccomp.cmake: Added.
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/WebCore:

Make the DATA_DIR global since it is now needed for WebCore and WebKit2.
It is now used to set a sandbox policy for the EFL port.

* PlatformEfl.cmake:

Source/WebKit2:

Introduce the foundations of the SeccompFilter-based sandbox. The
hardening of the WebProcess (and potentially PluginProcess, etc)
works by a combination of the two things:

- Blocking syscalls that are not used, reducing the size of the attack
surface.
- Trapping sensitive syscalls and delegating the execution of these
syscalls to a separated trusted process subject to a set of policies.

The initial implementation traps the open()-family of syscalls on WebKit
EFL's and Qt's WebProcess, but it could be easily used by any Linux port,
since the code is suppose to be Linux-compliant. The list of syscalls handled
by the broker process should definitely grow as we mature the
implementation. Other syscalls needs to be handled to get this sandbox
fully functional, like unlink(), mkdir(), etc.

The broker process should be initialized as early as possible on the
sandboxed process main() function, because it only does a fork(), which
is cheap on Linux. That also aims to minimize the resident memory footprint
of the broker process.

Opening of files for upload and saving downloads is not supported yet,
since it should be handled to the UIProcess in a similar fashion as
the Mac port does.

* PlatformEfl.cmake:
* Shared/linux/SeccompFilters/OpenSyscall.cpp: Added.
(WebKit):
(WebKit::OpenSyscall::createFromOpenatContext):
(WebKit::OpenSyscall::createFromCreatContext):
(WebKit::OpenSyscall::OpenSyscall):
(WebKit::OpenSyscall::setResult):
(WebKit::OpenSyscall::execute):
(WebKit::OpenSyscall::encode):
(WebKit::OpenSyscall::decode):
(WebKit::OpenSyscallResult::OpenSyscallResult):
(WebKit::OpenSyscallResult::~OpenSyscallResult):
(WebKit::OpenSyscallResult::encode):
(WebKit::OpenSyscallResult::decode):
* Shared/linux/SeccompFilters/OpenSyscall.h: Added.
(CoreIPC):
(WebKit):
(OpenSyscall):
(WebKit::OpenSyscall::setPath):
(WebKit::OpenSyscall::setFlags):
(WebKit::OpenSyscall::setMode):
(OpenSyscallResult):
(WebKit::OpenSyscallResult::fd):
(WebKit::OpenSyscallResult::errorNumber):
* Shared/linux/SeccompFilters/SeccompBroker.cpp: Added.
(WebKit):
(SeccompBrokerClient):
(WebKit::sendMessage):
(WebKit::receiveMessage):
(WebKit::SIGSYSHandler):
(WebKit::registerSIGSYSHandler):
(WebKit::SeccompBrokerClient::shared):
(WebKit::SeccompBrokerClient::SeccompBrokerClient):
(WebKit::SeccompBrokerClient::~SeccompBrokerClient):
(WebKit::SeccompBrokerClient::dispatch):
(WebKit::SeccompBrokerClient::handleIfOpeningOnlineCPUCount):
(WebKit::SeccompBroker::launchProcess):
(WebKit::SeccompBroker::initialize):
(WebKit::SeccompBroker::runLoop):
* Shared/linux/SeccompFilters/SeccompBroker.h: Added.
(WebKit):
(SeccompBroker):
(WebKit::SeccompBroker::setSyscallPolicy):
(WebKit::SeccompBroker::SeccompBroker):
* Shared/linux/SeccompFilters/SeccompFilters.cpp: Added.
(WebKit):
(WebKit::SeccompFilters::SeccompFilters):
(WebKit::SeccompFilters::~SeccompFilters):
(WebKit::SeccompFilters::addRule):
(WebKit::SeccompFilters::initialize):
* Shared/linux/SeccompFilters/SeccompFilters.h: Added.
(WebKit):
(SeccompFilters):
(WebKit::SeccompFilters::context):
(WebKit::SeccompFilters::platformInitialize):
* Shared/linux/SeccompFilters/SigactionSyscall.cpp: Added.
(WebKit):
(WebKit::SigactionSyscall::createFromContext):
* Shared/linux/SeccompFilters/SigactionSyscall.h: Added.
(WebKit):
(SigactionSyscall):
* Shared/linux/SeccompFilters/SigprocmaskSyscall.cpp: Added.
(WebKit):
(WebKit::SigprocmaskSyscall::createFromContext):
* Shared/linux/SeccompFilters/SigprocmaskSyscall.h: Added.
(WebKit):
(SigprocmaskSyscall):
* Shared/linux/SeccompFilters/Syscall.cpp: Added.
(WebKit):
(WebKit::Syscall::createFromContext):
(WebKit::Syscall::createFromDecoder):
(WebKit::Syscall::Syscall):
(WebKit::SyscallResult::createFromDecoder):
(WebKit::SyscallResult::SyscallResult):
* Shared/linux/SeccompFilters/Syscall.h: Added.
(CoreIPC):
(WebKit):
(Syscall):
(WebKit::Syscall::~Syscall):
(WebKit::Syscall::type):
(WebKit::Syscall::setContext):
(WebKit::Syscall::context):
(SyscallResult):
(WebKit::SyscallResult::~SyscallResult):
(WebKit::SyscallResult::type):
* Shared/linux/SeccompFilters/SyscallPolicy.cpp: Added.
(WebKit):
(WebKit::removeTrailingSlash):
(WebKit::SyscallPolicy::hasPermissionForPath):
(WebKit::SyscallPolicy::addFilePermission):
(WebKit::SyscallPolicy::addDirectoryPermission):
(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):
* Shared/linux/SeccompFilters/SyscallPolicy.h: Added.
(WebKit):
(SyscallPolicy):
* Target.pri:
* WebKit2.pri:
* WebProcess/efl/SeccompFiltersWebProcessEfl.cpp: Added.
(WebKit):
(WebKit::SeccompFiltersWebProcessEfl::SeccompFiltersWebProcessEfl):
(WebKit::SeccompFiltersWebProcessEfl::platformInitialize):
* WebProcess/efl/SeccompFiltersWebProcessEfl.h: Added.
(WebKit):
(SeccompFiltersWebProcessEfl):
* WebProcess/qt/SeccompFiltersWebProcessQt.cpp: Added.
(WebKit):
(WebKit::SeccompFiltersWebProcessQt::SeccompFiltersWebProcessQt):
(WebKit::SeccompFiltersWebProcessQt::platformInitialize):
* WebProcess/qt/SeccompFiltersWebProcessQt.h: Added.
(WebKit):
(SeccompFiltersWebProcessQt):
* WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
* WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

Add unit tests to verify if the handling of the open, openat, creat syscall
is being done right. We check if the Read/Write/ReadAndWrite permissions
are respected, if the canonical path is being resolved and if
the permissions are falling back to the topmost parent directory with a
policy set when the directory being opened has no policy.

We also test if any attempt of blocking SIGSYS is silently ignored.
SIGSYS cannot be blocked because in it's handler is where we hook
syscalls to the broker process.

Also added libseccomp to EFL's jhbuild to make the life of developers
willing to help easier.

* Scripts/webkitperl/FeatureList.pm:
* TestWebKitAPI/PlatformEfl.cmake:
* TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
(TestWebKitAPI):
(SeccompEnvironment):
(TestWebKitAPI::SeccompEnvironment::SetUp):
(TestWebKitAPI::SeccompEnvironment::TearDown):
(TestWebKitAPI::dummyHandler):
(TestWebKitAPI::TEST):
(TestWebKitAPI::stressTest):
* efl/jhbuild.modules:
* qmake/mkspecs/features/features.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* Source/autotools/symbols.filter: Add some symbols that are
mangled differently in 32 bits due to size_t.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/gtk/TestExpectations:
* platform/gtk/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
* platform/gtk/fast/js/exception-linenums-in-html-3-expected.png: Removed.
* platform/gtk/fast/js/missing-style-end-tag-js-expected.png: Removed.
* platform/gtk/fast/text/international/003-expected.png:
* platform/gtk/fast/text/international/003-expected.txt:
* platform/gtk/fast/text/international/text-combine-image-test-expected.png: Added.
* platform/gtk/fast/text/international/text-combine-image-test-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

fast/dom/shadow/selections-in-shadow.html is passed on EFL layout test now.

* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113846

Reviewed by Alexey Proskuryakov.

Tools: 

The problem was that we were replacing NSSpellCheck's dictionary with our own
in DumpRenderTree but we were not adding necessary corrections to the dictionary.

Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
and "would" respectively in DumpRenderTree.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):

LayoutTests: 

Removed failing expectations from tests that require "mesage" to be corrected to "message".

Also modified to dynamically assert the marker positions so that we may catch regressions
without pixel results (we still dump pixel results via dumpAsText(true) for sanity check).

* platform/mac/TestExpectations:
* platform/mac/editing/spelling/autocorrection-contraction-expected.png:
* platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
* platform/mac/editing/spelling/click-autocorrected-word-expected.png:
* platform/mac/editing/spelling/click-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/click-autocorrected-word.html:
* platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
* platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/delete-into-autocorrected-word.html:
* platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png:
* platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html:
* platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png:
* platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html:
* platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png:
* platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html:
* platform/mac-wk2/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=112261

Reviewed by Anders Carlsson.

There's no need to call client's methods in TextCheckerEfl.cpp if they are not
implemented. Mark them as not implemented until we provide proper implementation.

* UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::checkGrammarOfString):
(WebKit::TextChecker::spellingUIIsShowing):
(WebKit::TextChecker::toggleSpellingUIIsShowing):
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
(WebKit::TextChecker::updateSpellingUIWithGrammarString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114243

Reviewed by Geoffrey Garen.

Setting the CMAKE_BUILD_TYPE causes some problem with Visual Studio.
Adopt the current usage of the variable to better CMake style.

* CMakeLists.txt:
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/OptionsEfl.cmake:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114248

Reviewed by Ryosuke Niwa.

* DumpRenderTree/DumpRenderTree.gyp: Removed.
* DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
* DumpRenderTree/DumpRenderTree.gypi: Removed.
* TestWebKitAPI/TestWebKitAPI.gyp: Removed.
* TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
* TestWebKitAPI/TestWebKitAPI.gypi: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114247

Reviewed by Benjamin Poulain.

* yarr/yarr.gyp: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114244

Rubberstamped by Ryosuke Niwa.

* gyp: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114245

Unreviewed. Just removing an empty directory.

* ANGLE.gyp: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114239

Reviewed by Benjamin Poulain.

* WebCore.gyp: Removed.
* WebCore.gyp/.gitignore: Removed.
* WebCore.gyp/ConvertFileToHeaderWithCharacterArray.gypi: Removed.
* WebCore.gyp/MakeNames.gypi: Removed.
* WebCore.gyp/WebCore.gyp: Removed.
* WebCore.gyp/mac: Removed.
* WebCore.gyp/mac/adjust_visibility.sh: Removed.
* WebCore.gyp/mac/check_objc_rename.sh: Removed.
* WebCore.gyp/scripts: Removed.
* WebCore.gyp/scripts/action_csspropertynames.py: Removed.
* WebCore.gyp/scripts/action_cssvaluekeywords.py: Removed.
* WebCore.gyp/scripts/action_derivedsourcesallinone.py: Removed.
* WebCore.gyp/scripts/action_makenames.py: Removed.
* WebCore.gyp/scripts/action_useragentstylesheets.py: Removed.
* WebCore.gyp/scripts/rule_bison.py: Removed.
* WebCore.gyp/scripts/supplemental_idl_files.py: Removed.
* WebCore.gypi: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114238

Reviewed by Benjamin Poulain.

* JavaScriptCore.gyp: Removed.
* JavaScriptCore.gyp/.gitignore: Removed.
* JavaScriptCore.gypi: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=104807

Patch by Vahag Vardanyan <vaag@ispras.ru> on 2013-04-08
Reviewed by Oliver Hunt.

Switch to using fromCharCode intrinsic instead of call operation in some cases.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileFromCharCode):
(DFG):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/StringConstructor.cpp:
(JSC::stringFromCharCode):
(JSC):
* runtime/StringConstructor.h:
(JSC):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=110087

Reviewed by Geoffrey Garen.

Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
Just run "svn log -r <revision>" instead to cut down the delay.

Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.

* Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot):
(NewCommitBot.next_work_item):
(NewCommitBot._is_empty_log):
(NewCommitBot._update_checkout):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114176

Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-04-08
Reviewed by Alexis Menard.

Source/WebCore:

Rolling out the patch for https://bugs.webkit.org/show_bug.cgi?id=74144 "[CSS Regions] Elements in a region
should be assignable to a named flow" because of the performance regression in Parser/html5-full-render.html .

No new tests (because this is a rollout patch).

* dom/Element.cpp:
* dom/Element.h:
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
* dom/NodeRenderingContext.h:
* dom/PseudoElement.h:
* dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
(WebCore::Text::updateTextRenderer):
* dom/Text.h:
* rendering/FlowThreadController.cpp:
* rendering/FlowThreadController.h:
* rendering/RenderObject.h:
* rendering/RenderRegion.h:
* svg/SVGElement.cpp:
* svg/SVGElement.h:

LayoutTests:

* fast/regions/flow-body-in-html-expected.txt: Removed.
* fast/regions/flow-body-in-html.html: Removed.
* fast/regions/region-content-flown-into-region-expected.html: Removed.
* fast/regions/region-content-flown-into-region.html: Removed.
* fast/regions/universal-selector-children-to-the-same-region-expected.txt: Removed.
* fast/regions/universal-selector-children-to-the-same-region.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(appendCustomBuildFlags):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113990

Reviewed by Benjamin Poulain.

Removed.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(InstallGtkDependencies):
(RunUnitTests.start):
(RunWebKit2Tests.start):
(Factory.__init__):
(unitTestsSupported):
(TestFactory.__init__):
(BuildAndTestFactory.__init__):
(BuildAndPerfTestFactory.__init__):
(BuildAndPerfTestWebKit2Factory.__init__):
(DownloadAndPerfTestFactory.__init__):
(loadBuilderConfig):
* BuildSlaveSupport/build.webkit.org-config/templates/root.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114237

Reviewed by Maciej Stachowiak.

* WTF.gyp: Removed.
* WTF.gyp/.gitignore: Removed.
* WTF.gyp/WTF.gyp: Removed.
* WTF.gypi: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114231

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore: 

* Configurations/FeatureDefines.xcconfig:

Source/WebCore: 

The feature is dead. It was only kept in the tree because of chromium.

* Configurations/FeatureDefines.xcconfig:
* Modules/notifications/Notification.cpp:
(WebCore):
(WebCore::Notification::Notification):
* Modules/notifications/Notification.h:
(Notification):
* Modules/notifications/NotificationCenter.h:
(NotificationCenter):
* Modules/notifications/NotificationCenter.idl:
* page/FeatureObserver.h:

Source/WebKit/blackberry: 

* WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/mac: 

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/qt: 

* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationClicked):
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
(WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
(WebCore::NotificationPresenterClientQt::dumpShowText):

Source/WebKit2: 

* Configurations/FeatureDefines.xcconfig:

Source/WTF: 

* wtf/FeatureDefines.h:

Tools: 

* qmake/mkspecs/features/features.pri:

LayoutTests: 

* fast/notifications/notifications-with-permission-expected.txt:
* fast/notifications/notifications-with-permission.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08

* platform/mac-wk2/TestExpectations:
The test destroy-during-async-npp-new.html has not crashed in a long time. Re-enable
it to see how the bots like it.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114226
<rdar://problem/13604480>

Reviewed by Darin Adler.

We don't need to trigger the timer to remove a snapshot
if there was never a snapshot displayed.

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::setDisplayState): Detect if we're moving from the DisplayingSnapshot state.
(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired): Guard against a missing renderer.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=109709

Reviewed by Darin Adler.

The data structure Vector in wtf/dtoa has nothing to do with a traditional
vector, is it just a pointer and the length of the pointed buffer.

Rename it to BufferReference to avoid mistakes.

* wtf/dtoa/bignum-dtoa.cc:
* wtf/dtoa/bignum-dtoa.h:
* wtf/dtoa/bignum.cc:
* wtf/dtoa/bignum.h:
(Bignum):
* wtf/dtoa/double-conversion.cc:
* wtf/dtoa/fast-dtoa.cc:
* wtf/dtoa/fast-dtoa.h:
* wtf/dtoa/fixed-dtoa.cc:
* wtf/dtoa/fixed-dtoa.h:
(double_conversion):
* wtf/dtoa/strtod.cc:
* wtf/dtoa/strtod.h:
(double_conversion):
* wtf/dtoa/utils.h:
(double_conversion):
(WTF::double_conversion::BufferReference::BufferReference):
(WTF::double_conversion::BufferReference::SubBufferReference):
(StringBuilder):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=108444

Reviewed by Darin Adler.

Image::loadPlatformResource("urlIcon") returns nothing
since r30961 on Windows which makes the code useless.

* loader/icon/IconDatabase.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/win/DragImageWin.cpp:
(WebCore::createDragImageIconForCachedImageFilename):
* WebKit.vcproj/WebKitExports.def.in:
* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114148

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-08
Reviewed by Darin Adler.

Add explicit conversions between LayoutUnit and int, and between
LayoutRect and IntRect.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::rectForNode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=112683

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-08
Reviewed by Darin Adler.

After calls to signbit and friends were prefixed with std:: in
r143232, the BlackBerry port no longer compiles.

The solution is to get rid of the macros defined in math.h and use
the real functions instead.

* wtf/MathExtras.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147972 268f45cc-cd09-0410-ab3c-d52691b4dbfc