1. 30 Mar, 2010 19 commits
    • eric@webkit.org's avatar
      2010-03-30 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 6dbc5923
      eric@webkit.org authored
              Reviewed by David Kilzer.
      
              Guard Geolocation files with ENABLE_GEOLOCATION
              https://bugs.webkit.org/show_bug.cgi?id=25756
      
              The intent is to guard the Geolocation implementation files
              and minimize the impact on on clients/call sites.
      
              * DerivedSources.make:
              * WebCore.Geolocation.exp: Added. Exported interfaces if GEOLOCATION
              is enabled.
              * WebCore.base.exp:
              * bindings/js/JSCustomPositionCallback.cpp:
              * bindings/js/JSCustomPositionErrorCallback.cpp:
              * bindings/js/JSGeolocationCustom.cpp:
              * page/Geolocation.cpp:
              (WebCore::Geolocation::disconnectFrame): Stub implementation if
              GEOLOCATION is turned off.
              (WebCore::Geolocation::Geolocation): Ditto.
              (WebCore::Geolocation::~Geolocation): Ditto.
              (WebCore::Geolocation::setIsAllowed): Ditto.
              * page/Geolocation.h:
              * page/Geolocation.idl:
              * page/GeolocationPositionCache.cpp:
              * page/Geoposition.idl:
              * page/PositionError.idl:
              * platform/GeolocationService.cpp:
              * platform/mock/GeolocationServiceMock.cpp:
      2010-03-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
      
              Reviewed by David Kilzer.
      
              Explicit guards for ENABLE_GEOLOCATION
              https://bugs.webkit.org/show_bug.cgi?id=25756
      
              * WebCoreSupport/WebGeolocationMock.mm:
              (-[WebGeolocationMock setError:code:]): Make the body conditional on
              ENABLE(GEOLOCATION)
              (-[WebGeolocationMock setPosition:]): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6dbc5923
    • eric@webkit.org's avatar
      2010-03-30 Andrey Kosyakov <caseq@chromium.org> · c79ba53e
      eric@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Support EventTarget interface in fake workers (both for Worker object
              and WorkerContext). Use MessagePort to implement message passing to
              support passing ports in PostMessage.
              https://bugs.webkit.org/show_bug.cgi?id=36763
      
              * inspector/front-end/InjectedFakeWorker.js:
              (InjectedFakeWorker.Worker.onmessageGetter):
              (InjectedFakeWorker.Worker.onmessageSetter):
              (InjectedFakeWorker.Worker):
              (InjectedFakeWorker.FakeWorker):
              (InjectedFakeWorker.FakeWorker.prototype.postMessage):
              (InjectedFakeWorker.FakeWorker.prototype.terminate):
              (InjectedFakeWorker.FakeWorker.prototype._onWorkerFrameLoaded):
              (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext.onmessageGetter):
              (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext.onmessageSetter):
              (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext):
              (InjectedFakeWorker.FakeWorker.prototype._addEventListener):
              (InjectedFakeWorker.FakeWorker.prototype._removeEventListener):
              (InjectedFakeWorker.FakeWorker.prototype._callbackWrapper):
              (InjectedFakeWorker.FakeWorker.prototype._handleException):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c79ba53e
    • apavlov@chromium.org's avatar
      2010-03-30 Alexander Pavlov <apavlov@chromium.org> · 3fe41104
      apavlov@chromium.org authored
              Unreviewed, test missing in r56732.
      
              * inspector/audits-panel-functional-expected.txt: Added.
              * inspector/audits-panel-functional.html: Added.
              * inspector/resources/audits-script1.js: Added.
              (foo1):
              * inspector/resources/audits-script2.js: Added.
              (foo2):
              * inspector/resources/audits-script3.js: Added.
              (foo3):
              * inspector/resources/audits-style1.css: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fe41104
    • benm@google.com's avatar
      [v8] Add if ENABLE guard for Worker specific code. · db2f50ef
      benm@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=36597
      
      Patch by Kristian Monsen <kristianm@google.com> on 2010-03-30
      Reviewed by David Levin.
      
      Build fix only, no new tests.
      
      * bindings/v8/V8DOMWrapper.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db2f50ef
    • jorlow@chromium.org's avatar
      2010-03-29 Jeremy Orlow <jorlow@chromium.org> · 2087744b
      jorlow@chromium.org authored
              Reviewed by Darin Fisher.
      
              More IndexedDB work
              https://bugs.webkit.org/show_bug.cgi?id=36770
      
              Add the "singleton" IndexedDatabase object to PageGroup
              IndexedDatabase now has a create() method since PageGroup can own the instance (at least for now)
              Rip out the IDBRequest stuff (now obsolete).
              DOMWindow now can instantiate indexedDatabase objects on demand.
      
              New layout tests starting with the next patch (which should make indexedDB.open() "work").
      
              * WebCore.gypi:
              * bindings/v8/custom/V8IDBRequestCustom.cpp: Removed.
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::indexedDB):
              * page/DOMWindow.h:
              * page/PageGroup.cpp:
              (WebCore::PageGroup::indexedDatabase):
              * page/PageGroup.h:
              * storage/IDBDatabase.cpp:
              * storage/IDBDatabaseRequest.h:
              (WebCore::IDBDatabaseRequest::createObjectStore):
              * storage/IDBDatabaseRequest.idl:
              * storage/IDBRequest.cpp: Removed.
              * storage/IDBRequest.h: Removed.
              * storage/IDBRequest.idl: Removed.
              * storage/IndexedDatabase.cpp:
              (WebCore::IndexedDatabase::create):
              * storage/IndexedDatabase.h:
              * storage/IndexedDatabaseImpl.cpp:
              (WebCore::IndexedDatabaseImpl::create):
              (WebCore::IndexedDatabaseImpl::IndexedDatabaseImpl):
              (WebCore::IndexedDatabaseImpl::~IndexedDatabaseImpl):
              * storage/IndexedDatabaseImpl.h:
              * storage/IndexedDatabaseRequest.cpp:
              (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest):
              * storage/IndexedDatabaseRequest.h:
              (WebCore::IndexedDatabaseRequest::create):
              * storage/IndexedDatabaseRequest.idl:
              * storage/chromium/IndexedDatabase.cpp:
              (WebCore::IndexedDatabase::create):
      2010-03-29  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Darin Fisher.
      
              More IndexedDB work
              https://bugs.webkit.org/show_bug.cgi?id=36770
      
              Start the implementation of WebIndexedDatabase (for entrance back into WebKit).
      
              * WebKit.gyp:
              * public/WebIndexedDatabase.h:
              * src/WebIndexedDatabaseImpl.cpp: Added.
              (WebKit::WebIndexedDatabase::create):
              (WebKit::WebIndexedDatabaseImpl::~WebIndexedDatabaseImpl):
              (WebKit::WebIndexedDatabaseImpl::open):
              * src/WebIndexedDatabaseImpl.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2087744b
    • krit@webkit.org's avatar
      2010-03-30 Dirk Schulze <krit@webkit.org> · 7905038b
      krit@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              SVG Glyph transformations wrong on use of SVGFont
              https://bugs.webkit.org/show_bug.cgi?id=36731
      
              Kerning on SVGFonts should be applied to the userSpace of the current Char
              and not to the userSpace of the viewport. This means scaling the kerning
              to match the current userSpace.
      
              Test: svg/custom/glyph-transformation-with-hkern.svg
      
              * rendering/SVGRootInlineBox.cpp:
              (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
      2010-03-30  Dirk Schulze  <krit@webkit.org>
      
              Reviewed by Nikolas Zimmermann.
      
              SVG Glyph transformations wrong on use of SVGFont
              https://bugs.webkit.org/show_bug.cgi?id=36731
      
              Test of correct scaled kerning, if userSpace on SVGFont doesn't
              match the scaling of the viewport userSpace.
      
              * platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
              * platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
              * svg/custom/glyph-transformation-with-hkern.svg: Added.
              * svg/custom/resources/SVGFreeSans.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7905038b
    • krit@webkit.org's avatar
      2010-03-30 Dirk Schulze <krit@webkit.org> · 2137447f
      krit@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              SVG Animation doesn't respect 'currentColor'
              https://bugs.webkit.org/show_bug.cgi?id=36695
      
              Test: svg/custom/animation-currentColor.svg
      
              SVG Animation can't handle currentColor at the moment. This patch catches the
              color value of the target element and replaces 'currentColor' with it's color string.
      
              * svg/SVGAnimationElement.cpp:
              (WebCore::adjustForCurrentColor):
              (WebCore::SVGAnimationElement::startedActiveInterval):
      2010-03-30  Dirk Schulze  <krit@webkit.org>
      
              Reviewed by Nikolas Zimmermann.
      
              SVG Animation doesn't respect 'currentColor'
              https://bugs.webkit.org/show_bug.cgi?id=36695
      
              Check if SVG animation takes the color value of the target element as 'currentColor'.
      
              * platform/mac/svg/custom/animation-currentColor-expected.checksum: Added.
              * platform/mac/svg/custom/animation-currentColor-expected.png: Added.
              * platform/mac/svg/custom/animation-currentColor-expected.txt: Added.
              * svg/custom/animation-currentColor.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2137447f
    • ukai@chromium.org's avatar
      2010-03-30 Fumitoshi Ukai <ukai@chromium.org> · 0825b63e
      ukai@chromium.org authored
              Reviewed by Shinichiro Hamaji.
      
              [Chromium-Win] subprocess.call should be called with stdin=open(os.devnull,'r')
              https://bugs.webkit.org/show_bug.cgi?id=36811
      
              subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
              We don't need stdin, so use devnull as stdin.
              Same as https://bugs.webkit.org/show_bug.cgi?id=36586
      
              * Scripts/webkitpy/layout_tests/port/chromium_win.py: open os.devnull for stdin
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0825b63e
    • yurys@chromium.org's avatar
      2010-03-30 Yury Semikhatsky <yurys@chromium.org> · 18aa2079
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Skip http/tests/inspector-enabled on Linux and Mac where LayoutTestContoller doesn't support inspector methods yet.
      
              https://bugs.webkit.org/show_bug.cgi?id=36807
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18aa2079
    • pfeldman@chromium.org's avatar
      2010-03-30 Ilya Tikhonovsky <loislo@chromium.org> · af654036
      pfeldman@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Visible/captured records counter should be implemented in Timeline panel.
              https://bugs.webkit.org/show_bug.cgi?id=36708
      
              * English.lproj/localizedStrings.js:
              * inspector/front-end/TimelinePanel.js:
              (WebInspector.TimelinePanel.prototype.get statusBarItems):
              (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
              (WebInspector.TimelinePanel.prototype._updateRecordsCounter):
              (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
              (WebInspector.TimelinePanel.prototype._createRootRecord):
              (WebInspector.TimelinePanel.prototype._refresh):
              (WebInspector.TimelinePanel.prototype._filterRecords):
              * inspector/front-end/inspector.css:
              (.timeline-records-counter):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af654036
    • levin@chromium.org's avatar
      [chromium] Many new test results are needed due to recent check-ins. · 4d66fe8b
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=36799
      
      Reviewed by Adam Barth.
      
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum: Due to r56655.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d66fe8b
    • philn@webkit.org's avatar
      2010-03-30 Philippe Normand <pnormand@igalia.com> · 20eb4ee9
      philn@webkit.org authored
              [GStreamer] define static variables with DEFINE_STATIC_LOCAL macro
              https://bugs.webkit.org/show_bug.cgi?id=36653
      
              Unreviewed, don't define the bool variable with
              DEFINE_STATIC_LOCAL, it makes sense only for objects which have a
              destructor. Thanks to Dan Bernstein for spotting this.
      
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::mimeTypeCache):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20eb4ee9
    • eric@webkit.org's avatar
      2010-03-29 Gyuyoung Kim <gyuyoung.kim@samsung.com> · 16b80cfb
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              There is a build break due to the disabled() when wml feature is
              enabled. This break comes from the Bug 35056 - Disabled menu options
              are still submitted.(https://bugs.webkit.org/show_bug.cgi?id=35056)
              The WMLOptionElement.h needs to define the disabled() as well.
              And, there is an additional break due to Bug 36177 -  Multiselect Popup
              - Listbox click simulation. (https://bugs.webkit.org/show_bug.cgi?id=36177)
              virtual void listBoxSelectItem() should be added to WMLSelectElement.h as well.
      
              https://bugs.webkit.org/show_bug.cgi?id=36698
      
              * wml/WMLOptionElement.h:
              (WebCore::WMLOptionElement::disabled):
              * wml/WMLSelectElement.h:
              (WebCore::WMLSelectElement::listBoxSelectItem):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16b80cfb
    • levin@chromium.org's avatar
      Rubber-stamped by Adam Barth. · 768c4f22
      levin@chromium.org authored
      Needed to fix test_expectations.txt for recent addition in r56764.
      
      * platform/chromium/test_expectations.txt: Added IMAGE (due to the results on OSX).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      768c4f22
    • alice.liu@apple.com's avatar
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: · 39e29cd0
      alice.liu@apple.com authored
      add JSObjectRefPrivate.h
      
      Reviewed by NOBODY (build fix).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39e29cd0
    • levin@chromium.org's avatar
      [chromium] Many new test results are needed due to recent check-ins. · ae8b4419
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=36799
      
      Reviewed by Shinichiro Hamaji.
      
      Various rebaselines due to changes in layout or new tests. The revision that caused
      each change is by the change.
      
      * platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum: Added. Due to r56655.
      * platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Added. Ditto.
      * platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1296-expected.txt.
      * platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum: Added. Ditto.
      * platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png: Added. Ditto.
      * platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1430-expected.txt.
      * platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.checksum: Added. Due to r56740.
      * platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.png: Added. Ditto.
      * platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.txt: Added. Ditto.
      * platform/chromium-win/svg/custom/marker-overflow-clip-expected.txt: Due to r56693.
      * platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum: Due to r56655.
      * platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Ditto.
      * platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum: Ditto.
      * platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png: Ditto.
      * platform/chromium/test_expectations.txt: Added a few failures with follow up bugs.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae8b4419
    • eric@webkit.org's avatar
      2010-03-29 Eric Seidel <eric@webkit.org> · 943c9196
      eric@webkit.org authored
              Unreviewed, build fix only.
      
              * Scripts/webkitpy/tool/steps/validatereviewer.py: Add missing import.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      943c9196
    • hamaji@chromium.org's avatar
      2010-03-29 Shinichiro Hamaji <hamaji@chromium.org> · a8012640
      hamaji@chromium.org authored
              Reviewed by David Hyatt.
      
              No vertical scrollbar after the CSS class change
              https://bugs.webkit.org/show_bug.cgi?id=36461
      
              * fast/repaint/overflow-scroll-body-appear.html: Added.
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/mac/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
              * platform/mac/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
              * platform/mac/fast/repaint/overflow-scroll-body-appear-expected.txt: Added.
              * platform/qt/Skipped:
              * platform/win/Skipped:
      2010-03-29  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by David Hyatt.
      
              No vertical scrollbar after the CSS class change
              https://bugs.webkit.org/show_bug.cgi?id=36461
      
              Don't suppress scrollbar change for non-first layouts.
              In the first layout, the scrollbar change will happen in later
              adjustViewSize() call, but in other layouts, adjustViewSize() may
              not be called when the size of contents doesn't change.
      
              * page/FrameView.cpp:
              (WebCore::FrameView::layout):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8012640
    • eric@webkit.org's avatar
      2010-03-29 Hayato Ito <hayato@chromium.org> · b5781a6d
      eric@webkit.org authored
              Reviewed by Shinichiro Hamaji.
      
              Remove '_flymake' suffix from base part of file name so that
              check-webkit-style uses a correct header guard name when it is called from Emacs's flymake.
      
              https://bugs.webkit.org/show_bug.cgi?id=36573
      
              * Scripts/webkitpy/style/processors/cpp.py:
              * Scripts/webkitpy/style/processors/cpp_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5781a6d
  2. 29 Mar, 2010 21 commits
    • eric@webkit.org's avatar
      2010-03-29 Chris Jerdonek <cjerdonek@webkit.org> · b48a90b5
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Get the following test-webkitpy unit test working again:
              scm_unittest.SVNTest.test_svn_apply().
      
              https://bugs.webkit.org/show_bug.cgi?id=36696
      
              * Scripts/webkitpy/common/checkout/scm_unittest.py:
                - Add leading spaces to the empty lines of the ChangeLog strings.
                - Manually set the _reviewer attribute on the Attachment object
                  to get the tests to pass.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b48a90b5
    • sfalken@apple.com's avatar
      2010-03-29 Steve Falkenburg <sfalken@apple.com> · 65733e82
      sfalken@apple.com authored
              Reviewed by Adele Peterson.
      
              Default value of accelerated compositing should be false for Windows
              https://bugs.webkit.org/show_bug.cgi?id=36805
      
              * WebPreferences.cpp:
              (WebPreferences::initializeDefaultSettings):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65733e82
    • mrobinson@webkit.org's avatar
      2010-03-29 Martin Robinson <mrobinson@webkit.org> · 8402eff0
      mrobinson@webkit.org authored
              Reviewed by Holger Freyther.
      
              [GTK] suppress (un)desired launcher output that can make layout test to fail with stderr
              https://bugs.webkit.org/show_bug.cgi?id=36390
      
              Suppress debugging messages sent to the GLib logger during DRT runs.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (logHandler): Added.
              (main): Use logHandler as the default GLib log message handler.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8402eff0
    • eric@webkit.org's avatar
      2010-03-29 Chao-ying Fu <fu@mips.com> · 69363ecb
      eric@webkit.org authored
              Reviewed by Oliver Hunt.
      
              MIPS JIT Supports
              https://bugs.webkit.org/show_bug.cgi?id=30144
      
              The following changes enable MIPS JIT.
      
              * assembler/MIPSAssembler.h:
              (JSC::MIPSAssembler::lbu):
              (JSC::MIPSAssembler::linkWithOffset):
              * assembler/MacroAssemblerMIPS.h:
              (JSC::MacroAssemblerMIPS::load8):
              (JSC::MacroAssemblerMIPS::branch8):
              (JSC::MacroAssemblerMIPS::branchTest8):
              (JSC::MacroAssemblerMIPS::setTest8):
              (JSC::MacroAssemblerMIPS::setTest32):
              * jit/JIT.h:
              * jit/JITInlineMethods.h:
              (JSC::JIT::preserveReturnAddressAfterCall):
              (JSC::JIT::restoreReturnAddressBeforeReturn):
              * jit/JITOpcodes.cpp:
              * jit/JITStubs.cpp:
              (JSC::JITThunks::JITThunks):
              * jit/JITStubs.h:
              (JSC::JITStackFrame::returnAddressSlot):
              * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69363ecb
    • levin@chromium.org's avatar
      [chromium] Many new test results are needed due to recent check-ins. · 9147aa11
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=36799
      
      Reviewed by Dimitri Glazkov.
      
      r56655 changed how tables layout which causes a lot of pixels tests for
      tables to need rebaselines.
      
      r56693 did some svg changes.
      
      * platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum: Due to r56655.
      * platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png: Ditto.
      * platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum: Ditto.
      * platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png: Ditto.
      * platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum: Ditto.
      * platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Ditto.
      * platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum: Ditto.
      * platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Ditto.
      * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum: Ditto.
      * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Ditto.
      * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum: Ditto.
      * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Ditto.
      * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum: Ditto.
      * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Ditto.
      * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum: Ditto.
      * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Ditto.
      * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum: Ditto.
      * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Ditto.
      * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum: Ditto.
      * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Ditto.
      * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum: Ditto.
      * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Ditto.
      * platform/chromium-win/svg/custom/invalid-css-expected.txt: Due to r56693.
      * platform/chromium-win/svg/custom/marker-default-width-height-expected.txt: Ditto.
      * platform/chromium-win/svg/custom/shapes-supporting-markers-expected.txt: Ditto.
      * platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum: Due to r56655.
      * platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png: Ditto.
      * platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum: Ditto.
      * platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png: Ditto.
      * platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum: Ditto.
      * platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Ditto.
      * platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum: Ditto.
      * platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum: Ditto.
      * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Ditto.
      * platform/chromium/test_expectations.txt: Two newly added tests are timing out (covered by http://crbug.com/35387).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9147aa11
    • eric@webkit.org's avatar
      2010-03-29 Chris Evans <cevans@chromium.org> · 3857e49b
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              * fast/xmlhttprequest/xmlhttprequest-no-file-access.html:
                Check that an isolated file:// origin can access about:blank iframes
                that it created itself.
      2010-03-29  Chris Evans  <cevans@chromium.org>
      
              Reviewed by Adam Barth.
      
              Don't use unique domains for file:// separation: it breaks local
              databases, and access to your own same-origin iframes. Instead, use
              path-based access checks.
      
              https://bugs.webkit.org/show_bug.cgi?id=36692
      
              Test: fast/xmlhttprequest/xmlhttprequest-no-file-access.html
      
              * dom/Document.cpp:
              (WebCore::Document::initSecurityContext): renamed API.
              * page/SecurityOrigin.h:
              * page/SecurityOrigin.cpp:
              (WebCore::SecurityOrigin::SecurityOrigin):
                Initialize new flag. Take note of file:// path.
                Copy new fields in copy constructor.
              (WebCore::SecurityOrigin::canAccess):
                Take into account path-based origin separation for file://
              (WebCore::SecurityOrigin::enforceFilePathSeparation):
                New method to enable file:// path origin separation.
              (WebCore::SecurityOrigin::toString):
                Return a null domain for an isolated file origin.
              (WebCore::SecurityOrigin::isSameSchemeHostPort):
                Take into account path-based origin separation for file://
              (WebCore::SecurityOrigin::passesFileCheck):
                Abstraction of common logic for file:// access checks.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3857e49b
    • eric@webkit.org's avatar
      2010-03-29 Rafael Weinstein <rafaelw@chromium.org> · e7fe0ccd
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Change NotificationPresenter::checkPermission() to take the source frames full KURL,
              rather than its SecurityOrigin. This will aid chromium in having more fine grained
              permissions to control notification spam.
      
              * notifications/Notification.cpp:
              (WebCore::Notification::Notification):
              * notifications/NotificationCenter.cpp:
              (WebCore::NotificationCenter::checkPermission):
              * notifications/NotificationPresenter.h:
      2010-03-29  Rafael Weinstein  <rafaelw@chromium.org>
      
              Reviewed by Adam Barth.
      
              Change NotificationPresenter::checkPermission() to take the source frames full KURL,
              rather than its SecurityOrigin. This will aid chromium in having more fine grained
              permissions to control notification spam.
      
              * public/WebNotificationPresenter.h:
              (WebKit::WebNotificationPresenter::checkPermission):
              * src/NotificationPresenterImpl.cpp:
              (WebKit::NotificationPresenterImpl::checkPermission):
              * src/NotificationPresenterImpl.h:
      2010-03-29  Rafael Weinstein  <rafaelw@chromium.org>
      
              Reviewed by Adam Barth.
      
              Change NotificationPresenter::checkPermission() to take the source frames full KURL,
              rather than its SecurityOrigin. This will aid chromium in having more fine grained
              permissions to control notification spam.
      
              * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
              (WebDesktopNotificationsDelegate::checkPermission):
              * WebCoreSupport/WebDesktopNotificationsDelegate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7fe0ccd
    • eric@webkit.org's avatar
      2010-03-29 Eric Seidel <eric@webkit.org> · bae552e3
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              sheriff-bot should comment on bugs when builders break
              https://bugs.webkit.org/show_bug.cgi?id=36786
      
              * Scripts/webkitpy/tool/commands/sheriffbot.py:
               - Add a new _post_blame_comment_to_bug and all it from process_work_item
               - Move commit-queue logic into _post_rollout_patch to make its api match the other _post commands.
              * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
               - Test the new _post_blame_comment_to_bug call
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bae552e3
    • eric@webkit.org's avatar
      2010-03-29 Eric Seidel <eric@webkit.org> · 84ce9f0f
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              sheriff-bot fails to get information about certain builds
              https://bugs.webkit.org/show_bug.cgi?id=36768
      
              This seems to be caused by:
              http://buildbot.net/trac/ticket/753
              I have no work-around, but for now at least we're logging
              the error better.  I also added allow_none to our ServerProxy
              creation in case that fixes things for other versions of python.
      
              * Scripts/webkitpy/common/net/buildbot.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84ce9f0f
    • eric@webkit.org's avatar
      2010-03-29 Victor Wang <victorw@chromium.org> · 97f1af60
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Add sign in/out link to TestResults appengine
      
              Add a link to main menu for sign in/out to this appengine.
              People signed in with admin privilege could perform
              actions that are only allowed to admins like deleting files.
      
              https://bugs.webkit.org/show_bug.cgi?id=36767
      
              * TestResultServer/handlers/menu.py:
              * TestResultServer/stylesheets/menu.css:
              (.sign):
              * TestResultServer/templates/menu.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97f1af60
    • eric@webkit.org's avatar
      2010-03-29 Luiz Agostini <luiz.agostini@openbossa.org> · 6d4160c9
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Multiselect - Adding method itemIsSelected() to QtAbstractWebPopup
              https://bugs.webkit.org/show_bug.cgi?id=36769
      
              Adding method itemIsSelected() to QtAbstractWebPopup.
      
              * platform/qt/QtAbstractWebPopup.h:
              (WebCore::QtAbstractWebPopup::itemIsSelected):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d4160c9
    • levin@chromium.org's avatar
      Rubber-stamped by Dmitry Titov. · 524e486f
      levin@chromium.org authored
      [Chromium] pixel layout test fixes.
      
      r56655 caused runin test which needed separate results for each platform.
      r56673 caused computed-style-expected.
      r56655 cause the fast/table changes (and we need linux specific results).
      r56644 caused clip-path-referencing-use2-expected.
      r56693 caused painting-marker-01-f-expected.
      
      * platform/chromium-linux/fast/runin/generated2-expected.checksum: Added.
      * platform/chromium-linux/fast/runin/generated2-expected.png: Added.
      * platform/chromium-linux/fast/runin/generated2-expected.txt: Added.
      * platform/chromium-linux/fast/runin/generated3-expected.checksum: Added.
      * platform/chromium-linux/fast/runin/generated3-expected.png: Added.
      * platform/chromium-linux/fast/runin/generated3-expected.txt: Added.
      * platform/chromium-linux/fast/runin/generated4-expected.checksum: Added.
      * platform/chromium-linux/fast/runin/generated4-expected.png: Added.
      * platform/chromium-linux/fast/runin/generated4-expected.txt: Added.
      * platform/chromium-linux/fast/table/table-background-expected.checksum: Added.
      * platform/chromium-linux/fast/table/table-background-expected.png: Added.
      * platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
      * platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
      * platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
      * platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
      * platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
      * platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
      * platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
      * platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
      * platform/chromium-linux/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
      * platform/chromium-linux/fast/table/table-cell-overrides-row-background-expected.png: Added.
      * platform/chromium-linux/fast/table/table-col-background-expected.checksum: Added.
      * platform/chromium-linux/fast/table/table-col-background-expected.png: Added.
      * platform/chromium-linux/fast/table/table-col-group-background-expected.checksum: Added.
      * platform/chromium-linux/fast/table/table-col-group-background-expected.png: Added.
      * platform/chromium-linux/fast/table/table-col-group-col-span-background-expected.checksum: Added.
      * platform/chromium-linux/fast/table/table-col-group-col-span-background-expected.png: Added.
      * platform/chromium-linux/fast/table/table-col-group-span-background-expected.checksum: Added.
      * platform/chromium-linux/fast/table/table-col-group-span-background-expected.png: Added.
      * platform/chromium-linux/fast/table/table-col-span-background-expected.checksum: Added.
      * platform/chromium-linux/fast/table/table-col-span-background-expected.png: Added.
      * platform/chromium-linux/fast/table/table-row-background-expected.checksum: Added.
      * platform/chromium-linux/fast/table/table-row-background-expected.png: Added.
      * platform/chromium-linux/fast/table/table-row-background-left-50px-expected.checksum: Added.
      * platform/chromium-linux/fast/table/table-row-background-left-50px-expected.png: Added.
      * platform/chromium-linux/fast/table/table-row-background-right-100percent-expected.checksum: Added.
      * platform/chromium-linux/fast/table/table-row-background-right-100percent-expected.png: Added.
      * platform/chromium-linux/fast/table/table-row-background-right-50px-expected.checksum: Added.
      * platform/chromium-linux/fast/table/table-row-background-right-50px-expected.png: Added.
      * platform/chromium-linux/fast/table/table-row-group-background-expected.checksum: Added.
      * platform/chromium-linux/fast/table/table-row-group-background-expected.png: Added.
      * platform/chromium-linux/fast/table/table-row-group-background-positioned-expected.checksum: Added.
      * platform/chromium-linux/fast/table/table-row-group-background-positioned-expected.png: Added.
      * platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-mac/fast/runin/generated2-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated2-expected.checksum.
      * platform/chromium-mac/fast/runin/generated2-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated2-expected.png.
      * platform/chromium-mac/fast/runin/generated3-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated3-expected.checksum.
      * platform/chromium-mac/fast/runin/generated3-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated3-expected.png.
      * platform/chromium-mac/fast/runin/generated4-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated4-expected.checksum.
      * platform/chromium-mac/fast/runin/generated4-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated4-expected.png.
      * platform/chromium-mac/svg/custom/clip-path-referencing-use2-expected.txt:
      * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-win/fast/runin/generated2-expected.checksum: Added.
      * platform/chromium-win/fast/runin/generated2-expected.png: Added.
      * platform/chromium-win/fast/runin/generated2-expected.txt: Added.
      * platform/chromium-win/fast/runin/generated3-expected.checksum: Added.
      * platform/chromium-win/fast/runin/generated3-expected.png: Added.
      * platform/chromium-win/fast/runin/generated3-expected.txt: Added.
      * platform/chromium-win/fast/runin/generated4-expected.checksum: Added.
      * platform/chromium-win/fast/runin/generated4-expected.png: Added.
      * platform/chromium-win/fast/runin/generated4-expected.txt: Added.
      * platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
      * platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
      * platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
      * platform/chromium-win/svg/custom/clip-path-referencing-use2-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      524e486f
    • eric@webkit.org's avatar
      2010-03-29 Dawit Alemayehu <adawit@kde.org> · d58b2bb8
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Added a function, WebCore::shouldTreatAsAttachment, to HTTPParsers.*
      
              https://bugs.webkit.org/show_bug.cgi?id=36395
      
              This function, which was moved from WebKit/chromium/src/FrameClientImpl.cpp,
              is used to check whether or not a request is supposed to be rendered or
              simply downloaded based on the "Content-Disposition" header sent by the
              web server. The intent of code refactoring is to avoid code duplication
              so that this piece of code can be used by other implementations such as
              QtWebKit.
      
              * platform/network/HTTPParsers.cpp:
              (WebCore::shouldTreatAsAttachment):
              * platform/network/HTTPParsers.h:
      2010-03-29  Dawit Alemayehu  <adawit@kde.org>
      
              Reviewed by Simon Hausmann.
      
              Factored out the 'ShouldTreatAsAttachment' function to HTTPParsers.*
              and replacted local version with the factored out version.
      
              The code was factored out to make possible its use in other implementations
              such as QtWebKit.
      
              * src/FrameLoaderClientImpl.cpp:
              (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):
      2010-03-29  Dawit Alemayehu  <adawit@kde.org>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Added support for handling the HTTP "Content-Disposition" header.
      
              https://bugs.webkit.org/show_bug.cgi?id=36395
      
              Whenever a server response contains a "Content-Disposition: attachment..." header,
              treat the request as a download and emit the unsupportedContent signal.
      
              * Api/qwebpage.cpp:
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::download):
              (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForMIMEType):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d58b2bb8
    • eric@webkit.org's avatar
      2010-03-29 Chris Fleizach <cfleizach@apple.com> · 53789c9a
      eric@webkit.org authored
              Reviewed by Beth Dakin.
      
              Bug 36735 - Live regions don't send out notifications when the element changing is the live region
              https://bugs.webkit.org/show_bug.cgi?id=36735
      
              * platform/mac/accessibility/aria-liveregion-on-image-expected.txt: Added.
              * platform/mac/accessibility/aria-liveregion-on-image.html: Added.
      2010-03-29  Chris Fleizach  <cfleizach@apple.com>
      
              Reviewed by Beth Dakin.
      
              Bug 36735 - Live regions don't send out notifications when the element changing is the live region
              https://bugs.webkit.org/show_bug.cgi?id=36735
      
              Test: platform/mac/accessibility/aria-liveregion-on-image.html
      
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::contentChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53789c9a
    • eric@webkit.org's avatar
      2010-03-29 Eric Seidel <eric@webkit.org> · 15aa73a2
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              ValidateReviewer step is draconian and un-tested
              https://bugs.webkit.org/show_bug.cgi?id=36792
      
              ValidateReviewer logic was commented out in
              http://trac.webkit.org/changeset/56744
              That was a symptom of the fact that validatereviewer.py
              is too inflexible to be used when real humans are driving webkit-patch.
              For now we just disable ValidateReviewer when humans are at the keyboard.
      
              * Scripts/webkitpy/tool/steps/validatereviewer.py:
               - Only run when in non-interactive mode.
              * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Added.
               - Test our validation logic to make sure it's sane.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15aa73a2
    • eric@webkit.org's avatar
      2010-03-29 Chris Jerdonek <cjerdonek@webkit.org> · 0d4eb7db
      eric@webkit.org authored
              Reviewed by Shinichiro Hamaji.
      
              Eliminate explicit slash characters from check-webkit-style's
              _rel_path() method to make its implementation more platform
              independent.
      
              https://bugs.webkit.org/show_bug.cgi?id=36759
      
              * Scripts/webkitpy/style/main.py:
                - Changed to use os.sep instead of slash_chars "/\\".  This can
                  be done since os.path.abspath() converts slashes to os.sep.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d4eb7db
    • dpranke@chromium.org's avatar
      2010-03-29 Dirk Pranke <dpranke@chromium.org> · d5d6f2b2
      dpranke@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Change new-run-webkit-tests to not use more than four threads by
              default on the mac port until
              https://bugs.webkit.org/show_bug.cgi?id=36622 is fixed.
      
              https://bugs.webkit.org/show_bug.cgi?id=36687
      
              * Scripts/webkitpy/layout_tests/port/mac.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5d6f2b2
    • dpranke@chromium.org's avatar
      2010-03-29 Dirk Pranke <dpranke@chromium.org> · 109c1b08
      dpranke@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Reformat port/mac.py to fit witin 80 columns for PEP-8 compliance.
      
              https://bugs.webkit.org/show_bug.cgi?id=36691
      
              * Scripts/webkitpy/layout_tests/port/mac.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      109c1b08
    • senorblanco@chromium.org's avatar
      2010-03-29 Stephen White <senorblanco@chromium.org> · 03de080c
      senorblanco@chromium.org authored
              Reviewed by Dave Hyatt.
      
              In order to speed up multiple calls to CSSPrimitiveValue::cssText(),
              this CL caches the String result.  When m_value is changed, the
              cached string is cleared.  This gives a good speedup on benchmarks
              which do a lot of CSS property gets, such as Peacekeeper.
              The processing cost should be negligible, since the strings are 
              refcounted.  The memory cost is an additional 4 bytes per
              CSSPrimitiveValue, and the extended lifetime of the computed string
              (potentially, the same as the lifetime of the CSSPrimitiveValue).
      
              https://bugs.webkit.org/show_bug.cgi?id=36556
      
              Covered by fast/css/cssText-cache.html, and more.
      
              * css/CSSPrimitiveValue.cpp:
              (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
              (WebCore::CSSPrimitiveValue::cleanup):
              (WebCore::CSSPrimitiveValue::cssText):
              * css/CSSPrimitiveValue.h:
      2010-03-29  Stephen White  <senorblanco@chromium.org>
      
              Reviewed by Dave Hyatt.
      
              Added a test for CSSPrimitiveValue::cssText() string cacheing.
      
              https://bugs.webkit.org/show_bug.cgi?id=36556
      
              * fast/css/cssText-cache-expected.txt: Added.
              * fast/css/cssText-cache.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03de080c
    • eric@webkit.org's avatar
      2010-03-29 Eric Seidel <eric@webkit.org> · 74007793
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              new-run-webkit-tests fails java/lc3 on a clean checkout
              https://bugs.webkit.org/show_bug.cgi?id=36078
      
              * Scripts/webkitpy/layout_tests/port/mac.py:
               - Build the java support files in check_build
               - Unwrap a line which would still fit under 80col
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74007793
    • bweinstein@apple.com's avatar
      Build Fix: Touch WebKit.idl to force Interfaces to rebuild · 775886a6
      bweinstein@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      775886a6