1. 04 Mar, 2008 1 commit
    • weinig@apple.com's avatar
      WebCore: · 6d270f6f
      weinig@apple.com authored
              Reviewed by Mark Rowe.
      
              Move JSClipboard into its own file.
      
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * bindings/js/JSAttrCustom.cpp:
              * bindings/js/JSClipboardCustom.cpp: Added.
              (WebCore::JSClipboard::types):
              (WebCore::JSClipboard::clearData):
              (WebCore::JSClipboard::getData):
              (WebCore::JSClipboard::setData):
              (WebCore::JSClipboard::setDragImage):
              * bindings/js/JSElementCustom.cpp:
              * bindings/js/JSEventCustom.cpp:
              * bindings/js/JSHTMLFrameElementCustom.cpp:
              * bindings/js/JSHTMLIFrameElementCustom.cpp:
              * bindings/js/kjs_events.cpp:
              * bindings/js/kjs_events.h:
              * bindings/js/kjs_window.cpp:
              * bindings/scripts/CodeGeneratorJS.pm:
              * dom/Clipboard.cpp:
              (WebCore::Clipboard::setDropEffect):
              (WebCore::Clipboard::setEffectAllowed):
              * dom/Clipboard.idl: Added.
      
      LayoutTests:
      
              Reviewed by Mark Rowe.
      
              Update test results.
      
              * fast/dom/Window/window-properties-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d270f6f
  2. 03 Mar, 2008 20 commits
    • weinig@apple.com's avatar
      GTK+ build fix. · b1f7256e
      weinig@apple.com authored
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::windowObjectCleared):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1f7256e
    • weinig@apple.com's avatar
      Windows build fix. · a14bdae4
      weinig@apple.com authored
              * WebFrame.cpp:
              (WebFrame::windowObjectCleared):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a14bdae4
    • weinig@apple.com's avatar
      Windows build-fix. · ab48efbb
      weinig@apple.com authored
              * page/Chrome.cpp:
              * plugins/win/PluginViewWin.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab48efbb
    • weinig@apple.com's avatar
      Reviewed by Darin Adler. · 5f38e1a6
      weinig@apple.com authored
              Cleanup and plumbing in preparation for the great Window split.
      
              - Rename KJS::Window to WebCore::JSDOMWindowBase.
              - Remove KJS::Window::retrieve() and KJS::Window::retrieveWindow() and replace
                with the new toJSDOMWindow().
              - Remove KJS::Window::retrieveActive() and replace with explicit call to 
                exec->dynamicGlobalObject() and toJSDOMWindow().
      
              * bindings/js/JSCustomVoidCallback.cpp:
              (WebCore::toVoidCallback):.
              * bindings/js/JSCustomXPathNSResolver.cpp:
              (WebCore::JSCustomXPathNSResolver::create):
              * bindings/js/JSDatabaseCustom.cpp:
              (WebCore::JSDatabase::changeVersion):
              (WebCore::JSDatabase::transaction):
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::location):
              (WebCore::toJS):
              * bindings/js/JSEventTargetBase.cpp:
              (WebCore::jsEventTargetAddEventListener):
              (WebCore::jsEventTargetRemoveEventListener):
              * bindings/js/JSEventTargetNode.cpp:
              (WebCore::JSEventTargetNode::setListener):
              * bindings/js/JSHTMLDocumentCustom.cpp:
              (WebCore::JSHTMLDocument::nameGetter):
              (WebCore::JSHTMLDocument::open):
              * bindings/js/JSHTMLFrameSetElementCustom.cpp:
              (WebCore::JSHTMLFrameSetElement::nameGetter):
              * bindings/js/JSLocation.cpp:
              (WebCore::JSLocation::put):
              (WebCore::jsLocationProtoFuncReplace):
              (WebCore::jsLocationProtoFuncReload):
              (WebCore::jsLocationProtoFuncAssign):
              * bindings/js/JSLocation.h:
              * bindings/js/JSSQLTransactionCustom.cpp:
              (WebCore::JSSQLTransaction::executeSql):
              * bindings/js/JSSVGLazyEventListener.cpp:
              (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener):
              (WebCore::JSSVGLazyEventListener::eventParameterName):
              * bindings/js/JSSVGLazyEventListener.h:
              * bindings/js/JSXMLHttpRequest.cpp:
              (WebCore::JSXMLHttpRequest::putValueProperty):
              (WebCore::jsXMLHttpRequestPrototypeFunctionOpen):
              (WebCore::jsXMLHttpRequestPrototypeFunctionAddEventListener):
              (WebCore::jsXMLHttpRequestPrototypeFunctionRemoveEventListener):
              * bindings/js/ScheduledAction.cpp:
              (WebCore::ScheduledAction::execute):
              * bindings/js/ScheduledAction.h:
              * bindings/js/kjs_binding.cpp:
              (WebCore::allowsAccessFromFrame):
              (WebCore::printErrorMessageForFrame):
              * bindings/js/kjs_events.cpp:
              (WebCore::JSAbstractEventListener::handleEvent):
              (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
              (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
              (WebCore::JSUnprotectedEventListener::windowObj):
              (WebCore::JSEventListener::JSEventListener):
              (WebCore::JSEventListener::~JSEventListener):
              (WebCore::JSEventListener::windowObj):
              (WebCore::JSLazyEventListener::JSLazyEventListener):
              (WebCore::JSLazyEventListener::parseCode):
              * bindings/js/kjs_events.h:
              * bindings/js/kjs_navigator.cpp:
              (WebCore::MimeType::getValueProperty):
              * bindings/js/kjs_proxy.cpp:
              (WebCore::KJSProxy::evaluate):
              (WebCore::KJSProxy::createHTMLEventHandler):
              (WebCore::KJSProxy::createSVGEventHandler):
              * bindings/js/kjs_window.cpp:
              (WebCore::JSDOMWindowBasePrivate::JSDOMWindowBasePrivate):
              (WebCore::DOMWindowTimer::DOMWindowTimer):
              (WebCore::DOMWindowTimer::action):
              (WebCore::DOMWindowTimer::takeAction):
              (WebCore::):
              (WebCore::JSDOMWindowBase::JSDOMWindowBase):
              (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
              (WebCore::JSDOMWindowBase::location):
              (WebCore::JSDOMWindowBase::mark):
              (WebCore::allowPopUp):
              (WebCore::createWindow):
              (WebCore::showModalDialog):
              (WebCore::JSDOMWindowBase::getValueProperty):
              (WebCore::JSDOMWindowBase::childFrameGetter):
              (WebCore::JSDOMWindowBase::indexGetter):
              (WebCore::JSDOMWindowBase::namedItemGetter):
              (WebCore::JSDOMWindowBase::getOwnPropertySlot):
              (WebCore::JSDOMWindowBase::put):
              (WebCore::JSDOMWindowBase::allowsAccessFrom):
              (WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage):
              (WebCore::JSDOMWindowBase::allowsAccessFromPrivate):
              (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
              (WebCore::JSDOMWindowBase::printErrorMessage):
              (WebCore::JSDOMWindowBase::globalExec):
              (WebCore::JSDOMWindowBase::shouldInterruptScript):
              (WebCore::JSDOMWindowBase::setListener):
              (WebCore::JSDOMWindowBase::getListener):
              (WebCore::JSDOMWindowBase::findJSEventListener):
              (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
              (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener):
              (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
              (WebCore::JSDOMWindowBase::clearHelperObjectProperties):
              (WebCore::JSDOMWindowBase::clear):
              (WebCore::JSDOMWindowBase::setCurrentEvent):
              (WebCore::JSDOMWindowBase::currentEvent):
              (WebCore::windowProtoFuncAToB):
              (WebCore::windowProtoFuncBToA):
              (WebCore::windowProtoFuncOpen):
              (WebCore::windowProtoFuncSetTimeout):
              (WebCore::windowProtoFuncClearTimeout):
              (WebCore::windowProtoFuncSetInterval):
              (WebCore::windowProtoFuncAddEventListener):
              (WebCore::windowProtoFuncRemoveEventListener):
              (WebCore::windowProtoFuncShowModalDialog):
              (WebCore::windowProtoFuncNotImplemented):
              (WebCore::JSDOMWindowBase::setReturnValueSlot):
              (WebCore::JSDOMWindowBase::clearAllTimeouts):
              (WebCore::JSDOMWindowBase::installTimeout):
              (WebCore::JSDOMWindowBase::pauseTimeouts):
              (WebCore::JSDOMWindowBase::resumeTimeouts):
              (WebCore::JSDOMWindowBase::clearTimeout):
              (WebCore::JSDOMWindowBase::timerFired):
              (WebCore::JSDOMWindowBase::disconnectFrame):
              (WebCore::JSDOMWindowBase::jsEventListeners):
              (WebCore::JSDOMWindowBase::jsHTMLEventListeners):
              (WebCore::JSDOMWindowBase::jsUnprotectedEventListeners):
              (WebCore::JSDOMWindowBase::jsUnprotectedHTMLEventListeners):
              (WebCore::toJS):
              (WebCore::toJSDOMWindow):
              (WebCore::toJSDOMWindow):
              * bindings/js/kjs_window.h:
              (WebCore::JSDOMWindowBase::impl):
              (WebCore::JSDOMWindowBase::classInfo):
              (WebCore::JSDOMWindowBase::):
              * bindings/objc/DOMUtility.mm:
              (KJS::createDOMWrapper):
              * bindings/scripts/CodeGeneratorJS.pm:
              * history/CachedPage.cpp:
              (WebCore::CachedPage::CachedPage):
              (WebCore::CachedPage::restore):
              * page/Chrome.cpp:
              (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
              (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
              * page/DOMWindow.idl:
              * page/Frame.cpp:
              (WebCore::Frame::~Frame):
              (WebCore::Frame::windowScriptNPObject):
              (WebCore::Frame::pageDestroyed):
              * page/InspectorController.cpp:
              (WebCore::inspectedWindow):
              * page/mac/FrameMac.mm:
              (WebCore::Frame::windowScriptObject):
              * page/mac/WebCoreFrameBridge.mm:
              (updateRenderingForBindings):
              * platform/SecurityOrigin.cpp:
              (WebCore::SecurityOrigin::canAccess):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f38e1a6
    • oliver@apple.com's avatar
      Make ForInNode check for the timeout interrupt · 71d3a95e
      oliver@apple.com authored
      Reviewed by Anders
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71d3a95e
    • kevino@webkit.org's avatar
      wx build fixes after recent Frame-related changes. · 0840d06b
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0840d06b
    • mitz@apple.com's avatar
      WebCore: · c76605ad
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - make :first-letter apply to the first letter in normal flow, skipping
                floats and positioned objects
      
              Test: fast/css/first-letter-skip-out-of-flow.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::updateFirstLetter):
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test that :first-letter applies to the first letter in normal flow,
                skipping floats and positioned objects
      
              * fast/css/first-letter-skip-out-of-flow.html: Added.
              * platform/mac-leopard/fast/css/first-letter-skip-out-of-flow-expected.checksum: Added.
              * platform/mac-leopard/fast/css/first-letter-skip-out-of-flow-expected.png: Added.
              * platform/mac/fast/css/first-letter-skip-out-of-flow-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c76605ad
    • adachan@apple.com's avatar
      Fix build. · 31f4ae60
      adachan@apple.com authored
              * plugins/win/PluginViewWin.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31f4ae60
    • mrowe@apple.com's avatar
      2008-03-03 Mark Rowe <mrowe@apple.com> · 45e6a3fa
      mrowe@apple.com authored
              Reviewed by Dan Bernstein.
      
              Fix http://bugs.webkit.org/show_bug.cgi?id=17313
              Bug 17313: querySelectorAll() causing crashes when called via dojo.query() wrapper
      
              Node::querySelector and SelectorNodeList were not sufficiently initializing the CSSStyleSelector
              before using it to resolve styles, which lead to it having a stale m_style member in some situations.
              This stale m_style member resulted in a wild store that would write over whatever object now resided
              at the location m_style pointed to.
      
              Test: fast/dom/SelectorAPI/bug-17313.html
      
              * dom/Node.cpp:
              (WebCore::Node::querySelector): Call initForStyleResolve to further initialize the CSSStyleSelector.
              * dom/SelectorNodeList.cpp:
              (WebCore::SelectorNodeList::SelectorNodeList): Ditto.
      
      2008-03-03  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Test for http://bugs.webkit.org/show_bug.cgi?id=17313
              Bug 17313: querySelectorAll() causing crashes when called via dojo.query() wrapper
      
              * fast/dom/SelectorAPI/bug-17313-expected.txt: Added.
              * fast/dom/SelectorAPI/bug-17313.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45e6a3fa
    • alp@webkit.org's avatar
      2008-03-03 Brent Fulgham <bfulgham@gmail.com> · c1c99561
      alp@webkit.org authored
              Reviewed by Alp Toker.
      
              http://bugs.webkit.org/show_bug.cgi?id=17644
              Build GTK on Mac OS X using native ICU library
      
              Use Apple native ICU libraries when building GTK
              webkit on Mac OS.
      
              * configure.ac:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1c99561
    • andersca@apple.com's avatar
      Reviewed by Darin and Sam. · ae3f8c23
      andersca@apple.com authored
              Include fixes, in preparation of using the headers in WebCore/bridge.
              
              * bindings/js/kjs_binding.h:
              * bindings/js/kjs_dom.cpp:
              * bindings/objc/DOMInternal.mm:
              * bindings/objc/DOMUtility.mm:
              * bindings/objc/WebScriptObject.mm:
              * bindings/objc/WebScriptObjectPrivate.h:
              * bridge/objc/objc_class.h:
              * bridge/objc/objc_instance.h:
              * bridge/objc/objc_runtime.h:
              * bridge/objc/objc_utility.h:
              * bridge/runtime.h:
              * bridge/runtime_object.h:
              * bridge/runtime_root.h:
              * html/HTMLAppletElement.cpp:
              * html/HTMLAppletElement.h:
              * html/HTMLEmbedElement.cpp:
              * html/HTMLEmbedElement.h:
              * html/HTMLObjectElement.cpp:
              * html/HTMLPlugInElement.cpp:
              * html/HTMLPlugInElement.h:
              * page/mac/FrameMac.mm:
              * page/mac/WebCoreFrameBridge.h:
              * page/mac/WebCoreFrameBridge.mm:
              * page/mac/WebCoreScriptDebugger.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae3f8c23
    • hyatt@apple.com's avatar
      WebCore: · e47e8e90
      hyatt@apple.com authored
              Full page zoom plumbing.  Add a notion of whether or not a zoom is text only or a full zoom to the
              Frame.  setTextSizeMultiplier does a text only zoom.
      
              Reviewed by Tim H.
      
              * page/Frame.cpp:
              (WebCore::Frame::zoomFactor):
              (WebCore::Frame::isZoomFactorTextOnly):
              (WebCore::Frame::setZoomFactor):
              (WebCore::FramePrivate::FramePrivate):
              * page/Frame.h:
              * page/FramePrivate.h:
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge setTextSizeMultiplier:]):
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::setCurrentScale):
      
      WebKit/win:
      
              Full page zoom work.  Make setting of a zoom factor take a boolean saying whether it is a text only
              or full page zoom.
      
              Reviewed by Tim H.
      
              * WebFrame.cpp:
              (WebFrame::setTextSizeMultiplier):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e47e8e90
    • alp@webkit.org's avatar
      2008-03-03 Alp Toker <alp@atoker.com> · 4eac548b
      alp@webkit.org authored
              Fix the GTK+ build following breakage introduced in r30712.
      
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::imContextCommitted):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4eac548b
    • hyatt@apple.com's avatar
      Fix for <rdar://problem/5776161> REGRESSION: Google Docs Spreadsheet crash · 43b74397
      hyatt@apple.com authored
              This is also http://bugs.webkit.org/show_bug.cgi?id=17543, fixed table layout corrupts heap.
      
              Make sure not to access position -1 of the size 0 vectors.
      
              Reviewed by ggaren
      
              * rendering/FixedTableLayout.cpp:
              (WebCore::FixedTableLayout::layout):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43b74397
    • ddkilzer@apple.com's avatar
      WebCore: · a75202e1
      ddkilzer@apple.com authored
              Dynamically inserting CSS rule with @media query fails with DOM Exception 12
              <http://bugs.webkit.org/show_bug.cgi?id=15986>
      
              Reviewed by Darin.
      
              Allow any valid rule (@font-face, @import, @media, @page or style) to be
              parsed when using CSSStyleSheet.insertRule().  Previously only import and
              style rules were allowed.  Note that @page rules always throw an exception
              because they're not implemented yet, so no test case was added for them.
      
              Tests: fast/css/insertRule-font-face.html
                     fast/css/insertRule-media.html
      
              * css/CSSGrammar.y: Extracted 'valid_rule' out of 'rule'.  Renamed
              'ruleset_or_import' to 'valid_rule_or_import' and changed its definition.
      
      LayoutTests:
      
              Dynamically inserting CSS rule with @media query fails with DOM Exception 12
              <http://bugs.webkit.org/show_bug.cgi?id=15986>
      
              Reviewed by Darin.
      
              * fast/css/insertRule-font-face.html: Added.
              * fast/css/insertRule-media.html: Added.
              * fast/css/resources/insertRule-font-face.js: Added.
              * fast/css/resources/insertRule-media.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a75202e1
    • andersca@apple.com's avatar
      Reviewed by Sam. · 1408e7d8
      andersca@apple.com authored
              Copy JSC bindings directory over to WebCore/bridge.
      
              * bridge: Copied from ../JavaScriptCore/bindings.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1408e7d8
    • mitz@apple.com's avatar
      Reviewed by Darin Adler. · 2c4e9efb
      mitz@apple.com authored
              - remove CSSMutableStyleDeclaration::setChanged()'s change type
                parameter
      
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::setChanged): Removed the change
              type parameter and made this function determine the correct change type
              based on whether this is an inline style declaration.
              (WebCore::CSSMutableStyleDeclaration::setProperty):
              * css/CSSMutableStyleDeclaration.h:
              (WebCore::CSSMutableStyleDeclaration::clear): Removed this unused
              method.
              (WebCore::CSSMutableStyleDeclaration::setChanged): Made private.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c4e9efb
    • darin@apple.com's avatar
      WebCore: · 1b2dbf31
      darin@apple.com authored
              Reviewed by Adam.
      
              - some "cleanup" on the path to removing WebCoreFrameBridge
      
              * WebCore.base.exp: Exported some stuff we either already use or
              I am about to use in an upcoming patch.
      
              * WebCore.xcodeproj/project.pbxproj: Made FileChooser.h private rather
              than project, for future use in WebKit.
      
              * bindings/objc/WebScriptObject.mm: Removed some dead code.
      
              * dom/ContainerNode.cpp: Added a now-needed or soon-to-be-needed include.
              * editing/Editor.cpp: Ditto.
      
              * editing/Editor.h: Removed many unneeded declarations and includes.
              Removed the unused userVisibleString function.
      
              * editing/EditorCommand.cpp:
              (WebCore::executeYank): Added parameter for triggeringEvent, which no
              longer has a default value.
              (WebCore::executeYankAndSelect): Ditto.
      
              * editing/mac/EditorMac.mm: Removed userVisibleString.
      
              * page/mac/EventHandlerMac.mm:
              (WebCore::isKeyboardOptionTab): Tweaked formattin.
      
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge dragSourceMovedTo:]): Get window from -[NSView window]
              rather than from the bridge. There's no special value in the bridge's window
              method and we can use NSView directly.
              (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): Ditto.
      
              * platform/graphics/mac/ImageMac.mm:
              (WebCore::Image::loadPlatformResource): Use a new WebCoreBundleFinder class to
              find the bundle rather than using WebCoreFrameBridge.
      
              * platform/mac/ClipboardMac.mm: Added a now-needed or soon-to-be-needed include.
              * platform/mac/PasteboardMac.mm: Ditto.
      
              * rendering/RenderObject.h:
              (WebCore::DashboardRegionValue::operator==): Fixed mistake where this wasn't
              comparing the clip rectangle.
              (WebCore::DashboardRegionValue::operator!=): Added. Needed by my future work.
      
      WebKit/mac:
      
              Reviewed by Adam.
      
              - some "cleanup" on the path to removing WebCoreFrameBridge
      
              * Storage/WebDatabaseManager.mm: Tweak includes.
              * Storage/WebDatabaseTrackerClient.mm: Ditto.
              * Storage/WebSecurityOrigin.mm: Ditto.
              * Storage/WebSecurityOriginInternal.h: Ditto.
      
              * WebView/WebFrame.mm:
              (core): Changed to get rid of the requirement that WebKitEditableLinkBehavior exactly
              match WebCore::EditableLinkBehavior.
              * WebView/WebFrameInternal.h: Removed unused kit function.
      
              * WebView/WebHTMLView.mm: Moved WebHTMLViewPrivate class in here.
              * WebView/WebHTMLViewInternal.h: Moved WebHTMLVewPrivate class out of here.
              * WebView/WebHTMLViewPrivate.h: Tweaked formatting and removed some unneeded declarations.
      
              * WebView/WebPreferencesPrivate.h: Removed a no-longer-needed comment.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30712 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b2dbf31
    • oliver@apple.com's avatar
      Bug 17620: getImageData lies · 350652b5
      oliver@apple.com authored
      http://bugs.webkit.org/show_bug.cgi?id=17620
      
      Reviewed by Mark Rowe
      
      Correct logic to actually iterate over the source row
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      350652b5
    • oliver@apple.com's avatar
      Correct incorrect assertion · 7babd229
      oliver@apple.com authored
      Reviewed by Mark Rowe
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7babd229
  3. 02 Mar, 2008 9 commits
  4. 01 Mar, 2008 6 commits
    • oliver@apple.com's avatar
      Bug 16954: Support putImageData · 18ed29dc
      oliver@apple.com authored
      Reviewed by Sam Weinig.
      
      Implement support for HTML5's putImageData for the CG port.  All other ports
      are currently just using stubs for the final blit.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18ed29dc
    • kevino@webkit.org's avatar
      Typo fix. · c6ec2400
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6ec2400
    • jhoneycutt@apple.com's avatar
      2008-03-01 Jon Honeycutt <jhoneycutt@apple.com> · 9cb630a8
      jhoneycutt@apple.com authored
              Reviewed by Darin.
      
              <rdar://problem/5772987> Crashing viewing page with two VLC plug-in
              instances
      
              The VLC Netscape plug-in crashes if more than one instance is created.
      
              Added a quirk that disallows a plug-in from having more than one
              instance and set this for the VLC plug-in.
      
              In addition, we now sort plug-ins that handle the same MIME
              type to choose the most appropriate one. This sorting first sorts by
              whether a plug-in has an issue that should put it at the end of the
              list, then whether it appears in a "preferred" plug-in directory.
      
              * plugins/PluginQuirkSet.h: Added PluginQuirkDontAllowMultipleInstances.
              * plugins/PluginDatabase.cpp:
              (WebCore::PluginDatabase::preferredPluginCompare): Comparator for
              sorting plug-ins; calls PluginPackage::compare().
              (WebCore::PluginDatabase::pluginForMIMEType): Add all of the plug-ins
              that handle this MIME type to a list, sort the list, and return the
              first item.
              (WebCore::PluginDatabase::MIMETypeForExtension): Add all of the plug-ins
              that handle this extension to a list, sort the list, and return the MIME
              type used by the plug-in at the beginning of the list.
              * plugins/PluginDatabase.h:
              * plugins/PluginPackage.h:
              (WebCore::PluginPackage::version): Added; returns the module version.
              * plugins/win/PluginDatabaseWin.cpp:
              (WebCore::PluginDatabase::isPreferredPluginPath): Made static; removed
              const.
              * plugins/win/PluginPackageWin.cpp:
              (WebCore::PluginPackage::compare): Sorts plug-ins with known issues to
              the end, then plug-ins in preferred directories to the beginning, then
              alphabetically by file name, numerically by version, and alphabetically
              by parent directory.
              (WebCore::PluginPackage::determineQuirks): Set the "don't allow multiple
              instances" quirk for VLC.
              (WebCore::PluginPackage::load): Return false if the plug-in library has
              already been loaded and the "don't allow multiple instances" quirk is
              set.
              * platform/gtk/TemporaryLinkStubs.cpp:
              (PluginPackage::compare): Added stub.
              (PluginDatabase::IsPreferredPluginPath): Update the GTK stub.
              * platform/qt/TemporaryLinkStubs.cpp:
              (PluginPackage::compare): Added stub.
              (PluginDatabase::IsPreferredPluginPath): Update the Qt stub.
              * platform/wx/TemporaryLinkStubs.cpp:
              (PluginPackage::compare): Added stub.
              (PluginDatabase::IsPreferredPluginPath): Update the wx stub.
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cb630a8
    • weinig@apple.com's avatar
      Rubber-stamped by Mark Rowe. · 1102029a
      weinig@apple.com authored
              Remove reference to the now non-existent bridge directory.
      
              * WebCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1102029a
    • weinig@apple.com's avatar
      WebCore: · 4ba897c4
      weinig@apple.com authored
              Reviewed by Darin Adler.
      
              Search the entire prototype chain when doing early prototype lookup in
              the Window's getOwnPropertySlot method.
      
              Makes fast/dom/Window/window-function-name-getter-precedence.html pass all tests.
      
              * bindings/js/kjs_window.cpp:
              (KJS::Window::getOwnPropertySlot):
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              Update test result.
      
              * fast/dom/Window/window-function-name-getter-precedence-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ba897c4
    • zimmermann@webkit.org's avatar
      Reviewed by Oliver. · 6238d76f
      zimmermann@webkit.org authored
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=17568 (SVGForeignObjectElement can't react to width/height SVG DOM changes)
      
      As the bug title says, fix all dynamic update problems that occour with SVGForeignObjectElement.
      
      Tests: svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr.html
      	   svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr.html
      	   svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr.html
      	   svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr.html
      	   svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop.html
      	   svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop.html
      	   svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop.html
      	   svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop.html
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6238d76f
  5. 29 Feb, 2008 4 commits