1. 14 Oct, 2013 25 commits
    • fpizlo@apple.com's avatar
      FTL should have an inefficient but correct implementation of GetById · 6cd705df
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122740
      
      Reviewed by Mark Hahnenberg.
              
      It took some effort to realize that the node->prediction() check in the DFG backends
      are completely unnecessary since the ByteCodeParser will always insert a ForceOSRExit
      if !prediction.
              
      But other than that this was an easy patch.
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::handleGetById):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * ftl/FTLCapabilities.cpp:
      (JSC::FTL::canCompile):
      * ftl/FTLIntrinsicRepository.h:
      * ftl/FTLLowerDFGToLLVM.cpp:
      (JSC::FTL::LowerDFGToLLVM::compileNode):
      (JSC::FTL::LowerDFGToLLVM::compileGetById):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cd705df
    • akling@apple.com's avatar
      Pass Document directly to anonymous renderer constructors. · 42e10638
      akling@apple.com authored
      <https://webkit.org/b/122752>
      
      Reviewed by Antti Koivisto.
      
      Added separate constructors for creating anonymous renderers that
      take a Document& instead of a null Element*/Text*.
      
      Removed setDocumentForAnonymous() and all createAnonymous() helpers.
      ...and RenderObject::m_node is now a Node&, wohoo!
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42e10638
    • mihnea@adobe.com's avatar
      [CSSRegions] Move style-scoped* tests into fast/regions/style-scoped · 3dc95bb3
      mihnea@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122741
      
      Reviewed by Darin Adler.
      
      Move files, adjust TestExpectations.
      
      * fast/regions/style-scoped/style-scoped-in-flow-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-expected.html.
      * fast/regions/style-scoped/style-scoped-in-flow-override-container-style-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-container-style-expected.html.
      * fast/regions/style-scoped/style-scoped-in-flow-override-container-style.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-container-style.html.
      * fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling-expected.html.
      * fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions-expected.html.
      * fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions.html.
      * fast/regions/style-scoped/style-scoped-in-flow-override-region-styling.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling.html.
      * fast/regions/style-scoped/style-scoped-in-flow.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow.html.
      * platform/efl/TestExpectations:
      * platform/gtk-wk2/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3dc95bb3
    • ossy@webkit.org's avatar
      [WK2][Efl][Soup] Make NetworkProcessMainUnix handle proxy settings. · aa8ef681
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118388
      
      Reviewed by Carlos Garcia Campos.
      
      Original patch by Kwang Yul Seo <skyul@company100.net> .
      
      Proxy configuration should honor the no_proxy environment variable
      same to WebProcess. It is necessary not to change the current behaviour.
      See https://bugs.webkit.org/show_bug.cgi?id=91747 for details.
      
      The following things were fixed by Csaba Osztrogonác:
      - moved session variable before #if not to have conflict with https://bugs.webkit.org/show_bug.cgi?id=118343
      - added GRefPtr.h include
      - fixed ifdef guards
      
      * NetworkProcess/unix/NetworkProcessMainUnix.cpp:
      (WebKit::NetworkProcessMain):
      Copied from WebProcessMainEfl.cpp.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa8ef681
    • weinig@apple.com's avatar
      CTTE: Add more node conversion helpers · 9b9c8931
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122737
      
      Reviewed by Darin Adler.
      
      - Factor NODE_TYPE_CASTS into TYPE_CASTS_BASE(ToClassName, FromClassName)
        to allow for DOCUMENT_TYPE_CASTS.
      - Replace more static_casts<>.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b9c8931
    • mark.lam@apple.com's avatar
      Transition misc cti_op_* JITStubs to JIT operations. · 03944a0a
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122645.
      
      Reviewed by Michael Saboff.
      
      Stubs converted:
          cti_op_check_has_instance
          cti_op_create_arguments
          cti_op_del_by_id
          cti_op_instanceof
          cti_to_object
          cti_op_push_activation
          cti_op_get_pnames
          cti_op_load_varargs
      
      * dfg/DFGOperations.cpp:
      * dfg/DFGOperations.h:
      * jit/CCallHelpers.h:
      (JSC::CCallHelpers::setupArgumentsWithExecState):
      * jit/JIT.h:
      (JSC::JIT::emitStoreCell):
      * jit/JITCall.cpp:
      (JSC::JIT::compileLoadVarargs):
      * jit/JITCall32_64.cpp:
      (JSC::JIT::compileLoadVarargs):
      * jit/JITInlines.h:
      (JSC::JIT::callOperation):
      * jit/JITOpcodes.cpp:
      (JSC::JIT::emit_op_get_pnames):
      (JSC::JIT::emit_op_create_activation):
      (JSC::JIT::emit_op_create_arguments):
      (JSC::JIT::emitSlow_op_check_has_instance):
      (JSC::JIT::emitSlow_op_instanceof):
      (JSC::JIT::emitSlow_op_get_argument_by_val):
      * jit/JITOpcodes32_64.cpp:
      (JSC::JIT::emitSlow_op_check_has_instance):
      (JSC::JIT::emitSlow_op_instanceof):
      (JSC::JIT::emit_op_get_pnames):
      (JSC::JIT::emit_op_create_activation):
      (JSC::JIT::emit_op_create_arguments):
      (JSC::JIT::emitSlow_op_get_argument_by_val):
      * jit/JITOperations.cpp:
      * jit/JITOperations.h:
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::emit_op_del_by_id):
      * jit/JITPropertyAccess32_64.cpp:
      (JSC::JIT::emit_op_del_by_id):
      * jit/JITStubs.cpp:
      * jit/JITStubs.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03944a0a
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 61ac2a68
      m.pakula@samsung.com authored
      Added new baselines for tests marked as skipped.
      
      * platform/efl-wk1/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/efl/compositing/overflow/nested-scrolling-expected.txt: Added.
      * platform/efl/compositing/overflow/remove-overflow-crash2-expected.png: Added.
      * platform/efl/compositing/overflow/remove-overflow-crash2-expected.txt: Added.
      * platform/efl/editing/spelling/inline-spelling-markers-hidpi-expected.png: Added.
      * platform/efl/editing/unsupported-content/list-delete-001-expected.png:
      * platform/efl/editing/unsupported-content/list-delete-001-expected.txt: Added.
      * platform/efl/editing/unsupported-content/list-delete-003-expected.png:
      * platform/efl/editing/unsupported-content/list-delete-003-expected.txt: Added.
      * platform/efl/editing/unsupported-content/list-type-after-expected.png:
      * platform/efl/editing/unsupported-content/list-type-after-expected.txt: Added.
      * platform/efl/editing/unsupported-content/table-delete-002-expected.png:
      * platform/efl/editing/unsupported-content/table-delete-002-expected.txt: Added.
      * platform/efl/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
      * platform/efl/fast/table/click-near-anonymous-table-expected.png: Added.
      * platform/efl/fast/table/click-near-anonymous-table-expected.txt: Added.
      * platform/efl/fast/text/international/arabic-justify-expected.png: Added.
      * platform/efl/fast/text/international/arabic-justify-expected.txt: Added.
      * platform/efl/fast/text/international/bidi-linebreak-001-expected.png: Added.
      * platform/efl/fast/text/international/bidi-linebreak-001-expected.txt: Added.
      * platform/efl/fast/text/international/bidi-linebreak-002-expected.png: Added.
      * platform/efl/fast/text/international/bidi-linebreak-002-expected.txt: Added.
      * platform/efl/fast/text/international/bidi-linebreak-003-expected.png: Added.
      * platform/efl/fast/text/international/bidi-linebreak-003-expected.txt: Added.
      * platform/efl/fast/text/unicode-variation-selector-expected.png: Added.
      * platform/efl/fast/text/unicode-variation-selector-expected.txt: Added.
      * platform/efl/media/video-colorspace-yuv420-expected.png: Added.
      * platform/efl/media/video-colorspace-yuv420-expected.txt: Added.
      * platform/efl/media/video-colorspace-yuv422-expected.png: Added.
      * platform/efl/media/video-colorspace-yuv422-expected.txt: Added.
      * platform/efl/svg/as-image/image-respects-deviceScaleFactor-expected.png: Added.
      * platform/efl/svg/as-image/image-respects-deviceScaleFactor-expected.txt: Added.
      * platform/efl/svg/hixie/data-types/002-expected.png: Added.
      * platform/efl/svg/hixie/data-types/002-expected.txt:
      * platform/efl/svg/text/non-bmp-positioning-lists-expected.png: Added.
      * platform/efl/svg/text/non-bmp-positioning-lists-expected.txt: Added.
      * platform/efl/svg/zoom/text/zoom-hixie-mixed-009-expected.png: Added.
      * platform/efl/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61ac2a68
    • zandobersek@gmail.com's avatar
      Static assertions in WTF::adoptPtr should point to using adoptRef for ref-counted objects · d1149929
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122745
      
      Reviewed by Anders Carlsson.
      
      * wtf/PassOwnPtr.h:
      (WTF::adoptPtr): When the object's type is convertible to the RefCountedBase or ThreadSafeRefCountedBase type,
      the static assertion should note that adoptRef should be used instead.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1149929
    • zandobersek@gmail.com's avatar
      Reintroduce PassRefPtr<Event> copy in ScopedEventQueue::dispatchEvent · c338cc7d
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122742
      
      Reviewed by Alexey Proskuryakov.
      
      This is a follow-up to r157219 which introduced a workaround for the GCC's quirky behavior that
      was resulting in crashes due to the PassRefPtr<Event> object passed to EventDispatcher::dispatchEvent
      being copied and nullified first before retrieving the EventTarget of the Event object wrapped in that
      PassRefPtr.
      
      The implementation is now adjusted to first retrieve the pointer to the Event's EventTarget and store
      it in a local variable. That variable is then passed as the first parameter to EventDispatcher::dispatchEvent,
      and the PassRefPtr<Event> passed directly as the second parameter. Previously the pointer of that PassRefPtr
      object was passed in, with a new PassRefPtr being created which would increase the reference count of the
      ref-counted object. Passing in the original PassRefPtr avoids the unnecessary reference count increase by creating
      a copy. That still nullifies the original PassRefPtr, but that's not a problem anymore.
      
      * dom/ScopedEventQueue.cpp:
      (WebCore::ScopedEventQueue::dispatchEvent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c338cc7d
    • betravis@adobe.com's avatar
      [CSS Shapes] Shape-Margin should be animatable · 48a6a023
      betravis@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122524
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Mark content for relayout after shape-margin changes, and add shape-margin
      to the list of animatable properties.
      
      Tests: fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin.html
             fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation.html
      
      * page/animation/CSSPropertyAnimation.cpp:
      (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Add
      shape-margin to the map of animatable CSS properties.
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::updateShapeOutsideInfoAfterStyleChange): Compare shape-margins,
      and mark dependent content for relayout if they have changed.
      
      LayoutTests:
      
      Test that shape-margin can be set dynamically and content lays out correctly.
      Also test that shape-margin can be manipulated through CSS Animations.
      
      * fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation-expected.txt: Added.
      * fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48a6a023
    • g.czajkowski@samsung.com's avatar
      [EFL] Accessibility gardening · 3f033bcb
      g.czajkowski@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122751
      
      Unreviewed EFL gardening.
      
      Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-10-14
      
      * platform/efl-wk2/TestExpectations: Add bug numbers and marked missing tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f033bcb
    • commit-queue@webkit.org's avatar
      Don't crash after OpenGL robustness reset · 77c89c51
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122750
      
      Patch by Arvid Nilsson <anilsson@blackberry.com> on 2013-10-14
      Reviewed by George Staikos.
      
      JIRA 517132.
      Just log the incident and pretend like nothing happened.
      
      No new tests, we don't have repeatable steps to reproduce a robustness
      reset.
      
      * platform/graphics/blackberry/LayerRenderer.cpp:
      (WebCore::LayerRenderer::makeContextCurrent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77c89c51
    • andersca@apple.com's avatar
      [EFL] Buildfix after r157393 · 72c44014
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122749
      
      Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-10-14
      Reviewed by Andreas Kling.
      
      Buildfix with error enumeration value 'CSS_FR' not handled in switch.
      
      * css/CSSCalculationValue.cpp:
      (WebCore::hasDoubleValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72c44014
    • andersca@apple.com's avatar
      WebKit Nightlies broken by r157374 · 000b4a19
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122736
      
      Reviewed by Andreas Kling.
      
      Add back a callOnMainThread overload that Safari is using.
      
      * wtf/MainThread.cpp:
      (WTF::callOnMainThread):
      * wtf/MainThread.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      000b4a19
    • gyuyoung.kim@samsung.com's avatar
      Unreviewed. EFL Gardening. · 19369f97
      gyuyoung.kim@samsung.com authored
      Add baselines for new tests which was added by r156767.
      
      * platform/efl/TestExpectations: Remove tests supported by this commit.
      * platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
      * platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Added.
      * platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
      * platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
      * platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19369f97
    • mario@webkit.org's avatar
      [EFL] Present replaced objects with 0xFFFC character · e228d478
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122744
      
      Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-10-14
      Reviewed by Mario Sanchez Prada.
      
      Source/WebCore:
      
      Replaced elements should be emitted in GTK/EFL and
      marked their presence with the replacement character.
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::textIteratorBehaviorForTextRange):
      
      LayoutTests:
      
      Added new accessibility expectation after r156532.
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e228d478
    • svillar@igalia.com's avatar
      [CSS Grid Layout] Implement support for <flex> · dfdaa965
      svillar@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115362
      
      Reviewed by Andreas Kling.
      
      From Blink r149134, r149480, r149532, r150287 and r156127 by <jchaffraix@chromium.org>
      From Blink r157820 by <svillar@igalia.com>
      
      Source/WebCore:
      
      Added support for flexible lengths ('fr' unit) in CSS Grid Layout
      code. This requires the addition of GridLength class to
      encapsulate the knowledge of <flex> to the grid layout code.
      
      Also updated the algorithm that computes the layout. It increases
      the value of 1fr based on the grid tracks' usedBreath to fraction
      ratio (called normalizedFractionValue). This enables increasing
      the fraction value while updating the available space to account
      for processed grid tracks. The algorithm stops when we run out of
      grid tracks or available space (one grid item has an intrinsic
      size too big). This matches the specs to the letter for the known
      available space case (both the unknown case and the interaction
      with 'span' are left out of this patch).
      
      Tests: fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html
             fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html
             fast/css-grid-layout/flex-content-resolution-columns.html
             fast/css-grid-layout/flex-content-resolution-rows.html
      
      * GNUmakefile.list.am: Added GridLength.h to the build system.
      * Target.pri: Ditto.
      * WebCore.vcxproj/WebCore.vcxproj: Ditto.
      * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::valueForGridTrackBreadth): Replace Length by GridLength.
      * css/CSSGrammar.y.in: Added FR support.
      * css/CSSParser.cpp: Ditto.
      (WebCore::CSSParser::parseGridBreadth):
      (WebCore::CSSParser::detectNumberToken):
      * css/CSSParserValues.cpp: Added FR support.
      (WebCore::CSSParserValue::createCSSValue):
      * css/CSSParserValues.h:
      (WebCore::CSSParserString::operator[]):
      (WebCore::CSSParserString::equalIgnoringCase):
      * css/CSSPrimitiveValue.cpp: Added FR support.
      (WebCore::isValidCSSUnitTypeForDoubleConversion):
      (WebCore::CSSPrimitiveValue::cleanup):
      (WebCore::CSSPrimitiveValue::customCSSText):
      (WebCore::CSSPrimitiveValue::cloneForCSSOM):
      (WebCore::CSSPrimitiveValue::equals):
      * css/CSSPrimitiveValue.h: Added a couple of missing const.
      (WebCore::CSSPrimitiveValue::isFlex):
      * css/StyleResolver.cpp: Added FR support.
      (WebCore::createGridTrackBreadth):
      (WebCore::createGridTrackSize):
      * rendering/RenderGrid.cpp:
      (WebCore::GridTrackForNormalization::GridTrackForNormalization):
      New helper struct to ease the computation of track breadths with
      flexible lengths.
      (WebCore::GridTrackForNormalization::operator=):
      (WebCore::RenderGrid::computePreferredTrackWidth): Replaced Length by GridLength.
      (WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Grow grid lines
      having a fraction as the MaxTrackSizingFunction.
      (WebCore::RenderGrid::computeUsedBreadthOfMinLength): Replaced Length by GridLength.
      (WebCore::RenderGrid::computeUsedBreadthOfMaxLength): Ditto.
      (WebCore::sortByGridNormalizedFlexValue):
      (WebCore::RenderGrid::computeNormalizedFractionBreadth): Increase
      the fraction value while updating the available space to account
      for processed grid tracks.
      (WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
      (WebCore::RenderGrid::distributeSpaceToTracks): Never shrink track sizes.
      (WebCore::RenderGrid::tracksAreWiderThanMinTrackBreadth):
      * rendering/RenderGrid.h:
      * rendering/style/GridLength.h: Added.
      (WebCore::GridLength::GridLength):
      (WebCore::GridLength::isLength):
      (WebCore::GridLength::isFlex):
      (WebCore::GridLength::length):
      (WebCore::GridLength::flex):
      (WebCore::GridLength::setFlex):
      (WebCore::GridLength::operator==):
      * rendering/style/GridTrackSize.h: Replaced Length by GridLength.
      (WebCore::GridTrackSize::length):
      (WebCore::GridTrackSize::setLength):
      (WebCore::GridTrackSize::minTrackBreadth):
      (WebCore::GridTrackSize::maxTrackBreadth):
      (WebCore::GridTrackSize::setMinMax):
      (WebCore::GridTrackSize::hasMinOrMaxContentMinTrackBreadth):
      (WebCore::GridTrackSize::hasMaxContentMinTrackBreadth):
      (WebCore::GridTrackSize::hasMinOrMaxContentMaxTrackBreadth):
      (WebCore::GridTrackSize::hasMaxContentMaxTrackBreadth):
      
      LayoutTests:
      
      Added 4 new test cases to test the support for <flex> in CSS Grid
      Layout code. Also updated some of the existing ones to check the
      support for 'fr' units.
      
      * fast/css-grid-layout/flex-and-minmax-content-resolution-columns-expected.txt: Added.
      * fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html: Added.
      * fast/css-grid-layout/flex-and-minmax-content-resolution-rows-expected.txt: Added.
      * fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html: Added.
      * fast/css-grid-layout/flex-content-resolution-columns-expected.txt: Added.
      * fast/css-grid-layout/flex-content-resolution-columns.html: Added.
      * fast/css-grid-layout/flex-content-resolution-rows-expected.txt: Added.
      * fast/css-grid-layout/flex-content-resolution-rows.html: Added.
      * fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
      * fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
      * fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
      * fast/css-grid-layout/grid-columns-rows-get-set.html:
      * fast/css-grid-layout/grid-dynamic-updates-relayout-expected.txt:
      * fast/css-grid-layout/grid-dynamic-updates-relayout.html:
      * fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
      * fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfdaa965
    • commit-queue@webkit.org's avatar
      Broken text rendering when input field has selection. · 075023fa
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122716
      
      Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-14
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      Tests: fast/text/text-rendering-with-input-selection.html.
             fast/text/text-rendering-with-input-selection-expected.html.
      
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::paint): Check that text has selection.
      
      LayoutTests:
      
      * fast/text/text-rendering-with-input-selection.html: Added.
      * fast/text/text-rendering-with-input-selection-expected.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      075023fa
    • zalan@apple.com's avatar
      Unexpected word wrapping for wrapped content then raw content. · 41db3c18
      zalan@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121130
      
      Reviewed by Antti Koivisto.
      
      When deciding whether a line is considered empty, we need to check if the current
      object is fully responsible for the currently uncommitted width. It helps differentiating
      <span></span><span>abcd</span> from <span>a</span><span>bcd</span>, where in the first
      case when we hit the second <span> the line is still considered empty, as opposed to the
      second example.
      
      Source/WebCore:
      
      Test: fast/css/unexpected-word-wrapping-with-non-empty-spans.html
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::LineBreaker::nextSegmentBreak):
      
      LayoutTests:
      
      * fast/css/unexpected-word-wrapping-with-non-empty-spans-expected.html: Added.
      * fast/css/unexpected-word-wrapping-with-non-empty-spans.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41db3c18
    • akling@apple.com's avatar
      Be more efficient about passing RenderStyle to attachRenderTree(). · 652fa395
      akling@apple.com authored
      <https://webkit.org/b/122743>
      
      Reviewed by Antti Koivisto.
      
      Have attachRenderTree() and createRendererTreeIfNeeded() pass the
      RenderStyle in a PassRefPtr to avoid churning the ref count.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      652fa395
    • svillar@igalia.com's avatar
      [CSS Grid Layout] 2 span positions are not resolved correctly · 0043df78
      svillar@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119717
      
      Reviewed by Andreas Kling.
      
      From Blink r155397 by <jchaffraix@chromium.org>
      
      Source/WebCore:
      
      Test: fast/css-grid-layout/grid-item-bad-resolution-double-span.html
      
      Two opposite 'span' or 'auto' positions should be resolved using
      the auto placement algorithm. We were only checking for the 'auto'
      case. This also covers the case of other positions that, according
      to the spec, should be treated as 'auto'.
      
      * rendering/RenderGrid.cpp:
      (WebCore::RenderGrid::resolveGridPositionsFromStyle):
      
      LayoutTests:
      
      Added a new test case to check bad grid items resolution with two
      opposite span positions. Also added a real grid container to check
      also the resolution code path in some other tests.
      
      * fast/css-grid-layout/grid-item-area-get-set.html: Added a grid container.
      * fast/css-grid-layout/grid-item-bad-resolution-double-span-expected.txt: Added.
      * fast/css-grid-layout/grid-item-bad-resolution-double-span.html: Added.
      * fast/css-grid-layout/grid-item-end-after-get-set.html: Added a grid container.
      * fast/css-grid-layout/grid-item-start-before-get-set.html: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0043df78
    • akling@apple.com's avatar
      Use RenderElement instead of RenderObject in more places. · 1414155c
      akling@apple.com authored
      <https://webkit.org/b/122734>
      
      Reviewed by Antti Koivisto.
      
      Convert some sites to use RenderElement (or type inference) instead
      of RenderObject for less branchy code.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1414155c
    • darin@apple.com's avatar
      Deprecate or remove deleteAllValues functions; there are only a few call sites left · 00701b13
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122738
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      * platform/blackberry/CookieMap.cpp:
      (WebCore::CookieMap::deleteAllCookiesAndDomains):
      * platform/network/blackberry/rss/RSSParserBase.cpp:
      (WebCore::RSSFeed::clear):
      * platform/win/WCDataObject.cpp:
      (WebCore::WCDataObject::~WCDataObject):
      Renamed deleteAllValues to deprecatedDeleteAllValues.
      
      Source/WebKit/blackberry:
      
      * WebKitSupport/InPageSearchManager.cpp:
      (BlackBerry::WebKit::InPageSearchManager::cancelPendingScopingEffort):
      Renamed deleteAllValues to deprecatedDeleteAllValues.
      
      Source/WebKit2:
      
      * Shared/Plugins/NPRemoteObjectMap.cpp:
      (WebKit::NPRemoteObjectMap::pluginDestroyed): Renamed deleteAllValues to
      deprecatedDeleteAllValues.
      
      Source/WTF:
      
      * wtf/Deque.h: Deleted deleteAllValues.
      * wtf/HashMap.h: Ditto.
      * wtf/HashSet.h: Ditto.
      * wtf/ListHashSet.h: Ditto.
      * wtf/Vector.h: Renamed deleteAllValues to deprecatedDeleteAllValues.
      
      Tools:
      
      * DumpRenderTree/win/DRTDataObject.cpp:
      (DRTDataObject::~DRTDataObject):
      * DumpRenderTree/win/UIDelegate.cpp:
      (DRTUndoStack::~DRTUndoStack):
      (DRTUndoStack::clear):
      Renamed deleteAllValues to deprecatedDeleteAllValues.
      
      * Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00701b13
    • ap@apple.com's avatar
      build.webkit.org/dashboard incorrectly shows interrupted builds as green · 44f450be
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122732
      
      Reviewed by Tim Hatcher.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
      (BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
      I don't see it occur any time in recent history, but judging from what happens for
      status 5 (RETRY), we can just finish this function normally.
      Record overall text description for iteration as BuildbotIteration.text.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
      (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
      but no tests failed, make it yellow, and use buildbot-provided description for it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44f450be
    • weinig@apple.com's avatar
      Merge NODE_TYPE_CASTS and ELEMENT_TYPE_CASTS · b857d7bd
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122735
      
      Reviewed by Antti Koivisto.
      
      NODE_TYPE_CASTS and ELEMENT_TYPE_CASTS are identical. Let them become one
      with one another.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b857d7bd
  2. 13 Oct, 2013 15 commits
    • akling@apple.com's avatar
      Uncrashify Document::head() too. (Why am I even awake?) · 73aa7740
      akling@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73aa7740
    • akling@apple.com's avatar
      677b717f
    • fpizlo@apple.com's avatar
      FTL OSR exit should perform zero extension on values smaller than 64-bit · 47ce211f
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122688
      
      Reviewed by Gavin Barraclough.
              
      In the DFG we usually make the simplistic assumption that a 32-bit value in a 64-bit
      register will have zeros on the high bits.  In the few cases where the high bits are
      non-zero, the DFG sort of tells us this explicitly.
      
      But when working with llvm.webkit.stackmap, it doesn't work that way.  Consider we might
      emit LLVM IR like:
      
          %2 = trunc i64 %1 to i32
          stuff %2
          call @llvm.webkit.stackmap(...., %2)
      
      LLVM may never actually emit a truncation instruction of any kind.  And that's great - in
      many cases it won't be needed, like if 'stuff %2' is a 32-bit op that ignores the high
      bits anyway.  Hence LLVM may tell us that %2 is in the register that still had the value
      from before truncation, and that register may have garbage in the high bits.
      
      This means that on our end, if we want a 32-bit value and we want that value to be
      zero-extended, we should zero-extend it ourselves.  This is pretty easy and should be
      cheap, so we should just do it and not make it a requirement that LLVM does it on its
      end.
              
      This makes all tests pass with JSC_ftlOSRExitUsesStackmap=true.
      
      * ftl/FTLOSRExitCompiler.cpp:
      (JSC::FTL::compileStubWithOSRExitStackmap):
      * ftl/FTLValueFormat.cpp:
      (JSC::FTL::reboxAccordingToFormat):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47ce211f
    • darin@apple.com's avatar
      Rewrite Document::body and Document::head in modern style, way clearer and shorter · 15588fa8
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122717
      
      Reviewed by Andreas Kling.
      
      * dom/Document.cpp:
      (WebCore::Document::body): Use iterator to make this way easier to read.
      (WebCore::Document::head): Ditto.
      
      * html/HTMLTagNames.in: Added generateTypeHelpers for body and head.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15588fa8
    • mrowe@apple.com's avatar
      Roll deps^H^H^H^HChangeLogs. · 98d05b62
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98d05b62
    • berto@igalia.com's avatar
      Unreviewed GTK gardening. · 83dbb479
      berto@igalia.com authored
      * platform/gtk-wk2/TestExpectations:
      Add bug number to the failing animation tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83dbb479
    • akling@apple.com's avatar
      RenderLayerBacking should have RenderLayer& backpointer. · c68fe759
      akling@apple.com authored
      <https://webkit.org/b/122731>
      
      Reviewed by Anders Carlsson.
      
      RenderLayerBacking is always owned by a RenderLayer and so should
      store its backpointer in a reference.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c68fe759
    • commit-queue@webkit.org's avatar
      Removing input-file-entries.html from TestExpectation · 8db91a8a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122674
      
      Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-13
      Reviewed by Anders Carlsson.
      
      input-file-entries.html has been removed in
      changeset 156692. so removing references to this file.
      
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      * platform/wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8db91a8a
    • andersca@apple.com's avatar
      Try to fix the Lion build. · dbfe1293
      andersca@apple.com authored
      * Configurations/JavaScriptCore.xcconfig:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbfe1293
    • darin@apple.com's avatar
      Make element predicates and type casts work more consistently on more types · 57264685
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122718
      
      Reviewed by Antti Koivisto.
      
      * dom/ContainerNodeAlgorithms.cpp:
      (WebCore::assertConnectedSubrameCountIsConsistent):
      * dom/ContainerNodeAlgorithms.h:
      (WebCore::ChildFrameDisconnector::collectFrameOwners):
      Updated for name change.
      
      * dom/Document.cpp:
      (WebCore::Document::adoptNode): Use a reference instead of a pointer.
      (WebCore::Document::dispatchFullScreenChangeOrErrorEvent): Updated for
      typecast name change and also to cast a reference, since we don't overload
      for pointers.
      (WebCore::Document::updateHoverActiveState): Ditto.
      
      * dom/Element.h: Made the isElementOfType functions take references instead
      of pointers. Also use const in the type template argument. These changes go
      hand in hand with the changes in the generated code and all the classes.
      Also use a bit of nullptr.
      
      * dom/ElementIterator.h:
      (WebCore::findElementAncestorOfType): Got rid of the ElementTypeWithConst
      naming since this works with or without const. Added const to the call site
      for isElementOfType, because it works that way now.
      
      * dom/ElementTraversal.h:
      (WebCore::Traversal::firstChildTemplate): Add const to the type when calling
      isElementOfType. Along with the corresponding changes, this makes these
      templates work for const types.
      (WebCore::Traversal::lastChildTemplate): Ditto.
      (WebCore::Traversal::firstWithinTemplate): Ditto.
      (WebCore::Traversal::lastWithinTemplate): Ditto.
      (WebCore::Traversal::nextTemplate): Ditto.
      (WebCore::Traversal::previousTemplate): Ditto.
      (WebCore::Traversal::nextSiblingTemplate): Ditto.
      (WebCore::Traversal::previousSiblingTemplate): Ditto.
      (WebCore::Traversal::nextSkippingChildrenTemplate): Ditto.
      
      * dom/Node.cpp:
      (WebCore::Node::handleLocalEvents): Check isElementNode and then call the
      isDisabledFormControl member function, since we no longer have a helper that
      takes a node.
      (WebCore::Node::willRespondToMouseMoveEvents): Ditto.
      (WebCore::Node::willRespondToMouseClickEvents): Ditto.
      (WebCore::Node::willRespondToTouchEvents): Ditto.
      
      * dom/PseudoElement.h: Use some nullptr. Added an isPseudoElement function
      that the ELEMENT_TYPE_CASTS macro can use, and also used that macro to make
      the toPseudoElement functions instead of a hand-written local variant.
      
      * dom/make_names.pl:
      (printTypeHelpers): Added unimplemented versions of the element predicate
      functions that return void to catch unnecessary runtime checks of types
      that are already known at compile time. Added assertions to the pointer
      overloads of the predicates. Maybe later we can delete them. Added const
      to the isElementOf template arguments to make these work with both const
      and non-const. Put overloads in a consistent order, most specific class
      first, then less specific. Changed isElementOfType to take references
      rather than pointers.
      
      * editing/Editor.cpp:
      (WebCore::Editor::selectionForCommand): Updated to pass a reference.
      (WebCore::Editor::setBaseWritingDirection): Ditto.
      (WebCore::findFirstMarkable): Ditto.
      
      * html/FormAssociatedElement.h: Tweaked a comment.
      
      * html/HTMLBodyElement.cpp:
      (WebCore::HTMLBodyElement::insertedInto): Updated for name change and to
      pass a reference.
      
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::translate): Removed FIXME and const_cast since the
      problem is fixed.
      (WebCore::HTMLElement::directionality): Use a reference.
      
      * html/HTMLElement.h: Use const in the type of the isElementOfType functions.
      Use references for all the arguments, not pointers.
      
      * html/HTMLFieldSetElement.cpp:
      (WebCore::HTMLFieldSetElement::refreshElementsIfNeeded): Use documentVersion
      instead of docVersion for local variable name. Use elementDescendants instead
      of elementTraversal.
      (WebCore::HTMLFieldSetElement::length): Use length instead of len for name.
      
      * html/HTMLFormControlElement.h: Put predicates into the standard format and
      did them on single lines. Added ELEMENT_TYPE_CASTS so we get standard casts.
      * html/HTMLFrameElementBase.h: Ditto.
      * html/HTMLFrameOwnerElement.h: Ditto, but changed the name to match the class,
      so it's now isHTMLFrameOwnerElement and toHTMLFrameOwnerElement.
      
      * html/HTMLLabelElement.cpp:
      (WebCore::nodeAsSupportedLabelableElement): Updated to use references.
      
      * html/HTMLMediaElement.h: Put predicates into the standard format and did
      them on single lines. Added ELEMENT_TYPE_CASTS so we get standard casts.
      * html/HTMLPlugInElement.h: Ditto. Also marked isPluginElement FINAL.
      * html/HTMLPlugInImageElement.h: Ditto.
      * html/HTMLTableCellElement.cpp: Removed old hand-written cast functions.
      * html/HTMLTableCellElement.h: Did same predicate and ELEMENT_TYPE_CASTS
      changes. Also fixed up the ordering of functions in the class.
      
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::enclosingTextFormControl): Updated to use references and nullptr.
      
      * html/HTMLTextFormControlElement.h: Did same predicate and ELEMENT_TYPE_CASTS.
      
      * html/HTMLTrackElement.cpp:
      (WebCore::HTMLTrackElement::removedFrom): Call isHTMLMediaElement by its new name.
      
      * html/LabelableElement.h: Did same predicate and ELEMENT_TYPE_CASTS.
      
      * html/track/WebVTTElement.h: Made isWebVTTElement private. Changed the argument
      type of setLanguage to const AtomicString& to avoid excess reference count churn.
      Did the predicate and type casts thing.
      
      * loader/archive/cf/LegacyWebArchive.cpp:
      (WebCore::LegacyWebArchive::create): Update for name changes and use references.
      
      * mathml/MathMLElement.h: Did same predicate and ELEMENT_TYPE_CASTS.
      
      * page/FocusController.cpp:
      (WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument):
      (WebCore::FocusController::advanceFocusInDocumentOrder):
      * page/PageSerializer.cpp:
      (WebCore::SerializerMarkupAccumulator::appendCustomAttributes):
      Update for name change.
      
      * platform/Pasteboard.h: Removed unneeded forward declaration.
      
      * rendering/RenderWidget.h: Updated for name change.
      
      * rendering/svg/RenderSVGResourceFilter.cpp:
      (WebCore::RenderSVGResourceFilter::buildPrimitives): Use element iterator
      and nullptr.
      
      * svg/SVGAElement.cpp:
      (WebCore::SVGAElement::defaultEventHandler): Update for name changes.
      
      * svg/SVGAnimateElement.cpp:
      (WebCore::isSVGAnimateElement): Moved here since we don't want to inline such
      a long list of tag names.
      
      * svg/SVGAnimateElement.h: Marked a lot more virtual functions OVERRIDE.
      Did predicate and ELEMENT_TYPE_CASTS changes, but did not make the predicate
      be inlined.
      
      * svg/SVGElement.h: Did predicate and ELEMENT_TYPE_CASTS changes.
      * svg/SVGFilterPrimitiveStandardAttributes.h: Ditto.
      
      * svg/SVGGradientElement.cpp:
      (WebCore::isSVGGradientElement): Moved here since we don't want to inline
      the two tag names.
      
      * svg/SVGGradientElement.h: Did predicate and ELEMENT_TYPE_CASTS changes.
      * svg/SVGGraphicsElement.h: Ditto.
      
      * svg/SVGImageElement.cpp:
      (WebCore::SVGImageElement::SVGImageElement): Took out assertion, since it
      was asserting the class of the obejct we just created.
      
      * svg/SVGPolyElement.cpp:
      (WebCore::isSVGPolyElement): Moved here since we don't want to inline the
      two tag names.
      
      * svg/SVGPolyElement.h: Did predicate and ELEMENT_TYPE_CASTS changes.
      * svg/SVGTextContentElement.h: Ditto.
      
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::connectConditions): Update for name changes,
      to use references and nullptr, and to get rid of a non-helpful local.
      
      * svg/animation/SVGSMILElement.h: Added a virtual function to check if a
      given SVGElement is an SVGSMILElement so we don't have to check a long list
      of tag names instead. Also did the predicate and ELEMENT_TYPE_CASTS changes.
      
      * testing/Internals.cpp:
      (WebCore::Internals::visiblePlaceholder): Updated to use references.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57264685
    • andersca@apple.com's avatar
      Change callOnMainThread to take an std::function · c253c446
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122698
      
      Reviewed by Darin Adler.
      
      This will let us pass anything that can be converted to an std::function (including lambdas and
      WTF::Function objects) to callOnMainThread.
      
      * wtf/MainThread.cpp:
      (WTF::callOnMainThread):
      * wtf/MainThread.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c253c446
    • antti@apple.com's avatar
      Text::renderer() should return RenderText · e9c90169
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122729
      
      Reviewed by Andreas Kling.
              
      Tighten typing.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9c90169
    • akling@apple.com's avatar
      Devirtualize RenderView::viewRect(). · eaab3bdb
      akling@apple.com authored
      <https://webkit.org/b/122730>
      
      Reviewed by Antti Koivisto.
      
      There's no need for viewRect() to be a virtual RenderObject function.
      The single call site that didn't already access it through RenderView
      can just go via view().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eaab3bdb
    • akling@apple.com's avatar
      Move setPseudoStyle() to RenderImage (from RenderElement.) · 0b5763fb
      akling@apple.com authored
      <https://webkit.org/b/122726>
      
      Reviewed by Antti Koivisto.
      
      Only RenderImages ever use setPseudoStyle() so move it there and
      remove the non-image codepath.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b5763fb
    • akling@apple.com's avatar
      CTTE: RenderSlider always has an HTMLInputElement. · ceef1ea6
      akling@apple.com authored
      <https://webkit.org/b/122728>
      
      Reviewed by Anders Carlsson.
      
      This renderer is never anonymous and always has a corresponding
      HTMLInputElement. Tighten this up by having the constructor take
      the element by reference, and override element() with a stronger
      return type.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ceef1ea6