- 02 Dec, 2009 4 commits
-
-
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: DOM tree selection disappears upon page refresh. https://bugs.webkit.org/show_bug.cgi?id=31142 Test: inspector/elements-panel-selection-on-refresh.html * inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::pushNodeByPathToFrontend): * inspector/InjectedScriptHost.h: * inspector/InjectedScriptHost.idl: * inspector/InspectorBackend.h: * inspector/InspectorController.cpp: (WebCore::InspectorController::close): (WebCore::InspectorController::releaseDOMAgent): (WebCore::InspectorController::resetScriptObjects): * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::~InspectorDOMAgent): (WebCore::InspectorDOMAgent::reset): (WebCore::InspectorDOMAgent::setDocument): (WebCore::InspectorDOMAgent::pushDocumentToFrontend): (WebCore::InspectorDOMAgent::nodeForPath): (WebCore::InspectorDOMAgent::pushNodePathToFrontend): * inspector/InspectorDOMAgent.h: * inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._renumber): (WebInspector.DOMAgent.prototype._setDocument): * inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.setDocument.selectDefaultNode): (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode): (WebInspector.ElementsPanel.prototype.setDocument): * inspector/front-end/InjectedScript.js: (InjectedScript.pushNodeByPathToFrontend): * inspector/front-end/InjectedScriptAccess.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* platform/qt/Skipped: - fast/frames/sandboxed-iframe-navigation-windowopen.html added. (crasher) git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* platform/qt/Skipped: - svg/custom/mask-with-all-units.svg added. - fast/css/namespaces/namespaces-comments.xml added. - fast/css/namespaces/namespaces-empty.xml added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ukai@chromium.org authored
Reviewed by Alexey Proskuryakov. WebSocket handshake check query component of URL https://bugs.webkit.org/show_bug.cgi?id=31617 * websocket/tests/echo-location_wsh.py: Added. * websocket/tests/no-query_wsh.py: Added. * websocket/tests/script-tests/url-with-credential.js: Added. * websocket/tests/script-tests/url-with-empty-query.js: Added. * websocket/tests/script-tests/url-with-fragment.js: Added. * websocket/tests/script-tests/url-with-query-for-no-query.js: Added. * websocket/tests/script-tests/url-with-query.js: Added. * websocket/tests/url-with-credential-expected.txt: Added. * websocket/tests/url-with-credential.html: Added. * websocket/tests/url-with-empty-query-expected.txt: Added. * websocket/tests/url-with-empty-query.html: Added. * websocket/tests/url-with-fragment-expected.txt: Added. * websocket/tests/url-with-fragment.html: Added. * websocket/tests/url-with-query-expected.txt: Added. * websocket/tests/url-with-query-for-no-query-expected.txt: Added. * websocket/tests/url-with-query-for-no-query.html: Added. * websocket/tests/url-with-query.html: Added. 2009-12-02 Fumitoshi Ukai <ukai@chromium.org> Reviewed by Alexey Proskuryakov. WebSocket handshake check query component of URL https://bugs.webkit.org/show_bug.cgi?id=31617 Tests: websocket/tests/url-with-credential.html websocket/tests/url-with-empty-query.html websocket/tests/url-with-fragment.html websocket/tests/url-with-query-for-no-query.html websocket/tests/url-with-query.html * platform/KURLGoogle.cpp: (WebCore::KURL::query): returns a null if query is not specified and returns an empty if query is specified but empty. * websockets/WebSocketHandshake.cpp: (WebCore::resourceName): added. add query component to path if specified. (WebCore::WebSocketHandshake::clientLocation): (WebCore::WebSocketHandshake::clientHandshakeMessage): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 01 Dec, 2009 19 commits
-
-
hamaji@chromium.org authored
Reviewed by Eric Seidel. Update expectations of css2.1/t1205-c56* for Qt https://bugs.webkit.org/show_bug.cgi?id=32015 * platform/qt/Skipped: * platform/qt/css2.1/t1205-c561-list-displ-00-b-expected.txt: * platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.txt: * platform/qt/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Darin Adler. Change [Reflect] to [ConvertNullToNullString, Reflect] for min, max, pattern and step attributes of HTMLInputElement. https://bugs.webkit.org/show_bug.cgi?id=31708 * fast/forms/input-minmax-expected.txt: * fast/forms/input-pattern-expected.txt: Added. * fast/forms/input-pattern.html: Added. * fast/forms/input-step-expected.txt: * fast/forms/script-tests/input-minmax.js: Add tests for null/undefined/non-string. * fast/forms/script-tests/input-pattern.js: Added. * fast/forms/script-tests/input-step.js: Change the result for null. 2009-12-01 Kent Tamura <tkent@chromium.org> Reviewed by Darin Adler. Change [Reflect] to [ConvertNullToNullString, Reflect] for min, max, pattern and step attributes of HTMLInputElement. https://bugs.webkit.org/show_bug.cgi?id=31708 * html/HTMLInputElement.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cfleizach@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=32007 Reviewed by Darin Adler. WebCore: Test: platform/mac/accessibility/aria-drag-drop.html * accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::supportsARIADropping): (WebCore::AccessibilityObject::supportsARIADragging): (WebCore::AccessibilityObject::isARIAGrabbed): (WebCore::AccessibilityObject::setARIAGrabbed): (WebCore::AccessibilityObject::determineARIADropEffects): * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::supportsARIADropping): (WebCore::AccessibilityRenderObject::supportsARIADragging): (WebCore::AccessibilityRenderObject::isARIAGrabbed): (WebCore::AccessibilityRenderObject::setARIAGrabbed): (WebCore::AccessibilityRenderObject::determineARIADropEffects): * accessibility/AccessibilityRenderObject.h: * accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]): (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]): * html/HTMLAttributeNames.in: WebKitTools: * DumpRenderTree/AccessibilityUIElement.cpp: (getARIADropEffectsCallback): (getARIAIsGrabbedCallback): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::ariaIsGrabbed): (AccessibilityUIElement::ariaDropEffects): LayoutTests: * platform/mac/accessibility/aria-drag-drop-expected.txt: Added. * platform/mac/accessibility/aria-drag-drop.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Darin Adler. Add sneaky test that has tabs. * fast/frames/sandboxed-iframe-attribute-parsing-expected.txt: Added. * fast/frames/sandboxed-iframe-attribute-parsing.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Darin Adler. Implement HTML5 sandbox attribute for iframes. http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox https://bugs.webkit.org/show_bug.cgi?id=21288 * fast/frames/resources/non-sandboxed-iframe-navigation.html: Added. * fast/frames/resources/sandboxed-iframe-attribute-parsing-allowed.html: Added. * fast/frames/resources/sandboxed-iframe-attribute-parsing-disallowed.html: Added. * fast/frames/resources/sandboxed-iframe-form-allowed.html: Added. * fast/frames/resources/sandboxed-iframe-form-disallowed.html: Added. * fast/frames/resources/sandboxed-iframe-navigated.html: Added. * fast/frames/resources/sandboxed-iframe-navigation-child.html: Added. * fast/frames/resources/sandboxed-iframe-navigation-navigated.html: Added. * fast/frames/resources/sandboxed-iframe-navigation-parent.html: Added. * fast/frames/resources/sandboxed-iframe-navigation-source.html: Added. * fast/frames/resources/sandboxed-iframe-navigation-targetlink.html: Added. * fast/frames/resources/sandboxed-iframe-navigation-windowopen.html: Added. * fast/frames/resources/sandboxed-iframe-plugins-frame-applet.html: Added. * fast/frames/resources/sandboxed-iframe-plugins-frame-embed.html: Added. * fast/frames/resources/sandboxed-iframe-plugins-frame-object.html: Added. * fast/frames/resources/sandboxed-iframe-script-dynamic.html: Added. * fast/frames/resources/sandboxed-iframe-storage-allowed.html: Added. * fast/frames/resources/sandboxed-iframe-storage-disallowed.html: Added. * fast/frames/sandboxed-iframe-attribute-parsing-expected.txt: Added. * fast/frames/sandboxed-iframe-attribute-parsing.html: Added. * fast/frames/sandboxed-iframe-forms-expected.txt: Added. * fast/frames/sandboxed-iframe-forms.html: Added. * fast/frames/sandboxed-iframe-navigation-allowed-expected.txt: Added. * fast/frames/sandboxed-iframe-navigation-allowed.html: Added. * fast/frames/sandboxed-iframe-navigation-parent-expected.txt: Added. * fast/frames/sandboxed-iframe-navigation-parent.html: Added. * fast/frames/sandboxed-iframe-navigation-targetlink-expected.txt: Added. * fast/frames/sandboxed-iframe-navigation-targetlink.html: Added. * fast/frames/sandboxed-iframe-navigation-windowopen-expected.txt: Added. * fast/frames/sandboxed-iframe-navigation-windowopen.html: Added. * fast/frames/sandboxed-iframe-plugins-expected.txt: Added. * fast/frames/sandboxed-iframe-plugins.html: Added. * fast/frames/sandboxed-iframe-scripting-expected.txt: Added. * fast/frames/sandboxed-iframe-scripting.html: Added. * fast/frames/sandboxed-iframe-storage-expected.txt: Added. * fast/frames/sandboxed-iframe-storage.html: Added. * http/tests/security/resources/sandboxed-iframe-document-cookie-read-denied.html: Added. * http/tests/security/resources/sandboxed-iframe-modify-self.html: Added. * http/tests/security/resources/xss-DENIED-sandboxed-iframe-attacker.html: Added. * http/tests/security/sandboxed-iframe-document-cookie-expected.txt: Added. * http/tests/security/sandboxed-iframe-document-cookie.html: Added. * http/tests/security/sandboxed-iframe-modify-self-expected.txt: Added. * http/tests/security/sandboxed-iframe-modify-self.html: Added. * http/tests/security/xss-DENIED-sandboxed-iframe-expected.txt: Added. * http/tests/security/xss-DENIED-sandboxed-iframe.html: Added. * http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-expected.txt: Added. * http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html: Added. * http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt: Added. * http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt: Added. * http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard.html: Added. * http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied.html: Added. * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow-iframe.html: Added. * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow.cgi: Added. * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-iframe.html: Added. * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-without-wildcard-iframe.html: Added. * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-without-wildcard.cgi: Added. * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied.cgi: Added. 2009-12-01 Patrik Persson <patrik.j.persson@ericsson.com> Reviewed by Darin Adler. Implement HTML5 sandbox attribute for iframes. http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox https://bugs.webkit.org/show_bug.cgi?id=21288 Tests: fast/frames/sandboxed-iframe-attribute-parsing.html fast/frames/sandboxed-iframe-forms.html fast/frames/sandboxed-iframe-navigation-allowed.html fast/frames/sandboxed-iframe-navigation-parent.html fast/frames/sandboxed-iframe-navigation-targetlink.html fast/frames/sandboxed-iframe-navigation-windowopen.html fast/frames/sandboxed-iframe-plugins.html fast/frames/sandboxed-iframe-scripting.html fast/frames/sandboxed-iframe-storage.html http/tests/security/sandboxed-iframe-document-cookie.html http/tests/security/sandboxed-iframe-modify-self.html http/tests/security/xss-DENIED-sandboxed-iframe.html http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard.html http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied.html * bindings/js/JSDOMWindowCustom.cpp: sandboxing navigation (WebCore::createWindow): * bindings/js/ScriptController.cpp: sandboxing scripts (WebCore::ScriptController::isEnabled): * dom/Document.cpp: (WebCore::Document::processHttpEquiv): (WebCore::Document::cookie): raise exception when accessed from sandbox (WebCore::Document::setCookie): raise exception when accessed from sandbox (WebCore::Document::initSecurityContext): updae sandbox status (WebCore::Document::updateSandboxFlags): * dom/Document.h: * dom/Document.idl: * html/HTMLAppletElement.cpp: sandboxing applets (WebCore::HTMLAppletElement::createRenderer): (WebCore::HTMLAppletElement::renderWidgetForJSBindings): (WebCore::HTMLAppletElement::canEmbedJava): * html/HTMLAppletElement.h: * html/HTMLAttributeNames.in: * html/HTMLFrameOwnerElement.cpp: management of sandbox flags as stated in attribute (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): (WebCore::HTMLFrameOwnerElement::setSandboxFlags): * html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::sandboxFlags): * html/HTMLIFrameElement.cpp: sandbox attribute parsing (WebCore::parseSandboxAttribute): (WebCore::HTMLIFrameElement::parseMappedAttribute): * html/HTMLIFrameElement.idl: * inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies): * loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck): * loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::submitForm): sandboxing forms (WebCore::FrameLoader::requestObject): sandboxing plugins (WebCore::FrameLoader::shouldAllowNavigation): sandboxing navigation (WebCore::FrameLoader::updateSandboxFlags): propagation of sandbox flags * loader/FrameLoader.h: (WebCore::FrameLoader::ownerElementSandboxFlagsChanged): (WebCore::FrameLoader::isSandboxed): (WebCore::FrameLoader::sandboxFlags): * loader/FrameLoaderTypes.h: (WebCore::): * page/DOMWindow.cpp: disable storage and databases in sandboxed frames (WebCore::DOMWindow::sessionStorage): (WebCore::DOMWindow::localStorage): (WebCore::DOMWindow::openDatabase): * page/SecurityOrigin.cpp: added sandboxing status (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canAccess): (WebCore::SecurityOrigin::canRequest): (WebCore::SecurityOrigin::toString): * page/SecurityOrigin.h: (WebCore::SecurityOrigin::setSandboxFlags): (WebCore::SecurityOrigin::isSandboxed): (WebCore::SecurityOrigin::canAccessDatabase): (WebCore::SecurityOrigin::canAccessStorage): * websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cfleizach@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=32030 Reviewed by David Kilzer. WebCore: Test: accessibility/aria-text-role.html * accessibility/AccessibilityObject.cpp: (WebCore::createARIARoleMap): * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue): (WebCore::AccessibilityRenderObject::isDescendantOfBarrenParent): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): (WebCore::AccessibilityRenderObject::text): * accessibility/AccessibilityRenderObject.h: LayoutTests: * accessibility/aria-text-role-expected.txt: Added. * accessibility/aria-text-role.html: Added. * platform/gtk/Skipped: * platform/win/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zimmermann@webkit.org authored
Reviewed by Simon Fraser. Add SVG animation test framework with 'snapshot' functionality https://bugs.webkit.org/show_bug.cgi?id=31897 Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method, forwarding the call to SVGDocumentExtensions, if SVG is enabled. Implemented just like the existing pauseAnimation* methods for CSS animations. * Api/qwebframe.cpp: (qt_drt_pauseSVGAnimation): 2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Simon Fraser. Add SVG animation test framework with 'snapshot' functionality https://bugs.webkit.org/show_bug.cgi?id=31897 Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method, forwarding the call to SVGDocumentExtensions, if SVG is enabled. Implemented just like the existing pauseAnimation* methods for CSS animations. * webkit/webkitprivate.h: * webkit/webkitwebframe.cpp: (webkit_web_frame_pause_svg_animation): 2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Simon Fraser. Add SVG animation test framework with 'snapshot' functionality https://bugs.webkit.org/show_bug.cgi?id=31897 Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method, forwarding the call to SVGDocumentExtensions, if SVG is enabled. Implemented just like the existing pauseAnimation* methods for CSS animations. * Interfaces/IWebFramePrivate.idl: * WebFrame.cpp: (WebFrame::pauseSVGAnimation): * WebFrame.h: 2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Simon Fraser. Add SVG animation test framework with 'snapshot' functionality https://bugs.webkit.org/show_bug.cgi?id=31897 Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method, forwarding the call to SVGDocumentExtensions, if SVG is enabled. Implemented just like the existing pauseAnimation* methods for CSS animations. * WebView/WebFrame.mm: (-[WebFrame _pauseSVGAnimation:onSMILNode:atTime:]): * WebView/WebFramePrivate.h: 2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Simon Fraser. Add SVG animation test framework with 'snapshot' functionality https://bugs.webkit.org/show_bug.cgi?id=31897 Add 'sampleSVGAnimationForElementAtTime' method to the LayoutTestController, for the use within the new SVG animation test framework (LayoutTests/svg/animations/) layoutTestController.sampleAnimationAtTime(<svg animation id>, <absolute time>, <svg element id>); to sample a svg animateMotion/animateColor/animate/set element at certain times. After the desired SVG animation starts and calling the method above, it's immediately forwarded to the desired sampling time. After JS returns from the 'sampleSVGAnimationForElementAtTime' method a callback is fired used to sample the animation value at the target time. It's modelled similar to the CSS animation/transition testing framework, inspired by LayoutTests/animations/animation-test-helpers.js. Though it has been extended to integrate within the fast/js/js-test-* framework, that's used for the SVG dynamic-updates tests, to simplify test creation, by utilizing script-tests/* only. Adding a simple testcase testing the DRT methods, it will soon be extended to test animVal/baseVal interaction, while animating. Test: svg/animations/animVal-basics.html * WebCore.base.exp: * WebCore.xcodeproj/project.pbxproj: * svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::sampleAnimationAtTime): * svg/SVGDocumentExtensions.h: * svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::SMILTimeContainer): (WebCore::SMILTimeContainer::sampleAnimationAtTime): (WebCore::SMILTimeContainer::updateAnimations): * svg/animation/SMILTimeContainer.h: 2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Simon Fraser. Add SVG animation test framework with 'snapshot' functionality https://bugs.webkit.org/show_bug.cgi?id=31897 Add LayoutTests/svg/animations directory, containing a new framework for SVG animation test with sampling at certain times. Added one example test, which will be extended soon to cover animVal support, once basic support has been implemented. * svg/animations: Added. * svg/animations/animVal-basics-expected.txt: Added. * svg/animations/animVal-basics.html: Added. * svg/animations/resources: Added. * svg/animations/resources/SVGAnimationTestCase.js: Added. (isCloseEnough): (moveAnimationTimelineAndSample): (startTest): (sampleAnimation): (runAnimationTest): * svg/animations/script-tests: Added. * svg/animations/script-tests/TEMPLATE.html: Added. * svg/animations/script-tests/animVal-basics.js: Added. (sample1): (sample2): (sample3): (executeTest): 2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Simon Fraser. Add SVG animation test framework with 'snapshot' functionality https://bugs.webkit.org/show_bug.cgi?id=31897 Add new 'sampleSVGAnimationForElementAtTime' DRT method, used by the new SVG animation testing framework, implemented for qt/gtk/win/mac. * DumpRenderTree/LayoutTestController.cpp: (sampleSVGAnimationForElementAtTimeCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::sampleSVGAnimationForElementAtTime): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime): * DumpRenderTree/qt/LayoutTestControllerQt.h: * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime): * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Rubber-stamped in advance by Brady Eidson. * platform/win/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Pavel Feldman. https://bugs.webkit.org/show_bug.cgi?id=32001 Updated layout test to reflect change to localized string and rebased the result. * inspector/elements-img-tooltip-expected.txt: * inspector/elements-img-tooltip.html: 2009-12-01 Daniel Bates <dbates@webkit.org> Reviewed by Pavel Feldman. https://bugs.webkit.org/show_bug.cgi?id=32001 Added missing localized strings (that I left out of the patch for bug #21554): %d × %d pixels %d × %d pixels (Natural: %d × %d pixels) Also, changed formatting of these stings to conform with existing ones (added a space on both sides of the multiply sign). * English.lproj/localizedStrings.js: Added stings. * inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Rubber-stamped by Brady Eidson. * platform/win/Skipped: Skip http/tests/plugins/post-url-file.html. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
* platform/win/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Rubber-stamped by Ada Chan. * platform/win/Skipped: Added fast/dom/Window/window-postmessage-clone.html, which was timing out due to eventSender.beginDragFiles being unimplemented. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
<http://webkit.org/b/32021> covers fixing these tests. Rubber-stamped by Sam Weinig. * platform/win/Skipped: Removed tests that use textInputController. * platform/win/editing/selection/5825350-1-expected.txt: Added. * platform/win/editing/selection/5825350-2-expected.txt: Added. * platform/win/editing/selection/mixed-editability-10-expected.txt: Added. * platform/win/fast/events/ime-composition-events-001-expected.txt: Added. * platform/win/fast/forms/input-maxlength-ime-completed-expected.txt: Added. * platform/win/fast/forms/input-maxlength-ime-preedit-expected.txt: Added. * platform/win/fast/text/international/thai-cursor-position-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* platform/qt/Skipped: inspector/timeline-network-resource.html added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Pavel Feldman. Adds test for Timeline network resource records. https://bugs.webkit.org/show_bug.cgi?id=31378 * inspector/timeline-network-resource-expected.txt: Added. * inspector/timeline-network-resource.html: Added. * inspector/timeline-network-resource.js: Added. * inspector/timeline-test.js: (printTimelineRecords): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cmarrin@apple.com authored
Changed mallocs to fastMallocs and frees to fastFrees in GraphicsContext3D. Also added error returns https://bugs.webkit.org/show_bug.cgi?id=30778 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cmarrin@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=31672 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* platform/qt/Skipped: - editing/selection/mixed-editability-10.html added. - editing/selection/5825350-1.html added. - editing/selection/5825350-2.html added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hamaji@chromium.org authored
Reviewed by Dan Bernstein. css2.1/t1205-c566-list-stl-00-e-ag.html is failing https://bugs.webkit.org/show_bug.cgi?id=23264 css2.1/t1205-c565-list-pos-00-b.html is failing https://bugs.webkit.org/show_bug.cgi?id=23263 Ignore whitespaces after list markers. Rendering of this was already done for the case where inside=false. This fixes the rendering of inside=true case and calcInlinePrefWidths. Test: fast/lists/calc-width-with-space.html * rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths): * rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak): 2009-11-30 Shinichiro Hamaji <hamaji@chromium.org> Reviewed by Dan Bernstein. css2.1/t1205-c566-list-stl-00-e-ag.html is failing https://bugs.webkit.org/show_bug.cgi?id=23264 * editing/pasteboard/copy-crash-expected.txt: * fast/lists/calc-width-with-space-expected.txt: Added. * fast/lists/calc-width-with-space.html: Added. * platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.checksum: * platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.png: * platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.txt: * platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.checksum: * platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.png: * platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.txt: * platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.checksum: * platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.png: * platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt: * platform/mac/fast/block/positioning/complex-percentage-height-expected.checksum: * platform/mac/fast/block/positioning/complex-percentage-height-expected.png: * platform/mac/fast/block/positioning/complex-percentage-height-expected.txt: * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.checksum: * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.png: * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.txt: * platform/mac/fast/repaint/list-marker-expected.checksum: * platform/mac/fast/repaint/list-marker-expected.png: * platform/mac/fast/repaint/list-marker-expected.txt: * platform/qt/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 30 Nov, 2009 10 commits
-
-
enrica@apple.com authored
WebCore: Can focus but not type into content editable block that contains only non-editable content. <rdar://problem/5982901> https://bugs.webkit.org/show_bug.cgi?id=31750 Reviewed by Darin Adler. The goal is to change the way we choose a visible position after hit detection, by preferring a visually equivalent editable position if available. By doing this, it is possible to add content to an editable block that initially contains only non editable elements. Test: editing/selection/mixed-editability-10.html * WebCore.base.exp: Changed to match the new signature of downstream and upstream in the Position class. * dom/Position.cpp: (WebCore::Position::atEditingBoundary): Added. (WebCore::Position::upstream): Modified to allow to cross the boundary between editable and non editable content if required. (WebCore::Position::downstream): Modified to allow to cross the boundary between editable and non editable content if required. (WebCore::Position::isCandidate): Modified to qualify as candidates positions that are at the editability boundary. (WebCore::Position::getInlineBoxAndOffset): Modified to retrieve the inline box to be used in calculating the caret rectangle. * dom/Position.h: (WebCore::Position::): * dom/PositionIterator.cpp: (WebCore::PositionIterator::atEditingBoundary): Added. (WebCore::PositionIterator::isCandidate): Modified to qualify as candidates positions that are at the editability boundary. * dom/PositionIterator.h: * editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): Modified to accept not only descendants of the editable container, but the container itself. (WebCore::lastEditablePositionBeforePositionInRoot): Modified to accept not only descendants of the editable container, but the container itself. * rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition): Added logic to prefer an editable position, if available. * rendering/RenderText.cpp: (WebCore::RenderText::isAllCollapsibleWhitespace): Added. * rendering/RenderText.h: LayoutTests: Can focus but not type into content editable block that contains only non-editable content. <rdar://problem/5982901> https://bugs.webkit.org/show_bug.cgi?id=31750 Reviewed by Darin Adler. * editing/selection/5825350-1-expected.txt: * editing/selection/5825350-1.html: Modified to use caret rectangle. * editing/selection/5825350-2-expected.txt: * editing/selection/5825350-2.html: Modified to use caret rectangle. * editing/selection/mixed-editability-10-expected.txt: Added. * editing/selection/mixed-editability-10.html: Added. * platform/mac/editing/deleting/5390681-2-expected.txt: Re-baselined to account for the new possible caret position. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://bugs.webkit.org/show_bug.cgi?id=32000bdakin@apple.com authored
Safari caused by extreme column-gap and column-width values -and corresponding- <rdar://problem/7425433> Reviewed by Oliver Hunt. Prevent desiredColumnCount from being less than 1 since it is used as a divisor. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcColumnWidth): LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in Safari caused by extreme column-gap and column-width values -and corresponding- <rdar://problem/7425433> Reviewed by Oliver Hunt. * fast/multicol/huge-column-gap-crash-expected.txt: Added. * fast/multicol/huge-column-gap-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=31659 Connection must be closed in case of Web Socket handshake error The network connection was closed, but the close event wasn't dispatched. Tested by websocket/tests/handshake-error.html, which is un-skipped now. * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose): Call client didHandle() method. This looks strange in CFNetwork implementation, because it's the client that asked to close the stream, so it shouldn't need the callback. It makes more sense in cross-process implementation, because closing is async there. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric.carlson@apple.com authored
Reviewed by Simon Fraser. All HTML5 media element events should be regular events https://bugs.webkit.org/show_bug.cgi?id=30513 * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectMediaResource): (WebCore::HTMLMediaElement::noneSupported): (WebCore::HTMLMediaElement::mediaEngineError): (WebCore::HTMLMediaElement::setNetworkState): (WebCore::HTMLMediaElement::userCancelledLoad): Call scheduleEvent instead of scheduleProgressEvent. (WebCore::HTMLMediaElement::progressEventTimerFired): Call scheduleEvent instead of scheduleProgressEvent. Call renderer->updateFromElement after scheduling a 'progress' event so the controller will update download progress indicator. * html/HTMLMediaElement.h: Remove scheduleProgressEvent prototype. 2009-11-30 Eric Carlson <eric.carlson@apple.com> Reviewed by Simon Fraser. All HTML5 media element events should be regular events https://bugs.webkit.org/show_bug.cgi?id=30513 Remove progress event tests. * media/progress-event-at-least-one-expected.txt: Removed. * media/progress-event-at-least-one.html: Removed. * media/progress-event-expected.txt: Removed. * media/progress-event-total-expected.txt: Removed. * media/progress-event-total.html: Removed. * media/progress-event.html: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
It was me who reviewed the patch, not Eric! Alas, some tools we use cause wrong reviewer information in Bugzilla. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
Reviewed by Eric Seidel. In testing handshake-error case, web_socket_do_extra_handshake calls a non-existent method https://bugs.webkit.org/show_bug.cgi?id=31465 * platform/mac/Skipped: websocket/tests/handshake-error.html now fails on Mac, added to Skipped list, and filed bug 31659 to investigate. * websocket/tests/handshake-error_wsh.py: Call write() on a correct object. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
joepeck@webkit.org authored
Reviewed by Pavel Feldman. Web Inspector: Wrong console output for Regexp escape sequence https://bugs.webkit.org/show_bug.cgi?id=31538 Updated inspector/console-format.html * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.createDividerElement): style issues. (WebInspector.ConsoleView.createFilterElement): style issues. (WebInspector.ConsoleView): added _customFormatters table. (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): style isses. (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): style issues. (WebInspector.ConsoleView.prototype._format): simplified delegation to formatter logic. (WebInspector.ConsoleView.prototype._formatobject): (WebInspector.ConsoleView.prototype._formatnode): (WebInspector.ConsoleView.prototype._printArray): (WebInspector.ConsoleMessage.prototype._format): commented and broke down the algorithm into parts. (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append): handle substitution string formatting. (WebInspector.ConsoleMessage.prototype._formatIndividualValue): handling individual value formatting. (WebInspector.ConsoleCommandResult): * inspector/front-end/InjectedScript.js: simplified regex formatting. * inspector/front-end/inspector.js: (WebInspector.linkifyStringAsFragment): converted new RegExp to literal for performance benefits. * inspector/front-end/utilities.js: (Element.prototype.hasStyleClass): update inaccurate comment. (String.prototype.trimURL): converted new RegExp to literal for performance benefits. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
requiring new results. * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Nikolas Zimmermann. Complex test of mask with every combination of maskUnits and maskContentUnits as well as different values for size and position of the mask and it's content. * platform/mac/svg/custom/mask-with-all-units-expected.checksum: Added. * platform/mac/svg/custom/mask-with-all-units-expected.png: Added. * platform/mac/svg/custom/mask-with-all-units-expected.txt: Added. * svg/custom/mask-with-all-units.svg: Added. 2009-11-30 Dirk Schulze <krit@webkit.org> Reviewed by Nikolas Zimmermann. REGRESSION (r49757): masking-mask-01-b.svg rendered incorrectly [https://bugs.webkit.org/show_bug.cgi?id=31980] It turns out, that we did not handle maskUnits="userSpaceOnUse" correctly. We just need to move the context of the maskImage if maskContentUnits="objectBoundingBox". The context gets scaled on this unit combination, so we have to substract the position of the targetRect. On userSpaceOnUse the position just depends on the position of the mask element. I added a test with some senseless and reasonable values for size and postion of the mask and it's contents. I also used every combination of maskUnits and maskContentUnits to be sure, that it is fixed this time. Test: svg/custom/mask-with-all-units.svg * svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* platform/qt/Skipped: - fast/dom/Window/window-postmessage-clone.html added - inspector/elements-img-tooltip.html added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 29 Nov, 2009 3 commits
-
-
oliver@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=31955 Reviewed by Sam Weinig. Update SerializedScriptValue to include support for File objects in the serialized object graph. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
Rubber-stamped by Eric Seidel. Fix up some compositing layout tests. * compositing/layers-inside-overflow-scroll.html: * compositing/self-painting-layers.html: Use the 'loadeddata' event, instead of 'load', to know when the video loads. * platform/mac/compositing/repaint/content-into-overflow-expected.checksum: * platform/mac/compositing/repaint/content-into-overflow-expected.png: * platform/mac/compositing/repaint/overflow-into-content-expected.checksum: * platform/mac/compositing/repaint/overflow-into-content-expected.png: * platform/mac/compositing/self-painting-layers-expected.checksum: * platform/mac/compositing/self-painting-layers-expected.png: Update with correct pixel results. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Eric Seidel. Test using Id as index of node list. https://bugs.webkit.org/show_bug.cgi?id=31428 * fast/dom/Element/id-in-node-list-index01-expected.txt: Added. * fast/dom/Element/id-in-node-list-index01.html: Added. 2009-11-29 Shu Chang <Chang.Shu@nokia.com> Reviewed by Eric Seidel. Continue to search for matching node in the case where multiple nodes have the same id. https://bugs.webkit.org/show_bug.cgi?id=31428 Test: fast/dom/Element/id-in-node-list-index01.html * dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemWithName): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 28 Nov, 2009 1 commit
-
-
abarth@webkit.org authored
Reviewed by Dimitri Glazkov. [Chromium] Sify compose button alerts error https://bugs.webkit.org/show_bug.cgi?id=31394 Test: http/tests/security/calling-versus-current.html We're supposed to use the calling context for security checks. In JSC land, this is the lexicalGlobalObject. * bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::canAccessPrivate): 2009-11-28 Adam Barth <abarth@webkit.org> Reviewed by Dimitri Glazkov. [Chromium] Sify compose button alerts error https://bugs.webkit.org/show_bug.cgi?id=31394 Test that we're using the calling security context in a simple case. * http/tests/security/calling-versus-current-expected.txt: Added. * http/tests/security/calling-versus-current.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 27 Nov, 2009 3 commits
-
-
dbates@webkit.org authored
Reviewed by Adam Barth. https://bugs.webkit.org/show_bug.cgi?id=31940 Makes the error messages more descriptive when we refuse to load an object/embed or refuse to load from the document base URL. * page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadObject): Changed console message to be more descriptive. (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. 2009-11-27 Daniel Bates <dbates@webkit.org> Reviewed by Adam Barth. https://bugs.webkit.org/show_bug.cgi?id=31940 Rebased results because of new error messages. * http/tests/security/xssAuditor/base-href-control-char-expected.txt: * http/tests/security/xssAuditor/base-href-expected.txt: * http/tests/security/xssAuditor/base-href-null-char-expected.txt: * http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt: * http/tests/security/xssAuditor/embed-tag-control-char-expected.txt: * http/tests/security/xssAuditor/embed-tag-expected.txt: * http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt: * http/tests/security/xssAuditor/embed-tag-null-char-expected.txt: * http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt: * http/tests/security/xssAuditor/object-embed-tag-expected.txt: * http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt: * http/tests/security/xssAuditor/object-src-inject-expected.txt: * http/tests/security/xssAuditor/object-tag-expected.txt: * http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Eric Seidel. REGRESSION(51418): fast/canvas/webgl/gl-object-get-calls.html is failing on the Leopard commit bot https://bugs.webkit.org/show_bug.cgi?id=31919 Temporarily disabled portion of test which is failing on some machines but not others. Root cause will be investigated under https://bugs.webkit.org/show_bug.cgi?id=31843 . * fast/canvas/webgl/gl-object-get-calls-expected.txt: * fast/canvas/webgl/script-tests/gl-object-get-calls.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hamaji@chromium.org authored
Unreviewed red bot fix. Skip tests introduced by the previous change as it seems to be failing. * platform/qt/Skipped: * platform/win/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-