Skip to content
GitLab
Switch branch/tag
  1. 02 Dec, 2009 13 commits
    • pfeldman@chromium.org's avatar
      2009-12-02 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com> · 6cc49d07
      pfeldman@chromium.org authored 
              Reviewed by Timothy Hatcher.

        Web Inspector: DOM tree selection disappears upon page refresh.

        https://bugs.webkit.org/show_bug.cgi?id=31142

        Test: inspector/elements-panel-selection-on-refresh.html

        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::pushNodeByPathToFrontend):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptHost.idl:
        * inspector/InspectorBackend.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::close):
        (WebCore::InspectorController::releaseDOMAgent):
        (WebCore::InspectorController::resetScriptObjects):
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::~InspectorDOMAgent):
        (WebCore::InspectorDOMAgent::reset):
        (WebCore::InspectorDOMAgent::setDocument):
        (WebCore::InspectorDOMAgent::pushDocumentToFrontend):
        (WebCore::InspectorDOMAgent::nodeForPath):
        (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode.prototype._renumber):
        (WebInspector.DOMAgent.prototype._setDocument):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.reset):
        (WebInspector.ElementsPanel.prototype.setDocument.selectDefaultNode):
        (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode):
        (WebInspector.ElementsPanel.prototype.setDocument):
        * inspector/front-end/InjectedScript.js:
        (InjectedScript.pushNodeByPathToFrontend):
        * inspector/front-end/InjectedScriptAccess.js:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cc49d07
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=32045, make sure escape sequences work with · d140c858
      hyatt@apple.com authored 
      all the @-rules we support.  When escape sequences are present, the lexical scanner
just returns a generic token name: ATKEYWORD.  We have to process the escape sequences
and then recheck against the rules we support with the final processed name.  If we
find a match, we mutate the token value to the appropriate rule name token, e.g.,
NAMESPACE_SYM.

Reviewed by Dan Bernstein.

Added fast/css/namespaces/namespaces-escapes.xml

* css/CSSParser.cpp:
(WebCore::CSSParser::lex):
(WebCore::CSSParser::recheckAtKeyword):
(WebCore::CSSParser::text):
* css/CSSParser.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d140c858
    • eric@webkit.org's avatar
      2009-12-02 Anton Muhin <antonm@chromium.org> · f822b905
      eric@webkit.org authored 
              Reviewed by Adam Barth.:w

        Allow to skip thread checks when accessing DOMDataStore for processes
        which run V8 in single thread mode.
        https://bugs.webkit.org/show_bug.cgi?id=31877

        Should be covered by buildbots.

        * bindings/v8/V8DOMMap.cpp:
        (WebCore::getDOMDataStore):
        (WebCore::enableFasterDOMStoreAccess):
        (WebCore::getDOMNodeMap):
        (WebCore::getDOMObjectMap):
        (WebCore::getActiveDOMObjectMap):
        (WebCore::getDOMSVGElementInstanceMap):
        (WebCore::getDOMSVGObjectWithContextMap):
        * bindings/v8/V8DOMMap.h:
2009-12-02  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        Allow to skip thread checks when accessing DOMDataStore for processes
        which run V8 in single thread mode.
        https://bugs.webkit.org/show_bug.cgi?id=31877

        * src/WebScriptController.cpp:
        (WebKit::WebScriptController::enableV8SingleThreadMode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f822b905
    • yurys@chromium.org's avatar
      2009-12-02 Yury Semikhatsky <yurys@chromium.org> · 2aadf6dc
      yurys@chromium.org authored 
              Reviewed by Pavel Feldman.

        Code clean up: remove ScriptObjectQuarantine.* as a whole.

        https://bugs.webkit.org/show_bug.cgi?id=32060

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/ScriptObjectQuarantine.cpp: Removed.
        * bindings/js/ScriptObjectQuarantine.h: Removed.
        * bindings/js/ScriptValue.cpp:
        (WebCore::ScriptValue::quarantineValue):
        * bindings/js/ScriptValue.h:
        * bindings/v8/ScriptObjectQuarantine.cpp: Removed.
        * bindings/v8/ScriptObjectQuarantine.h: Removed.
        * bindings/v8/ScriptValue.h:
        (WebCore::ScriptValue::quarantineValue):
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage):
        * inspector/InspectorController.c...
      2aadf6dc
    • ossy@webkit.org's avatar
      [Qt] r51577 made fast/frames/sandboxed-iframe-plugins.html crash. · 38dd27ea
      ossy@webkit.org authored 
      * platform/qt/Skipped: 
- fast/frames/sandboxed-iframe-navigation-windowopen.html added. (crasher)



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38dd27ea
    • eric@webkit.org's avatar
      2009-12-02 Adam Barth <abarth@webkit.org> · 32371a87
      eric@webkit.org authored 
              Reviewed by Eric Seidel.

        [bzt] build-attachment shouldn't check whether the builders are red
        https://bugs.webkit.org/show_bug.cgi?id=32062

        build-attachment doesn't touch the remote repository, so there isn't a
        need to hold off when the builders are red.

        * Scripts/modules/commands/download.py:
        * Scripts/modules/landingsequence.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32371a87
    • eric@webkit.org's avatar
      2009-12-02 Eric Seidel <eric@webkit.org> · 437aabef
      eric@webkit.org authored 
              Reviewed by Adam Barth.

        REGRESSION(51590): style-queue and build-queue think their empty when they are not
        https://bugs.webkit.org/show_bug.cgi?id=32061

        * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
        * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      437aabef
    • ossy@webkit.org's avatar
      [Qt] Unreviewed. Skip new tests. · 61d43501
      ossy@webkit.org authored 
      * platform/qt/Skipped:
- svg/custom/mask-with-all-units.svg added.
- fast/css/namespaces/namespaces-comments.xml added.
- fast/css/namespaces/namespaces-empty.xml added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61d43501
    • eric@webkit.org's avatar
      2009-12-02 Eric Seidel <eric@webkit.org> · e061bef6
      eric@webkit.org authored 
              Reviewed by Adam Barth.

        build-queue is throwing exceptions and complaining about
        lack of --no-update on build-attachment.  Make it stop.

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/commands/download.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e061bef6
    • abarth@webkit.org's avatar
      2009-12-02 Adam Barth <abarth@webkit.org> · ceee978f
      abarth@webkit.org authored 
              Unreviewed "build" fix.  Forgot to declare my variables.  :(

        * QueueStatusServer/queue_status.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ceee978f
    • eric@webkit.org's avatar
      2009-12-02 Adam Barth <abarth@webkit.org> · 59b29506
      eric@webkit.org authored 
              Reviewed by Eric Seidel.

        [bzt] Implement status bubble view
        https://bugs.webkit.org/show_bug.cgi?id=32057

        The status bubble is a compact representation of the queue status for a
        given patch.  This will eventually help us reduce the comment spam from
        the queues.

        * QueueStatusServer/index.html: Added HTML5 doctype for sanity.
        * QueueStatusServer/queue_status.py:
        * QueueStatusServer/status_bubble.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59b29506
    • eric@webkit.org's avatar
      2009-12-02 Eric Seidel <eric@webkit.org> · 804478e1
      eric@webkit.org authored 
              Reviewed by Adam Barth.

        trim commands/*.py includes now that commands are unit tested
        https://bugs.webkit.org/show_bug.cgi?id=32056

        In the course of ensuring that the unit tests still
        passed after this change, I had to actually make them
        pass in the first place.

        * Scripts/modules/bugzilla.py:
         - Fix _parse_attachment_ids_request_query to return ints instead of strings.
        * Scripts/modules/commands/download.py: Remove unneeded imports.
        * Scripts/modules/commands/queries.py: Ditto.
        * Scripts/modules/commands/queues.py: Ditto.
        * Scripts/modules/commands/upload.py: Ditto.
        * Scripts/modules/scm_unittest.py:
         - Fix to expect the \n after the path since echo adds an \n.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      804478e1
    • ukai@chromium.org's avatar
      2009-12-02 Fumitoshi Ukai <ukai@chromium.org> · 35d8c016
      ukai@chromium.org authored 
              Reviewed by Alexey Proskuryakov.

        WebSocket handshake check query component of URL
        https://bugs.webkit.org/show_bug.cgi?id=31617

        * websocket/tests/echo-location_wsh.py: Added.
        * websocket/tests/no-query_wsh.py: Added.
        * websocket/tests/script-tests/url-with-credential.js: Added.
        * websocket/tests/script-tests/url-with-empty-query.js: Added.
        * websocket/tests/script-tests/url-with-fragment.js: Added.
        * websocket/tests/script-tests/url-with-query-for-no-query.js: Added.
        * websocket/tests/script-tests/url-with-query.js: Added.
        * websocket/tests/url-with-credential-expected.txt: Added.
        * websocket/tests/url-with-credential.html: Added.
        * websocket/tests/url-with-empty-query-expected.txt: Added.
        * websocket/tests/url-with-empty-query.html: Added.
        * websocket/tests/url-with-fragment-expected.txt: Added.
        * websocket/tests/url-with-fragment.html: Added.
        * websocket/tests/url-with-query-expected.txt: Added.
        * websocket/tests/url-with-query-for-no-query-expected.txt: Added.
        * websocket/tests/url-with-query-for-no-query.html: Added.
        * websocket/tests/url-with-query.html: Added.
2009-12-02  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        WebSocket handshake check query component of URL
        https://bugs.webkit.org/show_bug.cgi?id=31617

        Tests: websocket/tests/url-with-credential.html
               websocket/tests/url-with-empty-query.html
               websocket/tests/url-with-fragment.html
               websocket/tests/url-with-query-for-no-query.html
               websocket/tests/url-with-query.html

        * platform/KURLGoogle.cpp:
        (WebCore::KURL::query): returns a null if query is not specified and returns an empty if query is specified but empty.
        * websockets/WebSocketHandshake.cpp:
        (WebCore::resourceName): added. add query component to path if specified.
        (WebCore::WebSocketHandshake::clientLocation):
        (WebCore::WebSocketHandshake::clientHandshakeMessage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35d8c016
  3. 01 Dec, 2009 27 commits