1. 24 Feb, 2006 27 commits
    • antti's avatar
      Reviewed by Hyatt. · 6bead9c2
      antti authored
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7440
              Floats not positioned correctly
      
              * fast/block/float/multiple-float-positioning-expected.checksum: Added.
              * fast/block/float/multiple-float-positioning-expected.png: Added.
              * fast/block/float/multiple-float-positioning-expected.txt: Added.
              * fast/block/float/multiple-float-positioning.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12988 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bead9c2
    • antti's avatar
      Reviewed by Hyatt. · 4851572d
      antti authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7440
              Floats not positioned correctly
      
              Test: fast/block/float/multiple-float-positioning.html
      
              * rendering/RenderBlock.cpp: 
              (WebCore::RenderBlock::positionNewFloats): Correct iteration of the float list
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4851572d
    • justing's avatar
      LayoutTests: · 68658dd7
      justing authored
              Reviewed by justin
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=6933>
              Selection extends beyond focus ring for some contentEditable divs
      
              * editing/selection/extend-by-word-002-expected.checksum:
              * editing/selection/extend-by-word-002-expected.png:
              * editing/selection/select-all-001-expected.checksum:
              * editing/selection/select-all-001-expected.png:
              * editing/selection/select-all-002-expected.checksum:
              * editing/selection/select-all-002-expected.png:
      
      WebCore:
      
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=6933>
              Selection extends beyond focus ring for some contentEditable divs
      
              Reviewed by justin
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::isSelectionRoot): Have root editable elements paint their
              own selection gaps.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68658dd7
    • darin's avatar
      LayoutTests: · eca8abf8
      darin authored
              - test <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com
                in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188)
      
              * fast/dom/Window/redirect-with-timer.html: Added.
              * fast/dom/Window/redirect-with-timer-expected.txt: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              - fix <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com
                in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188)
      
              Test: fast/dom/Window/redirect-with-timer.html
      
              * platform/Timer.h: Made isActive no longer inline. Added inHeap function.
              * platform/Timer.cpp: Changed assertions to use inHeap function for clarity.
              (WebCore::TimerBase::isActive): Return true for timers that are ready to fire.
              They have a next fire time of 0, but they should still be considered active.
              (WebCore::TimerBase::checkConsistency): Correct the consistency check. The new
              rule is that timers with a next fire time of 0 are not in the heap, and all other
              timers are.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eca8abf8
    • justing's avatar
      LayoutTests: · d2045190
      justing authored
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=7245>
              caret does not display at the end of some lines in contenteditable divs
      
              Reviewed by justin
      
              * editing/deleting/delete-block-merge-contents-018-expected.txt:
              * editing/deleting/delete-block-merge-contents-021-expected.txt:
              * editing/deleting/delete-line-end-ws-001-expected.txt:
              * editing/deleting/delete-line-end-ws-002-expected.txt:
              * editing/deleting/forward-delete-expected.txt:
              * editing/execCommand/boldSelection-expected.txt:
              * editing/execCommand/italicizeByCharacter-expected.txt:
              * editing/execCommand/modifyForeColorByCharacter-expected.txt:
              * editing/execCommand/print-expected.txt:
              * editing/execCommand/selectAll-expected.txt:
              * editing/execCommand/strikethroughSelection-expected.txt:
              * editing/inserting/insert-div-019-expected.txt:
              * editing/inserting/insert-div-027-expected.txt:
              * editing/inserting/typing-003-expected.txt:
              * editing/pasteboard/paste-text-012-expected.txt:
              * editing/pasteboard/paste-text-013-expected.txt:
              * editing/pasteboard/paste-text-014-expected.txt:
              * editing/selection/extend-by-character-003-expected.txt:
              * editing/selection/extend-by-character-005-expected.txt:
              * editing/selection/extend-by-word-002-expected.checksum:
              * editing/selection/extend-by-word-002-expected.png:
              * editing/selection/extend-by-word-002-expected.txt:
              * editing/selection/move-by-character-003-expected.txt:
              * editing/selection/move-by-character-005-expected.txt:
              * editing/selection/select-all-001-expected.txt:
              * editing/selection/select-all-002-expected.checksum:
              * editing/selection/select-all-002-expected.png:
              * editing/selection/select-all-002-expected.txt:
              * editing/selection/select-all-003-expected.txt:
              * editing/style/create-block-for-style-001-expected.txt:
              * editing/style/create-block-for-style-002-expected.txt:
              * editing/style/create-block-for-style-003-expected.txt:
              * editing/style/create-block-for-style-004-expected.txt:
              * editing/style/create-block-for-style-005-expected.txt:
              * editing/style/create-block-for-style-006-expected.txt:
              * editing/style/create-block-for-style-007-expected.txt:
              * editing/style/create-block-for-style-008-expected.txt:
              * editing/style/create-block-for-style-009-expected.txt:
              * editing/style/create-block-for-style-010-expected.txt:
              * editing/style/create-block-for-style-011-expected.txt:
              * editing/style/create-block-for-style-012-expected.txt:
              * editing/style/create-block-for-style-013-expected.txt:
              * editing/style/relative-font-size-change-001-expected.txt:
              * editing/style/relative-font-size-change-002-expected.txt:
              * editing/style/relative-font-size-change-003-expected.txt:
              * editing/style/relative-font-size-change-004-expected.txt:
              * fast/clip/outline-overflowClip-expected.txt:
              * fast/overflow/overflow-focus-ring-expected.checksum:
              * fast/overflow/overflow-focus-ring-expected.png:
              * fast/overflow/overflow-focus-ring-expected.txt:
              * fast/text/justified-text-rect-expected.checksum:
              * fast/text/justified-text-rect-expected.png:
              * fast/text/justified-text-rect-expected.txt:
              * fast/text/justified-text-rect.html:
      
      WebCore:
      
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=7245>
              caret does not display at the end of some lines in contenteditable divs
      
              Reviewed by justin
      
              * khtml/html/HTMLElementImpl.cpp:
              (WebCore::HTMLElementImpl::setContentEditable):
              * page/Frame.cpp:
              (WebCore::Frame::applyEditingStyleToElement):
              (WebCore::Frame::removeEditingStyleFromElement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2045190
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · 965e8427
      eseidel authored
              Reviewed by mjs.
      
              Move dom_qname to QualifiedName and dom_atomicstringlist to AtomicStringList.
      
              * WebCore+SVG/KDOMHeaders.h:
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * css/css_base.h:
              * dom/AtomicStringList.h: Added.
              (WebCore::AtomicStringList::AtomicStringList):
              * dom/QualifiedName.cpp: Added.
              * dom/QualifiedName.h: Added.
              * dom/dom_atomicstringlist.h: Removed.
              * dom/dom_elementimpl.h:
              * dom/dom_qname.cpp: Removed.
              * dom/dom_qname.h: Removed.
              * editing/RemoveNodeAttributeCommand.h:
              * editing/SetNodeAttributeCommand.h:
              * khtml/html/htmlnames.h:
              * khtml/html/htmltokenizer.h:
              * ksvg2/scripts/make_names.pl: update for new headers
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      965e8427
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · dd1c709a
      eseidel authored
              Reviewed by beth.
      
              Made a few methods on frame pure virtual.
              Added a bunch of stub functions for win32 linking.
      
              * bridge/mac/MacFrame.h:
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::print):
              (WebCore::MacFrame::canUndo):
              (WebCore::MacFrame::canRedo):
              (WebCore::MacFrame::canPaste):
              * bridge/win/FrameWin.h:
              * page/Frame.h:
              * platform/win/TemporaryLinkStubs.cpp:
              (QTextEdit::sizeWithColumnsAndRows):
              (QLineEdit::maxLength):
              (QPainter::drawEllipse):
              (QTextEdit::setLineHeight):
              (QPainter::beginTransparencyLayer):
              (QLineEdit::selectedText):
              (Widget::setIsSelected):
              (QPainter::paintingDisabled):
              (QFontMetrics::selectionRectForText):
              (QTextEdit::getCursorPosition):
              (QSlider::QSlider):
              (WebCore::crossCursor):
              (WebCore::handCursor):
              (WebCore::moveCursor):
              (WebCore::iBeamCursor):
              (WebCore::waitCursor):
              (WebCore::helpCursor):
              (WebCore::eastResizeCursor):
              (WebCore::northResizeCursor):
              (WebCore::northEastResizeCursor):
              (WebCore::northWestResizeCursor):
              (WebCore::southResizeCursor):
              (WebCore::southEastResizeCursor):
              (WebCore::southWestResizeCursor):
              (WebCore::westResizeCursor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd1c709a
    • ggaren's avatar
      LayoutTests: · bb167e66
      ggaren authored
              Reviewed by Hyatt.
      
              -tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=5146
      
              * fast/replaced/maxheight-percent.html: Added.
              * fast/replaced/maxheight-pxs.html: Added.
              * fast/replaced/maxwidth-percent.html: Added.
              * fast/replaced/maxwidth-pxs.html: Added.
              * fast/replaced/minheight-percent.html: Added.
              * fast/replaced/minheight-pxs.html: Added.
              * fast/replaced/minwidth-percent.html: Added.
              * fast/replaced/minwidth-pxs.html: Added.
              * fast/replaced/resources/1x1-blue.png: Added.
              * fast/replaced/resources/square-blue-100x100.png: Added.
      
      WebCore:
      
              Reviewed by Hyatt, tweaked and landed by ggaren.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5146
                max-height/max-width not resizing images with correct aspect ratio
      
              This patch is a port and adaptation of Allan Sandfeld Jensen's (carewolf)
              patch of http://bugs.kde.org/show_bug.cgi?id=120107 with the needed
              modifications to suit the Webcore tree.  Makes images respect min/max 
              sizes and their intrinsic aspect ratios at the same time according to 
              CSS 2.1 (http://www.w3.org/TR/CSS21/visudet.html#min-max-widths).  
      
              Test: fast/replaced/maxheight-percent.html
              Test: fast/replaced/maxheight-pxs.html
              Test: fast/replaced/maxwidth-percent.html
              Test: fast/replaced/maxwidth-pxs.html
              Test: fast/replaced/minheight-percent.html
              Test: fast/replaced/minheight-pxs.html
              Test: fast/replaced/minwidth-percent.html
              Test: fast/replaced/minwidth-pxs.html
      
              * rendering/render_box.cpp:
              (WebCore::RenderBox::calcReplacedWidth):
              (WebCore::RenderBox::calcReplacedWidthUsing):
              (WebCore::RenderBox::calcReplacedHeight): 
              (WebCore::RenderBox::calcReplacedHeightUsing): Calculate percent heights correctly
              * rendering/render_image.cpp: Respect aspect ratios and calculate max/min
              (WebCore::RenderImage::calcReplacedWidth):
              (WebCore::RenderImage::calcReplacedHeight):
              (WebCore::RenderImage::calcAspectRatioWidth): Added
              (WebCore::RenderImage::calcAspectRatioHeight): Added
              (WebCore::RenderImage::calcMinMaxWidth): Added
              * rendering/render_image.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb167e66
    • vicki's avatar
      - add missing resources for manual-tests/scrolling-nestedframesets.html · 36c472f2
      vicki authored
              * manual-tests/resources/testframe-link_text.html: Added.
              * manual-tests/resources/testframeset.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36c472f2
    • vicki's avatar
      - test case for <rdar://problem/4394910> calling Javascript... · a1c0d00c
      vicki authored
              - test case for <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event
      
              * manual-tests/onbeforeunload-close_with_javascript.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1c0d00c
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · 0a5c4e11
      eseidel authored
              Reviewed by mjs.
      
              Add Path stubs for Win32 build.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * platform/win/TemporaryLinkStubs.cpp:
              (Path::Path):
              (Path::~Path):
              (Path::operator=):
              (Path::contains):
              (Path::translate):
              (Path::boundingRect):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a5c4e11
    • hyatt's avatar
      In preparation for the elimination of QFont and QFontMetrics, rename... · 3e99d1ca
      hyatt authored
              In preparation for the elimination of QFont and QFontMetrics, rename methods on RenderStyle.  htmlFont() becomes simply
              font().  The old font() method turns into qfont().  Also added a helper for obtaining the fontDescription() directly from
              the RenderStyle (without first obtaining the htmlFont()).
      
              Reviewed by darin
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/objc/DOM.mm:
              (-[DOMElement _font]):
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::attributedString):
              (WebCore::MacFrame::fontForSelection):
              (WebCore::MacFrame::fontAttributesForSelectionStart):
              * css/css_computedstyle.cpp:
              (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
              * css/css_valueimpl.cpp:
              (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::styleForElement):
              (WebCore::CSSStyleSelector::pseudoStyleForElement):
              (WebCore::CSSStyleSelector::applyProperty):
              (WebCore::CSSStyleSelector::checkForTextSizeAdjust):
              (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
              * dom/DocumentImpl.cpp:
              (WebCore::DocumentImpl::recalcStyle):
              * editing/visible_text.cpp:
              (khtml::TextIterator::exitNode):
              * ksvg2/svg/SVGLengthImpl.cpp:
              (SVGLengthImpl::updateValue):
              * kwq/KWQAccObject.mm:
              (AXAttributeStringSetStyle):
              * rendering/InlineTextBox.cpp:
              (khtml::InlineTextBox::paint):
              (khtml::InlineTextBox::offsetForPosition):
              * rendering/RenderText.cpp:
              (WebCore::RenderText::shouldUseMonospaceCache):
              (WebCore::RenderText::font):
              (WebCore::RenderText::width):
              (WebCore::RenderText::htmlFont):
              * rendering/bidi.cpp:
              (khtml::RenderBlock::tabWidth):
              (khtml::RenderBlock::checkLinesForTextOverflow):
              * rendering/render_br.cpp:
              (WebCore::RenderBR::lineHeight):
              * rendering/render_flexbox.cpp:
              (khtml::RenderFlexibleBox::layoutVerticalBox):
              * rendering/render_flow.cpp:
              (WebCore::RenderFlow::lineHeight):
              * rendering/render_form.cpp:
              (WebCore::RenderFormElement::setStyle):
              (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed):
              * rendering/render_image.cpp:
              (WebCore::RenderImage::paint):
              * rendering/render_line.cpp:
              (WebCore::InlineFlowBox::paintDecorations):
              (WebCore::EllipsisBox::paint):
              * rendering/render_list.cpp:
              (RenderListItem::getAbsoluteRepaintRect):
              (RenderListMarker::paint):
              * rendering/render_object.cpp:
              (WebCore::RenderObject::lineHeight):
              * rendering/render_object.h:
              (WebCore::RenderObject::font):
              * rendering/render_replaced.cpp:
              (WebCore::RenderWidget::setStyle):
              * rendering/render_style.h:
              (khtml::RenderStyle::font):
              (khtml::RenderStyle::fontDescription):
              (khtml::RenderStyle::qfont):
              * rendering/render_theme_mac.mm:
              (WebCore::RenderThemeMac::setFontFromControlSize):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e99d1ca
    • mjs's avatar
      Reviewed by Eric. · 5f101cc5
      mjs authored
              - add link stubs for symbols only referenced from the link stubs file
      
              * platform/win/TemporaryLinkStubs.cpp:
              (KWQFileButton::focusPolicy):
              (QLineEdit::checksDescendantsForFocus):
              (KWQFileButton::baselinePosition):
              (QSlider::~QSlider):
              (QListBox::~QListBox):
              (KWQFileButton::frameGeometry):
              (KWQFileButton::~KWQFileButton):
              (QTextEdit::focusPolicy):
              (QSlider::focusPolicy):
              (QListBox::setEnabled):
              (QListBox::checksDescendantsForFocus):
              (QListBox::focusPolicy):
              (QLineEdit::baselinePosition):
              (QSlider::sizeHint):
              (QLineEdit::~QLineEdit):
              (QTextEdit::~QTextEdit):
              (QTextEdit::checksDescendantsForFocus):
              (QLineEdit::focusPolicy):
              (QScrollBar::~QScrollBar):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f101cc5
    • mjs's avatar
      Rubber stamped by Eric. · adbc41c4
      mjs authored
              - fix up font.h inclues to be Font.h to fix build.
      
              * css/css_computedstyle.cpp:
              * css/css_valueimpl.cpp:
              * platform/Font.cpp:
              * rendering/render_style.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adbc41c4
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · ea3d23dc
      eseidel authored
              Reviewed by mjs.
      
              Fix mac build by changing constants to an enum.
      
              * khtml/dom/dom2_events.h:
              (DOM::KeyboardEvent::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea3d23dc
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · 517bbfdd
      eseidel authored
              Reviewed by mjs.
      
              Make DumpRenderTree link against icu.
      
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      517bbfdd
    • hyatt's avatar
      Move rendering/font to platform/Font. · ec364eee
      hyatt authored
              Reviewed by mjs
      
              * WebCore.xcodeproj/project.pbxproj:
              * css/cssstyleselector.cpp:
              * platform/Font.cpp: Added.
              * platform/Font.h: Added.
              * rendering/font.cpp: Removed.
              * rendering/font.h: Removed.
              * rendering/render_theme_mac.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec364eee
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · f16ca9fa
      eseidel authored
              Reviewed by mjs.
      
              Remove delcarations causing duplicate symbols on win32.
      
              * khtml/dom/dom2_events.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f16ca9fa
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · 30922b56
      eseidel authored
              * bridge/win/FrameWin.cpp: fix line endings
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30922b56
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · b8be970c
      eseidel authored
              Reviewed by mjs.
      
              Make DumpRenderTree link against libxml, etc.
      
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8be970c
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · 3bc58845
      eseidel authored
              Reviewed by beth.
      
              Removed WebCore:: prefixes added using namespace WebCore, fixes win32 build.
      
              * platform/win/TemporaryLinkStubs.cpp:
              (QPainter::save):
              (Widget::enableFlushDrawing):
              (QPainter::drawHighlightForText):
              (QTextEdit::textWithHardLineBreaks):
              (QPainter::setPen):
              (QPainter::selectedTextBackgroundColor):
              (QPainter::fontMetrics):
              (Widget::show):
              (QLineEdit::setWritingDirection):
              (KWQFileButton::sizeForCharacterWidth):
              (QTextEdit::sizeWithColumnsAndRows):
              (iBeamCursor):
              (QPainter::misspellingLineThickness):
              (westResizeCursor):
              (Widget::isEnabled):
              (northWestResizeCursor):
              (QPainter::drawEllipse):
              (southWestResizeCursor):
              (Widget::focusPolicy):
              (waitCursor):
              (QPainter::endTransparencyLayer):
              (ScrollView::addChild):
              (Widget::~Widget):
              (QListBox::sizeForNumberOfLines):
              (FrameView::updateBorder):
              (QPainter::drawLineForText):
              (QPainter::QPainter):
              (QComboBox::focusPolicy):
              (QPainter::drawImageAtPoint):
              (QPainter::clearShadow):
              (eastResizeCursor):
              (QFontMetrics::boundingRect):
              (QPainter::beginTransparencyLayer):
              (northEastResizeCursor):
              (Widget::frameGeometry):
              (QPainter::addFocusRingRect):
              (QPainter::restore):
              (Widget::setEnabled):
              (QPainter::font):
              (QPainter::pen):
              (crossCursor):
              (Widget::setIsSelected):
              (handCursor):
              (QLineEdit::text):
              (Widget::unlockDrawingFocus):
              (QPainter::paintingDisabled):
              (northResizeCursor):
              (Widget::lockDrawingFocus):
              (QPainter::drawLine):
              (QPainter::setBrush):
              (QPainter::drawText):
              (QLineEdit::sizeForCharacterWidth):
              (Cursor::~Cursor):
              (QFontMetrics::selectionRectForText):
              (southResizeCursor):
              (moveCursor):
              (FrameView::isFrameView):
              (helpCursor):
              (QTextEdit::setWritingDirection):
              (Widget::setDrawingAlpha):
              (southEastResizeCursor):
              (QPainter::drawScaledAndTiledImage):
              (QPainter::drawImage):
              (QComboBox::setWritingDirection):
              (QComboBox::sizeHint):
              (QPainter::drawRect):
              (QPainter::drawTiledImage):
              (QPainter::clearFocusRing):
              (Widget::Widget):
              (QTextEdit::text):
              (QPainter::drawImageInRect):
              (Widget::disableFlushDrawing):
              (QPainter::initFocusRing):
              (QPainter::drawLineForMisspelling):
              (QComboBox::frameGeometry):
              (QListBox::setWritingDirection):
              (ScrollView::updateContents):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bc58845
    • darin's avatar
      Reviewed by Hyatt. · 6fb0fdcd
      darin authored
              - moved QScrollView from kwq to platform directory
      
              * kwq/KWQScrollView.h: Removed.
              * kwq/KWQScrollView.mm: Removed.
      
              * platform/ScrollBarMode.h: Added. Just the enum for scroll bar mode.
              * platform/ScrollView.h: Added. The rest of the former QScrollView.
              * platform/mac/ScrollViewMac.mm: Added.
      
              * WebCore.xcodeproj/project.pbxproj: Updated.
              * WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
              * platform/win/TemporaryLinkStubs.cpp: Updated.
      
              * bridge/mac/MacFrame.mm: (WebCore::MacFrame::createFrame):
              * khtml/html/html_baseimpl.cpp:
              (WebCore::HTMLFrameElementImpl::init):
              (WebCore::HTMLFrameElementImpl::parseMappedAttribute):
              * page/Frame.cpp: (WebCore::Frame::scrollbarsVisible):
              Changed scrolling constants to use new names.
      
              * khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::bodySetter):
              Use FrameView instead of QScrollView for a local variable.
      
              * khtml/html/html_baseimpl.h: Use ScrollBarMode instead of
              QScrollView::ScrollBarMode.
      
              * kwq/KWQListBox.h: Use WebCore::ScrollView instead of
              QScrollView and WebCore::ScrollBarMode instead of QScrollView::ScrollBarMode.
              * kwq/KWQTextEdit.h: Ditto.
              * kwq/KWQTextEdit.mm:
              (QTextEdit::setScrollBarModes): Ditto.
              (QTextEdit::focusPolicy): Ditto.
      
              * page/FrameView.h:
              * page/FrameView.cpp:
              (WebCore::FrameViewPrivate::FrameViewPrivate): Use ScrollBarMode
              instead of QScrollView::ScrollBarMode.
              (WebCore::FrameView::FrameView): Remove mention of QScrollView.
              (WebCore::FrameView::resetScrollBars): Rename QScrollView to ScrollView.
              (WebCore::FrameView::applyOverflowToViewport): Use newly-named constants.
              (WebCore::FrameView::layout): Ditto.
              (WebCore::FrameView::setScrollBarsMode): Rename QScrollView to ScrollView.
              (WebCore::FrameView::setVScrollBarMode): Ditto.
              (WebCore::FrameView::setHScrollBarMode): Ditto.
              (WebCore::FrameView::restoreScrollBar): Ditto.
      
              * platform/mac/MouseEventMac.mm: (WebCore::positionForEvent): Fixed comment.
              * platform/mac/WheelEventMac.mm: (WebCore::positionForEvent): Ditto.
              * platform/mac/WidgetMac.mm: (WebCore::Widget::getOuterView): Ditto.
      
              * rendering/render_form.cpp: (WebCore::RenderTextArea::setStyle):
              Use ScrollBarMode instead of QScrollView::ScrollBarMode, and new constants.
              * rendering/render_frames.cpp:
              (WebCore::RenderFrameSet::userResize): Changed to use an IntRect to pass to
              updateContents so we can remove the overload.
              (WebCore::RenderPart::updateWidgetPosition): Remove unnecessary of QScrollView.
      
              * rendering/render_layer.cpp:
              (WebCore::RenderLayer::scrollRectToVisible): Use FrameView instead of QScrollView.
              (WebCore::RenderLayer::setHasHorizontalScrollbar): Ditto.
              (WebCore::RenderLayer::setHasVerticalScrollbar): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fb0fdcd
    • andersca's avatar
      2006-02-24 Mitz Pettel <opendarwin.org@mitzpettel.com> · 83afa1b4
      andersca authored
              Reviewed and landed by Anders.
              
              Prevent rendering to the offscreen window. -[NSWindow displayIfNeeded] was
              getting called from the run loop, making the view render each test and thus slowing
              down the tests.
      
              * DumpRenderTree/DumpRenderTree.m:
              (main): Set the offscreen window to not autodisplay.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83afa1b4
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · f148eebe
      eseidel authored
              Reviewed by anders.
      
              Fix the win32 build.
      
              * page/Frame.cpp:
              (WebCore::Frame::adjustPageHeight):
              (WebCore::Frame::forceLayoutWithPageWidthRange):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f148eebe
    • ap's avatar
      Reviewed by Darin. · 2fdcd478
      ap authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=7435
                Add Ian Hickson's XMLHttpRequest tests
      
              * http/conf/httpd.conf: Enable send-as-is handler, required by the tests.
              * http/tests/xmlhttprequest/web-apps: Added (recursively).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fdcd478
    • hyatt's avatar
      Rename FontDef to FontDescription and move it into the platform directory. · 1bb126c4
      hyatt authored
              Reviewed by darin
      
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::attributedString):
              * css/css_computedstyle.cpp:
              (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
              * css/css_valueimpl.cpp:
              (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              (WebCore::CSSStyleSelector::checkForTextSizeAdjust):
              (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
              (WebCore::CSSStyleSelector::setFontSize):
              * css/cssstyleselector.h:
              * dom/DocumentImpl.cpp:
              (WebCore::DocumentImpl::recalcStyle):
              * editing/visible_text.cpp:
              (khtml::TextIterator::exitNode):
              * platform/FontDescription.h: Added.
              (WebCore::FontDescription::):
              (WebCore::FontDescription::FontDescription):
              (WebCore::FontDescription::operator!=):
              (WebCore::FontDescription::family):
              (WebCore::FontDescription::firstFamily):
              (WebCore::FontDescription::specifiedSize):
              (WebCore::FontDescription::computedSize):
              (WebCore::FontDescription::italic):
              (WebCore::FontDescription::computedPixelSize):
              (WebCore::FontDescription::smallCaps):
              (WebCore::FontDescription::isAbsoluteSize):
              (WebCore::FontDescription::weight):
              (WebCore::FontDescription::genericFamily):
              (WebCore::FontDescription::usePrinterFont):
              (WebCore::FontDescription::setFamily):
              (WebCore::FontDescription::setComputedSize):
              (WebCore::FontDescription::setSpecifiedSize):
              (WebCore::FontDescription::setItalic):
              (WebCore::FontDescription::setSmallCaps):
              (WebCore::FontDescription::setIsAbsoluteSize):
              (WebCore::FontDescription::setWeight):
              (WebCore::FontDescription::setGenericFamily):
              (WebCore::FontDescription::setUsePrinterFont):
              (WebCore::FontDescription::operator==):
              * rendering/RenderText.cpp:
              (WebCore::RenderText::widthFromCache):
              (WebCore::RenderText::trimmedMinMaxWidth):
              * rendering/bidi.cpp:
              (khtml::RenderBlock::computeHorizontalPositionsForLine):
              * rendering/font.cpp:
              (khtml::Font::selectionRectForText):
              (khtml::Font::drawHighlightForText):
              (khtml::Font::drawText):
              (khtml::Font::update):
              * rendering/font.h:
              (WebCore::Font::Font):
              (WebCore::Font::operator==):
              (WebCore::Font::fontDescription):
              (WebCore::Font::isSmallCaps):
              (WebCore::Font::wordSpacing):
              (WebCore::Font::floatWidth):
              (WebCore::Font::checkSelectionPoint):
              (WebCore::Font::width):
              * rendering/render_line.cpp:
              (WebCore::InlineFlowBox::placeBoxesHorizontally):
              * rendering/render_list.cpp:
              (RenderListItem::getAbsoluteRepaintRect):
              * rendering/render_style.h:
              (khtml::RenderStyle::wordSpacing):
              (khtml::RenderStyle::letterSpacing):
              (khtml::RenderStyle::setFontDescription):
              (khtml::RenderStyle::setWordSpacing):
              (khtml::RenderStyle::setLetterSpacing):
              * rendering/render_theme_mac.mm:
              (WebCore::RenderThemeMac::setFontFromControlSize):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bb126c4
    • mjs's avatar
      - fix build by making some pointless changes to files that Xcode doesn't · 04973112
      mjs authored
              rebuild otherwise
      
              * bindings/js/JSDOMCore.cpp:
              * bindings/js/JSDOMEvents.cpp:
              * dom/Element.idl:
              * dom/WheelEvent.idl:
              
              - add -Y 3 flag to linking; this makes the linker say what files reference 
              unresolved symbols
              
              * WebCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04973112
  2. 23 Feb, 2006 13 commits
    • darin's avatar
      - try to fix buildbot failure · adae7a93
      darin authored
              * bindings/c/c_utility.cpp: Touch this file, which seems to not have been
              recompiled after additional inlining was introduced (Xcode bug?).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adae7a93
    • darin's avatar
      - try to fix Windows build · 83f99d9b
      darin authored
              * platform/win/TemporaryLinkStubs.cpp: Removed childX/Y stubs.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83f99d9b
    • darin's avatar
      - fix Windows build · 11cc9b0d
      darin authored
              * platform/win/TemporaryLinkStubs.cpp: Removed QPalette-related stubs
      
              - remove unused forwarding headers
      
              * ForwardingHeaders/kurl.h: Removed.
              * ForwardingHeaders/qlist.h: Removed.
              * ForwardingHeaders/qregion.h: Removed.
              * ForwardingHeaders/qsortedlist.h: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11cc9b0d
    • darin's avatar
      Reviewed by Maciej. · 5ed43097
      darin authored
              - removed QPalette, QRegion, QPrinter
              - added Path to replace QRegion
              - removed unused QScrollView functions
      
              * ForwardingHeaders/qpalette.h: Removed.
              * kwq/KWQPalette.h: Removed.
              * kwq/KWQPalette.mm: Removed.
              * kwq/KWQPrinter.h: Removed.
              * kwq/KWQRegion.cpp: Removed.
              * kwq/KWQRegion.h: Removed.
      
              * platform/Path.h: Added. Replaces QRegion.
              * platform/cg: Added.
              * platform/cg/PathCG.cpp: Added.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj: Updated for file changes.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
      
              * bridge/mac/MacFrame.mm: Removed use of KWQPrinter.h.
              (WebCore::MacFrame::khtmlMouseMoveEvent): Removed use of viewport().
              * bridge/mac/WebCoreFrameBridge.mm: Removed use of KWQPrinter.h.
              * khtml/html/html_imageimpl.cpp:
              (WebCore::HTMLAreaElementImpl::getRect): Replaced QRegion with Path.
              (WebCore::HTMLAreaElementImpl::getRegion): Ditto.
              * khtml/html/html_imageimpl.h: Ditto.
              * kwq/KWQPainter.mm: Removed use of QRegion.
              * page/Frame.cpp: (WebCore::Frame::~Frame): Removed use of viewport().
              * page/FrameView.cpp:
              (WebCore::FrameView::FrameView): Ditto.
              (WebCore::FrameView::viewportMouseMoveEvent): Ditto.
              * rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize): Ditto.
              * rendering/render_layer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Ditto.
      
              * kwq/KWQScrollView.h: Removed viewport(), hasVerticalScrollBar(),
              hasHorizontalScrollBar(), childX(), childY().
              * kwq/KWQScrollView.mm: Ditto.
      
              * rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
              Removed use of QPalette that always yields white.
              * rendering/render_canvas.cpp: (WebCore::RenderCanvas::paintBoxDecorations):
              Ditto.
      
              * platform/Widget.h:
              * platform/mac/WidgetMac.mm: Removed palette() and setPalette().
      
              * kwq/KWQLineEdit.h: Replaced setPalette with setColors.
              * kwq/KWQLineEdit.mm: (QLineEdit::setColors): Replaced setPalette.
              * kwq/KWQTextEdit.h: Ditto.
              * kwq/KWQTextEdit.mm: (QTextEdit::setColors): Ditto.
      
              * rendering/render_form.cpp:
              (WebCore::RenderFormElement::updateFromElement): Removed call to setPalette.
              (WebCore::RenderLineEdit::updateFromElement): Added call to setColors.
              (WebCore::RenderTextArea::updateFromElement): Ditto.
      
              * rendering/render_replaced.cpp: (WebCore::RenderWidget::paint):
              Removed use of childX and childY functions.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ed43097
    • mjs's avatar
      Reviewed by Darin. · 54023cf9
      mjs authored
              - add KURL to windows build and fix its compile issues
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7439
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * platform/KURL.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54023cf9
    • mjs's avatar
      - fix build (header name changed) · 48ec2dc7
      mjs authored
              * platform/mac/KURLMac.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48ec2dc7
    • mjs's avatar
      Reviewed by Eric. · 3bd09266
      mjs authored
              - add temporary stubs that call abort() for functions only called from render and editing code 
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7429
      
              This gets rid of a couple hundred link errors.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * kwq/KWQFontMetrics.h:
              * kwq/KWQSignal.h:
              (KWQSignal::KWQSignal):
              * platform/win/TemporaryLinkStubs.cpp: Added.
              (notImplemented):
              (QLineEdit::selectAll):
              (WebCore::QPainter::save):
              (WebCore::Widget::enableFlushDrawing):
              (WebCore::QPainter::drawHighlightForText):
              (QFont::setPrinterFont):
              (QTextEdit::textWithHardLineBreaks):
              (QLineEdit::cursorPosition):
              (WebCore::QPainter::setPen):
              (WebCore::QPainter::selectedTextBackgroundColor):
              (WebCore::QPainter::fontMetrics):
              (WebCore::Widget::show):
              (QFont::setItalic):
              (QSlider::setValue):
              (QLineEdit::addSearchResult):
              (KWQFileButton::click):
              (QLineEdit::setWritingDirection):
              (KWQFileButton::sizeForCharacterWidth):
              (QTextEdit::sizeWithColumnsAndRows):
              (WebCore::iBeamCursor):
              (QComboBox::clear):
              (WebCore::QPainter::misspellingLineThickness):
              (QLineEdit::maxLength):
              (WebCore::westResizeCursor):
              (WebCore::Widget::isEnabled):
              (WebCore::northWestResizeCursor):
              (QTextEdit::selectionEnd):
              (QFont::determinePitch):
              (QTextEdit::setScrollBarModes):
              (WebCore::QPainter::drawEllipse):
              (WebCore::southWestResizeCursor):
              (QTextEdit::setReadOnly):
              (QListBox::appendItem):
              (WebCore::Widget::focusPolicy):
              (QTextEdit::selectAll):
              (WebCore::waitCursor):
              (WebCore::QPainter::endTransparencyLayer):
              (QScrollView::addChild):
              (QTextEdit::setDisabled):
              (QScrollBar::scroll):
              (WebCore::Widget::~Widget):
              (QListBox::sizeForNumberOfLines):
              (QScrollView::resizeContents):
              (QLineEdit::selectionStart):
              (QLineEdit::QLineEdit):
              (WebCore::FrameView::updateBorder):
              (QLineEdit::hasSelectedText):
              (QListBox::doneAppendingItems):
              (QScrollView::inWindow):
              (QScrollBar::setValue):
              (QTextEdit::hasSelectedText):
              (QTextEdit::selectionStart):
              (QFont::setWeight):
              (QScrollView::scrollXOffset):
              (QListBox::isSelected):
              (QLineEdit::setReadOnly):
              (WebCore::QPainter::drawLineForText):
              (QObject::disconnect):
              (WebCore::QPainter::QPainter):
              (QComboBox::~QComboBox):
              (QComboBox::focusPolicy):
              (WebCore::QPainter::drawImageAtPoint):
              (WebCore::QPainter::clearShadow):
              (QTextEdit::setLineHeight):
              (QMouseEvent::QMouseEvent):
              (WebCore::eastResizeCursor):
              (QScrollBar::setKnobProportion):
              (QFontMetrics::boundingRect):
              (QTextEdit::setSelectionStart):
              (WebCore::QPainter::beginTransparencyLayer):
              (WebCore::northEastResizeCursor):
              (WebCore::Widget::frameGeometry):
              (QListBox::setSelected):
              (WebCore::QPainter::addFocusRingRect):
              (QTextEdit::setCursorPosition):
              (WebCore::QPainter::restore):
              (QFontMetrics::width):
              (WebCore::Widget::setEnabled):
              (QTextEdit::setSelectionEnd):
              (QComboBox::populate):
              (QScrollView::setStaticBackground):
              (WebCore::QPainter::font):
              (QTextEdit::setAlignment):
              (QLineEdit::setCursorPosition):
              (WebCore::Widget::palette):
              (WebCore::QPainter::pen):
              (QFontMetrics::descent):
              (QListBox::QListBox):
              (QFontMetrics::ascent):
              (QLineEdit::selectedText):
              (WebCore::crossCursor):
              (WebCore::Widget::setIsSelected):
              (WebCore::handCursor):
              (QLineEdit::text):
              (WebCore::Widget::unlockDrawingFocus):
              (QLineEdit::setLiveSearch):
              (WebCore::QPainter::paintingDisabled):
              (WebCore::northResizeCursor):
              (QComboBox::QComboBox):
              (QSlider::setMaxValue):
              (WebCore::Widget::lockDrawingFocus):
              (WebCore::QPainter::drawLine):
              (WebCore::QPainter::setBrush):
              (QTextEdit::setSelectionRange):
              (WebCore::QPainter::drawText):
              (QScrollView::scrollPointRecursively):
              (QLineEdit::sizeForCharacterWidth):
              (WebCore::Cursor::~Cursor):
              (QFontMetrics::selectionRectForText):
              (WebCore::southResizeCursor):
              (QScrollView::suppressScrollBars):
              (QFontMetrics::checkSelectionPoint):
              (QTextEdit::getCursorPosition):
              (WebCore::moveCursor):
              (WebCore::FrameView::isFrameView):
              (QScrollBar::setSteps):
              (QLineEdit::setMaxLength):
              (QComboBox::baselinePosition):
              (QComboBox::appendItem):
              (WebCore::helpCursor):
              (QTextEdit::setWritingDirection):
              (WebCore::Widget::setDrawingAlpha):
              (QSlider::QSlider):
              (WebCore::southEastResizeCursor):
              (QScrollView::setVScrollBarMode):
              (WebCore::QPainter::drawScaledAndTiledImage):
              (QScrollView::scrollYOffset):
              (WebCore::QPainter::drawImage):
              (QComboBox::setCurrentItem):
              (QFontMetrics::height):
              (QComboBox::setWritingDirection):
              (QScrollView::setScrollBarsMode):
              (QComboBox::sizeHint):
              (WebCore::QPainter::drawRect):
              (QFont::setPixelSize):
              (QLineEdit::setSelection):
              (QLineEdit::setMaxResults):
              (QListBox::clear):
              (QLineEdit::edited):
              (WebCore::QPainter::drawTiledImage):
              (WebCore::QPainter::clearFocusRing):
              (WebCore::Widget::Widget):
              (QTextEdit::text):
              (WebCore::QPainter::drawImageInRect):
              (WebCore::Widget::disableFlushDrawing):
              (WebCore::QPainter::initFocusRing):
              (QSlider::setMinValue):
              (QTextEdit::setWordWrap):
              (WebCore::QPainter::drawLineForMisspelling):
              (QSlider::value):
              (QListBox::setSelectionMode):
              (QFontMetrics::lineSpacing):
              (QLineEdit::setEdited):
              (QComboBox::frameGeometry):
              (QListBox::setWritingDirection):
              (QLineEdit::setAlignment):
              (QScrollView::updateContents):
              (QFontMetrics::floatWidth):
              (QScrollView::setHScrollBarMode):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bd09266
    • mjs's avatar
      Reviewed by Eric. · c6361a65
      mjs authored
              
              - Move KURL from kwq to platform, make portable
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7437
      
              * WebCore.xcodeproj/project.pbxproj:
              * css/css_ruleimpl.cpp:
              * css/cssparser.cpp:
              * css/cssstyleselector.cpp:
              * dom/DocumentImpl.h:
              * khtml/html/html_baseimpl.cpp:
              * khtml/html/html_documentimpl.cpp:
              * khtml/html/html_headimpl.cpp:
              * khtml/xbl/xbl_binding.cpp:
              * ksvg2/svg/SVGDocumentImpl.cpp:
              * kwq/KWQTextCodec.cpp:
              (QTextCodec::codecForName):
              (QTextCodec::utf8Codec):
              (QTextCodec::codecForNameEightBitOnly):
              (QTextCodec::codecForLocale):
              (QTextCodec::name):
              (QTextCodec::makeDecoder):
              * kwq/KWQTextCodec.h:
              * loader/CachedObject.cpp:
              * loader/DocLoader.cpp:
              * page/Frame.h:
              * platform/KURL.cpp: Added.
              (KURL::decode_string):
              (encodeRelativeString):
              * platform/KURL.h: Added.
              * platform/mac/KURLMac.mm: Added.
              (KURL::getNSURL):
              * xml/xmlhttprequest.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6361a65
    • darin's avatar
      Reviewed by John Sullivan. · 947a31b6
      darin authored
              - moved QMouseEvent, QKeyEvent, QWheelEvent, and "Foundation extras"
                from kwq to platform directory
              - moved history function from kwq to bridge directory
              - eliminated QEvent, MousePressEvent, MouseDoubleClickEvent, MouseMoveEvent,
                MoveReleaseEvent, and DrawContents classes
              - merged NodeImpl::MouseEvent and the MouseEvent from khtml_events.h into
                a single class in the page directory
              - broke khtmllayout.h out into a file for the Length structure in the css
                directory and a file for the GapRects structure in the rendering directory
              - redid the Length structure to work more portably by not relying on bitfield
                layout and improve the names to no longer explicitly mention "width"
              - reduced use of QGuardedPtr and other uses of the QObject "destroyed" signal
      
              * ForwardingHeaders/kparts: Removed.
              * ForwardingHeaders/qevent.h: Removed.
              * khtml/khtml_events.cpp: Removed.
              * khtml/khtml_events.h: Removed.
              * khtml/misc/khtmllayout.h: Removed.
              * kwq/KWQEvent.h: Removed.
              * kwq/KWQEvent.mm: Removed.
              * kwq/KWQFoundationExtras.h: Removed.
              * kwq/KWQKHistoryProvider.mm: Removed.
              * kwq/KWQKPartsHistoryProvider.h: Removed.
      
              * bridge/History.h: Added.
              * bridge/mac/HistoryMac.mm: Added.
              * css/Length.h: Added.
              * page/MouseEventWithHitTestResults.h: Added.
              * platform/KeyEvent.h: Added.
              * platform/MouseEvent.h: Added.
              * platform/WheelEvent.h: Added.
              * platform/mac/FoundationExtras.h: Added.
              * platform/mac/KeyEventMac.mm: Added.
              * platform/mac/MouseEventMac.mm: Added.
              * platform/mac/WheelEventMac.mm: Added.
              * rendering/GapRects.h: Added.
      
              * WebCore.xcodeproj/project.pbxproj: Updated for above changes.
              * WebCore.vcproj/WebCore/WebCore.vcproj: Updated for above changes.
      
              * bridge/mac/MacFrame.h: Removed unused parameters from urlSelected functions.
              Replaced MouseEvent, MousePressEvent, MouseMoveEvent, and MouseReleaseEvent
              with MouseEventWithHitTestResults.
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::urlSelected): Removed unused parameters.
              (WebCore::MacFrame::wheelEvent): Changed to use WheelEvent.
              (WebCore::MacFrame::keyEvent): Changed to use KeyEvent.
              (WebCore::MacFrame::khtmlMousePressEvent): Changed parameter type.
              (WebCore::MacFrame::khtmlMouseMoveEvent): Ditto.
              (WebCore::MacFrame::khtmlMouseReleaseEvent): Ditto.
              (WebCore::MacFrame::passSubframeEventToSubframe): Ditto.
              (WebCore::MacFrame::mouseDown): Changed to use MouseEvent.
              (WebCore::MacFrame::mouseDragged): Ditto.
              (WebCore::MacFrame::mouseUp): Ditto.
              (WebCore::MacFrame::mouseMoved): Ditto.
              (WebCore::MacFrame::sendContextMenuEvent): Ditto.
      
              * css/csshelper.h: Removed a bunch of unused declarations.
      
              * dom/DocumentImpl.h:
              * dom/DocumentImpl.cpp:
              (WebCore::DocumentImpl::prepareMouseEvent): Changed to take a MouseEvent
              and return a MouseEventWithHitTestResults.
              (WebCore::DocumentImpl::defaultEventHandler): Changed to use KeyEvent.
      
              * dom/NodeImpl.h: Removed NodeImpl::MouseEvent and NodeImpl::MouseEventType.
              * dom/NodeImpl.cpp:
              (WebCore::NodeImpl::dispatchMouseEvent): Changed to always get the type and
              detail values from the caller, never from the event. Changed to use MouseEvent.
              (WebCore::NodeImpl::dispatchKeyEvent): Changed to use KeyEvent.
              (WebCore::NodeImpl::dispatchWheelEvent): Changed to use WheelEvent.
      
              * dom/dom2_eventsimpl.h:
              * dom/dom2_eventsimpl.cpp:
              (WebCore::KeyboardEventImpl::KeyboardEventImpl): Changed to use KeyEvent.
              (WebCore::KeyboardEventImpl::charCode): Ditto.
      
              * dom/dom_elementimpl.h: Removed unused mouseEventHandler function.
      
              * khtml/ecma/domparser.h: Use RefPtr instead of QGuardedPtr to hold the reference
              to the document.
      
              * khtml/ecma/kjs_proxy.h: (WebCore::KJSProxyImpl::haveInterpreter): Added. For
              use in the Frame destructor so we can get an existing KJS::Window object without
              creating a new interpreter and window object.
      
              * khtml/ecma/kjs_window.h: Merged WindowQObject into Window. Changed all the
              guarded pointers to Frame to use plain old pointers that are cleared by the
              Frame explicitly (by the function disconnectFrame). Made the pointers to all
              the sub-objects of KJS::Window be mutable so we don't have to const_cast in
              the functions to get (and lazily create) them.
              * khtml/ecma/kjs_window.cpp:
              (KJS::DOMWindowTimer::DOMWindowTimer): Use Window* instead of WindowQObject*.
              (KJS::History::disconnectFrame): Added. Clears m_frame.
              (KJS::FrameArray::disconnectFrame): Added. Clears m_frame.
              (KJS::Window::Window): Removed code to create a WindowQObject.
              (KJS::Window::~Window): Removed code to delete a WindowQObject.
              (KJS::Window::location): Remove now-unneeded const_cast.
              (KJS::Window::selection): Ditto.
              (KJS::Window::locationbar): Ditto.
              (KJS::Window::menubar): Ditto.
              (KJS::Window::personalbar): Ditto.
              (KJS::Window::statusbar): Ditto.
              (KJS::Window::toolbar): Ditto.
              (KJS::Window::scrollbars): Ditto.
              (KJS::Window::getValueProperty): Update since m_frame is now a raw pointer.
              (KJS::Window::getOwnPropertySlot): Ditto.
              (KJS::Window::toBoolean): Ditto.
              (KJS::Window::scheduleClose): Remove assert that WindowQObject* is not null.
              (KJS::Window::isSafeScript): Update since m_frame is now a raw pointer.
              (KJS::Window::clear): Remove code to delete a WindowQObject. Added a call
              to clearAllTimeouts instead.
              (KJS::Window::clearAllTimeouts): Added. Does equivalent of the WindowQObject
              destructor.
              (KJS::Window::installTimeout): Moved to Window from WindowQObject.
              (KJS::Window::pauseTimeouts): Ditto.
              (KJS::Window::resumeTimeouts): Ditto.
              (KJS::Window::clearTimeout): Ditto.
              (KJS::Window::timerFired): Ditto.
              (KJS::Window::disconnectFrame): Added. Sets all the frame pointers to 0.
              (KJS::FrameArray::getOwnPropertySlot): Update since m_frame is now a raw pointer.
              (KJS::Location::getOwnPropertySlot): Ditto.
              (KJS::Location::put): Ditto.
              (KJS::Selection::getOwnPropertySlot): Ditto.
              (KJS::BarInfo::getOwnPropertySlot): Ditto.
      
              * khtml/html/html_baseimpl.h: Forward-declare Length instead of including khtmllayout.h.
              * khtml/html/html_imageimpl.h: Ditto.
      
              * khtml/html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElementImpl::defaultEventHandler):
              Changed to use KeyEvent and removed the code to extract the button and state from the
              DOM even to pass to urlSelected.
              * ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::defaultEventHandler): Ditto.
      
              * khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::timerFired): Change to use
              a RefPtr instead of a QGuardedPtr.
      
              * khtml/misc/helper.h:
              * khtml/misc/helper.cpp: Removed printpainter and setPrintPainter.
      
              * ksvg2/svg/SVGDocumentImpl.h:
              * ksvg2/svg/SVGDocumentImpl.cpp: (WebCore::SVGDocumentImpl::dispatchKeyEvent):
              Change to use KeyEvent.
      
              * kwq/KWQComboBox.mm:
              (-[KWQPopUpButton becomeFirstResponder]):
              (-[KWQPopUpButton resignFirstResponder]):
              * kwq/KWQFileButton.mm:
              (KWQFileButton::focusChanged):
              * kwq/KWQListBox.mm:
              (-[KWQTableView becomeFirstResponder]):
              (-[KWQTableView resignFirstResponder]):
              * kwq/KWQSlider.mm:
              (-[KWQSlider becomeFirstResponder]):
              (-[KWQSlider resignFirstResponder]):
              * kwq/KWQTextArea.mm:
              (-[KWQTextAreaTextView becomeFirstResponder]):
              (-[KWQTextAreaTextView resignFirstResponder]):
              * kwq/KWQTextField.mm:
              (-[KWQTextFieldController setHasFocus:]):
              Updated to use new eventFilterFocusIn/Out instead of the general purpose
              eventFilter function. This allows us to remove QEvent and the focus events.
      
              * kwq/KWQNamespace.h: Removed ButtonState.
      
              * kwq/KWQObject.h:
              * kwq/KWQObject.cpp: Replaced eventFilter function with eventFilterFocusIn and
              eventFilterFocusOut, allowing us to remove QEvent. Removed event function.
      
              * kwq/KWQSlot.cpp:
              (KWQSlot::KWQSlot): Removed the parentDestroyed slot.
              (KWQSlot::call): Ditto.
      
              * page/Frame.h:
              * page/Frame.cpp:
              (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): Renamed from
              PartStyleSheetLoader. Removed a lot of unneeded null checks. Use a
              raw Frame pointer instead of a QGuardedPtr, and count on the Frame
              to delete us when it's being deleted.
              (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): No longer
              a virtual function. This is not a polymorphic class.
              (WebCore::UserStyleSheetLoader::setStyleSheet): Remove code to delete
              ourselves -- that's now the frame's responsibility.
              (WebCore::Frame::~Frame): Call disconnectFrame on the KJS::Window and
              delete m_userStyleSheetLoader.
              (WebCore::Frame::changeLocation): Update since urlSelected no longer takes
              button and state parameters.
              (WebCore::Frame::setUserStyleSheet): Delete existing loader to stop a load
              in progress before starting a new load. Store reference to loader.
              (WebCore::Frame::urlSelected): Remove button and state parameters and unused
              local variable hasTarget.
              (WebCore::Frame::selectClosestWordFromMouseEvent): Change from QMouseEvent
              to MouseEvent.
              (WebCore::Frame::handleMousePressEventDoubleClick): Change from MousePressEvent
              to MouseEventWithHitTestResults.
              (WebCore::Frame::handleMousePressEventTripleClick): Ditto.
              (WebCore::Frame::handleMousePressEventSingleClick): Ditto.
              (WebCore::Frame::khtmlMousePressEvent): Ditto.
              (WebCore::Frame::handleMouseMoveEventSelection): Change from MouseMoveEvent
              to MouseEventWithHitTestResults.
              (WebCore::Frame::khtmlMouseMoveEvent): Ditto.
              (WebCore::Frame::khtmlMouseReleaseEvent): Change from MouseReleaseEvent
              to MouseEventWithHitTestResults.
              (WebCore::Frame::khtmlMouseDoubleClickEvent): Change from
              MouseReleaseDoubleClickEvent to MouseEventWithHitTestResults.
              (WebCore::Frame::passWidgetMouseDownEventToWidget): Change from
              NodeImpl::MouseEvent to MouseEventWithHitTestResults.
      
              * page/FramePrivate.h: Added m_userStyleSheetLoader.
      
              * page/FrameView.h:
              * page/FrameView.cpp:
              (WebCore::FrameView::viewportMousePressEvent): Change from QMouseEvent to
              MouseEvent and from NodeImpl::MouseEvent to MouseEventWithHitTestResults.
              (WebCore::FrameView::viewportMouseDoubleClickEvent): Ditto.
              (WebCore::selectCursor): Ditto.
              (WebCore::FrameView::viewportMouseMoveEvent): Ditto.
              (WebCore::FrameView::viewportMouseReleaseEvent): Ditto.
              (WebCore::FrameView::keyPressEvent): Change from QKeyEvent to KeyEvent.
              (WebCore::FrameView::dispatchMouseEvent): Change from QMouseEvent to
              MouseEvent and from NodeImpl::MouseEvent to MouseEventWithHitTestResults.
              (WebCore::FrameView::viewportWheelEvent): Change from QWheelEvent to
              WheelEvent.
              (WebCore::FrameView::hoverTimerFired): Update for change to prepareMouseEvent
              parameters.
      
              * platform/Widget.h:
              * platform/Widget.cpp: Removed event function.
      
              * rendering/render_form.h: Removed LineEditWidget, ComboBoxWidget, TextAreaWidget.
              * rendering/render_form.cpp:
              (WebCore::RenderFormElement::slotClicked): Changed from QMouseEvent to MouseEvent.
              (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed): Updated for changes
              to the Length class.
              (WebCore::RenderSelect::setWidgetWritingDirection): Updated for removal of
              ComboBoxWidget.
              (WebCore::RenderSelect::slotSelected): Ditto.
              (WebCore::RenderSelect::createComboBox): Ditto.
      
              * rendering/render_replaced.h:
              * rendering/render_replaced.cpp:
              (WebCore::RenderWidget::destroy): Updated since removeEventFilter no longer takes
              a parameter.
              (WebCore::RenderWidget::setQWidget): Ditto.
              (WebCore::RenderWidget::eventFilterFocusIn): Added. Replaces eventFilter.
              (WebCore::RenderWidget::eventFilterFocusOut): Ditto.
      
              * css/css_computedstyle.cpp:
              (WebCore::valueForLength):
              (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
              * css/cssstyleselector.cpp:
              (WebCore::checkPseudoState):
              (WebCore::CSSStyleSelector::applyProperty):
              (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
              * khtml/html/html_imageimpl.cpp:
              (WebCore::HTMLAreaElementImpl::getRegion):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::MarginInfo::MarginInfo):
              (WebCore::RenderBlock::isSelfCollapsingBlock):
              (WebCore::RenderBlock::layoutBlock):
              (WebCore::RenderBlock::determineHorizontalPosition):
              (WebCore::RenderBlock::leftRelOffset):
              (WebCore::RenderBlock::rightRelOffset):
              (WebCore::RenderBlock::calcMinMaxWidth):
              (WebCore::getBPMWidth):
              (WebCore::RenderBlock::calcInlineMinMaxWidth):
              (WebCore::RenderBlock::calcBlockMinMaxWidth):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::calcWidth):
              (WebCore::RenderTable::layout):
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::calcMinMaxWidth):
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::addChild):
              (WebCore::RenderTableSection::addCell):
              (WebCore::RenderTableSection::calcRowHeight):
              (WebCore::RenderTableSection::layoutRows):
              * rendering/RenderText.h:
              (khtml::RenderText::marginLeft):
              (khtml::RenderText::marginRight):
              * rendering/bidi.cpp:
              (khtml::getBPMWidth):
              * rendering/render_applet.cpp:
              (WebCore::RenderApplet::createWidgetIfNecessary):
              * rendering/render_box.cpp:
              (WebCore::RenderBox::paintBackgroundExtended):
              (WebCore::RenderBox::getClipRect):
              (WebCore::RenderBox::relativePositionOffset):
              (WebCore::RenderBox::calcWidth):
              (WebCore::RenderBox::calcWidthUsing):
              (WebCore::RenderBox::sizesToIntrinsicWidth):
              (WebCore::RenderBox::calcHorizontalMargins):
              (WebCore::RenderBox::calcHeight):
              (WebCore::RenderBox::calcHeightUsing):
              (WebCore::RenderBox::calcPercentageHeight):
              (WebCore::RenderBox::calcReplacedWidth):
              (WebCore::RenderBox::calcReplacedWidthUsing):
              (WebCore::RenderBox::calcReplacedHeight):
              (WebCore::RenderBox::calcReplacedHeightUsing):
              (WebCore::RenderBox::availableHeightUsing):
              (WebCore::RenderBox::calcVerticalMargins):
              (WebCore::RenderBox::calcAbsoluteHorizontal):
              (WebCore::RenderBox::calcAbsoluteHorizontalValues):
              (WebCore::RenderBox::calcAbsoluteVertical):
              (WebCore::RenderBox::calcAbsoluteVerticalValues):
              * rendering/render_br.cpp:
              (WebCore::RenderBR::lineHeight):
              * rendering/render_flexbox.cpp:
              (khtml::RenderFlexibleBox::calcHorizontalMinMaxWidth):
              (khtml::RenderFlexibleBox::calcVerticalMinMaxWidth):
              (khtml::RenderFlexibleBox::calcMinMaxWidth):
              (khtml::RenderFlexibleBox::allowedChildFlex):
              * rendering/render_flow.cpp:
              (WebCore::RenderFlow::lineHeight):
              * rendering/render_frames.cpp:
              (WebCore::RenderFrameSet::layout):
              * rendering/render_image.cpp:
              (WebCore::RenderImage::isWidthSpecified):
              (WebCore::RenderImage::isHeightSpecified):
              * rendering/render_layer.cpp:
              (WebCore::Marquee::direction):
              (WebCore::Marquee::start):
              (WebCore::Marquee::updateMarqueeStyle):
              (WebCore::Marquee::timerFired):
              * rendering/render_line.cpp:
              (WebCore::InlineFlowBox::marginLeft):
              (WebCore::InlineFlowBox::marginRight):
              * rendering/render_object.cpp:
              (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
              (WebCore::RenderObject::paintBorderImage):
              (WebCore::RenderObject::paddingTop):
              (WebCore::RenderObject::paddingBottom):
              (WebCore::RenderObject::paddingLeft):
              (WebCore::RenderObject::paddingRight):
              (WebCore::RenderObject::getVerticalPosition):
              (WebCore::RenderObject::lineHeight):
              (WebCore::RenderObject::addDashboardRegions):
              * rendering/render_style.h:
              * rendering/render_theme_mac.mm:
              (WebCore::RenderThemeMac::addIntrinsicMargins):
              * rendering/table_layout.cpp:
              (WebCore::FixedTableLayout::calcWidthArray):
              (WebCore::FixedTableLayout::calcMinMaxWidth):
              (WebCore::FixedTableLayout::layout):
              (WebCore::AutoTableLayout::recalcColumn):
              (WebCore::AutoTableLayout::fullRecalc):
              (WebCore::AutoTableLayout::calcMinMaxWidth):
              (WebCore::AutoTableLayout::calcEffectiveWidth):
              (WebCore::AutoTableLayout::layout):
              (WebCore::AutoTableLayout::calcPercentages):
              Updated for changes to the Length class.
              Also removed a check of the printpainter global, never used in WebCore.
      
              * bindings/objc/DOM.mm:
              * bindings/objc/DOMCSS.mm:
              * bindings/objc/DOMHTML.mm:
              * bridge/mac/WebCoreFrameBridge.mm:
              * css/csshelper.cpp:
              * editing/SelectionController.cpp:
              * khtml/ecma/kjs_html.h:
              * kwq/KWQAccObject.mm:
              * kwq/KWQAccObjectCache.mm:
              * kwq/KWQClipboard.mm:
              * kwq/KWQFont.mm:
              * kwq/KWQFontMetrics.mm:
              * kwq/KWQKJobClasses.mm:
              * kwq/KWQKURL.mm:
              * kwq/KWQLoader.mm:
              * kwq/KWQPageState.mm:
              * kwq/KWQPainter.mm:
              * kwq/WebCoreSettings.mm:
              * platform/StringImpl.cpp:
              * platform/mac/CursorMac.mm:
              * platform/mac/WidgetMac.mm:
              * rendering/RenderBlock.h:
              * rendering/render_canvas.cpp:
              * rendering/render_line.h:
              * rendering/render_style.cpp:
              * rendering/table_layout.h:
              Updated includes.
      
              * bindings/js/JSDOMCore.cpp: Touched, because I got strange failures if this
              didn't rebuild.
              * bindings/js/JSDOMEvents.cpp: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      947a31b6
    • thatcher's avatar
      New build to fix the i386 arch. (The _cuEnc64 symbol was missing.) · 05690148
      thatcher authored
              * libWebKitSystemInterface.a:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05690148
    • eseidel's avatar
      2006-02-23 Eric Seidel <eseidel@apple.com> · 864b4dde
      eseidel authored
              Reviewed by darin.
      
              Fix linking of static constructed globals on win32.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * config.h:
              * dom/EventNames.cpp:
              (WebCore::EventNames::init):
              * dom/EventNames.h:
              * dom/dom_qname.cpp:
              (WebCore::QualifiedName::init):
              * dom/dom_qname.h:
              * khtml/html/htmlnames.cpp:
              (WebCore::HTMLNames::init):
              * khtml/html/htmlnames.h:
              * platform/AtomicString.cpp:
              (WebCore::AtomicString::init):
              * platform/StaticConstructors.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      864b4dde
    • vicki's avatar
      Reviewed by Tim Omernick. · aebb78f0
      vicki authored
       
              - fix <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event
      
              Check shouldClose() before actually scheduling a close.
      
              shouldClose() checks for the onbeforeunload handler, displays the onbeforeunload dialog, and returns a 
              result based on whether the user clicks "OK" or "Cancel".  In cases where the window is closed with cmd-w 
              or by clicking the red globe, shouldClose() is checked in the windowShouldClose delegate method.  Since 
              windowShouldClose isn't invoked when a window is closed with Javascript, it makes sense to add a check 
              for shouldClose() in scheduleClose(), returning early when appropriate before the chain of events that 
              closes a window even gets started.  
      
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::scheduleClose): add a check for shouldClose()
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aebb78f0
    • ggaren's avatar
      Reviewed by Darin, Maciej. · d62a712a
      ggaren authored
              - Inline some functions suggested by Shark. 2.9% speedup on super
              accurate JS iBench.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7411
              <rdar://problem/4448116>
      
              * kjs/nodes.h:
              (KJS::ArgumentsNode::evaluateList):
              * kjs/object.cpp:
              * kjs/object.h:
              (KJS::ScopeChain::release):
              (KJS::JSObject::toPrimitive):
              * kjs/scope_chain.cpp:
              * kjs/ustring.cpp:
              * kjs/ustring.h:
              (KJS::UString::toArrayIndex):
              * kjs/value.cpp:
              * kjs/value.h:
              (KJS::JSValue::toObject):
              * kxmlcore/FastMalloc.cpp:
              (KXMLCore::TCMalloc_ThreadCache_FreeList::Push):
              (KXMLCore::TCMalloc_ThreadCache_FreeList::Pop):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d62a712a