1. 25 Jan, 2011 40 commits
    • tkent@chromium.org's avatar
      2011-01-25 Kent Tamura <tkent@chromium.org> · 6b7df945
      tkent@chromium.org authored
              Unreviewed, test expectation update.
      
              * platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum: Added.
              * platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
              * platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
              * platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.checksum:
              * platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
              * platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      2011-01-25  Kent Tamura  <tkent@chromium.org>
      
              Unreviewed trivial change.
      
              * DEPS: Roll to r72581 to have a webkit_support fix.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b7df945
    • sfalken@apple.com's avatar
      Windows production build fix. · 37f81ddf
      sfalken@apple.com authored
      Use correct configuration-specific path in makefile.
      
      * WebCore.vcproj/WebCore.make:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37f81ddf
    • tkent@chromium.org's avatar
      Radio button group state is not restored correctly · eae496df
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=50442
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      Fixes a bug that radio button states are not restored correctly in
      a case that non-first radio button in a group is checked.
      
      If "checked" attribute is present, the radio button is checked and
      other radio buttons in the group are unchecked. This behavior
      disturbs form state restoring. This patch changes this behavior so
      that the "checked" attribute handling is delayed after form state
      restoring.
      
      Test: fast/forms/state-restore-radio-group.html
      
      * html/HTMLFormControlElement.h:
       Make finishParsingChildren() protected so that HTMLInpuElement can call it.
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::HTMLInputElement):
       - Add createdByParser parameter.
       - Initialize m_stateRestored and m_parsingInProgress.
      (WebCore::HTMLInputElement::create): Sync with the constructor.
      (WebCore::HTMLInputElement::restoreFormControlState):
       Set m_stateRestored in order to refer it in finishParsingChildren().
      (WebCore::HTMLInputElement::parseMappedAttribute):
       Don't call setChecked() during parsing. Move setNeedsValidityCheck()
       to setChecked().
      (WebCore::HTMLInputElement::finishParsingChildren):
       Call setChecked() if form state is not restored.
      (WebCore::HTMLInputElement::setChecked):
       Move setNeedsValidityCheck() from parseMappedAttribute() because
       finishParsingChildren() also needs to call setNeedsValidityCheck().
      * html/HTMLInputElement.h:
       - Remove the default value of HTMLFormElement* of the HTMLInputElement
         constructor, and add createdByParser parameter.
       - Introduce m_parsingInProgress and m_stateRestored.
      * html/HTMLIsIndexElement.cpp:
      (WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
       Sync with the HTMLInputElement constructor change.
      * html/HTMLTagNames.in: Add constructorNeedsCreatedByParser flag.
      * rendering/MediaControlElements.cpp:
      (WebCore::MediaControlInputElement::MediaControlInputElement):
       Sync with the HTMLInputElement constructor change.
      * rendering/ShadowElement.cpp:
      (WebCore::ShadowInputElement::ShadowInputElement): ditto.
      * rendering/ShadowElement.h:
      (WebCore::ShadowElement::ShadowElement): ditto.
      
      LayoutTests:
      
      * fast/forms/state-restore-radio-group-expected.txt: Added.
      * fast/forms/state-restore-radio-group.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eae496df
    • tkent@chromium.org's avatar
      HTMLFormElement::checkValidity() returns incorrect result if 'invalid' events are canceled. · ced38641
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=52565
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::validateInteractively):
        Check checkInvalidControlsAndCollectUnhandled() result instead of
        checking emptiness of unhandled invalid controls list.
      (WebCore::HTMLFormElement::checkValidity): ditto.
      (WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):
        Renamed from collectUnhandledInvalidControls().
        Returns true if there is any invalid control regardless of event canceling.
      * html/HTMLFormElement.h: Rename collectUnhandledInvalidControls() to
        checkInvalidControlsAndCollectUnhandled().
      
      LayoutTests:
      
      Fix tests and results for the behavior change.
      
      * fast/forms/checkValidity-cancel-expected.txt:
      * fast/forms/checkValidity-handler-updates-dom-expected.txt:
      * fast/forms/interactive-validation-cancel-expected.txt:
      * fast/forms/interactive-validation-cancel.html:
      * fast/forms/script-tests/checkValidity-cancel.js:
      * fast/forms/script-tests/checkValidity-handler-updates-dom.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ced38641
    • tkent@chromium.org's avatar
      2011-01-25 Kent Tamura <tkent@chromium.org> · 1b27cba5
      tkent@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Range and number inputs should reject increment and decrement by
              keyboard or mouse wheel if they are disabled or read-only
              https://bugs.webkit.org/show_bug.cgi?id=53151
      
              Add checks for 'disabled' and 'readOnly'.
      
              * fast/forms/input-number-keyoperation-expected.txt:
              * fast/forms/input-number-wheel-expected.txt:
              * fast/forms/range-keyoperation-expected.txt:
              * fast/forms/range-keyoperation.html:
              * fast/forms/script-tests/input-number-keyoperation.js:
              * fast/forms/script-tests/input-number-wheel.js:
      2011-01-25  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Range and number inputs should reject increment and decrement by
              keyboard or mouse wheel if they are disabled or read-only
              https://bugs.webkit.org/show_bug.cgi?id=53151
      
              * html/RangeInputType.cpp:
              (WebCore::RangeInputType::handleKeydownEvent): Check disabled() and readOnly().
              * html/TextFieldInputType.cpp:
              (WebCore::TextFieldInputType::handleKeydownEventForSpinButton): ditto.
              (WebCore::TextFieldInputType::handleWheelEventForSpinButton): ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b27cba5
    • tkent@chromium.org's avatar
      API to support localized numbers for <input type=number> · a2a0e4ec
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=45730
      
      Reviewed by Dimitri Glazkov.
      
      Introduce platform/text/LocalizedNumber.h, and
      LocalizedNumberNone.cpp, which is an empty implementation of the
      functions in LocalizedNumber.h.  We use LocalizedNumberNone.cpp in
      all platforms for now.
      
      A string in a type=number field is parsed as a localized number
      first. If the parsing fails, it is parsed as the HTML5 number.
      
      We introduce HTMLInputElement::visibleValue(). It represents a value
      which should be drawn by a renderer. HTMLInputElement::value() always
      returns a number formatted for HTML5, and visibleValue() may return a
      localized number.
      
      No new tests because this doesn't change any behavior.
      
      * Android.mk: Add LocalizedNumber.h and/or LocalizedNumberNone.cpp.
      * CMakeLists.txt: ditto.
      * GNUmakefile.am: ditto.
      * WebCore.gypi: ditto.
      * WebCore.pro: ditto.
      * WebCore.vcproj/WebCore.vcproj: ditto.
      * WebCore.xcodeproj/project.pbxproj: ditto.
      * dom/InputElement.h: Add visibleValue().
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::visibleValue): Added.  Just call InputType::visibleValue().
      * html/HTMLInputElement.h: Declare visibleValue().
      * html/InputType.cpp:
      (WebCore::InputType::visibleValue): Add the default implementation of
        visibleValue(), which returns HTMLInputElement::value().
      * html/InputType.h: Add declarations.
      * html/NumberInputType.cpp:
      (WebCore::isHTMLNumberCharacter): Renamed from isNumberCharacter().
      (WebCore::isNumberCharacter): Calls isLocalizedNumberCharacter() and isHTMLNumberCharacter().
      (WebCore::NumberInputType::visibleValue):
        Returns a localized number string produced by formatLocalizedNumber().
      (WebCore::NumberInputType::isAcceptableValue): Calls parseLocalizedNumber().
      (WebCore::NumberInputType::sanitizeValue): Calls parseLocalizedNumber().
      * html/NumberInputType.h: Add declarations.
      * platform/text/LocalizedNumber.h: Added.
      * platform/text/LocalizedNumberNone.cpp: Added.
      (WebCore::parseLocalizedNumber):
      (WebCore::formatLocalizedNumber):
      (WebCore::isLocalizedNumberCharacter):
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::updateFromElement):
        Calls InputElement::visibleValue() instead of value().
      * wml/WMLInputElement.h:
      (WebCore::WMLInputElement::visibleValue): Added. It just calls value().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2a0e4ec
    • ap@apple.com's avatar
      Reviewed by Darin Adler. · 4faf3917
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=53143
              Add IntRectHash
      
              * WebCore.xcodeproj/project.pbxproj:
              * platform/graphics/IntRectHash.h: Added.
      
              * platform/graphics/IntSizeHash.h: Don't do "using WebCore::IntSize"!
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4faf3917
    • commit-queue@webkit.org's avatar
      2011-01-25 Ilya Sherman <isherman@chromium.org> · 07f620fa
      commit-queue@webkit.org authored
              Reviewed by Ryosuke Niwa.
      
              Remove trailing whitespace in HTMLInputElement.cpp
              https://bugs.webkit.org/show_bug.cgi?id=53152
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::updateCheckedRadioButtons):
              (WebCore::HTMLInputElement::applyStep):
              (WebCore::HTMLInputElement::updateFocusAppearance):
              (WebCore::HTMLInputElement::mapToEntry):
              (WebCore::HTMLInputElement::setAutofilled):
              (WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
              (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07f620fa
    • commit-queue@webkit.org's avatar
      2011-01-25 Mike Reed <reed@google.com> · 7a1a1452
      commit-queue@webkit.org authored
              Reviewed by James Robinson.
      
              DrawingBufer::reset() today checks if the new size is the same as its
              m_size, and if so, returns immediately. This does not match the
              semantics of <canvas>, which wants to clear its contents anytime the
              size is specified.
              https://bugs.webkit.org/show_bug.cgi?id=53149
      
              Test: Covered by existing <canvas> tests using gpu.
      
              * platform/graphics/chromium/DrawingBufferChromium.cpp:
              (WebCore::DrawingBuffer::DrawingBuffer):
              * platform/graphics/gpu/DrawingBuffer.cpp:
              (WebCore::DrawingBuffer::reset):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a1a1452
    • cfleizach@apple.com's avatar
      WK2 leaks when a page is closed · 5a1914ba
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=53100
      
      Reviewed by Darin Adler.
      
      Allow the WKView a chance to clean up on a page close. In this case,
      cleaning up means removing the references the accessibility token has
      to the window.
      
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::pageClosed):
      * UIProcess/API/mac/WKView.mm:
      (-[WKView _setRemoteAccessibilityWindow:]):
      (-[WKView _setAccessibilityChildToken:]):
      (-[WKView _processDidCrash]):
      (-[WKView _pageClosed]):
      * UIProcess/API/mac/WKViewInternal.h:
      * UIProcess/API/qt/qwkpage_p.h:
      (QWKPagePrivate::pageClosed):
      * UIProcess/PageClient.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::close):
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::pageClosed):
      * UIProcess/win/WebView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a1914ba
    • paroga@webkit.org's avatar
      2011-01-25 Patrick Gansterer <paroga@webkit.org> · 1bbdce1b
      paroga@webkit.org authored
              Reviewed by Adam Barth.
      
              Move main CMakeLists.txt into Source directory
              https://bugs.webkit.org/show_bug.cgi?id=52888
      
              * CMakeLists.txt: Removed.
              * Source/CMakeLists.txt: Copied from CMakeLists.txt.
              * Source/cmakeconfig.h.cmake: Copied from cmakeconfig.h.cmake.
              * cmakeconfig.h.cmake: Removed.
      2011-01-25  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by Adam Barth.
      
              Move main CMakeLists.txt into Source directory
              https://bugs.webkit.org/show_bug.cgi?id=52888
      
              * Scripts/webkitdirs.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bbdce1b
    • paroga@webkit.org's avatar
      2011-01-25 Patrick Gansterer <paroga@webkit.org> · 356bffb5
      paroga@webkit.org authored
              Reviewed by Eric Seidel.
      
              Improve label text in submit-to-ews
              https://bugs.webkit.org/show_bug.cgi?id=53130
      
              * QueueStatusServer/templates/submittoews.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      356bffb5
    • cmarrin@apple.com's avatar
      2011-01-25 Chris Marrin <cmarrin@apple.com> · 762c42a4
      cmarrin@apple.com authored
              Reviewed by Adam Roben.
      
              Expose WebGL flag set/get in WK2
              https://bugs.webkit.org/show_bug.cgi?id=53096
      
              * Shared/WebPreferencesStore.h:
              * UIProcess/API/C/WKPreferences.cpp:
              (WKPreferencesSetWebGLEnabled):
              (WKPreferencesGetWebGLEnabled):
              * UIProcess/API/C/WKPreferencesPrivate.h:
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::updatePreferences):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      762c42a4
    • andersca@apple.com's avatar
      2011-01-25 Anders Carlsson <andersca@apple.com> · b492e3a8
      andersca@apple.com authored
              Reviewed by Adam Roben.
      
              Add and implement LayerTreeHost::scheduleLayerFlush
              https://bugs.webkit.org/show_bug.cgi?id=53135
      
              * WebKit2.xcodeproj/project.pbxproj:
              Add LayerTreeHostMac.mm.
      
              * WebProcess/WebPage/DrawingAreaImpl.cpp:
              (WebKit::DrawingAreaImpl::scheduleCompositingLayerSync):
              Call LayerTreeHost::scheduleLayerFlush.
      
              * WebProcess/WebPage/LayerTreeHost.cpp:
              (WebKit::LayerTreeHost::~LayerTreeHost):
              Call platformInvalidate().
      
              (WebKit::LayerTreeHost::flushPendingLayerChanges):
              Rename from syncCompositingLayers.
      
              * WebProcess/WebPage/mac/LayerTreeHostMac.mm: Added.
              (WebKit::LayerTreeHost::scheduleLayerFlush):
              Create a run loop observer if needed. This code is copied from LayerBackedDrawingAreaMac.mm
      
              (WebKit::LayerTreeHost::platformInvalidate):
              Invalidate the run loop observer.
      
              (WebKit::LayerTreeHost::flushPendingLayerChangesRunLoopObserverCallback):
              Call flushPendingChanges() and remove the run loop observer if it succeeded.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b492e3a8
    • inferno@chromium.org's avatar
      2011-01-25 Cris Neckar <cdn@chromium.org> · 49aa540c
      inferno@chromium.org authored
              Reviewed by Adam Barth.
      
              Test for crash when a window's location changes before creating an object URL.
              https://bugs.webkit.org/show_bug.cgi?id=53038
      
              * fast/dom/window-domurl-crash-expected.txt: Added.
              * fast/dom/window-domurl-crash.html: Added.
      2011-01-25  Cris Neckar  <cdn@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add a hashset of DOMURLs to ScriptExecutionContext to track back references.
              https://bugs.webkit.org/show_bug.cgi?id=53038
      
              Test: fast/dom/window-domurl-crash.html
      
              * dom/ScriptExecutionContext.cpp:
              (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
              (WebCore::ScriptExecutionContext::createdDomUrl):
              (WebCore::ScriptExecutionContext::destroyedDomUrl):
              * dom/ScriptExecutionContext.h:
              (WebCore::ScriptExecutionContext::domUrls):
              * html/DOMURL.cpp:
              (WebCore::DOMURL::DOMURL):
              (WebCore::DOMURL::~DOMURL):
              (WebCore::DOMURL::contextDestroyed):
              * html/DOMURL.h:
              (WebCore::DOMURL::scriptExecutionContext):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49aa540c
    • aroben@apple.com's avatar
      Windows Production build fix · 1ef1789e
      aroben@apple.com authored
      Reviewed by Steve Falkenburg.
      
      * JavaScriptCore.vcproj/JavaScriptCore.make: Set BUILDSTYLE to Release_PGO at the very start
      of the file so that ConfigurationBuildDir takes that into account. Also set it the right way
      (by redefining the macro) rather than the wrong way (by modifying the environment variable).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ef1789e
    • andersca@apple.com's avatar
      2011-01-25 Anders Carlsson <andersca@apple.com> · d984e9c6
      andersca@apple.com authored
              Reviewed by Simon Fraser.
      
              Add LayerTreeHost class
              https://bugs.webkit.org/show_bug.cgi?id=53132
      
              * WebKit2.xcodeproj/project.pbxproj:
              Add LayerTreeHost files.
      
              * WebProcess/WebPage/DrawingAreaImpl.cpp:
              (WebKit::DrawingAreaImpl::DrawingAreaImpl):
              Initialize m_layerTreeHost.
      
              (WebKit::DrawingAreaImpl::setRootCompositingLayer):
              Call the m_layerTreeHost.
      
              * WebProcess/WebPage/LayerTreeHost.cpp: Added.
              (WebKit::LayerTreeHost::attachRootCompositingLayer):
              (WebKit::LayerTreeHost::detachRootCompositingLayer):
              Add stubbed out functions.
      
              (WebKit::LayerTreeHost::syncCompositingLayers):
              Sync the compositing layers in the main frame.
      
              * WebProcess/WebPage/LayerTreeHost.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d984e9c6
    • antti@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=52983 · 3c931302
      antti@apple.com authored
      Eliminate m_tagHistory pointer from CSSSelector
      
      Reviewed by Darin Adler.
      
      Keep the component selectors in the array in CSSSelectorList instead
      of maintaining a linked list between them. This allows eliminating
      m_tagHistory pointer, shrinking CSSSelector by 25% (selection performance
      seems to improve some too due to better locality).
      
      * WebCore.xcodeproj/project.pbxproj:
              
          Make CSSSelector.h a private header.
              
      * css/CSSGrammar.y:
              
          Use CSSParserSelector during parsing to keep the tag history in 
          a linked list. This is flattened to an array after parsing.
          Use accessors for setting selector values.
          Use OwnPtr in selector vector.
                  
      * css/CSSPageRule.cpp:
      (WebCore::CSSPageRule::CSSPageRule):
      * css/CSSPageRule.h:
      (WebCore::CSSPageRule::create):
              
          Simplify.
          
      * css/CSSParser.cpp:
      (WebCore::CSSParser::~CSSParser):
      (WebCore::CSSParser::createFloatingSelector):
      (WebCore::CSSParser::sinkFloatingSelector):
      (WebCore::CSSParser::createStyleRule):
      (WebCore::CSSParser::updateSpecifiersWithElementName):
      (WebCore::CSSParser::createPageRule):
      * css/CSSParser.h:
      (WebCore::CSSParser::reusableSelectorVector):
              
          CSSSelector -> CSSParserSelector.
          Use OwnPtr in selector vector.
                  
      * css/CSSParserValues.cpp:
      (WebCore::CSSParserSelector::CSSParserSelector):
      (WebCore::CSSParserSelector::~CSSParserSelector):
      * css/CSSParserValues.h:
      (WebCore::CSSParserSelector::releaseSelector):
      (WebCore::CSSParserSelector::setTag):
      (WebCore::CSSParserSelector::setValue):
      (WebCore::CSSParserSelector::setAttribute):
      (WebCore::CSSParserSelector::setArgument):
      (WebCore::CSSParserSelector::setSimpleSelector):
      (WebCore::CSSParserSelector::setMatch):
      (WebCore::CSSParserSelector::setRelation):
      (WebCore::CSSParserSelector::setForPage):
      (WebCore::CSSParserSelector::pseudoType):
      (WebCore::CSSParserSelector::isUnknownPseudoElement):
      (WebCore::CSSParserSelector::isSimple):
      (WebCore::CSSParserSelector::tagHistory):
      (WebCore::CSSParserSelector::setTagHistory):
              
          Linked list used during parsing.
          Avoid recursive destruction.
      
      * css/CSSSelector.cpp:
      (WebCore::CSSSelector::extractPseudoType):
      (WebCore::CSSSelector::operator==):
      (WebCore::CSSSelector::selectorText):
      (WebCore::CSSSelector::setSimpleSelector):
      * css/CSSSelector.h:
      (WebCore::CSSSelector::CSSSelector):
      (WebCore::CSSSelector::~CSSSelector):
      (WebCore::CSSSelector::tagHistory):
      (WebCore::CSSSelector::tag):
      (WebCore::CSSSelector::value):
      (WebCore::CSSSelector::setTag):
      (WebCore::CSSSelector::isLastInTagHistory):
      (WebCore::CSSSelector::setNotLastInTagHistory):
      (WebCore::CSSSelector::RareData::RareData):
      (WebCore::CSSSelector::RareData::~RareData):
      (WebCore::CSSSelector::createRareData):
      (WebCore::CSSSelector::setValue):
              
          Remove m_tagHistory.
          Keep m_value in the union with the rare data pointer instead.
          Make m_value and m_tag private, implement accessors.
          Add a new bit to indicate end of the tag history (multipart selector).
          Eliminate complex destruction. Selectors are now deleted as an array or by a CSSParserSelector chain.
                  
      * css/CSSSelectorList.cpp:
      (WebCore::CSSSelectorList::adoptSelectorVector):
              
          Flatten everything to an array.
              
      (WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
      * css/CSSSelectorList.h:
      (WebCore::CSSSelectorList::hasOneSelector):
      (WebCore::CSSSelectorList::next):
              
          Skip over the subparts of multipart selectors to find the next selector.
          
      * css/CSSStyleRule.h:
      (WebCore::CSSStyleRule::adoptSelectorVector):
              
          CSSSelector -> CSSParserSelector.
                  
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
      (WebCore::CSSRuleSet::addRule):
      (WebCore::collectIdsAndSiblingRulesFromList):
      (WebCore::CSSStyleSelector::matchPageRulesForList):
      * dom/Node.cpp:
      (WebCore::Node::querySelector):
      * dom/SelectorNodeList.cpp:
      (WebCore::createSelectorNodeList):
              
          Use accessors.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c931302
    • commit-queue@webkit.org's avatar
      2011-01-25 Mansi Mithal <mansi.mithal@nokia.com> · 13aa0664
      commit-queue@webkit.org authored
              Reviewed by Antonio Gomes.
      
              QtTestBrowser should have a UI Settings to prevent loading images
              https://bugs.webkit.org/show_bug.cgi?id=52409
      
              Added a new action item named "DisableAutoLoadImages"
              under the "Settings" menu
      
              * QtTestBrowser/launcherwindow.cpp:
              (LauncherWindow::createChrome):
              (LauncherWindow::toggleAutoLoadImages):
              * QtTestBrowser/launcherwindow.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13aa0664
    • simonjam@chromium.org's avatar
      2011-01-25 James Simonsen <simonjam@chromium.org> · 7b4c22ba
      simonjam@chromium.org authored
              Reviewed by Tony Chang.
      
              [Chromium] Support small caps in complex text on linux
              https://bugs.webkit.org/show_bug.cgi?id=53051
      
              * platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.checksum: Added.
              * platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.png: Added.
              * platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.txt: Added.
              * platform/chromium-linux/fast/text/atsui-small-caps-punctuation-size-expected.checksum: Added.
              * platform/chromium-linux/fast/text/atsui-small-caps-punctuation-size-expected.png: Added.
              * platform/chromium/test_expectations.txt: Re-enable 2 tests on linux.
      2011-01-25  James Simonsen  <simonjam@chromium.org>
      
              Reviewed by Tony Chang.
      
              [Chromium] Support small caps in complex text on linux
              https://bugs.webkit.org/show_bug.cgi?id=53051
      
              * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
              (WebCore::ComplexTextController::nextScriptRun): Break runs at small caps boundaries.
              (WebCore::ComplexTextController::setupFontForScriptRun): Setup small caps font data if needed.
              * platform/graphics/chromium/ComplexTextControllerLinux.h: Store small caps text in separate string.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b4c22ba
    • dpranke@chromium.org's avatar
      2011-01-25 Dirk Pranke <dpranke@chromium.org> · 35fc8141
      dpranke@chromium.org authored
              Reviewed by Tony Chang.
      
              Minor bug fixes and cleanup for filesystem wrappers, port/* test
              classes, test_expectations.py. This change adds "test-win" and
              "test-mac" variants to the test port so that we can better test
              rebaselining, and adds a MockUser() object for reuse in testing.
      
              https://bugs.webkit.org/show_bug.cgi?id=53036
      
              * Scripts/webkitpy/common/system/filesystem.py:
              * Scripts/webkitpy/common/system/filesystem_mock.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
              * Scripts/webkitpy/layout_tests/port/factory.py:
              * Scripts/webkitpy/layout_tests/port/base.py:
              * Scripts/webkitpy/layout_tests/port/test.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
              * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
              * Scripts/webkitpy/tool/mocktool.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35fc8141
    • jer.noble@apple.com's avatar
      Unreviewed build fix: add failing test to gtk/Skipped. · 091627d6
      jer.noble@apple.com authored
      * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      091627d6
    • sfalken@apple.com's avatar
      Windows production build fix. · 0d9eec91
      sfalken@apple.com authored
      Use correct environment variable escaping
      
      Rubber-stamped by Adam Roben.
      
      Source/JavaScriptCore: 
      
      * JavaScriptCore.vcproj/JavaScriptCore.make:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
      
      Source/WebCore: 
      
      * WebCore.vcproj/WebCore.make:
      
      Source/WebKit/win: 
      
      * WebKit.vcproj/WebKit.make:
      
      Source/WebKit2: 
      
      * win/WebKit2.make:
      * win/WebKit2Generated.make:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d9eec91
    • abarth@webkit.org's avatar
      2011-01-25 Adam Barth <abarth@webkit.org> · d7652e8b
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Empty URLs are never display isolated
              https://bugs.webkit.org/show_bug.cgi?id=53053
      
              This check mirrors the check in the local case.  There isn't a good way
              to test this with a LayoutTest, but it is tested in Chromium (where
              this registry is used).
      
              * platform/SchemeRegistry.cpp:
              (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7652e8b
    • weinig@apple.com's avatar
      2011-01-25 Sam Weinig <sam@webkit.org> · cb7e49f9
      weinig@apple.com authored
              Reviewed by Anders Carlsson.
      
              Pipe a timestamp down into the PlatformWheelEvent for the Mac.
              https://bugs.webkit.org/show_bug.cgi?id=53111
      
              * platform/PlatformWheelEvent.h:
              (WebCore::PlatformWheelEvent::PlatformWheelEvent):
              (WebCore::PlatformWheelEvent::timestamp):
              Add timestamp member.
      
              * platform/mac/WheelEventMac.mm:
              (WebCore::PlatformWheelEvent::PlatformWheelEvent):
              Initialize the timestamp from the event.
      2011-01-25  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam Weinig.
      
              Don't inform the UI process about compositing changes when using the new drawing area
              https://bugs.webkit.org/show_bug.cgi?id=53120
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::changeAcceleratedCompositingMode):
              Return early if we're using the new drawing area.
      
              (WebKit::WebPage::exitAcceleratedCompositingMode):
              Call setRootCompositingLayer(0) so the drawing area knows when we leave accelerated compositing.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb7e49f9
    • oliver@apple.com's avatar
      2011-01-25 Oliver Hunt <oliver@apple.com> · f60aec77
      oliver@apple.com authored
              Reviewed by Gavin Barraclough.
      
              JSON.stringify processing time exponentially grows with size of object
              https://bugs.webkit.org/show_bug.cgi?id=51922
      
              Remove last use of reserveCapacity from JSON stringification, as it results
              in appalling append behaviour when there are a large number of property names
              and nothing else.
      
              * runtime/JSONObject.cpp:
              (JSC::Stringifier::appendQuotedString):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f60aec77
    • andersca@apple.com's avatar
      2011-01-25 Anders Carlsson <andersca@apple.com> · 5fa7162f
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Don't inform the UI process about compositing changes when using the new drawing area
              https://bugs.webkit.org/show_bug.cgi?id=53120
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::changeAcceleratedCompositingMode):
              Return early if we're using the new drawing area.
      
              (WebKit::WebPage::exitAcceleratedCompositingMode):
              Call setRootCompositingLayer(0) so the drawing area knows when we leave accelerated compositing.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fa7162f
    • rniwa@webkit.org's avatar
      2011-01-25 Sheriff Bot <webkit.review.bot@gmail.com> · 7f5f5294
      rniwa@webkit.org authored
              Unreviewed, rolling out r76625.
              http://trac.webkit.org/changeset/76625
              https://bugs.webkit.org/show_bug.cgi?id=53119
      
              "incorrect pixel test results" (Requested by rniwa on
              #webkit).
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::localCaretRect):
      2011-01-25  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r76625.
              http://trac.webkit.org/changeset/76625
              https://bugs.webkit.org/show_bug.cgi?id=53119
      
              "incorrect pixel test results" (Requested by rniwa on
              #webkit).
      
              * editing/selection/caret-painting-after-paste-undo-rtl.html: Removed.
              * editing/selection/caret-painting-after-paste-undo.html: Removed.
              * platform/mac/editing/deleting/5408255-expected.checksum:
              * platform/mac/editing/deleting/5408255-expected.png:
              * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Removed.
              * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Removed.
              * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Removed.
              * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Removed.
              * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Removed.
              * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f5f5294
    • tony@chromium.org's avatar
      2011-01-25 Tony Chang <tony@chromium.org> · 28f2b0ab
      tony@chromium.org authored
              Unreviewed, debugger-scripts.html is failing on windows too.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28f2b0ab
    • dimich@chromium.org's avatar
      [Chromium] Not reviewed, rebaseline for a test. · e762199b
      dimich@chromium.org authored
      The difference is because V8 has different error messages.
      
      * platform/chromium-mac/fast/js/js-continue-break-restrictions-expected.txt: Added.
      * platform/chromium-win/fast/js/js-continue-break-restrictions-expected.txt: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e762199b
    • jamesr@google.com's avatar
      2011-01-25 James Robinson <jamesr@chromium.org> · 5b5f0c3f
      jamesr@google.com authored
              Remove = TEXT PASS lines for tests that consistently pass.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b5f0c3f
    • paroga@webkit.org's avatar
      2011-01-25 Patrick Gansterer <paroga@webkit.org> · 5e2d3026
      paroga@webkit.org authored
              Reviewed by Adam Roben.
      
              [WINCE] Ensure layouted frame when painting
              https://bugs.webkit.org/show_bug.cgi?id=53108
      
              * WebView.cpp:
              (WebView::paint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e2d3026
    • jer.noble@apple.com's avatar
      Unreviewed build fix: rollback untintentional changes in media expected results. · 250c1b31
      jer.noble@apple.com authored
      * media/video-source-moved-expected.txt:
      * media/video-source-none-supported-expected.txt:
      * LayoutTests/platform/win/media/audio-data-url-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      250c1b31
    • tony@chromium.org's avatar
      2011-01-25 Tony Chang <tony@chromium.org> · c042d8e9
      tony@chromium.org authored
              Unreviewed, mark inspector/debugger-scripts.html as failing on chromium linux.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c042d8e9
    • paroga@webkit.org's avatar
      2011-01-25 Patrick Gansterer <paroga@webkit.org> · b41e33e3
      paroga@webkit.org authored
              Unreviewed WinCE build fix for r76614.
      
              * platform/FileSystem.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b41e33e3
    • leviw@chromium.org's avatar
      2011-01-21 Levi Weintraub <leviw@chromium.org> · 2ea38bbf
      leviw@chromium.org authored
              Reviewed by Darin Adler.
      
              Adding border and padding to the calculation of the local caret rect for RenderBoxes.
      
              Undo moves caret to invalid position
              https://bugs.webkit.org/show_bug.cgi?id=49744
      
              Tests: editing/selection/caret-painting-after-paste-undo-rtl.html
                     editing/selection/caret-painting-after-paste-undo.html
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::localCaretRect):
      2011-01-21  Levi Weintraub  <leviw@chromium.org>
      
              Reviewed by Darin Adler.
      
              Updating the expected result for 5408255 and adding tests for caret positioning at the
              beginning and end of RenderBoxes.
      
              Undo moves caret to invalid position
              https://bugs.webkit.org/show_bug.cgi?id=49744
      
              * editing/selection/caret-painting-after-paste-undo-rtl.html: Added.
              * editing/selection/caret-painting-after-paste-undo.html: Added.
              * platform/mac/editing/deleting/5408255-expected.checksum:
              * platform/mac/editing/deleting/5408255-expected.png:
              * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Added.
              * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Added.
              * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Added.
              * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Added.
              * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Added.
              * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ea38bbf
    • tony@chromium.org's avatar
      2011-01-25 Tony Chang <tony@chromium.org> · 6ab872d3
      tony@chromium.org authored
              Unreviewed, add chromium-mac baselines after r76599.
      
              The platform/mac-leopard results were stale which is why the expected
              text results aren't updated as well.
      
              * platform/chromium-mac/svg/custom/junk-data-expected.checksum: Added.
              * platform/chromium-mac/svg/custom/junk-data-expected.png: Added.
              * platform/chromium-mac/svg/custom/missing-xlink-expected.checksum: Added.
              * platform/chromium-mac/svg/custom/missing-xlink-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ab872d3
    • jamesr@google.com's avatar
      2011-01-25 James Robinson <jamesr@chromium.org> · 096902d9
      jamesr@google.com authored
              Reviewed by Mihai Parparita.
      
              Convert requestAnimationFrame tests to be script-tests
              https://bugs.webkit.org/show_bug.cgi?id=53109
      
              This converts the new requestAnimationFrame tests to be proper script-tests using make-script-test-wrapper.
      
              * fast/animation/request-animation-frame-cancel-expected.txt:
              * fast/animation/request-animation-frame-cancel.html:
              * fast/animation/request-animation-frame-cancel2-expected.txt:
              * fast/animation/request-animation-frame-cancel2.html:
              * fast/animation/request-animation-frame-display-expected.txt:
              * fast/animation/request-animation-frame-display.html:
              * fast/animation/request-animation-frame-expected.txt:
              * fast/animation/request-animation-frame-within-callback-expected.txt:
              * fast/animation/request-animation-frame-within-callback.html:
              * fast/animation/request-animation-frame.html:
              * fast/animation/script-tests/TEMPLATE.html: Added.
              * fast/animation/script-tests/request-animation-frame-cancel.js: Copied from LayoutTests/fast/animation/request-animation-frame-cancel.html.
              * fast/animation/script-tests/request-animation-frame-cancel2.js: Copied from LayoutTests/fast/animation/request-animation-frame-cancel2.html.
              (secondCallbackId):
              * fast/animation/script-tests/request-animation-frame-display.js: Added.
              * fast/animation/script-tests/request-animation-frame-within-callback.js: Copied from LayoutTests/fast/animation/request-animation-frame-within-callback.html.
              (window):
              * fast/animation/script-tests/request-animation-frame.js: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      096902d9
    • weinig@apple.com's avatar
      2011-01-25 Sam Weinig <sam@webkit.org> · 7e6de6b9
      weinig@apple.com authored
              Reviewed by Anders Carlsson.
      
              Add hasPreciseScrollingDeltas bit to PlatformWheelEvent on the Mac.
              https://bugs.webkit.org/show_bug.cgi?id=53107
      
              * platform/PlatformWheelEvent.h:
              (WebCore::PlatformWheelEvent::PlatformWheelEvent):
              (WebCore::PlatformWheelEvent::hasPreciseScrollingDeltas):
              * platform/mac/WheelEventMac.mm:
              (WebCore::PlatformWheelEvent::PlatformWheelEvent):
      2011-01-25  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Add hasPreciseScrollingDeltas bit to PlatformWheelEvent on the Mac.
              https://bugs.webkit.org/show_bug.cgi?id=53107
      
              * Shared/WebEvent.h:
              (WebKit::WebWheelEvent::hasPreciseScrollingDeltas):
              * Shared/WebEventConversion.cpp:
              (WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
              * Shared/WebWheelEvent.cpp:
              (WebKit::WebWheelEvent::WebWheelEvent):
              * Shared/mac/WebEventFactory.mm:
              (WebKit::WebEventFactory::createWebWheelEvent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e6de6b9
    • jer.noble@apple.com's avatar
      2011-01-20 Jer Noble <jer.noble@apple.com> · 1a9f042d
      jer.noble@apple.com authored
              Reviewed by Eric Carlson.
      
              REGRESSION (r72119): Audio never plays on Star Wars intro animation
              https://bugs.webkit.org/show_bug.cgi?id=52467
      
              Test the ability to read audio/m4a files.  Disabled this new test
              on the chromium and qt platforms, as they do not support M4A/AAC.
      
              * media/audio-mpeg4-supported-expected.txt: Added.
              * media/audio-mpeg4-supported.html: Added.
              * media/content/silence.m4a: Added.
              * platform/chromium/test_expectations.txt:
              * platform/qt/Skipped:
      2011-01-20  Jer Noble  <jer.noble@apple.com>
      
              Reviewed by Eric Carlson.
      
              REGRESSION (r72119): Audio never plays on Star Wars intro animation
              https://bugs.webkit.org/show_bug.cgi?id=52467
      
              QuickTime's eat/m4a movie importer compontent doesn't list audio/m4a as a mime
              type which it supports, though it handles .m4a files just fine.  Change the way
              we build the list of supported MIME Types through a new WebKitSystemInterface
              function.
      
              Caused by r72119, which adds system-specific extension->MIME entries to the cache
              before global entries, and the system-specific entries include QuickTime's registry
              entries which contain the audio/m4a MIME type, while its components do not.
      
              Test: media/audio-mpeg4-supported.html
      
              * WebCore.vcproj/QTMovieWinCommon.vsprops:
              * platform/graphics/win/QTMovie.cpp:
              (getMIMETypeCallBack):
              (initializeSupportedTypes):
              (QTMovie::countSupportedTypes): gSupportedTypes is now a CFArrayRef.
              (QTMovie::getSupportedType): Ditto.
      2011-01-24  Jer Noble  <jer.noble@apple.com>
      
              Reviewed by Eric Carlson.
      
              REGRESSION (r72119): Audio never plays on Star Wars intro animation
              https://bugs.webkit.org/show_bug.cgi?id=52467
      
              Add wkGetQuickTimeMIMETypeList() function.
      
              * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
              * win/lib/WebKitSystemInterface.lib:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a9f042d