1. 07 Feb, 2013 40 commits
    • roger_fong@apple.com's avatar
      Unreviewed. More VS2010 WebKit solution touchups. · 6af4414c
      roger_fong@apple.com authored
      * win/tools/vsprops/common.props:
      Move an ignored warning from a project to common properties.
      
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.filters:
      Make WebKitExports.def.in be treated as a custom build file so that changes to it cause the exports to be rebuilt.
      
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj:
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.filters:
      Make JavaScriptCoreExports.def.in be treated as a custom build file so that changes to it cause the exports to be rebuilt.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6af4414c
    • haraken@chromium.org's avatar
      Fix FIXMEs in WindowFeatures.h · 0a72e8fc
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109151
      
      Reviewed by Adam Barth.
      
      1. // FIXME: We can delete this constructor once V8 showModalDialog is
         // changed to use DOMWindow.
      
      This FIXME is not right. The WindowFeatures() constructor is used by
      other ports too (e.g. WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp).
      So we should remove the FIXME.
      
      2. // FIXME: We can make these functions private non-member functions
         // once V8 showModalDialog is changed to use DOMWindow.
      
      Given that V8 now uses DOMWindow in showModalDialog(), we can make the
      methods private.
      
      No tests. No change in behavior.
      
      * page/WindowFeatures.h:
      (WebCore):
      (WebCore::WindowFeatures::WindowFeatures):
      (WindowFeatures):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a72e8fc
    • commit-queue@webkit.org's avatar
      Fix build warning after r142017 · a936b564
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109119
      
      Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-07
      Reviewed by Alexey Proskuryakov.
      
      Use UNUSED_PARAM macro to fix -Wunused-parameter build warning.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::getPluginPath):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a936b564
    • abarth@webkit.org's avatar
      fast/parser/document-write-noscript.html fails for threaded HTML parser · 7c49500c
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109237
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      If there are multiple calls to document.write in an external script, we
      need to wait for them all to complete before invalidating the
      speculative tokens. Instead of doing this when we unwind the
      document.write call stack, we do this when we're about to resume
      parsing after script execution.
      
      Test: fast/parser/document-write-basic.html
      
      * html/parser/HTMLDocumentParser.cpp:
      (WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
      (WebCore::HTMLDocumentParser::insert):
      (WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
      
      LayoutTests:
      
      This tests basic document.write functionality.  There doesn't appear to
      be another fast/parser test that covers this basic case (although it's
      convered in some more complicated test cases incidentally.)
      
      * fast/parser/document-write-basic-expected.txt: Added.
      * fast/parser/document-write-basic.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c49500c
    • commit-queue@webkit.org's avatar
      Fix build when compiling with css3-text and css3-conditional-rules feature flags enabled. · 6a761c81
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109217
      
      Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-02-07
      Reviewed by Benjamin Poulain.
      
      * css/InspectorCSSOMWrappers.cpp:
      (WebCore::InspectorCSSOMWrappers::collect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a761c81
    • tkent@chromium.org's avatar
      REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute · ac0fd487
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109136
      
      Patch by Keishi Hattori <keishi@webkit.org> on 2013-02-07
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      Calendar picker was using the "Clear" button to calculate the window width.
      Since it doesn't exist when the input element has a required attribute,
      it was throwing an error. This patch fixes the width calculating logic.
      
      Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html
             platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html
      
      * Resources/pagepopups/calendarPicker.css:
      (.today-clear-area):
      * Resources/pagepopups/calendarPicker.js:
      (CalendarPicker.prototype.fixWindowSize): Fixing the logic to calculate
      the width. We don't want to use clear button because it doesn't exist
      when a value is required.
      
      LayoutTests:
      
      * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
      * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
      * platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Added.
      * platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Added.
      * platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Added.
      * platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Added.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac0fd487
    • tdanderson@chromium.org's avatar
      [chromium] Flings should not bubble up to enclosing scrollables when main-thread touch scrolling · bf6cd6ff
      tdanderson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108719
      
      Reviewed by Eric Seidel.
      
      In the event of a main-thread touch fling, dispatch a series of
      GestureScrollUpdateWithoutPropagation events defined in
      https://bugs.webkit.org/show_bug.cgi?id=108849 (instead of
      GestureScrollUpdate events) so that the fling does not
      propagate to enclosing scrollables.
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::scrollBy):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf6cd6ff
    • tdanderson@chromium.org's avatar
      Non-scrollable divs and non-scrollable iframes can scroll with touch · 1ebf08f8
      tdanderson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109087
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      Tests: fast/events/touch/gesture/touch-gesture-noscroll-div.html
             fast/events/touch/gesture/touch-gesture-noscroll-iframe.html
      
      When finding a candidate for a scrollable node in
      EventHandler::handleGestureScrollUpdate(), select the document node
      if it is reached before any scrollable element when walking up the DOM
      tree. Also ensure that calling RenderLayer::scrollBy() for a document
      node does not result in scrolling if the element is not scrollable.
      
      * page/EventHandler.cpp:
      (WebCore::closestScrollableNodeCandidate):
      (WebCore::EventHandler::handleGestureScrollUpdate):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollBy):
      
      LayoutTests:
      
      Two new layout tests added to demonstrate that the changes to
      RenderLayer::scrollBy() and closestScrollableNodeCandidate() in
      EventHandler.cpp are both necessary to ensure that non-scrollable
      divs and non-scrollable iframes cannot be scrolled with touch.
      
      * fast/events/touch/gesture/touch-gesture-noscroll-div-expected.txt: Added.
      * fast/events/touch/gesture/touch-gesture-noscroll-div.html: Added.
      * fast/events/touch/gesture/touch-gesture-noscroll-iframe-expected.txt: Added.
      * fast/events/touch/gesture/touch-gesture-noscroll-iframe.html: Added.
      * platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-div-expected.txt: Added.
      * platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-iframe-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ebf08f8
    • mark.lam@apple.com's avatar
      Introduce SQLTransactionBackend and SQLTransactionBackendSync [Part 2]. · c95e8bcb
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109109.
      
      Reviewed by Anders Carlsson.
      
      Adding back the new SQLTransaction and SQLTransactionSync files.
      
      No new tests.
      
      * Modules/webdatabase/SQLTransaction.cpp: Added.
      (WebCore::SQLTransaction::create):
      (WebCore::SQLTransaction::SQLTransaction):
      (WebCore::SQLTransaction::from):
      * Modules/webdatabase/SQLTransaction.h: Added.
      (SQLTransaction):
      * Modules/webdatabase/SQLTransactionSync.cpp: Added.
      (WebCore::SQLTransactionSync::create):
      (WebCore::SQLTransactionSync::SQLTransactionSync):
      (WebCore::SQLTransactionSync::from):
      * Modules/webdatabase/SQLTransactionSync.h: Added.
      (SQLTransactionSync):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c95e8bcb
    • mark.lam@apple.com's avatar
      Introduce SQLTransactionBackend and SQLTransactionBackendSync. · 604c2c20
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109109.
      
      Reviewed by Anders Carlsson.
      
      - Renamed SQLTransaction and SQLTransactionSync to SQLTransactionBackend
        and SQLTransactionBackendSync respectively.
      - Added back SQLTransaction and SQLTransactionSync as new files, and have
        their classes extends their respective backends. This is a stop gap
        measure to keep things working until the front-end and back-end can be
        properly split.
        Note: these files will be committed in a subsequent commit to ensure
        that the patching goes smoothly.
      - Where needed, I made use of new SQLTransaction::from() and
        SQLTransactionSync::from() static methods that "get" the front-end
        transactions from the back-ends. This is also a stop gap measure to
        keep things working until the proper refactoring is complete.
      - Fixed up pre-existing style checker violations that are now detected
        on code that were touched during my renaming.
      - Added the back-end files to all the build files.
      
      No new tests.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/webdatabase/Database.cpp:
      (WebCore::Database::scheduleTransactionStep):
      * Modules/webdatabase/Database.h:
      (Database):
      * Modules/webdatabase/DatabaseBackend.h:
      (DatabaseBackend):
      * Modules/webdatabase/DatabaseTask.cpp:
      (WebCore::DatabaseBackendAsync::DatabaseTransactionTask::DatabaseTransactionTask):
      * Modules/webdatabase/DatabaseTask.h:
      (WebCore::DatabaseBackendAsync::DatabaseTransactionTask::create):
      (WebCore::DatabaseBackendAsync::DatabaseTransactionTask::transaction):
      (DatabaseBackendAsync::DatabaseTransactionTask):
      * Modules/webdatabase/SQLTransaction.cpp: Removed.
      * Modules/webdatabase/SQLTransaction.h: Removed.
      * Modules/webdatabase/SQLTransactionBackend.cpp: Copied from Source/WebCore/Modules/webdatabase/SQLTransaction.cpp.
      (WebCore::SQLTransactionBackend::SQLTransactionBackend):
      (WebCore::SQLTransactionBackend::~SQLTransactionBackend):
      (WebCore::SQLTransactionBackend::executeSQL):
      (WebCore::SQLTransactionBackend::enqueueStatement):
      (WebCore::SQLTransactionBackend::debugStepName):
      (WebCore::SQLTransactionBackend::checkAndHandleClosedOrInterruptedDatabase):
      (WebCore::SQLTransactionBackend::performNextStep):
      (WebCore::SQLTransactionBackend::performPendingCallback):
      (WebCore::SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown):
      (WebCore::SQLTransactionBackend::acquireLock):
      (WebCore::SQLTransactionBackend::lockAcquired):
      (WebCore::SQLTransactionBackend::openTransactionAndPreflight):
      (WebCore::SQLTransactionBackend::deliverTransactionCallback):
      (WebCore::SQLTransactionBackend::scheduleToRunStatements):
      (WebCore::SQLTransactionBackend::runStatements):
      (WebCore::SQLTransactionBackend::getNextStatement):
      (WebCore::SQLTransactionBackend::runCurrentStatement):
      (WebCore::SQLTransactionBackend::handleCurrentStatementError):
      (WebCore::SQLTransactionBackend::deliverStatementCallback):
      (WebCore::SQLTransactionBackend::deliverQuotaIncreaseCallback):
      (WebCore::SQLTransactionBackend::postflightAndCommit):
      (WebCore::SQLTransactionBackend::deliverSuccessCallback):
      (WebCore::SQLTransactionBackend::cleanupAfterSuccessCallback):
      (WebCore::SQLTransactionBackend::handleTransactionError):
      (WebCore::SQLTransactionBackend::deliverTransactionErrorCallback):
      (WebCore::SQLTransactionBackend::cleanupAfterTransactionErrorCallback):
      * Modules/webdatabase/SQLTransactionBackend.h: Copied from Source/WebCore/Modules/webdatabase/SQLTransaction.h.
      (SQLTransactionBackend):
      * Modules/webdatabase/SQLTransactionBackendSync.cpp: Copied from Source/WebCore/Modules/webdatabase/SQLTransactionSync.cpp.
      (WebCore::SQLTransactionBackendSync::SQLTransactionBackendSync):
      (WebCore::SQLTransactionBackendSync::~SQLTransactionBackendSync):
      (WebCore::SQLTransactionBackendSync::executeSQL):
      (WebCore::SQLTransactionBackendSync::begin):
      (WebCore::SQLTransactionBackendSync::execute):
      (WebCore::SQLTransactionBackendSync::commit):
      (WebCore::SQLTransactionBackendSync::rollback):
      * Modules/webdatabase/SQLTransactionBackendSync.h: Copied from Source/WebCore/Modules/webdatabase/SQLTransactionSync.h.
      (SQLTransactionBackendSync):
      * Modules/webdatabase/SQLTransactionCoordinator.cpp:
      (WebCore::getDatabaseIdentifier):
      (WebCore::SQLTransactionCoordinator::processPendingTransactions):
      (WebCore::SQLTransactionCoordinator::acquireLock):
      (WebCore::SQLTransactionCoordinator::releaseLock):
      (WebCore::SQLTransactionCoordinator::shutdown):
      * Modules/webdatabase/SQLTransactionCoordinator.h:
      (SQLTransactionCoordinator):
      (WebCore::SQLTransactionCoordinator::SQLTransactionCoordinator):
      (CoordinationInfo):
      * Modules/webdatabase/SQLTransactionSync.cpp: Removed.
      * Modules/webdatabase/SQLTransactionSync.h: Removed.
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      604c2c20
    • tkent@chromium.org's avatar
      [Chromium] Add a flag to enable native form validation message · c1470aa4
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109134
      
      Reviewed by Adam Barth.
      
      * public/WebRuntimeFeatures.h:
      (WebRuntimeFeatures): Add enableNativeValidationMessage and
      isNativeValidationMessageEnabled.
      * src/WebRuntimeFeatures.cpp:
      (WebKit): Add nativeValidationMessageEnabled.
      (WebKit::WebRuntimeFeatures::enableNativeValidationMessage): Added.
      (WebKit::WebRuntimeFeatures::isNativeValidationMessageEnabled): Addedd.
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::WebViewImpl):
      Fill Page::PageClients::validationMessageClient if the flag is true.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1470aa4
    • dino@apple.com's avatar
      Use new speech bubble artwork for captions menu button · bc9d1774
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109215
      
      Reviewed by Eric Carlson.
      
      Rather than call into RenderTheme to display this button, embed artwork
      into the CSS. This means we can remove some uncalled methods in
      RenderTheme.
      
      * css/mediaControlsQuickTime.css:
      (video::-webkit-media-controls-toggle-closed-captions-button): New background image using SVG.
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::paint): Don't call the specific painter for the CC button.
      * rendering/RenderTheme.h: Remove unused function.
      * rendering/RenderThemeMac.h: Ditto.
      * rendering/RenderThemeMac.mm: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc9d1774
    • michelangelo@webkit.org's avatar
      [CSS Shaders] Add the last blending step · b933bd28
      michelangelo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104012
      
      Source/WebCore:
      
      The resulting blended color in mix() is now weighted according to
      the original element's backdrop alpha value.
      
      Reviewed by Dean Jackson.
      
      Test: css3/filters/custom/custom-filter-blend-fractional-destination-alpha.html
      
      * platform/graphics/filters/CustomFilterValidatedProgram.cpp:
      (WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader):
      
      LayoutTests:
      
      Added a test to check the correct blending in presence of a transparent backdrop.
      
      Reviewed by Dean Jackson.
      
      * css3/filters/custom/custom-filter-blend-fractional-destination-alpha-expected.html: Added.
      * css3/filters/custom/custom-filter-blend-fractional-destination-alpha.html: Added.
      * platform/mac/TestExpectations: This test is currently skipped on Mac for slight color
      differences, please see the relevant bug: http://webkit.org/b/107487
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b933bd28
    • benjamin@webkit.org's avatar
      Fix two exports of WebCore symbols on iOS · 188c255e
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109238
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
      Reviewed by David Kilzer.
      
      * WebCore.exp.in: Export wkCTFontTransformGlyphs but not
      wkCGContextDrawsWithCorrectShadowOffsets on iOS.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      188c255e
    • roger_fong@apple.com's avatar
      Unreviewed. Another temporary EWS bot fix. It'll totally work this time. · 3c4f5517
      roger_fong@apple.com authored
      * Scripts/webkitpy/tool/steps/runtests.py:
      (RunTests.run):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c4f5517
    • commit-queue@webkit.org's avatar
      [CSS Exclusions] Ignore ExclusionPolygon edges above minLogicalIntervalTop · 41c85590
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107566
      
      Patch by Hans Muller <hmuller@adobe.com> on 2013-02-07
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Improve ExclusionPolygon::firstIncludedIntervalLogicalTop() performance by only
      creating offset edges for polygon edges that are below the horizontal minLogicalIntervalTop
      line. In other words, don't bother creating offset edges that can't define the polygon's
      first fit location.
      
      Test: fast/exclusions/shape-inside/shape-inside-first-fit-004.html
      
      * rendering/ExclusionPolygon.cpp:
      (WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Don't create offset edges for polygon edges above minLogicalIntervalTop.
      
      LayoutTests:
      
      Added a simple polygonal shape-inside test where only a subset of the polygon edges
      should contribute to each line's offset edges.
      
      * fast/exclusions/shape-inside/shape-inside-first-fit-004-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-first-fit-004.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41c85590
    • jer.noble@apple.com's avatar
      Improve logging of MediaPlayerPrivateAVFoundation Notifications. · 5cb9854c
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109223
      
      Reviewed by Eric Carlson.
      
      Convert the existing Notification enum to an expandable macro. Then add a
      Logging-only function which stringifies the enums.
      
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      (WebCore):
      (WebCore::notificationName):
      (WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification):
      (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cb9854c
    • commit-queue@webkit.org's avatar
      Add layout test verifying role, subrole, and role description for all HTML elements and ARIA roles · 18b77bec
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109027
      
      Patch by James Craig <jcraig@apple.com> on 2013-02-07
      Reviewed by Chris Fleizach.
      
      New layout test verifies AXRole, AXSubrole, and AXRoleDescription for all HTML elements and ARIA roles.
      
      * platform/mac/accessibility/role-subrole-roledescription-expected.txt: Added.
      * platform/mac/accessibility/role-subrole-roledescription.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18b77bec
    • mhahnenberg@apple.com's avatar
      Objective-C API: testapi.mm should use ARC · 79ed063a
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107838
      
      Reviewed by Mark Rowe.
      
      Removing the changes to the Xcode project file and moving the equivalent flags into 
      the ToolExecutable xcconfig file.
      
      * Configurations/ToolExecutable.xcconfig:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79ed063a
    • benjamin@webkit.org's avatar
      Fix an incorrect comment from r142163 · 6d26bbbd
      benjamin@webkit.org authored
      Unreviewed.
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
      
      * wtf/MainThread.h:
      I accidentally copied PLATFORM(IOS) instead of USE(WEB_THREAD) for the #ifdef closing.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d26bbbd
    • roger_fong@apple.com's avatar
      Unreviewed. Fix syntax error in runtests.py. · a916e7c1
      roger_fong@apple.com authored
      * Scripts/webkitpy/tool/steps/runtests.py:
      (RunTests.run):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a916e7c1
    • bfulgham@webkit.org's avatar
      [Windows] Unreviewed Visual Studio 2010 build fixes after r142179. · c83dc28e
      bfulgham@webkit.org authored
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: Correct changed symbols
      * JavaScriptCore.vcxproj/JavaScriptCoreExports.def: Removed autogenerated file.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c83dc28e
    • roger_fong@apple.com's avatar
      Temporary fix for Win EWS bots. · 3b9a8990
      roger_fong@apple.com authored
      Don't build DRT since it has already been built in the build step.
      
      * Scripts/webkitpy/tool/steps/runtests.py:
      (RunTests.run):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b9a8990
    • mrobinson@webkit.org's avatar
      [GTK] Cleanup command-line defines · 9bc326ff
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109213
      
      Reviewed by Xan Lopez.
      
      .:
      
      * GNUmakefile.am: Remove references to flags that are now provided
      by autotoolsconfig.h
      * configure.ac: Add new AC_DEFINE invocations for flags that were
      before manually appended to the compiler CPPFLAGS and clump all
      AC_DEFINE invocations together.
      
      Source/WebCore:
      
      * GNUmakefile.am: Remove references to flags that are now handled
      via autotoolsconfig.h.
      
      Source/WebKit/gtk:
      
      * GNUmakefile.am: Remove references to flags that are now provided
      by autotoolsconfig.h
      
      Source/WebKit2:
      
      * GNUmakefile.am:  Remove references to flags that are now
      provided by autotoolsconfig.h.
      
      Tools:
      
      * TestWebKitAPI/config.h: Include the autotoolsconfig.h header to pick
      up defines from autoconf.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9bc326ff
    • rniwa@webkit.org's avatar
      git.svn_revision doesn't fetch the same revision as svn.svn_revision · 0c7b81d1
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108684
      
      Reviewed by Dirk Pranke.
      
      Always call git log on the checkout root.
      
      * Scripts/webkitpy/common/checkout/scm/git.py:
      (Git.svn_revision):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c7b81d1
    • tsepez@chromium.org's avatar
      [V8] Binding Integrity crash in V8MediaStream::createWrapper · ccb3ea3f
      tsepez@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109211
      
      Reviewed by Adam Barth.
      
      Patch suppresses a chrome crasher.
      
      * Modules/mediastream/MediaStream.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccb3ea3f
    • eric.carlson@apple.com's avatar
      [Mac] decrease in-band caption advance notice interval · 6bd81cfb
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109190
      
      Reviewed by Simon Fraser.
      
      No new tests, no observable change in behavior.
      
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Request cues 2 seconds in advance.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142176 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bd81cfb
    • roger_fong@apple.com's avatar
      Unreviewed. Patch for testing Win EWS bots. · bbf6c198
      roger_fong@apple.com authored
      * Scripts/webkitpy/tool/steps/runtests.py:
      (RunTests.run):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbf6c198
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 2ed655db
      zandobersek@gmail.com authored
      * platform/gtk/TestExpectations: Adding a failure expectation for a test in r142122.
      * platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r142149.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ed655db
    • gavinp@chromium.org's avatar
      Unreviewed, rolling out r142165. · dea022b6
      gavinp@chromium.org authored
      http://trac.webkit.org/changeset/142165
      https://bugs.webkit.org/show_bug.cgi?id=108466
      
      Broke linux_aura builds.
      
      * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
      * DumpRenderTree/DumpRenderTree.gypi:
      * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
      * DumpRenderTree/chromium/TestRunner/public/WebTask.h:
      (WebTaskList):
      * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
      * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
      (WebTestInterfaces):
      * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
      (WebTestProxyBase):
      * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
      (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
      (WebTestRunner::AccessibilityUIElementList::getOrCreate):
      (WebTestRunner::AccessibilityUIElementList::createRoot):
      * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
      (AccessibilityUIElementList):
      * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
      (WebTestRunner::CppBoundClass::~CppBoundClass):
      (WebTestRunner::CppBoundClass::invoke):
      (WebTestRunner::CppBoundClass::getProperty):
      (WebTestRunner::CppBoundClass::setProperty):
      (WebTestRunner::CppBoundClass::bindCallback):
      (WebTestRunner::CppBoundClass::bindGetterCallback):
      (WebTestRunner::CppBoundClass::bindProperty):
      (WebTestRunner::CppBoundClass::getAsCppVariant):
      * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
      (WebTestRunner):
      (CppBoundClass):
      (WebTestRunner::CppBoundClass::bindProperty):
      (WebTestRunner::CppBoundClass::bindFallbackCallback):
      (WebTestRunner::CppBoundClass::bindFallbackMethod):
      * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
      (WebTestRunner::CppVariant::toString):
      (WebTestRunner::CppVariant::toInt32):
      (WebTestRunner::CppVariant::toDouble):
      (WebTestRunner::CppVariant::toBoolean):
      (WebTestRunner::CppVariant::toStringVector):
      (WebTestRunner::CppVariant::invoke):
      (WebTestRunner::CppVariant::invokeDefault):
      * DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
      (CppVariant):
      * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
      (WebTestRunner):
      (WebTestRunner::EventSender::EventSender):
      (WebTestRunner::EventSender::reset):
      (WebTestRunner::EventSender::mouseDown):
      (WebTestRunner::EventSender::mouseUp):
      (WebTestRunner::EventSender::mouseMoveTo):
      (WebTestRunner::EventSender::keyDown):
      (WebTestRunner::EventSender::dispatchMessage):
      (WebTestRunner::EventSender::leapForward):
      (WebTestRunner::EventSender::replaySavedEvents):
      (WebTestRunner::makeMenuItemStringsFor):
      (WebTestRunner::EventSender::contextClick):
      (WebTestRunner::EventSender::beginDragWithFiles):
      (WebTestRunner::EventSender::addTouchPoint):
      (WebTestRunner::EventSender::releaseTouchPoint):
      (WebTestRunner::EventSender::updateTouchPoint):
      (WebTestRunner::EventSender::cancelTouchPoint):
      (WebTestRunner::EventSender::sendCurrentTouchEvent):
      (WebTestRunner::EventSender::gestureEvent):
      * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:
      (WebTestRunner::NativeKeyCodeForWindowsKeyCode):
      * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
      (MockGrammarCheck::checkGrammarOfString):
      * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:
      (MockGrammarCheck):
      * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
      (append):
      (isNotASCIIAlpha):
      (MockSpellCheck::spellCheckWord):
      (MockSpellCheck::initializeIfNeeded):
      * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
      (MockSpellCheck):
      * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
      (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
      (WebTestRunner::SpellCheckClient::finishLastTextCheck):
      * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
      * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
      (WebTestRunner::TestInterfaces::TestInterfaces):
      * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
      (TestInterfaces):
      * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
      (WebTestRunner::TestPlugin::TestPlugin):
      (WebTestRunner::TestPlugin::initialize):
      (WebTestRunner::TestPlugin::destroy):
      (WebTestRunner::TestPlugin::parsePrimitive):
      (WebTestRunner::TestPlugin::parseColor):
      (WebTestRunner::TestPlugin::initProgram):
      (WebTestRunner::TestPlugin::initPrimitive):
      (WebTestRunner::TestPlugin::drawPrimitive):
      (WebTestRunner::TestPlugin::loadShader):
      (WebTestRunner::TestPlugin::loadProgram):
      (WebTestRunner::TestPlugin::handleDragStatusUpdate):
      * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:
      (TestPlugin):
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
      (WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
      (WebTestRunner::TestRunner::WorkQueue::processWork):
      (WebTestRunner::TestRunner::WorkQueue::reset):
      (WebTestRunner::TestRunner::WorkQueue::addWork):
      (WebTestRunner::TestRunner::TestRunner):
      (WebTestRunner::TestRunner::reset):
      (WebTestRunner::TestRunner::policyDelegateDone):
      (WebTestRunner::TestRunner::findString):
      (WebTestRunner::TestRunner::setTextSubpixelPositioning):
      (WebTestRunner::TestRunner::overridePreference):
      (WebTestRunner):
      (WebTestRunner::TestRunner::setBackingScaleFactor):
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
      (WebTestRunner::TestRunner::WorkQueue::isEmpty):
      (TestRunner):
      * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
      (WebTestRunner::TextInputController::markedRange):
      (WebTestRunner::TextInputController::selectedRange):
      (WebTestRunner::TextInputController::firstRectForCharacterRange):
      * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
      (WebTestRunner::WebPreferences::reset):
      * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:
      (WebTestRunner):
      (WebTestRunner::WebTaskList::WebTaskList):
      (WebTestRunner::WebTaskList::~WebTaskList):
      (WebTestRunner::WebTaskList::registerTask):
      (WebTestRunner::WebTaskList::unregisterTask):
      (WebTestRunner::WebTaskList::revokeAll):
      * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
      (WebTestRunner::WebTestInterfaces::WebTestInterfaces):
      (WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
      (WebTestRunner::WebTestInterfaces::testInterfaces):
      * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
      (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
      (WebTestRunner::WebTestProxyBase::spellCheckClient):
      (WebTestRunner::WebTestProxyBase::registerIntentService):
      (WebTestRunner::WebTestProxyBase::dispatchIntent):
      (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
      * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dea022b6
    • commit-queue@webkit.org's avatar
      [GTK][AC] Clutter required version up to 1.12 · 14c28b76
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109037
      
      Patch by ChangSeok Oh <shivamidow@gmail.com> on 2013-02-07
      Reviewed by Martin Robinson.
      
      .:
      
      The clutter requried version is changed to 1.12.
      
      * configure.ac:
      
      Source/WebCore:
      
      Replace deprecated clutter apis with new ones.
      
      No new tests, since this patch is minor refactoring.
      
      * platform/graphics/clutter/GraphicsLayerActor.cpp:
      (graphicsLayerActorSetAnchorPoint):
      * platform/graphics/clutter/GraphicsLayerClutter.cpp:
      (WebCore::idleDestroy):
      (WebCore::GraphicsLayerClutter::updateSublayerList):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14c28b76
    • benjamin@webkit.org's avatar
      Move pauseAnimation/pauseTransition from TestRunner to Internals · 84dbb0d6
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109107
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Tests: animations/animation-internals-api-multiple-keyframes.html
             animations/animation-internals-api.html
      
      * testing/Internals.cpp:
      (WebCore::Internals::pauseAnimationAtTimeOnElement):
      (WebCore):
      (WebCore::Internals::pauseTransitionAtTimeOnElement):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * WebCoreSupport/DumpRenderTreeSupportEfl.h:
      
      Source/WebKit/gtk: 
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      (DumpRenderTreeSupportGtk):
      
      Source/WebKit/mac: 
      
      * WebView/WebFrame.mm:
      * WebView/WebFramePrivate.h:
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      * WebCoreSupport/DumpRenderTreeSupportQt.h:
      
      Source/WebKit2: 
      
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
      * WebProcess/WebPage/WebFrame.cpp:
      * WebProcess/WebPage/WebFrame.h:
      (WebFrame):
      
      Tools: 
      
      * DumpRenderTree/TestRunner.cpp:
      (TestRunner::staticFunctions):
      * DumpRenderTree/TestRunner.h:
      * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
      (WebTestRunner::TestRunner::TestRunner):
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
      (TestRunner):
      * DumpRenderTree/efl/TestRunnerEfl.cpp:
      * DumpRenderTree/gtk/TestRunnerGtk.cpp:
      * DumpRenderTree/mac/TestRunnerMac.mm:
      * DumpRenderTree/qt/TestRunnerQt.cpp:
      * DumpRenderTree/qt/TestRunnerQt.h:
      (TestRunner):
      * DumpRenderTree/win/TestRunnerWin.cpp:
      * DumpRenderTree/wx/TestRunnerWx.cpp:
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      
      LayoutTests: 
      
      Change the tests with the following:
      -Use the methods on Internals instead of TestRunner.
      -Adapt the calls to pass a particular element instead of an ID.
      -Remove feature detection. Having Internals implies having the feature.
      
      * animations/animation-hit-test-transform.html:
      * animations/animation-hit-test.html:
      * animations/animation-internals-api-expected.txt: Renamed from LayoutTests/animations/animation-drt-api-expected.txt.
      * animations/animation-internals-api-multiple-keyframes-expected.txt: Renamed from LayoutTests/animations/animation-drt-api-multiple-keyframes-expected.txt.
      * animations/animation-internals-api-multiple-keyframes.html: Renamed from LayoutTests/animations/animation-drt-api-multiple-keyframes.html.
      * animations/animation-internals-api.html: Renamed from LayoutTests/animations/animation-drt-api.html.
      * animations/change-keyframes-name.html:
      * animations/change-transform-style-during-animation.html:
      * animations/missing-from-to-transforms.html:
      * animations/missing-from-to.html:
      * animations/resources/animation-test-helpers.js:
      (checkExpectedValue):
      (startTest):
      * css3/calc/transitions-dependent.html:
      * fast/dom/shadow/transition-on-shadow-host-with-distributed-node.html:
      * transitions/opacity-transition-zindex.html:
      * transitions/resources/transition-test-helpers.js:
      (expected):
      * transitions/transition-drt-api-delay.html:
      * transitions/transition-drt-api.html:
      * transitions/transition-hit-test-transform.html:
      * transitions/transition-hit-test.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142171 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84dbb0d6
    • gavinp@chromium.org's avatar
      Unreviewed, rolling out r142155. · 69942591
      gavinp@chromium.org authored
      http://trac.webkit.org/changeset/142155
      https://bugs.webkit.org/show_bug.cgi?id=82888
      
      cr/win build broke.
      
      * bindings/js/JSClipboardCustom.cpp:
      (WebCore::JSClipboard::types):
      * bindings/v8/custom/V8ClipboardCustom.cpp:
      (WebCore::V8Clipboard::typesAccessorGetter):
      * dom/Clipboard.h:
      (Clipboard):
      * platform/blackberry/ClipboardBlackBerry.cpp:
      (WebCore::ClipboardBlackBerry::types):
      * platform/blackberry/ClipboardBlackBerry.h:
      (ClipboardBlackBerry):
      * platform/chromium/ChromiumDataObject.cpp:
      (WebCore::ChromiumDataObject::types):
      * platform/chromium/ChromiumDataObject.h:
      (ChromiumDataObject):
      * platform/chromium/ClipboardChromium.cpp:
      (WebCore::ClipboardChromium::types):
      * platform/chromium/ClipboardChromium.h:
      (ClipboardChromium):
      * platform/efl/ClipboardEfl.cpp:
      (WebCore::ClipboardEfl::types):
      * platform/efl/ClipboardEfl.h:
      (ClipboardEfl):
      * platform/gtk/ClipboardGtk.cpp:
      (WebCore::ClipboardGtk::types):
      * platform/gtk/ClipboardGtk.h:
      (ClipboardGtk):
      * platform/mac/ClipboardMac.h:
      (ClipboardMac):
      * platform/mac/ClipboardMac.mm:
      (WebCore::addHTMLClipboardTypesForCocoaType):
      (WebCore::ClipboardMac::types):
      * platform/qt/ClipboardQt.cpp:
      (WebCore::ClipboardQt::types):
      * platform/qt/ClipboardQt.h:
      (ClipboardQt):
      * platform/win/ClipboardWin.cpp:
      (WebCore::addMimeTypesForFormat):
      (WebCore::ClipboardWin::types):
      * platform/win/ClipboardWin.h:
      (ClipboardWin):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69942591
    • mikhail.pozdnyakov@intel.com's avatar
      [WK2][EFL] Removal of non coordinated graphics code path from WK2 EFL · 4ffe112b
      mikhail.pozdnyakov@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109165
      
      Reviewed by Anders Carlsson.
      
      Removed non coordinated graphics code path from WK2 EFL as it was not used by
      anyone and caused a lot of preprocessor macros in the code making it less readable.
      
      * UIProcess/API/efl/EvasGLContext.cpp:
      * UIProcess/API/efl/EvasGLContext.h:
      (WebKit::EvasGLContext::context):
      * UIProcess/API/efl/EvasGLSurface.cpp:
      * UIProcess/API/efl/EvasGLSurface.h:
      (WebKit::EvasGLSurface::surface):
      
          Removed also 'inline' and 'const' keywords from functions declaration,
          as both EvasGLContext::context() and EvasGLSurface::surface()
          are defined inside their classes and return mutable pointer.
      
      * UIProcess/API/efl/EwkView.cpp:
      (EwkView::EwkView):
      (EwkView::transformFromScene):
      (EwkView::transformToScreen):
      (EwkView::coordinatedGraphicsScene):
      (EwkView::displayTimerFired):
      (EwkView::scheduleUpdateDisplay): Renamed from EwkView::update().
      (EwkView::exitAcceleratedCompositingMode):
      (EwkView::handleEvasObjectCalculate):
      (EwkView::takeSnapshot):
      * UIProcess/API/efl/EwkView.h:
      (WebCore):
      (EwkView):
      * UIProcess/API/efl/SnapshotImageGL.cpp:
      (getImageSurfaceFromFrameBuffer):
      * UIProcess/API/efl/SnapshotImageGL.h:
      * UIProcess/API/efl/ewk_view.cpp:
      * UIProcess/efl/PageClientBase.cpp:
      (WebKit::PageClientBase::setViewNeedsDisplay):
      (WebKit::PageClientBase::updateAcceleratedCompositingMode):
      * UIProcess/efl/PageClientBase.h:
      (PageClientBase):
      * UIProcess/efl/PageClientDefaultImpl.cpp:
      (WebKit::PageClientDefaultImpl::didCommitLoad):
      (WebKit::PageClientDefaultImpl::updateViewportSize):
      (WebKit::PageClientDefaultImpl::didChangeViewportProperties):
      (WebKit::PageClientDefaultImpl::didChangeContentsSize):
      (WebKit::PageClientDefaultImpl::pageTransitionViewportReady):
      * UIProcess/efl/PageClientDefaultImpl.h:
      (PageClientDefaultImpl):
      * UIProcess/efl/PageClientLegacyImpl.cpp:
      (WebKit::PageClientLegacyImpl::didCommitLoad):
      (WebKit::PageClientLegacyImpl::updateViewportSize):
      (WebKit::PageClientLegacyImpl::didChangeViewportProperties):
      (WebKit::PageClientLegacyImpl::didChangeContentsSize):
      (WebKit::PageClientLegacyImpl::pageDidRequestScroll):
      (WebKit::PageClientLegacyImpl::didRenderFrame):
      (WebKit::PageClientLegacyImpl::pageTransitionViewportReady):
      * UIProcess/efl/PageClientLegacyImpl.h:
      (PageClientLegacyImpl):
      * UIProcess/efl/PageLoadClientEfl.cpp:
      (WebKit::PageLoadClientEfl::didCommitLoadForFrame):
      (WebKit::PageLoadClientEfl::PageLoadClientEfl):
      * UIProcess/efl/PageLoadClientEfl.h:
      (PageLoadClientEfl):
      * UIProcess/efl/PageViewportControllerClientEfl.cpp:
      (WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
      (WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):
      * UIProcess/efl/PageViewportControllerClientEfl.h:
      * UIProcess/efl/WebInspectorProxyEfl.cpp:
      (WebKit::WebInspectorProxy::platformCreateInspectorPage):
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::contentsSizeChanged):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ffe112b
    • commit-queue@webkit.org's avatar
      Add support for parsing of -webkit-background-blend-mode · 62ba45f8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108547
      
      Patch by Rik Cabanier <cabanier@adobe.com> on 2013-02-07
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Added parsing and general CSS handling of -webkit-background-blend-mode per
      https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#background-blend-mode
      
      Tests: css3/compositing/background-blend-mode-property-parsing.html
             css3/compositing/background-blend-mode-property.html
      
      * css/CSSComputedStyleDeclaration.cpp: Built value for getComputedStyle.
      (WebCore):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp: Parsed and stored value of -webkit-background-blend-mode.
      (WebCore::CSSParser::parseValue):
      (WebCore::CSSParser::parseFillProperty):
      * css/CSSProperty.cpp: Listed -webkit-background-blend-mode as a non-inherited property.
      (WebCore::CSSProperty::isInheritedProperty):
      * css/CSSPropertyNames.in: Added -webkit-background-blend-mode as a CSS property.
      * css/CSSToStyleMap.cpp: Mapped background blend mode from CSS value to enum.
      (WebCore::CSSToStyleMap::mapFillBlendMode):
      (WebCore):
      * css/CSSToStyleMap.h: Added function declaration 'mapFillBlendMode'.
      (CSSToStyleMap):
      * css/StyleBuilder.cpp: Set up propery handler for -webkit-background-blend-mode.
      (WebCore::StyleBuilder::StyleBuilder):
      * rendering/style/FillLayer.cpp: Added code to store and retrieve the blend mode from a layer.
      (WebCore::FillLayer::FillLayer):
      (WebCore::FillLayer::operator=):
      (WebCore::FillLayer::operator==):
      (WebCore::FillLayer::fillUnsetProperties):
      * rendering/style/FillLayer.h: Added function definitions to manage blend mode in a layer.
      (WebCore::FillLayer::blendMode):
      (WebCore::FillLayer::isBlendModeSet):
      (WebCore::FillLayer::setBlendMode):
      (WebCore::FillLayer::clearBlendMode):
      (WebCore::FillLayer::initialFillBlendMode):
      (FillLayer):
      
      LayoutTests:
      
      Added parsing and general CSS handling of -webkit-background-blend-mode per
      https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#background-blend-mode
      
      * css3/compositing/background-blend-mode-property-expected.txt: Added.
      * css3/compositing/background-blend-mode-property-parsing-expected.txt: Added.
      * css3/compositing/background-blend-mode-property-parsing.html: Added.
      * css3/compositing/background-blend-mode-property.html: Added.
      * css3/compositing/script-tests/background-blend-mode-property-parsing.js: Added.
      (jsWrapperClass):
      (shouldBeType):
      (testBlendModeRule):
      * css3/compositing/script-tests/background-blend-mode-property.js: Added.
      (testblendmode):
      
      * css3/compositing/background-blend-mode-property-expected.txt: Added.
      * css3/compositing/background-blend-mode-property-parsing-expected.txt: Added.
      * css3/compositing/background-blend-mode-property-parsing.html: Added.
      * css3/compositing/background-blend-mode-property.html: Added.
      * css3/compositing/script-tests/background-blend-mode-property-parsing.js: Added.
      (jsWrapperClass):
      (shouldBeType):
      (testBlendModeRule):
      * css3/compositing/script-tests/background-blend-mode-property.js: Added.
      (testblendmode):
      * platform/chromium/css3/compositing/background-blend-mode-property-expected.txt: Added.
      * platform/chromium/css3/compositing/background-blend-mode-property-parsing-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62ba45f8
    • gavinp@chromium.org's avatar
      Unreviewed, rolling out r142142. · 2b5abc7b
      gavinp@chromium.org authored
      http://trac.webkit.org/changeset/142142
      https://bugs.webkit.org/show_bug.cgi?id=109154
      
      Source/WebCore:
      
      Mac expectations were not right. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio-leak-test.html and http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio.html .
      
      * inspector/front-end/DefaultTextEditor.js:
      (WebInspector.TextEditorMainPanel.prototype._registerShortcuts):
      
      LayoutTests:
      
      Mac expectations were not right. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Feditor%2Ftext-editor-home-button.html
      
      * inspector/editor/text-editor-home-button-expected.txt: Removed.
      * inspector/editor/text-editor-home-button.html: Removed.
      * platform/efl/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b5abc7b
    • gavinp@chromium.org's avatar
      Unreviewed, rolling out r142081. · ea04ea86
      gavinp@chromium.org authored
      http://trac.webkit.org/changeset/142081
      https://bugs.webkit.org/show_bug.cgi?id=109146
      
      The patch caused a crash in inspector-protocol/nmi-webaudio*.html .
      
      See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio-leak-test.html and http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio.html .
      
      * dom/WebCoreMemoryInstrumentation.cpp:
      (WebCore):
      * inspector/front-end/NativeMemorySnapshotView.js:
      (WebInspector.MemoryBlockViewProperties._initialize):
      * platform/PlatformMemoryInstrumentation.cpp:
      (WebCore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea04ea86
    • jochen@chromium.org's avatar
      [chromium] turn TestRunner library into a component build · a985b1be
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108466
      
      Reviewed by Adam Barth.
      
      To achieve this, we need to drop all dependencies on WTF.
      
      * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
      * DumpRenderTree/DumpRenderTree.gypi:
      * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
      * DumpRenderTree/chromium/TestRunner/public/WebTask.h:
      * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
      * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
      * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
      * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
      (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
      (WebTestRunner::AccessibilityUIElementList::getOrCreate):
      (WebTestRunner::AccessibilityUIElementList::createRoot):
      * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
      (AccessibilityUIElementList):
      * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
      (WebTestRunner::CppBoundClass::~CppBoundClass):
      (WebTestRunner::CppBoundClass::invoke):
      (WebTestRunner::CppBoundClass::getProperty):
      (WebTestRunner::CppBoundClass::setProperty):
      (WebTestRunner::CppBoundClass::bindCallback):
      (WebTestRunner::CppBoundClass::bindGetterCallback):
      (WebTestRunner::CppBoundClass::bindProperty):
      (WebTestRunner::CppBoundClass::getAsCppVariant):
      * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
      (WebTestRunner):
      (CppBoundClass):
      (WebTestRunner::CppBoundClass::bindProperty):
      (WebTestRunner::CppBoundClass::bindFallbackCallback):
      (WebTestRunner::CppBoundClass::bindFallbackMethod):
      * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
      (WebTestRunner::CppVariant::toString):
      (WebTestRunner::CppVariant::toInt32):
      (WebTestRunner::CppVariant::toDouble):
      (WebTestRunner::CppVariant::toBoolean):
      (WebTestRunner::CppVariant::toStringVector):
      (WebTestRunner::CppVariant::invoke):
      (WebTestRunner::CppVariant::invokeDefault):
      * DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
      (CppVariant):
      * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
      (WebTestRunner):
      (WebTestRunner::EventSender::EventSender):
      (WebTestRunner::EventSender::reset):
      (WebTestRunner::EventSender::mouseDown):
      (WebTestRunner::EventSender::mouseUp):
      (WebTestRunner::EventSender::mouseMoveTo):
      (WebTestRunner::EventSender::keyDown):
      (WebTestRunner::EventSender::dispatchMessage):
      (WebTestRunner::EventSender::leapForward):
      (WebTestRunner::EventSender::replaySavedEvents):
      (WebTestRunner::makeMenuItemStringsFor):
      (WebTestRunner::EventSender::contextClick):
      (WebTestRunner::EventSender::beginDragWithFiles):
      (WebTestRunner::EventSender::addTouchPoint):
      (WebTestRunner::EventSender::releaseTouchPoint):
      (WebTestRunner::EventSender::updateTouchPoint):
      (WebTestRunner::EventSender::cancelTouchPoint):
      (WebTestRunner::EventSender::sendCurrentTouchEvent):
      (WebTestRunner::EventSender::gestureEvent):
      * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:
      (WebTestRunner::NativeKeyCodeForWindowsKeyCode):
      * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
      (WebTestRunner::MockGrammarCheck::checkGrammarOfString):
      (WebTestRunner):
      * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:
      (WebTestRunner):
      (MockGrammarCheck):
      * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
      (WebTestRunner::MockSpellCheck::spellCheckWord):
      (WebTestRunner::MockSpellCheck::initializeIfNeeded):
      (WebTestRunner):
      * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
      (MockSpellCheck):
      * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
      (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
      (WebTestRunner::SpellCheckClient::finishLastTextCheck):
      * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
      (isASCIIAlpha):
      (isNotASCIIAlpha):
      * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
      (WebTestRunner::TestInterfaces::TestInterfaces):
      * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
      (TestInterfaces):
      * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
      (WebTestRunner::TestPlugin::TestPlugin):
      (WebTestRunner::TestPlugin::initialize):
      (WebTestRunner::TestPlugin::destroy):
      (WebTestRunner::TestPlugin::parsePrimitive):
      (WebTestRunner::TestPlugin::parseColor):
      (WebTestRunner::TestPlugin::initProgram):
      (WebTestRunner::TestPlugin::initPrimitive):
      (WebTestRunner::TestPlugin::drawPrimitive):
      (WebTestRunner::TestPlugin::loadShader):
      (WebTestRunner::TestPlugin::loadProgram):
      (WebTestRunner::TestPlugin::handleDragStatusUpdate):
      * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:
      (TestPlugin):
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
      (WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
      (WebTestRunner::TestRunner::WorkQueue::processWork):
      (WebTestRunner::TestRunner::WorkQueue::reset):
      (WebTestRunner::TestRunner::WorkQueue::addWork):
      (WebTestRunner::TestRunner::TestRunner):
      (WebTestRunner::TestRunner::reset):
      (WebTestRunner::TestRunner::policyDelegateDone):
      (WebTestRunner::TestRunner::findString):
      (WebTestRunner::TestRunner::setTextSubpixelPositioning):
      (WebTestRunner::TestRunner::overridePreference):
      (WebTestRunner::TestRunner::deliverWebIntent):
      (WebTestRunner::TestRunner::setBackingScaleFactor):
      (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
      (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
      (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
      (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
      (WebTestRunner::TestRunner::WorkQueue::isEmpty):
      (TestRunner):
      * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
      (WebTestRunner::TextInputController::markedRange):
      (WebTestRunner::TextInputController::selectedRange):
      (WebTestRunner::TextInputController::firstRectForCharacterRange):
      * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
      (WebTestRunner::WebPreferences::reset):
      * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:
      (WebTestRunner::WebTaskList::~WebTaskList):
      (WebTestRunner::WebTaskList::registerTask):
      (WebTestRunner::WebTaskList::unregisterTask):
      (WebTestRunner::WebTaskList::revokeAll):
      * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
      (WebTestRunner::WebTestInterfaces::WebTestInterfaces):
      (WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
      (WebTestRunner::WebTestInterfaces::testInterfaces):
      * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
      (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
      (WebTestRunner::WebTestProxyBase::spellCheckClient):
      (WebTestRunner::WebTestProxyBase::registerIntentService):
      (WebTestRunner::WebTestProxyBase::dispatchIntent):
      (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
      * DumpRenderTree/chromium/TestRunner/src/config.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a985b1be
    • commit-queue@webkit.org's avatar
      [CSS Exclusions] shape-inside does not properly handle padding or border · a24e4773
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102715
      
      Patch by Bear Travis <betravis@adobe.com> on 2013-02-07
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      This patch positions the exclusion shape based on the value of the css box sizing
      property. Geometry calculations happen in the shape coordinate space. For layout,
      these coordinates are translated to the border-box coordinate system by adding
      the appropriate offsets.
      
      Test: fast/exclusions/shape-inside/shape-inside-box-sizing.html
      
      * rendering/ExclusionShapeInfo.cpp:
      (WebCore::::computedShape): Pass m_shapeLogicalWidth to the exclusion shape
      geometry code.
      * rendering/ExclusionShapeInfo.h:
      (WebCore::ExclusionShapeInfo::setShapeSize): Adjust block layout dimensions to
      shape dimensions when checking to see if the shape geometry must be recalculated.
      (WebCore::ExclusionShapeInfo::shapeLogicalTop): Account for layout offsets.
      (WebCore::ExclusionShapeInfo::shapeLogicalBottom): Ditto.
      (WebCore::ExclusionShapeInfo::shapeLogicalLeft): Ditto.
      (WebCore::ExclusionShapeInfo::shapeLogicalRight): Ditto.
      (WebCore::ExclusionShapeInfo::logicalTopOffset): Return the offset from the logical
      top of the border box to the logical top of the shape.
      (WebCore::ExclusionShapeInfo::logicalLeftOffset): Return the offset from the logical
      left of the border box to the logical left of the shape.
      (ExclusionShapeInfo):
      * rendering/ExclusionShapeInsideInfo.cpp:
      (WebCore::ExclusionShapeInsideInfo::computeSegmentsForLine): Adjust line top to
      be in shape coordinates.
      (WebCore::ExclusionShapeInsideInfo::adjustLogicalLineTop): Ditto.
      * rendering/ExclusionShapeInsideInfo.h:
      (WebCore::ExclusionShapeInsideInfo::lineOverlapsShapeBounds): Use consistent
      coordinate system (border box) to test for whether a line overlaps a shape.
      (WebCore::ExclusionShapeInsideInfo::logicalLineTop): Include the logical offset
      from the border box.
      (WebCore::ExclusionShapeInsideInfo::logicalLineBottom): Ditto.
      
      LayoutTests:
      
      Test that borders and padding are properly accounted for when laying out text in
      a shape inside.
      
      * fast/exclusions/shape-inside/shape-inside-bottom-edge.html: Modified to no longer
      use padding.
      * fast/exclusions/shape-inside/shape-inside-box-sizing-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-box-sizing.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a24e4773
    • benjamin@webkit.org's avatar
      Upstream iOS isWebThread() and isUIThread() · 4333db5d
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109130
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
      Reviewed by Sam Weinig.
      
      Source/WebCore: 
      
      * bindings/objc/WebScriptObject.mm:
      (+[WebScriptObject initialize]):
      * platform/mac/SharedBufferMac.mm:
      (+[WebCoreSharedBufferData initialize]):
      #ifdef out the legacy initialization as it is not correct when
      using a WebThread.
      
      Source/WTF: 
      
      On iOS, it is sometimes necessary to differenciate the thread running WebCore,
      and the thread running the UI. This patch upstream those functions.
      
      * wtf/MainThread.cpp:
      * wtf/MainThread.h:
      Disable the legacy initializer as it is incorrect when using the WebThread to run WebCore.
      (WTF::isWebThread):
      (WTF::isUIThread):
      Return true when the current thread is the Web/UI thread.
      
      * wtf/mac/MainThreadMac.mm:
      (WTF::isUIThread):
      (WTF::isWebThread):
      
      * wtf/text/AtomicString.cpp:
      (WTF::AtomicStringTable::create):
      Use the newly added methods.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4333db5d