1. 25 Feb, 2008 19 commits
    • andersca@apple.com's avatar
      Reviewed by Darin. · 6ac9e50e
      andersca@apple.com authored
              Move remaining render style objects over to start with a refcount of 1 and get
              rid of DeprecatedDataRef.
              
              * rendering/DataRef.h:
              (WebCore::DataRef::operator*):
              (WebCore::DataRef::operator->):
              * rendering/RenderStyle.h:
              * rendering/SVGRenderStyle.cpp:
              (WebCore::SVGRenderStyle::SVGRenderStyle):
              * rendering/SVGRenderStyle.h:
              (WebCore::SVGRenderStyle::create):
              (WebCore::SVGRenderStyle::copy):
              * rendering/SVGRenderStyleDefs.cpp:
              (StyleFillData::StyleFillData):
              (StyleStrokeData::StyleStrokeData):
              (StyleStopData::StyleStopData):
              (StyleTextData::StyleTextData):
              (StyleClipData::StyleClipData):
              (StyleMaskData::StyleMaskData):
              (StyleMarkerData::StyleMarkerData):
              (StyleMiscData::StyleMiscData):
              * rendering/SVGRenderStyleDefs.h:
              (WebCore::StyleFillData::create):
              (WebCore::StyleFillData::copy):
              (WebCore::StyleStrokeData::create):
              (WebCore::StyleStrokeData::copy):
              (WebCore::StyleStopData::create):
              (WebCore::StyleStopData::copy):
              (WebCore::StyleTextData::create):
              (WebCore::StyleTextData::copy):
              (WebCore::StyleClipData::create):
              (WebCore::StyleClipData::copy):
              (WebCore::StyleMaskData::create):
              (WebCore::StyleMaskData::copy):
              (WebCore::StyleMarkerData::create):
              (WebCore::StyleMarkerData::copy):
              (WebCore::StyleMiscData::create):
              (WebCore::StyleMiscData::copy):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ac9e50e
    • mrowe@apple.com's avatar
      2008-02-25 Mark Mentovai <mark@moxienet.com> · 3b6e3b06
      mrowe@apple.com authored
              Reviewed by Mark Rowe.
      
              Enable CollectorHeapIntrospector to build by itself, as well as in an AllInOneFile build.
              http://bugs.webkit.org/show_bug.cgi?id=17538
      
              * kjs/CollectorHeapIntrospector.cpp: Provide "using" declaration for
                WTF::RemoteMemoryReader.
              * kjs/collector.h: Move CollectorHeap declaration here...
              * kjs/collector.cpp: ... from here.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b6e3b06
    • mitz@apple.com's avatar
      Reviewed by Dave Hyatt. · 887f359e
      mitz@apple.com authored
              - remove file-static BidiRun variables from bidi.cpp
      
              * platform/text/BidiResolver.h:
              (WebCore::BidiResolver::): Initialize m_logicallyLastRun.
              (WebCore::BidiResolver::logicallyLastRun): Added.
              (WebCore::BidiResolver::runCount): Made unsigned.
              (WebCore::::reverseRuns): Changed ints to unsigned.
              (WebCore::::createBidiRunsForLine): Made this function set
              m_logicallyLastRun.
              * rendering/RenderBlock.h:
              * rendering/bidi.cpp:
              (WebCore::BidiState::addRun): Removed setting of sLogicallyLastBidiRun.
              (WebCore::RenderBlock::constructLine): Removed unused start parameter
              and added run count and first and last run parameters. Replaced end
              parameter with lastLine boolean and endObject pointer.
              (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added first
              and logically last run parameters.
              (WebCore::RenderBlock::computeVerticalPositionsForLine): Added firstRun
              parameter.
              (WebCore::RenderBlock::bidiReorderLine): Removed setting of static
              variables.
              (WebCore::RenderBlock::layoutInlineChildren): Changed to use BidiState
              accessors instead of file statics.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      887f359e
    • mrowe@apple.com's avatar
      2008-02-25 Rodney Dawes <dobey@wayofthemonkey.com> · 81bf662c
      mrowe@apple.com authored
              Reviewed by Jon Honeycutt.
      
              http://bugs.webkit.org/show_bug.cgi?id=16924
              Bug 16924: Shared PluginDatabase, PluginPackage, and PlugInInfoStore implementations
      
              Add PluginInfoStore.cpp and new PluginDatabase.cpp to GTK+ and Qt ports.
              Remove old PlugInInfoStoreQt.cpp as it is obsoleted by shared code.
              Add PluginInfoStore, PluginDatabase, and PluginStream files to Wx build.
              Add new PluginDatabase.cpp to Windows build.
              Add temporary stubs for new PluginDatabase and PluginPackage.
              shared classes to GTK+, Qt, and Wx ports.
              Copy PluginDatabaseWin.cpp to PluginDatabase.cpp to preserve history.
              Remove shared code from PluginDatabaseWin.cpp.
              Remove Windows-specific code from PluginDatabase.cpp.
              Use PlatformModule and PlatformFileTime instead of HMODULE and FILETIME.
              Remove extraneous PluginPackage:: from hash() class method prototype.
              Subsume storeFileVersion into PluginPackage::fetchInfo.
              Add cross-platform PlatformModuleVersion type definition.
              Use PlatformModuleVersion to store the module version.
              Rename m_fileVersion[ML]S to m_moduleVersion.
              Change compareFileVersion to use PlatformModuleVersion as the argument.
              Move PluginView::determineQuirks and m_quirks to PluginPackage.
              Updated determineQuirks for the PlatformModuleVersion.
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCoreSources.bkl:
              * webcore-base.bkl:
              * WebCore.vcproj/WebCore.vcproj:
              * Platform/FileSystem.h:
              * platform/qt/PlugInInfoStoreQt.cpp:
              * platform/gtk/TemporaryLinkStubs.cpp:
              * platform/qt/TemporaryLinkStubs.cpp:
              * platform/wx/TemporaryLinkStubs.cpp:
              * plugins/PluginDatabase.cpp:
              * plugins/PluginDatabase.h:
              * plugins/win/PluginDatabaseWin.cpp:
              * plugins/PluginPackage.h:
              * plugins/win/PluginPackageWin.cpp:
              * plugins/PluginView.h:
              * plugins/win/PluginViewWin.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81bf662c
    • andersca@apple.com's avatar
      Reviewed by Darin. · 63d5b8ed
      andersca@apple.com authored
              Make more style objects start out with a refcount of 1.
              
              * rendering/RenderStyle.cpp:
              (WebCore::StyleSurroundData::StyleSurroundData):
              (WebCore::StyleBoxData::StyleBoxData):
              (WebCore::StyleVisualData::StyleVisualData):
              (WebCore::StyleBackgroundData::StyleBackgroundData):
              (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
              (WebCore::StyleRareInheritedData::StyleRareInheritedData):
              (WebCore::StyleInheritedData::StyleInheritedData):
              * rendering/RenderStyle.h:
              (WebCore::StyleSurroundData::create):
              (WebCore::StyleSurroundData::copy):
              (WebCore::StyleBoxData::create):
              (WebCore::StyleBoxData::copy):
              (WebCore::StyleVisualData::create):
              (WebCore::StyleVisualData::copy):
              (WebCore::StyleBackgroundData::create):
              (WebCore::StyleBackgroundData::copy):
              (WebCore::StyleBackgroundData::~StyleBackgroundData):
              (WebCore::StyleRareNonInheritedData::create):
              (WebCore::StyleRareNonInheritedData::copy):
              (WebCore::StyleRareInheritedData::create):
              (WebCore::StyleRareInheritedData::copy):
              (WebCore::StyleInheritedData::create):
              (WebCore::StyleInheritedData::copy):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63d5b8ed
    • andersca@apple.com's avatar
      Reviewed by Darin. · 5c3a52de
      andersca@apple.com authored
              Make some of the refcounted style objects start out with a refcount of 1.
      
              * rendering/DataRef.h:
              Make a DeprecatedDataRef class which is just a copy of the old DataRef class.
              Change DataRef to use ::create() and ::copy() instead of the constructors.
              Change DataRef's pointer to be a RefPtr instead.
      
              * rendering/RenderStyle.cpp:
              (WebCore::StyleMarqueeData::StyleMarqueeData):
              (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
              (WebCore::StyleMultiColData::StyleMultiColData):
              (WebCore::StyleTransformData::StyleTransformData):
              Start with a RefCount of 1.
              
              * rendering/RenderStyle.h:
              * rendering/SVGRenderStyle.h:
              Add ::create() and ::copy() methods. Make not yet converted classes use DeprecatedDataRef.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c3a52de
    • darin@apple.com's avatar
      WebCore: · 129cdd7b
      darin@apple.com authored
              Reviewed by Anders.
              Based on a patch by Tim Steele <timsteele41@gmail.com>.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=17186
                Fragment navigation within a page permanently cancels meta refresh
      
              Test: fast/loader/meta-refresh-anchor-click.html
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::load): When load type is FrameLoadTypeRedirectWithLockedHistory,
              always do a real load. This makes sure that meta refresh loads are treated as real loads
              rather than anchor scrolls. Also tweaked formatting a bit.
              (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): This function is
              an alternate way to complete a load, so it needs to start the redirection timer if
              redirection has already been scheduled.
      
      LayoutTests:
      
              Reviewed by Anders.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=17186
                Fragment navigation within a page permanently cancels meta refresh
      
              * fast/loader/meta-refresh-anchor-click-expected.txt: Added.
              * fast/loader/meta-refresh-anchor-click.html: Added.
              * fast/loader/resources/meta-refresh-subframe.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      129cdd7b
    • mitz@apple.com's avatar
      Reviewed by Darin Adler. · 815ef2f2
      mitz@apple.com authored
              - avoid counting spaces in non-justified text
      
              * rendering/bidi.cpp:
              Removed file-static numSpaces.
              (WebCore::BidiState::addRun): Removed space counting.
              (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added space
              counting, conditional on the block having the text-align: justify
              property value.
              (WebCore::RenderBlock::bidiReorderLine): Removed initialization of
              numSpaces.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      815ef2f2
    • darin@apple.com's avatar
      Requested by Steve. · 190e4057
      darin@apple.com authored
              * platform/graphics/cg/ImageSourceCG.cpp:
              (WebCore::ImageSource::createFrameAtIndex): Put the string into a global
              variable (because CFSTR is inefficient on Windows).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      190e4057
    • darin@apple.com's avatar
      JavaScriptCore: · c06878b4
      darin@apple.com authored
              Reviewed by Adam.
      
              * JavaScriptCore.exp: Sort the contents of this file.
      
      WebCore:
      
              Reviewed by Adam.
      
              * WebCore.base.exp: Export blankURL, and sort the file.
      
      WebKit/mac:
      
              Reviewed by Adam.
      
              * WebView/WebArchiver.mm:
              (+[WebArchiver archiveSelectionInFrame:]): Use blankURL.
              * WebView/WebFrame.mm:
              (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Avoid the
              variable name URL to avoid clashing with the renamed KURL in the future. Also use
              blankURL.
              (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Ditto.
              (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Ditto.
              (-[WebFrame loadHTMLString:baseURL:]): Ditto.
              (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c06878b4
    • aroben@apple.com's avatar
      MSVC build fix · f3172872
      aroben@apple.com authored
              * kjs/testkjs.cpp:
              (functionQuit): Don't add a return statement after exit(0) for MSVC.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3172872
    • aroben@apple.com's avatar
      Move many dispatch methods to WebFrameLoaderClient · b6b1ea20
      aroben@apple.com authored
               Reviewed by Sam.
      
               * WebCoreSupport/WebFrameLoaderClient.cpp:
               (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
               (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
               (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
               (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
               (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
               (WebFrameLoaderClient::dispatchWillClose):
               (WebFrameLoaderClient::dispatchDidReceiveIcon):
               (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
               (WebFrameLoaderClient::dispatchDidReceiveTitle):
               (WebFrameLoaderClient::dispatchDidCommitLoad):
               (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
               (WebFrameLoaderClient::dispatchDidFinishLoad):
               (WebFrameLoaderClient::dispatchDidFirstLayout):
               (WebFrameLoaderClient::dispatchShow):
               * WebCoreSupport/WebFrameLoaderClient.h:
               * WebFrame.cpp:
               * WebFrame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6b1ea20
    • aroben@apple.com's avatar
      Move two more methods to WebFrameLoaderClient · 2497509c
      aroben@apple.com authored
               Reviewed by Sam.
      
               * WebCoreSupport/WebFrameLoaderClient.cpp:
               (WebFrameLoaderClient::hasFrameView):
               (WebFrame::forceLayout):
               * WebCoreSupport/WebFrameLoaderClient.h:
               * WebFrame.cpp:
               * WebFrame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2497509c
    • hausmann@webkit.org's avatar
      3de6b94a
    • mrowe@apple.com's avatar
      2008-02-25 Johnny Ding <johnnyding.webkit@gmail.com> · 8dbab3a4
      mrowe@apple.com authored
              Reviewed by Darin Adler.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=17444
      
              In HTMLTokenizer::write, the code checks 'pendingScripts.isEmpty()' to decide
              whether to save prependingSrc or not. However, in HTMLTokenizer::scriptHandler
              and HTMLTokenizer::scriptExecution, the code checks testBit:LoadingExtScript
              to decide whether to save prependingSrc or not. The later behavior is not right
              because, in scriptHandler and scriptExecution, even the pendingScripts queue is
              empty, the testBit:LoadingExtScript might be TRUE.
      
              Test: fast/tokenizer/nested-multiple-scripts.html
      
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::scriptHandler): check pendingScripts.isEmpty() instead of
              checking state.loadingExtScript().
              (WebCore::HTMLTokenizer::scriptExecution): check pendingScripts.isEmpty() instead of
              checking state.loadingExtScript().
      
      2008-02-25  Johnny Ding  <johnnyding.webkit@gmail.com>
      
              Reviewed by Darin Adler.
      
              - bug http://bugs.webkit.org/show_bug.cgi?id=17444
              Test for multiple nested scripts which are in a external script.
      
              * fast/tokenizer/nested-multiple-scripts-expected.txt: Added.
              * fast/tokenizer/nested-multiple-scripts.html: Added.
              * fast/tokenizer/resources/external-script-1.js: Added.
              * fast/tokenizer/resources/external-script-2.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8dbab3a4
    • darin@apple.com's avatar
      * Scripts/do-webcore-rename: Make some updates based on a trial run of · be2b2787
      darin@apple.com authored
              the renaming script.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be2b2787
    • darin@apple.com's avatar
      * Scripts/do-webcore-rename: More renaming plans. · 77a29c5a
      darin@apple.com authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77a29c5a
    • weinig@apple.com's avatar
      Reviewed by Mark Rowe. · 0e854124
      weinig@apple.com authored
              http://bugs.webkit.org/show_bug.cgi?id=17529
              Add support for reading from stdin from testkjs
      
              * kjs/testkjs.cpp:
              (GlobalObject::GlobalObject): Add readline function to global object.
              (functionReadline): Added. Reads characters from stdin until a '\n' or
              EOF is encountered. The input is returned as a String to the caller.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e854124
    • darin@apple.com's avatar
      * dom/Document.h: Removed stray duplicate declaration of · 5383def0
      darin@apple.com authored
              RegisteredEventListenerList.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5383def0
  2. 24 Feb, 2008 17 commits
    • darin@apple.com's avatar
      * dom/Range.cpp: · 1bcd66ce
      darin@apple.com authored
              (WebCore::Range::surroundContents): Removed incorrect comment.
              I added it a while ago, and I was just mixed up.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bcd66ce
    • darin@apple.com's avatar
      - quick follow-up to that last check-in · b4f2d43f
      darin@apple.com authored
              * platform/graphics/cg/ImageSourceCG.cpp:
              (WebCore::ImageSource::createFrameAtIndex): Use CFEqual instead of
              WebCore::String's == for speed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4f2d43f
    • darin@apple.com's avatar
      WebCore: · 6d8ef453
      darin@apple.com authored
              Reviewed by Darin.
      
              Bug 8749: XBM rendered incorrectly as black on white
      
              xbm images are now created and rendered using black on a
              transparent background (same behavior as in Firefox)
      
              Test: platform/mac/fast/canvas/canvas-draw-xbm-image.html
      
              * platform/graphics/cg/ImageSourceCG.cpp:
              (WebCore::ImageSource::createFrameAtIndex):
      
      LayoutTests:
      
              Reviewed by Darin.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=8749
              
              * platform/mac/fast/canvas/canvas-draw-xbm-image-expected.checksum: Added.
              * platform/mac/fast/canvas/canvas-draw-xbm-image-expected.png: Added.
              * platform/mac/fast/canvas/canvas-draw-xbm-image-expected.txt: Added.
              * platform/mac/fast/canvas/canvas-draw-xbm-image.html: Added.
              * platform/mac/fast/canvas/resources: Added.
              * platform/mac/fast/canvas/resources/smile.xbm: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d8ef453
    • weinig@apple.com's avatar
      Reviewed by Mark Rowe. · 95ec0004
      weinig@apple.com authored
              http://bugs.webkit.org/show_bug.cgi?id=17528
              Give testkjs a bath
      
              * JavaScriptCore.exp:
              * JavaScriptCore.xcodeproj/project.pbxproj: Make the testkjs.cpp use 4 space indentation.
              * kjs/testkjs.cpp:
              (StopWatch::getElapsedMS):
              (GlobalObject::className):
              (GlobalObject::GlobalObject):
              Rename GlobalImp to GlobalObject and setup the global functions
              in the GlobalObject's constructor. Also, use static functions for
              the implementation so we can use the standard PrototypeFunction
              class and remove TestFunctionImp.
              (functionPrint): Move print() functionality here.
              (functionDebug): Move debug() functionality here.
              (functionGC): Move gc() functionality here.
              (functionVersion): Move version() functionality here.
              (functionRun): Move run() functionality here.
              (functionLoad): Move load() functionality here.
              (functionQuit): Move quit() functionality here.
              (prettyPrintScript): Fix indentation.
              (runWithScripts): Since all the functionality of createGlobalObject is
              now in the GlobalObject constructor, just call new here.
              (parseArguments): Fix indentation.
              (kjsmain): Ditto
              (fillBufferWithContentsOfFile): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95ec0004
    • mitz@apple.com's avatar
      WebCore: · b831f30f
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=17471
                REGRESSION (r30438): Crash in deleteLineBoxes in cursor-adjusting code browsing Acid3
      
              Test: http/tests/misc/object-image-error.html
      
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::attach): Added an early return in case
              updateFromElement() has changed the object to use fallback content.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=17471
                REGRESSION (r30438): Crash in deleteLineBoxes in cursor-adjusting code browsing Acid3
      
              * http/tests/misc/object-image-error-expected.txt: Added.
              * http/tests/misc/object-image-error.html: Added.
              * http/tests/misc/resources/404image.php: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b831f30f
    • weinig@apple.com's avatar
      Reviewed by Oliver Hunt and Mark Rowe. · 86f155c3
      weinig@apple.com authored
              http://bugs.webkit.org/show_bug.cgi?id=17505
              Add support for getting command line arguments in testkjs
      
              - This slightly changes the behavior of parsing arguments by requiring
                a '-f' before all files. 
      
              * kjs/testkjs.cpp:
              (createGlobalObject): Add a global property called 'arguments' which
              contains an array with the parsed arguments as strings.
              (runWithScripts): Pass in the arguments vector so that it can be passed
              to the global object.
              (parseArguments): Change parsing rules to require a '-f' before any script
              file. After all '-f' and '-p' arguments have been parsed, the remaining
              are added to the arguments vector and exposed to the script. If there is a
              chance of ambiguity (the user wants to pass the string '-f' to the script),
              the string '--' can be used separate the options from the pass through 
              arguments.
              (kjsmain):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86f155c3
    • mitz@apple.com's avatar
      Rubber-stamped by Oliver Hunt. · 37233468
      mitz@apple.com authored
              - replace expected results in platform/mac-tiger and
                platform/mac-leopard which were identical with a single copy in
                platform/mac
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37233468
    • mitz@apple.com's avatar
      WebCore: · 25beac6d
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix float positioning when a float that does not fit on the line is
                followed by a float that does
      
              Test: fast/block/float/narrow-after-wide.html
      
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::findNextLineBreak): Changed to not position any
              more floats on the line once a float that does not fit is encountered.
              That float should be pushed to the next line, and so should all floats
              that follow, regardless of whether they can fit on the current line.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test float positioning when a float that does not fit on the line is
                followed by a float that does
      
              * fast/block/float/narrow-after-wide.html: Added.
              * platform/mac/fast/block/float/narrow-after-wide-expected.checksum: Added.
              * platform/mac/fast/block/float/narrow-after-wide-expected.png: Added.
              * platform/mac/fast/block/float/narrow-after-wide-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25beac6d
    • mitz@apple.com's avatar
      Reviewed by Darin Adler. · 00aa164f
      mitz@apple.com authored
              - fix http://bugs.webkit.org/show_bug.cgi?id=17511
                REGRESSION: Reproducible crash in SegmentedSubstring::SegmentedSubstring(SegmentedSubstring const&)
      
              * wtf/Deque.h:
              (WTF::::expandCapacityIfNeeded): Fixed the case where m_start and m_end
              are both zero but the buffer capacity is non-zero.
              (WTF::::prepend): Added validity checks.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00aa164f
    • darin@apple.com's avatar
      WebCore: · c9bc8d37
      darin@apple.com authored
              Reviewed by Sam.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=16770
                Acid3 expects :visited styled links to restyle on iframe load
      
              Disentangle global history updating from the back/forward history.
              There are many cases where we don't want to create a new back/forward
              item, but we do still want to add to the global history (used for visited
              link coloring) in those cases.
      
              Test: fast/history/subframe-is-visited.html
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::updateGlobalHistory): Renamed from
              addHistoryForCurrentLocation and removed the back/forward handling.
              (WebCore::FrameLoader::updateHistoryForStandardLoad): Streamlined logic a
              bit. Replaced call to addHistoryForCurrentLocation with a call to
              addBackForwardItemClippedAtTarget. Added an unconditional call to
              updateGlobalHistory.
              (WebCore::FrameLoader::updateHistoryForClientRedirect): Added a FIXME;
              why doesn't this function update global history?
              (WebCore::FrameLoader::updateHistoryForBackForwardNavigation): Ditto.
              (WebCore::FrameLoader::updateHistoryForReload): Replaced the direct call
              the client with a call to the new updateGlobalHistory function.
              (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory): Did
              the same changes as for updateHistoryForStandardLoad.
              * loader/FrameLoader.h: More of the same.
      
              * loader/FrameLoaderClient.h: Removed updateGlobalHistoryForReload and
              renamed updateGlobalHistoryForStandardLoad to updateGlobalHistory.
      
              * svg/graphics/SVGImageEmptyClients.h:
              (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistory): Updated to
              match the above.
      
      WebKit/gtk:
      
              Reviewed by Sam.
      
              - remove separate client calls for "standard" and "reload' history
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::updateGlobalHistory):
              * WebCoreSupport/FrameLoaderClientGtk.h:
      
      WebKit/mac:
      
              Reviewed by Sam.
      
              - remove separate client calls for "standard" and "reload' history
      
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::updateGlobalHistory):
      
      WebKit/qt:
      
              Reviewed by Sam.
      
              - remove separate client calls for "standard" and "reload' history
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::updateGlobalHistory):
              * WebCoreSupport/FrameLoaderClientQt.h:
      
      WebKit/win:
      
              Reviewed by Sam.
      
              - remove separate client calls for "standard" and "reload' history
      
              * WebFrame.cpp:
              (WebFrame::updateGlobalHistory):
              * WebFrame.h:
      
      WebKit/wx:
      
              Reviewed by Sam.
      
              - remove separate client calls for "standard" and "reload' history
      
              * WebKitSupport/FrameLoaderClientWx.cpp:
              (WebCore::FrameLoaderClientWx::updateGlobalHistory):
              * WebKitSupport/FrameLoaderClientWx.h:
      
      LayoutTests:
      
              Reviewed by Sam.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=16770
                Acid3 expects :visited styled links to restyle on iframe load
      
              * fast/history/resources/subframe.html: Added.
              * fast/history/subframe-is-visited-expected.txt: Added.
              * fast/history/subframe-is-visited.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9bc8d37
    • darin@apple.com's avatar
      - another try at fixing the build · ec993bc0
      darin@apple.com authored
              * Api/qwebframe.cpp:
              (QWebFrame::load): Replace new FormData with FormData::create.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec993bc0
    • darin@apple.com's avatar
      Reviewed by Sam. · a8f68911
      darin@apple.com authored
              - fix http://bugs.webkit.org/show_bug.cgi?id=17508
                REGRESSION (r30535): mailto regression tests failing
      
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::submit): Restore the old logic, with its unpleasant
              trip through String do to the replace operation. It's inefficient, but there's
              no real reason to worry about the efficiency of mailto forms, since that feature
              is nearly obsolete.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8f68911
    • darin@apple.com's avatar
      Reviewed by Sam. · 79259dad
      darin@apple.com authored
              - replace SegmentedString's use of DeprecatedValueList with Deque
      
              Testing indicates this is a slight speed-up for page loading.
      
              * platform/text/SegmentedString.cpp:
              (WebCore::SegmentedString::length): Update to use Deque.
              (WebCore::SegmentedString::setExcludeLineNumbers): Ditto.
              (WebCore::SegmentedString::append): Ditto.
              (WebCore::SegmentedString::prepend): Ditto.
              (WebCore::SegmentedString::advanceSubstring): Ditto.
              (WebCore::SegmentedString::toString): Ditto.
              * platform/text/SegmentedString.h: Tweak formatting. Don't bother making an entire
              class private with a single friend. Change m_sbstrings from a DeprecatedValueList
              to a Deque.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79259dad
    • darin@apple.com's avatar
      Reviewed by Anders. · bc185eb5
      darin@apple.com authored
              - fix http://bugs.webkit.org/show_bug.cgi?id=17506
                REGRESSION (r30535): ASSERTION FAILED: i < size()
      
              * loader/TextResourceDecoder.cpp:
              (WebCore::findTextEncoding): Fix off-by-one in code that null-terminates
              the C string here.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc185eb5
    • pewtermoose@webkit.org's avatar
      Not reviewed, build fix. · 939f8488
      pewtermoose@webkit.org authored
              * platform/network/cf/FormDataStreamCFNet.cpp:
              (WebCore::httpBodyFromRequest):
              * plugins/win/PluginViewWin.cpp:
              (WebCore::PluginView::handlePost):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      939f8488
    • mitz@apple.com's avatar
      - fix a typo · cf11bfbe
      mitz@apple.com authored
              * platform/graphics/win/GlyphPageTreeNodeCGWin.cpp:
              (WebCore::GlyphPage::fill):
              * platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp:
              (WebCore::GlyphPage::fill):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf11bfbe
    • pewtermoose@webkit.org's avatar
      2008-02-23 Jan Michael Alonzo <jmalonzo@unpluggable.com> · 7a953d97
      pewtermoose@webkit.org authored
      .:
      
              Rubber stamped by Darin.
      
              Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
              whitespaces introduced in the previous commit.
      
              * GNUmakefile.am: 
      
      JavaScriptCore:
      
              Rubber stamped by Darin.
      
              Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
              whitespaces introduced in the previous commit.
      
              * GNUmakefile.am: 
      
      WebKitTools:
      
              Rubber stamped by Darin.
      
              Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
              whitespaces introduced in the previous commit.
      
              * GNUmakefile.am:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a953d97
  3. 23 Feb, 2008 4 commits